anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8523] feat(desktop): open external links in system browser instead of webview #12776

New Issue
Open
opened 2026-02-16 18:17:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8523

State: open
Merged: No

Summary

Fixes #8361

This PR fixes the issue where clicking links in AI responses navigates inside the Tauri webview instead of opening in the system browser.

What makes this PR different from #8520 and #7360:

  • ✅ User toggle setting - Users can choose between external browser or in-app navigation
  • ✅ Command palette integration - Quick toggle via Mod+Shift+P
  • ✅ UI toggle button - Visible in sidebar footer (desktop only)
  • ✅ Persisted preference - Setting survives app restarts

Changes

  • Global click handler: Intercepts all <a> tag clicks with http:// or https:// URLs and opens them via shellOpen() in the system browser
  • User setting: Added links.openExternally to Layout context (persisted) so users can toggle between external browser and in-app navigation
  • Command palette: Added "Open links in browser/app" command for quick toggling
  • UI toggle: Added a toggle button in the sidebar footer (only visible on desktop)

Problem

In Tauri webview, target="_blank" on <a> tags does NOT automatically open links in the system browser. When users click links from:

  • Markdown rendered AI responses
  • Native <a> tags (like the feedback button)

...the webview navigates to that URL, and users get "stuck" with no obvious way to return.

Solution

Added a global click handler that:

  1. Intercepts clicks on <a> tags with external URLs
  2. Checks user preference (window.__OPENCODE__.openLinksExternally)
  3. If enabled (default: true), prevents default navigation and opens via shellOpen()

Testing

  1. Run bun dev in packages/opencode
  2. Open desktop app
  3. Ask the AI to respond with a link (e.g., "give me a link to github")
  4. Click the link → should open in system browser
  5. Toggle the setting in sidebar → links should now navigate in-app

Files Changed

File Change
packages/desktop/src/index.tsx Global click handler
packages/app/src/context/layout.tsx Persisted setting + sync to window.__OPENCODE__
packages/app/src/app.tsx Type definition for window.__OPENCODE__
packages/app/src/pages/layout.tsx Command palette + UI toggle button

Default Behavior

Opens links in external browser (most users expect this behavior)

Users who prefer in-app browsing can toggle the setting.

Note: This PR is aware of #8520 and #7360 which address the same core issue. This PR adds additional user-facing features (toggle setting, command palette, UI button) that those PRs don't include. Happy to collaborate or consolidate if needed!

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8523 **State:** open **Merged:** No --- ## Summary Fixes #8361 This PR fixes the issue where clicking links in AI responses navigates inside the Tauri webview instead of opening in the system browser. **What makes this PR different from #8520 and #7360:** - ✅ **User toggle setting** - Users can choose between external browser or in-app navigation - ✅ **Command palette integration** - Quick toggle via Mod+Shift+P - ✅ **UI toggle button** - Visible in sidebar footer (desktop only) - ✅ **Persisted preference** - Setting survives app restarts ## Changes - **Global click handler**: Intercepts all `<a>` tag clicks with `http://` or `https://` URLs and opens them via `shellOpen()` in the system browser - **User setting**: Added `links.openExternally` to Layout context (persisted) so users can toggle between external browser and in-app navigation - **Command palette**: Added "Open links in browser/app" command for quick toggling - **UI toggle**: Added a toggle button in the sidebar footer (only visible on desktop) ## Problem In Tauri webview, `target="_blank"` on `<a>` tags does NOT automatically open links in the system browser. When users click links from: - Markdown rendered AI responses - Native `<a>` tags (like the feedback button) ...the webview navigates to that URL, and users get "stuck" with no obvious way to return. ## Solution Added a global click handler that: 1. Intercepts clicks on `<a>` tags with external URLs 2. Checks user preference (`window.__OPENCODE__.openLinksExternally`) 3. If enabled (default: true), prevents default navigation and opens via `shellOpen()` ## Testing 1. Run `bun dev` in `packages/opencode` 2. Open desktop app 3. Ask the AI to respond with a link (e.g., "give me a link to github") 4. Click the link → should open in system browser 5. Toggle the setting in sidebar → links should now navigate in-app ## Files Changed | File | Change | |------|--------| | `packages/desktop/src/index.tsx` | Global click handler | | `packages/app/src/context/layout.tsx` | Persisted setting + sync to `window.__OPENCODE__` | | `packages/app/src/app.tsx` | Type definition for `window.__OPENCODE__` | | `packages/app/src/pages/layout.tsx` | Command palette + UI toggle button | ## Default Behavior **Opens links in external browser** (most users expect this behavior) Users who prefer in-app browsing can toggle the setting. --- > **Note:** This PR is aware of #8520 and #7360 which address the same core issue. This PR adds additional user-facing features (toggle setting, command palette, UI button) that those PRs don't include. Happy to collaborate or consolidate if needed!
yindo added the pull-request label 2026-02-16 18:17:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12776
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?