anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10874] fix(bash): detect external directories without realpath #13585

New Issue
Open
opened 2026-02-16 18:18:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10874

State: open
Merged: No

Fixes #10872

What does this PR do?

Removes the realpath external dependency from bash tool path detection by using internal resolution (path.resolve) with fs.realpath fallback, so external_directory prompts still happen when realpath is missing.

How did you verify your code works?

  • bun run --cwd packages/opencode typecheck
  • bun test test/tool/bash.test.ts -t "realpath is missing" (regression test)
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10874 **State:** open **Merged:** No --- Fixes #10872 ### What does this PR do? Removes the `realpath` external dependency from bash tool path detection by using internal resolution (`path.resolve`) with `fs.realpath` fallback, so `external_directory` prompts still happen when `realpath` is missing. ### How did you verify your code works? - `bun run --cwd packages/opencode typecheck` - `bun test test/tool/bash.test.ts -t "realpath is missing"` (regression test)
yindo added the pull-request label 2026-02-16 18:18:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?