anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #13109] fix(web): sync docs locale cookie on alias redirects #14511

New Issue
Closed
opened 2026-02-16 18:19:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/13109

State: closed
Merged: Yes

Closes #13108 #13078 #13057

What does this PR do?

This fixes docs locale reversion when users explicitly navigate via locale aliases (especially /docs/en) while an existing non-English oc_locale cookie is set.
I updated docs middleware to set oc_locale on alias redirects, and normalize root English to oc_locale=en.
I also synced locale changes to oc_locale in app language context so cookie/state stay aligned.
Why this works: docs routing reads oc_locale when deciding redirects from /docs. If cookie and user-selected locale drift, users can bounce back to a previous non-English locale. Keeping cookie synchronized removes that drift.
Note: production /docs/en returning 404 appears to be a front-door routing issue. This PR improves locale consistency once requests reach app/docs logic.

How did you verify your code works?

  • Reproduced and checked behavior locally with oc_locale set to non-English values (not only ko).
  • Verified /docs/ alias redirect behavior and cookie updates in local docs middleware flow.
  • Confirmed changed files are:
    • packages/web/src/middleware.ts
    • packages/app/src/context/language.tsx
  • Checked production headers for context:
    • /docs/en returns 404
    • /docs returns 200
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/13109 **State:** closed **Merged:** Yes --- Closes #13108 #13078 #13057 ### What does this PR do? This fixes docs locale reversion when users explicitly navigate via locale aliases (especially /docs/en) while an existing non-English oc_locale cookie is set. I updated docs middleware to set oc_locale on alias redirects, and normalize root English to oc_locale=en. I also synced locale changes to oc_locale in app language context so cookie/state stay aligned. Why this works: docs routing reads oc_locale when deciding redirects from /docs. If cookie and user-selected locale drift, users can bounce back to a previous non-English locale. Keeping cookie synchronized removes that drift. Note: production /docs/en returning 404 appears to be a front-door routing issue. This PR improves locale consistency once requests reach app/docs logic. ### How did you verify your code works? - Reproduced and checked behavior locally with oc_locale set to non-English values (not only ko). - Verified /docs/<locale> alias redirect behavior and cookie updates in local docs middleware flow. - Confirmed changed files are: - packages/web/src/middleware.ts - packages/app/src/context/language.tsx - Checked production headers for context: - /docs/en returns 404 - /docs returns 200
yindo added the pull-request label 2026-02-16 18:19:18 -05:00
yindo closed this issue 2026-02-16 18:19:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?