fix comments;

.github/workflows/build.yml

@@ -1,8 +1,6 @@
 name: CD Pipeline
-on:
-  push:
-    tags:
-      - '*'
+
+on: [push]
 
 jobs:
   build-nix:

Cargo.lock

@@ -1519,6 +1519,7 @@ dependencies = [
  "rlimit",
  "serde",
  "serde_derive",
+ "subprocess",
  "text_placeholder",
  "toml",
  "wait-timeout",
@@ -1632,6 +1633,16 @@ version = "0.11.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "7da8b5736845d9f2fcb837ea5d9e2628564b3b043a70948a3f0b778838c5fb4f"
 
+[[package]]
+name = "subprocess"
+version = "0.2.9"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "0c2e86926081dda636c546d8c5e641661049d7562a68f5488be4a1f7f66f6086"
+dependencies = [
+ "libc",
+ "winapi",
+]
+
 [[package]]
 name = "syn"
 version = "2.0.69"

Cargo.toml

@@ -37,6 +37,7 @@ cidr-utils = "0.6.1"
 itertools = "0.13.0"
 hickory-resolver = { version = "0.24.0", features = ["dns-over-rustls"] }
 anyhow = "1.0.40"
+subprocess = "0.2.6"
 text_placeholder = { version = "0.5", features = ["struct_context"] }
 once_cell = "1.20.2"
 

README.md

@@ -24,21 +24,6 @@ RustScan is in many repositories already. Install it with whatever tools you wis
 [![Packaging status](https://repology.org/badge/vertical-allrepos/rustscan.svg)](https://repology.org/project/rustscan/versions)
 
 RustScan only officially supports Cargo installations, if you want to use that please install Rust and then `cargo install rustscan`
-
-Example installations include:
-
-MacOS:
-
-```
-  brew install rustscan
-```
-
-Arch:
-
-```
-  yay rustscan
-```
-
 # ✨ Features
 
 - Scans all 65k ports in **3 seconds**.
@@ -141,7 +126,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
 <!-- markdownlint-disable -->
 <table>
   <tr>
-    <td align="center"><a href="https://skerritt.blog"><img src="https://avatars3.githubusercontent.com/u/10378052?v=4" width="100px;" alt=""/><br /><sub><b>Bee</b></sub></a><br /><a href="#infra-beeskerritt" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="https://github.com/RustScan/RustScan/commits?author=beeskerritt" title="Tests">⚠️</a> <a href="https://github.com/RustScan/RustScan/commits?author=beesan" title="Code">💻</a> <a href="#design-beeskerritt" title="Design">🎨</a></td>
+    <td align="center"><a href="https://skerritt.blog"><img src="https://avatars3.githubusercontent.com/u/10378052?v=4" width="100px;" alt=""/><br /><sub><b>Brandon</b></sub></a><br /><a href="#infra-brandonskerritt" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="https://github.com/RustScan/RustScan/commits?author=brandonskerritt" title="Tests">⚠️</a> <a href="https://github.com/RustScan/RustScan/commits?author=brandonskerritt" title="Code">💻</a> <a href="#design-brandonskerritt" title="Design">🎨</a></td>
     <td align="center"><a href="https://sakiir.ovh"><img src="https://avatars1.githubusercontent.com/u/9950578?v=4" width="100px;" alt=""/><br /><sub><b>SakiiR</b></sub></a><br /><a href="https://github.com/RustScan/RustScan/commits?author=SakiiR" title="Code">💻</a> <a href="https://github.com/RustScan/RustScan/issues?q=author%3ASakiiR" title="Bug reports">🐛</a></td>
     <td align="center"><a href="https://github.com/smackhack"><img src="https://avatars2.githubusercontent.com/u/48143394?v=4" width="100px;" alt=""/><br /><sub><b>smackhack</b></sub></a><br /><a href="#ideas-smackhack" title="Ideas, Planning, & Feedback">🤔</a> <a href="#example-smackhack" title="Examples">💡</a></td>
     <td align="center"><a href="http://bernardoamc.github.io/"><img src="https://avatars0.githubusercontent.com/u/428984?v=4" width="100px;" alt=""/><br /><sub><b>Bernardo Araujo</b></sub></a><br /><a href="https://github.com/RustScan/RustScan/commits?author=bernardoamc" title="Code">💻</a> <a href="https://github.com/RustScan/RustScan/issues?q=author%3Abernardoamc" title="Bug reports">🐛</a> <a href="#design-bernardoamc" title="Design">🎨</a></td>

justfile

@@ -1,6 +1,6 @@
 test:
     cargo nextest run
-    cargo clippy -- --deny warnings
+    cargo clippy 
     cargo fmt --check
     cargo doc --workspace --all-features --no-deps --document-private-items
 

src/scanner/mod.rs

@@ -223,7 +223,7 @@ impl Scanner {
         Ok(stream)
     }
 
-    /// Binds to a UDP socket so we can send and receive packets
+    /// Binds to a UDP socket so we can send and recieve packets
     /// # Example
     ///
     /// ```compile_fail

src/scripts/mod.rs

@@ -79,17 +79,15 @@ use crate::input::ScriptsRequired;
 use anyhow::{anyhow, Result};
 use log::debug;
 use serde_derive::{Deserialize, Serialize};
+use std::convert::TryInto;
 use std::fs::{self, File};
 use std::io::{self, prelude::*};
 use std::net::IpAddr;
 use std::path::PathBuf;
-use std::process::{Command, Stdio};
 use std::string::ToString;
+use subprocess::{Exec, ExitStatus};
 use text_placeholder::Template;
 
-#[cfg(unix)]
-use std::os::unix::process::ExitStatusExt;
-
 static DEFAULT: &str = r#"tags = ["core_approved", "RustScan", "default"]
 developer = [ "RustScan", "https://github.com/RustScan" ]
 ports_separator = ","
@@ -273,41 +271,19 @@ impl Script {
 #[cfg(not(tarpaulin_include))]
 fn execute_script(script: &str) -> Result<String> {
     debug!("\nScript arguments {}", script);
-
-    let (cmd, arg) = if cfg!(unix) {
-        ("sh", "-c")
-    } else {
-        ("cmd.exe", "/c")
-    };
-
-    match Command::new(cmd)
-        .args(&[arg, script])
-        .stdin(Stdio::piped())
-        .stderr(Stdio::piped())
-        .output()
-    {
-        Ok(output) => {
-            let status = output.status;
-
-            let es = match status.code() {
-                Some(code) => code,
-                _ => {
-                    #[cfg(unix)]
-                    {
-                        status.signal().unwrap()
-                    }
-
-                    #[cfg(windows)]
-                    {
-                        return Err(anyhow!("Unknown exit status"));
-                    }
-                }
+    let process = Exec::shell(script);
+    match process.capture() {
+        Ok(c) => {
+            let es = match c.exit_status {
+                ExitStatus::Exited(c) => c.try_into().unwrap(),
+                ExitStatus::Signaled(c) => c.into(),
+                ExitStatus::Other(c) => c,
+                ExitStatus::Undetermined => -1,
             };
-
             if es != 0 {
                 return Err(anyhow!("Exit code = {}", es));
             }
-            Ok(String::from_utf8_lossy(&output.stdout).into_owned())
+            Ok(c.stdout_str())
         }
         Err(error) => {
             debug!("Command error {}", error.to_string());