borgbackup/borg
1
0
Fork 0
mirror of https://github.com/borgbackup/borg.git synced 2026-10-12 02:11:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

webdav: address review comments

Browse Source 
- docs: say 50 MB instead of 47 MiB for the Windows download limit (same size,
  friendlier unit).
- docs: drop the note about Windows refusing Basic auth over plain HTTP - the
  server has no authentication, so it does not matter.
- docs: drop the two notes about large directories being slow - that is expected
  behaviour, not a WebDAV issue worth documenting.
- use a separate line per method for the "not allowed" HTTP method assignments.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
Thomas Waldmann
2026-07-26 15:48:31 +02:00
co-authored by Claude Opus 4.8
parent 916371ac43
commit 7bfd489b06
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/usage/webdav.rst
+2 -8
View File
@@ -22,16 +22,11 @@ these - the notes below matter mainly when *mounting* the server as a file syste
**Windows Explorer** (the "WebClient" / mini-redirector)
- Downloads are limited to about 47 MiB by default (the ``FileSizeLimitInBytes``
- Downloads are limited to about 50 MB by default (the ``FileSizeLimitInBytes``
registry value). Bigger files fail when copied from a mapped drive - use a web
browser (including for the ``?tar`` directory download) or another WebDAV client.
- The ``WebClient`` service must be running for ``net use`` / "Map network drive"
to work; if it is stopped, mounting silently fails.
- Windows refuses HTTP Basic authentication over plain HTTP by default (only over
HTTPS). This does not matter now (the server has no authentication), but it is a
wall for any future networked, authenticated setup.
- Explorer is chatty (a PROPFIND per navigation, many short connections), so
browsing large directories over a mount can feel slow.
**macOS Finder** (``mount_webdav`` / WebDAVFS)
@@ -48,8 +43,7 @@ these - the notes below matter mainly when *mounting* the server as a file syste
a read-only server rejects. Set ``use_locks 0`` in ``davfs2.conf`` (or the
per-mount config) to avoid the failed lock attempts. davfs2 also caches whole
files in a local cache directory.
- The GNOME (gvfs) and KDE (KIO) DAV backends work without such tweaks, but are
also PROPFIND-heavy on large directories.
- The GNOME (gvfs) and KDE (KIO) DAV backends work without such tweaks.
**Protocol-level (any client)**
src/borg/webdav.py
+10 -2
View File
@@ -585,8 +585,16 @@ class WebDAVHandler(BaseHTTPRequestHandler):
self.end_headers()
self.close_connection = True # we did not read a request body the client may have sent
do_POST = do_PUT = do_DELETE = do_PATCH = _method_not_allowed
do_PROPPATCH = do_MKCOL = do_COPY = do_MOVE = do_LOCK = do_UNLOCK = _method_not_allowed
do_POST = _method_not_allowed
do_PUT = _method_not_allowed
do_DELETE = _method_not_allowed
do_PATCH = _method_not_allowed
do_PROPPATCH = _method_not_allowed
do_MKCOL = _method_not_allowed
do_COPY = _method_not_allowed
do_MOVE = _method_not_allowed
do_LOCK = _method_not_allowed
do_UNLOCK = _method_not_allowed
def _guarded(self, method, *args):
try: