centerWindows() was unconditionally adding window.scrollX/Y, which
incorrectly offset window positions when using renderInto with a scrolled
page. Move scroll offset responsibility to callers so each can decide:
- contained (renderInto): no scroll offset needed
- non-contained (renderWhenReady): add scroll offset to viewport coords
- body fallback (centerWindowsInView): add scroll offset only for body
Also make parentDomNode required in browserWindowSizeChanged,
ensureWindowsAreOnScreen, and centerWindowsInView since the serialized
state code (the only caller without a parentDomNode) was removed.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The serialized state feature (LOAD_SERIALIZED_STATE action, SerializedStateV1
types, getSerializedState/getSerlializedState functions) was unused external
API surface. Removing it simplifies the codebase and eliminates the only
caller of ensureWindowsAreOnScreen() without a parentDomNode argument.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The RichText import from @atproto/api was unused after refactoring the
Bluesky posting logic to use manual facets instead of RichText helpers.
This caused the ESLint no-unused-vars rule to fail in CI.
Co-authored-by: Claude Sonnet 4.6 <[email protected]>
- Remove stale browserslist field (Babel was removed)
- Remove stale files exclusion for built/types/demo
- Fix rollup typescript plugin to not emit declarations (suppresses TS5069 warning)
- Clean up tsconfig.json: remove commented-out lines, replace jest types with vitest/globals, remove stale includes/excludes
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* Split demo site into its own package
Move the demo site from packages/webamp/demo/ into packages/webamp-demo/
as a standalone workspace package. This cleanly separates the library
(published to npm) from the demo site (deployed to webamp.org).
Key changes:
- Demo imports webamp source via relative paths (no aliases needed)
- Demo has its own package.json with demo-specific deps
- Simplified vite config (just nodePolyfills plugin)
- Removed vite branching from rollupPlugins.mjs (library-only now)
- Renamed build-library -> build in webamp package
- Updated turbo.json, CI, netlify config, and code-size workflow
- Removed demo-only deps from webamp package (sentry, butterchurn stays
for the butterchurn bundle)
- Zero bundle size change for the library
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* Fix: add type-check dependency to webamp#build task
The webamp-docs package needs type declarations from webamp to
type-check. These are generated by tsc (type-check), which must run
before the build task.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* Add updated readme to webamp-demo package
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* Document the live reloading dev flow in both readmes
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* Fix code-size CI: use deploy script that exists on both branches
The compressed-size-action checks out master and runs the build script.
Master doesn't have a root "build" script, so revert to using "deploy"
which exists on both branches.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
---------
Co-authored-by: Claude Opus 4.6 <[email protected]>
All dependencies are bundled into the library output at build time,
so consumers don't need any of them installed. This gives users a
zero-dependency install.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Use the standard window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ runtime
check instead of importing the package. DevTools still work if the
browser extension is installed.
Also inline the defaultMemoize usage from reselect to fix Vite dev
server compatibility.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Both now ship ESM. Updated imports to use named exports
(redux-thunk v3 dropped the default export).
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Remove style-loader, url-loader (Webpack-era), canvas-mock,
react-test-renderer, glob, http-server, and @types/lodash-es.
None were imported anywhere in the codebase.
Replace http-server serve script with vite preview.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Replace Jest with Vitest for unit tests
- Remove integration tests (not used in CI, relied on puppeteer)
- Remove .babelrc (no longer needed — was only used for Jest transform)
- Remove jest-puppeteer, jest-image-snapshot, and related deps
- Replace jest.fn() with vi.fn() in test files
- Add vitest.config.ts with jsdom environment
All 224 unit tests pass. The postcss plugin test remains skipped
as before.
Co-authored-by: Claude Opus 4.6 <[email protected]>
The rollup build already uses @rollup/plugin-typescript for type
stripping and JSX. Babel was running after it as a no-op for modern
targets. Now Babel is only used by Jest for ESM→CJS conversion.
Also removes @babel/preset-env since it's no longer needed.
Bundle size decreased by ~1.7KB.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The demo site still imports it, so it needs to remain as a dev
dependency for the Vite build. Consumers don't need it since it's
not used in the library bundle.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Not imported anywhere in the source. It was pulling in babel-runtime@6
and core-js@2 as transitive dependencies for consumers.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
These options told preset-env to inject core-js polyfills, but with
modern browser targets nothing was being polyfilled. Removes the
transitive core-js dependency.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The fscreen library was a vendor-prefix shim for the Fullscreen API.
All target browsers now support the unprefixed standard API natively.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
These plugins handled class properties, optional chaining, nullish
coalescing, object rest spread, and dynamic import syntax — all of
which are natively supported by our target browsers. Bundle size is
unchanged, confirming they were no-ops.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Same issue as ani-cursor: bundled at build time via rollup, so
consumers don't need it installed. The workspace:* protocol caused
install failures for users outside the workspace.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
It's bundled at build time via rollup, so consumers don't need it
at install time. Having it as a dependency with workspace:* caused
install failures for users since the workspace protocol isn't
resolved during npm publish.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The RichText import from @atproto/api was unused after refactoring the
Bluesky posting logic to use manual facets instead of RichText helpers.
This caused the ESLint no-unused-vars rule to fail in CI.
Co-authored-by: Claude Sonnet 4.6 <[email protected]>
Add non-null assertion operator to ref.current when calling webamp.renderInto()
to match the pattern used elsewhere in the component and resolve the CI type error:
"Argument of type 'HTMLDivElement | null' is not assignable to parameter of type 'HTMLElement'"
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Claude <[email protected]>
* Webamp optionally fully contained into a DOM element
* Fix spelling
* Reenable updating search index for uploads
* Replace contained flag on renderWhenReady with a new method. Add docs
---------
Co-authored-by: Jordan Eldredge <[email protected]>
