mirror of
https://github.com/codewhale-hq/Codewhale.git
synced 2026-11-13 18:17:39 -10:00
Compare commits
96
Commits
ci/mode-02
...
main
No files matched your search
@@ -48,7 +48,7 @@
|
||||
tags: cnb:arch:amd64
|
||||
cpus: 16
|
||||
docker:
|
||||
image: rust:1.88-bookworm
|
||||
image: rust:1.100.0-bookworm
|
||||
# codewhale-cnb-bridge GitHub App credentials from the CNB KeyStore
|
||||
# (codewhale.net/codewhale-ci-secrets, github-bridge.yml), injected as
|
||||
# environment variables. Values are never printed.
|
||||
@@ -112,7 +112,7 @@
|
||||
tags: cnb:arch:amd64
|
||||
cpus: 16
|
||||
docker:
|
||||
image: rust:1.88-bookworm
|
||||
image: rust:1.100.0-bookworm
|
||||
stages:
|
||||
- name: install release dependencies
|
||||
script: |
|
||||
@@ -163,7 +163,7 @@ main:
|
||||
$:
|
||||
tag_push:
|
||||
- docker:
|
||||
image: rust:1.88-bookworm
|
||||
image: rust:1.100.0-bookworm
|
||||
stages:
|
||||
- name: build linux x64 release assets (static)
|
||||
# The static full-LTO link can also outlive CNB's default no-output
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
ARG RUST_VERSION=1.88
|
||||
ARG RUST_VERSION=1.100.0
|
||||
FROM rust:${RUST_VERSION}-slim-bookworm
|
||||
|
||||
# Native DBus headers and pkg-config are required by libdbus-sys during
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
"context": "..",
|
||||
"dockerfile": "Dockerfile",
|
||||
"args": {
|
||||
"RUST_VERSION": "1.88"
|
||||
"RUST_VERSION": "1.100.0"
|
||||
}
|
||||
},
|
||||
"customizations": {
|
||||
|
||||
@@ -75,6 +75,7 @@ security boundaries and adds bridge-specific controls.
|
||||
- **Token gate**: All runtime API calls carry `CODEWHALE_RUNTIME_TOKEN`
|
||||
- **Chat allowlist**: Only chats/users listed in `WECOM_CHAT_ALLOWLIST` can interact. First-pairing mode (`WECOM_ALLOW_UNLISTED=true`) is meant for onboarding only
|
||||
- **Approval required**: Tool calls from WeCom sessions must be approved — either via explicit `/allow <id>` commands or natural-language keywords (`允许`, `yes`, `ok`, etc.)
|
||||
- **Thread ownership**: `/threads` and `/resume` cover only the threads the chat itself created; any other thread ID is refused with one fixed reply
|
||||
- **No workspace exposure**: Only prompts, status summaries, and approval requests are sent to WeCom. Workspace contents, shell output, and runtime internals stay on the local machine
|
||||
|
||||
### Reporting WeCom Bridge vulnerabilities
|
||||
|
||||
@@ -248,7 +248,7 @@ assert.match(nightly, /startsWith\(matrix\.target, 'aarch64-'\).*runner\.arch ==
|
||||
const nightlyArmMuslSetup = namedStep(nightly, "Install Linux ARM64 musl toolchain");
|
||||
assert.match(nightlyArmMuslSetup, /matrix\.target == 'aarch64-unknown-linux-musl'/);
|
||||
assert.match(nightlyArmMuslSetup, /apt-get install -y binutils musl-tools/);
|
||||
assert.match(nightlyArmMuslSetup, /rustup target add --toolchain stable aarch64-unknown-linux-musl/);
|
||||
assert.match(nightlyArmMuslSetup, /rustup target add aarch64-unknown-linux-musl/);
|
||||
const nightlyArmStaticSmoke = namedStep(
|
||||
nightly,
|
||||
"Verify static Linux ARM64 binary and launch",
|
||||
@@ -373,7 +373,7 @@ assert.deepEqual([...new Set(valuesForKey(artifacts, "target"))].sort(), expecte
|
||||
const releaseMuslBuild = namedStep(artifacts, "Build static Linux binaries (musl)");
|
||||
assert.match(releaseMuslBuild, /endsWith\(matrix\.target, '-unknown-linux-musl'\)/);
|
||||
assert.match(releaseMuslBuild, /apt-get install -y binutils musl-tools/);
|
||||
assert.match(releaseMuslBuild, /rustup target add --toolchain stable \$\{\{ matrix\.target \}\}/);
|
||||
assert.match(releaseMuslBuild, /rustup target add \$\{\{ matrix\.target \}\}/);
|
||||
assert.match(
|
||||
releaseMuslBuild,
|
||||
/cargo build --profile dist --locked --target \$\{\{ matrix\.target \}\} -p codewhale-cli/,
|
||||
@@ -810,6 +810,20 @@ assert.doesNotMatch(
|
||||
// A job that calls a reusable workflow (`uses:`) cannot carry the key at all —
|
||||
// GitHub rejects it — so the callee owns its own caps. That is why the artifact
|
||||
// bounds live in release-artifacts.yml rather than in its callers.
|
||||
function timeoutMinutes(value) {
|
||||
const literal = /^\d+$/.test(value);
|
||||
const conditional = value.match(
|
||||
/^\$\{\{\s*startsWith\(matrix\.os,\s*'macos-'\)\s*&&\s*(\d+)\s*\|\|\s*(\d+)\s*\}\}$/,
|
||||
);
|
||||
if (!literal && !conditional) return null;
|
||||
const macos = Number(literal ? value : conditional[1]);
|
||||
const other = Number(literal ? value : conditional[2]);
|
||||
if (![macos, other].every((cap) => Number.isInteger(cap) && cap > 0 && cap <= 360)) {
|
||||
return null;
|
||||
}
|
||||
return { macos, other };
|
||||
}
|
||||
|
||||
function jobsWithoutTimeout(source) {
|
||||
const lines = source.split("\n");
|
||||
const jobsAt = lines.findIndex((line) => /^jobs:\s*$/.test(line));
|
||||
@@ -823,7 +837,8 @@ function jobsWithoutTimeout(source) {
|
||||
for (let j = i + 1; j < lines.length; j += 1) {
|
||||
if (/^ [A-Za-z0-9_-]+:\s*$/.test(lines[j])) break;
|
||||
if (/^ uses:/.test(lines[j])) reusable = true;
|
||||
if (/^ timeout-minutes:\s*\d+\s*$/.test(lines[j])) capped = true;
|
||||
const timeout = lines[j].match(/^ timeout-minutes:\s*(.+?)\s*$/);
|
||||
if (timeout && timeoutMinutes(timeout[1])) capped = true;
|
||||
}
|
||||
if (!reusable && !capped) offenders.push(header[1]);
|
||||
}
|
||||
@@ -862,26 +877,41 @@ for (const [name, source] of [
|
||||
);
|
||||
}
|
||||
|
||||
// The Windows artifact build historically runs 40-45 minutes, so its cap has to
|
||||
// keep real margin — a tight bound here fails healthy releases.
|
||||
const buildTimeout = artifacts.match(/^ build:\n(?:.*\n)*? timeout-minutes: (\d+)$/m);
|
||||
assert.ok(buildTimeout, "release-artifacts build job must be capped");
|
||||
assert.ok(
|
||||
Number(buildTimeout[1]) >= 60,
|
||||
`artifact build cap ${buildTimeout[1]}m leaves no margin over a healthy 40-45m Windows build`,
|
||||
);
|
||||
|
||||
function jobTimeout(source, job) {
|
||||
function jobTimeout(source, job, platform = "other") {
|
||||
const match = source.match(
|
||||
new RegExp(`^ ${job}:\\n(?:.*\\n)*? timeout-minutes: (\\d+)$`, "m"),
|
||||
new RegExp(`^ ${job}:\\n(?:.*\\n)*? timeout-minutes: (.+)$`, "m"),
|
||||
);
|
||||
assert.ok(match, `${job} must declare timeout-minutes`);
|
||||
return Number(match[1]);
|
||||
const caps = timeoutMinutes(match[1].trim());
|
||||
assert.ok(caps, `${job} must declare a bounded timeout`);
|
||||
return caps[platform];
|
||||
}
|
||||
|
||||
// Fast setup and packaging fail quickly. Native builds need the same finite
|
||||
// cold-build allowance as full CI: both 0.10.1 macOS artifacts hit the old
|
||||
// 90m compilation cap before reaching their launch and inventory checks.
|
||||
const macosTimeout = "${{ startsWith(matrix.os, 'macos-') && 360 || 210 }}";
|
||||
assert.deepEqual(timeoutMinutes(macosTimeout), { macos: 360, other: 210 });
|
||||
for (const invalid of [
|
||||
"0", "361", "Infinity", "${{ matrix.timeout }}",
|
||||
"${{ startsWith(matrix.os, 'macos-') && 361 || 210 }}",
|
||||
"${{ startsWith(matrix.os, 'macos-') && 360 || 0 }}",
|
||||
]) {
|
||||
assert.equal(timeoutMinutes(invalid), null, `${invalid} must not count as a bounded cap`);
|
||||
}
|
||||
assert.deepEqual(
|
||||
jobsWithoutTimeout(`jobs:\n capped:\n timeout-minutes: ${macosTimeout}\n`),
|
||||
[],
|
||||
);
|
||||
assert.equal(jobTimeout(artifacts, "build", "macos"), 360);
|
||||
assert.equal(jobTimeout(artifacts, "build"), 210);
|
||||
const artifactCacheSetup = artifacts.match(
|
||||
/ - uses: mozilla-actions\/sccache-action@[^\n]+\n(?:(?! - ).*\n)*/,
|
||||
);
|
||||
assert.ok(artifactCacheSetup, "artifact compiler cache setup must be explicit");
|
||||
assert.match(artifactCacheSetup[0], /^ if: runner\.os == 'Linux'$/m);
|
||||
assert.match(
|
||||
namedStep(artifacts, "Enable sccache"),
|
||||
/^ if: steps\.sccache\.outcome == 'success' && runner\.os == 'Linux'$/m,
|
||||
);
|
||||
|
||||
assert.equal(jobTimeout(candidate, "resolve"), 10);
|
||||
assert.equal(jobTimeout(candidate, "web"), 15);
|
||||
assert.equal(jobTimeout(artifacts, "pin"), 10);
|
||||
@@ -894,7 +924,7 @@ for (const job of ["bundle", "windows-installer", "assemble", "smoke"]) {
|
||||
}
|
||||
assert.equal(
|
||||
jobTimeout(nightly, "build"), jobTimeout(artifacts, "build"),
|
||||
"nightly and release must share the native cold-build allowance",
|
||||
"nightly and non-macOS release builds must share the cold-build allowance",
|
||||
);
|
||||
assert.equal(jobTimeout(release, "resolve"), 10);
|
||||
// The 0.10.1 cold parity build exhausted 45 minutes before tests started.
|
||||
@@ -904,6 +934,76 @@ assert.ok(
|
||||
"release parity must allow the full CI suite's cold-build budget",
|
||||
);
|
||||
|
||||
const pinnedToolchain = read("rust-toolchain.toml").match(/^channel\s*=\s*"([^"]+)"/m)[1];
|
||||
assert.match(pinnedToolchain, /^\d+\.\d+\.\d+$/, "rust-toolchain.toml must pin an exact Rust release");
|
||||
const msrv = read("Cargo.toml").match(/^rust-version\s*=\s*"([^"]+)"/m)[1];
|
||||
assert.match(msrv, /^\d+\.\d+$/, "Cargo.toml must declare a minor MSRV");
|
||||
const escapeRegExp = (value) => value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
|
||||
const stripWorkflowComments = (source) =>
|
||||
source
|
||||
.split("\n")
|
||||
.map((line) => line.replace(/(^|\s)#.*$/, ""))
|
||||
.join("\n");
|
||||
const workflowDir = path.join(repoRoot, ".github", "workflows");
|
||||
const workflowSources = new Map();
|
||||
for (const file of fs.readdirSync(workflowDir).filter((name) => /\.ya?ml$/.test(name)).sort()) {
|
||||
workflowSources.set(file, stripWorkflowComments(read(`.github/workflows/${file}`)));
|
||||
}
|
||||
const ciSource = workflowSources.get("ci.yml");
|
||||
const msrvHeader = /^ msrv:[ \t]*$/m.exec(ciSource);
|
||||
assert.ok(msrvHeader, "ci.yml must keep an MSRV job");
|
||||
const msrvStart = msrvHeader.index;
|
||||
const afterMsrvHeader = msrvStart + msrvHeader[0].length;
|
||||
const nextJob = /^ \S/m.exec(ciSource.slice(afterMsrvHeader));
|
||||
const msrvEnd = nextJob ? afterMsrvHeader + nextJob.index : ciSource.length;
|
||||
const selectorValue = (value) => value.trim().replace(/^(["'])(.*)\1$/, "$2");
|
||||
const inMsrvJob = (index) => index >= msrvStart && index < msrvEnd;
|
||||
for (const [file, source] of workflowSources) {
|
||||
const selectors = [
|
||||
...[...source.matchAll(/dtolnay\/rust-toolchain@([^\s]+)/g)].map((m) => ["action ref", m[1], m.index]),
|
||||
...[...source.matchAll(/^[ \t]+toolchain:[ \t]*([^\r\n]*)$/gm)].map((m) => ["toolchain input", selectorValue(m[1]), m.index]),
|
||||
...[...source.matchAll(/^[ \t]+rust-version:[ \t]*([^\r\n]*)$/gm)].map((m) => ["rust-version input", selectorValue(m[1]), m.index]),
|
||||
...[...source.matchAll(/^[ \t]+RUSTUP_TOOLCHAIN:[ \t]*([^\r\n]*)$/gm)].map((m) => ["RUSTUP_TOOLCHAIN", selectorValue(m[1]), m.index]),
|
||||
...[...source.matchAll(/\bcargo\s+\+\s*["']?([^\s"']+)/g)].map((m) => ["cargo + selector", m[1], m.index]),
|
||||
];
|
||||
for (const [kind, value, index] of selectors) {
|
||||
if (kind === "action ref" && (/^[0-9a-f]{40}$/.test(value) || value === "master")) continue;
|
||||
const expected = file === "ci.yml" && inMsrvJob(index) ? msrv : pinnedToolchain;
|
||||
assert.equal(value, expected, `${file}: ${kind} ${value} must equal ${expected}`);
|
||||
}
|
||||
assert.doesNotMatch(source, /rustup (?:target|component) add --toolchain/, `${file}: rustup adds must follow rust-toolchain.toml`);
|
||||
}
|
||||
const msrvJob = ciSource.slice(msrvStart, msrvEnd);
|
||||
assert.match(msrvJob, new RegExp(`RUSTUP_TOOLCHAIN: "${escapeRegExp(msrv)}"`), "the MSRV job must override rust-toolchain.toml for every step");
|
||||
assert.match(msrvJob, new RegExp(`toolchain: "?${escapeRegExp(msrv)}"?`));
|
||||
assert.match(msrvJob, new RegExp(`cargo \\+${escapeRegExp(msrv)} check --workspace --locked`));
|
||||
assert.doesNotMatch(msrvJob, new RegExp(`\\b${escapeRegExp(pinnedToolchain)}\\b`), "the MSRV job must not select the pinned release toolchain");
|
||||
|
||||
const rootDockerfile = read("Dockerfile");
|
||||
const devcontainerDockerfile = read(".devcontainer/Dockerfile");
|
||||
const devcontainerConfig = read(".devcontainer/devcontainer.json");
|
||||
const tencentCnb = read("deploy/tencent-lighthouse/cnb/cnb.yml.example");
|
||||
const pinnedTag = `${pinnedToolchain}-bookworm`;
|
||||
for (const [label, source] of [
|
||||
["Dockerfile", rootDockerfile],
|
||||
[".devcontainer/Dockerfile", devcontainerDockerfile],
|
||||
]) {
|
||||
assert.match(source, new RegExp(`^ARG RUST_VERSION=${escapeRegExp(pinnedToolchain)}$`, "m"), `${label} must default RUST_VERSION to the pinned toolchain`);
|
||||
assert.match(source, /^FROM .*\brust:\$\{RUST_VERSION\}/m, `${label} must build from the RUST_VERSION image`);
|
||||
}
|
||||
assert.match(devcontainerConfig, new RegExp(`"RUST_VERSION":\\s*"${escapeRegExp(pinnedToolchain)}"`), ".devcontainer/devcontainer.json must pass the pinned RUST_VERSION build arg");
|
||||
for (const [label, source] of [
|
||||
[".cnb.yml", cnb],
|
||||
["deploy/tencent-lighthouse/cnb/cnb.yml.example", tencentCnb],
|
||||
]) {
|
||||
const tags = [...stripWorkflowComments(source).matchAll(/^[ \t]*image:[ \t]*([^\r\n]*)$/gm)]
|
||||
.map((m) => selectorValue(m[1]))
|
||||
.filter((value) => value.startsWith("rust:"))
|
||||
.map((value) => value.slice("rust:".length));
|
||||
assert.ok(tags.length > 0, `${label} must declare a Rust build image`);
|
||||
assert.deepEqual([...new Set(tags)], [pinnedTag], `${label}: Rust build images must match rust-toolchain.toml`);
|
||||
}
|
||||
|
||||
console.log(
|
||||
"Workflow contracts OK: 6-target/12-asset single-runtime nightly and exact-head 8-target/38-asset release candidate.",
|
||||
);
|
||||
@@ -23,17 +23,17 @@ jobs:
|
||||
continue-on-error: ${{ matrix.checks == 'advisories' }}
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
# rust-toolchain.toml pins `channel = "stable"` with no target, so
|
||||
# rust-toolchain.toml pins `channel = "1.100.0"` with no target, so
|
||||
# inside the action's alpine (musl) container rustup resolves it to
|
||||
# `stable-x86_64-unknown-linux-musl` — which the container does not
|
||||
# `1.100.0-x86_64-unknown-linux-musl`, which the container does not
|
||||
# have. Without provisioning, the action's `rustup show` step prints
|
||||
# "error: override toolchain 'stable-x86_64-unknown-linux-musl' is not
|
||||
# "error: override toolchain '1.100.0-x86_64-unknown-linux-musl' is not
|
||||
# installed" and then auto-installs mid-run (network-dependent ~12s
|
||||
# detour, hard failure if the download stalls). `rust-version` makes the
|
||||
# entrypoint run `rustup default stable` (same musl host triple) before
|
||||
# entrypoint run `rustup default 1.100.0` (same musl host triple) before
|
||||
# cargo-deny touches the workspace, so the toolchain file resolves to an
|
||||
# already-installed toolchain on every run.
|
||||
- uses: EmbarkStudios/cargo-deny-action@v2
|
||||
with:
|
||||
command: check ${{ matrix.checks }}
|
||||
rust-version: stable
|
||||
rust-version: 1.100.0
|
||||
+14
-12
@@ -203,7 +203,7 @@ jobs:
|
||||
- uses: actions/checkout@v7
|
||||
with:
|
||||
fetch-depth: 0
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- uses: actions/[email protected]
|
||||
with:
|
||||
node-version: 22
|
||||
@@ -428,7 +428,7 @@ jobs:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@master
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
- uses: mozilla-actions/[email protected]
|
||||
id: sccache
|
||||
# The GitHub Actions cache backend is main-only, mirroring
|
||||
@@ -487,7 +487,7 @@ jobs:
|
||||
- uses: dtolnay/rust-toolchain@master
|
||||
if: needs.changes.outputs.heavy == 'true'
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
components: rustfmt, clippy
|
||||
- uses: mozilla-actions/[email protected]
|
||||
id: sccache
|
||||
@@ -728,6 +728,8 @@ jobs:
|
||||
if: github.event_name == 'workflow_dispatch' && needs.changes.outputs.heavy == 'true'
|
||||
timeout-minutes: 45
|
||||
runs-on: ubuntu-latest
|
||||
env:
|
||||
RUSTUP_TOOLCHAIN: "1.89"
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@master
|
||||
@@ -751,7 +753,7 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- uses: mozilla-actions/[email protected]
|
||||
id: sccache
|
||||
# Main-only GitHub Actions cache backend; see the Safety gate job.
|
||||
@@ -825,11 +827,11 @@ jobs:
|
||||
if: needs.changes.outputs.heavy == 'true' && matrix.os == 'windows-latest'
|
||||
shell: pwsh
|
||||
run: ./scripts/installer/installer-path-regression.tests.ps1 -AllowUserPathMutation
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
if: needs.changes.outputs.heavy == 'true' && (matrix.os != 'ubuntu-latest' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request')
|
||||
- name: Install macOS LLVM tools
|
||||
if: needs.changes.outputs.heavy == 'true' && matrix.os == 'macos-latest'
|
||||
run: rustup component add llvm-tools --toolchain stable
|
||||
run: rustup component add llvm-tools
|
||||
- name: Omit macOS build debug metadata
|
||||
if: needs.changes.outputs.heavy == 'true' && matrix.os == 'macos-latest'
|
||||
shell: bash
|
||||
@@ -1222,7 +1224,7 @@ jobs:
|
||||
if: needs.changes.outputs.heavy == 'true'
|
||||
shell: pwsh
|
||||
run: ./scripts/installer/update-user-path.tests.ps1
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
if: needs.changes.outputs.heavy == 'true'
|
||||
- name: Check every workspace target compiles on Windows
|
||||
if: needs.changes.outputs.heavy == 'true'
|
||||
@@ -1267,7 +1269,7 @@ jobs:
|
||||
runs-on: macos-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- uses: Swatinem/rust-cache@v2
|
||||
with:
|
||||
cache-bin: false
|
||||
@@ -1305,7 +1307,7 @@ jobs:
|
||||
run: echo "No executable Rust changes detected; preserving required npm wrapper smoke context."
|
||||
- uses: actions/checkout@v7
|
||||
if: needs.changes.outputs.heavy == 'true' && (matrix.os != 'ubuntu-latest' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request')
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
if: needs.changes.outputs.heavy == 'true' && (matrix.os != 'ubuntu-latest' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request')
|
||||
- uses: mozilla-actions/[email protected]
|
||||
id: sccache
|
||||
@@ -1313,7 +1315,7 @@ jobs:
|
||||
# Main-only GitHub Actions cache backend; see the Safety gate job.
|
||||
if: needs.changes.outputs.heavy == 'true' && (matrix.os != 'ubuntu-latest' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request') && github.ref == 'refs/heads/main'
|
||||
- name: Enable sccache
|
||||
if: needs.changes.outputs.heavy == 'true' && (matrix.os != 'ubuntu-latest' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request') && steps.sccache.outcome == 'success'
|
||||
if: needs.changes.outputs.heavy == 'true' && (matrix.os != 'ubuntu-latest' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request') && steps.sccache.outcome == 'success' && matrix.os != 'windows-latest'
|
||||
shell: bash
|
||||
run: |
|
||||
echo "SCCACHE_GHA_ENABLED=true" >> "${GITHUB_ENV}"
|
||||
@@ -1364,7 +1366,7 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- uses: mozilla-actions/[email protected]
|
||||
id: sccache
|
||||
# Main-only GitHub Actions cache backend; see the Safety gate job.
|
||||
@@ -1423,7 +1425,7 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- name: Install Linux system dependencies
|
||||
if: runner.os == 'Linux'
|
||||
run: |
|
||||
|
||||
@@ -48,7 +48,7 @@ jobs:
|
||||
|
||||
- uses: dtolnay/rust-toolchain@master
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
components: rustfmt
|
||||
|
||||
- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
|
||||
|
||||
@@ -67,13 +67,13 @@ jobs:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@master
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
targets: ${{ matrix.target }}
|
||||
- uses: mozilla-actions/[email protected]
|
||||
id: sccache
|
||||
continue-on-error: true
|
||||
- name: Enable sccache
|
||||
if: steps.sccache.outcome == 'success'
|
||||
if: steps.sccache.outcome == 'success' && runner.os != 'Windows'
|
||||
shell: bash
|
||||
run: |
|
||||
{
|
||||
@@ -99,7 +99,7 @@ jobs:
|
||||
run: |
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y binutils musl-tools
|
||||
rustup target add --toolchain stable aarch64-unknown-linux-musl
|
||||
rustup target add aarch64-unknown-linux-musl
|
||||
- name: Build
|
||||
shell: bash
|
||||
# Nightly artifacts are disposable smoke binaries (14-day retention),
|
||||
|
||||
@@ -24,7 +24,7 @@ jobs:
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- name: Install Rust target
|
||||
uses: dtolnay/rust-toolchain@stable
|
||||
uses: dtolnay/rust-toolchain@1.100.0
|
||||
with:
|
||||
targets: aarch64-unknown-linux-ohos
|
||||
- name: Install OpenHarmony native SDK
|
||||
|
||||
@@ -21,7 +21,7 @@ jobs:
|
||||
node-version: '22'
|
||||
cache: npm
|
||||
cache-dependency-path: pet/package-lock.json
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- run: npm --prefix pet ci --ignore-scripts
|
||||
- run: npm --prefix pet run check
|
||||
- run: npm --prefix pet run sync
|
||||
@@ -60,7 +60,7 @@ jobs:
|
||||
cache-dependency-path: pet/package-lock.json
|
||||
- run: npm --prefix pet ci --ignore-scripts
|
||||
- run: npm --prefix pet run check
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
if: runner.os == 'macOS'
|
||||
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
|
||||
if: runner.os == 'macOS'
|
||||
|
||||
@@ -88,9 +88,7 @@ jobs:
|
||||
|
||||
build:
|
||||
name: Build ${{ matrix.platform }}
|
||||
# Both cold macOS artifact builds on 0.10.1 exhausted 90 minutes inside
|
||||
# compilation. Keep the full CI build budget; packaging stays capped below.
|
||||
timeout-minutes: 210
|
||||
timeout-minutes: ${{ startsWith(matrix.os, 'macos-') && 360 || 210 }}
|
||||
# FreeBSD is a source-build target with no prebuilt asset, no npm binary and no CI check
|
||||
# (see packaging/freebsd/README.md and docs/INSTALL.md#freebsd).
|
||||
strategy:
|
||||
@@ -172,13 +170,14 @@ jobs:
|
||||
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||
- uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master 2026-07-18
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
targets: ${{ matrix.target }}
|
||||
- uses: mozilla-actions/sccache-action@fc920bf0ec8de6ee65d409111f7ec508035751ba # v0.0.11
|
||||
if: runner.os == 'Linux'
|
||||
id: sccache
|
||||
continue-on-error: true
|
||||
- name: Enable sccache
|
||||
if: steps.sccache.outcome == 'success'
|
||||
if: steps.sccache.outcome == 'success' && runner.os == 'Linux'
|
||||
shell: bash
|
||||
run: |
|
||||
{
|
||||
@@ -216,7 +215,7 @@ jobs:
|
||||
run: |
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y binutils musl-tools
|
||||
rustup target add --toolchain stable ${{ matrix.target }}
|
||||
rustup target add ${{ matrix.target }}
|
||||
cargo build --profile dist --locked --target ${{ matrix.target }} -p codewhale-cli
|
||||
- name: Configure Android NDK linker
|
||||
if: matrix.target == 'aarch64-linux-android' && runner.os == 'Linux'
|
||||
|
||||
@@ -35,7 +35,7 @@ jobs:
|
||||
package-manager-cache: false
|
||||
- uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # stable 2026-07-18
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
- name: Match dispatch to the requested commit
|
||||
id: source
|
||||
shell: bash
|
||||
@@ -68,6 +68,8 @@ jobs:
|
||||
|
||||
echo "sha=${actual}" >> "${GITHUB_OUTPUT}"
|
||||
echo "version=${workspace_version}" >> "${GITHUB_OUTPUT}"
|
||||
- name: Check the first-party catalog snapshot is current
|
||||
run: ./scripts/refresh-first-party-marketplace.sh --check
|
||||
- name: Check version and OHOS release contracts
|
||||
# --require-dated-release, as auto-tag.yml and release.yml run it:
|
||||
# release.yml only accepts an RC receipt for the exact tag SHA, so an
|
||||
|
||||
@@ -34,7 +34,7 @@ jobs:
|
||||
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||
- uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master 2026-07-18
|
||||
with:
|
||||
toolchain: stable
|
||||
toolchain: 1.100.0
|
||||
components: clippy, rustfmt
|
||||
- uses: mozilla-actions/sccache-action@fc920bf0ec8de6ee65d409111f7ec508035751ba # v0.0.11
|
||||
id: sccache
|
||||
|
||||
@@ -18,7 +18,7 @@ jobs:
|
||||
contents: read
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- name: Install cargo-audit
|
||||
run: cargo install cargo-audit
|
||||
- name: Run cargo audit
|
||||
|
||||
@@ -33,7 +33,7 @@ jobs:
|
||||
with:
|
||||
ref: ${{ inputs.expected_sha }}
|
||||
fetch-depth: 1
|
||||
- uses: dtolnay/rust-toolchain@stable
|
||||
- uses: dtolnay/rust-toolchain@1.100.0
|
||||
- uses: taiki-e/install-action@nextest
|
||||
- name: Run focused tests
|
||||
shell: bash
|
||||
|
||||
+45
-14
@@ -7,14 +7,52 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
- **Agent `cwd` in sibling worktrees:** spawning an agent with `cwd` pointing to an existing linked worktree (or a subdirectory inside it) under the repository's `.codewhale-worktrees/<repo>/` root is now accepted when both share the same repository common git directory; outside directories and foreign or plain directories under `.codewhale-worktrees/` stay refused. (CW-8215)
|
||||
- **DSH market npm installs and extension catalog service:** DSH market `npm` entries with an exact semantic version (and optional `https` registry) now resolve to reviewed registry-tarball install plans (`npm:<pkg>@<ver>` or exact `.tgz` URL) without executing `npm` or bypassing plugin trust review. Inside the extension host, the `dsh/catalog` broker arm now plans reviewed installs without writing to disk, returns only verified approved provider routes scoped to the calling plugin, and serves account balance read-only while withholding credentials and account mutations (CW-7988).
|
||||
- **Plugin settings service backend (0.10.3):** adds the internal `settings` host-service handler (`describe`, `update`, `replace`, `mutate`) and extension-host adapter helper so plugins can inspect and atomically edit only their own reviewed `[plugins."<name>".config]` keys in `config.toml` through the session permission gate and live write posture, leaving comments, unrelated tables and other plugins' configuration untouched (writes return `applies: "reload"` and take effect at the next reload). This backend is not yet wired into live host-service dispatch or plugin grants, so no active plugin exposes it yet. (CW-7983)
|
||||
- **Runtime thread completion wakes:** idle non-ACP runtime threads automatically coalesce finished background shell jobs and completed child sub-agents into a bounded runtime continuation turn without dropping completions during busy turns or triggering wakes on cancelled, archived, or already-drained work. (CW-8215)
|
||||
- **Plugin install summary builder (crate API):** `codewhale-plugins` adds `install::build_summary`, a pure one-line install and update summary builder with stable message IDs for plugins and DSH packages; no CLI, TUI or desktop caller uses it yet. (CW-8182)
|
||||
- **Live reload for external plugin and MCP changes:** when another process installs, enables or disables a plugin or updates the configured MCP file, an idle TUI session now applies the change automatically and records any added or removed skills in the transcript (provider plugin changes still note they apply in a new session); while a turn is running, a toast notifies you and applies the change once idle. (CW-8183)
|
||||
- **First-party plugin catalog updates:** saved `codewhale` marketplace catalogs that came from an earlier embedded snapshot revision now update to the shipped snapshot on load while leaving custom, moving-branch, desktop-bundled, and removed catalogs untouched; release-candidate checks also verify that the embedded snapshot matches the marketplace files it installs from. (CW-8185)
|
||||
- **Network guard and portable config bundles:** `/network allow` now admits a local or private address only for `fetch_url`, `web.run`, and `config import` when the host is a `localhost` name (resolving to loopback only) or a local/private IP literal you typed and explicitly allowed (with IPv6 `deny` rules matching across bracketed and uncompressed spellings and wildcard rules never matching IP literals); domain names resolving to private addresses, skill and plugin installs, extension-host requests, and all cloud metadata forms (including `64:ff9b:1::/48` and `::ffff:0:0:0/96` embedded addresses) plus `0.0.0.0/8` stay refused on every hop. `codewhale config import <url>` now validates every redirect hop and refuses cross-host redirects to visibly local hosts, and portable config bundles reject on import and omit on export visibly local `network.allow` entries (including `localhost` names, local-domain wildcards such as `.localdomain` and `*.localhost`, and local IP literals).
|
||||
- **Skill install and update controller:** installing an already installed skill now updates it in place (reporting any replaced source and preserving `skills_state.toml` enabled/disabled state), local folders and `.tar.gz`/`.tgz` archives install and update as managed skills with path-safety and archive-bound checks, person-started global installs are trusted automatically without marking project skills, and mutations emit a one-line outcome receipt. (CW-8184)
|
||||
- **Removed (crate API):** the unwired `codewhale-hooks` dispatcher and its stdout, JSONL and Unix-socket sinks; `codewhale-core`'s `session`, `journal` and `ids` modules and the `hooks` argument of `Runtime::new`; `codewhale-runtime::resource_telemetry`; ten unreferenced public functions; and the duplicate `codewhale-agent` crate. `hook_sinks.unix_socket_path` still parses and is ignored. CLI, TUI and app-server behavior is unchanged.
|
||||
- **First-run setup:** installer downloads retry up to three times and remove partial files after a failed attempt. Folder trust uses 1 to trust, 2 to continue untrusted, and 3 or Esc to quit; letters do nothing. Provider pickers consistently say "needs key", and the unconfigured custom placeholder says "needs endpoint" while configured-route errors remain visible.
|
||||
- **Quota-window reset text:** a rate-limited turn now gives the reset time in plain words such as "19h29m" instead of Rust debug output like `Some(70168s)`, and leaves the reset clause out when the provider gives no reset time. An OpenCode Go message points at that provider's own key with `codewhale auth set --provider opencode-go`, without repeating a hint the message already carries. (CW-8209)
|
||||
- **Usage-reporting collector:** accepts runtime schema 6 alongside existing versions and keeps schema 6 reports first-party only.
|
||||
|
||||
- **Source-build toolchain:** Rust 1.100.0 is pinned consistently across local source builds, CI, Docker, Dev Containers and CNB recipes. The minimum supported Rust version remains 1.89.
|
||||
- **Terminal input recovery:** retains a wake event from a replaced reader, suppresses retired events observed during a child-terminal handoff, and closes only the handoff window owned by that scope.
|
||||
|
||||
- **Plugin index hooks:** hooks with the same name and event now have distinct row IDs, so clients can keep every configured hook visible.
|
||||
- **Extension service approvals:** plugin service acts use the session permission gate and retain their approved or refused act records when a tool call fails. Closing a call seals its broker-act record so a late approval cannot authorize an unrecorded act. Ordinary nested-call receipts may still show an in-flight outcome when cancellation ends the call early.
|
||||
- **Delayed-message workspaces and shell stdin approvals:** `send_later` `schedule` now keeps its workspace inside the session's reachable paths instead of accepting an arbitrary directory, and `send_later` approval prompts show the requested workspace; session shell grants now match exact inputs when `stdin` (`stdin`, `input`, `data`) is supplied instead of reusing a command-only grant across different `stdin`.
|
||||
|
||||
- **Installers no longer say Computer Use comes bundled:** the macOS install script and the install guide no longer print or state that Computer Use ships with the binary or needs Node.js 20. Computer Use is released separately and stays off until you turn it on.
|
||||
- **Charts in the transcript:** the model can now show numbers as a small chart with the new read-only `show_data` tool: a one-row sparkline, up to 24 labelled bars, or a multi-row trend. The TUI paints it in the transcript with the terminal kit, including after a session is restored, and every value is also in words, so the model and other clients get the same facts as text. Input the chart cannot show honestly (a non-finite number, more than 1024 points or 24 bars, a label over 120 characters) is refused with the limit it broke.
|
||||
- **Charts in the transcript:** the model can now show numbers as a small chart with the new read-only `show_data` tool: a one-row sparkline, up to 24 labelled bars, or a multi-row trend. The TUI paints it in the transcript with the terminal kit, including after a session is restored, and a plain-text summary accompanies each chart for the model and other clients. Input the chart cannot show honestly (a non-finite number, more than 1024 points or 24 bars, a label over 120 characters) is refused with the limit it broke.
|
||||
- **Terminal widgets:** narrow action hints wrap, scrollbars reach the final row, progress bars show fractional cells, focused tabs and panels are clearer, and the shared terminal kit supports measured ocean themes and reduced-motion-aware water drift.
|
||||
- **Plugin lifecycle from the shell:** `codewhale plugins` now has `install <spec>`, `show <name>`, `update <name>` and `uninstall <name>` (each with `--json`) alongside `status`, `restage`, `trust`, `enable`, `disable` and `revoke`. `plugins install` uses the same reviewed installer as `codewhale install`, `show` prints the capability review without prompting or trusting, `update` refreshes from the recorded source and reports either the new version or `already current`, and `uninstall` disables an enabled bundle first and asks in a terminal unless `--yes` is passed (non-interactive and `--json` runs require `--yes`). (CW-8161)
|
||||
|
||||
- **Renaming sessions with Chinese titles:** the session picker no longer rejects a Chinese, Japanese, Korean or emoji title of more than about 33 characters as "Title must be 1–100 characters". It now counts characters, as the message says and as `/rename` and the Runtime API already did, so any title up to 100 characters is accepted. Thanks [@luochen211](https://github.com/luochen211) (PR 7322).
|
||||
- **Non-ASCII file names:** `/diff`, the `@git` and `@diff` mentions and the Runtime API workspace diff now show paths with Chinese, emoji and other non-ASCII characters as written instead of as quoted octal escapes, and the turn context no longer lists the workspace root as an empty "Active paths" entry. Thanks [@luochen211](https://github.com/luochen211) (PR 7317).
|
||||
- **Session names after a crash, and keep-forever snapshot retention:** a session name saved right after a crash that cut off the previous session-index line is no longer lost, because the new entry now starts on its own line; and a very large `[snapshots] max_age_days` (such as `9223372036854775807` for "keep forever") no longer wraps around and deletes every undo snapshot at session start. Thanks [@luochen211](https://github.com/luochen211) (PR 7316).
|
||||
- **Blank environment variables:** exporting a variable empty (for example `CODEWHALE_MODEL=` from a compose `${VAR:-}` template) no longer hides its legacy alias. `DEEPSEEK_MODEL`, `DEEPSEEK_BASE_URL`, `KIMI_BASE_URL`, `DEEPSEEK_FORCE_HTTP1`, `DEEPSEEK_STREAM_OPEN_TIMEOUT_SECS` and the other provider alias variables now apply as they do when the primary is unset. Thanks [@luochen211](https://github.com/luochen211) (PR 7315).
|
||||
- **MCP and language servers that send requests mid-call:** a tool call no longer fails with "neither a result nor an error" when an MCP server sends a `ping` or other request that reuses the call's id while the call is running, and a language server's `workspace/configuration` or similar request no longer ends a pending LSP request. Codewhale now answers `ping`, answers other server requests with "Method not found" (it never advertised them), keeps waiting for the real reply, and a refused answer over Streamable HTTP no longer drops the connection to legacy SSE. Thanks [@luochen211](https://github.com/luochen211) (PR 7319).
|
||||
- **Qwen Code as an external agent:** Codewhale now finds an installed Qwen Code CLI (`qwen`, 0.6.1 or newer) and can run it as a session over ACP with `qwen --acp`. `GET /v1/agents/external` lists it, an older install is reported as needing `npm i -g @qwen-code/qwen-code@latest`, and sign-in stays inside Qwen Code (`/auth`). Thanks [@MannXo](https://github.com/MannXo) (#7293).
|
||||
- **Qwen Code as an external agent:** Codewhale now finds an installed Qwen Code CLI (`qwen`, 0.6.1 or newer) and can run it as a session over ACP with `qwen --acp`. `GET /v1/agents/external` lists it, an older install is reported as needing `npm i -g @qwen-code/qwen-code@latest`, and sign-in stays inside Qwen Code (`/auth`). Thanks [@MannXo](https://github.com/MannXo) (PR 7293).
|
||||
- **Telemetry setting default:** the settings schema API reports telemetry's default as on, matching what Codewhale does when you have not chosen.
|
||||
- **Auto routing abstention:** when the decision model marks a tier, effort or shadow answer `abstained: true`, Auto no longer acts on it, even with `min_confidence = 0`: an abstained tier takes the local fallback, an abstained effort keeps the tier and drops only the effort, and the routing receipt lists the abstained questions.
|
||||
- **Plugin index (Runtime API):** a new `GET /v1/apps/plugin-index` route lists plugins, skills, connectors, hooks and hand-written commands with kind, source and state, and `/v1/commands` rows say which plugin (`plugin_id`) added a command and whether a command came from the project (`workspace_sourced`) (CW-8092).
|
||||
- **Model commands and routing:** `codewhale model list` now lists every custom endpoint you have configured, under its own name. `codewhale model resolve` no longer refuses a model on a custom endpoint, router or local server whose model list has not been fetched yet; once a list is fetched, a model missing from it is still refused. Automatic routing marks a context window as verified only when the route itself supplies it, and no longer reports a guessed output limit.
|
||||
- **ACP:** when a plugin tool asks the core to run a tool that needs approval, the editor now gets a `session/request_permission` on the plugin tool's call that names the nested tool and its input; before, the prompt ended with an internal error (CW-8050).
|
||||
- **Website maintainer and cron secrets:** the manual cron trigger is rate limited, admin sign-in and the cron secret require a 32 to 512 character secret with at least 8 distinct characters that is not a repeated pattern, and changing the maintainer token signs out existing admin sessions.
|
||||
- **Chat bridges thread ownership:** Chat bridges now list and resume only the threads the chat itself created: `/threads` shows owned threads, `/resume` refuses any other thread id with one fixed message, and `/new` always starts a new thread. In an existing thread map each chat keeps only the thread it is bound to, so threads it created earlier and left are no longer listed or resumable; a thread that several chats already pointed at is usable from none of them (send `/new`). Review `thread-map.json` after upgrading.
|
||||
- **Skill and plugin installs:** skill and plugin installs now enforce the uncompressed size cap on the whole decompressed archive, and reject archive entries with names longer than 4096 bytes.
|
||||
- **Built-in execution rules:** a `Bash` deny rule now also blocks built-in test and verifier runs (`Run` / `run_tests` / `run_verifiers`), `workflow` runs with `verify: true`, and delayed-message scheduling (`send_later` `schedule`) while keeping task reads, status checks, management actions, and the bounded verifier's own default verification runs working.
|
||||
- **README and contributor credit:** the repository front page now opens the way the website does: the line "The model can be anyone's. The agent should be yours.", one sentence on what Codewhale is, the install command and one picture, with reference detail moved into the linked guides; the 18 translated READMEs follow the same structure and say they are machine-drafted. The contributor wall and the website now count the same 433 people (407 GitHub accounts and the commit authors whose email is not linked to an account), where the website had counted accounts only. `DEPENDENCY_SECURITY.md` moved into `docs/dependency-maintenance.md`, and `.github/SUPPORT.md` says where to ask for help.
|
||||
- **Website Plugins page:** The website's Plugins page now describes what the released version does, and a labelled section says what 0.10.3 adds: one Plugins place, Standard and Creator mode, and the Permissions control.
|
||||
- **Website `/app` captures:** the `/app` page's desktop build screenshots (`conversation.webp`, `approval.webp`, `model-picker.webp`) and their alt and caption text have been refreshed from the current 0.10.3 desktop UI.
|
||||
- **First-time guide on the website:** a new docs page, "Use Codewhale for the first time" (`/docs/first-time`, English and Simplified Chinese), walks someone who has never used a terminal through opening one, installing, choosing the folder Codewhale works in and when that choice matters, opening a terminal in a folder from Finder or File Explorer, connecting a model, a first task, and stopping, undoing and quitting. The install page gains a short "New to the terminal?" block for macOS and Windows that links to it, and `llms.txt` carries the same steps.
|
||||
- **Plugin docs and plugin-creator:** Docs now say everything you add is a plugin. The bundled plugin-creator skill no longer tells an agent never to trust or enable a plugin (in Full Access it may, for one it wrote and installed from its project), points code and screen plugins at cordis-plugin-development, and an untouched copy from 0.10.2 now upgrades. The Chinese extension and Runtime API docs now say editor ACP sessions get plugin tools and configured MCP servers.
|
||||
- **Model thinking:** New installs show model thinking by default: it streams live in the transcript and collapses under a "Thought for …" header when the answer starts. Existing installs keep their saved setting; turn it on under Model reasoning in chat in /config.
|
||||
@@ -95,6 +133,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
### Fixed
|
||||
|
||||
- **Credential redaction:** text, JSON, and workflow-disclosure redaction now masks multi-line private-key blocks across PGP armor headers (including `Comment:` URLs), longer preambles, and 16-character wrapped lines; masks credential values inside nested or escaped JSON assignments, escaped quotes, `\u003c`/`\u003e` delimiters, and spaced or nested JSON objects and arrays; and treats plural token keys (`API_TOKENS`, `ACCESS_TOKENS`) and credential-shaped `tokens` values as credentials while keeping model and tokenizer metric names (`max_tokens`, `tokenizer`, `token_limit`, `tokens=5`) visible.
|
||||
- Child processes now inherit only the standard locale variables (`LC_ALL`, `LC_CTYPE` and the other locale categories, plus `LC_TERMINAL` and `LC_TERMINAL_VERSION`) and a listed set of `DOTNET_` host, SDK and runtime settings. Other `DOTNET_` variables, including application configuration keys, are no longer passed to child processes or MCP servers.
|
||||
- **Deny rules and command safety:** a command whose command word is not a plain literal, or that redefines a command name earlier in the same call, is now refused while a deny rule is configured; the background destroyer hold reads commands the shell tokenizer rejects and decodes ANSI-C escapes inside shell payloads; and `sed`, `find`, `sort`, `rg`, `fd`, `uniq`, `env`, `less`, `more`, `ag`, `info` and `git` count as read-only only when their words are literal and use read-only flags, with `codewhale --version` and Windows trailing-backslash paths normalized before checking.
|
||||
- **Starting after a hard kill:** the Engine now starts when its process was killed and its data directory was then deleted. A socket owner record whose process is dead and whose data directory, the one this start selected, no longer exists is discarded instead of failing every start with "Failed to resolve ... tasks/runtime". A home reached through a symbolic link, such as one under macOS /tmp, is not covered yet.
|
||||
- The install guide's note for a first message that gets no answer now describes v0.10.2: connect a model with `/provider`, and restart if messages stay saved for later after you connect. It described v0.10.0's key screen. The Chinese guide carries the same correction.
|
||||
- Project activity on the site now comes from a server-side snapshot with a freshness record, the browser no longer calls GitHub, and count sentences use the right plural form in every language.
|
||||
@@ -446,6 +487,8 @@ work is declared complete here. Items moved to 0.10.4 by name are marked below.
|
||||
|
||||
### Changed
|
||||
|
||||
- **Terminal Plugins screen:** The terminal's Extensions screen is now called Plugins; its tabs filter by kind (Installed, Skills, Connectors, Hooks, Marketplace), and `/plugin` is listed with the main commands. `/skills`, `/mcp` and `/hooks` work as before.
|
||||
|
||||
- **`read` pages in lines only (breaking).** One `read` call returns at
|
||||
most 2,000 lines — the default and the maximum `limit` — inside a 50 KiB
|
||||
output cap, and a line longer than 2,000 chars comes back truncated with
|
||||
@@ -676,12 +719,12 @@ work is declared complete here. Items moved to 0.10.4 by name are marked below.
|
||||
- **Windows uninstall removes the receipt and update leftovers.** The installer's uninstaller also deletes `.codewhale-install.sha256` and `codewhale.old-*`/`codew.old-*` left by a self-update, so `bin` can be removed. Refs #7091.
|
||||
- **Windows `/undo` matches recorded file paths regardless of case.** A write recorded under a different drive-letter or directory case, or a `\\?\` prefix, is no longer dropped from the restore plan. Refs #6970.
|
||||
- **Windows: Fleet and metrics read live files again.** Replaying a Fleet ledger and reading audit or receipt records no longer fail with a sharing violation while their writer is still open; the same regular-file, link and identity checks apply. Plugin enablement now says which snapshot check refused (stage root, content identity or final check) instead of one generic message. Generated protocol and SDK exports keep LF line endings in Windows checkouts.
|
||||
- **A held coordination lock no longer makes a new session read-only.** When another session owns the delegated-agent store, the new session starts on private state and says so, instead of refusing every sub-agent with “Failed to clean up sub-agents”.
|
||||
- **Sessions in one folder no longer leave each other's sub-agents read-only or private:** a second session works beside another one, stale or suspended included, the older sub-agent store upgrades right away, and a store that cannot be opened is retried on the next sub-agent change instead of needing a restart. While another Codewhale session, a suspended one included, is open in a folder the desktop app or `serve` was asked to work in (other than the folder it started in), that Runtime still refuses sub-agents that would edit the folder directly; isolated worktrees are unaffected. A sub-agent store that cannot be opened shows its refusal once instead of repeating cleanup warnings on every sidebar refresh. Restart any session started with Codewhale 0.10.2 or older: once the folder upgrades it can no longer save sub-agent state (Refs #7232).
|
||||
- **A dev server can outlive the turn in an interactive session.** `persist:true` now works in the TUI and desktop when the thread has Full Access; restricted postures and Fleet/sub-agents still refuse it.
|
||||
- **`codewhale exec --add-dir <path>`** (repeatable) and `addDirs` on `POST /v1/threads` let the file tools read and write a sibling directory, a second checkout or a shared scratch root without turning on Full Access.
|
||||
- **Unsettled usage is persisted in production, not only in tests.** The interactive sink now records a legacy usage receipt when a provider response has no settlement, so children and turns stop reporting settlement failure.
|
||||
- **A full usage journal no longer fails a turn before dispatch.** The request runs with cost unknown instead of stopping on “native usage journal capacity reached”.
|
||||
- **Reverting a file works in any posture.** Restoring a file the thread's own turns changed no longer requires `/trust` or Full Access; the exact snapshot and reviewed-hash checks still apply. **`fetch_url` can reach a local or private host you allowed** with `/network allow <host>`; cloud metadata stays blocked. Both refusals now name the setting.
|
||||
- **Reverting a file works in any posture.** Restoring a file the thread's own turns changed no longer requires `/trust` or Full Access; the exact snapshot and reviewed-hash checks still apply. **`fetch_url` can reach a typed `localhost` name or local IP literal you allowed** with `/network allow <host>` (domain names resolving to private addresses and cloud metadata stay blocked). Both refusals now name the setting.
|
||||
- **`codewhale exec` offers tools by default**, still under the configured sandbox and approval posture. `--no-tools` is the one-shot. A pipe on stdin is the prompt when no arguments are given, or is appended to them.
|
||||
- **A child no longer dies when usage settlement is not acknowledged.** The turn continues and cost stays unknown, matching the parent path.
|
||||
- **Workspace memory works without a git origin.** A plain folder or a repo with no `origin` remote gets a stable workspace id. `codewhale plugin list` is an alias of `plugins status`. A heavy command runs after 30 seconds instead of waiting forever for an admission slot. An MCP registration 4xx names the status and the manual client-id path.
|
||||
@@ -713,12 +756,6 @@ work is declared complete here. Items moved to 0.10.4 by name are marked below.
|
||||
composer. Real Pinyin input on macOS and Windows is not yet confirmed.
|
||||
Thanks [@cmdcorp6534](https://github.com/cmdcorp6534) for the report
|
||||
(Refs #2323).
|
||||
- **Sub-agents beside an older session:** while a Codewhale 0.10.2 session
|
||||
still uses a folder's older delegated-agent store, a 0.10.3 session in the
|
||||
same folder keeps working sub-agents with private state that is not saved,
|
||||
instead of refusing every sub-agent action. The older session's files are
|
||||
left untouched, and the store upgrades when a session starts after the older
|
||||
one exits (Refs #7232).
|
||||
- **Fleet members:** a replayed member start now matches only within its own
|
||||
session, so two sessions that reuse an operation key no longer receive each
|
||||
other's agent.
|
||||
@@ -747,12 +784,6 @@ work is declared complete here. Items moved to 0.10.4 by name are marked below.
|
||||
bare self-package exports resolve inside the selected package directory.
|
||||
Invalid or incompatible ranges and paths outside the reviewed package still
|
||||
refuse. Real published-plugin activation remains unqualified.
|
||||
- **Coordination lock diagnostics (#7232):** stale lock-file contents no longer
|
||||
identify an owner PID. A refused legacy admission keeps its reason in Work
|
||||
and shows one notice per cause instead of repeating cleanup warnings on
|
||||
every sidebar refresh. Legacy migration still requires the actual holder to
|
||||
exit and the refused owning Runtime to restart; locks and retained state
|
||||
remain protected.
|
||||
- **A local proxy that stops mid-session no longer strands the session (#7231):** the model, catalog, search, vision, finance, MCP-registry, profile and remote-control clients watch a loopback proxy port and go direct while it refuses connections, then resume proxying when it returns. Only a definite refusal from every resolved address changes the route; remote proxies, `NO_PROXY` matches, credentials and the existing precedence are unchanged. Set `CODEWHALE_LOCAL_PROXY_FALLBACK=0` to keep the old build-time snapshot.
|
||||
- **Proxy diagnostic privacy ([#7233](https://github.com/codewhale-hq/codewhale/issues/7233)):** malformed MCP proxy warnings omit configured values; local-proxy log labels mask userinfo and omit URL paths, queries and fragments. Routing is unchanged. All 23 existing proxy tests passed on macOS; runtime log capture and other platforms remain unqualified. Thanks [@SparkofSpike](https://github.com/SparkofSpike) for the report.
|
||||
- **Fork, undo and retry work after a workspace drift notice (#7234):** the history-boundary walks now treat a whole `<context_update>` envelope as engine-owned, so a session that received one can be cut at every saved turn. A person quoting a notice or a truncated envelope still counts as their own prompt.
|
||||
|
||||
Generated
+10
-27
@@ -912,14 +912,6 @@ dependencies = [
|
||||
"zeroize",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "codewhale-agent"
|
||||
version = "0.10.3"
|
||||
dependencies = [
|
||||
"codewhale-config",
|
||||
"serde",
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "codewhale-agent-contract"
|
||||
version = "0.10.3"
|
||||
@@ -943,7 +935,6 @@ dependencies = [
|
||||
"chrono",
|
||||
"clap",
|
||||
"codewhale-account-cli",
|
||||
"codewhale-agent",
|
||||
"codewhale-agent-contract",
|
||||
"codewhale-app-server-protocol",
|
||||
"codewhale-build-support",
|
||||
@@ -1046,9 +1037,11 @@ dependencies = [
|
||||
"codewhale-engine",
|
||||
"codewhale-execpolicy",
|
||||
"codewhale-lane",
|
||||
"codewhale-net",
|
||||
"codewhale-paths",
|
||||
"codewhale-release",
|
||||
"codewhale-runtime",
|
||||
"codewhale-sanitize",
|
||||
"codewhale-secrets",
|
||||
"codewhale-state",
|
||||
"codewhale-telemetry",
|
||||
@@ -1118,6 +1111,7 @@ dependencies = [
|
||||
"codewhale-execpolicy",
|
||||
"codewhale-paths",
|
||||
"codewhale-protocol",
|
||||
"codewhale-sanitize",
|
||||
"codewhale-secrets",
|
||||
"fd-lock",
|
||||
"libc",
|
||||
@@ -1141,7 +1135,6 @@ name = "codewhale-core"
|
||||
version = "0.10.3"
|
||||
dependencies = [
|
||||
"codewhale-config",
|
||||
"codewhale-hooks",
|
||||
"codewhale-protocol",
|
||||
"codewhale-state",
|
||||
"regex",
|
||||
@@ -1150,7 +1143,6 @@ dependencies = [
|
||||
"sha2 0.11.1",
|
||||
"tempfile",
|
||||
"thiserror 2.0.21",
|
||||
"tokio",
|
||||
"uuid",
|
||||
]
|
||||
|
||||
@@ -1179,14 +1171,12 @@ dependencies = [
|
||||
"agent-client-protocol",
|
||||
"agent-client-protocol-schema",
|
||||
"anyhow",
|
||||
"arboard",
|
||||
"async-stream",
|
||||
"async-trait",
|
||||
"axum",
|
||||
"base64 0.23.1",
|
||||
"chrono",
|
||||
"clap",
|
||||
"codewhale-agent",
|
||||
"codewhale-agent-contract",
|
||||
"codewhale-app-server-protocol",
|
||||
"codewhale-build-support",
|
||||
@@ -1207,6 +1197,7 @@ dependencies = [
|
||||
"codewhale-paths",
|
||||
"codewhale-plugins",
|
||||
"codewhale-protocol",
|
||||
"codewhale-ratatui",
|
||||
"codewhale-release",
|
||||
"codewhale-repl",
|
||||
"codewhale-runtime",
|
||||
@@ -1221,7 +1212,6 @@ dependencies = [
|
||||
"codewhale-util",
|
||||
"codewhale-workflow",
|
||||
"codewhale-workflow-js",
|
||||
"cucumber",
|
||||
"dirs 7.0.0",
|
||||
"encoding_rs",
|
||||
"fd-lock",
|
||||
@@ -1240,12 +1230,10 @@ dependencies = [
|
||||
"objc2-foundation",
|
||||
"parking_lot",
|
||||
"portable-pty",
|
||||
"pretty_assertions",
|
||||
"proc-macro2",
|
||||
"regex",
|
||||
"reqwest",
|
||||
"ring",
|
||||
"rio-vt",
|
||||
"rmcp",
|
||||
"rusqlite",
|
||||
"rustls",
|
||||
@@ -1261,9 +1249,7 @@ dependencies = [
|
||||
"tar",
|
||||
"tempfile",
|
||||
"thiserror 2.0.21",
|
||||
"tiny_http",
|
||||
"tokio",
|
||||
"tokio-tungstenite 0.30.0",
|
||||
"tokio-util",
|
||||
"toml 1.1.6+spec-1.1.0",
|
||||
"toml_edit 0.25.15+spec-1.1.0",
|
||||
@@ -1307,14 +1293,11 @@ name = "codewhale-hooks"
|
||||
version = "0.10.3"
|
||||
dependencies = [
|
||||
"anyhow",
|
||||
"async-trait",
|
||||
"chrono",
|
||||
"codewhale-app-server-protocol",
|
||||
"codewhale-paths",
|
||||
"codewhale-protocol",
|
||||
"codewhale-release",
|
||||
"reqwest",
|
||||
"serde",
|
||||
"serde_json",
|
||||
"tempfile",
|
||||
"tokio",
|
||||
@@ -1434,7 +1417,7 @@ version = "0.10.3"
|
||||
dependencies = [
|
||||
"codewhale-config",
|
||||
"codewhale-runtime",
|
||||
"codewhale-secrets",
|
||||
"codewhale-sanitize",
|
||||
"dirs 7.0.0",
|
||||
"regex",
|
||||
"tempfile",
|
||||
@@ -1611,12 +1594,12 @@ dependencies = [
|
||||
"codewhale-paths",
|
||||
"codewhale-protocol",
|
||||
"codewhale-release",
|
||||
"codewhale-sanitize",
|
||||
"codewhale-secrets",
|
||||
"codewhale-util",
|
||||
"colored",
|
||||
"dirs 7.0.0",
|
||||
"fd-lock",
|
||||
"futures-util",
|
||||
"ignore",
|
||||
"jsonwebtoken",
|
||||
"libc",
|
||||
@@ -1734,9 +1717,11 @@ dependencies = [
|
||||
"codewhale-runtime",
|
||||
"codewhale-skill-install",
|
||||
"codewhale-util",
|
||||
"flate2",
|
||||
"serde",
|
||||
"serde_json",
|
||||
"sha2 0.11.1",
|
||||
"tar",
|
||||
"tempfile",
|
||||
"tokio",
|
||||
"toml 1.1.6+spec-1.1.0",
|
||||
@@ -1884,9 +1869,7 @@ dependencies = [
|
||||
"reqwest",
|
||||
"rio-vt",
|
||||
"rquickjs",
|
||||
"rusqlite",
|
||||
"rustls",
|
||||
"schemars 1.2.2",
|
||||
"semver",
|
||||
"serde",
|
||||
"serde_json",
|
||||
@@ -1896,7 +1879,6 @@ dependencies = [
|
||||
"tempfile",
|
||||
"tiny_http",
|
||||
"tokio",
|
||||
"tokio-tungstenite 0.30.0",
|
||||
"tokio-util",
|
||||
"toml 1.1.6+spec-1.1.0",
|
||||
"toml_edit 0.25.15+spec-1.1.0",
|
||||
@@ -1920,7 +1902,7 @@ version = "0.10.3"
|
||||
dependencies = [
|
||||
"codewhale-palette",
|
||||
"codewhale-ratatui",
|
||||
"codewhale-secrets",
|
||||
"codewhale-sanitize",
|
||||
"crossterm",
|
||||
"ratatui",
|
||||
"similar",
|
||||
@@ -1961,6 +1943,7 @@ name = "codewhale-workflow"
|
||||
version = "0.10.3"
|
||||
dependencies = [
|
||||
"codewhale-protocol",
|
||||
"codewhale-sanitize",
|
||||
"serde",
|
||||
"serde_json",
|
||||
"sha2 0.11.1",
|
||||
|
||||
@@ -1,7 +1,6 @@
|
||||
[workspace]
|
||||
members = [
|
||||
"crates/account-cli",
|
||||
"crates/agent",
|
||||
"crates/agent-contract",
|
||||
"crates/app-server",
|
||||
"crates/app-server-protocol",
|
||||
|
||||
+1
-1
@@ -12,7 +12,7 @@
|
||||
# Or mount an env file:
|
||||
# docker run --rm -it --env-file .env codewhale
|
||||
|
||||
ARG RUST_VERSION=1.88
|
||||
ARG RUST_VERSION=1.100.0
|
||||
|
||||
# ── Stage 1: Build ────────────────────────────────────────────────────
|
||||
FROM --platform=$BUILDPLATFORM rust:${RUST_VERSION}-slim-bookworm AS builder
|
||||
|
||||
@@ -119,12 +119,9 @@ Connect [MCP servers](docs/MCP.md), add [skills](docs/SKILLS.md) and
|
||||
[plugins](docs/PLUGINS.md), and run [hooks](docs/HOOKS.md) on session and tool
|
||||
events. Code mode (experimental, on by default) lets the model write one
|
||||
`execute_tools` program that calls several MCP and plugin tools; each call
|
||||
still meets your approval rules and keeps its receipt. The Computer Use plugin
|
||||
bundled with v0.10.2 (experimental, macOS only) can observe and operate other
|
||||
apps, and it stays off until you review its access and enable it
|
||||
([guide](https://github.com/codewhale-hq/Codewhale/blob/v0.10.2/crates/tui/plugins/computer-use/README.md)).
|
||||
Coming in 0.10.3: the plugin is released
|
||||
[separately](https://github.com/codewhale-hq/codewhale-cu-plugin).
|
||||
still meets your approval rules and keeps its receipt. [Computer Use](https://github.com/codewhale-hq/codewhale-cu-plugin)
|
||||
is a separate plugin released on its own (experimental, macOS only), and stays
|
||||
off until you review its access and turn it on.
|
||||
|
||||
### Ways to run it
|
||||
|
||||
|
||||
@@ -1,15 +0,0 @@
|
||||
[package]
|
||||
name = "codewhale-agent"
|
||||
version.workspace = true
|
||||
edition.workspace = true
|
||||
rust-version.workspace = true
|
||||
license.workspace = true
|
||||
repository.workspace = true
|
||||
description = "Model/provider registry and fallback strategy for Codewhale"
|
||||
|
||||
[lints]
|
||||
workspace = true
|
||||
|
||||
[dependencies]
|
||||
codewhale-config = { path = "../config", version = "0.10.3" }
|
||||
serde.workspace = true
|
||||
File diff suppressed because it is too large.
Load diff
@@ -32,7 +32,6 @@ codewhale-app-server-protocol = { path = "../app-server-protocol", version = "0.
|
||||
anyhow.workspace = true
|
||||
axum.workspace = true
|
||||
chrono.workspace = true
|
||||
codewhale-agent = { path = "../agent", version = "0.10.3" }
|
||||
codewhale-config = { path = "../config", version = "0.10.3" }
|
||||
codewhale-core = { path = "../core", version = "0.10.3" }
|
||||
codewhale-hooks = { path = "../hooks", version = "0.10.3" }
|
||||
|
||||
@@ -47,6 +47,18 @@ impl Drop for TurnClaim {
|
||||
}
|
||||
}
|
||||
}
|
||||
fn admitted_call<'a>(
|
||||
calls: &'a HashMap<String, PendingToolCall>,
|
||||
execution: &str,
|
||||
) -> Option<(&'a str, &'a PendingToolCall)> {
|
||||
let mut id = execution;
|
||||
loop {
|
||||
if let Some((key, call)) = calls.get_key_value(id) {
|
||||
return Some((key.as_str(), call));
|
||||
}
|
||||
id = id.rsplit_once('.')?.0;
|
||||
}
|
||||
}
|
||||
fn update(session: &str, update: acp::SessionUpdate) -> Outgoing {
|
||||
Outgoing::Update(acp::SessionNotification::new(session.to_string(), update))
|
||||
}
|
||||
@@ -419,27 +431,50 @@ impl PromptRun {
|
||||
&& pending.turn_id == turn
|
||||
&& pending.tool_call_id.as_deref() == Some(execution)
|
||||
}) {
|
||||
let call = calls
|
||||
.get(execution)
|
||||
let (shown, call) = admitted_call(calls, execution)
|
||||
.ok_or_else(|| anyhow!("Approval projection lacks admitted tool start"))?;
|
||||
let id = uuid::Uuid::new_v4().to_string();
|
||||
let title = tool_call_title(call);
|
||||
let text = p
|
||||
let nested = shown != execution;
|
||||
let nested_call;
|
||||
let shown_call = if nested {
|
||||
nested_call = PendingToolCall {
|
||||
execution_id: execution.to_string(),
|
||||
name: p
|
||||
.get("tool_name")
|
||||
.and_then(Value::as_str)
|
||||
.unwrap_or(&call.name)
|
||||
.to_string(),
|
||||
input: p.get("input").cloned().unwrap_or(Value::Null),
|
||||
};
|
||||
&nested_call
|
||||
} else {
|
||||
call
|
||||
};
|
||||
let title = tool_call_title(shown_call);
|
||||
let description = p
|
||||
.get("description")
|
||||
.and_then(Value::as_str)
|
||||
.filter(|text| !text.trim().is_empty())
|
||||
.map_or_else(|| title.clone(), str::to_string);
|
||||
.filter(|text| !text.trim().is_empty());
|
||||
let summary = p
|
||||
.get("summary")
|
||||
.and_then(Value::as_str)
|
||||
.filter(|text| nested && !text.trim().is_empty());
|
||||
let text = match (summary, description) {
|
||||
(Some(summary), Some(description)) => format!("{summary}\n{description}"),
|
||||
(Some(text), None) | (None, Some(text)) => text.to_string(),
|
||||
(None, None) => title.clone(),
|
||||
};
|
||||
let mut fields = acp::ToolCallUpdateFields::new()
|
||||
.title(title)
|
||||
.kind(tool_call_kind(shown_call))
|
||||
.raw_input((!shown_call.input.is_null()).then(|| shown_call.input.clone()))
|
||||
.content(vec![acp::ToolCallContent::from(text)]);
|
||||
if !nested {
|
||||
fields = fields.status(acp::ToolCallStatus::Pending);
|
||||
}
|
||||
let request = acp::RequestPermissionRequest::new(
|
||||
session.to_string(),
|
||||
acp::ToolCallUpdate::new(
|
||||
execution.to_string(),
|
||||
acp::ToolCallUpdateFields::new()
|
||||
.title(title)
|
||||
.kind(tool_call_kind(call))
|
||||
.status(acp::ToolCallStatus::Pending)
|
||||
.raw_input((!call.input.is_null()).then(|| call.input.clone()))
|
||||
.content(vec![acp::ToolCallContent::from(text)]),
|
||||
),
|
||||
acp::ToolCallUpdate::new(shown.to_string(), fields),
|
||||
vec![
|
||||
acp::PermissionOption::new(
|
||||
"allow-once",
|
||||
|
||||
@@ -14,7 +14,6 @@ use crate::stdio::{BoundedLines, run_stdio_loop};
|
||||
use anyhow::Context as _;
|
||||
use anyhow::{Result, anyhow};
|
||||
use axum::http::{Method, StatusCode};
|
||||
use codewhale_agent::ModelRegistry;
|
||||
use codewhale_app_server_protocol::rpc::{
|
||||
RequestId, RpcCall, RpcErrorDetails, RpcErrorResponse, RpcResponse,
|
||||
};
|
||||
@@ -23,7 +22,6 @@ use codewhale_app_server_protocol::runtime::MAX_RUNTIME_IMAGE_BODY_BYTES;
|
||||
use codewhale_app_server_protocol::runtime::RuntimeImageInput;
|
||||
use codewhale_config::ConfigStore;
|
||||
use codewhale_core::Runtime;
|
||||
use codewhale_hooks::{HookDispatcher, JsonlHookSink, StdoutHookSink, UnixSocketHookSink};
|
||||
use codewhale_protocol::EventFrame;
|
||||
use codewhale_state::StateStore;
|
||||
use serde::Deserialize;
|
||||
@@ -364,7 +362,6 @@ pub struct AppState {
|
||||
/// Bookkeeping config and read-only historical archive access.
|
||||
/// Actual turns and transcript writes belong to the captured owner.
|
||||
runtime: Arc<RwLock<Runtime>>,
|
||||
registry: ModelRegistry,
|
||||
auth_token: Option<String>,
|
||||
#[cfg(test)]
|
||||
runtime_bridge: Arc<Mutex<Option<SharedRuntimeBridge>>>,
|
||||
@@ -797,46 +794,19 @@ async fn build_state_off_runtime(
|
||||
fn build_state_with_transport(
|
||||
config_path: Option<PathBuf>,
|
||||
auth_token: Option<String>,
|
||||
transport: AppTransport,
|
||||
_transport: AppTransport,
|
||||
) -> Result<AppState> {
|
||||
let has_explicit_config_path = config_path.is_some();
|
||||
let store = ConfigStore::load(config_path)?;
|
||||
let config_path = has_explicit_config_path.then(|| store.path().to_path_buf());
|
||||
let config = store.config.clone();
|
||||
let registry = ModelRegistry::default();
|
||||
|
||||
let state_db_path = config_path
|
||||
.as_ref()
|
||||
.and_then(|p| p.parent().map(|parent| parent.join("state.db")));
|
||||
let state_store = StateStore::open(state_db_path)?;
|
||||
|
||||
let mut hooks = HookDispatcher::default();
|
||||
// Stdio carries JSON-RPC on stdout: printing raw hook events there
|
||||
// corrupts the protocol stream (#5165). HTTP mode keeps the stdout
|
||||
// sink for local development visibility.
|
||||
if transport == AppTransport::Http {
|
||||
hooks.add_sink(Arc::new(StdoutHookSink));
|
||||
}
|
||||
// The hook log sits beside the state database: next to an explicit
|
||||
// config, otherwise in the directory the state store resolved under the
|
||||
// Codewhale home. Never relative to the process cwd (#6513).
|
||||
let hook_log_path = state_store
|
||||
.db_path()
|
||||
.parent()
|
||||
.unwrap_or_else(|| Path::new("."))
|
||||
.join("events.jsonl");
|
||||
hooks.add_sink(Arc::new(JsonlHookSink::new(hook_log_path)));
|
||||
|
||||
if let Some(socket_path) = config
|
||||
.hook_sinks
|
||||
.as_ref()
|
||||
.and_then(|sinks| sinks.unix_socket_path.as_ref())
|
||||
.filter(|path| !path.as_os_str().is_empty())
|
||||
{
|
||||
hooks.add_sink(Arc::new(UnixSocketHookSink::new(socket_path.clone())));
|
||||
}
|
||||
|
||||
let runtime = Runtime::new(config.clone(), state_store, hooks);
|
||||
let runtime = Runtime::new(config.clone(), state_store);
|
||||
|
||||
Ok(AppState {
|
||||
captured_owner: None,
|
||||
@@ -846,7 +816,6 @@ fn build_state_with_transport(
|
||||
config_path,
|
||||
config: Arc::new(RwLock::new(config)),
|
||||
runtime: Arc::new(RwLock::new(runtime)),
|
||||
registry,
|
||||
auth_token,
|
||||
#[cfg(test)]
|
||||
runtime_bridge: Arc::new(Mutex::new(None)),
|
||||
|
||||
@@ -111,7 +111,14 @@ pub(crate) async fn runtime_app_models(state: &AppState) -> Result<Vec<Value>> {
|
||||
providers.len() <= 256,
|
||||
"Runtime provider catalog exceeds its limit"
|
||||
);
|
||||
let aliases = state.registry.list();
|
||||
let aliases = codewhale_config::catalog::reviewed::bundled_reviewed()
|
||||
.selections
|
||||
.iter()
|
||||
.filter_map(|row| {
|
||||
codewhale_config::ProviderKind::parse_config_identity(&row.provider)
|
||||
.map(|provider| (provider, row))
|
||||
})
|
||||
.collect::<Vec<_>>();
|
||||
let mut models = Vec::new();
|
||||
let mut routes = std::collections::HashSet::new();
|
||||
for provider in providers {
|
||||
@@ -149,13 +156,13 @@ pub(crate) async fn runtime_app_models(state: &AppState) -> Result<Vec<Value>> {
|
||||
.context("Runtime model identity is invalid")?;
|
||||
let compatibility_aliases = aliases
|
||||
.iter()
|
||||
.find(|entry| {
|
||||
.find(|(provider, row)| {
|
||||
parsed != codewhale_config::ProviderKind::Custom
|
||||
&& provider_id.is_none_or(|identity| identity == kind)
|
||||
&& entry.provider == parsed
|
||||
&& entry.id == id
|
||||
&& *provider == parsed
|
||||
&& row.id == id
|
||||
})
|
||||
.map(|entry| entry.aliases.clone())
|
||||
.map(|(_, row)| row.aliases.clone())
|
||||
.unwrap_or_default();
|
||||
let capabilities: codewhale_config::route::RouteCapabilities =
|
||||
match model.pointer("/facts/capabilities") {
|
||||
|
||||
@@ -129,6 +129,7 @@ mod members;
|
||||
mod memory_lens;
|
||||
mod mobile;
|
||||
mod plans;
|
||||
mod plugin_index;
|
||||
mod plugins;
|
||||
pub(crate) mod review;
|
||||
mod secrets;
|
||||
@@ -386,7 +387,7 @@ impl RuntimeWorkspaceScopes {
|
||||
let owner = self.clone();
|
||||
codewhale_runtime::runtime_control::owner_work(move || {
|
||||
let (canonical, directory) =
|
||||
codewhale_util::workspace_dir::open_workspace_directory(&lexical)?;
|
||||
codewhale_util::workspace_dir::open_pinned_workspace_directory(&lexical)?;
|
||||
let directory = Arc::new(directory);
|
||||
let mut scopes = owner.scopes.lock();
|
||||
if let Some(scope) = scopes.get(&lexical) {
|
||||
@@ -3372,6 +3373,7 @@ pub fn build_router(state: RuntimeApiState) -> Router {
|
||||
.route("/v1/skills/{name}/audit", get(audit_skill_api))
|
||||
.route("/v1/apps/mcp/tools", get(list_mcp_tools))
|
||||
.route("/v1/apps/plugins", get(plugins::list_plugins))
|
||||
.route("/v1/apps/plugin-index", get(plugin_index::get_plugin_index))
|
||||
.route("/v1/apps/avatars", get(avatars::list_avatars))
|
||||
.route(
|
||||
"/v1/apps/avatars/{handle}/atlases/{page}",
|
||||
@@ -5875,6 +5877,10 @@ struct CommandCatalogEntry {
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
origin: Option<String>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
plugin_id: Option<String>,
|
||||
#[serde(skip_serializing_if = "std::ops::Not::not")]
|
||||
workspace_sourced: bool,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
registration_id: Option<String>,
|
||||
}
|
||||
|
||||
@@ -5933,6 +5939,8 @@ fn command_catalog(
|
||||
shadowed_by,
|
||||
shadowed_aliases,
|
||||
origin: None,
|
||||
plugin_id: None,
|
||||
workspace_sourced: false,
|
||||
registration_id: None,
|
||||
});
|
||||
}
|
||||
@@ -5956,6 +5964,8 @@ fn command_catalog(
|
||||
shadowed_by: None,
|
||||
shadowed_aliases: Vec::new(),
|
||||
origin: None,
|
||||
plugin_id: command.plugin_id.clone(),
|
||||
workspace_sourced: command.workspace_sourced,
|
||||
registration_id: None,
|
||||
});
|
||||
}
|
||||
@@ -6038,6 +6048,8 @@ async fn list_commands(
|
||||
shadowed_by: None,
|
||||
shadowed_aliases: Vec::new(),
|
||||
origin: Some(reference.origin.clone()),
|
||||
plugin_id: Some(reference.plugin_id.clone()),
|
||||
workspace_sourced: false,
|
||||
registration_id: query
|
||||
.thread_id
|
||||
.as_deref()
|
||||
|
||||
@@ -0,0 +1,489 @@
|
||||
use std::collections::{BTreeSet, HashMap};
|
||||
use std::path::{Path as FsPath, PathBuf};
|
||||
|
||||
use axum::Json;
|
||||
use axum::extract::{Query, State};
|
||||
use serde::Serialize;
|
||||
use serde_json::Value;
|
||||
|
||||
use super::plugins::{self, PluginSummaryEntry};
|
||||
use super::{ApiError, CommandsQuery, HooksQuery, RuntimeApiState};
|
||||
|
||||
const MAX_ADDED_NAMES: usize = 512;
|
||||
|
||||
#[derive(Debug, Serialize)]
|
||||
pub(super) struct PluginIndexResponse {
|
||||
workspace: String,
|
||||
items: Vec<IndexItem>,
|
||||
unavailable: Vec<IndexNote>,
|
||||
problems: Vec<IndexNote>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Serialize)]
|
||||
struct IndexNote {
|
||||
kind: &'static str,
|
||||
message: String,
|
||||
}
|
||||
|
||||
#[derive(Debug, Serialize)]
|
||||
struct IndexItem {
|
||||
id: String,
|
||||
kind: &'static str,
|
||||
name: String,
|
||||
description: Option<String>,
|
||||
source: &'static str,
|
||||
state: &'static str,
|
||||
labels: Vec<&'static str>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
plugin: Option<String>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
adds: Option<PluginAdds>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
tier: Option<&'static str>,
|
||||
owner: &'static str,
|
||||
row: Value,
|
||||
}
|
||||
|
||||
#[derive(Debug, Default, Serialize)]
|
||||
struct PluginAdds {
|
||||
skills: Vec<String>,
|
||||
connectors: Vec<String>,
|
||||
hooks: Vec<String>,
|
||||
commands: Vec<String>,
|
||||
profiles: Vec<String>,
|
||||
}
|
||||
|
||||
impl PluginAdds {
|
||||
fn labels(&self, entry: &PluginSummaryEntry) -> Vec<&'static str> {
|
||||
[
|
||||
("skill", !self.skills.is_empty()),
|
||||
("connector", !self.connectors.is_empty()),
|
||||
("hook", !self.hooks.is_empty()),
|
||||
("command", !self.commands.is_empty()),
|
||||
(
|
||||
"tool",
|
||||
entry.inventory.native > 0 || entry.inventory.lsp > 0,
|
||||
),
|
||||
("profile", !self.profiles.is_empty()),
|
||||
]
|
||||
.into_iter()
|
||||
.filter_map(|(label, present)| present.then_some(label))
|
||||
.collect()
|
||||
}
|
||||
}
|
||||
|
||||
fn row_value<T: Serialize>(row: &T) -> Value {
|
||||
serde_json::to_value(row).unwrap_or(Value::Null)
|
||||
}
|
||||
|
||||
fn note_failure(unavailable: &mut Vec<IndexNote>, kind: &'static str, error: &ApiError) {
|
||||
unavailable.push(IndexNote {
|
||||
kind,
|
||||
message: error.message.clone(),
|
||||
});
|
||||
}
|
||||
|
||||
fn plugin_source(origin: &str) -> &'static str {
|
||||
match origin {
|
||||
"codewhale-builtin" => "built_in",
|
||||
"workspace-codewhale" => "project",
|
||||
_ => "user",
|
||||
}
|
||||
}
|
||||
|
||||
fn plugin_state(entry: &PluginSummaryEntry) -> &'static str {
|
||||
if matches!(
|
||||
entry.trust_status,
|
||||
"content-changed" | "capabilities-changed"
|
||||
) || entry.state == "enabled-untrusted"
|
||||
{
|
||||
return "needs_review";
|
||||
}
|
||||
match entry.state {
|
||||
"active" => "enabled",
|
||||
"disabled" => "disabled",
|
||||
_ => "unavailable",
|
||||
}
|
||||
}
|
||||
|
||||
fn add_stem(names: &mut BTreeSet<String>, path: &FsPath, extension: Option<&str>, lowercase: bool) {
|
||||
if let Some(wanted) = extension
|
||||
&& path.extension().and_then(|value| value.to_str()) != Some(wanted)
|
||||
{
|
||||
return;
|
||||
}
|
||||
if let Some(stem) = path.file_stem().and_then(|value| value.to_str()) {
|
||||
names.insert(if lowercase {
|
||||
stem.to_lowercase()
|
||||
} else {
|
||||
stem.to_string()
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
async fn component_names(
|
||||
paths: &[PathBuf],
|
||||
extension: Option<&str>,
|
||||
lowercase: bool,
|
||||
omitted: &mut bool,
|
||||
) -> Vec<String> {
|
||||
let mut names = BTreeSet::new();
|
||||
for path in paths {
|
||||
let Ok(meta) = tokio::fs::symlink_metadata(path).await else {
|
||||
continue;
|
||||
};
|
||||
if meta.is_file() {
|
||||
add_stem(&mut names, path, extension, lowercase);
|
||||
} else if meta.is_dir()
|
||||
&& let Ok(mut entries) = tokio::fs::read_dir(path).await
|
||||
{
|
||||
let mut seen = 0;
|
||||
while let Ok(Some(entry)) = entries.next_entry().await {
|
||||
seen += 1;
|
||||
if seen > MAX_ADDED_NAMES {
|
||||
*omitted = true;
|
||||
break;
|
||||
}
|
||||
if entry.file_type().await.is_ok_and(|kind| kind.is_file()) {
|
||||
add_stem(&mut names, &entry.path(), extension, lowercase);
|
||||
}
|
||||
}
|
||||
}
|
||||
if names.len() >= MAX_ADDED_NAMES {
|
||||
*omitted = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
if names.iter().any(|name| name.chars().any(char::is_control)) {
|
||||
*omitted = true;
|
||||
names.retain(|name| !name.chars().any(char::is_control));
|
||||
}
|
||||
names.into_iter().take(MAX_ADDED_NAMES).collect()
|
||||
}
|
||||
|
||||
async fn plugin_adds(
|
||||
plugin: &codewhale_plugins::types::LoadedPlugin,
|
||||
omitted: &mut bool,
|
||||
) -> PluginAdds {
|
||||
let mut skills: Vec<String> = plugin
|
||||
.skill_snapshots
|
||||
.iter()
|
||||
.map(|skill| skill.name.clone())
|
||||
.collect();
|
||||
skills.sort();
|
||||
let mut connectors: Vec<String> = plugin
|
||||
.manifest
|
||||
.mcp_servers
|
||||
.as_ref()
|
||||
.map(|servers| servers.keys().cloned().collect())
|
||||
.unwrap_or_default();
|
||||
connectors.sort();
|
||||
PluginAdds {
|
||||
skills,
|
||||
connectors,
|
||||
hooks: component_names(&plugin.components.hooks, None, false, omitted).await,
|
||||
commands: component_names(&plugin.components.commands, Some("md"), true, omitted).await,
|
||||
profiles: component_names(&plugin.components.agents, Some("toml"), false, omitted).await,
|
||||
}
|
||||
}
|
||||
|
||||
async fn plugin_adds_by_id(
|
||||
state: &RuntimeApiState,
|
||||
omitted: &mut BTreeSet<String>,
|
||||
) -> HashMap<String, PluginAdds> {
|
||||
let registry = state
|
||||
.plugin_discovery
|
||||
.registry_for_workspace(&state.workspace);
|
||||
let mut adds = HashMap::new();
|
||||
for plugin in registry.list() {
|
||||
let mut cut = false;
|
||||
adds.insert(
|
||||
plugin.id.as_str().to_string(),
|
||||
plugin_adds(plugin, &mut cut).await,
|
||||
);
|
||||
if cut {
|
||||
omitted.insert(plugin.name().to_string());
|
||||
}
|
||||
}
|
||||
adds
|
||||
}
|
||||
|
||||
fn skill_source(
|
||||
path: Option<&PathBuf>,
|
||||
is_bundled: bool,
|
||||
skills_dir: &FsPath,
|
||||
workspace: &FsPath,
|
||||
) -> &'static str {
|
||||
if is_bundled {
|
||||
return "built_in";
|
||||
}
|
||||
match path {
|
||||
Some(path) if path.starts_with(skills_dir) => "user",
|
||||
Some(path) if path.starts_with(workspace) => "project",
|
||||
Some(_) => "other_app",
|
||||
None => "plugin",
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) async fn get_plugin_index(
|
||||
State(state): State<RuntimeApiState>,
|
||||
) -> Result<Json<PluginIndexResponse>, ApiError> {
|
||||
let mut items = Vec::new();
|
||||
let mut unavailable = Vec::new();
|
||||
let mut problems = Vec::new();
|
||||
|
||||
let commands = super::list_commands(
|
||||
State(state.clone()),
|
||||
Query(CommandsQuery { thread_id: None }),
|
||||
)
|
||||
.await;
|
||||
let mut plugin_commands: HashMap<String, BTreeSet<String>> = HashMap::new();
|
||||
if let Ok(Json(response)) = &commands {
|
||||
for command in &response.commands {
|
||||
if let (Some(plugin_id), "user") = (command.plugin_id.as_ref(), command.kind) {
|
||||
plugin_commands
|
||||
.entry(plugin_id.clone())
|
||||
.or_default()
|
||||
.insert(command.name.clone());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
match plugins::list_plugins(State(state.clone())).await {
|
||||
Ok(Json(response)) => {
|
||||
let mut omitted = BTreeSet::new();
|
||||
let mut adds_by_id = plugin_adds_by_id(&state, &mut omitted).await;
|
||||
for name in &omitted {
|
||||
problems.push(IndexNote {
|
||||
kind: "plugin",
|
||||
message: format!(
|
||||
"plugin '{name}' adds more files than are listed, or a file name with control characters; some names are left out of `adds`"
|
||||
),
|
||||
});
|
||||
}
|
||||
for diagnostic in &response.registry_diagnostics {
|
||||
problems.push(IndexNote {
|
||||
kind: "plugin",
|
||||
message: diagnostic.message.clone(),
|
||||
});
|
||||
}
|
||||
for entry in &response.plugins {
|
||||
let mut adds = adds_by_id.remove(&entry.id);
|
||||
if entry.state == "active"
|
||||
&& commands.is_ok()
|
||||
&& let Some(adds) = adds.as_mut()
|
||||
{
|
||||
adds.commands = plugin_commands
|
||||
.remove(&entry.id)
|
||||
.map(|names| names.into_iter().collect())
|
||||
.unwrap_or_default();
|
||||
}
|
||||
items.push(IndexItem {
|
||||
id: format!("plugin:{}", entry.id),
|
||||
kind: "plugin",
|
||||
name: entry
|
||||
.display_name
|
||||
.clone()
|
||||
.unwrap_or_else(|| entry.name.clone()),
|
||||
description: entry.description.clone(),
|
||||
source: plugin_source(entry.origin),
|
||||
state: plugin_state(entry),
|
||||
labels: adds
|
||||
.as_ref()
|
||||
.map(|adds| adds.labels(entry))
|
||||
.unwrap_or_default(),
|
||||
plugin: None,
|
||||
adds,
|
||||
tier: None,
|
||||
owner: "/v1/apps/plugins",
|
||||
row: row_value(entry),
|
||||
});
|
||||
}
|
||||
}
|
||||
Err(error) => note_failure(&mut unavailable, "plugin", &error),
|
||||
}
|
||||
|
||||
match plugins::list_plugin_catalog(State(state.clone())).await {
|
||||
Ok(Json(catalog)) => {
|
||||
for (tier, rows) in [
|
||||
("builtin", &catalog.builtin),
|
||||
("experimental", &catalog.experimental),
|
||||
("more", &catalog.more),
|
||||
] {
|
||||
for row in rows {
|
||||
items.push(IndexItem {
|
||||
id: format!("plugin:catalog:{}", row.id),
|
||||
kind: "plugin",
|
||||
name: row.title.clone(),
|
||||
description: row.description.clone(),
|
||||
source: "built_in",
|
||||
state: if !row.available {
|
||||
"unavailable"
|
||||
} else if row.enabled {
|
||||
"enabled"
|
||||
} else {
|
||||
"disabled"
|
||||
},
|
||||
labels: Vec::new(),
|
||||
plugin: None,
|
||||
adds: None,
|
||||
tier: Some(tier),
|
||||
owner: "/v1/apps/plugins/catalog",
|
||||
row: row_value(row),
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
Err(error) => note_failure(&mut unavailable, "plugin", &error),
|
||||
}
|
||||
|
||||
match super::list_skills(State(state.clone())).await {
|
||||
Ok(Json(response)) => {
|
||||
for warning in &response.warnings {
|
||||
problems.push(IndexNote {
|
||||
kind: "skill",
|
||||
message: warning.clone(),
|
||||
});
|
||||
}
|
||||
for skill in &response.skills {
|
||||
if skill.plugin_id.is_some() {
|
||||
continue;
|
||||
}
|
||||
items.push(IndexItem {
|
||||
id: format!("skill:{}", skill.name),
|
||||
kind: "skill",
|
||||
name: skill.name.clone(),
|
||||
description: Some(skill.description.clone()),
|
||||
source: skill_source(
|
||||
skill.path.as_ref(),
|
||||
skill.is_bundled,
|
||||
&response.directory,
|
||||
&state.workspace,
|
||||
),
|
||||
state: if skill.enabled { "enabled" } else { "disabled" },
|
||||
labels: vec!["skill"],
|
||||
plugin: None,
|
||||
adds: None,
|
||||
tier: None,
|
||||
owner: "/v1/skills",
|
||||
row: row_value(skill),
|
||||
});
|
||||
}
|
||||
}
|
||||
Err(error) => note_failure(&mut unavailable, "skill", &error),
|
||||
}
|
||||
|
||||
match super::list_mcp_servers(State(state.clone())).await {
|
||||
Ok(Json(response)) => {
|
||||
for server in &response.servers {
|
||||
let source = match server.origin {
|
||||
"plugin" => continue,
|
||||
"project" => "project",
|
||||
"runtime" => "runtime",
|
||||
_ => "user",
|
||||
};
|
||||
items.push(IndexItem {
|
||||
id: format!("connector:{}", server.name),
|
||||
kind: "connector",
|
||||
name: server.name.clone(),
|
||||
description: None,
|
||||
source,
|
||||
state: if !server.enabled {
|
||||
"disabled"
|
||||
} else if server.auth_required {
|
||||
"needs_sign_in"
|
||||
} else {
|
||||
"enabled"
|
||||
},
|
||||
labels: vec!["connector"],
|
||||
plugin: None,
|
||||
adds: None,
|
||||
tier: None,
|
||||
owner: "/v1/apps/mcp/servers",
|
||||
row: row_value(server),
|
||||
});
|
||||
}
|
||||
}
|
||||
Err(error) => note_failure(&mut unavailable, "connector", &error),
|
||||
}
|
||||
|
||||
match super::list_hooks(State(state.clone()), Query(HooksQuery { thread_id: None })).await {
|
||||
Ok(Json(response)) => {
|
||||
for problem in &response.problems {
|
||||
problems.push(IndexNote {
|
||||
kind: "hook",
|
||||
message: problem.clone(),
|
||||
});
|
||||
}
|
||||
let mut ordinals: HashMap<&'static str, usize> = HashMap::new();
|
||||
for hook in &response.hooks {
|
||||
let ordinal = ordinals.entry(hook.event).or_default();
|
||||
*ordinal += 1;
|
||||
let source = match hook.source {
|
||||
"plugin" => continue,
|
||||
"project" => "project",
|
||||
_ => "user",
|
||||
};
|
||||
let name = hook
|
||||
.name
|
||||
.clone()
|
||||
.unwrap_or_else(|| format!("{} {}", hook.event, ordinal));
|
||||
items.push(IndexItem {
|
||||
id: format!("hook:{source}:{}:{ordinal}", hook.event),
|
||||
kind: "hook",
|
||||
name,
|
||||
description: None,
|
||||
source,
|
||||
state: if response.enabled {
|
||||
"enabled"
|
||||
} else {
|
||||
"disabled"
|
||||
},
|
||||
labels: vec!["hook"],
|
||||
plugin: None,
|
||||
adds: None,
|
||||
tier: None,
|
||||
owner: "/v1/hooks",
|
||||
row: row_value(hook),
|
||||
});
|
||||
}
|
||||
}
|
||||
Err(error) => note_failure(&mut unavailable, "hook", &error),
|
||||
}
|
||||
|
||||
match commands {
|
||||
Ok(Json(response)) => {
|
||||
for command in &response.commands {
|
||||
let (source, plugin) = match (command.kind, command.plugin_id.as_ref()) {
|
||||
("builtin", _) => continue,
|
||||
("user", Some(_)) => continue,
|
||||
("extension", plugin_id) => ("plugin", plugin_id.cloned()),
|
||||
_ if command.workspace_sourced => ("project", None),
|
||||
_ => ("user", None),
|
||||
};
|
||||
items.push(IndexItem {
|
||||
id: format!("command:{}", command.name),
|
||||
kind: "command",
|
||||
name: command.name.clone(),
|
||||
description: command.summary.clone(),
|
||||
source,
|
||||
state: "enabled",
|
||||
labels: vec!["command"],
|
||||
plugin,
|
||||
adds: None,
|
||||
tier: None,
|
||||
owner: "/v1/commands",
|
||||
row: row_value(command),
|
||||
});
|
||||
}
|
||||
}
|
||||
Err(error) => note_failure(&mut unavailable, "command", &error),
|
||||
}
|
||||
|
||||
Ok(Json(PluginIndexResponse {
|
||||
workspace: state.workspace.display().to_string(),
|
||||
items,
|
||||
unavailable,
|
||||
problems,
|
||||
}))
|
||||
}
|
||||
@@ -15,6 +15,7 @@ use tokio::sync::{Mutex, mpsc, oneshot};
|
||||
use tokio::time::sleep;
|
||||
use uuid::Uuid;
|
||||
|
||||
mod catalog_parity;
|
||||
mod command_catalog;
|
||||
#[cfg(unix)]
|
||||
mod control_socket_selection;
|
||||
@@ -28,6 +29,7 @@ mod headless_catalog;
|
||||
mod member_operations;
|
||||
#[cfg(unix)]
|
||||
mod owner_bootstrap;
|
||||
mod plugin_index;
|
||||
mod plugin_ui;
|
||||
mod profile_constitution;
|
||||
#[cfg(any(unix, windows))]
|
||||
|
||||
@@ -0,0 +1,600 @@
|
||||
use super::*;
|
||||
use codewhale_config::catalog::{
|
||||
CatalogOffering, CatalogSource, CatalogStatus, ProviderCatalogDelta, base_url_fingerprint,
|
||||
now_unix,
|
||||
};
|
||||
use codewhale_engine::cost_status::EffectiveRouteEnvelope;
|
||||
use codewhale_engine::model_inventory::ModelInventory;
|
||||
use codewhale_runtime::config::ProviderIdentity;
|
||||
use sha2::{Digest, Sha256};
|
||||
use std::collections::BTreeMap;
|
||||
|
||||
const SINGULAR: &str = "model list / model resolve";
|
||||
const PLURAL: &str = "models";
|
||||
const RUNTIME: &str = "runtime api";
|
||||
const ROUTING: &str = "routing inventory";
|
||||
const COST: &str = "cost";
|
||||
const UNKNOWN: &str = "unknown";
|
||||
|
||||
const ROSTER: &[&str] = &["claude-opus-5", "claude-haiku-4-5", "claude-parity-probe-1"];
|
||||
|
||||
type Readings = BTreeMap<(String, String, &'static str), BTreeMap<&'static str, String>>;
|
||||
|
||||
struct Route {
|
||||
label: &'static str,
|
||||
api_path: &'static str,
|
||||
identity: ProviderIdentity,
|
||||
base_url: String,
|
||||
models: &'static [&'static str],
|
||||
}
|
||||
|
||||
fn cold_process() {
|
||||
codewhale_engine::provider_catalog_live::reset_cache_for_test();
|
||||
codewhale_engine::provider_lake::clear_live_snapshot();
|
||||
}
|
||||
|
||||
fn known<T: ToString>(value: Option<T>) -> String {
|
||||
value.map_or_else(|| UNKNOWN.to_string(), |value| value.to_string())
|
||||
}
|
||||
|
||||
fn rate(value: &Value) -> String {
|
||||
let number = match value {
|
||||
Value::Number(number) => number.as_f64(),
|
||||
Value::String(text) => text.parse::<f64>().ok(),
|
||||
_ => None,
|
||||
};
|
||||
known(number)
|
||||
}
|
||||
|
||||
fn roster(mut models: Vec<String>) -> String {
|
||||
models.sort();
|
||||
models.dedup();
|
||||
models.join(",")
|
||||
}
|
||||
|
||||
fn read(
|
||||
readings: &mut Readings,
|
||||
route: &Route,
|
||||
model: &str,
|
||||
field: &'static str,
|
||||
surface: &'static str,
|
||||
value: String,
|
||||
) {
|
||||
readings
|
||||
.entry((route.label.to_string(), model.to_string(), field))
|
||||
.or_default()
|
||||
.insert(surface, value);
|
||||
}
|
||||
|
||||
fn persist_id_only_roster(identity: &ProviderIdentity, base_url: &str) {
|
||||
let fingerprint = base_url_fingerprint(base_url);
|
||||
let fetched_at = now_unix();
|
||||
let ticket = codewhale_engine::provider_catalog_live::begin_refresh_for_identity(
|
||||
identity.provider,
|
||||
identity.key.as_str(),
|
||||
base_url,
|
||||
);
|
||||
assert_eq!(
|
||||
codewhale_engine::provider_catalog_live::record_success_if_current(
|
||||
&ticket,
|
||||
ProviderCatalogDelta {
|
||||
provider: identity.key.to_string(),
|
||||
base_url_fingerprint: fingerprint.clone(),
|
||||
fetched_at,
|
||||
offerings: ROSTER
|
||||
.iter()
|
||||
.map(|id| CatalogOffering {
|
||||
provider: identity.key.to_string(),
|
||||
wire_model_id: (*id).to_string(),
|
||||
endpoint_key: "chat".into(),
|
||||
source: CatalogSource::Live {
|
||||
base_url_fingerprint: fingerprint.clone(),
|
||||
fetched_at,
|
||||
},
|
||||
..Default::default()
|
||||
})
|
||||
.collect(),
|
||||
},
|
||||
),
|
||||
Some(CatalogStatus::Fresh)
|
||||
);
|
||||
}
|
||||
|
||||
fn read_singular(readings: &mut Readings, config_path: &Path, route: &Route) -> Result<()> {
|
||||
cold_process();
|
||||
let store = codewhale_config::ConfigStore::load(Some(config_path.to_path_buf()))?;
|
||||
let listed =
|
||||
codewhale_engine::route_preferences::list_models(&store, Some(route.identity.provider))?
|
||||
.into_iter()
|
||||
.find(|(listed, _)| listed == route.identity.key.as_str())
|
||||
.map(|(_, models)| roster(models));
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
"*",
|
||||
"roster",
|
||||
SINGULAR,
|
||||
listed.unwrap_or_else(|| "route not listed".into()),
|
||||
);
|
||||
for model in route.models {
|
||||
let limits = codewhale_engine::route_preferences::resolve_model(
|
||||
config_path,
|
||||
route.identity.key.as_str(),
|
||||
&route.base_url,
|
||||
Some(model),
|
||||
)
|
||||
.map(|candidate| candidate.limits());
|
||||
let (context, output) = match limits {
|
||||
Ok(limits) => (known(limits.context_tokens), known(limits.output_tokens)),
|
||||
Err(error) => (format!("refused: {error}"), format!("refused: {error}")),
|
||||
};
|
||||
read(readings, route, model, "limit.context", SINGULAR, context);
|
||||
read(readings, route, model, "limit.output", SINGULAR, output);
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn read_plural(readings: &mut Readings, config: &Config, route: &Route) -> Result<()> {
|
||||
cold_process();
|
||||
codewhale_engine::models_dev_live::maybe_load_persisted_cache();
|
||||
let mut route_config = config.clone();
|
||||
route_config
|
||||
.scope_to_provider_identity(&route.identity)
|
||||
.map_err(anyhow::Error::msg)?;
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
"*",
|
||||
"roster",
|
||||
PLURAL,
|
||||
roster(codewhale_engine::provider_lake::listed_models_for_route(
|
||||
&route_config,
|
||||
&route.identity,
|
||||
)),
|
||||
);
|
||||
Ok(())
|
||||
}
|
||||
|
||||
async fn read_runtime(
|
||||
readings: &mut Readings,
|
||||
client: &reqwest::Client,
|
||||
addr: &SocketAddr,
|
||||
route: &Route,
|
||||
) -> Result<()> {
|
||||
let body: Value = client
|
||||
.get(format!("http://{addr}/v1/providers/{}", route.api_path))
|
||||
.send()
|
||||
.await?
|
||||
.error_for_status()?
|
||||
.json()
|
||||
.await?;
|
||||
let models = body["models"].as_array().context("models array")?;
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
"*",
|
||||
"roster",
|
||||
RUNTIME,
|
||||
roster(
|
||||
models
|
||||
.iter()
|
||||
.filter_map(|model| model["id"].as_str().map(str::to_string))
|
||||
.collect(),
|
||||
),
|
||||
);
|
||||
for model in route.models {
|
||||
let facts = models
|
||||
.iter()
|
||||
.find(|entry| entry["id"] == *model)
|
||||
.map_or(&Value::Null, |entry| &entry["facts"]);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"limit.context",
|
||||
RUNTIME,
|
||||
known(facts["effective_limits"]["context_tokens"].as_u64()),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"limit.output",
|
||||
RUNTIME,
|
||||
known(facts["effective_limits"]["output_tokens"].as_u64()),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"window",
|
||||
RUNTIME,
|
||||
known(facts["effective_context"]["tokens"].as_u64()),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"window.source",
|
||||
RUNTIME,
|
||||
known(facts["effective_context"]["source"].as_str()),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"price.input",
|
||||
RUNTIME,
|
||||
rate(&facts["pricing"]["input_per_million"]),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"price.output",
|
||||
RUNTIME,
|
||||
rate(&facts["pricing"]["output_per_million"]),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"price.basis",
|
||||
RUNTIME,
|
||||
format!(
|
||||
"provenance={} status={} source={}",
|
||||
facts["pricing"]["provenance"], facts["pricing_status"], facts["source"]
|
||||
),
|
||||
);
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn read_routing(readings: &mut Readings, config: &Config, route: &Route) -> Result<()> {
|
||||
let inventory = ModelInventory::from_config(config).map_err(anyhow::Error::msg)?;
|
||||
let candidates: Vec<_> = inventory
|
||||
.candidates
|
||||
.iter()
|
||||
.filter(|candidate| candidate.identity == route.identity)
|
||||
.collect();
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
"*",
|
||||
"roster",
|
||||
ROUTING,
|
||||
roster(
|
||||
candidates
|
||||
.iter()
|
||||
.map(|candidate| candidate.model.clone())
|
||||
.collect(),
|
||||
),
|
||||
);
|
||||
for model in route.models {
|
||||
let candidate = candidates
|
||||
.iter()
|
||||
.find(|candidate| candidate.model == *model);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"window",
|
||||
ROUTING,
|
||||
known(candidate.map(|candidate| candidate.context_window)),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"window.source",
|
||||
ROUTING,
|
||||
known(candidate.map(|candidate| {
|
||||
if candidate.context_window_unverified {
|
||||
"unverified"
|
||||
} else {
|
||||
"verified"
|
||||
}
|
||||
})),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"limit.output",
|
||||
ROUTING,
|
||||
known(candidate.and_then(|candidate| candidate.max_output)),
|
||||
);
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn read_cost(readings: &mut Readings, config: &Config, route: &Route) {
|
||||
let usage = Usage {
|
||||
input_tokens: 100_000,
|
||||
output_tokens: 10_000,
|
||||
..Default::default()
|
||||
};
|
||||
for model in route.models {
|
||||
let envelope = EffectiveRouteEnvelope::from_admitted(
|
||||
Some(config),
|
||||
&route.identity,
|
||||
*model,
|
||||
Some(&route.base_url),
|
||||
chrono::Utc::now(),
|
||||
);
|
||||
let quote = envelope.provider_live_pricing.as_ref();
|
||||
let audit = envelope.audit(&usage);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"price.input",
|
||||
COST,
|
||||
quote
|
||||
.and_then(|quote| quote.input_per_million.as_deref())
|
||||
.map_or_else(|| UNKNOWN.to_string(), |text| rate(&json!(text))),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"price.output",
|
||||
COST,
|
||||
quote
|
||||
.and_then(|quote| quote.output_per_million.as_deref())
|
||||
.map_or_else(|| UNKNOWN.to_string(), |text| rate(&json!(text))),
|
||||
);
|
||||
read(
|
||||
readings,
|
||||
route,
|
||||
model,
|
||||
"price.basis",
|
||||
COST,
|
||||
format!(
|
||||
"provenance={:?} billing={:?} charge_usd={} unpriced={:?}",
|
||||
quote.map(|quote| quote.provenance.clone()),
|
||||
envelope.billing_mode,
|
||||
known(audit.exact_usd.as_deref()),
|
||||
audit.unpriced_reason,
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn one_captured_catalog_reads_the_same_on_every_model_surface() -> Result<()> {
|
||||
let _env = lock_test_env();
|
||||
let _live = codewhale_engine::provider_lake::lock_live_snapshot();
|
||||
let root = tempfile::tempdir()?;
|
||||
let captured = codewhale_config::catalog::BUNDLED_MODELS_DEV_JSON;
|
||||
let catalog_path = root.path().join("captured-models-dev.json");
|
||||
fs::write(&catalog_path, captured)?;
|
||||
let _catalog = EnvVarGuard::set("CODEWHALE_MODELS_DEV_PATH", &catalog_path);
|
||||
let _home = EnvVarGuard::set("CODEWHALE_HOME", root.path());
|
||||
let _config_path = EnvVarGuard::remove("CODEWHALE_CONFIG_PATH");
|
||||
let _legacy_config_path = EnvVarGuard::remove("DEEPSEEK_CONFIG_PATH");
|
||||
let _cli = EnvVarGuard::remove(codewhale_config::CLI_API_KEY_ENV);
|
||||
cold_process();
|
||||
|
||||
let config_path = root.path().join("config.toml");
|
||||
fs::write(
|
||||
&config_path,
|
||||
r#"provider = "anthropic"
|
||||
|
||||
[providers.anthropic]
|
||||
api_key = "parity-fixture-key"
|
||||
model = "claude-opus-5"
|
||||
|
||||
[providers.zai]
|
||||
api_key = "parity-fixture-key"
|
||||
model = "GLM-5.3"
|
||||
|
||||
[providers.lab]
|
||||
kind = "openai-compatible"
|
||||
base_url = "http://127.0.0.1:9/v1"
|
||||
api_key = "parity-fixture-key"
|
||||
model = "claude-haiku-4-5"
|
||||
"#,
|
||||
)?;
|
||||
let config = Config::load(Some(config_path.clone()), None)?;
|
||||
let route = |label: &'static str,
|
||||
api_path: &'static str,
|
||||
key: &str,
|
||||
models: &'static [&'static str]|
|
||||
-> Result<Route> {
|
||||
let identity = config
|
||||
.resolve_provider_pin_identity(key)
|
||||
.map_err(anyhow::Error::msg)?;
|
||||
Ok(Route {
|
||||
label,
|
||||
api_path,
|
||||
base_url: config.base_url_for_route(&identity),
|
||||
identity,
|
||||
models,
|
||||
})
|
||||
};
|
||||
let routes = [
|
||||
route(
|
||||
"anthropic (official, id-only roster)",
|
||||
"anthropic/models",
|
||||
"anthropic",
|
||||
ROSTER,
|
||||
)?,
|
||||
route(
|
||||
"lab (custom endpoint, same spelling)",
|
||||
"custom/models?model_provider_id=lab",
|
||||
"lab",
|
||||
&["claude-haiku-4-5"],
|
||||
)?,
|
||||
route(
|
||||
"zai (plan endpoint)",
|
||||
"zai/models",
|
||||
"zai",
|
||||
&["GLM-5.3", "GLM-5.2"],
|
||||
)?,
|
||||
];
|
||||
|
||||
assert!(
|
||||
codewhale_engine::models_dev_live::refresh(false)
|
||||
.await
|
||||
.map_err(|error| anyhow::anyhow!("{error}"))?
|
||||
> 0
|
||||
);
|
||||
persist_id_only_roster(&routes[0].identity, &routes[0].base_url);
|
||||
|
||||
let mut readings = Readings::new();
|
||||
for route in &routes {
|
||||
read_singular(&mut readings, &config_path, route)?;
|
||||
read_plural(&mut readings, &config, route)?;
|
||||
}
|
||||
cold_process();
|
||||
let (addr, _, handle) = spawn_test_server_with_config_path(config_path.clone())
|
||||
.await?
|
||||
.expect("loopback server required");
|
||||
let client = codewhale_release::tls::reqwest_client();
|
||||
for route in &routes {
|
||||
read_runtime(&mut readings, &client, &addr, route).await?;
|
||||
read_routing(&mut readings, &config, route)?;
|
||||
read_cost(&mut readings, &config, route);
|
||||
}
|
||||
handle.abort();
|
||||
cold_process();
|
||||
|
||||
println!(
|
||||
"PARITY captured_catalog sha256={} bytes={}",
|
||||
Sha256::digest(captured.as_bytes())
|
||||
.iter()
|
||||
.map(|byte| format!("{byte:02x}"))
|
||||
.collect::<String>(),
|
||||
captured.len()
|
||||
);
|
||||
let mut differing = Vec::new();
|
||||
let mut known_differences: Vec<String> = Vec::new();
|
||||
for ((route, model, field), surfaces) in &readings {
|
||||
let mut values: Vec<String> = surfaces
|
||||
.values()
|
||||
.map(|value| {
|
||||
if *field == "roster" {
|
||||
roster(
|
||||
value
|
||||
.to_ascii_lowercase()
|
||||
.split(',')
|
||||
.map(str::to_string)
|
||||
.collect(),
|
||||
)
|
||||
} else {
|
||||
value.clone()
|
||||
}
|
||||
})
|
||||
.collect();
|
||||
values.sort();
|
||||
values.dedup();
|
||||
let compared = !matches!(*field, "price.basis" | "window.source");
|
||||
let borrowed_window = *field == "window"
|
||||
&& surfaces.get(RUNTIME).map(String::as_str) == Some(UNKNOWN)
|
||||
&& readings
|
||||
.get(&(route.clone(), model.clone(), "window.source"))
|
||||
.and_then(|sources| sources.get(ROUTING))
|
||||
.map(String::as_str)
|
||||
== Some("unverified");
|
||||
let verdict = if !compared {
|
||||
"info"
|
||||
} else if borrowed_window {
|
||||
known_differences.push(format!("{route} | {model} | {surfaces:?}"));
|
||||
"KNOWN-DIFFERENCE"
|
||||
} else if values.len() == 1 {
|
||||
"agree"
|
||||
} else {
|
||||
differing.push(format!("{route} | {model} | {field} | {surfaces:?}"));
|
||||
"DIFFER"
|
||||
};
|
||||
println!("PARITY {verdict} | {route} | {model} | {field} | {surfaces:?}");
|
||||
}
|
||||
let value = |route: &Route, model: &str, field: &'static str, surface: &'static str| {
|
||||
readings
|
||||
.get(&(route.label.to_string(), model.to_string(), field))
|
||||
.and_then(|surfaces| surfaces.get(surface))
|
||||
.cloned()
|
||||
.unwrap_or_default()
|
||||
};
|
||||
assert_eq!(
|
||||
value(&routes[0], "*", "roster", SINGULAR),
|
||||
"claude-haiku-4-5,claude-opus-5,claude-parity-probe-1",
|
||||
"the singular command lists the route's own roster, not every bundled row"
|
||||
);
|
||||
assert_eq!(
|
||||
value(&routes[0], "claude-opus-5", "limit.context", RUNTIME),
|
||||
"1000000"
|
||||
);
|
||||
assert_eq!(
|
||||
value(&routes[0], "claude-haiku-4-5", "limit.context", RUNTIME),
|
||||
"200000"
|
||||
);
|
||||
assert_eq!(value(&routes[0], "claude-opus-5", "price.input", COST), "5");
|
||||
assert_eq!(
|
||||
value(&routes[0], "claude-haiku-4-5", "price.output", COST),
|
||||
"5"
|
||||
);
|
||||
for field in ["limit.context", "limit.output", "price.input"] {
|
||||
assert_eq!(
|
||||
value(&routes[1], "claude-haiku-4-5", field, RUNTIME),
|
||||
UNKNOWN,
|
||||
"a custom endpoint borrows no fact from a same-named model: {field}"
|
||||
);
|
||||
}
|
||||
assert_eq!(
|
||||
value(&routes[1], "claude-haiku-4-5", "window.source", ROUTING),
|
||||
"unverified",
|
||||
"routing never presents a same-named model's window as this endpoint's"
|
||||
);
|
||||
assert_eq!(
|
||||
value(&routes[1], "claude-haiku-4-5", "limit.output", ROUTING),
|
||||
UNKNOWN
|
||||
);
|
||||
for model in ["GLM-5.3", "GLM-5.2"] {
|
||||
let basis = value(&routes[2], model, "price.basis", COST);
|
||||
assert!(
|
||||
basis.contains("NotMoneyMetered") && basis.contains("charge_usd=unknown"),
|
||||
"a plan route is never billed per token: {model}: {basis}"
|
||||
);
|
||||
}
|
||||
for (model, rate) in [("GLM-5.3", UNKNOWN), ("GLM-5.2", "1.4")] {
|
||||
for surface in [COST, RUNTIME] {
|
||||
assert_eq!(
|
||||
value(&routes[2], model, "price.input", surface),
|
||||
rate,
|
||||
"the list rate is shown the same everywhere and never turned into a charge: {model} {surface}"
|
||||
);
|
||||
}
|
||||
}
|
||||
let basis = value(&routes[1], "claude-haiku-4-5", "price.basis", COST);
|
||||
assert!(
|
||||
basis.contains("UnknownBillingBasis") && basis.contains("charge_usd=unknown"),
|
||||
"a custom endpoint is never given a charge: {basis}"
|
||||
);
|
||||
for surface in [COST, RUNTIME] {
|
||||
assert_eq!(
|
||||
value(&routes[0], "claude-parity-probe-1", "price.input", surface),
|
||||
UNKNOWN,
|
||||
"a metered first-party model with no price row reads unknown: {surface}"
|
||||
);
|
||||
}
|
||||
let basis = value(&routes[0], "claude-parity-probe-1", "price.basis", COST);
|
||||
assert!(
|
||||
basis.contains("charge_usd=unknown") && !basis.contains("unpriced=None"),
|
||||
"an unpriced model produces no charge and says why: {basis}"
|
||||
);
|
||||
assert_eq!(
|
||||
known_differences,
|
||||
vec![
|
||||
"lab (custom endpoint, same spelling) | claude-haiku-4-5 | {\"routing inventory\": \"200000\", \"runtime api\": \"unknown\"}"
|
||||
],
|
||||
"the only named difference is the custom endpoint's borrowed routing window"
|
||||
);
|
||||
assert!(
|
||||
differing.is_empty(),
|
||||
"surfaces disagree on the same captured catalog:\n{}",
|
||||
differing.join("\n")
|
||||
);
|
||||
Ok(())
|
||||
}
|
||||
@@ -28,6 +28,8 @@ fn user(name: &str) -> UserCommand {
|
||||
takes_arguments: false,
|
||||
hidden: false,
|
||||
extension: false,
|
||||
plugin_id: None,
|
||||
workspace_sourced: false,
|
||||
builtin_bindings: vec![name.to_string()],
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,219 @@
|
||||
use super::*;
|
||||
use codewhale_engine::command_catalog::{BuiltinCommand, CommandCatalog, UserCommand};
|
||||
|
||||
struct Catalog(Arc<std::sync::Mutex<Option<String>>>);
|
||||
|
||||
impl CommandCatalog for Catalog {
|
||||
fn answers_to(&self, _name: &str) -> bool {
|
||||
false
|
||||
}
|
||||
fn builtins(&self) -> Vec<BuiltinCommand> {
|
||||
Vec::new()
|
||||
}
|
||||
fn user_commands(&self, _workspace: &Path) -> Vec<UserCommand> {
|
||||
let plugin_id = self.0.lock().expect("plugin id").clone();
|
||||
let command = |name: &str, plugin: Option<String>| UserCommand {
|
||||
name: name.to_string(),
|
||||
aliases: Vec::new(),
|
||||
description: Some("A command.".to_string()),
|
||||
usage: None,
|
||||
takes_arguments: false,
|
||||
hidden: false,
|
||||
extension: false,
|
||||
plugin_id: plugin,
|
||||
workspace_sourced: false,
|
||||
builtin_bindings: Vec::new(),
|
||||
};
|
||||
vec![command("mine", None), command("ship", plugin_id)]
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn the_index_lists_every_kind_once_and_a_plugin_carries_what_it_adds() -> Result<()> {
|
||||
let _env = lock_test_env();
|
||||
let temp = tempfile::tempdir()?;
|
||||
let root = temp.path().join("index-route");
|
||||
let workspace = root.join("workspace");
|
||||
fs::create_dir_all(&workspace)?;
|
||||
let plugin_id = Arc::new(std::sync::Mutex::new(None));
|
||||
let _catalog = codewhale_engine::command_catalog::CatalogGuard::install(Arc::new(Catalog(
|
||||
plugin_id.clone(),
|
||||
)));
|
||||
let sources = root.join("sources");
|
||||
fs::create_dir_all(&sources)?;
|
||||
let bundle = write_plugin_source_bundle(&sources, "indexed")?;
|
||||
fs::create_dir_all(bundle.join("commands"))?;
|
||||
fs::write(bundle.join("commands/ship.md"), "Ship it.\n")?;
|
||||
fs::create_dir_all(bundle.join("agents"))?;
|
||||
fs::write(bundle.join("agents/reviewer.toml"), "name = \"reviewer\"\n")?;
|
||||
fs::write(
|
||||
bundle.join("plugin.toml"),
|
||||
"schema_version = 1\n[plugin]\nname = \"indexed\"\nversion = \"1.0.0\"\n\
|
||||
description = \"test bundle\"\n\n[skills]\npath = \"skills\"\n\
|
||||
[commands]\npath = \"commands\"\n[agents]\npath = \"agents\"\n",
|
||||
)?;
|
||||
|
||||
let Some((addr, handle)) = spawn_plugin_api_server(root, workspace).await? else {
|
||||
return Ok(());
|
||||
};
|
||||
let client = codewhale_release::tls::reqwest_client();
|
||||
plugin_ui::install_active(
|
||||
&client,
|
||||
&format!("http://{addr}/v1/apps/plugins"),
|
||||
bundle.display().to_string(),
|
||||
)
|
||||
.await?;
|
||||
|
||||
let listed: Value = client
|
||||
.get(format!("http://{addr}/v1/apps/plugins"))
|
||||
.send()
|
||||
.await?
|
||||
.error_for_status()?
|
||||
.json()
|
||||
.await?;
|
||||
let id = listed["plugins"]
|
||||
.as_array()
|
||||
.and_then(|plugins| plugins.iter().find(|plugin| plugin["name"] == "indexed"))
|
||||
.and_then(|plugin| plugin["id"].as_str())
|
||||
.expect("installed plugin id")
|
||||
.to_string();
|
||||
*plugin_id.lock().expect("plugin id") = Some(id.clone());
|
||||
|
||||
let commands: Value = client
|
||||
.get(format!("http://{addr}/v1/commands"))
|
||||
.send()
|
||||
.await?
|
||||
.error_for_status()?
|
||||
.json()
|
||||
.await?;
|
||||
let ship = commands["commands"]
|
||||
.as_array()
|
||||
.and_then(|rows| rows.iter().find(|row| row["name"] == "ship"))
|
||||
.expect("ship row");
|
||||
assert_eq!(ship["plugin_id"], id.as_str());
|
||||
|
||||
let index: Value = client
|
||||
.get(format!("http://{addr}/v1/apps/plugin-index"))
|
||||
.send()
|
||||
.await?
|
||||
.error_for_status()?
|
||||
.json()
|
||||
.await?;
|
||||
let items = index["items"].as_array().expect("items");
|
||||
let find = |id: &str| items.iter().find(|item| item["id"] == id);
|
||||
|
||||
let plugin = items
|
||||
.iter()
|
||||
.find(|item| item["kind"] == "plugin" && item["row"]["name"] == "indexed")
|
||||
.unwrap_or_else(|| panic!("plugin row in {index}"));
|
||||
assert_eq!(plugin["kind"], "plugin");
|
||||
assert_eq!(plugin["state"], "enabled");
|
||||
assert_eq!(plugin["adds"]["skills"], serde_json::json!(["greet"]));
|
||||
assert_eq!(plugin["adds"]["commands"], serde_json::json!(["ship"]));
|
||||
assert_eq!(plugin["adds"]["profiles"], serde_json::json!(["reviewer"]));
|
||||
assert_eq!(
|
||||
plugin["labels"],
|
||||
serde_json::json!(["skill", "command", "profile"])
|
||||
);
|
||||
assert_eq!(plugin["row"]["name"], "indexed");
|
||||
|
||||
assert!(find("skill:greet").is_none());
|
||||
assert!(find("command:ship").is_none());
|
||||
let mine = find("command:mine").expect("a hand-written command is a row");
|
||||
assert_eq!(mine["source"], "user");
|
||||
assert_eq!(mine["labels"], serde_json::json!(["command"]));
|
||||
assert!(
|
||||
items
|
||||
.iter()
|
||||
.any(|item| item["kind"] == "plugin" && item["tier"] == "builtin"),
|
||||
"built-in switches are rows"
|
||||
);
|
||||
assert_eq!(
|
||||
index["unavailable"].as_array().map(Vec::len),
|
||||
Some(0),
|
||||
"{index}"
|
||||
);
|
||||
|
||||
handle.abort();
|
||||
Ok(())
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn the_index_keeps_same_name_hooks_distinct() -> Result<()> {
|
||||
let _env = lock_test_env();
|
||||
let temp = tempfile::tempdir()?;
|
||||
let root = temp.path().join("hook-index-route");
|
||||
let workspace = root.join("workspace");
|
||||
let mut config = Config::default();
|
||||
config.hooks = Some(codewhale_config::hooks::HooksConfig {
|
||||
hooks: vec![
|
||||
codewhale_config::hooks::Hook::new(
|
||||
codewhale_config::hooks::HookEvent::SessionStart,
|
||||
"echo first",
|
||||
)
|
||||
.with_name("gate"),
|
||||
codewhale_config::hooks::Hook::new(
|
||||
codewhale_config::hooks::HookEvent::SessionStart,
|
||||
"echo second",
|
||||
)
|
||||
.with_name("gate"),
|
||||
codewhale_config::hooks::Hook::new(
|
||||
codewhale_config::hooks::HookEvent::SessionStart,
|
||||
"echo third",
|
||||
),
|
||||
codewhale_config::hooks::Hook::new(
|
||||
codewhale_config::hooks::HookEvent::SessionStart,
|
||||
"echo fourth",
|
||||
)
|
||||
.with_name("session_start 3"),
|
||||
],
|
||||
enabled: true,
|
||||
..Default::default()
|
||||
});
|
||||
let (addr, _runtime_threads, handle) =
|
||||
spawn_test_server_with_root_token_mobile_workspace_and_overrides(
|
||||
root.clone(),
|
||||
root.join("sessions"),
|
||||
None,
|
||||
false,
|
||||
workspace.clone(),
|
||||
TestServerOverrides {
|
||||
config: Some(config),
|
||||
plugin_discovery: Some(isolated_plugin_discovery(&root, &workspace)),
|
||||
..TestServerOverrides::default()
|
||||
},
|
||||
)
|
||||
.await?
|
||||
.expect("hook index test server");
|
||||
let client = codewhale_release::tls::reqwest_client();
|
||||
let index: Value = client
|
||||
.get(format!("http://{addr}/v1/apps/plugin-index"))
|
||||
.send()
|
||||
.await?
|
||||
.error_for_status()?
|
||||
.json()
|
||||
.await?;
|
||||
let hooks: Vec<_> = index["items"]
|
||||
.as_array()
|
||||
.expect("items")
|
||||
.iter()
|
||||
.filter(|item| item["kind"] == "hook")
|
||||
.collect();
|
||||
assert_eq!(hooks.len(), 4, "{index}");
|
||||
for (ordinal, hook) in hooks.iter().enumerate() {
|
||||
assert_eq!(
|
||||
hook["id"],
|
||||
format!("hook:user:session_start:{}", ordinal + 1)
|
||||
);
|
||||
assert_eq!(hook["state"], "enabled");
|
||||
}
|
||||
assert_eq!(hooks[0]["name"], "gate");
|
||||
assert_eq!(hooks[1]["name"], "gate");
|
||||
assert_eq!(hooks[2]["name"], "session_start 3");
|
||||
assert_eq!(hooks[3]["name"], "session_start 3");
|
||||
assert_eq!(hooks[3]["row"]["command"], "echo fourth");
|
||||
assert_eq!(hooks[0]["row"]["command"], "echo first");
|
||||
assert_eq!(hooks[1]["row"]["command"], "echo second");
|
||||
handle.abort();
|
||||
Ok(())
|
||||
}
|
||||
@@ -79,7 +79,7 @@ fn write_native_ui_bundle(dir: &Path, name: &str) -> Result<PathBuf> {
|
||||
Ok(bundle)
|
||||
}
|
||||
|
||||
async fn install_active(
|
||||
pub(super) async fn install_active(
|
||||
client: &reqwest::Client,
|
||||
base: &str,
|
||||
source: String,
|
||||
|
||||
@@ -1202,15 +1202,15 @@ async fn real_owner_two_workspace_services_share_scope_caches_and_settle_global_
|
||||
{
|
||||
let error = fs::rename(&selected_workspace, &retired_workspace)
|
||||
.expect_err("a live Runtime owner must prevent workspace replacement");
|
||||
assert_eq!(error.raw_os_error(), Some(5), "{error}");
|
||||
assert_eq!(error.raw_os_error(), Some(32), "{error}");
|
||||
assert!(!retired_workspace.exists());
|
||||
}
|
||||
manager.shutdown_and_wait().await?;
|
||||
#[cfg(windows)]
|
||||
{
|
||||
let error = fs::rename(&selected_workspace, &retired_workspace)
|
||||
.expect_err("Engine shutdown must retain the Runtime owner's workspace lock");
|
||||
assert_eq!(error.raw_os_error(), Some(5), "{error}");
|
||||
.expect_err("Engine shutdown must retain the Runtime owner's pinned workspace");
|
||||
assert_eq!(error.raw_os_error(), Some(32), "{error}");
|
||||
assert!(!retired_workspace.exists());
|
||||
assert!(Arc::ptr_eq(
|
||||
&scopes.admit(selected_workspace.clone()).await?,
|
||||
|
||||
@@ -367,81 +367,6 @@ fn build_state_keeps_resolved_explicit_config_path() {
|
||||
);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn stdio_transport_never_registers_the_stdout_hook_sink() {
|
||||
let tmp = tempfile::tempdir().expect("tempdir");
|
||||
let config_path = tmp.path().join("config.toml");
|
||||
fs::write(&config_path, "api_key = \"sk-deepseek-secret\"\n").expect("write config");
|
||||
|
||||
let http_state =
|
||||
build_state_with_transport(Some(config_path.clone()), None, AppTransport::Http)
|
||||
.expect("http state");
|
||||
let stdio_state = build_state_with_transport(Some(config_path), None, AppTransport::Stdio)
|
||||
.expect("stdio state");
|
||||
|
||||
let http_sinks = http_state.runtime.read().await.hooks.sink_count();
|
||||
let stdio_sinks = stdio_state.runtime.read().await.hooks.sink_count();
|
||||
assert_eq!(
|
||||
http_sinks,
|
||||
stdio_sinks + 1,
|
||||
"HTTP mode keeps StdoutHookSink + JsonlHookSink; stdio must drop the stdout sink (#5165)"
|
||||
);
|
||||
}
|
||||
|
||||
// Points CODEWHALE_HOME at a temp dir for one test and restores it after.
|
||||
// The variable is process-global, so these tests hold a lock.
|
||||
static CODEWHALE_HOME_TEST_LOCK: std::sync::Mutex<()> = std::sync::Mutex::new(());
|
||||
|
||||
struct CodewhaleHomeGuard {
|
||||
prior: Option<std::ffi::OsString>,
|
||||
_lock: std::sync::MutexGuard<'static, ()>,
|
||||
}
|
||||
|
||||
impl CodewhaleHomeGuard {
|
||||
fn set(value: &Path) -> Self {
|
||||
let lock = CODEWHALE_HOME_TEST_LOCK
|
||||
.lock()
|
||||
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
||||
let prior = std::env::var_os("CODEWHALE_HOME");
|
||||
// SAFETY: serialised by CODEWHALE_HOME_TEST_LOCK.
|
||||
unsafe { std::env::set_var("CODEWHALE_HOME", value) };
|
||||
Self { prior, _lock: lock }
|
||||
}
|
||||
}
|
||||
|
||||
impl Drop for CodewhaleHomeGuard {
|
||||
fn drop(&mut self) {
|
||||
// SAFETY: serialised by CODEWHALE_HOME_TEST_LOCK.
|
||||
unsafe {
|
||||
match &self.prior {
|
||||
Some(value) => std::env::set_var("CODEWHALE_HOME", value),
|
||||
None => std::env::remove_var("CODEWHALE_HOME"),
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn hook_log_without_config_path_goes_beside_state_db_not_cwd() {
|
||||
let home = tempfile::tempdir().expect("tempdir");
|
||||
let _home = CodewhaleHomeGuard::set(home.path());
|
||||
|
||||
let state = build_state_with_transport(None, None, AppTransport::Stdio).expect("state");
|
||||
state
|
||||
.runtime
|
||||
.read()
|
||||
.await
|
||||
.hooks
|
||||
.emit(codewhale_hooks::HookEvent::ResponseStart {
|
||||
response_id: "resp-6513".to_string(),
|
||||
})
|
||||
.await;
|
||||
|
||||
let log = fs::read_to_string(home.path().join("events.jsonl"))
|
||||
.expect("hook log beside state.db in CODEWHALE_HOME");
|
||||
assert!(log.contains("resp-6513"), "{log}");
|
||||
}
|
||||
|
||||
async fn response_body_json(response: Response) -> Value {
|
||||
let bytes = to_bytes(response.into_body(), usize::MAX)
|
||||
.await
|
||||
|
||||
@@ -3,13 +3,13 @@ mod acp_support;
|
||||
use acp_support::{Client, fixture_config, text_of, updates};
|
||||
use anyhow::{Result, anyhow};
|
||||
use codewhale_app_server::acp_server::capture_frontend;
|
||||
use codewhale_engine::llm_client::mock::{MockLlmClient, canned};
|
||||
use codewhale_engine::llm_client::mock::{CannedTurn, MockLlmClient, canned};
|
||||
use codewhale_engine::runtime_threads::RuntimeTurnStatus;
|
||||
use codewhale_engine::runtime_threads::manager::{
|
||||
RuntimeThreadManager, RuntimeThreadManagerConfig,
|
||||
};
|
||||
use serde_json::{Value, json};
|
||||
use std::path::PathBuf;
|
||||
use std::path::{Path, PathBuf};
|
||||
use std::sync::Arc;
|
||||
use std::time::Duration;
|
||||
use tokio::io::{AsyncWriteExt, BufReader};
|
||||
@@ -497,3 +497,346 @@ async fn extension_journey() -> Result<()> {
|
||||
host.shutdown().await;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
const GATES_MCP_FIXTURE: &str = r#"import readline from 'node:readline';
|
||||
readline.createInterface({input:process.stdin}).on('line', line => {
|
||||
const r = JSON.parse(line); if (r.id === undefined) return;
|
||||
let result = {};
|
||||
if (r.method === 'initialize') result = {protocolVersion:'2024-11-05',capabilities:{tools:{}},serverInfo:{name:'fixture',version:'1'}};
|
||||
if (r.method === 'tools/list') result = {tools:['echo','hidden'].map(name => ({name,description:'Echo text',inputSchema:{type:'object',properties:{text:{type:'string'}},required:['text']}}))};
|
||||
if (r.method === 'tools/call') result = {content:[{type:'text',text:'mcp-ran:' + r.params.name + ':' + r.params.arguments.text}]};
|
||||
process.stdout.write(JSON.stringify({jsonrpc:'2.0',id:r.id,result}) + '\n');
|
||||
});
|
||||
"#;
|
||||
|
||||
struct Outcome {
|
||||
response: Value,
|
||||
frames: Vec<Value>,
|
||||
asked: Vec<Value>,
|
||||
}
|
||||
|
||||
impl Outcome {
|
||||
fn rendered(&self) -> String {
|
||||
serde_json::to_string(&self.frames).unwrap_or_default()
|
||||
}
|
||||
fn completed(&self) -> usize {
|
||||
updates(&self.frames, "tool_call_update")
|
||||
.iter()
|
||||
.filter(|frame| frame.pointer("/params/update/status") == Some(&json!("completed")))
|
||||
.count()
|
||||
}
|
||||
fn titles(&self) -> Vec<String> {
|
||||
self.asked
|
||||
.iter()
|
||||
.map(|frame| {
|
||||
frame["params"]["toolCall"]["title"]
|
||||
.as_str()
|
||||
.unwrap_or_default()
|
||||
.to_string()
|
||||
})
|
||||
.collect()
|
||||
}
|
||||
fn announced_ids(&self) -> Vec<String> {
|
||||
updates(&self.frames, "tool_call")
|
||||
.iter()
|
||||
.filter_map(|frame| frame.pointer("/params/update/toolCallId")?.as_str())
|
||||
.map(str::to_string)
|
||||
.collect()
|
||||
}
|
||||
}
|
||||
|
||||
async fn run_prompt(
|
||||
client: &mut Client,
|
||||
session: &str,
|
||||
allow: &dyn Fn(usize) -> bool,
|
||||
) -> Result<Outcome> {
|
||||
client.next_id += 1;
|
||||
let prompt_id = client.next_id;
|
||||
client
|
||||
.send(
|
||||
json!({"jsonrpc":"2.0","id":prompt_id,"method":"session/prompt","params":{
|
||||
"sessionId":session,"prompt":[{"type":"text","text":"go"}]}}),
|
||||
)
|
||||
.await?;
|
||||
let mut frames = Vec::new();
|
||||
let mut asked = Vec::new();
|
||||
let response = loop {
|
||||
let frame = client.recv().await?;
|
||||
if frame["method"] == "session/request_permission" {
|
||||
let option = if allow(asked.len()) {
|
||||
"allow-once"
|
||||
} else {
|
||||
"reject-once"
|
||||
};
|
||||
client
|
||||
.send(json!({"jsonrpc":"2.0","id":frame["id"],
|
||||
"result":{"outcome":{"outcome":"selected","optionId":option}}}))
|
||||
.await?;
|
||||
asked.push(frame);
|
||||
} else if frame["id"] == json!(prompt_id) && frame.get("method").is_none() {
|
||||
break frame;
|
||||
} else {
|
||||
frames.push(frame);
|
||||
}
|
||||
};
|
||||
Ok(Outcome {
|
||||
response,
|
||||
frames,
|
||||
asked,
|
||||
})
|
||||
}
|
||||
|
||||
async fn new_session(
|
||||
client: &mut Client,
|
||||
manager: &RuntimeThreadManager,
|
||||
workspace: &Path,
|
||||
turns: Vec<CannedTurn>,
|
||||
plan: bool,
|
||||
) -> Result<String> {
|
||||
manager.set_test_model_client(Arc::new(MockLlmClient::new(turns)));
|
||||
let (created, _) = client
|
||||
.request("session/new", json!({"cwd":workspace}))
|
||||
.await?;
|
||||
let session = created["result"]["sessionId"]
|
||||
.as_str()
|
||||
.ok_or_else(|| anyhow!("session/new returned no sessionId: {created}"))?
|
||||
.to_string();
|
||||
if plan {
|
||||
let (set, _) = client
|
||||
.request(
|
||||
"session/set_mode",
|
||||
json!({"sessionId":session,"modeId":"plan"}),
|
||||
)
|
||||
.await?;
|
||||
assert!(set.get("error").is_none(), "{set}");
|
||||
}
|
||||
Ok(session)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn extension_tools_keep_the_permission_boundary_in_an_acp_session() -> Result<()> {
|
||||
std::thread::Builder::new()
|
||||
.stack_size(64 << 20)
|
||||
.spawn(|| {
|
||||
tokio::runtime::Builder::new_current_thread()
|
||||
.enable_all()
|
||||
.build()?
|
||||
.block_on(async {
|
||||
tokio::time::timeout(Duration::from_secs(180), gates())
|
||||
.await
|
||||
.map_err(|_| anyhow!("extension gates exceeded 180s"))?
|
||||
})
|
||||
})?
|
||||
.join()
|
||||
.map_err(|_| anyhow!("extension gates thread panicked"))?
|
||||
}
|
||||
|
||||
async fn gates() -> Result<()> {
|
||||
use codewhale_engine::extension_host::test_support::{FixturePlugins, node_for_tests};
|
||||
let Some(node) = node_for_tests("extension_tools_keep_the_permission_boundary") else {
|
||||
return Ok(());
|
||||
};
|
||||
let _policy = codewhale_plugins::activation::TestPolicyGuard::extension_host(true);
|
||||
let fixture = FixturePlugins::new(&["plugin-context", "core-call"]).await;
|
||||
let host = fixture.manager(node.clone());
|
||||
let _host = codewhale_engine::extension_host::TestManagerGuard::install(Arc::clone(&host));
|
||||
let dir = tempfile::tempdir()?;
|
||||
let _home = codewhale_engine::test_support::SealedHome::at(dir.path());
|
||||
let workspace = fixture.workspace().to_path_buf();
|
||||
std::fs::write(workspace.join("seed.txt"), "seed-content-xyz")?;
|
||||
let server = dir.path().join("fixture-mcp.mjs");
|
||||
std::fs::write(&server, GATES_MCP_FIXTURE)?;
|
||||
let mcp_config = dir.path().join("mcp.json");
|
||||
std::fs::write(
|
||||
&mcp_config,
|
||||
serde_json::to_vec(&json!({"servers":{
|
||||
"fixture":{"command":node,"args":[server],"disabled_tools":["hidden"]},
|
||||
"off":{"command":node,"args":[server],"disabled":true}
|
||||
}}))?,
|
||||
)?;
|
||||
let runtime_dir = dir.path().join("runtime");
|
||||
let mut config = fixture_config();
|
||||
config.set_feature("mcp", true).unwrap();
|
||||
config.set_feature("extension_host", true).unwrap();
|
||||
config.mcp_config_path = Some(mcp_config.to_string_lossy().into_owned());
|
||||
let manager = Arc::new(RuntimeThreadManager::open_host(
|
||||
config.clone(),
|
||||
workspace.clone(),
|
||||
RuntimeThreadManagerConfig {
|
||||
mcp_auth_context: Default::default(),
|
||||
data_dir: runtime_dir.clone(),
|
||||
task_data_dir: runtime_dir,
|
||||
sessions_dir: None,
|
||||
max_active_threads: 16,
|
||||
},
|
||||
fixture.registry(),
|
||||
codewhale_engine::core::engine::EngineHostProfile::Acp,
|
||||
None,
|
||||
None,
|
||||
)?);
|
||||
let frontend = capture_frontend(
|
||||
config,
|
||||
"fixture-model".into(),
|
||||
workspace.clone(),
|
||||
Arc::clone(&manager),
|
||||
codewhale_engine::session_manager::default_sessions_dir()?,
|
||||
None,
|
||||
None,
|
||||
)?;
|
||||
let (mut client, agent_read, agent_write) = Client::connect(false);
|
||||
let connection = frontend.serve(Box::new(BufReader::new(agent_read)), Box::new(agent_write));
|
||||
let manager_for_script = Arc::clone(&manager);
|
||||
let script =
|
||||
async {
|
||||
let manager = manager_for_script;
|
||||
let result = async {
|
||||
client
|
||||
.request(
|
||||
"initialize",
|
||||
json!({"protocolVersion":1,"clientCapabilities":{}}),
|
||||
)
|
||||
.await?;
|
||||
|
||||
let session = new_session(
|
||||
&mut client,
|
||||
&manager,
|
||||
&workspace,
|
||||
vec![
|
||||
canned::tool_call_turn(
|
||||
"n1",
|
||||
"cc_call",
|
||||
r#"{"name":"write","input":{"path":"nested.txt","content":"via-plugin"}}"#,
|
||||
),
|
||||
canned::simple_text_turn("nested allowed"),
|
||||
],
|
||||
false,
|
||||
)
|
||||
.await?;
|
||||
let allowed = run_prompt(&mut client, &session, &|_| true).await?;
|
||||
assert!(allowed.response.get("error").is_none(), "{}", allowed.response);
|
||||
assert_eq!(allowed.response["result"]["stopReason"], "end_turn");
|
||||
assert_eq!(allowed.asked.len(), 2, "{:?}", allowed.titles());
|
||||
assert!(allowed.titles()[0].starts_with("cc_call"));
|
||||
let announced = allowed.announced_ids();
|
||||
for request in &allowed.asked {
|
||||
let id = request["params"]["toolCall"]["toolCallId"]
|
||||
.as_str()
|
||||
.unwrap_or_default();
|
||||
assert!(
|
||||
announced.iter().any(|known| known == id),
|
||||
"a nested approval is shown on a tool call the editor knows: {id} {announced:?}"
|
||||
);
|
||||
}
|
||||
let nested = &allowed.asked[1]["params"]["toolCall"];
|
||||
assert_eq!(nested["title"], "write: nested.txt", "{nested}");
|
||||
assert_eq!(nested["kind"], "edit", "{nested}");
|
||||
assert_eq!(nested["rawInput"]["path"], "nested.txt", "{nested}");
|
||||
assert!(nested.get("status").is_none(), "{nested}");
|
||||
assert_eq!(
|
||||
std::fs::read_to_string(workspace.join("nested.txt"))?,
|
||||
"via-plugin"
|
||||
);
|
||||
|
||||
std::fs::remove_file(workspace.join("nested.txt"))?;
|
||||
let session = new_session(
|
||||
&mut client,
|
||||
&manager,
|
||||
&workspace,
|
||||
vec![
|
||||
canned::tool_call_turn(
|
||||
"n2",
|
||||
"cc_call",
|
||||
r#"{"name":"write","input":{"path":"nested.txt","content":"via-plugin"}}"#,
|
||||
),
|
||||
canned::simple_text_turn("nested denied"),
|
||||
],
|
||||
false,
|
||||
)
|
||||
.await?;
|
||||
let denied = run_prompt(&mut client, &session, &|index| index == 0).await?;
|
||||
assert!(denied.response.get("error").is_none(), "{}", denied.response);
|
||||
assert_eq!(denied.response["result"]["stopReason"], "end_turn");
|
||||
assert_eq!(denied.asked.len(), 2, "{:?}", denied.titles());
|
||||
assert!(
|
||||
!workspace.join("nested.txt").exists(),
|
||||
"a rejected nested write must not run"
|
||||
);
|
||||
|
||||
let session = new_session(
|
||||
&mut client,
|
||||
&manager,
|
||||
&workspace,
|
||||
vec![
|
||||
canned::tool_call_turn("r1", "ctx_probe", "{}"),
|
||||
canned::tool_call_turn("r2", "mcp_fixture_echo", r#"{"text":"control"}"#),
|
||||
canned::tool_call_turn("r3", "ctx_note", r#"{"text":"must-not-be-written"}"#),
|
||||
canned::tool_call_turn("r4", "mcp_fixture_echo", r#"{"text":"rejected"}"#),
|
||||
canned::simple_text_turn("rejections done"),
|
||||
],
|
||||
false,
|
||||
)
|
||||
.await?;
|
||||
let rejected = run_prompt(&mut client, &session, &|index| index < 2).await?;
|
||||
assert_eq!(rejected.asked.len(), 4, "{:?}", rejected.titles());
|
||||
let rendered = rejected.rendered();
|
||||
assert!(rendered.contains("mcp-ran:echo:control"), "{rendered}");
|
||||
assert!(!rendered.contains("mcp-ran:echo:rejected"), "{rendered}");
|
||||
assert!(!rendered.contains("note.txt"), "{rendered}");
|
||||
|
||||
let session = new_session(
|
||||
&mut client,
|
||||
&manager,
|
||||
&workspace,
|
||||
vec![
|
||||
canned::tool_call_turn("p1", "ctx_probe", "{}"),
|
||||
canned::tool_call_turn("p2", "mcp_fixture_echo", r#"{"text":"plan"}"#),
|
||||
canned::simple_text_turn("plan done"),
|
||||
],
|
||||
true,
|
||||
)
|
||||
.await?;
|
||||
let plan = run_prompt(&mut client, &session, &|_| true).await?;
|
||||
assert!(plan.asked.is_empty(), "{:?}", plan.titles());
|
||||
assert_eq!(plan.completed(), 0, "{}", plan.rendered());
|
||||
assert!(!plan.rendered().contains("mcp-ran:"));
|
||||
|
||||
let session = new_session(
|
||||
&mut client,
|
||||
&manager,
|
||||
&workspace,
|
||||
vec![
|
||||
canned::tool_call_turn("f1", "mcp_fixture_hidden", r#"{"text":"hid"}"#),
|
||||
canned::tool_call_turn("f2", "mcp_off_echo", r#"{"text":"off"}"#),
|
||||
canned::tool_call_turn("f3", "mcp_evil_echo", r#"{"text":"evil"}"#),
|
||||
canned::tool_call_turn(
|
||||
"f4",
|
||||
"start_mcp_server",
|
||||
r#"{"name":"evil","command":"node","args":["-e","0"]}"#,
|
||||
),
|
||||
canned::tool_call_turn("f5", "agent", r#"{"action":"start","prompt":"p"}"#),
|
||||
canned::simple_text_turn("fabricated done"),
|
||||
],
|
||||
false,
|
||||
)
|
||||
.await?;
|
||||
let fabricated = run_prompt(&mut client, &session, &|_| true).await?;
|
||||
assert!(fabricated.asked.is_empty(), "{:?}", fabricated.titles());
|
||||
assert_eq!(fabricated.completed(), 0, "{}", fabricated.rendered());
|
||||
assert!(!fabricated.rendered().contains("mcp-ran:"));
|
||||
|
||||
client.request("shutdown", json!({})).await?;
|
||||
Ok::<_, anyhow::Error>(())
|
||||
}
|
||||
.await;
|
||||
if result.is_err() {
|
||||
let _ = client.write.shutdown().await;
|
||||
}
|
||||
result
|
||||
};
|
||||
let (served, scripted) = tokio::join!(connection, script);
|
||||
served?;
|
||||
scripted?;
|
||||
manager.shutdown_and_wait().await?;
|
||||
host.shutdown().await;
|
||||
Ok(())
|
||||
}
|
||||
@@ -34,10 +34,12 @@ codewhale-engine = { path = "../engine", version = "0.10.3" }
|
||||
codewhale-app-server = { path = "../app-server", version = "0.10.3" }
|
||||
codewhale-config = { path = "../config", version = "0.10.3" }
|
||||
codewhale-lane = { path = "../lane", version = "0.10.3" }
|
||||
codewhale-net = { path = "../net", version = "0.10.3" }
|
||||
codewhale-workflow = { path = "../workflow", version = "0.10.3" }
|
||||
codewhale-execpolicy = { path = "../execpolicy", version = "0.10.3" }
|
||||
codewhale-paths = { path = "../paths", version = "0.10.3" }
|
||||
codewhale-release = { path = "../release", version = "0.10.3" }
|
||||
codewhale-sanitize = { path = "../sanitize", version = "0.10.3" }
|
||||
codewhale-secrets = { path = "../secrets", version = "0.10.3" }
|
||||
codewhale-state = { path = "../state", version = "0.10.3" }
|
||||
codewhale-telemetry = { path = "../telemetry", version = "0.10.3" }
|
||||
|
||||
@@ -15,6 +15,9 @@
|
||||
//! - Input size is capped (5 MiB, matching the skill installer's cap).
|
||||
//! - HTTPS only for remote fetch, except plain `http` on loopback; redirects
|
||||
//! are followed at most a bounded number of times within the same scheme.
|
||||
//! The first request and every redirect honor the `[network]` policy and
|
||||
//! refuse loopback, private, link-local and cloud-metadata destinations,
|
||||
//! except a visibly local host the person listed or typed as the URL.
|
||||
//! - Bundle-declared file paths must resolve inside the target config
|
||||
//! directory; traversal and symlink escapes are refused.
|
||||
//! - Project scope never mutates the user-global document and vice versa.
|
||||
@@ -379,7 +382,7 @@ fn url_carries_credential(text: &str) -> bool {
|
||||
// `***`; count masks rather than compare bytes, because it re-encodes the
|
||||
// query and would otherwise flag benign URLs.
|
||||
let masks = |value: &str| value.matches("***").count();
|
||||
if masks(&codewhale_secrets::sanitize::redact_url_for_display(text)) > masks(text) {
|
||||
if masks(&codewhale_sanitize::sanitize::redact_url_for_display(text)) > masks(text) {
|
||||
return true;
|
||||
}
|
||||
let host = url.host_str().unwrap_or_default().to_ascii_lowercase();
|
||||
@@ -573,13 +576,29 @@ fn nonportable_path_reason(path: &str) -> Option<&'static str> {
|
||||
None
|
||||
}
|
||||
|
||||
fn is_network_allow_path(path: &str) -> bool {
|
||||
let mut segments = path.split('.').map(normalize_bundle_key).rev();
|
||||
matches!(
|
||||
(segments.next().as_deref(), segments.next().as_deref()),
|
||||
(Some("allow"), Some("network"))
|
||||
)
|
||||
}
|
||||
|
||||
/// Telemetry opt-out is safe to move between machines, but opt-in is durable
|
||||
/// user consent coupled to SetupState. A portable bundle may tighten that
|
||||
/// consent (`false`); it must never manufacture or transfer `true`.
|
||||
fn nonportable_value_reason(path: &str, value: &toml::Value) -> Option<&'static str> {
|
||||
let top_level_telemetry = !path.contains('.') && normalize_bundle_key(path) == "telemetry";
|
||||
(top_level_telemetry && matches!(value, toml::Value::Boolean(true)))
|
||||
.then_some("would port telemetry opt-in consent between machines")
|
||||
if top_level_telemetry && matches!(value, toml::Value::Boolean(true)) {
|
||||
return Some("would port telemetry opt-in consent between machines");
|
||||
}
|
||||
if is_network_allow_path(path)
|
||||
&& let toml::Value::String(host) = value
|
||||
&& codewhale_net::guard::is_visibly_local_host(host)
|
||||
{
|
||||
return Some("network.allow entry would grant local-network authority");
|
||||
}
|
||||
None
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
@@ -798,67 +817,85 @@ pub fn resolve_bounded_path(base_dir: &Path, candidate: &str) -> Result<PathBuf>
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
/// Fetch a bundle over HTTPS (or plain http on loopback only) with a hard
|
||||
/// size cap, a timeout, and bounded redirects. Mirrors the skill installer's
|
||||
/// fetch bounds.
|
||||
pub fn fetch_bundle(url: &str) -> Result<Vec<u8>> {
|
||||
let mut current_url = reqwest::Url::parse(url).map_err(|_| anyhow!("invalid bundle URL"))?;
|
||||
validate_bundle_url(¤t_url)?;
|
||||
let initial_scheme = current_url.scheme().to_string();
|
||||
/// size cap, a timeout, and bounded redirects. The first request and every
|
||||
/// redirect go through the shared guarded download: the network policy
|
||||
/// applies, the host is resolved and checked, and loopback, private,
|
||||
/// link-local and cloud-metadata destinations are refused unless the person
|
||||
/// listed a visibly local host in `network.allow`. A loopback host typed as
|
||||
/// the URL itself is admitted without a listing.
|
||||
pub fn fetch_bundle(
|
||||
url: &str,
|
||||
network: &codewhale_net::network_policy::NetworkPolicy,
|
||||
) -> Result<Vec<u8>> {
|
||||
let initial_url = reqwest::Url::parse(url).map_err(|_| anyhow!("invalid bundle URL"))?;
|
||||
validate_bundle_url(&initial_url)?;
|
||||
let initial_scheme = initial_url.scheme().to_string();
|
||||
let initial_host = initial_url
|
||||
.host_str()
|
||||
.context("bundle URL must include a host")?
|
||||
.to_string();
|
||||
|
||||
let client = codewhale_release::platform_blocking_http_client_builder()
|
||||
.timeout(std::time::Duration::from_secs(FETCH_TIMEOUT_SECS))
|
||||
// Redirect targets must pass the same scheme/host policy as the
|
||||
// initial request, so redirects are followed explicitly below.
|
||||
.redirect(reqwest::redirect::Policy::none())
|
||||
.build()
|
||||
.map_err(|_| anyhow!("building bundle fetch client failed"))?;
|
||||
let mut redirects = 0usize;
|
||||
let response = loop {
|
||||
let response = client
|
||||
.get(current_url.clone())
|
||||
.send()
|
||||
// reqwest errors can include the full URL (including its query or
|
||||
// userinfo), so keep transport failures deliberately URL-free.
|
||||
.map_err(|_| anyhow!("bundle fetch request failed"))?;
|
||||
|
||||
if !response.status().is_redirection() {
|
||||
break response;
|
||||
}
|
||||
if redirects >= MAX_REDIRECTS {
|
||||
bail!("bundle fetch exceeded the five-redirect limit");
|
||||
}
|
||||
let location = response
|
||||
.headers()
|
||||
.get(reqwest::header::LOCATION)
|
||||
.ok_or_else(|| anyhow!("bundle redirect is missing a valid Location header"))?
|
||||
.to_str()
|
||||
.map_err(|_| anyhow!("bundle redirect is missing a valid Location header"))?;
|
||||
let next_url = current_url
|
||||
.join(location)
|
||||
.map_err(|_| anyhow!("bundle redirect Location is invalid"))?;
|
||||
validate_bundle_redirect(&initial_scheme, &next_url)?;
|
||||
current_url = next_url;
|
||||
redirects += 1;
|
||||
};
|
||||
|
||||
if !response.status().is_success() {
|
||||
bail!(
|
||||
"bundle fetch failed with HTTP status {}",
|
||||
response.status().as_u16()
|
||||
);
|
||||
let mut policy = network.clone();
|
||||
if is_loopback_bundle_host(&initial_host) {
|
||||
policy.add_allow(&initial_host);
|
||||
}
|
||||
let check =
|
||||
move |next: &reqwest::Url| validate_bundle_redirect(&initial_scheme, &initial_host, next);
|
||||
let request = codewhale_net::guard::GuardedGet::new(
|
||||
url,
|
||||
&policy,
|
||||
"config_import",
|
||||
codewhale_net::guard::PrivateTargets::TypedLocalHosts,
|
||||
)
|
||||
.timeouts(
|
||||
std::time::Duration::from_secs(FETCH_TIMEOUT_SECS),
|
||||
std::time::Duration::from_secs(FETCH_TIMEOUT_SECS),
|
||||
)
|
||||
.max_redirects(MAX_REDIRECTS)
|
||||
.redirect_check(&check);
|
||||
|
||||
// Read at most MAX_BUNDLE_BYTES + 1 so an oversize body is detected
|
||||
// rather than silently truncated.
|
||||
let mut buffer = Vec::new();
|
||||
let body = response;
|
||||
body.take(MAX_BUNDLE_BYTES + 1)
|
||||
.read_to_end(&mut buffer)
|
||||
.map_err(|_| anyhow!("reading remote bundle failed"))?;
|
||||
if buffer.len() as u64 > MAX_BUNDLE_BYTES {
|
||||
bail!("remote bundle exceeds the {MAX_BUNDLE_BYTES} byte limit; refused");
|
||||
}
|
||||
Ok(buffer)
|
||||
run_blocking(async move {
|
||||
let mut response = request.send().await?;
|
||||
if !response.status().is_success() {
|
||||
bail!(
|
||||
"bundle fetch failed with HTTP status {}",
|
||||
response.status().as_u16()
|
||||
);
|
||||
}
|
||||
if response
|
||||
.content_length()
|
||||
.is_some_and(|length| length > MAX_BUNDLE_BYTES)
|
||||
{
|
||||
bail!("remote bundle exceeds the {MAX_BUNDLE_BYTES} byte limit; refused");
|
||||
}
|
||||
let mut buffer = Vec::new();
|
||||
while let Some(chunk) = response
|
||||
.chunk()
|
||||
.await
|
||||
.map_err(|_| anyhow!("reading remote bundle failed"))?
|
||||
{
|
||||
if (buffer.len() + chunk.len()) as u64 > MAX_BUNDLE_BYTES {
|
||||
bail!("remote bundle exceeds the {MAX_BUNDLE_BYTES} byte limit; refused");
|
||||
}
|
||||
buffer.extend_from_slice(&chunk);
|
||||
}
|
||||
Ok(buffer)
|
||||
})
|
||||
}
|
||||
|
||||
fn run_blocking<T: Send>(future: impl std::future::Future<Output = Result<T>> + Send) -> Result<T> {
|
||||
std::thread::scope(|scope| {
|
||||
scope
|
||||
.spawn(|| {
|
||||
tokio::runtime::Builder::new_current_thread()
|
||||
.enable_all()
|
||||
.build()
|
||||
.map_err(|_| anyhow!("building bundle fetch runtime failed"))?
|
||||
.block_on(future)
|
||||
})
|
||||
.join()
|
||||
.map_err(|_| anyhow!("bundle fetch thread failed"))?
|
||||
})
|
||||
}
|
||||
|
||||
fn validate_bundle_url(url: &reqwest::Url) -> Result<()> {
|
||||
@@ -877,19 +914,37 @@ fn validate_bundle_url(url: &reqwest::Url) -> Result<()> {
|
||||
}
|
||||
}
|
||||
|
||||
fn validate_bundle_redirect(initial_scheme: &str, next_url: &reqwest::Url) -> Result<()> {
|
||||
fn validate_bundle_redirect(
|
||||
initial_scheme: &str,
|
||||
initial_host: &str,
|
||||
next_url: &reqwest::Url,
|
||||
) -> Result<()> {
|
||||
validate_bundle_url(next_url)?;
|
||||
if next_url.scheme() != initial_scheme {
|
||||
bail!("bundle redirects may not change URL scheme");
|
||||
}
|
||||
let next_host = next_url
|
||||
.host_str()
|
||||
.context("bundle URL must include a host")?;
|
||||
if codewhale_net::guard::is_visibly_local_host(next_host)
|
||||
&& !same_bundle_host(initial_host, next_host)
|
||||
{
|
||||
bail!("bundle redirects may not target a different local host");
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn same_bundle_host(left: &str, right: &str) -> bool {
|
||||
let normalize = |host: &str| host.trim().trim_end_matches('.').to_ascii_lowercase();
|
||||
normalize(left) == normalize(right)
|
||||
}
|
||||
|
||||
fn is_loopback_bundle_host(host: &str) -> bool {
|
||||
let normalized = host
|
||||
.strip_prefix('[')
|
||||
.and_then(|value| value.strip_suffix(']'))
|
||||
.unwrap_or(host);
|
||||
.unwrap_or(host)
|
||||
.trim_end_matches('.');
|
||||
normalized.eq_ignore_ascii_case("localhost")
|
||||
|| normalized.to_ascii_lowercase().ends_with(".localhost")
|
||||
|| normalized
|
||||
@@ -1571,7 +1626,13 @@ pub fn run_import(
|
||||
}
|
||||
buffer
|
||||
} else if remote_source {
|
||||
fetch_bundle(&args.source)?
|
||||
let network = store
|
||||
.config
|
||||
.network
|
||||
.clone()
|
||||
.map(codewhale_net::network_policy::NetworkPolicy::from)
|
||||
.unwrap_or_default();
|
||||
fetch_bundle(&args.source, &network)?
|
||||
} else {
|
||||
let path = PathBuf::from(&args.source);
|
||||
let metadata = std::fs::metadata(&path)
|
||||
@@ -1672,6 +1733,7 @@ pub fn run_export(args: &ExportArgs, store: &codewhale_config::ConfigStore) -> R
|
||||
mod tests {
|
||||
use super::*;
|
||||
use codewhale_config::ConfigStore;
|
||||
use codewhale_net::network_policy::NetworkPolicy;
|
||||
use std::io::Write;
|
||||
use std::net::{Ipv4Addr, TcpListener};
|
||||
|
||||
@@ -4183,7 +4245,7 @@ label = "safe-nested-workspace-label"
|
||||
|
||||
#[test]
|
||||
fn http_non_loopback_fetch_is_refused_without_network_access() {
|
||||
let err = fetch_bundle("http://example.com/bundle.toml")
|
||||
let err = fetch_bundle("http://example.com/bundle.toml", &NetworkPolicy::default())
|
||||
.expect_err("plain http to a public host must be refused");
|
||||
assert!(err.to_string().contains("loopback"), "{err:#}");
|
||||
assert!(!err.to_string().contains("example.com"), "{err:#}");
|
||||
@@ -4196,7 +4258,8 @@ label = "safe-nested-workspace-label"
|
||||
let response = http_response("302 Found", &[("Location", location.as_str())], b"");
|
||||
let (url, server) = spawn_bundle_http_server(vec![response]);
|
||||
|
||||
let error = fetch_bundle(&url).expect_err("redirect target must be revalidated");
|
||||
let error = fetch_bundle(&url, &NetworkPolicy::default())
|
||||
.expect_err("redirect target must be revalidated");
|
||||
let rendered = format!("{error:#}");
|
||||
assert!(rendered.contains("loopback"), "{rendered}");
|
||||
assert!(!rendered.contains("example.com"), "{rendered}");
|
||||
@@ -4204,13 +4267,149 @@ label = "safe-nested-workspace-label"
|
||||
assert_eq!(server.join().expect("server joins"), 1);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn visibly_local_network_allow_entries_are_rejected_while_public_hosts_import() {
|
||||
let local_bundle = parse_bundle_str(
|
||||
r#"
|
||||
schema_version = 1
|
||||
kind = "codewhale.portable-config"
|
||||
|
||||
[global.network]
|
||||
default = "prompt"
|
||||
allow = ["docs.example.com", "localhost", "10.0.0.5"]
|
||||
"#,
|
||||
"local-allow.toml",
|
||||
)
|
||||
.expect("local allow bundle parses");
|
||||
let rejected = find_rejected_entries(&local_bundle);
|
||||
assert_eq!(rejected.len(), 1, "{rejected:?}");
|
||||
assert_eq!(rejected[0].key, "global.network");
|
||||
assert!(rejected[0].reason.contains("network.allow"), "{rejected:?}");
|
||||
assert!(!rejected[0].reason.contains("localhost"), "{rejected:?}");
|
||||
assert!(!rejected[0].reason.contains("10.0.0.5"), "{rejected:?}");
|
||||
|
||||
let mut store = isolated_store();
|
||||
let before = std::fs::read(store.path()).expect("config before import");
|
||||
let dir = store.path().parent().expect("config dir").to_path_buf();
|
||||
apply_bundle(&local_bundle, &mut store, BundleScope::Global, &dir)
|
||||
.expect_err("bundle adding visibly local network.allow entries must fail");
|
||||
assert_eq!(
|
||||
std::fs::read(store.path()).expect("config after rejected import"),
|
||||
before
|
||||
);
|
||||
|
||||
let public_bundle = parse_bundle_str(
|
||||
r#"
|
||||
schema_version = 1
|
||||
kind = "codewhale.portable-config"
|
||||
|
||||
[global.network]
|
||||
default = "prompt"
|
||||
allow = ["docs.example.com"]
|
||||
"#,
|
||||
"public-allow.toml",
|
||||
)
|
||||
.expect("public allow bundle parses");
|
||||
assert!(find_rejected_entries(&public_bundle).is_empty());
|
||||
let receipt = apply_bundle(&public_bundle, &mut store, BundleScope::Global, &dir)
|
||||
.expect("public network.allow entry must import");
|
||||
assert!(receipt.plan.rejected.is_empty());
|
||||
assert_eq!(
|
||||
store
|
||||
.config
|
||||
.network
|
||||
.as_ref()
|
||||
.map(|network| network.allow.as_slice()),
|
||||
Some(&["docs.example.com".to_string()][..])
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn localdomain_and_localhost_wildcard_network_allow_entries_are_rejected_and_scrubbed() {
|
||||
for (section, entry) in [
|
||||
("global", ".localdomain"),
|
||||
("global", "*.localdomain"),
|
||||
("global", ".localhost"),
|
||||
("global", "*.localhost"),
|
||||
("global", "*.dev.localhost"),
|
||||
("project", "*.localdomain"),
|
||||
] {
|
||||
let bundle_text = format!(
|
||||
r#"
|
||||
schema_version = 1
|
||||
kind = "codewhale.portable-config"
|
||||
|
||||
[{section}.network]
|
||||
default = "prompt"
|
||||
allow = ["docs.example.com", "{entry}"]
|
||||
"#
|
||||
);
|
||||
let bundle = parse_bundle_str(&bundle_text, "wildcard-local-allow.toml")
|
||||
.expect("wildcard allow bundle parses");
|
||||
let rejected = find_rejected_entries(&bundle);
|
||||
assert_eq!(rejected.len(), 1, "{section} {entry}: {rejected:?}");
|
||||
assert_eq!(rejected[0].key, format!("{section}.network"));
|
||||
assert!(rejected[0].reason.contains("network.allow"), "{rejected:?}");
|
||||
assert!(!rejected[0].reason.contains(entry), "{rejected:?}");
|
||||
}
|
||||
|
||||
let combined = parse_bundle_str(
|
||||
r#"
|
||||
schema_version = 1
|
||||
kind = "codewhale.portable-config"
|
||||
|
||||
[global.network]
|
||||
default = "prompt"
|
||||
allow = [".localdomain", "*.localdomain", "*.localhost"]
|
||||
"#,
|
||||
"combined-wildcard-local-allow.toml",
|
||||
)
|
||||
.expect("combined wildcard bundle parses");
|
||||
let mut store = isolated_store();
|
||||
let before = std::fs::read(store.path()).expect("config before import");
|
||||
let dir = store.path().parent().expect("config dir").to_path_buf();
|
||||
apply_bundle(&combined, &mut store, BundleScope::Global, &dir)
|
||||
.expect_err("bundle adding local-domain wildcard network.allow entries must fail");
|
||||
assert_eq!(
|
||||
std::fs::read(store.path()).expect("config after rejected import"),
|
||||
before
|
||||
);
|
||||
|
||||
let config: ConfigToml = toml::from_str(
|
||||
r#"
|
||||
[network]
|
||||
default = "prompt"
|
||||
allow = ["docs.example.com", ".localdomain", "*.localdomain", ".localhost", "*.localhost", "localhost", "10.0.0.5"]
|
||||
"#,
|
||||
)
|
||||
.expect("config with local network.allow entries parses");
|
||||
let exported = export_bundle(&config, BundleScope::Global, BundleMetadata::default())
|
||||
.expect("local network.allow entries are scrubbed on export");
|
||||
let body = serialize_bundle(&exported).expect("serialize scrubbed export");
|
||||
for forbidden in [
|
||||
".localdomain",
|
||||
"*.localdomain",
|
||||
".localhost",
|
||||
"*.localhost",
|
||||
"\"localhost\"",
|
||||
"10.0.0.5",
|
||||
] {
|
||||
assert!(
|
||||
!body.contains(forbidden),
|
||||
"export retained {forbidden}: {body}"
|
||||
);
|
||||
}
|
||||
assert!(body.contains("docs.example.com"), "{body}");
|
||||
assert!(find_rejected_entries(&exported).is_empty(), "{exported:?}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn https_redirect_cannot_downgrade_to_loopback_http() {
|
||||
let secret = "downgrade-secret-must-not-leak";
|
||||
let target = reqwest::Url::parse(&format!("http://127.0.0.1/internal?token={secret}"))
|
||||
.expect("test target URL");
|
||||
|
||||
let error = validate_bundle_redirect("https", &target)
|
||||
let error = validate_bundle_redirect("https", "example.com", &target)
|
||||
.expect_err("HTTPS redirect must not downgrade to loopback HTTP");
|
||||
let rendered = format!("{error:#}");
|
||||
assert!(rendered.contains("scheme"), "{rendered}");
|
||||
@@ -4218,6 +4417,59 @@ label = "safe-nested-workspace-label"
|
||||
assert!(!rendered.contains("127.0.0.1"), "{rendered}");
|
||||
}
|
||||
|
||||
fn spawn_counting_server(
|
||||
response: Vec<u8>,
|
||||
) -> (u16, std::sync::Arc<std::sync::atomic::AtomicUsize>) {
|
||||
use std::sync::atomic::{AtomicUsize, Ordering};
|
||||
let listener = TcpListener::bind((Ipv4Addr::LOCALHOST, 0)).expect("bind counting fixture");
|
||||
let port = listener.local_addr().expect("fixture address").port();
|
||||
let hits = std::sync::Arc::new(AtomicUsize::new(0));
|
||||
let counter = std::sync::Arc::clone(&hits);
|
||||
std::thread::spawn(move || {
|
||||
for stream in listener.incoming() {
|
||||
let Ok(mut stream) = stream else { return };
|
||||
counter.fetch_add(1, Ordering::SeqCst);
|
||||
let mut chunk = [0_u8; 1024];
|
||||
let _ = stream.read(&mut chunk);
|
||||
let _ = stream.write_all(&response);
|
||||
}
|
||||
});
|
||||
(port, hits)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn redirect_to_another_local_host_is_refused() {
|
||||
use std::sync::atomic::Ordering;
|
||||
let (port, hits) = spawn_counting_server(http_response(
|
||||
"200 OK",
|
||||
&[("Content-Type", "text/plain")],
|
||||
VALID_TOML.as_bytes(),
|
||||
));
|
||||
let location = format!("http://localhost:{port}/bundle.toml");
|
||||
let redirect = http_response("302 Found", &[("Location", location.as_str())], b"");
|
||||
let (url, entry_server) = spawn_bundle_http_server(vec![redirect.clone()]);
|
||||
|
||||
let error = fetch_bundle(&url, &NetworkPolicy::default())
|
||||
.expect_err("a hop to another local host must be refused");
|
||||
assert!(!format!("{error:#}").contains("bundle.toml"), "{error:#}");
|
||||
assert_eq!(entry_server.join().expect("entry joins"), 1);
|
||||
assert_eq!(hits.load(Ordering::SeqCst), 0);
|
||||
|
||||
let (listed_url, listed_entry_server) = spawn_bundle_http_server(vec![redirect]);
|
||||
let listed_policy = NetworkPolicy {
|
||||
allow: vec!["localhost".to_string()],
|
||||
..NetworkPolicy::default()
|
||||
};
|
||||
let listed_error = fetch_bundle(&listed_url, &listed_policy)
|
||||
.expect_err("even a listed local host must be refused on redirect from another host");
|
||||
assert!(
|
||||
!format!("{listed_error:#}").contains("bundle.toml"),
|
||||
"{listed_error:#}"
|
||||
);
|
||||
assert_eq!(listed_entry_server.join().expect("listed entry joins"), 1);
|
||||
assert_eq!(hits.load(Ordering::SeqCst), 0);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn relative_loopback_redirect_fetches_bundle() {
|
||||
let redirect = http_response("302 Found", &[("Location", "/bundle.toml")], b"");
|
||||
@@ -4225,7 +4477,8 @@ label = "safe-nested-workspace-label"
|
||||
let success = http_response("200 OK", &[("Content-Type", "text/plain")], body);
|
||||
let (url, server) = spawn_bundle_http_server(vec![redirect, success]);
|
||||
|
||||
let fetched = fetch_bundle(&url).expect("relative redirect remains allowed");
|
||||
let fetched = fetch_bundle(&url, &NetworkPolicy::default())
|
||||
.expect("relative redirect remains allowed");
|
||||
assert_eq!(fetched, body);
|
||||
assert_eq!(server.join().expect("server joins"), 2);
|
||||
}
|
||||
@@ -4240,16 +4493,23 @@ label = "safe-nested-workspace-label"
|
||||
.collect();
|
||||
let (url, server) = spawn_bundle_http_server(responses);
|
||||
|
||||
let error = fetch_bundle(&url).expect_err("sixth redirect must be refused");
|
||||
assert!(error.to_string().contains("five-redirect"), "{error:#}");
|
||||
let error = fetch_bundle(&url, &NetworkPolicy::default())
|
||||
.expect_err("sixth redirect must be refused");
|
||||
assert!(
|
||||
error.to_string().contains("too many redirects"),
|
||||
"{error:#}"
|
||||
);
|
||||
assert_eq!(server.join().expect("server joins"), MAX_REDIRECTS + 1);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn bundle_url_credentials_are_rejected_without_echoing_them() {
|
||||
let secret = "credential-secret-must-not-leak";
|
||||
let error = fetch_bundle(&format!("https://user:{secret}@example.com/bundle.toml"))
|
||||
.expect_err("URL userinfo must be refused");
|
||||
let error = fetch_bundle(
|
||||
&format!("https://user:{secret}@example.com/bundle.toml"),
|
||||
&NetworkPolicy::default(),
|
||||
)
|
||||
.expect_err("URL userinfo must be refused");
|
||||
let rendered = format!("{error:#}");
|
||||
assert!(rendered.contains("credentials"), "{rendered}");
|
||||
assert!(!rendered.contains(secret), "{rendered}");
|
||||
@@ -4258,7 +4518,8 @@ label = "safe-nested-workspace-label"
|
||||
|
||||
#[test]
|
||||
fn unsupported_schemes_are_refused() {
|
||||
let err = fetch_bundle("file:///etc/passwd").expect_err("file scheme refused");
|
||||
let err = fetch_bundle("file:///etc/passwd", &NetworkPolicy::default())
|
||||
.expect_err("file scheme refused");
|
||||
assert!(err.to_string().contains("scheme"), "{err:#}");
|
||||
}
|
||||
|
||||
|
||||
@@ -234,10 +234,10 @@ enum Commands {
|
||||
#[command(about = "Install a plugin bundle without trusting or enabling it")]
|
||||
Install(TuiPassthroughArgs),
|
||||
#[command(
|
||||
about = "Inspect, review, trust, enable, disable or revoke plugin bundles",
|
||||
about = "Install, inspect, review, trust, enable, disable, update, uninstall or revoke plugin bundles",
|
||||
alias = "plugin",
|
||||
override_usage = "codewhale plugins <COMMAND>",
|
||||
after_help = "Commands:\n status [NAME] [--json] Inspect plugin status and diagnostics\n list [NAME] [--json] Alias of status\n restage <NAME> [--json] Restore an eligible reviewed plugin snapshot\n trust <NAME> [--json] Show the capability review; in a terminal, then ask\n trust <NAME> --review-token T [--yes] [--json] Trust exactly the content the bundle review token names\n enable <NAME> [--json] Enable a trusted plugin\n disable <NAME> [--json] Disable a plugin, keeping its trust\n revoke <NAME> [--json] Revoke trust\n\nThe bundle review token ties trust to exact content; it does not show that anyone read the review,\nand it is not the host-service review token. A --yes trust is recorded as the command line. When\nCODEWHALE_AGENT_PROJECT marks the process, as it does every command the agent runs, trust and enable\nare the agent's, for that project only; that mark is a label the agent could remove in Full Access."
|
||||
after_help = "Commands:\n install <SPEC> [--json] Install a plugin bundle without trusting or enabling it\n status [NAME] [--json] Inspect plugin status and diagnostics\n list [NAME] [--json] Alias of status\n show <NAME> [--json] Show the capability review without prompting or trusting\n restage <NAME> [--json] Restore an eligible reviewed plugin snapshot\n trust <NAME> [--json] Show the capability review; in a terminal, then ask\n trust <NAME> --review-token T [--yes] [--json] Trust exactly the content the bundle review token names\n enable <NAME> [--json] Enable a trusted plugin\n disable <NAME> [--json] Disable a plugin, keeping its trust\n update <NAME> [--json] Update an installed plugin bundle from its recorded source\n uninstall <NAME> [--yes] [--json] Disable if needed and remove an installed plugin bundle\n revoke <NAME> [--json] Revoke trust\n\nThe bundle review token ties trust to exact content; it does not show that anyone read the review,\nand it is not the host-service review token. A --yes trust is recorded as the command line. When\nCODEWHALE_AGENT_PROJECT marks the process, as it does every command the agent runs, trust and enable\nare the agent's, for that project only; that mark is a label the agent could remove in Full Access."
|
||||
)]
|
||||
Plugins(TuiPassthroughArgs),
|
||||
/// Bootstrap MCP config and/or skills directories.
|
||||
|
||||
@@ -25,6 +25,7 @@ semver.workspace = true
|
||||
schemars = { version = "1.2.1", optional = true, features = ["derive", "preserve_order"] }
|
||||
codewhale-execpolicy = { path = "../execpolicy", version = "0.10.3" }
|
||||
codewhale-paths = { path = "../paths", version = "0.10.3" }
|
||||
codewhale-sanitize = { path = "../sanitize", version = "0.10.3" }
|
||||
codewhale-secrets = { path = "../secrets", version = "0.10.3" }
|
||||
fd-lock = "4.0.4"
|
||||
libc = "0.2"
|
||||
|
||||
@@ -300,7 +300,7 @@ pub(crate) fn remove_plaintext_api_keys_in_array(array: &mut toml_edit::Array) {
|
||||
pub(crate) fn backup_value_carries_secret(value: &toml_edit::Value) -> bool {
|
||||
value
|
||||
.as_str()
|
||||
.is_some_and(codewhale_secrets::sanitize::contains_secret)
|
||||
.is_some_and(codewhale_sanitize::sanitize::contains_secret)
|
||||
}
|
||||
|
||||
pub(crate) fn scrub_backup_decor(decor: &mut toml_edit::Decor) {
|
||||
@@ -331,7 +331,7 @@ pub(crate) fn scrub_backup_comments(text: &str) -> String {
|
||||
comment
|
||||
.split_once('=')
|
||||
.is_some_and(|(key, _)| is_sensitive_config_key(key))
|
||||
|| codewhale_secrets::sanitize::contains_secret(comment)
|
||||
|| codewhale_sanitize::sanitize::contains_secret(comment)
|
||||
})
|
||||
})
|
||||
.collect()
|
||||
|
||||
@@ -99,7 +99,7 @@ pub fn toml_error_location(source: Option<&str>, err: &toml::de::Error) -> Strin
|
||||
.and_then(|rest| rest.strip_prefix("\nin `"))
|
||||
.and_then(|rest| rest.strip_suffix("`\n"))
|
||||
.filter(|keys| !keys.is_empty())
|
||||
.map(|keys| format!("in `{}`", codewhale_secrets::redact::redact_secrets(keys)));
|
||||
.map(|keys| format!("in `{}`", codewhale_sanitize::redact::redact_secrets(keys)));
|
||||
match (position, key_path) {
|
||||
(Some(position), Some(keys)) => format!("{position}, {keys}"),
|
||||
(Some(position), None) => position,
|
||||
|
||||
@@ -128,7 +128,7 @@ pub(crate) fn redact_secret(secret: &str) -> String {
|
||||
pub fn is_sensitive_config_key(key: &str) -> bool {
|
||||
key.rsplit('.')
|
||||
.next()
|
||||
.is_some_and(codewhale_secrets::sanitize::is_sensitive_key_name)
|
||||
.is_some_and(codewhale_sanitize::sanitize::is_sensitive_key_name)
|
||||
}
|
||||
|
||||
/// Resolve dotted paths without treating a dotted key as a top-level literal.
|
||||
|
||||
@@ -5,13 +5,6 @@ use std::path::PathBuf;
|
||||
/// On-disk schema for the `[hook_sinks]` table.
|
||||
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
|
||||
pub struct HookSinksToml {
|
||||
/// Unix domain socket path used by the app-server event sink.
|
||||
///
|
||||
/// Known limitation: only `codewhale app-server` reads this table; the
|
||||
/// TUI and the Runtime API do not dispatch hook events to it.
|
||||
///
|
||||
/// When unset, no Unix socket sink is registered. There is deliberately no
|
||||
/// shared `/tmp` default because socket ownership should be explicit.
|
||||
#[serde(default)]
|
||||
pub unix_socket_path: Option<PathBuf>,
|
||||
}
|
||||
|
||||
@@ -314,10 +314,10 @@ fn rollback(snapshots: &[Snapshot]) {
|
||||
}
|
||||
|
||||
// FEAT-025 D4: the pure secret-redaction primitives moved to
|
||||
// `codewhale-secrets::redact` so portable command helpers can share one
|
||||
// `codewhale-sanitize::redact` so portable command helpers can share one
|
||||
// implementation without depending on this crate. Re-exported here to keep
|
||||
// the existing `codewhale_config::persistence::*` public API stable.
|
||||
pub use codewhale_secrets::redact::{
|
||||
pub use codewhale_sanitize::redact::{
|
||||
REDACTED, RedactionPolicy, redact_json_model_bound_secrets, redact_json_secrets,
|
||||
redact_model_bound_secrets, redact_secrets, redact_secrets_with,
|
||||
};
|
||||
|
||||
@@ -59,7 +59,7 @@ pub fn check_config_toml_choice(key: &str, value: &str) -> Result<()> {
|
||||
} else {
|
||||
""
|
||||
};
|
||||
let value = codewhale_secrets::redact::redact_secrets(value);
|
||||
let value = codewhale_sanitize::redact::redact_secrets(value);
|
||||
bail!(
|
||||
"invalid value '{value}' for '{key}': config.toml accepts {}.{settings_note} \
|
||||
No value was changed.\nfix: codewhale config set {key} {}",
|
||||
@@ -205,7 +205,7 @@ pub fn load_project_config_outcome(workspace: &Path) -> ProjectConfigOutcome {
|
||||
// echoed; an ordinary typo stays readable.
|
||||
Some(name) => format!(
|
||||
"unknown provider '{}'",
|
||||
codewhale_secrets::redact::redact_secrets(&name)
|
||||
codewhale_sanitize::redact::redact_secrets(&name)
|
||||
),
|
||||
None => "unknown provider".to_string(),
|
||||
},
|
||||
|
||||
@@ -605,7 +605,7 @@ pub const SETTINGS_SCHEMA: &[SettingDef] = &[
|
||||
def(
|
||||
"show_thinking",
|
||||
SettingKind::Bool(SHOW_THINKING),
|
||||
"false",
|
||||
"true",
|
||||
ui(
|
||||
TAB_APPEARANCE,
|
||||
"display",
|
||||
@@ -1313,7 +1313,7 @@ pub const SETTINGS_SCHEMA: &[SettingDef] = &[
|
||||
def(
|
||||
"telemetry",
|
||||
SettingKind::Bool(TELEMETRY),
|
||||
"false",
|
||||
"true",
|
||||
ui(
|
||||
TAB_TRUST,
|
||||
"network",
|
||||
@@ -1546,6 +1546,12 @@ pub const SETTINGS_SCHEMA: &[SettingDef] = &[
|
||||
"false",
|
||||
None,
|
||||
),
|
||||
def(
|
||||
"account_preferences_notice_shown",
|
||||
SettingKind::String,
|
||||
"",
|
||||
None,
|
||||
),
|
||||
// Round 3 work-bar placement migration ran once (`top` → `bottom`).
|
||||
def(
|
||||
"work_surface_bottom_migrated",
|
||||
|
||||
@@ -14,7 +14,6 @@ workspace = true
|
||||
serde.workspace = true
|
||||
thiserror.workspace = true
|
||||
codewhale-config = { path = "../config", version = "0.10.3" }
|
||||
codewhale-hooks = { path = "../hooks", version = "0.10.3" }
|
||||
codewhale-protocol = { path = "../protocol", version = "0.10.3" }
|
||||
codewhale-state = { path = "../state", version = "0.10.3" }
|
||||
regex = "1.11"
|
||||
@@ -24,4 +23,3 @@ serde_json = { workspace = true, features = ["preserve_order"] }
|
||||
[dev-dependencies]
|
||||
tempfile.workspace = true
|
||||
uuid.workspace = true
|
||||
tokio = { workspace = true, features = ["macros", "rt", "time"] }
|
||||
@@ -1,9 +0,0 @@
|
||||
//! `ThreadId` / `SessionId` for the `crates/core` boundary (issue #5261).
|
||||
//!
|
||||
//! Re-exports the protocol ids so every crate that depends on `core` (the
|
||||
//! TUI, CLI, app-server) speaks the same typed ids without depending on
|
||||
//! `protocol` directly. The persisted JSON shape stays a plain string
|
||||
//! (`"thread-…"` / `"session-…"`) so existing `state.json` / `threads/`
|
||||
//! files need no migration.
|
||||
|
||||
pub use codewhale_protocol::ids::{SessionId, ThreadId};
|
||||
@@ -1,78 +0,0 @@
|
||||
//! Session tree journal placeholder (issue #5262).
|
||||
//!
|
||||
//! The journal is append-only with an in-memory tree projection:
|
||||
//! every non-header entry carries `id` + `parentId`, the active position is
|
||||
//! a `leafId`, appending creates a child of the leaf, and branching only
|
||||
//! moves the leaf — it never rewrites history. This file lands the entry
|
||||
//! shape that #5262's tree operations hang off of; compaction and
|
||||
//! branch-summary entry kinds are included as first-class kinds but their
|
||||
//! *strategies* are deferred.
|
||||
//!
|
||||
//! Re-exports the protocol journal as the canonical shape so `protocol` and
|
||||
//! `core` agree on the wire. `core` adds the `SessionJournal` wrapper that
|
||||
//! owns the `current_leaf_id` column in `state.threads`.
|
||||
|
||||
pub use codewhale_protocol::journal::{Journal, JournalEntry};
|
||||
|
||||
use serde::{Deserialize, Serialize};
|
||||
|
||||
/// Persisted thread metadata extension for the tree. This is the
|
||||
/// `current_leaf_id` column added to `state.threads`; `None` before the
|
||||
/// first turn, `Some(id)` after. The existing `threads` JSON shape is
|
||||
/// otherwise unchanged (back-compat: old rows read as `None` and the next
|
||||
/// append mints the header leaf).
|
||||
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
||||
pub struct ThreadLeafState {
|
||||
pub thread_id: String,
|
||||
pub leaf_id: Option<String>,
|
||||
}
|
||||
|
||||
/// First-class journal entry kinds (data shape lands now; strategies later).
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub enum JournalKind {
|
||||
Header,
|
||||
User,
|
||||
Assistant,
|
||||
ToolResult,
|
||||
Compaction,
|
||||
BranchSummary,
|
||||
}
|
||||
|
||||
impl JournalKind {
|
||||
#[must_use]
|
||||
pub fn as_str(self) -> &'static str {
|
||||
match self {
|
||||
Self::Header => "header",
|
||||
Self::User => "user",
|
||||
Self::Assistant => "assistant",
|
||||
Self::ToolResult => "tool_result",
|
||||
Self::Compaction => "compaction",
|
||||
Self::BranchSummary => "branch_summary",
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use serde_json::json;
|
||||
|
||||
#[test]
|
||||
fn leaf_state_roundtrip() {
|
||||
let s = ThreadLeafState {
|
||||
thread_id: "thread-1".into(),
|
||||
leaf_id: Some("entry-abc".into()),
|
||||
};
|
||||
let j = serde_json::to_string(&s).unwrap();
|
||||
let back: ThreadLeafState = serde_json::from_str(&j).unwrap();
|
||||
assert_eq!(back, s);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn journal_append_is_child_of_leaf() {
|
||||
let mut j = Journal::new();
|
||||
let a = j.append("header", json!({}));
|
||||
let b = j.append("user", json!("hi"));
|
||||
assert_eq!(j.get(&b).unwrap().parent_id.as_deref(), Some(a.as_str()));
|
||||
}
|
||||
}
|
||||
+5
-18
@@ -1,12 +1,9 @@
|
||||
pub mod context_reference;
|
||||
pub mod fragments;
|
||||
pub mod ids;
|
||||
pub mod journal;
|
||||
pub mod prefix_cache;
|
||||
pub mod request;
|
||||
pub mod role;
|
||||
pub mod secret_eq;
|
||||
pub mod session;
|
||||
pub mod tool_parser;
|
||||
|
||||
pub use context_reference::{
|
||||
@@ -15,10 +12,9 @@ pub use context_reference::{
|
||||
};
|
||||
|
||||
use codewhale_config::{ConfigToml, ProviderKind};
|
||||
use codewhale_hooks::HookDispatcher;
|
||||
use codewhale_state::StateStore;
|
||||
|
||||
/// Compatibility configuration and hooks.
|
||||
/// Compatibility configuration.
|
||||
///
|
||||
/// Conversation execution and durable history belong to the held canonical
|
||||
/// RuntimeThreadManager/Engine. Legacy State data is retained for read-only
|
||||
@@ -26,16 +22,11 @@ use codewhale_state::StateStore;
|
||||
pub struct Runtime {
|
||||
pub config: ConfigToml,
|
||||
state: StateStore,
|
||||
pub hooks: HookDispatcher,
|
||||
}
|
||||
|
||||
impl Runtime {
|
||||
pub fn new(config: ConfigToml, state: StateStore, hooks: HookDispatcher) -> Self {
|
||||
Self {
|
||||
config,
|
||||
state,
|
||||
hooks,
|
||||
}
|
||||
pub fn new(config: ConfigToml, state: StateStore) -> Self {
|
||||
Self { config, state }
|
||||
}
|
||||
|
||||
/// Existing compatibility data and receipts; no transcript controller.
|
||||
@@ -103,7 +94,7 @@ mod tests {
|
||||
fn runtime_bookkeeping_keeps_the_legacy_store_read_only() {
|
||||
let store = temp_core_state("read-only-runtime");
|
||||
let before = store.list_threads(Default::default()).unwrap();
|
||||
let mut runtime = Runtime::new(ConfigToml::default(), store, HookDispatcher::default());
|
||||
let mut runtime = Runtime::new(ConfigToml::default(), store);
|
||||
runtime.update_config(ConfigToml::default());
|
||||
assert_eq!(
|
||||
runtime
|
||||
@@ -113,11 +104,7 @@ mod tests {
|
||||
.len(),
|
||||
before.len()
|
||||
);
|
||||
let reopened = Runtime::new(
|
||||
runtime.config.clone(),
|
||||
runtime.state_store().clone(),
|
||||
HookDispatcher::default(),
|
||||
);
|
||||
let reopened = Runtime::new(runtime.config.clone(), runtime.state_store().clone());
|
||||
assert!(
|
||||
reopened
|
||||
.state_store()
|
||||
|
||||
@@ -1,135 +0,0 @@
|
||||
//! `Thread` / `Session` split (issue #5261).
|
||||
//!
|
||||
//! `codewhale`'s `Session` was really a thread. The new split is:
|
||||
//! - `Thread` — durable, persisted, owns the append-only `Journal` and the
|
||||
//! `leafId` cursor. One row in `state.threads`, one directory on disk.
|
||||
//! - `Session` — ephemeral, per-turn / per-engine-lifetime, owns the
|
||||
//! in-memory `TurnContext` plus the live approval/sandbox posture for this
|
||||
//! `SessionId`. Many sessions can attach to one thread over time, but only
|
||||
//! one `Session` drives a turn for a given `ThreadId` at a time.
|
||||
//!
|
||||
//! The canonical RuntimeThreadManager creates sessions without a TUI and drives
|
||||
//! the same Engine turn loop used by mounted clients. These types preserve the
|
||||
//! shared model, append log, prefix stability and message revision state; the
|
||||
//! compatibility Core Runtime owns only configuration, hooks and job bookkeeping.
|
||||
|
||||
use std::path::PathBuf;
|
||||
|
||||
use serde::{Deserialize, Serialize};
|
||||
|
||||
use crate::ids::{SessionId, ThreadId};
|
||||
use crate::journal::Journal;
|
||||
|
||||
/// Durable thread (the former `Session`). One per conversation, persisted in
|
||||
/// `state.threads`. The only new field vs the old `Session` is `leaf_id` — the
|
||||
/// journal cursor — plus the typed `ThreadId`. All other fields keep their
|
||||
/// persisted JSON shape unchanged.
|
||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||
pub struct Thread {
|
||||
pub thread_id: ThreadId,
|
||||
/// Active branch tip. `None` before the first journal header.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub leaf_id: Option<String>,
|
||||
/// Journal (append-only). In-memory projection of the persisted
|
||||
/// `threads/turns/items/events` layout is derived root→leaf.
|
||||
#[serde(default)]
|
||||
pub journal: Journal,
|
||||
pub model: String,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub reasoning_effort: Option<String>,
|
||||
pub workspace: PathBuf,
|
||||
#[serde(default)]
|
||||
pub ephemeral: bool,
|
||||
}
|
||||
|
||||
impl Thread {
|
||||
#[must_use]
|
||||
pub fn new(thread_id: ThreadId, workspace: PathBuf, model: impl Into<String>) -> Self {
|
||||
Self {
|
||||
thread_id,
|
||||
leaf_id: None,
|
||||
journal: Journal::new(),
|
||||
model: model.into(),
|
||||
reasoning_effort: None,
|
||||
workspace,
|
||||
ephemeral: false,
|
||||
}
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn leaf_id(&self) -> Option<&str> {
|
||||
self.leaf_id.as_deref()
|
||||
}
|
||||
|
||||
pub fn set_leaf(&mut self, leaf: Option<String>) {
|
||||
self.leaf_id = leaf;
|
||||
}
|
||||
}
|
||||
|
||||
/// Ephemeral session within a thread (one engine lifetime / one turn's
|
||||
/// live posture). The TUI's `EngineHandle` and the headless `exec` both
|
||||
/// hold a `Session` that points at the same `ThreadId` but with different
|
||||
/// `SessionId`s.
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct Session {
|
||||
pub session_id: SessionId,
|
||||
pub thread_id: ThreadId,
|
||||
/// Model for this session's next turn (may differ from thread default).
|
||||
pub model: String,
|
||||
pub workspace: PathBuf,
|
||||
/// Monotonic `messages_revision` for prefix-cache memoization (carried
|
||||
/// from the former `Session::messages_revision`).
|
||||
pub messages_revision: u64,
|
||||
}
|
||||
|
||||
impl Session {
|
||||
#[must_use]
|
||||
pub fn new(thread_id: ThreadId, workspace: PathBuf, model: impl Into<String>) -> Self {
|
||||
Self {
|
||||
session_id: SessionId::new(),
|
||||
thread_id,
|
||||
model: model.into(),
|
||||
workspace,
|
||||
messages_revision: 0,
|
||||
}
|
||||
}
|
||||
|
||||
pub fn bump_revision(&mut self) {
|
||||
self.messages_revision = self.messages_revision.wrapping_add(1);
|
||||
}
|
||||
}
|
||||
|
||||
/// Split helper: derive a `Session` from an existing `Thread` without
|
||||
/// cloning the journal. Headless and TUI call the same constructor so
|
||||
/// the request shape stays identical.
|
||||
#[must_use]
|
||||
pub fn session_for_thread(thread: &Thread, workspace: PathBuf) -> Session {
|
||||
Session::new(thread.thread_id.clone(), workspace, thread.model.clone())
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
#[test]
|
||||
fn thread_and_session_ids_are_distinct_scopes() {
|
||||
let t = Thread::new(ThreadId::new(), PathBuf::from("/tmp"), "deepseek-v4-flash");
|
||||
let s1 = Session::new(t.thread_id.clone(), PathBuf::from("/tmp"), &t.model);
|
||||
let s2 = Session::new(t.thread_id.clone(), PathBuf::from("/tmp"), &t.model);
|
||||
assert_eq!(s1.thread_id, s2.thread_id);
|
||||
assert_ne!(s1.session_id, s2.session_id);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn leaf_is_moved_not_rewritten() {
|
||||
let mut t = Thread::new(ThreadId::new(), PathBuf::from("/tmp"), "m");
|
||||
let a = t.journal.append("header", serde_json::json!({}));
|
||||
let b = t.journal.append("user", serde_json::json!("b"));
|
||||
t.leaf_id = t.journal.leaf_id.clone();
|
||||
assert_eq!(t.leaf_id.as_deref(), Some(b.as_str()));
|
||||
assert!(t.journal.branch_to(&a));
|
||||
t.leaf_id = t.journal.leaf_id.clone();
|
||||
assert_eq!(t.leaf_id.as_deref(), Some(a.as_str()));
|
||||
assert_eq!(t.journal.len(), 2); // history never rewritten; branching only moved the leaf
|
||||
}
|
||||
}
|
||||
@@ -79,7 +79,6 @@ codewhale-app-server-protocol = { path = "../app-server-protocol", version = "0.
|
||||
codewhale-sanitize = { path = "../sanitize", version = "0.10.3" }
|
||||
codewhale-memory = { path = "../memory", version = "0.10.3" }
|
||||
anyhow.workspace = true
|
||||
codewhale-agent = { path = "../agent", version = "0.10.3" }
|
||||
codewhale-agent-contract = { path = "../agent-contract", version = "0.10.3" }
|
||||
codewhale-config = { path = "../config", version = "0.10.3" }
|
||||
codewhale-command-contract = { path = "../command-contract", version = "0.10.3" }
|
||||
@@ -172,6 +171,7 @@ sha2.workspace = true
|
||||
# Reuse the locked cryptographic implementation for exact-call user decisions.
|
||||
ring = "0.17"
|
||||
codewhale-localization = { path = "../localization", version = "0.10.3" }
|
||||
codewhale-ratatui = { path = "../../vendor/codewhale-ratatui", version = "0.2.0" }
|
||||
shell-words = "1.1.1"
|
||||
|
||||
wiremock = { version = "0.6", optional = true }
|
||||
@@ -203,14 +203,9 @@ codewhale-util = { path = "../util", version = "0.10.3", features = ["test-suppo
|
||||
codewhale-models = { path = "../models", version = "0.10.3", features = [
|
||||
"test-support",
|
||||
] }
|
||||
cucumber = "0.23.0"
|
||||
wiremock = "0.6"
|
||||
tiny_http = "0.12"
|
||||
pretty_assertions = "1.4"
|
||||
rio-vt = "0.5.1"
|
||||
rusqlite.workspace = true
|
||||
schemars = { version = "1.2.1", features = ["derive", "preserve_order"] }
|
||||
tokio-tungstenite = "0.30"
|
||||
|
||||
[target.'cfg(unix)'.dependencies]
|
||||
libc = "0.2"
|
||||
@@ -219,9 +214,6 @@ libc = "0.2"
|
||||
windows-sys = { version = "0.61.2", features = ["Wdk_Storage_FileSystem", "Win32_System_IO", "Win32_Foundation", "Win32_Security", "Win32_Security_Authorization", "Win32_Security_Isolation", "Win32_Storage_FileSystem", "Win32_System_LibraryLoader", "Win32_System_Pipes", "Win32_System_Threading", "Win32_System_SystemServices", "Win32_System_WindowsProgramming"] }
|
||||
|
||||
|
||||
[target.'cfg(any(target_os = "macos", target_os = "windows", all(target_os = "linux", not(target_env = "ohos"))))'.dependencies]
|
||||
arboard = { version = "3.4", features = ["wayland-data-control"] }
|
||||
|
||||
[target.'cfg(not(target_env = "ohos"))'.dependencies]
|
||||
portable-pty = "0.9"
|
||||
|
||||
|
||||
+1
-1
@@ -18,7 +18,7 @@ var ErrorCode = {
|
||||
Denied: -32003,
|
||||
Cancelled: -32800
|
||||
};
|
||||
var DSH_SERVICES = ["workspace", "llm", "network", "settings", "catalog", "terminal", "remote"];
|
||||
var DSH_SERVICES = ["workspace", "llm", "network", "settings", "catalog", "terminal", "remote", "plugins"];
|
||||
var METHODS = [
|
||||
{ name: "host/initialize", direction: "core_to_host", request: true, params: "InitializeParams", tiers: ["plugin", "builtin"] },
|
||||
{ name: "host/ping", direction: "core_to_host", request: true, params: "EmptyParams", tiers: ["plugin", "builtin"] },
|
||||
|
||||
@@ -0,0 +1,193 @@
|
||||
import { Service } from '@deepseek-ai/cordis'
|
||||
import { ErrorCode } from '../protocol.ts'
|
||||
import { RpcError } from '../rpc.ts'
|
||||
import type { AdapterHost, DshAdapter } from './adapters.ts'
|
||||
|
||||
export interface ApprovedRoute {
|
||||
provider: string
|
||||
base_url: string
|
||||
default_model: string | null
|
||||
models: string[]
|
||||
}
|
||||
|
||||
export interface ResolvedRoute extends ApprovedRoute {
|
||||
model: string | null
|
||||
}
|
||||
|
||||
export interface InstallPlan {
|
||||
status: 'review_required' | 'already_present'
|
||||
package: string
|
||||
version: string
|
||||
plugin: string
|
||||
spec?: string
|
||||
command: string
|
||||
message: string
|
||||
}
|
||||
|
||||
export type BalanceAnswer =
|
||||
| { status: 'known', currency: string, total: string, topped_up: string, granted: string }
|
||||
| { status: 'unknown' }
|
||||
| { status: 'absent' }
|
||||
|
||||
interface AccountWallet {
|
||||
currency: string
|
||||
balance: string
|
||||
}
|
||||
|
||||
type AccountBalance = { status: 'ready', value: AccountWallet[], bonusWallets: AccountWallet[] } | { status: 'failed' }
|
||||
|
||||
interface ChangeResult {
|
||||
changed: false
|
||||
application: 'failed'
|
||||
stage: 'install' | 'remove'
|
||||
target: string
|
||||
error: { code: string, diagnostic: string, message: string }
|
||||
}
|
||||
|
||||
const EXACT_VERSION_ONLY = 'Codewhale plans a plugin install only for one exact npm version, written [email protected]'
|
||||
const REMOVE_IN_CODEWHALE = 'Codewhale removes a plugin only from its own plugin manager, after you disable it: /plugin uninstall'
|
||||
const WITHHELD_ACCOUNT_METHODS = [
|
||||
'getState', 'getProfile', 'getUnnotifiedBonuses', 'ackBonusNotified', 'startSignIn', 'cancelSignIn', 'signOut', 'watch',
|
||||
'resolveToken', 'rejectToken', 'getPlatformSession', 'getDeviceIdentity',
|
||||
] as const
|
||||
|
||||
function invalid(what: string): RpcError {
|
||||
return new RpcError(ErrorCode.Internal, `invalid catalog broker ${what}`)
|
||||
}
|
||||
|
||||
function record(value: unknown, what: string): Record<string, unknown> {
|
||||
if (value === null || typeof value !== 'object' || Array.isArray(value)) throw invalid(what)
|
||||
return value as Record<string, unknown>
|
||||
}
|
||||
|
||||
function text(value: unknown, what: string): string {
|
||||
if (typeof value !== 'string' || value.length === 0) throw invalid(what)
|
||||
return value
|
||||
}
|
||||
|
||||
function named(value: unknown, what: string): string {
|
||||
if (typeof value !== 'string' || value.length === 0) throw new RpcError(ErrorCode.InvalidParams, `${what} is a non-empty string`)
|
||||
return value
|
||||
}
|
||||
|
||||
function approvedRoute(value: unknown): ApprovedRoute {
|
||||
const row = record(value, 'route')
|
||||
const models = row.models
|
||||
const defaultModel = row.default_model
|
||||
if (!Array.isArray(models) || models.some((model) => typeof model !== 'string') || (defaultModel !== null && typeof defaultModel !== 'string')) throw invalid('route')
|
||||
return { provider: text(row.provider, 'route'), base_url: text(row.base_url, 'route'), default_model: defaultModel, models: [...models] }
|
||||
}
|
||||
|
||||
export async function approvedRoutes(host: AdapterHost, ctx: unknown): Promise<ApprovedRoute[]> {
|
||||
const routes = record(await host.broker(ctx, 'catalog', 'routes.list', {}), 'routes').routes
|
||||
if (!Array.isArray(routes)) throw invalid('routes')
|
||||
return routes.map(approvedRoute)
|
||||
}
|
||||
|
||||
export async function resolveRoute(host: AdapterHost, ctx: unknown, provider: unknown, model?: unknown): Promise<ResolvedRoute> {
|
||||
const input = model === undefined || model === null
|
||||
? { provider: named(provider, 'a provider route') }
|
||||
: { provider: named(provider, 'a provider route'), model: named(model, 'a model') }
|
||||
const answer = record(await host.broker(ctx, 'catalog', 'routes.resolve', input), 'route')
|
||||
const resolved = answer.model
|
||||
if (resolved !== null && typeof resolved !== 'string') throw invalid('route')
|
||||
return { ...approvedRoute(answer.route), model: resolved }
|
||||
}
|
||||
|
||||
export async function accountBalance(host: AdapterHost, ctx: unknown): Promise<BalanceAnswer> {
|
||||
const answer = record(await host.broker(ctx, 'catalog', 'balance', {}), 'balance')
|
||||
const status = answer.status
|
||||
if (status === 'unknown' || status === 'absent') return { status }
|
||||
const toppedUp = answer.topped_up
|
||||
const granted = answer.granted
|
||||
if (status !== 'known' || typeof toppedUp !== 'string' || typeof granted !== 'string') throw invalid('balance')
|
||||
return { status, currency: text(answer.currency, 'balance'), total: text(answer.total, 'balance'), topped_up: toppedUp, granted }
|
||||
}
|
||||
|
||||
export async function planInstall(host: AdapterHost, ctx: unknown, spec: unknown, registry?: unknown): Promise<InstallPlan> {
|
||||
const exact = typeof spec === 'string' ? spec.lastIndexOf('@') : -1
|
||||
if (typeof spec !== 'string' || exact <= 0 || exact === spec.length - 1) throw new RpcError(ErrorCode.InvalidParams, EXACT_VERSION_ONLY)
|
||||
const request = { package: spec.slice(0, exact), version: spec.slice(exact + 1) }
|
||||
const input = registry === undefined || registry === null ? request : { ...request, registry: named(registry, 'a registry URL') }
|
||||
const plan = record(await host.broker(ctx, 'catalog', 'install.plan', input), 'install plan')
|
||||
const status = plan.status
|
||||
const planned = plan.spec
|
||||
if ((status !== 'review_required' && status !== 'already_present') || (planned !== undefined && typeof planned !== 'string')) throw invalid('install plan')
|
||||
return {
|
||||
status,
|
||||
package: text(plan.package, 'install plan'),
|
||||
version: text(plan.version, 'install plan'),
|
||||
plugin: text(plan.plugin, 'install plan'),
|
||||
...(planned === undefined ? {} : { spec: planned }),
|
||||
command: text(plan.command, 'install plan'),
|
||||
message: text(plan.message, 'install plan'),
|
||||
}
|
||||
}
|
||||
|
||||
function notChanged(stage: ChangeResult['stage'], target: unknown, code: string, diagnostic: string): ChangeResult {
|
||||
return { changed: false, application: 'failed', stage, target: typeof target === 'string' ? target : '', error: { code, diagnostic, message: diagnostic } }
|
||||
}
|
||||
|
||||
function declined(error: unknown): string | undefined {
|
||||
if (!(error instanceof Error)) return undefined
|
||||
if (error instanceof RpcError && error.code === ErrorCode.InvalidParams && error.data === undefined) return error.message
|
||||
const refusal = (error as { data?: { dsh_refusal?: unknown } }).data?.dsh_refusal
|
||||
return refusal === 'refused' || refusal === 'invalid_input' ? error.message : undefined
|
||||
}
|
||||
|
||||
export const pluginManagerAdapter: DshAdapter = {
|
||||
service: 'pluginManager',
|
||||
define(host) {
|
||||
class PluginManagerService extends Service {
|
||||
constructor(ctx: any) { super(ctx, 'pluginManager') }
|
||||
|
||||
async installBundle(spec: unknown, options?: { registry?: unknown } | null): Promise<ChangeResult> {
|
||||
try {
|
||||
const plan = await planInstall(host, this.ctx, spec, options?.registry)
|
||||
return notChanged('install', spec, plan.status === 'already_present' ? 'already-installed' : 'management-required', plan.message)
|
||||
} catch (error) {
|
||||
const diagnostic = declined(error)
|
||||
if (diagnostic === undefined) throw error
|
||||
return notChanged('install', spec, 'invalid-spec', diagnostic)
|
||||
}
|
||||
}
|
||||
|
||||
async removeBundle(target: unknown): Promise<ChangeResult> {
|
||||
return notChanged('remove', target, 'management-required', REMOVE_IN_CODEWHALE)
|
||||
}
|
||||
|
||||
async cancelInstall(): Promise<{ status: 'not-running' }> {
|
||||
return { status: 'not-running' }
|
||||
}
|
||||
}
|
||||
Object.freeze(PluginManagerService.prototype)
|
||||
return PluginManagerService
|
||||
},
|
||||
}
|
||||
|
||||
export const deepseekAccountAdapter: DshAdapter = {
|
||||
service: 'deepseekAccount',
|
||||
define(host) {
|
||||
class DeepSeekAccountService extends Service {
|
||||
constructor(ctx: any) { super(ctx, 'deepseekAccount') }
|
||||
|
||||
async getBalance(): Promise<AccountBalance | null> {
|
||||
const answer = await accountBalance(host, this.ctx)
|
||||
if (answer.status === 'absent') return null
|
||||
if (answer.status === 'unknown') return { status: 'failed' }
|
||||
const { currency, total, topped_up: toppedUp, granted } = answer
|
||||
const wallet = (balance: string): AccountWallet[] => balance.length > 0 ? [{ currency, balance }] : []
|
||||
return { status: 'ready', value: wallet(toppedUp.length > 0 ? toppedUp : total), bonusWallets: wallet(granted) }
|
||||
}
|
||||
}
|
||||
for (const method of WITHHELD_ACCOUNT_METHODS) {
|
||||
Object.defineProperty(DeepSeekAccountService.prototype, method, {
|
||||
value() {
|
||||
throw new RpcError(ErrorCode.NotAvailable, `deepseekAccount.${method} is not provided: Codewhale answers a read-only balance and never gives a plugin an account credential or a sign-in`)
|
||||
},
|
||||
})
|
||||
}
|
||||
Object.freeze(DeepSeekAccountService.prototype)
|
||||
return DeepSeekAccountService
|
||||
},
|
||||
}
|
||||
@@ -0,0 +1,91 @@
|
||||
import { Service } from '@deepseek-ai/cordis'
|
||||
import { ErrorCode } from '../protocol.ts'
|
||||
import { RpcError } from '../rpc.ts'
|
||||
import type { AdapterHost, DshAdapter } from './adapters.ts'
|
||||
|
||||
export interface SettingsDescriptor {
|
||||
ns: string
|
||||
writable: boolean
|
||||
roots: string[]
|
||||
value: Record<string, unknown>
|
||||
revision: string
|
||||
applied: boolean | null
|
||||
applies: 'reload'
|
||||
}
|
||||
|
||||
export type SettingsPathOp =
|
||||
| { op: 'set', path: readonly string[], value: unknown }
|
||||
| { op: 'unset', path: readonly string[] }
|
||||
|
||||
export interface SettingsWrite {
|
||||
written: boolean
|
||||
revision: string
|
||||
applies: 'reload'
|
||||
}
|
||||
|
||||
export class SettingsConflictError extends Error {
|
||||
readonly code = 'SETTINGS_CONFLICT'
|
||||
constructor(readonly ns: string, readonly expected: string | undefined, readonly actual: string) {
|
||||
super(`settings namespace "${ns}" changed since it was read`)
|
||||
this.name = 'SettingsConflictError'
|
||||
}
|
||||
}
|
||||
|
||||
function plain(value: unknown, what: string): Record<string, unknown> {
|
||||
if (typeof value !== 'object' || value === null || Array.isArray(value)) throw new RpcError(ErrorCode.InvalidParams, `${what} is a plain object`)
|
||||
return value as Record<string, unknown>
|
||||
}
|
||||
|
||||
function revision(value: unknown): string | undefined {
|
||||
if (value === undefined) return undefined
|
||||
if (typeof value !== 'string' || value.length === 0) throw new RpcError(ErrorCode.InvalidParams, 'an expected revision is the revision string describe returned')
|
||||
return value
|
||||
}
|
||||
|
||||
function descriptor(value: unknown): SettingsDescriptor {
|
||||
const row = value as Partial<SettingsDescriptor> | null
|
||||
if (row === null || typeof row !== 'object' || typeof row.ns !== 'string' || typeof row.revision !== 'string' || typeof row.writable !== 'boolean'
|
||||
|| !Array.isArray(row.roots) || typeof row.value !== 'object' || row.value === null || row.applies !== 'reload') {
|
||||
throw new RpcError(ErrorCode.Internal, 'invalid settings broker response')
|
||||
}
|
||||
return { ns: row.ns, writable: row.writable, roots: row.roots.map(String), value: row.value, revision: row.revision, applied: typeof row.applied === 'boolean' ? row.applied : null, applies: 'reload' }
|
||||
}
|
||||
|
||||
export const settingsAdapter: DshAdapter = {
|
||||
service: 'settings',
|
||||
define(host: AdapterHost) {
|
||||
class SettingsService extends Service {
|
||||
constructor(ctx: any) { super(ctx, 'settings') }
|
||||
|
||||
async describe(): Promise<SettingsDescriptor[]> {
|
||||
return [descriptor(await host.broker(this.ctx, 'settings', 'describe', {}))]
|
||||
}
|
||||
|
||||
async update(ns: unknown, patch: unknown, expectedRevision?: unknown): Promise<SettingsWrite> {
|
||||
return this.write(ns, 'update', { patch: plain(patch, 'a settings patch') }, expectedRevision)
|
||||
}
|
||||
|
||||
async replace(ns: unknown, section: unknown, expectedRevision?: unknown): Promise<SettingsWrite> {
|
||||
return this.write(ns, 'replace', { value: plain(section, 'a settings section') }, expectedRevision)
|
||||
}
|
||||
|
||||
async mutate(ns: unknown, ops: unknown, expectedRevision?: unknown): Promise<SettingsWrite> {
|
||||
if (!Array.isArray(ops)) throw new RpcError(ErrorCode.InvalidParams, 'settings edits are an array of path operations')
|
||||
return this.write(ns, 'mutate', { ops }, expectedRevision)
|
||||
}
|
||||
|
||||
private async write(ns: unknown, method: 'update' | 'replace' | 'mutate', input: Record<string, unknown>, expectedRevision: unknown): Promise<SettingsWrite> {
|
||||
if (typeof ns !== 'string' || ns.length === 0) throw new RpcError(ErrorCode.InvalidParams, 'a settings namespace is a non-empty string')
|
||||
const owner = host.ownerOf(this.ctx)
|
||||
if (owner === undefined || ns !== owner.pluginName) throw new RpcError(ErrorCode.Refused, 'a plugin may edit only its own settings namespace')
|
||||
const expected = revision(expectedRevision)
|
||||
const result = await host.broker(this.ctx, 'settings', method, expected === undefined ? input : { ...input, expected_revision: expected }) as { written?: unknown, conflict?: unknown, revision?: unknown } | null
|
||||
if (result === null || typeof result !== 'object' || typeof result.written !== 'boolean' || typeof result.revision !== 'string') throw new RpcError(ErrorCode.Internal, 'invalid settings broker response')
|
||||
if (result.conflict === true) throw new SettingsConflictError(ns, expected, result.revision)
|
||||
return { written: result.written, revision: result.revision, applies: 'reload' }
|
||||
}
|
||||
}
|
||||
Object.freeze(SettingsService.prototype)
|
||||
return SettingsService
|
||||
},
|
||||
}
|
||||
@@ -25,7 +25,7 @@ export const ErrorCode = {
|
||||
|
||||
export type Direction = 'core_to_host' | 'host_to_core'
|
||||
|
||||
export const DSH_SERVICES = ['workspace', 'llm', 'network', 'settings', 'catalog', 'terminal', 'remote'] as const
|
||||
export const DSH_SERVICES = ['workspace', 'llm', 'network', 'settings', 'catalog', 'terminal', 'remote', 'plugins'] as const
|
||||
export type DshService = typeof DSH_SERVICES[number]
|
||||
|
||||
/** Every method either side may send, and the trust tiers it is allowed on; nothing else is admitted. */
|
||||
|
||||
@@ -0,0 +1,158 @@
|
||||
import { test, before } from 'node:test'
|
||||
import assert from 'node:assert/strict'
|
||||
import { mkdtempSync, rmSync } from 'node:fs'
|
||||
import { join, dirname } from 'node:path'
|
||||
import { fileURLToPath, pathToFileURL } from 'node:url'
|
||||
import { build } from 'esbuild'
|
||||
|
||||
const here = dirname(fileURLToPath(import.meta.url))
|
||||
let catalog
|
||||
|
||||
before(async () => {
|
||||
const dir = mkdtempSync(join(here, '..', 'node_modules', '.cw-catalog-'))
|
||||
const outfile = join(dir, 'catalog.mjs')
|
||||
await build({ entryPoints: [join(here, '../src/dsh/catalog.ts')], outfile, bundle: true, platform: 'node', format: 'esm', packages: 'external', absWorkingDir: join(here, '..'), logLevel: 'silent' })
|
||||
catalog = await import(pathToFileURL(outfile).href)
|
||||
process.on('exit', () => rmSync(dir, { recursive: true, force: true }))
|
||||
})
|
||||
|
||||
function brokerHost(answers) {
|
||||
const calls = []
|
||||
return {
|
||||
calls,
|
||||
host: {
|
||||
tier: 'plugin',
|
||||
broker: async (ctx, service, method, input) => {
|
||||
calls.push({ service, method, input })
|
||||
const answer = typeof answers[method] === 'function' ? answers[method](input) : answers[method]
|
||||
if (answer instanceof Error) throw answer
|
||||
return answer
|
||||
},
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
function serviceOf(adapter, host) {
|
||||
const service = Object.create(adapter.define(host).prototype)
|
||||
service.ctx = {}
|
||||
return service
|
||||
}
|
||||
|
||||
const brokerRefusal = (code, refusal, message) => Object.assign(new Error(message), { code, data: { dsh_refusal: refusal, service: 'catalog' } })
|
||||
|
||||
test('a balance widget reads an absent account, an unknown balance and a known balance, and never a key', async () => {
|
||||
const answers = { balance: { status: 'absent' } }
|
||||
const { host, calls } = brokerHost(answers)
|
||||
const account = serviceOf(catalog.deepseekAccountAdapter, host)
|
||||
const client = { version: '0.4.2', locale: 'zh_CN', timezoneOffsetSeconds: 28800 }
|
||||
|
||||
assert.equal(await account.getBalance(client), null)
|
||||
answers.balance = { status: 'unknown' }
|
||||
assert.deepEqual(await account.getBalance(client), { status: 'failed' })
|
||||
answers.balance = { status: 'known', currency: 'CNY', total: '123.45', topped_up: '100.00', granted: '23.45' }
|
||||
const ready = await account.getBalance(client)
|
||||
assert.deepEqual(ready, { status: 'ready', value: [{ currency: 'CNY', balance: '100.00' }], bonusWallets: [{ currency: 'CNY', balance: '23.45' }] })
|
||||
const shown = [...ready.value, ...ready.bonusWallets].reduce((sum, wallet) => sum + Number(wallet.balance), 0)
|
||||
assert.equal(shown.toFixed(2), '123.45')
|
||||
answers.balance = { status: 'known', currency: 'USD', total: '12.50', topped_up: '', granted: '' }
|
||||
assert.deepEqual(await account.getBalance(client), { status: 'ready', value: [{ currency: 'USD', balance: '12.50' }], bonusWallets: [] })
|
||||
|
||||
assert.deepEqual(calls.map((call) => [call.service, call.method, call.input]), Array(4).fill(['catalog', 'balance', {}]))
|
||||
for (const method of ['resolveToken', 'getPlatformSession', 'getState', 'startSignIn', 'signOut', 'rejectToken']) {
|
||||
assert.throws(() => account[method]('https://api.deepseek.com'), (error) => error.code === -32001 && error.message.includes(`deepseekAccount.${method} is not provided`))
|
||||
}
|
||||
assert.equal(calls.length, 4)
|
||||
|
||||
answers.balance = { status: 'known', currency: 'CNY', total: '1', topped_up: '1', granted: '0', api_key: 'sk-raw' }
|
||||
assert.deepEqual(Object.keys(await catalog.accountBalance(host, {})).sort(), ['currency', 'granted', 'status', 'topped_up', 'total'])
|
||||
answers.balance = { status: 'ready', value: [] }
|
||||
await assert.rejects(account.getBalance(client), /invalid catalog broker balance/)
|
||||
answers.balance = brokerRefusal(-32001, 'not_available', 'the catalog broker is not available yet')
|
||||
await assert.rejects(account.getBalance(client), /not available yet/)
|
||||
})
|
||||
|
||||
test('a market plugin asking to install gets the reviewed-install answer, and nothing installs or removes', async () => {
|
||||
const review = {
|
||||
status: 'review_required', package: '@acme/review', version: '1.10.0', plugin: 'review', spec: 'npm:@acme/[email protected]',
|
||||
command: '/plugin install npm:@acme/[email protected]',
|
||||
message: 'Codewhale installs a plugin only through its reviewed install flow; nothing was installed. Review and install @acme/[email protected] with `/plugin install npm:@acme/[email protected]`.',
|
||||
}
|
||||
const answers = { 'install.plan': review }
|
||||
const { host, calls } = brokerHost(answers)
|
||||
const manager = serviceOf(catalog.pluginManagerAdapter, host)
|
||||
|
||||
const requested = await manager.installBundle('@acme/[email protected]', { requestId: 'r1', registry: 'https://registry.example.com' })
|
||||
assert.deepEqual(requested, {
|
||||
changed: false, application: 'failed', stage: 'install', target: '@acme/[email protected]',
|
||||
error: { code: 'management-required', diagnostic: review.message, message: review.message },
|
||||
})
|
||||
assert.deepEqual(calls[0], { service: 'catalog', method: 'install.plan', input: { package: '@acme/review', version: '1.10.0', registry: 'https://registry.example.com' } })
|
||||
await manager.installBundle('[email protected]')
|
||||
assert.deepEqual(calls[1].input, { package: 'dsh-demo', version: '1.2.3' })
|
||||
|
||||
answers['install.plan'] = { status: 'already_present', package: 'dsh-demo', version: '1.2.3', plugin: 'dsh-demo', command: '/plugin trust dsh-demo', message: 'A plugin named `dsh-demo` is already present; nothing was installed.' }
|
||||
assert.equal((await manager.installBundle('[email protected]')).error.code, 'already-installed')
|
||||
|
||||
answers['install.plan'] = brokerRefusal(-32002, 'refused', '`dsh-demo@^1.2.3` is not an exact npm package version Codewhale can fetch')
|
||||
const range = await manager.installBundle('dsh-demo@^1.2.3')
|
||||
assert.equal(range.error.code, 'invalid-spec')
|
||||
assert.match(range.error.diagnostic, /not an exact npm package version/)
|
||||
|
||||
const sent = calls.length
|
||||
for (const spec of ['dsh-demo', '@acme/review', 'git+https://github.com/acme/review.git#0123456789abcdef0123456789abcdef01234567', 'dsh-demo@', 7]) {
|
||||
const refused = await manager.installBundle(spec)
|
||||
assert.equal(refused.error.code, 'invalid-spec', String(spec))
|
||||
assert.equal(refused.application, 'failed')
|
||||
}
|
||||
assert.equal((await manager.installBundle('[email protected]', { registry: 7 })).error.code, 'invalid-spec')
|
||||
assert.deepEqual(await manager.removeBundle('dsh-demo'), {
|
||||
changed: false, application: 'failed', stage: 'remove', target: 'dsh-demo',
|
||||
error: { code: 'management-required', diagnostic: 'Codewhale removes a plugin only from its own plugin manager, after you disable it: /plugin uninstall', message: 'Codewhale removes a plugin only from its own plugin manager, after you disable it: /plugin uninstall' },
|
||||
})
|
||||
assert.deepEqual(await manager.cancelInstall('r1'), { status: 'not-running' })
|
||||
assert.equal(calls.length, sent, 'a spec that is not name@exact-version, a removal and a cancel never reach the broker')
|
||||
|
||||
answers['install.plan'] = brokerRefusal(-32002, 'ticket_refused', 'the invocation this dsh/broker:catalog belongs to has ended')
|
||||
await assert.rejects(manager.installBundle('[email protected]'), /has ended/)
|
||||
answers['install.plan'] = { status: 'installed', package: 'dsh-demo', version: '1.2.3', plugin: 'dsh-demo', command: 'x', message: 'x' }
|
||||
await assert.rejects(manager.installBundle('[email protected]'), /invalid catalog broker install plan/)
|
||||
})
|
||||
|
||||
test('a model-proxy directory is built from approved provider routes, and an unapproved route is the refusal', async () => {
|
||||
const gateway = { provider: 'gateway', base_url: 'https://gateway.example/api', default_model: 'tiny-model', models: ['tiny-model', 'large-model'] }
|
||||
const answers = {
|
||||
'routes.list': { routes: [gateway] },
|
||||
'routes.resolve': (input) => input.provider === 'gateway'
|
||||
? { route: gateway, model: input.model ?? gateway.default_model }
|
||||
: brokerRefusal(-32002, 'refused', `\`${input.provider}\` is not a provider route approved for this plugin`),
|
||||
}
|
||||
const { host, calls } = brokerHost(answers)
|
||||
|
||||
const routes = await catalog.approvedRoutes(host, {})
|
||||
const directory = {
|
||||
providers: routes.map((route) => ({ provider: route.provider, active: true })),
|
||||
models: routes.map((route) => ({ provider: route.provider, models: route.models.map((id) => ({ id })) })),
|
||||
}
|
||||
assert.deepEqual(directory, {
|
||||
providers: [{ provider: 'gateway', active: true }],
|
||||
models: [{ provider: 'gateway', models: [{ id: 'tiny-model' }, { id: 'large-model' }] }],
|
||||
})
|
||||
|
||||
assert.deepEqual(await catalog.resolveRoute(host, {}, 'gateway', 'large-model'), { ...gateway, model: 'large-model' })
|
||||
assert.deepEqual(await catalog.resolveRoute(host, {}, 'gateway'), { ...gateway, model: 'tiny-model' })
|
||||
await assert.rejects(catalog.resolveRoute(host, {}, 'openai', 'gpt-x'), /not a provider route approved for this plugin/)
|
||||
assert.deepEqual(calls.map((call) => [call.service, call.method, call.input]), [
|
||||
['catalog', 'routes.list', {}],
|
||||
['catalog', 'routes.resolve', { provider: 'gateway', model: 'large-model' }],
|
||||
['catalog', 'routes.resolve', { provider: 'gateway' }],
|
||||
['catalog', 'routes.resolve', { provider: 'openai', model: 'gpt-x' }],
|
||||
])
|
||||
|
||||
await assert.rejects(catalog.resolveRoute(host, {}, '', 'x'), (error) => error.code === -32602)
|
||||
await assert.rejects(catalog.resolveRoute(host, {}, 'gateway', 7), (error) => error.code === -32602)
|
||||
assert.equal(calls.length, 4)
|
||||
answers['routes.list'] = { routes: [{ provider: 'gateway', base_url: 'https://gateway.example/api', default_model: null, models: [7] }] }
|
||||
await assert.rejects(catalog.approvedRoutes(host, {}), /invalid catalog broker route/)
|
||||
answers['routes.list'] = [gateway]
|
||||
await assert.rejects(catalog.approvedRoutes(host, {}), /invalid catalog broker routes/)
|
||||
})
|
||||
@@ -0,0 +1,83 @@
|
||||
import { test, before } from 'node:test'
|
||||
import assert from 'node:assert/strict'
|
||||
import { mkdtempSync, rmSync } from 'node:fs'
|
||||
import { join, dirname } from 'node:path'
|
||||
import { fileURLToPath, pathToFileURL } from 'node:url'
|
||||
import { build } from 'esbuild'
|
||||
|
||||
const here = dirname(fileURLToPath(import.meta.url))
|
||||
let settingsAdapter
|
||||
let SettingsConflictError
|
||||
|
||||
before(async () => {
|
||||
const dir = mkdtempSync(join(here, '..', 'node_modules', '.cw-settings-'))
|
||||
const outfile = join(dir, 'settings.mjs')
|
||||
await build({ entryPoints: [join(here, '../src/dsh/settings.ts')], outfile, bundle: true, platform: 'node', format: 'esm', packages: 'external', absWorkingDir: join(here, '..'), logLevel: 'silent' })
|
||||
;({ settingsAdapter, SettingsConflictError } = await import(pathToFileURL(outfile).href))
|
||||
process.on('exit', () => rmSync(dir, { recursive: true, force: true }))
|
||||
})
|
||||
|
||||
function service(answers, pluginName = 'fixture.plugin') {
|
||||
const calls = []
|
||||
const host = {
|
||||
tier: 'plugin',
|
||||
ownerOf: () => ({ pluginName }),
|
||||
broker: async (ctx, name, method, input) => {
|
||||
calls.push({ name, method, input })
|
||||
const answer = answers[method]
|
||||
if (answer instanceof Error) throw answer
|
||||
return answer
|
||||
},
|
||||
}
|
||||
const instance = Object.create(settingsAdapter.define(host).prototype)
|
||||
instance.ctx = {}
|
||||
return { settings: instance, calls }
|
||||
}
|
||||
|
||||
const row = { ns: 'fixture.plugin', writable: true, roots: ['model'], value: { model: 'small' }, revision: 'r1', applied: true, applies: 'reload' }
|
||||
|
||||
test('settings read and edit go to the settings broker as typed methods', async () => {
|
||||
const { settings, calls } = service({
|
||||
describe: row,
|
||||
update: { written: true, conflict: false, revision: 'r2', applies: 'reload' },
|
||||
replace: { written: true, conflict: false, revision: 'r3', applies: 'reload' },
|
||||
mutate: { written: false, conflict: false, revision: 'r3', applies: 'reload' },
|
||||
})
|
||||
assert.deepEqual(await settings.describe(), [row])
|
||||
assert.deepEqual(await settings.update('fixture.plugin', { model: 'large' }, 'r1'), { written: true, revision: 'r2', applies: 'reload' })
|
||||
await settings.replace('fixture.plugin', { model: 'tiny' })
|
||||
assert.equal((await settings.mutate('fixture.plugin', [{ op: 'unset', path: ['model'] }])).written, false)
|
||||
assert.deepEqual(calls, [
|
||||
{ name: 'settings', method: 'describe', input: {} },
|
||||
{ name: 'settings', method: 'update', input: { patch: { model: 'large' }, expected_revision: 'r1' } },
|
||||
{ name: 'settings', method: 'replace', input: { value: { model: 'tiny' } } },
|
||||
{ name: 'settings', method: 'mutate', input: { ops: [{ op: 'unset', path: ['model'] }] } },
|
||||
])
|
||||
})
|
||||
|
||||
test('another namespace, a malformed edit and a malformed answer never become a broker write', async () => {
|
||||
const { settings, calls } = service({ describe: { ns: 'fixture.plugin' }, update: { written: 'yes' } })
|
||||
await assert.rejects(settings.update('other.plugin', { model: 'x' }), /only its own settings namespace/)
|
||||
await assert.rejects(settings.update('', { model: 'x' }), /non-empty string/)
|
||||
await assert.rejects(settings.update('fixture.plugin', ['model']), /plain object/)
|
||||
await assert.rejects(settings.replace('fixture.plugin', null), /plain object/)
|
||||
await assert.rejects(settings.mutate('fixture.plugin', { op: 'set' }), /array of path operations/)
|
||||
await assert.rejects(settings.update('fixture.plugin', { model: 'x' }, 7), /expected revision/)
|
||||
assert.deepEqual(calls, [])
|
||||
await assert.rejects(settings.describe(), /invalid settings broker response/)
|
||||
await assert.rejects(settings.update('fixture.plugin', { model: 'x' }), /invalid settings broker response/)
|
||||
})
|
||||
|
||||
test('a stale edit is a conflict and a broker refusal reaches the plugin as the refusal', async () => {
|
||||
const stale = service({ update: { written: false, conflict: true, revision: 'r9', applies: 'reload' } })
|
||||
await assert.rejects(stale.settings.update('fixture.plugin', { model: 'x' }, 'r1'), (error) => {
|
||||
assert.ok(error instanceof SettingsConflictError)
|
||||
assert.equal(error.code, 'SETTINGS_CONFLICT')
|
||||
assert.equal(error.expected, 'r1')
|
||||
assert.equal(error.actual, 'r9')
|
||||
return true
|
||||
})
|
||||
const refused = service({ update: new Error('that setting is outside this plugin\'s reviewed settings'), describe: new Error('the settings broker is not available yet') })
|
||||
await assert.rejects(refused.settings.update('fixture.plugin', { internal: 1 }), /outside this plugin's reviewed settings/)
|
||||
await assert.rejects(refused.settings.describe(), /not available yet/)
|
||||
})
|
||||
@@ -56,7 +56,7 @@ use codewhale_models::{
|
||||
ContentBlock, Message, MessageRequest, MessageResponse, SystemPrompt, Usage,
|
||||
};
|
||||
use codewhale_runtime::logging;
|
||||
use codewhale_secrets::sanitize::redact_url_for_display;
|
||||
use codewhale_sanitize::sanitize::redact_url_for_display;
|
||||
|
||||
/// Every provider request that can feed the interactive TUI's attached CWC run
|
||||
/// takes a shared permit at this lowest common dispatch seam. Runtime Chat holds
|
||||
|
||||
@@ -115,7 +115,7 @@ impl RouteShape {
|
||||
/// Which endpoint this request would be POSTed to, as typed facts.
|
||||
///
|
||||
/// `url` is the real, unredacted target: production needs it to send. Every
|
||||
/// display surface must go through [`codewhale_secrets::sanitize::redact_url_for_display`] rather
|
||||
/// display surface must go through [`codewhale_sanitize::sanitize::redact_url_for_display`] rather
|
||||
/// than printing it, and the manifest only ever publishes the redacted
|
||||
/// scheme/host and a fingerprint — never the path, which can itself carry a
|
||||
/// deployment secret.
|
||||
|
||||
@@ -138,6 +138,16 @@ pub struct SystemOneResponse {
|
||||
pub answers_validated: Option<bool>,
|
||||
}
|
||||
|
||||
impl SystemOneResponse {
|
||||
pub fn abstained_questions(&self, names: &[&str]) -> Vec<String> {
|
||||
names
|
||||
.iter()
|
||||
.filter(|name| self.answers.get(**name).is_some_and(|a| a.abstained))
|
||||
.map(|name| (*name).to_string())
|
||||
.collect()
|
||||
}
|
||||
}
|
||||
|
||||
impl<'de> Deserialize<'de> for SystemOneResponse {
|
||||
fn deserialize<D: serde::Deserializer<'de>>(
|
||||
deserializer: D,
|
||||
@@ -201,6 +211,8 @@ pub struct SystemOneAnswer {
|
||||
pub probabilities: BTreeMap<String, Option<f64>>,
|
||||
#[serde(default)]
|
||||
pub confidence: Option<f64>,
|
||||
#[serde(default)]
|
||||
pub abstained: bool,
|
||||
}
|
||||
|
||||
/// Provider usage. OpenRouter adds `cost`; the token-count casing differs
|
||||
|
||||
@@ -29,6 +29,8 @@ pub struct UserCommand {
|
||||
pub takes_arguments: bool,
|
||||
pub hidden: bool,
|
||||
pub extension: bool,
|
||||
pub plugin_id: Option<String>,
|
||||
pub workspace_sourced: bool,
|
||||
pub builtin_bindings: Vec<String>,
|
||||
}
|
||||
|
||||
|
||||
@@ -1130,7 +1130,7 @@ pub fn build_reviewer_context(
|
||||
held_reason: &str,
|
||||
tool_input: &Value,
|
||||
) -> String {
|
||||
use codewhale_secrets::redact::{redact_json_model_bound_secrets, redact_model_bound_secrets};
|
||||
use codewhale_sanitize::redact::{redact_json_model_bound_secrets, redact_model_bound_secrets};
|
||||
|
||||
let mut input = redact_json_model_bound_secrets(tool_input);
|
||||
let tool = redact_model_bound_secrets(ctx.tool_name.as_ref());
|
||||
@@ -2889,6 +2889,17 @@ mod tests {
|
||||
"cat junk | dd of=/dev/sda",
|
||||
"timeout 30 mkfs /dev/sda1",
|
||||
r#"echo \";mkfs.ext4 /dev/sda1"#,
|
||||
r#"mk""fs.ext4 -L \; /dev/sda1"#,
|
||||
r#"shr""ed /dev/sda \;"#,
|
||||
r#"d""d if=/dev/zero of=/dev/sda 2>\;"#,
|
||||
r#"wip""efs -a /dev/sda \"#,
|
||||
r#"m\kfs.ext4 /dev/sda1 \;"#,
|
||||
"mk\"\"fs.ext4 /dev/sda1\necho \"",
|
||||
r#"sh -c $'echo x\nwipefs -a /dev/sda'"#,
|
||||
r#"sh -c $'echo x\nmkfs.ext4 /dev/sda1'"#,
|
||||
r#"sh -c $'echo x\nshred /dev/sda'"#,
|
||||
r#"sh -c $'echo x\ndd if=/dev/zero of=/dev/sda'"#,
|
||||
r#"sh -c $'echo x\rwipefs -a /dev/sda'"#,
|
||||
] {
|
||||
let ctx = ctx_for(
|
||||
"exec_shell",
|
||||
@@ -2900,6 +2911,41 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn auto_review_asks_for_prefixed_writable_and_windows_backslash_commands() {
|
||||
let policy = AutoReviewPolicy::default();
|
||||
for command in [
|
||||
"FOO=1>/tmp/out codewhale --version",
|
||||
"PATH=/tmp/bin codewhale --version",
|
||||
"LD_PRELOAD=/tmp/lib.so codewhale --version",
|
||||
"git stash list --output=/tmp/out",
|
||||
"rg --hostname-bin=/tmp/tool foo",
|
||||
"less -o /tmp/out file",
|
||||
"less -O /tmp/out file",
|
||||
"less --log-file=/tmp/out file",
|
||||
"less --LOG-FILE=/tmp/out file",
|
||||
"ag --pager=\"sh -c id\" foo",
|
||||
"info -o /tmp/out",
|
||||
r"find C:\ -delete",
|
||||
r"rg C:\ --pre=id foo",
|
||||
r"find \\?\ -delete",
|
||||
r"rg \\?\ --pre=id foo",
|
||||
] {
|
||||
let ctx = ctx_for(
|
||||
"exec_shell",
|
||||
json!({ "command": command }),
|
||||
RunOrigin::Interactive,
|
||||
ApprovalMode::Auto,
|
||||
);
|
||||
let decision = policy.evaluate(&ctx);
|
||||
assert_eq!(
|
||||
decision.action,
|
||||
AutoReviewAction::AskUser,
|
||||
"{command:?} should require review in Auto mode: {decision:?}"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
fn destroyer_held(workspace: &std::path::Path, command: &str) -> bool {
|
||||
let ctx = AutoReviewContext::from_tool_call(
|
||||
"exec_shell",
|
||||
|
||||
@@ -314,8 +314,8 @@ pub struct EngineConfig {
|
||||
pub session_id: Option<String>,
|
||||
/// Optional host-owned root for delegated-agent runtime state.
|
||||
///
|
||||
/// When unset, the worker ledger, complete transcript artifacts and
|
||||
/// coordination lock retain their historical location under
|
||||
/// When unset, the worker ledger and complete transcript artifacts
|
||||
/// retain their historical location under
|
||||
/// `workspace/.codewhale/state`. Embedders may set a session-scoped root
|
||||
/// to separate that control-plane state from the execution workspace.
|
||||
/// Child cwd and file authority still derive from `workspace`; hosts using
|
||||
|
||||
@@ -2640,6 +2640,8 @@ mod tests {
|
||||
enum Posture {
|
||||
Ask,
|
||||
FullAccess,
|
||||
AutoReview,
|
||||
Plan,
|
||||
}
|
||||
|
||||
struct ExtensionTurn {
|
||||
@@ -2655,18 +2657,44 @@ mod tests {
|
||||
/// A turn whose model calls the extension tool (id `ext-1`) with `input`,
|
||||
/// over the file, shell and web tools.
|
||||
fn start_extension_turn(input: Value, posture: Posture) -> ExtensionTurn {
|
||||
start_extension_turn_with(input, posture, Vec::new())
|
||||
}
|
||||
|
||||
fn start_extension_turn_with(
|
||||
input: Value,
|
||||
posture: Posture,
|
||||
reviewer: Vec<crate::llm_client::mock::CannedTurn>,
|
||||
) -> ExtensionTurn {
|
||||
start_extension_turn_hooked(input, posture, reviewer, None)
|
||||
}
|
||||
|
||||
fn start_extension_turn_hooked(
|
||||
input: Value,
|
||||
posture: Posture,
|
||||
reviewer: Vec<crate::llm_client::mock::CannedTurn>,
|
||||
hook_executor: Option<Arc<crate::hooks::HookExecutor>>,
|
||||
) -> ExtensionTurn {
|
||||
let tmp = tempfile::tempdir().expect("fixture directory");
|
||||
std::fs::write(tmp.path().join("a.txt"), "alpha").expect("fixture file");
|
||||
let mock = Arc::new(MockLlmClient::new(vec![
|
||||
canned::tool_call_turn("ext-1", FAKE_EXT, &input.to_string()),
|
||||
canned::simple_text_turn("Extension finished."),
|
||||
]));
|
||||
let mock = Arc::new(MockLlmClient::new(
|
||||
std::iter::once(canned::tool_call_turn(
|
||||
"ext-1",
|
||||
FAKE_EXT,
|
||||
&input.to_string(),
|
||||
))
|
||||
.chain(reviewer)
|
||||
.chain(std::iter::once(canned::simple_text_turn(
|
||||
"Extension finished.",
|
||||
)))
|
||||
.collect(),
|
||||
));
|
||||
let (mut engine, handle) = Engine::new_with_model_client(
|
||||
EngineConfig {
|
||||
workspace: tmp.path().to_path_buf(),
|
||||
snapshots_enabled: false,
|
||||
subagents_enabled: false,
|
||||
terminal_chrome_enabled: false,
|
||||
hook_executor,
|
||||
..EngineConfig::default()
|
||||
},
|
||||
&Config::default(),
|
||||
@@ -2674,10 +2702,10 @@ mod tests {
|
||||
);
|
||||
let full = posture == Posture::FullAccess;
|
||||
engine.session.auto_approve = full;
|
||||
engine.session.approval_mode = if full {
|
||||
ApprovalMode::Bypass
|
||||
} else {
|
||||
ApprovalMode::Suggest
|
||||
engine.session.approval_mode = match posture {
|
||||
Posture::FullAccess => ApprovalMode::Bypass,
|
||||
Posture::AutoReview => ApprovalMode::Auto,
|
||||
Posture::Ask | Posture::Plan => ApprovalMode::Suggest,
|
||||
};
|
||||
engine.session.mcp_config_path = tmp.path().join("mcp.json");
|
||||
engine.session.add_message(Message {
|
||||
@@ -2701,11 +2729,18 @@ mod tests {
|
||||
registry.register(Arc::new(FakeExtensionTool {
|
||||
withdraw: withdraw.clone(),
|
||||
}));
|
||||
for gate in crate::extension_host::dsh_broker::BrokerActTool::all() {
|
||||
registry.register(gate);
|
||||
}
|
||||
let catalog = registry.to_api_tools_with_cache(true);
|
||||
let surface = ToolSurfacePolicy::new(
|
||||
registry,
|
||||
Some(catalog),
|
||||
AppMode::Agent,
|
||||
if posture == Posture::Plan {
|
||||
AppMode::Plan
|
||||
} else {
|
||||
AppMode::Agent
|
||||
},
|
||||
&engine.config.tools_always_load,
|
||||
&[],
|
||||
false,
|
||||
@@ -3139,4 +3174,180 @@ mod tests {
|
||||
vec![ApprovalOutcome::Cancelled]
|
||||
);
|
||||
}
|
||||
|
||||
fn broker_act(effect: &str) -> Value {
|
||||
json!({
|
||||
"plugin": "fake",
|
||||
"service": "remote",
|
||||
"method": "pair",
|
||||
"effect": effect,
|
||||
})
|
||||
}
|
||||
|
||||
fn broker_calls(acts: &[&Value]) -> Value {
|
||||
let calls: Vec<Value> = acts
|
||||
.iter()
|
||||
.map(|act| {
|
||||
let name = if act["effect"] == "reach" {
|
||||
crate::extension_host::dsh_broker::REACH_TOOL
|
||||
} else {
|
||||
crate::extension_host::dsh_broker::ACT_TOOL
|
||||
};
|
||||
json!({"name": name, "input": act})
|
||||
})
|
||||
.collect();
|
||||
json!({ "calls": calls })
|
||||
}
|
||||
|
||||
fn approvals(seen: &[Event]) -> usize {
|
||||
seen.iter()
|
||||
.filter(|event| matches!(event, Event::ApprovalRequired { .. }))
|
||||
.count()
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_broker_act_asks_in_ask_and_proceeds_in_full_access() {
|
||||
let act = broker_act("reach");
|
||||
let _open = crate::extension_host::dsh_broker::OpenAct::open(&act, 0).expect("open act");
|
||||
|
||||
let mut turn = start_extension_turn(broker_calls(&[&act]), Posture::Ask);
|
||||
let events = turn.events.clone();
|
||||
let mut seen = Vec::new();
|
||||
let event = next_approval_event(&events, &mut seen).await;
|
||||
let (id, tool, description, _, _, force) = approval_fields(&event);
|
||||
assert_eq!(tool, crate::extension_host::dsh_broker::REACH_TOOL);
|
||||
assert!(!force, "the mode decides; no extension force-prompt");
|
||||
assert!(
|
||||
description.contains("plugin `fake`") && description.contains("remote"),
|
||||
"{description}"
|
||||
);
|
||||
turn.handle.deny_tool_call(id).await.expect("deny");
|
||||
let answer = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
assert_eq!(answer["results"][0]["rejected"], "Denied", "{answer}");
|
||||
|
||||
let mut turn = start_extension_turn(broker_calls(&[&act]), Posture::FullAccess);
|
||||
let mut seen = Vec::new();
|
||||
let answer = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
assert_eq!(answer["results"][0]["ok"], true, "{answer}");
|
||||
assert_eq!(approvals(&seen), 0, "Full Access opens no card");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn auto_review_reviewer_no_refuses_a_broker_act() {
|
||||
let act = broker_act("write");
|
||||
let _open = crate::extension_host::dsh_broker::OpenAct::open(&act, 0).expect("open act");
|
||||
let mut turn = start_extension_turn_with(
|
||||
broker_calls(&[&act]),
|
||||
Posture::AutoReview,
|
||||
vec![
|
||||
canned::simple_text_turn(
|
||||
r#"{"risk_level":"low","decision":"allow","reason":"the person asked to run the extension"}"#,
|
||||
),
|
||||
canned::simple_text_turn(
|
||||
r#"{"risk_level":"high","decision":"deny","reason":"not what the person asked for"}"#,
|
||||
),
|
||||
],
|
||||
);
|
||||
let mut seen = Vec::new();
|
||||
let answer = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
assert_eq!(answer["results"][0]["rejected"], "Refused", "{answer}");
|
||||
assert_eq!(approvals(&seen), 0, "the reviewer, not a person, decided");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn plan_refuses_a_broker_act_that_writes_or_reaches_out() {
|
||||
let reach = broker_act("reach");
|
||||
let write = broker_act("write");
|
||||
let read = broker_act("read");
|
||||
let _open: Vec<_> = [&reach, &write, &read]
|
||||
.into_iter()
|
||||
.map(|act| crate::extension_host::dsh_broker::OpenAct::open(act, 0).expect("open act"))
|
||||
.collect();
|
||||
let mut turn = start_extension_turn(broker_calls(&[&reach, &write, &read]), Posture::Plan);
|
||||
let mut seen = Vec::new();
|
||||
let answer = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
assert_eq!(answer["results"][0]["rejected"], "Refused", "{answer}");
|
||||
assert_eq!(answer["results"][1]["rejected"], "Refused", "{answer}");
|
||||
assert_eq!(answer["results"][2]["ok"], true, "{answer}");
|
||||
assert_eq!(approvals(&seen), 0);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_broker_act_nobody_opened_is_refused_before_any_card() {
|
||||
let act =
|
||||
json!({"plugin": "fake", "service": "network", "method": "fetch", "effect": "reach"});
|
||||
let mut turn = start_extension_turn(broker_calls(&[&act]), Posture::Ask);
|
||||
let mut seen = Vec::new();
|
||||
let answer = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
assert_eq!(answer["results"][0]["rejected"], "Refused", "{answer}");
|
||||
assert_eq!(approvals(&seen), 0);
|
||||
}
|
||||
|
||||
#[cfg(unix)]
|
||||
#[tokio::test]
|
||||
async fn a_hook_rewrite_cannot_make_the_gate_answer_for_another_act() {
|
||||
use crate::extension_host::dsh_broker::{OpenAct, REACH_TOOL, answered_for};
|
||||
let act = |target: &str| {
|
||||
json!({
|
||||
"plugin": "fake",
|
||||
"service": "network",
|
||||
"method": "fetch",
|
||||
"effect": "reach",
|
||||
"target": target,
|
||||
})
|
||||
};
|
||||
let shown = act("api.github.com");
|
||||
let asked = act("evil.example");
|
||||
let hooks = tempfile::tempdir().expect("hook directory");
|
||||
let hook = codewhale_config::hooks::Hook::new(
|
||||
codewhale_config::hooks::HookEvent::ToolCallBefore,
|
||||
&format!("printf '%s' '{}'", json!({ "updatedInput": shown })),
|
||||
)
|
||||
.with_condition(codewhale_config::hooks::HookCondition::ToolName {
|
||||
name: REACH_TOOL.to_string(),
|
||||
});
|
||||
let executor = Arc::new(crate::hooks::HookExecutor::new(
|
||||
codewhale_config::hooks::HooksConfig {
|
||||
enabled: true,
|
||||
hooks: vec![hook],
|
||||
..codewhale_config::hooks::HooksConfig::default()
|
||||
},
|
||||
hooks.path().to_path_buf(),
|
||||
));
|
||||
|
||||
let _asked_open = OpenAct::open(&asked, 0).expect("open the asked act");
|
||||
let mut turn = start_extension_turn_hooked(
|
||||
broker_calls(&[&asked]),
|
||||
Posture::FullAccess,
|
||||
Vec::new(),
|
||||
Some(executor.clone()),
|
||||
);
|
||||
let mut seen = Vec::new();
|
||||
let control = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
assert_eq!(control["results"][0]["rejected"], "Refused", "{control}");
|
||||
|
||||
let _shown_open = OpenAct::open(&shown, 1).expect("open the shown act");
|
||||
let mut turn = start_extension_turn_hooked(
|
||||
broker_calls(&[&asked]),
|
||||
Posture::Ask,
|
||||
Vec::new(),
|
||||
Some(executor),
|
||||
);
|
||||
let events = turn.events.clone();
|
||||
let mut seen = Vec::new();
|
||||
let event = next_approval_event(&events, &mut seen).await;
|
||||
let (id, _tool, description, _key, _, _force) = approval_fields(&event);
|
||||
assert!(description.contains("api.github.com"), "{description}");
|
||||
turn.handle.approve_tool_call(id).await.expect("approve");
|
||||
let answer = finish_extension_turn(&mut turn, &mut seen).await;
|
||||
let result = &answer["results"][0]["result"];
|
||||
assert!(
|
||||
answered_for(&shown, result),
|
||||
"the gate names the act it decided: {answer}"
|
||||
);
|
||||
assert!(
|
||||
!answered_for(&asked, result),
|
||||
"the yes is not for the act that asked: {answer}"
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -456,7 +456,7 @@ async fn captured_identity_cancel_and_task_bounds_refuse_before_any_provider() {
|
||||
|
||||
#[tokio::test]
|
||||
async fn dropping_an_actual_dispatched_core_call_keeps_unknown_usage_without_retaining_authority() {
|
||||
struct Pending;
|
||||
struct Pending(Arc<tokio::sync::Notify>);
|
||||
impl Replies for Pending {
|
||||
fn effective_route_envelope(
|
||||
&self,
|
||||
@@ -478,24 +478,42 @@ async fn dropping_an_actual_dispatched_core_call_keeps_unknown_usage_without_ret
|
||||
&self,
|
||||
_: MessageRequest,
|
||||
) -> Pin<Box<dyn Future<Output = anyhow::Result<MessageResponse>> + Send + '_>> {
|
||||
self.0.notify_one();
|
||||
Box::pin(std::future::pending())
|
||||
}
|
||||
}
|
||||
let caller = Arc::new(caller_for(Arc::new(Pending), "captured-model"));
|
||||
let entered = Arc::new(tokio::sync::Notify::new());
|
||||
let caller = Arc::new(caller_for(
|
||||
Arc::new(Pending(entered.clone())),
|
||||
"captured-model",
|
||||
));
|
||||
let weak_caller = Arc::downgrade(&caller);
|
||||
let usage = RlmUsageAccumulator::new();
|
||||
let result = caller
|
||||
.dispatch(RlmInvocation {
|
||||
prompt: "pending".into(),
|
||||
mode: RlmMode::Completion,
|
||||
max_tokens: None,
|
||||
task_instructions: None,
|
||||
deadline: Some(tokio::time::Instant::now() + Duration::from_millis(100)),
|
||||
gate: None,
|
||||
events: None,
|
||||
usage: usage.clone(),
|
||||
})
|
||||
.await;
|
||||
let mut dispatch = caller.dispatch(RlmInvocation {
|
||||
prompt: "pending".into(),
|
||||
mode: RlmMode::Completion,
|
||||
max_tokens: None,
|
||||
task_instructions: None,
|
||||
deadline: Some(tokio::time::Instant::now() + Duration::from_secs(600)),
|
||||
gate: None,
|
||||
events: None,
|
||||
usage: usage.clone(),
|
||||
});
|
||||
tokio::time::timeout(Duration::from_secs(10), async {
|
||||
tokio::select! {
|
||||
biased;
|
||||
() = entered.notified() => {}
|
||||
result = &mut dispatch => panic!(
|
||||
"dropped dispatch never reached the client: {:?}",
|
||||
result.error
|
||||
),
|
||||
}
|
||||
})
|
||||
.await
|
||||
.expect("the dispatched call must reach the client");
|
||||
tokio::time::pause();
|
||||
tokio::time::advance(Duration::from_secs(601)).await;
|
||||
let result = dispatch.await;
|
||||
assert!(
|
||||
result
|
||||
.error
|
||||
|
||||
@@ -710,7 +710,7 @@ fn shell_denial_filters_search_catalog_without_expanding_allow_grants() {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shell_denial_preserves_task_reads_and_bounded_verification_actions() {
|
||||
fn shell_denial_preserves_task_reads_and_denies_verification_actions() {
|
||||
let mut tasks = catalog_tool("tasks");
|
||||
tasks.input_schema =
|
||||
json!({"type":"object", "properties":{"action":{"enum":["list", "read", "gate_run"]}}});
|
||||
@@ -737,21 +737,293 @@ fn shell_denial_preserves_task_reads_and_bounded_verification_actions() {
|
||||
assert!(surface.denies_call("tasks", &json!({"action":"gate_run"})));
|
||||
assert!(!surface.denies_call("task_shell_wait", &json!({})));
|
||||
assert!(!surface.denies_call("terminal/cancel", &json!({})));
|
||||
assert!(!surface.denies_call(
|
||||
"Run",
|
||||
&json!({"action":"tests", "args":"-p fixture selected_test"})
|
||||
));
|
||||
assert!(!surface.denies_call("Run", &json!({"action":"verifiers", "commands":[]})));
|
||||
assert!(surface.denies_call(
|
||||
"Run",
|
||||
&json!({"action":"tests", "args":"--config build.rustc=malicious"})
|
||||
));
|
||||
for input in [
|
||||
json!({"action":"tests"}),
|
||||
json!({"action":"tests", "args":""}),
|
||||
json!({"action":"tests", "args":"-p fixture selected_test"}),
|
||||
json!({"action":"tests", "args":"--config build.rustc=malicious"}),
|
||||
json!({"action":"verifiers"}),
|
||||
json!({"action":"verifiers", "profile":"node"}),
|
||||
json!({"action":"verifiers", "commands":[]}),
|
||||
json!({"action":"verifiers", "commands":[{"program":"sh"}]}),
|
||||
] {
|
||||
assert!(surface.denies_call("Run", &input), "{input}");
|
||||
}
|
||||
for name in ["run_tests", "run_verifiers"] {
|
||||
assert!(surface.denies_call(name, &json!({})), "{name}");
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shell_denial_covers_every_code_executing_action_or_names_an_exemption() {
|
||||
use crate::tools::execution_envelope::{CallClass, classify_call, tool_call_denied};
|
||||
use crate::tools::spec::ToolCapability;
|
||||
use codewhale_agent_contract::worker_profile::ShellPolicy;
|
||||
|
||||
const EXEMPT: &[(&str, &str)] = &[
|
||||
("automation/pause", "stops a stored automation from firing"),
|
||||
("automation/delete", "removes a stored automation"),
|
||||
("send_later/cancel", "cancels a pending delayed message"),
|
||||
("tasks/cancel", "stops a durable task"),
|
||||
("tasks/suggest", "offers a task card and starts nothing"),
|
||||
("tasks/pr_attempt_record", "records a stored patch artifact"),
|
||||
(
|
||||
"tasks/pr_attempt_preflight",
|
||||
"git apply --check of a stored patch",
|
||||
),
|
||||
("terminal/cancel", "stops an existing terminal session"),
|
||||
("terminal/wait", "reads an existing terminal session"),
|
||||
(
|
||||
"rlm/open",
|
||||
"loads content into a context; running code in it is rlm/eval, and a url is gated by fetch_url",
|
||||
),
|
||||
(
|
||||
"workflow/start",
|
||||
"runs sub-agents that inherit this deny list; the verify input is denied by the flag list below",
|
||||
),
|
||||
(
|
||||
"workflow/run",
|
||||
"runs sub-agents that inherit this deny list; the verify input is denied by the flag list below",
|
||||
),
|
||||
(
|
||||
"workflow/cancel",
|
||||
"stops a workflow run and starts nothing",
|
||||
),
|
||||
];
|
||||
const EXECUTING_FLAGS: &[(&str, &str)] = &[("workflow", "verify")];
|
||||
|
||||
let tmp = tempdir().expect("tempdir");
|
||||
let mut options = crate::tools::AgentToolSurfaceOptions::new(ShellPolicy::Full);
|
||||
options.apply_patch_enabled = true;
|
||||
options.web_search_enabled = true;
|
||||
options.memory_tool_enabled = true;
|
||||
let pool = std::sync::Arc::new(tokio::sync::Mutex::new(crate::mcp::McpPool::new(
|
||||
codewhale_mcp::config::McpConfig::default(),
|
||||
)));
|
||||
let client = CodewhaleClient::new(
|
||||
&Config::default().with_legacy_root(Some("test-key".to_string()), None),
|
||||
)
|
||||
.expect("stub client");
|
||||
let manager = crate::tools::subagent::new_shared_subagent_manager(tmp.path().to_path_buf(), 4);
|
||||
let runtime = SubAgentRuntime::new(
|
||||
client.clone(),
|
||||
"sweep-model".to_string(),
|
||||
crate::tools::ToolContext::new(tmp.path().to_path_buf()),
|
||||
true,
|
||||
None,
|
||||
manager.clone(),
|
||||
);
|
||||
let registry = crate::tools::ToolRegistryBuilder::new()
|
||||
.with_full_agent_surface_options(
|
||||
Some(client),
|
||||
"sweep-model".to_string(),
|
||||
manager,
|
||||
runtime,
|
||||
options,
|
||||
crate::tools::todo::new_shared_todo_list(),
|
||||
crate::tools::plan::new_shared_plan_state(),
|
||||
)
|
||||
.with_registry_mcp_sync_tool()
|
||||
.with_runtime_mcp_tool(pool.clone())
|
||||
.with_registry_mcp_start_tool(pool)
|
||||
.build(crate::tools::ToolContext::new(tmp.path().to_path_buf()));
|
||||
|
||||
let rules = vec!["Bash".to_string()];
|
||||
for name in ["workflow", "agent", "Run"] {
|
||||
assert!(
|
||||
registry.all().iter().any(|tool| tool.name() == name),
|
||||
"the sweep surface lacks {name}"
|
||||
);
|
||||
}
|
||||
for (name, flag) in EXECUTING_FLAGS {
|
||||
let tool = registry
|
||||
.all()
|
||||
.into_iter()
|
||||
.find(|tool| tool.name() == *name)
|
||||
.unwrap_or_else(|| panic!("{name} is not registered"));
|
||||
assert_eq!(
|
||||
tool.input_schema()
|
||||
.pointer(&format!("/properties/{flag}/type"))
|
||||
.and_then(Value::as_str),
|
||||
Some("boolean"),
|
||||
"{name} no longer declares a boolean {flag}"
|
||||
);
|
||||
assert!(
|
||||
tool_call_denied(Some(&rules), name, &json!({"action":"run", (*flag): true})),
|
||||
"{name} with {flag} starts workspace code and a Bash rule does not deny it"
|
||||
);
|
||||
}
|
||||
let mut swept = 0usize;
|
||||
let mut unaccounted = Vec::new();
|
||||
let mut stale = Vec::new();
|
||||
for tool in registry.all() {
|
||||
let schema = tool.input_schema();
|
||||
let actions: Vec<Option<String>> = schema
|
||||
.pointer("/properties/action/enum")
|
||||
.and_then(Value::as_array)
|
||||
.map(|actions| {
|
||||
actions
|
||||
.iter()
|
||||
.filter_map(|action| action.as_str().map(|action| Some(action.to_string())))
|
||||
.collect()
|
||||
})
|
||||
.unwrap_or_else(|| vec![None]);
|
||||
for action in actions {
|
||||
let input = action
|
||||
.as_ref()
|
||||
.map_or_else(|| json!({}), |action| json!({"action": action}));
|
||||
let label = match &action {
|
||||
Some(action) => format!("{}/{action}", tool.name()),
|
||||
None => tool.name().to_string(),
|
||||
};
|
||||
let denied = tool_call_denied(Some(&rules), tool.name(), &input);
|
||||
let executes = tool.capabilities().contains(&ToolCapability::ExecutesCode)
|
||||
&& classify_call(tool.name(), &input, &*tool) != CallClass::Bounded;
|
||||
let exempt = EXEMPT.iter().any(|(name, _)| *name == label);
|
||||
if executes {
|
||||
swept += 1;
|
||||
}
|
||||
if executes && !denied && !exempt {
|
||||
unaccounted.push(label.clone());
|
||||
}
|
||||
if exempt && denied {
|
||||
stale.push(label);
|
||||
}
|
||||
}
|
||||
}
|
||||
assert!(swept > 10, "the sweep found only {swept} executing actions");
|
||||
assert!(
|
||||
unaccounted.is_empty(),
|
||||
"executing actions neither denied by a Bash rule nor exempt: {unaccounted:?}"
|
||||
);
|
||||
assert!(
|
||||
stale.is_empty(),
|
||||
"exempt actions a Bash rule already denies: {stale:?}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shell_denial_keeps_only_the_bounded_verifier_its_default_gate() {
|
||||
use crate::tools::execution_envelope::{enforce_tool_denial, holds_bounded_verification};
|
||||
use crate::tools::spec::{
|
||||
ToolAuthorityEnvelope, ToolMutationAuthority, ToolShellAuthority,
|
||||
ToolVerificationAuthority,
|
||||
};
|
||||
let tmp = tempdir().expect("tempdir");
|
||||
let rules: Vec<String> = codewhale_agent_contract::role::RAW_SHELL_DENYLIST
|
||||
.iter()
|
||||
.map(|rule| (*rule).to_string())
|
||||
.collect();
|
||||
|
||||
let mut operator = crate::tools::ToolContext::new(tmp.path().to_path_buf());
|
||||
operator.disallowed_tools = rules.clone();
|
||||
assert!(!holds_bounded_verification(&operator));
|
||||
|
||||
let mut verifier = crate::tools::ToolContext::new(tmp.path().to_path_buf())
|
||||
.with_tool_authority(ToolAuthorityEnvelope {
|
||||
schema_version: 1,
|
||||
owner: "verifier-1".to_string(),
|
||||
authority: ToolMutationAuthority::ReadOnly,
|
||||
network_access: Some(false),
|
||||
shell: ToolShellAuthority::None,
|
||||
verification: ToolVerificationAuthority::Bounded,
|
||||
writable_roots: Vec::new(),
|
||||
writable_files: Vec::new(),
|
||||
coordination_contracts: Vec::new(),
|
||||
})
|
||||
.expect("bounded verifier authority");
|
||||
verifier.disallowed_tools = rules;
|
||||
assert!(holds_bounded_verification(&verifier));
|
||||
|
||||
for input in [
|
||||
json!({"action":"tests"}),
|
||||
json!({"action":"tests", "args":"-p fixture selected_test"}),
|
||||
json!({"action":"verifiers"}),
|
||||
] {
|
||||
assert!(enforce_tool_denial(&operator, "Run", &input).is_err(), "{input}");
|
||||
assert!(enforce_tool_denial(&verifier, "Run", &input).is_ok(), "{input}");
|
||||
}
|
||||
for input in [
|
||||
json!({"action":"tests", "args":"--config build.rustc=malicious"}),
|
||||
json!({"action":"verifiers", "commands":[{"program":"sh"}]}),
|
||||
] {
|
||||
assert!(enforce_tool_denial(&operator, "Run", &input).is_err(), "{input}");
|
||||
assert!(enforce_tool_denial(&verifier, "Run", &input).is_err(), "{input}");
|
||||
}
|
||||
let workflow_verify = json!({"action":"run", "script":"return 1;", "verify":true});
|
||||
assert!(enforce_tool_denial(&operator, "workflow", &workflow_verify).is_err());
|
||||
assert!(enforce_tool_denial(&verifier, "workflow", &workflow_verify).is_ok());
|
||||
|
||||
let surface = ToolSurfacePolicy::new(
|
||||
crate::tools::ToolRegistry::new(verifier.clone()),
|
||||
Some(vec![catalog_tool("Run")]),
|
||||
AppMode::Agent,
|
||||
&HashSet::new(),
|
||||
&[],
|
||||
false,
|
||||
None,
|
||||
verifier.disallowed_tools.clone().into(),
|
||||
None,
|
||||
crate::core::engine::tool_catalog::ToolMode::Direct,
|
||||
);
|
||||
assert!(!surface.denies_call("Run", &json!({"action":"verifiers"})));
|
||||
assert!(surface.denies_call(
|
||||
"Run",
|
||||
&json!({"action":"verifiers", "commands":[{"program":"sh"}]})
|
||||
));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shell_denial_covers_workflow_completion_verification_but_not_plain_runs() {
|
||||
use crate::tools::execution_envelope::tool_call_denied;
|
||||
let rules = vec!["Bash".to_string()];
|
||||
for input in [
|
||||
json!({"verify":true}),
|
||||
json!({"action":"start", "verify":true}),
|
||||
json!({"action":"spawn", "verify":true, "script":"return 1;"}),
|
||||
json!({"action":"run", "verify":true, "script":"return 1;"}),
|
||||
json!({"action":"wait", "verify":true}),
|
||||
json!({"action":" RUN ", "verify":true}),
|
||||
] {
|
||||
assert!(tool_call_denied(Some(&rules), "workflow", &input), "{input}");
|
||||
}
|
||||
for input in [
|
||||
json!({"action":"run", "script":"return 1;"}),
|
||||
json!({"action":"run", "verify":false}),
|
||||
json!({"action":"status", "run_id":"workflow_1"}),
|
||||
json!({"action":"cancel", "run_id":"workflow_1"}),
|
||||
] {
|
||||
assert!(!tool_call_denied(Some(&rules), "workflow", &input), "{input}");
|
||||
}
|
||||
assert!(!tool_call_denied(
|
||||
None,
|
||||
"workflow",
|
||||
&json!({"action":"run", "verify":true})
|
||||
));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shell_denial_covers_delayed_message_scheduling_but_not_its_management() {
|
||||
use crate::tools::execution_envelope::tool_call_denied;
|
||||
let rules = vec!["Bash".to_string()];
|
||||
assert!(tool_call_denied(
|
||||
Some(&rules),
|
||||
"send_later",
|
||||
&json!({"action":"schedule", "delay_minutes":5, "message":"go", "thread_id":""})
|
||||
));
|
||||
for action in ["list", "read", "cancel"] {
|
||||
assert!(
|
||||
!tool_call_denied(Some(&rules), "send_later", &json!({"action": action})),
|
||||
"{action}"
|
||||
);
|
||||
}
|
||||
assert!(!tool_call_denied(
|
||||
None,
|
||||
"send_later",
|
||||
&json!({"action":"schedule"})
|
||||
));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shell_denial_applies_to_new_durable_execution_without_hiding_management() {
|
||||
use crate::tools::execution_envelope::tool_call_denied;
|
||||
|
||||
@@ -30,18 +30,13 @@ use std::hash::{Hash, Hasher};
|
||||
use crate::compaction::estimate_input_tokens_for_pressure;
|
||||
use codewhale_models::{Message, SystemPrompt};
|
||||
|
||||
/// Default capacity for the rolling audit ring. Sized so a 64-entry window
|
||||
/// covers a full capacity controller observation cycle without unbounded
|
||||
/// growth on long-running sessions.
|
||||
const AUDIT_RING_CAPACITY: usize = 64;
|
||||
|
||||
/// Process-local memoization for `estimate_input_tokens_for_pressure`.
|
||||
///
|
||||
/// The cache is keyed on the `(messages_revision, system_fingerprint)`
|
||||
/// pair, both of which the engine bumps on every content change. On a hit
|
||||
/// the previously stored token estimate is returned without re-walking the
|
||||
/// message list. On a miss, the estimator runs and the result is stored
|
||||
/// alongside the audit ring entry.
|
||||
/// for the next lookup.
|
||||
#[derive(Debug, Default, Clone)]
|
||||
pub struct TokenEstimateCache {
|
||||
/// Monotonic counter bumped by the engine on every message mutation.
|
||||
@@ -51,10 +46,6 @@ pub struct TokenEstimateCache {
|
||||
system_fingerprint: u64,
|
||||
/// Cached token count, valid iff both keys match the current inputs.
|
||||
cached_tokens: Option<usize>,
|
||||
/// Audit ring of recent (revision, tokens) pairs. The most recent entry
|
||||
/// is the tail; the oldest is dropped when capacity is exceeded. Used by
|
||||
/// observability to surface cache effectiveness to `/status`.
|
||||
audit_ring: Vec<(u64, usize)>,
|
||||
/// Number of cache hits since the cache was last cleared. Saturates at
|
||||
/// `u64::MAX` (effectively never in practice).
|
||||
hits: u64,
|
||||
@@ -97,7 +88,6 @@ impl TokenEstimateCache {
|
||||
self.system_fingerprint = system_fingerprint;
|
||||
self.cached_tokens = Some(tokens);
|
||||
self.misses = self.misses.saturating_add(1);
|
||||
self.push_audit(messages_revision, tokens);
|
||||
tokens
|
||||
}
|
||||
|
||||
@@ -115,7 +105,6 @@ impl TokenEstimateCache {
|
||||
pub fn invalidate(&mut self) {
|
||||
self.cached_tokens = None;
|
||||
self.system_fingerprint = 0;
|
||||
self.audit_ring.clear();
|
||||
self.hits = 0;
|
||||
self.misses = 0;
|
||||
}
|
||||
@@ -125,20 +114,6 @@ impl TokenEstimateCache {
|
||||
pub fn stats(&self) -> (u64, u64) {
|
||||
(self.hits, self.misses)
|
||||
}
|
||||
|
||||
/// Returns the most recent `(revision, tokens)` audit entries, newest
|
||||
/// first. Bounded by [`AUDIT_RING_CAPACITY`].
|
||||
#[must_use]
|
||||
pub fn recent_audit(&self) -> &[(u64, usize)] {
|
||||
&self.audit_ring
|
||||
}
|
||||
|
||||
fn push_audit(&mut self, revision: u64, tokens: usize) {
|
||||
if self.audit_ring.len() >= AUDIT_RING_CAPACITY {
|
||||
self.audit_ring.remove(0);
|
||||
}
|
||||
self.audit_ring.push((revision, tokens));
|
||||
}
|
||||
}
|
||||
|
||||
/// Stable 64-bit hash of the system prompt text. Walks the same shape the
|
||||
@@ -288,29 +263,4 @@ mod tests {
|
||||
assert_eq!(hits, 0);
|
||||
assert_eq!(misses, 2);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn audit_ring_records_recent_pairs() {
|
||||
let mut cache = TokenEstimateCache::new();
|
||||
let messages = vec![user_text("hi")];
|
||||
for rev in 1..=5 {
|
||||
let _ = cache.lookup_or_compute(rev, None, &messages);
|
||||
}
|
||||
let ring = cache.recent_audit();
|
||||
assert_eq!(ring.len(), 5);
|
||||
assert_eq!(ring.last().copied(), Some((5, ring.last().unwrap().1)));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn audit_ring_bounded_by_capacity() {
|
||||
let mut cache = TokenEstimateCache::new();
|
||||
let messages = vec![user_text("hi")];
|
||||
for rev in 1..=(AUDIT_RING_CAPACITY + 10) as u64 {
|
||||
let _ = cache.lookup_or_compute(rev, None, &messages);
|
||||
}
|
||||
let ring = cache.recent_audit();
|
||||
assert_eq!(ring.len(), AUDIT_RING_CAPACITY);
|
||||
// newest entry should be the most recent revision we asked for
|
||||
assert_eq!(ring.last().unwrap().0, (AUDIT_RING_CAPACITY + 10) as u64);
|
||||
}
|
||||
}
|
||||
@@ -5,7 +5,7 @@
|
||||
//! tool suggestions, and the small set of built-in advanced tools that are not
|
||||
//! registered by the normal runtime tool registry.
|
||||
|
||||
use crate::tools::execution_envelope::tool_call_denied;
|
||||
use crate::tools::execution_envelope::{holds_bounded_verification, tool_call_denied_for};
|
||||
use codewhale_tools::names::{
|
||||
LEGACY_TOOL_SEARCH_BM25_NAME, LEGACY_TOOL_SEARCH_REGEX_NAME, TOOL_SEARCH_NAME,
|
||||
is_tool_search_tool,
|
||||
@@ -625,6 +625,7 @@ pub(super) struct ToolSurfacePolicy {
|
||||
pub(super) strict_tool_mode: bool,
|
||||
allowed_tools: Option<Vec<String>>,
|
||||
disallowed_tools: Option<Vec<String>>,
|
||||
holds_bounded_verification: bool,
|
||||
/// Hard per-turn cap on admitted tool calls (#4415). The turn loop copies
|
||||
/// this limit into its own admission counter at turn start; `None` means
|
||||
/// unlimited (the default), which keeps the admission gate inert.
|
||||
@@ -645,6 +646,7 @@ impl ToolSurfacePolicy {
|
||||
max_tool_calls: Option<u32>,
|
||||
tool_mode: ToolMode,
|
||||
) -> Self {
|
||||
let holds_bounded_verification = holds_bounded_verification(registry.context());
|
||||
let mut catalog = tools.unwrap_or_default();
|
||||
if !catalog.is_empty() {
|
||||
ensure_advanced_tooling(&mut catalog, mode, always_load, tool_mode);
|
||||
@@ -669,10 +671,11 @@ impl ToolSurfacePolicy {
|
||||
.and_then(Value::as_array_mut)
|
||||
{
|
||||
actions.retain(|action| {
|
||||
!tool_call_denied(
|
||||
!tool_call_denied_for(
|
||||
disallowed_tools.as_deref(),
|
||||
&tool.name,
|
||||
&json!({"action": action}),
|
||||
holds_bounded_verification,
|
||||
)
|
||||
});
|
||||
}
|
||||
@@ -697,6 +700,7 @@ impl ToolSurfacePolicy {
|
||||
strict_tool_mode,
|
||||
allowed_tools,
|
||||
disallowed_tools,
|
||||
holds_bounded_verification,
|
||||
max_tool_calls,
|
||||
}
|
||||
}
|
||||
@@ -738,7 +742,12 @@ impl ToolSurfacePolicy {
|
||||
}
|
||||
|
||||
pub(super) fn denies_call(&self, name: &str, input: &Value) -> bool {
|
||||
tool_call_denied(self.disallowed_tools.as_deref(), name, input)
|
||||
tool_call_denied_for(
|
||||
self.disallowed_tools.as_deref(),
|
||||
name,
|
||||
input,
|
||||
self.holds_bounded_verification,
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -110,6 +110,7 @@ impl Engine {
|
||||
// the ToolContext carries ShellPolicy::None.
|
||||
.with_file_tools()
|
||||
.with_present_tool()
|
||||
.with_show_data_tool()
|
||||
// Foreground-only shell registration: never add terminal/*
|
||||
// lifecycle tools to Plan merely to keep the `bash` identity
|
||||
// stable across modes.
|
||||
|
||||
@@ -5968,7 +5968,9 @@ fn mode_blocks_write_capable_tool(
|
||||
&& (matches!(
|
||||
canonical_action_alias(tool_name, input),
|
||||
"write_file" | "edit_file" | "apply_patch"
|
||||
) || (McpPool::is_mcp_tool(tool_name) && !read_only))
|
||||
) || ((McpPool::is_mcp_tool(tool_name)
|
||||
|| crate::extension_host::dsh_broker::is_gate_tool(tool_name))
|
||||
&& !read_only))
|
||||
}
|
||||
|
||||
/// Synthesize the tool result recorded for a tool call that never executed
|
||||
|
||||
@@ -301,7 +301,7 @@ fn mcp_snapshot_to_wire(snapshot: &McpManagerSnapshot) -> wire::McpManagerSnapsh
|
||||
/// `EventMsg::McpSessionBoot`, which every SSE and stream-JSON consumer
|
||||
/// receives and any frame-retaining log keeps.
|
||||
///
|
||||
/// URLs reuse the existing masking in `codewhale_secrets::sanitize::redact_url_for_display`. Stdio
|
||||
/// URLs reuse the existing masking in `codewhale_sanitize::sanitize::redact_url_for_display`. Stdio
|
||||
/// keeps the program name and elides the arguments, because a secret there can
|
||||
/// be positional and is not reliably recognizable by key.
|
||||
fn redacted_command_or_url(raw: &str) -> String {
|
||||
@@ -315,7 +315,7 @@ fn redacted_command_or_url(raw: &str) -> String {
|
||||
// mentions a URL — `docker run -e TOKEN=… img --url https://…` — would
|
||||
// reach the wire with its positional secret intact.
|
||||
if !trimmed.is_empty() && !trimmed.contains(char::is_whitespace) && trimmed.contains("://") {
|
||||
return codewhale_secrets::sanitize::redact_url_for_display(trimmed);
|
||||
return codewhale_sanitize::sanitize::redact_url_for_display(trimmed);
|
||||
}
|
||||
if let Some((program, rest)) = trimmed.split_once(char::is_whitespace)
|
||||
&& !rest.trim().is_empty()
|
||||
|
||||
@@ -2643,6 +2643,7 @@ pub fn decision_receipt_fixture(source_id: &str) -> RuntimeDecisionReceipt {
|
||||
probabilities_bp: Default::default(),
|
||||
confidence_bp: 0,
|
||||
min_confidence_bp: 5_000,
|
||||
abstained_questions: Vec::new(),
|
||||
cost_saving_kept_fast: false,
|
||||
thinking: None,
|
||||
provider_reported_cost_usd: Some("0.000012054".to_string()),
|
||||
|
||||
@@ -204,7 +204,7 @@ pub enum CommandOutcome {
|
||||
|
||||
fn strip_escapes(text: &str) -> String {
|
||||
let mut clean = String::with_capacity(text.len());
|
||||
codewhale_secrets::sanitize::strip_ansi_into(text, &mut clean);
|
||||
codewhale_sanitize::sanitize::strip_ansi_into(text, &mut clean);
|
||||
clean
|
||||
}
|
||||
|
||||
|
||||
@@ -42,6 +42,9 @@
|
||||
//! network calls force a prompt: a session grant is not consulted, and
|
||||
//! Full Access still opens their card. Auto-Review and Never refuse them
|
||||
//! (`resolve_approval_request_disposition`); explicit denials always win.
|
||||
//! The broker's own gate tools ([`dsh_broker::GATE_TOOLS`]) are the exception:
|
||||
//! the permission mode alone decides them, and only a broker arm reaches them
|
||||
//! (a plugin's own `core/call` of one is refused by name).
|
||||
//!
|
||||
//! **Caps.** Per invocation: 50 core tool calls in all, counted together
|
||||
//! across `core/call` and the nested calls of broker arms, 4 at
|
||||
@@ -77,7 +80,7 @@ use serde_json::{Value, json};
|
||||
use tokio_util::sync::CancellationToken;
|
||||
|
||||
use super::ManagerShared;
|
||||
use super::dsh_broker::{self, Arm, BrokerCall, BrokerRefusal};
|
||||
use super::dsh_broker::{self, Arm, BrokerCall, BrokerEffect, BrokerRefusal, OpenAct};
|
||||
use super::protocol::{
|
||||
ContentBlockWire, CoreCallParams, DshBrokerParams, DshBrokerTicketWire, DshService,
|
||||
RpcErrorWire, SessionCheckpointParams, ToolResultWire, UserQuestionParams, error_code,
|
||||
@@ -106,6 +109,7 @@ const TICKET_TTL: Duration = Duration::from_secs(24 * 60 * 60);
|
||||
const GRANT_PROBE: Duration = Duration::from_millis(50);
|
||||
/// Receipts attached to an extension tool's result metadata.
|
||||
pub const RECEIPTS_ATTACHED: usize = 50;
|
||||
pub const MAX_ACT_RECORD_BYTES: usize = 1024;
|
||||
|
||||
/// Tools an extension may never reach through `core/call`, by lower-case
|
||||
/// name, checked on the spelling the host sent and on the canonical action
|
||||
@@ -204,7 +208,8 @@ pub fn refusal(specs: &[Arc<dyn ToolSpec>], name: &str, input: &Value) -> Option
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub enum OriginApproval {
|
||||
/// Planning's decision stands (the tool is in [`EXT_AUTO_ELIGIBLE`] and
|
||||
/// nothing asked for approval).
|
||||
/// nothing asked for approval, or it is one of the broker's gate tools,
|
||||
/// which the permission mode alone decides).
|
||||
Unchanged,
|
||||
/// Needs approval; an extension-scoped session grant may satisfy it.
|
||||
Prompt,
|
||||
@@ -226,6 +231,9 @@ pub fn origin_approval(
|
||||
|
||||
let lower = name.to_ascii_lowercase();
|
||||
let resolved = canonical(name, input);
|
||||
if dsh_broker::is_gate_tool(&lower) && spec.is_some_and(dsh_broker::is_gate_spec) {
|
||||
return OriginApproval::Unchanged;
|
||||
}
|
||||
let forced = |candidate: &str| {
|
||||
matches!(
|
||||
get_tool_category_for_call(candidate, input),
|
||||
@@ -269,8 +277,11 @@ pub struct Invocation {
|
||||
root_caller: Option<SessionCheckpointCaller>,
|
||||
broker: Option<BrokerScope>,
|
||||
nested_calls: AtomicU32,
|
||||
broker_acts: Mutex<(usize, Vec<Value>, bool)>,
|
||||
tickets: Vec<Ticket>,
|
||||
caller_tools: Vec<String>,
|
||||
gates: Vec<&'static str>,
|
||||
act_slots: tokio::sync::Semaphore,
|
||||
activations: Mutex<
|
||||
HashMap<
|
||||
String,
|
||||
@@ -309,17 +320,145 @@ impl BrokerContext {
|
||||
&self.cancel
|
||||
}
|
||||
|
||||
pub async fn core_call(
|
||||
&self,
|
||||
name: &str,
|
||||
input: Value,
|
||||
) -> Result<ToolCallResponse, BrokerRefusal> {
|
||||
if self.cancel.is_cancelled() {
|
||||
return Err(BrokerRefusal::nested(
|
||||
self.service,
|
||||
NestedFailure::Unavailable("the broker call was withdrawn".to_string()),
|
||||
));
|
||||
pub fn record(&self, entry: Value) -> bool {
|
||||
let mut entry = match entry {
|
||||
Value::Object(fields) => fields,
|
||||
other => {
|
||||
let mut fields = serde_json::Map::new();
|
||||
fields.insert("detail".to_string(), other);
|
||||
fields
|
||||
}
|
||||
};
|
||||
entry.insert(
|
||||
"service".to_string(),
|
||||
Value::String(self.service.name().to_string()),
|
||||
);
|
||||
let mut entry = Value::Object(entry);
|
||||
if entry.to_string().len() > MAX_ACT_RECORD_BYTES {
|
||||
let cut = |key: &str| {
|
||||
entry
|
||||
.get(key)
|
||||
.and_then(Value::as_str)
|
||||
.map_or(Value::Null, |text| {
|
||||
Value::String(text.chars().take(dsh_broker::MAX_ACT_TARGET).collect())
|
||||
})
|
||||
};
|
||||
entry = json!({
|
||||
"service": self.service.name(),
|
||||
"method": cut("method"),
|
||||
"outcome": cut("outcome"),
|
||||
"cut": true,
|
||||
});
|
||||
}
|
||||
let mut acts = self
|
||||
.invocation
|
||||
.broker_acts
|
||||
.lock()
|
||||
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
||||
if acts.2 {
|
||||
return false;
|
||||
}
|
||||
acts.0 += 1;
|
||||
if acts.1.len() < RECEIPTS_ATTACHED {
|
||||
acts.1.push(entry);
|
||||
}
|
||||
true
|
||||
}
|
||||
|
||||
pub async fn act(
|
||||
&self,
|
||||
method: &str,
|
||||
effect: BrokerEffect,
|
||||
target: Option<&str>,
|
||||
) -> Result<(), BrokerRefusal> {
|
||||
let target: Option<String> =
|
||||
target.map(|target| target.chars().take(dsh_broker::MAX_ACT_TARGET).collect());
|
||||
let record = |outcome: &str| -> bool {
|
||||
let mut entry =
|
||||
json!({ "method": method, "effect": effect.name(), "outcome": outcome });
|
||||
if let Some(target) = &target {
|
||||
entry["target"] = json!(target);
|
||||
}
|
||||
self.record(entry)
|
||||
};
|
||||
if self.cancel.is_cancelled() {
|
||||
return Err(self.withdrawn());
|
||||
}
|
||||
if effect == BrokerEffect::Read {
|
||||
if let Err(refusal) = self.count() {
|
||||
record(refusal.code());
|
||||
return Err(refusal);
|
||||
}
|
||||
if !record("read") {
|
||||
return Err(self.withdrawn());
|
||||
}
|
||||
return Ok(());
|
||||
}
|
||||
let gate_tool = effect.gate_tool();
|
||||
if !self.invocation.gates.contains(&gate_tool) {
|
||||
record("refused");
|
||||
return Err(BrokerRefusal::Refused {
|
||||
service: self.service,
|
||||
message: "the permission gate is not available in this turn".to_string(),
|
||||
});
|
||||
}
|
||||
let slot = tokio::select! {
|
||||
slot = self.invocation.act_slots.acquire() => slot.ok(),
|
||||
() = self.cancel.cancelled() => None,
|
||||
() = self.invocation.cancel.cancelled() => None,
|
||||
};
|
||||
if slot.is_none() {
|
||||
return Err(self.withdrawn());
|
||||
}
|
||||
if let Err(refusal) = self.count() {
|
||||
record(refusal.code());
|
||||
return Err(refusal);
|
||||
}
|
||||
let mut input = json!({
|
||||
"plugin": self.invocation.owner.plugin_id,
|
||||
"service": self.service.name(),
|
||||
"method": method,
|
||||
"effect": effect.name(),
|
||||
});
|
||||
if let Some(target) = &target {
|
||||
input["target"] = json!(target);
|
||||
}
|
||||
let Some(_open) = OpenAct::open(&input, Arc::as_ptr(&self.invocation) as usize) else {
|
||||
record("refused");
|
||||
return Err(BrokerRefusal::Refused {
|
||||
service: self.service,
|
||||
message: "too many broker acts are waiting on the permission gate".to_string(),
|
||||
});
|
||||
};
|
||||
match self.call_counted(gate_tool, input.clone()).await {
|
||||
Ok(response) if response.ok && dsh_broker::answered_for(&input, &response.result) => {
|
||||
if !record("allowed") {
|
||||
return Err(self.withdrawn());
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
Ok(_) => {
|
||||
record("refused");
|
||||
Err(BrokerRefusal::Refused {
|
||||
service: self.service,
|
||||
message: "the permission gate refused this act".to_string(),
|
||||
})
|
||||
}
|
||||
Err(refusal) => {
|
||||
record(refusal.code());
|
||||
Err(refusal)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn withdrawn(&self) -> BrokerRefusal {
|
||||
BrokerRefusal::nested(
|
||||
self.service,
|
||||
NestedFailure::Unavailable("the broker call was withdrawn".to_string()),
|
||||
)
|
||||
}
|
||||
|
||||
fn count(&self) -> Result<(), BrokerRefusal> {
|
||||
if self.invocation.nested_calls.fetch_add(1, Ordering::SeqCst) >= MAX_CALLS_PER_INVOCATION {
|
||||
return Err(BrokerRefusal::nested(
|
||||
self.service,
|
||||
@@ -331,6 +470,26 @@ impl BrokerContext {
|
||||
},
|
||||
));
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub async fn core_call(
|
||||
&self,
|
||||
name: &str,
|
||||
input: Value,
|
||||
) -> Result<ToolCallResponse, BrokerRefusal> {
|
||||
if self.cancel.is_cancelled() {
|
||||
return Err(self.withdrawn());
|
||||
}
|
||||
self.count()?;
|
||||
self.call_counted(name, input).await
|
||||
}
|
||||
|
||||
async fn call_counted(
|
||||
&self,
|
||||
name: &str,
|
||||
input: Value,
|
||||
) -> Result<ToolCallResponse, BrokerRefusal> {
|
||||
self.invocation
|
||||
.calls
|
||||
.call(name.to_string(), input, Some(&self.cancel))
|
||||
@@ -345,7 +504,7 @@ impl BrokerContext {
|
||||
let tool = ToolContext::new(std::path::PathBuf::from("."));
|
||||
let gate = NestedCallGate::admitting_for_test();
|
||||
let calls = CodemodeInvoker::for_extension(
|
||||
Vec::new(),
|
||||
dsh_broker::BrokerActTool::all().to_vec(),
|
||||
tool.clone(),
|
||||
gate.clone(),
|
||||
String::new(),
|
||||
@@ -363,8 +522,11 @@ impl BrokerContext {
|
||||
root_caller: None,
|
||||
broker: None,
|
||||
nested_calls: AtomicU32::new(0),
|
||||
broker_acts: Mutex::new((0, Vec::new(), false)),
|
||||
tickets: Vec::new(),
|
||||
caller_tools: Vec::new(),
|
||||
gates: dsh_broker::GATE_TOOLS.to_vec(),
|
||||
act_slots: tokio::sync::Semaphore::new(dsh_broker::MAX_OPEN_ACTS_PER_INVOCATION),
|
||||
activations: Mutex::new(HashMap::new()),
|
||||
session_call_lock: tokio::sync::Mutex::new(()),
|
||||
cancel: CancellationToken::new(),
|
||||
@@ -511,12 +673,16 @@ impl CoreCalls {
|
||||
.as_ref()
|
||||
.map(|session| session.session_id.clone())
|
||||
.filter(|id| !id.is_empty());
|
||||
let root_agent = context.execution.owner_agent_id.is_none();
|
||||
let broker_tickets: Vec<(DshService, Ticket)> = broker_session
|
||||
.iter()
|
||||
.flat_map(|session| {
|
||||
DshService::ALL
|
||||
DshService::EVERY
|
||||
.into_iter()
|
||||
.filter(|service| tier == HostTier::Plugin && broker_services.contains(service))
|
||||
.filter(|service| {
|
||||
broker_services.contains(service)
|
||||
&& dsh_broker::mintable(tier, owner, *service, root_agent)
|
||||
})
|
||||
.map(move |service| {
|
||||
(
|
||||
service,
|
||||
@@ -544,9 +710,19 @@ impl CoreCalls {
|
||||
context: Arc::new(context),
|
||||
}
|
||||
});
|
||||
let gates: Vec<&'static str> = dsh_broker::GATE_TOOLS
|
||||
.into_iter()
|
||||
.filter(|gate| {
|
||||
specs.iter().any(|spec| {
|
||||
spec.name().eq_ignore_ascii_case(gate)
|
||||
&& dsh_broker::is_gate_spec(spec.as_ref())
|
||||
})
|
||||
})
|
||||
.collect();
|
||||
let caller_tools = specs
|
||||
.iter()
|
||||
.map(|spec| spec.name().to_string())
|
||||
.filter(|name| !dsh_broker::is_gate_tool(name))
|
||||
.filter(|name| {
|
||||
!context
|
||||
.disallowed_tools
|
||||
@@ -566,6 +742,7 @@ impl CoreCalls {
|
||||
root_caller,
|
||||
broker,
|
||||
nested_calls: AtomicU32::new(0),
|
||||
broker_acts: Mutex::new((0, Vec::new(), false)),
|
||||
tickets: std::iter::once(ticket.clone())
|
||||
.chain(checkpoint_ticket.iter().cloned())
|
||||
.chain(question_ticket.iter().cloned())
|
||||
@@ -573,6 +750,8 @@ impl CoreCalls {
|
||||
.chain(broker_tickets.iter().map(|(_, ticket)| ticket.clone()))
|
||||
.collect(),
|
||||
caller_tools,
|
||||
gates,
|
||||
act_slots: tokio::sync::Semaphore::new(dsh_broker::MAX_OPEN_ACTS_PER_INVOCATION),
|
||||
activations: Mutex::new(HashMap::new()),
|
||||
session_call_lock: tokio::sync::Mutex::new(()),
|
||||
cancel: CancellationToken::new(),
|
||||
@@ -1299,6 +1478,9 @@ impl CoreCalls {
|
||||
.as_ref()
|
||||
.map(|scope| (scope.session_id.clone(), Arc::clone(&scope.context)))
|
||||
.ok_or_else(|| refused("dsh/broker requires an invocation in a session".into()))?;
|
||||
if service.builtin_only() && tool.execution.owner_agent_id.is_some() {
|
||||
return Err(BrokerRefusal::NotGranted(service).wire());
|
||||
}
|
||||
if !shared.broker_granted(¶ms.owner, service).await {
|
||||
return Err(BrokerRefusal::NotGranted(service).wire());
|
||||
}
|
||||
@@ -1386,6 +1568,15 @@ impl CoreCalls {
|
||||
METHOD,
|
||||
&cx,
|
||||
)?;
|
||||
if dsh_broker::is_gate_tool(¶ms.name) {
|
||||
return Err(refuse(
|
||||
error_code::REFUSED,
|
||||
format!(
|
||||
"`{}` is the host broker's permission gate; only the broker reaches it",
|
||||
params.name
|
||||
),
|
||||
));
|
||||
}
|
||||
if invocation.nested_calls.fetch_add(1, Ordering::SeqCst) >= MAX_CALLS_PER_INVOCATION {
|
||||
return Err(refuse(
|
||||
error_code::REFUSED,
|
||||
@@ -1544,8 +1735,33 @@ impl InvocationGuard {
|
||||
/// The receipts of the core calls made so far, bounded, for the tool's
|
||||
/// result metadata; `None` when it made none.
|
||||
pub fn receipts(&self) -> Option<Value> {
|
||||
let receipts = self.invocation.calls.receipts_json(RECEIPTS_ATTACHED);
|
||||
(receipts["total"].as_u64().unwrap_or(0) > 0).then_some(receipts)
|
||||
self.snapshot(false)
|
||||
}
|
||||
|
||||
pub fn seal_receipts(&self) -> Option<Value> {
|
||||
self.snapshot(true)
|
||||
}
|
||||
|
||||
fn snapshot(&self, seal: bool) -> Option<Value> {
|
||||
let (total, acts) = {
|
||||
let mut guard = self
|
||||
.invocation
|
||||
.broker_acts
|
||||
.lock()
|
||||
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
||||
if seal {
|
||||
guard.2 = true;
|
||||
}
|
||||
(guard.0, guard.1.clone())
|
||||
};
|
||||
if seal {
|
||||
self.invocation.cancel.cancel();
|
||||
}
|
||||
let mut receipts = self.invocation.calls.receipts_json(RECEIPTS_ATTACHED);
|
||||
if total > 0 {
|
||||
receipts["broker_acts"] = json!({ "total": total, "acts": acts });
|
||||
}
|
||||
(receipts["total"].as_u64().unwrap_or(0) > 0 || total > 0).then_some(receipts)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1554,3 +1770,86 @@ impl Drop for InvocationGuard {
|
||||
self.core_calls.end(&self.ticket);
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod seal_tests {
|
||||
use super::*;
|
||||
use crate::tools::codemode::{NestedCallRequest, NestedCallVerdict};
|
||||
use crate::tools::spec::ToolResult;
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_successful_gate_answer_after_sealing_cannot_record_or_perform_an_act() {
|
||||
let owner = OwnerRef {
|
||||
plugin_id: "sealed-gate".into(),
|
||||
generation: 1,
|
||||
owner_token: "fixture".into(),
|
||||
};
|
||||
let caller = ExtensionCaller {
|
||||
origin: "extension:sealed-gate".into(),
|
||||
tool: "sealed_tool".into(),
|
||||
scope: "ext:sealed-gate@hash".into(),
|
||||
};
|
||||
let context = ToolContext::new(std::path::PathBuf::from("."));
|
||||
let (events, _events) = tokio::sync::mpsc::channel(8);
|
||||
let (gate, mut requests) = NestedCallGate::new(None, events, Duration::from_secs(5));
|
||||
let gate = gate.for_extension(caller.clone(), dsh_broker::BrokerActTool::all().to_vec());
|
||||
let calls = Arc::new(CoreCalls::default());
|
||||
let guard = calls
|
||||
.begin(
|
||||
HostTier::Plugin,
|
||||
1,
|
||||
&owner,
|
||||
"call",
|
||||
&caller,
|
||||
&context,
|
||||
&gate,
|
||||
)
|
||||
.expect("invocation");
|
||||
let broker = BrokerContext {
|
||||
invocation: Arc::clone(&guard.invocation),
|
||||
tool: Arc::new(context),
|
||||
service: DshService::Remote,
|
||||
cancel: CancellationToken::new(),
|
||||
};
|
||||
assert!(broker.record(json!({"method": "before", "outcome": "read"})));
|
||||
let performed = std::sync::atomic::AtomicBool::new(false);
|
||||
let (result, sealed) = tokio::join!(
|
||||
async {
|
||||
broker
|
||||
.act("write", BrokerEffect::Write, Some("late"))
|
||||
.await?;
|
||||
performed.store(true, Ordering::SeqCst);
|
||||
Ok::<(), BrokerRefusal>(())
|
||||
},
|
||||
async {
|
||||
let Some(NestedCallRequest::Tool(request)) = requests.recv().await else {
|
||||
panic!("the act must reach its gate before sealing");
|
||||
};
|
||||
let sealed = guard.seal_receipts().expect("the earlier record survives");
|
||||
assert!(!broker.cancel.is_cancelled());
|
||||
assert!(
|
||||
request
|
||||
.reply
|
||||
.send(NestedCallVerdict::Answered {
|
||||
result: ToolResult::success(request.input.to_string()),
|
||||
hook_context: None,
|
||||
})
|
||||
.is_ok(),
|
||||
"the gate response is still delivered"
|
||||
);
|
||||
sealed
|
||||
}
|
||||
);
|
||||
assert!(
|
||||
result.is_err(),
|
||||
"a successful late answer must be refused: {result:?}"
|
||||
);
|
||||
assert!(!performed.load(Ordering::SeqCst));
|
||||
assert!(!broker.record(json!({"method": "late", "outcome": "allowed"})));
|
||||
assert_eq!(sealed["broker_acts"]["total"], 1);
|
||||
assert_eq!(
|
||||
guard.receipts().unwrap()["broker_acts"],
|
||||
sealed["broker_acts"]
|
||||
);
|
||||
}
|
||||
}
|
||||
File diff suppressed because it is too large.
Load diff
@@ -7,10 +7,15 @@ use serde_json::{Value, json};
|
||||
|
||||
use super::protocol::{DshService, RpcErrorWire, error_code};
|
||||
use super::registry::OwnerRegistry;
|
||||
use super::tier::{HOST_OWNER_PREFIX, HostTier};
|
||||
use super::{
|
||||
dsh_catalog, dsh_llm, dsh_network, dsh_remote, dsh_settings, dsh_terminal, dsh_workspace,
|
||||
dsh_catalog, dsh_llm, dsh_network, dsh_plugins, dsh_remote, dsh_settings, dsh_terminal,
|
||||
dsh_workspace,
|
||||
};
|
||||
use crate::tools::codemode::{NestedDecision, NestedFailure};
|
||||
use crate::tools::spec::{
|
||||
ApprovalRequirement, ToolCapability, ToolContext, ToolError, ToolResult, ToolSpec,
|
||||
};
|
||||
|
||||
pub use super::core_call::BrokerContext;
|
||||
|
||||
@@ -149,8 +154,52 @@ pub const TABLE: &[(DshService, Arm)] = &[
|
||||
(DshService::Catalog, dsh_catalog::serve as Arm),
|
||||
(DshService::Terminal, dsh_terminal::serve as Arm),
|
||||
(DshService::Remote, dsh_remote::serve as Arm),
|
||||
(DshService::Plugins, dsh_plugins::serve as Arm),
|
||||
];
|
||||
|
||||
pub const BUILTIN_SERVICES: &[(&str, &[DshService])] = &[("creator", &[DshService::Plugins])];
|
||||
|
||||
#[must_use]
|
||||
pub fn builtin_services(owner_id: &str) -> &'static [DshService] {
|
||||
owner_id
|
||||
.strip_prefix(HOST_OWNER_PREFIX)
|
||||
.and_then(|module| {
|
||||
BUILTIN_SERVICES
|
||||
.iter()
|
||||
.find(|(id, _)| *id == module)
|
||||
.map(|(_, services)| *services)
|
||||
})
|
||||
.unwrap_or(&[])
|
||||
}
|
||||
|
||||
fn builtin_route(owner: &OwnerRef, service: DshService) -> bool {
|
||||
owner.plugin_id.starts_with(HOST_OWNER_PREFIX) || service.builtin_only()
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn builtin_granted(
|
||||
registry: &OwnerRegistry,
|
||||
owner: &OwnerRef,
|
||||
service: DshService,
|
||||
) -> Option<bool> {
|
||||
builtin_route(owner, service).then(|| {
|
||||
registry.tier_of(owner) == Some(HostTier::Builtin)
|
||||
&& builtin_services(&owner.plugin_id).contains(&service)
|
||||
})
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn mintable(tier: HostTier, owner: &OwnerRef, service: DshService, root_agent: bool) -> bool {
|
||||
if builtin_route(owner, service) || tier == HostTier::Builtin {
|
||||
tier == HostTier::Builtin
|
||||
&& owner.plugin_id.starts_with(HOST_OWNER_PREFIX)
|
||||
&& builtin_services(&owner.plugin_id).contains(&service)
|
||||
&& (root_agent || !service.builtin_only())
|
||||
} else {
|
||||
tier == HostTier::Plugin
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
thread_local! {
|
||||
static TEST_GRANTS: std::cell::RefCell<Option<Vec<DshService>>> =
|
||||
@@ -193,6 +242,9 @@ pub fn offered(service: DshService) -> bool {
|
||||
|
||||
#[must_use]
|
||||
pub fn granted(registry: &OwnerRegistry, owner: &OwnerRef, service: DshService) -> bool {
|
||||
if let Some(granted) = builtin_granted(registry, owner, service) {
|
||||
return granted;
|
||||
}
|
||||
match test_grants() {
|
||||
Some(granted) => granted.contains(&service),
|
||||
None => offered(service) && registry.host_service_granted(owner, service),
|
||||
@@ -201,7 +253,7 @@ pub fn granted(registry: &OwnerRegistry, owner: &OwnerRef, service: DshService)
|
||||
|
||||
#[must_use]
|
||||
pub fn granted_services(registry: &OwnerRegistry, owner: &OwnerRef) -> Vec<DshService> {
|
||||
DshService::ALL
|
||||
DshService::EVERY
|
||||
.into_iter()
|
||||
.filter(|service| granted(registry, owner, *service))
|
||||
.collect()
|
||||
@@ -225,6 +277,7 @@ pub fn ticket_method(service: DshService) -> &'static str {
|
||||
DshService::Catalog => "dsh/broker:catalog",
|
||||
DshService::Terminal => "dsh/broker:terminal",
|
||||
DshService::Remote => "dsh/broker:remote",
|
||||
DshService::Plugins => "dsh/broker:plugins",
|
||||
}
|
||||
}
|
||||
|
||||
@@ -252,3 +305,242 @@ pub fn not_available(service: DshService) -> BrokerFuture {
|
||||
service,
|
||||
))))
|
||||
}
|
||||
|
||||
pub const ACT_TOOL: &str = "dsh_broker_act";
|
||||
pub const REACH_TOOL: &str = "dsh_broker_reach";
|
||||
pub const GATE_TOOLS: [&str; 2] = [ACT_TOOL, REACH_TOOL];
|
||||
pub const MAX_ACT_TARGET: usize = 256;
|
||||
const MAX_OPEN_ACTS: usize = 256;
|
||||
pub const MAX_OPEN_ACTS_PER_INVOCATION: usize = 4;
|
||||
|
||||
#[must_use]
|
||||
pub fn is_gate_tool(name: &str) -> bool {
|
||||
GATE_TOOLS
|
||||
.iter()
|
||||
.any(|tool| name.eq_ignore_ascii_case(tool))
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
|
||||
#[serde(rename_all = "snake_case")]
|
||||
pub enum BrokerEffect {
|
||||
Read,
|
||||
Write,
|
||||
Reach,
|
||||
}
|
||||
|
||||
impl BrokerEffect {
|
||||
#[must_use]
|
||||
pub fn name(self) -> &'static str {
|
||||
match self {
|
||||
Self::Read => "read",
|
||||
Self::Write => "write",
|
||||
Self::Reach => "reach",
|
||||
}
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn gate_tool(self) -> &'static str {
|
||||
match self {
|
||||
Self::Reach => REACH_TOOL,
|
||||
Self::Read | Self::Write => ACT_TOOL,
|
||||
}
|
||||
}
|
||||
|
||||
fn of(input: &Value) -> Option<Self> {
|
||||
serde_json::from_value(input.get("effect")?.clone()).ok()
|
||||
}
|
||||
}
|
||||
|
||||
static OPEN_ACTS: std::sync::Mutex<Vec<(usize, Value)>> = std::sync::Mutex::new(Vec::new());
|
||||
|
||||
fn open_acts() -> std::sync::MutexGuard<'static, Vec<(usize, Value)>> {
|
||||
OPEN_ACTS
|
||||
.lock()
|
||||
.unwrap_or_else(std::sync::PoisonError::into_inner)
|
||||
}
|
||||
|
||||
pub struct OpenAct(usize, Value);
|
||||
|
||||
impl OpenAct {
|
||||
#[must_use]
|
||||
pub fn open(input: &Value, holder: usize) -> Option<Self> {
|
||||
let mut open = open_acts();
|
||||
if open.len() >= MAX_OPEN_ACTS {
|
||||
return None;
|
||||
}
|
||||
open.push((holder, input.clone()));
|
||||
Some(Self(holder, input.clone()))
|
||||
}
|
||||
}
|
||||
|
||||
impl Drop for OpenAct {
|
||||
fn drop(&mut self) {
|
||||
let mut open = open_acts();
|
||||
if let Some(at) = open
|
||||
.iter()
|
||||
.position(|(holder, act)| *holder == self.0 && *act == self.1)
|
||||
{
|
||||
open.swap_remove(at);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn act_is_open(input: &Value) -> bool {
|
||||
open_acts().iter().any(|(_, open)| open == input)
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn answered_for(input: &Value, result: &Value) -> bool {
|
||||
match result.get("content") {
|
||||
Some(Value::String(text)) => {
|
||||
serde_json::from_str::<Value>(text).is_ok_and(|answered| answered == *input)
|
||||
}
|
||||
Some(other) => other == input,
|
||||
None => false,
|
||||
}
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn is_gate_spec(spec: &dyn ToolSpec) -> bool {
|
||||
is_gate_tool(spec.name())
|
||||
&& spec.registration_origin() == std::any::type_name::<BrokerActTool>()
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn act_description(input: &Value) -> String {
|
||||
let field = |key: &str| input.get(key).and_then(Value::as_str).unwrap_or("?");
|
||||
let verb = match BrokerEffect::of(input) {
|
||||
Some(BrokerEffect::Write) => "change something",
|
||||
Some(BrokerEffect::Reach) => "reach outside this session",
|
||||
_ => "read",
|
||||
};
|
||||
let target = input
|
||||
.get("target")
|
||||
.and_then(Value::as_str)
|
||||
.map(|target| format!(" ({target})"))
|
||||
.unwrap_or_default();
|
||||
format!(
|
||||
"plugin `{}` asks to {verb} through the {} service: `{}`{target}",
|
||||
field("plugin"),
|
||||
field("service"),
|
||||
field("method"),
|
||||
)
|
||||
}
|
||||
|
||||
pub struct BrokerActTool {
|
||||
reach: bool,
|
||||
}
|
||||
|
||||
impl BrokerActTool {
|
||||
pub const ACT: Self = Self { reach: false };
|
||||
pub const REACH: Self = Self { reach: true };
|
||||
|
||||
#[must_use]
|
||||
pub fn all() -> [std::sync::Arc<dyn ToolSpec>; 2] {
|
||||
[
|
||||
std::sync::Arc::new(Self::ACT),
|
||||
std::sync::Arc::new(Self::REACH),
|
||||
]
|
||||
}
|
||||
|
||||
fn effects(&self) -> &'static [&'static str] {
|
||||
if self.reach {
|
||||
&["reach"]
|
||||
} else {
|
||||
&["read", "write"]
|
||||
}
|
||||
}
|
||||
|
||||
fn admits(&self, input: &Value) -> Result<(), ToolError> {
|
||||
let fits = BrokerEffect::of(input)
|
||||
.is_some_and(|effect| (effect == BrokerEffect::Reach) == self.reach);
|
||||
if fits && act_is_open(input) {
|
||||
Ok(())
|
||||
} else {
|
||||
Err(ToolError::permission_denied(format!(
|
||||
"{} answers only for an act a plugin broker has open",
|
||||
self.name()
|
||||
)))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[async_trait::async_trait]
|
||||
impl ToolSpec for BrokerActTool {
|
||||
fn name(&self) -> &str {
|
||||
if self.reach { REACH_TOOL } else { ACT_TOOL }
|
||||
}
|
||||
|
||||
fn description(&self) -> &str {
|
||||
"The session's permission gate for one act a plugin asked the host broker for."
|
||||
}
|
||||
|
||||
fn input_schema(&self) -> Value {
|
||||
json!({
|
||||
"type": "object",
|
||||
"properties": {
|
||||
"plugin": {"type": "string"},
|
||||
"service": {"type": "string"},
|
||||
"method": {"type": "string"},
|
||||
"effect": {"type": "string", "enum": self.effects()},
|
||||
"target": {"type": "string"},
|
||||
},
|
||||
"required": ["plugin", "service", "method", "effect"],
|
||||
"additionalProperties": false,
|
||||
})
|
||||
}
|
||||
|
||||
fn capabilities(&self) -> Vec<ToolCapability> {
|
||||
if self.reach {
|
||||
vec![ToolCapability::Network]
|
||||
} else {
|
||||
Vec::new()
|
||||
}
|
||||
}
|
||||
|
||||
fn approval_requirement(&self) -> ApprovalRequirement {
|
||||
ApprovalRequirement::Required
|
||||
}
|
||||
|
||||
fn approval_requirement_for(&self, input: &Value) -> ApprovalRequirement {
|
||||
match BrokerEffect::of(input) {
|
||||
Some(BrokerEffect::Read) => ApprovalRequirement::Auto,
|
||||
_ => ApprovalRequirement::Required,
|
||||
}
|
||||
}
|
||||
|
||||
fn is_read_only(&self) -> bool {
|
||||
false
|
||||
}
|
||||
|
||||
fn is_read_only_for(&self, input: &Value) -> bool {
|
||||
BrokerEffect::of(input) == Some(BrokerEffect::Read)
|
||||
}
|
||||
|
||||
fn model_visible(&self) -> bool {
|
||||
false
|
||||
}
|
||||
|
||||
fn prepare(
|
||||
&self,
|
||||
input: Value,
|
||||
_context: &ToolContext,
|
||||
) -> Result<crate::tools::spec::PreparedToolCall, ToolError> {
|
||||
self.admits(&input)?;
|
||||
Ok(crate::tools::spec::PreparedToolCall {
|
||||
name: self.name().to_string(),
|
||||
description: act_description(&input),
|
||||
read_only: self.is_read_only_for(&input),
|
||||
supports_parallel: false,
|
||||
starts_detached: false,
|
||||
approval: self.approval_requirement_for(&input),
|
||||
resources: vec![crate::tools::spec::ResourceClaim::GlobalExclusive],
|
||||
input,
|
||||
})
|
||||
}
|
||||
|
||||
async fn execute(&self, input: Value, _context: &ToolContext) -> Result<ToolResult, ToolError> {
|
||||
self.admits(&input)?;
|
||||
Ok(ToolResult::success(input.to_string()))
|
||||
}
|
||||
}
|
||||
@@ -1,6 +1,337 @@
|
||||
use super::dsh_broker::{BrokerCall, BrokerFuture, not_available};
|
||||
use super::protocol::DshService;
|
||||
use std::sync::Arc;
|
||||
|
||||
pub(super) fn serve(_call: BrokerCall) -> BrokerFuture {
|
||||
not_available(DshService::Catalog)
|
||||
use codewhale_config::PluginAuthority;
|
||||
use codewhale_plugins::PluginRegistry;
|
||||
use codewhale_plugins::activation::{
|
||||
PluginActivationCapability, PolicyScope, extension_host_policy_enabled,
|
||||
};
|
||||
use codewhale_plugins::install::dsh::{plan_npm_install, refusal_text};
|
||||
use codewhale_plugins::providers::{PluginProviderDeclaration, validate_declarations};
|
||||
use codewhale_plugins::recommend::{
|
||||
PluginMatchSource, PluginNextStep, PluginTaskRecommendation, lookup_reviewable_plugin,
|
||||
};
|
||||
use codewhale_plugins::registry::verify_plugin_component_authority;
|
||||
use serde::Deserialize;
|
||||
use serde_json::{Value, json};
|
||||
|
||||
use super::dsh_broker::{
|
||||
BrokerCall, BrokerEffect, BrokerFuture, BrokerMethods, BrokerRefusal, decode,
|
||||
};
|
||||
use super::protocol::DshService;
|
||||
use crate::pricing::BalanceInfo;
|
||||
|
||||
#[derive(Deserialize)]
|
||||
#[serde(tag = "method", content = "input", deny_unknown_fields)]
|
||||
enum CatalogMethod {
|
||||
#[serde(rename = "install.plan")]
|
||||
InstallPlan(InstallRequest),
|
||||
#[serde(rename = "routes.list")]
|
||||
RoutesList(NoInput),
|
||||
#[serde(rename = "routes.resolve")]
|
||||
RoutesResolve(RouteRequest),
|
||||
#[serde(rename = "balance")]
|
||||
Balance(NoInput),
|
||||
}
|
||||
|
||||
impl BrokerMethods for CatalogMethod {
|
||||
const NAMES: &'static [&'static str] =
|
||||
&["install.plan", "routes.list", "routes.resolve", "balance"];
|
||||
}
|
||||
|
||||
#[derive(Deserialize)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
struct NoInput {}
|
||||
|
||||
#[derive(Deserialize)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
struct InstallRequest {
|
||||
package: String,
|
||||
version: String,
|
||||
#[serde(default)]
|
||||
registry: Option<String>,
|
||||
}
|
||||
|
||||
#[derive(Deserialize)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
struct RouteRequest {
|
||||
provider: String,
|
||||
#[serde(default)]
|
||||
model: Option<String>,
|
||||
}
|
||||
|
||||
pub(super) struct AccountBalance {
|
||||
pub available: bool,
|
||||
pub reading: Option<BalanceInfo>,
|
||||
}
|
||||
|
||||
type ApprovedRoutes = Vec<(String, PluginProviderDeclaration)>;
|
||||
|
||||
pub(super) fn serve(call: BrokerCall) -> BrokerFuture {
|
||||
serve_with(call, None)
|
||||
}
|
||||
|
||||
pub(super) fn serve_with(call: BrokerCall, account: Option<AccountBalance>) -> BrokerFuture {
|
||||
Box::pin(async move {
|
||||
let caller = call.owner.plugin_id.clone();
|
||||
match decode::<CatalogMethod>(&call)? {
|
||||
CatalogMethod::InstallPlan(request) => {
|
||||
let plugins = plugins(&call)?;
|
||||
call.context
|
||||
.act("install.plan", BrokerEffect::Read, Some(&request.package))
|
||||
.await?;
|
||||
install_plan(&plugins, &caller, request)
|
||||
}
|
||||
CatalogMethod::RoutesList(NoInput {}) => {
|
||||
let plugins = plugins(&call)?;
|
||||
call.context
|
||||
.act("routes.list", BrokerEffect::Read, None)
|
||||
.await?;
|
||||
let routes = approved_routes(plugins, &caller).await?;
|
||||
let routes: Vec<Value> = routes
|
||||
.iter()
|
||||
.map(|(name, declaration)| route(name, declaration))
|
||||
.collect();
|
||||
Ok(json!({ "routes": routes }))
|
||||
}
|
||||
CatalogMethod::RoutesResolve(request) => {
|
||||
let plugins = plugins(&call)?;
|
||||
call.context
|
||||
.act(
|
||||
"routes.resolve",
|
||||
BrokerEffect::Read,
|
||||
Some(&request.provider),
|
||||
)
|
||||
.await?;
|
||||
let routes = approved_routes(plugins, &caller).await?;
|
||||
resolve_route(&caller, routes, request)
|
||||
}
|
||||
CatalogMethod::Balance(NoInput {}) => {
|
||||
call.context
|
||||
.act("balance", BrokerEffect::Read, None)
|
||||
.await?;
|
||||
Ok(balance(account))
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
fn plugins(call: &BrokerCall) -> Result<Arc<PluginRegistry>, BrokerRefusal> {
|
||||
call.context
|
||||
.tool()
|
||||
.plugin_registry
|
||||
.clone()
|
||||
.ok_or(BrokerRefusal::NotAvailable(DshService::Catalog))
|
||||
}
|
||||
|
||||
fn refused(message: impl Into<String>) -> BrokerRefusal {
|
||||
BrokerRefusal::Refused {
|
||||
service: DshService::Catalog,
|
||||
message: message.into(),
|
||||
}
|
||||
}
|
||||
|
||||
fn review_command(name: &str, next_step: PluginNextStep) -> String {
|
||||
PluginTaskRecommendation {
|
||||
name: name.to_string(),
|
||||
source: PluginMatchSource::Installed {
|
||||
id: name.to_string(),
|
||||
},
|
||||
matched_terms: Vec::new(),
|
||||
score: 0,
|
||||
next_step,
|
||||
}
|
||||
.command()
|
||||
}
|
||||
|
||||
fn install_plan(
|
||||
plugins: &PluginRegistry,
|
||||
caller: &str,
|
||||
request: InstallRequest,
|
||||
) -> Result<Value, BrokerRefusal> {
|
||||
let plan = plan_npm_install(
|
||||
&request.package,
|
||||
&request.version,
|
||||
request.registry.as_deref(),
|
||||
)
|
||||
.map_err(|reason| {
|
||||
tracing::info!(target: "codewhale::dsh_catalog", plugin = %caller, "install plan refused");
|
||||
refused(reason)
|
||||
})?;
|
||||
let existing = plugins.get(&plan.plugin_name);
|
||||
let (status, command, message) = match existing {
|
||||
Some(existing) => {
|
||||
let command = lookup_reviewable_plugin(existing.name(), plugins, &[])
|
||||
.map(|reviewable| reviewable.command())
|
||||
.unwrap_or_else(|| review_command(existing.name(), PluginNextStep::Inspect));
|
||||
let message = format!(
|
||||
"A plugin named `{}` is already present; nothing was installed. Review it with `{command}`. A market listing does not establish that it is the same bundle.",
|
||||
existing.name()
|
||||
);
|
||||
("already_present", command, message)
|
||||
}
|
||||
None => {
|
||||
let command = review_command(
|
||||
&plan.plugin_name,
|
||||
PluginNextStep::SourceInstall {
|
||||
spec: plan.spec.clone(),
|
||||
},
|
||||
);
|
||||
let message = format!(
|
||||
"Codewhale installs a plugin only through its reviewed install flow; nothing was installed. Review and install {}@{} with `{command}`.",
|
||||
request.package, request.version
|
||||
);
|
||||
("review_required", command, message)
|
||||
}
|
||||
};
|
||||
tracing::info!(
|
||||
target: "codewhale::dsh_catalog",
|
||||
plugin = %caller,
|
||||
package = %request.package,
|
||||
version = %request.version,
|
||||
status,
|
||||
"install planned for review; nothing installed"
|
||||
);
|
||||
let mut answer = json!({
|
||||
"status": status,
|
||||
"package": request.package,
|
||||
"version": request.version,
|
||||
"plugin": plan.plugin_name,
|
||||
"command": command,
|
||||
"message": message,
|
||||
});
|
||||
if existing.is_none() {
|
||||
answer["spec"] = Value::String(plan.spec);
|
||||
}
|
||||
Ok(answer)
|
||||
}
|
||||
|
||||
fn declared_routes(
|
||||
plugins: &PluginRegistry,
|
||||
caller: &str,
|
||||
) -> Result<Option<(ApprovedRoutes, PluginAuthority)>, String> {
|
||||
let Some(plugin) = plugins.get(caller).filter(|plugin| plugin.active()) else {
|
||||
return Ok(None);
|
||||
};
|
||||
if plugin.manifest.providers.is_empty() {
|
||||
return Ok(None);
|
||||
}
|
||||
validate_declarations(&plugin.manifest.providers)?;
|
||||
let authority = plugins
|
||||
.authority_for(caller)
|
||||
.ok_or("the plugin has no review receipt")?;
|
||||
let routes = plugin
|
||||
.manifest
|
||||
.providers
|
||||
.iter()
|
||||
.map(|(name, declaration)| (name.clone(), declaration.clone()))
|
||||
.collect();
|
||||
Ok(Some((routes, authority)))
|
||||
}
|
||||
|
||||
async fn approved_routes(
|
||||
plugins: Arc<PluginRegistry>,
|
||||
caller: &str,
|
||||
) -> Result<ApprovedRoutes, BrokerRefusal> {
|
||||
let receipt = |reason: String| {
|
||||
tracing::info!(
|
||||
target: "codewhale::dsh_catalog",
|
||||
plugin = %caller,
|
||||
reason = %reason,
|
||||
"provider routes refused: the review receipt does not hold"
|
||||
);
|
||||
refused(
|
||||
"the review that approved this plugin's provider routes no longer holds; review the plugin again in Codewhale",
|
||||
)
|
||||
};
|
||||
let Some((routes, authority)) = declared_routes(&plugins, caller).map_err(receipt)? else {
|
||||
return Ok(Vec::new());
|
||||
};
|
||||
let policy = extension_host_policy_enabled();
|
||||
#[cfg(any(test, feature = "test-support"))]
|
||||
let env_scope = crate::test_support::env_scope_ticket();
|
||||
let verified = tokio::task::spawn_blocking(move || {
|
||||
#[cfg(any(test, feature = "test-support"))]
|
||||
let _env_scope = crate::test_support::join_env_scope(env_scope);
|
||||
let _policy = PolicyScope::propagate(policy);
|
||||
verify_plugin_component_authority(&authority, PluginActivationCapability::Providers)
|
||||
})
|
||||
.await;
|
||||
match verified {
|
||||
Ok(Ok(())) => Ok(routes),
|
||||
Ok(Err(reason)) => Err(receipt(reason)),
|
||||
Err(error) => Err(receipt(error.to_string())),
|
||||
}
|
||||
}
|
||||
|
||||
fn resolve_route(
|
||||
caller: &str,
|
||||
routes: ApprovedRoutes,
|
||||
request: RouteRequest,
|
||||
) -> Result<Value, BrokerRefusal> {
|
||||
let Some((name, declaration)) = routes
|
||||
.into_iter()
|
||||
.find(|(name, _)| *name == request.provider)
|
||||
else {
|
||||
tracing::info!(
|
||||
target: "codewhale::dsh_catalog",
|
||||
plugin = %caller,
|
||||
"provider route refused: not approved for this plugin"
|
||||
);
|
||||
return Err(refused(format!(
|
||||
"`{}` is not a provider route approved for this plugin. A plugin cannot register a model adapter in Codewhale: a model route is a provider route you approve in the plugin's review",
|
||||
refusal_text(&request.provider)
|
||||
)));
|
||||
};
|
||||
let model = match request.model {
|
||||
None => declaration.model.clone(),
|
||||
Some(model) => {
|
||||
let offered = if declaration.models.is_empty() {
|
||||
declaration
|
||||
.model
|
||||
.as_deref()
|
||||
.is_none_or(|default| default == model)
|
||||
} else {
|
||||
declaration.models.contains(&model)
|
||||
};
|
||||
if !offered {
|
||||
return Err(refused(format!(
|
||||
"model `{}` is not on the approved provider route `{name}`",
|
||||
refusal_text(&model)
|
||||
)));
|
||||
}
|
||||
Some(model)
|
||||
}
|
||||
};
|
||||
Ok(json!({ "route": route(&name, &declaration), "model": model }))
|
||||
}
|
||||
|
||||
fn route(name: &str, declaration: &PluginProviderDeclaration) -> Value {
|
||||
json!({
|
||||
"provider": name,
|
||||
"base_url": declaration.base_url,
|
||||
"default_model": declaration.model,
|
||||
"models": declaration.models,
|
||||
})
|
||||
}
|
||||
|
||||
fn balance(account: Option<AccountBalance>) -> Value {
|
||||
let Some(account) = account else {
|
||||
return json!({ "status": "unknown" });
|
||||
};
|
||||
if !account.available {
|
||||
return json!({ "status": "absent" });
|
||||
}
|
||||
match account
|
||||
.reading
|
||||
.filter(|reading| !reading.total_balance.trim().is_empty())
|
||||
{
|
||||
Some(reading) => json!({
|
||||
"status": "known",
|
||||
"currency": reading.currency,
|
||||
"total": reading.total_balance,
|
||||
"topped_up": reading.topped_up_balance,
|
||||
"granted": reading.granted_balance,
|
||||
}),
|
||||
None => json!({ "status": "unknown" }),
|
||||
}
|
||||
}
|
||||
@@ -6,10 +6,13 @@ use codewhale_secrets::Secrets;
|
||||
use serde::Deserialize;
|
||||
use serde_json::{Value, json};
|
||||
|
||||
use super::dsh_broker::{BrokerCall, BrokerFuture, BrokerMethods, BrokerRefusal, decode};
|
||||
use super::dsh_broker::{
|
||||
BrokerCall, BrokerEffect, BrokerFuture, BrokerMethods, BrokerRefusal, decode,
|
||||
};
|
||||
use super::protocol::DshService;
|
||||
use crate::tools::spec::ToolContext;
|
||||
use crate::tools::web::guard::validate_fetch_target;
|
||||
use codewhale_net::guard::PrivateTargets;
|
||||
|
||||
pub const CREDENTIAL_HANDLE_PREFIX: &str = "codewhale-credential:";
|
||||
const MAX_REF_LEN: usize = 128;
|
||||
@@ -90,6 +93,8 @@ pub(super) struct NetworkAuthority {
|
||||
pub hosts: BTreeSet<String>,
|
||||
pub tool: Option<ToolContext>,
|
||||
pub vault: Option<Secrets>,
|
||||
#[cfg(test)]
|
||||
pub test_dns_pin: Option<(String, std::net::IpAddr)>,
|
||||
}
|
||||
|
||||
impl NetworkAuthority {
|
||||
@@ -98,6 +103,8 @@ impl NetworkAuthority {
|
||||
hosts: BTreeSet::new(),
|
||||
tool: None,
|
||||
vault: None,
|
||||
#[cfg(test)]
|
||||
test_dns_pin: None,
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -115,11 +122,19 @@ pub(super) fn serve_with(call: BrokerCall, authority: NetworkAuthority) -> Broke
|
||||
let Some(tool) = authority.tool.as_ref() else {
|
||||
return Err(BrokerRefusal::NotAvailable(DshService::Network));
|
||||
};
|
||||
let host = reqwest::Url::parse(&input.url)
|
||||
.ok()
|
||||
.and_then(|url| url.host_str().map(normalized_host));
|
||||
call.context
|
||||
.act("fetch", BrokerEffect::Reach, host.as_deref())
|
||||
.await?;
|
||||
fetch(
|
||||
&plugin,
|
||||
&authority.hosts,
|
||||
tool,
|
||||
authority.vault.as_ref(),
|
||||
#[cfg(test)]
|
||||
authority.test_dns_pin.as_ref(),
|
||||
input,
|
||||
)
|
||||
.await
|
||||
@@ -127,6 +142,9 @@ pub(super) fn serve_with(call: BrokerCall, authority: NetworkAuthority) -> Broke
|
||||
NetworkMethod::Describe(CredentialRef { name }) => {
|
||||
let vault = vault(&authority)?;
|
||||
let name = checked_ref(&name)?;
|
||||
call.context
|
||||
.act("credentials.describe", BrokerEffect::Read, Some(name))
|
||||
.await?;
|
||||
let set = read_secret(vault, &plugin, name)?.is_some();
|
||||
tracing::info!(target: "codewhale::dsh_network", plugin = %plugin, credential = %name, set, "credential described");
|
||||
Ok(json!({ "ref": name, "set": set, "handle": handle(name) }))
|
||||
@@ -134,6 +152,9 @@ pub(super) fn serve_with(call: BrokerCall, authority: NetworkAuthority) -> Broke
|
||||
NetworkMethod::Resolve(CredentialRef { name }) => {
|
||||
let vault = vault(&authority)?;
|
||||
let name = checked_ref(&name)?;
|
||||
call.context
|
||||
.act("credentials.resolve", BrokerEffect::Read, Some(name))
|
||||
.await?;
|
||||
let set = read_secret(vault, &plugin, name)?.is_some();
|
||||
tracing::info!(target: "codewhale::dsh_network", plugin = %plugin, credential = %name, set, "credential resolved to its handle");
|
||||
Ok(json!({ "ref": name, "value": set.then(|| handle(name)) }))
|
||||
@@ -146,6 +167,9 @@ pub(super) fn serve_with(call: BrokerCall, authority: NetworkAuthority) -> Broke
|
||||
"a credential value must be a non-empty secret, not a handle",
|
||||
));
|
||||
}
|
||||
call.context
|
||||
.act("credentials.set", BrokerEffect::Write, Some(name))
|
||||
.await?;
|
||||
vault
|
||||
.set(&vault_slot(&plugin, name), &value)
|
||||
.map_err(|_| invalid("the credential vault refused the write"))?;
|
||||
@@ -315,6 +339,7 @@ async fn fetch(
|
||||
hosts: &BTreeSet<String>,
|
||||
tool: &ToolContext,
|
||||
vault: Option<&Secrets>,
|
||||
#[cfg(test)] test_dns_pin: Option<&(String, std::net::IpAddr)>,
|
||||
input: FetchInput,
|
||||
) -> Result<Value, BrokerRefusal> {
|
||||
let mut url = reqwest::Url::parse(&input.url).map_err(|_| invalid("the URL is not valid"))?;
|
||||
@@ -376,9 +401,26 @@ async fn fetch(
|
||||
let mut substituted: Option<Substituted> = None;
|
||||
let response = loop {
|
||||
egress_host(&url, hosts)?;
|
||||
let pin = validate_fetch_target(&url, tool, AUDIT_LABEL)
|
||||
.await
|
||||
.map_err(|error| invalid(format!("egress refused: {error}")))?;
|
||||
let pin = {
|
||||
#[cfg(test)]
|
||||
if let Some((pinned_host, pinned_ip)) = test_dns_pin
|
||||
&& url
|
||||
.host_str()
|
||||
.is_some_and(|candidate| candidate.eq_ignore_ascii_case(pinned_host))
|
||||
{
|
||||
crate::tools::web::guard::validate_network_policy(&host, tool, AUDIT_LABEL)
|
||||
.map_err(|error| invalid(format!("egress refused: {error}")))?;
|
||||
Some((pinned_host.clone(), *pinned_ip))
|
||||
} else {
|
||||
validate_fetch_target(&url, tool, AUDIT_LABEL, PrivateTargets::Refuse)
|
||||
.await
|
||||
.map_err(|error| invalid(format!("egress refused: {error}")))?
|
||||
}
|
||||
#[cfg(not(test))]
|
||||
validate_fetch_target(&url, tool, AUDIT_LABEL, PrivateTargets::Refuse)
|
||||
.await
|
||||
.map_err(|error| invalid(format!("egress refused: {error}")))?
|
||||
};
|
||||
let substitution = match substituted.take() {
|
||||
Some(done) => done,
|
||||
None => substitute_headers(plugin, vault, &input.headers)?,
|
||||
@@ -539,6 +581,22 @@ mod tests {
|
||||
hosts: hosts.iter().map(|h| (*h).to_string()).collect(),
|
||||
tool: Some(tool),
|
||||
vault: Some(vault.clone()),
|
||||
test_dns_pin: None,
|
||||
}
|
||||
}
|
||||
|
||||
fn authority_with_pin(
|
||||
hosts: &[&str],
|
||||
tool: ToolContext,
|
||||
vault: &Secrets,
|
||||
pinned_host: &str,
|
||||
) -> NetworkAuthority {
|
||||
NetworkAuthority {
|
||||
test_dns_pin: Some((
|
||||
pinned_host.to_string(),
|
||||
std::net::IpAddr::V4(std::net::Ipv4Addr::LOCALHOST),
|
||||
)),
|
||||
..authority(hosts, tool, vault)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -648,11 +706,16 @@ mod tests {
|
||||
"a",
|
||||
"fetch",
|
||||
json!({
|
||||
"url": format!("{}/v1/models", server.uri()),
|
||||
"url": format!("http://api.example.com:{}/v1/models", server.address().port()),
|
||||
"headers": [["authorization", "Bearer codewhale-credential:KEY"]],
|
||||
}),
|
||||
),
|
||||
authority(&["127.0.0.1"], policy(&["127.0.0.1"], &[]), &vault),
|
||||
authority_with_pin(
|
||||
&["api.example.com"],
|
||||
policy(&["api.example.com"], &[]),
|
||||
&vault,
|
||||
"api.example.com",
|
||||
),
|
||||
)
|
||||
.await
|
||||
.unwrap();
|
||||
@@ -708,6 +771,16 @@ mod tests {
|
||||
)
|
||||
.await;
|
||||
assert!(message(&unapproved).contains("egress refused"));
|
||||
let local_allowed = serve_with(
|
||||
call("a", "fetch", json!({"url": url})),
|
||||
authority(&["127.0.0.1"], policy(&["127.0.0.1"], &[]), &vault),
|
||||
)
|
||||
.await;
|
||||
assert!(
|
||||
message(&local_allowed).contains("restricted"),
|
||||
"{}",
|
||||
message(&local_allowed)
|
||||
);
|
||||
let metadata = serve_with(
|
||||
call(
|
||||
"a",
|
||||
@@ -798,16 +871,18 @@ mod tests {
|
||||
let vault = vault();
|
||||
vault.set(&vault_slot("a", "KEY"), SECRET).unwrap();
|
||||
let headers = json!([["authorization", "codewhale-credential:KEY"]]);
|
||||
let both = authority(
|
||||
&["127.0.0.1", "localhost"],
|
||||
policy(&["127.0.0.1", "localhost"], &[]),
|
||||
let base = format!("http://api.example.com:{}", server.address().port());
|
||||
let both = authority_with_pin(
|
||||
&["api.example.com", "localhost"],
|
||||
policy(&["api.example.com", "localhost"], &[]),
|
||||
&vault,
|
||||
"api.example.com",
|
||||
);
|
||||
let away = serve_with(
|
||||
call(
|
||||
"a",
|
||||
"fetch",
|
||||
json!({"url": format!("{}/away", server.uri()), "headers": headers}),
|
||||
json!({"url": format!("{base}/away"), "headers": headers}),
|
||||
),
|
||||
both,
|
||||
)
|
||||
@@ -817,12 +892,13 @@ mod tests {
|
||||
call(
|
||||
"a",
|
||||
"fetch",
|
||||
json!({"url": format!("{}/rename", server.uri()), "headers": headers}),
|
||||
json!({"url": format!("{base}/rename"), "headers": headers}),
|
||||
),
|
||||
authority(
|
||||
&["127.0.0.1", "localhost"],
|
||||
policy(&["127.0.0.1", "localhost"], &[]),
|
||||
authority_with_pin(
|
||||
&["api.example.com", "localhost"],
|
||||
policy(&["api.example.com", "localhost"], &[]),
|
||||
&vault,
|
||||
"api.example.com",
|
||||
),
|
||||
)
|
||||
.await;
|
||||
@@ -831,9 +907,14 @@ mod tests {
|
||||
call(
|
||||
"a",
|
||||
"fetch",
|
||||
json!({"url": format!("{}/hop", server.uri()), "headers": headers}),
|
||||
json!({"url": format!("{base}/hop"), "headers": headers}),
|
||||
),
|
||||
authority_with_pin(
|
||||
&["api.example.com"],
|
||||
policy(&["api.example.com"], &[]),
|
||||
&vault,
|
||||
"api.example.com",
|
||||
),
|
||||
authority(&["127.0.0.1"], policy(&["127.0.0.1"], &[]), &vault),
|
||||
)
|
||||
.await
|
||||
.unwrap();
|
||||
|
||||
@@ -0,0 +1,85 @@
|
||||
use serde::Deserialize;
|
||||
use serde_json::{Map, Value};
|
||||
|
||||
use super::dsh_broker::{
|
||||
BrokerCall, BrokerFuture, BrokerMethods, BrokerRefusal, builtin_services, decode,
|
||||
};
|
||||
use super::protocol::DshService;
|
||||
use crate::tools::spec::ToolContext;
|
||||
|
||||
const LOG: &str = "codewhale::dsh_plugins";
|
||||
const MAX_INPUT_FIELDS: usize = 32;
|
||||
|
||||
#[derive(Deserialize)]
|
||||
#[serde(tag = "method", content = "input", deny_unknown_fields)]
|
||||
enum PluginsMethod {
|
||||
#[serde(rename = "list")]
|
||||
List(Map<String, Value>),
|
||||
#[serde(rename = "status")]
|
||||
Status(Map<String, Value>),
|
||||
#[serde(rename = "posture")]
|
||||
Posture(Map<String, Value>),
|
||||
#[serde(rename = "install")]
|
||||
Install(Map<String, Value>),
|
||||
#[serde(rename = "remove")]
|
||||
Remove(Map<String, Value>),
|
||||
#[serde(rename = "enable")]
|
||||
Enable(Map<String, Value>),
|
||||
#[serde(rename = "disable")]
|
||||
Disable(Map<String, Value>),
|
||||
}
|
||||
|
||||
impl BrokerMethods for PluginsMethod {
|
||||
const NAMES: &'static [&'static str] = &[
|
||||
"list", "status", "posture", "install", "remove", "enable", "disable",
|
||||
];
|
||||
}
|
||||
|
||||
pub(super) fn serve(call: BrokerCall) -> BrokerFuture {
|
||||
Box::pin(async move {
|
||||
let method = decode::<PluginsMethod>(&call)?;
|
||||
if !builtin_services(&call.owner.plugin_id).contains(&DshService::Plugins) {
|
||||
tracing::info!(target: LOG, plugin = %call.owner.plugin_id, "plugins refused: not the creator module");
|
||||
return Err(refused());
|
||||
}
|
||||
let tool = live(&call);
|
||||
if tool.execution.owner_agent_id.is_some() {
|
||||
tracing::info!(target: LOG, "plugins refused: a sub-agent caller");
|
||||
return Err(refused());
|
||||
}
|
||||
if method.input().len() > MAX_INPUT_FIELDS {
|
||||
return Err(BrokerRefusal::InvalidInput {
|
||||
service: DshService::Plugins,
|
||||
message: format!("a plugins input has at most {MAX_INPUT_FIELDS} fields"),
|
||||
});
|
||||
}
|
||||
Err(BrokerRefusal::NotAvailable(DshService::Plugins))
|
||||
})
|
||||
}
|
||||
|
||||
impl PluginsMethod {
|
||||
fn input(&self) -> &Map<String, Value> {
|
||||
match self {
|
||||
Self::List(input)
|
||||
| Self::Status(input)
|
||||
| Self::Posture(input)
|
||||
| Self::Install(input)
|
||||
| Self::Remove(input)
|
||||
| Self::Enable(input)
|
||||
| Self::Disable(input) => input,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn live(call: &BrokerCall) -> ToolContext {
|
||||
let mut tool = call.context.tool().clone();
|
||||
let _ = tool.refresh_live_posture();
|
||||
tool
|
||||
}
|
||||
|
||||
fn refused() -> BrokerRefusal {
|
||||
BrokerRefusal::Refused {
|
||||
service: DshService::Plugins,
|
||||
message: "the plugins service is not available to this caller".to_string(),
|
||||
}
|
||||
}
|
||||
@@ -6,7 +6,9 @@ use serde::Deserialize;
|
||||
use serde_json::{Value, json};
|
||||
use sha2::{Digest, Sha256};
|
||||
|
||||
use super::dsh_broker::{BrokerCall, BrokerFuture, BrokerMethods, BrokerRefusal, decode};
|
||||
use super::dsh_broker::{
|
||||
BrokerCall, BrokerEffect, BrokerFuture, BrokerMethods, BrokerRefusal, decode,
|
||||
};
|
||||
use super::protocol::DshService;
|
||||
|
||||
pub const PAIRING_TTL: Duration = Duration::from_secs(10 * 60);
|
||||
@@ -142,7 +144,16 @@ pub fn remote_grants() -> &'static RemoteGrants {
|
||||
}
|
||||
|
||||
pub(super) fn serve(call: BrokerCall) -> BrokerFuture {
|
||||
Box::pin(std::future::ready(remote_grants().serve(&call)))
|
||||
Box::pin(async move {
|
||||
let (method, effect) = match decode::<RemoteMethod>(&call)? {
|
||||
RemoteMethod::Status {} => ("status", BrokerEffect::Read),
|
||||
RemoteMethod::Pair { .. } => ("pair", BrokerEffect::Reach),
|
||||
RemoteMethod::Clients {} => ("clients", BrokerEffect::Read),
|
||||
RemoteMethod::Revoke { .. } => ("revoke", BrokerEffect::Write),
|
||||
};
|
||||
call.context.act(method, effect, None).await?;
|
||||
remote_grants().serve(&call)
|
||||
})
|
||||
}
|
||||
|
||||
impl RemoteGrants {
|
||||
|
||||
File diff suppressed because it is too large.
Load diff
@@ -5,7 +5,9 @@ use codewhale_workflow_js::ToolCallResponse;
|
||||
use serde::{Deserialize, Serialize};
|
||||
use serde_json::{Value, json};
|
||||
|
||||
use super::dsh_broker::{BrokerCall, BrokerFuture, BrokerMethods, BrokerRefusal, decode};
|
||||
use super::dsh_broker::{
|
||||
BrokerCall, BrokerEffect, BrokerFuture, BrokerMethods, BrokerRefusal, decode,
|
||||
};
|
||||
use super::protocol::DshService;
|
||||
use crate::tools::execution_envelope::enforce_tool_denial;
|
||||
|
||||
@@ -121,6 +123,7 @@ pub(super) fn serve(call: BrokerCall) -> BrokerFuture {
|
||||
match method {
|
||||
TerminalMethod::List(NoInput {}) => {
|
||||
let live = live(&call, "terminal/wait").await?;
|
||||
call.context.act("list", BrokerEffect::Read, None).await?;
|
||||
tracing::info!(target: LOG, plugin = %call.owner.plugin_id, terminals = live.terminals.len(), "terminals listed");
|
||||
Ok(json!({
|
||||
"instance": live.instance,
|
||||
|
||||
@@ -126,6 +126,7 @@ pub mod dsh_broker;
|
||||
mod dsh_catalog;
|
||||
mod dsh_llm;
|
||||
mod dsh_network;
|
||||
mod dsh_plugins;
|
||||
mod dsh_remote;
|
||||
pub use dsh_remote::{RemoteClient, RemoteDenial, RemoteGrants, RemotePairing, remote_grants};
|
||||
mod dsh_settings;
|
||||
@@ -1933,6 +1934,11 @@ impl ExtensionHostManager {
|
||||
if tools.is_empty() {
|
||||
return Vec::new();
|
||||
}
|
||||
for gate in dsh_broker::BrokerActTool::all() {
|
||||
if tool_registry.get(gate.name()).is_none() {
|
||||
tool_registry.register(gate);
|
||||
}
|
||||
}
|
||||
let taken: HashSet<String> = tool_registry
|
||||
.names()
|
||||
.into_iter()
|
||||
@@ -3629,6 +3635,9 @@ impl ManagerShared {
|
||||
})
|
||||
}
|
||||
pub(super) fn broker_services(&self, owner: &OwnerRef) -> Vec<protocol::DshService> {
|
||||
if let Some(granted) = dsh_broker::test_grants() {
|
||||
return granted;
|
||||
}
|
||||
dsh_broker::granted_services(&self.registry.lock().expect("registry lock"), owner)
|
||||
}
|
||||
|
||||
@@ -3637,6 +3646,13 @@ impl ManagerShared {
|
||||
owner: &OwnerRef,
|
||||
service: protocol::DshService,
|
||||
) -> bool {
|
||||
if let Some(granted) = dsh_broker::builtin_granted(
|
||||
&self.registry.lock().expect("registry lock"),
|
||||
owner,
|
||||
service,
|
||||
) {
|
||||
return granted;
|
||||
}
|
||||
if let Some(granted) = dsh_broker::test_grants() {
|
||||
return granted.contains(&service);
|
||||
}
|
||||
|
||||
@@ -38,7 +38,7 @@ pub const MAX_PLUGIN_CONFIG_BYTES: usize = 16 * 1024;
|
||||
/// Deepest nesting of tables and arrays accepted.
|
||||
const MAX_CONFIG_DEPTH: usize = 16;
|
||||
/// How the `toml` crate serializes a date-time (a one-key table).
|
||||
const TOML_DATETIME_KEY: &str = "$__toml_private_datetime";
|
||||
pub(super) const TOML_DATETIME_KEY: &str = "$__toml_private_datetime";
|
||||
|
||||
/// The config one activation is given, and its digest.
|
||||
#[derive(Debug, Clone, PartialEq)]
|
||||
@@ -89,7 +89,7 @@ fn has_datetime(value: &Value) -> bool {
|
||||
}
|
||||
|
||||
/// One plugin's `[plugins."<name>".config]`, checked.
|
||||
fn convert(name: &str, settings: &PluginSettings) -> Result<PluginConfig, String> {
|
||||
pub(super) fn convert(name: &str, settings: &PluginSettings) -> Result<PluginConfig, String> {
|
||||
let Some(table) = &settings.config else {
|
||||
return Ok(PluginConfig::empty());
|
||||
};
|
||||
|
||||
@@ -540,6 +540,7 @@ pub enum DshService {
|
||||
Catalog,
|
||||
Terminal,
|
||||
Remote,
|
||||
Plugins,
|
||||
}
|
||||
|
||||
impl DshService {
|
||||
@@ -553,6 +554,19 @@ impl DshService {
|
||||
Self::Remote,
|
||||
];
|
||||
|
||||
pub const BUILTIN_ONLY: [Self; 1] = [Self::Plugins];
|
||||
|
||||
pub const EVERY: [Self; 8] = [
|
||||
Self::Workspace,
|
||||
Self::Llm,
|
||||
Self::Network,
|
||||
Self::Settings,
|
||||
Self::Catalog,
|
||||
Self::Terminal,
|
||||
Self::Remote,
|
||||
Self::Plugins,
|
||||
];
|
||||
|
||||
#[must_use]
|
||||
pub fn name(self) -> &'static str {
|
||||
match self {
|
||||
@@ -563,12 +577,20 @@ impl DshService {
|
||||
Self::Catalog => "catalog",
|
||||
Self::Terminal => "terminal",
|
||||
Self::Remote => "remote",
|
||||
Self::Plugins => "plugins",
|
||||
}
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn parse(name: &str) -> Option<Self> {
|
||||
Self::ALL.into_iter().find(|service| service.name() == name)
|
||||
Self::EVERY
|
||||
.into_iter()
|
||||
.find(|service| service.name() == name)
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn builtin_only(self) -> bool {
|
||||
Self::BUILTIN_ONLY.contains(&self)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -196,7 +196,7 @@ fn render() -> String {
|
||||
let _ = writeln!(out, " {name}: {code},");
|
||||
}
|
||||
out.push_str("} as const\n\nexport type Direction = 'core_to_host' | 'host_to_core'\n");
|
||||
let services: Vec<String> = DshService::ALL
|
||||
let services: Vec<String> = DshService::EVERY
|
||||
.iter()
|
||||
.map(|service| quote(service.name()))
|
||||
.collect();
|
||||
@@ -676,7 +676,7 @@ fn dsh_broker_is_one_strict_envelope_and_names_only_the_closed_service_list() {
|
||||
unknown["params"]["service"] = json!("vault");
|
||||
assert!(parse_host_message(unknown, tier).is_ok());
|
||||
}
|
||||
let names: Vec<&str> = DshService::ALL
|
||||
let names: Vec<&str> = DshService::EVERY
|
||||
.iter()
|
||||
.map(|service| service.name())
|
||||
.collect();
|
||||
@@ -689,10 +689,17 @@ fn dsh_broker_is_one_strict_envelope_and_names_only_the_closed_service_list() {
|
||||
"settings",
|
||||
"catalog",
|
||||
"terminal",
|
||||
"remote"
|
||||
"remote",
|
||||
"plugins"
|
||||
]
|
||||
);
|
||||
for service in DshService::ALL {
|
||||
assert_eq!(DshService::BUILTIN_ONLY, [DshService::Plugins]);
|
||||
assert!(
|
||||
DshService::ALL
|
||||
.iter()
|
||||
.all(|service| !service.builtin_only())
|
||||
);
|
||||
for service in DshService::EVERY {
|
||||
assert_eq!(DshService::parse(service.name()), Some(service));
|
||||
}
|
||||
assert_eq!(DshService::parse("Workspace"), None);
|
||||
|
||||
@@ -51,6 +51,8 @@ const RESERVED_NAMES: &[&str] = &[
|
||||
"js_execution",
|
||||
"request_user_input",
|
||||
"multi_tool_use.parallel",
|
||||
"dsh_broker_act",
|
||||
"dsh_broker_reach",
|
||||
];
|
||||
|
||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||
|
||||
@@ -226,6 +226,23 @@ fn map_call_error(tool: &str, error: HostCallError) -> ToolError {
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) fn failed_with_acts(
|
||||
error: ToolError,
|
||||
receipts: Option<&Value>,
|
||||
) -> Result<ToolResultWire, ToolError> {
|
||||
let holds_acts = receipts.is_some_and(|receipts| receipts.get("broker_acts").is_some());
|
||||
if !holds_acts {
|
||||
return Err(error);
|
||||
}
|
||||
Ok(ToolResultWire {
|
||||
content: vec![ContentBlockWire::Text {
|
||||
text: error.to_string(),
|
||||
}],
|
||||
is_error: true,
|
||||
structured: None,
|
||||
})
|
||||
}
|
||||
|
||||
pub fn wire_to_result(wire: ToolResultWire, origin: &str) -> ToolResult {
|
||||
let content = wire
|
||||
.content
|
||||
@@ -396,26 +413,44 @@ impl ToolSpec for HostToolSpec {
|
||||
});
|
||||
// The deadline stops while one of this call's `core/call`s waits on
|
||||
// the gate (an approval card), so a person's time is not the tool's.
|
||||
let value = host
|
||||
let outcome = host
|
||||
.call_with_clock(
|
||||
request,
|
||||
Some(registration.owner.plugin_id.clone()),
|
||||
invocation.as_ref().map(InvocationGuard::clock),
|
||||
)
|
||||
.await
|
||||
.map_err(|error| map_call_error(®istration.name, error))?;
|
||||
self.check_caller(context)?;
|
||||
self.manager
|
||||
.live_host_for(registration)
|
||||
.await
|
||||
.map_err(ToolError::not_available)?;
|
||||
self.check_caller(context)?;
|
||||
let wire: ToolResultWire = serde_json::from_value(value).map_err(|error| {
|
||||
ToolError::execution_failed(format!(
|
||||
"extension tool `{}` returned a malformed result: {error}",
|
||||
registration.name
|
||||
))
|
||||
})?;
|
||||
.await;
|
||||
let receipts = invocation.as_ref().and_then(InvocationGuard::seal_receipts);
|
||||
let settled: Result<ToolResultWire, ToolError> = async {
|
||||
match outcome {
|
||||
Ok(value) => {
|
||||
self.check_caller(context)?;
|
||||
self.manager
|
||||
.live_host_for(registration)
|
||||
.await
|
||||
.map_err(ToolError::not_available)?;
|
||||
self.check_caller(context)?;
|
||||
serde_json::from_value(value).map_err(|error| {
|
||||
ToolError::execution_failed(format!(
|
||||
"extension tool `{}` returned a malformed result: {error}",
|
||||
registration.name
|
||||
))
|
||||
})
|
||||
}
|
||||
Err(error) => Err(map_call_error(®istration.name, error)),
|
||||
}
|
||||
}
|
||||
.await;
|
||||
let wire = match settled {
|
||||
Ok(wire) => wire,
|
||||
Err(error) => {
|
||||
let wire = failed_with_acts(error, receipts.as_ref())?;
|
||||
match self.check_caller(context) {
|
||||
Ok(()) => wire,
|
||||
Err(stale) => failed_with_acts(stale, receipts.as_ref())?,
|
||||
}
|
||||
}
|
||||
};
|
||||
let mut result = wire_to_result(wire, &self.origin());
|
||||
if let Some(Value::Object(metadata)) = result.metadata.as_mut() {
|
||||
metadata.insert(
|
||||
@@ -433,10 +468,9 @@ impl ToolSpec for HostToolSpec {
|
||||
);
|
||||
}
|
||||
// What the tool asked the core to run, so the persisted record shows it.
|
||||
if let (Some(receipts), Some(Value::Object(metadata))) = (
|
||||
invocation.as_ref().and_then(InvocationGuard::receipts),
|
||||
result.metadata.as_mut(),
|
||||
) {
|
||||
if let (Some(receipts), Some(Value::Object(metadata))) =
|
||||
(receipts, result.metadata.as_mut())
|
||||
{
|
||||
metadata.insert("core_calls".to_string(), receipts);
|
||||
}
|
||||
Ok(result)
|
||||
|
||||
@@ -18,8 +18,6 @@
|
||||
//! never render a child session, which is what keeps the orchestrator light at
|
||||
//! high fanout.
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
use anyhow::Result;
|
||||
use codewhale_config::FleetExecConfig;
|
||||
use codewhale_protocol::fleet::{
|
||||
@@ -529,7 +527,7 @@ fn parse_exec_terminal_route(value: &serde_json::Value) -> ParsedTerminalRoute {
|
||||
route.map_or(ParsedTerminalRoute::Invalid, ParsedTerminalRoute::Valid)
|
||||
}
|
||||
|
||||
#[cfg(any(test, feature = "test-support"))]
|
||||
#[cfg(test)]
|
||||
fn map_exec_terminal_route(line: &str) -> Option<FleetWorkerReportedRoute> {
|
||||
let value: serde_json::Value = serde_json::from_str(line).ok()?;
|
||||
match parse_exec_terminal_route(&value) {
|
||||
|
||||
@@ -4,8 +4,6 @@
|
||||
//! observe work through this trait without knowing whether the worker is a
|
||||
//! local child process or an SSH-backed remote command.
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
use std::collections::{BTreeMap, BTreeSet};
|
||||
use std::fs::File;
|
||||
use std::io::{Read, Seek, SeekFrom};
|
||||
@@ -218,7 +216,7 @@ struct LocalWorkerProcess {
|
||||
#[cfg(unix)]
|
||||
session_id: libc::pid_t,
|
||||
#[cfg(unix)]
|
||||
parent_death_writer: Option<std::io::PipeWriter>,
|
||||
_parent_death_writer: Option<std::io::PipeWriter>,
|
||||
#[cfg(windows)]
|
||||
windows_job: FleetWindowsJob,
|
||||
host_kind: FleetHostKind,
|
||||
@@ -387,7 +385,7 @@ impl LocalProcessFleetHostAdapter {
|
||||
#[cfg(unix)]
|
||||
session_id: pid as libc::pid_t,
|
||||
#[cfg(unix)]
|
||||
parent_death_writer,
|
||||
_parent_death_writer: parent_death_writer,
|
||||
#[cfg(windows)]
|
||||
windows_job,
|
||||
host_kind,
|
||||
@@ -1520,7 +1518,7 @@ fn signal_unix_session(
|
||||
Ok(errors)
|
||||
}
|
||||
|
||||
#[cfg(unix)]
|
||||
#[cfg(all(unix, test))]
|
||||
fn unix_pid_is_running(pid: libc::pid_t) -> bool {
|
||||
if !unix_pid_exists(pid) {
|
||||
return false;
|
||||
|
||||
@@ -5,8 +5,6 @@
|
||||
//! Artifacts are referenced by bounded metadata; large payloads live on disk
|
||||
//! and are never embedded in the ledger.
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
use std::collections::BTreeMap;
|
||||
use std::collections::HashMap;
|
||||
#[cfg(test)]
|
||||
|
||||
@@ -4,8 +4,6 @@
|
||||
//! foreground and coordinate logical local workers while later host adapters
|
||||
//! add real process and SSH execution behind the same records.
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
use std::collections::{BTreeMap, BTreeSet};
|
||||
use std::path::{Path, PathBuf};
|
||||
use std::time::Duration;
|
||||
@@ -2360,6 +2358,7 @@ impl FleetManager {
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn append_worker_event(
|
||||
&self,
|
||||
run_id: &FleetRunId,
|
||||
|
||||
@@ -1,7 +1,5 @@
|
||||
//! Fleet profile vocabulary, local profile discovery, and config-facing aliases.
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
use std::collections::BTreeSet;
|
||||
use std::path::{Path, PathBuf};
|
||||
|
||||
@@ -10,7 +8,6 @@ use serde::{Deserialize, Serialize};
|
||||
|
||||
use crate::reasoning_preference::ReasoningEffort;
|
||||
|
||||
#[allow(unused_imports)]
|
||||
pub use codewhale_config::{
|
||||
FleetDelegationHints, FleetLoadout, FleetProfile, FleetProfilePermissions, FleetRole, FleetSlot,
|
||||
};
|
||||
|
||||
@@ -1,14 +1,16 @@
|
||||
//! Fleet scheduler policy: leases, heartbeats, backpressure, and recovery.
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
#[cfg(test)]
|
||||
use std::collections::{BTreeMap, BTreeSet};
|
||||
use std::path::Path;
|
||||
use std::time::Duration;
|
||||
|
||||
use anyhow::{Context, Result, anyhow};
|
||||
#[cfg(test)]
|
||||
use anyhow::anyhow;
|
||||
use anyhow::{Context, Result};
|
||||
use chrono::{DateTime, SecondsFormat, Utc};
|
||||
use codewhale_protocol::fleet::*;
|
||||
#[cfg(test)]
|
||||
use serde_json::Value;
|
||||
|
||||
use super::ledger::{FleetLedger, FleetLedgerState, FleetTaskLedgerStatus, FleetTaskState};
|
||||
@@ -65,7 +67,7 @@ impl FleetScheduler {
|
||||
self.now = now;
|
||||
}
|
||||
|
||||
#[cfg(any(test, feature = "test-support"))]
|
||||
#[cfg(test)]
|
||||
pub fn tick_run(&self, run_id: &FleetRunId) -> Result<FleetSchedulerReport> {
|
||||
let mut report = FleetSchedulerReport::default();
|
||||
self.recover_unhealthy_work(run_id, &mut report, &mut |_, _, _, _| Ok(()))?;
|
||||
@@ -83,7 +85,7 @@ impl FleetScheduler {
|
||||
/// and idempotent to call on a fresh process: a task re-leased by an
|
||||
/// earlier resume is no longer stale at the same instant, and a terminally
|
||||
/// failed task is never failed or escalated twice.
|
||||
#[cfg(any(test, feature = "test-support"))]
|
||||
#[cfg(test)]
|
||||
pub fn resume_run(&self, run_id: &FleetRunId) -> Result<FleetSchedulerReport> {
|
||||
self.resume_run_with_restart_callback(run_id, |_, _, _, _| Ok(()))
|
||||
}
|
||||
@@ -134,6 +136,7 @@ impl FleetScheduler {
|
||||
Ok(report)
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn recover_unhealthy_work(
|
||||
&self,
|
||||
run_id: &FleetRunId,
|
||||
@@ -394,6 +397,7 @@ impl FleetScheduler {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn launch_queued_work(
|
||||
&self,
|
||||
run_id: &FleetRunId,
|
||||
@@ -450,6 +454,7 @@ impl FleetScheduler {
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn next_launch(
|
||||
&self,
|
||||
run: &FleetRun,
|
||||
@@ -594,6 +599,7 @@ impl FleetScheduler {
|
||||
.update_run_status(run_id, status, &self.timestamp())
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn append_worker_event(
|
||||
&self,
|
||||
run_id: &FleetRunId,
|
||||
@@ -615,12 +621,14 @@ impl FleetScheduler {
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
#[derive(Debug, Default)]
|
||||
struct ActiveCounts {
|
||||
by_host: BTreeMap<String, usize>,
|
||||
by_task_class: BTreeMap<String, usize>,
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn active_counts(state: &FleetLedgerState, run: &FleetRun) -> ActiveCounts {
|
||||
let mut counts = ActiveCounts::default();
|
||||
for task in active_tasks_for_run(state, &run.id) {
|
||||
@@ -646,6 +654,7 @@ fn active_counts(state: &FleetLedgerState, run: &FleetRun) -> ActiveCounts {
|
||||
counts
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn active_tasks_for_run(state: &FleetLedgerState, run_id: &FleetRunId) -> Vec<FleetTaskState> {
|
||||
state
|
||||
.tasks
|
||||
@@ -667,6 +676,7 @@ fn task_spec_for(state: &FleetLedgerState, task: &FleetTaskState) -> Option<Flee
|
||||
.cloned()
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn host_key(worker: &FleetWorkerSpec) -> String {
|
||||
match &worker.host {
|
||||
FleetHostSpec::Local => "local".to_string(),
|
||||
@@ -676,6 +686,7 @@ fn host_key(worker: &FleetWorkerSpec) -> String {
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
fn task_class(task: &FleetTaskSpec) -> String {
|
||||
task.metadata
|
||||
.get("class")
|
||||
|
||||
@@ -11,8 +11,6 @@
|
||||
//! - Mailbox events stream into the Fleet ledger as `FleetWorkerEventPayload`
|
||||
//! - `FleetWorkerInspection` reads both ledger state and sub-agent worker records
|
||||
|
||||
#![allow(dead_code)]
|
||||
|
||||
use std::borrow::Cow;
|
||||
use std::path::PathBuf;
|
||||
|
||||
|
||||
@@ -25,6 +25,7 @@
|
||||
pub mod rate_limit;
|
||||
|
||||
use anyhow::Result;
|
||||
use codewhale_command_contract::metrics::format_duration;
|
||||
use codewhale_models::{MessageRequest, MessageResponse, StreamEvent};
|
||||
use codewhale_runtime::config::{RateLimitRetryPolicy, RetryPolicy};
|
||||
use serde_json::Value;
|
||||
@@ -457,6 +458,18 @@ pub enum LlmError {
|
||||
Other(String),
|
||||
}
|
||||
|
||||
fn opencode_go_hint(message: &str) -> &'static str {
|
||||
let lowered = message.to_lowercase();
|
||||
if lowered.contains("codewhale auth set") {
|
||||
return "";
|
||||
}
|
||||
if lowered.contains("opencode go") || lowered.contains("opencode.ai/go") {
|
||||
" OpenCode Go is a separate provider with its own key; run: codewhale auth set --provider opencode-go"
|
||||
} else {
|
||||
""
|
||||
}
|
||||
}
|
||||
|
||||
impl std::fmt::Display for LlmError {
|
||||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
||||
match self {
|
||||
@@ -464,11 +477,25 @@ impl std::fmt::Display for LlmError {
|
||||
message,
|
||||
retry_after,
|
||||
..
|
||||
} => write!(
|
||||
} => {
|
||||
let hint = opencode_go_hint(message);
|
||||
match retry_after {
|
||||
Some(d) => write!(
|
||||
f,
|
||||
"Rate limit exceeded: {message}; quota window resets in {}; automatic retry stopped{hint}",
|
||||
format_duration(*d)
|
||||
),
|
||||
None => write!(
|
||||
f,
|
||||
"Rate limit exceeded: {message}; automatic retry stopped{hint}"
|
||||
),
|
||||
}
|
||||
}
|
||||
LlmError::RateLimited { message, .. } => write!(
|
||||
f,
|
||||
"Rate limit exceeded: {message}; quota window reset in {retry_after:?}; automatic retry stopped"
|
||||
"Rate limit exceeded: {message}{}",
|
||||
opencode_go_hint(message)
|
||||
),
|
||||
LlmError::RateLimited { message, .. } => write!(f, "Rate limit exceeded: {message}"),
|
||||
LlmError::QuotaExhausted(error) => {
|
||||
write!(f, "Provider plan quota exhausted: {}", error.message)
|
||||
}
|
||||
|
||||
@@ -119,6 +119,76 @@ fn retryability_distinguishes_transient_failures_from_durable_failures() {
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn quota_window_display_prints_reset_time_as_plain_text() {
|
||||
let windowed = LlmError::QuotaWindow {
|
||||
message: "Free usage limit reached".into(),
|
||||
retry_after: Some(Duration::from_secs(70168)),
|
||||
transmission: RequestTransmission::Rejected,
|
||||
}
|
||||
.to_string();
|
||||
assert!(windowed.contains("resets in 19h29m"), "{windowed}");
|
||||
assert!(windowed.contains("automatic retry stopped"), "{windowed}");
|
||||
|
||||
let open_ended = LlmError::QuotaWindow {
|
||||
message: "Free usage limit reached".into(),
|
||||
retry_after: None,
|
||||
transmission: RequestTransmission::Rejected,
|
||||
}
|
||||
.to_string();
|
||||
assert!(!open_ended.contains("reset"), "{open_ended}");
|
||||
assert!(
|
||||
open_ended.contains("automatic retry stopped"),
|
||||
"{open_ended}"
|
||||
);
|
||||
|
||||
for text in [&windowed, &open_ended] {
|
||||
assert!(!text.contains("Some("), "{text}");
|
||||
assert!(!text.contains("None"), "{text}");
|
||||
}
|
||||
|
||||
let hinted = LlmError::QuotaWindow {
|
||||
message: "OpenCode Go free usage limit reached".into(),
|
||||
retry_after: Some(Duration::from_secs(70168)),
|
||||
transmission: RequestTransmission::Rejected,
|
||||
}
|
||||
.to_string();
|
||||
assert_eq!(
|
||||
hinted
|
||||
.matches("codewhale auth set --provider opencode-go")
|
||||
.count(),
|
||||
1,
|
||||
"{hinted}"
|
||||
);
|
||||
|
||||
let rate_limited = LlmError::RateLimited {
|
||||
message: "OpenCode Go free usage limit reached".into(),
|
||||
retry_after: None,
|
||||
}
|
||||
.to_string();
|
||||
assert_eq!(
|
||||
rate_limited
|
||||
.matches("codewhale auth set --provider opencode-go")
|
||||
.count(),
|
||||
1,
|
||||
"{rate_limited}"
|
||||
);
|
||||
|
||||
let already_hinted = LlmError::QuotaWindow {
|
||||
message: hinted.clone(),
|
||||
retry_after: Some(Duration::from_secs(70168)),
|
||||
transmission: RequestTransmission::Rejected,
|
||||
}
|
||||
.to_string();
|
||||
assert_eq!(
|
||||
already_hinted
|
||||
.matches("codewhale auth set --provider opencode-go")
|
||||
.count(),
|
||||
1,
|
||||
"{already_hinted}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn http_response_boundary_classifies_status_contract() {
|
||||
for status in [408, 409, 499, 500, 502, 503, 504] {
|
||||
|
||||
Loaded 100 of 413 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user