diasurgical/DevilutionX
1
0
Fork 0
mirror of https://github.com/diasurgical/DevilutionX.git synced 2026-10-12 02:13:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
9f2ea6b993e9683fabd8df443e95958ea55f3626
DevilutionX/Source
T
History
Gleb MazovetskiyandClaude Opus 5 9f2ea6b993 Depend on libdevilutionx_sdl2_to_1_2_backports explicitly 
DevilutionX::SDL carried libdevilutionx_sdl2_to_1_2_backports, so
linking SDL pulled in our own compatibility shims, and with them
libdevilutionx_strings and libdevilutionx_utils_console. Anything that
only wanted the SDL headers got a chunk of devilutionX behind them.

Drop it from DevilutionX::SDL and let the targets that actually use the
shims say so. That is every target whose objects reference a symbol
defined by sdl2_to_1_2_backports.cpp, found by matching the undefined
symbols in each object library against the ones it defines. Object
libraries do not link, so a missing dependency here is invisible at
build time: the archive reached the executable through whichever target
happened to name it.

The dependency is PUBLIC where one of the target's own headers reaches
utils/sdl2_to_1_2_backports.h and PRIVATE where only its .cpp files do.
libdevilutionx_paths already declared it and is moved to PRIVATE on the
same rule: only utils/paths.cpp includes the header, utils/paths.h does
not.

Co-Authored-By: Claude Opus 5 <[email protected]>
2026-08-24 02:28:56 +01:00
..
control
Untangle more dependencies
2026-08-23 06:08:15 +01:00
controls
Untangle more dependencies
2026-08-23 06:08:15 +01:00
data
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
DiabloUI
Untangle more dependencies
2026-08-23 06:08:15 +01:00
discord
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
dvlnet
Untangle more dependencies
2026-08-23 06:08:15 +01:00
engine
Untangle more dependencies
2026-08-23 06:08:15 +01:00
items
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
levels
Untangle more dependencies
2026-08-23 06:08:15 +01:00
lua
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
mods
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
monsters
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
mpq
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
panels
Untangle more dependencies
2026-08-23 06:08:15 +01:00
platform
[3DS] Update text input state using data from the on-screen keyboard
2026-08-09 18:13:12 +09:00
players
Do not process packet headers or buffered messages from invalid players
2026-04-10 22:15:14 +02:00
portals
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
qol
Untangle more dependencies
2026-08-23 06:08:15 +01:00
quests
Move *dat files to tables dir
2026-01-05 20:14:23 +01:00
storm
Migrate DOS to SDL3 (fixing AUDIO and stuff)
2026-07-15 21:56:02 +02:00
tables
Untangle more dependencies
2026-08-23 06:08:15 +01:00
utils
Fix SDLC_PushEvent() return value for SDL1
2026-08-15 15:13:02 -05:00
.clang-format
Apply simple const rules using clang-tidy
2025-08-16 01:21:36 +02:00
.clang-tidy
clang-tidy: auto fix headers for DiabloUI
2025-08-16 06:20:40 +02:00
appfat.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
appfat.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
automap.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
automap.h
Extract Is{Any,None}Of out of engine.hpp
2025-01-08 09:54:56 +09:00
capture.cpp
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
capture.h
Lowercase all file paths
2022-08-20 23:49:23 +01:00
CMakeLists.txt
Depend on libdevilutionx_sdl2_to_1_2_backports explicitly
2026-08-24 02:28:56 +01:00
codec.cpp
SDL3: Some more migration
2025-10-09 01:28:37 +01:00
codec.h
Remove utils/stdcompat/cstddef.hpp
2023-08-14 01:54:29 +01:00
cpp.hint
Add hint to avoid bugprone-use-after-move warnings
2022-04-19 09:54:19 +01:00
crawl.cpp
Optimize DoCrawl
2024-08-07 23:40:28 +01:00
crawl.hpp
Extract Crawl to a library
2024-08-07 02:01:23 +01:00
cursor_defs.hpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
cursor.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
cursor.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
dead.cpp
Move *dat files to tables dir
2026-01-05 20:14:23 +01:00
dead.h
Split up engine.{h,cpp}
2025-01-09 08:51:55 +00:00
debug.cpp
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
debug.h
Add missiles to tile data debug command
2025-02-03 08:10:14 +01:00
diablo_msg.cpp
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
diablo_msg.hpp
Split up engine.{h,cpp}
2025-01-09 08:51:55 +00:00
diablo.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
diablo.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
doom.cpp
Split control.cpp (#8347)
2025-12-13 08:32:02 +00:00
doom.h
Split up engine.{h,cpp}
2025-01-09 08:51:55 +00:00
effects_stubs.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
effects.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
effects.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
encrypt.cpp
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
encrypt.h
Validate length of incoming deltas
2025-05-10 20:01:53 -04:00
game_mode.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
game_mode.hpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
gamemenu.cpp
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
gamemenu.h
Add tests for most of the UI (#8530)
2026-03-29 18:57:20 -04:00
gmenu.cpp
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
gmenu.h
Add tests for most of the UI (#8530)
2026-03-29 18:57:20 -04:00
headless_mode.cpp
Extract HeadlessMode from diablo.h
2025-01-09 12:21:26 +00:00
headless_mode.hpp
Extract HeadlessMode from diablo.h
2025-01-09 12:21:26 +00:00
help.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
help.h
Split up engine.{h,cpp}
2025-01-09 08:51:55 +00:00
hwcursor.cpp
SDL3: Fix nearest-neighbor scaling
2025-10-25 16:17:51 +02:00
hwcursor.hpp
Fix condition for logging errors in SetHardwareCursorVisible()
2025-11-16 22:44:55 +01:00
init.cpp
Migrate from libmpq to mpqfs (#8482)
2026-03-30 00:14:11 +02:00
init.hpp
SDL3: Even more migration
2025-10-09 01:28:37 +01:00
interfac.cpp
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
interfac.h
SDL3: Make text_render_integration_test build
2025-10-05 20:17:47 +01:00
inv_iterators.hpp
Support const inventory iterators
2023-08-16 06:01:03 +09:00
inv.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
inv.h
Add tests for most of the UI (#8530)
2026-03-29 18:57:20 -04:00
items.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
items.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
lighting.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
lighting.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
loadsave.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
loadsave.h
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
main.cpp
Add multiplayer event logging
2025-11-25 04:07:49 +01:00
menu.cpp
Block MP when overwrites are present
2026-07-08 13:45:41 -04:00
menu.h
Add missing <cstdint> includes
2023-05-10 13:50:12 +01:00
minitext.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
minitext.h
Add panel and store transaction tests with UI test fixture (#8528)
2026-03-29 21:21:04 +02:00
missiles.cpp
Fix compiler warning in ProcessWeaponExplosion()
2026-07-11 17:55:38 +02:00
missiles.h
Move *dat files to tables dir
2026-01-05 20:14:23 +01:00
monster.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
monster.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
movie.cpp
Skip video playback in HeadlessMode
2026-07-16 05:13:29 +01:00
movie.h
Move documentation from implementations to declarations. (#2858)
2021-09-13 15:45:38 +02:00
msg.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
msg.h
[Bugfix] Update players directions on joining (#8462)
2026-03-09 21:01:52 -04:00
multi.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
multi.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
nthread.cpp
SDL3: Even more migration
2025-10-09 01:28:37 +01:00
nthread.h
Add missing <cstdint> includes
2023-05-10 13:50:12 +01:00
objects.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
objects.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
options.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
options.h
Unify store UI options
2026-07-16 07:56:04 +01:00
pack.cpp
Fix OOB read from unterminated player names in save/network data
2026-07-27 14:34:57 -04:00
pack.h
[Bugfix] Update players directions on joining (#8462)
2026-03-09 21:01:52 -04:00
parse_sfx_id.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
parse_sfx_id.hpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
pfile.cpp
Fix OOB read from unterminated player names in save/network data
2026-07-27 14:34:57 -04:00
pfile.h
Replace tl::expected with std::expected
2026-07-22 00:00:04 +02:00
player.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
player.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
plrmsg.cpp
Replace libfmt with std::format
2026-07-22 00:00:04 +02:00
plrmsg.h
SDL3: Even more migration
2025-10-09 01:28:37 +01:00
portal.cpp
Move *dat files to tables dir
2026-01-05 20:14:23 +01:00
portal.h
Msg: Change OnXYZ to get a Player reference instead of a player index
2023-11-12 22:17:59 +01:00
quests.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
quests.h
Untangle more dependencies
2026-08-23 06:08:15 +01:00
quick_messages.cpp
Move QuickMessages to its own library
2025-01-11 13:51:56 +00:00
quick_messages.hpp
Move QuickMessages to its own library
2025-01-11 13:51:56 +00:00
restrict.cpp
SDL3: Add some backports / compat helpers
2025-10-10 00:49:44 +01:00
restrict.h
Move doc from restrict.cpp to header
2021-09-12 02:53:50 +02:00
sha.cpp
Apply simple const rules using clang-tidy
2025-08-16 01:21:36 +02:00
sha.h
Remove utils/stdcompat/cstddef.hpp
2023-08-14 01:54:29 +01:00
sound_effect_enums.h
First step to migrate accessibility features
2026-02-10 10:56:22 +01:00
spells.cpp
Split control.cpp (#8347)
2025-12-13 08:32:02 +00:00
spells.h
Fix Resurrect Illegal Player State/Crash (#8349)
2025-12-11 20:12:40 -05:00
stores.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
stores.h
Add Lua towner API and dynamic dialog options (prework for multi-town PR) (#8539)
2026-04-11 00:47:07 +00:00
sync.cpp
SDL3: Use endianness swap helpers throughout
2025-10-09 01:28:37 +01:00
sync.h
Fix includes in sync.h
2025-05-11 04:47:25 +01:00
tmsg.cpp
chore: clang-tidy cleanup part 1
2026-04-03 22:57:48 +02:00
tmsg.h
Remove utils/stdcompat/cstddef.hpp
2023-08-14 01:54:29 +01:00
towners.cpp
Untangle more dependencies
2026-08-23 06:08:15 +01:00
towners.h
Add Lua towner API and dynamic dialog options (prework for multi-town PR) (#8539)
2026-04-11 00:47:07 +00:00
track.cpp
Add Monster hasNoLife helper (#8304)
2025-12-03 18:48:20 -05:00
track.h
Fix Automap movement being hardcoded to right stick on gamepad (#7921)
2025-08-14 23:19:08 +02:00
translation_dummy.cpp
Update all the files that do not have CRLF as line break
2025-12-23 13:08:46 +00:00
vision.cpp
Extract the vision algorithm to a separate library
2025-04-24 08:29:52 +01:00
vision.hpp
Extract the vision algorithm to a separate library
2025-04-24 08:29:52 +01:00