Nicolas De Loof
55a8a88265
Two review findings on the same root cause: - docker-agent: a failing OpRunPreStart emitted a bare Error with no preceding Working/Starting event, since triggersWorking only fires on OpStartContainer. onNodeError now emits the group's Working event first when it hasn't fired yet, keeping the progression well-formed. - glours (following up on the docker-agent thread): worse than a missing event -- OpStartContainer's own goroutine was unblocked by <-done[dep.ID] and ran anyway, since close(done[node.ID]) races ahead of errgroup's cancel() (same TOCTOU class as the ctx.Err() guards already tracked under #14081, but deterministic here with the default unset --parallel limiter: no semaphore wait gives cancel() time to land first). It fired a second, spurious Starting right after the sibling's Error, with no further event ever closing it. Reproduced 143/143 iterations against this PR's own regression test. run() now records each node's terminal error in a shared, mutex-guarded map as it closes done[node.ID], and a dependent checks that map right after its dependency wait, treating a genuine dependency failure exactly like a context cancellation: no slot acquired, no event emitted, its own failure recorded and propagated to its own dependents the same way. This closes the event-ordering race outright for this specific chain, rather than narrowing it like the existing ctx.Err() guards -- those stay in place and still guard actual engine calls, unrelated to event emission. TestExecutePlanFailedPreStartGatesStart now asserts the full event sequence (Creating, Created, Starting, Error — nothing after), verified by reverting the executor.go fix locally and confirming the test catches the reintroduced spurious Starting. Signed-off-by: Nicolas De Loof <[email protected]>
Table of Contents
Docker Compose
Docker Compose is a tool for running multi-container applications on Docker
defined using the Compose file format.
A Compose file is used to define how one or more containers that make up
your application are configured.
Once you have a Compose file, you can create and start your application with a
single command: docker compose up.
Note
: About Docker Swarm Docker Swarm used to rely on the legacy compose file format but did not adopt the compose specification so is missing some of the recent enhancements in the compose syntax. After acquisition by Mirantis swarm isn't maintained by Docker Inc, and as such some Docker Compose features aren't accessible to swarm users.
Where to get Docker Compose
Windows and macOS
Docker Compose is included in Docker Desktop for Windows and macOS.
Linux
You can download Docker Compose binaries from the release page on this repository.
Rename the relevant binary for your OS to docker-compose and copy it to $HOME/.docker/cli-plugins
Or copy it into one of these folders to install it system-wide:
/usr/local/lib/docker/cli-pluginsOR/usr/local/libexec/docker/cli-plugins/usr/lib/docker/cli-pluginsOR/usr/libexec/docker/cli-plugins
(might require making the downloaded file executable with chmod +x)
Quick Start
Using Docker Compose is a three-step process:
- Define your app's environment with a
Dockerfileso it can be reproduced anywhere. - Define the services that make up your app in
compose.yamlso they can be run together in an isolated environment. - Lastly, run
docker compose upand Compose will start and run your entire app.
A Compose file looks like this:
services:
web:
build: .
ports:
- "5000:5000"
volumes:
- .:/code
redis:
image: redis
Contributing
Want to help develop Docker Compose? Check out our contributing documentation.
If you find an issue, please report it on the issue tracker.
Legacy
The Python version of Compose is available under the v1 branch.