Add intensity EFB copy test

gxtest/CMakeLists.txt

@@ -1,5 +1,6 @@
 add_hwtest(MODULE gxtest TEST bitfield FILES bitfield.cpp cgx.cpp util.cpp)
 add_hwtest(MODULE gxtest TEST clipping FILES clipping.cpp cgx.cpp util.cpp)
+add_hwtest(MODULE gxtest TEST intensity FILES intensity.cpp cgx.cpp util.cpp)
 add_hwtest(MODULE gxtest TEST lighting FILES lighting.cpp cgx.cpp util.cpp)
 add_hwtest(MODULE gxtest TEST rasterization FILES rasterization.cpp cgx.cpp util.cpp)
 add_hwtest(MODULE gxtest TEST tev FILES tev.cpp cgx.cpp util.cpp)

gxtest/intensity.cpp

@@ -0,0 +1,112 @@
+// Copyright 2022 Dolphin Emulator Project
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#include <algorithm>
+#include <array>
+#include <cmath>
+
+#include <ogcsys.h>
+#include <wiiuse/wpad.h>
+#include "common/hwtests.h"
+#include "gxtest/cgx.h"
+#include "gxtest/cgx_defaults.h"
+#include "gxtest/util.h"
+
+static void FillEFB(u8 blue)
+{
+  PEControl ctrl;
+  ctrl.hex = BPMEM_ZCOMPARE << 24;
+  ctrl.pixel_format = PixelFormat::RGB8_Z24;
+  ctrl.zformat = DepthFormat::ZLINEAR;
+  ctrl.early_ztest = false;
+  CGX_LOAD_BP_REG(ctrl.hex);
+  CGX_WaitForGpuToFinish();
+
+  CGX_PEPokeDither(false);
+  CGX_PEPokeAlphaUpdate(true);
+  CGX_PEPokeColorUpdate(true);
+  CGX_PEPokeBlendMode(GX_BM_NONE, SrcBlendFactor::Zero, DstBlendFactor::Zero, LogicOp::Set);
+  CGX_PEPokeAlphaRead(GX_READ_NONE);
+  CGX_PEPokeZMode(false, CompareMode::Always, true);
+
+  for (u16 x = 0; x < 256; x++)
+  {
+    for (u16 y = 0; y < 256; y++)
+    {
+      GXTest::Vec4<u8> color;
+      color.r = static_cast<u8>(x);
+      color.g = static_cast<u8>(y);
+      color.b = blue;
+      color.a = 255;
+      CGX_PokeARGB(x, y, color, PixelFormat::RGB8_Z24);
+    }
+  }
+}
+
+GXTest::Vec4<u8> GetIntensityColor(u8 r, u8 g, u8 b, u8 a)
+{
+  // BT.601 conversion
+  const u16 y = +66 * r + 129 * g + +25 * b;
+  const s16 u = -38 * r + -74 * g + 112 * b;
+  const s16 v = 112 * r + -94 * g + -18 * b;
+  const u8 y_round = static_cast<u8>((y >> 8) + ((y >> 7) & 1) + 16);
+  const u8 u_round = static_cast<u8>((u >> 8) + ((u >> 7) & 1) + 128);
+  const u8 v_round = static_cast<u8>((v >> 8) + ((v >> 7) & 1) + 128);
+  return { y_round, u_round, v_round, a };
+}
+
+void IntensityTest(u8 blue, bool unknown_yuv, bool intensity_fmt, bool auto_conv)
+{
+  START_TEST();
+
+  GXTest::CopyToTestBuffer(0, 0, 255, 255, {.unknown_bit = unknown_yuv, .intensity_fmt = intensity_fmt, .auto_conv = auto_conv});
+  CGX_WaitForGpuToFinish();
+
+  for (u32 x = 0; x < 256; x++)
+  {
+    for (u32 y = 0; y < 256; y++)
+    {
+      GXTest::Vec4<u8> actual = GXTest::ReadTestBuffer(x, y, 256);
+      bool actually_is_intensity = intensity_fmt && auto_conv;
+      GXTest::Vec4<u8> expected = actually_is_intensity ? GetIntensityColor(x, y, blue, 255) : GXTest::Vec4<u8>{static_cast<u8>(x), static_cast<u8>(y), blue, 255};
+      DO_TEST(actual.r == expected.r, "Got wrong red   / y value for x {} y {} blue {}, {} {} {}: expected {}, was {}", x, y, blue, unknown_yuv, intensity_fmt, auto_conv, expected.r, actual.r);
+      DO_TEST(actual.g == expected.g, "Got wrong green / u value for x {} y {} blue {}, {} {} {}: expected {}, was {}", x, y, blue, unknown_yuv, intensity_fmt, auto_conv, expected.g, actual.g);
+      DO_TEST(actual.b == expected.b, "Got wrong blue  / v value for x {} y {} blue {}, {} {} {}: expected {}, was {}", x, y, blue, unknown_yuv, intensity_fmt, auto_conv, expected.b, actual.b);
+      DO_TEST(actual.a == expected.a, "Got wrong alpha     value for x {} y {} blue {}, {} {} {}: expected {}, was {}", x, y, blue, unknown_yuv, intensity_fmt, auto_conv, expected.a, actual.a);
+    }
+  }
+
+  END_TEST();
+}
+
+int main()
+{
+  network_init();
+  WPAD_Init();
+
+  GXTest::Init();
+
+  for (u32 blue = 0; blue < 256; blue++)
+  {
+    FillEFB(blue);
+    for (u32 counter = 0; counter < 8; counter++)
+    {
+      // The bit corresponding to unknown_yuv was renamed to "yuv" in Dolphin commit
+      // 522746b2c223f37c45569ee7fd4a226b278cb6d9.  It's not clear why, and seems to do nothing.
+      const bool unknown_yuv = (counter & 1);
+      const bool intensity_fmt = (counter & 2);
+      const bool auto_conv = (counter & 4);
+      IntensityTest(blue, unknown_yuv, intensity_fmt, auto_conv);
+
+      WPAD_ScanPads();
+      if (WPAD_ButtonsDown(0) & WPAD_BUTTON_HOME)
+        break;
+    }
+  }
+
+  report_test_results();
+  network_printf("Shutting down...\n");
+  network_shutdown();
+
+  return 0;
+}