dolphin-emu/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-10-11 22:49:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14911 from acts-1631/netplay-save-banner-validation

Browse Source 
NetPlay: reject oversized Wii save banners
This commit is contained in:
JosJuice
2026-10-07 19:48:18 +02:00
committed by GitHub
parent 9b4d5a5449 c987640440
commit 584bee07d7
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Core/NetPlayClient.cpp
+7 -1
View File
@@ -1209,12 +1209,18 @@ void NetPlayClient::OnSyncSaveDataWii(sf::Packet& packet)
WiiSave::Header header;
packet >> header.tid;
packet >> header.banner_size;
if (!packet || header.banner_size > sizeof(header.banner))
{
WARN_LOG_FMT(NETPLAY, "Received invalid Wii save banner size.");
SyncSaveDataResponse(false);
return;
}
packet >> header.permissions;
packet >> header.unk1;
for (u8& byte : header.md5)
packet >> byte;
packet >> header.unk2;
for (size_t i = 0; i < std::min<size_t>(header.banner_size, sizeof(header.banner)); i++)
for (size_t i = 0; i < header.banner_size; i++)
packet >> header.banner[i];
// BkHeader