pull request template

.github/pull_request_template.md

@@ -0,0 +1,17 @@
+* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)
+
+
+
+* **What is the current behavior?** (You can also link to an open issue here)
+
+
+
+* **What is the new behavior (if this is a feature change)? If possible add a screenshot.**
+
+
+
+* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)
+
+
+
+* **Other information**:

helpers/helpers_emba_print.sh

@@ -543,11 +543,9 @@ pre_module_reporter() {
   # .sh are executed via source -> you can use variables, color codes, execute further commands
   if [[ -f "report_templates/$REPORT_TEMPLATE.txt" ]]; then
     tee -a "$LOG_FILE" < "report_templates/$REPORT_TEMPLATE.txt"
-    print_bar ""
   elif [[ -f "report_templates/$REPORT_TEMPLATE.sh" ]]; then
     # shellcheck disable=SC1090
     source "./report_templates/$REPORT_TEMPLATE.sh"
-    print_bar ""
   fi
 }
 

report_templates/F10_license_summary-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "This module collects license details and creates a details on the identified binaries, versions and the corresponding license (if available). The license details are maintained in the configuration file config/bin_version_strings.cfg."
-print_output ""

report_templates/F20_vul_aggregator-pre.sh

@@ -2,4 +2,3 @@
 
 print_output "This module aggregates all found version numbers together from S06, S09, S25 and S115 and searches with cve-search for known vulnerabilities."
 print_output "Additionally the identified CVE details are matched with public exploit databases."
-print_output ""

report_templates/L10_system_emulator-pre.sh

@@ -3,4 +3,3 @@
 print_output "This module builds and emulates Linux firmware - this module is based on the great work of firmadyne"
 print_output "Check out the original firmadyne project at https://github.com/firmadyne"
 print_output "${MAGENTA}Warning:${NC} This module changes your network configuration and it could happen that your system looses network connectivity."
-print_output ""

report_templates/P11_dlink_SHRS_enc_extract-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "This module extracts encrypted firmware images from D-Link (See https://github.com/0xricksanchez/dlink-decrypt)"
-print_output ""

report_templates/P12_avm_freetz_ng_extract-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "This module extracts AVM firmware images with Freetz-NG (see https://github.com/Freetz-NG/freetz-ng.git)"
-print_output ""

report_templates/P14_ext2_mounter-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "This module mounts and extracts ext2/3 images (currently binwalk destroys the permissions and the symlinks)."
-print_output ""

report_templates/P15_ubi_extractor-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "This module extracts UBI filesystems via ubireader_extract_images and ubireader_extract_files."
-print_output ""

report_templates/P17_gpg_decompress-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "Extracts gpg compressed (not encrypted) firmware images. This technique is used by multiple Linksys/Belkin firmware images"
-print_output ""

report_templates/P18_qnap_decryptor-pre.sh

@@ -1,4 +1,3 @@
 #!/bin/bash
 
 print_output "This module extracts encrypted firmware images from QNAP as shown here: https://github.com/max-boehm/qnap-utils"
-print_output ""

report_templates/P60_firmware_bin_extractor-pre.sh

@@ -5,4 +5,3 @@ print_output "If binwalk fails to extract the firmware, FACT-extractor is used."
 print_output "As last resort binwalk will try to extract every available file multiple times."
 print_output ""
 print_output "If archives like apk, ipk or deb are found they are also extracted to the root filesystem."
-print_output ""

report_templates/P70_firmware_bin_base_analyzer-pre.sh

@@ -2,4 +2,3 @@
 
 print_output "This module tries to identify the operating system. Currently, it tries to identify VxWorks, eCos, Adonis, Siprotec, uC/OS and Linux."
 print_output "If no Linux operating system is found, then it also tries to identify the target architecture (currently with binwalk only). For Linux operating systems later analysis will do this task."
-print_output ""

report_templates/S06_distribution_identification-pre.sh

@@ -2,4 +2,3 @@
 
 print_output "This module counts the number of files and executables in firmware and prints firmware tree in the log files."
 print_output "Additionally it also searches through possible release files (see config/release_files.cfg) for relevant details."
-print_output ""