DeepSeek-Reasonix/internal/assembly/boot/model_error_test.go

package boot

import (
	"context"
	"strings"
	"testing"

	"reasonix/internal/contract/config"
	"reasonix/internal/contract/event"

	_ "reasonix/internal/model/openai"
	_ "reasonix/internal/tools/builtin"
)

// TestBuildUnknownModelErrorIsActionable: a default_model that doesn't resolve
// (e.g. a stale preset name after [[providers]] replaced the built-in presets) must
// fail with a message that names the model, lists what IS configured, and hints
// at the [[providers]] trap — not a silent empty model. This contract holds when
// the project file is the only config, so isolate REASONIX_HOME: a user-global
// config with an explicit default_model would instead rescue the boot (#4218).
func TestBuildUnknownModelErrorIsActionable(t *testing.T) {
	t.Setenv("REASONIX_HOME", robustTempDir(t))
	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	writeFile(t, dir, "reasonix.toml", `
default_model = "legacy-missing"

[[providers]]
name = "deepseek-flash"
kind = "openai"
base_url = "https://example.invalid"
model = "deepseek-v4-flash"
api_key_env = "REASONIX_TEST_KEY_UNSET"
`)
	approveWorkspace(t, dir)

	_, err := Build(context.Background(), Options{Sink: event.Discard})
	if err == nil {
		t.Fatal("expected an error for an unresolvable default_model")
	}
	msg := err.Error()
	for _, want := range []string{`"legacy-missing"`, "deepseek-flash", "[[providers]]"} {
		if !strings.Contains(msg, want) {
			t.Fatalf("error %q should mention %q", msg, want)
		}
	}
}

func TestBuildNoticesProjectDefaultModelFallback(t *testing.T) {
	home := robustTempDir(t)
	t.Setenv("REASONIX_HOME", home)
	writeFile(t, home, "config.toml", `
default_model = "deepseek-pro"

[[providers]]
name = "deepseek-pro"
kind = "openai"
base_url = "https://example.invalid"
model = "deepseek-v4-pro"
api_key_env = "REASONIX_TEST_KEY_UNSET"
`)

	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	writeFile(t, dir, "reasonix.toml", `
default_model = "deepseek-flash"
`)
	approveWorkspace(t, dir)

	var notices []event.Event
	ctrl, err := Build(context.Background(), Options{
		Sink: event.FuncSink(func(e event.Event) {
			if e.Kind == event.Notice {
				notices = append(notices, e)
			}
		}),
	})
	if err != nil {
		t.Fatalf("Build should fall back to the user default model: %v", err)
	}
	defer ctrl.Close()

	for _, notice := range notices {
		if notice.Level == event.LevelWarn &&
			notice.Text == "Ignored the project config's default_model." &&
			strings.Contains(notice.Detail, `default_model = "deepseek-flash"`) &&
			strings.Contains(notice.Detail, `using "deepseek-pro"`) {
			return
		}
	}
	t.Fatalf("expected a warning naming the ignored project model and user fallback; got %v", notices)
}

func TestBuildMigratesLegacyBareMimoModelOverride(t *testing.T) {
	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	writeFile(t, dir, "reasonix.toml", `
default_model = "deepseek-flash"

[[providers]]
name = "deepseek-flash"
kind = "openai"
base_url = "https://example.invalid"
model = "deepseek-v4-flash"
api_key_env = "REASONIX_TEST_KEY_UNSET"
`)
	approveWorkspace(t, dir)

	ctrl, err := Build(context.Background(), Options{Sink: event.Discard, Model: "mimo-v2.5-pro"})
	if err != nil {
		t.Fatalf("Build should migrate legacy bare MiMo model override: %v", err)
	}
	defer ctrl.Close()
	if ctrl.Label() != "mimo-v2.5-pro" {
		t.Fatalf("controller label = %q, want mimo-v2.5-pro", ctrl.Label())
	}
}

// TestBuildNoticesMissingAPIKey: a resolvable model whose API key env is unset
// builds fine (RequireKey is false so the UI stays reachable) but must emit a
// notice naming the env var, instead of silently showing a dead/empty model.
func TestBuildNoticesMissingAPIKey(t *testing.T) {
	const keyEnv = "REASONIX_MISSING_KEY_FOR_TEST"
	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	writeFile(t, dir, "reasonix.toml", `
default_model = "x"

[[providers]]
name = "x"
kind = "openai"
base_url = "https://example.invalid"
model = "m"
api_key_env = "`+keyEnv+`"
`)
	approveWorkspace(t, dir)

	var notices []event.Event
	ctrl, err := Build(context.Background(), Options{
		Sink: event.FuncSink(func(e event.Event) {
			if e.Kind == event.Notice {
				notices = append(notices, e)
			}
		}),
	})
	if err != nil {
		t.Fatalf("Build should succeed with RequireKey=false even without a key: %v", err)
	}
	defer ctrl.Close()

	found := false
	for _, n := range notices {
		if n.Text == "Selected model is missing its API key." && strings.Contains(n.Detail, keyEnv) {
			found = true
		}
	}
	if !found {
		t.Fatalf("expected a notice naming the unset key env %q; got %v", keyEnv, notices)
	}
}

func TestBuildDoesNotNoticeMissingAPIKeyForNoAuthLoopback(t *testing.T) {
	const keyEnv = "REASONIX_LOCAL_GATEWAY_KEY_FOR_TEST"
	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	t.Setenv(keyEnv, "")
	writeFile(t, dir, "reasonix.toml", `
default_model = "local/model-a"

[[providers]]
name = "local"
kind = "openai"
base_url = "http://127.0.0.1:23333/v1"
models = ["model-a"]
api_key_env = "`+keyEnv+`"
`)
	approveWorkspace(t, dir)

	var notices []string
	ctrl, err := Build(context.Background(), Options{
		Sink: event.FuncSink(func(e event.Event) {
			if e.Kind == event.Notice {
				notices = append(notices, e.Text)
			}
		}),
	})
	if err != nil {
		t.Fatalf("Build should allow no-auth loopback provider without a key: %v", err)
	}
	defer ctrl.Close()

	for _, n := range notices {
		if strings.Contains(n, keyEnv) {
			t.Fatalf("did not expect missing-key notice for loopback no-auth provider; got %v", notices)
		}
	}
}

// TestBuildKeylessDefaultFallsBackToConfiguredProvider: when the configured
// default_model is resolvable but its API key is missing, Build should fall
// through to the next provider that IS configured rather than fail with
// "missing env X_API_KEY" (issue #6996). The fallback only kicks in when
// the caller did not pass an explicit Options.Model — explicit choices
// still fail loudly so the user is not silently rerouted.
func TestBuildKeylessDefaultFallsBackToConfiguredProvider(t *testing.T) {
	const keylessEnv = "REASONIX_KEYLESS_DEFAULT_FALLBACK_KEYLESS"
	const configuredEnv = "REASONIX_KEYLESS_DEFAULT_FALLBACK_CONFIGURED"

	home := robustTempDir(t)
	t.Setenv("REASONIX_HOME", home)
	t.Setenv("REASONIX_CREDENTIALS_STORE", "file")
	if _, err := config.SetCredential(configuredEnv, "sk-test"); err != nil {
		t.Fatalf("seed configured key: %v", err)
	}

	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	writeFile(t, dir, "reasonix.toml", `
default_model = "deepseek/deepseek-flash"

[[providers]]
name = "deepseek"
kind = "openai"
base_url = "https://api.deepseek.com"
model = "deepseek-v4-flash"
api_key_env = "`+keylessEnv+`"

[[providers]]
name = "audio"
kind = "openai"
base_url = "https://audio.example.com/v1"
model = "tts-1"
api_key_env = "`+configuredEnv+`"

[[providers]]
name = "minimax"
kind = "openai"
base_url = "https://api.MiniMax.chat/v1"
model = "MiniMax-M3"
api_key_env = "`+configuredEnv+`"
`)
	approveWorkspace(t, dir)

	ctrl, err := Build(context.Background(), Options{Sink: event.Discard})
	if err != nil {
		t.Fatalf("Build should fall back to a configured provider instead of failing on the keyless default: %v", err)
	}
	defer ctrl.Close()
	if got, want := ctrl.Label(), "MiniMax-M3"; got != want {
		t.Fatalf("controller label = %q, want %q (the next provider's model with a configured key)", got, want)
	}
}

// TestBuildExplicitKeylessModelStillFails: an Options.Model that the user
// passed explicitly must keep its fail-fast behavior even when another
// provider is configured and could be used as a fallback. The user asked
// for that specific ref, so we must not silently reroute them.
func TestBuildExplicitKeylessModelStillFails(t *testing.T) {
	const keylessEnv = "REASONIX_EXPLICIT_KEYLESS_KEY"
	const configuredEnv = "REASONIX_EXPLICIT_KEYLESS_CONFIGURED"

	home := robustTempDir(t)
	t.Setenv("REASONIX_HOME", home)
	t.Setenv("REASONIX_CREDENTIALS_STORE", "file")
	if _, err := config.SetCredential(configuredEnv, "sk-test"); err != nil {
		t.Fatalf("seed configured key: %v", err)
	}

	dir := robustTempDir(t)
	fenceBootTestHistoryCatalog(t)
	t.Chdir(dir)
	writeFile(t, dir, "reasonix.toml", `
default_model = "minimax/MiniMax-M3"

[[providers]]
name = "deepseek"
kind = "openai"
base_url = "https://api.deepseek.com"
model = "deepseek-v4-flash"
api_key_env = "`+keylessEnv+`"

[[providers]]
name = "minimax"
kind = "openai"
base_url = "https://api.MiniMax.chat/v1"
model = "MiniMax-M3"
api_key_env = "`+configuredEnv+`"
`)
	approveWorkspace(t, dir)

	_, err := Build(context.Background(), Options{
		Sink:       event.Discard,
		Model:      "deepseek/deepseek-flash",
		RequireKey: true,
	})
	if err == nil {
		t.Fatal("explicit keyless ref must fail loudly even with a configured fallback available")
	}
	if !strings.Contains(err.Error(), keylessEnv) {
		t.Fatalf("error %q should mention %q", err.Error(), keylessEnv)
	}
}