code-review-cli

expo/code-review-cli

0 Fork 0

mirror of https://github.com/expo/code-review-cli.git synced 2026-11-14 17:49:25 -10:00

Author	SHA1	Message	Date
Philippe Loulidi	a5453ba045	ref-check: cover scope-relative citations that carry an extension (#52 ) * ref-check: cover scope-relative citations that carry an extension A scoped prompt writes `pgbouncer/base/pdb.yaml` for what is really `infrastructure/pgbouncer/base/pdb.yaml`. Only extensionless tokens were resolved before, so the precise ref did not silence the citation and the only thing that did was `glob:*/pdb.yaml` — which resolves while pointing at every same-named file in the repo. Six agents pinning a real setup all reached for that glob. Suggestions now name the resolved path; a token with its own wildcard keeps the glob form. ref-check: don't report scrubbed ambient config as a stale ref The read root is scrubbed of AGENTS.md, CLAUDE.md, .env and friends, so a ref to one is missing there by design. The template's own shared.md cites AGENTS.md, so the review note cried wolf on every PR — including this repo's, which is how it was found. The standalone gate is unchanged: there the tree is a real checkout. * ref-check: strip anchor, line and glob prefix before the ambient-config test `AGENTS.md#conventions` and `glob:*/.env.local` name scrubbed files too. Found by the review on this PR. ref-check: see Terraform citations, resolve wildcards as globs, probe scope first Re-review findings, each reproduced before fixing: - .tf/.tfvars/.hcl were missing from the citation allowlist, so `backend.tf` or `/.terraform.lock.hcl` in a prompt was never checked — 18 unchecked citations in the infra setup that motivated this feature. - A wildcard token now resolves as a glob, scope-rebased when that is what matches; the suggested `glob:` ref for `pgbouncer//patch.yaml` used to be a ref that itself failed the check. - namedPath probes the scope before the root: a scoped prompt citing `alerts/` means its own tree even when the root has one too. - USAGE documents the `target` field --json now emits.	2026-08-03 16:08:26 -06:00

Author

SHA1

Message

Date

Philippe Loulidi

a5453ba045

ref-check: cover scope-relative citations that carry an extension (#52 )

* ref-check: cover scope-relative citations that carry an extension

A scoped prompt writes `pgbouncer/base/pdb.yaml` for what is really
`infrastructure/pgbouncer/base/pdb.yaml`. Only extensionless tokens were resolved
before, so the precise ref did not silence the citation and the only thing that
did was `glob:**/pdb.yaml` — which resolves while pointing at every same-named
file in the repo. Six agents pinning a real setup all reached for that glob.

Suggestions now name the resolved path; a token with its own wildcard keeps the
glob form.

* ref-check: don't report scrubbed ambient config as a stale ref

The read root is scrubbed of AGENTS.md, CLAUDE.md, .env and friends, so a ref to
one is missing there by design. The template's own shared.md cites AGENTS.md, so
the review note cried wolf on every PR — including this repo's, which is how it
was found. The standalone gate is unchanged: there the tree is a real checkout.

* ref-check: strip anchor, line and glob prefix before the ambient-config test

`AGENTS.md#conventions` and `glob:**/.env.local` name scrubbed files too. Found by
the review on this PR.

* ref-check: see Terraform citations, resolve wildcards as globs, probe scope first

Re-review findings, each reproduced before fixing:
- .tf/.tfvars/.hcl were missing from the citation allowlist, so `backend.tf` or
  `*/.terraform.lock.hcl` in a prompt was never checked — 18 unchecked citations
  in the infra setup that motivated this feature.
- A wildcard token now resolves as a glob, scope-rebased when that is what
  matches; the suggested `glob:` ref for `pgbouncer/*/patch.yaml` used to be a
  ref that itself failed the check.
- namedPath probes the scope before the root: a scoped prompt citing `alerts/`
  means its own tree even when the root has one too.
- USAGE documents the `target` field --json now emits.

2026-08-03 16:08:26 -06:00

Compare commits

Diff Content Not Available