code-review-cli

expo/code-review-cli

0 Fork 0

mirror of https://github.com/expo/code-review-cli.git synced 2026-11-14 17:49:25 -10:00

Author	SHA1	Message	Date
Brent Vatne	1b2e0c8ffa	Let routed CI cache researched reviews too, from one shared policy #71 removed the offline index and dropped the research gate from `cacheAllowed` — but only from runLegacyCi. runRoutedCi, which handles every repo that has adopted routing.jsonc, kept `!rootConfig.research.enabled` and so has been running a fresh review for every researched PR, for a reason that stopped existing when the index did. Both gates were added by the same commit (#61) for the same index reason, so this was a missed half, not a separate constraint. Caught by the reviewer on the roadmap PR (#72), which claimed the fix had already landed. Rather than qualify that claim, make it true. The duplication is the actual defect: one policy written out twice will drift, and did. `reviewCacheAllowed` in review-cache.ts is now the single definition and both paths call it, with a unit test pinning each flag and recording that research is deliberately not among them.	2026-08-08 16:07:18 -07:00

Author

SHA1

Message

Date

Brent Vatne

1b2e0c8ffa

Let routed CI cache researched reviews too, from one shared policy

#71 removed the offline index and dropped the research gate from `cacheAllowed`
— but only from runLegacyCi. runRoutedCi, which handles every repo that has
adopted routing.jsonc, kept `!rootConfig.research.enabled` and so has been
running a fresh review for every researched PR, for a reason that stopped
existing when the index did. Both gates were added by the same commit (#61) for
the same index reason, so this was a missed half, not a separate constraint.

Caught by the reviewer on the roadmap PR (#72), which claimed the fix had already
landed. Rather than qualify that claim, make it true.

The duplication is the actual defect: one policy written out twice will drift,
and did. `reviewCacheAllowed` in review-cache.ts is now the single definition and
both paths call it, with a unit test pinning each flag and recording that research
is deliberately not among them.

2026-08-08 16:07:18 -07:00

Compare commits

Diff Content Not Available