chore: 2.1.0

## @config-plugins/react-native-webrtc [2.1.0](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-22)

### Features

* **react-native-webrtc:** add config mod for Android minSdkVersion 24 ([ff8b167](https://github.com/expo/config-plugins/commit/ff8b1677640a560ca98abd8a83f349b3a1ee9017))

.github/CODEOWNERS

@@ -0,0 +1 @@
+/*                     @EvanBacon

.github/PULL_REQUEST_TEMPLATE

@@ -0,0 +1,24 @@
+<!--
+🚨 We use semantic release (a bot publishes everything automatically)
+🚨 so please use conventional commit style for the PR title:
+🚨 https://www.conventionalcommits.org/en/v1.0.0/
+🚨 Example: feat(detox): add new step
+-->
+
+# Why
+
+<!--
+Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
+-->
+
+# How
+
+<!--
+How did you build this feature or fix this bug and why?
+-->
+
+# Test Plan
+
+<!--
+Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
+-->

packages/detox/CHANGELOG.md

@@ -1,3 +1,10 @@
+### @config-plugins/detox [1.2.2](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-16)
+
+
+### Bug Fixes
+
+* **detox:** use improved xml generation ([#47](https://github.com/expo/config-plugins/issues/47)) ([6324eb0](https://github.com/expo/config-plugins/commit/6324eb041b3b4eb2318c0a1ea0297e3b7bf28f7c))
+
 ### @config-plugins/detox [1.2.1](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-16)
 
 

packages/detox/build/withNetworkSecurityConfig.js

@@ -42,12 +42,15 @@ function getTemplateConfigContent(subdomains) {
 }
 function getTemplateFile(subdomains) {
     const content = getTemplateConfigContent(subdomains);
-    return `
+    /**
-    <?xml version="1.0" encoding="utf-8"?>
+     * May not have new lines or spaces in the beginning.
-    <network-security-config>
+     * Otherwise build fails with:
-      ${content}
+     * "AAPT: error: XML or text declaration not at start of entity"
-    </network-security-config>
+     */
-  `;
+    return `<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+${content}
+</network-security-config>`;
 }
 exports.getTemplateFile = getTemplateFile;
 /**

packages/detox/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@config-plugins/detox",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Config plugin to auto configure detox on prebuild",
   "main": "build/withDetox.js",
   "types": "build/withDetox.d.ts",

packages/detox/src/__tests__/__snapshots__/withNetworkSecurityConfig-test.ts.snap

@@ -1,25 +1,21 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`getTemplateFile returns domain-config when subdomains is an array 1`] = `
-"
+"<?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
-    <?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
+<network-security-config>
-    <network-security-config>
 
     <domain-config cleartextTrafficPermitted=\\"true\\">
       <domain includeSubdomains=\\"true\\">localhost</domain>
     </domain-config>
   
-    </network-security-config>
+</network-security-config>"
-  "
 `;
 
 exports[`getTemplateFile returns only base-config when subdomains is '*' 1`] = `
-"
+"<?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
-    <?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
+<network-security-config>
-    <network-security-config>
+<base-config cleartextTrafficPermitted=\\"true\\" />
-      <base-config cleartextTrafficPermitted=\\"true\\" />
+</network-security-config>"
-    </network-security-config>
-  "
 `;
 
 exports[`withNetworkSecurityConfigManifest doesn't modify config if subdomains is an empty array 1`] = `

packages/detox/src/withNetworkSecurityConfig.ts

@@ -29,12 +29,15 @@ function getTemplateConfigContent(subdomains: SubdomainsType) {
 
 export function getTemplateFile(subdomains: SubdomainsType): string {
   const content = getTemplateConfigContent(subdomains);
-  return `
+  /**
-    <?xml version="1.0" encoding="utf-8"?>
+   * May not have new lines or spaces in the beginning.
-    <network-security-config>
+   * Otherwise build fails with: 
-      ${content}
+   * "AAPT: error: XML or text declaration not at start of entity"
-    </network-security-config>
+   */
-  `;
+  return `<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+${content}
+</network-security-config>`;
 }
 
 /**

packages/react-native-webrtc/CHANGELOG.md

@@ -1 +1,15 @@
+## @config-plugins/react-native-webrtc [2.1.0](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-22)
+
+
+### Features
+
+* **react-native-webrtc:** add config mod for Android minSdkVersion 24 ([ff8b167](https://github.com/expo/config-plugins/commit/ff8b1677640a560ca98abd8a83f349b3a1ee9017))
+
+### @config-plugins/react-native-webrtc [2.0.2](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-16)
+
+
+### Continuous Integration
+
+* fix versions [skip ci] ([#53](https://github.com/expo/config-plugins/issues/53)) ([5de4ae3](https://github.com/expo/config-plugins/commit/5de4ae3e6182c32b7aa24d70ccd23a11663bb089))
+
 ## @config-plugins/react-native-webrtc 2.0.1

packages/react-native-webrtc/README.md

@@ -59,7 +59,10 @@ export default {
 };
 ```
 
-This plugin will also disable desugaring in the Android `gradle.properties`: `android.enableDexingArtifactTransform.desugaring=false`, and disable iOS Bitcode for "Release" builds (required).
+## Important Notes
+
+- For iOS, this plugin disables Bitcodes for all builds (required).
+- For Android, this plugin disables desugaring in `gradle.properties`: `android.enableDexingArtifactTransform.desugaring=false` and the [minimum deployment target is changed to `24`](https://github.com/react-native-webrtc/react-native-webrtc/issues/720#issuecomment-552374206) (from `21`) which may break other packages in your app!
 
 ## Manual Setup
 

packages/react-native-webrtc/build/withWebRTC.js

@@ -21,6 +21,10 @@ const withWebRTC = (config, props = {}) => {
         "android.permission.SYSTEM_ALERT_WINDOW",
         "android.permission.WAKE_LOCK",
     ]);
+    config = config_plugins_1.AndroidConfig.Version.withBuildScriptExtMinimumVersion(config, {
+        name: "minSdkVersion",
+        minVersion: 24,
+    });
     config = withDesugaring_1.withDesugaring(config, true);
     return config;
 };

packages/react-native-webrtc/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@config-plugins/react-native-webrtc",
-  "version": "2.0.1",
+  "version": "2.1.0",
   "description": "Config plugin to setup react-native-webrtc on prebuild",
   "main": "build/withWebRTC.js",
   "types": "build/withWebRTC.d.ts",

packages/react-native-webrtc/src/withWebRTC.ts

@@ -31,7 +31,12 @@ const withWebRTC: ConfigPlugin<IOSPermissionsProps | void> = (
     "android.permission.SYSTEM_ALERT_WINDOW",
     "android.permission.WAKE_LOCK",
   ]);
-
+  config = AndroidConfig.Version.withBuildScriptExtMinimumVersion(config,
+    {
+      name: "minSdkVersion",
+      minVersion: 24,
+    }
+  )
   config = withDesugaring(config, true);
 
   return config;