[eas-cli] don't print any error logs when doing fallback to https

packages/eas-cli/src/onboarding/git.ts

@@ -1,3 +1,6 @@
+import spawnAsync from '@expo/spawn-async';
+import chalk from 'chalk';
+
 import { runCommandAsync } from './runCommand';
 import Log from '../log';
 import { confirmAsync, promptAsync } from '../prompts';
@@ -7,29 +10,61 @@ export async function runGitCloneAsync({
   githubRepositoryName,
   githubUsername,
   useSsh = true,
+  firstTry = true,
 }: {
   githubUsername: string;
   githubRepositoryName: string;
   targetProjectDir: string;
   useSsh?: boolean;
+  firstTry?: boolean;
 }): Promise<{
   targetProjectDir: string;
 }> {
+  if (firstTry) {
+    Log.log(
+      `📥 Cloning ${chalk.bold(`${githubUsername}/${githubRepositoryName}`)} into ${chalk.bold(
+        targetProjectDir
+      )}...`
+    );
+  }
   const url = useSsh
     ? `[email protected]:${githubUsername}/${githubRepositoryName}.git`
     : `https://github.com/${githubUsername}/${githubRepositoryName}.git`;
+  const wholeStderr: string[] = [];
   try {
-    await runCommandAsync({
-      command: 'git',
-      args: ['clone', url, targetProjectDir],
-      shouldPrintStderrLineAsStdout: line => {
-        return line.includes('Cloning into');
-      },
-      showSpinner: false,
+    const spawnPromise = spawnAsync('git', ['clone', url, targetProjectDir], {
+      stdio: ['inherit', 'pipe', 'pipe'],
     });
+
+    const {
+      child: { stdout, stderr },
+    } = spawnPromise;
+    if (!stdout || !stderr) {
+      throw new Error(`Failed to spawn git clone`);
+    }
+    stdout.on('data', data => {
+      for (const line of data.toString().trim().split('\n')) {
+        Log.log(`${chalk.gray(`[git]`)} ${line}`);
+      }
+    });
+
+    stderr.on('data', data => {
+      for (const line of data.toString().trim().split('\n')) {
+        wholeStderr.push(`${chalk.gray(`[git]`)} ${line}`);
+      }
+    });
+
+    await spawnPromise;
+
+    printFormattedStderr(wholeStderr);
+    Log.log(
+      `✅ ${chalk.bold(`${githubUsername}/${githubRepositoryName}`)} was cloned successfully.`
+    );
+    Log.log();
     return { targetProjectDir };
   } catch (error: any) {
     if (error.stderr.includes('already exists')) {
+      printFormattedStderr(wholeStderr);
       Log.warn(`Directory ${targetProjectDir} already exists.`);
       const shouldContinue = await confirmAsync({
         message: 'Do you want to clone your project to some other destination?',
@@ -47,22 +82,20 @@ export async function runGitCloneAsync({
         githubRepositoryName,
         githubUsername,
         targetProjectDir: newTargetProjectDir,
+        firstTry: false,
       });
     } else if (useSsh && error.stderr.includes('Permission denied')) {
-      Log.warn('It seems like you do not have permission to clone the repository using SSH.');
-      const shouldContinue = await confirmAsync({
-        message: 'Do you want to clone the repository using HTTPS instead?',
-      });
-      if (!shouldContinue) {
-        throw new Error('Permission denied. Aborting...');
-      }
+      Log.debug('Failed to clone using SSH, trying HTTPS');
       return await runGitCloneAsync({
         githubRepositoryName,
         githubUsername,
         targetProjectDir,
         useSsh: false,
+        firstTry: false,
       });
     } else {
+      printFormattedStderr(wholeStderr);
+      Log.error(`❌ ${chalk.bold(`git clone`)} failed`);
       throw error;
     }
   }
@@ -79,3 +112,9 @@ export async function runGitPushAsync({
     cwd: targetProjectDir,
   });
 }
+
+function printFormattedStderr(stderr: string[]): void {
+  for (const line of stderr) {
+    Log.warn(line);
+  }
+}