Compare commits

..
Author SHA1 Message Date
Vojtech NovakandClaude Fable 5.1 23952dfb64 [build-tools] Free evicted Android log files early and close uncapped files
Serialize each file's I/O through one queue so a fully evicted file is
truncated as soon as its queued writes land, live or finished. Evict the
least recently written file first. Seal uncapped files when their stream
finishes and close the handle even when sealing fails.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 22:58:13 +01:00
Vojtech NovakandClaude Fable 5.1 6ab793bbc9 [build-tools] Describe tail retention in the Android log changeset
Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 21:52:57 +01:00
Vojtech NovakandClaude Fable 5.1 96b3e76c63 [build-tools] Name truncated Android logs as tail retention
Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 21:52:44 +01:00
Vojtech NovakandClaude Fable 5.1 9f087b164e [build-tools] Retain the last 20 MiB of each Android log source
Each capture file is a fixed-size ring on disk. A source keeps its newest
bytes across launches: a later launch evicts the head of an earlier one, so
the final attempt always keeps its tail. Finalization rewrites each ring in
log order and truncates evicted bytes.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 21:52:44 +01:00
Vojtech NovakandClaude Fable 5.1 2d8ad58854 [build-tools] Test the shared upload helper once and drop duplicate log cases
Give uploadDeviceRunSessionFileAsync its own suite for empty, missing,
read-error and signal forwarding, and keep one failure case per caller.
Move the early-503 replay to the HTTP suite with a small file. Fold the
memoization and failure-isolation cases into one, test the truncation
metadata through the mocked upload, and give the unused-pipe case
assertions. Drop the capture-side Infinity case that the factory suite
already covers.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 21:25:03 +01:00
Vojtech NovakandClaude Fable 5.1 95bcffb731 [build-tools] Collapse log-source pass-through grids to one case each
The step and CLI layers hand the parsed source list on unchanged, so
the array value never changes the path. Keep one explicit empty-list
case per step, which also guards the disable-logging contract, and one
repeated-flag case for the CLI. Drop capture-factory ordering checks
that cannot fail, since the capture is an argument of the boot call.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 21:22:45 +01:00
Vojtech NovakandClaude Fable 5.1 1099ac72ac [build-tools] Trim overlapping startAsync log tests
Drop the launch-gate dimension from the source-selection grid; the gate
and the log sources never meet in one expression. Keep one pipe-routing
case and reduce the output test to filename and detach assertions that
no other case covers. Assert prepareLogcatOutputAsync directly instead
of through the -logcat argument.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
2026-11-05 21:19:37 +01:00
Vojtech Novak 4dbdaed113 [build-tools] Default session logs safely and isolate FIFO transport 2026-11-05 15:50:50 +01:00
Vojtech Novak 85ea9a2a0b [build-tools] Simplify Android diagnostic collection 2026-11-05 15:18:05 +01:00
Vojtech Novak b03bd85fec [build-tools] Upload finalized Android logs directly 2026-11-05 00:36:55 +01:00
Vojtech Novak 2d5c88d2bc [build-tools] Bound Android session log capture to 20 MiB
Revert the gzip and 100 MiB snapshot changes. Retain the first 20 MiB per selected source across session retries and drain excess output without saving it.
2026-11-05 00:25:44 +01:00
Vojtech Novak 4ce581cf7b [build-tools] Use a 100 MiB Android diagnostic snapshot cap 2026-11-05 00:25:30 +01:00
Vojtech Novak e412e2923a [build-tools] Compress Android diagnostic log snapshots 2026-11-05 00:25:30 +01:00
Vojtech Novak c6231366e1 [build-tools] Apply input defaults in session host tests 2026-11-05 00:25:30 +01:00
Vojtech Novak 04f8663856 [simulator] Record only requested Android session logs 2026-11-05 00:25:30 +01:00
Vojtech Novak 81243a6631 [simulator] Make Android logcat uploads opt-in 2026-11-05 00:25:09 +01:00
Vojtech Novak e38cc79811 [build-tools] Preserve Android log snapshot descriptor ownership 2026-11-05 00:25:09 +01:00
Vojtech Novak b5de1517ac [build-tools] Upload Android session diagnostic logs 2026-11-05 00:25:09 +01:00
208 changed files with 2660 additions and 17693 deletions

No files matched your search

@@ -0,0 +1,5 @@
---
'@expo/build-tools': patch
---
Stop an agent-device session that is still starting up when it is stopped.
+6
View File
@@ -0,0 +1,6 @@
---
'@expo/build-tools': patch
---
Stop an Appium session that is still starting up when it is stopped.
Report temporary-directory cleanup failures when Stop interrupts Appium installation.
+5
View File
@@ -0,0 +1,5 @@
---
'@expo/build-tools': patch
---
Stop an Argent session that is still starting up when it is stopped.
@@ -1,7 +0,0 @@
---
'@expo/build-tools': patch
---
Fix black iOS session preview artifacts on multi-display Simulators by capturing the active display through serve-sim.
Skip automatic previews on older serve-sim versions that cannot exclude them from idle activity.
+8
View File
@@ -0,0 +1,8 @@
---
'@expo/build-tools': patch
'eas-cli': patch
---
Record and upload Android emulator process output as a simulator session artifact by default. Add explicit source selection and a simulator CLI flag to opt in to recording and uploading device-wide logcat. Unselected sources are not recorded by simulator sessions.
Simulator sessions retain the last 20 MiB of each selected Android log source across launches and retries. Each log file is a fixed-size ring on disk, so the end of the final attempt is always kept; older output is dropped first, and artifacts remain uncompressed.
-5
View File
@@ -1,5 +0,0 @@
---
'eas-cli': minor
---
Add `simulator:crashes` to inspect live crashes and download individual saved IPS reports.
-5
View File
@@ -1,5 +0,0 @@
---
'eas-cli': minor
---
Add `simulator:network-requests` to list, follow, and inspect captured requests and download HAR files.
+5
View File
@@ -0,0 +1,5 @@
---
'eas-cli': patch
---
Show the Expo Simulators hint after a successful build from November 12 instead of November 10.
@@ -0,0 +1,5 @@
---
'@expo/build-tools': patch
---
Stop a web-preview session that is still starting up when it is stopped.
+1 -3
View File
@@ -28,9 +28,7 @@ jobs:
contains(github.event.pull_request.labels.*.name, 'no changelog') ||
github.event.pull_request.user.login == 'dependabot[bot]'
}}
# The base branch, not `pull_request.base.sha`: that SHA can be older than the base that the
# checked-out merge commit contains, and the diff then includes other people's changes.
BASE_REF: origin/${{ github.base_ref || 'main' }}
BASE_REF: ${{ github.event.pull_request.base.sha || 'origin/main' }}
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
-70
View File
@@ -2,76 +2,6 @@
This is the log of notable changes to EAS CLI and related packages.
## [27.7.2](https://github.com/expo/eas-cli/releases/tag/v27.7.2) - 2026-11-10
### 🐛 Bug fixes
- [eas-cli] Add `--log-source` to `eas simulator` to select which Android logs a session records. ([#4823](https://github.com/expo/eas-cli/pull/4823) by [@vonovak](https://github.com/vonovak))
- [build-tools] Start SSH session shells in the job's build directory instead of the worker's directory. ([#4843](https://github.com/expo/eas-cli/pull/4843) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
- [eas-cli] Show that the ssh session has ended, instead of saying SSH was not enabled, when `eas workflow:ssh` is given the ID of a finished build. ([#4842](https://github.com/expo/eas-cli/pull/4842) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
- [eas-cli] Show the ID argument and examples in `eas workflow:ssh --help`. ([#4829](https://github.com/expo/eas-cli/pull/4829) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
## [27.7.1](https://github.com/expo/eas-cli/releases/tag/v27.7.1) - 2026-11-10
### 🐛 Bug fixes
- [eas-cli][eas-json][build-tools][eas-build-job][steps][local-build-plugin][worker][simulator-launcher] Update `node-forge`, `tar`, `nanoid`, `minimatch`, `joi`, `ajv`, `yaml`, and `zod` to versions with fixes for published security advisories. ([#4847](https://github.com/expo/eas-cli/pull/4847) by [@tchayen](https://github.com/tchayen))
- [build-tools] Strip the GitHub repository access token from the git remote before a sandbox agent starts. ([#4826](https://github.com/expo/eas-cli/pull/4826) by [@sswrk](https://github.com/sswrk))
## [27.7.0](https://github.com/expo/eas-cli/releases/tag/v27.7.0) - 2026-11-10
### 🎉 New features
- [eas-cli] Add `--git-branch` and `--git-commit-hash` to `eas workflow:run` to record the branch and commit of the uploaded project. ([#4815](https://github.com/expo/eas-cli/pull/4815) by [@hSATAC](https://github.com/hSATAC))
### 🐛 Bug fixes
- [build-tools] Record Android emulator output and, when selected, device logcat during simulator sessions, and upload the last 20 MiB of each as a session artifact. ([#4822](https://github.com/expo/eas-cli/pull/4822) by [@vonovak](https://github.com/vonovak))
- [eas-cli] Stop spinners from flickering when their text wraps onto a second line, such as the `simulator:start` queue message in a narrow terminal. ([#4850](https://github.com/expo/eas-cli/pull/4850) by [@brentvatne](https://github.com/brentvatne))
## [27.6.0](https://github.com/expo/eas-cli/releases/tag/v27.6.0) - 2026-11-10
### 🎉 New features
- [build-tools] Reuse compatible prefetched Appium and XCUITest files without removing them during cleanup. Resolve explicit package versions, including `latest`, and reuse prepared tools only when they match. Use the launcher's runtime serve-sim version for warm adoption and recordings, including prereleases. ([#4837](https://github.com/expo/eas-cli/pull/4837) by [@gwdp](https://github.com/gwdp))
- [eas-cli] Add the `--property key=value` flag to `eas observe:events` to filter events by a property value. ([#4812](https://github.com/expo/eas-cli/pull/4812) by [@Ubax](https://github.com/Ubax))
- [simulator-launcher] Prepare pinned Appium, XCUITest and WebDriverAgent files with `prefetch`. ([#4836](https://github.com/expo/eas-cli/pull/4836) by [@gwdp](https://github.com/gwdp))
- [simulator-launcher] Add `simulator-launcher prefetch` to cache Expo Go downloads. ([#4834](https://github.com/expo/eas-cli/pull/4834) by [@gwdp](https://github.com/gwdp))
- [simulator-launcher] Use caller-supplied serve-sim, agent-device and Argent versions and include exact version inputs in claims. ([#4845](https://github.com/expo/eas-cli/pull/4845) by [@gwdp](https://github.com/gwdp))
- [simulator-launcher] Add `simulator-launcher warmup` so consumers can warm up Simulators, install Expo Go and prepare native tool caches. The command stops its tools and shuts down the selected Simulators before returning. ([#4838](https://github.com/expo/eas-cli/pull/4838) by [@gwdp](https://github.com/gwdp))
### 🐛 Bug fixes
- [build-tools] Stop waiting for `com.apple.datamigrator` to exit before an iOS Simulator on iOS 27.2 or later counts as ready; there it stays resident, so the wait never finished. Earlier runtimes keep the wait. Take the readiness screenshot from the first integrated screen when the device lists several, so the iPhone Duo on iOS 27.2 passes the check. ([#4816](https://github.com/expo/eas-cli/pull/4816) by [@hSATAC](https://github.com/hSATAC))
- [eas-cli] Stop suggesting other event names in `eas observe:events` when an event name with `--session-id`, `--app-version`, `--build-number`, or `--update-id` returns no events. ([#4813](https://github.com/expo/eas-cli/pull/4813) by [@Ubax](https://github.com/Ubax))
- [build-tools] Require the sandbox worker token for sandbox jobs and remove the sandbox GraphQL fallback. ([#4808](https://github.com/expo/eas-cli/pull/4808) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
- [vm-tools] Run the macOS VM-tools service with interactive scheduling so Simulator startup and preview processes avoid launchd's default CPU and I/O throttling. ([#4833](https://github.com/expo/eas-cli/pull/4833) by [@gwdp](https://github.com/gwdp))
## [27.5.0](https://github.com/expo/eas-cli/releases/tag/v27.5.0) - 2026-11-05
### 🎉 New features
- [eas-cli] Import ordered action configurations with `eas simulator:control --import` and show progress for each action. ([#4686](https://github.com/expo/eas-cli/pull/4686) by [@gwdp](https://github.com/gwdp))
- [eas-cli] Reuse simulator control connections with `--keep-alive` or `simulator:control:connection open`. Set an idle timeout, inspect the connection, or close it without stopping the simulator session. Keep-alive currently supports macOS and Linux. ([#4791](https://github.com/expo/eas-cli/pull/4791) by [@gwdp](https://github.com/gwdp))
- [eas-cli] Start simulator sessions from saved settings and apply control actions after readiness. ([#4687](https://github.com/expo/eas-cli/pull/4687) by [@gwdp](https://github.com/gwdp))
- [eas-cli] Run `eas simulator` commands also as `eas simulators`, `eas emulator` and `eas emulators`, for example `eas emulators:start` or `eas simulators:list`. These aliases are hidden from help. ([#4794](https://github.com/expo/eas-cli/pull/4794) by [@szdziedzic](https://github.com/szdziedzic))
- [eas-cli] List `eas workflow:ssh` in `eas --help`. ([#4793](https://github.com/expo/eas-cli/pull/4793) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
### 🐛 Bug fixes
- [build-tools] Stop an agent-device session that is still starting up when it is stopped. ([#4666](https://github.com/expo/eas-cli/pull/4666) by [@gwdp](https://github.com/gwdp))
- [build-tools] Stop an Appium session that is still starting up when it is stopped. ([#4668](https://github.com/expo/eas-cli/pull/4668) by [@gwdp](https://github.com/gwdp))
Report temporary-directory cleanup failures when Stop interrupts Appium installation.
- [build-tools] Stop an Argent session that is still starting up when it is stopped. ([#4667](https://github.com/expo/eas-cli/pull/4667) by [@gwdp](https://github.com/gwdp))
- [eas-cli] Find the personal account by its owner instead of assuming that its name equals the username. ([#3922](https://github.com/expo/eas-cli/pull/3922) by [@byronkarlen](https://github.com/byronkarlen))
- [build-tools][worker] Use the sandbox worker token for sandbox jobs when www provides one, and keep Expo credentials out of the commands of those jobs. ([#4807](https://github.com/expo/eas-cli/pull/4807) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
- [eas-cli] Show the Expo Simulators hint after a successful build from November 12 instead of November 10. ([#4817](https://github.com/expo/eas-cli/pull/4817) by [@williamgrosset](https://github.com/williamgrosset))
- [build-tools] Stop a web-preview session that is still starting up when it is stopped. ([#4669](https://github.com/expo/eas-cli/pull/4669) by [@gwdp](https://github.com/gwdp))
### 🧹 Chores
- [build-tools] Extract the worker API client core from the device run session worker API client. ([#4806](https://github.com/expo/eas-cli/pull/4806) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
## [27.4.1](https://github.com/expo/eas-cli/releases/tag/v27.4.1) - 2026-11-04
### 🐛 Bug fixes
+2 -2
View File
@@ -1,4 +1,4 @@
{
"STAGING": "27.7.2",
"PRODUCTION": "27.7.2"
"STAGING": "27.4.1",
"PRODUCTION": "27.4.1"
}
+1 -1
View File
@@ -1,5 +1,5 @@
{
"npmClient": "yarn",
"version": "27.7.2",
"version": "27.4.1",
"$schema": "node_modules/lerna/schemas/lerna-schema.json"
}
-41
View File
@@ -1,46 +1,5 @@
# @expo/build-tools
## 27.7.2
### Patch Changes
- Start SSH session shells in the job's build directory instead of the worker's directory. ([#4843](https://github.com/expo/eas-cli/pull/4843) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
## 27.7.1
### Patch Changes
- Update `node-forge`, `tar`, `nanoid`, `minimatch`, `joi`, `ajv`, `yaml`, and `zod` to versions with fixes for published security advisories. ([#4847](https://github.com/expo/eas-cli/pull/4847) by [@tchayen](https://github.com/tchayen))
- Strip the GitHub repository access token from the git remote before a sandbox agent starts. ([#4826](https://github.com/expo/eas-cli/pull/4826) by [@sswrk](https://github.com/sswrk))
## 27.7.0
### Patch Changes
- Record Android emulator output and, when selected, device logcat during simulator sessions, and upload the last 20 MiB of each as a session artifact. ([#4822](https://github.com/expo/eas-cli/pull/4822) by [@vonovak](https://github.com/vonovak))
## 27.6.0
### Minor Changes
- Reuse compatible prefetched Appium and XCUITest files without removing them during cleanup. Resolve explicit package versions, including `latest`, and reuse prepared tools only when they match. Use the launcher's runtime serve-sim version for warm adoption and recordings, including prereleases. ([#4837](https://github.com/expo/eas-cli/pull/4837) by [@gwdp](https://github.com/gwdp))
### Patch Changes
- Stop waiting for `com.apple.datamigrator` to exit before an iOS Simulator on iOS 27.2 or later counts as ready; there it stays resident, so the wait never finished. Earlier runtimes keep the wait. Take the readiness screenshot from the first integrated screen when the device lists several, so the iPhone Duo on iOS 27.2 passes the check. ([#4816](https://github.com/expo/eas-cli/pull/4816) by [@hSATAC](https://github.com/hSATAC))
- Require the sandbox worker token for sandbox jobs and remove the sandbox GraphQL fallback. ([#4808](https://github.com/expo/eas-cli/pull/4808) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
## 27.5.0
### Patch Changes
- Stop an agent-device session that is still starting up when it is stopped. ([#4666](https://github.com/expo/eas-cli/pull/4666) by [@gwdp](https://github.com/gwdp))
- Stop an Appium session that is still starting up when it is stopped. ([#4668](https://github.com/expo/eas-cli/pull/4668) by [@gwdp](https://github.com/gwdp))
Report temporary-directory cleanup failures when Stop interrupts Appium installation.
- Stop an Argent session that is still starting up when it is stopped. ([#4667](https://github.com/expo/eas-cli/pull/4667) by [@gwdp](https://github.com/gwdp))
- Use the sandbox worker token for sandbox jobs when www provides one, and keep Expo credentials out of the commands of those jobs. ([#4807](https://github.com/expo/eas-cli/pull/4807) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
- Stop a web-preview session that is still starting up when it is stopped. ([#4669](https://github.com/expo/eas-cli/pull/4669) by [@gwdp](https://github.com/gwdp))
## 27.4.1
### Patch Changes
+12 -12
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/build-tools",
"version": "27.7.2",
"version": "27.4.1",
"bugs": "https://github.com/expo/eas-cli/issues",
"license": "BUSL-1.1",
"author": "Expo <[email protected]>",
@@ -42,17 +42,17 @@
"dependencies": {
"@expo/config": "55.0.10",
"@expo/config-plugins": "55.0.7",
"@expo/downloader": "27.7.2",
"@expo/eas-build-job": "27.7.2",
"@expo/downloader": "27.4.1",
"@expo/eas-build-job": "27.4.1",
"@expo/env": "^0.4.0",
"@expo/logger": "27.7.2",
"@expo/logger": "27.4.1",
"@expo/package-manager": "1.9.10",
"@expo/plist": "^0.3.5",
"@expo/results": "^1.0.0",
"@expo/spawn-async": "1.7.2",
"@expo/steps": "27.7.2",
"@expo/template-file": "27.7.2",
"@expo/turtle-spawn": "27.7.2",
"@expo/steps": "27.4.1",
"@expo/template-file": "27.4.1",
"@expo/turtle-spawn": "27.4.1",
"@expo/xcpretty": "^4.4.7",
"@ngrok/ngrok": "1.7.0",
"@sentry/node": "7.77.0",
@@ -63,11 +63,11 @@
"fast-xml-parser": "^4.4.1",
"fs-extra": "^11.2.0",
"gql.tada": "^1.11.3",
"joi": "^17.13.9",
"joi": "^17.13.1",
"jose": "5.10.0",
"lodash": "^4.18.1",
"node-fetch": "^2.7.0",
"node-forge": "^1.4.3",
"node-forge": "^1.3.1",
"node-pty": "1.2.0-beta.15",
"node-stream-zip": "1.15.0",
"nullthrows": "^1.1.1",
@@ -77,11 +77,11 @@
"resolve-from": "^5.0.0",
"retry": "^0.13.1",
"semver": "^7.6.2",
"tar": "7.5.22",
"tar": "7.5.19",
"uuid": "9.0.1",
"ws": "8.21.1",
"yaml": "^2.9.1",
"zod": "^4.6.7"
"yaml": "^2.8.1",
"zod": "^4.3.5"
},
"devDependencies": {
"@expo/repack-app": "~0.9.0",
@@ -2,7 +2,6 @@ import {
BuildPhase,
BuildPhaseResult,
BuildTrigger,
EnvironmentSecretType,
Job,
Metadata,
Platform,
@@ -32,34 +31,6 @@ describe('BuildContext', () => {
(fs.readdir as unknown as jest.Mock).mockResolvedValue([]);
});
it('keeps the sandbox worker token out of the env and keeps the other secrets', () => {
const ctx = new BuildContext(
{
triggeredBy: BuildTrigger.GIT_BASED_INTEGRATION,
secrets: {
environmentSecrets: [
{
name: 'EAS_SANDBOX_WORKER_TOKEN',
value: 'sandbox-worker-token',
type: EnvironmentSecretType.STRING,
},
{ name: 'KEEP', value: 'value', type: EnvironmentSecretType.STRING },
],
},
} as Job,
{
env: { __API_SERVER_URL: 'https://api.expo.test' },
workingdir: '/workingdir',
logger: createMockLogger(),
logBuffer: { getLogs: () => [], getPhaseLogs: () => [] },
uploadArtifact: jest.fn(),
}
);
expect(ctx.env.EAS_SANDBOX_WORKER_TOKEN).toBeUndefined();
expect(ctx.env.KEEP).toBe('value');
});
it('should merge secrets', async () => {
const robotAccessToken = randomUUID();
await vol.promises.mkdir('/workingdir/eas-environment-secrets/', { recursive: true });
@@ -361,67 +361,6 @@ describe('Datadog singleton', () => {
expect(turtleFetchMock).not.toHaveBeenCalled();
});
it('POSTs distribution metrics to the sandbox worker API with the sandbox worker token', () => {
turtleFetchMock.mockResolvedValueOnce({} as Response);
Datadog.setup({
expoApiV2BaseUrl: 'https://api.expo.test/v2/',
sandboxWorkerToken: 'sandbox-token',
target: { kind: 'sandbox' },
});
Datadog.distribution('eas.workflow.hook', 1, { hook: 'on_start' });
expect(turtleFetchMock).toHaveBeenCalledWith(
'https://api.expo.test/v2/sandbox-worker/metrics',
'POST',
{
json: {
metrics: [
{
name: 'eas.workflow.hook',
type: 'distribution',
value: 1,
tags: { hook: 'on_start', target: 'job_run' },
},
],
},
headers: { 'expo-sandbox-worker-token': 'sandbox-token' },
retries: 2,
}
);
});
it('labels metric upload failures for sandbox targets with the sandbox kind', async () => {
turtleFetchMock.mockRejectedValueOnce(new Error('network down'));
Datadog.setup({
expoApiV2BaseUrl: 'https://api.expo.test/v2/',
sandboxWorkerToken: 'sandbox-token',
target: { kind: 'sandbox' },
});
Datadog.distribution('eas.workflow.hook', 1);
await flushPromises();
expect(sentryCaptureMock).toHaveBeenCalledWith(
'Failed to report turtle sandbox metric',
expect.any(Error),
expect.anything()
);
});
it('does not report logs for sandbox targets', () => {
Datadog.setup({
expoApiV2BaseUrl: 'https://api.expo.test/v2/',
sandboxWorkerToken: 'sandbox-token',
target: { kind: 'sandbox' },
});
Datadog.log('Custom build saw user-provided function');
expect(turtleFetchMock).not.toHaveBeenCalled();
});
it('flushes pending metric uploads', async () => {
let resolveUpload!: (response: Response) => void;
turtleFetchMock.mockReturnValueOnce(
@@ -1,8 +1,8 @@
import { SystemError, UserError } from '@expo/eas-build-job';
import { UserError } from '@expo/eas-build-job';
import spawn from '@expo/turtle-spawn';
import { vol } from 'memfs';
import { fetchAndCheckoutRefAsync, stripRepositoryCredentialsAsync } from '../git';
import { fetchAndCheckoutRefAsync } from '../git';
jest.mock('@expo/turtle-spawn');
@@ -147,64 +147,3 @@ describe(fetchAndCheckoutRefAsync, () => {
expect(error.message).not.toContain('ghs_secret123');
});
});
describe(stripRepositoryCredentialsAsync, () => {
const token = 'ghs_secret123';
function mockRemoteUrl(url: string): void {
jest.mocked(spawn).mockResolvedValueOnce({ stdout: `${url}\n` } as never);
}
it('strips the token from the origin remote', async () => {
mockRemoteUrl(`https://x-access-token:${token}@github.com/expo/app.git`);
await stripRepositoryCredentialsAsync({ repositoryDirectory });
expect(spawn).toHaveBeenNthCalledWith(1, 'git', ['remote', 'get-url', 'origin'], {
cwd: repositoryDirectory,
});
expect(spawn).toHaveBeenNthCalledWith(
2,
'git',
['remote', 'set-url', 'origin', 'https://github.com/expo/app.git'],
{ cwd: repositoryDirectory }
);
expect(spawn).toHaveBeenCalledTimes(2);
});
it('keeps the host and port of a GitHub Enterprise remote', async () => {
mockRemoteUrl(`https://x-access-token:${token}@ghe.example.com:8443/org/app.git`);
await stripRepositoryCredentialsAsync({ repositoryDirectory });
expect(spawn).toHaveBeenNthCalledWith(
2,
'git',
['remote', 'set-url', 'origin', 'https://ghe.example.com:8443/org/app.git'],
{ cwd: repositoryDirectory }
);
});
it('does nothing when the origin remote carries no credentials', async () => {
mockRemoteUrl('https://github.com/expo/app.git');
await stripRepositoryCredentialsAsync({ repositoryDirectory });
expect(spawn).toHaveBeenCalledTimes(1);
});
it('throws when the remote URL cannot be rewritten', async () => {
mockRemoteUrl(`https://x-access-token:${token}@github.com/expo/app.git`);
const gitError = Object.assign(new Error('git exited with non-zero code: 128'), {
stderr: "fatal: No such remote 'origin'",
});
jest.mocked(spawn).mockRejectedValueOnce(gitError);
const promise = stripRepositoryCredentialsAsync({ repositoryDirectory });
await expect(promise).rejects.toBeInstanceOf(SystemError);
await expect(promise).rejects.toMatchObject({ cause: gitError });
const error = await promise.catch(err => err);
expect(error.message).not.toContain(token);
});
});
@@ -2,7 +2,6 @@ import {
ArchiveSourceType,
BuildMode,
BuildTrigger,
EnvironmentSecretType,
ErrorCode,
Job,
Platform,
@@ -117,73 +116,6 @@ describe('projectSources', () => {
);
});
it('fetches a sandbox project source from the sandbox worker router with only the worker token', async () => {
const gitCommitHash = randomBytes(20).toString('hex');
const ctx = new BuildContext(
{
triggeredBy: BuildTrigger.GIT_BASED_INTEGRATION,
projectArchive: {
type: ArchiveSourceType.GIT,
gitRef: 'refs/heads/main',
gitCommitHash,
},
secrets: {
robotAccessToken: 'sandbox-worker-token',
environmentSecrets: [
{
name: 'EAS_SANDBOX_WORKER_TOKEN',
type: EnvironmentSecretType.STRING,
value: 'sandbox-worker-token',
},
],
},
} as unknown as Job,
{
env: {
__API_SERVER_URL: 'https://api.expo.dev',
EAS_BUILD_ID: randomUUID(),
EAS_BUILD_RUNNER: 'eas-build',
},
workingdir: '/workingdir',
logger: createMockLogger(),
logBuffer: { getLogs: () => [], getPhaseLogs: () => [] },
uploadArtifact: jest.fn(),
}
);
const fetchMock = jest.mocked(fetch);
fetchMock.mockImplementation(
async () =>
({
ok: true,
json: async () => ({
data: {
gitRef: 'refs/heads/main',
gitCommitHash,
repositoryUrl: 'https://x-access-token:[email protected]/expo/eas-cli.git',
type: ArchiveSourceType.GIT,
},
}),
}) as Response
);
await prepareProjectSourcesAsync(ctx, ctx.buildDirectory);
expect(fetchMock).toHaveBeenCalledWith(
'https://api.expo.dev/v2/sandbox-worker/project-archive',
expect.objectContaining({
method: 'POST',
headers: { 'expo-sandbox-worker-token': 'sandbox-worker-token' },
})
);
expect(shallowCloneRepositoryAsync).toHaveBeenCalledWith(
expect.objectContaining({
archiveSource: expect.objectContaining({
repositoryUrl: 'https://x-access-token:[email protected]/expo/eas-cli.git',
}),
})
);
});
it.each(['http', 'network', 'json', 'schema', 'missing-url', 'PATH', 'GCS', 'R2'])(
'throws a system error if refresh fails (%s)',
async failure => {
+1 -40
View File
@@ -1,4 +1,4 @@
import { ArchiveSource, ArchiveSourceType, SystemError, UserError } from '@expo/eas-build-job';
import { ArchiveSource, ArchiveSourceType, UserError } from '@expo/eas-build-job';
import { bunyan } from '@expo/logger';
import spawn from '@expo/turtle-spawn';
import fs from 'fs-extra';
@@ -99,45 +99,6 @@ export async function fetchAndCheckoutRefAsync({
}
}
export async function stripRepositoryCredentialsAsync({
repositoryDirectory,
}: {
repositoryDirectory: string;
}): Promise<void> {
let remoteUrl: URL;
try {
const { stdout } = await spawn('git', ['remote', 'get-url', 'origin'], {
cwd: repositoryDirectory,
});
remoteUrl = new URL(stdout.trim());
} catch (err) {
throw new SystemError('Failed to read the origin remote URL of the project repository.', {
cause: err,
});
}
if (!remoteUrl.username && !remoteUrl.password) {
return;
}
try {
await spawn('git', ['remote', 'set-url', 'origin', stripCredentialsFromGitUrl(remoteUrl)], {
cwd: repositoryDirectory,
});
} catch (err) {
throw new SystemError('Failed to strip credentials from the origin remote URL.', {
cause: err,
});
}
}
function stripCredentialsFromGitUrl(url: URL): string {
const strippedUrl = new URL(url.toString());
strippedUrl.username = '';
strippedUrl.password = '';
return strippedUrl.toString();
}
function getSanitizedGitUrl(maybeGitUrl: string): string | null {
try {
const url = new URL(maybeGitUrl);
@@ -1,15 +0,0 @@
import { ArchiveSourceType } from '@expo/eas-build-job';
import { z } from 'zod';
export const ProjectArchiveSourceSchema = z.discriminatedUnion('type', [
z.object({
type: z.literal(ArchiveSourceType.GIT),
repositoryUrl: z.string().url(),
gitRef: z.string().nullable(),
gitCommitHash: z.string(),
}),
z.object({ type: z.literal(ArchiveSourceType.URL), url: z.string().url() }),
z.object({ type: z.literal(ArchiveSourceType.NONE) }),
]);
export type ProjectArchiveSource = z.infer<typeof ProjectArchiveSourceSchema>;
@@ -10,9 +10,7 @@ import path from 'path';
import { z } from 'zod';
import { shallowCloneRepositoryAsync } from './git';
import { type ProjectArchiveSource, ProjectArchiveSourceSchema } from './projectArchiveSource';
import { BuildContext } from '../context';
import { getSandboxWorkerApi } from '../steps/utils/sandboxWorkerApi';
import { uploadContentWithSignedUrl } from '../storage/uploadWithSignedUrl';
import { turtleFetch } from '../utils/turtleFetch';
@@ -247,18 +245,7 @@ async function uploadProjectMetadataAsync(
}
}
async function fetchProjectArchiveSourceAsync(
ctx: BuildContext<Job>
): Promise<ProjectArchiveSource> {
const sandboxWorkerApi = getSandboxWorkerApi(ctx);
if (sandboxWorkerApi) {
return await sandboxWorkerApi.getProjectArchiveSourceAsync({
timeoutMs: 20000,
retries: 3,
logger: ctx.logger,
});
}
async function fetchProjectArchiveSourceAsync(ctx: BuildContext<Job>) {
const taskId = nullthrows(ctx.env.EAS_BUILD_ID, 'EAS_BUILD_ID is not set');
const expoApiServerURL = nullthrows(ctx.env.__API_SERVER_URL, '__API_SERVER_URL is not set');
const robotAccessToken = nullthrows(
@@ -296,7 +283,20 @@ async function fetchProjectArchiveSourceAsync(
);
}
const dataResult = z.object({ data: ProjectArchiveSourceSchema }).safeParse(jsonResult.value);
const dataResult = z
.object({
data: z.discriminatedUnion('type', [
z.object({
type: z.literal(ArchiveSourceType.GIT),
repositoryUrl: z.string().url(),
gitRef: z.string().nullable(),
gitCommitHash: z.string(),
}),
z.object({ type: z.literal(ArchiveSourceType.URL), url: z.string().url() }),
z.object({ type: z.literal(ArchiveSourceType.NONE) }),
]),
})
.safeParse(jsonResult.value);
if (!dataResult.success) {
throw new Error(
`Unexpected data from server (${response.status}): ${z.prettifyError(dataResult.error)}`
+1 -9
View File
@@ -3,7 +3,6 @@ import {
BuildPhase,
BuildPhaseResult,
Env,
type EnvironmentSecret,
EnvironmentSecretType,
Job,
LogMarker,
@@ -19,7 +18,6 @@ import path from 'path';
import { resolveBuildPhaseErrorAsync } from './buildErrors/detectError';
import { Datadog } from './datadog';
import { SANDBOX_WORKER_TOKEN_ENV } from './steps/utils/sandboxWorkerApi';
import { readAppConfig } from './utils/appConfig';
import { createTemporaryEnvironmentSecretFile } from './utils/environmentSecrets';
import { PackageManager, resolvePackageManager } from './utils/packageManager';
@@ -410,7 +408,7 @@ export class BuildContext<TJob extends Job = Job> {
const environmentSecretsDirectory = path.join(this.workingdir, 'eas-environment-secrets');
const environmentSecrets: Record<string, string> = {};
for (const { name, type, value } of job.secrets.environmentSecrets.filter(isJobSecret)) {
for (const { name, type, value } of job.secrets.environmentSecrets) {
if (type === EnvironmentSecretType.STRING) {
environmentSecrets[name] = value;
} else {
@@ -424,9 +422,3 @@ export class BuildContext<TJob extends Job = Job> {
return environmentSecrets;
}
}
const EXCLUDED_JOB_SECRET_NAMES: ReadonlySet<string> = new Set([SANDBOX_WORKER_TOKEN_ENV]);
function isJobSecret({ name }: EnvironmentSecret): boolean {
return !EXCLUDED_JOB_SECRET_NAMES.has(name);
}
+2 -15
View File
@@ -1,30 +1,23 @@
import { Sentry } from './sentry';
import { DEVICE_RUN_SESSION_TOKEN_HEADER } from './steps/utils/deviceRunSessionWorkerApi';
import { SANDBOX_WORKER_TOKEN_HEADER } from './steps/utils/sandboxWorkerApi';
import { turtleFetch } from './utils/turtleFetch';
type MetricsTarget =
| { kind: 'build'; turtleBuildId: string }
| { kind: 'jobRun'; turtleJobRunId: string }
// A device run session job with a session token. The token names the session and its job run.
| { kind: 'deviceRunSession' }
| { kind: 'sandbox' };
| { kind: 'deviceRunSession' };
type DatadogSetupOptions =
| {
expoApiV2BaseUrl: string;
robotAccessToken: string;
target: Exclude<MetricsTarget, { kind: 'deviceRunSession' | 'sandbox' }>;
target: Exclude<MetricsTarget, { kind: 'deviceRunSession' }>;
}
| {
expoApiV2BaseUrl: string;
deviceRunSessionToken: string;
target: Extract<MetricsTarget, { kind: 'deviceRunSession' }>;
}
| {
expoApiV2BaseUrl: string;
sandboxWorkerToken: string;
target: Extract<MetricsTarget, { kind: 'sandbox' }>;
};
let setupOptions: DatadogSetupOptions | null = null;
@@ -48,12 +41,6 @@ function getMetricsRequest(options: DatadogSetupOptions): {
headers: { [DEVICE_RUN_SESSION_TOKEN_HEADER]: options.deviceRunSessionToken },
};
}
if ('sandboxWorkerToken' in options) {
return {
path: 'sandbox-worker/metrics',
headers: { [SANDBOX_WORKER_TOKEN_HEADER]: options.sandboxWorkerToken },
};
}
const { target, robotAccessToken } = options;
return {
path:
-1
View File
@@ -43,6 +43,5 @@ export * from './generic';
export { Datadog } from './datadog';
export { getDeviceRunSessionTokenFromEnvironmentSecrets } from './steps/utils/deviceRunSessionWorkerApi';
export { getSandboxWorkerTokenFromEnvironmentSecrets } from './steps/utils/sandboxWorkerApi';
export { Sentry } from './sentry';
export * from './runtimeSettings';
@@ -4,7 +4,7 @@ import spawn from '@expo/turtle-spawn';
import { createGlobalContextMock } from '../../../__tests__/utils/context';
import { type CustomBuildContext } from '../../../customBuildContext';
import { AndroidEmulatorLogRing } from '../../../utils/androidEmulatorLogCapture';
import { AndroidEmulatorLogCapture } from '../../../utils/androidEmulatorLogCapture';
import { getAndroidEmulatorLogCapture } from '../../utils/androidEmulatorLogs';
import { IosSimulatorUtils } from '../../../utils/IosSimulatorUtils';
import { stopLocalEgressResourcesAsync } from '../../utils/localEgress';
@@ -447,27 +447,32 @@ describe(createStartAgentDeviceSessionBuildFunction, () => {
});
await step.executeAsync();
expect(startAndroidEmulatorAsync).toHaveBeenCalledWith(
expect.objectContaining({
logCapture: expect.objectContaining({ sources: ['emulator-output'] }),
})
expect.objectContaining({ logSources: ['emulator-output'] })
);
});
it('passes an explicit empty source list and the workflow capture to Android boot', async () => {
const capture = new AndroidEmulatorLogRing({ sources: [] });
const capture = new AndroidEmulatorLogCapture();
jest.mocked(getAndroidEmulatorLogCapture).mockReturnValue(capture);
const env = { DEVICE_RUN_SESSION_ID: 'session' };
await runStep(BuildRuntimePlatform.LINUX, { log_sources: [] }, undefined, ctx, false, env);
expect(getAndroidEmulatorLogCapture).toHaveBeenCalledWith(expect.anything(), env, []);
await runStep(
BuildRuntimePlatform.LINUX,
{ android_log_sources: [] },
undefined,
ctx,
false,
env
);
expect(getAndroidEmulatorLogCapture).toHaveBeenCalledWith(expect.anything(), env);
expect(startAndroidEmulatorAsync).toHaveBeenCalledWith(
expect.objectContaining({ logCapture: capture })
expect.objectContaining({ logSources: [], logCapture: capture })
);
});
it('rejects invalid Android log sources before boot or downloading', async () => {
await expect(
runStep(BuildRuntimePlatform.LINUX, {
log_sources: ['unknown'],
android_log_sources: ['unknown'],
build_id: 'build-id',
})
).rejects.toThrow();
@@ -475,24 +480,6 @@ describe(createStartAgentDeviceSessionBuildFunction, () => {
expect(downloadBuildAsync).not.toHaveBeenCalled();
});
it('rejects Android log sources on an iOS session before boot or downloading', async () => {
await expect(
runStep(BuildRuntimePlatform.DARWIN, {
log_sources: ['device-logcat'],
build_id: 'build-id',
})
).rejects.toThrow('Input "log_sources" selects Android emulator logs');
expect(runAgentDeviceRemoteSessionAsync).not.toHaveBeenCalled();
expect(IosSimulatorUtils.resolveUdidAsync).not.toHaveBeenCalled();
expect(downloadBuildAsync).not.toHaveBeenCalled();
});
it('boots an iOS session with an explicit empty source list', async () => {
await runStep(BuildRuntimePlatform.DARWIN, { log_sources: [] });
expect(runAgentDeviceRemoteSessionAsync).toHaveBeenCalled();
expect(startAndroidEmulatorAsync).not.toHaveBeenCalled();
});
it('boots the Android Emulator with the device inputs', async () => {
await runStep(BuildRuntimePlatform.LINUX, {
device_identifier: 'pixel_7',
@@ -682,7 +669,7 @@ describe(createStartAgentDeviceSessionBuildFunction, () => {
expect(
buildFunction.inputProviders?.map(provider => provider(globalCtx, 'Test step').id)
).toEqual([
'log_sources',
'android_log_sources',
'device_identifier',
'system_image_package',
'lcd_width',
@@ -887,17 +874,6 @@ describe(createStartAgentDeviceSessionBuildFunction, () => {
expect(runAgentDeviceRemoteSessionAsync).toHaveBeenCalledTimes(2);
});
it('passes the resolved version to agent-device after a warm version mismatch', async () => {
jest
.mocked(runOnWarmIosSimulatorAsync)
.mockImplementation((_claim, run) => run(undefined, '999.1.0'));
await runStep(BuildRuntimePlatform.DARWIN, { package_version: 'latest' }, undefined, ctx, true);
expect(runAgentDeviceRemoteSessionAsync).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({ packageVersion: '999.1.0' })
);
});
it('accepts only one application source', async () => {
await expect(
runStep(BuildRuntimePlatform.DARWIN, { install_app_path: '/tmp/App.app', build_id: 'id' })
@@ -9,7 +9,7 @@ import {
} from '../../../utils/AndroidEmulatorUtils';
import { retryAsync } from '../../../utils/retry';
import { resolveAndroidEmulatorLocalEgressAsync } from '../../utils/androidLocalEgress';
import { AndroidEmulatorLogRing } from '../../../utils/androidEmulatorLogCapture';
import { AndroidEmulatorLogCapture } from '../../../utils/androidEmulatorLogCapture';
import { getAndroidEmulatorLogCapture } from '../../utils/androidEmulatorLogs';
import { createStartAndroidEmulatorBuildFunction } from '../startAndroidEmulator';
@@ -101,25 +101,25 @@ describe(createStartAndroidEmulatorBuildFunction, () => {
it('preserves an explicit empty source list and one capture through boot retries and clones', async () => {
mockedAndroidUtils.waitForReadyAsync.mockRejectedValueOnce(new Error('retry boot'));
const capture = new AndroidEmulatorLogRing({ sources: [] });
const capture = new AndroidEmulatorLogCapture();
jest.mocked(getAndroidEmulatorLogCapture).mockReturnValue(capture);
await createStep(
{ log_sources: [], count: 2 },
{ android_log_sources: [], count: 2 },
{ DEVICE_RUN_SESSION_ID: 'session' }
).executeAsync();
expect(getAndroidEmulatorLogCapture).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({ DEVICE_RUN_SESSION_ID: 'session' }),
[]
expect.objectContaining({ DEVICE_RUN_SESSION_ID: 'session' })
);
expect(mockedAndroidUtils.startAsync).toHaveBeenCalledTimes(4);
for (const [options] of mockedAndroidUtils.startAsync.mock.calls) {
expect(options.logSources).toEqual([]);
expect(options.logCapture).toBe(capture);
}
});
it('rejects invalid sources before starting the emulator', async () => {
await expect(createStep({ log_sources: ['unknown'] }).executeAsync()).rejects.toThrow();
await expect(createStep({ android_log_sources: ['unknown'] }).executeAsync()).rejects.toThrow();
expect(mockedAndroidUtils.startAsync).not.toHaveBeenCalled();
});
@@ -144,7 +144,8 @@ describe(createStartAndroidEmulatorBuildFunction, () => {
deviceName: 'EasAndroidDevice01',
env: expect.any(Object),
logcatDirectory: '/tmp/logcat-directory',
logCapture: expect.objectContaining({ sources: ['emulator-output', 'device-logcat'] }),
logSources: ['emulator-output', 'device-logcat'],
logCapture: expect.any(AndroidEmulatorLogCapture),
});
expect(mockedAndroidUtils.waitForReadyAsync).toHaveBeenCalledWith({
env: expect.any(Object),
@@ -1,10 +1,7 @@
import { type WarmIosSession } from '../../utils/warmIosSession';
import { BuildRuntimePlatform, type BuildStepContext } from '@expo/steps';
import spawn from '@expo/turtle-spawn';
import { vol } from 'memfs';
import plist from 'plist';
import fs from 'node:fs';
import os from 'node:os';
import path from 'node:path';
import * as timersPromises from 'node:timers/promises';
@@ -12,7 +9,6 @@ import { createGlobalContextMock } from '../../../__tests__/utils/context';
import { type CustomBuildContext } from '../../../customBuildContext';
import { AndroidEmulatorUtils } from '../../../utils/AndroidEmulatorUtils';
import { IosSimulatorUtils } from '../../../utils/IosSimulatorUtils';
import { PackageManager, resolveConfiguredPackageManager } from '../../../utils/packageManager';
import * as processes from '../../../utils/processes';
import { sleepAsync } from '../../../utils/retry';
import { turtleFetch } from '../../../utils/turtleFetch';
@@ -102,46 +98,6 @@ jest.mock('../../utils/localEgressSession', () => ({
}));
const logger = { info: jest.fn(), warn: jest.fn() } as never;
const preparedHome = path.join(os.homedir(), 'Library/Caches/expo-simulator-startup/appium');
const preparedManifest = path.join(path.dirname(preparedHome), 'prepared.json');
const preparedBin = path.join(preparedHome, 'node_modules', '.bin', 'appium');
const preparedRunner = path.join(
preparedHome,
'preinstalled-wda',
'WebDriverAgentRunner-Runner.app'
);
const driverList = ['driver', 'list', '--installed', '--json'];
/** Today's `driver list` output: the prepared home lists xcuitest, a new home lists nothing. */
function driverListStdout(command: string): string {
return JSON.stringify(command === preparedBin ? { xcuitest: { installed: true } } : {});
}
/** Writes the Appium home that `simulator-launcher prefetch` prepares for reuse. */
function writePreparedHome(): void {
fs.mkdirSync(path.dirname(preparedBin), { recursive: true });
fs.writeFileSync(preparedBin, '');
writeInstalledVersion('appium', '3.9.0');
writeInstalledVersion('appium-xcuitest-driver', '12.22.8');
fs.mkdirSync(preparedRunner, { recursive: true });
fs.writeFileSync(
path.join(preparedRunner, 'Info.plist'),
plist.build({ CFBundleExecutable: 'Runner' })
);
fs.writeFileSync(path.join(preparedRunner, 'Runner'), 'executable', { mode: 0o755 });
writePreparedManifest({ version: '3.9.0', xcuitest: '12.22.8', home: preparedHome });
}
function writePreparedManifest(appium: unknown): void {
fs.writeFileSync(preparedManifest, `${JSON.stringify({ tools: { appium } })}\n`);
}
function writeInstalledVersion(name: string, version: string): void {
const directory = path.join(preparedHome, 'node_modules', name);
fs.mkdirSync(directory, { recursive: true });
fs.writeFileSync(path.join(directory, 'package.json'), JSON.stringify({ name, version }));
}
describe(resolveAppium3VersionSpec, () => {
it('uses the worker-supported Appium 3 version by default', () => {
@@ -216,9 +172,9 @@ describe(installAppiumAsync, () => {
beforeEach(() => {
jest.clearAllMocks();
jest.mocked(watchDeviceRunSessionStartup).mockImplementation(createStartupWatchMock);
jest.mocked(spawn).mockImplementation((async (command: string, args: string[]) => {
jest.mocked(spawn).mockImplementation((async (_command: string, args: string[]) => {
if (args.includes('--json')) {
return { stdout: driverListStdout(command) };
return { stdout: JSON.stringify({}) };
}
return { stdout: '' };
}) as never);
@@ -252,255 +208,6 @@ describe(installAppiumAsync, () => {
}
});
it('uses the xcuitest home prefetched without installing', async () => {
writePreparedHome();
const info = jest.fn();
const result = await installAppiumAsync({
versionSpec: '^3',
driverName: 'xcuitest',
env: { EXISTING: 'value' },
logger: { info } as never,
});
expect(jest.mocked(spawn).mock.calls).toEqual([
[
preparedBin,
driverList,
{ env: { EXISTING: 'value', APPIUM_HOME: preparedHome }, stdio: 'pipe' },
],
]);
expect(info).toHaveBeenCalledWith(
'Using the prefetched Appium home (appium 3.9.0, xcuitest 12.22.8).'
);
expect(result).toEqual({
appiumHome: preparedHome,
appiumBinPath: preparedBin,
appiumEnv: { EXISTING: 'value', APPIUM_HOME: preparedHome },
prepared: true,
});
const env = { EAS_OVERRIDE_PACKAGE_MANAGER: 'nope' };
const expected = (() => {
try {
resolveConfiguredPackageManager(env, PackageManager.NPM);
} catch (error) {
return error;
}
})();
const onError = jest.fn();
await expect(
installAppiumAsync({ versionSpec: '^3', driverName: 'xcuitest', env, logger, onError })
).rejects.toEqual(expected);
expect(onError).toHaveBeenCalledWith(expected);
expect(jest.mocked(spawn).mock.calls.map(([, args]) => args)).toEqual([driverList, driverList]);
});
it('reuses WDA with binary bundle metadata', async () => {
writePreparedHome();
fs.writeFileSync(
path.join(preparedRunner, 'Info.plist'),
Buffer.from(
'YnBsaXN0MDDRAQJfEBJDRkJ1bmRsZUV4ZWN1dGFibGVWUnVubmVyCAsgAAAAAAAAAQEAAAAAAAAAAwAAAAAAAAAAAAAAAAAAACc=',
'base64'
)
);
const result = await installAppiumAsync({
versionSpec: '^3',
driverName: 'xcuitest',
env: {},
logger,
});
expect(result.prepared).toBe(true);
});
it.each([
['a version spec it does not satisfy', { versionSpec: '3.5.0' }, () => {}],
['the uiautomator2 driver', { driverName: 'uiautomator2' as const }, () => {}],
['no prepared.json', {}, () => fs.rmSync(preparedManifest)],
['an invalid prepared.json', {}, () => fs.writeFileSync(preparedManifest, 'not json')],
['a prepared.json without xcuitest', {}, () => writePreparedManifest({ version: '3.9.0' })],
[
'an older per-tool manifest',
{},
() => {
fs.rmSync(preparedManifest);
fs.writeFileSync(
path.join(preparedHome, 'prepared.json'),
JSON.stringify({
appium: '3.9.0',
xcuitest: '12.22.8',
home: preparedHome,
})
);
},
],
[
'a home prepared at another path',
{},
() =>
writePreparedManifest({
version: '3.9.0',
xcuitest: '12.22.8',
home: '/Users/other/appium',
}),
],
['another installed Appium', {}, () => writeInstalledVersion('appium', '2.19.0')],
[
'another installed xcuitest driver',
{},
() => writeInstalledVersion('appium-xcuitest-driver', '12.0.0'),
],
[
'no xcuitest driver',
{},
() =>
fs.rmSync(path.join(preparedHome, 'node_modules', 'appium-xcuitest-driver'), {
recursive: true,
}),
],
['no runner', {}, () => fs.rmSync(preparedRunner, { recursive: true })],
['no runner metadata', {}, () => fs.rmSync(path.join(preparedRunner, 'Info.plist'))],
[
'invalid runner metadata',
{},
() => fs.writeFileSync(path.join(preparedRunner, 'Info.plist'), 'invalid'),
],
['no runner executable', {}, () => fs.rmSync(path.join(preparedRunner, 'Runner'))],
[
'a non-executable runner binary',
{},
() => fs.chmodSync(path.join(preparedRunner, 'Runner'), 0o644),
],
['an empty runner binary', {}, () => fs.writeFileSync(path.join(preparedRunner, 'Runner'), '')],
[
'a directory as runner binary',
{},
() => {
fs.rmSync(path.join(preparedRunner, 'Runner'));
fs.mkdirSync(path.join(preparedRunner, 'Runner'));
},
],
[
'an executable outside the bundle',
{},
() =>
fs.writeFileSync(
path.join(preparedRunner, 'Info.plist'),
plist.build({ CFBundleExecutable: '../outside' })
),
],
['an unreadable runner', {}, () => fs.chmodSync(preparedRunner, 0o000)],
[
'a runner that is a file',
{},
() => {
fs.rmSync(preparedRunner, { recursive: true });
// Readable and executable, so only the directory check rejects it.
fs.writeFileSync(preparedRunner, '', { mode: 0o755 });
},
],
])('installs as before for %s', async (_name, options, breakHome) => {
writePreparedHome();
breakHome();
const before = vol.toJSON(preparedHome);
const versionSpec = 'versionSpec' in options ? options.versionSpec : '^3';
const resolveRequestedVersionAsync = jest.fn(async () => {
throw new Error('registry unavailable');
});
const result = await installAppiumAsync({
versionSpec,
resolveRequestedVersionAsync,
driverName: 'driverName' in options ? options.driverName : 'xcuitest',
env: {},
logger,
});
try {
expect(spawn).toHaveBeenNthCalledWith(
1,
'npm',
['install', '--no-audit', `appium@${versionSpec}`],
expect.objectContaining({ cwd: result.appiumHome })
);
expect(path.basename(result.appiumHome)).toMatch(/^eas-appium-home-/);
expect(result.prepared).toBe(false);
expect(resolveRequestedVersionAsync).not.toHaveBeenCalled();
expect(vol.toJSON(preparedHome)).toEqual(before);
} finally {
await fs.promises.rm(result.appiumHome, { recursive: true, force: true });
}
});
it.each([
['a driver list without xcuitest', async () => ({ stdout: '{}' })],
['a failed driver list', async () => Promise.reject(new Error('appium exited with 1.'))],
])('installs as before after %s in the prepared home', async (_name, list) => {
writePreparedHome();
jest.mocked(spawn).mockImplementationOnce(list as never);
const before = vol.toJSON(preparedHome);
const result = await installAppiumAsync({
versionSpec: '^3',
driverName: 'xcuitest',
env: {},
logger,
});
try {
expect(jest.mocked(spawn).mock.calls.slice(0, 2)).toEqual([
[preparedBin, driverList, expect.objectContaining({ stdio: 'pipe' })],
[
'npm',
['install', '--no-audit', 'appium@^3'],
expect.objectContaining({ cwd: result.appiumHome }),
],
]);
expect(result.prepared).toBe(false);
expect(vol.toJSON(preparedHome)).toEqual(before);
} finally {
await fs.promises.rm(result.appiumHome, { recursive: true, force: true });
}
});
it('kills the prepared-home driver list on a stop and installs nothing', async () => {
writePreparedHome();
const before = vol.toJSON(preparedHome);
const controller = new AbortController();
const failure = new Error('session stopped');
const child = { pid: 4242, kill: jest.fn() };
let finishList!: (error: Error) => void;
let listStarted!: () => void;
const started = new Promise<void>(resolve => {
listStarted = resolve;
});
jest.mocked(spawn).mockImplementationOnce(() => {
listStarted();
return Object.assign(
new Promise((_resolve, reject) => {
finishList = reject;
}),
{ child }
) as never;
});
const killGroup = jest.spyOn(processes, 'killProcessGroup').mockImplementation(() => {});
const running = installAppiumAsync({
versionSpec: '^3',
driverName: 'xcuitest',
env: {},
logger,
signal: controller.signal,
});
running.catch(() => {});
try {
await started;
controller.abort(failure);
expect(killGroup).toHaveBeenCalledWith(child, 'SIGKILL');
finishList(new Error('killed'));
await expect(running).rejects.toBe(failure);
expect(spawn).toHaveBeenCalledTimes(1);
expect(vol.toJSON(preparedHome)).toEqual(before);
} finally {
finishList?.(new Error('test cleanup'));
killGroup.mockRestore();
}
});
it('installs Appium with bun add when EAS_OVERRIDE_PACKAGE_MANAGER is bun', async () => {
const result = await installAppiumAsync({
versionSpec: '3.5.0',
@@ -595,115 +302,6 @@ describe('createStartAppiumRemoteSessionBuildFunction', () => {
});
});
it.each(
[BuildRuntimePlatform.DARWIN, BuildRuntimePlatform.LINUX].flatMap(platform =>
['^3', '3.x'].map(version => [platform, version] as const)
)
)(
'starts cold Appium on %s with cached installer range %s and no registry lookup',
async (runtimePlatform, packageVersion) => {
// Android must ignore prepared XCUITest files too.
if (runtimePlatform === BuildRuntimePlatform.LINUX) {
writePreparedHome();
}
jest.mocked(spawn).mockImplementation((async (_command: string, args: string[]) => {
if (args[0] === 'view') {
throw new Error('registry unavailable');
}
return { stdout: '{}' };
}) as never);
jest
.mocked(IosSimulatorUtils.getAvailableDevicesAsync)
.mockResolvedValue([{ udid: 'simulator' }] as never);
jest
.mocked(AndroidEmulatorUtils.getAttachedDevicesAsync)
.mockResolvedValue([{ serialId: 'emulator-5554', state: 'device' }] as never);
const launched = new Error('launch captured');
jest.mocked(spawnDetached).mockImplementation(() => {
throw launched;
});
const buildFunction = createStartAppiumRemoteSessionBuildFunction({} as CustomBuildContext);
await expect(
buildFunction.fn!(
{ logger, global: { runtimePlatform } } as unknown as BuildStepContext,
{
inputs: {
package_version: { value: packageVersion },
max_idle_time_minutes: { value: undefined },
},
outputs: {},
env: {
DEVICE_RUN_SESSION_ID: 'session',
EAS_SIMULATOR_NGROK_TUNNEL_DOMAIN: 'example.test',
NGROK_AUTHTOKEN: 'token',
EAS_OVERRIDE_PACKAGE_MANAGER: 'bun',
},
} as never
)
).rejects.toBe(launched);
expect(jest.mocked(spawn).mock.calls.some(([, args]) => args[0] === 'view')).toBe(false);
expect(spawn).toHaveBeenCalledWith(
'bun',
['add', `appium@${packageVersion}`],
expect.anything()
);
}
);
it.each(
['latest', '^3', '3.x'].flatMap(requested =>
['3.9.0', '3.10.0'].map(latest => [requested, latest])
)
)('checks %s before using the prepared Appium version (%s)', async (requested, latest) => {
writePreparedHome();
const before = vol.toJSON(preparedHome);
jest.mocked(spawn).mockImplementation((async (command: string, args: string[]) => ({
stdout:
args[0] === 'view'
? JSON.stringify(latest)
: args.includes('--json')
? driverListStdout(command)
: '',
})) as never);
jest
.mocked(IosSimulatorUtils.getAvailableDevicesAsync)
.mockResolvedValue([{ udid: 'simulator' }] as never);
const launched = new Error('launch captured');
jest.mocked(spawnDetached).mockImplementation(() => {
throw launched;
});
const buildFunction = createStartAppiumRemoteSessionBuildFunction({} as CustomBuildContext);
await expect(
buildFunction.fn!(
{
logger,
global: { runtimePlatform: BuildRuntimePlatform.DARWIN },
} as unknown as BuildStepContext,
{
inputs: {
package_version: { value: requested },
max_idle_time_minutes: { value: undefined },
},
outputs: {},
env: {
DEVICE_RUN_SESSION_ID: 'session',
EAS_SIMULATOR_NGROK_TUNNEL_DOMAIN: 'example.test',
NGROK_AUTHTOKEN: 'token',
},
} as never
)
).rejects.toBe(launched);
const installs = jest.mocked(spawn).mock.calls.filter(([, args]) => args[0] === 'install');
if (latest === '3.9.0') {
expect(installs).toHaveLength(0);
expect(jest.mocked(spawnDetached).mock.calls[0][0].env.APPIUM_HOME).toBe(preparedHome);
} else {
expect(installs).toHaveLength(1);
expect(installs[0][1]).toContain('[email protected]');
}
expect(vol.toJSON(preparedHome)).toEqual(before);
});
it('claims the warm Simulator for Appium without its package version', async () => {
jest.mocked(runOnWarmIosSimulatorAsync).mockResolvedValue(undefined);
const buildFunction = createStartAppiumRemoteSessionBuildFunction({} as CustomBuildContext, {
@@ -771,8 +369,8 @@ describe('createStartAppiumRemoteSessionBuildFunction session lifecycle', () =>
runtime: 'com.apple.CoreSimulator.SimRuntime.iOS-26-5',
state: 'Shutdown',
} as never);
jest.mocked(spawn).mockImplementation((async (command: string, args: string[]) => ({
stdout: args.includes('--json') ? driverListStdout(command) : '',
jest.mocked(spawn).mockImplementation((async (_command: string, args: string[]) => ({
stdout: args.includes('--json') ? '{}' : '',
})) as never);
jest
.mocked(AndroidEmulatorUtils.getAttachedDevicesAsync)
@@ -1027,73 +625,6 @@ describe('createStartAppiumRemoteSessionBuildFunction session lifecycle', () =>
return stopWarm;
}
it.each(['cancelled lookup', 'AbortError lookup', 'resolved lookup'])(
'recovers from failed warm adoption with a %s',
async stage => {
writePreparedHome();
const stopWarm = mockWarmSession();
stopAppium.mockResolvedValue(undefined);
const adoptionError = new WarmSessionAdoptionError();
let failHost!: (error: Error) => void;
jest.mocked(startDeviceSessionHostAsync).mockReturnValueOnce(
new Promise((_resolve, reject) => {
failHost = reject;
})
);
let lookups = 0;
jest.mocked(spawn).mockImplementation((async (command, args, options) => {
if (args[0] !== 'view') {
return { stdout: args.includes('--json') ? driverListStdout(command) : '' };
}
lookups++;
if (lookups === 1 && stage !== 'resolved lookup') {
return await new Promise((_resolve, reject) => {
options!.signal!.addEventListener(
'abort',
() => {
reject(
stage === 'AbortError lookup'
? new DOMException('Aborted', 'AbortError')
: options!.signal!.reason
);
},
{ once: true }
);
failHost(adoptionError);
});
}
return { stdout: JSON.stringify('3.9.0') };
}) as typeof spawn);
if (stage === 'resolved lookup') {
const process = jest.mocked(spawnDetached).getMockImplementation()!;
jest.mocked(spawnDetached).mockImplementationOnce(options => {
failHost(adoptionError);
return process(options);
});
}
await expect(
runSessionAsync(
logger,
undefined,
BuildRuntimePlatform.DARWIN,
{
boot_simulator: { value: true },
device_identifier: { value: 'iPhone 17' },
package_version: { value: '^3' },
},
true
)
).resolves.toBeUndefined();
expect(lookups).toBe(stage === 'resolved lookup' ? 1 : 2);
expect(stopWarm).toHaveBeenCalledTimes(1);
expect(startDeviceSessionHostAsync).toHaveBeenCalledTimes(2);
expect(spawnDetached).toHaveBeenCalledTimes(stage === 'resolved lookup' ? 2 : 1);
expect(fs.existsSync(preparedRunner)).toBe(true);
}
);
it.each(['event collection', 'Appium process'])(
'waits for warm %s teardown before finishing the session host',
async stage => {
@@ -1571,31 +1102,6 @@ describe('createStartAppiumRemoteSessionBuildFunction session lifecycle', () =>
);
});
it('a Darwin session uses the prepared Appium home and keeps it', async () => {
stopAppium.mockResolvedValue(undefined);
writePreparedHome();
jest.mocked(IosSimulatorUtils.getAvailableDevicesAsync).mockResolvedValue([
{
udid: 'chosen-ios-udid',
runtime: 'com.apple.CoreSimulator.SimRuntime.iOS-26-4',
} as never,
]);
await runSessionAsync(
{ info: jest.fn(), warn: jest.fn() },
undefined,
BuildRuntimePlatform.DARWIN
);
expect(jest.mocked(spawnDetached).mock.calls[0][0].env.APPIUM_HOME).toBe(preparedHome);
expect(preparePreinstalledWdaAsync).toHaveBeenCalledWith(
expect.objectContaining({ appiumHome: preparedHome, prepared: true })
);
expect(jest.mocked(spawn).mock.calls.map(([command, args]) => [command, args])).toEqual([
[preparedBin, driverList],
]);
expect(stopAppium).toHaveBeenCalledTimes(1);
expect(fs.existsSync(preparedManifest)).toBe(true);
});
it('starts serve-sim on the selected iOS device while Appium installation is pending', async () => {
stopAppium.mockResolvedValue(undefined);
jest.mocked(selectXcodeDeveloperDirectoryAsync).mockClear();
@@ -322,29 +322,6 @@ describe('createStartArgentRemoteSessionBuildFunction orchestration', () => {
expect(uploadRemoteSessionConfigAsync).not.toHaveBeenCalled();
});
it('uses the resolved Argent version after a warm mismatch', async () => {
jest
.mocked(runOnWarmIosSimulatorAsync)
.mockImplementation((_claim, run) => run(undefined, '999.1.0'));
await createStartArgentRemoteSessionBuildFunction({} as CustomBuildContext, { warm: true }).fn!(
{
logger: { info: jest.fn(), warn: jest.fn(), child: jest.fn().mockReturnThis() },
global: { runtimePlatform: BuildRuntimePlatform.DARWIN },
} as never,
{
inputs: {
package_version: { value: 'latest' },
max_idle_time_minutes: { value: undefined },
},
outputs: {},
env: {},
} as never
);
expect(spawnDetached).toHaveBeenCalledWith(
expect.objectContaining({ args: expect.arrayContaining(['@swmansion/[email protected]']) })
);
});
it('keeps watching startup when warm adoption retries cold', async () => {
const ctx = {} as CustomBuildContext;
const logger = { info: jest.fn(), warn: jest.fn(), child: jest.fn().mockReturnThis() };
@@ -1,51 +1,11 @@
import {
ArchiveSourceType,
EnvironmentSecretType,
SystemError,
UserError,
} from '@expo/eas-build-job';
import fetch from 'node-fetch';
import { SystemError, UserError } from '@expo/eas-build-job';
import { Client, fetchExchange } from '@urql/core';
import { stripRepositoryCredentialsAsync } from '../../../common/git';
import * as sandboxDaemon from '../../utils/sandboxDaemon';
import { SandboxWorkerApi } from '../../utils/sandboxWorkerApi';
import { createStartSandboxBuildFunction } from '../startSandbox';
const { AbortError, Response } = jest.requireActual('node-fetch') as typeof import('node-fetch');
jest.mock('../../../common/git');
const checkedOutStepCtx = { logger: {}, global: { wasCheckedOut: () => true } } as any;
const notCheckedOutStepCtx = { logger: {}, global: { wasCheckedOut: () => false } } as any;
const URL_JOB = {
projectArchive: { type: ArchiveSourceType.URL, url: 'https://example.com/project.tar.gz' },
};
const context = {
job: {
...URL_JOB,
secrets: {
environmentSecrets: [
{
name: 'EAS_SANDBOX_WORKER_TOKEN',
type: EnvironmentSecretType.STRING,
value: 'worker-token',
},
],
},
},
env: {},
expoApiV2BaseUrl: 'https://api.expo.test/v2/',
mcpServerUrl: 'ws://localhost:8787',
};
const inputs = { sandbox_id: { value: 'sandbox-id' } };
import { createStartSandboxBuildFunction, markSandboxReadyAsync } from '../startSandbox';
describe('sandbox build functions', () => {
afterEach(() => {
jest.restoreAllMocks();
});
it.each([
{ completion: 'duration', duration: 0.02 },
{ completion: 'cancellation', duration: 60 },
@@ -56,41 +16,49 @@ describe('sandbox build functions', () => {
const controller = new AbortController();
let ready!: () => void;
const stopAsync = jest.fn(async () => {});
jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync').mockResolvedValue({
const start = jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync').mockResolvedValue({
ready: new Promise<void>(resolve => {
ready = resolve;
}),
stopAsync,
});
const markReady = jest
.spyOn(SandboxWorkerApi.prototype, 'markReadyAsync')
.mockResolvedValue(undefined);
const mutation = jest.fn(() => ({ toPromise: async () => ({ data: {} }) }));
const logger = { info: jest.fn(), child: jest.fn() };
logger.child.mockReturnValue(logger);
const fn = createStartSandboxBuildFunction(context as any);
const pending = fn.fn!({ logger } as any, {
inputs: { ...inputs, max_duration_seconds: { value: duration } },
outputs: {},
env: {},
signal: controller.signal,
});
await new Promise(resolve => setTimeout(resolve, 40));
expect(markReady).not.toHaveBeenCalled();
expect(stopAsync).not.toHaveBeenCalled();
ready();
if (completion === 'cancellation') {
await new Promise(resolve => setImmediate(resolve));
const fn = createStartSandboxBuildFunction({
mcpServerUrl: 'ws://localhost:8787',
graphqlClient: { mutation },
} as any);
try {
const pending = fn.fn!({ logger } as any, {
inputs: {
sandbox_id: { value: 'sandbox-id' },
max_duration_seconds: { value: duration },
},
outputs: {},
env: { __EAS_SANDBOX_MCP_TOKEN: 'token' },
signal: controller.signal,
});
await new Promise(resolve => setTimeout(resolve, 40));
expect(mutation).not.toHaveBeenCalled();
expect(stopAsync).not.toHaveBeenCalled();
controller.abort();
}
await pending;
expect(markReady).toHaveBeenCalledTimes(1);
expect(stopAsync).toHaveBeenCalledTimes(1);
const timeoutMessage = `Sandbox reached its maximum runtime of ${duration} seconds. Stopping.`;
if (completion === 'duration') {
expect(logger.info).toHaveBeenCalledWith(timeoutMessage);
} else {
expect(logger.info).not.toHaveBeenCalledWith(timeoutMessage);
ready();
if (completion === 'cancellation') {
await new Promise(resolve => setImmediate(resolve));
expect(stopAsync).not.toHaveBeenCalled();
controller.abort();
}
await pending;
expect(mutation).toHaveBeenCalledTimes(1);
expect(stopAsync).toHaveBeenCalledTimes(1);
const timeoutMessage = `Sandbox reached its maximum runtime of ${duration} seconds. Stopping.`;
if (completion === 'duration') {
expect(logger.info).toHaveBeenCalledWith(timeoutMessage);
} else {
expect(logger.info).not.toHaveBeenCalledWith(timeoutMessage);
}
} finally {
start.mockRestore();
}
}
);
@@ -99,221 +67,177 @@ describe('sandbox build functions', () => {
'rejects invalid maximum duration %s before starting the daemon',
async duration => {
const start = jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync');
const fn = createStartSandboxBuildFunction(context as any);
const result = fn.fn!({} as any, {
inputs: { ...inputs, max_duration_seconds: { value: duration } },
outputs: {},
env: {},
});
await expect(result).rejects.toBeInstanceOf(UserError);
await expect(result).rejects.toThrow(
`Invalid sandbox maximum duration: ${duration}. Provide a finite number greater than zero, or omit max_duration_seconds.`
);
expect(start).not.toHaveBeenCalled();
const fn = createStartSandboxBuildFunction({
mcpServerUrl: 'ws://localhost:8787',
} as any);
try {
const result = fn.fn!({} as any, {
inputs: {
sandbox_id: { value: 'sandbox-id' },
max_duration_seconds: { value: duration },
},
outputs: {},
env: { __EAS_SANDBOX_MCP_TOKEN: 'token' },
});
await expect(result).rejects.toBeInstanceOf(UserError);
await expect(result).rejects.toThrow(
`Invalid sandbox maximum duration: ${duration}. Provide a finite number greater than zero, or omit max_duration_seconds.`
);
expect(start).not.toHaveBeenCalled();
} finally {
start.mockRestore();
}
}
);
it('connects with the worker token from the job secrets, which the step env does not have', async () => {
const env = { PREPARED_BY_EARLIER_STEP: 'value' };
const startupError = new Error('stop after checking options');
const start = jest
.spyOn(sandboxDaemon, 'startSandboxDaemonAsync')
.mockRejectedValue(startupError);
const fn = createStartSandboxBuildFunction(context as any);
await expect(fn.fn!({ logger: {} } as any, { inputs, outputs: {}, env })).rejects.toBe(
startupError
);
expect(start.mock.calls[0][0]).toMatchObject({ credential: 'worker-token', env });
});
it('does not mark the sandbox ready if startup was canceled', async () => {
it('aborts an active ready request and keeps its authentication headers', async () => {
const controller = new AbortController();
const stopAsync = jest.fn(async () => {});
jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync').mockImplementation(async options => {
expect(options.signal).toBe(controller.signal);
controller.abort();
return { ready: Promise.resolve(), stopAsync };
});
const fn = createStartSandboxBuildFunction(context as any);
await expect(
fn.fn!({ logger: {} } as any, { inputs, outputs: {}, env: {}, signal: controller.signal })
).rejects.toMatchObject({ name: 'AbortError' });
expect(fetch).not.toHaveBeenCalled();
expect(stopAsync).toHaveBeenCalledTimes(1);
});
it('marks the sandbox ready with only the worker token and aborts the request when canceled', async () => {
const controller = new AbortController();
const stopAsync = jest.fn(async () => {});
jest
.spyOn(sandboxDaemon, 'startSandboxDaemonAsync')
.mockResolvedValue({ ready: Promise.resolve(), stopAsync });
let requestStarted!: () => void;
const started = new Promise<void>(resolve => {
requestStarted = resolve;
});
jest.mocked(fetch).mockImplementationOnce(async (url, init) => {
expect(url).toBe('https://api.expo.test/v2/sandbox-worker/ready');
expect(init?.headers).toEqual({ 'expo-sandbox-worker-token': 'worker-token' });
return await new Promise((_resolve, reject) => {
init!.signal!.addEventListener('abort', () => reject(new AbortError('Aborted')));
const fetchMock = jest.spyOn(globalThis, 'fetch').mockImplementation(async (_input, init) => {
expect(new Headers(init?.headers).get('Authorization')).toBe('Bearer test-token');
return await new Promise<Response>((_resolve, reject) => {
init!.signal!.addEventListener('abort', () => reject(init!.signal!.reason), { once: true });
requestStarted();
});
});
const fn = createStartSandboxBuildFunction(context as any);
const pending = fn.fn!({ logger: {} } as any, {
inputs,
outputs: {},
env: {},
signal: controller.signal,
const graphqlClient = new Client({
url: 'https://api.expo.test/graphql',
exchanges: [fetchExchange],
fetchOptions: { headers: { Authorization: 'Bearer test-token' } },
});
const rejected = expect(pending).rejects.toMatchObject({ name: 'AbortError' });
await started;
controller.abort();
await rejected;
expect(stopAsync).toHaveBeenCalledTimes(1);
try {
const pending = markSandboxReadyAsync(
{ graphqlClient } as any,
'sandbox-id',
controller.signal
);
const rejected = expect(pending).rejects.toMatchObject({ name: 'AbortError' });
await started;
controller.abort();
await rejected;
} finally {
fetchMock.mockRestore();
}
});
it('throws a system error and stops the daemon when readiness fails', async () => {
it('does not mark the sandbox ready if startup was canceled', async () => {
const controller = new AbortController();
const stopAsync = jest.fn(async () => {});
jest
const start = jest
.spyOn(sandboxDaemon, 'startSandboxDaemonAsync')
.mockResolvedValue({ ready: Promise.resolve(), stopAsync });
jest.mocked(fetch).mockResolvedValueOnce(
new Response(JSON.stringify({ errors: [{ message: 'Sandbox has stopped.' }] }), {
status: 400,
})
);
const fn = createStartSandboxBuildFunction(context as any);
const result = fn.fn!({ logger: {} } as any, { inputs, outputs: {}, env: {} });
await expect(result).rejects.toBeInstanceOf(SystemError);
await expect(result).rejects.toMatchObject({
message: 'Failed to mark sandbox sandbox-id as ready.',
cause: expect.objectContaining({ status: 400 }),
});
expect(stopAsync).toHaveBeenCalledTimes(1);
.mockImplementation(async options => {
expect(options.signal).toBe(controller.signal);
controller.abort();
return { ready: Promise.resolve(), stopAsync };
});
const mutation = jest.fn();
const fn = createStartSandboxBuildFunction({
env: { __EAS_SANDBOX_MCP_TOKEN: 'token' },
mcpServerUrl: 'ws://localhost:8787',
graphqlClient: { mutation },
} as any);
try {
await expect(
fn.fn!({ logger: {} } as any, {
inputs: { sandbox_id: { value: 'sandbox-id' } },
outputs: {},
env: { __EAS_SANDBOX_MCP_TOKEN: 'token' },
signal: controller.signal,
})
).rejects.toMatchObject({ name: 'AbortError' });
expect(mutation).not.toHaveBeenCalled();
expect(stopAsync).toHaveBeenCalledTimes(1);
} finally {
start.mockRestore();
}
});
it('strips the repository credentials before starting the daemon for git sources', async () => {
it('excludes the MCP token from the command environment', async () => {
const env = {
PREPARED_BY_EARLIER_STEP: 'value',
EXPO_TOKEN: 'expo-token',
__EAS_SANDBOX_MCP_TOKEN: 'token',
};
const startupError = new Error('stop after checking options');
const start = jest
.spyOn(sandboxDaemon, 'startSandboxDaemonAsync')
.mockRejectedValue(startupError);
const fn = createStartSandboxBuildFunction({
...context,
job: {
...context.job,
projectArchive: {
type: ArchiveSourceType.GIT,
gitRef: 'refs/heads/main',
gitCommitHash: '0123456789abcdef0123456789abcdef01234567',
},
},
projectTargetDirectory: '/workingdir/build',
env: { __EAS_SANDBOX_MCP_TOKEN: 'token' },
mcpServerUrl: 'ws://localhost:8787',
} as any);
await expect(fn.fn!(checkedOutStepCtx, { inputs, outputs: {}, env: {} })).rejects.toBe(
startupError
);
expect(stripRepositoryCredentialsAsync).toHaveBeenCalledWith({
repositoryDirectory: '/workingdir/build',
});
expect(jest.mocked(stripRepositoryCredentialsAsync).mock.invocationCallOrder[0]).toBeLessThan(
start.mock.invocationCallOrder[0]
);
try {
await expect(
fn.fn!({ logger: {} } as any, {
inputs: { sandbox_id: { value: 'sandbox-id' } },
outputs: {},
env,
})
).rejects.toBe(startupError);
expect(start.mock.calls[0][0]).toMatchObject({ credential: 'token' });
expect(start.mock.calls[0][0].env).toEqual({
PREPARED_BY_EARLIER_STEP: 'value',
EXPO_TOKEN: 'expo-token',
});
expect(env.__EAS_SANDBOX_MCP_TOKEN).toBe('token');
} finally {
start.mockRestore();
}
});
it('strips the repository credentials from the source directory before eas/checkout', async () => {
const startupError = new Error('stop after checking options');
jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync').mockRejectedValue(startupError);
it('throws a system error when the sandbox token is missing', async () => {
const fn = createStartSandboxBuildFunction({
...context,
job: {
...context.job,
projectArchive: {
type: ArchiveSourceType.GIT,
gitRef: null,
gitCommitHash: '0123456789abcdef0123456789abcdef01234567',
},
},
projectSourceDirectory: '/workingdir/temporary-custom-build',
projectTargetDirectory: '/workingdir/build',
job: {},
env: {},
mcpServerUrl: 'ws://localhost:8787',
} as any);
await expect(fn.fn!(notCheckedOutStepCtx, { inputs, outputs: {}, env: {} })).rejects.toBe(
startupError
);
expect(stripRepositoryCredentialsAsync).toHaveBeenCalledWith({
repositoryDirectory: '/workingdir/temporary-custom-build',
});
await expect(
fn.fn!({} as any, {
inputs: { sandbox_id: { value: 'sandbox-id' } },
outputs: {},
env: {},
})
).rejects.toBeInstanceOf(SystemError);
});
it('does not start the daemon when stripping the repository credentials fails', async () => {
const stripError = new SystemError('Failed to strip credentials from the origin remote URL.');
jest.mocked(stripRepositoryCredentialsAsync).mockRejectedValueOnce(stripError);
const start = jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync');
it('throws a system error when the MCP server URL is missing', async () => {
const fn = createStartSandboxBuildFunction({
...context,
job: {
...context.job,
projectArchive: {
type: ArchiveSourceType.GIT,
gitRef: null,
gitCommitHash: '0123456789abcdef0123456789abcdef01234567',
},
},
projectTargetDirectory: '/workingdir/build',
job: {},
env: { __EAS_SANDBOX_MCP_TOKEN: 'sandbox-token' },
} as any);
await expect(fn.fn!(checkedOutStepCtx, { inputs, outputs: {}, env: {} })).rejects.toBe(
stripError
);
expect(start).not.toHaveBeenCalled();
await expect(
fn.fn!({} as any, {
inputs: { sandbox_id: { value: 'sandbox-id' } },
outputs: {},
env: { __EAS_SANDBOX_MCP_TOKEN: 'sandbox-token' },
})
).rejects.toThrow('MCP server URL is required to start the sandbox daemon.');
});
it('leaves the remote alone for non-git sources', async () => {
const startupError = new Error('stop after checking options');
jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync').mockRejectedValue(startupError);
const fn = createStartSandboxBuildFunction({
...context,
projectTargetDirectory: '/workingdir/build',
} as any);
it('marks the sandbox as ready', async () => {
const mutation = jest.fn(() => ({
toPromise: async () => ({ data: { sandbox: { markSandboxReady: { id: 'sandbox-id' } } } }),
}));
await expect(fn.fn!({ logger: {} } as any, { inputs, outputs: {}, env: {} })).rejects.toBe(
startupError
await markSandboxReadyAsync({ graphqlClient: { mutation } } as any, 'sandbox-id');
expect(mutation).toHaveBeenCalledWith(
expect.anything(),
{ sandboxId: 'sandbox-id' },
undefined
);
expect(stripRepositoryCredentialsAsync).not.toHaveBeenCalled();
});
it.each([
{
missing: 'the sandbox worker token',
overrides: { job: {} },
message: 'This sandbox job has no EAS_SANDBOX_WORKER_TOKEN secret.',
},
{
missing: 'the MCP server URL',
overrides: { mcpServerUrl: undefined },
message: 'MCP server URL is required to start the sandbox daemon.',
},
{
missing: 'the API server URL',
overrides: { expoApiV2BaseUrl: undefined },
message: 'The API server URL is not set',
},
])('throws a system error without $missing', async ({ overrides, message }) => {
const start = jest.spyOn(sandboxDaemon, 'startSandboxDaemonAsync');
const fn = createStartSandboxBuildFunction({ ...context, ...overrides } as any);
it('throws a system error when marking the sandbox as ready fails', async () => {
const mutation = jest.fn(() => ({
toPromise: async () => ({ error: new Error('request failed') }),
}));
const result = fn.fn!({} as any, { inputs, outputs: {}, env: {} });
await expect(result).rejects.toBeInstanceOf(SystemError);
await expect(result).rejects.toThrow(message);
expect(start).not.toHaveBeenCalled();
await expect(
markSandboxReadyAsync({ graphqlClient: { mutation } } as any, 'sandbox-id')
).rejects.toThrow('Failed to mark sandbox sandbox-id as ready.');
});
});
@@ -224,20 +224,6 @@ describe(createStartWebPreviewRemoteSessionBuildFunction, () => {
);
});
it('passes the resolved version to cold setup after a warm version mismatch', async () => {
jest
.mocked(runOnWarmIosSimulatorAsync)
.mockImplementation((_claim, run) => run(undefined, '0.14.0'));
await createStartWebPreviewRemoteSessionBuildFunction(ctx, { warm: true }).fn!(
{ logger, global: { runtimePlatform: BuildRuntimePlatform.DARWIN } } as never,
{ inputs: { package_version: { value: 'latest' } }, outputs: {}, env } as never
);
expect(startDeviceSessionHostAsync).toHaveBeenCalledWith(
ctx,
expect.objectContaining({ packageVersion: '0.14.0' })
);
});
it('uses preview activity to reset the configured idle timeout', async () => {
await runAsync(BuildRuntimePlatform.DARWIN, { max_idle_time_minutes: { value: 5 } });
const { idleTimeout } = jest.mocked(waitForDeviceRunSessionStoppedAsync).mock.calls[0][0];
@@ -35,9 +35,9 @@ import { retryOnNetworkFailureAsync } from '../../utils/retryOnNetworkFailure';
import { pluralize } from '../../utils/strings';
import {
type DeviceRunSessionWorkerApi,
DeviceRunSessionWorkerApiError,
getDeviceRunSessionWorkerApi,
} from '../utils/deviceRunSessionWorkerApi';
import { WorkerApiError } from '../utils/workerApi';
const streamPipeline = promisify(stream.pipeline);
@@ -219,7 +219,7 @@ async function fetchDeviceRunSessionApplicationArchiveUrlAsync({
{
operation: 'download_build.session_build_lookup',
signal,
isRetryable: error => error instanceof WorkerApiError && error.isTransient,
isRetryable: error => error instanceof DeviceRunSessionWorkerApiError && error.isTransient,
}
);
} catch (err) {
@@ -16,8 +16,8 @@ import {
AndroidVirtualDeviceName,
} from '../../utils/AndroidEmulatorUtils';
import { watchDeviceRunSessionStartup } from '../utils/deviceRunSessionStartup';
import { AndroidEmulatorLogSourcesSchema } from '../../utils/androidEmulatorLogSources';
import { getAndroidEmulatorLogCapture } from '../utils/androidEmulatorLogs';
import { parseLogSourcesInput } from '../utils/logSourcesInput';
import { getDeviceRunSessionWorkerApi } from '../utils/deviceRunSessionWorkerApi';
import { readIosApplicationIdentifierAsync } from '../utils/iosAppArtifact';
import { resolveIosSessionStartupAsync } from '../utils/iosSimulatorSession';
@@ -73,10 +73,10 @@ export function createStartAgentDeviceSessionBuildFunction(
name: 'Start agent-device session',
__metricsId: warm ? 'eas/start_warm_agent_device_session' : 'eas/start_agent_device_session',
inputProviders: [
// No default: an omitted input must stay distinguishable from an explicit selection.
BuildStepInput.createProvider({
id: 'log_sources',
id: 'android_log_sources',
required: false,
defaultValue: ['emulator-output'],
allowedValueTypeName: BuildStepInputValueTypeName.JSON,
}),
// Device. On iOS a Simulator name or UDID, on Android an AVD hardware profile.
@@ -196,10 +196,9 @@ export function createStartAgentDeviceSessionBuildFunction(
} else {
validateAndroidLaunchOptions({ launchArgs, openUrl });
}
const logSources = parseLogSourcesInput(inputs.log_sources.value, {
runtimePlatform,
fallback: isIos ? [] : ['emulator-output'],
});
const logSources = isIos
? []
: AndroidEmulatorLogSourcesSchema.parse(inputs.android_log_sources.value);
const deviceIdentifier = inputs.device_identifier.value as string | undefined;
const capture = parseNetworkCaptureInputs(
{
@@ -217,10 +216,7 @@ export function createStartAgentDeviceSessionBuildFunction(
logger,
startup: { signal: startupSignal, abort: reason => startup.abort(reason) },
});
const startSessionAsync = async (
warmSession?: WarmIosSession,
resolvedPackageVersion = inputs.package_version.value as string | undefined
): Promise<void> => {
const startSessionAsync = async (warmSession?: WarmIosSession): Promise<void> => {
const tasks = createStartupTasks(logger, startupSignal);
let booted: Promise<void> | undefined;
let sessionOwnsTeardown = false;
@@ -268,7 +264,8 @@ export function createStartAgentDeviceSessionBuildFunction(
lcdHeight: inputs.lcd_height.value as number | undefined,
lcdDensity: inputs.lcd_density.value as number | undefined,
logcatDirectory,
logCapture: getAndroidEmulatorLogCapture(global, env, logSources),
logSources,
logCapture: getAndroidEmulatorLogCapture(global, env),
env,
logger: taskLogger,
});
@@ -354,7 +351,7 @@ export function createStartAgentDeviceSessionBuildFunction(
signal,
runtimePlatform,
sessionEnv,
packageVersion: resolvedPackageVersion,
packageVersion: inputs.package_version.value as string | undefined,
// A missing or non-positive value disables the idle timeout (opt-in feature).
maxIdleTimeMinutes: inputs.max_idle_time_minutes.value as number | undefined,
maxDurationSeconds: inputs.max_duration_seconds.value as number | undefined,
@@ -23,9 +23,12 @@ import {
import { type AndroidEmulatorLogCapture } from '../../utils/androidEmulatorLogCapture';
import { retryAsync } from '../../utils/retry';
import { resolveAndroidEmulatorLocalEgressAsync } from '../utils/androidLocalEgress';
import { ALL_ANDROID_EMULATOR_LOG_SOURCES } from '../../utils/androidEmulatorLogSources';
import {
ALL_ANDROID_EMULATOR_LOG_SOURCES,
type AndroidEmulatorLogSource,
AndroidEmulatorLogSourcesSchema,
} from '../../utils/androidEmulatorLogSources';
import { getAndroidEmulatorLogCapture } from '../utils/androidEmulatorLogs';
import { parseLogSourcesInput } from '../utils/logSourcesInput';
const ANDROID_STARTUP_ATTEMPT_TIMEOUT_MS = [60_000, 120_000, 180_000];
const ANDROID_STARTUP_RETRIES_COUNT = ANDROID_STARTUP_ATTEMPT_TIMEOUT_MS.length - 1;
@@ -38,7 +41,7 @@ export function createStartAndroidEmulatorBuildFunction(): BuildFunction {
__metricsId: 'eas/start_android_emulator',
inputProviders: [
BuildStepInput.createProvider({
id: 'log_sources',
id: 'android_log_sources',
required: false,
defaultValue: [...ALL_ANDROID_EMULATOR_LOG_SOURCES],
allowedValueTypeName: BuildStepInputValueTypeName.JSON,
@@ -89,14 +92,11 @@ export function createStartAndroidEmulatorBuildFunction(): BuildFunction {
}),
],
fn: async ({ logger, global }, { inputs, outputs, env }) => {
const logSources = parseLogSourcesInput(inputs.log_sources.value, {
runtimePlatform: global.runtimePlatform,
fallback: ALL_ANDROID_EMULATOR_LOG_SOURCES,
});
const logSources = AndroidEmulatorLogSourcesSchema.parse(inputs.android_log_sources.value);
const logcatDirectory = await fs.promises.mkdtemp(
path.join(os.tmpdir(), 'eas-android-emulator-logcat-')
);
const logCapture = getAndroidEmulatorLogCapture(global, env, logSources);
const logCapture = getAndroidEmulatorLogCapture(global, env);
outputs.logcat_directory.set(logcatDirectory);
const deviceName = `${inputs.device_name.value}` as AndroidVirtualDeviceName;
@@ -110,6 +110,7 @@ export function createStartAndroidEmulatorBuildFunction(): BuildFunction {
lcdHeight: inputs.lcd_height.value as number | undefined,
lcdDensity: inputs.lcd_density.value as number | undefined,
logcatDirectory,
logSources,
logCapture,
env,
logger,
@@ -149,6 +150,7 @@ export function createStartAndroidEmulatorBuildFunction(): BuildFunction {
deviceName: cloneIdentifier,
env,
logcatDirectory,
logSources,
logCapture,
});
cloneSerialId = startResult.serialId;
@@ -219,6 +221,7 @@ export async function startAndroidEmulatorAsync({
lcdHeight,
lcdDensity,
logcatDirectory,
logSources,
logCapture,
env,
logger,
@@ -230,6 +233,7 @@ export async function startAndroidEmulatorAsync({
lcdHeight?: number;
lcdDensity?: number;
logcatDirectory: string;
logSources: readonly AndroidEmulatorLogSource[];
logCapture: AndroidEmulatorLogCapture;
env: BuildStepEnv;
logger: bunyan;
@@ -312,6 +316,7 @@ export async function startAndroidEmulatorAsync({
deviceName,
env,
logcatDirectory,
logSources,
logCapture,
...(localEgress ? { launchGate: localEgress.launchGate } : {}),
});
@@ -14,8 +14,6 @@ import os from 'node:os';
import path from 'node:path';
import { setTimeout as setTimeoutAsync } from 'node:timers/promises';
import semver from 'semver';
import bplistParser from 'bplist-parser';
import plist from 'plist';
import { z } from 'zod';
import { type CustomBuildContext } from '../../customBuildContext';
@@ -45,8 +43,6 @@ import {
import { killProcessGroup } from '../../utils/processes';
import { sleepAsync } from '../../utils/retry';
import { turtleFetch } from '../../utils/turtleFetch';
import { resolveSimulatorPackageVersionAsync } from '../../utils/simulatorPackageVersion';
import { readPreparedSimulatorToolAsync } from '../../utils/warmSimulator';
import { startAppiumEventCollectionAsync } from '../utils/appiumEvents';
import { preparePreinstalledWdaAsync } from '../utils/preinstalledWda';
import { watchDeviceRunSessionStartup } from '../utils/deviceRunSessionStartup';
@@ -83,12 +79,6 @@ const AppiumInstalledDriversSchema = z.record(
z.string(),
z.object({ installed: z.boolean().optional() }).passthrough()
);
const PreparedAppiumSchema = z.object({
version: z.string(),
xcuitest: z.string(),
home: z.string(),
});
const PackageVersionSchema = z.object({ version: z.string() });
export function createStartAppiumRemoteSessionBuildFunction(
ctx: CustomBuildContext,
@@ -137,7 +127,6 @@ export function createStartAppiumRemoteSessionBuildFunction(
startup: { signal: watchSignal, abort: reason => startupStop.abort(reason) },
});
const deviceIdentifier = inputs.device_identifier?.value as string | undefined;
let requestedVersion: string | undefined;
const startSessionAsync = async (warmSession?: WarmIosSession): Promise<void> => {
const startupAbortController = new AbortController();
const startupSignal = AbortSignal.any([watchSignal, startupAbortController.signal]);
@@ -160,21 +149,7 @@ export function createStartAppiumRemoteSessionBuildFunction(
},
{ runtimePlatform }
);
const resolveRequestedVersionAsync =
packageVersion === undefined
? undefined
: async (): Promise<string> =>
(requestedVersion ??= await resolveSimulatorPackageVersionAsync(
'appium',
packageVersion,
{ env, signal: startupSignal }
));
// Keep cold ranges on the configured installer's path. Tags need resolution to enforce Appium 3.
const versionSpec = resolveAppium3VersionSpec(
packageVersion !== undefined && !semver.validRange(packageVersion)
? await resolveRequestedVersionAsync!()
: packageVersion
);
const versionSpec = resolveAppium3VersionSpec(packageVersion);
logger.info(
`Starting Appium remote session (version: ${versionSpec}, runtime: ${runtimePlatform}).`
@@ -236,7 +211,6 @@ export function createStartAppiumRemoteSessionBuildFunction(
asyncResult(
installAppiumAsync({
versionSpec,
resolveRequestedVersionAsync,
driverName: device.driverName,
env,
logger,
@@ -257,8 +231,7 @@ export function createStartAppiumRemoteSessionBuildFunction(
),
]);
const installation = appiumInstall.enforceValue();
// A prepared home is shared across sessions; remove only a job-owned home after a session.
appiumHome = installation.prepared ? undefined : installation.appiumHome;
appiumHome = installation.appiumHome;
startupSignal?.throwIfAborted();
const { appiumBinPath, appiumEnv } = installation;
const wdaCapabilities = await preparePreinstalledWdaAsync({
@@ -270,8 +243,7 @@ export function createStartAppiumRemoteSessionBuildFunction(
})
)?.runtime
: device.runtimeIdentifier,
appiumHome: installation.appiumHome,
prepared: installation.prepared,
appiumHome,
appiumBinPath,
appiumEnv,
logger,
@@ -446,8 +418,7 @@ export function createStartAppiumRemoteSessionBuildFunction(
watchSignal.throwIfAborted();
if (warm && runtimePlatform === BuildRuntimePlatform.DARWIN) {
await runOnWarmIosSimulatorAsync(
// package_version is the Appium version. The job installs it or uses the prepared
// home; the warm claim does not depend on it.
// package_version is the Appium version, which the job installs either way.
{
engine: 'appium',
requestedDevice: deviceIdentifier,
@@ -532,7 +503,6 @@ export async function resolveAppiumDeviceAsync({
export async function installAppiumAsync({
versionSpec,
resolveRequestedVersionAsync,
driverName,
env,
logger,
@@ -540,53 +510,13 @@ export async function installAppiumAsync({
onError,
}: {
versionSpec: string;
resolveRequestedVersionAsync?: () => Promise<string>;
driverName: AppiumDevice['driverName'];
env: BuildStepEnv;
logger: bunyan;
signal?: AbortSignal;
onError?: (error: unknown) => void;
}): Promise<{
appiumHome: string;
appiumBinPath: string;
appiumEnv: BuildStepEnv;
prepared: boolean;
}> {
}): Promise<{ appiumHome: string; appiumBinPath: string; appiumEnv: BuildStepEnv }> {
signal?.throwIfAborted();
let prepared =
driverName === 'xcuitest'
? await readPreparedSimulatorToolAsync('appium', PreparedAppiumSchema)
: undefined;
if (
prepared &&
!(await isPreparedAppiumCompatibleAsync(prepared, { versionSpec, env, signal }))
) {
prepared = undefined;
}
if (prepared && resolveRequestedVersionAsync) {
versionSpec = resolveAppium3VersionSpec(await resolveRequestedVersionAsync());
if (!semver.satisfies(prepared.version, versionSpec)) {
prepared = undefined;
}
}
if (prepared) {
try {
// An invalid package manager override fails as it does without a prepared home.
resolveConfiguredPackageManager(env, PackageManager.NPM);
} catch (error) {
onError?.(error);
throw error;
}
logger.info(
`Using the prefetched Appium home (appium ${prepared.version}, xcuitest ${prepared.xcuitest}).`
);
return {
appiumHome: prepared.home,
appiumBinPath: path.join(prepared.home, 'node_modules', '.bin', 'appium'),
appiumEnv: { ...env, APPIUM_HOME: prepared.home },
prepared: true,
};
}
const appiumHome = await fs.promises.mkdtemp(path.join(os.tmpdir(), 'eas-appium-home-'));
try {
signal?.throwIfAborted();
@@ -639,7 +569,7 @@ export async function installAppiumAsync({
signal
);
}
return { appiumHome, appiumBinPath, appiumEnv, prepared: false };
return { appiumHome, appiumBinPath, appiumEnv };
} catch (error) {
onError?.(error);
if (signal) {
@@ -650,67 +580,6 @@ export async function installAppiumAsync({
}
}
/** A metadata hit still needs Appium-specific version, driver and runner checks before reuse. */
async function isPreparedAppiumCompatibleAsync(
prepared: z.infer<typeof PreparedAppiumSchema>,
{ versionSpec, env, signal }: { versionSpec: string; env: BuildStepEnv; signal?: AbortSignal }
): Promise<boolean> {
const { home } = prepared;
if (home !== path.join(os.homedir(), 'Library', 'Caches', 'expo-simulator-startup', 'appium')) {
return false;
}
try {
const installedVersionAsync = async (name: string): Promise<string> =>
PackageVersionSchema.parse(
JSON.parse(
await fs.promises.readFile(path.join(home, 'node_modules', name, 'package.json'), 'utf8')
)
).version;
if (
!semver.satisfies(prepared.version, versionSpec) ||
(await installedVersionAsync('appium')) !== prepared.version ||
(await installedVersionAsync('appium-xcuitest-driver')) !== prepared.xcuitest
) {
return false;
}
const runner = path.join(home, 'preinstalled-wda', 'WebDriverAgentRunner-Runner.app');
await fs.promises.access(runner, fs.constants.R_OK | fs.constants.X_OK);
if (!(await fs.promises.stat(runner)).isDirectory()) {
return false;
}
const metadata = await fs.promises.readFile(path.join(runner, 'Info.plist'));
const info =
metadata.subarray(0, 8).toString('ascii') === 'bplist00'
? bplistParser.parseBuffer(metadata)[0]
: plist.parse(metadata.toString('utf8'));
const executable = z
.object({ CFBundleExecutable: z.string().min(1) })
.parse(info).CFBundleExecutable;
if (path.basename(executable) !== executable || executable === '.' || executable === '..') {
return false;
}
const executablePath = path.join(runner, executable);
await fs.promises.access(executablePath, fs.constants.R_OK | fs.constants.X_OK);
const executableStat = await fs.promises.stat(executablePath);
if (!executableStat.isFile() || executableStat.size === 0) {
return false;
}
// Today's driver list shows that the Appium CLI runs from this home. It does not load the driver.
const { stdout } = await runAppiumSetupCommandAsync(
path.join(home, 'node_modules', '.bin', 'appium'),
['driver', 'list', '--installed', '--json'],
{ env: { ...env, APPIUM_HOME: home }, stdio: 'pipe' },
signal
);
if (!AppiumInstalledDriversSchema.parse(JSON.parse(stdout)).xcuitest?.installed) {
return false;
}
return true;
} catch {
return false;
}
}
async function runAppiumSetupCommandAsync(
command: string,
args: string[],
@@ -137,6 +137,13 @@ export function createStartArgentRemoteSessionBuildFunction(
// A missing or non-positive value disables the idle timeout (opt-in feature).
const maxIdleTimeMinutes = inputs.max_idle_time_minutes.value as number | undefined;
const maxDurationSeconds = inputs.max_duration_seconds?.value as number | undefined;
validateControllerVersion({
packageName: ARGENT_PACKAGE_NAME,
minimumVersion: MIN_ARGENT_REMOTE_SESSION_VERSION,
packageVersion,
logger,
});
const versionSpec = packageVersion ?? 'latest';
const { runtimePlatform } = global;
const startupStop = new AbortController();
const watchSignal = signal
@@ -149,17 +156,7 @@ export function createStartArgentRemoteSessionBuildFunction(
startup: { signal: watchSignal, abort: reason => startupStop.abort(reason) },
});
const deviceIdentifier = inputs.device_identifier?.value as string | undefined;
const startSessionAsync = async (
warmSession?: WarmIosSession,
resolvedPackageVersion = packageVersion
): Promise<void> => {
const versionSpec = resolvedPackageVersion ?? 'latest';
validateControllerVersion({
packageName: ARGENT_PACKAGE_NAME,
minimumVersion: MIN_ARGENT_REMOTE_SESSION_VERSION,
packageVersion: resolvedPackageVersion,
logger,
});
const startSessionAsync = async (warmSession?: WarmIosSession): Promise<void> => {
const startupAbortController = new AbortController();
const startupSignal = AbortSignal.any([watchSignal, startupAbortController.signal]);
const { launch, iosStartup } = await resolveIosSessionStartupAsync({
@@ -1,11 +1,21 @@
import { ArchiveSourceType, SystemError, UserError } from '@expo/eas-build-job';
import { SystemError, UserError } from '@expo/eas-build-job';
import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
import { graphql } from 'gql.tada';
import { stripRepositoryCredentialsAsync } from '../../common/git';
import { CustomBuildContext } from '../../customBuildContext';
import { graphqlAbortContext } from '../../utils/graphqlAbort';
import { withLogPhaseAsync } from '../../utils/logPhase';
import { startSandboxDaemonAsync } from '../utils/sandboxDaemon';
import { requireSandboxWorkerApi } from '../utils/sandboxWorkerApi';
const MARK_SANDBOX_READY_MUTATION = graphql(`
mutation MarkSandboxReady($sandboxId: ID!) {
sandbox {
markSandboxReady(sandboxId: $sandboxId) {
id
}
}
}
`);
const RECONNECT_DELAY_MS = 1_000;
const AWAIT_SANDBOX_STEP_NAME = 'Await sandbox completion';
@@ -29,11 +39,16 @@ export function createStartSandboxBuildFunction(ctx: CustomBuildContext): BuildF
}),
],
fn: async (stepCtx, { inputs, signal, env }) => {
const workerApi = requireSandboxWorkerApi(ctx);
// The daemon needs this credential, but shell commands do not.
const { __EAS_SANDBOX_MCP_TOKEN: sandboxToken, ...commandEnv } = env;
if (!sandboxToken) {
throw new SystemError('__EAS_SANDBOX_MCP_TOKEN is required to start the sandbox daemon.');
}
const mcpServerUrl = ctx.mcpServerUrl;
if (!mcpServerUrl) {
throw new SystemError('MCP server URL is required to start the sandbox daemon.');
}
const sandboxId = String(inputs.sandbox_id.value);
const maxDurationSeconds = inputs.max_duration_seconds?.value;
if (
maxDurationSeconds !== undefined &&
@@ -46,35 +61,21 @@ export function createStartSandboxBuildFunction(ctx: CustomBuildContext): BuildF
`Invalid sandbox maximum duration: ${String(maxDurationSeconds)}. Provide a finite number greater than zero, or omit max_duration_seconds.`
);
}
if (ctx.job.projectArchive.type === ArchiveSourceType.GIT) {
// Scripts and commands inside the sandbox could read the token from .git/config.
await stripRepositoryCredentialsAsync({
repositoryDirectory: stepCtx.global.wasCheckedOut()
? ctx.projectTargetDirectory
: ctx.projectSourceDirectory,
});
}
const daemon = await startSandboxDaemonAsync({
credential: workerApi.token,
credential: sandboxToken,
serverUrl: mcpServerUrl,
reconnectDelayMs: RECONNECT_DELAY_MS,
logger: stepCtx.logger,
signal,
workingDirectory: stepCtx.workingDirectory,
env,
workerApi,
env: commandEnv,
graphqlClient: ctx.graphqlClient,
sandboxId,
});
try {
await daemon.ready;
signal?.throwIfAborted();
await workerApi.markReadyAsync({ signal }).catch((error: unknown) => {
signal?.throwIfAborted();
throw new SystemError(
`Failed to mark sandbox ${String(inputs.sandbox_id.value)} as ready.`,
{ cause: error }
);
});
await markSandboxReadyAsync(ctx, sandboxId, signal);
signal?.throwIfAborted();
stepCtx.logger.info('Sandbox daemon started.');
@@ -102,6 +103,23 @@ export function createStartSandboxBuildFunction(ctx: CustomBuildContext): BuildF
});
}
export async function markSandboxReadyAsync(
ctx: CustomBuildContext,
sandboxId: string,
signal?: AbortSignal
): Promise<void> {
signal?.throwIfAborted();
const result = await ctx.graphqlClient
.mutation(MARK_SANDBOX_READY_MUTATION, { sandboxId }, graphqlAbortContext(signal))
.toPromise();
signal?.throwIfAborted();
if (result.error) {
throw new SystemError(`Failed to mark sandbox ${sandboxId} as ready.`, {
cause: result.error,
});
}
}
async function waitForCompletionAsync(signal: AbortSignal): Promise<void> {
if (signal.aborted) {
return;
@@ -108,10 +108,7 @@ export function createStartWebPreviewRemoteSessionBuildFunction(
startup: { signal: watchSignal, abort: reason => startupStop.abort(reason) },
});
const deviceIdentifier = inputs.device_identifier?.value as string | undefined;
const startSessionAsync = async (
warmSession?: WarmIosSession,
resolvedPackageVersion = packageVersion
): Promise<void> => {
const startSessionAsync = async (warmSession?: WarmIosSession): Promise<void> => {
const startupAbortController = new AbortController();
const startupSignal = AbortSignal.any([watchSignal, startupAbortController.signal]);
const { launch, iosStartup } = await resolveIosSessionStartupAsync({
@@ -151,7 +148,7 @@ export function createStartWebPreviewRemoteSessionBuildFunction(
preview: { baseDomain: ngrokTunnelDomain, authtoken: ngrokAuthtoken },
signal: startupSignal,
onStartupError: error => startupAbortController.abort(error),
packageVersion: resolvedPackageVersion,
packageVersion,
disableShare: inputs.public_preview?.value === false,
privatePreviewUrl: inputs.private_preview_url?.value as string | undefined,
frameAncestors: parseFrameAncestorsInput(inputs.frame_ancestors?.value),
@@ -9,8 +9,10 @@ import RemoteLoggerStream from '../../../logging/RemoteLoggerStream';
import { Sentry } from '../../../sentry';
import { turtleFetch } from '../../../utils/turtleFetch';
import { startAgentDeviceEventCollectionAsync } from '../agentDeviceEvents';
import { DEVICE_RUN_SESSION_TOKEN_HEADER } from '../deviceRunSessionWorkerApi';
import { WorkerApiError } from '../workerApi';
import {
DEVICE_RUN_SESSION_TOKEN_HEADER,
DeviceRunSessionWorkerApiError,
} from '../deviceRunSessionWorkerApi';
const mockEventLogStream = {
init: jest.fn(async () => undefined),
@@ -575,7 +577,7 @@ describe(startAgentDeviceEventCollectionAsync, () => {
'Failed to create device run session event log upload session: ' +
'POST /v2/device-run-session-worker/event-log-upload-session failed with status 503: ' +
'WWW unavailable',
cause: expect.any(WorkerApiError),
cause: expect.any(DeviceRunSessionWorkerApiError),
}),
},
'Could not persist device run session events to the artifact.'
@@ -587,7 +589,7 @@ describe(startAgentDeviceEventCollectionAsync, () => {
'Failed to create device run session event log upload session: ' +
'POST /v2/device-run-session-worker/event-log-upload-session failed with status 503: ' +
'WWW unavailable',
cause: expect.any(WorkerApiError),
cause: expect.any(DeviceRunSessionWorkerApiError),
}),
{
level: 'warning',
@@ -16,10 +16,7 @@ import { PassThrough, Readable } from 'node:stream';
import { createMockLogger } from '../../../__tests__/utils/logger';
import { type CustomBuildContext } from '../../../customBuildContext';
import { MAX_ANDROID_LOG_BYTES_PER_SOURCE } from '../../../utils/androidEmulatorLogCapture';
import {
ALL_ANDROID_EMULATOR_LOG_SOURCES,
type AndroidEmulatorLogSource,
} from '../../../utils/androidEmulatorLogSources';
import { type AndroidEmulatorLogSource } from '../../../utils/androidEmulatorLogSources';
import {
collectAndroidEmulatorLogsAsync,
getAndroidEmulatorLogCapture,
@@ -33,13 +30,10 @@ jest.unmock('fs/promises');
jest.unmock('node:fs/promises');
const ctx = {} as CustomBuildContext;
const sessionEnv = { DEVICE_RUN_SESSION_ID: 'session' };
const upload = jest.mocked(uploadDeviceRunSessionArtifactAsync);
let directory: string;
let emulatorPath: string;
let logcatPath: string;
let emulatorRing: string;
let logcatRing: string;
let global: BuildStepGlobalContext;
let logger: ReturnType<typeof createMockLogger>;
let uploadedContents: Map<string, string>;
@@ -51,8 +45,6 @@ beforeEach(async () => {
directory = await mkdtemp(path.join(os.tmpdir(), 'android-log-collection-'));
emulatorPath = path.join(directory, 'device-attempt-1-emulator.log');
logcatPath = path.join(directory, 'device-attempt-1-logcat.log');
emulatorRing = path.join(directory, 'emulator-output.log');
logcatRing = path.join(directory, 'device-logcat.log');
upload.mockReset().mockImplementation(async (_ctx, { filename, openStream }) => {
const chunks: Buffer[] = [];
for await (const chunk of openStream()) {
@@ -67,20 +59,13 @@ afterEach(async () => {
await rm(directory, { recursive: true, force: true });
});
/** `==== <launch> <ISO time> ====\n` precedes the first output of a launch. */
const MARKER = String.raw`==== \S+ \S+ ====\n`;
async function captureLaunch(
async function captureLog(
filePath: string,
source: AndroidEmulatorLogSource,
text: string,
workflow = global
): Promise<void> {
const capture = getAndroidEmulatorLogCapture(
workflow,
sessionEnv,
ALL_ANDROID_EMULATOR_LOG_SOURCES
);
const capture = getAndroidEmulatorLogCapture(workflow, { DEVICE_RUN_SESSION_ID: 'session' });
const input = Readable.from([Buffer.from(text)]);
capture.attach(input, filePath, source);
await once(input, 'end');
@@ -96,28 +81,23 @@ function collect(): Promise<void> {
}
it.each([
{ env: {}, file: 'device-attempt-1-emulator.log', expectedBytes: 20 * 1024 * 1024 + 1 },
{ env: sessionEnv, file: 'emulator-output.log', expectedBytes: 20 * 1024 * 1024 },
])(
'retains $expectedBytes in $file with workflow environment $env',
async ({ env, file, expectedBytes }) => {
const capture = getAndroidEmulatorLogCapture(global, env, ALL_ANDROID_EMULATOR_LOG_SOURCES);
const input = Readable.from([Buffer.alloc(20 * 1024 * 1024 + 1, 'x')]);
capture.attach(input, emulatorPath, 'emulator-output');
await once(input, 'end');
await capture.finishAsync();
expect((await fsPromises.stat(path.join(directory, file))).size).toBe(expectedBytes);
}
);
{ env: {}, expectedBytes: 20 * 1024 * 1024 + 1 },
{ env: { DEVICE_RUN_SESSION_ID: 'session' }, expectedBytes: 20 * 1024 * 1024 },
])('retains $expectedBytes with workflow environment $env', async ({ env, expectedBytes }) => {
const capture = getAndroidEmulatorLogCapture(global, env);
const input = Readable.from([Buffer.alloc(20 * 1024 * 1024 + 1, 'x')]);
capture.attach(input, emulatorPath, 'emulator-output');
await once(input, 'end');
await capture.finishAsync();
expect((await fsPromises.stat(emulatorPath)).size).toBe(expectedBytes);
});
it('uploads one artifact per source and ignores files outside the capture inventory', async () => {
await captureLaunch(emulatorPath, 'emulator-output', 'host output');
await captureLaunch(logcatPath, 'device-logcat', 'Android output');
await captureLaunch(
path.join(directory, 'retry-emulator.log'),
'emulator-output',
'retry output'
);
it('uses captured source records and ignores files outside the capture inventory', async () => {
const first = path.join(directory, 'first.txt');
const second = path.join(directory, 'second.txt');
await captureLog(first, 'emulator-output', 'host output');
await captureLog(second, 'device-logcat', 'Android output');
await captureLog(path.join(directory, 'retry.txt'), 'emulator-output', 'retry output');
await writeFile(emulatorPath, 'not captured');
const elsewhere = path.join(directory, 'elsewhere');
await mkdir(elsewhere);
@@ -125,23 +105,17 @@ it('uploads one artifact per source and ignores files outside the capture invent
await symlink(path.join(elsewhere, 'other-emulator.log'), logcatPath);
await collect();
expect([...uploadedContents.keys()]).toEqual(['emulator-output.log', 'device-logcat.log']);
expect(uploadedContents.get('emulator-output.log')).toMatch(
new RegExp(`^${MARKER}host output\\n${MARKER}retry output$`)
);
expect(uploadedContents.get('device-logcat.log')).toMatch(
new RegExp(`^${MARKER}Android output$`)
);
expect([...uploadedContents.values()]).toEqual(['host output', 'Android output', 'retry output']);
expect(upload).toHaveBeenCalledWith(
ctx,
expect.objectContaining({
filename: 'emulator-output.log',
filename: 'first.txt',
kind: 'simulator-log',
metadata: expect.objectContaining({
platform: 'android',
source: 'emulator-output',
scope: 'emulator-process',
originalSizeBytes: uploadedContents.get('emulator-output.log')?.length,
originalSizeBytes: 11,
omittedBytes: 0,
truncated: false,
}),
@@ -152,7 +126,7 @@ it('uploads one artifact per source and ignores files outside the capture invent
expect(upload).toHaveBeenCalledWith(
ctx,
expect.objectContaining({
filename: 'device-logcat.log',
filename: 'second.txt',
metadata: expect.objectContaining({ source: 'device-logcat', scope: 'device' }),
})
);
@@ -160,18 +134,13 @@ it('uploads one artifact per source and ignores files outside the capture invent
it('seals a live producer before upload and keeps retry bodies identical without copying files', async () => {
const input = new PassThrough();
const capture = getAndroidEmulatorLogCapture(
global,
sessionEnv,
ALL_ANDROID_EMULATOR_LOG_SOURCES
);
const capture = getAndroidEmulatorLogCapture(global, { DEVICE_RUN_SESSION_ID: 'session' });
capture.attach(input, emulatorPath, 'emulator-output');
input.write('before');
const contents: string[] = [];
upload.mockImplementationOnce(async (_ctx, { size, openStream, metadata }) => {
expect(metadata).toEqual(
expect.objectContaining({ originalSizeBytes: size, truncated: false })
);
expect(size).toBe(6);
expect(metadata).toEqual(expect.objectContaining({ originalSizeBytes: 6, truncated: false }));
for (let attempt = 0; attempt < 2; attempt++) {
input.write(' ignored after finalization');
const chunks: Buffer[] = [];
@@ -183,30 +152,28 @@ it('seals a live producer before upload and keeps retry bodies identical without
});
try {
await collect();
expect(contents).toHaveLength(2);
expect(contents[0]).toMatch(new RegExp(`^${MARKER}before$`));
expect(contents[1]).toBe(contents[0]);
expect(await readFile(emulatorRing, 'utf8')).toBe(contents[0]);
expect(await readdir(directory)).toEqual(['emulator-output.log']);
expect(contents).toEqual(['before', 'before']);
expect(await readFile(emulatorPath, 'utf8')).toBe('before');
expect(await readdir(directory)).toEqual([path.basename(emulatorPath)]);
expect(input.readableFlowing).toBe(true);
const late = new PassThrough();
capture.attach(late, logcatPath, 'device-logcat');
late.end('not captured');
expect(late.readableFlowing).toBe(true);
await expect(fsPromises.stat(logcatRing)).rejects.toMatchObject({ code: 'ENOENT' });
await expect(fsPromises.stat(logcatPath)).rejects.toMatchObject({ code: 'ENOENT' });
} finally {
input.end();
}
});
it('continues with the other log after a failed upload and never repeats the collection', async () => {
await captureLaunch(emulatorPath, 'emulator-output', 'host output');
await captureLaunch(logcatPath, 'device-logcat', 'Android output');
await captureLog(emulatorPath, 'emulator-output', 'host output');
await captureLog(logcatPath, 'device-logcat', 'Android output');
upload.mockRejectedValueOnce(new Error('storage unavailable'));
await Promise.all([collect(), collect()]);
await collect();
expect(upload).toHaveBeenCalledTimes(2);
expect(uploadedContents.get('device-logcat.log')).toMatch(/Android output$/);
expect(uploadedContents.get(path.basename(logcatPath))).toBe('Android output');
expect(logger.warn).toHaveBeenCalledTimes(1);
expect(logger.warn).toHaveBeenCalledWith(
expect.anything(),
@@ -215,8 +182,8 @@ it('continues with the other log after a failed upload and never repeats the col
});
it('uses a fresh 30 second budget for the next file after an upload times out', async () => {
await captureLaunch(emulatorPath, 'emulator-output', 'host output');
await captureLaunch(logcatPath, 'device-logcat', 'Android output');
await captureLog(emulatorPath, 'emulator-output', 'host output');
await captureLog(logcatPath, 'device-logcat', 'Android output');
const controllers: AbortController[] = [];
const timeout = jest.spyOn(AbortSignal, 'timeout').mockImplementation(() => {
const controller = new AbortController();
@@ -228,52 +195,46 @@ it('uses a fresh 30 second budget for the next file after an upload times out',
signal?.throwIfAborted();
});
await expect(collect()).resolves.toBeUndefined();
expect(uploadedContents.get('device-logcat.log')).toMatch(/Android output$/);
expect(uploadedContents.get(path.basename(logcatPath))).toBe('Android output');
expect(timeout.mock.calls).toEqual([[30_000], [30_000]]);
expect(upload.mock.calls[1][1].signal?.aborted).toBe(false);
});
it('does not collect another workflow and warns when a captured file disappears', async () => {
const otherWorkflow = {} as BuildStepGlobalContext;
await captureLaunch(emulatorPath, 'emulator-output', 'other workflow', otherWorkflow);
await captureLog(emulatorPath, 'emulator-output', 'other workflow', {} as BuildStepGlobalContext);
await collect();
expect(upload).not.toHaveBeenCalled();
await getAndroidEmulatorLogCapture(otherWorkflow, sessionEnv, []).finishAsync();
await captureLaunch(path.join(directory, 'missing-emulator.log'), 'emulator-output', 'removed');
await rm(emulatorRing);
await captureLog(path.join(directory, 'missing.log'), 'emulator-output', 'removed');
await rm(path.join(directory, 'missing.log'));
await expect(collect()).resolves.toBeUndefined();
expect(upload).not.toHaveBeenCalled();
expect(logger.warn).toHaveBeenCalledWith(
expect.anything(),
expect.stringContaining('emulator-output.log')
expect.stringContaining('missing.log')
);
});
it('uploads the tail of a truncated log with the retained size and omission metadata', async () => {
const capture = getAndroidEmulatorLogCapture(
global,
sessionEnv,
ALL_ANDROID_EMULATOR_LOG_SOURCES
);
const capture = getAndroidEmulatorLogCapture(global, { DEVICE_RUN_SESSION_ID: 'session' });
const input = Readable.from([
Buffer.concat([Buffer.from('head: '), Buffer.alloc(MAX_ANDROID_LOG_BYTES_PER_SOURCE, 'b')]),
]);
capture.attach(input, emulatorPath, 'emulator-output');
await once(input, 'end');
await collect();
const uploaded = uploadedContents.get('emulator-output.log');
expect(uploaded).toHaveLength(MAX_ANDROID_LOG_BYTES_PER_SOURCE);
expect(uploaded).not.toContain('head');
expect(uploaded).not.toContain('====');
const [, call] = upload.mock.calls[0];
const { originalSizeBytes } = call.metadata as { originalSizeBytes: number };
const omitted = originalSizeBytes - MAX_ANDROID_LOG_BYTES_PER_SOURCE;
expect(omitted).toBeGreaterThanOrEqual(6);
expect(call).toEqual(
expect(upload).toHaveBeenCalledWith(
ctx,
expect.objectContaining({
size: MAX_ANDROID_LOG_BYTES_PER_SOURCE,
name: expect.stringContaining('truncated, last 20.0 MB retained'),
metadata: expect.objectContaining({ omittedBytes: omitted, truncated: true }),
name: expect.stringContaining('truncated, last 20 MiB retained'),
metadata: expect.objectContaining({
originalSizeBytes: MAX_ANDROID_LOG_BYTES_PER_SOURCE + 6,
omittedBytes: 6,
truncated: true,
}),
})
);
const uploaded = uploadedContents.get(path.basename(emulatorPath));
expect(uploaded).toHaveLength(MAX_ANDROID_LOG_BYTES_PER_SOURCE);
expect(uploaded).not.toContain('head');
});
@@ -315,8 +315,10 @@ describe(captureDeviceRunSessionPreviewAsync, () => {
}) as ReturnType<typeof spawn>;
}
return (async () => {
expect(command).not.toBe('xcrun');
if (command === 'sips') {
if (command === 'xcrun') {
expect(args.slice(0, 4)).toEqual(['simctl', 'io', 'selected-device', 'screenshot']);
await writeFile(args[4], Uint8Array.from(png));
} else if (command === 'sips') {
expect(args.slice(0, 2)).toEqual(['-Z', '320']);
expect(await readFile(args[2])).toEqual(png);
await writeFile(args[args.indexOf('--out') + 1], Uint8Array.from(resized));
@@ -338,10 +340,6 @@ describe(captureDeviceRunSessionPreviewAsync, () => {
await captureDeviceRunSessionPreviewAsync({
runtimePlatform,
device,
captureIosScreenshotAsync: async (file, signal) => {
signal.throwIfAborted();
await writeFile(file, Uint8Array.from(png));
},
env: {},
signal: new AbortController().signal,
})
@@ -374,9 +372,6 @@ describe(captureDeviceRunSessionPreviewAsync, () => {
captureDeviceRunSessionPreviewAsync({
runtimePlatform: BuildRuntimePlatform.DARWIN,
device: 'device',
captureIosScreenshotAsync: async () => {
throw new Error('capture failed');
},
env: {},
signal: new AbortController().signal,
})
@@ -1,10 +1,12 @@
import { SystemError } from '@expo/eas-build-job';
import { FetchError } from 'node-fetch';
import { CustomBuildContext } from '../../../customBuildContext';
import { turtleFetch } from '../../../utils/turtleFetch';
import {
DEVICE_RUN_SESSION_TOKEN_HEADER,
DeviceRunSessionWorkerApi,
DeviceRunSessionWorkerApiError,
getDeviceRunSessionWorkerApi,
requireDeviceRunSessionWorkerApi,
} from '../deviceRunSessionWorkerApi';
@@ -63,6 +65,23 @@ describe(getDeviceRunSessionWorkerApi, () => {
);
});
it('derives the API v2 base URL from __API_SERVER_URL when the context has none', async () => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(jsonResponse({ data: { id: 'drs-id', status: 'in-progress' } }));
const api = getDeviceRunSessionWorkerApi({
env: { EAS_DEVICE_RUN_SESSION_TOKEN: TOKEN, __API_SERVER_URL: 'https://api.expo.test' },
} as unknown as CustomBuildContext);
await api!.getSessionAsync();
expect(jest.mocked(turtleFetch)).toHaveBeenCalledWith(
'https://api.expo.test/v2/device-run-session-worker/session',
'GET',
expect.anything()
);
});
it('throws a system error when the token is set but no API URL is known', () => {
expect(() =>
getDeviceRunSessionWorkerApi({
@@ -249,4 +268,273 @@ describe(DeviceRunSessionWorkerApi, () => {
'GET /v2/device-run-session-worker/application returned an unexpected response'
);
});
it('passes the signal and timeout without enabling nested retries', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(jsonResponse({ data: { iceServers: [] } }));
const controller = new AbortController();
await createApi().fetchTurnIceServersAsync({
signal: controller.signal,
timeoutMs: 5000,
retries: 1,
});
expect(jest.mocked(turtleFetch)).toHaveBeenCalledWith(
expect.any(String),
'POST',
expect.objectContaining({ signal: controller.signal, timeout: 5000, retries: 0 })
);
});
it('reports the API v2 error message and status without the token', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(
jsonResponse(
{
errors: [
{
code: 'UNAUTHORIZED_ERROR',
message: 'This device run session no longer accepts worker requests.',
},
],
},
403
)
);
const error = await createApi()
.stopAsync()
.catch(err => err);
expect(error).toBeInstanceOf(DeviceRunSessionWorkerApiError);
expect(error.status).toBe(403);
expect(error.message).toBe(
'POST /v2/device-run-session-worker/stop failed with status 403: This device run session no longer accepts worker requests.'
);
expect(error.message).not.toContain(TOKEN);
});
it('reports the status text when the error response is not an API v2 error', async () => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(
new Response('<html>bad gateway</html>', { status: 502, statusText: 'Bad Gateway' })
);
const error = await createApi()
.getSessionAsync({ retries: 0 })
.catch(err => err);
expect(error).toBeInstanceOf(DeviceRunSessionWorkerApiError);
expect(error.status).toBe(502);
expect(error.message).toBe(
'GET /v2/device-run-session-worker/session failed with status 502: Bad Gateway'
);
});
it('reports a request that failed before www responded', async () => {
const reason = new Error('socket hang up');
jest.mocked(turtleFetch).mockRejectedValueOnce(reason);
const error = await createApi()
.getSessionAsync({ retries: 0 })
.catch(err => err);
expect(error).toBeInstanceOf(DeviceRunSessionWorkerApiError);
expect(error.status).toBeUndefined();
expect(error.cause).toBe(reason);
expect(error.message).toContain('failed before www responded: socket hang up');
});
it('rejects a response that does not match the route contract', async () => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(jsonResponse({ data: { id: 'drs-id', status: 'STOPPED' } }));
await expect(createApi().getSessionAsync({ retries: 3 })).rejects.toThrow(
'GET /v2/device-run-session-worker/session returned an unexpected response'
);
});
it('rejects a successful response that is not JSON', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('ok', { status: 200 }));
await expect(createApi().getSessionAsync({ retries: 3 })).rejects.toThrow(
'GET /v2/device-run-session-worker/session returned a response that is not JSON.'
);
});
});
describe('device run session worker API retries', () => {
beforeEach(() => {
jest.useFakeTimers();
jest.mocked(turtleFetch).mockReset();
});
afterEach(() => {
jest.useRealTimers();
});
it.each([429, 500, 502, 503, 504])(
'recovers from HTTP %s when starting a session',
async status => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(new Response('unavailable', { status }))
.mockResolvedValueOnce(jsonResponse({ data: { id: 'drs-id', status: 'in-progress' } }));
const result = createApi().startAsync(
{ remoteConfig: { url: 'https://preview.test' } },
{ retries: 3, timeoutMs: 30_000 }
);
const assertion = expect(result).resolves.toEqual({ id: 'drs-id', status: 'in-progress' });
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
expect(jest.mocked(turtleFetch).mock.calls[1]).toEqual(
jest.mocked(turtleFetch).mock.calls[0]
);
expect(jest.mocked(turtleFetch).mock.calls[0][2]).toMatchObject({
retries: 0,
timeout: 30_000,
});
}
);
it('recovers from a network failure', async () => {
jest
.mocked(turtleFetch)
.mockRejectedValueOnce(new Error('socket hang up'))
.mockResolvedValueOnce(jsonResponse({ data: { build: null } }));
const assertion = expect(createApi().getApplicationAsync({ retries: 3 })).resolves.toEqual({
build: null,
});
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
});
it('exhausts three retries with exponential backoff', async () => {
jest
.mocked(turtleFetch)
.mockImplementation(async () => new Response('unavailable', { status: 503 }));
const assertion = expect(
createApi().startAsync({ remoteConfig: {} }, { retries: 3 })
).rejects.toMatchObject({
status: 503,
});
await jest.advanceTimersByTimeAsync(0);
expect(turtleFetch).toHaveBeenCalledTimes(1);
await jest.advanceTimersByTimeAsync(1000);
expect(turtleFetch).toHaveBeenCalledTimes(2);
await jest.advanceTimersByTimeAsync(2000);
expect(turtleFetch).toHaveBeenCalledTimes(3);
await jest.advanceTimersByTimeAsync(4000);
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(4);
});
it.each([400, 401, 403, 404, 409])('does not retry HTTP %s', async status => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('refused', { status }));
await expect(
createApi().startAsync({ remoteConfig: {} }, { retries: 3 })
).rejects.toMatchObject({ status });
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
it.each([
['status polling', (api: DeviceRunSessionWorkerApi) => api.getSessionAsync()],
['stop', (api: DeviceRunSessionWorkerApi) => api.stopAsync()],
[
'screenshot application metadata',
(api: DeviceRunSessionWorkerApi) => api.getApplicationAsync(),
],
['event log setup', (api: DeviceRunSessionWorkerApi) => api.createEventLogUploadSessionAsync()],
['preview setup', (api: DeviceRunSessionWorkerApi) => api.createPreviewUploadSessionAsync()],
[
'TURN without an explicit retry option',
(api: DeviceRunSessionWorkerApi) => api.fetchTurnIceServersAsync(),
],
])('does not retry %s by default', async (_name, call) => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('unavailable', { status: 503 }));
await expect(call(createApi())).rejects.toMatchObject({ status: 503 });
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
it('honors an explicit retry count', async () => {
jest
.mocked(turtleFetch)
.mockImplementation(async () => new Response('unavailable', { status: 503 }));
const assertion = expect(
createApi().fetchTurnIceServersAsync({ retries: 1 })
).rejects.toMatchObject({ status: 503 });
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
});
it('does not send another request after cancellation during backoff', async () => {
const controller = new AbortController();
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('unavailable', { status: 503 }));
const assertion = expect(
createApi().getApplicationAsync({ signal: controller.signal, retries: 3 })
).rejects.toMatchObject({ name: 'AbortError' });
await jest.advanceTimersByTimeAsync(0);
controller.abort();
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
});
describe('device run session retry safety', () => {
beforeEach(() => {
jest.mocked(turtleFetch).mockReset();
});
it('does not replay artifact creation after a transient failure', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('unavailable', { status: 503 }));
await expect(
createApi().createArtifactUploadSessionAsync({
name: 'report',
filename: 'report.json',
size: 1,
})
).rejects.toMatchObject({ status: 503 });
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
it('does not send an already cancelled request', async () => {
const controller = new AbortController();
controller.abort();
await expect(
createApi().getApplicationAsync({ signal: controller.signal, retries: 3 })
).rejects.toMatchObject({
name: 'AbortError',
});
expect(turtleFetch).not.toHaveBeenCalled();
});
it.each(['system', 'body-timeout'])(
'retries a response body transport failure (%s)',
async type => {
jest.useFakeTimers();
try {
const response = jsonResponse({});
jest
.spyOn(response, 'json')
.mockRejectedValueOnce(new FetchError('connection interrupted', type));
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(response)
.mockResolvedValueOnce(jsonResponse({ data: { id: 'drs-id', status: 'in-progress' } }));
const assertion = expect(
createApi().startAsync({ remoteConfig: {} }, { retries: 3 })
).resolves.toMatchObject({ status: 'in-progress' });
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
} finally {
jest.useRealTimers();
}
}
);
});
@@ -9,7 +9,6 @@ import path from 'node:path';
import type { CustomBuildContext } from '../../../customBuildContext';
import { IosSimulatorUtils } from '../../../utils/IosSimulatorUtils';
import { IosSimulatorRecordingUtils } from '../IosSimulatorRecordingUtils';
import { verifyLocalEgressGuardAsync } from '../localEgressGuard';
import { type ServeSimApplicationOptions } from '../remoteDeviceRunSession';
@@ -40,14 +39,9 @@ import {
spawnDetached,
startNgrokTunnelAsync,
} from '../remoteDeviceRunSession';
import {
runServeSimActionAsync,
runServeSimActionWithResultAsync,
stageServeSimAppAsync,
} from '../serveSimActions';
import { runServeSimActionAsync, stageServeSimAppAsync } from '../serveSimActions';
import { startServeSimActivityPolling } from '../serveSimActivity';
import { readServeSimServersAsync } from '../serveSimMetricsRecorder';
import * as previewCapture from '../serveSimPreviewCapture';
jest.mock('@ngrok/ngrok');
jest.mock('@expo/turtle-spawn');
@@ -170,12 +164,6 @@ beforeEach(() => {
.mockImplementation(async ({ artifactPath }) => installedBundleIds[artifactPath]);
jest.mocked(verifyLocalEgressGuardAsync).mockReset().mockResolvedValue(undefined);
jest.mocked(readLocalEgressHandoffAsync).mockReset().mockResolvedValue(null);
jest
.mocked(runServeSimActionWithResultAsync)
.mockReset()
.mockResolvedValue(
JSON.stringify({ 'screenshot.capture': { properties: { automation: { type: 'boolean' } } } })
);
stopSessionPreview.mockResolvedValue(undefined);
jest.mocked(startDeviceRunSessionPreview).mockReturnValue({ stopAsync: stopSessionPreview });
jest.mocked(ensureFfmpegInstalledOnceAsync).mockResolvedValue(undefined);
@@ -1490,119 +1478,6 @@ it.each([BuildRuntimePlatform.LINUX, BuildRuntimePlatform.DARWIN])(
}
);
it.each(['missing automation', 'invalid catalog', 'unavailable catalog'])(
'skips automated thumbnails with %s without stopping the iOS session',
async failure => {
if (failure === 'unavailable catalog') {
jest
.mocked(runServeSimActionWithResultAsync)
.mockRejectedValueOnce(new Error('unknown action'));
} else {
jest
.mocked(runServeSimActionWithResultAsync)
.mockResolvedValueOnce(
failure === 'invalid catalog'
? 'invalid JSON'
: JSON.stringify({ 'screenshot.capture': { properties: {} } })
);
}
const host = await startDeviceSessionHostAsync(ctx, {
runtimePlatform: BuildRuntimePlatform.DARWIN,
env,
logger,
timeoutMs: 10_000,
preview: { baseDomain, authtoken },
});
await new Promise(resolve => setImmediate(resolve));
expect(runServeSimActionWithResultAsync).toHaveBeenCalledTimes(1);
expect(startDeviceRunSessionPreview).not.toHaveBeenCalled();
expect(ensureMacosPreviewEncoderInstalledAsync).not.toHaveBeenCalled();
expect(stopServer).not.toHaveBeenCalled();
await host.finishAsync();
}
);
it('cancels catalog inspection during shutdown without sending a thumbnail capture', async () => {
let inspectionSignal: AbortSignal | undefined;
jest.mocked(runServeSimActionWithResultAsync).mockImplementationOnce(async ({ signal }) => {
inspectionSignal = signal;
return await new Promise<string>((_resolve, reject) => {
signal?.addEventListener('abort', () => reject(signal.reason), { once: true });
});
});
const host = await startDeviceSessionHostAsync(ctx, {
runtimePlatform: BuildRuntimePlatform.DARWIN,
env,
logger,
timeoutMs: 10_000,
preview: { baseDomain, authtoken },
});
expect(inspectionSignal?.aborted).toBe(false);
await host.finishAsync();
expect(inspectionSignal?.aborted).toBe(true);
expect(startDeviceRunSessionPreview).not.toHaveBeenCalled();
expect(ensureMacosPreviewEncoderInstalledAsync).not.toHaveBeenCalled();
expect(stopServer).toHaveBeenCalledTimes(1);
});
it('finishes manual screenshots even when thumbnail cleanup fails', async () => {
const finishScreenshots = jest.fn().mockResolvedValue(undefined);
const collector = jest
.spyOn(screenshotCollector, 'startDeviceRunSessionScreenshotsAsync')
.mockResolvedValueOnce({
directory: '/tmp/manual-screenshots',
finishAsync: finishScreenshots,
});
const cleanup = jest.fn().mockRejectedValue(new Error('unlink refused'));
const factory = jest.spyOn(previewCapture, 'createServeSimPreviewCapture').mockReturnValueOnce({
isSupportedAsync: jest.fn().mockResolvedValue(true),
captureAsync: jest.fn(),
cleanupAfterHostStoppedAsync: cleanup,
});
try {
const host = await startDeviceSessionHostAsync(ctx, {
runtimePlatform: BuildRuntimePlatform.DARWIN,
env,
logger,
timeoutMs: 10_000,
preview: { baseDomain, authtoken },
});
await new Promise(resolve => setImmediate(resolve));
await host.finishAsync();
expect(cleanup).toHaveBeenCalledTimes(1);
expect(finishScreenshots).toHaveBeenCalledWith(true);
expect(logger.warn).toHaveBeenCalledWith(
expect.objectContaining({ err: expect.any(Error) }),
'Could not remove session preview capture files.'
);
} finally {
factory.mockRestore();
collector.mockRestore();
}
});
it('drains thumbnail capture before stopping the iOS host', async () => {
const stopped = deferred<void>();
stopSessionPreview.mockReturnValueOnce(stopped.promise);
const host = await startDeviceSessionHostAsync(ctx, {
runtimePlatform: BuildRuntimePlatform.DARWIN,
env,
logger,
timeoutMs: 10_000,
preview: { baseDomain, authtoken },
});
await new Promise(resolve => setImmediate(resolve));
const finishing = host.finishAsync();
try {
await new Promise(resolve => setImmediate(resolve));
expect(stopServer).not.toHaveBeenCalled();
} finally {
stopped.resolve();
await finishing;
}
expect(stopServer).toHaveBeenCalledTimes(1);
});
it.each(['success', 'failure'])(
'keeps macOS readiness nonblocking and drains encoder setup %s before ending the phase',
async result => {
@@ -2318,58 +2193,6 @@ it.each([false, true])(
}
);
it.each([
['0.13.3', '@expo/[email protected]'],
[undefined, '@expo/serve-sim@latest'],
])(
'uses the warm serve-sim version %s for adoption and recordings',
async (serveSimVersion, spec) => {
jest
.mocked(readServeSimServersAsync)
.mockResolvedValue([
{ udid: 'emulator-5554', token: 'preview-token', url: 'http://127.0.0.1:3200' },
]);
const recording = jest.spyOn(IosSimulatorRecordingUtils, 'useServeSimPackage');
const startAsync = jest.fn(async () => ({
pid: undefined,
getOutput: () => '',
getExitError: () => undefined,
stopAsync: stopServer,
}));
const host = await startDeviceSessionHostAsync(
ctx,
{
preview: { baseDomain, authtoken },
runtimePlatform: BuildRuntimePlatform.DARWIN,
env: { ...env, EAS_OVERRIDE_PACKAGE_MANAGER: 'bun' },
logger,
iosSimulatorUdid: 'emulator-5554',
timeoutMs: 1000,
},
{
port: 3200,
serveSimVersion,
turnArgs: Promise.resolve([]),
requiresPreviewRetirement: true,
startAsync,
stopAsync: stopServer,
}
);
try {
expect(startAsync).toHaveBeenCalledWith(
expect.objectContaining({
command: 'bun',
args: expect.arrayContaining(['x', spec]),
})
);
expect(recording).toHaveBeenCalledWith(spec);
} finally {
await host.finishAsync();
recording.mockRestore();
}
}
);
it('opens the preview while a supplied server waits for TURN and its startup handshake', async () => {
const turn = deferred<string[]>();
const handshake = deferred<Awaited<ReturnType<typeof spawnDetached>>>();
@@ -54,23 +54,6 @@ it('downloads the driver-matched Simulator runner and retains its XCTest framewo
).toBe(true);
});
it('uses the runner of a prepared Appium home without a download', async () => {
await fs.promises.mkdir(runner, { recursive: true });
await expect(preparePreinstalledWdaAsync({ ...options, prepared: true })).resolves.toEqual({
'appium:usePreinstalledWDA': true,
'appium:prebuiltWDAPath': runner,
});
await expect(
preparePreinstalledWdaAsync({
...options,
prepared: true,
runtimeIdentifier: 'com.apple.CoreSimulator.SimRuntime.iOS-16-4',
})
).resolves.toEqual({});
expect(spawn).not.toHaveBeenCalled();
expect(fs.existsSync(runner)).toBe(true);
});
it.each([
undefined,
'com.apple.CoreSimulator.SimRuntime.iOS-16-4',
@@ -11,8 +11,9 @@ jest.mock('node-fetch', () => {
};
});
import { SandboxDaemonErrorCode } from '@expo/eas-build-job';
import { SandboxDaemonErrorCode, SystemError } from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { type Client, CombinedError } from '@urql/core';
import fetch, { type RequestInit } from 'node-fetch';
import fs from 'node:fs/promises';
import os from 'node:os';
@@ -23,8 +24,6 @@ import { setTimeout as delay } from 'node:timers/promises';
import { inspect } from 'node:util';
import { SandboxArtifactUploadManager, startSandboxArtifactUploadAsync } from '../sandboxArtifacts';
import { type SandboxWorkerApi } from '../sandboxWorkerApi';
import { WorkerApiError } from '../workerApi';
const { AbortError, FetchError, Response } = jest.requireActual(
'node-fetch'
@@ -34,18 +33,25 @@ const ARTIFACT_ID = '0199c0de-7b3a-7c1e-8f00-1234567890ab';
const SIGNED_URL = 'https://uploads.expo.test/artifact?X-Amz-Signature=secret-signature';
const DOWNLOAD_URL = 'https://downloads.expo.test/artifact?X-Amz-Signature=download-signature';
const createdSession = {
artifact: { id: ARTIFACT_ID },
uploadSession: { url: SIGNED_URL, headers: { 'If-None-Match': '*' } },
const createdResult = {
data: {
sandbox: {
createArtifactUploadSession: {
artifact: { id: ARTIFACT_ID },
uploadSession: { url: SIGNED_URL, headers: { 'If-None-Match': '*' } },
},
},
},
};
const finalizedResult = {
data: { sandbox: { finalizeArtifact: { id: ARTIFACT_ID, downloadUrl: DOWNLOAD_URL } } },
};
describe('sandbox artifact uploads', () => {
let directory: string;
let filePath: string;
let workerApi: {
createArtifactUploadSessionAsync: jest.Mock;
finalizeArtifactAsync: jest.Mock;
};
let mutation: jest.Mock;
let graphqlClient: Client;
let logger: { info: jest.Mock; error: jest.Mock };
let uploadArtifactAsync: (options: {
filePath: string;
@@ -58,14 +64,13 @@ describe('sandbox artifact uploads', () => {
filePath = path.join(directory, 'crash.log');
await fs.writeFile(filePath, 'crash');
jest.mocked(fetch).mockReset();
workerApi = {
createArtifactUploadSessionAsync: jest.fn(),
finalizeArtifactAsync: jest.fn(),
};
mutation = jest.fn();
logger = { info: jest.fn(), error: jest.fn() };
graphqlClient = { mutation } as unknown as Client;
uploadArtifactAsync = async options =>
await startSandboxArtifactUploadAsync({
workerApi: workerApi as unknown as SandboxWorkerApi,
graphqlClient,
sandboxId: 'sandbox-id',
logger: logger as unknown as bunyan,
...options,
});
@@ -76,7 +81,7 @@ describe('sandbox artifact uploads', () => {
});
it('returns the artifact id before the PUT completes', async () => {
mockWorkerApi({ finalize: DOWNLOAD_URL });
mockMutationResults(createdResult, finalizedResult);
let respond!: (response: InstanceType<typeof Response>) => void;
jest.mocked(fetch).mockReturnValueOnce(
new Promise(resolve => {
@@ -91,29 +96,34 @@ describe('sandbox artifact uploads', () => {
});
expect(upload.id).toBe(ARTIFACT_ID);
expect(workerApi.createArtifactUploadSessionAsync).toHaveBeenCalledWith(
{ name: 'Crash log', filename: 'crash.log', size: 5 },
expect(mutation).toHaveBeenCalledTimes(1);
expect(mutation).toHaveBeenCalledWith(
expect.anything(),
{ sandboxId: 'sandbox-id', input: { name: 'Crash log', filename: 'crash.log', size: 5 } },
expect.anything()
);
expect(workerApi.finalizeArtifactAsync).not.toHaveBeenCalled();
respond(new Response('', { status: 200 }));
await expect(upload.completed).resolves.toEqual({
status: 'uploaded',
downloadUrl: DOWNLOAD_URL,
});
expect(workerApi.finalizeArtifactAsync).toHaveBeenCalledWith(
ARTIFACT_ID,
expect.objectContaining({ retries: 2 })
expect(mutation).toHaveBeenLastCalledWith(
expect.anything(),
{ artifactId: ARTIFACT_ID },
expect.anything()
);
expect(logger.error).not.toHaveBeenCalled();
});
it('sends exactly the stat size on every attempt when the file grows', async () => {
workerApi.createArtifactUploadSessionAsync.mockImplementationOnce(async () => {
await fs.appendFile(filePath, ' and more');
return createdSession;
});
workerApi.finalizeArtifactAsync.mockResolvedValueOnce(DOWNLOAD_URL);
mutation
.mockReturnValueOnce({
toPromise: async () => {
await fs.appendFile(filePath, ' and more');
return createdResult;
},
})
.mockReturnValueOnce({ toPromise: async () => finalizedResult });
const bodies: string[] = [];
const respondAfterReadingBody =
(status: number) =>
@@ -143,7 +153,7 @@ describe('sandbox artifact uploads', () => {
it('uploads an empty file with an empty body', async () => {
await fs.writeFile(filePath, '');
mockWorkerApi({ finalize: DOWNLOAD_URL });
mockMutationResults(createdResult, finalizedResult);
let body: string | undefined;
jest.mocked(fetch).mockImplementationOnce((async (_url: unknown, init?: RequestInit) => {
const chunks: Buffer[] = [];
@@ -161,8 +171,9 @@ describe('sandbox artifact uploads', () => {
});
await upload.completed;
expect(workerApi.createArtifactUploadSessionAsync).toHaveBeenCalledWith(
{ name: 'Empty log', filename: 'crash.log', size: 0 },
expect(mutation).toHaveBeenCalledWith(
expect.anything(),
{ sandboxId: 'sandbox-id', input: { name: 'Empty log', filename: 'crash.log', size: 0 } },
expect.anything()
);
expect(body).toBe('');
@@ -170,7 +181,7 @@ describe('sandbox artifact uploads', () => {
});
it('finalizes when a retry fails the upload precondition', async () => {
mockWorkerApi({ finalize: DOWNLOAD_URL });
mockMutationResults(createdResult, finalizedResult);
jest
.mocked(fetch)
.mockRejectedValueOnce(
@@ -188,20 +199,33 @@ describe('sandbox artifact uploads', () => {
await upload.completed;
expect(fetch).toHaveBeenCalledTimes(2);
expect(workerApi.finalizeArtifactAsync).toHaveBeenCalledWith(ARTIFACT_ID, expect.anything());
expect(mutation).toHaveBeenLastCalledWith(
expect.anything(),
{ artifactId: ARTIFACT_ID },
expect.anything()
);
expect(logger.error).not.toHaveBeenCalled();
expect(logger.info).toHaveBeenLastCalledWith(
`Uploaded sandbox artifact "Crash log" (${ARTIFACT_ID}, 5 bytes).`
);
});
it('logs a finalize failure and reports the upload as failed', async () => {
mockWorkerApi({
finalize: new WorkerApiError(
'POST /v2/sandbox-worker/artifacts/x/finalize failed with status 502: Bad Gateway',
502
),
});
it('retries finalize after a server error and logs a failure that persists', async () => {
mockMutationResults(
createdResult,
{
error: new CombinedError({
networkError: new Error('Bad Gateway'),
response: { status: 502 },
}),
},
{
error: new CombinedError({
graphQLErrors: ['Sandbox artifact "Crash log" has no uploaded file.'],
response: { status: 200 },
}),
}
);
jest.mocked(fetch).mockResolvedValueOnce(new Response('', { status: 200 }));
const upload = await uploadArtifactAsync({
@@ -211,23 +235,21 @@ describe('sandbox artifact uploads', () => {
});
await expect(upload.completed).resolves.toEqual({ status: 'failed' });
expect(mutation).toHaveBeenCalledTimes(3);
expect(logger.error).toHaveBeenCalledWith(
expect.anything(),
`Uploaded sandbox artifact "Crash log" (${ARTIFACT_ID}), but could not finalize it.`
);
});
it.each([
{ status: 400, code: 'VALIDATION_ERROR' },
{ status: 403, code: 'UNAUTHORIZED' },
])(
'rejects a $code upload session error as a bad request with the API message',
async ({ status, code }) => {
it.each(['VALIDATION_ERROR', 'UNAUTHORIZED'])(
'rejects a %s upload session error as a bad request with the GraphQL message',
async errorCode => {
const message =
'POST /v2/sandbox-worker/artifact-upload-sessions failed with status 400: Sandbox already has an artifact named "Crash log". Use a different name for this artifact.';
workerApi.createArtifactUploadSessionAsync.mockRejectedValueOnce(
new WorkerApiError(message, status, undefined, code)
);
'Sandbox already has an artifact named "Crash log". Use a different name for this artifact.';
mockMutationResults({
error: new CombinedError({ graphQLErrors: [{ message, extensions: { errorCode } }] }),
});
const upload = uploadArtifactAsync({
filePath,
@@ -243,16 +265,23 @@ describe('sandbox artifact uploads', () => {
}
);
it.each([
{ status: 500, code: 'UNEXPECTED_ERROR' },
{ status: 401, code: 'AUTHENTICATION_ERROR' },
])('rethrows a $code upload session error unchanged', async ({ status, code }) => {
const error = new WorkerApiError('Request failed.', status, undefined, code);
workerApi.createArtifactUploadSessionAsync.mockRejectedValueOnce(error);
it('rejects an unexpected upload session error as a system error', async () => {
mockMutationResults({
error: new CombinedError({
graphQLErrors: [
{ message: 'Request failed.', extensions: { errorCode: 'UNEXPECTED_ERROR' } },
],
}),
});
await expect(
uploadArtifactAsync({ filePath, name: 'Crash log', signal: new AbortController().signal })
).rejects.toBe(error);
const upload = uploadArtifactAsync({
filePath,
name: 'Crash log',
signal: new AbortController().signal,
});
await expect(upload).rejects.toBeInstanceOf(SystemError);
await expect(upload).rejects.toMatchObject({ message: 'Request failed.' });
});
it('rejects a missing file as a bad request without creating an upload session', async () => {
@@ -268,11 +297,11 @@ describe('sandbox artifact uploads', () => {
code: SandboxDaemonErrorCode.BAD_REQUEST,
message: `File does not exist: ${missingPath}`,
});
expect(workerApi.createArtifactUploadSessionAsync).not.toHaveBeenCalled();
expect(mutation).not.toHaveBeenCalled();
});
it('keeps the signed URL out of logs', async () => {
mockWorkerApi({});
mockMutationResults(createdResult);
jest.mocked(fetch).mockRejectedValue(
new FetchError(`request to ${SIGNED_URL} failed, reason: socket hang up`, 'system', {
code: 'ECONNRESET',
@@ -294,7 +323,7 @@ describe('sandbox artifact uploads', () => {
});
it('waits for an aborted upload before the manager reports that it stopped', async () => {
mockWorkerApi({});
mockMutationResults(createdResult);
mockPutUntilAborted();
const controller = new AbortController();
const manager = createManager(controller.signal);
@@ -317,24 +346,36 @@ describe('sandbox artifact uploads', () => {
).rejects.toMatchObject({
name: 'AbortError',
});
expect(workerApi.createArtifactUploadSessionAsync).toHaveBeenCalledTimes(1);
expect(mutation).toHaveBeenCalledTimes(1);
});
it.each([
{
case: 'a finalized upload as uploaded with its download URL',
finalize: DOWNLOAD_URL,
finalizeResult: finalizedResult,
outcome: { status: 'uploaded', downloadUrl: DOWNLOAD_URL },
},
{
case: 'a failed finalization as failed',
finalize: new WorkerApiError('Sandbox artifact "Crash log" has no uploaded file.', 400),
finalizeResult: {
error: new CombinedError({
graphQLErrors: ['Sandbox artifact "Crash log" has no uploaded file.'],
response: { status: 200 },
}),
},
outcome: { status: 'failed' },
},
{
case: 'a finalized artifact without a download URL as failed',
finalizeResult: {
data: { sandbox: { finalizeArtifact: { id: ARTIFACT_ID, downloadUrl: null } } },
},
outcome: { status: 'failed' },
},
])(
'waits for an upload that ends within the yield time and reports $case',
async ({ finalize, outcome }) => {
mockWorkerApi({ finalize });
async ({ finalizeResult, outcome }) => {
mockMutationResults(createdResult, finalizeResult);
jest.mocked(fetch).mockResolvedValueOnce(new Response('', { status: 200 }));
const manager = createManager(new AbortController().signal);
@@ -349,10 +390,12 @@ describe('sandbox artifact uploads', () => {
const finalizeCalledPromise = new Promise<void>(resolve => {
finalizeCalled = resolve;
});
mockWorkerApi({});
workerApi.finalizeArtifactAsync.mockImplementationOnce(async () => {
finalizeCalled();
return DOWNLOAD_URL;
mockMutationResults(createdResult);
mutation.mockReturnValueOnce({
toPromise: async () => {
finalizeCalled();
return finalizedResult;
},
});
let respond!: (response: InstanceType<typeof Response>) => void;
jest.mocked(fetch).mockReturnValueOnce(
@@ -370,9 +413,11 @@ describe('sandbox artifact uploads', () => {
});
it('counts upload session creation toward the yield time', async () => {
workerApi.createArtifactUploadSessionAsync.mockImplementationOnce(async () => {
await delay(400);
return createdSession;
mutation.mockReturnValueOnce({
toPromise: async () => {
await delay(400);
return createdResult;
},
});
mockPutUntilAborted();
const controller = new AbortController();
@@ -389,7 +434,8 @@ describe('sandbox artifact uploads', () => {
function createManager(signal: AbortSignal): SandboxArtifactUploadManager {
return new SandboxArtifactUploadManager({
workerApi: workerApi as unknown as SandboxWorkerApi,
graphqlClient,
sandboxId: 'sandbox-id',
logger: logger as unknown as bunyan,
signal,
});
@@ -405,12 +451,9 @@ describe('sandbox artifact uploads', () => {
}) as unknown as typeof fetch);
}
function mockWorkerApi({ finalize }: { finalize?: string | Error }): void {
workerApi.createArtifactUploadSessionAsync.mockResolvedValueOnce(createdSession);
if (finalize instanceof Error) {
workerApi.finalizeArtifactAsync.mockRejectedValueOnce(finalize);
} else if (finalize !== undefined) {
workerApi.finalizeArtifactAsync.mockResolvedValueOnce(finalize);
function mockMutationResults(...results: unknown[]): void {
for (const result of results) {
mutation.mockReturnValueOnce({ toPromise: async () => result });
}
}
});
@@ -1,12 +1,12 @@
import { SandboxDaemonResponseZ, SystemError } from '@expo/eas-build-job';
import Log from '@expo/logger';
import { type Client } from '@urql/core';
import http from 'node:http';
import net, { AddressInfo } from 'node:net';
import WebSocket, { WebSocketServer } from 'ws';
import * as sandboxCommandImplementations from '../sandboxCommandImplementations';
import { startSandboxDaemonAsync } from '../sandboxDaemon';
import { type SandboxWorkerApi } from '../sandboxWorkerApi';
jest.unmock('@expo/logger');
jest.unmock('fs');
@@ -16,7 +16,7 @@ jest.unmock('node:fs/promises');
describe(startSandboxDaemonAsync.name, () => {
const logger = Log.child({ buildStepId: 'sandbox-test' });
const workerApi = {} as SandboxWorkerApi;
const graphqlClient = {} as Client;
it.each(['ftp://localhost', 'not a URL'])('reports invalid server URL %s', async serverUrl => {
const errorLog = jest.spyOn(logger, 'error').mockImplementation(() => {});
const daemon = await startSandboxDaemonAsync({
@@ -26,7 +26,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
try {
await expect(daemon.ready).rejects.toBeInstanceOf(SystemError);
@@ -52,7 +53,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
try {
const socket = await connection;
@@ -87,7 +89,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
try {
await expect(daemon.ready).rejects.toBeInstanceOf(SystemError);
@@ -118,7 +121,8 @@ describe(startSandboxDaemonAsync.name, () => {
signal: controller.signal,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
const connectionError = daemon.ready.catch(error => error);
@@ -147,7 +151,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
await expect(daemon.ready).rejects.toThrow('Sandbox MCP server connection failed');
@@ -181,7 +186,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
const socket = await connection;
const daemon = await daemonPromise;
@@ -213,7 +219,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
const socket = await connection;
await daemon.ready;
@@ -257,7 +264,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
const socket = await connection;
await daemon.ready;
@@ -342,7 +350,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
const socket = await connection;
await daemon.ready;
@@ -387,7 +396,8 @@ describe(startSandboxDaemonAsync.name, () => {
logger,
workingDirectory: process.cwd(),
env: process.env,
workerApi,
graphqlClient,
sandboxId: 'sandbox-id',
});
const socket = await connection;
const daemon = await daemonPromise;
@@ -5,6 +5,7 @@ jest.unmock('node:fs/promises');
import { type SandboxDaemonCommandResult, SandboxDaemonErrorCode } from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { type Client } from '@urql/core';
import fetch from 'node-fetch';
import { readFileSync, statSync } from 'node:fs';
import fs, { type FileHandle } from 'node:fs/promises';
@@ -18,7 +19,6 @@ import {
type SandboxDaemonCommandImplementations,
createSandboxCommandImplementations,
} from '../sandboxCommandImplementations';
import { type SandboxWorkerApi } from '../sandboxWorkerApi';
const READ_FILE_LIMITS = { maxTextBytes: 40_000, maxImageBytes: 3_000_000 };
const FIXTURES_DIRECTORY = path.join(__dirname, 'fixtures');
@@ -31,25 +31,22 @@ describe('sandbox daemon commands', () => {
let commandImplementations: SandboxDaemonCommandImplementations;
let stopAsync: () => Promise<void>;
let workingDirectory: string;
let workerApi: {
createArtifactUploadSessionAsync: jest.Mock;
finalizeArtifactAsync: jest.Mock;
};
let mutation: jest.Mock;
let graphqlClient: Client;
let logger: bunyan;
beforeEach(async () => {
workingDirectory = await fs.mkdtemp(path.join(os.tmpdir(), 'sandbox-command-executor-'));
workerApi = {
createArtifactUploadSessionAsync: jest.fn(),
finalizeArtifactAsync: jest.fn(),
};
mutation = jest.fn();
graphqlClient = { mutation } as unknown as Client;
logger = { info: jest.fn(), error: jest.fn() } as unknown as bunyan;
const controller = new AbortController();
const commands = createSandboxCommandImplementations({
workingDirectory,
env: process.env,
signal: controller.signal,
workerApi: workerApi as unknown as SandboxWorkerApi,
graphqlClient,
sandboxId: 'sandbox-id',
logger,
});
commandImplementations = commands.commandImplementations;
@@ -78,7 +75,8 @@ describe('sandbox daemon commands', () => {
workingDirectory,
env: process.env,
signal: controller.signal,
workerApi: workerApi as unknown as SandboxWorkerApi,
graphqlClient,
sandboxId: 'sandbox-id',
logger,
});
const command = commands.commandImplementations.execCommand({ cmd: 'printf should-not-run' });
@@ -432,17 +430,37 @@ describe('sandbox daemon commands', () => {
`${path.join(workingDirectory, 'dist')} is not a regular file. To upload a directory, create an archive first`
),
});
expect(workerApi.createArtifactUploadSessionAsync).not.toHaveBeenCalled();
expect(mutation).not.toHaveBeenCalled();
});
it('uploads an artifact from a path relative to the working directory and waits for it by default', async () => {
await fs.mkdir(path.join(workingDirectory, 'logs'));
await fs.writeFile(path.join(workingDirectory, 'logs', 'crash.log'), 'crash');
workerApi.createArtifactUploadSessionAsync.mockResolvedValueOnce({
artifact: { id: ARTIFACT_ID },
uploadSession: { url: 'https://uploads.expo.test/artifact', headers: {} },
});
workerApi.finalizeArtifactAsync.mockResolvedValueOnce('https://downloads.expo.test/artifact');
mutation
.mockReturnValueOnce({
toPromise: async () => ({
data: {
sandbox: {
createArtifactUploadSession: {
artifact: { id: ARTIFACT_ID },
uploadSession: { url: 'https://uploads.expo.test/artifact', headers: {} },
},
},
},
}),
})
.mockReturnValueOnce({
toPromise: async () => ({
data: {
sandbox: {
finalizeArtifact: {
id: ARTIFACT_ID,
downloadUrl: 'https://downloads.expo.test/artifact',
},
},
},
}),
});
jest.mocked(fetch).mockResolvedValueOnce(new Response('', { status: 200 }));
const result = await commandImplementations.uploadArtifact({
@@ -455,8 +473,9 @@ describe('sandbox daemon commands', () => {
status: 'uploaded',
downloadUrl: 'https://downloads.expo.test/artifact',
});
expect(workerApi.createArtifactUploadSessionAsync).toHaveBeenCalledWith(
{ name: 'Crash log', filename: 'crash.log', size: 5 },
expect(mutation).toHaveBeenCalledWith(
expect.anything(),
{ sandboxId: 'sandbox-id', input: { name: 'Crash log', filename: 'crash.log', size: 5 } },
expect.anything()
);
});
@@ -1,132 +0,0 @@
import { ArchiveSourceType, EnvironmentSecretType, type Job } from '@expo/eas-build-job';
import { turtleFetch } from '../../../utils/turtleFetch';
import { SandboxWorkerApi, getSandboxWorkerApi } from '../sandboxWorkerApi';
jest.mock('../../../utils/turtleFetch');
jest.unmock('node-fetch');
const { Response } = jest.requireActual('node-fetch') as typeof import('node-fetch');
const BASE_URL = 'https://api.expo.test/v2/';
const TOKEN = 'sandbox-worker-token-value';
const ARTIFACT_ID = '0199c0de-7b3a-7c1e-8f00-1234567890ab';
function jsonResponse(body: unknown): InstanceType<typeof Response> {
return new Response(JSON.stringify(body), {
status: 200,
headers: { 'Content-Type': 'application/json' },
});
}
describe(getSandboxWorkerApi, () => {
beforeEach(() => {
jest.mocked(turtleFetch).mockReset();
});
it('returns null when the job has no sandbox worker token', () => {
expect(
getSandboxWorkerApi({
job: { secrets: { environmentSecrets: [] } } as unknown as Job,
env: { EAS_SANDBOX_WORKER_TOKEN: TOKEN },
expoApiV2BaseUrl: BASE_URL,
})
).toBeNull();
});
it('reads the token from the job secrets', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(jsonResponse({ data: { id: 'sandbox-id' } }));
const api = getSandboxWorkerApi({
job: {
secrets: {
environmentSecrets: [
{ name: 'EAS_SANDBOX_WORKER_TOKEN', type: EnvironmentSecretType.STRING, value: TOKEN },
],
},
} as unknown as Job,
env: {},
expoApiV2BaseUrl: BASE_URL,
});
await api!.markReadyAsync();
expect(jest.mocked(turtleFetch)).toHaveBeenCalledWith(
'https://api.expo.test/v2/sandbox-worker/ready',
'POST',
expect.objectContaining({ headers: { 'expo-sandbox-worker-token': TOKEN } })
);
});
});
describe(SandboxWorkerApi, () => {
beforeEach(() => {
jest.mocked(turtleFetch).mockReset();
});
it.each([
{
name: 'getProjectArchiveSourceAsync',
call: (api: SandboxWorkerApi) => api.getProjectArchiveSourceAsync(),
route: 'project-archive',
json: undefined,
data: { type: ArchiveSourceType.URL, url: 'https://storage.expo.test/project.tar.gz' },
expected: { type: ArchiveSourceType.URL, url: 'https://storage.expo.test/project.tar.gz' },
},
{
name: 'markReadyAsync',
call: (api: SandboxWorkerApi) => api.markReadyAsync(),
route: 'ready',
json: undefined,
data: { id: 'sandbox-id' },
expected: undefined,
},
{
name: 'createArtifactUploadSessionAsync',
call: (api: SandboxWorkerApi) =>
api.createArtifactUploadSessionAsync({ name: 'Crash log', filename: 'crash.log', size: 5 }),
route: 'artifact-upload-sessions',
json: { name: 'Crash log', filename: 'crash.log', size: 5 },
data: {
artifact: { id: ARTIFACT_ID },
uploadSession: { url: 'https://uploads.expo.test/a', headers: { 'If-None-Match': '*' } },
},
expected: {
artifact: { id: ARTIFACT_ID },
uploadSession: { url: 'https://uploads.expo.test/a', headers: { 'If-None-Match': '*' } },
},
},
{
name: 'finalizeArtifactAsync',
call: (api: SandboxWorkerApi) => api.finalizeArtifactAsync(ARTIFACT_ID),
route: `artifacts/${ARTIFACT_ID}/finalize`,
json: undefined,
data: { id: ARTIFACT_ID, downloadUrl: 'https://downloads.expo.test/a' },
expected: 'https://downloads.expo.test/a',
},
])(
'$name calls POST /v2/sandbox-worker/$route with the sandbox worker token header',
async ({ call, route, json, data, expected }) => {
jest.mocked(turtleFetch).mockResolvedValueOnce(jsonResponse({ data }));
await expect(call(new SandboxWorkerApi(BASE_URL, TOKEN))).resolves.toEqual(expected);
const [url, method, options] = jest.mocked(turtleFetch).mock.calls[0];
expect(url).toBe(`https://api.expo.test/v2/sandbox-worker/${route}`);
expect(method).toBe('POST');
expect(options.headers).toEqual({ 'expo-sandbox-worker-token': TOKEN });
expect(options.json).toEqual(json);
}
);
it('escapes the artifact ID in the finalize route', async () => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(jsonResponse({ data: { id: 'a', downloadUrl: 'https://d.test/a' } }));
await new SandboxWorkerApi(BASE_URL, TOKEN).finalizeArtifactAsync('../ready');
expect(jest.mocked(turtleFetch).mock.calls[0][0]).toBe(
'https://api.expo.test/v2/sandbox-worker/artifacts/..%2Fready/finalize'
);
});
});
@@ -16,11 +16,7 @@ import os from 'node:os';
import path from 'node:path';
import { WebSocketServer } from 'ws';
import {
runServeSimActionAsync,
runServeSimActionWithResultAsync,
stageServeSimAppAsync,
} from '../serveSimActions';
import { runServeSimActionAsync, stageServeSimAppAsync } from '../serveSimActions';
jest.unmock('fs');
jest.unmock('node:fs');
@@ -71,18 +67,6 @@ it('authenticates the upgrade, waits for ready, and sends the action once', asyn
expect(actions).toEqual([{ id: 1, action: 'app.install', params: request().params }]);
});
it('returns stdout from an authenticated action for catalog inspection', async () => {
server.on('connection', socket => {
socket.on('message', () =>
socket.send(JSON.stringify({ id: 1, stdout: '{"actions":[]}', exitCode: 0 }))
);
socket.send(JSON.stringify({ ready: true }));
});
await expect(
runServeSimActionWithResultAsync({ ...request(), action: 'actions.describe', params: {} })
).resolves.toBe('{"actions":[]}');
});
it.each([
[{ id: 1, exitCode: 1, stderr: 'install refused' }, 'install refused'],
[{ id: 1, error: 'unknown action app.install' }, 'unknown action'],
@@ -153,55 +137,6 @@ it('aborts an in-flight action without resending it', async () => {
expect(attempts).toBe(1);
});
it('cancels before dispatch while waiting for ready in drain mode', async () => {
const controller = new AbortController();
const actions = jest.fn();
server.on('connection', socket => {
socket.on('message', actions);
controller.abort(new Error('stopped before ready'));
socket.send(JSON.stringify({ ready: true }));
});
await expect(
runServeSimActionAsync({
...request(),
signal: controller.signal,
drainAfterDispatch: true,
})
).rejects.toThrow('stopped before ready');
expect(actions).not.toHaveBeenCalled();
});
it('drains dispatched actions after cancellation in drain mode', async () => {
const controller = new AbortController();
let reply!: () => void;
let dispatched!: () => void;
const ready = new Promise<void>(resolve => {
dispatched = resolve;
});
server.on('connection', socket => {
socket.send(JSON.stringify({ ready: true }));
socket.on('message', () => {
reply = () => socket.send(JSON.stringify({ id: 1, stdout: 'completed', exitCode: 0 }));
dispatched();
});
});
let settled = false;
const action = runServeSimActionAsync({
...request(),
signal: controller.signal,
drainAfterDispatch: true,
});
void action.finally(() => {
settled = true;
});
await ready;
controller.abort(new Error('stopped after dispatch'));
await new Promise(resolve => setImmediate(resolve));
expect(settled).toBe(false);
reply();
await expect(action).resolves.toBeUndefined();
});
it('does not connect when already aborted', async () => {
const connected = jest.fn();
server.on('connection', connected);
@@ -1,153 +0,0 @@
import { mkdir, readFile, readdir, writeFile } from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import { runServeSimActionAsync, runServeSimActionWithResultAsync } from '../serveSimActions';
import { createServeSimPreviewCapture } from '../serveSimPreviewCapture';
jest.mock('../serveSimActions');
const signal = new AbortController().signal;
const tmpdir = path.join(os.tmpdir(), 'host-tmp');
const staging = path.join(tmpdir, 'serve-sim-screenshots');
const destination = path.join(os.tmpdir(), 'screen.png');
const png = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0xff, 0x00]);
const options = { port: 1234, token: 'host-token', device: 'selected-udid', tmpdir };
beforeEach(async () => {
await mkdir(staging, { recursive: true });
jest.mocked(runServeSimActionAsync).mockReset();
});
it('captures the selected active display and removes only its own staging', async () => {
await writeFile(path.join(staging, 'unrelated.png'), 'keep');
jest.mocked(runServeSimActionAsync).mockImplementation(async request => {
expect(request).toEqual({
port: 1234,
token: 'host-token',
action: 'screenshot.capture',
params: {
udid: 'selected-udid',
fileName: expect.stringMatching(/^serve-sim-screenshot-preview-.*\.png$/),
automation: true,
},
timeoutMs: 30_000,
signal,
drainAfterDispatch: true,
});
await writeFile(path.join(staging, request.params.fileName as string), png);
return;
});
const capture = createServeSimPreviewCapture(options);
await capture.captureAsync(destination, signal);
expect(await readFile(destination)).toEqual(png);
expect(await readdir(staging)).toEqual(['unrelated.png']);
});
it('drains an already sent action before honoring abort and deleting its output', async () => {
const controller = new AbortController();
let complete!: () => void;
const pending = new Promise<void>(resolve => {
complete = resolve;
});
let staged!: string;
jest.mocked(runServeSimActionAsync).mockImplementation(async request => {
staged = path.join(staging, request.params.fileName as string);
await pending;
await writeFile(staged, png);
return;
});
const capture = createServeSimPreviewCapture(options);
let settled = false;
const capturing = capture.captureAsync(destination, controller.signal);
void capturing.then(
() => {
settled = true;
},
() => {
settled = true;
}
);
controller.abort(new Error('session stopped'));
await Promise.resolve();
expect(settled).toBe(false);
complete();
await expect(capturing).rejects.toThrow('session stopped');
expect(await readdir(staging)).toEqual([]);
});
it.each(['timed out', 'connection closed'])(
'keeps a possibly writable file after %s until the host stops',
async message => {
let staged!: string;
jest.mocked(runServeSimActionAsync).mockImplementation(async request => {
staged = path.join(staging, request.params.fileName as string);
await writeFile(staged, 'reservation');
throw new Error(message);
});
const capture = createServeSimPreviewCapture(options);
await expect(capture.captureAsync(destination, signal)).rejects.toThrow(message);
expect(await readFile(staged, 'utf8')).toBe('reservation');
// The server may still write after the client's deadline or disconnect.
await writeFile(staged, png);
await capture.cleanupAfterHostStoppedAsync();
expect(await readdir(staging)).toEqual([]);
}
);
it('attempts every owned cleanup when one file cannot be removed', async () => {
let blocked!: string;
let count = 0;
jest.mocked(runServeSimActionAsync).mockImplementation(async request => {
const staged = path.join(staging, request.params.fileName as string);
if (count++ === 0) {
blocked = staged;
await mkdir(staged);
} else {
await writeFile(staged, png);
}
throw new Error('capture disconnected');
});
const capture = createServeSimPreviewCapture(options);
await expect(capture.captureAsync(destination, signal)).rejects.toThrow('disconnected');
await expect(capture.captureAsync(destination, signal)).rejects.toThrow('disconnected');
await expect(capture.cleanupAfterHostStoppedAsync()).rejects.toThrow(
'Could not remove preview captures'
);
expect(await readdir(staging)).toEqual([path.basename(blocked)]);
});
it('does not send a capture when already aborted', async () => {
const capture = createServeSimPreviewCapture(options);
await expect(
capture.captureAsync(destination, AbortSignal.abort(new Error('stopped')))
).rejects.toThrow('stopped');
expect(runServeSimActionAsync).not.toHaveBeenCalled();
});
it.each([
[
{ 'screenshot.capture': { properties: { automation: { type: 'boolean', default: false } } } },
true,
],
[{ 'screenshot.capture': { properties: {} } }, false],
[{ 'screenshot.capture': { properties: { automation: { type: 'string' } } } }, false],
[{}, false],
[null, false],
])(
'checks the catalog automation field before enabling captures (%j)',
async (catalog, supported) => {
jest.mocked(runServeSimActionWithResultAsync).mockResolvedValueOnce(JSON.stringify(catalog));
const capture = createServeSimPreviewCapture(options);
await expect(capture.isSupportedAsync(signal)).resolves.toBe(supported);
expect(runServeSimActionWithResultAsync).toHaveBeenCalledWith({
port: options.port,
token: options.token,
action: 'actions.describe',
params: {},
timeoutMs: 30_000,
signal,
});
expect(runServeSimActionAsync).not.toHaveBeenCalled();
}
);
@@ -2,8 +2,6 @@ import { type bunyan } from '@expo/logger';
import spawn from '@expo/turtle-spawn';
import { type CustomBuildContext } from '../../../customBuildContext';
import { resolveSimulatorPackageVersionAsync } from '../../../utils/simulatorPackageVersion';
import { stopWarmSimulatorAsync } from '../../../utils/warmSimulator';
import { IosSimulatorRecordingUtils } from '../IosSimulatorRecordingUtils';
import { fetchWebPreviewTurnArgsAsync } from '../remoteDeviceRunSession';
import {
@@ -14,8 +12,6 @@ import {
import { type WarmIosSession, tryClaimWarmIosSessionAsync } from '../warmIosSession';
jest.mock('@expo/turtle-spawn');
jest.mock('../../../utils/simulatorPackageVersion');
jest.mock('../../../utils/warmSimulator');
jest.mock('../IosSimulatorRecordingUtils');
jest.mock('../warmIosSession');
jest.mock('../remoteDeviceRunSession', () => ({
@@ -67,11 +63,9 @@ beforeEach(() => {
});
it('adopts the warm device on the warm port with its recording, then prepares tools', async () => {
warm.serveSimVersion = '0.13.3';
const server = createWarmDeviceSessionServer(ctx, logger, warm);
expect(server).toMatchObject({
port: 3200,
serveSimVersion: '0.13.3',
requiresPreviewRetirement: true,
preinstalledApp: warm.preinstalledExpoGo,
});
@@ -131,7 +125,7 @@ describe(runOnWarmIosSimulatorAsync, () => {
jest.mocked(tryClaimWarmIosSessionAsync).mockResolvedValue(undefined);
const run = jest.fn().mockResolvedValue('cold');
await expect(runOnWarmIosSimulatorAsync(claim, run)).resolves.toBe('cold');
expect(run).toHaveBeenCalledWith(undefined, undefined);
expect(run).toHaveBeenCalledWith(undefined);
});
it('runs on the claimed warm Simulator', async () => {
@@ -139,7 +133,7 @@ describe(runOnWarmIosSimulatorAsync, () => {
const run = jest.fn().mockResolvedValue('warm');
await expect(runOnWarmIosSimulatorAsync(claim, run)).resolves.toBe('warm');
expect(run).toHaveBeenCalledTimes(1);
expect(run).toHaveBeenCalledWith(warm, undefined);
expect(run).toHaveBeenCalledWith(warm);
});
it('stops warmup and runs cold after an adoption failure', async () => {
@@ -150,71 +144,7 @@ describe(runOnWarmIosSimulatorAsync, () => {
.mockResolvedValueOnce('cold');
await expect(runOnWarmIosSimulatorAsync(claim, run)).resolves.toBe('cold');
expect(warm.process.stopAsync).toHaveBeenCalledTimes(1);
expect(run).toHaveBeenLastCalledWith(undefined, undefined);
});
it.each([true, false])(
'uses the resolved request for claim and setup (warm: %s)',
async reuse => {
jest.mocked(resolveSimulatorPackageVersionAsync).mockResolvedValue('0.14.0');
jest.mocked(tryClaimWarmIosSessionAsync).mockResolvedValue(reuse ? warm : undefined);
const request = { ...claim, env: { EAS_USE_WARM_SIMULATOR: '1' }, packageVersion: 'latest' };
const run = jest.fn().mockResolvedValue('done');
await expect(runOnWarmIosSimulatorAsync(request, run)).resolves.toBe('done');
expect(tryClaimWarmIosSessionAsync).toHaveBeenCalledWith({
...request,
packageVersion: '0.14.0',
});
expect(run).toHaveBeenCalledWith(reuse ? warm : undefined, '0.14.0');
}
);
it('keeps the resolved version through an adoption failure', async () => {
jest.mocked(resolveSimulatorPackageVersionAsync).mockResolvedValue('0.14.0');
jest.mocked(tryClaimWarmIosSessionAsync).mockResolvedValue(warm);
const run = jest
.fn()
.mockRejectedValueOnce(new WarmSessionAdoptionError())
.mockResolvedValue('cold');
await runOnWarmIosSimulatorAsync(
{ ...claim, env: { EAS_USE_WARM_SIMULATOR: '1' }, packageVersion: 'latest' },
run
);
expect(resolveSimulatorPackageVersionAsync).toHaveBeenCalledTimes(1);
expect(run.mock.calls).toEqual([
[warm, '0.14.0'],
[undefined, '0.14.0'],
]);
});
it('stops warmup and fails when an explicit request cannot be resolved', async () => {
const error = new Error('lookup failed');
jest.mocked(resolveSimulatorPackageVersionAsync).mockRejectedValue(error);
const run = jest.fn();
await expect(
runOnWarmIosSimulatorAsync(
{ ...claim, env: { EAS_USE_WARM_SIMULATOR: '1' }, packageVersion: 'latest' },
run
)
).rejects.toBe(error);
expect(stopWarmSimulatorAsync).toHaveBeenCalledTimes(1);
expect(tryClaimWarmIosSessionAsync).not.toHaveBeenCalled();
expect(run).not.toHaveBeenCalled();
});
it('preserves lookup and cleanup failures without starting a session', async () => {
const lookup = new Error('lookup failed');
const cleanup = new Error('cleanup failed');
jest.mocked(resolveSimulatorPackageVersionAsync).mockRejectedValue(lookup);
jest.mocked(stopWarmSimulatorAsync).mockRejectedValue(cleanup);
const run = jest.fn();
await expect(
runOnWarmIosSimulatorAsync(
{ ...claim, env: { EAS_USE_WARM_SIMULATOR: '1' }, packageVersion: 'latest' },
run
)
).rejects.toMatchObject({ errors: [lookup, cleanup] });
expect(run).not.toHaveBeenCalled();
expect(run).toHaveBeenLastCalledWith(undefined);
});
it('does not run cold after a failure during the session', async () => {
@@ -4,7 +4,6 @@ import path from 'node:path';
import { runSimulatorLauncherAsync, stopWarmSimulatorAsync } from '../../../utils/warmSimulator';
import { readLocalEgressHandoffAsync } from '../localEgress';
import { runOnWarmIosSimulatorAsync } from '../warmDeviceSessionHost';
import { tryClaimWarmIosSessionAsync } from '../warmIosSession';
jest.mock('../../../utils/warmSimulator');
@@ -85,24 +84,6 @@ it('takes the preinstalled Expo Go that prepare-tools reports', async () => {
expect(session!.preinstalledExpoGo).toEqual(expoGo);
});
it('keeps the exact serve-sim version from the launcher claim', async () => {
jest
.mocked(runSimulatorLauncherAsync)
.mockResolvedValueOnce(JSON.stringify({ ...claim, serveSimVersion: '0.13.3' }));
const session = await tryClaimWarmIosSessionAsync({ engine: 'serve-sim', env, logger });
expect(session?.serveSimVersion).toBe('0.13.3');
});
it('stops warmup when the claim contains an invalid serve-sim version', async () => {
jest
.mocked(runSimulatorLauncherAsync)
.mockResolvedValueOnce(JSON.stringify({ ...claim, serveSimVersion: 'latest' }));
await expect(
tryClaimWarmIosSessionAsync({ engine: 'serve-sim', env, logger })
).resolves.toBeUndefined();
expect(stopWarmSimulatorAsync).toHaveBeenCalledTimes(1);
});
it('reads the agent-device server after tool preparation', async () => {
jest
.spyOn(fs, 'readFile')
@@ -140,6 +121,7 @@ it.each([
{},
() => jest.mocked(runSimulatorLauncherAsync).mockRejectedValue(new Error('no session')),
],
['a pinned package version', { packageVersion: '1.2.3' }, () => {}],
['a job Simulator setting', { env: { ...env, SIMCTL_CHILD_FOO: '1' } }, () => {}],
[
'a local egress session',
@@ -167,69 +149,3 @@ it('stops the claimed session once', async () => {
await Promise.all([session!.process.stopAsync(), session!.process.stopAsync()]);
expect(stopWarmSimulatorAsync).toHaveBeenCalledTimes(1);
});
it.each([
['serve-sim', 'serveSimVersion'],
['agent-device', 'agentDeviceVersion'],
['argent', 'argentVersion'],
] as const)(
'reuses %s only when its recorded version matches the resolved request',
async (engine, field) => {
jest
.mocked(runSimulatorLauncherAsync)
.mockResolvedValue(JSON.stringify({ ...claim, [field]: '1.2.3' }));
await expect(
tryClaimWarmIosSessionAsync({ engine, packageVersion: '1.2.3', env, logger })
).resolves.toBeDefined();
expect(stopWarmSimulatorAsync).not.toHaveBeenCalled();
await expect(
tryClaimWarmIosSessionAsync({ engine, packageVersion: '1.2.4', env, logger })
).resolves.toBeUndefined();
expect(stopWarmSimulatorAsync).toHaveBeenCalledTimes(1);
}
);
it.each(['serve-sim', 'agent-device', 'argent'] as const)(
'uses normal setup for %s when older claims omit its version',
async engine => {
await expect(
tryClaimWarmIosSessionAsync({ engine, packageVersion: '1.2.3', env, logger })
).resolves.toBeUndefined();
expect(stopWarmSimulatorAsync).toHaveBeenCalledTimes(1);
}
);
it('accepts a resolved prerelease pin for matching warm adoption', async () => {
jest
.mocked(runSimulatorLauncherAsync)
.mockResolvedValue(JSON.stringify({ ...claim, serveSimVersion: '0.13.4-beta.1+build.2' }));
await expect(
tryClaimWarmIosSessionAsync({
engine: 'serve-sim',
packageVersion: '0.13.4-beta.1+build.2',
env,
logger,
})
).resolves.toMatchObject({ serveSimVersion: '0.13.4-beta.1+build.2' });
expect(stopWarmSimulatorAsync).not.toHaveBeenCalled();
});
it('preserves exact build metadata through job resolution and warm claim', async () => {
const version = '0.13.4-beta.1+build.2';
jest
.mocked(runSimulatorLauncherAsync)
.mockResolvedValueOnce(JSON.stringify({ ...claim, serveSimVersion: version }));
const run = jest.fn(async (session, resolvedVersion) => {
expect(session?.serveSimVersion).toBe(version);
expect(resolvedVersion).toBe(version);
return 'warm';
});
await expect(
runOnWarmIosSimulatorAsync(
{ engine: 'serve-sim', packageVersion: `v${version}`, env, logger },
run
)
).resolves.toBe('warm');
expect(run).toHaveBeenCalledTimes(1);
expect(stopWarmSimulatorAsync).not.toHaveBeenCalled();
});
@@ -1,295 +0,0 @@
import { SystemError } from '@expo/eas-build-job';
import { FetchError } from 'node-fetch';
import { z } from 'zod';
import { turtleFetch } from '../../../utils/turtleFetch';
import {
WorkerApi,
WorkerApiError,
type WorkerApiRequestOptions,
getExpoApiV2BaseUrl,
} from '../workerApi';
jest.mock('../../../utils/turtleFetch');
jest.unmock('node-fetch');
const { Response } = jest.requireActual('node-fetch') as typeof import('node-fetch');
type Response = InstanceType<typeof Response>;
const BASE_URL = 'https://api.expo.test/v2/test-worker/';
const AUTH = { authHeader: 'expo-test-worker-token', token: 'test-worker-token-value' };
function jsonResponse(body: unknown, status = 200): Response {
return new Response(JSON.stringify(body), {
status,
headers: { 'Content-Type': 'application/json' },
});
}
const ThingSchema = z.object({ id: z.string() });
async function getThingAsync(options?: WorkerApiRequestOptions): Promise<{ id: string }> {
return await new WorkerApi(BASE_URL, AUTH).requestAsync('GET', 'thing', ThingSchema, options);
}
async function createThingAsync(
json: Record<string, unknown>,
options: WorkerApiRequestOptions = {}
): Promise<{ id: string }> {
return await new WorkerApi(BASE_URL, AUTH).requestAsync('POST', 'things', ThingSchema, {
...options,
json,
});
}
describe(getExpoApiV2BaseUrl, () => {
it('uses the API v2 base URL of the context', () => {
expect(
getExpoApiV2BaseUrl({
env: { __API_SERVER_URL: 'https://other.expo.test' },
expoApiV2BaseUrl: 'https://api.expo.test/v2/',
})
).toBe('https://api.expo.test/v2/');
});
it('derives the API v2 base URL from __API_SERVER_URL when the context has none', () => {
expect(getExpoApiV2BaseUrl({ env: { __API_SERVER_URL: 'https://api.expo.test' } })).toBe(
'https://api.expo.test/v2/'
);
});
it('throws a system error when no API URL is known', () => {
expect(() => getExpoApiV2BaseUrl({ env: {} })).toThrow(SystemError);
});
});
describe(WorkerApi, () => {
beforeEach(() => {
jest.mocked(turtleFetch).mockReset();
});
it('resolves routes under the worker router and sends only the worker auth header', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(jsonResponse({ data: { id: 'thing-id' } }));
await expect(createThingAsync({ name: 'a' })).resolves.toEqual({ id: 'thing-id' });
expect(jest.mocked(turtleFetch)).toHaveBeenCalledTimes(1);
const [url, method, options] = jest.mocked(turtleFetch).mock.calls[0];
expect(url).toBe('https://api.expo.test/v2/test-worker/things');
expect(method).toBe('POST');
expect(options.headers).toEqual({ 'expo-test-worker-token': 'test-worker-token-value' });
expect(options.json).toEqual({ name: 'a' });
expect(options).toEqual(expect.objectContaining({ retries: 0, shouldThrowOnNotOk: false }));
});
it('passes the signal and timeout without enabling nested retries', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(jsonResponse({ data: { id: 'thing-id' } }));
const controller = new AbortController();
await getThingAsync({ signal: controller.signal, timeoutMs: 5000, retries: 1 });
expect(jest.mocked(turtleFetch)).toHaveBeenCalledWith(
expect.any(String),
'GET',
expect.objectContaining({ signal: controller.signal, timeout: 5000, retries: 0 })
);
});
it('reports the API v2 error message, code and status without the token', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(
jsonResponse(
{
errors: [
{
code: 'UNAUTHORIZED_ERROR',
message: 'This worker no longer accepts requests.',
},
],
},
403
)
);
const error = await createThingAsync({}).catch(err => err);
expect(error).toBeInstanceOf(WorkerApiError);
expect(error.status).toBe(403);
expect(error.code).toBe('UNAUTHORIZED_ERROR');
expect(error.message).toBe(
'POST /v2/test-worker/things failed with status 403: This worker no longer accepts requests.'
);
expect(error.message).not.toContain(AUTH.token);
});
it('reports the status text when the error response is not an API v2 error', async () => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(
new Response('<html>bad gateway</html>', { status: 502, statusText: 'Bad Gateway' })
);
const error = await getThingAsync().catch(err => err);
expect(error).toBeInstanceOf(WorkerApiError);
expect(error.status).toBe(502);
expect(error.message).toBe('GET /v2/test-worker/thing failed with status 502: Bad Gateway');
});
it('reports a request that failed before www responded', async () => {
const reason = new Error('socket hang up');
jest.mocked(turtleFetch).mockRejectedValueOnce(reason);
const error = await getThingAsync().catch(err => err);
expect(error).toBeInstanceOf(WorkerApiError);
expect(error.status).toBeUndefined();
expect(error.isTransient).toBe(true);
expect(error.cause).toBe(reason);
expect(error.message).toContain('failed before www responded: socket hang up');
});
it('rejects a response that does not match the route contract', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(jsonResponse({ data: { id: 1 } }));
await expect(getThingAsync({ retries: 3 })).rejects.toThrow(
'GET /v2/test-worker/thing returned an unexpected response'
);
});
it('rejects a successful response that is not JSON', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('ok', { status: 200 }));
await expect(getThingAsync({ retries: 3 })).rejects.toThrow(
'GET /v2/test-worker/thing returned a response that is not JSON.'
);
});
});
describe('worker API retries', () => {
beforeEach(() => {
jest.useFakeTimers();
jest.mocked(turtleFetch).mockReset();
});
afterEach(() => {
jest.useRealTimers();
});
it.each([429, 500, 502, 503, 504])('recovers from HTTP %s', async status => {
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(new Response('unavailable', { status }))
.mockResolvedValueOnce(jsonResponse({ data: { id: 'thing-id' } }));
const result = createThingAsync({}, { retries: 3, timeoutMs: 30_000 });
const assertion = expect(result).resolves.toEqual({ id: 'thing-id' });
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
expect(jest.mocked(turtleFetch).mock.calls[1]).toEqual(jest.mocked(turtleFetch).mock.calls[0]);
expect(jest.mocked(turtleFetch).mock.calls[0][2]).toMatchObject({
retries: 0,
timeout: 30_000,
});
});
it('recovers from a network failure', async () => {
jest
.mocked(turtleFetch)
.mockRejectedValueOnce(new Error('socket hang up'))
.mockResolvedValueOnce(jsonResponse({ data: { id: 'thing-id' } }));
const assertion = expect(getThingAsync({ retries: 3 })).resolves.toEqual({
id: 'thing-id',
});
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
});
it('exhausts three retries with exponential backoff', async () => {
jest
.mocked(turtleFetch)
.mockImplementation(async () => new Response('unavailable', { status: 503 }));
const assertion = expect(createThingAsync({}, { retries: 3 })).rejects.toMatchObject({
status: 503,
});
await jest.advanceTimersByTimeAsync(0);
expect(turtleFetch).toHaveBeenCalledTimes(1);
await jest.advanceTimersByTimeAsync(1000);
expect(turtleFetch).toHaveBeenCalledTimes(2);
await jest.advanceTimersByTimeAsync(2000);
expect(turtleFetch).toHaveBeenCalledTimes(3);
await jest.advanceTimersByTimeAsync(4000);
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(4);
});
it.each([400, 401, 403, 404, 409])('does not retry HTTP %s', async status => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('refused', { status }));
await expect(createThingAsync({}, { retries: 3 })).rejects.toMatchObject({
status,
});
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
it('does not retry without an explicit retry count', async () => {
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('unavailable', { status: 503 }));
await expect(createThingAsync({})).rejects.toMatchObject({ status: 503 });
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
it('honors an explicit retry count', async () => {
jest
.mocked(turtleFetch)
.mockImplementation(async () => new Response('unavailable', { status: 503 }));
const assertion = expect(getThingAsync({ retries: 1 })).rejects.toMatchObject({
status: 503,
});
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
});
it('does not send another request after cancellation during backoff', async () => {
const controller = new AbortController();
jest.mocked(turtleFetch).mockResolvedValueOnce(new Response('unavailable', { status: 503 }));
const assertion = expect(
getThingAsync({ signal: controller.signal, retries: 3 })
).rejects.toMatchObject({ name: 'AbortError' });
await jest.advanceTimersByTimeAsync(0);
controller.abort();
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(1);
});
it('does not send an already cancelled request', async () => {
const controller = new AbortController();
controller.abort();
const assertion = expect(
getThingAsync({ signal: controller.signal, retries: 3 })
).rejects.toMatchObject({ name: 'AbortError' });
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).not.toHaveBeenCalled();
});
it.each(['system', 'body-timeout'])(
'retries a response body transport failure (%s)',
async type => {
const response = jsonResponse({});
jest
.spyOn(response, 'json')
.mockRejectedValueOnce(new FetchError('connection interrupted', type));
jest
.mocked(turtleFetch)
.mockResolvedValueOnce(response)
.mockResolvedValueOnce(jsonResponse({ data: { id: 'thing-id' } }));
const assertion = expect(createThingAsync({}, { retries: 3 })).resolves.toEqual({
id: 'thing-id',
});
await jest.runAllTimersAsync();
await assertion;
expect(turtleFetch).toHaveBeenCalledTimes(2);
}
);
});
@@ -4,13 +4,11 @@ import path from 'node:path';
import { type CustomBuildContext } from '../../customBuildContext';
import {
type AndroidEmulatorLogCapture,
AndroidEmulatorLogRing,
AndroidEmulatorLogCapture,
type FinalizedAndroidEmulatorLog,
MAX_ANDROID_LOG_BYTES_PER_SOURCE,
} from '../../utils/androidEmulatorLogCapture';
import { AndroidEmulatorLogFiles } from '../../utils/androidEmulatorLogFiles';
import { type AndroidEmulatorLogSource } from '../../utils/androidEmulatorLogSources';
import { formatBytes } from '../../utils/artifacts';
import { uploadDeviceRunSessionFileAsync } from './uploadDeviceRunSessionFile';
const UPLOAD_TIMEOUT_MS = 30_000;
@@ -27,19 +25,16 @@ type Collection = {
// A worker can execute more than one job; each workflow owns its capture and uploads.
const collections = new WeakMap<BuildStepGlobalContext, Collection>();
/** The first launch of a workflow fixes its source selection; later calls reuse the capture. */
export function getAndroidEmulatorLogCapture(
global: BuildStepGlobalContext,
env: NodeJS.ProcessEnv,
sources: readonly AndroidEmulatorLogSource[]
env: NodeJS.ProcessEnv
): AndroidEmulatorLogCapture {
let collection = collections.get(global);
if (!collection) {
collection = {
// Sessions upload a bounded ring per source; builds keep plain launch files.
capture: env.DEVICE_RUN_SESSION_ID
? new AndroidEmulatorLogRing({ sources })
: new AndroidEmulatorLogFiles({ sources }),
capture: new AndroidEmulatorLogCapture(
env.DEVICE_RUN_SESSION_ID ? MAX_ANDROID_LOG_BYTES_PER_SOURCE : Infinity
),
};
collections.set(global, collection);
}
@@ -118,8 +113,9 @@ async function uploadLogAsync(
return await uploadDeviceRunSessionFileAsync(ctx, {
filePath,
describe: size => {
const truncationNote =
size < bytesSeen ? `; truncated, last ${formatBytes(size)} retained` : '';
const retainedSize =
size >= 1024 * 1024 ? `${Number((size / (1024 * 1024)).toFixed(2))} MiB` : `${size} bytes`;
const truncationNote = size < bytesSeen ? `; truncated, last ${retainedSize} retained` : '';
return {
deviceRunSessionId,
artifactId: filename,
@@ -141,25 +141,18 @@ export async function captureDeviceRunSessionPreviewAsync({
device,
env,
signal,
captureIosScreenshotAsync,
}: {
runtimePlatform: BuildRuntimePlatform;
device: string;
env: BuildStepEnv;
signal: AbortSignal;
captureIosScreenshotAsync?: (file: string, signal: AbortSignal) => Promise<void>;
}): Promise<Buffer> {
const directory = await mkdtemp(path.join(os.tmpdir(), 'session-preview-'));
try {
const options = { env, signal, timeout: 30_000, stdio: 'pipe' as const };
const preview = path.join(directory, 'preview.webp');
if (runtimePlatform === BuildRuntimePlatform.DARWIN) {
if (!captureIosScreenshotAsync) {
throw new Error(
'Cannot capture the iOS session preview: serve-sim screenshot capture is not configured.'
);
}
await captureIosPreviewAsync({ captureIosScreenshotAsync, directory, preview, options });
await captureIosPreviewAsync({ device, directory, preview, options });
} else {
await captureAndroidPreviewAsync({ device, directory, preview, options });
}
@@ -177,20 +170,19 @@ type CaptureOptions = {
};
async function captureIosPreviewAsync({
captureIosScreenshotAsync,
device,
directory,
preview,
options,
}: {
captureIosScreenshotAsync: (file: string, signal: AbortSignal) => Promise<void>;
device: string;
directory: string;
preview: string;
options: CaptureOptions;
}): Promise<void> {
const screenshot = path.join(directory, 'screen.png');
const resized = path.join(directory, 'resized.png');
await captureIosScreenshotAsync(screenshot, options.signal);
options.signal.throwIfAborted();
await spawn('xcrun', ['simctl', 'io', device, 'screenshot', screenshot], options);
await spawn('sips', ['-Z', String(PREVIEW_MAX_DIMENSION), screenshot, '--out', resized], options);
await spawn('cwebp', ['-quiet', '-q', String(PREVIEW_QUALITY), resized, '-o', preview], options);
}
@@ -1,9 +1,12 @@
import { type EnvironmentSecret, SystemError } from '@expo/eas-build-job';
import { type EnvironmentSecret, EnvironmentSecretType, SystemError } from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { asyncResult } from '@expo/results';
import { FetchError } from 'node-fetch';
import { z } from 'zod';
import { type CustomBuildContext } from '../../customBuildContext';
import { getStringEnvironmentSecretValue } from '../../utils/environmentSecrets';
import { WorkerApi, type WorkerApiRequestOptions, getExpoApiV2BaseUrl } from './workerApi';
import { promiseRetryWithCondition } from '../../utils/promiseRetryWithCondition';
import { turtleFetch } from '../../utils/turtleFetch';
/**
* The environment secret that holds the device run session token. www gives it only to the job of
@@ -17,6 +20,8 @@ export const DEVICE_RUN_SESSION_TOKEN_ENV = 'EAS_DEVICE_RUN_SESSION_TOKEN';
*/
export const DEVICE_RUN_SESSION_TOKEN_HEADER = 'expo-device-run-session-token';
const DEVICE_RUN_SESSION_WORKER_PATH = 'device-run-session-worker/';
const DeviceRunSessionStatusSchema = z.object({
id: z.string(),
// The status entity values that www returns.
@@ -50,6 +55,10 @@ const DeviceRunSessionApplicationSchema = z.object({
.nullable(),
});
const ApiV2ErrorResponseSchema = z.object({
errors: z.array(z.object({ code: z.string().optional(), message: z.string() })).min(1),
});
export type DeviceRunSessionStatus = z.infer<typeof DeviceRunSessionStatusSchema>;
export type DeviceRunSessionUploadSession = z.infer<typeof UploadSessionSchema>['uploadSession'];
export type DeviceRunSessionTurnIceServers = z.infer<typeof TurnIceServersSchema>['iceServers'];
@@ -63,48 +72,70 @@ export type CreateDeviceRunSessionArtifactUploadSessionInput = {
metadata?: Record<string, unknown> | null;
};
/**
* Client for the www routes under `/v2/device-run-session-worker/`. These routes act only on the
* session that the token names.
*/
export class DeviceRunSessionWorkerApi {
private readonly client: WorkerApi;
type RequestOptions = {
/** Stops the request when aborted. */
signal?: AbortSignal;
/** node-fetch timeout of each attempt, in milliseconds. */
timeoutMs?: number;
/** Additional attempts for transient failures. Defaults to none; critical callers opt in. */
retries?: number;
logger?: bunyan;
};
constructor(expoApiV2BaseUrl: string, token: string) {
this.client = new WorkerApi(
new URL('device-run-session-worker/', expoApiV2BaseUrl).toString(),
{
authHeader: DEVICE_RUN_SESSION_TOKEN_HEADER,
token,
}
);
/**
* A request to the device run session worker API failed. The message names the route and the
* reason. It never includes the device run session token.
*/
export class DeviceRunSessionWorkerApiError extends Error {
constructor(
message: string,
/** The HTTP status of the response, or undefined when no response arrived. */
readonly status: number | undefined,
options?: ErrorOptions,
readonly code?: string
) {
super(message, options);
this.name = 'DeviceRunSessionWorkerApiError';
}
public async getSessionAsync(
options: WorkerApiRequestOptions = {}
): Promise<DeviceRunSessionStatus> {
return await this.client.requestAsync('GET', 'session', DeviceRunSessionStatusSchema, options);
get isTransient(): boolean {
return this.status === undefined || this.status >= 500;
}
}
/**
* Client for the www routes under `/v2/device-run-session-worker/`. These routes act only on the
* session that the token names, so no request carries a session ID.
*/
export class DeviceRunSessionWorkerApi {
constructor(
private readonly expoApiV2BaseUrl: string,
private readonly deviceRunSessionToken: string
) {}
public async getSessionAsync(options: RequestOptions = {}): Promise<DeviceRunSessionStatus> {
return await this.requestAsync('GET', 'session', DeviceRunSessionStatusSchema, options);
}
public async startAsync(
{ remoteConfig }: { remoteConfig: Record<string, unknown> },
options: WorkerApiRequestOptions = {}
options: RequestOptions = {}
): Promise<DeviceRunSessionStatus> {
return await this.client.requestAsync('POST', 'start', DeviceRunSessionStatusSchema, {
return await this.requestAsync('POST', 'start', DeviceRunSessionStatusSchema, {
...options,
json: { remoteConfig },
});
}
public async stopAsync(options: WorkerApiRequestOptions = {}): Promise<DeviceRunSessionStatus> {
return await this.client.requestAsync('POST', 'stop', DeviceRunSessionStatusSchema, options);
public async stopAsync(options: RequestOptions = {}): Promise<DeviceRunSessionStatus> {
return await this.requestAsync('POST', 'stop', DeviceRunSessionStatusSchema, options);
}
public async createArtifactUploadSessionAsync(
input: CreateDeviceRunSessionArtifactUploadSessionInput,
options: WorkerApiRequestOptions = {}
options: RequestOptions = {}
): Promise<DeviceRunSessionUploadSession> {
const { uploadSession } = await this.client.requestAsync(
const { uploadSession } = await this.requestAsync(
'POST',
'artifact-upload-sessions',
UploadSessionSchema,
@@ -114,9 +145,9 @@ export class DeviceRunSessionWorkerApi {
}
public async createEventLogUploadSessionAsync(
options: WorkerApiRequestOptions = {}
options: RequestOptions = {}
): Promise<DeviceRunSessionUploadSession> {
const { uploadSession } = await this.client.requestAsync(
const { uploadSession } = await this.requestAsync(
'POST',
'event-log-upload-session',
UploadSessionSchema,
@@ -126,9 +157,9 @@ export class DeviceRunSessionWorkerApi {
}
public async createPreviewUploadSessionAsync(
options: WorkerApiRequestOptions = {}
options: RequestOptions = {}
): Promise<DeviceRunSessionUploadSession> {
const { uploadSession } = await this.client.requestAsync(
const { uploadSession } = await this.requestAsync(
'POST',
'preview-upload-session',
UploadSessionSchema,
@@ -138,9 +169,9 @@ export class DeviceRunSessionWorkerApi {
}
public async fetchTurnIceServersAsync(
options: WorkerApiRequestOptions = {}
options: RequestOptions = {}
): Promise<DeviceRunSessionTurnIceServers> {
const { iceServers } = await this.client.requestAsync(
const { iceServers } = await this.requestAsync(
'POST',
'turn-ice-servers',
TurnIceServersSchema,
@@ -150,26 +181,160 @@ export class DeviceRunSessionWorkerApi {
}
public async getApplicationAsync(
options: WorkerApiRequestOptions = {}
options: RequestOptions = {}
): Promise<DeviceRunSessionApplication> {
return await this.client.requestAsync(
return await this.requestAsync(
'GET',
'application',
DeviceRunSessionApplicationSchema,
options
);
}
private async requestAsync<T>(
method: 'GET' | 'POST',
route: string,
dataSchema: z.ZodType<T>,
{ retries = 0, ...options }: RequestOptions & { json?: Record<string, unknown> }
): Promise<T> {
const request = () => {
options.signal?.throwIfAborted();
return this.requestOnceAsync(method, route, dataSchema, options);
};
if (retries === 0) {
return await request();
}
return await promiseRetryWithCondition(
request,
error =>
!options.signal?.aborted &&
error instanceof DeviceRunSessionWorkerApiError &&
(error.status === undefined || error.status === 429 || error.status >= 500),
{ retries, factor: 2, minTimeout: 1000 },
({ attemptNumber, maxAttemptsCount }) =>
options.logger?.warn(
`Retrying ${method} /v2/${DEVICE_RUN_SESSION_WORKER_PATH}${route} (attempt ${attemptNumber}/${maxAttemptsCount}).`
)
)();
}
private async requestOnceAsync<T>(
method: 'GET' | 'POST',
route: string,
dataSchema: z.ZodType<T>,
{
signal,
timeoutMs,
logger,
json,
}: Omit<RequestOptions, 'retries'> & {
json?: Record<string, unknown>;
}
): Promise<T> {
const routeDescription = `${method} /v2/${DEVICE_RUN_SESSION_WORKER_PATH}${route}`;
const url = new URL(
`${DEVICE_RUN_SESSION_WORKER_PATH}${route}`,
this.expoApiV2BaseUrl
).toString();
const responseResult = await asyncResult(
turtleFetch(url, method, {
headers: { [DEVICE_RUN_SESSION_TOKEN_HEADER]: this.deviceRunSessionToken },
...(json ? { json } : {}),
...(signal ? { signal } : {}),
...(timeoutMs !== undefined ? { timeout: timeoutMs } : {}),
retries: 0,
shouldThrowOnNotOk: false,
logger,
})
);
if (!responseResult.ok) {
const reason = responseResult.reason;
throw new DeviceRunSessionWorkerApiError(
`${routeDescription} failed before www responded: ${
reason instanceof Error ? reason.message : String(reason)
}. Check the network connection of the worker.`,
undefined,
{ cause: reason }
);
}
const response = responseResult.value;
const bodyResult = await asyncResult(response.json());
if (!response.ok) {
const apiError = bodyResult.ok ? ApiV2ErrorResponseSchema.safeParse(bodyResult.value) : null;
const apiErrorMessage = apiError?.success
? apiError.data.errors.map(error => error.message).join(' ')
: response.statusText;
throw new DeviceRunSessionWorkerApiError(
`${routeDescription} failed with status ${response.status}: ${apiErrorMessage}`,
response.status,
undefined,
apiError?.success ? apiError.data.errors[0]?.code : undefined
);
}
if (!bodyResult.ok) {
if (
bodyResult.reason instanceof FetchError &&
['system', 'body-timeout'].includes(bodyResult.reason.type)
) {
throw new DeviceRunSessionWorkerApiError(
`${routeDescription} failed while reading the response body.`,
undefined
);
}
throw new DeviceRunSessionWorkerApiError(
`${routeDescription} returned a response that is not JSON.`,
response.status
);
}
const parsed = z.object({ data: dataSchema }).safeParse(bodyResult.value);
if (!parsed.success) {
throw new DeviceRunSessionWorkerApiError(
`${routeDescription} returned an unexpected response: ${parsed.error.message}`,
response.status
);
}
return parsed.data.data;
}
}
/**
* Returns the device run session token when www gave one to this job, or null. Without a token,
* callers keep using the robot access token and the account-wide API.
*/
export function getDeviceRunSessionToken(
env: Record<string, string | undefined> | undefined
): string | null {
const token = env?.[DEVICE_RUN_SESSION_TOKEN_ENV];
return token ? token : null;
}
/**
* Returns the device run session token from the job's environment secrets, or null. It resolves
* duplicate names like the build context env does (the last secret wins), so the worker and the
* steps use the same token. A file secret is not a token.
*/
export function getDeviceRunSessionTokenFromEnvironmentSecrets(
environmentSecrets: EnvironmentSecret[] | undefined
): string | null {
const secret = [...(environmentSecrets ?? [])]
.reverse()
.find(({ name }) => name === DEVICE_RUN_SESSION_TOKEN_ENV);
if (!secret || secret.type !== EnvironmentSecretType.STRING || !secret.value) {
return null;
}
return secret.value;
}
/**
* Returns a client for the device run session worker API when this job has a device run session
* token, or null when it does not. Without a token, callers keep using the robot access token and
* the account-wide API.
* token, or null when it does not.
*/
export function getDeviceRunSessionWorkerApi(
ctx: Pick<CustomBuildContext, 'env' | 'expoApiV2BaseUrl'>
): DeviceRunSessionWorkerApi | null {
const token = ctx.env?.[DEVICE_RUN_SESSION_TOKEN_ENV];
const token = getDeviceRunSessionToken(ctx.env);
if (!token) {
return null;
}
@@ -194,13 +359,16 @@ export function requireDeviceRunSessionWorkerApi(
return workerApi;
}
/**
* Returns the device run session token from the job's environment secrets, or null. It resolves
* duplicate names like the build context env does (the last secret wins), so the worker and the
* steps use the same token. A file secret is not a token.
*/
export function getDeviceRunSessionTokenFromEnvironmentSecrets(
environmentSecrets: EnvironmentSecret[] | undefined
): string | null {
return getStringEnvironmentSecretValue(environmentSecrets, DEVICE_RUN_SESSION_TOKEN_ENV);
function getExpoApiV2BaseUrl(ctx: Pick<CustomBuildContext, 'env' | 'expoApiV2BaseUrl'>): string {
if (ctx.expoApiV2BaseUrl) {
return ctx.expoApiV2BaseUrl;
}
if (ctx.env.__API_SERVER_URL) {
return new URL('/v2/', ctx.env.__API_SERVER_URL).toString();
}
throw new SystemError(
`${DEVICE_RUN_SESSION_TOKEN_ENV} is set, but the API server URL is not. ` +
'The worker cannot call the device run session API without it. ' +
'Check that the worker sets __API_SERVER_URL for device run session jobs.'
);
}
@@ -54,7 +54,6 @@ import {
isPreinstalledExpoGoAsync,
readIosApplicationIdentifierAsync,
} from './iosAppArtifact';
import { createServeSimPreviewCapture } from './serveSimPreviewCapture';
import { type ServeSimActivityPolling, startServeSimActivityPolling } from './serveSimActivity';
import { verifyLocalEgressGuardAsync } from './localEgressGuard';
import { type IosSimulatorUuid } from '../../utils/IosSimulatorUtils';
@@ -433,8 +432,6 @@ export type DeviceSessionServerLaunch = {
*/
export type DeviceSessionServer = {
port: number;
/** The exact serve-sim version prepared by the warm launcher. */
serveSimVersion?: string;
turnArgs: Promise<string[]>;
/** Cold iOS setup runs after control readiness, alongside app installation and before launch. */
setupSimulatorAsync?(options: { signal: AbortSignal; logger: bunyan }): Promise<void>;
@@ -587,7 +584,6 @@ async function startDeviceSessionHostInternalAsync(
? await createAndroidDeviceSessionServerAsync(ctx, { logger })
: await createColdIosSessionAsync(ctx, { env, logger, iosSimulatorUdid }));
const port = server.port;
packageVersion = server.serveSimVersion ?? packageVersion;
const serverName = isAndroid ? 'expo-device-hub' : 'serve-sim';
const packageSpec = isAndroid
? createExpoDeviceHubPackageSpec(packageVersion)
@@ -606,7 +602,6 @@ async function startDeviceSessionHostInternalAsync(
const previewRetirementErrors: unknown[] = [];
let finishTask: Promise<void> | null = null;
let hostReady = false;
let iosPreviewCapture: ReturnType<typeof createServeSimPreviewCapture> | undefined;
let sessionPreview: ReturnType<typeof startDeviceRunSessionPreview> | null = null;
const previewSetupController = new AbortController();
let previewSetupTask: Promise<void> | undefined;
@@ -829,7 +824,6 @@ async function startDeviceSessionHostInternalAsync(
await sessionPreview?.stopAsync();
await previewActivity?.stopAsync();
},
cleanupPreviewCaptureAsync: async () => iosPreviewCapture?.cleanupAfterHostStoppedAsync(),
previewServer,
screenshots,
serverName,
@@ -995,18 +989,6 @@ async function startDeviceSessionHostInternalAsync(
// readiness on macOS, so it starts after its encoder is installed there.
previewSetupTask = (async () => {
if (!isAndroid) {
iosPreviewCapture = createServeSimPreviewCapture({
port,
token: previewToken!,
device,
tmpdir: serveSimTmpdir,
});
if (!(await iosPreviewCapture.isSupportedAsync(previewSetupController.signal))) {
logger.warn(
'This serve-sim version does not support automated screenshots; skipping session previews.'
);
return;
}
await ensureMacosPreviewEncoderInstalledAsync({
env,
logger,
@@ -1020,7 +1002,6 @@ async function startDeviceSessionHostInternalAsync(
logger,
captureAsync: signal =>
captureDeviceRunSessionPreviewAsync({
captureIosScreenshotAsync: iosPreviewCapture?.captureAsync,
runtimePlatform,
device: previewDevice ?? device,
env,
@@ -1096,7 +1077,6 @@ async function finishDeviceSessionHostAsync(
{
previewRetirement,
stopSessionPreviewAsync,
cleanupPreviewCaptureAsync,
previewServer,
screenshots,
serverName,
@@ -1108,7 +1088,6 @@ async function finishDeviceSessionHostAsync(
}: {
previewRetirement: Promise<boolean>;
stopSessionPreviewAsync: () => Promise<void>;
cleanupPreviewCaptureAsync: () => Promise<void>;
previewServer: DetachedProcessHandle;
screenshots: { finishAsync(hostStopped: boolean): Promise<void> };
serverName: string;
@@ -1142,13 +1121,6 @@ async function finishDeviceSessionHostAsync(
} catch (err) {
logger.warn({ err }, `Could not stop the ${serverName} session host.`);
}
if (hostStopped) {
try {
await cleanupPreviewCaptureAsync();
} catch (err) {
logger.warn({ err }, 'Could not remove session preview capture files.');
}
}
const previewRetired = await previewRetirement;
onStopped(hostStopped && !hostExited && previewRetired);
await screenshots.finishAsync(hostStopped);
@@ -1,31 +0,0 @@
import { UserError } from '@expo/eas-build-job';
import { BuildRuntimePlatform } from '@expo/steps';
import {
type AndroidEmulatorLogSource,
AndroidEmulatorLogSourcesSchema,
} from '../../utils/androidEmulatorLogSources';
/**
* `log_sources` is unprefixed like every other step input, so the platform
* rule is checked here at runtime, the way `network_capture` is.
*/
export function parseLogSourcesInput(
value: unknown,
{
runtimePlatform,
fallback,
}: { runtimePlatform: BuildRuntimePlatform; fallback: readonly AndroidEmulatorLogSource[] }
): readonly AndroidEmulatorLogSource[] {
if (value === undefined) {
return fallback;
}
const sources = AndroidEmulatorLogSourcesSchema.parse(value);
if (sources.length > 0 && runtimePlatform === BuildRuntimePlatform.DARWIN) {
throw new UserError(
'EAS_LOG_SOURCES_INVALID_INPUT',
`Input "log_sources" selects Android emulator logs, and this session runs on iOS. Drop "log_sources", or run the session on Android.`
);
}
return sources;
}
@@ -9,7 +9,6 @@ import { killProcessGroup } from '../../utils/processes';
export async function preparePreinstalledWdaAsync({
runtimeIdentifier,
appiumHome,
prepared = false,
appiumBinPath,
appiumEnv,
logger,
@@ -17,8 +16,6 @@ export async function preparePreinstalledWdaAsync({
}: {
runtimeIdentifier: string | undefined;
appiumHome: string;
/** A prepared Appium home that already holds the runner. */
prepared?: boolean;
appiumBinPath: string;
appiumEnv: BuildStepEnv;
logger: bunyan;
@@ -35,13 +32,6 @@ export async function preparePreinstalledWdaAsync({
const outdir = path.join(appiumHome, 'preinstalled-wda');
const runner = path.join(outdir, 'WebDriverAgentRunner-Runner.app');
if (prepared) {
logger.info('Using preinstalled WebDriverAgent to avoid xcodebuild during session creation.');
return {
'appium:usePreinstalledWDA': true,
'appium:prebuiltWDAPath': runner,
};
}
try {
// The driver selects the release matching its installed WDA and the host architecture.
// Keep the Simulator runner intact; removing its XCTest frameworks breaks launch.
@@ -29,9 +29,9 @@ import { createProcessOutput } from './processOutput';
import { withDeviceRunSessionTimeoutAsync } from './deviceRunSessionTimeout';
import {
type DeviceRunSessionStatus,
DeviceRunSessionWorkerApiError,
requireDeviceRunSessionWorkerApi,
} from './deviceRunSessionWorkerApi';
import { WorkerApiError } from './workerApi';
const XCODE_DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
@@ -525,7 +525,10 @@ export async function fetchWebPreviewTurnArgsAsync(
}
return args;
} catch (err) {
if (err instanceof WorkerApiError && err.code === 'DEVICE_RUN_SESSION_ALREADY_STOPPED') {
if (
err instanceof DeviceRunSessionWorkerApiError &&
err.code === 'DEVICE_RUN_SESSION_ALREADY_STOPPED'
) {
logger.info('Device run session was stopped before TURN credentials were fetched.');
return [];
}
@@ -577,7 +580,10 @@ export async function uploadRemoteSessionConfigAsync({
return 'started';
} catch (err) {
signal?.throwIfAborted();
if (err instanceof WorkerApiError && err.code === 'DEVICE_RUN_SESSION_ALREADY_STOPPED') {
if (
err instanceof DeviceRunSessionWorkerApiError &&
err.code === 'DEVICE_RUN_SESSION_ALREADY_STOPPED'
) {
logger.info(`Device run session ${deviceRunSessionId} was stopped during startup.`);
return 'stopped';
}
@@ -2,20 +2,52 @@ import {
type SandboxDaemonCommandResult,
SandboxDaemonError,
SandboxDaemonErrorCode,
SystemError,
} from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { type Client, CombinedError } from '@urql/core';
import { graphql } from 'gql.tada';
import { createReadStream } from 'node:fs';
import fs from 'node:fs/promises';
import path from 'node:path';
import { performance } from 'node:perf_hooks';
import { Readable } from 'node:stream';
import { setTimeout as delay } from 'node:timers/promises';
import { SignedUrlUploadApiError, uploadWithSignedUrl } from '../../storage/uploadWithSignedUrl';
import { type SandboxArtifactUploadSession, type SandboxWorkerApi } from './sandboxWorkerApi';
import { WorkerApiError } from './workerApi';
import { graphqlAbortContext } from '../../utils/graphqlAbort';
const WORKER_API_REQUEST_TIMEOUT_MS = 15_000;
const FINALIZE_RETRIES = 2;
const CREATE_SANDBOX_ARTIFACT_UPLOAD_SESSION_MUTATION = graphql(`
mutation CreateSandboxArtifactUploadSession(
$sandboxId: ID!
$input: CreateSandboxArtifactUploadSessionInput!
) {
sandbox {
createArtifactUploadSession(sandboxId: $sandboxId, input: $input) {
artifact {
id
}
uploadSession {
url
headers
}
}
}
}
`);
const FINALIZE_SANDBOX_ARTIFACT_MUTATION = graphql(`
mutation FinalizeSandboxArtifact($artifactId: ID!) {
sandbox {
finalizeArtifact(artifactId: $artifactId) {
id
downloadUrl
}
}
}
`);
const FINALIZE_ATTEMPTS = 3;
const REJECTED_UPLOAD_SESSION_ERROR_CODES = new Set(['VALIDATION_ERROR', 'UNAUTHORIZED']);
type SandboxArtifactUploadOutcome =
@@ -28,7 +60,8 @@ export class SandboxArtifactUploadManager {
public constructor(
private readonly options: {
workerApi: SandboxWorkerApi;
graphqlClient: Client;
sandboxId: string;
logger: bunyan;
signal: AbortSignal;
}
@@ -81,13 +114,15 @@ export class SandboxArtifactUploadManager {
}
export async function startSandboxArtifactUploadAsync({
workerApi,
graphqlClient,
sandboxId,
logger,
filePath,
name,
signal,
}: {
workerApi: SandboxWorkerApi;
graphqlClient: Client;
sandboxId: string;
logger: bunyan;
filePath: string;
name: string;
@@ -122,9 +157,9 @@ export async function startSandboxArtifactUploadAsync({
artifact: { id: artifactId },
uploadSession,
} = await createSandboxArtifactUploadSessionAsync(
workerApi,
{ name, filename: path.basename(filePath), size },
signal
graphqlClient,
{ sandboxId, name, filename: path.basename(filePath), size },
AbortSignal.any([signal, AbortSignal.timeout(15_000)])
);
const completed = (async (): Promise<SandboxArtifactUploadOutcome> => {
logger.info(`Uploading sandbox artifact "${name}" (${artifactId}, ${size} bytes).`);
@@ -136,12 +171,7 @@ export async function startSandboxArtifactUploadAsync({
}
let downloadUrl: string;
try {
downloadUrl = await workerApi.finalizeArtifactAsync(artifactId, {
signal,
timeoutMs: WORKER_API_REQUEST_TIMEOUT_MS,
retries: FINALIZE_RETRIES,
logger,
});
downloadUrl = await finalizeSandboxArtifactAsync(graphqlClient, artifactId, signal);
} catch (error) {
logger.error(
{ err: error },
@@ -156,28 +186,44 @@ export async function startSandboxArtifactUploadAsync({
}
async function createSandboxArtifactUploadSessionAsync(
workerApi: SandboxWorkerApi,
input: { name: string; filename: string; size: number },
graphqlClient: Client,
{
sandboxId,
name,
filename,
size,
}: { sandboxId: string; name: string; filename: string; size: number },
signal: AbortSignal
): Promise<SandboxArtifactUploadSession> {
try {
return await workerApi.createArtifactUploadSessionAsync(input, {
signal,
timeoutMs: WORKER_API_REQUEST_TIMEOUT_MS,
});
} catch (error) {
signal.throwIfAborted();
) {
const result = await graphqlClient
.mutation(
CREATE_SANDBOX_ARTIFACT_UPLOAD_SESSION_MUTATION,
{ sandboxId, input: { name, filename, size } },
graphqlAbortContext(signal)
)
.toPromise();
signal.throwIfAborted();
if (result.error) {
const { graphQLErrors } = result.error;
const message =
graphQLErrors.length > 0
? graphQLErrors.map(error => error.message).join('\n')
: `Failed to create an upload session for sandbox artifact "${name}": ${result.error.message}`;
if (
error instanceof WorkerApiError &&
error.code !== undefined &&
REJECTED_UPLOAD_SESSION_ERROR_CODES.has(error.code)
graphQLErrors.length > 0 &&
graphQLErrors.every(error =>
REJECTED_UPLOAD_SESSION_ERROR_CODES.has(error.extensions?.errorCode as string)
)
) {
throw new SandboxDaemonError(SandboxDaemonErrorCode.BAD_REQUEST, error.message, {
cause: error,
throw new SandboxDaemonError(SandboxDaemonErrorCode.BAD_REQUEST, message, {
cause: result.error,
});
}
throw error;
throw new SystemError(message, { cause: result.error });
}
return result.data!.sandbox.createArtifactUploadSession;
}
async function putSandboxArtifactAsync({
@@ -188,13 +234,16 @@ async function putSandboxArtifactAsync({
}: {
filePath: string;
size: number;
uploadSession: SandboxArtifactUploadSession['uploadSession'];
uploadSession: { url: string; headers: unknown };
signal: AbortSignal;
}): Promise<void> {
try {
await uploadWithSignedUrl(
{
signedUrl: uploadSession,
signedUrl: {
url: uploadSession.url,
headers: uploadSession.headers as Record<string, string>,
},
srcGeneratorAsync: async () =>
size === 0 ? Readable.from([]) : createReadStream(filePath, { start: 0, end: size - 1 }),
},
@@ -206,3 +255,45 @@ async function putSandboxArtifactAsync({
}
}
}
async function finalizeSandboxArtifactAsync(
graphqlClient: Client,
artifactId: string,
signal: AbortSignal
): Promise<string> {
for (let attempt = 1; ; attempt++) {
const timeoutSignal = AbortSignal.timeout(15_000);
const finalizeSignal = AbortSignal.any([signal, timeoutSignal]);
try {
const result = await graphqlClient
.mutation(
FINALIZE_SANDBOX_ARTIFACT_MUTATION,
{ artifactId },
graphqlAbortContext(finalizeSignal)
)
.toPromise();
finalizeSignal.throwIfAborted();
if (result.error) {
throw result.error;
}
const { downloadUrl } = result.data!.sandbox.finalizeArtifact;
if (downloadUrl === null) {
throw new SystemError(`Finalized sandbox artifact ${artifactId} has no download URL.`);
}
return downloadUrl;
} catch (error) {
signal.throwIfAborted();
const retryable =
timeoutSignal.aborted || (error instanceof CombinedError && isTransientGraphqlError(error));
if (!retryable || attempt >= FINALIZE_ATTEMPTS) {
throw error;
}
await delay(500 * attempt, undefined, { signal });
}
}
}
function isTransientGraphqlError(error: CombinedError): boolean {
const status: number | undefined = error.response?.status;
return status === undefined ? error.networkError !== undefined : status >= 500;
}
@@ -6,6 +6,7 @@ import {
type SandboxDaemonMethod,
} from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { type Client } from '@urql/core';
import fs, { type FileHandle } from 'node:fs/promises';
import path from 'node:path';
import { performance } from 'node:perf_hooks';
@@ -13,7 +14,6 @@ import { performance } from 'node:perf_hooks';
import { readBytesAsync, readTextAsync } from '../../utils/files';
import { detectFileType } from '../../utils/files/filetypes';
import { SandboxArtifactUploadManager } from './sandboxArtifacts';
import { type SandboxWorkerApi } from './sandboxWorkerApi';
import { ShellSessionManager } from './shellSessionManager';
const DEFAULT_EXEC_YIELD_TIME_MS = 10_000;
@@ -30,13 +30,15 @@ export function createSandboxCommandImplementations({
workingDirectory,
env,
signal,
workerApi,
graphqlClient,
sandboxId,
logger,
}: {
workingDirectory: string;
env: NodeJS.ProcessEnv;
signal: AbortSignal;
workerApi: SandboxWorkerApi;
graphqlClient: Client;
sandboxId: string;
logger: bunyan;
}): {
commandImplementations: SandboxDaemonCommandImplementations;
@@ -44,7 +46,8 @@ export function createSandboxCommandImplementations({
} {
const sessions = new ShellSessionManager({ workingDirectory, env, signal });
const artifactUploads = new SandboxArtifactUploadManager({
workerApi,
graphqlClient,
sandboxId,
logger,
signal,
});
@@ -9,6 +9,7 @@ import {
SystemError,
} from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { type Client } from '@urql/core';
import { setTimeout as setTimeoutAsync } from 'node:timers/promises';
import WebSocket from 'ws';
@@ -16,7 +17,6 @@ import {
type SandboxDaemonCommandImplementations,
createSandboxCommandImplementations,
} from './sandboxCommandImplementations';
import { type SandboxWorkerApi } from './sandboxWorkerApi';
export interface SandboxDaemonOptions {
credential: string;
@@ -26,7 +26,8 @@ export interface SandboxDaemonOptions {
signal?: AbortSignal;
workingDirectory: string;
env: NodeJS.ProcessEnv;
workerApi: SandboxWorkerApi;
graphqlClient: Client;
sandboxId: string;
}
export interface SandboxDaemon {
@@ -48,7 +49,8 @@ export async function startSandboxDaemonAsync(
workingDirectory: options.workingDirectory,
env: options.env,
signal: abortController.signal,
workerApi: options.workerApi,
graphqlClient: options.graphqlClient,
sandboxId: options.sandboxId,
logger: options.logger,
});
const connected = new Promise<void>((resolve, reject) => {
@@ -1,115 +0,0 @@
import { type Env, type EnvironmentSecret, type Job, SystemError } from '@expo/eas-build-job';
import { z } from 'zod';
import {
type ProjectArchiveSource,
ProjectArchiveSourceSchema,
} from '../../common/projectArchiveSource';
import { getStringEnvironmentSecretValue } from '../../utils/environmentSecrets';
import { WorkerApi, type WorkerApiRequestOptions, getExpoApiV2BaseUrl } from './workerApi';
export const SANDBOX_WORKER_TOKEN_ENV = 'EAS_SANDBOX_WORKER_TOKEN';
export const SANDBOX_WORKER_TOKEN_HEADER = 'expo-sandbox-worker-token';
const MarkReadyResponseSchema = z.object({ id: z.string() });
const ArtifactUploadSessionSchema = z.object({
artifact: z.object({ id: z.string() }),
uploadSession: z.object({
url: z.string(),
headers: z.record(z.string(), z.string()),
}),
});
const FinalizedArtifactSchema = z.object({
id: z.string(),
downloadUrl: z.string(),
});
export type SandboxArtifactUploadSession = z.infer<typeof ArtifactUploadSessionSchema>;
export class SandboxWorkerApi {
private readonly client: WorkerApi;
constructor(
expoApiV2BaseUrl: string,
readonly token: string
) {
this.client = new WorkerApi(new URL('sandbox-worker/', expoApiV2BaseUrl).toString(), {
authHeader: SANDBOX_WORKER_TOKEN_HEADER,
token,
});
}
public async getProjectArchiveSourceAsync(
options: WorkerApiRequestOptions = {}
): Promise<ProjectArchiveSource> {
return await this.client.requestAsync(
'POST',
'project-archive',
ProjectArchiveSourceSchema,
options
);
}
public async markReadyAsync(options: WorkerApiRequestOptions = {}): Promise<void> {
await this.client.requestAsync('POST', 'ready', MarkReadyResponseSchema, options);
}
public async createArtifactUploadSessionAsync(
input: { name: string; filename: string; size: number },
options: WorkerApiRequestOptions = {}
): Promise<SandboxArtifactUploadSession> {
return await this.client.requestAsync(
'POST',
'artifact-upload-sessions',
ArtifactUploadSessionSchema,
{ ...options, json: input }
);
}
public async finalizeArtifactAsync(
artifactId: string,
options: WorkerApiRequestOptions = {}
): Promise<string> {
const { downloadUrl } = await this.client.requestAsync(
'POST',
`artifacts/${encodeURIComponent(artifactId)}/finalize`,
FinalizedArtifactSchema,
options
);
return downloadUrl;
}
}
export function getSandboxWorkerTokenFromEnvironmentSecrets(
environmentSecrets: EnvironmentSecret[] | undefined
): string | null {
return getStringEnvironmentSecretValue(environmentSecrets, SANDBOX_WORKER_TOKEN_ENV);
}
export function getSandboxWorkerApi(ctx: {
job: Job;
env: Env;
expoApiV2BaseUrl?: string;
}): SandboxWorkerApi | null {
const token = getSandboxWorkerTokenFromEnvironmentSecrets(ctx.job.secrets?.environmentSecrets);
return token ? new SandboxWorkerApi(getExpoApiV2BaseUrl(ctx), token) : null;
}
export function requireSandboxWorkerApi(ctx: {
job: Job;
env: Env;
expoApiV2BaseUrl?: string;
}): SandboxWorkerApi {
const workerApi = getSandboxWorkerApi(ctx);
if (!workerApi) {
throw new SystemError(
`This sandbox job has no ${SANDBOX_WORKER_TOKEN_ENV} secret. ` +
'www gives one to every sandbox job, and the worker needs it to call the sandbox API. ' +
'Start a new sandbox, and contact support if it happens again.'
);
}
return workerApi;
}
@@ -30,20 +30,13 @@ export async function stageServeSimAppAsync(
}
}
export async function runServeSimActionAsync(
options: Parameters<typeof runServeSimActionWithResultAsync>[0]
): Promise<void> {
await runServeSimActionWithResultAsync(options);
}
export async function runServeSimActionWithResultAsync({
export async function runServeSimActionAsync({
port,
token,
action,
params,
timeoutMs,
signal,
drainAfterDispatch = false,
}: {
port: number;
token: string;
@@ -51,15 +44,13 @@ export async function runServeSimActionWithResultAsync({
params: Record<string, unknown>;
timeoutMs: number;
signal?: AbortSignal;
/** Abort before dispatch; once sent, wait for its reply or deadline because exec-ws cannot cancel it. */
drainAfterDispatch?: boolean;
}): Promise<string> {
}): Promise<void> {
signal?.throwIfAborted();
return await new Promise<string>((resolve, reject) => {
await new Promise<void>((resolve, reject) => {
const socket = new WebSocket(`ws://127.0.0.1:${port}/exec-ws`, [`serve-sim.token.${token}`]);
let settled = false;
let sent = false;
const finish = (error?: unknown, stdout = '') => {
const finish = (error?: unknown) => {
if (settled) {
return;
}
@@ -70,14 +61,10 @@ export async function runServeSimActionWithResultAsync({
if (error) {
reject(error);
} else {
resolve(stdout);
}
};
const aborted = () => {
if (!sent || !drainAfterDispatch) {
finish(signal?.reason ?? new Error('Serve-sim action aborted.'));
resolve();
}
};
const aborted = () => finish(signal?.reason ?? new Error('Serve-sim action aborted.'));
const timer = setTimeout(
() => finish(new SystemError(`serve-sim ${action} timed out.`)),
timeoutMs
@@ -88,9 +75,6 @@ export async function runServeSimActionWithResultAsync({
finish(new SystemError(`serve-sim ${action} connection closed before completion.`))
);
socket.on('message', data => {
if (settled) {
return;
}
let reply;
try {
reply = JSON.parse(data.toString());
@@ -106,8 +90,7 @@ export async function runServeSimActionWithResultAsync({
? undefined
: new SystemError(
`serve-sim ${action} failed: ${(typeof reply.error === 'string' && reply.error) || (typeof reply.stderr === 'string' && reply.stderr) || 'invalid response'}`
),
typeof reply.stdout === 'string' ? reply.stdout : ''
)
);
}
});
@@ -1,74 +0,0 @@
import { randomUUID } from 'node:crypto';
import { copyFile, rm } from 'node:fs/promises';
import path from 'node:path';
import { runServeSimActionAsync, runServeSimActionWithResultAsync } from './serveSimActions';
export function createServeSimPreviewCapture({
port,
token,
device,
tmpdir,
}: {
port: number;
token: string;
device: string;
tmpdir: string;
}) {
const ownedFiles = new Set<string>();
return {
async isSupportedAsync(signal: AbortSignal): Promise<boolean> {
const result = await runServeSimActionWithResultAsync({
port,
token,
action: 'actions.describe',
params: {},
timeoutMs: 30_000,
signal,
});
const catalog: {
'screenshot.capture'?: { properties?: { automation?: { type?: unknown } } };
} | null = JSON.parse(result);
return catalog?.['screenshot.capture']?.properties?.automation?.type === 'boolean';
},
async captureAsync(destination: string, signal: AbortSignal): Promise<void> {
signal.throwIfAborted();
const fileName = `serve-sim-screenshot-preview-${randomUUID()}.png`;
const staged = path.join(tmpdir, 'serve-sim-screenshots', fileName);
ownedFiles.add(staged);
// Closing exec-ws does not cancel its host action. Drain a sent capture before honoring
// cancellation; on timeout/disconnect, leave its file alone until the host has stopped.
await runServeSimActionAsync({
port,
token,
action: 'screenshot.capture',
params: { udid: device, fileName, automation: true },
timeoutMs: 30_000,
signal,
drainAfterDispatch: true,
});
try {
signal.throwIfAborted();
await copyFile(staged, destination);
} finally {
await rm(staged, { force: true });
ownedFiles.delete(staged);
}
},
/** Call only after the host process group has stopped, including timed-out actions. */
async cleanupAfterHostStoppedAsync(): Promise<void> {
const results = await Promise.allSettled(
[...ownedFiles].map(async file => {
await rm(file, { force: true });
ownedFiles.delete(file);
})
);
const errors = results
.filter(result => result.status === 'rejected')
.map(result => result.reason);
if (errors.length) {
throw new AggregateError(errors, 'Could not remove preview captures.');
}
},
};
}
@@ -2,8 +2,6 @@ import type { bunyan } from '@expo/logger';
import spawn from '@expo/turtle-spawn';
import { type CustomBuildContext } from '../../customBuildContext';
import { resolveSimulatorPackageVersionAsync } from '../../utils/simulatorPackageVersion';
import { stopWarmSimulatorAsync } from '../../utils/warmSimulator';
import { IosSimulatorRecordingUtils } from './IosSimulatorRecordingUtils';
import { type DeviceSessionServer } from './deviceSessionHost';
import { fetchWebPreviewTurnArgsAsync } from './remoteDeviceRunSession';
@@ -30,7 +28,6 @@ export function createWarmDeviceSessionServer(
}
return {
port: warm.server.port,
serveSimVersion: warm.serveSimVersion,
turnArgs: fetchWebPreviewTurnArgsAsync(ctx, { logger }),
// Set by prepare-tools, which the host runs before it installs the app.
get preinstalledApp() {
@@ -71,34 +68,14 @@ export function createWarmDeviceSessionServer(
*/
export async function runOnWarmIosSimulatorAsync<T>(
claim: Parameters<typeof tryClaimWarmIosSessionAsync>[0],
run: (warm?: WarmIosSession, packageVersion?: string) => Promise<T>
run: (warm?: WarmIosSession) => Promise<T>
): Promise<T> {
let packageVersion = claim.packageVersion;
if (packageVersion !== undefined && claim.env.EAS_USE_WARM_SIMULATOR === '1') {
try {
packageVersion = await resolveSimulatorPackageVersionAsync(
claim.engine,
packageVersion,
claim
);
} catch (error) {
try {
await stopWarmSimulatorAsync(claim.env);
} catch (cleanupError) {
throw new AggregateError(
[error, cleanupError],
'Could not stop warmup after version resolution failed.'
);
}
throw error;
}
}
const warm = await tryClaimWarmIosSessionAsync({ ...claim, packageVersion });
const warm = await tryClaimWarmIosSessionAsync(claim);
if (!warm) {
return await run(undefined, packageVersion);
return await run(undefined);
}
try {
return await run(warm, packageVersion);
return await run(warm);
} catch (error) {
try {
await warm.process.stopAsync();
@@ -113,6 +90,6 @@ export async function runOnWarmIosSimulatorAsync<T>(
}
claim.logger.warn('Could not adopt the warm Simulator; starting a cold Simulator.');
claim.signal?.throwIfAborted();
return await run(undefined, packageVersion);
return await run(undefined);
}
}
@@ -2,7 +2,6 @@ import { type bunyan } from '@expo/logger';
import { type BuildStepEnv } from '@expo/steps';
import fs from 'node:fs/promises';
import path from 'node:path';
import semver from 'semver';
import { z } from 'zod';
import { runSimulatorLauncherAsync, stopWarmSimulatorAsync } from '../../utils/warmSimulator';
@@ -10,11 +9,7 @@ import { readLocalEgressHandoffAsync } from './localEgress';
import { type DetachedProcessHandle, isProcessRunning } from './remoteDeviceRunSession';
const ServiceSchema = z.object({ pid: z.number(), port: z.number(), token: z.string() });
const PackageVersionSchema = z.string().refine(version => semver.valid(version) !== null);
const ClaimSchema = z.object({
serveSimVersion: PackageVersionSchema.optional(),
agentDeviceVersion: PackageVersionSchema.optional(),
argentVersion: PackageVersionSchema.optional(),
device: z.object({ udid: z.string(), name: z.string() }),
server: ServiceSchema,
agentDeviceStateDir: z.string(),
@@ -58,6 +53,10 @@ export async function tryClaimWarmIosSessionAsync({
return undefined;
}
try {
// Warm tools run the latest release with the VM's Simulator settings.
if (packageVersion && packageVersion !== 'latest') {
throw new Error('A pinned package_version needs a cold start.');
}
const setting = Object.keys(env).find(
name => name === 'SERVE_SIM_ADDITIONAL_DYLIBS' || name.startsWith('SIMCTL_CHILD_')
);
@@ -72,15 +71,6 @@ export async function tryClaimWarmIosSessionAsync({
const claim = ClaimSchema.parse(
JSON.parse(await runSimulatorLauncherAsync(claimArgs, { env, signal }))
);
const selectedVersion = {
'serve-sim': claim.serveSimVersion,
'agent-device': claim.agentDeviceVersion,
argent: claim.argentVersion,
appium: undefined,
}[engine];
if (packageVersion !== undefined && selectedVersion !== packageVersion) {
throw new Error('The warm tool does not match the requested package version.');
}
logger.info(`Claimed the warm Simulator ${claim.device.name} (${claim.device.udid}).`);
let stopping: Promise<void> | undefined;
const session: WarmIosSession = {
@@ -1,185 +0,0 @@
import { type Env, SystemError } from '@expo/eas-build-job';
import { type bunyan } from '@expo/logger';
import { asyncResult } from '@expo/results';
import { FetchError } from 'node-fetch';
import { z } from 'zod';
import { promiseRetryWithCondition } from '../../utils/promiseRetryWithCondition';
import { turtleFetch } from '../../utils/turtleFetch';
/**
* The header and value that authenticate a worker to its www worker router. The token is not an
* `Authorization` credential, and www accepts it only on that router.
*/
export type WorkerApiAuth = {
authHeader: string;
token: string;
};
export type WorkerApiRequestOptions = {
/** Stops the request when aborted. */
signal?: AbortSignal;
/** node-fetch timeout of each attempt, in milliseconds. */
timeoutMs?: number;
/** Additional attempts for transient failures. Defaults to none; critical callers opt in. */
retries?: number;
logger?: bunyan;
};
const ApiV2ErrorResponseSchema = z.object({
errors: z.array(z.object({ code: z.string().optional(), message: z.string() })).min(1),
});
/**
* A request to a worker API failed. The message names the route and the reason. It never includes
* the worker token.
*/
export class WorkerApiError extends Error {
constructor(
message: string,
/** The HTTP status of the response, or undefined when no response arrived. */
readonly status: number | undefined,
options?: ErrorOptions,
readonly code?: string
) {
super(message, options);
this.name = 'WorkerApiError';
}
get isTransient(): boolean {
return this.status === undefined || this.status >= 500;
}
}
/**
* Client for one www worker router. The token names the resource the worker serves, so no request
* carries its ID.
*/
export class WorkerApi {
constructor(
/** The URL of the worker router. It ends with a slash, so routes resolve under it. */
private readonly baseUrl: string,
private readonly auth: WorkerApiAuth
) {}
public async requestAsync<T>(
method: 'GET' | 'POST',
route: string,
dataSchema: z.ZodType<T>,
{ retries = 0, ...options }: WorkerApiRequestOptions & { json?: Record<string, unknown> } = {}
): Promise<T> {
const url = new URL(route, this.baseUrl);
const routeDescription = `${method} ${url.pathname}`;
const request = () => {
options.signal?.throwIfAborted();
return this.requestOnceAsync(method, url.toString(), routeDescription, dataSchema, options);
};
if (retries === 0) {
return await request();
}
return await promiseRetryWithCondition(
request,
error =>
!options.signal?.aborted &&
error instanceof WorkerApiError &&
(error.status === undefined || error.status === 429 || error.status >= 500),
{ retries, factor: 2, minTimeout: 1000 },
({ attemptNumber, maxAttemptsCount }) =>
options.logger?.warn(
`Retrying ${routeDescription} (attempt ${attemptNumber}/${maxAttemptsCount}).`
)
)();
}
private async requestOnceAsync<T>(
method: 'GET' | 'POST',
url: string,
routeDescription: string,
dataSchema: z.ZodType<T>,
{
signal,
timeoutMs,
logger,
json,
}: Omit<WorkerApiRequestOptions, 'retries'> & {
json?: Record<string, unknown>;
}
): Promise<T> {
const responseResult = await asyncResult(
turtleFetch(url, method, {
headers: { [this.auth.authHeader]: this.auth.token },
...(json ? { json } : {}),
...(signal ? { signal } : {}),
...(timeoutMs !== undefined ? { timeout: timeoutMs } : {}),
retries: 0,
shouldThrowOnNotOk: false,
logger,
})
);
if (!responseResult.ok) {
const reason = responseResult.reason;
throw new WorkerApiError(
`${routeDescription} failed before www responded: ${
reason instanceof Error ? reason.message : String(reason)
}. Check the network connection of the worker.`,
undefined,
{ cause: reason }
);
}
const response = responseResult.value;
const bodyResult = await asyncResult(response.json());
if (!response.ok) {
const apiError = bodyResult.ok ? ApiV2ErrorResponseSchema.safeParse(bodyResult.value) : null;
const apiErrorMessage = apiError?.success
? apiError.data.errors.map(error => error.message).join(' ')
: response.statusText;
throw new WorkerApiError(
`${routeDescription} failed with status ${response.status}: ${apiErrorMessage}`,
response.status,
undefined,
apiError?.success ? apiError.data.errors[0]?.code : undefined
);
}
if (!bodyResult.ok) {
if (
bodyResult.reason instanceof FetchError &&
['system', 'body-timeout'].includes(bodyResult.reason.type)
) {
throw new WorkerApiError(
`${routeDescription} failed while reading the response body.`,
undefined
);
}
throw new WorkerApiError(
`${routeDescription} returned a response that is not JSON.`,
response.status
);
}
const parsed = z.object({ data: dataSchema }).safeParse(bodyResult.value);
if (!parsed.success) {
throw new WorkerApiError(
`${routeDescription} returned an unexpected response: ${parsed.error.message}`,
response.status
);
}
return parsed.data.data;
}
}
/**
* Returns the API v2 base URL of the worker. It throws when the worker knows no API server URL,
* because a worker API client cannot work without it.
*/
export function getExpoApiV2BaseUrl(ctx: { env: Env; expoApiV2BaseUrl?: string }): string {
if (ctx.expoApiV2BaseUrl) {
return ctx.expoApiV2BaseUrl;
}
if (ctx.env.__API_SERVER_URL) {
return new URL('/v2/', ctx.env.__API_SERVER_URL).toString();
}
throw new SystemError(
'The API server URL is not set, so the worker cannot call its worker API. ' +
'Check that the worker sets __API_SERVER_URL.'
);
}
@@ -13,6 +13,7 @@ import { setTimeout } from 'node:timers/promises';
import { z } from 'zod';
import { Sentry } from '../sentry';
import { type AndroidEmulatorLogSource } from './androidEmulatorLogSources';
import { type AndroidEmulatorLogCapture } from './androidEmulatorLogCapture';
import { retryAsync } from './retry';
@@ -327,12 +328,14 @@ export namespace AndroidEmulatorUtils {
deviceName,
env,
logcatDirectory,
logSources,
launchGate,
logCapture,
}: {
deviceName: AndroidVirtualDeviceName;
env: NodeJS.ProcessEnv;
logcatDirectory: string;
logSources: readonly AndroidEmulatorLogSource[];
launchGate?: AndroidEmulatorLaunchGate;
logCapture: AndroidEmulatorLogCapture;
}): Promise<{
@@ -348,11 +351,13 @@ export namespace AndroidEmulatorUtils {
.toString(16)
.padStart(8, '0');
const outputName = `${safeDeviceName}-${timestamp}-${randomBytes(2).toString('hex')}`;
if (logCapture.sources.includes('device-logcat')) {
if (logSources.includes('device-logcat')) {
logcatOutputPath = path.join(logcatDirectory, `${outputName}-logcat.log`);
await fs.promises.writeFile(logcatOutputPath, '');
}
if (logCapture.sources.includes('emulator-output')) {
if (logSources.includes('emulator-output')) {
emulatorOutputPath = path.join(logcatDirectory, `${outputName}-emulator.log`);
await fs.promises.writeFile(emulatorOutputPath, '');
}
} catch (err) {
throw new SystemError(`Failed to prepare Android emulator output for ${deviceName}.`, {
@@ -4,7 +4,6 @@ import fs from 'node:fs';
import os from 'node:os';
import path from 'node:path';
import { setTimeout } from 'node:timers/promises';
import semver from 'semver';
import { z } from 'zod';
import { retryAsync } from './retry';
@@ -203,7 +202,7 @@ export namespace IosSimulatorUtils {
env: NodeJS.ProcessEnv;
}): Promise<IosSimulatorUuid> {
if (UDID_PATTERN.test(deviceIdentifier)) {
return deviceIdentifier.toUpperCase() as IosSimulatorUuid;
return deviceIdentifier as IosSimulatorUuid;
}
const devices = await getAvailableDevicesAsync({ env, filter: 'available' });
const device = devices.find(candidate => candidate.name === deviceIdentifier);
@@ -285,23 +284,9 @@ export namespace IosSimulatorUtils {
const readinessScreenshotPath = path.join(os.tmpdir(), 'eas-simulator-readiness.png');
await retryAsync(
async () => {
const { stdout: enumerateStdout } = await spawn(
'xcrun',
['simctl', 'io', udid, 'enumerate'],
{ env }
);
await spawn(
'xcrun',
[
'simctl',
'io',
udid,
'screenshot',
...displayFlagForScreenshot(enumerateStdout),
readinessScreenshotPath,
],
{ env }
);
await spawn('xcrun', ['simctl', 'io', udid, 'screenshot', readinessScreenshotPath], {
env,
});
},
{
retryOptions: {
@@ -313,30 +298,22 @@ export namespace IosSimulatorUtils {
);
await fs.promises.rm(readinessScreenshotPath, { force: true });
const device = await getDeviceAsync({ udid, env });
const runtimes = await getAvailableRuntimesAsync({ env });
const iosVersion = semver.coerce(
runtimes.find(runtime => runtime.identifier === device?.runtime)?.version
);
// From iOS 27.2 on, `com.apple.datamigrator` stays resident after the boot's data migration, so
// waiting for it to exit never ends; earlier runtimes exit it within about a minute of boot.
if (!iosVersion || semver.lt(iosVersion, '27.2.0')) {
// Based on WebKit's approach: https://trac.webkit.org/changeset/231452/webkit
await retryAsync(
async () => {
const isDataMigrating = await isDataMigratorProcessRunning({ env });
if (isDataMigrating) {
throw new Error('com.apple.datamigrator still running');
}
},
{
retryOptions: {
retries: 30 * 60,
retryIntervalMs: 1_000,
},
// Wait for data migration to complete before declaring the simulator ready
// Based on WebKit's approach: https://trac.webkit.org/changeset/231452/webkit
await retryAsync(
async () => {
const isDataMigrating = await isDataMigratorProcessRunning({ env });
if (isDataMigrating) {
throw new Error('com.apple.datamigrator still running');
}
);
}
},
{
retryOptions: {
retries: 30 * 60,
retryIntervalMs: 1_000,
},
}
);
}
export async function disableApsdAsync({
@@ -545,20 +522,6 @@ async function isLaunchctlServiceLoadedAsync({
}
}
/**
* `simctl io screenshot` refuses to choose between the iPhone Duo's two integrated screens on
* iOS 27.2, while the simctl in Xcode 15.3 rejects a numeric `--display` ("Device does not have a
* '1' display port"), so the flag is passed only when there is a choice to make.
*/
function displayFlagForScreenshot(enumerateStdout: string): string[] {
// `simctl io enumerate` lists each screen as an indented "(n) Name:" header followed by its fields.
const screens = enumerateStdout.split(/^ {4}\(\d+\) .*:$/m);
const integratedScreenIds = screens
.filter(screen => /^\s*Screen Type: Integrated$/m.test(screen))
.flatMap(screen => screen.match(/^\s*Screen ID: (\d+)$/m)?.[1] ?? []);
return integratedScreenIds.length > 1 ? [`--display=${integratedScreenIds[0]}`] : [];
}
function parseUdidFromBootstatusStdout(stdout: string): IosSimulatorUuid | null {
const matches = stdout.match(/^Monitoring boot status for .+ \((.+)\)\.$/m);
if (!matches) {
@@ -13,7 +13,7 @@ import {
AndroidVirtualDeviceName,
} from '../AndroidEmulatorUtils';
import { retryAsync } from '../retry';
import { AndroidEmulatorLogFiles } from '../androidEmulatorLogFiles';
import { AndroidEmulatorLogCapture } from '../androidEmulatorLogCapture';
import { ALL_ANDROID_EMULATOR_LOG_SOURCES } from '../androidEmulatorLogSources';
// We need to use real fs for cloning devices to work.
@@ -80,7 +80,8 @@ describe('AndroidEmulatorUtils', () => {
logger: createMockLogger({ logToConsole: true }),
});
({ serialId } = await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName,
env: { ...process.env, ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1' },
logcatDirectory,
@@ -108,7 +109,8 @@ describe('AndroidEmulatorUtils', () => {
logger: createMockLogger({ logToConsole: true }),
});
const { serialId, emulatorPromise } = await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName,
env: { ...process.env, ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1' },
logcatDirectory,
@@ -139,7 +141,8 @@ describe('AndroidEmulatorUtils', () => {
const { serialId: serialIdClone, emulatorPromise: emulatorPromiseClone } =
await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName: cloneDeviceName,
env: { ...process.env, ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1' },
logcatDirectory,
@@ -177,7 +180,8 @@ describe('AndroidEmulatorUtils', () => {
});
const { serialId, emulatorPromise } = await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName,
env: { ...process.env, ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1' },
logcatDirectory,
@@ -232,7 +236,8 @@ describe('AndroidEmulatorUtils', () => {
});
const startResult = await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName,
env: envForAttempt,
logcatDirectory,
@@ -316,7 +321,8 @@ describe('AndroidEmulatorUtils', () => {
logger,
});
const startResult = await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName,
env: { ...process.env, ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1' },
logcatDirectory: testLogcatDirectory,
@@ -410,7 +416,8 @@ describe('AndroidEmulatorUtils', () => {
});
const { serialId, emulatorPromise } = await AndroidEmulatorUtils.startAsync({
logCapture: new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES }),
logCapture: new AndroidEmulatorLogCapture(Infinity),
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
deviceName,
env: { ...process.env, ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1' },
logcatDirectory,
@@ -14,8 +14,7 @@ import {
AndroidVirtualDeviceName,
} from '../AndroidEmulatorUtils';
import { retryAsync } from '../retry';
import { AndroidEmulatorLogRing } from '../androidEmulatorLogCapture';
import { AndroidEmulatorLogFiles } from '../androidEmulatorLogFiles';
import { AndroidEmulatorLogCapture } from '../androidEmulatorLogCapture';
import {
ALL_ANDROID_EMULATOR_LOG_SOURCES,
AndroidEmulatorLogSourcesSchema,
@@ -185,9 +184,9 @@ describe('AndroidEmulatorUtils', () => {
});
describe(AndroidEmulatorUtils.startAsync, () => {
let buildCapture: AndroidEmulatorLogFiles;
let buildCapture: AndroidEmulatorLogCapture;
beforeEach(() => {
buildCapture = new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES });
buildCapture = new AndroidEmulatorLogCapture(Infinity);
});
afterEach(async () => {
await buildCapture.finishAsync();
@@ -240,13 +239,12 @@ describe('AndroidEmulatorUtils', () => {
const { child } = mockSuccessfulStart(deviceName);
await AndroidEmulatorUtils.startAsync({
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
logCapture: buildCapture,
deviceName,
env: process.env,
logcatDirectory: outputDir,
});
child.emit('close');
await buildCapture.finishAsync();
expect(await logFile(outputDir, 'logcat')).toMatch(
new RegExp(`^${outputDir}/eas-simulator-[a-f0-9]{8}-[a-f0-9]{4}-logcat\\.log$`)
@@ -269,6 +267,7 @@ describe('AndroidEmulatorUtils', () => {
// for as long as the emulator runs.
expect(child.stdout.unref).toHaveBeenCalled();
expect(child.stderr.unref).toHaveBeenCalled();
child.emit('close');
});
it.each([
@@ -283,15 +282,13 @@ describe('AndroidEmulatorUtils', () => {
const { child } = mockSuccessfulStart(deviceName);
const stdoutPipe = jest.spyOn(child.stdout, 'pipe');
const stderrPipe = jest.spyOn(child.stderr, 'pipe');
const capture = new AndroidEmulatorLogFiles({
sources: AndroidEmulatorLogSourcesSchema.parse(sources),
});
const prepare = jest.spyOn(capture, 'prepareLogcatOutputAsync');
const prepare = jest.spyOn(buildCapture, 'prepareLogcatOutputAsync');
await AndroidEmulatorUtils.startAsync({
logCapture: capture,
logCapture: buildCapture,
deviceName,
env: {},
logcatDirectory: outputDir,
logSources: AndroidEmulatorLogSourcesSchema.parse(sources),
});
const capturesOutput = sources.includes('emulator-output');
const capturesLogcat = sources.includes('device-logcat');
@@ -310,9 +307,7 @@ describe('AndroidEmulatorUtils', () => {
child.stdout.emit('data', Buffer.from('stdout marker\n'));
child.stderr.emit('data', Buffer.from('stderr marker\n'));
child.emit('close');
}
await capture.finishAsync();
if (capturesOutput) {
await buildCapture.finishAsync();
await expect(
fs.promises.readFile(await logFile(outputDir, 'emulator'), 'utf8')
).resolves.toBe('stdout marker\nstderr marker\n');
@@ -328,7 +323,7 @@ describe('AndroidEmulatorUtils', () => {
temporaryDirectories.push(outputDir);
const deviceName = 'bounded-emulator' as AndroidVirtualDeviceName;
const { child } = mockSuccessfulStart(deviceName);
const capture = new AndroidEmulatorLogRing({ sources: ['device-logcat'] });
const capture = new AndroidEmulatorLogCapture();
const close = jest.fn();
const createPipe = jest.spyOn(capture, 'prepareLogcatOutputAsync').mockResolvedValue({
path: '/logcat.pipe',
@@ -339,13 +334,10 @@ describe('AndroidEmulatorUtils', () => {
deviceName,
env: {},
logcatDirectory: outputDir,
logSources: ['device-logcat'],
logCapture: capture,
});
expect(createPipe).toHaveBeenCalledWith(
expect.stringMatching(
new RegExp(`^${outputDir}/bounded-emulator-[a-f0-9]{8}-[a-f0-9]{4}-logcat\\.log$`)
)
);
expect(createPipe).toHaveBeenCalledWith(await logFile(outputDir, 'logcat'));
expect(mockedSpawn.mock.calls[0][1]).toEqual(
expect.arrayContaining(['-logcat-output', '/logcat.pipe'])
);
@@ -353,7 +345,7 @@ describe('AndroidEmulatorUtils', () => {
child.emit('close');
await capture.finishAsync();
expect(close).toHaveBeenCalledTimes(1);
expect(await fs.promises.readdir(outputDir)).toEqual([]);
expect(await fs.promises.readdir(outputDir)).toHaveLength(1);
});
it('spawns the emulator directly with the same arguments when there is no launch gate', async () => {
@@ -364,6 +356,7 @@ describe('AndroidEmulatorUtils', () => {
const env = { ANDROID_EMULATOR_EXTRA_ARGS: '-gpu swiftshader_indirect' };
await AndroidEmulatorUtils.startAsync({
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
logCapture: buildCapture,
deviceName,
env,
@@ -423,6 +416,7 @@ describe('AndroidEmulatorUtils', () => {
const admitAsync = jest.fn().mockResolvedValue(undefined);
await AndroidEmulatorUtils.startAsync({
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
logCapture: buildCapture,
deviceName,
env: {},
@@ -487,6 +481,7 @@ describe('AndroidEmulatorUtils', () => {
await expect(
AndroidEmulatorUtils.startAsync({
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
logCapture: buildCapture,
deviceName,
env: {},
@@ -512,6 +507,7 @@ describe('AndroidEmulatorUtils', () => {
try {
await expect(
AndroidEmulatorUtils.startAsync({
logSources: ALL_ANDROID_EMULATOR_LOG_SOURCES,
logCapture: buildCapture,
deviceName,
env: process.env,
@@ -252,179 +252,24 @@ describe('IosSimulatorUtils', () => {
});
describe(IosSimulatorUtils.waitForReadyAsync, () => {
const readinessScreenshotPath = path.join(os.tmpdir(), 'eas-simulator-readiness.png');
it('takes the readiness screenshot into a writable temp file, not /dev/null', async () => {
mockSimulator({});
await IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env });
expect(mockedSpawn).toHaveBeenCalledWith(
'xcrun',
['simctl', 'io', 'test-udid', 'screenshot', readinessScreenshotPath],
{ env: process.env }
);
});
it('names the first integrated screen when the device has several (iPhone Duo on iOS 27.2)', async () => {
// Connected screens from `xcrun simctl io <udid> enumerate` on an iPhone Duo (iOS 27.2).
mockSimulator({
version: '27.2',
connectedScreens: ` Connected Screens:
(1) LCD:
Screen ID: 1
Screen Type: Integrated
(2) TVOut:
Screen ID: 2
Screen Type: TVOut
(3) LCD-1:
Screen ID: 3
Screen Type: Integrated
`,
await IosSimulatorUtils.waitForReadyAsync({
udid: 'test-udid' as any,
env: process.env,
});
await IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env });
expect(mockedSpawn).toHaveBeenCalledWith(
'xcrun',
['simctl', 'io', 'test-udid', 'screenshot', '--display=1', readinessScreenshotPath],
[
'simctl',
'io',
'test-udid',
'screenshot',
path.join(os.tmpdir(), 'eas-simulator-readiness.png'),
],
{ env: process.env }
);
});
it('takes the first listed integrated screen, skipping screens that are not integrated', async () => {
mockSimulator({
connectedScreens: ` Connected Screens:
(1) TVOut:
Screen ID: 1
Screen Type: TVOut
(2) LCD-1:
Screen ID: 5
Screen Type: Integrated
(3) LCD:
Screen ID: 3
Screen Type: Integrated
`,
});
await IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env });
expect(mockedSpawn).toHaveBeenCalledWith(
'xcrun',
['simctl', 'io', 'test-udid', 'screenshot', '--display=5', readinessScreenshotPath],
{ env: process.env }
);
});
it('keeps the plain screenshot when the device has one integrated screen', async () => {
mockSimulator({
connectedScreens: ` Connected Screens:
(2) TVOut:
Screen ID: 2
Screen Type: TVOut
(1) LCD:
Screen ID: 1
Screen Type: Integrated
`,
});
await IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env });
expect(mockedSpawn).toHaveBeenCalledWith(
'xcrun',
['simctl', 'io', 'test-udid', 'screenshot', readinessScreenshotPath],
{ env: process.env }
);
});
it.each(['27.2', '27.3', '28.0'])(
'does not wait for com.apple.datamigrator to exit on iOS %s, where it stays resident',
async version => {
mockSimulator({ version, dataMigratorRunning: true });
await IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env });
expect(mockedSpawn).not.toHaveBeenCalledWith('ps', expect.anything(), expect.anything());
}
);
it.each(['27.1', '26.3.1', '18.6'])(
'waits for com.apple.datamigrator to exit on iOS %s',
async version => {
mockSimulator({ version, dataMigratorRunning: true });
await expect(
IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env })
).rejects.toThrow('com.apple.datamigrator still running');
expect(mockedSpawn).toHaveBeenCalledWith('ps', ['-eo', 'pid,comm'], { env: process.env });
}
);
it('waits for com.apple.datamigrator to exit when the device is not listed', async () => {
mockSimulator({ listed: false, dataMigratorRunning: true });
await expect(
IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env })
).rejects.toThrow('com.apple.datamigrator still running');
});
it('waits for com.apple.datamigrator to exit when the runtime reports no version', async () => {
mockSimulator({ version: null, dataMigratorRunning: true });
await expect(
IosSimulatorUtils.waitForReadyAsync({ udid: 'test-udid' as any, env: process.env })
).rejects.toThrow('com.apple.datamigrator still running');
});
function mockSimulator({
version = '26.4',
listed = true,
connectedScreens = '',
dataMigratorRunning = false,
}: {
version?: string | null;
listed?: boolean;
connectedScreens?: string;
dataMigratorRunning?: boolean;
}): void {
const runtime = 'com.apple.CoreSimulator.SimRuntime.iOS-26-4';
const otherRuntime = {
identifier: 'com.apple.CoreSimulator.SimRuntime.iOS-27-2',
version: '27.2',
};
mockedSpawn.mockImplementation((async (command: string, args: string[]) => {
if (command === 'ps') {
return {
stdout: dataMigratorRunning
? ' 123 /sbin/launchd_sim\n 456 /Library/Developer/CoreSimulator/Volumes/iOS_23E244/XPCServices/com.apple.datamigrator.xpc/com.apple.datamigrator\n'
: ' 123 /sbin/launchd_sim\n',
stderr: '',
} as any;
}
if (args.includes('runtimes')) {
return {
stdout: JSON.stringify({
runtimes: [
otherRuntime,
version === null ? { identifier: runtime } : { identifier: runtime, version },
],
}),
stderr: '',
} as any;
}
if (args.includes('list')) {
return {
stdout: JSON.stringify({
devices: { [runtime]: listed ? [{ udid: 'test-udid' }] : [] },
}),
stderr: '',
} as any;
}
if (args.includes('enumerate')) {
return { stdout: connectedScreens, stderr: '' } as any;
}
return { stdout: '', stderr: '' } as any;
}) as any);
}
});
describe(IosSimulatorUtils.disableApsdAsync, () => {
@@ -582,15 +427,6 @@ describe('IosSimulatorUtils', () => {
expect(mockedSpawn).not.toHaveBeenCalled();
});
it('uppercases a udid given in lowercase, matching how simctl lists devices', async () => {
await expect(
IosSimulatorUtils.resolveUdidAsync({
deviceIdentifier: '8027f627-9534-4679-85bf-0f14aff228e8' as any,
env: process.env,
})
).resolves.toBe('8027F627-9534-4679-85BF-0F14AFF228E8');
});
it('resolves a device name to the first available device with that name', async () => {
mockedSpawn.mockResolvedValue({
stdout: JSON.stringify({
@@ -7,10 +7,9 @@ import { PassThrough, Readable } from 'node:stream';
import { Sentry } from '../../sentry';
import {
AndroidEmulatorLogRing,
AndroidEmulatorLogCapture,
MAX_ANDROID_LOG_BYTES_PER_SOURCE,
} from '../androidEmulatorLogCapture';
import { ALL_ANDROID_EMULATOR_LOG_SOURCES } from '../androidEmulatorLogSources';
jest.unmock('fs');
jest.unmock('node:fs');
@@ -27,27 +26,25 @@ afterEach(async () => {
await fs.rm(directory, { recursive: true, force: true });
});
function createCapture(maxBytes?: number): AndroidEmulatorLogRing {
return new AndroidEmulatorLogRing({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES, maxBytes });
}
/** `==== <name> <ISO time> ====\n` */
function markerLength(name: string): number {
return name.length + 36;
}
async function record(
capture: AndroidEmulatorLogRing,
capture: AndroidEmulatorLogCapture,
file: string,
text: string,
source: 'emulator-output' | 'device-logcat' = 'emulator-output'
text: string
): Promise<void> {
const input = Readable.from([Buffer.from(text)]);
capture.attach(input, file, source);
capture.attach(input, file, 'emulator-output');
await once(input, 'end');
await capture.finishFileAsync(file);
}
async function waitForSize(file: string, size: number): Promise<void> {
const deadline = Date.now() + 2_000;
while ((await fs.stat(file)).size !== size && Date.now() < deadline) {
await new Promise(resolve => setTimeout(resolve, 5));
}
expect((await fs.stat(file)).size).toBe(size);
}
function trackOpenedFiles(): FileHandle[] {
const opened: FileHandle[] = [];
const open = fs.open;
@@ -59,69 +56,121 @@ function trackOpenedFiles(): FileHandle[] {
return opened;
}
it('keeps one ring per source across launches and names each launch that wrote', async () => {
const capture = createCapture(120);
const emulatorRing = path.join(directory, 'emulator-output.log');
const logcatRing = path.join(directory, 'device-logcat.log');
await record(capture, path.join(directory, 'first-emulator.log'), 'first!');
await record(capture, path.join(directory, 'retry-emulator.log'), 'second!!');
await record(capture, path.join(directory, 'one-logcat.log'), 'device log', 'device-logcat');
it('keeps the newest bytes of a source across launches, with independent budgets for the two sources', async () => {
const capture = new AndroidEmulatorLogCapture(10);
const first = path.join(directory, 'first.log');
const retry = path.join(directory, 'retry.log');
const device = path.join(directory, 'logcat.log');
await record(capture, first, 'first!');
await record(capture, retry, 'second!!');
const logcat = Readable.from([Buffer.from('device logs are separate')]);
capture.attach(logcat, device, 'device-logcat');
await once(logcat, 'end');
// A partially evicted file keeps its size on disk until it is sealed.
expect((await fs.stat(first)).size).toBe(6);
const logs = await capture.finishAsync();
const seen = markerLength('first-emulator') + 6 + 1 + markerLength('retry-emulator') + 8;
expect(logs).toEqual([
{ filePath: emulatorRing, source: 'emulator-output', bytesSeen: seen },
{ filePath: logcatRing, source: 'device-logcat', bytesSeen: markerLength('one-logcat') + 10 },
{ filePath: first, source: 'emulator-output', bytesSeen: 6 },
{ filePath: retry, source: 'emulator-output', bytesSeen: 8 },
{ filePath: device, source: 'device-logcat', bytesSeen: 24 },
]);
expect(await fs.readFile(emulatorRing, 'utf8')).toMatch(
/^==== first-emulator \S+ ====\nfirst!\n==== retry-emulator \S+ ====\nsecond!!$/
);
expect(await fs.readFile(logcatRing, 'utf8')).toMatch(/^==== one-logcat \S+ ====\ndevice log$/);
expect((await fs.readdir(directory)).sort()).toEqual([
'device-logcat.log',
'emulator-output.log',
// The retry evicts the head of the earlier launch; its own tail stays whole.
expect(await fs.readFile(first, 'utf8')).toBe('t!');
expect(await fs.readFile(retry, 'utf8')).toBe('second!!');
expect(await fs.readFile(device, 'utf8')).toBe('e separate');
});
it('frees a finished file on disk once a later launch evicts all of it', async () => {
const capture = new AndroidEmulatorLogCapture(10);
const first = path.join(directory, 'first.log');
const retry = path.join(directory, 'retry.log');
await record(capture, first, 'first!');
const input = new PassThrough();
capture.attach(input, retry, 'emulator-output');
input.write('second log is too long');
await waitForSize(first, 0);
await capture.finishAsync();
expect(await fs.readFile(first, 'utf8')).toBe('');
expect(await fs.readFile(retry, 'utf8')).toBe('s too long');
});
it('frees a fully evicted live capture on disk and records its later output', async () => {
const capture = new AndroidEmulatorLogCapture(10);
const first = path.join(directory, 'first.log');
const second = path.join(directory, 'second.log');
const a = new PassThrough();
const b = new PassThrough();
capture.attach(a, first, 'emulator-output');
capture.attach(b, second, 'emulator-output');
// Wait between writes: two streams deliver their first chunks in either order.
a.write('0123456789');
await waitForSize(first, 10);
b.write('abcdefghij');
await waitForSize(first, 0);
await waitForSize(second, 10);
a.write('xy');
await capture.finishAsync();
expect(await fs.readFile(first, 'utf8')).toBe('xy');
expect(await fs.readFile(second, 'utf8')).toBe('cdefghij');
});
it('closes an uncapped file when its stream finishes', async () => {
const opened = trackOpenedFiles();
const capture = new AndroidEmulatorLogCapture(Infinity);
const file = path.join(directory, 'build.log');
await record(capture, file, 'ordinary build output');
expect(opened).toHaveLength(1);
expect(opened[0].fd).toBe(-1);
expect(await fs.readFile(file, 'utf8')).toBe('ordinary build output');
expect(await capture.finishAsync()).toEqual([
{ filePath: file, source: 'emulator-output', bytesSeen: 21 },
]);
});
it('keeps the tail of the final launch when the ring overflows', async () => {
const capture = createCapture(120);
await record(capture, path.join(directory, 'first-emulator.log'), 'first!');
await record(capture, path.join(directory, 'retry-emulator.log'), 'y'.repeat(100));
const [log] = await capture.finishAsync();
const result = await fs.readFile(log.filePath, 'utf8');
expect(result).toHaveLength(120);
expect(result.endsWith('y'.repeat(100))).toBe(true);
expect(result).not.toContain('first!');
expect(log.bytesSeen).toBeGreaterThan(120);
it('closes the file and reports once when sealing fails', async () => {
const opened = trackOpenedFiles();
const capture = new AndroidEmulatorLogCapture(10);
const file = path.join(directory, 'wrapped.log');
await record(capture, file, '0123456789abcdef');
const diskError = Object.assign(new Error('full'), { code: 'ENOSPC' });
jest.spyOn(opened[0], 'truncate').mockRejectedValueOnce(diskError);
await capture.finishAsync();
expect(opened[0].fd).toBe(-1);
expect(Sentry.capture).toHaveBeenCalledTimes(1);
expect(Sentry.capture).toHaveBeenCalledWith(
'Failed to write Android diagnostic log',
diskError,
expect.anything()
);
});
it('keeps the tail of a wrapped ring in order', async () => {
const capture = createCapture(10);
const capture = new AndroidEmulatorLogCapture(10);
const file = path.join(directory, 'wrapped.log');
const input = new PassThrough();
capture.attach(input, file, 'emulator-output');
for (const piece of ['0123', '4567', '89ab', 'cdef']) {
input.write(piece);
}
const [log] = await capture.finishAsync();
expect(await fs.readFile(log.filePath, 'utf8')).toBe('6789abcdef');
await capture.finishAsync();
expect(await fs.readFile(file, 'utf8')).toBe('6789abcdef');
});
it('lets overlapping launches of one source share the ring', async () => {
const capture = createCapture(400);
it('reserves bytes across simultaneous captures and drains after finalization', async () => {
const capture = new AndroidEmulatorLogCapture(10);
const a = new PassThrough();
const b = new PassThrough();
capture.attach(a, path.join(directory, 'clone-1.log'), 'emulator-output');
capture.attach(b, path.join(directory, 'clone-2.log'), 'emulator-output');
a.write('from clone 1 first\n');
b.write('from clone 2\n');
a.write('from clone 1 second\n');
const [log] = await capture.finishAsync();
const result = await fs.readFile(log.filePath, 'utf8');
expect(result).toMatch(/==== clone-1 \S+ ====\n/);
expect(result).toMatch(/==== clone-2 \S+ ====\n/);
expect(result).toContain('from clone 2\n');
expect(result.indexOf('from clone 1 first')).toBeLessThan(result.indexOf('from clone 1 second'));
expect(result).toHaveLength(log.bytesSeen);
const first = path.join(directory, 'first.log');
const second = path.join(directory, 'second.log');
capture.attach(a, first, 'emulator-output');
capture.attach(b, second, 'emulator-output');
a.write('12345678');
await waitForSize(first, 8);
b.write('abcdefgh');
await capture.finishAsync();
// The least recently written capture gives up its bytes first.
expect(await fs.readFile(first, 'utf8')).toBe('78');
expect(await fs.readFile(second, 'utf8')).toBe('abcdefgh');
a.end('ignored after cleanup');
b.end('also ignored');
expect(a.readableFlowing).toBe(true);
@@ -130,7 +179,7 @@ it('lets overlapping launches of one source share the ring', async () => {
it('drains a real FIFO beyond 20 MiB, retains the tail, and closes after the writer exits', async () => {
const file = path.join(directory, 'logcat.log');
const capture = createCapture();
const capture = new AndroidEmulatorLogCapture();
const pipe = await capture.prepareLogcatOutputAsync(file);
expect((await fs.stat(pipe.path)).isFIFO()).toBe(true);
const writer = spawn(
@@ -159,17 +208,12 @@ it('drains a real FIFO beyond 20 MiB, retains the tail, and closes after the wri
pipe.close();
await pipe.closed;
const logs = await capture.finishAsync();
const ring = path.join(directory, 'device-logcat.log');
const result = await fs.readFile(ring);
const result = await fs.readFile(file);
expect(result.length).toBe(MAX_ANDROID_LOG_BYTES_PER_SOURCE);
expect(result.subarray(0, 4).toString()).toBe('xxxx');
expect(result.subarray(-4).toString()).toBe('\nEND');
expect(logs).toEqual([
{
filePath: ring,
source: 'device-logcat',
bytesSeen: 64 * 1024 * 1024 + 10 + markerLength('logcat'),
},
{ filePath: file, source: 'device-logcat', bytesSeen: 64 * 1024 * 1024 + 10 },
]);
await expect(fs.stat(pipe.path)).rejects.toMatchObject({ code: 'ENOENT' });
} finally {
@@ -178,23 +222,33 @@ it('drains a real FIFO beyond 20 MiB, retains the tail, and closes after the wri
}
}, 30_000);
it('uses the original logcat path for ordinary builds without creating a FIFO', async () => {
const file = path.join(directory, 'build-logcat.log');
const capture = new AndroidEmulatorLogCapture(Infinity);
const output = await capture.prepareLogcatOutputAsync(file);
expect(output.path).toBe(file);
expect(await fs.readdir(directory)).toEqual([]);
output.close();
await output.closed;
expect(await capture.finishAsync()).toEqual([]);
});
it('closes an unused logcat pipe when the emulator fails to launch', async () => {
const file = path.join(directory, 'empty.log');
const capture = createCapture();
const capture = new AndroidEmulatorLogCapture();
const pipe = await capture.prepareLogcatOutputAsync(file);
pipe.close();
await pipe.closed;
await expect(fs.stat(pipe.path)).rejects.toMatchObject({ code: 'ENOENT' });
const ring = path.join(directory, 'device-logcat.log');
expect(await capture.finishAsync()).toEqual([
{ filePath: ring, source: 'device-logcat', bytesSeen: 0 },
{ filePath: file, source: 'device-logcat', bytesSeen: 0 },
]);
expect((await fs.stat(ring)).size).toBe(0);
expect((await fs.stat(file)).size).toBe(0);
}, 5_000);
it('keeps draining the FIFO after capture finishes while the emulator is alive', async () => {
const file = path.join(directory, 'live-logcat.log');
const capture = createCapture(10);
const capture = new AndroidEmulatorLogCapture(10);
const output = await capture.prepareLogcatOutputAsync(file);
const writer = spawn(
process.execPath,
@@ -225,7 +279,7 @@ it('keeps draining the FIFO after capture finishes while the emulator is alive',
expect(await once(writer, 'close')).toEqual([0, null]);
output.close();
await output.closed;
expect((await fs.stat(path.join(directory, 'device-logcat.log'))).size).toBe(0);
expect((await fs.stat(file)).size).toBe(0);
await expect(fs.stat(output.path)).rejects.toMatchObject({ code: 'ENOENT' });
} finally {
writer.kill();
@@ -235,7 +289,7 @@ it('keeps draining the FIFO after capture finishes while the emulator is alive',
}, 10_000);
it('reports a disk write failure once and continues draining output', async () => {
const capture = createCapture(10);
const capture = new AndroidEmulatorLogCapture(10);
const input = new PassThrough();
const file = path.join(directory, 'failed.log');
const diskError = Object.assign(new Error('full'), { code: 'ENOSPC' });
@@ -253,19 +307,3 @@ it('reports a disk write failure once and continues draining output', async () =
);
expect(input.readableFlowing).toBe(true);
});
it('closes the file and reports once when sealing fails', async () => {
const opened = trackOpenedFiles();
const capture = createCapture(10);
await record(capture, path.join(directory, 'wrapped.log'), '0123456789abcdef');
const diskError = Object.assign(new Error('full'), { code: 'ENOSPC' });
jest.spyOn(opened[0], 'truncate').mockRejectedValueOnce(diskError);
await capture.finishAsync();
expect(opened[0].fd).toBe(-1);
expect(Sentry.capture).toHaveBeenCalledTimes(1);
expect(Sentry.capture).toHaveBeenCalledWith(
'Failed to write Android diagnostic log',
diskError,
expect.anything()
);
});
@@ -1,89 +0,0 @@
import { once } from 'node:events';
import fs from 'node:fs';
import os from 'node:os';
import path from 'node:path';
import { PassThrough, Readable } from 'node:stream';
import { Sentry } from '../../sentry';
import { AndroidEmulatorLogFiles } from '../androidEmulatorLogFiles';
import { ALL_ANDROID_EMULATOR_LOG_SOURCES } from '../androidEmulatorLogSources';
jest.unmock('fs');
jest.unmock('node:fs');
jest.unmock('fs/promises');
jest.unmock('node:fs/promises');
jest.mock('../../sentry', () => ({ Sentry: { capture: jest.fn() } }));
let directory: string;
beforeEach(async () => {
directory = await fs.promises.mkdtemp(path.join(os.tmpdir(), 'android-build-logs-'));
});
afterEach(async () => {
jest.restoreAllMocks();
await fs.promises.rm(directory, { recursive: true, force: true });
});
function trackWriteStreams(): fs.WriteStream[] {
const streams: fs.WriteStream[] = [];
const createWriteStream = fs.createWriteStream;
jest.spyOn(fs, 'createWriteStream').mockImplementation((file, options) => {
const stream = createWriteStream(file, options);
streams.push(stream);
return stream;
});
return streams;
}
it('appends one plain file per launch, closes it when the launch ends, and finalizes nothing', async () => {
const streams = trackWriteStreams();
const capture = new AndroidEmulatorLogFiles({ sources: ALL_ANDROID_EMULATOR_LOG_SOURCES });
const first = path.join(directory, 'first-emulator.log');
const stdout = Readable.from([Buffer.from('out ')]);
const stderr = Readable.from([Buffer.from('err')]);
capture.attach(stdout, first, 'emulator-output');
capture.attach(stderr, first, 'emulator-output');
await Promise.all([once(stdout, 'end'), once(stderr, 'end')]);
await capture.finishFileAsync(first);
expect(streams).toHaveLength(1);
expect(streams[0].closed).toBe(true);
expect(await fs.promises.readFile(first, 'utf8')).toBe('out err');
const retry = path.join(directory, 'retry-emulator.log');
const input = Readable.from([Buffer.from('retry')]);
capture.attach(input, retry, 'emulator-output');
await once(input, 'end');
expect(await capture.finishAsync()).toEqual([]);
expect(streams[1].closed).toBe(true);
expect((await fs.promises.readdir(directory)).sort()).toEqual([
'first-emulator.log',
'retry-emulator.log',
]);
});
it('gives the emulator the logcat file itself without creating a FIFO', async () => {
const capture = new AndroidEmulatorLogFiles({ sources: ['device-logcat'] });
const file = path.join(directory, 'build-logcat.log');
const output = await capture.prepareLogcatOutputAsync(file);
expect(output.path).toBe(file);
expect(await fs.promises.readdir(directory)).toEqual(['build-logcat.log']);
output.close();
await output.closed;
expect(await capture.finishAsync()).toEqual([]);
});
it('reports a write failure once and keeps draining the emulator', async () => {
const capture = new AndroidEmulatorLogFiles({ sources: ['emulator-output'] });
const input = new PassThrough();
const file = path.join(directory, 'missing-directory', 'failed.log');
capture.attach(input, file, 'emulator-output');
input.write('first');
await capture.finishFileAsync(file);
input.write('second');
input.end('more');
expect(Sentry.capture).toHaveBeenCalledTimes(1);
expect(Sentry.capture).toHaveBeenCalledWith(
'Failed to write Android diagnostic log',
expect.objectContaining({ code: 'ENOENT' }),
expect.anything()
);
expect(input.readableFlowing).toBe(true);
});
@@ -1,38 +1,7 @@
import { EnvironmentSecretType } from '@expo/eas-build-job';
import fs from 'fs/promises';
import { vol } from 'memfs';
import {
createTemporaryEnvironmentSecretFile,
getStringEnvironmentSecretValue,
} from '../environmentSecrets';
describe(getStringEnvironmentSecretValue, () => {
it('returns the last string secret with the name, like the build env', () => {
expect(
getStringEnvironmentSecretValue(
[
{ name: 'TOKEN', type: EnvironmentSecretType.STRING, value: 'first' },
{ name: 'OTHER', type: EnvironmentSecretType.STRING, value: 'other' },
{ name: 'TOKEN', type: EnvironmentSecretType.STRING, value: 'last' },
],
'TOKEN'
)
).toBe('last');
});
it('returns null when the last secret with the name is a file secret', () => {
expect(
getStringEnvironmentSecretValue(
[
{ name: 'TOKEN', type: EnvironmentSecretType.STRING, value: 'a' },
{ name: 'TOKEN', type: EnvironmentSecretType.FILE, value: 'Yg==' },
],
'TOKEN'
)
).toBeNull();
});
});
import { createTemporaryEnvironmentSecretFile } from '../environmentSecrets';
describe(createTemporaryEnvironmentSecretFile, () => {
beforeEach(async () => {
@@ -1,78 +0,0 @@
import spawn from '@expo/turtle-spawn';
import { resolveSimulatorPackageVersionAsync } from '../simulatorPackageVersion';
jest.mock('@expo/turtle-spawn');
beforeEach(() => jest.resetAllMocks());
it.each(['1.2.3', 'v1.2.3', '1.2.3-beta.1', '1.2.3-beta.1+build.2', 'v1.2.3+build.2'])(
'compares an exact request without a registry call (%s)',
async requested => {
await expect(
resolveSimulatorPackageVersionAsync('serve-sim', requested, { env: {} })
).resolves.toBe(requested.replace(/^v/, ''));
expect(spawn).not.toHaveBeenCalled();
}
);
it.each([
['serve-sim', '@expo/serve-sim'],
['agent-device', 'agent-device'],
['argent', '@swmansion/argent'],
['appium', 'appium'],
] as const)('checks the current dist-tag for %s', async (engine, name) => {
jest.mocked(spawn).mockResolvedValue({ stdout: '"1.2.4"' } as never);
const env = { NPM_CONFIG_REGISTRY: 'https://registry.example' };
const signal = new AbortController().signal;
await expect(
resolveSimulatorPackageVersionAsync(engine, 'latest', { env, signal })
).resolves.toBe('1.2.4');
expect(spawn).toHaveBeenCalledWith(
'npm',
[
'view',
`${name}@latest`,
'version',
'--json',
'--prefer-online',
'--prefer-offline=false',
'--offline=false',
'--fetch-retries=0',
],
{ env, signal, stdio: 'pipe', timeout: 30_000 }
);
});
it('selects the newest matching version from range metadata without relying on output order', async () => {
jest.mocked(spawn).mockResolvedValue({ stdout: '["3.9.0","3.10.0","3.8.0"]' } as never);
await expect(resolveSimulatorPackageVersionAsync('appium', '^3', { env: {} })).resolves.toBe(
'3.10.0'
);
});
it.each(['not json', '{}', '[]', '"latest"'])(
'rejects unusable registry output (%s)',
async stdout => {
jest.mocked(spawn).mockResolvedValue({ stdout } as never);
await expect(
resolveSimulatorPackageVersionAsync('serve-sim', 'latest', { env: {} })
).rejects.toThrow();
}
);
it('preserves registry lookup failures instead of trusting the prepared version', async () => {
const error = new Error('registry unavailable');
jest.mocked(spawn).mockRejectedValue(error);
await expect(resolveSimulatorPackageVersionAsync('argent', 'latest', { env: {} })).rejects.toBe(
error
);
});
it('does not look up a cancelled request', async () => {
const signal = AbortSignal.abort(new Error('cancelled'));
await expect(
resolveSimulatorPackageVersionAsync('serve-sim', 'latest', { env: {}, signal })
).rejects.toThrow('cancelled');
expect(spawn).not.toHaveBeenCalled();
});
@@ -1,10 +1,7 @@
import { SystemError } from '@expo/eas-build-job';
import downloadFile from '@expo/downloader';
import spawn from '@expo/turtle-spawn';
import { spawnSync } from 'node:child_process';
import fs from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import { createMockLogger } from '../../__tests__/utils/logger';
import { BuildContext } from '../../context';
@@ -167,14 +164,10 @@ describe(startUptermHostAsync, () => {
};
}
function makeCtx(
env: Record<string, string> = {},
buildDirectory = '/workingdir/build'
): BuildContext {
function makeCtx(env: Record<string, string> = {}): BuildContext {
return {
logger: createMockLogger(),
env,
buildDirectory,
} as unknown as BuildContext;
}
@@ -234,33 +227,6 @@ describe(startUptermHostAsync, () => {
);
});
it('starts each client shell in the build directory', async () => {
const realFs = jest.requireActual<typeof import('node:fs')>('node:fs');
const tmpDir = realFs.mkdtempSync(path.join(os.tmpdir(), 'eas-upterm-join-'));
try {
const buildDirectory = path.join(tmpDir, "it's $HOME `pwd`", 'build');
realFs.mkdirSync(buildDirectory, { recursive: true });
await startUptermHostAsync(makeCtx({}, buildDirectory), { relayServerUrl: 'wss://r' });
const joinScriptCall = mockedFs.writeFile.mock.calls.find(
([file]) => file === '/tmp/eas-ssh-1/join.sh'
);
const joinScriptPath = path.join(tmpDir, 'join.sh');
realFs.writeFileSync(joinScriptPath, String(joinScriptCall?.[1]));
const result = spawnSync('bash', [joinScriptPath], {
cwd: tmpDir,
env: { PATH: process.env.PATH, HOME: tmpDir },
input: 'pwd\n',
encoding: 'utf8',
});
expect(result.stdout.trim()).toBe(buildDirectory);
} finally {
realFs.rmSync(tmpDir, { recursive: true, force: true });
}
});
it('downloads from GCS into a fresh temp dir when upterm is not on PATH', async () => {
uptermOnPath = false;
@@ -1,18 +1,9 @@
import spawn from '@expo/turtle-spawn';
import fs from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import { setTimeout as sleepAsync } from 'node:timers/promises';
import { z } from 'zod';
import {
readPreparedSimulatorToolAsync,
runSimulatorLauncherAsync,
stopWarmSimulatorAsync,
} from '../warmSimulator';
import { runSimulatorLauncherAsync, stopWarmSimulatorAsync } from '../warmSimulator';
jest.mock('@expo/turtle-spawn');
jest.mock('node:timers/promises');
const originalPlatform = process.platform;
@@ -20,86 +11,12 @@ beforeEach(() => {
Object.defineProperty(process, 'platform', { value: 'darwin' });
jest.resetAllMocks();
jest.mocked(spawn).mockResolvedValue({ stdout: '{"ok":true}' } as never);
jest.spyOn(os, 'uptime').mockReturnValue(600);
jest.spyOn(fs, 'access').mockRejectedValue(new Error('no startup script'));
jest.mocked(sleepAsync).mockResolvedValue(undefined);
});
afterEach(() => {
jest.restoreAllMocks();
Object.defineProperty(process, 'platform', { value: originalPlatform });
});
it('reads different prepared tool schemas without Appium-specific fields', async () => {
const directory = path.join(os.homedir(), 'Library', 'Caches', 'expo-simulator-startup');
const appium = { home: path.join(directory, 'appium'), version: '3.9.0', xcuitest: '12.22.8' };
const otherTool = { version: '2.4.0' };
const expoGo = { sdk: '55.0.0', url: 'https://example.test/ExpoGo.tar.gz' };
const read = jest
.spyOn(fs, 'readFile')
.mockResolvedValue(
JSON.stringify({ tools: { appium, 'other-tool': otherTool, 'expo-go': expoGo } })
);
await expect(
readPreparedSimulatorToolAsync(
'appium',
z.object({ home: z.string(), version: z.string(), xcuitest: z.string() })
)
).resolves.toEqual(appium);
const prepared = await readPreparedSimulatorToolAsync(
'other-tool',
z.object({ version: z.string() })
);
expect(prepared?.version).toBe('2.4.0');
await expect(
readPreparedSimulatorToolAsync('expo-go', z.object({ sdk: z.string(), url: z.string() }))
).resolves.toEqual(expoGo);
expect(read.mock.calls).toEqual([
[path.join(directory, 'prepared.json'), 'utf8'],
[path.join(directory, 'prepared.json'), 'utf8'],
[path.join(directory, 'prepared.json'), 'utf8'],
]);
expect(spawn).not.toHaveBeenCalled();
});
it.each(['missing-tool', 'toString'])(
'does not invent %s metadata from schema defaults or inherited properties',
async tool => {
jest.spyOn(fs, 'readFile').mockResolvedValue('{"tools":{}}');
await expect(
readPreparedSimulatorToolAsync(tool, z.unknown().default({ version: '1.2.3' }))
).resolves.toBeUndefined();
}
);
it.each(['missing', 'invalid JSON', 'invalid fields', 'missing tool', 'older format'])(
'ignores prepared tool metadata with %s',
async failure => {
const read = jest.spyOn(fs, 'readFile');
switch (failure) {
case 'missing':
read.mockRejectedValue(Object.assign(new Error('missing'), { code: 'ENOENT' }));
break;
case 'invalid JSON':
read.mockResolvedValue('not JSON');
break;
case 'invalid fields':
read.mockResolvedValue(JSON.stringify({ tools: { tool: { version: 42 } } }));
break;
case 'missing tool':
read.mockResolvedValue('{"tools":{}}');
break;
case 'older format':
read.mockResolvedValue('{"appium":"3.9.0","xcuitest":"12.22.8","home":"/old/home"}');
break;
}
await expect(
readPreparedSimulatorToolAsync('tool', z.object({ version: z.string() }))
).resolves.toBeUndefined();
expect(spawn).not.toHaveBeenCalled();
}
);
it('runs the launcher version that start recorded and returns its output', async () => {
jest.spyOn(fs, 'readFile').mockResolvedValue('{"launcherVersion":"27.1.0"}');
await expect(runSimulatorLauncherAsync(['claim', 'serve-sim'], { env: {} })).resolves.toBe(
@@ -142,79 +59,3 @@ it('does nothing on other platforms', async () => {
await stopWarmSimulatorAsync({});
expect(spawn).not.toHaveBeenCalled();
});
const missing = Object.assign(new Error('missing'), { code: 'ENOENT' });
const warmEnv = { EAS_USE_WARM_SIMULATOR: '1', EAS_OVERRIDE_PACKAGE_MANAGER: 'bun' };
it('waits for startup to write state, then claims with the recorded launcher version', async () => {
jest.mocked(os.uptime).mockReturnValue(10);
jest.mocked(fs.access).mockResolvedValue();
jest
.spyOn(fs, 'readFile')
.mockRejectedValueOnce(missing)
.mockRejectedValueOnce(missing)
.mockResolvedValue('{"launcherVersion":"27.6.0"}');
await runSimulatorLauncherAsync(['claim', 'serve-sim'], { env: warmEnv });
expect(sleepAsync).toHaveBeenCalled();
expect(spawn).toHaveBeenCalledWith(
'bun',
['x', '@expo/[email protected]', 'claim', 'serve-sim'],
expect.objectContaining({ env: warmEnv })
);
});
it.each([
['a later session request', ['claim', 'serve-sim'], warmEnv, 300, true],
['a system without startup', ['claim', 'serve-sim'], warmEnv, 10, false],
['a job without warmup', ['claim', 'serve-sim'], {}, 10, true],
['stop', ['stop'], warmEnv, 10, true],
['prepare-tools', ['prepare-tools'], warmEnv, 10, true],
])('does not wait for %s', async (_name, args, env, uptime, installed) => {
jest.mocked(os.uptime).mockReturnValue(uptime);
if (installed) {
jest.mocked(fs.access).mockResolvedValue();
}
jest.spyOn(fs, 'readFile').mockRejectedValue(missing);
await runSimulatorLauncherAsync(args, { env });
expect(sleepAsync).not.toHaveBeenCalled();
expect(spawn).toHaveBeenCalled();
});
it('times out before invoking claim so its caller can stop warmup before starting cold', async () => {
jest.mocked(os.uptime).mockReturnValue(10);
jest.mocked(fs.access).mockResolvedValue();
jest.spyOn(fs, 'readFile').mockRejectedValue(missing);
let now = 0;
jest.spyOn(Date, 'now').mockImplementation(() => now);
jest.mocked(sleepAsync).mockImplementation(async delay => {
now += delay ?? 0;
});
await expect(runSimulatorLauncherAsync(['claim', 'serve-sim'], { env: warmEnv })).rejects.toThrow(
'Timed out waiting for the warm Simulator launcher to start.'
);
expect(now).toBe(60_000);
expect(spawn).not.toHaveBeenCalled();
await stopWarmSimulatorAsync(warmEnv);
expect(spawn).toHaveBeenCalledWith(
'bun',
['x', '@expo/simulator-launcher@latest', 'stop'],
expect.anything()
);
});
it('cancels the missing-state wait without invoking claim', async () => {
jest.mocked(os.uptime).mockReturnValue(10);
jest.mocked(fs.access).mockResolvedValue();
jest.spyOn(fs, 'readFile').mockRejectedValue(missing);
const controller = new AbortController();
jest.mocked(sleepAsync).mockImplementation(async () => {
controller.abort(new Error('cancelled'));
});
await expect(
runSimulatorLauncherAsync(['claim', 'serve-sim'], {
env: warmEnv,
signal: controller.signal,
})
).rejects.toThrow('cancelled');
expect(spawn).not.toHaveBeenCalled();
});
@@ -1,6 +1,5 @@
import fs from 'node:fs';
import { type FileHandle } from 'node:fs/promises';
import path from 'node:path';
import { type Readable, Writable } from 'node:stream';
import { finished } from 'node:stream/promises';
@@ -16,132 +15,108 @@ export type FinalizedAndroidEmulatorLog = {
readonly bytesSeen: number;
};
export type AndroidLogcatOutput = {
/** Where the emulator writes its logcat: a FIFO for sessions, the file itself for builds. */
path: string;
close: () => void;
/**
* Resolves once the pipe reader exited and the FIFO is removed. Emulator
* launch does not wait for it, because the emulator can outlive log
* collection; tests use it to observe the cleanup.
*/
closed: Promise<void>;
};
/** Records emulator output per launch file; `getAndroidEmulatorLogCapture` picks the writer. */
export type AndroidEmulatorLogCapture = {
readonly sources: readonly AndroidEmulatorLogSource[];
attach(input: Readable, filePath: string, source: AndroidEmulatorLogSource): void;
finishFileAsync(filePath: string): Promise<void>;
finishAsync(): Promise<readonly FinalizedAndroidEmulatorLog[]>;
prepareLogcatOutputAsync(filePath: string): Promise<AndroidLogcatOutput>;
};
/** One ring of `maxBytes` bytes: `writePos` wraps and the newest `retained` bytes end at it. */
type Ring = {
filePath: string;
/**
* One file is a ring of `maxBytes` bytes: `writePos` wraps and the newest
* `retained` bytes end at it. Sealing rewrites the file in log order.
*/
type Capture = {
source: AndroidEmulatorLogSource;
stream: Writable;
inputs: Set<Readable>;
done: Promise<void>;
/** Runs one file operation after every earlier one on the same handle. */
run: (operation: (handle: FileHandle) => Promise<void>) => Promise<void>;
sealed?: Promise<void>;
bytesSeen: number;
writePos: number;
retained: number;
};
/** One emulator launch. Launches of a source can overlap: clones, or a late exit. */
type Launch = {
ring: Ring;
stream: Writable;
inputs: Set<Readable>;
done: Promise<void>;
lastWrite: number;
};
/**
* One budget per session, shared by all emulator launches and retries.
* One budget per workflow, shared by all emulator launches and retries.
*
* Each source has one ring file, `<source>.log` beside the launch files, so
* the last `maxBytes` bytes of a source survive across launches and the tail
* of the final attempt is always kept. A marker line names each launch that
* produced output. Overlapping launches share the ring, so their lines can
* interleave. Logcat arrives through a named pipe so the budget applies to it.
* A source keeps the last `maxBytes` bytes it produced, across files. The
* oldest bytes go first, so an earlier launch gives up its head to a later
* one and the final attempt always keeps its tail, where failures explain
* themselves. The least recently written file gives up bytes first, which
* approximates byte age without tracking every chunk.
*
* Eviction is bookkeeping until a file loses all its bytes, which frees it
* on disk at once. A partially evicted file keeps its size until it is
* sealed, so one source occupies at most twice its budget while recording.
*/
export class AndroidEmulatorLogRing implements AndroidEmulatorLogCapture {
readonly sources: readonly AndroidEmulatorLogSource[];
private readonly maxBytes: number;
private readonly rings = new Map<AndroidEmulatorLogSource, Ring>();
private readonly launches = new Map<string, Launch>();
export class AndroidEmulatorLogCapture {
private readonly sources = new Map<AndroidEmulatorLogSource, Capture[]>();
private readonly captures = new Map<string, Capture>();
private finishing = false;
private writes = 0;
constructor({
sources,
maxBytes = MAX_ANDROID_LOG_BYTES_PER_SOURCE,
}: {
sources: readonly AndroidEmulatorLogSource[];
maxBytes?: number;
}) {
this.sources = sources;
this.maxBytes = maxBytes;
}
constructor(private readonly maxBytes = MAX_ANDROID_LOG_BYTES_PER_SOURCE) {}
attach(input: Readable, filePath: string, source: AndroidEmulatorLogSource): void {
if (this.finishing) {
input.resume();
return;
}
let launch = this.launches.get(filePath);
if (!launch) {
launch = this.startLaunch(filePath, this.ringFor(filePath, source));
this.launches.set(filePath, launch);
let capture = this.captures.get(filePath);
if (!capture) {
capture = this.open(filePath, source);
this.captures.set(filePath, capture);
const list = this.sources.get(source) ?? [];
list.push(capture);
this.sources.set(source, list);
}
launch.inputs.add(input);
input.pipe(launch.stream, { end: false });
capture.inputs.add(input);
input.pipe(capture.stream, { end: false });
}
async finishFileAsync(filePath: string): Promise<void> {
const launch = this.launches.get(filePath);
if (!launch) {
const capture = this.captures.get(filePath);
if (!capture) {
return;
}
for (const input of launch.inputs) {
input.unpipe(launch.stream);
for (const input of capture.inputs) {
input.unpipe(capture.stream);
// Keep draining: closing a full log must never block or break the emulator.
input.resume();
}
launch.inputs.clear();
launch.stream.end();
await launch.done;
capture.inputs.clear();
capture.stream.end();
await capture.done;
// Nothing can evict an uncapped file later, so release its handle now.
if (!Number.isFinite(this.maxBytes)) {
await this.sealAsync(capture);
}
}
async finishAsync(): Promise<readonly FinalizedAndroidEmulatorLog[]> {
this.finishing = true;
await Promise.all([...this.launches.keys()].map(file => this.finishFileAsync(file)));
await Promise.all([...this.rings.values()].map(ring => this.sealAsync(ring)));
await Promise.all([...this.captures.keys()].map(file => this.finishFileAsync(file)));
await Promise.all([...this.captures.values()].map(capture => this.sealAsync(capture)));
// Every writer is closed, so uploads can reopen these files on each retry.
return [...this.rings.values()].map(({ filePath, source, bytesSeen }) => ({
return [...this.captures].map(([filePath, { source, bytesSeen }]) => ({
filePath,
source,
bytesSeen,
}));
}
async prepareLogcatOutputAsync(filePath: string): Promise<AndroidLogcatOutput> {
/** Select the output transport without exposing the capture budget to emulator launch. */
async prepareLogcatOutputAsync(
filePath: string
): Promise<{ path: string; close: () => void; closed: Promise<void> }> {
// Ordinary builds retain the emulator's direct, uncapped logcat file writer.
if (!Number.isFinite(this.maxBytes)) {
return { path: filePath, close: () => {}, closed: Promise.resolve() };
}
const pipe = await createAndroidLogcatPipeAsync(`${filePath}.pipe`);
this.attach(pipe.stream, filePath, 'device-logcat');
const closed = pipe.closed.then(() => this.finishFileAsync(filePath)).catch(() => {});
return { path: pipe.path, close: pipe.close, closed };
}
private ringFor(filePath: string, source: AndroidEmulatorLogSource): Ring {
let ring = this.rings.get(source);
if (!ring) {
ring = this.open(path.join(path.dirname(filePath), `${source}.log`), source);
this.rings.set(source, ring);
}
return ring;
}
private open(filePath: string, source: AndroidEmulatorLogSource): Ring {
private open(filePath: string, source: AndroidEmulatorLogSource): Capture {
const file = fs.promises.open(filePath, 'w+');
// Handle open errors even if the process never produces output.
void file.catch(() => {});
@@ -167,47 +142,65 @@ export class AndroidEmulatorLogRing implements AndroidEmulatorLogCapture {
.catch(report);
return queue;
};
return { filePath, source, run, bytesSeen: 0, writePos: 0, retained: 0 };
}
private startLaunch(filePath: string, ring: Ring): Launch {
let marked = false;
const record = {
source,
inputs: new Set<Readable>(),
run,
bytesSeen: 0,
writePos: 0,
retained: 0,
lastWrite: 0,
};
const stream = new Writable({
write: (chunk: Buffer, _encoding, callback) => {
if (!marked) {
marked = true;
// Written before the first chunk only, so a silent launch leaves no trace.
const name = path.basename(filePath, '.log');
const marker = `==== ${name} ${new Date().toISOString()} ====\n`;
void this.write(ring, Buffer.from(ring.bytesSeen > 0 ? `\n${marker}` : marker));
record.bytesSeen += chunk.length;
if (failed) {
callback();
return;
}
void this.write(ring, chunk).then(() => callback());
const max = this.maxBytes;
const data = chunk.length > max ? chunk.subarray(chunk.length - max) : chunk;
const position = record.writePos;
const head = Math.min(data.length, max - position);
// Account before awaiting I/O so concurrent launches share the same cap.
record.writePos = (position + data.length) % max;
record.retained = Math.min(record.retained + data.length, max);
record.lastWrite = ++this.writes;
this.evict(source);
void run(async handle => {
await writeAtAsync(handle, data.subarray(0, head), position);
await writeAtAsync(handle, data.subarray(head), 0);
}).then(() => callback());
},
});
return { ring, stream, inputs: new Set(), done: finished(stream) };
return Object.assign(record, { stream, done: finished(stream) });
}
/** Account synchronously, then queue the I/O, so overlapping launches share one ring consistently. */
private write(ring: Ring, chunk: Buffer): Promise<void> {
const max = this.maxBytes;
ring.bytesSeen += chunk.length;
const data = chunk.length > max ? chunk.subarray(chunk.length - max) : chunk;
const position = ring.writePos;
const head = Math.min(data.length, max - position);
ring.writePos = (position + data.length) % max;
ring.retained = Math.min(ring.retained + data.length, max);
return ring.run(async handle => {
await writeAtAsync(handle, data.subarray(0, head), position);
await writeAtAsync(handle, data.subarray(head), 0);
});
/** Drop the oldest bytes of a source until its files fit the budget together. */
private evict(source: AndroidEmulatorLogSource): void {
const list = [...(this.sources.get(source) ?? [])].sort((a, b) => a.lastWrite - b.lastWrite);
let excess = list.reduce((sum, capture) => sum + capture.retained, 0) - this.maxBytes;
for (const capture of list) {
if (excess <= 0) {
return;
}
const dropped = Math.min(capture.retained, excess);
capture.retained -= dropped;
excess -= dropped;
if (dropped > 0 && capture.retained === 0) {
// Nothing of this file survives: free the disk after its queued writes land.
capture.writePos = 0;
void capture.run(handle => handle.truncate(0));
}
}
}
/** Rewrite the ring in log order, drop the overwritten bytes, and close the file. */
private sealAsync(ring: Ring): Promise<void> {
ring.sealed ??= ring.run(async handle => {
/** Rewrite the ring in log order, drop evicted bytes, and close the file. */
private sealAsync(capture: Capture): Promise<void> {
capture.sealed ??= capture.run(async handle => {
try {
const { retained } = ring;
let start = ring.writePos - retained;
const { retained } = capture;
let start = capture.writePos - retained;
if (start < 0) {
start += this.maxBytes;
}
@@ -223,7 +216,7 @@ export class AndroidEmulatorLogRing implements AndroidEmulatorLogCapture {
await handle.close();
}
});
return ring.sealed;
return capture.sealed;
}
}
@@ -1,74 +0,0 @@
import fs from 'node:fs';
import { type Readable } from 'node:stream';
import { finished } from 'node:stream/promises';
import { Sentry } from '../sentry';
import {
type AndroidEmulatorLogCapture,
type AndroidLogcatOutput,
type FinalizedAndroidEmulatorLog,
} from './androidEmulatorLogCapture';
import { type AndroidEmulatorLogSource } from './androidEmulatorLogSources';
type LaunchFile = { stream: fs.WriteStream; inputs: Set<Readable> };
/**
* Ordinary builds: one plain file per launch, appended without a budget and
* closed when the launch ends. The emulator writes logcat to its file directly.
* Nothing is finalized or uploaded.
*/
export class AndroidEmulatorLogFiles implements AndroidEmulatorLogCapture {
readonly sources: readonly AndroidEmulatorLogSource[];
private readonly files = new Map<string, LaunchFile>();
constructor({ sources }: { sources: readonly AndroidEmulatorLogSource[] }) {
this.sources = sources;
}
attach(input: Readable, filePath: string, source: AndroidEmulatorLogSource): void {
let file = this.files.get(filePath);
if (!file) {
const inputs = new Set<Readable>();
const stream = fs.createWriteStream(filePath, { flags: 'a' });
stream.once('error', err => {
Sentry.capture('Failed to write Android diagnostic log', err, {
level: 'warning',
extras: { filePath, source },
});
// The pipe detaches on error; keep draining so the emulator never blocks.
for (const attached of inputs) {
attached.resume();
}
});
file = { stream, inputs };
this.files.set(filePath, file);
}
file.inputs.add(input);
input.pipe(file.stream, { end: false });
}
async finishFileAsync(filePath: string): Promise<void> {
const file = this.files.get(filePath);
if (!file) {
return;
}
for (const input of file.inputs) {
input.unpipe(file.stream);
input.resume();
}
file.inputs.clear();
file.stream.end();
// A write error was reported when it happened.
await finished(file.stream).catch(() => {});
}
async finishAsync(): Promise<readonly FinalizedAndroidEmulatorLog[]> {
await Promise.all([...this.files.keys()].map(file => this.finishFileAsync(file)));
return [];
}
async prepareLogcatOutputAsync(filePath: string): Promise<AndroidLogcatOutput> {
await fs.promises.writeFile(filePath, '');
return { path: filePath, close: () => {}, closed: Promise.resolve() };
}
}
@@ -1,26 +1,7 @@
import { type EnvironmentSecret, EnvironmentSecretType } from '@expo/eas-build-job';
import crypto from 'crypto';
import fs from 'fs';
import path from 'path';
/**
* Returns the value of the string environment secret with this name, or null. It resolves
* duplicate names like the build context env does (the last secret wins). A file secret has no
* string value.
*/
export function getStringEnvironmentSecretValue(
environmentSecrets: EnvironmentSecret[] | undefined,
name: string
): string | null {
const secret = Array.from(environmentSecrets ?? [])
.reverse()
.find(secret => secret.name === name);
if (!secret || secret.type !== EnvironmentSecretType.STRING || !secret.value) {
return null;
}
return secret.value;
}
export function createTemporaryEnvironmentSecretFile({
secretsDir,
name,
@@ -1,48 +0,0 @@
import { type BuildStepEnv } from '@expo/steps';
import spawn from '@expo/turtle-spawn';
import semver from 'semver';
import { z } from 'zod';
const PackageNames = {
'serve-sim': '@expo/serve-sim',
'agent-device': 'agent-device',
argent: '@swmansion/argent',
appium: 'appium',
};
/** Resolve an explicit request once, so comparison and installation use the same version. */
export async function resolveSimulatorPackageVersionAsync(
engine: keyof typeof PackageNames,
requested: string,
{ env, signal }: { env: BuildStepEnv; signal?: AbortSignal }
): Promise<string> {
signal?.throwIfAborted();
const exact = semver.parse(requested);
if (exact) {
return exact.version + (exact.build.length ? `+${exact.build.join('.')}` : '');
}
// Use npm's configured registry and revalidate metadata instead of trusting a cached dist-tag.
const { stdout } = await spawn(
'npm',
[
'view',
`${PackageNames[engine]}@${requested}`,
'version',
'--json',
'--prefer-online',
'--prefer-offline=false',
'--offline=false',
'--fetch-retries=0',
],
{ env, signal, stdio: 'pipe', timeout: 30_000 }
);
signal?.throwIfAborted();
const version = z.string().refine(value => semver.valid(value) !== null);
const versions = z.union([version, z.array(version)]).parse(JSON.parse(stdout));
const candidates = typeof versions === 'string' ? [versions] : versions;
const resolved = semver.rsort(candidates)[0];
if (!resolved) {
throw new Error(`Could not resolve the requested ${engine} package version.`);
}
return resolved;
}
+1 -6
View File
@@ -202,12 +202,7 @@ export async function startUptermHostAsync(
await spawn('ssh-keygen', ['-t', 'ed25519', '-N', '', '-f', hostKeyPath, '-q'], {
logger: ctx.logger,
});
const quotedBuildDirectory = `'${ctx.buildDirectory.replaceAll("'", "'\\''")}'`;
await fs.writeFile(
forceCommandPath,
`#!/usr/bin/env bash\ncd -- ${quotedBuildDirectory}\nexec bash -l\n`,
{ mode: 0o755 }
);
await fs.writeFile(forceCommandPath, '#!/usr/bin/env bash\nexec bash -l\n', { mode: 0o755 });
let currentProcess: SpawnPromise<SpawnResult> | null = null;
@@ -1,10 +1,6 @@
import { type BuildStepEnv } from '@expo/steps';
import spawn from '@expo/turtle-spawn';
import fs from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import { setTimeout as sleepAsync } from 'node:timers/promises';
import { type ZodType, z } from 'zod';
import {
PackageManager,
@@ -12,28 +8,6 @@ import {
resolvePackageExec,
} from './packageManager';
/** Read one tool's prepared metadata; its consumer defines the schema and compatibility checks. */
export async function readPreparedSimulatorToolAsync<T>(
tool: string,
schema: ZodType<T>
): Promise<T | undefined> {
const manifestPath = path.join(
os.homedir(),
'Library',
'Caches',
'expo-simulator-startup',
'prepared.json'
);
try {
const manifest = z
.object({ tools: z.record(z.string(), z.unknown()) })
.parse(JSON.parse(await fs.readFile(manifestPath, 'utf8')));
return Object.hasOwn(manifest.tools, tool) ? schema.parse(manifest.tools[tool]) : undefined;
} catch {
return undefined;
}
}
/**
* Runs a Simulator launcher command with the version that `start` recorded, which warmup cached.
* The output can contain credentials, so it is returned and never logged.
@@ -42,29 +16,10 @@ export async function runSimulatorLauncherAsync(
launcherArgs: string[],
{ env, signal }: { env: BuildStepEnv; signal?: AbortSignal }
): Promise<string> {
signal?.throwIfAborted();
const contents = await fs
const version = await fs
.readFile('/tmp/expo-simulator-startup.json', 'utf8')
.catch(async error => {
if (
error.code === 'ENOENT' &&
launcherArgs[0] === 'claim' &&
env.EAS_USE_WARM_SIMULATOR === '1' &&
process.platform === 'darwin' &&
os.uptime() < 300 &&
(await fs.access('/usr/local/share/vm-tools/startup.sh').then(
() => true,
() => false
))
) {
return await waitForLauncherStateFileAsync(signal);
}
return undefined;
});
let version: unknown;
try {
version = JSON.parse(contents ?? '{}').launcherVersion;
} catch {}
.then(text => JSON.parse(text).launcherVersion)
.catch(() => undefined);
const { command, args } = resolvePackageExec(
resolveConfiguredPackageManager(env, PackageManager.BUN),
[
@@ -76,27 +31,6 @@ export async function runSimulatorLauncherAsync(
return stdout;
}
/** A session request can arrive before startup writes launcher state. */
async function waitForLauncherStateFileAsync(signal?: AbortSignal): Promise<string> {
const deadline = Date.now() + 60_000;
for (;;) {
signal?.throwIfAborted();
try {
return await fs.readFile('/tmp/expo-simulator-startup.json', 'utf8');
} catch (error) {
if ((error as NodeJS.ErrnoException).code !== 'ENOENT') {
throw error;
}
}
const remaining = deadline - Date.now();
if (remaining <= 0) {
// The claim caller must still stop warmup before it can start cold.
throw new Error('Timed out waiting for the warm Simulator launcher to start.');
}
await sleepAsync(Math.min(250, remaining), undefined, { signal });
}
}
/** Stops warmup; resolves only after the launcher confirms cleanup. */
export async function stopWarmSimulatorAsync(env: BuildStepEnv): Promise<void> {
if (process.platform === 'darwin') {
@@ -1,25 +1,5 @@
# create-eas-build-function
## 27.7.2
No changes in this release.
## 27.7.1
No changes in this release.
## 27.7.0
No changes in this release.
## 27.6.0
No changes in this release.
## 27.5.0
No changes in this release.
## 27.4.1
No changes in this release.
@@ -1,6 +1,6 @@
{
"name": "create-eas-build-function",
"version": "27.7.2",
"version": "27.4.1",
"description": "Create functions for use in EAS Build custom builds.",
"keywords": [
"expo",
@@ -35,7 +35,7 @@
"clean": "rimraf ./build/ \"*.tsbuildinfo\""
},
"dependencies": {
"@expo/steps": "27.7.2"
"@expo/steps": "27.4.1"
},
"devDependencies": {
"@expo/package-manager": "1.9.10",
-20
View File
@@ -1,25 +1,5 @@
# @expo/downloader
## 27.7.2
No changes in this release.
## 27.7.1
No changes in this release.
## 27.7.0
No changes in this release.
## 27.6.0
No changes in this release.
## 27.5.0
No changes in this release.
## 27.4.1
No changes in this release.
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/downloader",
"version": "27.7.2",
"version": "27.4.1",
"bugs": "https://github.com/expo/eas-cli/issues",
"license": "BUSL-1.1",
"author": "Expo <[email protected]>",
@@ -1,25 +1,5 @@
# eas-build-cache-provider
## 27.7.2
No changes in this release.
## 27.7.1
No changes in this release.
## 27.7.0
No changes in this release.
## 27.6.0
No changes in this release.
## 27.5.0
No changes in this release.
## 27.4.1
No changes in this release.
@@ -1,6 +1,6 @@
{
"name": "eas-build-cache-provider",
"version": "27.7.2",
"version": "27.4.1",
"description": "A build cache provider plugin for the Expo CLI",
"homepage": "https://github.com/expo/eas-cli",
"bugs": "https://github.com/expo/eas-cli/issues",
-22
View File
@@ -1,27 +1,5 @@
# @expo/eas-build-job
## 27.7.2
No changes in this release.
## 27.7.1
### Patch Changes
- Update `node-forge`, `tar`, `nanoid`, `minimatch`, `joi`, `ajv`, `yaml`, and `zod` to versions with fixes for published security advisories. ([#4847](https://github.com/expo/eas-cli/pull/4847) by [@tchayen](https://github.com/tchayen))
## 27.7.0
No changes in this release.
## 27.6.0
No changes in this release.
## 27.5.0
No changes in this release.
## 27.4.1
No changes in this release.
+5 -5
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/eas-build-job",
"version": "27.7.2",
"version": "27.4.1",
"bugs": "https://github.com/expo/eas-cli/issues",
"license": "MIT",
"author": "Expo <[email protected]>",
@@ -25,12 +25,12 @@
"clean": "rimraf node_modules dist coverage \"*.tsbuildinfo\""
},
"dependencies": {
"@expo/logger": "27.7.2",
"@expo/logger": "27.4.1",
"@expo/results": "1.0.0",
"@expo/turtle-spawn": "27.7.2",
"joi": "^17.13.9",
"@expo/turtle-spawn": "27.4.1",
"joi": "^17.13.1",
"semver": "^7.6.2",
"zod": "^4.6.7"
"zod": "^4.3.5"
},
"devDependencies": {
"@types/jest": "^29.5.12",
-49
View File
@@ -1,54 +1,5 @@
# eas-cli
## 27.7.2
### Patch Changes
- Add `--log-source` to `eas simulator` to select which Android logs a session records. ([#4823](https://github.com/expo/eas-cli/pull/4823) by [@vonovak](https://github.com/vonovak))
- Show that the ssh session has ended, instead of saying SSH was not enabled, when `eas workflow:ssh` is given the ID of a finished build. ([#4842](https://github.com/expo/eas-cli/pull/4842) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
- Show the ID argument and examples in `eas workflow:ssh --help`. ([#4829](https://github.com/expo/eas-cli/pull/4829) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
## 27.7.1
### Patch Changes
- Update `node-forge`, `tar`, `nanoid`, `minimatch`, `joi`, `ajv`, `yaml`, and `zod` to versions with fixes for published security advisories. ([#4847](https://github.com/expo/eas-cli/pull/4847) by [@tchayen](https://github.com/tchayen))
## 27.7.0
### Minor Changes
- Add `--git-branch` and `--git-commit-hash` to `eas workflow:run` to record the branch and commit of the uploaded project. ([#4815](https://github.com/expo/eas-cli/pull/4815) by [@hSATAC](https://github.com/hSATAC))
### Patch Changes
- Stop spinners from flickering when their text wraps onto a second line, such as the `simulator:start` queue message in a narrow terminal. ([#4850](https://github.com/expo/eas-cli/pull/4850) by [@brentvatne](https://github.com/brentvatne))
## 27.6.0
### Minor Changes
- Add the `--property key=value` flag to `eas observe:events` to filter events by a property value. ([#4812](https://github.com/expo/eas-cli/pull/4812) by [@Ubax](https://github.com/Ubax))
### Patch Changes
- Stop suggesting other event names in `eas observe:events` when an event name with `--session-id`, `--app-version`, `--build-number`, or `--update-id` returns no events. ([#4813](https://github.com/expo/eas-cli/pull/4813) by [@Ubax](https://github.com/Ubax))
## 27.5.0
### Minor Changes
- Import ordered action configurations with `eas simulator:control --import` and show progress for each action. ([#4686](https://github.com/expo/eas-cli/pull/4686) by [@gwdp](https://github.com/gwdp))
- Reuse simulator control connections with `--keep-alive` or `simulator:control:connection open`. Set an idle timeout, inspect the connection, or close it without stopping the simulator session. Keep-alive currently supports macOS and Linux. ([#4791](https://github.com/expo/eas-cli/pull/4791) by [@gwdp](https://github.com/gwdp))
- Start simulator sessions from saved settings and apply control actions after readiness. ([#4687](https://github.com/expo/eas-cli/pull/4687) by [@gwdp](https://github.com/gwdp))
- Run `eas simulator` commands also as `eas simulators`, `eas emulator` and `eas emulators`, for example `eas emulators:start` or `eas simulators:list`. These aliases are hidden from help. ([#4794](https://github.com/expo/eas-cli/pull/4794) by [@szdziedzic](https://github.com/szdziedzic))
- List `eas workflow:ssh` in `eas --help`. ([#4793](https://github.com/expo/eas-cli/pull/4793) by [@AHGIJMKLKKZNPJKQR](https://github.com/AHGIJMKLKKZNPJKQR))
### Patch Changes
- Find the personal account by its owner instead of assuming that its name equals the username. ([#3922](https://github.com/expo/eas-cli/pull/3922) by [@byronkarlen](https://github.com/byronkarlen))
- Show the Expo Simulators hint after a successful build from November 12 instead of November 10. ([#4817](https://github.com/expo/eas-cli/pull/4817) by [@williamgrosset](https://github.com/williamgrosset))
## 27.4.1
No changes in this release.
+234 -424
View File
File diff suppressed because it is too large. Load diff
+19 -250
View File
@@ -1907,18 +1907,6 @@
"name": "environmentSecrets",
"description": "Environment secrets for an account",
"args": [
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "filterNames",
"description": null,
@@ -1963,20 +1951,7 @@
{
"name": "environmentVariableEnvironments",
"description": null,
"args": [
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
}
],
"args": [],
"type": {
"kind": "NON_NULL",
"name": null,
@@ -2029,18 +2004,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "filterNames",
"description": null,
@@ -2098,18 +2061,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "filterNames",
"description": null,
@@ -4925,7 +4876,7 @@
},
{
"name": "setEnvironmentVariableProtectionEnabled",
"description": "Set whether environment variable protection is on for this account. When it is on, reading,\nusing, creating, changing, or deleting an environment variable whose environments are\nexclusively production needs the PUBLISH_PROTECTED permission on the account, whatever its\nvisibility, in every project of the account. Requires the ADMIN permission on the account.",
"description": "Set whether environment variable protection is on for this account. When it is on, reading,\nusing, creating, changing, or deleting an environment variable whose environments are\nexclusively production needs the PUBLISH_PROTECTED permission on the account, whatever its\nvisibility, in every project of the account. Requires the ADMIN permission on the account.\nTurning protection off also requires a sudo session.",
"args": [
{
"name": "accountID",
@@ -11689,18 +11640,6 @@
"name": "environmentSecrets",
"description": "Environment secrets for an app",
"args": [
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "filterNames",
"description": null,
@@ -11745,20 +11684,7 @@
{
"name": "environmentVariableEnvironments",
"description": null,
"args": [
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
}
],
"args": [],
"type": {
"kind": "NON_NULL",
"name": null,
@@ -11795,18 +11721,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "filterNames",
"description": null,
@@ -11864,18 +11778,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "excludeProductionOnly",
"description": "Leave out variables whose only environment is production. In an account with environment\nvariable protection, a member without the Release Manager role may not read them, and the\nrequest fails unless it leaves them out.",
"type": {
"kind": "SCALAR",
"name": "Boolean",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "filterNames",
"description": null,
@@ -20732,7 +20634,7 @@
"fields": [
{
"name": "affectedSessions",
"description": "Distinct sessions on this platform that hit any exception, including installations outside the sampleRate sample.",
"description": "Distinct sessions on this platform that hit any exception.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20748,7 +20650,7 @@
},
{
"name": "affectedUsers",
"description": "Distinct users on this platform that hit any exception, including installations outside the sampleRate sample.",
"description": "Distinct users on this platform that hit any exception.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20764,7 +20666,7 @@
},
{
"name": "crashFreeSessions",
"description": "Fraction (0..1) of this platform's active sessions without a fatal error. Counts only installations in the sampleRate sample.",
"description": "Fraction (0..1) of this platform's active sessions without a fatal error.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20780,7 +20682,7 @@
},
{
"name": "crashFreeUsers",
"description": "Fraction (0..1) of this platform's active users without a fatal error. Counts only installations in the sampleRate sample.",
"description": "Fraction (0..1) of this platform's active users without a fatal error.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20894,7 +20796,7 @@
"fields": [
{
"name": "affectedSessions",
"description": "Distinct sessions that hit any exception, including installations outside the sampleRate sample.",
"description": "Distinct sessions that hit any exception.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20910,7 +20812,7 @@
},
{
"name": "affectedUsers",
"description": "Distinct users that hit any exception, including installations outside the sampleRate sample that send errors because of errorSampleRate.",
"description": "Distinct users that hit any exception.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20926,7 +20828,7 @@
},
{
"name": "crashFreeSessions",
"description": "Fraction (0..1) of active sessions without a fatal error. Counts only installations in the sampleRate sample. Denominator spans app_metrics and app_events.",
"description": "Fraction (0..1) of active sessions without a fatal error. Denominator spans app_metrics and app_events.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -20942,7 +20844,7 @@
},
{
"name": "crashFreeUsers",
"description": "Fraction (0..1) of active users without a fatal error. Counts only installations in the sampleRate sample.",
"description": "Fraction (0..1) of active users without a fatal error.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -26325,7 +26227,7 @@
},
{
"name": "crashFreeSessions",
"description": "Fraction (0..1) of active sessions without a fatal error. Counts only installations in the sampleRate sample.",
"description": "Fraction (0..1) of active sessions without a fatal error.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -26341,7 +26243,7 @@
},
{
"name": "crashFreeUsers",
"description": "Fraction (0..1) of active users without a fatal error. Counts only installations in the sampleRate sample.",
"description": "Fraction (0..1) of active users without a fatal error.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -26357,7 +26259,7 @@
},
{
"name": "crashedUsers",
"description": "Distinct users that hit a fatal error in range, including installations outside the sampleRate sample.",
"description": "Distinct users that hit a fatal error in range.",
"args": [],
"type": {
"kind": "NON_NULL",
@@ -28028,26 +27930,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "scopes",
"description": null,
"type": {
"kind": "LIST",
"name": null,
"ofType": {
"kind": "NON_NULL",
"name": null,
"ofType": {
"kind": "SCALAR",
"name": "String",
"ofType": null
}
}
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "statusCodes",
"description": null,
@@ -28498,22 +28380,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "scopeName",
"description": "The instrumentation scope that produced the span (OTLP scopeSpans.scope.name), such as\nexpo-observe.network. Empty when the span was sent without a scope or stored before scopes were kept.",
"args": [],
"type": {
"kind": "NON_NULL",
"name": null,
"ofType": {
"kind": "SCALAR",
"name": "String",
"ofType": null
}
},
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "sessionId",
"description": null,
@@ -29208,26 +29074,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "scopes",
"description": "Spans produced by any of these instrumentation scopes, such as expo-observe.network.",
"type": {
"kind": "LIST",
"name": null,
"ofType": {
"kind": "NON_NULL",
"name": null,
"ofType": {
"kind": "SCALAR",
"name": "String",
"ofType": null
}
}
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "sessionId",
"description": null,
@@ -47524,7 +47370,7 @@
"inputFields": [
{
"name": "deviceIdentifier",
"description": "AVD hardware profile id to use for the emulator (e.g. \"pixel_9\"). Defaults to \"medium_phone\".",
"description": "AVD hardware profile id to use for the emulator (e.g. \"pixel_9\").",
"type": {
"kind": "SCALAR",
"name": "String",
@@ -48965,7 +48811,7 @@
"inputFields": [
{
"name": "deviceIdentifier",
"description": "Simulator device name or UDID to use for the session (e.g. \"iPhone 16 Pro\"). Defaults to\n\"iPhone 17\".",
"description": "Simulator device name or UDID to use for the session (e.g. \"iPhone 16 Pro\").",
"type": {
"kind": "SCALAR",
"name": "String",
@@ -52471,18 +52317,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "deviceIdentifier",
"description": "The simulator or emulator the session starts: the requested simulator device\nname or UDID on iOS, or the AVD hardware profile id on Android, or the platform\ndefault when none is requested. Null on sessions created before it was saved.",
"args": [],
"type": {
"kind": "SCALAR",
"name": "String",
"ofType": null
},
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "finishedAt",
"description": null,
@@ -60932,13 +60766,9 @@
"description": null,
"args": [],
"type": {
"kind": "NON_NULL",
"name": null,
"ofType": {
"kind": "SCALAR",
"name": "String",
"ofType": null
}
"kind": "SCALAR",
"name": "String",
"ofType": null
},
"isDeprecated": false,
"deprecationReason": null
@@ -102981,67 +102811,12 @@
"enumValues": null,
"possibleTypes": null
},
{
"kind": "INPUT_OBJECT",
"name": "WorkflowRunGitInput",
"description": "Git metadata for a run started from an uploaded project. The commit must exist in the\nproject's linked GitHub repository. The run records the branch and commit but is not\nlinked to the repository.",
"fields": null,
"inputFields": [
{
"name": "branch",
"description": "Branch name such as \"main\". Stored as refs/heads/<branch>. Fully qualified refs are rejected.",
"type": {
"kind": "NON_NULL",
"name": null,
"ofType": {
"kind": "SCALAR",
"name": "String",
"ofType": null
}
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "commitHash",
"description": "Full commit SHA. The commit message is read from GitHub.",
"type": {
"kind": "NON_NULL",
"name": null,
"ofType": {
"kind": "SCALAR",
"name": "String",
"ofType": null
}
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
}
],
"interfaces": null,
"enumValues": null,
"possibleTypes": null
},
{
"kind": "INPUT_OBJECT",
"name": "WorkflowRunInput",
"description": null,
"fields": null,
"inputFields": [
{
"name": "git",
"description": null,
"type": {
"kind": "INPUT_OBJECT",
"name": "WorkflowRunGitInput",
"ofType": null
},
"defaultValue": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "inputs",
"description": null,
@@ -103691,12 +103466,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "OBSERVE_NEW_ERROR",
"description": null,
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "REPACK_EXPO_GO",
"description": null,
+13 -15
View File
@@ -1,6 +1,6 @@
{
"name": "eas-cli",
"version": "27.7.2",
"version": "27.4.1",
"description": "EAS command line tool",
"keywords": [
"cli",
@@ -48,12 +48,12 @@
"@expo/code-signing-certificates": "0.0.5",
"@expo/config": "55.0.10",
"@expo/config-plugins": "55.0.7",
"@expo/eas-build-job": "27.7.2",
"@expo/eas-json": "27.7.2",
"@expo/eas-build-job": "27.4.1",
"@expo/eas-json": "27.4.1",
"@expo/env": "^1.0.0",
"@expo/experimentation": "0.0.5",
"@expo/json-file": "8.3.3",
"@expo/logger": "27.7.2",
"@expo/logger": "27.4.1",
"@expo/multipart-body-parser": "2.0.0",
"@expo/osascript": "2.1.4",
"@expo/package-manager": "1.9.10",
@@ -65,7 +65,7 @@
"@expo/results": "1.0.0",
"@expo/rudder-sdk-node": "1.1.1",
"@expo/spawn-async": "1.7.2",
"@expo/steps": "27.7.2",
"@expo/steps": "27.4.1",
"@expo/timeago.js": "1.0.0",
"@oclif/core": "^4.8.3",
"@oclif/plugin-autocomplete": "^3.2.40",
@@ -74,7 +74,7 @@
"@urql/core": "4.0.11",
"@urql/exchange-retry": "1.2.0",
"agent-cli-detector": "0.1.7",
"ajv": "8.20.0",
"ajv": "8.11.0",
"ajv-formats": "2.1.1",
"better-opn": "3.0.2",
"bplist-parser": "^0.3.0",
@@ -101,15 +101,15 @@
"indent-string": "4.0.0",
"invariant": "^2.2.2",
"jks-js": "1.1.0",
"joi": "17.13.9",
"joi": "17.11.0",
"keychain": "1.5.0",
"log-symbols": "4.1.0",
"mime": "3.0.0",
"minimatch": "5.1.9",
"minimatch": "5.1.2",
"minizlib": "3.1.0",
"nanoid": "3.3.20",
"nanoid": "3.3.8",
"node-fetch": "2.6.7",
"node-forge": "1.4.3",
"node-forge": "1.4.0",
"node-stream-zip": "1.15.0",
"nullthrows": "1.1.1",
"open": "8.4.0",
@@ -119,14 +119,13 @@
"promise-limit": "2.7.0",
"promise-retry": "2.0.1",
"prompts": "2.4.2",
"proper-lockfile": "4.1.2",
"qrcode-terminal": "0.12.0",
"resolve-from": "5.0.0",
"sandbox-cli-detector": "0.2.0",
"semver": "7.5.4",
"set-interval-async": "3.0.3",
"slash": "3.0.0",
"tar": "7.5.22",
"tar": "7.5.19",
"tar-stream": "3.1.7",
"terminal-link": "2.1.1",
"ts-deepmerge": "6.2.0",
@@ -136,8 +135,8 @@
"uuid": "11.1.1",
"wrap-ansi": "7.0.0",
"ws": "8.21.1",
"yaml": "2.9.1",
"zod": "^4.6.7"
"yaml": "2.6.0",
"zod": "^4.1.3"
},
"devDependencies": {
"@graphql-codegen/cli": "6.3.1",
@@ -160,7 +159,6 @@
"@types/pngjs": "6.0.4",
"@types/promise-retry": "1.1.3",
"@types/prompts": "2.4.2",
"@types/proper-lockfile": "4.1.4",
"@types/semver": "7.5.6",
"@types/tar": "6.1.10",
"@types/tar-stream": "3.1.3",
@@ -6,20 +6,18 @@ const { createRequire } = require('node:module');
const root = fs.realpathSync(process.argv[2]);
const cli = path.join(root, 'packages/eas-cli');
const cliRequire = createRequire(path.join(cli, 'package.json'));
const { oclif } = cliRequire('./package.json');
cliRequire('ts-node').register({ project: path.join(cli, 'tsconfig.json'), transpileOnly: true });
const { Config, run } = cliRequire('@oclif/core');
const { Config } = cliRequire('@oclif/core');
const EasCommand = require(path.join(cli, 'src/commandUtils/EasCommand')).default;
const Control = require(path.join(cli, 'src/commands/simulator/control')).default;
const EasHelp = require(path.join(cli, 'src/help')).default;
const cases = JSON.parse(process.argv[3]);
const directory = fs.mkdtempSync(path.join(os.tmpdir(), 'eas-help-lifecycle-'));
const events = [];
let commandArgs;
globalThis.__helpLifecycleEvents = events;
// Replace command work (auth/device I/O), keeping discovery, parsing and hooks real.
EasCommand.prototype.run = async function () {
commandArgs = this.argv;
events.push({ event: 'run', id: this.id });
};
EasCommand.prototype.finally = async function () {};
@@ -33,26 +31,14 @@ EasCommand.prototype.finally = async function () {};
version: '1.0.0',
oclif: {
bin: 'eas',
additionalHelpFlags: ['-h'],
helpClass: oclif.helpClass,
commands: './commands',
commands: { strategy: 'explicit', target: './commands.cjs' },
hooks: { prerun: './prerun.cjs', postrun: './postrun.cjs' },
},
})
);
for (const command of ['simulator/control', 'simulator/index', 'account/login']) {
const file = path.join(directory, 'commands', `${command}.js`);
fs.mkdirSync(path.dirname(file), { recursive: true });
fs.writeFileSync(
file,
`exports.default = require(${JSON.stringify(path.join(cli, 'src/commands', command))}).default;`
);
}
const helpFile = path.join(directory, `${oclif.helpClass}.js`);
fs.mkdirSync(path.dirname(helpFile), { recursive: true });
fs.writeFileSync(
helpFile,
`exports.default = require(${JSON.stringify(path.join(cli, 'src/help'))}).default;`
path.join(directory, 'commands.cjs'),
`exports.default = { 'simulator:control': require(${JSON.stringify(path.join(cli, 'src/commands/simulator/control'))}).default };`
);
for (const event of ['prerun', 'postrun']) {
fs.writeFileSync(
@@ -62,24 +48,13 @@ EasCommand.prototype.finally = async function () {};
}
process.env.XDG_DATA_HOME = directory;
process.env.XDG_CACHE_HOME = directory;
let config = await Config.load({ root: directory });
if (process.argv[4] === 'manifest') {
if (!config.rootPlugin.manifest.commands['simulator:control'].relativePath) {
throw new Error('The manifest must exercise cached command module paths');
}
fs.writeFileSync(
path.join(directory, 'oclif.manifest.json'),
JSON.stringify(config.rootPlugin.manifest)
);
config = await Config.load({ root: directory });
}
const config = await Config.load({ root: directory });
const results = [];
for (const args of cases) {
// Published manifests discover metadata without loading the command class.
// Clear eager discovery's assignment to exercise that cold-start boundary.
delete Control.id;
const start = events.length;
commandArgs = undefined;
const write = process.stdout.write;
let stdout = '',
error;
@@ -90,13 +65,13 @@ EasCommand.prototype.finally = async function () {};
return true;
};
try {
await run(args, config);
await new EasHelp(config).showHelp(args);
} catch (err) {
error = err.message;
} finally {
process.stdout.write = write;
}
results.push({ stdout, events: events.slice(start), error, commandArgs });
results.push({ stdout, events: events.slice(start), error });
}
console.log('LIFECYCLE_RESULT ' + JSON.stringify(results));
} finally {
@@ -5,99 +5,47 @@ import { promisify } from 'node:util';
const execFileAsync = promisify(execFile);
const root = path.resolve(__dirname, '../../../..');
const fixture = path.join(__dirname, 'fixtures/simulator-control-lifecycle.cjs');
const modes = ['discovery', 'manifest'];
const actionHelp = [
['simulator:control', 'rotate', '--help'],
['sim:control', 'screenshot.capture', '-h', '--id', 'session-123'],
['simulator:control', '--id', 'session-123', '--help', 'rotate'],
['simulators:control', 'rotate', '--help'],
['emulator:control', 'rotate', '-h'],
['emulators:control', 'rotate', '--help'],
];
const configHelp = [
const incompleteFlags = [
['simulator:control', 'screenshot.capture', '--help', '--output'],
['sim:control', 'rotate', '-h', '--id'],
['simulator:start', '--help'],
['simulator', '--help'],
['sim:start', '-h'],
['sim', '-h'],
['simulators:start', '--help'],
['emulator:start', '-h'],
['emulators:start', '--help'],
['simulators', '--help'],
['emulator', '-h'],
['emulators', '--help'],
['simulators:control', '--help'],
['emulator:control', '-h'],
['emulators:control', '--help'],
['simulator:control', '--help'],
['sim:control', '-h'],
['--help', 'simulator:start'],
['--help', 'help', 'simulator:start'],
['simulator:start', '--import', 'does-not-exist.json', '--help'],
['simulator:control', '--import', 'does-not-exist.json', '--help'],
];
const ordinaryHelp = [['account:login', '--help'], ['--help']];
const literalHelp = ['simulator:control', 'clipboard.write', '--', '--help'];
let results: {
stdout: string;
events: unknown[];
error?: string;
commandArgs?: string[];
}[][];
let results: { stdout: string; events: unknown[]; error?: string }[];
beforeAll(async () => {
results = await Promise.all(
modes.map(async mode => {
const { stdout } = await execFileAsync(
process.execPath,
[
fixture,
root,
JSON.stringify([...actionHelp, ...configHelp, ...ordinaryHelp, literalHelp]),
mode,
],
{ timeout: 20_000 }
);
return JSON.parse(stdout.split('LIFECYCLE_RESULT ').at(-1)!);
})
// Load TypeScript once, outside per-case timeouts, including on coverage runners.
const { stdout } = await execFileAsync(
process.execPath,
[fixture, root, JSON.stringify([...actionHelp, ...incompleteFlags])],
{ timeout: 20_000 }
);
results = JSON.parse(stdout.split('LIFECYCLE_RESULT ').at(-1)!);
}, 30_000);
describe.each(modes.map((mode, index) => ({ mode, index })))(
'simulator help through real oclif routing ($mode)',
({ index: mode }) => {
it.each(actionHelp.map((argv, index) => ({ argv, index })))(
'keeps command identity and lifecycle hooks for action help: $argv',
({ index }) => {
expect(results[mode][index].error).toBeUndefined();
expect(results[mode][index].events).toEqual([
{ event: 'prerun', id: 'simulator:control' },
{ event: 'run', id: 'simulator:control' },
{ event: 'postrun', id: 'simulator:control' },
]);
}
);
it.each([...configHelp, ...ordinaryHelp].map((argv, index) => ({ argv, index })))(
'prints help without executing a command: $argv',
({ index }) => {
const { stdout, events, error } = results[mode][index + actionHelp.length];
expect(error).toBeUndefined();
expect(stdout).toContain('USAGE');
expect(events).toEqual([]);
}
);
it('keeps --help after -- as a literal action value', () => {
const result = results[mode].at(-1)!;
expect(result.error).toBeUndefined();
expect(result.commandArgs).toEqual(['clipboard.write', '--', '--help']);
expect(result.events).toEqual([
describe('simulator action help through real oclif lookup and hooks', () => {
it.each(actionHelp.map((argv, index) => ({ argv, index })))(
'keeps canonical command identity and executes lifecycle hooks: $argv',
({ index }) => {
expect(results[index].error).toBeUndefined();
expect(results[index].events).toEqual([
{ event: 'prerun', id: 'simulator:control' },
{ event: 'run', id: 'simulator:control' },
{ event: 'postrun', id: 'simulator:control' },
]);
});
}
);
}
);
it.each(incompleteFlags.map((argv, index) => ({ argv, index })))(
'shows ordinary help without starting the command for an incomplete flag: $argv',
({ index }) => {
const { stdout, events, error } = results[index + actionHelp.length];
expect(error).toBeUndefined();
expect(stdout).toContain('USAGE');
expect(events).toEqual([]);
}
);
});
Loaded 100 of 208 files, more files were not shown because too many files have changed in this diff. Show more