[eas-cli] create debug fingerprints

* Parse error only when needed

* Add changelog

* Fix linting

CHANGELOG.md

@@ -8,6 +8,21 @@ This is the log of notable changes to EAS CLI and related packages.
 
 ### 🎉 New features
 
+### 🐛 Bug fixes
+
+- Show `eas deploy` upload error messages. ([#2771](https://github.com/expo/eas-cli/pull/2771) by [@kadikraman](https://github.com/kadikraman))
+- Prevent EAS CLI dependencies check from running repeatedly. ([#2781](https://github.com/expo/eas-cli/pull/2781) by [@kitten](https://github.com/kitten))
+- Prevent optimistic request body parsing for `eas deploy`. ([#2784](https://github.com/expo/eas-cli/pull/2784) by [@kadikraman](https://github.com/kadikraman))
+
+### 🧹 Chores
+
+- Update log output for `worker` deploy and alias commands. ([#2780](https://github.com/expo/eas-cli/pull/2780) by [@kitten](https://github.com/kitten))
+- Update various messages wording. ([#2790](https://github.com/expo/eas-cli/pull/2790) by [@simek](https://github.com/simek))
+
+## [14.2.0](https://github.com/expo/eas-cli/releases/tag/v14.2.0) - 2024-12-13
+
+### 🎉 New features
+
 - Add `eas deploy --dry-run` flag to output tarball. ([#2761](https://github.com/expo/eas-cli/pull/2761) by [@kitten](https://github.com/kitten))
 
 ### 🐛 Bug fixes

packages/eas-cli/package.json

@@ -12,7 +12,7 @@
     "@expo/code-signing-certificates": "0.0.5",
     "@expo/config": "10.0.6",
     "@expo/config-plugins": "9.0.12",
-    "@expo/eas-build-job": "1.0.154",
+    "@expo/eas-build-job": "1.0.156",
     "@expo/eas-json": "14.2.0",
     "@expo/env": "^0.4.0",
     "@expo/json-file": "8.3.3",
@@ -28,7 +28,7 @@
     "@expo/results": "1.0.0",
     "@expo/rudder-sdk-node": "1.1.1",
     "@expo/spawn-async": "1.7.2",
-    "@expo/steps": "1.0.154",
+    "@expo/steps": "1.0.156",
     "@expo/timeago.js": "1.0.0",
     "@oclif/core": "^1.26.2",
     "@oclif/plugin-autocomplete": "^2.3.10",

packages/eas-cli/src/build/build.ts

@@ -672,7 +672,9 @@ async function computeAndMaybeUploadRuntimeAndFingerprintMetadataAsync<T extends
   const runtimeAndFingerprintMetadata =
     await computeAndMaybeUploadFingerprintFromExpoUpdatesAsync(ctx);
   if (!runtimeAndFingerprintMetadata?.fingerprintHash) {
-    const fingerprint = await computeAndMaybeUploadFingerprintWithoutExpoUpdatesAsync(ctx);
+    const fingerprint = await computeAndMaybeUploadFingerprintWithoutExpoUpdatesAsync(ctx, {
+      debug: true,
+    });
     return {
       ...runtimeAndFingerprintMetadata,
       ...fingerprint,
@@ -739,6 +741,7 @@ async function computeAndMaybeUploadFingerprintWithoutExpoUpdatesAsync<T extends
     workflow: ctx.workflow,
     platforms: [ctx.platform],
     env: ctx.env,
+    debug,
   });
   if (!fingerprint) {
     return {};

packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts

@@ -103,6 +103,8 @@ export async function findProjectRootAsync({
   }
 }
 
+let ranEnsureEasCliIsNotInDependencies = false;
+
 /**
  * Determine the project root directory and ensure some constraints about the project setup
  * like CLI version and dependencies.
@@ -113,6 +115,9 @@ export async function findProjectRootAsync({
 export async function findProjectDirAndVerifyProjectSetupAsync(): Promise<string> {
   const projectDir = await findProjectRootAsync();
   await applyCliConfigAsync(projectDir);
-  await ensureEasCliIsNotInDependenciesAsync(projectDir);
+  if (!ranEnsureEasCliIsNotInDependencies) {
+    ranEnsureEasCliIsNotInDependencies = true;
+    await ensureEasCliIsNotInDependenciesAsync(projectDir);
+  }
   return projectDir;
 }

packages/eas-cli/src/commandUtils/context/contextUtils/loadServerSideEnvironmentVariablesAsync.ts

@@ -42,13 +42,13 @@ export async function loadServerSideEnvironmentVariablesAsync({
 
   if (Object.keys(serverEnvVars).length > 0) {
     Log.log(
-      `Environment variables with visibility "Plain text" and "Sensitive" loaded from the "${environment.toLowerCase()}" environment on EAS servers: ${Object.keys(
+      `Environment variables with visibility "Plain text" and "Sensitive" loaded from the "${environment.toLowerCase()}" environment on EAS: ${Object.keys(
         serverEnvVars
       ).join(', ')}.`
     );
   } else {
     Log.log(
-      `No environment variables with visibility "Plain text" and "Sensitive" found for the "${environment.toLowerCase()}" environment on EAS servers.`
+      `No environment variables with visibility "Plain text" and "Sensitive" found for the "${environment.toLowerCase()}" environment on EAS.`
     );
   }
   Log.newLine();

packages/eas-cli/src/commands/build/version/sync.ts

@@ -120,7 +120,7 @@ export default class BuildVersionSyncView extends EasCommand {
       const workflow = await resolveWorkflowAsync(projectDir, profileInfo.platform, vcsClient);
       if (!remoteVersions?.buildVersion) {
         Log.warn(
-          `Skipping versions sync for ${platformDisplayName}. There are no versions configured on Expo servers, use "eas build:version:set" or run a build to initialize it.`
+          `Skipping versions sync for ${platformDisplayName}. There are no versions configured on EAS, use "eas build:version:set" or run a build to initialize it.`
         );
         continue;
       }

packages/eas-cli/src/commands/device/delete.ts

@@ -147,10 +147,10 @@ export default class DeviceDelete extends EasCommand {
     graphqlClient: ExpoGraphqlClient,
     chosenDevice: AppleDevice | AppleDeviceQueryResult
   ): Promise<void> {
-    const removalSpinner = ora(`Removing Apple device on Expo`).start();
+    const removalSpinner = ora(`Removing Apple device on EAS`).start();
     try {
       await AppleDeviceMutation.deleteAppleDeviceAsync(graphqlClient, chosenDevice.id);
-      removalSpinner.succeed('Removed Apple device from Expo');
+      removalSpinner.succeed('Removed Apple device from EAS');
     } catch (err) {
       removalSpinner.fail();
       throw err;

packages/eas-cli/src/commands/device/rename.ts

@@ -105,12 +105,12 @@ export default class DeviceRename extends EasCommand {
     chosenDevice: AppleDevice | AppleDeviceQueryResult,
     newDeviceName: string
   ): Promise<void> {
-    const removalSpinner = ora(`Renaming Apple device on Expo`).start();
+    const removalSpinner = ora(`Renaming Apple device on EAS`).start();
     try {
       await AppleDeviceMutation.updateAppleDeviceAsync(graphqlClient, chosenDevice.id, {
         name: newDeviceName,
       });
-      removalSpinner.succeed('Renamed Apple device on Expo');
+      removalSpinner.succeed('Renamed Apple device on EAS');
     } catch (err) {
       removalSpinner.fail();
       throw err;

packages/eas-cli/src/commands/env/exec.ts

@@ -170,7 +170,7 @@ export default class EnvExec extends EasCommand {
       );
     } else {
       Log.log(
-        `No environment variables with visibility "Plain text" and "Sensitive" found for the "${environment.toLowerCase()}" environment on EAS servers.`
+        `No environment variables with visibility "Plain text" and "Sensitive" found for the "${environment.toLowerCase()}" environment on EAS.`
       );
     }
     Log.newLine();

packages/eas-cli/src/commands/fingerprint/compare.ts

@@ -83,11 +83,12 @@ export default class FingerprintCompare extends EasCommand {
     const workflows = await resolveWorkflowPerPlatformAsync(projectDir, vcsClient);
     const buildPlatform = buildWithFingerprint.platform;
     const workflow = workflows[appPlatformToPlatform(buildPlatform)];
+    const isDebug = true;
 
     const projectFingerprint = await createFingerprintAsync(projectDir, {
       workflow,
       platforms: [appPlatformToString(buildPlatform)],
-      debug: true,
+      debug: isDebug,
       env: undefined,
     });
     if (!projectFingerprint) {

packages/eas-cli/src/commands/worker/alias.ts

@@ -73,7 +73,7 @@ export default class WorkerAlias extends EasCommand {
       enableJsonOutput();
     }
 
-    Log.warn('EAS Worker Deployments are in beta and subject to breaking changes.');
+    Log.warn('EAS Hosting is still in beta and subject to changes.');
 
     const {
       getDynamicPrivateProjectConfigAsync,

packages/eas-cli/src/commands/worker/deploy.ts

@@ -114,7 +114,7 @@ export default class WorkerDeploy extends EasCommand {
       enableJsonOutput();
     }
 
-    Log.warn('EAS Worker Deployments are in beta and subject to breaking changes.');
+    Log.warn('EAS Hosting is still in beta and subject to changes.');
 
     const {
       getDynamicPrivateProjectConfigAsync,
@@ -426,7 +426,7 @@ async function resolveExportedProjectAsync(
 
   if (!exportDirStat?.isDirectory()) {
     throw new Error(
-      `No "${flags.exportDir}/" folder found. Prepare your project for deployment with "npx expo export --platform web"`
+      `No "${flags.exportDir}/" folder found. Export your app with "npx expo export --platform web"`
     );
   }
 
@@ -451,7 +451,8 @@ function logExportedProjectInfo(
   // Only show the timestamp for exports older than 1 minute
   if (project.modifiedAt && Date.now() - project.modifiedAt.getTime() > 60_000) {
     modifiedAgo = ` - exported ${formatTimeAgo(project.modifiedAt)}`;
+    Log.warn(`> Project export: ${project.type}${modifiedAgo}}`);
+  } else {
+    Log.log(chalk`{dim > Project export: ${project.type}}`);
   }
-
-  Log.log(chalk`{dim > Project export: ${project.type}${modifiedAgo}}`);
 }

packages/eas-cli/src/devices/actions/create/currentMachineMethod.ts

@@ -48,7 +48,7 @@ async function collectDataAndRegisterDeviceAsync(
   }
 
   const { udid, deviceClass, name } = deviceData;
-  const spinner = ora(`Registering Apple device on Expo`).start();
+  const spinner = ora(`Registering Apple device on EAS`).start();
   try {
     await AppleDeviceMutation.createAppleDeviceAsync(
       graphqlClient,

packages/eas-cli/src/devices/actions/create/inputMethod.ts

@@ -45,7 +45,7 @@ async function collectDataAndRegisterDeviceAsync(
 ): Promise<void> {
   const { udid, deviceClass, name } = await collectDeviceDataAsync(appleTeam);
 
-  const spinner = ora(`Registering Apple device on Expo`).start();
+  const spinner = ora(`Registering Apple device on EAS`).start();
   try {
     await AppleDeviceMutation.createAppleDeviceAsync(
       graphqlClient,

packages/eas-cli/src/project/fetchOrCreateProjectIDForWriteToConfigWithConfirmationAsync.ts

@@ -84,13 +84,13 @@ export async function fetchOrCreateProjectIDForWriteToConfigWithConfirmationAsyn
   const projectDashboardUrl = getProjectDashboardUrl(accountName, projectName);
   const projectLink = link(projectDashboardUrl, { text: projectFullName });
 
-  const spinner = ora(`Creating ${chalk.bold(projectFullName)} on Expo`).start();
+  const spinner = ora(`Creating ${chalk.bold(projectFullName)} on EAS`).start();
   try {
     const id = await AppMutation.createAppAsync(graphqlClient, {
       accountId: account.id,
       projectName,
     });
-    spinner.succeed(`Created ${chalk.bold(projectLink)} on Expo`);
+    spinner.succeed(`Created ${chalk.bold(projectLink)} on EAS`);
     return id;
   } catch (err) {
     spinner.fail();

packages/eas-cli/src/project/publish.ts

@@ -923,6 +923,7 @@ export async function maybeCalculateFingerprintForRuntimeVersionInfoObjectsWitho
         workflow: workflowsByPlatform[platform],
         projectDir,
         env,
+        debug: true,
       };
       fingerprintOptionsByRuntimeAndPlatform.set(runtimeAndPlatform, options);
     }

packages/eas-cli/src/utils/statuspageService.ts

@@ -42,13 +42,13 @@ function warnAboutServiceOutage(service: StatuspageServiceFragment): void {
 
   if (service.incidents.length > 0) {
     const [currentIncident] = service.incidents;
-    Log.warn(`Reason: ${currentIncident.name}`);
+    Log.warn(`Reason: ${currentIncident.name}.`);
   }
 
   Log.warn(
     `All information on service status and incidents available at ${link(
       'https://status.expo.dev/'
-    )}.`
+    )}`
   );
   Log.newLine();
 }

packages/eas-cli/src/worker/upload.ts

@@ -109,20 +109,23 @@ export async function uploadAsync(params: UploadParams): Promise<UploadResult> {
         return retry(error);
       }
 
+      const getErrorMessageAsync = async (): Promise<string> => {
+        const body = await response.json().catch(() => null);
+        return body?.error ?? `Upload of "${filePath}" failed: ${response.statusText}`;
+      };
+
       if (
         response.status === 408 ||
         response.status === 409 ||
         response.status === 429 ||
         (response.status >= 500 && response.status <= 599)
       ) {
-        const message = `Upload of "${filePath}" failed: ${response.statusText}`;
-        const text = await response.text().catch(() => null);
-        return retry(new Error(text ? `${message}\n${text}` : message));
+        return retry(new Error(await getErrorMessageAsync()));
       } else if (response.status === 413) {
         const message = `Upload of "${filePath}" failed: File size exceeded the upload limit`;
         throw new Error(message);
       } else if (!response.ok) {
-        throw new Error(`Upload of "${filePath}" failed: ${response.statusText}`);
+        throw new Error(await getErrorMessageAsync());
       }
 
       return {

packages/eas-json/package.json

@@ -6,7 +6,7 @@
   "bugs": "https://github.com/expo/eas-cli/issues",
   "dependencies": {
     "@babel/code-frame": "7.23.5",
-    "@expo/eas-build-job": "1.0.154",
+    "@expo/eas-build-job": "1.0.156",
     "chalk": "4.1.2",
     "env-string": "1.0.1",
     "fs-extra": "11.2.0",

yarn.lock

@@ -1465,10 +1465,10 @@
     slugify "^1.3.4"
     sucrase "3.35.0"
 
-"@expo/[email protected]4":
-  version "1.0.154"
-  resolved "https://registry.yarnpkg.com/@expo/eas-build-job/-/eas-build-job-1.0.154.tgz#366511196e983bdb4d4687266373a5822a74af82"
-  integrity sha512-h5VQYX++KZqU2d6PB1xskgB3DXZRpuLNHjciW6RQ67sRzMgsSxMbFAosiW03LV/rYi8yZdR8NHFbsIf1Qk6ZIg==
+"@expo/[email protected]6":
+  version "1.0.156"
+  resolved "https://registry.yarnpkg.com/@expo/eas-build-job/-/eas-build-job-1.0.156.tgz#c8e1f34a480eba217e6aa37e5d178f440065a7e7"
+  integrity sha512-pD3vWO7fIaQ4wmJy/x6L2dVK2rwf1qNzTE/4I5JI4r6vYSKrSCv8EIoE87xDBaRUBMk72ZdzyznJe516pMyTaw==
   dependencies:
     "@expo/logger" "1.0.117"
     joi "^17.13.1"
@@ -1645,12 +1645,12 @@
   dependencies:
     cross-spawn "^7.0.3"
 
-"@expo/[email protected]4":
-  version "1.0.154"
-  resolved "https://registry.yarnpkg.com/@expo/steps/-/steps-1.0.154.tgz#631148dd1fa58a30a70f92be50abdc4e42672ab0"
-  integrity sha512-PoFT1IDYptmfw3zGwblHOqfU4zFx8ckHALm7OalqceITqn0MTAk85/y5SUuh/AQCHbo/ULTJTnrnBocmDzpkQA==
+"@expo/[email protected]6":
+  version "1.0.156"
+  resolved "https://registry.yarnpkg.com/@expo/steps/-/steps-1.0.156.tgz#79a043a7dd4f5c098c954ed7a013c407631f515a"
+  integrity sha512-fa2rMaWqF0DaqqyDXy2Dy5pBbXTPfnMD1ALQid3ApjokMV5Gq+CTyr7sYFGqr1vywK0sftpmKVAOMJzHV95dDg==
   dependencies:
-    "@expo/eas-build-job" "1.0.154"
+    "@expo/eas-build-job" "1.0.156"
     "@expo/logger" "1.0.117"
     "@expo/spawn-async" "^1.7.2"
     arg "^5.0.2"
@@ -13228,7 +13228,16 @@ string-length@^5.0.1:
     char-regex "^2.0.0"
     strip-ansi "^7.0.1"
 
-"string-width-cjs@npm:string-width@^4.2.0", "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.2.3:
+"string-width-cjs@npm:string-width@^4.2.0":
+  version "4.2.3"
+  resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
+  integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
+  dependencies:
+    emoji-regex "^8.0.0"
+    is-fullwidth-code-point "^3.0.0"
+    strip-ansi "^6.0.1"
+
+"string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.2.3:
   version "4.2.3"
   resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
   integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
@@ -13384,7 +13393,7 @@ string_decoder@~1.1.1:
   dependencies:
     safe-buffer "~5.1.0"
 
-"strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@^6.0.1:
+"strip-ansi-cjs@npm:strip-ansi@^6.0.1":
   version "6.0.1"
   resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
   integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
@@ -13405,6 +13414,13 @@ strip-ansi@^6.0.0:
   dependencies:
     ansi-regex "^5.0.0"
 
+strip-ansi@^6.0.1:
+  version "6.0.1"
+  resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
+  integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
+  dependencies:
+    ansi-regex "^5.0.1"
+
 strip-ansi@^7.0.1:
   version "7.0.1"
   resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-7.0.1.tgz#61740a08ce36b61e50e65653f07060d000975fb2"
@@ -14611,7 +14627,16 @@ wordwrap@^1.0.0:
   resolved "https://registry.yarnpkg.com/wordwrap/-/wordwrap-1.0.0.tgz#27584810891456a4171c8d0226441ade90cbcaeb"
   integrity sha1-J1hIEIkUVqQXHI0CJkQa3pDLyus=
 
-"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", [email protected], wrap-ansi@^7.0.0:
+"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0":
+  version "7.0.0"
+  resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
+  integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==
+  dependencies:
+    ansi-styles "^4.0.0"
+    string-width "^4.1.0"
+    strip-ansi "^6.0.0"
+
+[email protected], wrap-ansi@^7.0.0:
   version "7.0.0"
   resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
   integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==