Compare commits

..
5 Commits
Author SHA1 Message Date
Quinlan Jung d8d7ac68da [eas-cli] amend fingerprint compare url 2025-02-26 20:24:55 -08:00
Quinlan Jung 1b713af42f [eas-cli] fix git diff header in fingerprint:compare (#2915)
* [eas-cli] fix git diff header in fingerprint:compare

* Temporary Commit at 2/24/2025, 12:01:45 PM
2025-02-24 12:48:11 -08:00
Quinlan Jung 3ac6472682 [eas-cli] fix formatFields to handle empty array (#2914)
* [eas-cli] fix formatFields to handle empty array

* Temporary Commit at 2/24/2025, 11:40:14 AM
2025-02-24 11:53:02 -08:00
Quinlan Jung 4b8a9d195f [eas-cli] lowercase urls, add more pretty prints (#2909)
* [eas-cli] lowercase urls, add more pretty prints

* Temporary Commit at 2/14/2025, 12:38:47 PM

* Temporary Commit at 2/14/2025, 12:41:29 PM

* Temporary Commit at 2/21/2025, 12:17:24 PM
2025-02-24 11:23:07 -08:00
Expo CI 30c5e9f4c1 update CHANGELOG.md 2025-02-22 01:46:31 +00:00
5 changed files with 29 additions and 11 deletions

No files matched your search

+10 -2
View File
@@ -10,10 +10,18 @@ This is the log of notable changes to EAS CLI and related packages.
### 🐛 Bug fixes
- Fix APNS key creation. ([#2916](https://github.com/expo/eas-cli/pull/2916) by [@EvanBacon](https://github.com/EvanBacon))
### 🧹 Chores
- Fix `eas fingerprint:compare` URL generation and pretty prints. ([#2909](https://github.com/expo/eas-cli/pull/2909) by [@quinlanj](https://github.com/quinlanj))
- fix formatFields to handle empty array. ([#2914](https://github.com/expo/eas-cli/pull/2914) by [@quinlanj](https://github.com/quinlanj))
- fix git diff header in `fingerprint:compare`. ([#2915](https://github.com/expo/eas-cli/pull/2915) by [@quinlanj](https://github.com/quinlanj))
## [15.0.12](https://github.com/expo/eas-cli/releases/tag/v15.0.12) - 2025-02-22
### 🐛 Bug fixes
- Fix APNS key creation. ([#2916](https://github.com/expo/eas-cli/pull/2916) by [@EvanBacon](https://github.com/EvanBacon))
## [15.0.11](https://github.com/expo/eas-cli/releases/tag/v15.0.11) - 2025-02-21
### 🐛 Bug fixes
@@ -238,11 +238,9 @@ export default class FingerprintCompare extends EasCommand {
const project = await AppQuery.byIdAsync(graphqlClient, projectId);
const fingerprintCompareUrl = new URL(
`/accounts/${project.ownerAccount.name}/projects/${project.name}/fingerprints/compare`,
`/accounts/${project.ownerAccount.name}/projects/${project.slug}/fingerprints/compare/${firstFingerprintInfo.fingerprint.hash}/${secondFingerprintInfo.fingerprint.hash}`,
getExpoWebsiteBaseUrl()
);
fingerprintCompareUrl.searchParams.set('a', firstFingerprintInfo.fingerprint.hash);
fingerprintCompareUrl.searchParams.set('b', secondFingerprintInfo.fingerprint.hash);
if (!open) {
Log.newLine();
@@ -528,7 +526,7 @@ async function getFingerprintInfoFromUpdateGroupIdOrUpdateIdAsync(
const project = await AppQuery.byIdAsync(graphqlClient, projectId);
const updateUrl =
getExpoWebsiteBaseUrl() +
`/accounts/${project.ownerAccount.name}/projects/${project.name}/updates/${maybeUpdateGroupId}`;
`/accounts/${project.ownerAccount.name}/projects/${project.slug}/updates/${maybeUpdateGroupId}`;
throw new Error(
`Please pass in your update ID from ${updateUrl} or use interactive mode to select the update ID.`
);
@@ -739,7 +737,10 @@ const PRETTY_CONTENT_ID: Record<string, string> = {
'expoAutolinkingConfig:ios': 'Expo autolinking config (iOS)',
'expoAutolinkingConfig:android': 'Expo autolinking config (Android)',
'packageJson:scripts': 'package.json scripts',
expoConfig: 'Expo config',
expoConfig: 'Expo app config',
'package:react-native': 'React Native package.json',
'rncoreAutolinkingConfig:ios': 'React Native Community autolinking config (iOS)',
'rncoreAutolinkingConfig:android': 'React Native Community autolinking config (Android)',
};
function printContentSource({
@@ -22,7 +22,7 @@ describe('abridgedDiff', () => {
abridgedDiff(str1, str2, 1);
const expectedOutput = [
'cyan(@@ -2,1 +2,1 @@)',
'cyan(@@ -1,3 +1,3 @@)',
' gray(Line1)',
'red(-Line2)',
'green(+LineX)',
@@ -106,7 +106,7 @@ describe('abridgedDiff', () => {
abridgedDiff(str1, str2, 1);
const expectedOutput = [
'cyan(@@ -3,1 +3,1 @@)',
'cyan(@@ -2,3 +2,3 @@)',
' gray(Line1)',
'red(-Line2)',
'green(+LineX)',
@@ -52,8 +52,13 @@ export function abridgedDiff(str1: string, str2: string, contextLines: number =
const flushChunk = (): void => {
if (currentChunk.length > 0) {
const originalRange = `${startOriginal},${removedLines || 0}`;
const modifiedRange = `${startModified},${addedLines || 0}`;
const contextLines = currentChunkPriorContext.length + currentChunkAfterContext.length;
const originalRange = `${(startOriginal ?? 1) - currentChunkPriorContext.length},${
contextLines + removedLines
}`;
const modifiedRange = `${(startModified ?? 1) - currentChunkPriorContext.length},${
contextLines + addedLines
}`;
// `git diff` style header
output.push(chalk.cyan(`@@ -${originalRange} +${modifiedRange} @@`));
output.push(...currentChunkPriorContext);
@@ -10,6 +10,10 @@ export default function formatFields(
fields: FormatFieldsItem[],
options: FormatFieldsOptions = { labelFormat: chalk.dim }
): string {
if (fields.length === 0) {
return '';
}
const columnWidth = fields.reduce((a, b) => (a.label.length > b.label.length ? a : b)).label
.length;