[build-tools] - bubble validation error for when caches exceed max size

.github/PULL_REQUEST_TEMPLATE

@@ -1,3 +1,4 @@
+<!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. -->
 <!-- You can skip the changelog check by labeling the PR with "no changelog". -->
 
 # Why

.github/workflows/codemention.yml

@@ -12,9 +12,9 @@ jobs:
       contents: read
       pull-requests: write
     steps:
-      # Pinned to a commit SHA (not a tag or branch) because this runs under
-      # pull_request_target with a write-scoped token — a re-pointed tag or
-      # moving branch would allow unreviewed upstream code to run here.
-      - uses: tobyhs/codemention@ebac5877393ab8693fd73b42708c8552043e9a3b # post-v1.5.2
+      # Pinned to a commit SHA (not the v1.4.0 tag) because this runs under
+      # pull_request_target with a write-scoped token — a re-pointed tag from
+      # a compromised upstream account would give the attacker repo write access.
+      - uses: tobyhs/codemention@bb6bfb2c3ff1e6fee7ee37006bbee6d114057225 # v1.4.0
         with:
-          githubToken: ${{ secrets.GITHUB_TOKEN }}
+          githubToken: ${{ secrets.GITHUB_TOKEN }}

.vscode/settings.json

@@ -5,6 +5,5 @@
     "**/*.code-search": true,
     "**/src/**/build/**": false,
     "**/src/build/**": false,
-  },
-  "js/ts.tsdk.path": "node_modules/typescript/lib"
+  }
 }

CHANGELOG.md

@@ -8,112 +8,11 @@ This is the log of notable changes to EAS CLI and related packages.
 
 ### 🎉 New features
 
-- [eas-cli] Add `eas project:delete` command to delete a project — the current directory's project by default, or any project passed as an argument (`@account/slug` or ID). Confirmation requires the project's full name, typed at the interactive prompt or passed via `--dangerously-confirm-deletion` (required in non-interactive mode). Deletion requires sudo mode: the command prompts for your password (and OTP) to upgrade the session when the server requires it. Deletion was previously only possible from the website. ([#4012](https://github.com/expo/eas-cli/pull/4012) by [@brentvatne](https://github.com/brentvatne))
-- [eas-cli] Add `eas browse` to open the project page on expo.dev in a web browser, with an optional page argument (e.g. `eas browse build`, `eas browse hosting`) for project subpages and a `--no-browser` flag to print the URL. `eas open` is now an alias of `eas browse`. ([#4003](https://github.com/expo/eas-cli/pull/4003) by [@jonsamp](https://github.com/jonsamp))
-- [eas-cli] Add `--dev-domain` flag to `eas deploy` to choose the project's preview URL (`<name>.expo.app`) without prompting, allowing first-time deploys with `--non-interactive`. ([#4004](https://github.com/expo/eas-cli/pull/4004) by [@brentvatne](https://github.com/brentvatne))
-- [eas-cli] Add `-p` as an alias for `--platform` in `eas simulator:start`. ([#3902](https://github.com/expo/eas-cli/pull/3902) by [@brentvatne](https://github.com/brentvatne))
-
-### 🐛 Bug fixes
-
-### 🧹 Chores
-
-- [eas-cli][build-tools][local-build-plugin][worker] Bump `tar` to `7.5.19`. ([#3971](https://github.com/expo/eas-cli/pull/3971) by [@szdziedzic](https://github.com/szdziedzic))
-
-## [21.0.0](https://github.com/expo/eas-cli/releases/tag/v21.0.0) - 2026-07-13
-
-### 🛠 Breaking changes
-
-- [eas-cli] Remove `eas onboarding` command (aliases `init:onboarding`, `project:onboarding`). ([#3993](https://github.com/expo/eas-cli/pull/3993) by [@byronkarlen](https://github.com/byronkarlen))
-
-### 🎉 New features
-
-- [eas-cli] Improve `eas workflow:create`: add a `--template` flag, generate a placeholder workflow when a file name is passed, use shorter default file names (`build.yml`, `update.yml`, `deploy.yml`), configure EAS Build and EAS Update automatically when the chosen template requires them, set default app identifiers without prompting for the development build and deploy templates, install `expo-dev-client` during development build setup, and tighten the generated comments and next steps. ([#3943](https://github.com/expo/eas-cli/pull/3943) by [@jonsamp](https://github.com/jonsamp))
-- [eas-cli] `eas integrations:posthog:dashboard` now opens PostHog via a signed-in link, skipping the login prompt. ([#3975](https://github.com/expo/eas-cli/pull/3975) by [@gwdp](https://github.com/gwdp))
-- [build-tools] Add `eas/posthog_capture_event` workflow function to send PostHog events from workflow runs. ([#3934](https://github.com/expo/eas-cli/pull/3934) by [@gwdp](https://github.com/gwdp))
-- [build-tools] Add `eas/posthog_flag_rollout` workflow function to update PostHog feature flags from workflow runs. ([#3944](https://github.com/expo/eas-cli/pull/3944) by [@gwdp](https://github.com/gwdp))
-- [build-tools] Add `eas/posthog_wait_for_metric` workflow function to gate workflow runs on a PostHog metric. ([#3945](https://github.com/expo/eas-cli/pull/3945) by [@gwdp](https://github.com/gwdp))
-- [build-tools] Add `eas/posthog_upload_sourcemaps` workflow function to upload source maps to PostHog. ([#3947](https://github.com/expo/eas-cli/pull/3947) by [@gwdp](https://github.com/gwdp))
-- [build-tools] Add `eas/posthog_annotation` workflow function to create PostHog annotations from workflow runs. ([#3948](https://github.com/expo/eas-cli/pull/3948) by [@gwdp](https://github.com/gwdp))
-- [build-tools] Add `eas/posthog_wait_for_query` workflow function to gate workflow runs on a PostHog query. ([#3949](https://github.com/expo/eas-cli/pull/3949) by [@gwdp](https://github.com/gwdp))
-
-### 🐛 Bug fixes
-
-- [eas-cli] Rethrow Apple errors during capability sync instead of silently succeeding. ([#3989](https://github.com/expo/eas-cli/pull/3989) by [@douglowder](https://github.com/douglowder))
-- [build-tools] Skip embedded bundle upload for development client builds instead of warning that the bundle is missing. ([#3940](https://github.com/expo/eas-cli/pull/3940) by [@gwdp](https://github.com/gwdp))
-- [eas-cli] Accept a navigation metric name in observe:metrics when passed in on the command line. ([#3973](https://github.com/expo/eas-cli/pull/3973) by [@douglowder](https://github.com/douglowder))
-- [eas-cli] Retry uploading assets that don't finish processing during `eas update`, instead of failing the update. ([#3918](https://github.com/expo/eas-cli/pull/3918) by [@gwdp](https://github.com/gwdp))
-
-### 🧹 Chores
-
-- [eas-cli] add agent detection to analytics events. ([#3983](https://github.com/expo/eas-cli/pull/3983) by [@davidmokos](https://github.com/davidmokos))
-- Bump `glob` 10.x to a patched version in the root lockfile. ([#3979](https://github.com/expo/eas-cli/pull/3979) by [@szdziedzic](https://github.com/szdziedzic))
-- [build-tools] Bump `jws` to a patched version in the root lockfile. ([#3978](https://github.com/expo/eas-cli/pull/3978) by [@szdziedzic](https://github.com/szdziedzic))
-- [worker] Bump `koa` to `3.1.2`. ([#3974](https://github.com/expo/eas-cli/pull/3974) by [@szdziedzic](https://github.com/szdziedzic))
-- [steps] Bump `cross-spawn` to a patched version in the TypeScript custom function fixture. ([#3977](https://github.com/expo/eas-cli/pull/3977) by [@szdziedzic](https://github.com/szdziedzic))
-- [eas-cli] Bump `node-forge` to `1.4.0`. ([#3970](https://github.com/expo/eas-cli/pull/3970) by [@szdziedzic](https://github.com/szdziedzic))
-- [eas-cli] Bump `fast-xml-builder` to `1.2.1` to resolve [Dependabot alert 400](https://github.com/expo/eas-cli/security/dependabot/400). ([#3966](https://github.com/expo/eas-cli/pull/3966) by [@szdziedzic](https://github.com/szdziedzic))
-- [eas-cli] Bump `form-data` to patched releases to resolve [Dependabot alert 465](https://github.com/expo/eas-cli/security/dependabot/465). ([#3962](https://github.com/expo/eas-cli/pull/3962) by [@szdziedzic](https://github.com/szdziedzic))
-- [eas-cli] Bump `fast-xml-parser` to `4.5.7` to resolve [Dependabot alert 286](https://github.com/expo/eas-cli/security/dependabot/286). ([#3960](https://github.com/expo/eas-cli/pull/3960) by [@szdziedzic](https://github.com/szdziedzic))
-- [eas-cli] Bump `shell-quote` to `1.9.0` to resolve [Dependabot alert 440](https://github.com/expo/eas-cli/security/dependabot/440). ([#3959](https://github.com/expo/eas-cli/pull/3959) by [@szdziedzic](https://github.com/szdziedzic))
-
-## [20.5.1](https://github.com/expo/eas-cli/releases/tag/v20.5.1) - 2026-07-01
-
-### 🐛 Bug fixes
-
-- [eas-cli] Fix Free plan users being warned they had reached their build limit while still well below it. Overage warnings are now shown only for paid plans with an actual billable overage cost. ([#3882](https://github.com/expo/eas-cli/pull/3882) by [@sarahlane8](https://github.com/sarahlane8))
-- [eas-cli] Select correct tvOS build target for non-interactive Apple builds when EXPO_TV env variable is set. ([#3907](https://github.com/expo/eas-cli/pull/3907) by [@douglowder](https://github.com/douglowder))
-
-### 🧹 Chores
-
-- [eas-cli] Bump `@expo/apple-utils` to `2.1.22`. ([#3913](https://github.com/expo/eas-cli/pull/3913) by [@sjchmiela](https://github.com/sjchmiela))
-
-## [20.5.0](https://github.com/expo/eas-cli/releases/tag/v20.5.0) - 2026-06-29
-
-### 🎉 New features
-
-- [eas-cli] `eas integrations:posthog:connect` now supports existing PostHog user connection. ([#3895](https://github.com/expo/eas-cli/pull/3895) by [@gwdp](https://github.com/gwdp))
-
-## [20.4.0](https://github.com/expo/eas-cli/releases/tag/v20.4.0) - 2026-06-25
-
-### 🎉 New features
-
-- [eas-cli] New command `observe:session` for inspecting events by session ID. ([#3868](https://github.com/expo/eas-cli/pull/3868) by [@douglowder](https://github.com/douglowder))
-- [eas-cli] Add tiered build-credit usage warnings (approaching/at/over) before each build, lowering the warning threshold to 80% to match email notifications. ([#3882](https://github.com/expo/eas-cli/pull/3882) by [@sarahlane8](https://github.com/sarahlane8))
-
-### 🐛 Bug fixes
-
-- [eas-cli] Fix `eas update --channel` failing with "Channel has no branches associated with it" when the channel was auto-created by a build. A branch with the channel's name is now created and linked, matching the behavior for a channel that doesn't exist yet. ([#3891](https://github.com/expo/eas-cli/pull/3891) by [@gwdp](https://github.com/gwdp))
-
-## [20.3.0](https://github.com/expo/eas-cli/releases/tag/v20.3.0) - 2026-06-18
-
-### 🎉 New features
-
-- [eas-cli] Add `eas account:audit [ACCOUNT_NAME]` command to view an account's audit logs. ([#3863](https://github.com/expo/eas-cli/pull/3863) by [@keith-kurak](https://github.com/keith-kurak))
-- [eas-cli] `eas update:view [GROUP_ID]` now also accepts a platform-specific update ID, resolving it to and displaying its update group. ([#3864](https://github.com/expo/eas-cli/pull/3864) by [@keith-kurak](https://github.com/keith-kurak))
-- [eas-cli] Add `eas integrations:posthog:connect` command. ([#3836](https://github.com/expo/eas-cli/pull/3836) by [@gwdp](https://github.com/gwdp))
-- [eas-cli] Add `eas integrations:posthog:dashboard` command. ([#3837](https://github.com/expo/eas-cli/pull/3837) by [@gwdp](https://github.com/gwdp))
-- [eas-cli] Add `eas integrations:posthog:disconnect` command. ([#3838](https://github.com/expo/eas-cli/pull/3838) by [@gwdp](https://github.com/gwdp))
-
-### 🐛 Bug fixes
-
-- [eas-cli] `eas integrations:posthog:connect` no longer aborts when `npx expo install` reports an error (for example, on a dynamic app config); it finishes writing the environment variables and prints any remaining manual steps. ([#3877](https://github.com/expo/eas-cli/pull/3877) by [@gwdp](https://github.com/gwdp))
-
-### 🧹 Chores
-
-- [eas-cli] Sync new app agent templates from `expo/llm-configs` before publishing. ([#3865](https://github.com/expo/eas-cli/pull/3865) by [@davidmokos](https://github.com/davidmokos))
-- [eas-cli] Simplify 2FA now that SMS is no longer supported. ([#3859](https://github.com/expo/eas-cli/pull/3859) by [@wschurman](https://github.com/wschurman))
-
-## [20.2.0](https://github.com/expo/eas-cli/releases/tag/v20.2.0) - 2026-06-15
-
-### 🎉 New features
-
-- [eas-cli] Non-interactive iOS App Store and Enterprise builds can now use the App Store Connect API key stored in EAS credentials as a submission key to validate and repair provisioning profiles on Apple servers, without requiring `EXPO_ASC_*` environment variables or an interactive Apple login. ([#3805](https://github.com/expo/eas-cli/pull/3805) by [@sswrk](https://github.com/sswrk))
-- [eas-cli] Add support for non-interactive `eas update:rollback [GROUP_ID]`. The given update group must be the latest for its branch and runtime version; the previous update group is republished, or a roll back to the embedded update is published if there is none. ([#3825](https://github.com/expo/eas-cli/pull/3825) by [@quinlanj](https://github.com/quinlanj))
-
 ### 🐛 Bug fixes
 
 - [expo-cocoapods-proxy] Fix iOS worker tarball build failing on macOS Tahoe due to bundler incompatibility with RubyGems 4. ([#3824](https://github.com/expo/eas-cli/pull/3824) by [@gwdp](https://github.com/gwdp))
-- [eas-cli] Fix `update:embedded` topic showing the `update:embedded:delete` subcommand description in the command listing. ([#3866](https://github.com/expo/eas-cli/pull/3866) by [@jc-expo](https://github.com/jc-expo))
+
+### 🧹 Chores
 
 ## [20.1.0](https://github.com/expo/eas-cli/releases/tag/v20.1.0) - 2026-06-05
 

lerna.json

@@ -1,5 +1,5 @@
 {
   "npmClient": "yarn",
-  "version": "21.0.1",
+  "version": "20.1.0",
   "$schema": "node_modules/lerna/schemas/lerna-schema.json"
 }

packages/build-tools/.gitignore

@@ -1,6 +1,5 @@
 node_modules/
 dist/
-bin/record-sim
 
 .secrets*
 !.secrets.example

packages/build-tools/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@expo/build-tools",
-  "version": "21.0.1",
+  "version": "20.1.0",
   "bugs": "https://github.com/expo/eas-cli/issues",
   "license": "BUSL-1.1",
   "author": "Expo <[email protected]>",
@@ -23,7 +23,6 @@
     "watch": "tsc --watch --preserveWatchOutput",
     "prebuild": "yarn gql",
     "build": "tsc",
-    "build:record-sim": "mkdir -p bin && record_sim_bin_path=$(swift build -c release --package-path resources/record-sim --build-path resources/record-sim/.build --show-bin-path) && swift build -c release --package-path resources/record-sim --build-path resources/record-sim/.build && cp \"$record_sim_bin_path/record-sim\" bin/record-sim && chmod +x bin/record-sim",
     "typecheck": "tsc",
     "prepack": "rimraf dist \"*.tsbuildinfo\" && yarn gql && tsc -p tsconfig.build.json",
     "jest-unit": "jest --config jest/unit-config.ts",
@@ -38,17 +37,17 @@
   "dependencies": {
     "@expo/config": "55.0.10",
     "@expo/config-plugins": "55.0.7",
-    "@expo/downloader": "21.0.0",
-    "@expo/eas-build-job": "21.0.1",
+    "@expo/downloader": "20.0.0",
+    "@expo/eas-build-job": "20.1.0",
     "@expo/env": "^0.4.0",
-    "@expo/logger": "21.0.0",
+    "@expo/logger": "20.0.0",
     "@expo/package-manager": "1.9.10",
     "@expo/plist": "^0.2.0",
     "@expo/results": "^1.0.0",
     "@expo/spawn-async": "1.7.2",
-    "@expo/steps": "21.0.1",
-    "@expo/template-file": "21.0.0",
-    "@expo/turtle-spawn": "21.0.0",
+    "@expo/steps": "20.1.0",
+    "@expo/template-file": "20.0.0",
+    "@expo/turtle-spawn": "20.0.0",
     "@expo/xcpretty": "^4.3.1",
     "@google-cloud/storage": "^7.11.2",
     "@ngrok/ngrok": "1.7.0",
@@ -72,7 +71,7 @@
     "resolve-from": "^5.0.0",
     "retry": "^0.13.1",
     "semver": "^7.6.2",
-    "tar": "7.5.19",
+    "tar": "7.5.7",
     "uuid": "9.0.1",
     "yaml": "^2.8.1",
     "zod": "^4.3.5"

packages/build-tools/resources/record-sim/.gitignore

@@ -1,4 +0,0 @@
-.build/
-.swiftpm/
-DerivedData/
-.DS_Store

packages/build-tools/resources/record-sim/Package.swift

@@ -1,28 +0,0 @@
-// swift-tools-version: 5.9
-
-import PackageDescription
-
-let package = Package(
-    name: "record-sim",
-    platforms: [
-        .macOS(.v14),
-    ],
-    products: [
-        .library(name: "RecordSim", targets: ["RecordSim"]),
-        .executable(name: "record-sim", targets: ["record-sim"]),
-    ],
-    targets: [
-        .target(
-            name: "RecordSim",
-            linkerSettings: [
-                .linkedFramework("AVFoundation"),
-                .linkedFramework("CoreGraphics"),
-                .linkedFramework("CoreMedia"),
-                .linkedFramework("CoreVideo"),
-                .linkedFramework("IOSurface"),
-                .linkedFramework("UniformTypeIdentifiers"),
-            ]
-        ),
-        .executableTarget(name: "record-sim", dependencies: ["RecordSim"]),
-    ]
-)

packages/build-tools/resources/record-sim/README.md

@@ -1,79 +0,0 @@
-# RecordSim
-
-Small Swift library for non-exclusive iOS Simulator screen recording.
-
-It implements one recording path:
-
-1. Listen to SimRenderServer framebuffer callbacks.
-2. Copy the live `IOSurface` immediately into an owned `CVPixelBuffer`.
-3. Feed one continuous `AVAssetWriter`.
-4. Emit Apple HLS/CMAF-style fragmented MP4 segments.
-
-The output is suitable for uploading while recording. `session.json` contains
-the ordered segment metadata needed to build a playlist later.
-
-## Output
-
-```text
-session/
-  init.mp4
-  session.json
-  segments/
-    segment-000000.m4s
-    segment-000001.m4s
-```
-
-`init.mp4` is the fMP4 initialization segment. Individual `.m4s` files are not
-standalone MP4 files. `session.json` stores the wall-clock timestamp for the
-first video frame plus the metadata needed to build a playlist: HLS version,
-target duration, media sequence, `initSegment`, and the ordered `segments` array
-with file path and duration for each media segment.
-
-## CLI
-
-```bash
-swift run record-sim \
-  --udid <BOOTED_SIMULATOR_UDID> \
-  --output /tmp/sim-recording \
-  --segment-duration 120 \
-  --fps 30 \
-  --bitrate 30000000 \
-  --codec h264
-```
-
-For sparse 2h sessions, `--segment-duration 120` is a reasonable default: about
-60 media objects plus the init segment. The recorder appends a single duplicate
-hold frame near each segment boundary when the simulator is idle, so long idle
-periods still produce uploadable segments without encoding idle frames at 60fps.
-Use `--segment-duration 0` to write one continuous `recording.mp4` instead of
-`init.mp4` plus media segments.
-
-Frame timestamps use monotonic host time, not wall-clock time. The recorder also
-probes the framebuffer seed once per second; if the surface changes without
-callbacks for 5 seconds, it captures that frame and rewires the private callback
-registration.
-
-## Library
-
-```swift
-let recorder = SimulatorRecorder(
-  configuration: SimulatorRecordingConfiguration(
-    deviceUDID: udid,
-    outputDirectory: sessionDirectory,
-    segmentDuration: 120
-  )
-)
-
-recorder.onSegment = { segment in
-  // Enqueue upload of segment.url.
-}
-
-try recorder.start()
-try recorder.waitUntilFirstFrame()
-// ...
-let manifest = try recorder.stop()
-```
-
-`session.json` contains the precise wall-clock time for video PTS zero. In
-segmented mode it also contains the init segment and ordered media segment
-file/duration entries; in single-file mode it points at `recording.mp4`.

packages/build-tools/resources/record-sim/Sources/RecordSim/FramebufferDisplaySource.swift

@@ -1,192 +0,0 @@
-import Foundation
-import IOSurface
-import ObjectiveC
-
-final class FramebufferDisplaySource {
-    struct SurfaceSnapshot {
-        let surface: IOSurface
-        let width: Int
-        let height: Int
-        let seed: UInt32
-    }
-
-    private let deviceUDID: String
-    private let callbackQueue: DispatchQueue
-    private let onFrame: () -> Void
-    private let onSurfaceChange: () -> Void
-    private var descriptors: [NSObject] = []
-    private var callbackUUIDs: [ObjectIdentifier: NSUUID] = [:]
-    private var retainedBlocks: [AnyObject] = []
-    private var ioClient: NSObject?
-
-    init(
-        deviceUDID: String,
-        callbackQueue: DispatchQueue,
-        onFrame: @escaping () -> Void,
-        onSurfaceChange: @escaping () -> Void
-    ) {
-        self.deviceUDID = deviceUDID
-        self.callbackQueue = callbackQueue
-        self.onFrame = onFrame
-        self.onSurfaceChange = onSurfaceChange
-    }
-
-    func start() throws {
-        try PrivateSimulatorFrameworks.load()
-        guard let device = SimulatorDeviceLookup.find(udid: deviceUDID) else {
-            throw RecorderError.make(1, "Simulator \(deviceUDID) not found")
-        }
-        let state = device.value(forKey: "stateString") as? String ?? "unknown"
-        guard state == "Booted" else {
-            throw RecorderError.make(2, "Simulator \(deviceUDID) is not booted (state: \(state))")
-        }
-        guard
-            let io = device.perform(NSSelectorFromString("io"))?.takeUnretainedValue() as? NSObject
-        else {
-            throw RecorderError.make(3, "Failed to get simulator IO client")
-        }
-        ioClient = io
-        try wireUpFramebuffer()
-    }
-
-    func stop() {
-        unregisterCallbacks()
-        descriptors.removeAll()
-        retainedBlocks.removeAll()
-        ioClient = nil
-    }
-
-    func surfaceSnapshot() -> SurfaceSnapshot? {
-        let surfaceSelector = NSSelectorFromString("framebufferSurface")
-        var bestSnapshot: SurfaceSnapshot?
-        var bestArea = 0
-        for descriptor in descriptors {
-            guard let surfaceObject = descriptor.perform(surfaceSelector)?.takeUnretainedValue()
-            else {
-                continue
-            }
-            let surface = unsafeBitCast(surfaceObject, to: IOSurface.self)
-            let width = IOSurfaceGetWidth(surface)
-            let height = IOSurfaceGetHeight(surface)
-            let area = width * height
-            if area > bestArea {
-                bestSnapshot = SurfaceSnapshot(
-                    surface: surface,
-                    width: width,
-                    height: height,
-                    seed: IOSurfaceGetSeed(surface)
-                )
-                bestArea = area
-            }
-        }
-        return bestSnapshot
-    }
-
-    func rewireFramebuffer() throws {
-        try wireUpFramebuffer()
-    }
-
-    private func wireUpFramebuffer() throws {
-        guard let io = ioClient else {
-            throw RecorderError.make(3, "No simulator IO client")
-        }
-        io.perform(NSSelectorFromString("updateIOPorts"))
-        let nextDescriptors = try findFramebufferDescriptors(io: io)
-        unregisterCallbacks()
-        descriptors = nextDescriptors
-        retainedBlocks.removeAll()
-        do {
-            for descriptor in descriptors {
-                try registerCallbacks(descriptor: descriptor)
-            }
-        } catch {
-            unregisterCallbacks()
-            descriptors.removeAll()
-            retainedBlocks.removeAll()
-            throw error
-        }
-    }
-
-    private func findFramebufferDescriptors(io: NSObject) throws -> [NSObject] {
-        guard let ports = io.value(forKey: "deviceIOPorts") as? [NSObject] else {
-            throw RecorderError.make(4, "Failed to read simulator IO ports")
-        }
-        let portIdentifierSelector = NSSelectorFromString("portIdentifier")
-        let descriptorSelector = NSSelectorFromString("descriptor")
-        let surfaceSelector = NSSelectorFromString("framebufferSurface")
-
-        var candidates: [NSObject] = []
-        for port in ports {
-            guard port.responds(to: portIdentifierSelector),
-                let portIdentifier = port.perform(portIdentifierSelector)?.takeUnretainedValue(),
-                "\(portIdentifier)" == "com.apple.framebuffer.display",
-                port.responds(to: descriptorSelector),
-                let descriptor = port.perform(descriptorSelector)?.takeUnretainedValue()
-                    as? NSObject,
-                descriptor.responds(to: surfaceSelector)
-            else {
-                continue
-            }
-            candidates.append(descriptor)
-        }
-        if candidates.isEmpty {
-            throw RecorderError.make(5, "No framebuffer display descriptor found")
-        }
-        return candidates
-    }
-
-    private func registerCallbacks(descriptor: NSObject) throws {
-        let selector = NSSelectorFromString(
-            "registerScreenCallbacksWithUUID:callbackQueue:frameCallback:surfacesChangedCallback:propertiesChangedCallback:"
-        )
-        guard descriptor.responds(to: selector) else {
-            throw RecorderError.make(6, "Framebuffer descriptor does not support screen callbacks")
-        }
-        guard let msgSendPointer = dlsym(UnsafeMutableRawPointer(bitPattern: -2), "objc_msgSend")
-        else {
-            throw RecorderError.make(7, "objc_msgSend not found")
-        }
-        typealias MsgSend =
-            @convention(c) (
-                AnyObject, Selector, AnyObject, AnyObject, AnyObject, AnyObject, AnyObject
-            ) -> Void
-        let msgSend = unsafeBitCast(msgSendPointer, to: MsgSend.self)
-
-        let uuid = NSUUID()
-        callbackUUIDs[ObjectIdentifier(descriptor)] = uuid
-
-        let frameCallback: @convention(block) () -> Void = { [weak self] in
-            self?.onFrame()
-        }
-        let surfacesCallback: @convention(block) (AnyObject?, AnyObject?) -> Void = {
-            [weak self] _, _ in
-            self?.onSurfaceChange()
-        }
-        let propertiesCallback: @convention(block) () -> Void = {}
-        retainedBlocks.append(frameCallback as AnyObject)
-        retainedBlocks.append(surfacesCallback as AnyObject)
-        retainedBlocks.append(propertiesCallback as AnyObject)
-
-        msgSend(
-            descriptor,
-            selector,
-            uuid,
-            callbackQueue as AnyObject,
-            frameCallback as AnyObject,
-            surfacesCallback as AnyObject,
-            propertiesCallback as AnyObject
-        )
-    }
-
-    private func unregisterCallbacks() {
-        let selector = NSSelectorFromString("unregisterScreenCallbacksWithUUID:")
-        for descriptor in descriptors {
-            if let uuid = callbackUUIDs[ObjectIdentifier(descriptor)],
-                descriptor.responds(to: selector)
-            {
-                descriptor.perform(selector, with: uuid)
-            }
-        }
-        callbackUUIDs.removeAll()
-    }
-}

packages/build-tools/resources/record-sim/Sources/RecordSim/PrivateSimulatorServices.swift

@@ -1,96 +0,0 @@
-import Foundation
-import ObjectiveC
-
-enum XcodeDeveloperDirectory {
-    static let current: String = {
-        if let developerDir = ProcessInfo.processInfo.environment["DEVELOPER_DIR"],
-            !developerDir.isEmpty
-        {
-            return developerDir
-        }
-
-        let fallback = "/Applications/Xcode.app/Contents/Developer"
-        let pipe = Pipe()
-        let process = Process()
-        process.executableURL = URL(fileURLWithPath: "/usr/bin/xcode-select")
-        process.arguments = ["-p"]
-        process.standardOutput = pipe
-        do {
-            try process.run()
-        } catch {
-            return fallback
-        }
-        process.waitUntilExit()
-        return String(data: pipe.fileHandleForReading.readDataToEndOfFile(), encoding: .utf8)?
-            .trimmingCharacters(in: .whitespacesAndNewlines) ?? fallback
-    }()
-}
-
-enum PrivateSimulatorFrameworks {
-    static func load() throws {
-        try loadResult.get()
-    }
-
-    private static let loadResult: Result<Void, Error> = {
-        let developerDir = XcodeDeveloperDirectory.current
-        let candidates = [
-            "/Library/Developer/PrivateFrameworks/CoreSimulator.framework/CoreSimulator",
-            "\(developerDir)/Library/PrivateFrameworks/CoreSimulator.framework/CoreSimulator",
-            "\(developerDir)/../SharedFrameworks/SimulatorKit.framework/SimulatorKit",
-            "\(developerDir)/Library/PrivateFrameworks/SimulatorKit.framework/SimulatorKit",
-        ]
-        var failures: [String] = []
-        for path in candidates {
-            if dlopen(path, RTLD_NOW) == nil {
-                let message = dlerror().map { String(cString: $0) } ?? "unknown error"
-                failures.append("\(path): \(message)")
-            }
-        }
-        guard NSClassFromString("SimServiceContext") != nil else {
-            let tried = candidates.joined(separator: ", ")
-            let errors = failures.isEmpty ? "no dlopen errors" : failures.joined(separator: "; ")
-            return .failure(
-                RecorderError.make(
-                    8,
-                    "Failed to load CoreSimulator/SimulatorKit (tried: \(tried); errors: \(errors))"
-                )
-            )
-        }
-        return .success(())
-    }()
-}
-
-enum SimulatorDeviceLookup {
-    private static let context: NSObject? = {
-        guard let contextClass = NSClassFromString("SimServiceContext") as? NSObject.Type else {
-            return nil
-        }
-        let sharedSelector = NSSelectorFromString("sharedServiceContextForDeveloperDir:error:")
-        return contextClass.perform(
-            sharedSelector, with: XcodeDeveloperDirectory.current, with: nil)?
-            .takeUnretainedValue() as? NSObject
-    }()
-
-    static func find(udid: String) -> NSObject? {
-        guard let context else {
-            return nil
-        }
-        let deviceSetSelector = NSSelectorFromString("defaultDeviceSetWithError:")
-        guard
-            let deviceSet = context.perform(deviceSetSelector, with: nil)?
-                .takeUnretainedValue() as? NSObject
-        else {
-            return nil
-        }
-        guard let devices = deviceSet.value(forKey: "devices") as? [NSObject] else {
-            return nil
-        }
-        return devices.first {
-            ($0.value(forKey: "UDID") as? NSUUID)?.uuidString == udid
-        }
-    }
-
-    static func stateString(udid: String) -> String? {
-        find(udid: udid)?.value(forKey: "stateString") as? String
-    }
-}

packages/build-tools/resources/record-sim/Sources/RecordSim/RecordingModels.swift

@@ -1,70 +0,0 @@
-import Foundation
-
-public enum RecorderCodec: String, Codable, Sendable {
-    case h264
-    case hevc
-}
-
-public struct SimulatorRecordingConfiguration: Sendable {
-    public var deviceUDID: String
-    public var outputDirectory: URL
-    public var fps: Int
-    public var bitrate: Int
-    public var codec: RecorderCodec
-    public var segmentDuration: TimeInterval
-    public var maxPendingFrames: Int
-    public var overwrite: Bool
-
-    public init(
-        deviceUDID: String,
-        outputDirectory: URL,
-        fps: Int = 30,
-        bitrate: Int = 30_000_000,
-        codec: RecorderCodec = .h264,
-        segmentDuration: TimeInterval = 120,
-        maxPendingFrames: Int = 8,
-        overwrite: Bool = true
-    ) {
-        self.deviceUDID = deviceUDID
-        self.outputDirectory = outputDirectory
-        self.fps = fps
-        self.bitrate = bitrate
-        self.codec = codec
-        self.segmentDuration = segmentDuration
-        self.maxPendingFrames = maxPendingFrames
-        self.overwrite = overwrite
-    }
-}
-
-public enum SegmentKind: String, Codable, Sendable {
-    case initialization
-    case media
-}
-
-public struct SegmentOutput: Sendable {
-    public let kind: SegmentKind
-    public let relativePath: String
-    public let url: URL
-    public let byteCount: Int
-    public let durationSeconds: Double?
-}
-
-public struct MediaSegmentRecord: Codable, Sendable {
-    public let file: String
-    public let durationSeconds: Double
-}
-
-public struct FirstFrameWallClock: Codable, Sendable {
-    public let unixMs: Int64
-    public let iso8601: String
-}
-
-public struct RecordingManifest: Codable, Sendable {
-    public let firstFrameWallClock: FirstFrameWallClock
-    public let hlsVersion: Int?
-    public let hlsTargetDurationSeconds: Int?
-    public let hlsMediaSequence: Int?
-    public let recording: String?
-    public let initSegment: String?
-    public let segments: [MediaSegmentRecord]
-}

packages/build-tools/resources/record-sim/Sources/RecordSim/RecordingOutputWriter.swift

@@ -1,136 +0,0 @@
-import AVFoundation
-import Foundation
-
-final class RecordingOutputWriter: NSObject, AVAssetWriterDelegate {
-    private let rootDirectory: URL
-    private let segmentsDirectory: URL
-    let singleRecordingURL: URL
-    private let stateQueue = DispatchQueue(label: "record-sim.segment-writer")
-    private let notificationQueue = DispatchQueue(label: "record-sim.segment-notifications")
-    private let onSegment: ((SegmentOutput) -> Void)?
-    private var initSegmentPath: String?
-    private var segments: [MediaSegmentRecord] = []
-    private var nextMediaSegmentIndex = 0
-    private var firstError: Error?
-
-    init(rootDirectory: URL, onSegment: ((SegmentOutput) -> Void)?) {
-        self.rootDirectory = rootDirectory
-        self.segmentsDirectory = rootDirectory.appendingPathComponent("segments", isDirectory: true)
-        self.singleRecordingURL = rootDirectory.appendingPathComponent("recording.mp4")
-        self.onSegment = onSegment
-        super.init()
-    }
-
-    func prepare(overwrite: Bool, segmented: Bool) throws {
-        if overwrite {
-            try? FileManager.default.removeItem(at: rootDirectory)
-        }
-        try FileManager.default.createDirectory(at: rootDirectory, withIntermediateDirectories: true)
-        if segmented {
-            try FileManager.default.createDirectory(at: segmentsDirectory, withIntermediateDirectories: true)
-        }
-    }
-
-    var error: Error? {
-        stateQueue.sync { firstError }
-    }
-
-    func assetWriter(
-        _ writer: AVAssetWriter,
-        didOutputSegmentData segmentData: Data,
-        segmentType: AVAssetSegmentType,
-        segmentReport: AVAssetSegmentReport?
-    ) {
-        var notification: SegmentOutput?
-
-        stateQueue.sync {
-            if firstError != nil {
-                return
-            }
-            do {
-                switch segmentType {
-                case .initialization:
-                    let relativePath = "init.mp4"
-                    let url = rootDirectory.appendingPathComponent(relativePath)
-                    try segmentData.write(to: url, options: .atomic)
-                    initSegmentPath = relativePath
-                    notification = SegmentOutput(
-                        kind: .initialization,
-                        relativePath: relativePath,
-                        url: url,
-                        byteCount: segmentData.count,
-                        durationSeconds: nil
-                    )
-                case .separable:
-                    let index = nextMediaSegmentIndex
-                    let relativePath = String(format: "segments/segment-%06d.m4s", index)
-                    let url = rootDirectory.appendingPathComponent(relativePath)
-                    try segmentData.write(to: url, options: .atomic)
-
-                    let videoReport = segmentReport?.trackReports.first(where: { $0.mediaType == .video })
-                    let duration = videoReport.flatMap { timeSeconds($0.duration) } ?? 0
-                    let record = MediaSegmentRecord(
-                        file: relativePath,
-                        durationSeconds: duration
-                    )
-                    nextMediaSegmentIndex += 1
-                    segments.append(record)
-                    notification = SegmentOutput(
-                        kind: .media,
-                        relativePath: relativePath,
-                        url: url,
-                        byteCount: segmentData.count,
-                        durationSeconds: duration
-                    )
-                default:
-                    break
-                }
-            } catch {
-                firstError = error
-            }
-        }
-
-        if let notification, let onSegment {
-            notificationQueue.async {
-                onSegment(notification)
-            }
-        }
-    }
-
-    @discardableResult
-    func writeManifest(
-        configuration: SimulatorRecordingConfiguration,
-        firstFrameWallClock: Date
-    ) throws -> RecordingManifest {
-        try stateQueue.sync {
-            if let firstError {
-                throw firstError
-            }
-            let segmented = configuration.segmentDuration > 0
-            if segmented, initSegmentPath == nil {
-                throw RecorderError.make(50, "Missing initialization segment")
-            }
-            if segmented, segments.isEmpty {
-                throw RecorderError.make(51, "No media segments were written")
-            }
-            let targetDuration = segmented
-                ? max(1, Int(ceil(segments.map(\.durationSeconds).max() ?? configuration.segmentDuration)))
-                : nil
-            let manifest = RecordingManifest(
-                firstFrameWallClock: FirstFrameWallClock(
-                    unixMs: unixMs(firstFrameWallClock),
-                    iso8601: iso8601(firstFrameWallClock)
-                ),
-                hlsVersion: segmented ? 7 : nil,
-                hlsTargetDurationSeconds: targetDuration,
-                hlsMediaSequence: segmented ? 0 : nil,
-                recording: segmented ? nil : "recording.mp4",
-                initSegment: segmented ? initSegmentPath : nil,
-                segments: segments
-            )
-            let data = try JSONEncoder.prettySorted.encode(manifest)
-            try data.write(to: rootDirectory.appendingPathComponent("session.json"), options: .atomic)
-            return manifest
-        }
-    }
-}

packages/build-tools/resources/record-sim/Sources/RecordSim/SimulatorRecorder.swift

@@ -1,632 +0,0 @@
-import AVFoundation
-import CoreVideo
-import Foundation
-import IOSurface
-import UniformTypeIdentifiers
-
-public final class SimulatorRecorder {
-    public var onSegment: ((SegmentOutput) -> Void)?
-    public var onSimulatorStopped: ((String) -> Void)?
-
-    private static let callbackStalenessTimeout: TimeInterval = 5
-    private static let firstFrameRewireInterval: TimeInterval = 1
-    private let configuration: SimulatorRecordingConfiguration
-    private let callbackQueue = DispatchQueue(
-        label: "record-sim.frame-callbacks", qos: .userInteractive)
-    private let writerQueue = DispatchQueue(label: "record-sim.asset-writer", qos: .userInitiated)
-    private let eventQueue = DispatchQueue(label: "record-sim.events", qos: .utility)
-    private let pendingLock = NSLock()
-    private var pendingFrames = 0
-    private var displaySource: FramebufferDisplaySource?
-    private var outputWriter: RecordingOutputWriter?
-    private var writer: AVAssetWriter?
-    private var input: AVAssetWriterInput?
-    private var adaptor: AVAssetWriterInputPixelBufferAdaptor?
-    private var boundaryTimer: DispatchSourceTimer?
-    private var monotonicClock = MonotonicClock()
-    private var firstAcceptedCaptureTime: CMTime?
-    private var firstAcceptedWallClock: Date?
-    private var lastPTS: CMTime?
-    private var lastSeed: UInt32?
-    private var lastFrameCallbackElapsed: TimeInterval?
-    private var lastFirstFrameRewireElapsed: TimeInterval = 0
-    private var lastAppendedPixelBuffer: CVPixelBuffer?
-    private var nextBoundaryElapsed: TimeInterval = 0
-    private var simulatorStoppedReason: String?
-    private var stopped = false
-    private var firstFrameReady = false
-    private let firstFrameSemaphore = DispatchSemaphore(value: 0)
-    private var firstError: Error?
-
-    public init(configuration: SimulatorRecordingConfiguration) {
-        self.configuration = configuration
-    }
-
-    public func start() throws {
-        try validateConfiguration()
-
-        let outputWriter = RecordingOutputWriter(
-            rootDirectory: configuration.outputDirectory,
-            onSegment: { [weak self] segment in
-                self?.onSegment?(segment)
-            })
-        try outputWriter.prepare(
-            overwrite: configuration.overwrite, segmented: configuration.segmentDuration > 0)
-        self.outputWriter = outputWriter
-
-        monotonicClock = MonotonicClock()
-        nextBoundaryElapsed = configuration.segmentDuration
-        lastFirstFrameRewireElapsed = 0
-        stopped = false
-
-        let source = FramebufferDisplaySource(
-            deviceUDID: configuration.deviceUDID,
-            callbackQueue: callbackQueue,
-            onFrame: { [weak self] in
-                self?.captureFrame(force: false, reason: .callback)
-            },
-            onSurfaceChange: { [weak self] in
-                self?.captureFrame(force: true, reason: .surfaceChange)
-            }
-        )
-        try source.start()
-        displaySource = source
-
-        startBoundaryTimer()
-    }
-
-    public func waitUntilFirstFrame(timeoutSeconds: TimeInterval = 15) throws {
-        let alreadyReady = try writerQueue.sync {
-            if let firstError {
-                throw firstError
-            }
-            return firstFrameReady
-        }
-        if alreadyReady {
-            return
-        }
-        if firstFrameSemaphore.wait(timeout: .now() + timeoutSeconds) == .timedOut {
-            throw RecorderError.make(20, "Timed out waiting for first frame")
-        }
-        try writerQueue.sync {
-            if let firstError {
-                throw firstError
-            }
-            if !firstFrameReady {
-                throw RecorderError.make(21, "Recorder stopped before first frame")
-            }
-        }
-    }
-
-    public func simulatorStopReason() -> String? {
-        callbackQueue.sync {
-            simulatorStoppedReason
-        }
-    }
-
-    @discardableResult
-    public func stop() throws -> RecordingManifest {
-        callbackQueue.sync {
-            stopped = true
-            boundaryTimer?.cancel()
-            boundaryTimer = nil
-            displaySource?.stop()
-            displaySource = nil
-        }
-
-        return try writerQueue.sync {
-            if let firstError {
-                throw firstError
-            }
-            guard let writer, let input, let outputWriter else {
-                let error = RecorderError.make(22, "No frames were captured")
-                firstError = error
-                signalFirstFrameReadyIfNeeded()
-                throw error
-            }
-            try appendTailFrameIfNeeded(finalPTS: monotonicClock.elapsedTime())
-            input.markAsFinished()
-            let semaphore = DispatchSemaphore(value: 0)
-            writer.finishWriting {
-                semaphore.signal()
-            }
-            if semaphore.wait(timeout: .now() + 60) == .timedOut {
-                throw RecorderError.make(23, "Timed out finishing AVAssetWriter")
-            }
-            if writer.status == .failed {
-                throw writer.error ?? RecorderError.make(24, "AVAssetWriter failed")
-            }
-            if let error = outputWriter.error {
-                throw error
-            }
-            guard let firstAcceptedWallClock else {
-                throw RecorderError.make(25, "Missing first frame wall-clock timestamp")
-            }
-            return try outputWriter.writeManifest(
-                configuration: configuration,
-                firstFrameWallClock: firstAcceptedWallClock
-            )
-        }
-    }
-
-    private enum CaptureReason {
-        case callback
-        case surfaceChange
-        case boundary
-        case healthProbe
-    }
-
-    private func validateConfiguration() throws {
-        guard !configuration.deviceUDID.isEmpty else {
-            throw RecorderError.make(30, "deviceUDID must not be empty")
-        }
-        guard configuration.fps > 0, configuration.fps <= 120 else {
-            throw RecorderError.make(31, "fps must be between 1 and 120")
-        }
-        guard configuration.bitrate > 0 else {
-            throw RecorderError.make(32, "bitrate must be positive")
-        }
-        guard configuration.segmentDuration >= 0 else {
-            throw RecorderError.make(33, "segmentDuration must be non-negative")
-        }
-        guard configuration.maxPendingFrames > 0 else {
-            throw RecorderError.make(34, "maxPendingFrames must be positive")
-        }
-    }
-
-    private func startBoundaryTimer() {
-        let timer = DispatchSource.makeTimerSource(queue: callbackQueue)
-        timer.schedule(deadline: .now() + 1, repeating: 1, leeway: .milliseconds(100))
-        timer.setEventHandler { [weak self] in
-            self?.probeSimulatorState()
-            self?.probeFramebufferHealth()
-            self?.appendBoundaryFrameIfNeeded()
-        }
-        timer.resume()
-        boundaryTimer = timer
-    }
-
-    private func appendBoundaryFrameIfNeeded() {
-        if stopped {
-            return
-        }
-        guard configuration.segmentDuration > 0 else {
-            return
-        }
-        writerQueue.sync {
-            guard firstAcceptedCaptureTime != nil else {
-                return
-            }
-            let currentPTSSeconds = CMTimeGetSeconds(
-                normalizedPresentationTime(for: monotonicClock.elapsedTime()))
-            guard currentPTSSeconds >= nextBoundaryElapsed else {
-                return
-            }
-            let boundary = nextBoundaryElapsed
-            guard let lastPTS else {
-                return
-            }
-
-            do {
-                if CMTimeGetSeconds(lastPTS) < boundary {
-                    let boundaryPTS = CMTime(seconds: boundary, preferredTimescale: 1_000_000_000)
-                    guard try appendHeldFrame(at: boundaryPTS) else {
-                        return
-                    }
-                }
-                nextBoundaryElapsed = boundary + configuration.segmentDuration
-            } catch {
-                firstError = error
-                signalFirstFrameReadyIfNeeded()
-            }
-        }
-    }
-
-    private func captureFrame(force: Bool, reason: CaptureReason) {
-        if stopped {
-            return
-        }
-        if reason == .callback {
-            lastFrameCallbackElapsed = monotonicClock.elapsedSeconds()
-        }
-        guard let snapshot = displaySource?.surfaceSnapshot() else {
-            return
-        }
-        let surface = snapshot.surface
-        let surfaceWidth = snapshot.width
-        let surfaceHeight = snapshot.height
-        guard surfaceWidth > 0, surfaceHeight > 0 else {
-            return
-        }
-
-        let seed = snapshot.seed
-        let matchesLastAppendedSeed = writerQueue.sync { lastSeed == seed }
-        if !force, matchesLastAppendedSeed {
-            return
-        }
-
-        guard reservePendingFrame() else {
-            return
-        }
-
-        let capturedAt = monotonicClock.elapsedTime()
-        let capturedAtWallClock = Date()
-        do {
-            let pixelBuffer = try copySurfaceToOwnedPixelBuffer(
-                surface,
-                width: surfaceWidth,
-                height: surfaceHeight
-            )
-            appendOwned(
-                pixelBuffer: pixelBuffer,
-                seed: seed,
-                capturedAt: capturedAt,
-                capturedAtWallClock: capturedAtWallClock
-            )
-        } catch {
-            releasePendingFrame()
-            writerQueue.async {
-                self.firstError = error
-                self.signalFirstFrameReadyIfNeeded()
-            }
-        }
-    }
-
-    private func probeFramebufferHealth() {
-        guard !stopped, let displaySource else {
-            return
-        }
-        let elapsed = monotonicClock.elapsedSeconds()
-        if !isFirstFrameReady(),
-            elapsed - lastFirstFrameRewireElapsed >= Self.firstFrameRewireInterval
-        {
-            lastFirstFrameRewireElapsed = elapsed
-            rewireFramebuffer()
-            captureFrame(force: true, reason: .healthProbe)
-            return
-        }
-
-        guard let snapshot = displaySource.surfaceSnapshot(),
-            snapshot.width > 0,
-            snapshot.height > 0
-        else {
-            rewireFramebuffer()
-            return
-        }
-
-        let observedSeed = snapshot.seed
-        let lastAppendedSeed = writerQueue.sync { lastSeed }
-        guard let lastAppendedSeed, observedSeed != lastAppendedSeed else {
-            return
-        }
-
-        let lastCallback = lastFrameCallbackElapsed ?? 0
-        if elapsed - lastCallback >= Self.callbackStalenessTimeout {
-            captureFrame(force: false, reason: .healthProbe)
-            rewireFramebuffer()
-        }
-    }
-
-    private func probeSimulatorState() {
-        guard !stopped, simulatorStoppedReason == nil else {
-            return
-        }
-        let state = SimulatorDeviceLookup.stateString(udid: configuration.deviceUDID) ?? "missing"
-        guard state != "Booted" else {
-            return
-        }
-        simulatorStoppedReason = state
-        let error = RecorderError.make(26, "Simulator stopped before first frame (state: \(state))")
-        writerQueue.async {
-            if self.firstError == nil, !self.firstFrameReady {
-                self.firstError = error
-                self.signalFirstFrameReadyIfNeeded()
-            }
-        }
-        let onSimulatorStopped = onSimulatorStopped
-        eventQueue.async {
-            onSimulatorStopped?(state)
-        }
-    }
-
-    private func rewireFramebuffer() {
-        guard let displaySource else {
-            return
-        }
-        do {
-            try displaySource.rewireFramebuffer()
-        } catch {
-            writerQueue.async {
-                self.firstError = error
-                self.signalFirstFrameReadyIfNeeded()
-            }
-        }
-    }
-
-    private func reservePendingFrame() -> Bool {
-        pendingLock.lock()
-        defer { pendingLock.unlock() }
-        if pendingFrames >= configuration.maxPendingFrames {
-            return false
-        }
-        pendingFrames += 1
-        return true
-    }
-
-    private func releasePendingFrame() {
-        pendingLock.lock()
-        pendingFrames = max(0, pendingFrames - 1)
-        pendingLock.unlock()
-    }
-
-    private func copySurfaceToOwnedPixelBuffer(
-        _ surface: IOSurface,
-        width: Int,
-        height: Int
-    ) throws -> CVPixelBuffer {
-        let pool = try writerQueue.sync {
-            if let firstError {
-                throw firstError
-            }
-            if writer == nil {
-                try startWriter(width: width, height: height)
-            }
-            guard let pool = adaptor?.pixelBufferPool else {
-                throw RecorderError.make(40, "AVAssetWriter pixel buffer pool is unavailable")
-            }
-            return pool
-        }
-
-        var output: CVPixelBuffer?
-        let status = CVPixelBufferPoolCreatePixelBuffer(kCFAllocatorDefault, pool, &output)
-        guard status == kCVReturnSuccess, let destination = output else {
-            throw RecorderError.make(41, "Failed to allocate pixel buffer from pool: \(status)")
-        }
-
-        let destinationLockStatus = CVPixelBufferLockBaseAddress(destination, [])
-        guard destinationLockStatus == kCVReturnSuccess else {
-            throw RecorderError.make(50, "Failed to lock pixel buffer: \(destinationLockStatus)")
-        }
-        let surfaceLockStatus = IOSurfaceLock(surface, .readOnly, nil)
-        guard surfaceLockStatus == KERN_SUCCESS else {
-            CVPixelBufferUnlockBaseAddress(destination, [])
-            throw RecorderError.make(49, "Failed to lock IOSurface: \(surfaceLockStatus)")
-        }
-        defer {
-            IOSurfaceUnlock(surface, .readOnly, nil)
-            CVPixelBufferUnlockBaseAddress(destination, [])
-        }
-
-        guard let destinationAddress = CVPixelBufferGetBaseAddress(destination) else {
-            throw RecorderError.make(42, "Pixel buffer has no base address")
-        }
-        let sourceAddress = IOSurfaceGetBaseAddress(surface)
-        let sourceStride = IOSurfaceGetBytesPerRow(surface)
-        let destinationStride = CVPixelBufferGetBytesPerRow(destination)
-        let copyWidth = min(width, IOSurfaceGetWidth(surface), CVPixelBufferGetWidth(destination))
-        let copyHeight = min(
-            height, IOSurfaceGetHeight(surface), CVPixelBufferGetHeight(destination))
-        let copyBytes = min(copyWidth * 4, sourceStride, destinationStride)
-        for row in 0..<copyHeight {
-            memcpy(
-                destinationAddress.advanced(by: row * destinationStride),
-                sourceAddress.advanced(by: row * sourceStride),
-                copyBytes
-            )
-        }
-        return destination
-    }
-
-    private func appendOwned(
-        pixelBuffer: CVPixelBuffer,
-        seed: UInt32,
-        capturedAt: CMTime,
-        capturedAtWallClock: Date
-    ) {
-        writerQueue.async {
-            defer { self.releasePendingFrame() }
-            if self.firstError != nil {
-                return
-            }
-            do {
-                try self.appendOnWriterQueue(
-                    pixelBuffer: pixelBuffer,
-                    seed: seed,
-                    capturedAt: capturedAt,
-                    capturedAtWallClock: capturedAtWallClock
-                )
-            } catch {
-                self.firstError = error
-                self.signalFirstFrameReadyIfNeeded()
-            }
-        }
-    }
-
-    private func appendOnWriterQueue(
-        pixelBuffer: CVPixelBuffer,
-        seed: UInt32,
-        capturedAt: CMTime,
-        capturedAtWallClock: Date
-    ) throws {
-        guard let writer, let input, let adaptor else {
-            throw RecorderError.make(43, "AVAssetWriter is not initialized")
-        }
-        let isFirstFrame = firstAcceptedCaptureTime == nil
-        let pts = isFirstFrame ? .zero : normalizedPresentationTime(for: capturedAt)
-        if let lastPTS, CMTimeCompare(pts, lastPTS) <= 0 {
-            return
-        }
-        guard try appendPendingBoundaryFrames(before: pts) else {
-            return
-        }
-        guard input.isReadyForMoreMediaData else {
-            return
-        }
-        if !adaptor.append(pixelBuffer, withPresentationTime: pts) {
-            throw writer.error ?? RecorderError.make(44, "Failed to append pixel buffer")
-        }
-        if isFirstFrame {
-            firstAcceptedCaptureTime = capturedAt
-            firstAcceptedWallClock = capturedAtWallClock
-        }
-        lastPTS = pts
-        lastSeed = seed
-        lastAppendedPixelBuffer = pixelBuffer
-        signalFirstFrameReadyIfNeeded()
-    }
-
-    private func appendTailFrameIfNeeded(finalPTS: CMTime) throws {
-        let deadline = Date().addingTimeInterval(5)
-        while true {
-            if try appendTailFrame(finalPTS: finalPTS) {
-                return
-            }
-            if Date() >= deadline {
-                throw RecorderError.make(45, "Timed out waiting to append tail frame")
-            }
-            Thread.sleep(forTimeInterval: 0.05)
-        }
-    }
-
-    private func appendTailFrame(finalPTS: CMTime) throws -> Bool {
-        let pts = normalizedPresentationTime(for: finalPTS)
-        return try appendHeldFrame(at: pts)
-    }
-
-    private func appendPendingBoundaryFrames(before pts: CMTime) throws -> Bool {
-        guard configuration.segmentDuration > 0,
-            firstAcceptedCaptureTime != nil
-        else {
-            return true
-        }
-
-        while CMTimeGetSeconds(pts) > nextBoundaryElapsed {
-            if let lastPTS, CMTimeGetSeconds(lastPTS) >= nextBoundaryElapsed {
-                nextBoundaryElapsed += configuration.segmentDuration
-                continue
-            }
-
-            let boundaryPTS = CMTime(
-                seconds: nextBoundaryElapsed, preferredTimescale: 1_000_000_000)
-            guard try appendHeldFrame(at: boundaryPTS) else {
-                return false
-            }
-            nextBoundaryElapsed += configuration.segmentDuration
-        }
-        return true
-    }
-
-    private func appendHeldFrame(at pts: CMTime) throws -> Bool {
-        guard let input,
-            let adaptor,
-            let lastPTS,
-            let lastAppendedPixelBuffer
-        else {
-            return true
-        }
-        if CMTimeCompare(pts, lastPTS) <= 0 {
-            return true
-        }
-        guard input.isReadyForMoreMediaData else {
-            return false
-        }
-        if !adaptor.append(lastAppendedPixelBuffer, withPresentationTime: pts) {
-            throw writer?.error ?? RecorderError.make(45, "Failed to append held frame")
-        }
-        self.lastPTS = pts
-        return true
-    }
-
-    private func normalizedPresentationTime(for capturedAt: CMTime) -> CMTime {
-        let start = firstAcceptedCaptureTime ?? capturedAt
-        return CMTimeSubtract(capturedAt, start)
-    }
-
-    private func startWriter(width: Int, height: Int) throws {
-        guard let outputWriter else {
-            throw RecorderError.make(46, "Missing output writer")
-        }
-
-        let writer: AVAssetWriter
-        if configuration.segmentDuration > 0 {
-            writer = AVAssetWriter(contentType: .mpeg4Movie)
-            writer.delegate = outputWriter
-            writer.outputFileTypeProfile = .mpeg4AppleHLS
-            writer.preferredOutputSegmentInterval = CMTime(
-                seconds: configuration.segmentDuration,
-                preferredTimescale: 600
-            )
-        } else {
-            writer = try AVAssetWriter(outputURL: outputWriter.singleRecordingURL, fileType: .mp4)
-        }
-        writer.initialSegmentStartTime = .zero
-
-        let input = AVAssetWriterInput(
-            mediaType: .video,
-            outputSettings: assetWriterSettings(width: width, height: height)
-        )
-        input.expectsMediaDataInRealTime = true
-
-        let attributes: [String: Any] = [
-            kCVPixelBufferPixelFormatTypeKey as String: kCVPixelFormatType_32BGRA,
-            kCVPixelBufferWidthKey as String: width,
-            kCVPixelBufferHeightKey as String: height,
-            kCVPixelBufferIOSurfacePropertiesKey as String: [:],
-        ]
-        let adaptor = AVAssetWriterInputPixelBufferAdaptor(
-            assetWriterInput: input,
-            sourcePixelBufferAttributes: attributes
-        )
-
-        guard writer.canAdd(input) else {
-            throw RecorderError.make(47, "AVAssetWriter cannot add video input")
-        }
-        writer.add(input)
-        guard writer.startWriting() else {
-            throw writer.error ?? RecorderError.make(48, "AVAssetWriter failed to start")
-        }
-        writer.startSession(atSourceTime: .zero)
-
-        self.writer = writer
-        self.input = input
-        self.adaptor = adaptor
-    }
-
-    private func assetWriterSettings(width: Int, height: Int) -> [String: Any] {
-        let codecType: AVVideoCodecType = configuration.codec == .hevc ? .hevc : .h264
-        var compression: [String: Any] = [
-            AVVideoAverageBitRateKey: configuration.bitrate,
-            AVVideoExpectedSourceFrameRateKey: configuration.fps,
-            AVVideoAllowFrameReorderingKey: true,
-        ]
-        if configuration.segmentDuration > 0 {
-            compression[AVVideoMaxKeyFrameIntervalKey] = max(
-                1,
-                Int((configuration.segmentDuration * Double(configuration.fps)).rounded())
-            )
-        }
-        if configuration.codec == .h264 {
-            compression[AVVideoProfileLevelKey] = AVVideoProfileLevelH264HighAutoLevel
-        }
-        return [
-            AVVideoCodecKey: codecType,
-            AVVideoWidthKey: width,
-            AVVideoHeightKey: height,
-            AVVideoCompressionPropertiesKey: compression,
-        ]
-    }
-
-    private func signalFirstFrameReadyIfNeeded() {
-        if firstFrameReady {
-            return
-        }
-        firstFrameReady = true
-        firstFrameSemaphore.signal()
-    }
-
-    private func isFirstFrameReady() -> Bool {
-        writerQueue.sync {
-            firstFrameReady
-        }
-    }
-}

packages/build-tools/resources/record-sim/Sources/RecordSim/Utilities.swift

@@ -1,60 +0,0 @@
-import CoreMedia
-import Foundation
-
-enum RecorderError {
-    static func make(_ code: Int, _ message: String) -> NSError {
-        NSError(
-            domain: "RecordSim",
-            code: code,
-            userInfo: [NSLocalizedDescriptionKey: message]
-        )
-    }
-}
-
-extension JSONEncoder {
-    static var prettySorted: JSONEncoder {
-        let encoder = JSONEncoder()
-        encoder.outputFormatting = [.prettyPrinted, .sortedKeys]
-        return encoder
-    }
-}
-
-func timeSeconds(_ time: CMTime) -> Double? {
-    guard time.isValid, !time.isIndefinite, !time.isNegativeInfinity, !time.isPositiveInfinity else {
-        return nil
-    }
-    return CMTimeGetSeconds(time)
-}
-
-func iso8601(_ date: Date) -> String {
-    let formatter = ISO8601DateFormatter()
-    formatter.formatOptions = [.withInternetDateTime, .withFractionalSeconds]
-    formatter.timeZone = TimeZone(secondsFromGMT: 0)
-    return formatter.string(from: date)
-}
-
-func unixMs(_ date: Date) -> Int64 {
-    Int64((date.timeIntervalSince1970 * 1000).rounded())
-}
-
-struct MonotonicClock {
-    private static let timescale: CMTimeScale = 1_000_000_000
-
-    let startedAtUptimeNanoseconds: UInt64
-
-    init() {
-        startedAtUptimeNanoseconds = DispatchTime.now().uptimeNanoseconds
-    }
-
-    func elapsedSeconds() -> TimeInterval {
-        TimeInterval(elapsedNanoseconds()) / TimeInterval(Self.timescale)
-    }
-
-    func elapsedTime() -> CMTime {
-        CMTime(value: CMTimeValue(elapsedNanoseconds()), timescale: Self.timescale)
-    }
-
-    private func elapsedNanoseconds() -> UInt64 {
-        DispatchTime.now().uptimeNanoseconds - startedAtUptimeNanoseconds
-    }
-}

packages/build-tools/resources/record-sim/Sources/record-sim/main.swift

@@ -1,143 +0,0 @@
-import Foundation
-import RecordSim
-
-struct CLIOptions {
-    var udid: String?
-    var output: String?
-    var segmentDuration: TimeInterval = 120
-    var fps = 30
-    var bitrate = 30_000_000
-    var codec: RecorderCodec = .h264
-}
-
-private var stopRequested: CInt = 0
-private var simulatorStopped: CInt = 0
-
-private func handleStopSignal(_: CInt) {
-    stopRequested = 1
-}
-
-private func isStopRequested() -> Bool {
-    stopRequested != 0 || simulatorStopped != 0
-}
-
-func usage() -> String {
-    """
-    Usage:
-      record-sim --udid <UDID> --output <session-dir> [options]
-
-    Options:
-      --segment-duration <seconds>  Target fMP4 media segment duration. Use 0 for one MP4. Default: 120
-      --fps <fps>                   Expected source frame rate. Default: 30
-      --bitrate <bits/sec>          AVAssetWriter average bitrate. Default: 30000000
-      --codec <h264|hevc>           Video codec. Default: h264
-      -h, --help                    Show this help
-    """
-}
-
-func parseOptions(_ args: [String]) throws -> CLIOptions {
-    var options = CLIOptions()
-    var i = 0
-
-    func next(_ flag: String) throws -> String {
-        i += 1
-        guard i < args.count else {
-            throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "Missing value for \(flag)"])
-        }
-        return args[i]
-    }
-
-    while i < args.count {
-        let arg = args[i]
-        switch arg {
-        case "--udid", "-u":
-            options.udid = try next(arg)
-        case "--output", "--output-dir", "--out", "-o":
-            options.output = try next(arg)
-        case "--segment-duration":
-            options.segmentDuration = Double(try next(arg)) ?? -1
-        case "--fps":
-            options.fps = Int(try next(arg)) ?? 0
-        case "--bitrate":
-            options.bitrate = Int(try next(arg)) ?? 0
-        case "--codec":
-            let raw = try next(arg)
-            guard let codec = RecorderCodec(rawValue: raw) else {
-                throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "--codec must be h264 or hevc"])
-            }
-            options.codec = codec
-        case "--help", "-h":
-            print(usage())
-            exit(0)
-        default:
-            throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "Unknown argument: \(arg)"])
-        }
-        i += 1
-    }
-
-    guard options.udid != nil else {
-        throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "Missing required --udid"])
-    }
-    guard options.output != nil else {
-        throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "Missing required --output"])
-    }
-    guard options.segmentDuration >= 0 else {
-        throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "--segment-duration must be non-negative"])
-    }
-    guard options.fps > 0, options.fps <= 120 else {
-        throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "--fps must be between 1 and 120"])
-    }
-    guard options.bitrate > 0 else {
-        throw NSError(domain: "record-sim", code: 2, userInfo: [NSLocalizedDescriptionKey: "--bitrate must be positive"])
-    }
-    return options
-}
-
-do {
-    signal(SIGINT, handleStopSignal)
-    signal(SIGTERM, handleStopSignal)
-
-    let options = try parseOptions(Array(CommandLine.arguments.dropFirst()))
-    let configuration = SimulatorRecordingConfiguration(
-        deviceUDID: options.udid!,
-        outputDirectory: URL(fileURLWithPath: options.output!),
-        fps: options.fps,
-        bitrate: options.bitrate,
-        codec: options.codec,
-        segmentDuration: options.segmentDuration
-    )
-
-    let recorder = SimulatorRecorder(configuration: configuration)
-    recorder.onSimulatorStopped = { state in
-        simulatorStopped = 1
-        fputs("[record-sim] simulator stopped state=\(state); finalizing recording\n", stderr)
-    }
-    recorder.onSegment = { segment in
-        switch segment.kind {
-        case .initialization:
-            fputs("[record-sim] init \(segment.relativePath) bytes=\(segment.byteCount)\n", stderr)
-        case .media:
-            let duration = segment.durationSeconds ?? 0
-            fputs(String(format: "[record-sim] segment %@ duration=%.3fs bytes=%d\n", segment.relativePath, duration, segment.byteCount), stderr)
-        }
-    }
-
-    try recorder.start()
-    try recorder.waitUntilFirstFrame()
-    fputs("[record-sim] recording -> \(options.output!)\n", stderr)
-
-    while !isStopRequested() {
-        Thread.sleep(forTimeInterval: 0.1)
-    }
-
-    let manifest = try recorder.stop()
-    if let recording = manifest.recording {
-        fputs("[record-sim] done recording=\(recording)\n", stderr)
-    } else {
-        fputs("[record-sim] done segments=\(manifest.segments.count)\n", stderr)
-    }
-    fputs("[record-sim] manifest \(URL(fileURLWithPath: options.output!).appendingPathComponent("session.json").path)\n", stderr)
-} catch {
-    fputs("error: \(error.localizedDescription)\n", stderr)
-    exit(1)
-}

packages/build-tools/src/__tests__/context.test.ts

@@ -19,12 +19,10 @@ jest.mock('fs-extra');
 jest.mock('../datadog', () => ({
   Datadog: {
     distribution: jest.fn(),
-    log: jest.fn(),
   },
 }));
 
 const datadogDistributionMock = jest.mocked(Datadog.distribution);
-const datadogLogMock = jest.mocked(Datadog.log);
 
 describe('BuildContext', () => {
   beforeEach(() => {
@@ -141,77 +139,6 @@ describe('BuildContext', () => {
     });
   });
 
-  it('overwrites existing environment variables when updating env', async () => {
-    await vol.promises.mkdir('/workingdir/eas-environment-secrets/', { recursive: true });
-
-    const ctx = new BuildContext(
-      {
-        triggeredBy: BuildTrigger.GIT_BASED_INTEGRATION,
-        secrets: {},
-      } as Job,
-      {
-        env: {
-          __API_SERVER_URL: 'http://api.expo.test',
-          EXISTING_ENV: 'old-value',
-          REMOVED_ENV: 'old-value',
-        },
-        workingdir: '/workingdir',
-        logger: createMockLogger(),
-        logBuffer: { getLogs: () => [], getPhaseLogs: () => [] },
-        uploadArtifact: jest.fn(),
-      }
-    );
-
-    ctx.updateEnv({
-      EXISTING_ENV: 'new-value',
-      REMOVED_ENV: undefined,
-      NEW_ENV: 'new-env-value',
-    });
-
-    expect(ctx.env.EXISTING_ENV).toBe('new-value');
-    expect(ctx.env.REMOVED_ENV).toBeUndefined();
-    expect(ctx.env.NEW_ENV).toBe('new-env-value');
-    const logMessage = datadogLogMock.mock.calls[0][0];
-    expect(logMessage).toContain('BuildContext.updateEnv merge order produced different env');
-    expect(logMessage).toContain('different_env_names=');
-    expect(logMessage).toContain('EXISTING_ENV');
-    expect(logMessage).toContain('REMOVED_ENV');
-    expect(JSON.stringify(datadogLogMock.mock.calls)).not.toContain('old-value');
-    expect(JSON.stringify(datadogLogMock.mock.calls)).not.toContain('new-value');
-    expect(JSON.stringify(datadogLogMock.mock.calls)).not.toContain('new-env-value');
-  });
-
-  it('logs when updateEnv merge order produces the same env without values', async () => {
-    await vol.promises.mkdir('/workingdir/eas-environment-secrets/', { recursive: true });
-
-    const ctx = new BuildContext(
-      {
-        triggeredBy: BuildTrigger.GIT_BASED_INTEGRATION,
-        secrets: {},
-      } as Job,
-      {
-        env: {
-          __API_SERVER_URL: 'http://api.expo.test',
-          EXISTING_ENV: 'same-value',
-        },
-        workingdir: '/workingdir',
-        logger: createMockLogger(),
-        logBuffer: { getLogs: () => [], getPhaseLogs: () => [] },
-        uploadArtifact: jest.fn(),
-      }
-    );
-
-    ctx.updateEnv({
-      EXISTING_ENV: 'same-value',
-      UNSET_ENV: undefined,
-    });
-
-    expect(datadogLogMock).toHaveBeenCalledWith(
-      'BuildContext.updateEnv merge order produced same env'
-    );
-    expect(JSON.stringify(datadogLogMock.mock.calls)).not.toContain('same-value');
-  });
-
   it('emits build phase duration metrics for successful build phases', async () => {
     const ctx = createTestBuildContext({ platform: Platform.IOS });
 

packages/build-tools/src/__tests__/generic.test.ts

@@ -111,37 +111,6 @@ describe(runGenericJobAsync, () => {
     expect(rejected).toBe(true);
   });
 
-  it('passes the job hooks into the steps parser', async () => {
-    // @expo/steps is fully mocked here — assert the plumbing only (real
-    // insertion behavior is covered by the parser's own tests).
-    const mockWorkflow = { executeAsync: jest.fn().mockResolvedValue(undefined) };
-    (StepsConfigParser as unknown as jest.Mock).mockImplementation(() => ({
-      parseAsync: jest.fn().mockResolvedValue(mockWorkflow),
-    }));
-
-    mockCtx.job.hooks = { before_install_node_modules: [{ run: 'echo hi' }] };
-    await runGenericJobAsync(mockCtx);
-
-    expect(StepsConfigParser).toHaveBeenCalledWith(
-      expect.anything(),
-      expect.objectContaining({ hooks: mockCtx.job.hooks })
-    );
-  });
-
-  it('passes hooks: undefined into the steps parser for a hook-less job (dormancy)', async () => {
-    const mockWorkflow = { executeAsync: jest.fn().mockResolvedValue(undefined) };
-    (StepsConfigParser as unknown as jest.Mock).mockImplementation(() => ({
-      parseAsync: jest.fn().mockResolvedValue(mockWorkflow),
-    }));
-
-    await runGenericJobAsync(mockCtx);
-
-    expect(StepsConfigParser).toHaveBeenCalledWith(
-      expect.anything(),
-      expect.objectContaining({ hooks: undefined })
-    );
-  });
-
   it('throws before workflow execution when expoApiV2BaseUrl is missing', async () => {
     mockCtx.expoApiV2BaseUrl = undefined;
 

packages/build-tools/src/__tests__/runtimeSettings.test.ts

@@ -14,6 +14,10 @@ jest.mock('../sentry', () => ({
 }));
 
 describe('runtimeSettings', () => {
+  const logger = {
+    info: jest.fn(),
+    warn: jest.fn(),
+  };
   const originalCacheUrls = {
     EAS_NPM_CACHE_URL: process.env.EAS_NPM_CACHE_URL,
     EAS_NODEJS_CACHE_URL: process.env.EAS_NODEJS_CACHE_URL,
@@ -26,6 +30,8 @@ describe('runtimeSettings', () => {
     jest.mocked(fetch).mockReset();
     jest.restoreAllMocks();
     jest.mocked(Sentry.capture).mockReset();
+    logger.info.mockReset();
+    logger.warn.mockReset();
     restoreEnv('EAS_NPM_CACHE_URL', originalCacheUrls.EAS_NPM_CACHE_URL);
     restoreEnv('EAS_NODEJS_CACHE_URL', originalCacheUrls.EAS_NODEJS_CACHE_URL);
     restoreEnv('EAS_MAVEN_CACHE_URL', originalCacheUrls.EAS_MAVEN_CACHE_URL);
@@ -35,16 +41,24 @@ describe('runtimeSettings', () => {
 
   beforeEach(async () => {
     jest.mocked(fetch).mockResolvedValue(response({}));
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
     jest.mocked(fetch).mockReset();
+    logger.info.mockReset();
+    logger.warn.mockReset();
   });
 
   it('fetches runtime settings from the staging and production buckets', async () => {
     jest.mocked(fetch).mockResolvedValue(response({}));
 
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
-    await RuntimeSettings.loadAsync({ environment: 'production' });
-    await RuntimeSettings.loadAsync({ environment: 'test' });
+    await RuntimeSettings.loadAsync({
+      environment: 'staging',
+      logger: logger as any,
+      cacheUrlFallbacks: {
+        npm: 'https://fallback-npm.example',
+      },
+    });
+    await RuntimeSettings.loadAsync({ environment: 'production', logger: logger as any });
+    await RuntimeSettings.loadAsync({ environment: 'test', logger: logger as any });
 
     expect(fetch).toHaveBeenNthCalledWith(
       1,
@@ -67,11 +81,12 @@ describe('runtimeSettings', () => {
     process.env.EAS_NPM_CACHE_URL = 'https://npm.example';
     jest.mocked(fetch).mockResolvedValue(response({}, 404));
 
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
 
     mockProcessPlatform('linux');
     expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
     expect(RuntimeSettings.isUsingIosPrecompiledModulesEnabled()).toBe(false);
+    expect(logger.warn).toHaveBeenCalled();
     expect(Sentry.capture).toHaveBeenCalledWith('Failed to fetch worker runtime settings', {
       extras: {
         status: 404,
@@ -88,12 +103,13 @@ describe('runtimeSettings', () => {
       .mockResolvedValueOnce(response({ caches: { linux: { npm: true } } }))
       .mockResolvedValueOnce(response({ iosPrecompiledModules: 'enabled' }));
 
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
 
     mockProcessPlatform('linux');
     expect(RuntimeSettings.getNpmCacheUrl()).toBe('https://npm.example');
     expect(RuntimeSettings.isUsingIosPrecompiledModulesEnabled()).toBe(false);
+    expect(logger.warn).toHaveBeenCalled();
     expect(Sentry.capture).toHaveBeenCalledWith(
       'Failed to load worker runtime settings',
       expect.any(Error),
@@ -122,7 +138,7 @@ describe('runtimeSettings', () => {
       })
     );
 
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
 
     mockProcessPlatform('linux');
     expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
@@ -147,7 +163,7 @@ describe('runtimeSettings', () => {
       })
     );
 
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
 
     mockProcessPlatform('linux');
     expect(RuntimeSettings.getMavenCacheUrl()).toBe('https://maven.example');
@@ -156,13 +172,50 @@ describe('runtimeSettings', () => {
     expect(RuntimeSettings.getCocoapodsCacheUrl()).toBe('https://pods.example');
   });
 
-  it('uses job environment flags to enable cache URLs from worker environment variables', async () => {
-    process.env.EAS_NPM_CACHE_URL = 'https://npm.example';
+  it('uses cache URL fallbacks when enabled cache environment variables are not set', async () => {
+    jest.mocked(fetch).mockResolvedValue(
+      response({
+        caches: {
+          linux: { npm: true, nodejs: true, maven: true },
+          darwin: { cocoapods: true },
+        },
+      })
+    );
 
     await RuntimeSettings.loadAsync({
-      environment: 'test',
-      env: {
-        EAS_USE_NPM_CACHE: '1',
+      environment: 'staging',
+      logger: logger as any,
+      cacheUrlFallbacks: {
+        npm: 'https://fallback-npm.example',
+        nodejs: 'https://fallback-node.example',
+        maven: 'https://fallback-maven.example',
+        cocoapods: 'https://fallback-pods.example',
+      },
+    });
+
+    mockProcessPlatform('linux');
+    expect(RuntimeSettings.getNpmCacheUrl()).toBe('https://fallback-npm.example');
+    expect(RuntimeSettings.getNodeJsCacheUrl()).toBe('https://fallback-node.example');
+    expect(RuntimeSettings.getMavenCacheUrl()).toBe('https://fallback-maven.example');
+    mockProcessPlatform('darwin');
+    expect(RuntimeSettings.getCocoapodsCacheUrl()).toBe('https://fallback-pods.example');
+  });
+
+  it('prefers cache URL environment variables over fallbacks', async () => {
+    process.env.EAS_NPM_CACHE_URL = 'https://npm.example';
+    jest.mocked(fetch).mockResolvedValue(
+      response({
+        caches: {
+          linux: { npm: true },
+        },
+      })
+    );
+
+    await RuntimeSettings.loadAsync({
+      environment: 'staging',
+      logger: logger as any,
+      cacheUrlFallbacks: {
+        npm: 'https://fallback-npm.example',
       },
     });
 
@@ -170,41 +223,20 @@ describe('runtimeSettings', () => {
     expect(RuntimeSettings.getNpmCacheUrl()).toBe('https://npm.example');
   });
 
-  it('returns null when job env enables cache but worker env var is empty', async () => {
-    process.env.EAS_NPM_CACHE_URL = '';
-
-    await RuntimeSettings.loadAsync({
-      environment: 'test',
-      env: {
-        EAS_USE_NPM_CACHE: '1',
-      },
-    });
-
-    mockProcessPlatform('linux');
-    expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
-  });
-
-  it('does not use cache URLs from the job environment', async () => {
-    await RuntimeSettings.loadAsync({
-      environment: 'test',
-      env: {
-        EAS_USE_NPM_CACHE: '1',
-        EAS_NPM_CACHE_URL: 'https://job-npm.example',
-      },
-    });
-
-    mockProcessPlatform('linux');
-    expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
-  });
-
-  it('does not enable cache when runtime settings explicitly disable it, even with job env flag', async () => {
-    process.env.EAS_NPM_CACHE_URL = 'https://npm.example';
-    jest.mocked(fetch).mockResolvedValue(response({ caches: { linux: { npm: false } } }));
+  it('does not use cache URL fallbacks when runtime settings disable caches', async () => {
+    jest.mocked(fetch).mockResolvedValue(
+      response({
+        caches: {
+          linux: { npm: false },
+        },
+      })
+    );
 
     await RuntimeSettings.loadAsync({
       environment: 'staging',
-      env: {
-        EAS_USE_NPM_CACHE: '1',
+      logger: logger as any,
+      cacheUrlFallbacks: {
+        npm: 'https://fallback-npm.example',
       },
     });
 
@@ -212,61 +244,17 @@ describe('runtimeSettings', () => {
     expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
   });
 
-  it('disables cache when EAS_BUILD_DISABLE_NPM_CACHE is set', async () => {
-    process.env.EAS_NPM_CACHE_URL = 'https://npm.example';
+  it('clears cache URL fallbacks when loading without them', async () => {
     jest.mocked(fetch).mockResolvedValue(response({ caches: { linux: { npm: true } } }));
 
     await RuntimeSettings.loadAsync({
       environment: 'staging',
-      env: {
-        EAS_BUILD_DISABLE_NPM_CACHE: '1',
-      },
-    });
-
-    mockProcessPlatform('linux');
-    expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
-  });
-
-  it('disables cache when EAS_BUILD_DISABLE_MAVEN_CACHE is set', async () => {
-    process.env.EAS_MAVEN_CACHE_URL = 'https://maven.example';
-    jest.mocked(fetch).mockResolvedValue(response({ caches: { linux: { maven: true } } }));
-
-    await RuntimeSettings.loadAsync({
-      environment: 'staging',
-      env: {
-        EAS_BUILD_DISABLE_MAVEN_CACHE: '1',
-      },
-    });
-
-    mockProcessPlatform('linux');
-    expect(RuntimeSettings.getMavenCacheUrl()).toBeNull();
-  });
-
-  it('disables cache when EAS_BUILD_DISABLE_COCOAPODS_CACHE is set', async () => {
-    process.env.EAS_COCOAPODS_CACHE_URL = 'https://pods.example';
-    jest.mocked(fetch).mockResolvedValue(response({ caches: { darwin: { cocoapods: true } } }));
-
-    await RuntimeSettings.loadAsync({
-      environment: 'staging',
-      env: {
-        EAS_BUILD_DISABLE_COCOAPODS_CACHE: '1',
-      },
-    });
-
-    mockProcessPlatform('darwin');
-    expect(RuntimeSettings.getCocoapodsCacheUrl()).toBeNull();
-  });
-
-  it('allows job environment flags to disable remotely enabled cache URLs', async () => {
-    process.env.EAS_NPM_CACHE_URL = 'https://npm.example';
-    jest.mocked(fetch).mockResolvedValue(response({ caches: { linux: { npm: true } } }));
-
-    await RuntimeSettings.loadAsync({
-      environment: 'staging',
-      env: {
-        EAS_USE_NPM_CACHE: '0',
+      logger: logger as any,
+      cacheUrlFallbacks: {
+        npm: 'https://fallback-npm.example',
       },
     });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
 
     mockProcessPlatform('linux');
     expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
@@ -287,7 +275,7 @@ describe('runtimeSettings', () => {
     jest.mocked(fetch).mockResolvedValue(response({ caches: { linux: { npm: true } } }));
     mockProcessPlatform('darwin');
 
-    await RuntimeSettings.loadAsync({ environment: 'staging' });
+    await RuntimeSettings.loadAsync({ environment: 'staging', logger: logger as any });
 
     expect(RuntimeSettings.getNpmCacheUrl()).toBeNull();
     expect(Sentry.capture).toHaveBeenCalledWith(

packages/build-tools/src/__tests__/utils/context.ts

@@ -10,10 +10,7 @@ import os from 'os';
 import path from 'path';
 import { v4 as uuidv4 } from 'uuid';
 
-import { createTestIosJob } from './job';
 import { createMockLogger } from './logger';
-import { BuildContext } from '../../context';
-import { CustomBuildContext } from '../../customBuildContext';
 
 export class MockContextProvider implements ExternalBuildContextProvider {
   private _env: BuildStepEnv = {};
@@ -75,19 +72,6 @@ export function createStepContextMock({
   });
 }
 
-export function createCustomBuildContextMock(): CustomBuildContext {
-  const ctx = new BuildContext(createTestIosJob({}), {
-    env: {
-      __API_SERVER_URL: 'http://api.expo.test',
-    },
-    logBuffer: { getLogs: () => [], getPhaseLogs: () => [] },
-    logger: createMockLogger(),
-    uploadArtifact: jest.fn(),
-    workingdir: '',
-  });
-  return new CustomBuildContext(ctx);
-}
-
 export function createGlobalContextMock({
   logger,
   skipCleanup,

packages/build-tools/src/android/gradle.ts

@@ -1,10 +1,12 @@
 import { Android, Env, Job, Platform } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
-import spawn from '@expo/turtle-spawn';
+import spawn, { SpawnPromise, SpawnResult } from '@expo/turtle-spawn';
+import assert from 'assert';
 import fs from 'fs-extra';
 import path from 'path';
 
 import { BuildContext } from '../context';
+import { getParentAndDescendantProcessPidsAsync } from '../utils/processes';
 
 export async function ensureLFLineEndingsInGradlewScript<TJob extends Job>(
   ctx: BuildContext<TJob>
@@ -29,19 +31,10 @@ export async function runGradleCommand(
   logger.info(`Running 'gradlew ${gradleCommand}' in ${androidDir}`);
   await fs.chmod(path.join(androidDir, 'gradlew'), 0o755);
   const verboseFlag = ctx.env['EAS_VERBOSE'] === '1' ? '--info' : '';
-  const shouldResetOOMScore =
-    ctx.env.EAS_BUILD_RUNNER === 'eas-build' && process.platform === 'linux';
 
-  await spawn(
+  const spawnPromise = spawn(
     'bash',
-    [
-      '-c',
-      getGradleShellCommand({
-        gradleCommand,
-        oomScoreAdj: shouldResetOOMScore ? 0 : undefined,
-        verboseFlag,
-      }),
-    ],
+    ['-c', `./gradlew ${gradleCommand} --profile ${verboseFlag}`],
     {
       cwd: androidDir,
       logger,
@@ -60,20 +53,42 @@ export async function runGradleCommand(
       },
     }
   );
+  if (ctx.env.EAS_BUILD_RUNNER === 'eas-build' && process.platform === 'linux') {
+    adjustOOMScore(spawnPromise, logger);
+  }
+
+  await spawnPromise;
 }
 
-export function getGradleShellCommand({
-  gradleCommand,
-  oomScoreAdj,
-  verboseFlag,
-}: {
-  gradleCommand: string;
-  oomScoreAdj?: number;
-  verboseFlag: string;
-}): string {
-  const oomScoreAdjPrefix =
-    oomScoreAdj === undefined ? '' : `echo ${oomScoreAdj} > /proc/$$/oom_score_adj || true; `;
-  return `${oomScoreAdjPrefix}exec ./gradlew ${gradleCommand} --profile ${verboseFlag}`;
+/**
+ * OOM Killer sometimes kills worker server while build is exceeding memory limits.
+ * `oom_score_adj` is a value between -1000 and 1000 and it defaults to 0.
+ * It defines which process is more likely to get killed (higher value more likely).
+ *
+ * This function sets oom_score_adj for Gradle process and all its child processes.
+ */
+function adjustOOMScore(spawnPromise: SpawnPromise<SpawnResult>, logger: bunyan): void {
+  setTimeout(
+    async () => {
+      try {
+        assert(spawnPromise.child.pid);
+        const pids = await getParentAndDescendantProcessPidsAsync(spawnPromise.child.pid);
+        await Promise.all(
+          pids.map(async (pid: number) => {
+            // Value 800 is just a guess here. It's probably higher than most other
+            // process. I didn't want to set it any higher, because I'm not sure if OOM Killer
+            // can start killing processes when there is still enough memory left.
+            const oomScoreOverride = 800;
+            await fs.writeFile(`/proc/${pid}/oom_score_adj`, `${oomScoreOverride}\n`);
+          })
+        );
+      } catch (err: any) {
+        logger.debug({ err, stderr: err?.stderr }, 'Failed to override oom_score_adj');
+      }
+    },
+    // Wait 20 seconds to make sure all child processes are started
+    20000
+  );
 }
 
 // Version envs should be set at the beginning of the build, but when building

packages/build-tools/src/builders/__tests__/custom.test.ts

@@ -7,7 +7,6 @@ import { createMockLogger } from '../../__tests__/utils/logger';
 import { prepareProjectSourcesAsync } from '../../common/projectSources';
 import { BuildContext } from '../../context';
 import { CustomBuildContext } from '../../customBuildContext';
-import { Datadog } from '../../datadog';
 import { findAndUploadXcodeBuildLogsAsync } from '../../ios/xcodeBuildLogs';
 import { runCustomBuildAsync } from '../custom';
 
@@ -18,7 +17,6 @@ const findAndUploadXcodeBuildLogsAsyncMock = jest.mocked(findAndUploadXcodeBuild
 
 describe(runCustomBuildAsync, () => {
   let ctx: BuildContext<BuildJob>;
-  const datadogLogSpy = jest.spyOn(Datadog, 'log');
 
   beforeEach(() => {
     const job = createTestIosJob();
@@ -29,24 +27,10 @@ describe(runCustomBuildAsync, () => {
       vol.fromJSON(
         {
           'test.yaml': `
-          functions:
-            test_function:
-              name: Test function
-              path: ./custom-function
-              shell: /bin/zsh
-              supported_platforms:
-                - darwin
-                - linux
-              inputs:
-                - name
-                - profile
-              outputs:
-                - artifact_path
           build:
             steps:
               - eas/checkout
           `,
-          'custom-function/package.json': '{}',
         },
         '/workingdir/temporary-custom-build'
       );
@@ -93,21 +77,6 @@ describe(runCustomBuildAsync, () => {
     expect(prepareProjectSourcesAsync).toHaveBeenCalledTimes(2);
   });
 
-  it('reports user-provided custom functions when parsing the custom build config', async () => {
-    await runCustomBuildAsync(ctx);
-
-    expect(datadogLogSpy).toHaveBeenCalledWith('Custom build saw user-provided function', {
-      event: 'custom_build_user_provided_function',
-      custom_function_id: 'test_function',
-      custom_function_input_count: '2',
-      custom_function_module_path: '/workingdir/temporary-custom-build/custom-function',
-      custom_function_name: 'Test function',
-      custom_function_output_count: '1',
-      custom_function_shell: '/bin/zsh',
-      custom_function_supported_runtime_platforms: 'darwin,linux',
-    });
-  });
-
   it('awaits drainPendingMetricUploads after workflow execution', async () => {
     let resolveDrain!: () => void;
     const drainSpy = jest

packages/build-tools/src/builders/custom.ts

@@ -1,11 +1,5 @@
 import { BuildJob, BuildPhase, BuildTrigger, Ios, Platform } from '@expo/eas-build-job';
-import {
-  BuildConfigParser,
-  BuildStepGlobalContext,
-  BuildWorkflow,
-  StepsConfigParser,
-  errors,
-} from '@expo/steps';
+import { BuildConfigParser, BuildStepGlobalContext, StepsConfigParser, errors } from '@expo/steps';
 import assert from 'assert';
 import fs from 'fs/promises';
 import nullthrows from 'nullthrows';
@@ -15,7 +9,6 @@ import { resolveEnvFromBuildProfileAsync } from '../common/easBuildInternal';
 import { prepareProjectSourcesAsync } from '../common/projectSources';
 import { Artifacts, BuildContext } from '../context';
 import { CustomBuildContext } from '../customBuildContext';
-import { Datadog } from '../datadog';
 import { findAndUploadXcodeBuildLogsAsync } from '../ios/xcodeBuildLogs';
 import { getEasFunctionGroups } from '../steps/easFunctionGroups';
 import { getEasFunctions } from '../steps/easFunctions';
@@ -63,7 +56,6 @@ export async function runCustomBuildAsync(ctx: BuildContext<BuildJob>): Promise<
         externalFunctions: easFunctions,
         externalFunctionGroups: easFunctionGroups,
         steps: ctx.job.steps,
-        hooks: ctx.job.hooks,
       })
     : new BuildConfigParser(globalContext, {
         externalFunctions: easFunctions,
@@ -89,7 +81,6 @@ export async function runCustomBuildAsync(ctx: BuildContext<BuildJob>): Promise<
       throw parseError;
     }
   });
-  logUserProvidedCustomFunctions(workflow);
   try {
     try {
       await workflow.executeAsync();
@@ -112,26 +103,3 @@ export async function runCustomBuildAsync(ctx: BuildContext<BuildJob>): Promise<
 
   return ctx.artifacts;
 }
-
-function logUserProvidedCustomFunctions(workflow: BuildWorkflow): void {
-  for (const buildFunction of Object.values(workflow.buildFunctions)) {
-    if (!buildFunction.customFunctionModulePath) {
-      continue;
-    }
-    Datadog.log('Custom build saw user-provided function', {
-      event: 'custom_build_user_provided_function',
-      custom_function_id: buildFunction.getFullId(),
-      custom_function_module_path: buildFunction.customFunctionModulePath,
-      custom_function_input_count: String(buildFunction.inputProviders?.length ?? 0),
-      custom_function_output_count: String(buildFunction.outputProviders?.length ?? 0),
-      ...(buildFunction.name ? { custom_function_name: buildFunction.name } : {}),
-      ...(buildFunction.shell ? { custom_function_shell: buildFunction.shell } : {}),
-      ...(buildFunction.supportedRuntimePlatforms
-        ? {
-            custom_function_supported_runtime_platforms:
-              buildFunction.supportedRuntimePlatforms.join(','),
-          }
-        : {}),
-    });
-  }
-}

packages/build-tools/src/common/__tests__/installDependencies.test.ts

@@ -1,256 +0,0 @@
-import spawn, { SpawnPromise, SpawnResult } from '@expo/turtle-spawn';
-
-import { createMockLogger } from '../../__tests__/utils/logger';
-import { Sentry } from '../../sentry';
-import { PackageManager } from '../../utils/packageManager';
-import { installDependenciesWithNpmCacheFallbackAsync } from '../installDependencies';
-
-jest.mock('@expo/turtle-spawn', () => jest.fn());
-jest.mock('../../sentry', () => ({
-  Sentry: {
-    capture: jest.fn(),
-  },
-}));
-
-describe(installDependenciesWithNpmCacheFallbackAsync, () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
-  it('retries without NPM_CONFIG_REGISTRY when npm cache install fails', async () => {
-    const logger = createMockLogger();
-    const npmCacheUrl = 'http://npm.staging.caches.eas-build.internal';
-    const error = Object.assign(
-      new Error('npm install --include=dev exited with non-zero code: 1'),
-      {
-        status: 1,
-        signal: null,
-        stdout: '',
-        stderr: `npm error request to ${npmCacheUrl}/left-pad failed, reason: getaddrinfo ENOTFOUND npm.staging.caches.eas-build.internal`,
-      }
-    );
-
-    jest
-      .mocked(spawn)
-      .mockReturnValueOnce(createSpawnPromise(Promise.reject(error)))
-      .mockReturnValueOnce(createSpawnPromise(Promise.resolve(createSpawnResult())));
-
-    await installDependenciesWithNpmCacheFallbackAsync({
-      packageManager: PackageManager.NPM,
-      env: {
-        EAS_VERBOSE: '1',
-        EAS_USE_NPM_CACHE: '1',
-        EAS_BUILD_NPM_CACHE_URL: npmCacheUrl,
-      },
-      logger,
-      cwd: '/tmp/build',
-      useFrozenLockfile: false,
-    });
-
-    expect(spawn).toHaveBeenCalledTimes(2);
-    expect(spawn).toHaveBeenNthCalledWith(1, 'npm', ['install', '--include=dev', '--verbose'], {
-      cwd: '/tmp/build',
-      logger,
-      infoCallbackFn: undefined,
-      lineTransformer: expect.any(Function),
-      env: {
-        EAS_VERBOSE: '1',
-        EAS_USE_NPM_CACHE: '1',
-        EAS_BUILD_NPM_CACHE_URL: npmCacheUrl,
-        NPM_CONFIG_REGISTRY: npmCacheUrl,
-      },
-    });
-    expect(spawn).toHaveBeenNthCalledWith(2, 'npm', ['install', '--include=dev', '--verbose'], {
-      cwd: '/tmp/build',
-      logger,
-      infoCallbackFn: undefined,
-      env: {
-        EAS_VERBOSE: '1',
-        EAS_USE_NPM_CACHE: '1',
-        EAS_BUILD_NPM_CACHE_URL: npmCacheUrl,
-      },
-    });
-    expect(logger.warn).toHaveBeenCalledWith(
-      `Failed to install dependencies using the npm cache registry (${npmCacheUrl}). Retrying without the npm cache registry.`
-    );
-    expect(Sentry.capture).toHaveBeenCalledWith(
-      expect.objectContaining({
-        message: 'Failed to install dependencies using npm cache registry',
-        name: 'NpmCacheRegistryInstallError',
-      }),
-      {
-        level: 'warning',
-        tags: {
-          packageManager: 'npm',
-        },
-        extras: {
-          cwd: '/tmp/build',
-          npmCacheUrl,
-          useFrozenLockfile: false,
-          originalErrorMessage: 'npm install --include=dev exited with non-zero code: 1',
-          status: 1,
-          signal: null,
-        },
-      }
-    );
-  });
-
-  it('reports non-fatal npm cache registry errors from successful installs', async () => {
-    const logger = createMockLogger();
-    const npmCacheUrl = 'http://npm.staging.caches.eas-build.internal';
-    const auditErrorLine = `npm verbose audit error FetchError: request to ${npmCacheUrl}/-/npm/v1/security/advisories/bulk failed, reason: getaddrinfo ENOTFOUND npm.staging.caches.eas-build.internal`;
-
-    jest.mocked(spawn).mockImplementationOnce((_command, _args, options: any) => {
-      options.lineTransformer(auditErrorLine);
-      options.lineTransformer(
-        `npm http cache left-pad@${npmCacheUrl}/left-pad/-/left-pad-1.3.0.tgz 0ms (cache hit)`
-      );
-      return createSpawnPromise(Promise.resolve(createSpawnResult()));
-    });
-
-    await installDependenciesWithNpmCacheFallbackAsync({
-      packageManager: PackageManager.NPM,
-      env: {
-        EAS_USE_NPM_CACHE: '1',
-        EAS_BUILD_NPM_CACHE_URL: npmCacheUrl,
-      },
-      logger,
-      cwd: '/tmp/build',
-      useFrozenLockfile: false,
-    });
-
-    expect(spawn).toHaveBeenCalledTimes(1);
-    expect(Sentry.capture).toHaveBeenCalledWith(
-      expect.objectContaining({
-        message: 'Non-fatal npm cache registry error during dependency install',
-        name: 'NpmCacheRegistryNonFatalError',
-      }),
-      {
-        level: 'warning',
-        tags: {
-          packageManager: 'npm',
-        },
-        extras: {
-          cwd: '/tmp/build',
-          npmCacheUrl,
-          useFrozenLockfile: false,
-          firstErrorLine: auditErrorLine,
-          errorLineCount: 1,
-        },
-      }
-    );
-  });
-
-  it('does not retry when install failure does not reference npm cache registry', async () => {
-    const logger = createMockLogger();
-    const error = Object.assign(
-      new Error('npm install --include=dev exited with non-zero code: 1'),
-      {
-        status: 1,
-        signal: null,
-        stdout: '',
-        stderr: 'npm error command sh -c node postinstall.js',
-      }
-    );
-
-    jest.mocked(spawn).mockReturnValueOnce(createSpawnPromise(Promise.reject(error)));
-
-    await expect(
-      installDependenciesWithNpmCacheFallbackAsync({
-        packageManager: PackageManager.NPM,
-        env: {
-          EAS_USE_NPM_CACHE: '1',
-          EAS_BUILD_NPM_CACHE_URL: 'http://npm.staging.caches.eas-build.internal',
-        },
-        logger,
-        cwd: '/tmp/build',
-        useFrozenLockfile: false,
-      })
-    ).rejects.toThrow(error);
-
-    expect(spawn).toHaveBeenCalledTimes(1);
-    expect(Sentry.capture).not.toHaveBeenCalled();
-  });
-
-  it('does not retry when the npm cache is not enabled', async () => {
-    const logger = createMockLogger();
-    const npmCacheUrl = 'http://npm.staging.caches.eas-build.internal';
-    const error = Object.assign(
-      new Error('npm install --include=dev exited with non-zero code: 1'),
-      {
-        status: 1,
-        signal: null,
-        stdout: '',
-        stderr: `npm error request to ${npmCacheUrl}/left-pad failed, reason: getaddrinfo ENOTFOUND npm.staging.caches.eas-build.internal`,
-      }
-    );
-
-    jest.mocked(spawn).mockReturnValueOnce(createSpawnPromise(Promise.reject(error)));
-
-    await expect(
-      installDependenciesWithNpmCacheFallbackAsync({
-        packageManager: PackageManager.NPM,
-        env: {},
-        logger,
-        cwd: '/tmp/build',
-        useFrozenLockfile: false,
-      })
-    ).rejects.toThrow(error);
-
-    expect(spawn).toHaveBeenCalledTimes(1);
-    expect(Sentry.capture).not.toHaveBeenCalled();
-  });
-
-  it('installs through the npm cache registry without retrying when the cache install succeeds', async () => {
-    const logger = createMockLogger();
-    const npmCacheUrl = 'http://npm.staging.caches.eas-build.internal';
-
-    jest
-      .mocked(spawn)
-      .mockReturnValueOnce(createSpawnPromise(Promise.resolve(createSpawnResult())));
-
-    await installDependenciesWithNpmCacheFallbackAsync({
-      packageManager: PackageManager.NPM,
-      env: {
-        EAS_USE_NPM_CACHE: '1',
-        EAS_BUILD_NPM_CACHE_URL: npmCacheUrl,
-      },
-      logger,
-      cwd: '/tmp/build',
-      useFrozenLockfile: false,
-    });
-
-    expect(spawn).toHaveBeenCalledTimes(1);
-    expect(spawn).toHaveBeenCalledWith('npm', ['install', '--include=dev'], {
-      cwd: '/tmp/build',
-      logger,
-      infoCallbackFn: undefined,
-      lineTransformer: expect.any(Function),
-      env: {
-        EAS_USE_NPM_CACHE: '1',
-        EAS_BUILD_NPM_CACHE_URL: npmCacheUrl,
-        NPM_CONFIG_REGISTRY: npmCacheUrl,
-      },
-    });
-    expect(Sentry.capture).not.toHaveBeenCalled();
-  });
-});
-
-function createSpawnPromise(result: Promise<SpawnResult>): SpawnPromise<SpawnResult> {
-  return Object.assign(result, {
-    child: {
-      pid: 123,
-    },
-  }) as SpawnPromise<SpawnResult>;
-}
-
-function createSpawnResult(): SpawnResult {
-  return {
-    pid: 123,
-    output: ['', ''],
-    stdout: '',
-    stderr: '',
-    status: 0,
-    signal: null,
-  };
-}

packages/build-tools/src/common/installDependencies.ts

@@ -1,9 +1,8 @@
-import { Job, SystemError } from '@expo/eas-build-job';
+import { Job } from '@expo/eas-build-job';
 import spawn, { SpawnOptions, SpawnPromise, SpawnResult } from '@expo/turtle-spawn';
 import path from 'path';
 
 import { BuildContext } from '../context';
-import { Sentry } from '../sentry';
 import { PackageManager, findPackagerRootDir } from '../utils/packageManager';
 import { isUsingModernYarnVersion } from '../utils/project';
 
@@ -12,7 +11,6 @@ export async function installDependenciesAsync({
   env,
   logger,
   infoCallbackFn,
-  lineTransformer,
   cwd,
   useFrozenLockfile,
 }: {
@@ -21,7 +19,6 @@ export async function installDependenciesAsync({
   cwd: string;
   logger: Exclude<SpawnOptions['logger'], undefined>;
   infoCallbackFn?: SpawnOptions['infoCallbackFn'];
-  lineTransformer?: SpawnOptions['lineTransformer'];
   useFrozenLockfile: boolean;
 }): Promise<{ spawnPromise: SpawnPromise<SpawnResult> }> {
   let args: string[];
@@ -72,108 +69,11 @@ export async function installDependenciesAsync({
       cwd,
       logger,
       infoCallbackFn,
-      lineTransformer,
       env,
     }),
   };
 }
 
-export async function installDependenciesWithNpmCacheFallbackAsync({
-  packageManager,
-  env,
-  logger,
-  infoCallbackFn,
-  cwd,
-  useFrozenLockfile,
-}: {
-  packageManager: PackageManager;
-  env: Record<string, string | undefined>;
-  cwd: string;
-  logger: Exclude<SpawnOptions['logger'], undefined>;
-  infoCallbackFn?: SpawnOptions['infoCallbackFn'];
-  useFrozenLockfile: boolean;
-}): Promise<void> {
-  const npmCacheUrl = env.EAS_BUILD_NPM_CACHE_URL;
-
-  if (!npmCacheUrl) {
-    await (
-      await installDependenciesAsync({
-        packageManager,
-        env,
-        logger,
-        infoCallbackFn,
-        cwd,
-        useFrozenLockfile,
-      })
-    ).spawnPromise;
-    return;
-  }
-
-  logger.info(`Installing dependencies using the npm cache registry (${npmCacheUrl}).`);
-
-  let firstErrorLine: string | undefined;
-  let errorLineCount = 0;
-
-  try {
-    await (
-      await installDependenciesAsync({
-        packageManager,
-        env: { ...env, NPM_CONFIG_REGISTRY: npmCacheUrl },
-        logger,
-        infoCallbackFn,
-        lineTransformer: (line: string) => {
-          if (isNpmCacheRegistryErrorLine(line, npmCacheUrl)) {
-            firstErrorLine ??= line;
-            errorLineCount += 1;
-          }
-          return line;
-        },
-        cwd,
-        useFrozenLockfile,
-      })
-    ).spawnPromise;
-
-    if (firstErrorLine) {
-      Sentry.capture(new NpmCacheRegistryNonFatalError(), {
-        level: 'warning',
-        tags: { packageManager },
-        extras: { cwd, npmCacheUrl, useFrozenLockfile, firstErrorLine, errorLineCount },
-      });
-    }
-  } catch (err: unknown) {
-    if (!isNpmCacheInstallFailure(err, npmCacheUrl)) {
-      throw err;
-    }
-
-    logger.warn(
-      `Failed to install dependencies using the npm cache registry (${npmCacheUrl}). Retrying without the npm cache registry.`
-    );
-    Sentry.capture(new NpmCacheRegistryInstallError(err), {
-      level: 'warning',
-      tags: { packageManager },
-      extras: {
-        cwd,
-        npmCacheUrl,
-        useFrozenLockfile,
-        originalErrorMessage: err instanceof Error ? err.message : String(err),
-        status: err instanceof Error ? (err as any).status : undefined,
-        signal: err instanceof Error ? (err as any).signal : undefined,
-      },
-    });
-
-    await (
-      await installDependenciesAsync({
-        packageManager,
-        env,
-        logger,
-        infoCallbackFn,
-        cwd,
-        useFrozenLockfile,
-      })
-    ).spawnPromise;
-  }
-}
-
 export function resolvePackagerDir(ctx: BuildContext<Job>): string {
   const packagerRunDir = findPackagerRootDir(ctx.getReactNativeProjectDirectory());
   if (packagerRunDir !== ctx.getReactNativeProjectDirectory()) {
@@ -187,36 +87,3 @@ export function resolvePackagerDir(ctx: BuildContext<Job>): string {
   }
   return packagerRunDir;
 }
-
-function isNpmCacheInstallFailure(err: unknown, npmCacheUrl: string): boolean {
-  return getErrorOutput(err).includes(npmCacheUrl);
-}
-
-function isNpmCacheRegistryErrorLine(line: string, npmCacheUrl: string): boolean {
-  return (
-    line.includes(npmCacheUrl) &&
-    /(?:error|failed|ENOTFOUND|ECONN|ETIMEDOUT|EAI_AGAIN|FetchError)/i.test(line)
-  );
-}
-
-function getErrorOutput(err: unknown): string {
-  if (!(err instanceof Error)) {
-    return '';
-  }
-  const { stdout, stderr } = err as Error & { stdout?: string; stderr?: string };
-  return [stdout, stderr].filter(Boolean).join('\n');
-}
-
-class NpmCacheRegistryNonFatalError extends SystemError {
-  override name = 'NpmCacheRegistryNonFatalError';
-  constructor() {
-    super('Non-fatal npm cache registry error during dependency install');
-  }
-}
-
-class NpmCacheRegistryInstallError extends SystemError {
-  override name = 'NpmCacheRegistryInstallError';
-  constructor(cause: unknown) {
-    super('Failed to install dependencies using npm cache registry', { cause });
-  }
-}

packages/build-tools/src/common/prebuild.ts

@@ -2,10 +2,7 @@ import { BuildJob } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
 import { SpawnOptions } from '@expo/turtle-spawn';
 
-import {
-  installDependenciesWithNpmCacheFallbackAsync,
-  resolvePackagerDir,
-} from './installDependencies';
+import { installDependenciesAsync, resolvePackagerDir } from './installDependencies';
 import { BuildContext } from '../context';
 import { runExpoCliCommand } from '../utils/project';
 
@@ -33,14 +30,17 @@ export async function prebuildAsync<TJob extends BuildJob>(
     options: spawnOptions,
     packageManager: ctx.packageManager,
   });
-  await installDependenciesWithNpmCacheFallbackAsync({
-    packageManager: ctx.packageManager,
-    env: ctx.env,
-    logger,
-    cwd: resolvePackagerDir(ctx),
-    // prebuild sometimes modifies package.json, so we don't want to use frozen lockfile
-    useFrozenLockfile: false,
-  });
+  const installDependenciesSpawnPromise = (
+    await installDependenciesAsync({
+      packageManager: ctx.packageManager,
+      env: ctx.env,
+      logger,
+      cwd: resolvePackagerDir(ctx),
+      // prebuild sometimes modifies package.json, so we don't want to use frozen lockfile
+      useFrozenLockfile: false,
+    })
+  ).spawnPromise;
+  await installDependenciesSpawnPromise;
 }
 
 function getPrebuildCommandArgs<TJob extends BuildJob>(ctx: BuildContext<TJob>): string[] {

packages/build-tools/src/common/projectSources.ts

@@ -233,7 +233,7 @@ async function uploadProjectMetadataAsync(
         }
       `),
       {
-        buildId: nullthrows(ctx.env.EAS_BUILD_ID, 'EAS_BUILD_ID is not set'),
+        buildId: ctx.env.EAS_BUILD_ID,
         projectMetadataFile: {
           type: 'GCS',
           bucketKey: uploadSession.bucketKey,

packages/build-tools/src/context.ts

@@ -45,7 +45,6 @@ export type ArtifactToUpload =
       type: GenericArtifactType;
       name: string;
       paths: string[];
-      metadata?: Record<string, unknown>;
     };
 
 export interface BuildContextOptions {
@@ -63,7 +62,7 @@ export interface BuildContextOptions {
   reportError?: (
     msg: string,
     err?: Error,
-    options?: { tags?: Record<string, string>; extras?: Record<string, string | undefined> }
+    options?: { tags?: Record<string, string>; extras?: Record<string, string> }
   ) => void;
   skipNativeBuild?: boolean;
   metadata?: Metadata;
@@ -72,41 +71,6 @@ export interface BuildContextOptions {
 
 export class SkipNativeBuildError extends Error {}
 
-function logEnvComparison({
-  oldMergeOrderEnv,
-  newMergeOrderEnv,
-}: {
-  oldMergeOrderEnv: Env;
-  newMergeOrderEnv: Env;
-}): void {
-  const envNames = new Set([...Object.keys(oldMergeOrderEnv), ...Object.keys(newMergeOrderEnv)]);
-  const sameEnvNames: string[] = [];
-  const differentEnvNames: string[] = [];
-
-  for (const key of envNames) {
-    const hasOldValue = key in oldMergeOrderEnv;
-    const hasNewValue = key in newMergeOrderEnv;
-    if (hasOldValue === hasNewValue && oldMergeOrderEnv[key] === newMergeOrderEnv[key]) {
-      sameEnvNames.push(key);
-    } else {
-      differentEnvNames.push(key);
-    }
-  }
-
-  if (differentEnvNames.length === 0) {
-    Datadog.log('BuildContext.updateEnv merge order produced same env');
-    return;
-  }
-
-  Datadog.log(
-    `BuildContext.updateEnv merge order produced different env: compared_env_count=${
-      envNames.size
-    } different_env_count=${differentEnvNames.length} different_env_names=${differentEnvNames.join(
-      ','
-    )} same_env_count=${sameEnvNames.length} same_env_names=${sameEnvNames.join(',')}`
-  );
-}
-
 export class BuildContext<TJob extends Job = Job> {
   public readonly workingdir: string;
   public logger: bunyan;
@@ -115,7 +79,7 @@ export class BuildContext<TJob extends Job = Job> {
   public readonly reportError?: (
     msg: string,
     err?: Error,
-    options?: { tags?: Record<string, string>; extras?: Record<string, string | undefined> }
+    options?: { tags?: Record<string, string>; extras?: Record<string, string> }
   ) => void;
   public readonly skipNativeBuild?: boolean;
   public readonly expoApiV2BaseUrl?: string;
@@ -282,24 +246,11 @@ export class BuildContext<TJob extends Job = Job> {
         'Updating environment variables is only allowed when build was triggered by a git-based integration.'
       );
     }
-
-    const oldMergeOrderEnv: Env = {
+    this._env = {
       ...env,
       ...this._env,
       __EAS_BUILD_ENVS_DIR: this.buildEnvsDirectory,
     };
-    const newMergeOrderEnv: Env = {
-      ...this._env,
-      ...env,
-      __EAS_BUILD_ENVS_DIR: this.buildEnvsDirectory,
-    };
-
-    logEnvComparison({
-      oldMergeOrderEnv,
-      newMergeOrderEnv,
-    });
-
-    this._env = newMergeOrderEnv;
     this._env.PATH = this._env.PATH
       ? [this.buildExecutablesDirectory, this._env.PATH].join(':')
       : this.buildExecutablesDirectory;

packages/build-tools/src/customBuildContext.ts

@@ -9,18 +9,12 @@ import {
   StaticJobInterpolationContext,
 } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
-import {
-  BuildRuntimePlatform,
-  ExternalBuildContextProvider,
-  StepMetric,
-  WorkflowHookMetric,
-} from '@expo/steps';
+import { BuildRuntimePlatform, ExternalBuildContextProvider, StepMetric } from '@expo/steps';
 import { Client } from '@urql/core';
 import assert from 'assert';
 import path from 'path';
 
 import { ArtifactToUpload, BuildContext } from './context';
-import { reportWorkflowHookMetricToDatadog } from './utils/hookMetrics';
 import { uploadStepMetricsToWwwAsync } from './utils/stepMetrics';
 
 const platformToBuildRuntimePlatform: Record<Platform, BuildRuntimePlatform> = {
@@ -171,10 +165,6 @@ export class CustomBuildContext<TJob extends Job = Job> implements ExternalBuild
     this.pendingMetricUploads.push(p);
   }
 
-  public reportWorkflowHookMetric(metric: WorkflowHookMetric): void {
-    reportWorkflowHookMetricToDatadog(metric);
-  }
-
   public async drainPendingMetricUploads(): Promise<void> {
     await Promise.allSettled(this.pendingMetricUploads);
   }

packages/build-tools/src/generic.ts

@@ -47,7 +47,6 @@ export async function runGenericJobAsync(
     externalFunctions: getEasFunctions(customBuildCtx),
     externalFunctionGroups: getEasFunctionGroups(customBuildCtx),
     steps: ctx.job.steps,
-    hooks: ctx.job.hooks,
   });
 
   const workflow = await ctx.runBuildPhase(BuildPhase.PARSE_CUSTOM_WORKFLOW_CONFIG, async () => {

packages/build-tools/src/ios/fastlane.ts

@@ -93,7 +93,7 @@ export async function runFastlane(
     cwd,
   }: {
     logger?: bunyan;
-    env?: Env;
+    env?: Record<string, string>;
     cwd?: string;
   } = {}
 ): Promise<SpawnResult> {

packages/build-tools/src/runtimeSettings.ts

@@ -1,4 +1,4 @@
-import { Env } from '@expo/eas-build-job';
+import { type bunyan } from '@expo/logger';
 import fetch from 'node-fetch';
 import { z } from 'zod';
 
@@ -26,18 +26,27 @@ const RuntimeSettingsSchema = z
   })
   .partial();
 
+type CacheUrlFallbacks = {
+  npm?: string | null;
+  nodejs?: string | null;
+  maven?: string | null;
+  cocoapods?: string | null;
+};
+
 let runtimeSettings: z.infer<typeof RuntimeSettingsSchema> = {};
-let runtimeEnvironment: Env = {};
+let cacheUrlFallbacks: CacheUrlFallbacks = {};
 
 export namespace RuntimeSettings {
   export async function loadAsync({
     environment,
-    env: nextRuntimeEnvironment = {},
+    logger,
+    cacheUrlFallbacks: nextCacheUrlFallbacks = {},
   }: {
     environment: string;
-    env?: Env;
+    logger: bunyan;
+    cacheUrlFallbacks?: CacheUrlFallbacks;
   }): Promise<void> {
-    runtimeEnvironment = nextRuntimeEnvironment;
+    cacheUrlFallbacks = nextCacheUrlFallbacks;
     const url = ENVIRONMENT_TO_RUNTIME_SETTINGS_URL[environment];
     if (!url) {
       return;
@@ -49,6 +58,10 @@ export namespace RuntimeSettings {
       });
 
       if (!response.ok) {
+        logger.warn(
+          { url, status: response.status },
+          'Failed to fetch worker runtime settings, using defaults'
+        );
         Sentry.capture('Failed to fetch worker runtime settings', {
           extras: { url, status: response.status },
           level: 'warning',
@@ -71,7 +84,9 @@ export namespace RuntimeSettings {
           }
         );
       }
+      logger.info({ url, settings: runtimeSettings }, 'Loaded worker runtime settings');
     } catch (err) {
+      logger.warn({ err, url }, 'Failed to load worker runtime settings, using defaults');
       Sentry.capture(
         'Failed to load worker runtime settings',
         err instanceof Error ? err : new Error(String(err)),
@@ -88,51 +103,26 @@ export namespace RuntimeSettings {
   }
 
   export function getNpmCacheUrl(): string | null {
-    if (runtimeEnvironment['EAS_BUILD_DISABLE_NPM_CACHE'] === '1') {
-      return null;
-    }
-    const runtimeEnabled = runtimeSettings.caches?.[process.platform]?.npm;
-    if (runtimeEnabled === false) {
-      return null;
-    }
-    const envOverride = runtimeEnvironment['EAS_USE_NPM_CACHE'];
-    const enabled = envOverride === '1' || (envOverride !== '0' && runtimeEnabled);
-    return enabled ? process.env.EAS_NPM_CACHE_URL || null : null;
+    return runtimeSettings.caches?.[process.platform]?.npm
+      ? process.env.EAS_NPM_CACHE_URL || cacheUrlFallbacks.npm || null
+      : null;
   }
 
   export function getNodeJsCacheUrl(): string | null {
-    const runtimeEnabled = runtimeSettings.caches?.[process.platform]?.nodejs;
-    if (runtimeEnabled === false) {
-      return null;
-    }
-    const envOverride = runtimeEnvironment['EAS_USE_NODEJS_CACHE'];
-    const enabled = envOverride === '1' || (envOverride !== '0' && runtimeEnabled);
-    return enabled ? process.env.EAS_NODEJS_CACHE_URL || null : null;
+    return runtimeSettings.caches?.[process.platform]?.nodejs
+      ? process.env.EAS_NODEJS_CACHE_URL || cacheUrlFallbacks.nodejs || null
+      : null;
   }
 
   export function getMavenCacheUrl(): string | null {
-    if (runtimeEnvironment['EAS_BUILD_DISABLE_MAVEN_CACHE'] === '1') {
-      return null;
-    }
-    const runtimeEnabled = runtimeSettings.caches?.[process.platform]?.maven;
-    if (runtimeEnabled === false) {
-      return null;
-    }
-    const envOverride = runtimeEnvironment['EAS_USE_MAVEN_CACHE'];
-    const enabled = envOverride === '1' || (envOverride !== '0' && runtimeEnabled);
-    return enabled ? process.env.EAS_MAVEN_CACHE_URL || null : null;
+    return runtimeSettings.caches?.[process.platform]?.maven
+      ? process.env.EAS_MAVEN_CACHE_URL || cacheUrlFallbacks.maven || null
+      : null;
   }
 
   export function getCocoapodsCacheUrl(): string | null {
-    if (runtimeEnvironment['EAS_BUILD_DISABLE_COCOAPODS_CACHE'] === '1') {
-      return null;
-    }
-    const runtimeEnabled = runtimeSettings.caches?.[process.platform]?.cocoapods;
-    if (runtimeEnabled === false) {
-      return null;
-    }
-    const envOverride = runtimeEnvironment['EAS_USE_COCOAPODS_CACHE'];
-    const enabled = envOverride === '1' || (envOverride !== '0' && runtimeEnabled);
-    return enabled ? process.env.EAS_COCOAPODS_CACHE_URL || null : null;
+    return runtimeSettings.caches?.[process.platform]?.cocoapods
+      ? process.env.EAS_COCOAPODS_CACHE_URL || cacheUrlFallbacks.cocoapods || null
+      : null;
   }
 }

packages/build-tools/src/steps/__tests__/hookAnchors.test.ts

@@ -1,117 +0,0 @@
-import { HookAnchorId } from '@expo/eas-build-job';
-import { StepsConfigParser } from '@expo/steps';
-
-import {
-  createCustomBuildContextMock,
-  createGlobalContextMock,
-} from '../../__tests__/utils/context';
-import { getEasFunctionGroups } from '../easFunctionGroups';
-import { getEasFunctions } from '../easFunctions';
-
-jest.mock('fs');
-
-describe('hook anchor self-declarations', () => {
-  it('exactly the four v0 functions declare anchors, with these bindings', () => {
-    const declarations: Record<string, HookAnchorId> = {};
-    for (const buildFunction of getEasFunctions(createCustomBuildContextMock())) {
-      if (buildFunction.__hookId !== undefined) {
-        declarations[buildFunction.getFullId()] = buildFunction.__hookId;
-      }
-    }
-    // An empty declaration set must fail: without these, every user-authored
-    // unstamped `uses:` step and every `eas/build` expansion loses hooks.
-    expect(declarations).toEqual({
-      'eas/checkout': 'checkout',
-      'eas/install_node_modules': 'install_node_modules',
-      'eas/upload_to_asc': 'submit',
-      'eas/maestro_tests': 'maestro_tests',
-    });
-  });
-
-  it('no function group id collides with a declaring function id', () => {
-    // Group lookup shadows function lookup in StepsConfigParser, so a
-    // collision would silently unbind the anchor.
-    const declaringFunctionIds = getEasFunctions(createCustomBuildContextMock())
-      .filter(buildFunction => buildFunction.__hookId !== undefined)
-      .map(buildFunction => buildFunction.getFullId());
-    const functionGroupIds = getEasFunctionGroups(createCustomBuildContextMock()).map(
-      functionGroup => functionGroup.getFullId()
-    );
-    for (const functionId of declaringFunctionIds) {
-      expect(functionGroupIds).not.toContain(functionId);
-    }
-  });
-
-  it('attaches hooks inside a uses: eas/build expansion (declaration-driven anchor discovery)', async () => {
-    // This is the guard against a semantically stale declaration — the
-    // declaration existence test alone cannot catch a binding that no longer
-    // corresponds to what the group actually expands to.
-    const customBuildCtx = createCustomBuildContextMock();
-    const globalContext = createGlobalContextMock({});
-    const parser = new StepsConfigParser(globalContext, {
-      steps: [{ uses: 'eas/build' }],
-      hooks: {
-        before_install_node_modules: [{ run: 'echo before', id: 'before-hook' }],
-        after_install_node_modules: [{ run: 'echo after', id: 'after-hook' }],
-      },
-      externalFunctions: getEasFunctions(customBuildCtx),
-      externalFunctionGroups: getEasFunctionGroups(customBuildCtx),
-    });
-    const workflow = await parser.parseAsync();
-
-    const installStep = workflow.buildSteps.find(step => step.__hookId === 'install_node_modules');
-    expect(installStep).toBeDefined();
-    const anchorHooks = workflow.hooksByAnchorStep.get(installStep!);
-    expect(anchorHooks?.anchor).toBe('install_node_modules');
-    expect(anchorHooks?.before[0].steps[0].id).toBe('before-hook');
-    expect(anchorHooks?.after[0].steps[0].id).toBe('after-hook');
-  });
-
-  it.each([
-    ['eas/checkout', 'before_checkout', 'after_checkout', undefined],
-    [
-      'eas/install_node_modules',
-      'before_install_node_modules',
-      'after_install_node_modules',
-      undefined,
-    ],
-    [
-      'eas/upload_to_asc',
-      'before_submit',
-      'after_submit',
-      {
-        ipa_path: 'app.ipa',
-        asc_api_key_path: 'key.p8',
-        apple_app_identifier: '1234567890',
-        bundle_version: '1',
-        bundle_short_version: '1.0.0',
-      },
-    ],
-    [
-      'eas/maestro_tests',
-      'before_maestro_tests',
-      'after_maestro_tests',
-      { flow_path: ['flow.yaml'] },
-    ],
-  ] as const)(
-    'an unstamped user-authored %s step fires its hook keys end-to-end',
-    async (functionId, beforeKey, afterKey, callInputs) => {
-      const customBuildCtx = createCustomBuildContextMock();
-      const globalContext = createGlobalContextMock({});
-      const parser = new StepsConfigParser(globalContext, {
-        steps: [{ uses: functionId, ...(callInputs !== undefined ? { with: callInputs } : null) }],
-        hooks: {
-          [beforeKey]: [{ run: 'echo before', id: 'before-hook' }],
-          [afterKey]: [{ run: 'echo after', id: 'after-hook' }],
-        },
-        externalFunctions: getEasFunctions(customBuildCtx),
-        externalFunctionGroups: getEasFunctionGroups(customBuildCtx),
-      });
-      const workflow = await parser.parseAsync();
-      expect(workflow.hooksByAnchorStep.size).toBe(1);
-      const anchorHooks = [...workflow.hooksByAnchorStep.values()][0];
-      expect(anchorHooks.before[0].steps[0].id).toBe('before-hook');
-      expect(anchorHooks.after[0].steps[0].id).toBe('after-hook');
-    }
-  );
-});

packages/build-tools/src/steps/easFunctions.ts

@@ -1,7 +1,6 @@
 import { BuildFunction } from '@expo/steps';
 
 import { calculateEASUpdateRuntimeVersionFunction } from './functions/calculateEASUpdateRuntimeVersion';
-import { createCapturePosthogEventFunction } from './functions/capturePosthogEvent';
 import { createCheckoutBuildFunction } from './functions/checkout';
 import { configureAndroidVersionFunction } from './functions/configureAndroidVersion';
 import { configureEASUpdateIfInstalledFunction } from './functions/configureEASUpdateIfInstalled';
@@ -14,7 +13,6 @@ import { createEasDeployBuildFunction } from './functions/deploy';
 import { createEasExportBuildFunction } from './functions/export';
 import { eagerBundleBuildFunction } from './functions/eagerBundle';
 import { createFindAndUploadBuildArtifactsBuildFunction } from './functions/findAndUploadBuildArtifacts';
-import { createFinishIosSimulatorRecordingsBuildFunction } from './functions/finishIosSimulatorRecordings';
 import { generateGymfileFromTemplateFunction } from './functions/generateGymfileFromTemplate';
 import { createGetCredentialsForBuildTriggeredByGithubIntegration } from './functions/getCredentialsForBuildTriggeredByGitHubIntegration';
 import { injectAndroidCredentialsFunction } from './functions/injectAndroidCredentials';
@@ -39,7 +37,6 @@ import { runFastlaneFunction } from './functions/runFastlane';
 import { runGradleFunction } from './functions/runGradle';
 import { createMaestroTestsBuildFunction } from './functions/maestroTests';
 import { createSaveBuildCacheFunction } from './functions/saveBuildCache';
-import { createRolloutPosthogFlagFunction } from './functions/rolloutPosthogFlag';
 import { createSaveCacheFunction } from './functions/saveCache';
 import { createSendSlackMessageFunction } from './functions/sendSlackMessage';
 import { createStartAgentDeviceRemoteSessionBuildFunction } from './functions/startAgentDeviceRemoteSession';
@@ -47,16 +44,10 @@ import { createStartAndroidEmulatorBuildFunction } from './functions/startAndroi
 import { createStartArgentRemoteSessionBuildFunction } from './functions/startArgentRemoteSession';
 import { createStartCuttlefishDeviceBuildFunction } from './functions/startCuttlefishDevice';
 import { createStartIosSimulatorBuildFunction } from './functions/startIosSimulator';
-import { createStartIosSimulatorRecordingsBuildFunction } from './functions/startIosSimulatorRecordings';
 import { createStartServeSimRemoteSessionBuildFunction } from './functions/startServeSimRemoteSession';
 import { createUploadArtifactBuildFunction } from './functions/uploadArtifact';
-import { createUploadDeviceRunSessionScreenRecordingsBuildFunction } from './functions/uploadDeviceRunSessionScreenRecordings';
 import { createUploadToAscBuildFunction } from './functions/uploadToAsc';
 import { createSetUpNpmrcBuildFunction } from './functions/useNpmToken';
-import { createWaitForPosthogMetricFunction } from './functions/waitForPosthogMetric';
-import { createUploadPosthogSourcemapsFunction } from './functions/uploadPosthogSourcemaps';
-import { createPosthogAnnotationFunction } from './functions/createPosthogAnnotation';
-import { createWaitForPosthogQueryFunction } from './functions/waitForPosthogQuery';
 import { CustomBuildContext } from '../customBuildContext';
 
 export function getEasFunctions(ctx: CustomBuildContext): BuildFunction[] {
@@ -70,7 +61,7 @@ export function getEasFunctions(ctx: CustomBuildContext): BuildFunction[] {
     createInstallNodeModulesBuildFunction(),
     createPrebuildBuildFunction(),
     createReadIpaInfoBuildFunction(),
-    createDownloadBuildFunction(ctx),
+    createDownloadBuildFunction(),
     createEasExportBuildFunction(),
     createEasDeployBuildFunction(),
     createRepackBuildFunction(),
@@ -95,20 +86,11 @@ export function getEasFunctions(ctx: CustomBuildContext): BuildFunction[] {
     createStartAndroidEmulatorBuildFunction(),
     createStartCuttlefishDeviceBuildFunction(),
     createStartIosSimulatorBuildFunction(),
-    createStartIosSimulatorRecordingsBuildFunction(),
-    createFinishIosSimulatorRecordingsBuildFunction(),
-    createUploadDeviceRunSessionScreenRecordingsBuildFunction(ctx),
     createStartServeSimRemoteSessionBuildFunction(ctx),
     createInstallMaestroBuildFunction(),
 
     createInstallPodsBuildFunction(),
     createSendSlackMessageFunction(),
-    createCapturePosthogEventFunction(),
-    createRolloutPosthogFlagFunction(),
-    createWaitForPosthogMetricFunction(),
-    createUploadPosthogSourcemapsFunction(),
-    createPosthogAnnotationFunction(),
-    createWaitForPosthogQueryFunction(),
 
     calculateEASUpdateRuntimeVersionFunction(),
 
@@ -116,7 +98,7 @@ export function getEasFunctions(ctx: CustomBuildContext): BuildFunction[] {
     createUploadToAscBuildFunction(),
 
     createReportMaestroTestResultsFunction(ctx),
-    createMaestroTestsBuildFunction(ctx),
+    createMaestroTestsBuildFunction(),
   ];
 
   if (ctx.hasBuildJob()) {

packages/build-tools/src/steps/functions/__tests__/capturePosthogEvent.test.ts

@@ -1,176 +0,0 @@
-import fetch, { Response } from 'node-fetch';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { createCapturePosthogEventFunction } from '../capturePosthogEvent';
-
-jest.mock('@expo/logger');
-jest.mock('node-fetch');
-
-describe(createCapturePosthogEventFunction, () => {
-  const fetchMock = jest.mocked(fetch);
-  const captureEvent = createCapturePosthogEventFunction();
-
-  afterEach(() => {
-    jest.resetAllMocks();
-  });
-
-  function createStep(
-    callInputs: Record<string, unknown>,
-    env: Record<string, string>
-  ): ReturnType<typeof captureEvent.createBuildStepFromFunctionCall> {
-    return captureEvent.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs,
-      env,
-      id: captureEvent.id,
-    });
-  }
-
-  it('sends the event to the ingestion endpoint using the env key', async () => {
-    fetchMock.mockResolvedValue({ status: 200, ok: true } as Response);
-    const step = createStep(
-      { event: 'workflow_finished', distinct_id: 'account-1' },
-      {
-        EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test',
-        EXPO_PUBLIC_POSTHOG_HOST: 'https://us.posthog.com',
-      }
-    );
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-    const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('https://us.posthog.com/i/v0/e/');
-    const body = JSON.parse(init?.body as string);
-    expect(body).toMatchObject({
-      api_key: 'phc_test',
-      event: 'workflow_finished',
-      distinct_id: 'account-1',
-    });
-    expect(body.properties?.$process_person_profile).toBeUndefined();
-  });
-
-  it('sends an anonymous system event when no distinct_id is given', async () => {
-    fetchMock.mockResolvedValue({ status: 200, ok: true } as Response);
-    const step = createStep(
-      { event: 'workflow_finished' },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-
-    await step.executeAsync();
-
-    const body = JSON.parse(fetchMock.mock.calls[0][1]?.body as string);
-    expect(body.distinct_id).toBe('eas-workflow');
-    expect(body.properties.$process_person_profile).toBe(false);
-  });
-
-  it('skips when no api key is available and ignore_error is set', async () => {
-    const step = createStep(
-      { event: 'workflow_finished', distinct_id: 'account-1', ignore_error: true },
-      {}
-    );
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(fetchMock).not.toHaveBeenCalled();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error\.$/)
-    );
-  });
-
-  it('logs and does not throw on a non-2xx response when ignore_error is set', async () => {
-    fetchMock.mockResolvedValue({
-      status: 400,
-      ok: false,
-      text: async () => '',
-    } as unknown as Response);
-    const step = createStep(
-      { event: 'workflow_finished', distinct_id: 'account-1', ignore_error: true },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'Sending PostHog event "workflow_finished" failed with status 400. Ignoring error.'
-    );
-  });
-
-  it('does not let properties override the anonymous marker', async () => {
-    fetchMock.mockResolvedValue({ status: 200, ok: true } as Response);
-    const step = createStep(
-      { event: 'workflow_finished', properties: { $process_person_profile: true, foo: 'bar' } },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-
-    await step.executeAsync();
-
-    const body = JSON.parse(fetchMock.mock.calls[0][1]?.body as string);
-    expect(body.properties.$process_person_profile).toBe(false);
-    expect(body.properties.foo).toBe('bar');
-  });
-
-  it('throws on a network error by default', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    const step = createStep(
-      { event: 'workflow_finished' },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      'Sending PostHog event "workflow_finished" failed.'
-    );
-  });
-
-  it('logs and does not throw on a network error when ignore_error is set', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    const step = createStep(
-      { event: 'workflow_finished', ignore_error: true },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'Sending PostHog event "workflow_finished" failed. Ignoring error.'
-    );
-  });
-
-  it('throws with the PostHog error detail on failure by default', async () => {
-    fetchMock.mockResolvedValue({
-      status: 400,
-      ok: false,
-      text: async () => JSON.stringify({ detail: 'Invalid event name' }),
-    } as unknown as Response);
-    const step = createStep(
-      { event: 'workflow_finished' },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-
-    await expect(step.executeAsync()).rejects.toThrow(/failed with status 400: Invalid event name/);
-  });
-
-  it('falls back to the raw error body when PostHog omits a detail', async () => {
-    fetchMock.mockResolvedValue({
-      status: 400,
-      ok: false,
-      text: async () => JSON.stringify({ error: 'nope' }),
-    } as unknown as Response);
-    const step = createStep(
-      { event: 'workflow_finished' },
-      { EXPO_PUBLIC_POSTHOG_API_KEY: 'phc_test' }
-    );
-
-    await expect(step.executeAsync()).rejects.toThrow(/failed with status 400: {"error":"nope"}/);
-  });
-
-  it('throws on missing key by default', async () => {
-    const step = createStep({ event: 'workflow_finished' }, {});
-
-    await expect(step.executeAsync()).rejects.toThrow(/PostHog API key not provided/);
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-});

packages/build-tools/src/steps/functions/__tests__/createPosthogAnnotation.test.ts

@@ -1,138 +0,0 @@
-import fetch, { Response } from 'node-fetch';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { createPosthogAnnotationFunction } from '../createPosthogAnnotation';
-
-jest.mock('@expo/logger');
-jest.mock('node-fetch');
-
-function jsonResponse(data: unknown, { ok = true, status = 200 } = {}): Response {
-  return {
-    ok,
-    status,
-    json: async () => data,
-    text: async () => JSON.stringify(data),
-  } as unknown as Response;
-}
-
-const ENV = {
-  POSTHOG_CLI_API_KEY: 'phx_test',
-  POSTHOG_CLI_PROJECT_ID: '123',
-  POSTHOG_CLI_HOST: 'https://us.posthog.com',
-};
-
-describe(createPosthogAnnotationFunction, () => {
-  const fetchMock = jest.mocked(fetch);
-  const annotation = createPosthogAnnotationFunction();
-
-  afterEach(() => {
-    jest.resetAllMocks();
-  });
-
-  function createStep(
-    callInputs: Record<string, unknown>,
-    env: Record<string, string> = ENV
-  ): ReturnType<typeof annotation.createBuildStepFromFunctionCall> {
-    return annotation.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs,
-      env,
-      id: annotation.id,
-    });
-  }
-
-  it('posts the annotation with an explicit date_marker', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ id: 1 }, { status: 201 }));
-    const step = createStep({ content: 'Released abc123', date_marker: '2026-07-03T00:00:00Z' });
-
-    await step.executeAsync();
-
-    const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('https://us.posthog.com/api/projects/123/annotations/');
-    expect(JSON.parse(init?.body as string)).toEqual({
-      content: 'Released abc123',
-      date_marker: '2026-07-03T00:00:00Z',
-    });
-  });
-
-  it('defaults date_marker to now when not given', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ id: 1 }, { status: 201 }));
-    const step = createStep({ content: 'Deploy' });
-
-    await step.executeAsync();
-
-    const body = JSON.parse(fetchMock.mock.calls[0][1]?.body as string);
-    expect(body.content).toBe('Deploy');
-    expect(typeof body.date_marker).toBe('string');
-  });
-
-  it('throws when credentials are missing by default', async () => {
-    const step = createStep({ content: 'Deploy' }, {});
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /Missing PostHog credentials: personal API key, project id/
-    );
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('warns and skips when credentials are missing and ignore_error is set', async () => {
-    const step = createStep({ content: 'Deploy', ignore_error: true }, {});
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(fetchMock).not.toHaveBeenCalled();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error/)
-    );
-  });
-
-  it('throws on a network error by default', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    const step = createStep({ content: 'Deploy' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/Creating the PostHog annotation failed/);
-  });
-
-  it('warns and continues on a network error when ignore_error is set', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    const step = createStep({ content: 'Deploy', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error/)
-    );
-  });
-
-  it('throws on a 403 without swallowing it', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({}, { ok: false, status: 403 }));
-    const step = createStep({ content: 'Deploy' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/annotation:write/);
-  });
-
-  it('throws with the PostHog error detail on a non-2xx response', async () => {
-    fetchMock.mockResolvedValue(
-      jsonResponse({ detail: 'Invalid date_marker' }, { ok: false, status: 400 })
-    );
-    const step = createStep({ content: 'Deploy' });
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /failed with status 400: Invalid date_marker/
-    );
-  });
-
-  it('warns and continues on a non-2xx response when ignore_error is set', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({}, { ok: false, status: 500 }));
-    const step = createStep({ content: 'Deploy', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error/)
-    );
-  });
-});

packages/build-tools/src/steps/functions/__tests__/downloadBuild.test.ts

@@ -1,6 +1,4 @@
-import { SystemError, UserError } from '@expo/eas-build-job';
 import { createLogger } from '@expo/logger';
-import { Client, CombinedError } from '@urql/core';
 import fetch, { Response } from 'node-fetch';
 import { randomUUID } from 'node:crypto';
 import fs from 'node:fs';
@@ -19,63 +17,22 @@ const APP_TAR_GZ_BUFFER = Buffer.from(
   'base64'
 );
 
-const APPLICATION_ARCHIVE_URL = `https://expo.dev/artifacts/eas/${randomUUID()}.tar.gz`;
-
-function createMockGraphqlClient({
-  applicationArchiveUrl,
-  error,
-}: {
-  applicationArchiveUrl?: string | null;
-  error?: Error;
-}): Client {
-  const toPromise = jest.fn().mockResolvedValue(
-    error
-      ? { error, data: undefined }
-      : {
-          data: {
-            builds: {
-              byId: {
-                id: randomUUID(),
-                platform: 'IOS',
-                artifacts: {
-                  applicationArchiveUrl: applicationArchiveUrl ?? null,
-                },
-              },
-            },
-          },
-        }
-  );
-
-  return {
-    query: jest.fn().mockReturnValue({ toPromise }),
-  } as unknown as Client;
-}
-
 describe('downloadBuild', () => {
-  it('downloads from applicationArchiveUrl returned by GraphQL', async () => {
-    const buildId = randomUUID();
-    const graphqlClient = createMockGraphqlClient({
-      applicationArchiveUrl: APPLICATION_ARCHIVE_URL,
-    });
-
+  it('should handle an archive', async () => {
     jest.mocked(fetch).mockResolvedValue({
       ok: true,
       body: Readable.from(APP_TAR_GZ_BUFFER),
-      url: APPLICATION_ARCHIVE_URL,
+      url: `https://storage.googleapis.com/eas-workflows-production/artifacts/${randomUUID()}/${randomUUID()}/application-${randomUUID()}.tar.gz?X-Goog-Algorithm=GOOG4-RSA-SHA256`,
     } as unknown as Response);
 
     const { artifactPath } = await downloadBuildAsync({
       logger: createLogger({ name: 'test' }),
-      buildId,
-      graphqlClient,
+      buildId: randomUUID(),
+      expoApiServerURL: 'http://api.expo.test',
       robotAccessToken: null,
       extensions: ['app'],
     });
 
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith(
-      APPLICATION_ARCHIVE_URL,
-      expect.objectContaining({ headers: undefined })
-    );
     expect(artifactPath).toBeDefined();
     expect(await fs.promises.readFile(path.join(artifactPath, 'TestApp'), 'utf8')).toBe(
       'i am executable\n'
@@ -83,21 +40,16 @@ describe('downloadBuild', () => {
   });
 
   it('should handle a straight-up file', async () => {
-    const applicationArchiveUrl = `https://expo.dev/artifacts/eas/${randomUUID()}.apk`;
-    const graphqlClient = createMockGraphqlClient({
-      applicationArchiveUrl,
-    });
-
     jest.mocked(fetch).mockResolvedValue({
       ok: true,
       body: Readable.from(Buffer.from('hello')),
-      url: applicationArchiveUrl,
+      url: `https://storage.googleapis.com/eas-workflows-production/artifacts/${randomUUID()}/${randomUUID()}/application-${randomUUID()}.txt?X-Goog-Algorithm=GOOG4-RSA-SHA256`,
     } as unknown as Response);
 
     const { artifactPath } = await downloadBuildAsync({
       logger: createLogger({ name: 'test' }),
       buildId: randomUUID(),
-      graphqlClient,
+      expoApiServerURL: 'http://api.expo.test',
       robotAccessToken: null,
       extensions: ['app'],
     });
@@ -106,114 +58,18 @@ describe('downloadBuild', () => {
     expect(await fs.promises.readFile(artifactPath, 'utf-8')).toBe('hello');
   });
 
-  it('throws UserError when the build has no application archive url', async () => {
-    const graphqlClient = createMockGraphqlClient({ applicationArchiveUrl: null });
-
-    await expect(
-      downloadBuildAsync({
-        logger: createLogger({ name: 'test' }),
-        buildId: randomUUID(),
-        graphqlClient,
-        robotAccessToken: null,
-        extensions: ['app'],
-      })
-    ).rejects.toMatchObject({
-      errorCode: 'EAS_DOWNLOAD_BUILD_NO_APPLICATION_ARCHIVE',
-      message: 'Build does not have an application archive url',
-    });
-
-    expect(jest.mocked(fetch)).not.toHaveBeenCalled();
-  });
-
-  it('throws SystemError when GraphQL request fails with a network error', async () => {
-    const buildId = randomUUID();
-    const graphqlClient = createMockGraphqlClient({
-      error: new CombinedError({
-        networkError: new Error('Network request failed'),
-      }),
-    });
-
-    const promise = downloadBuildAsync({
-      logger: createLogger({ name: 'test' }),
-      buildId,
-      graphqlClient,
-      robotAccessToken: null,
-      extensions: ['app'],
-    });
-
-    await expect(promise).rejects.toBeInstanceOf(SystemError);
-    await expect(promise).rejects.toMatchObject({
-      message: `Could not fetch build ${buildId}: [Network] Network request failed`,
-    });
-
-    expect(jest.mocked(fetch)).not.toHaveBeenCalled();
-  });
-
-  it('throws SystemError when GraphQL request returns 5xx', async () => {
-    const buildId = randomUUID();
-    const graphqlClient = createMockGraphqlClient({
-      error: Object.assign(new Error('Internal Server Error'), {
-        response: { status: 500 },
-      }),
-    });
-
-    const promise = downloadBuildAsync({
-      logger: createLogger({ name: 'test' }),
-      buildId,
-      graphqlClient,
-      robotAccessToken: null,
-      extensions: ['app'],
-    });
-
-    await expect(promise).rejects.toBeInstanceOf(SystemError);
-    await expect(promise).rejects.toMatchObject({
-      message: `Could not fetch build ${buildId}: Internal Server Error`,
-    });
-
-    expect(jest.mocked(fetch)).not.toHaveBeenCalled();
-  });
-
-  it('throws UserError when GraphQL returns a client error', async () => {
-    const buildId = randomUUID();
-    const graphqlClient = createMockGraphqlClient({
-      error: new CombinedError({
-        graphQLErrors: [{ message: 'Build not found' }],
-      }),
-    });
-
-    const promise = downloadBuildAsync({
-      logger: createLogger({ name: 'test' }),
-      buildId,
-      graphqlClient,
-      robotAccessToken: null,
-      extensions: ['app'],
-    });
-
-    await expect(promise).rejects.toBeInstanceOf(UserError);
-    await expect(promise).rejects.toMatchObject({
-      errorCode: 'EAS_DOWNLOAD_BUILD_FETCH_FAILED',
-      message: `Could not fetch build ${buildId}: [GraphQL] Build not found`,
-    });
-
-    expect(jest.mocked(fetch)).not.toHaveBeenCalled();
-  });
-
   it('should throw an error if no matching files are found', async () => {
-    const graphqlClient = createMockGraphqlClient({
-      applicationArchiveUrl: APPLICATION_ARCHIVE_URL,
-    });
-
     jest.mocked(fetch).mockResolvedValue({
       ok: true,
       body: Readable.from(APP_TAR_GZ_BUFFER),
-      url: APPLICATION_ARCHIVE_URL,
+      url: `https://storage.googleapis.com/eas-workflows-production/artifacts/${randomUUID()}/${randomUUID()}/application-${randomUUID()}.tar.gz?X-Goog-Algorithm=GOOG4-RSA-SHA256`,
     } as unknown as Response);
 
     await expect(
       downloadBuildAsync({
         logger: createLogger({ name: 'test' }),
         buildId: randomUUID(),
-        graphqlClient,
+        expoApiServerURL: 'http://api.expo.test',
         robotAccessToken: null,
         extensions: ['apk'],
       })
@@ -223,11 +79,7 @@ describe('downloadBuild', () => {
 
 describe('createDownloadBuildFunction', () => {
   it('should download a build', async () => {
-    const buildId = randomUUID();
-    const graphqlClient = createMockGraphqlClient({
-      applicationArchiveUrl: APPLICATION_ARCHIVE_URL,
-    });
-    const downloadBuild = createDownloadBuildFunction({ graphqlClient } as any);
+    const downloadBuild = createDownloadBuildFunction();
     const logger = createMockLogger();
 
     const buildStep = downloadBuild.createBuildStepFromFunctionCall(
@@ -240,7 +92,7 @@ describe('createDownloadBuildFunction', () => {
       }),
       {
         callInputs: {
-          build_id: buildId,
+          build_id: randomUUID(),
           extensions: ['app'],
         },
       }
@@ -253,9 +105,5 @@ describe('createDownloadBuildFunction', () => {
     } as unknown as Response);
 
     await expect(buildStep.executeAsync()).rejects.toThrow('Internal Server Error');
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith(
-      APPLICATION_ARCHIVE_URL,
-      expect.objectContaining({ headers: undefined })
-    );
   });
 });

packages/build-tools/src/steps/functions/__tests__/maestroResultParser.test.ts

@@ -4,14 +4,10 @@ import { vol } from 'memfs';
 
 import {
   copyLatestAttemptXml,
-  isFileAttrRun,
-  junitFileHasFileAttrs,
   mergeJUnitReports,
-  parseFailedFlowsFromFileAttrs,
   parseFailedFlowsFromJUnit,
   parseJUnitTestCases,
   parseMaestroResults,
-  parseMaestroResultsFromFileAttrs,
 } from '../maestroResultParser';
 
 describe(parseMaestroResults, () => {
@@ -302,169 +298,7 @@ describe(parseMaestroResults, () => {
   });
 });
 
-describe(parseMaestroResultsFromFileAttrs, () => {
-  it('uses file= as the path', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file=".maestro/login.yaml" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const results = await parseMaestroResultsFromFileAttrs('/junit');
-    expect(results[0]).toEqual(
-      expect.objectContaining({ name: 'login', path: '.maestro/login.yaml' })
-    );
-  });
-
-  it('keeps two same-named flows separate by their file= path', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file="a/login.yaml" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="login" file="b/login.yaml" status="ERROR" time="1.0"><failure>x</failure></testcase>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const results = await parseMaestroResultsFromFileAttrs('/junit');
-    expect(results.map(r => r.path).sort()).toEqual(['a/login.yaml', 'b/login.yaml']);
-  });
-
-  it('returns per-attempt results keyed by file= across attempt files', async () => {
-    vol.fromJSON({
-      '/junit/android-maestro-junit-attempt-0.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file="flows/login.yaml" time="1.0"><failure>x</failure></testcase>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-      '/junit/android-maestro-junit-attempt-1.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file="flows/login.yaml" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const results = await parseMaestroResultsFromFileAttrs('/junit');
-    expect(results).toEqual([
-      expect.objectContaining({ path: 'flows/login.yaml', status: 'failed', retryCount: 0 }),
-      expect.objectContaining({ path: 'flows/login.yaml', status: 'passed', retryCount: 1 }),
-    ]);
-  });
-
-  it('returns empty array when the directory does not exist', async () => {
-    const results = await parseMaestroResultsFromFileAttrs('/nope');
-    expect(results).toEqual([]);
-  });
-
-  it('skips testcases without file= instead of emitting an undefined path (contract guard)', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="a" file="a.yaml" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="b" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const results = await parseMaestroResultsFromFileAttrs('/junit');
-    expect(results).toEqual([expect.objectContaining({ name: 'a', path: 'a.yaml' })]);
-  });
-});
-
-describe('junitFileHasFileAttrs', () => {
-  it('returns true when every testcase has a non-empty file= attribute', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="a" file="a.yaml" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="b" file="b.yaml" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    expect(await junitFileHasFileAttrs('/junit/report.xml')).toBe(true);
-  });
-
-  it('returns false when any testcase lacks file= (mixed report)', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="a" file="a.yaml" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="b" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    expect(await junitFileHasFileAttrs('/junit/report.xml')).toBe(false);
-  });
-
-  it('returns false when file= is an empty string', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="a" file="" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    expect(await junitFileHasFileAttrs('/junit/report.xml')).toBe(false);
-  });
-
-  it('returns false for a legacy report with no file= attributes', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="a" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    expect(await junitFileHasFileAttrs('/junit/report.xml')).toBe(false);
-  });
-
-  it('returns false when the file cannot be read', async () => {
-    expect(await junitFileHasFileAttrs('/missing.xml')).toBe(false);
-  });
-});
-
-describe('isFileAttrRun', () => {
-  it('returns false for an empty list (an empty report is not a file-attr run)', () => {
-    expect(isFileAttrRun([])).toBe(false);
-  });
-});
-
 describe(parseJUnitTestCases, () => {
-  it('extracts the file= attribute when present', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file=".maestro/login.yaml" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const results = await parseJUnitTestCases('/junit');
-    expect(results[0].file).toBe('.maestro/login.yaml');
-  });
-
-  it('treats a missing or empty file= attribute as undefined', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="a" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="b" file="" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const results = await parseJUnitTestCases('/junit');
-    expect(results.find(r => r.name === 'a')!.file).toBeUndefined();
-    expect(results.find(r => r.name === 'b')!.file).toBeUndefined();
-  });
-
   it('parses a single testcase with SUCCESS status', async () => {
     vol.fromJSON({
       '/junit/report.xml': [
@@ -748,100 +582,6 @@ describe(parseJUnitTestCases, () => {
   });
 });
 
-describe(parseFailedFlowsFromFileAttrs, () => {
-  it('returns the failing flows by file= (duplicate names retry correctly)', async () => {
-    vol.fromJSON({
-      '/tmp/jr/attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="login" file="a/login.yaml" status="SUCCESS" time="1.0"/>
-  <testcase name="login" file="b/login.yaml" time="1.0"><failure>x</failure></testcase>
-</testsuite></testsuites>`,
-      '/proj/b/login.yaml': '',
-    });
-    const result = await parseFailedFlowsFromFileAttrs({
-      junitFile: '/tmp/jr/attempt-0.xml',
-      workingDirectory: '/proj',
-    });
-    expect(result).toEqual(['b/login.yaml']);
-  });
-
-  it('returns null when a file= path does not exist on disk (dumb retry, never legacy)', async () => {
-    vol.fromJSON({
-      '/tmp/jr/attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="gone" file="missing/flow.yaml" time="1.0"><failure>x</failure></testcase>
-</testsuite></testsuites>`,
-    });
-    const result = await parseFailedFlowsFromFileAttrs({
-      junitFile: '/tmp/jr/attempt-0.xml',
-      workingDirectory: '/proj',
-    });
-    expect(result).toBeNull();
-  });
-
-  it('returns null when the report lacks file= attributes (callers must pre-check)', async () => {
-    vol.fromJSON({
-      '/tmp/jr/attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="A" file="a.yaml" time="1.0"><failure>x</failure></testcase>
-  <testcase name="B" time="1.0"><failure>y</failure></testcase>
-</testsuite></testsuites>`,
-      '/proj/a.yaml': '',
-    });
-    const result = await parseFailedFlowsFromFileAttrs({
-      junitFile: '/tmp/jr/attempt-0.xml',
-      workingDirectory: '/proj',
-    });
-    expect(result).toBeNull();
-  });
-
-  it('dedupes repeated failing file= paths (same flow failed twice in one attempt)', async () => {
-    vol.fromJSON({
-      '/tmp/jr/attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="login" file="flows/login.yaml" time="1.0"><failure>x</failure></testcase>
-  <testcase name="login" file="flows/login.yaml" time="1.0"><failure>y</failure></testcase>
-</testsuite></testsuites>`,
-      '/proj/flows/login.yaml': '',
-    });
-    const result = await parseFailedFlowsFromFileAttrs({
-      junitFile: '/tmp/jr/attempt-0.xml',
-      workingDirectory: '/proj',
-    });
-    expect(result).toEqual(['flows/login.yaml']);
-  });
-
-  it('resolves and existence-checks an absolute file= path', async () => {
-    vol.fromJSON({
-      '/tmp/jr/attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="ext" file="/outside/flow.yaml" time="1.0"><failure>x</failure></testcase>
-</testsuite></testsuites>`,
-      '/outside/flow.yaml': '',
-    });
-    const result = await parseFailedFlowsFromFileAttrs({
-      junitFile: '/tmp/jr/attempt-0.xml',
-      workingDirectory: '/proj',
-    });
-    expect(result).toEqual(['/outside/flow.yaml']);
-  });
-
-  it('returns null when junit XML is truncated mid-tag (partial parse risk)', async () => {
-    vol.fromJSON({
-      '/tmp/jr/attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="A" file="a.yaml" time="1.0"><failure>x</failure></testcase>
-  <testcase name="B" file="b.yaml"`, // intentionally truncated mid-tag
-      '/proj/a.yaml': '',
-    });
-    const result = await parseFailedFlowsFromFileAttrs({
-      junitFile: '/tmp/jr/attempt-0.xml',
-      workingDirectory: '/proj',
-    });
-    expect(result).toBeNull();
-  });
-});
-
 describe('parseFailedFlowsFromJUnit', () => {
   it('returns the subset of input flow paths whose testcases failed', async () => {
     vol.fromJSON({
@@ -1025,28 +765,6 @@ describe('mergeJUnitReports', () => {
     expect(b.failure).toBeUndefined();
   });
 
-  it('keeps a same-named flow from an earlier attempt when keyed by file=', async () => {
-    vol.fromJSON({
-      '/tmp/r/android-maestro-junit-attempt-0.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="login" file="a/login.yaml" status="SUCCESS" time="1.0"/>
-  <testcase name="login" file="b/login.yaml" time="1.0"><failure>x</failure></testcase>
-</testsuite></testsuites>`,
-      '/tmp/r/android-maestro-junit-attempt-1.xml': `<?xml version="1.0"?>
-<testsuites><testsuite>
-  <testcase name="login" file="b/login.yaml" status="SUCCESS" time="1.0"/>
-</testsuite></testsuites>`,
-    });
-
-    await mergeJUnitReports({ sourceDir: '/tmp/r', outputPath: '/tmp/final.xml' });
-
-    const out = await fs.readFile('/tmp/final.xml', 'utf-8');
-    const parsed = new XMLParser({ ignoreAttributes: false }).parse(out);
-    const testcases = parsed.testsuites.testsuite.testcase;
-    const files = testcases.map((t: any) => t['@_file']).sort();
-    expect(files).toEqual(['a/login.yaml', 'b/login.yaml']);
-  });
-
   it('throws when source directory contains no *.xml files', async () => {
     // No per-attempt JUnit files were ever written (maestro crashed before
     // producing output). Phase 3 in runMaestroTests treats this as a SystemError

packages/build-tools/src/steps/functions/__tests__/maestroScreenshots.test.ts

@@ -1,287 +0,0 @@
-import fs from 'fs/promises';
-import os from 'os';
-import path from 'path';
-
-import { createMockLogger } from '../../../__tests__/utils/logger';
-import {
-  type HarvestedScreenshot,
-  computePureFailureFlowNames,
-  harvestFailureScreenshotsAsync,
-  parseFailureScreenshotFilename,
-  selectFailureScreenshots,
-} from '../maestroScreenshots';
-
-describe(parseFailureScreenshotFilename, () => {
-  it('parses a plain failure screenshot', () => {
-    expect(parseFailureScreenshotFilename('screenshot-❌-1781186692250-(Login Flow).png')).toEqual({
-      flowName: 'Login Flow',
-      capturedAtMs: 1781186692250,
-    });
-  });
-
-  it('parses a sharded failure screenshot', () => {
-    expect(
-      parseFailureScreenshotFilename('screenshot-shard-2-❌-1781186692250-(Login Flow).png')
-    ).toEqual({
-      flowName: 'Login Flow',
-      capturedAtMs: 1781186692250,
-    });
-  });
-
-  it('handles parentheses inside the flow name (right-to-left parse)', () => {
-    expect(
-      parseFailureScreenshotFilename('screenshot-❌-1781186692250-(Login (staging) Flow).png')
-    ).toEqual({
-      flowName: 'Login (staging) Flow',
-      capturedAtMs: 1781186692250,
-    });
-  });
-
-  it('rejects non-failure screenshots (✅, ⚠️) and unrelated files', () => {
-    expect(
-      parseFailureScreenshotFilename('screenshot-✅-1781186692250-(Login Flow).png')
-    ).toBeNull();
-    expect(parseFailureScreenshotFilename('commands-(Login Flow).json')).toBeNull();
-    expect(parseFailureScreenshotFilename('android-maestro-junit-attempt-0.xml')).toBeNull();
-  });
-});
-
-describe(harvestFailureScreenshotsAsync, () => {
-  const logger = createMockLogger();
-  let testsDirectory: string;
-
-  beforeEach(async () => {
-    testsDirectory = await fs.mkdtemp(path.join(os.tmpdir(), 'maestro-harvest-test-'));
-  });
-
-  afterEach(async () => {
-    await fs.rm(testsDirectory, { recursive: true, force: true });
-  });
-
-  async function makeDebugDir(name: string, files: string[], mtimeMs: number): Promise<void> {
-    const dir = path.join(testsDirectory, name);
-    await fs.mkdir(dir);
-    for (const file of files) {
-      await fs.writeFile(path.join(dir, file), '');
-    }
-    const when = new Date(mtimeMs);
-    await fs.utimes(dir, when, when);
-  }
-
-  it('returns shots from dirs modified at/after sinceMtimeMs, attributed to the attempt', async () => {
-    const sinceMtimeMs = 1_000_000;
-    await makeDebugDir(
-      'attempt-dir',
-      ['screenshot-❌-1781186692250-(Login Flow).png', 'commands.json'],
-      sinceMtimeMs + 5_000
-    );
-
-    const shots = await harvestFailureScreenshotsAsync({
-      testsDirectory,
-      capturedSinceMs: sinceMtimeMs,
-      attemptIndex: 1,
-      logger,
-    });
-
-    expect(shots).toEqual([
-      {
-        fileAbsPath: path.join(
-          testsDirectory,
-          'attempt-dir',
-          'screenshot-❌-1781186692250-(Login Flow).png'
-        ),
-        displayName: 'Failure Screenshot: Login Flow (attempt 2)',
-        metadata: {
-          kind: 'maestro-test-screenshot',
-          flowName: 'Login Flow',
-          attemptIndex: 1,
-          capturedAtMs: 1781186692250,
-        },
-      },
-    ]);
-  });
-
-  it('ignores dirs older than sinceMtimeMs (previous attempts)', async () => {
-    const sinceMtimeMs = 1_000_000;
-    await makeDebugDir(
-      'old-dir',
-      ['screenshot-❌-1781186692250-(Old Flow).png'],
-      sinceMtimeMs - 5_000
-    );
-
-    const shots = await harvestFailureScreenshotsAsync({
-      testsDirectory,
-      capturedSinceMs: sinceMtimeMs,
-      attemptIndex: 0,
-      logger,
-    });
-
-    expect(shots).toEqual([]);
-  });
-
-  it('scans multiple new dirs (maestro <2.5.0 split-dir bug)', async () => {
-    const sinceMtimeMs = 1_000_000;
-    await makeDebugDir(
-      'dir-a',
-      [`screenshot-❌-${sinceMtimeMs + 100}-(Flow A).png`],
-      sinceMtimeMs + 1_000
-    );
-    await makeDebugDir(
-      'dir-b',
-      [`screenshot-❌-${sinceMtimeMs + 200}-(Flow B).png`],
-      sinceMtimeMs + 2_000
-    );
-
-    const shots = await harvestFailureScreenshotsAsync({
-      testsDirectory,
-      capturedSinceMs: sinceMtimeMs,
-      attemptIndex: 0,
-      logger,
-    });
-
-    expect(shots.map(shot => shot.metadata.flowName).sort()).toEqual(['Flow A', 'Flow B']);
-  });
-
-  it('keeps the disk flow name (slashes already substituted) and strips the shard prefix', async () => {
-    const sinceMtimeMs = 1_000_000;
-    await makeDebugDir(
-      'sharded-dir',
-      ['screenshot-shard-3-❌-1781186692250-(Login_Sub Flow).png'],
-      sinceMtimeMs + 1_000
-    );
-
-    const shots = await harvestFailureScreenshotsAsync({
-      testsDirectory,
-      capturedSinceMs: sinceMtimeMs,
-      attemptIndex: 0,
-      logger,
-    });
-
-    expect(shots).toHaveLength(1);
-    expect(shots[0].metadata.flowName).toBe('Login_Sub Flow');
-  });
-
-  it('ignores a stale screenshot whose capturedAtMs predates sinceMtimeMs (dir touched later)', async () => {
-    const sinceMtimeMs = 1_000_000;
-    // The dir mtime is AFTER this attempt started (so it passes the dir gate), but the
-    // screenshot inside was captured BEFORE it — a prior attempt's shot in a dir touched later.
-    await makeDebugDir(
-      'touched-dir',
-      ['screenshot-❌-999000-(Stale Flow).png'],
-      sinceMtimeMs + 5_000
-    );
-
-    const shots = await harvestFailureScreenshotsAsync({
-      testsDirectory,
-      capturedSinceMs: sinceMtimeMs,
-      attemptIndex: 1,
-      logger,
-    });
-
-    expect(shots).toEqual([]);
-  });
-
-  it('logs and returns [] when the tests dir cannot be read', async () => {
-    const shots = await harvestFailureScreenshotsAsync({
-      testsDirectory: path.join(testsDirectory, 'does-not-exist'),
-      capturedSinceMs: 0,
-      attemptIndex: 0,
-      logger,
-    });
-
-    expect(shots).toEqual([]);
-  });
-});
-
-describe(computePureFailureFlowNames, () => {
-  it('classifies a flow that failed every attempt as pure', () => {
-    const pure = computePureFailureFlowNames([
-      { name: 'Login Flow', status: 'failed' },
-      { name: 'Login Flow', status: 'failed' },
-    ]);
-    expect([...pure]).toEqual(['Login Flow']);
-  });
-
-  it('excludes a flaky flow (failed then passed)', () => {
-    const pure = computePureFailureFlowNames([
-      { name: 'Flaky Flow', status: 'failed' },
-      { name: 'Flaky Flow', status: 'passed' },
-    ]);
-    expect(pure.size).toBe(0);
-  });
-
-  it('excludes a fail-pass-fail flow (it passed at some point)', () => {
-    const pure = computePureFailureFlowNames([
-      { name: 'FPF', status: 'failed' },
-      { name: 'FPF', status: 'passed' },
-      { name: 'FPF', status: 'failed' },
-    ]);
-    expect(pure.size).toBe(0);
-  });
-
-  it('excludes a flow that only passed', () => {
-    expect(computePureFailureFlowNames([{ name: 'Happy', status: 'passed' }]).size).toBe(0);
-  });
-
-  it('normalizes the JUnit name to the screenshot form (/ -> _)', () => {
-    const pure = computePureFailureFlowNames([{ name: 'sub/Login', status: 'failed' }]);
-    expect([...pure]).toEqual(['sub_Login']);
-  });
-
-  it('excludes flows that collide only after / -> _ normalization (one failed, one passed)', () => {
-    const pure = computePureFailureFlowNames([
-      { name: 'sub/Login', status: 'failed' },
-      { name: 'sub_Login', status: 'passed' },
-    ]);
-    expect(pure.size).toBe(0);
-  });
-
-  it('returns an empty set for no testcases', () => {
-    expect(computePureFailureFlowNames([]).size).toBe(0);
-  });
-});
-
-describe(selectFailureScreenshots, () => {
-  function makeShot(flowName: string, attemptIndex: number): HarvestedScreenshot {
-    return {
-      fileAbsPath: `/tmp/${flowName}-${attemptIndex}.png`,
-      displayName: `Failure Screenshot: ${flowName} (attempt ${attemptIndex + 1})`,
-      metadata: {
-        kind: 'maestro-test-screenshot',
-        flowName,
-        attemptIndex,
-        capturedAtMs: 1_000 + attemptIndex,
-      },
-    };
-  }
-
-  it('keeps only the final attempt for a pure-failure flow', () => {
-    const shots = [makeShot('Pure', 0), makeShot('Pure', 1), makeShot('Pure', 2)];
-    const selected = selectFailureScreenshots(shots, new Set(['Pure']));
-    expect(selected.map(shot => shot.metadata.attemptIndex)).toEqual([2]);
-  });
-
-  it('keeps every attempt for a flow not classified pure (flaky)', () => {
-    const shots = [makeShot('Flaky', 0), makeShot('Flaky', 1)];
-    const selected = selectFailureScreenshots(shots, new Set());
-    expect(selected.map(shot => shot.metadata.attemptIndex)).toEqual([0, 1]);
-  });
-
-  it('reduces pure flows while preserving flaky flows and input order', () => {
-    const shots = [
-      makeShot('Pure', 0),
-      makeShot('Flaky', 0),
-      makeShot('Pure', 1),
-      makeShot('Flaky', 1),
-    ];
-    const selected = selectFailureScreenshots(shots, new Set(['Pure']));
-    expect(selected.map(shot => `${shot.metadata.flowName}#${shot.metadata.attemptIndex}`)).toEqual(
-      ['Flaky#0', 'Pure#1', 'Flaky#1']
-    );
-  });
-
-  it('keeps all when the pure set is empty', () => {
-    const shots = [makeShot('A', 0), makeShot('A', 1)];
-    expect(selectFailureScreenshots(shots, new Set())).toHaveLength(2);
-  });
-});

packages/build-tools/src/steps/functions/__tests__/maestroTests.test.ts

@@ -1,15 +1,10 @@
-import { GenericArtifactType, SystemError, UserError } from '@expo/eas-build-job';
+import { SystemError, UserError } from '@expo/eas-build-job';
 import spawn from '@expo/turtle-spawn';
-import fs from 'fs/promises';
-import os from 'os';
-import path from 'path';
 
 import { createGlobalContextMock } from '../../../__tests__/utils/context';
 import { createMockLogger } from '../../../__tests__/utils/logger';
-import { CustomBuildContext } from '../../../customBuildContext';
 import * as discovery from '../maestroFlowDiscovery';
 import * as parser from '../maestroResultParser';
-import * as maestroScreenshots from '../maestroScreenshots';
 import { createMaestroTestsBuildFunction } from '../maestroTests';
 
 jest.mock('@expo/turtle-spawn', () => ({
@@ -22,29 +17,7 @@ jest.mock('../../../utils/retry', () => ({
   sleepAsync: jest.fn().mockResolvedValue(undefined),
 }));
 
-// Partial mock: stub the harvest (filesystem) but keep the real reduction helpers
-// (computePureFailureFlowNames / selectFailureScreenshots) the step now calls post-loop.
-jest.mock('../maestroScreenshots', () => ({
-  ...jest.requireActual('../maestroScreenshots'),
-  harvestFailureScreenshotsAsync: jest.fn(),
-}));
-
 const mockedSpawn = jest.mocked(spawn);
-const mockedHarvest = jest.mocked(maestroScreenshots.harvestFailureScreenshotsAsync);
-const mockUploadArtifact = jest.fn();
-
-function makeShot(index: number): maestroScreenshots.HarvestedScreenshot {
-  return {
-    fileAbsPath: path.join(os.tmpdir(), `src-screenshot-${index}.png`),
-    displayName: 'Failure Screenshot: Login (attempt 1)',
-    metadata: {
-      kind: 'maestro-test-screenshot',
-      flowName: 'Login',
-      attemptIndex: 0,
-      capturedAtMs: 1781186692250,
-    },
-  };
-}
 
 const SPAWN_SUCCESS = {
   status: 0,
@@ -68,10 +41,7 @@ function createStep(
   ReturnType<typeof createMaestroTestsBuildFunction>['createBuildStepFromFunctionCall']
 > {
   const logger = createMockLogger();
-  const ctx = {
-    runtimeApi: { uploadArtifact: mockUploadArtifact },
-  } as unknown as CustomBuildContext;
-  const fn = createMaestroTestsBuildFunction(ctx);
+  const fn = createMaestroTestsBuildFunction();
   const globalCtx = createGlobalContextMock({ logger });
   globalCtx.updateEnv(options.env ?? { HOME: '/home/expo' });
   return fn.createBuildStepFromFunctionCall(globalCtx, { callInputs });
@@ -84,18 +54,10 @@ describe('createMaestroTestsBuildFunction', () => {
     // hit the real disk. Individual tests override this.
     jest.restoreAllMocks();
     jest.spyOn(parser, 'mergeJUnitReports').mockResolvedValue();
-    mockedHarvest.mockReset();
-    mockedHarvest.mockResolvedValue([]);
-    mockUploadArtifact.mockReset();
-    mockUploadArtifact.mockResolvedValue({ artifactId: 'artifact-1' });
   });
 
   it('exports a factory that returns a BuildFunction instance', () => {
-    expect(
-      createMaestroTestsBuildFunction({
-        runtimeApi: { uploadArtifact: mockUploadArtifact },
-      } as unknown as CustomBuildContext)
-    ).toBeDefined();
+    expect(createMaestroTestsBuildFunction()).toBeDefined();
   });
 
   it('sets all outputs before running any flows', async () => {
@@ -311,33 +273,6 @@ describe('createMaestroTestsBuildFunction', () => {
     );
   });
 
-  it('uses the file= path on reports that carry it, without scanning flow files', async () => {
-    mockedSpawn.mockRejectedValueOnce(rejectExit1()).mockResolvedValueOnce(SPAWN_SUCCESS);
-    jest.spyOn(parser, 'junitFileHasFileAttrs').mockResolvedValue(true);
-    const discoverySpy = jest.spyOn(discovery, 'buildFlowNameToPathMap');
-    const legacyParseSpy = jest.spyOn(parser, 'parseFailedFlowsFromJUnit');
-    const newParseSpy = jest
-      .spyOn(parser, 'parseFailedFlowsFromFileAttrs')
-      .mockResolvedValue(['flows/b.yaml']);
-
-    const step = createStep({
-      flow_path: ['flows/a.yaml', 'flows/b.yaml'],
-      retries: 1,
-      output_format: 'junit',
-      retry_failed_only: true,
-      platform: 'android',
-    });
-    await step.executeAsync();
-
-    expect(newParseSpy).toHaveBeenCalledTimes(1);
-    // The new branch needs no name→path map: no scan, no legacy parser.
-    expect(discoverySpy).not.toHaveBeenCalled();
-    expect(legacyParseSpy).not.toHaveBeenCalled();
-    const a1 = mockedSpawn.mock.calls[1][1]!;
-    expect(a1).toContain('flows/b.yaml');
-    expect(a1).not.toContain('flows/a.yaml');
-  });
-
   it('falls back to all-flows retry when nameToPath is null (duplicate flow names)', async () => {
     mockedSpawn.mockRejectedValueOnce(rejectExit1()).mockResolvedValueOnce(SPAWN_SUCCESS);
     jest.spyOn(discovery, 'buildFlowNameToPathMap').mockResolvedValue(null);
@@ -358,44 +293,6 @@ describe('createMaestroTestsBuildFunction', () => {
     );
   });
 
-  it('never scans flow files when all attempts succeed', async () => {
-    mockedSpawn.mockResolvedValue(SPAWN_SUCCESS);
-    const discoverySpy = jest.spyOn(discovery, 'buildFlowNameToPathMap');
-
-    const step = createStep({ flow_path: ['flows/a.yaml'], platform: 'android' });
-    await step.executeAsync();
-
-    expect(discoverySpy).not.toHaveBeenCalled();
-  });
-
-  it('memoizes the flow scan across retries (legacy reports)', async () => {
-    // Routing note: the step lands in the legacy arm because the real
-    // junitFileHasFileAttrs returns false — the attempt XML does not exist on
-    // the mock fs. Creating that file with file= attrs would flip the branch.
-    mockedSpawn
-      .mockRejectedValueOnce(rejectExit1())
-      .mockRejectedValueOnce(rejectExit1())
-      .mockResolvedValueOnce(SPAWN_SUCCESS);
-    const discoverySpy = jest
-      .spyOn(discovery, 'buildFlowNameToPathMap')
-      .mockResolvedValue(new Map([['a', 'flows/a.yaml']]));
-    const parseSpy = jest
-      .spyOn(parser, 'parseFailedFlowsFromJUnit')
-      .mockResolvedValue(['flows/a.yaml']);
-
-    const step = createStep({
-      flow_path: ['flows/a.yaml'],
-      retries: 2,
-      output_format: 'junit',
-      platform: 'android',
-    });
-    await step.executeAsync();
-
-    // Two failed attempts hit the legacy branch twice; the scan runs once.
-    expect(parseSpy).toHaveBeenCalledTimes(2);
-    expect(discoverySpy).toHaveBeenCalledTimes(1);
-  });
-
   it('defaults retry_failed_only to true when omitted from inputs', async () => {
     mockedSpawn.mockRejectedValueOnce(rejectExit1()).mockResolvedValueOnce(SPAWN_SUCCESS);
     jest.spyOn(parser, 'parseFailedFlowsFromJUnit').mockResolvedValue(['flows/b.yaml']);
@@ -742,149 +639,4 @@ describe('createMaestroTestsBuildFunction', () => {
     const step = createStep({ flow_path: ['a.yaml'], platform: 'android' }); // no shards
     await step.executeAsync(); // should succeed, not throw
   });
-
-  it('uploads harvested screenshots after the retry loop with metadata', async () => {
-    mockedSpawn.mockResolvedValue(SPAWN_SUCCESS);
-    const shot = makeShot(0);
-    await fs.writeFile(shot.fileAbsPath, '');
-    mockedHarvest.mockResolvedValue([shot]);
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-    await step.executeAsync();
-
-    expect(mockUploadArtifact).toHaveBeenCalledTimes(1);
-    expect(mockUploadArtifact).toHaveBeenCalledWith(
-      expect.objectContaining({
-        artifact: expect.objectContaining({
-          type: GenericArtifactType.OTHER,
-          name: shot.displayName,
-          metadata: shot.metadata,
-        }),
-      })
-    );
-  });
-
-  it('uploads screenshots even when all attempts fail, before throwing ERR_MAESTRO_TESTS_FAILED', async () => {
-    mockedSpawn.mockRejectedValue(rejectExit1());
-    const shot = makeShot(0);
-    await fs.writeFile(shot.fileAbsPath, '');
-    mockedHarvest.mockResolvedValue([shot]);
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-    await expect(step.executeAsync()).rejects.toThrow(UserError);
-
-    expect(mockUploadArtifact).toHaveBeenCalledTimes(1);
-  });
-
-  it('swallows upload errors without affecting the test verdict', async () => {
-    mockedSpawn.mockResolvedValue(SPAWN_SUCCESS);
-    const shot = makeShot(0);
-    await fs.writeFile(shot.fileAbsPath, '');
-    mockedHarvest.mockResolvedValue([shot]);
-    mockUploadArtifact.mockRejectedValue(new Error('upload boom'));
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-    await step.executeAsync();
-
-    expect(mockUploadArtifact).toHaveBeenCalledTimes(1);
-  });
-
-  it('skips screenshot upload but preserves the verdict when the JUnit re-parse throws', async () => {
-    mockedSpawn.mockRejectedValue(rejectExit1());
-    mockedHarvest.mockResolvedValue([makeShot(0)]);
-    jest.spyOn(parser, 'parseJUnitTestCases').mockRejectedValue(new Error('malformed junit'));
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-
-    // The classify throw is swallowed; the maestro failure verdict still surfaces.
-    await expect(step.executeAsync()).rejects.toThrow(UserError);
-    expect(mockUploadArtifact).not.toHaveBeenCalled();
-  });
-
-  it('skips screenshot upload but preserves the verdict when the staging dir cannot be created', async () => {
-    mockedSpawn.mockRejectedValue(rejectExit1());
-    mockedHarvest.mockResolvedValue([makeShot(0)]);
-    jest.spyOn(parser, 'parseJUnitTestCases').mockResolvedValue([]);
-    jest.spyOn(fs, 'mkdtemp').mockRejectedValue(new Error('no tmp space'));
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-
-    // mkdtemp failure is swallowed; the maestro failure verdict still surfaces.
-    await expect(step.executeAsync()).rejects.toThrow(UserError);
-    expect(mockUploadArtifact).not.toHaveBeenCalled();
-  });
-
-  it('caps uploads at 30 screenshots (excess dropped)', async () => {
-    mockedSpawn.mockResolvedValue(SPAWN_SUCCESS);
-    const shots = Array.from({ length: 35 }, (_, index) => makeShot(index));
-    await Promise.all(shots.map(shot => fs.writeFile(shot.fileAbsPath, '')));
-    mockedHarvest.mockResolvedValue(shots);
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-    await step.executeAsync();
-
-    expect(mockUploadArtifact).toHaveBeenCalledTimes(30);
-  });
-
-  it('does not harvest or upload screenshots when output_format is not junit', async () => {
-    mockedSpawn.mockResolvedValue(SPAWN_SUCCESS);
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'html' });
-    await step.executeAsync();
-
-    expect(mockedHarvest).not.toHaveBeenCalled();
-    expect(mockUploadArtifact).not.toHaveBeenCalled();
-  });
-
-  it('uploads only the final attempt for a pure-failure flow, but every attempt for a flaky flow', async () => {
-    mockedSpawn.mockResolvedValue(SPAWN_SUCCESS);
-    const tc = (name: string, status: 'passed' | 'failed'): parser.JUnitTestCaseResult => ({
-      name,
-      file: undefined,
-      status,
-      duration: 0,
-      errorMessage: null,
-      tags: [],
-      properties: {},
-    });
-    jest
-      .spyOn(parser, 'parseJUnitTestCases')
-      .mockResolvedValue([
-        tc('PureFlow', 'failed'),
-        tc('FlakyFlow', 'failed'),
-        tc('FlakyFlow', 'passed'),
-      ]);
-
-    const makeShotFor = (
-      flowName: string,
-      attemptIndex: number
-    ): maestroScreenshots.HarvestedScreenshot => ({
-      fileAbsPath: path.join(os.tmpdir(), `wiring-${flowName}-${attemptIndex}.png`),
-      displayName: `Failure Screenshot: ${flowName} (attempt ${attemptIndex + 1})`,
-      metadata: {
-        kind: 'maestro-test-screenshot',
-        flowName,
-        attemptIndex,
-        capturedAtMs: 1781186692250 + attemptIndex,
-      },
-    });
-    const shots = [
-      makeShotFor('PureFlow', 0),
-      makeShotFor('PureFlow', 1),
-      makeShotFor('FlakyFlow', 0),
-      makeShotFor('FlakyFlow', 1),
-    ];
-    await Promise.all(shots.map(shot => fs.writeFile(shot.fileAbsPath, '')));
-    mockedHarvest.mockResolvedValue(shots);
-
-    const step = createStep({ flow_path: ['a.yaml'], platform: 'android', output_format: 'junit' });
-    await step.executeAsync();
-
-    // PureFlow keeps only its final attempt (1); FlakyFlow keeps every failed attempt.
-    // Uploads run concurrently, so compare the set, not the order.
-    const uploaded = mockUploadArtifact.mock.calls
-      .map(([arg]) => `${arg.artifact.metadata.flowName}#${arg.artifact.metadata.attemptIndex}`)
-      .sort();
-    expect(uploaded).toEqual(['FlakyFlow#0', 'FlakyFlow#1', 'PureFlow#1']);
-  });
 });

packages/build-tools/src/steps/functions/__tests__/repack.test.ts

@@ -27,7 +27,7 @@ describe(createRepackBuildFunction, () => {
     vol.reset();
   });
 
-  it('should set generated output path for successful repack', async () => {
+  it('should set the output path for successful repack', async () => {
     const repack = createRepackBuildFunction();
     const repackStep = repack.createBuildStepFromFunctionCall(
       createGlobalContextMock({
@@ -38,33 +38,14 @@ describe(createRepackBuildFunction, () => {
       {
         callInputs: {
           platform: 'ios',
-          source_app_path: '/path/to/source_app.ipa',
+          source_app_path: '/path/to/source_app',
+          output_path: '/path/to/output_app',
         },
       }
     );
 
     await repackStep.executeAsync();
-    expect(repackStep.outputById['output_path'].value).toMatch(/repacked-.*\.ipa$/);
-  });
-
-  it('should rename generated aab output path to apk', async () => {
-    const repack = createRepackBuildFunction();
-    const repackStep = repack.createBuildStepFromFunctionCall(
-      createGlobalContextMock({
-        staticContextContent: {
-          job: createTestAndroidJob(),
-        },
-      }),
-      {
-        callInputs: {
-          platform: 'android',
-          source_app_path: '/path/to/source_app.aab',
-        },
-      }
-    );
-
-    await repackStep.executeAsync();
-    expect(repackStep.outputById['output_path'].value).toMatch(/repacked-.*\.apk$/);
+    expect(repackStep.outputById['output_path'].value).toBe('/path/to/output_app');
   });
 
   it('should throw for unsupported platforms', async () => {

packages/build-tools/src/steps/functions/__tests__/reportMaestroTestResults.test.ts

@@ -3,7 +3,6 @@ import { vol } from 'memfs';
 
 import { createGlobalContextMock } from '../../../__tests__/utils/context';
 import { createMockLogger } from '../../../__tests__/utils/logger';
-import * as discovery from '../maestroFlowDiscovery';
 import { createReportMaestroTestResultsFunction } from '../reportMaestroTestResults';
 
 const JUNIT_PASS = [
@@ -44,24 +43,15 @@ describe(createReportMaestroTestResultsFunction, () => {
     } as unknown as Client;
   });
 
-  // Returns a mock logger whose child() is itself, so step-level log calls can
-  // be asserted on the returned object.
-  function createSelfChildedLogger(): ReturnType<typeof createMockLogger> {
-    const logger = createMockLogger();
-    (logger.child as jest.Mock).mockReturnValue(logger);
-    return logger;
-  }
-
   function createStep(overrides?: {
     callInputs?: Record<string, unknown>;
     staticContextContent?: Record<string, unknown>;
     env?: Record<string, string>;
-    logger?: ReturnType<typeof createMockLogger>;
   }) {
     const ctx = { graphqlClient: mockGraphqlClient };
     const fn = createReportMaestroTestResultsFunction(ctx as any);
     const globalCtx = createGlobalContextMock({
-      logger: overrides?.logger ?? createMockLogger(),
+      logger: createMockLogger(),
       projectTargetDirectory: '/root/project',
       staticContextContent: {
         expoApiServerURL: 'https://api.expo.test',
@@ -115,54 +105,6 @@ describe(createReportMaestroTestResultsFunction, () => {
     ]);
   });
 
-  it('reports both flows when two share a name but have distinct file= paths', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file="a/login.yaml" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="login" file="b/login.yaml" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    mockMutationFn.mockResolvedValue({
-      data: {
-        workflowDeviceTestCaseResult: {
-          createWorkflowDeviceTestCaseResults: [{ id: '1' }, { id: '2' }],
-        },
-      },
-    });
-    await createStep().executeAsync();
-    expect(mockGraphqlClient.mutation).toHaveBeenCalledTimes(1);
-    const [, variables] = (mockGraphqlClient.mutation as jest.Mock).mock.calls[0];
-    expect(variables.input.testCaseResults.map((r: any) => r.path).sort()).toEqual([
-      'a/login.yaml',
-      'b/login.yaml',
-    ]);
-  });
-
-  it('never scans flow files for a file= report, even when flow_path is provided', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file="flows/login.yaml" status="SUCCESS" time="1.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-    const discoverySpy = jest.spyOn(discovery, 'buildFlowNameToPathMap');
-    mockMutationFn.mockResolvedValue({
-      data: {
-        workflowDeviceTestCaseResult: { createWorkflowDeviceTestCaseResults: [{ id: '1' }] },
-      },
-    });
-
-    await createStep({ callInputs: { flow_path: ['flows/login.yaml'] } }).executeAsync();
-
-    expect(mockGraphqlClient.mutation).toHaveBeenCalledTimes(1);
-    expect(discoverySpy).not.toHaveBeenCalled();
-  });
-
   it('sends tags and properties from JUnit XML', async () => {
     vol.fromJSON({
       '/junit/report.xml': [
@@ -279,7 +221,7 @@ describe(createReportMaestroTestResultsFunction, () => {
     await createStep().executeAsync();
   });
 
-  it('skips report when duplicate testcase names found (legacy), advising unique names', async () => {
+  it('skips report when duplicate testcase names found', async () => {
     vol.fromJSON({
       '/junit/report.xml': [
         '<?xml version="1.0"?>',
@@ -296,27 +238,8 @@ describe(createReportMaestroTestResultsFunction, () => {
       }),
     });
 
-    const logger = createSelfChildedLogger();
-    await createStep({ logger }).executeAsync();
+    await createStep().executeAsync();
     expect(mockGraphqlClient.mutation).not.toHaveBeenCalled();
-    expect(logger.error).toHaveBeenCalledWith(expect.stringContaining('unique name'));
-  });
-
-  it('skips report when the same flow file appears twice in one attempt, advising flow_path check', async () => {
-    vol.fromJSON({
-      '/junit/report.xml': [
-        '<?xml version="1.0"?>',
-        '<testsuites><testsuite>',
-        '  <testcase name="login" file="flows/login.yaml" status="SUCCESS" time="1.0"/>',
-        '  <testcase name="login" file="flows/login.yaml" status="SUCCESS" time="2.0"/>',
-        '</testsuite></testsuites>',
-      ].join('\n'),
-    });
-
-    const logger = createSelfChildedLogger();
-    await createStep({ logger }).executeAsync();
-    expect(mockGraphqlClient.mutation).not.toHaveBeenCalled();
-    expect(logger.error).toHaveBeenCalledWith(expect.stringContaining('flow_path entries'));
   });
 
   it('sends per-attempt results with same name but different retryCount', async () => {

packages/build-tools/src/steps/functions/__tests__/rolloutPosthogFlag.test.ts

@@ -1,443 +0,0 @@
-import fetch, { Response } from 'node-fetch';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { createRolloutPosthogFlagFunction } from '../rolloutPosthogFlag';
-
-jest.mock('@expo/logger');
-jest.mock('node-fetch');
-
-function jsonResponse(data: unknown, { ok = true, status = 200 } = {}): Response {
-  return {
-    ok,
-    status,
-    json: async () => data,
-    text: async () => JSON.stringify(data),
-  } as unknown as Response;
-}
-
-const ENV = {
-  POSTHOG_CLI_API_KEY: 'phx_test',
-  POSTHOG_CLI_PROJECT_ID: '123',
-  POSTHOG_CLI_HOST: 'https://us.posthog.com',
-};
-
-describe(createRolloutPosthogFlagFunction, () => {
-  const fetchMock = jest.mocked(fetch);
-  const rolloutFlag = createRolloutPosthogFlagFunction();
-
-  afterEach(() => {
-    jest.resetAllMocks();
-  });
-
-  function createStep(
-    callInputs: Record<string, unknown>,
-    env: Record<string, string> = ENV
-  ): ReturnType<typeof rolloutFlag.createBuildStepFromFunctionCall> {
-    return rolloutFlag.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs,
-      env,
-      id: rolloutFlag.id,
-    });
-  }
-
-  it('enables a flag by key', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({ id: 42 }));
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await step.executeAsync();
-
-    const [patchUrl, patchInit] = fetchMock.mock.calls[1];
-    expect(patchUrl).toBe('https://us.posthog.com/api/projects/123/feature_flags/42/');
-    expect(patchInit?.method).toBe('PATCH');
-    expect(JSON.parse(patchInit?.body as string)).toEqual({ active: true });
-  });
-
-  it('sets rollout_percentage only on the catch-all group, preserving others', async () => {
-    fetchMock
-      .mockResolvedValueOnce(
-        jsonResponse({
-          results: [
-            {
-              id: 7,
-              key: 'gradual',
-              filters: {
-                groups: [
-                  { properties: [{ key: 'is_internal' }], rollout_percentage: 100 },
-                  { properties: [], rollout_percentage: 5 },
-                ],
-              },
-            },
-          ],
-        })
-      )
-      .mockResolvedValueOnce(jsonResponse({ id: 7 }));
-    const step = createStep({ flag: 'gradual', rollout_percentage: '50' });
-
-    await step.executeAsync();
-
-    const patchBody = JSON.parse(fetchMock.mock.calls[1][1]?.body as string);
-    expect(patchBody.filters.groups).toEqual([
-      { properties: [{ key: 'is_internal' }], rollout_percentage: 100 },
-      { properties: [], rollout_percentage: 50 },
-    ]);
-  });
-
-  it('creates a catch-all group when the flag has none', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 8, key: 'bare', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({ id: 8 }));
-    const step = createStep({ flag: 'bare', rollout_percentage: '25' });
-
-    await step.executeAsync();
-
-    const patchBody = JSON.parse(fetchMock.mock.calls[1][1]?.body as string);
-    expect(patchBody.filters.groups).toEqual([{ properties: [], rollout_percentage: 25 }]);
-  });
-
-  it('falls back to the first group with a warning when no catch-all exists', async () => {
-    fetchMock
-      .mockResolvedValueOnce(
-        jsonResponse({
-          results: [
-            {
-              id: 9,
-              key: 'scoped',
-              filters: { groups: [{ properties: [{ key: 'is_internal' }] }] },
-            },
-          ],
-        })
-      )
-      .mockResolvedValueOnce(jsonResponse({ id: 9 }));
-    const step = createStep({ flag: 'scoped', rollout_percentage: '10' });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    const patchBody = JSON.parse(fetchMock.mock.calls[1][1]?.body as string);
-    expect(patchBody.filters.groups).toEqual([
-      { properties: [{ key: 'is_internal' }], rollout_percentage: 10 },
-    ]);
-    expect(warnMock).toHaveBeenCalledWith(expect.stringMatching(/no catch-all/));
-  });
-
-  it('throws when the flag key does not exist', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ results: [{ id: 1, key: 'other-flag' }] }));
-    const step = createStep({ flag: 'missing-flag', active: 'true' });
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /No PostHog feature flag with key "missing-flag"/
-    );
-  });
-
-  it('throws on a 403 even when ignore_error is set', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 403 }));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-
-    await expect(step.executeAsync()).rejects.toThrow(/forbidden \(403\)/);
-  });
-
-  it('throws when none of active, rollout_percentage, or payload is provided', async () => {
-    const step = createStep({ flag: 'my-flag' });
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /"active", "rollout_percentage", or "payload"/
-    );
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('sets a boolean-flag payload under the "true" key as a JSON string', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({ id: 42 }));
-    const step = createStep({ flag: 'my-flag', payload: { color: 'blue', count: 3 } });
-
-    await step.executeAsync();
-
-    const patchBody = JSON.parse(fetchMock.mock.calls[1][1]?.body as string);
-    expect(patchBody.filters.payloads).toEqual({ true: '{"color":"blue","count":3}' });
-  });
-
-  it('keys the payload under a given variant', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({ id: 42 }));
-    const step = createStep({ flag: 'my-flag', payload: { v: 1 }, variant: 'control' });
-
-    await step.executeAsync();
-
-    const patchBody = JSON.parse(fetchMock.mock.calls[1][1]?.body as string);
-    expect(patchBody.filters.payloads).toEqual({ control: '{"v":1}' });
-  });
-
-  it('sets rollout_percentage and payload together in one filters object', async () => {
-    fetchMock
-      .mockResolvedValueOnce(
-        jsonResponse({
-          results: [{ id: 7, key: 'my-flag', filters: { groups: [{ properties: [] }] } }],
-        })
-      )
-      .mockResolvedValueOnce(jsonResponse({ id: 7 }));
-    const step = createStep({ flag: 'my-flag', rollout_percentage: 25, payload: { a: 1 } });
-
-    await step.executeAsync();
-
-    const patchBody = JSON.parse(fetchMock.mock.calls[1][1]?.body as string);
-    expect(patchBody.filters.groups[0].rollout_percentage).toBe(25);
-    expect(patchBody.filters.payloads).toEqual({ true: '{"a":1}' });
-  });
-
-  it('surfaces the PostHog error detail on a failed update', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(
-        jsonResponse(
-          { type: 'validation_error', detail: 'Variant control does not exist' },
-          { ok: false, status: 400 }
-        )
-      );
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /failed with status 400: Variant control does not exist/
-    );
-  });
-
-  it('falls back to the raw body when the error body is not JSON', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce({
-        ok: false,
-        status: 502,
-        text: async () => 'Bad Gateway',
-      } as unknown as Response);
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/failed with status 502: Bad Gateway/);
-  });
-
-  it('warns and skips when the flag is not found and ignore_error is set', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ results: [] }));
-    const step = createStep({ flag: 'missing-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/No PostHog feature flag with key "missing-flag"/)
-    );
-  });
-
-  it('throws on an out-of-range rollout_percentage', async () => {
-    const step = createStep({ flag: 'my-flag', rollout_percentage: '150' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/between 0 and 100/);
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('throws when credentials are missing by default', async () => {
-    const step = createStep({ flag: 'my-flag', active: 'true' }, {});
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /Missing PostHog credentials: personal API key, project id/
-    );
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('warns and skips on missing credentials when ignore_error is set', async () => {
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true }, {});
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(fetchMock).not.toHaveBeenCalled();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error\.$/)
-    );
-  });
-
-  it('throws on a failed update by default', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 500 }));
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/failed with status 500/);
-  });
-
-  it('warns and skips on a failed update when ignore_error is set', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 500 }));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'Updating PostHog flag "my-flag" failed with status 500: {}. Ignoring error.'
-    );
-  });
-
-  it('warns and skips on a lookup network error when ignore_error is set', async () => {
-    fetchMock.mockRejectedValueOnce(new Error('ECONNRESET'));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'Looking up PostHog flag "my-flag" failed. Ignoring error.'
-    );
-  });
-
-  it('warns and skips on a non-object lookup response when ignore_error is set', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse('not-json-object'));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.anything() },
-      expect.stringMatching(/unexpected response/)
-    );
-  });
-
-  it('warns and skips on an unexpected lookup response when ignore_error is set', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ nope: true }));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.anything() },
-      expect.stringMatching(/unexpected response/)
-    );
-  });
-
-  it('ignores malformed entries in the lookup results', async () => {
-    fetchMock
-      .mockResolvedValueOnce(
-        jsonResponse({ results: ['junk', null, { id: 42, key: 'my-flag', filters: {} }] })
-      )
-      .mockResolvedValueOnce(jsonResponse({ id: 42 }));
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('throws on a failed lookup by default', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 500 }));
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /Looking up PostHog flag "my-flag" failed with status 500/
-    );
-  });
-
-  it('warns and skips on a failed lookup when ignore_error is set', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 500 }));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'Looking up PostHog flag "my-flag" failed with status 500: {}. Ignoring error.'
-    );
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-  });
-
-  it('warns and skips on an update network error when ignore_error is set', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockRejectedValueOnce(new Error('ECONNRESET'));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'Updating PostHog flag "my-flag" failed. Ignoring error.'
-    );
-  });
-
-  it('throws on a 403 update even when ignore_error is set', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 403 }));
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-
-    await expect(step.executeAsync()).rejects.toThrow(/feature_flag:write/);
-  });
-
-  it('debugs the underlying error before throwing on a network failure by default', async () => {
-    fetchMock.mockRejectedValueOnce(new Error('ECONNRESET'));
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-    const debugMock = jest.spyOn(step.ctx.logger, 'debug');
-
-    await expect(step.executeAsync()).rejects.toThrow(/Looking up PostHog flag "my-flag" failed/);
-    expect(debugMock).toHaveBeenCalled();
-  });
-
-  it('throws on an invalid JSON lookup response by default', async () => {
-    fetchMock.mockResolvedValueOnce({
-      ok: true,
-      status: 200,
-      json: async () => {
-        throw new Error('unexpected token');
-      },
-    } as unknown as Response);
-    const step = createStep({ flag: 'my-flag', active: 'true' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/returned an unexpected response/);
-  });
-
-  it('warns and skips on an invalid JSON lookup response when ignore_error is set', async () => {
-    fetchMock.mockResolvedValueOnce({
-      ok: true,
-      status: 200,
-      json: async () => {
-        throw new Error('unexpected token');
-      },
-    } as unknown as Response);
-    const step = createStep({ flag: 'my-flag', active: 'true', ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      'PostHog flag lookup for "my-flag" returned an unexpected response. Ignoring error.'
-    );
-  });
-
-  it('throws on a non-integer rollout_percentage', async () => {
-    const step = createStep({ flag: 'my-flag', rollout_percentage: 25.5 });
-
-    await expect(step.executeAsync()).rejects.toThrow(/must be an integer between 0 and 100/);
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('falls back to the default host when POSTHOG_CLI_HOST is unset', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [{ id: 42, key: 'my-flag', filters: {} }] }))
-      .mockResolvedValueOnce(jsonResponse({ id: 42 }));
-    const step = createStep(
-      { flag: 'my-flag', active: 'true' },
-      { POSTHOG_CLI_API_KEY: 'phx_test', POSTHOG_CLI_PROJECT_ID: '123' }
-    );
-
-    await step.executeAsync();
-
-    const [searchUrl] = fetchMock.mock.calls[0];
-    expect(searchUrl).toBe(
-      'https://us.posthog.com/api/projects/123/feature_flags/?limit=200&search=my-flag'
-    );
-  });
-});

packages/build-tools/src/steps/functions/__tests__/startArgentRemoteSession.test.ts

@@ -1,145 +0,0 @@
-import { SystemError } from '@expo/eas-build-job';
-import { type bunyan } from '@expo/logger';
-import fs from 'node:fs';
-import os from 'node:os';
-import path from 'node:path';
-
-import {
-  MIN_ARGENT_REMOTE_SESSION_VERSION,
-  waitForArgentToolServerStateAsync,
-  warnIfArgentPackageVersionCannotBeVerified,
-} from '../startArgentRemoteSession';
-
-describe(warnIfArgentPackageVersionCannotBeVerified, () => {
-  const warn = jest.fn();
-  const logger = { warn } as unknown as bunyan;
-  const supportedVersion = '999.0.0';
-  const oldVersion = '0.0.0';
-
-  beforeEach(() => {
-    warn.mockClear();
-  });
-
-  it('allows the default latest package version', () => {
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion: undefined, logger })
-    ).not.toThrow();
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion: 'latest', logger })
-    ).not.toThrow();
-    expect(warn).not.toHaveBeenCalled();
-  });
-
-  it('allows exact supported semver versions', () => {
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({
-        packageVersion: MIN_ARGENT_REMOTE_SESSION_VERSION,
-        logger,
-      })
-    ).not.toThrow();
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion: supportedVersion, logger })
-    ).not.toThrow();
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({
-        packageVersion: `v${supportedVersion}`,
-        logger,
-      })
-    ).not.toThrow();
-    expect(warn).not.toHaveBeenCalled();
-  });
-
-  it('rejects exact semver versions that are too old', () => {
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion: oldVersion, logger })
-    ).toThrow(SystemError);
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion: oldVersion, logger })
-    ).toThrow(`Use "latest" or pass an exact version >= ${MIN_ARGENT_REMOTE_SESSION_VERSION}`);
-  });
-
-  it('warns for package tags or ranges that cannot be verified', () => {
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion: 'next', logger })
-    ).not.toThrow();
-    expect(() =>
-      warnIfArgentPackageVersionCannotBeVerified({
-        packageVersion: `^${MIN_ARGENT_REMOTE_SESSION_VERSION}`,
-        logger,
-      })
-    ).not.toThrow();
-    expect(warn).toHaveBeenCalledTimes(2);
-    expect(warn).toHaveBeenCalledWith(
-      expect.stringContaining('Continuing and letting bunx resolve it.')
-    );
-  });
-});
-
-describe(waitForArgentToolServerStateAsync, () => {
-  let stateDir: string;
-
-  beforeEach(async () => {
-    stateDir = await fs.promises.mkdtemp(path.join(os.tmpdir(), 'argent-state-test-'));
-  });
-
-  afterEach(async () => {
-    await fs.promises.rm(stateDir, { recursive: true, force: true });
-  });
-
-  function stateJson({ port, pid, token }: { port: number; pid: number; token?: string }): string {
-    return JSON.stringify({ port, pid, token });
-  }
-
-  it.each(['tool-server.json', 'tool-server-012345abcdef.json'])(
-    'reads a matching process from %s',
-    async fileName => {
-      await fs.promises.writeFile(
-        path.join(stateDir, fileName),
-        stateJson({ port: 4321, pid: process.pid, token: 'secret' })
-      );
-
-      await expect(
-        waitForArgentToolServerStateAsync({
-          stateDir,
-          ancestorPid: process.ppid,
-          timeoutMs: 100,
-          pollIntervalMs: 1,
-        })
-      ).resolves.toEqual({ port: 4321, pid: process.pid, token: 'secret' });
-    }
-  );
-
-  it('selects the state whose pid belongs to the launched process tree', async () => {
-    await fs.promises.writeFile(
-      path.join(stateDir, 'tool-server-111111111111.json'),
-      stateJson({ port: 1111, pid: Number.MAX_SAFE_INTEGER })
-    );
-    await fs.promises.writeFile(
-      path.join(stateDir, 'tool-server-222222222222.json'),
-      stateJson({ port: 2222, pid: process.pid })
-    );
-
-    await expect(
-      waitForArgentToolServerStateAsync({
-        stateDir,
-        ancestorPid: process.ppid,
-        timeoutMs: 100,
-        pollIntervalMs: 1,
-      })
-    ).resolves.toEqual({ port: 2222, pid: process.pid });
-  });
-
-  it('does not return a state file outside the launched process tree', async () => {
-    const filePath = path.join(stateDir, 'tool-server-012345abcdef.json');
-    await fs.promises.writeFile(filePath, stateJson({ port: 1111, pid: Number.MAX_SAFE_INTEGER }));
-
-    await expect(
-      waitForArgentToolServerStateAsync({
-        stateDir,
-        ancestorPid: process.pid,
-        timeoutMs: 10,
-        pollIntervalMs: 1,
-      })
-    ).rejects.toThrow(`state file belonging to process ${process.pid}`);
-  });
-});

packages/build-tools/src/steps/functions/__tests__/startIosSimulator.test.ts

@@ -15,7 +15,6 @@ jest.mock('../../../utils/IosSimulatorUtils', () => ({
     getAvailableDevicesAsync: jest.fn(),
     getDeviceAsync: jest.fn(),
     cloneAsync: jest.fn(),
-    enableAccessibilitySettingsAsync: jest.fn(),
     startAsync: jest.fn(),
     waitForReadyAsync: jest.fn(),
     disableApsdAsync: jest.fn(),
@@ -35,59 +34,15 @@ function createStep(callInputs?: Record<string, unknown>) {
 
 describe(createStartIosSimulatorBuildFunction, () => {
   beforeEach(() => {
-    jest.clearAllMocks();
     mockedSpawn.mockResolvedValue({ stdout: '', stderr: '' } as any);
     mockedUtils.getAvailableDevicesAsync.mockResolvedValue([]);
     mockedUtils.getDeviceAsync.mockResolvedValue(null);
     mockedUtils.cloneAsync.mockResolvedValue(undefined);
-    mockedUtils.enableAccessibilitySettingsAsync.mockResolvedValue(undefined);
     mockedUtils.startAsync.mockResolvedValue({ udid: 'test-udid' as any });
     mockedUtils.waitForReadyAsync.mockResolvedValue(undefined);
     mockedUtils.disableApsdAsync.mockResolvedValue(undefined);
   });
 
-  it('does not enable accessibility settings by default', async () => {
-    await createStep({ device_identifier: 'iPhone 15' }).executeAsync();
-
-    expect(mockedUtils.enableAccessibilitySettingsAsync).not.toHaveBeenCalled();
-    expect(mockedUtils.startAsync).toHaveBeenCalledWith({
-      deviceIdentifier: 'iPhone 15',
-      env: expect.any(Object),
-    });
-  });
-
-  it('enables accessibility settings before starting the main device and every clone when requested', async () => {
-    mockedUtils.startAsync
-      .mockResolvedValueOnce({ udid: 'base' as any })
-      .mockResolvedValueOnce({ udid: 'clone-1' as any })
-      .mockResolvedValueOnce({ udid: 'clone-2' as any });
-
-    await createStep({
-      device_identifier: 'iPhone 15',
-      count: 2,
-      enable_accessibility_settings: true,
-    }).executeAsync();
-
-    expect(mockedUtils.enableAccessibilitySettingsAsync).toHaveBeenCalledWith({
-      deviceIdentifier: 'iPhone 15',
-      env: expect.any(Object),
-    });
-    expect(mockedUtils.enableAccessibilitySettingsAsync).toHaveBeenCalledWith({
-      deviceIdentifier: 'eas-simulator-1',
-      env: expect.any(Object),
-    });
-    expect(mockedUtils.enableAccessibilitySettingsAsync).toHaveBeenCalledWith({
-      deviceIdentifier: 'eas-simulator-2',
-      env: expect.any(Object),
-    });
-    for (const [callIndex] of mockedUtils.startAsync.mock.calls.entries()) {
-      const enableCallOrder =
-        mockedUtils.enableAccessibilitySettingsAsync.mock.invocationCallOrder[callIndex];
-      const startCallOrder = mockedUtils.startAsync.mock.invocationCallOrder[callIndex];
-      expect(enableCallOrder).toBeLessThan(startCallOrder);
-    }
-  });
-
   it('disables apsd on the main device and every clone', async () => {
     mockedUtils.startAsync
       .mockResolvedValueOnce({ udid: 'base' as any })

packages/build-tools/src/steps/functions/__tests__/uploadArtifact.test.ts

@@ -120,44 +120,4 @@ describe(createUploadArtifactBuildFunction, () => {
     const typeInput = buildStep.inputs?.find(input => input.id === 'type')!;
     expect(typeInput.isRawValueOneOfAllowedValues()).toBe(false);
   });
-
-  it('passes the metadata input through to runtimeApi.uploadArtifact', async () => {
-    contextUploadArtifact.mockClear();
-    const metadata = { kind: 'screen-recording', startedAtMs: '123', device: 'emulator-5554' };
-    const buildStep = uploadArtifact.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs: {
-        // Generic ('other') artifact: only generic artifacts persist metadata in the worker
-        // (the managed-type upload paths drop it), so that's the type metadata is meant for.
-        type: 'other',
-        key: 'Screen Recording',
-        path: '/',
-        metadata,
-      },
-    });
-
-    await buildStep.executeAsync();
-
-    expect(contextUploadArtifact).toHaveBeenCalledWith(
-      expect.objectContaining({ artifact: expect.objectContaining({ metadata }) })
-    );
-  });
-
-  it('does not attach metadata to managed artifact types (the worker drops it)', async () => {
-    contextUploadArtifact.mockClear();
-    const buildStep = uploadArtifact.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs: {
-        type: 'build-artifact',
-        path: '/',
-        metadata: { kind: 'screen-recording' },
-      },
-    });
-
-    await buildStep.executeAsync();
-
-    expect(contextUploadArtifact).toHaveBeenCalledWith(
-      expect.objectContaining({
-        artifact: expect.not.objectContaining({ metadata: expect.anything() }),
-      })
-    );
-  });
 });

packages/build-tools/src/steps/functions/__tests__/uploadDeviceRunSessionScreenRecordings.test.ts

@@ -1,67 +0,0 @@
-import { BuildRuntimePlatform } from '@expo/steps';
-import fs from 'node:fs/promises';
-import os from 'node:os';
-import path from 'node:path';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { type CustomBuildContext } from '../../../customBuildContext';
-import { uploadDeviceRunSessionArtifactAsync } from '../../utils/deviceRunSessionArtifacts';
-import { createUploadDeviceRunSessionScreenRecordingsBuildFunction } from '../uploadDeviceRunSessionScreenRecordings';
-
-jest.mock('../../utils/deviceRunSessionArtifacts', () => ({
-  uploadDeviceRunSessionArtifactAsync: jest.fn(),
-}));
-
-describe(createUploadDeviceRunSessionScreenRecordingsBuildFunction, () => {
-  it('uploads simulator device metadata', async () => {
-    const recordingDirectory = await fs.mkdtemp(path.join(os.tmpdir(), 'ios-recording-test-'));
-    const recordingPath = path.join(recordingDirectory, 'recording.mp4');
-    await fs.writeFile(recordingPath, 'recording');
-    await fs.writeFile(
-      path.join(recordingDirectory, 'session.json'),
-      JSON.stringify({
-        recording: path.basename(recordingPath),
-        firstFrameWallClock: { iso8601: '2026-07-10T10:00:00.000Z' },
-      })
-    );
-
-    try {
-      const globalContext = createGlobalContextMock({
-        runtimePlatform: BuildRuntimePlatform.DARWIN,
-      });
-      const buildStep = createUploadDeviceRunSessionScreenRecordingsBuildFunction(
-        {} as CustomBuildContext
-      ).createBuildStepFromFunctionCall(globalContext, {
-        env: { DEVICE_RUN_SESSION_ID: 'device-run-session-id' },
-        callInputs: {
-          recordings_json: [
-            {
-              udid: 'simulator-udid',
-              deviceName: 'iPhone 16',
-              runtimeDisplayName: 'iOS 18.6',
-              directory: recordingDirectory,
-            },
-          ],
-        },
-      });
-
-      await buildStep.executeAsync();
-
-      expect(uploadDeviceRunSessionArtifactAsync).toHaveBeenCalledWith(
-        expect.anything(),
-        expect.objectContaining({
-          name: 'iPhone 16 screen recording',
-          metadata: {
-            __eas_screen_recording: '1',
-            udid: 'simulator-udid',
-            deviceName: 'iPhone 16',
-            runtimeDisplayName: 'iOS 18.6',
-            firstFrameAt: '2026-07-10T10:00:00.000Z',
-          },
-        })
-      );
-    } finally {
-      await fs.rm(recordingDirectory, { recursive: true, force: true });
-    }
-  });
-});

packages/build-tools/src/steps/functions/__tests__/uploadPosthogSourcemaps.test.ts

@@ -1,144 +0,0 @@
-import { PipeMode } from '@expo/logger';
-import spawn from '@expo/turtle-spawn';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { createUploadPosthogSourcemapsFunction } from '../uploadPosthogSourcemaps';
-
-jest.mock('@expo/logger');
-jest.mock('@expo/turtle-spawn');
-
-const spawnMock = jest.mocked(spawn);
-
-const ENV = {
-  POSTHOG_CLI_API_KEY: 'phx_test',
-  POSTHOG_CLI_PROJECT_ID: '123',
-  POSTHOG_CLI_HOST: 'https://us.posthog.com',
-};
-
-describe(createUploadPosthogSourcemapsFunction, () => {
-  const uploadSourcemaps = createUploadPosthogSourcemapsFunction();
-
-  afterEach(() => {
-    jest.resetAllMocks();
-  });
-
-  function createStep(
-    callInputs: Record<string, unknown> = {},
-    env: Record<string, string> = ENV
-  ): ReturnType<typeof uploadSourcemaps.createBuildStepFromFunctionCall> {
-    return uploadSourcemaps.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs,
-      env,
-      id: uploadSourcemaps.id,
-    });
-  }
-
-  it('runs @posthog/cli hermes upload with the resolved credentials and host', async () => {
-    spawnMock.mockResolvedValue({ stdout: '', stderr: '' } as unknown as Awaited<
-      ReturnType<typeof spawn>
-    >);
-    const step = createStep();
-
-    await step.executeAsync();
-
-    expect(spawnMock).toHaveBeenCalledTimes(1);
-    const [command, args, options] = spawnMock.mock.calls[0];
-    expect(command).toBe('npx');
-    expect(args).toEqual([
-      '-y',
-      '@posthog/cli',
-      '--host',
-      'https://us.posthog.com',
-      'hermes',
-      'upload',
-      '--directory',
-      'dist',
-    ]);
-    expect(options?.env).toMatchObject({
-      POSTHOG_CLI_API_KEY: 'phx_test',
-      POSTHOG_CLI_PROJECT_ID: '123',
-    });
-    expect(options?.mode).toBe(PipeMode.COMBINED_AS_STDOUT);
-  });
-
-  it('passes a custom host through to --host', async () => {
-    spawnMock.mockResolvedValue({ stdout: '', stderr: '' } as unknown as Awaited<
-      ReturnType<typeof spawn>
-    >);
-    const step = createStep({}, { ...ENV, POSTHOG_CLI_HOST: 'https://eu.i.posthog.com' });
-
-    await step.executeAsync();
-
-    expect(spawnMock.mock.calls[0][1]).toEqual([
-      '-y',
-      '@posthog/cli',
-      '--host',
-      'https://eu.i.posthog.com',
-      'hermes',
-      'upload',
-      '--directory',
-      'dist',
-    ]);
-  });
-
-  it('uploads the given directory', async () => {
-    spawnMock.mockResolvedValue({ stdout: '', stderr: '' } as unknown as Awaited<
-      ReturnType<typeof spawn>
-    >);
-    const step = createStep({ directory: 'build-output' });
-
-    await step.executeAsync();
-
-    expect(spawnMock.mock.calls[0][1]).toEqual([
-      '-y',
-      '@posthog/cli',
-      '--host',
-      'https://us.posthog.com',
-      'hermes',
-      'upload',
-      '--directory',
-      'build-output',
-    ]);
-  });
-
-  it('throws when credentials are missing by default', async () => {
-    const step = createStep({}, {});
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /Missing PostHog credentials: personal API key, project id/
-    );
-    expect(spawnMock).not.toHaveBeenCalled();
-  });
-
-  it('warns and skips when credentials are missing and ignore_error is set', async () => {
-    const step = createStep({ ignore_error: true }, {});
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(spawnMock).not.toHaveBeenCalled();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error/)
-    );
-  });
-
-  it('throws when the upload fails by default', async () => {
-    spawnMock.mockRejectedValue(new Error('upload failed'));
-    const step = createStep();
-
-    await expect(step.executeAsync()).rejects.toThrow(/Uploading source maps to PostHog failed/);
-  });
-
-  it('warns and continues when the upload fails and ignore_error is set', async () => {
-    spawnMock.mockRejectedValue(new Error('upload failed'));
-    const step = createStep({ ignore_error: true });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(warnMock).toHaveBeenCalledWith(
-      { err: expect.any(Error) },
-      expect.stringMatching(/Ignoring error/)
-    );
-  });
-});

packages/build-tools/src/steps/functions/__tests__/waitForPosthogMetric.test.ts

@@ -1,263 +0,0 @@
-import fetch, { Response } from 'node-fetch';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { createWaitForPosthogMetricFunction } from '../waitForPosthogMetric';
-
-jest.mock('@expo/logger');
-jest.mock('node-fetch');
-
-function jsonResponse(data: unknown, { ok = true, status = 200 } = {}): Response {
-  return {
-    ok,
-    status,
-    json: async () => data,
-    text: async () => JSON.stringify(data),
-  } as unknown as Response;
-}
-
-const ENV = {
-  POSTHOG_CLI_API_KEY: 'phx_test',
-  POSTHOG_CLI_PROJECT_ID: '123',
-  POSTHOG_CLI_HOST: 'https://us.posthog.com',
-};
-
-describe(createWaitForPosthogMetricFunction, () => {
-  const fetchMock = jest.mocked(fetch);
-  const waitForMetric = createWaitForPosthogMetricFunction();
-
-  afterEach(() => {
-    jest.resetAllMocks();
-  });
-
-  function createStep(
-    callInputs: Record<string, unknown>,
-    env: Record<string, string> = ENV
-  ): ReturnType<typeof waitForMetric.createBuildStepFromFunctionCall> {
-    return waitForMetric.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs,
-      env,
-      id: waitForMetric.id,
-    });
-  }
-
-  it('clears when the metric already meets the condition (blocking query)', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ results: [[3]] }));
-    const step = createStep({
-      query: 'select count() from events',
-      operator: 'lt',
-      threshold: '5',
-    });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-    const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('https://us.posthog.com/api/projects/123/query/');
-    expect(JSON.parse(init?.body as string)).toMatchObject({
-      query: { kind: 'HogQLQuery' },
-      refresh: 'blocking',
-    });
-    expect(step.outputById.value.value).toBe('3');
-  });
-
-  it('throws when credentials are missing', async () => {
-    const step = createStep({ query: 'q', operator: 'lt', threshold: '5' }, {});
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /Missing PostHog credentials: personal API key, project id/
-    );
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('throws on an invalid operator', async () => {
-    const step = createStep({ query: 'q', operator: 'between', threshold: '5' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/Invalid "operator"/);
-  });
-
-  it('rejects an Object.prototype key as an operator', async () => {
-    const step = createStep({ query: 'q', operator: 'toString', threshold: '5' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/Invalid "operator"/);
-  });
-
-  it('throws with the PostHog error detail when the query fails to run', async () => {
-    fetchMock.mockResolvedValueOnce(
-      jsonResponse({ detail: 'Malformed HogQL query' }, { ok: false, status: 400 })
-    );
-    const step = createStep({ query: 'bad', operator: 'lt', threshold: '5' });
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /failed with status 400: Malformed HogQL query/
-    );
-  });
-
-  it('retries after a transient 500 and clears when the metric recovers', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({}, { ok: false, status: 500 }))
-      .mockResolvedValueOnce(jsonResponse({ results: [[1]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 5,
-    });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('keeps polling while the query returns no numeric value', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [['not-a-number']] }))
-      .mockResolvedValueOnce(jsonResponse({ results: [[2]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 5,
-    });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('reports a query-shape problem when no numeric value ever arrives', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ results: [['not-a-number']] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 0.15,
-    });
-
-    await expect(step.executeAsync()).rejects.toThrow(/never returned a numeric value/);
-  });
-
-  it('includes the last observed value in the timeout error', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ results: [[10]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 0.15,
-    });
-
-    await expect(step.executeAsync()).rejects.toThrow(/last value: 10/);
-  });
-
-  it('throws on a non-positive interval', async () => {
-    const step = createStep({ query: 'q', operator: 'lt', threshold: '5', interval_seconds: 0 });
-
-    await expect(step.executeAsync()).rejects.toThrow(/greater than 0/);
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it.each([
-    ['lte', 3, 3],
-    ['gt', 10, 5],
-    ['gte', 5, 5],
-    ['eq', 3, 3],
-  ] as const)('clears with the %s operator', async (operator, value, threshold) => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ results: [[value]] }));
-    const step = createStep({ query: 'q', operator, threshold });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-  });
-
-  it('treats a non-numeric non-string cell as no value and keeps polling', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [[true]] }))
-      .mockResolvedValueOnce(jsonResponse({ results: [[1]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 5,
-    });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('retries after a network error and clears when the query recovers', async () => {
-    fetchMock
-      .mockRejectedValueOnce(new Error('ECONNRESET'))
-      .mockResolvedValueOnce(jsonResponse({ results: [[1]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 5,
-    });
-    const warnMock = jest.spyOn(step.ctx.logger, 'warn');
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-    expect(warnMock).toHaveBeenCalledWith(
-      'Running the PostHog query failed with a network error; will retry on the next poll.'
-    );
-  });
-
-  it('retries after an invalid JSON response and clears when the query recovers', async () => {
-    fetchMock
-      .mockResolvedValueOnce({
-        ok: true,
-        status: 200,
-        json: async () => {
-          throw new Error('unexpected token');
-        },
-      } as unknown as Response)
-      .mockResolvedValueOnce(jsonResponse({ results: [[1]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 5,
-    });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('throws on a 403 without retrying', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({}, { ok: false, status: 403 }));
-    const step = createStep({ query: 'q', operator: 'lt', threshold: '5' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/forbidden \(403\)/);
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-  });
-
-  it('keeps polling through malformed response shapes until a numeric value arrives', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [[Infinity]] }))
-      .mockResolvedValueOnce(jsonResponse('not an object'))
-      .mockResolvedValueOnce(jsonResponse({ results: [5] }))
-      .mockResolvedValueOnce(jsonResponse({ results: [[1]] }));
-    const step = createStep({
-      query: 'q',
-      operator: 'lt',
-      threshold: '5',
-      interval_seconds: 0.05,
-      timeout_seconds: 5,
-    });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(4);
-  });
-});

packages/build-tools/src/steps/functions/__tests__/waitForPosthogQuery.test.ts

@@ -1,109 +0,0 @@
-import fetch, { Response } from 'node-fetch';
-
-import { createGlobalContextMock } from '../../../__tests__/utils/context';
-import { createWaitForPosthogQueryFunction } from '../waitForPosthogQuery';
-
-jest.mock('@expo/logger');
-jest.mock('node-fetch');
-
-function jsonResponse(data: unknown, { ok = true, status = 200 } = {}): Response {
-  return { ok, status, json: async () => data } as unknown as Response;
-}
-
-const ENV = {
-  POSTHOG_CLI_API_KEY: 'phx_test',
-  POSTHOG_CLI_PROJECT_ID: '123',
-  POSTHOG_CLI_HOST: 'https://us.posthog.com',
-};
-
-describe(createWaitForPosthogQueryFunction, () => {
-  const fetchMock = jest.mocked(fetch);
-  const waitForQuery = createWaitForPosthogQueryFunction();
-
-  afterEach(() => {
-    jest.resetAllMocks();
-  });
-
-  function createStep(
-    callInputs: Record<string, unknown>,
-    env: Record<string, string> = ENV
-  ): ReturnType<typeof waitForQuery.createBuildStepFromFunctionCall> {
-    return waitForQuery.createBuildStepFromFunctionCall(createGlobalContextMock({}), {
-      callInputs,
-      env,
-      id: waitForQuery.id,
-    });
-  }
-
-  it('resolves when the query returns true', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ results: [[true]] }));
-    const step = createStep({ query: 'SELECT count() > 0 FROM events' });
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-    const [, init] = fetchMock.mock.calls[0];
-    expect(JSON.parse(init?.body as string).query).toEqual({
-      kind: 'HogQLQuery',
-      query: 'SELECT count() > 0 FROM events',
-    });
-  });
-
-  it('resolves when the query returns a nonzero number', async () => {
-    fetchMock.mockResolvedValueOnce(jsonResponse({ results: [[1]] }));
-    const step = createStep({ query: 'q' });
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-  });
-
-  it('keeps polling until the query turns true', async () => {
-    fetchMock
-      .mockResolvedValueOnce(jsonResponse({ results: [[0]] }))
-      .mockResolvedValueOnce(jsonResponse({ results: [[true]] }));
-    const step = createStep({ query: 'q', interval_seconds: 0.05, timeout_seconds: 5 });
-
-    await step.executeAsync();
-
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('keeps polling after a transient failure and clears when the query recovers', async () => {
-    fetchMock
-      .mockRejectedValueOnce(new Error('ECONNRESET'))
-      .mockResolvedValueOnce(jsonResponse({ results: [[true]] }));
-    const step = createStep({ query: 'q', interval_seconds: 0.05, timeout_seconds: 5 });
-
-    await expect(step.executeAsync()).resolves.not.toThrow();
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('throws when the query never returns true within the timeout', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({ results: [[false]] }));
-    const step = createStep({ query: 'q', interval_seconds: 0.05, timeout_seconds: 0.1 });
-
-    await expect(step.executeAsync()).rejects.toThrow(/did not return true within/);
-  });
-
-  it('throws when credentials are missing', async () => {
-    const step = createStep({ query: 'q' }, {});
-
-    await expect(step.executeAsync()).rejects.toThrow(
-      /Missing PostHog credentials: personal API key, project id/
-    );
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('throws on a non-positive interval', async () => {
-    const step = createStep({ query: 'q', interval_seconds: 0 });
-
-    await expect(step.executeAsync()).rejects.toThrow(/greater than 0/);
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('throws on a 403 without retrying', async () => {
-    fetchMock.mockResolvedValue(jsonResponse({}, { ok: false, status: 403 }));
-    const step = createStep({ query: 'q' });
-
-    await expect(step.executeAsync()).rejects.toThrow(/forbidden \(403\)/);
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-  });
-});

packages/build-tools/src/steps/functions/capturePosthogEvent.ts

@@ -1,82 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
-
-import { PosthogClient } from '../utils/PosthogClient';
-import { PosthogUtils } from '../utils/PosthogUtils';
-
-export function createCapturePosthogEventFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'posthog_capture_event',
-    name: 'Capture PostHog event',
-    __metricsId: 'eas/posthog_capture_event',
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'event',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'distinct_id',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'properties',
-        allowedValueTypeName: BuildStepInputValueTypeName.JSON,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'api_key',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'host',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'ignore_error',
-        allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
-        required: false,
-      }),
-    ],
-    fn: async (stepCtx, { inputs, env, signal }) => {
-      const { logger } = stepCtx;
-      const ignoreError = Boolean(inputs.ignore_error.value);
-      const event = inputs.event.value as string;
-
-      const client = PosthogClient.forIngestion({
-        apiKeyOverride: inputs.api_key.value as string | undefined,
-        hostOverride: inputs.host.value as string | undefined,
-        env,
-      });
-      if (!client) {
-        PosthogUtils.failOrLogError({
-          logger,
-          ignoreError,
-          error: new UserError(
-            'EAS_POSTHOG_MISSING_API_KEY',
-            'PostHog API key not provided. Set the "api_key" input or the EXPO_PUBLIC_POSTHOG_API_KEY environment variable.'
-          ),
-        });
-        return;
-      }
-
-      logger.info(`Sending PostHog event "${event}"`);
-      try {
-        await client.captureEventAsync({
-          event,
-          distinctId: inputs.distinct_id.value as string | undefined,
-          properties: inputs.properties.value as Record<string, unknown> | undefined,
-          signal,
-        });
-      } catch (error) {
-        PosthogUtils.failOrLogError({ logger, ignoreError, error });
-        return;
-      }
-      logger.info(`Sent PostHog event "${event}"`);
-    },
-  });
-}

packages/build-tools/src/steps/functions/checkout.ts

@@ -7,7 +7,6 @@ export function createCheckoutBuildFunction(): BuildFunction {
     id: 'checkout',
     name: 'Checkout',
     __metricsId: 'eas/checkout',
-    __hookId: 'checkout',
     fn: async stepsCtx => {
       if (stepsCtx.global.wasCheckedOut()) {
         stepsCtx.logger.info('Project directory is already checked out');

packages/build-tools/src/steps/functions/createPosthogAnnotation.ts

@@ -1,78 +0,0 @@
-import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
-
-import { PosthogClient } from '../utils/PosthogClient';
-import { PosthogUtils } from '../utils/PosthogUtils';
-
-export function createPosthogAnnotationFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'posthog_annotation',
-    name: 'Create a PostHog annotation',
-    __metricsId: 'eas/posthog_annotation',
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'content',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'date_marker',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'api_key',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'project_id',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'ignore_error',
-        allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
-        required: false,
-      }),
-    ],
-    fn: async (stepCtx, { inputs, env, signal }) => {
-      const { logger } = stepCtx;
-      const ignoreError = Boolean(inputs.ignore_error.value);
-
-      const result = PosthogClient.fromEnv({
-        apiKeyOverride: inputs.api_key.value as string | undefined,
-        projectIdOverride: inputs.project_id.value as string | undefined,
-        env,
-      });
-      if (!result.client) {
-        PosthogUtils.failOrLogError({
-          logger,
-          ignoreError,
-          error: PosthogUtils.missingCredentialsError(result.missing),
-        });
-        return;
-      }
-      const client = result.client;
-
-      const content = inputs.content.value as string;
-      const dateMarker =
-        (inputs.date_marker.value as string | undefined) ?? new Date().toISOString();
-
-      logger.info(`Creating PostHog annotation "${content}"`);
-      try {
-        await client.requestAsync('POST', '/annotations/', {
-          action: 'Creating the PostHog annotation',
-          forbiddenScope: 'annotation:write',
-          body: { content, date_marker: dateMarker },
-          signal,
-        });
-      } catch (error) {
-        PosthogUtils.failOrLogError({ logger, ignoreError, error });
-        return;
-      }
-
-      logger.info('Created PostHog annotation');
-    },
-  });
-}

packages/build-tools/src/steps/functions/createSubmissionEntity.ts

@@ -1,7 +1,6 @@
 import { asyncResult } from '@expo/results';
 import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
 
-import { Sentry } from '../../sentry';
 import { retryOnDNSFailure } from '../../utils/retryOnDNSFailure';
 
 export function createSubmissionEntityFunction(): BuildFunction {
@@ -55,42 +54,18 @@ export function createSubmissionEntityFunction(): BuildFunction {
       const robotAccessToken = stepsCtx.global.staticContext.job.secrets?.robotAccessToken;
       if (!robotAccessToken) {
         stepsCtx.logger.error('Failed to create submission entity: no robot access token found');
-        Sentry.capture('Failed to create submission entity: missing robot access token');
         return;
       }
 
       const buildId = inputs.build_id.value;
       if (!buildId) {
         stepsCtx.logger.error('Failed to create submission entity: no build ID provided');
-        Sentry.capture('Failed to create submission entity: missing build ID', {
-          extras: {
-            buildId,
-          },
-        });
         return;
       }
 
       const workflowJobId = stepsCtx.global.env.__WORKFLOW_JOB_ID;
       if (!workflowJobId) {
         stepsCtx.logger.error('Failed to create submission entity: no workflow job ID found');
-        Sentry.capture('Failed to create submission entity: missing workflow job ID', {
-          extras: {
-            buildId,
-            workflowJobId,
-          },
-        });
-        return;
-      }
-
-      const expoApiServerURL = stepsCtx.global.staticContext.expoApiServerURL;
-      if (!expoApiServerURL) {
-        stepsCtx.logger.error('Failed to create submission entity: no Expo API server URL found');
-        Sentry.capture('Failed to create submission entity: missing Expo API server URL', {
-          extras: {
-            buildId,
-            workflowJobId,
-          },
-        });
         return;
       }
 
@@ -108,7 +83,7 @@ export function createSubmissionEntityFunction(): BuildFunction {
 
       try {
         const response = await retryOnDNSFailure(fetch)(
-          new URL('/v2/app-store-submissions/', expoApiServerURL),
+          new URL('/v2/app-store-submissions/', stepsCtx.global.staticContext.expoApiServerURL),
           {
             method: 'POST',
             headers: {

packages/build-tools/src/steps/functions/downloadArtifact.ts

@@ -1,4 +1,4 @@
-import { SystemError } from '@expo/eas-build-job';
+import { UserError } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
 import { asyncResult } from '@expo/results';
 import {
@@ -56,23 +56,18 @@ export function createDownloadArtifactFunction(): BuildFunction {
       const interpolationContext = stepsCtx.global.getInterpolationContext();
 
       if (!('workflow' in interpolationContext)) {
-        throw new SystemError('No workflow found in the interpolation context.', {
-          trackingCode: 'EAS_DOWNLOAD_ARTIFACT_NO_WORKFLOW',
-        });
+        throw new UserError(
+          'EAS_DOWNLOAD_ARTIFACT_NO_WORKFLOW',
+          'No workflow found in the interpolation context.'
+        );
       }
 
       const robotAccessToken = stepsCtx.global.staticContext.job.secrets?.robotAccessToken;
       if (!robotAccessToken) {
-        throw new SystemError('No robot access token found in the job secrets.', {
-          trackingCode: 'EAS_DOWNLOAD_ARTIFACT_NO_ROBOT_ACCESS_TOKEN',
-        });
-      }
-
-      const expoApiServerURL = stepsCtx.global.staticContext.expoApiServerURL;
-      if (!expoApiServerURL) {
-        throw new SystemError('Missing Expo API server URL.', {
-          trackingCode: 'EAS_DOWNLOAD_ARTIFACT_NO_EXPO_API_SERVER_URL',
-        });
+        throw new UserError(
+          'EAS_DOWNLOAD_ARTIFACT_NO_ROBOT_ACCESS_TOKEN',
+          'No robot access token found in the job secrets.'
+        );
       }
 
       const workflowRunId = interpolationContext.workflow.id;
@@ -87,7 +82,7 @@ export function createDownloadArtifactFunction(): BuildFunction {
       const { artifactPath } = await downloadArtifactAsync({
         logger,
         workflowRunId,
-        expoApiServerURL,
+        expoApiServerURL: stepsCtx.global.staticContext.expoApiServerURL,
         robotAccessToken,
         params,
       });

packages/build-tools/src/steps/functions/downloadBuild.ts

@@ -1,4 +1,4 @@
-import { SystemError, UserError } from '@expo/eas-build-job';
+import { UserError } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
 import { asyncResult } from '@expo/results';
 import {
@@ -7,9 +7,7 @@ import {
   BuildStepInputValueTypeName,
   BuildStepOutput,
 } from '@expo/steps';
-import { Client } from '@urql/core';
 import { glob } from 'fast-glob';
-import { graphql } from 'gql.tada';
 import fetch from 'node-fetch';
 import fs from 'node:fs';
 import os from 'node:os';
@@ -18,7 +16,6 @@ import stream from 'stream';
 import { promisify } from 'util';
 import { z } from 'zod';
 
-import { CustomBuildContext } from '../../customBuildContext';
 import { formatBytes } from '../../utils/artifacts';
 import { decompressTarAsync, isFileTarGzAsync } from '../../utils/files';
 import { retryOnDNSFailure } from '../../utils/retryOnDNSFailure';
@@ -26,21 +23,7 @@ import { pluralize } from '../../utils/strings';
 
 const streamPipeline = promisify(stream.pipeline);
 
-const BUILD_BY_ID_QUERY = graphql(`
-  query DownloadBuildByIdQuery($buildId: ID!) {
-    builds {
-      byId(buildId: $buildId) {
-        id
-        platform
-        artifacts {
-          applicationArchiveUrl
-        }
-      }
-    }
-  }
-`);
-
-export function createDownloadBuildFunction(ctx: CustomBuildContext): BuildFunction {
+export function createDownloadBuildFunction(): BuildFunction {
   return new BuildFunction({
     namespace: 'eas',
     id: 'download_build',
@@ -76,7 +59,7 @@ export function createDownloadBuildFunction(ctx: CustomBuildContext): BuildFunct
       const { artifactPath } = await downloadBuildAsync({
         logger,
         buildId,
-        graphqlClient: ctx.graphqlClient,
+        expoApiServerURL: stepsCtx.global.staticContext.expoApiServerURL,
         robotAccessToken: stepsCtx.global.staticContext.job.secrets?.robotAccessToken ?? null,
         extensions,
       });
@@ -86,45 +69,16 @@ export function createDownloadBuildFunction(ctx: CustomBuildContext): BuildFunct
   });
 }
 
-async function fetchApplicationArchiveUrlAsync({
-  buildId,
-  graphqlClient,
-}: {
-  buildId: string;
-  graphqlClient: Client;
-}): Promise<string> {
-  const result = await graphqlClient.query(BUILD_BY_ID_QUERY, { buildId }).toPromise();
-
-  if (result.error) {
-    const { error } = result;
-    const message = `Could not fetch build ${buildId}: ${error.message}`;
-
-    throw error.networkError || result.error.response?.status >= 500
-      ? new SystemError(message, { cause: error })
-      : new UserError('EAS_DOWNLOAD_BUILD_FETCH_FAILED', message, { cause: error });
-  }
-
-  const applicationArchiveUrl = result.data?.builds.byId?.artifacts?.applicationArchiveUrl;
-  if (!applicationArchiveUrl) {
-    throw new UserError(
-      'EAS_DOWNLOAD_BUILD_NO_APPLICATION_ARCHIVE',
-      'Build does not have an application archive url'
-    );
-  }
-
-  return applicationArchiveUrl;
-}
-
 export async function downloadBuildAsync({
   logger,
   buildId,
-  graphqlClient,
+  expoApiServerURL,
   robotAccessToken,
   extensions,
 }: {
   logger: bunyan;
   buildId: string;
-  graphqlClient: Client;
+  expoApiServerURL: string;
   robotAccessToken: string | null;
   extensions: string[];
 }): Promise<{ artifactPath: string }> {
@@ -132,11 +86,12 @@ export async function downloadBuildAsync({
     path.join(os.tmpdir(), 'download_build-downloaded-')
   );
 
-  const downloadUrl = await fetchApplicationArchiveUrlAsync({ buildId, graphqlClient });
-
-  const response = await retryOnDNSFailure(fetch)(downloadUrl, {
-    headers: robotAccessToken ? { Authorization: `Bearer ${robotAccessToken}` } : undefined,
-  });
+  const response = await retryOnDNSFailure(fetch)(
+    new URL(`/v2/artifacts/eas/${buildId}`, expoApiServerURL),
+    {
+      headers: robotAccessToken ? { Authorization: `Bearer ${robotAccessToken}` } : undefined,
+    }
+  );
 
   if (!response.ok) {
     const textResult = await asyncResult(response.text());

packages/build-tools/src/steps/functions/findAndUploadBuildArtifacts.ts

@@ -26,14 +26,14 @@ export function createFindAndUploadBuildArtifactsBuildFunction(
       try {
         await uploadApplicationArchivesAsync({ ctx, stepCtx });
       } catch (err: unknown) {
-        stepCtx.logger.error({ err }, `Failed to upload application archives.`);
+        stepCtx.logger.error(`Failed to upload application archives.`, err);
         firstError ||= err;
       }
 
       try {
         await uploadBuildArtifacts({ ctx, stepCtx });
       } catch (err: unknown) {
-        stepCtx.logger.error({ err }, `Failed to upload build artifacts.`);
+        stepCtx.logger.error(`Failed to upload build artifacts.`, err);
         firstError ||= err;
       }
 

packages/build-tools/src/steps/functions/finishIosSimulatorRecordings.ts

@@ -1,23 +0,0 @@
-import { BuildFunction, BuildRuntimePlatform, BuildStepOutput } from '@expo/steps';
-
-import { IosSimulatorRecordingUtils } from '../utils/IosSimulatorRecordingUtils';
-
-export function createFinishIosSimulatorRecordingsBuildFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'finish_ios_simulator_recordings',
-    name: 'Finish iOS Simulator recordings',
-    __metricsId: 'eas/finish_ios_simulator_recordings',
-    supportedRuntimePlatforms: [BuildRuntimePlatform.DARWIN],
-    outputProviders: [
-      BuildStepOutput.createProvider({
-        id: 'recordings_json',
-        required: true,
-      }),
-    ],
-    fn: async ({ logger }, { outputs }) => {
-      const recordings = await IosSimulatorRecordingUtils.finishAsync({ logger });
-      outputs.recordings_json.set(JSON.stringify(recordings));
-    },
-  });
-}

packages/build-tools/src/steps/functions/installNodeModules.ts

@@ -16,7 +16,6 @@ export function createInstallNodeModulesBuildFunction(): BuildFunction {
     id: 'install_node_modules',
     name: 'Install node modules',
     __metricsId: 'eas/install_node_modules',
-    __hookId: 'install_node_modules',
     fn: async (stepCtx, { env }) => {
       await installNodeModules(stepCtx, env);
     },

packages/build-tools/src/steps/functions/maestroResultParser.ts

@@ -1,4 +1,3 @@
-import { asyncResult } from '@expo/results';
 import { XMLBuilder, XMLParser, XMLValidator } from 'fast-xml-parser';
 import fs from 'fs/promises';
 import path from 'path';
@@ -19,7 +18,6 @@ const ATTEMPT_PATTERN = /attempt-(\d+)/;
 
 export interface JUnitTestCaseResult {
   name: string;
-  file: string | undefined;
   status: 'passed' | 'failed';
   duration: number; // milliseconds
   errorMessage: string | null;
@@ -34,12 +32,6 @@ const xmlParser = new XMLParser({
   isArray: name => ['testsuite', 'testcase', 'property'].includes(name),
 });
 
-// A `file=` attribute counts as present only when it is a non-empty string.
-function fileAttrOf(tc: any): string | undefined {
-  const f = tc?.['@_file'];
-  return typeof f === 'string' && f.length > 0 ? f : undefined;
-}
-
 function parseJUnitContent(content: string): JUnitTestCaseResult[] {
   const results: JUnitTestCaseResult[] = [];
   try {
@@ -62,8 +54,6 @@ function parseJUnitContent(content: string): JUnitTestCaseResult[] {
           continue;
         }
 
-        const file = fileAttrOf(tc);
-
         const timeStr = tc['@_time'];
         const timeSeconds = timeStr ? parseFloat(timeStr) : 0;
         const duration = Number.isFinite(timeSeconds) ? Math.round(timeSeconds * 1000) : 0;
@@ -104,7 +94,7 @@ function parseJUnitContent(content: string): JUnitTestCaseResult[] {
           : [];
         delete properties['tags'];
 
-        results.push({ name, file, status, duration, errorMessage, tags, properties });
+        results.push({ name, status, duration, errorMessage, tags, properties });
       }
     }
   } catch {
@@ -141,142 +131,6 @@ export async function parseJUnitTestCases(junitDirectory: string): Promise<JUnit
   return perFile.flat();
 }
 
-// ---------------------------------------------------------------------------
-// Maestro >= 2.6.0 code path: every <testcase> carries a `file=` attribute with
-// its flow's own path (all-or-none per run). Callers check the report first
-// (isFileAttrRun / junitFileHasFileAttrs) and route here; the legacy name→path
-// scan is then never consulted.
-// ---------------------------------------------------------------------------
-
-export function isFileAttrRun(
-  testcases: JUnitTestCaseResult[]
-): testcases is (JUnitTestCaseResult & { file: string })[] {
-  return testcases.length > 0 && testcases.every(tc => tc.file !== undefined);
-}
-
-// Unreadable or attribute-less reports ⇒ false: the caller then takes the
-// legacy path, whose own guards degrade safely.
-export async function junitFileHasFileAttrs(junitFile: string): Promise<boolean> {
-  return isFileAttrRun(await parseJUnitFile(junitFile));
-}
-
-async function fileExists(absPath: string): Promise<boolean> {
-  return (await asyncResult(fs.stat(absPath))).ok;
-}
-
-// Group by `file=` so two same-named flows in different files stay separate.
-export async function parseMaestroResultsFromFileAttrs(
-  junitDirectory: string
-): Promise<MaestroFlowResult[]> {
-  interface JUnitEntry {
-    result: JUnitTestCaseResult;
-    sourceFile: string;
-  }
-
-  let junitEntries: string[];
-  try {
-    junitEntries = await fs.readdir(junitDirectory);
-  } catch {
-    return [];
-  }
-  const xmlFiles = junitEntries.filter(f => f.endsWith('.xml')).sort();
-
-  const entries: JUnitEntry[] = [];
-  for (const xmlFile of xmlFiles) {
-    const fileResults = await parseJUnitFile(path.join(junitDirectory, xmlFile));
-    for (const result of fileResults) {
-      entries.push({ result, sourceFile: xmlFile });
-    }
-  }
-
-  const byPath = new Map<string, JUnitEntry[]>();
-  for (const entry of entries) {
-    // Callers verify the report with isFileAttrRun/junitFileHasFileAttrs first;
-    // skip (rather than emit an undefined path) if that contract is violated.
-    const flowPath = entry.result.file;
-    if (flowPath === undefined) {
-      continue;
-    }
-    const group = byPath.get(flowPath) ?? [];
-    group.push(entry);
-    byPath.set(flowPath, group);
-  }
-
-  const results: MaestroFlowResult[] = [];
-  for (const [flowPath, group] of byPath) {
-    // retryCount is derived from each entry's source filename (`attempt-N`);
-    // a single entry from `report.xml` (no marker) collapses to attempt 0.
-    const sorted = group
-      .map(entry => {
-        const match = entry.sourceFile.match(ATTEMPT_PATTERN);
-        const attemptIndex = match ? parseInt(match[1], 10) : 0;
-        return { ...entry, attemptIndex };
-      })
-      .sort((a, b) => a.attemptIndex - b.attemptIndex);
-
-    for (const { result, attemptIndex } of sorted) {
-      results.push({
-        name: result.name,
-        path: flowPath,
-        status: result.status,
-        errorMessage: result.errorMessage,
-        duration: result.duration,
-        retryCount: attemptIndex,
-        tags: result.tags,
-        properties: result.properties,
-      });
-    }
-  }
-  return results;
-}
-
-/**
- * Returns the `file=` paths of the failing testcases in the given attempt's
- * JUnit file, or `null` when the result cannot be trusted (caller then falls
- * back to dumb retry — re-run everything; never the legacy scan).
- *
- * Callers verify the report carries `file=` attributes first
- * (junitFileHasFileAttrs).
- */
-export async function parseFailedFlowsFromFileAttrs(args: {
-  junitFile: string;
-  workingDirectory: string;
-}): Promise<string[] | null> {
-  // Same hardening as the legacy parser: fast-xml-parser is lenient — a
-  // truncated XML could drop testcases, and trusting that partial failing set
-  // would skip retries for cut-off flows.
-  let content: string;
-  try {
-    content = await fs.readFile(args.junitFile, 'utf-8');
-  } catch {
-    return null;
-  }
-  if (XMLValidator.validate(content) !== true) {
-    return null;
-  }
-
-  const testcases = parseJUnitContent(content);
-  if (!isFileAttrRun(testcases)) {
-    return null;
-  }
-
-  const failing = testcases.filter(tc => tc.status === 'failed');
-  if (failing.length === 0) {
-    return [];
-  }
-
-  // Each failing testcase is self-identifying via `file=`, so duplicate flow
-  // names retry correctly. path.resolve (not join): `file=` may be absolute
-  // when the flow lives outside the working directory.
-  const paths = [...new Set(failing.map(tc => tc.file))];
-  for (const p of paths) {
-    if (!(await fileExists(path.resolve(args.workingDirectory, p)))) {
-      return null;
-    }
-  }
-  return paths;
-}
-
 export async function parseMaestroResults(
   junitDirectory: string,
   nameToPath: Map<string, string> | null
@@ -459,13 +313,6 @@ export async function mergeJUnitReports(args: {
     }
     const match = filename.match(ATTEMPT_PATTERN);
     const attemptIndex = match ? parseInt(match[1], 10) : 0;
-    // Maestro >= 2.6.0 reports: key by `file=` so two same-named flows in
-    // different files merge separately. Legacy reports keep name keying.
-    const allCases = testsuites.flatMap((suite: any) =>
-      Array.isArray(suite?.testcase) ? suite.testcase : []
-    );
-    const useFileKeys =
-      allCases.length > 0 && allCases.every((tc: any) => fileAttrOf(tc) !== undefined);
     const testcasesByName = new Map<string, unknown[]>();
     for (const suite of testsuites) {
       const cases = suite?.testcase;
@@ -477,10 +324,9 @@ export async function mergeJUnitReports(args: {
         if (typeof name !== 'string') {
           continue;
         }
-        const key = useFileKeys ? fileAttrOf(tc)! : name;
-        const group = testcasesByName.get(key) ?? [];
+        const group = testcasesByName.get(name) ?? [];
         group.push(tc);
-        testcasesByName.set(key, group);
+        testcasesByName.set(name, group);
       }
     }
     if (testcasesByName.size === 0) {

packages/build-tools/src/steps/functions/maestroScreenshots.ts

@@ -1,159 +0,0 @@
-import { bunyan } from '@expo/logger';
-import { type Dirent } from 'fs';
-import fs from 'fs/promises';
-import path from 'path';
-
-export interface ParsedFailureScreenshot {
-  flowName: string;
-  capturedAtMs: number;
-}
-
-// Maestro failure screenshot: `screenshot-[shard-N-]❌-<epochMillis>-(<flowName>).png`.
-// The flow name may contain parentheses, so anchor on the `-(` after the epoch and the
-// `).png` suffix rather than scanning for parens.
-const FAILURE_SCREENSHOT_PATTERN = /^screenshot-(?:shard-\d+-)?❌-(\d+)-\((.+)\)\.png$/u;
-
-export function parseFailureScreenshotFilename(filename: string): ParsedFailureScreenshot | null {
-  const match = filename.match(FAILURE_SCREENSHOT_PATTERN);
-  if (!match) {
-    return null;
-  }
-  const capturedAtMs = Number(match[1]);
-  if (!Number.isFinite(capturedAtMs)) {
-    return null;
-  }
-  return {
-    flowName: match[2],
-    capturedAtMs,
-  };
-}
-
-export interface HarvestedScreenshot {
-  fileAbsPath: string;
-  displayName: string; // `Failure Screenshot: <flowName> (attempt <n>)`
-  metadata: {
-    kind: 'maestro-test-screenshot';
-    // The Maestro flow name straight from the filename (already '/'->'_' substituted by
-    // Maestro). The website matches this against `attempt.name` (normalized the same way).
-    flowName: string;
-    attemptIndex: number;
-    capturedAtMs: number;
-  };
-}
-
-// Scans every debug dir under testsDirectory whose mtime is recent enough (mtime-based to cover
-// the maestro <2.5.0 bug that splits one invocation across two dirs), then keeps only screenshots
-// whose own capturedAtMs is at/after capturedSinceMs. Never throws: an unreadable dir is logged
-// and skipped so a screenshot harvest can't affect the maestro step outcome.
-export async function harvestFailureScreenshotsAsync(args: {
-  testsDirectory: string;
-  capturedSinceMs: number;
-  attemptIndex: number;
-  logger: bunyan;
-}): Promise<HarvestedScreenshot[]> {
-  // Gate dirs by mtime floored to the second, so a dir created within the same second as the
-  // attempt start isn't stat'd below the baseline. The exact capturedAtMs gate below is what
-  // prevents mis-attributing an earlier attempt's screenshot.
-  const dirSinceMtimeMs = Math.floor(args.capturedSinceMs / 1000) * 1000;
-  let entries: Dirent[];
-  try {
-    entries = await fs.readdir(args.testsDirectory, { withFileTypes: true });
-  } catch (err: any) {
-    args.logger.info({ err }, `Skipping screenshot harvest: cannot read ${args.testsDirectory}.`);
-    return [];
-  }
-
-  const results: HarvestedScreenshot[] = [];
-  for (const entry of entries) {
-    if (!entry.isDirectory()) {
-      continue;
-    }
-    const dirPath = path.join(args.testsDirectory, entry.name);
-    let filenames: string[];
-    try {
-      if ((await fs.stat(dirPath)).mtimeMs < dirSinceMtimeMs) {
-        continue;
-      }
-      filenames = await fs.readdir(dirPath);
-    } catch (err: any) {
-      args.logger.info({ err }, `Skipping unreadable debug dir ${dirPath}.`);
-      continue;
-    }
-    for (const filename of filenames) {
-      const parsed = parseFailureScreenshotFilename(filename);
-      // Re-check capture time per file: a dir's mtime can advance after this attempt began (or
-      // fall within the floored-second dir baseline), so the dir gate alone would re-attribute an
-      // earlier attempt's screenshot to this one.
-      if (parsed === null || parsed.capturedAtMs < args.capturedSinceMs) {
-        continue;
-      }
-      results.push({
-        fileAbsPath: path.join(dirPath, filename),
-        displayName: `Failure Screenshot: ${parsed.flowName} (attempt ${args.attemptIndex + 1})`,
-        metadata: {
-          kind: 'maestro-test-screenshot',
-          flowName: parsed.flowName,
-          attemptIndex: args.attemptIndex,
-          capturedAtMs: parsed.capturedAtMs,
-        },
-      });
-    }
-  }
-  return results;
-}
-
-// Maestro substitutes '/' -> '_' in screenshot filenames (so HarvestedScreenshot.flowName
-// is already in that form) but keeps '/' in the JUnit testcase name. Normalize the JUnit
-// name the same way before comparing — matching the website's own normalization.
-function normalizeFlowName(name: string): string {
-  return name.replace(/\//g, '_');
-}
-
-// A flow is a "pure failure" when it failed and never passed across all attempts. The website
-// surfaces only the final screenshot for such a flow, so keeping its earlier attempts would
-// spend the per-job artifact budget on screenshots that are never shown — we keep only the final
-// one (selectFailureScreenshots). A flow that passed at least once (flaky / fail-pass-fail) is
-// NOT pure: each of its failed attempts is a distinct failure and is kept.
-export function computePureFailureFlowNames(
-  testCases: readonly { name: string; status: 'passed' | 'failed' }[]
-): Set<string> {
-  const passed = new Set<string>();
-  const failed = new Set<string>();
-  for (const testCase of testCases) {
-    const flowName = normalizeFlowName(testCase.name);
-    if (testCase.status === 'passed') {
-      passed.add(flowName);
-    } else {
-      failed.add(flowName);
-    }
-  }
-  const pure = new Set<string>();
-  for (const flowName of failed) {
-    if (!passed.has(flowName)) {
-      pure.add(flowName);
-    }
-  }
-  return pure;
-}
-
-// Keep every harvested screenshot for flaky/mixed flows; for pure-failure flows keep only
-// the final (highest attemptIndex) screenshot.
-export function selectFailureScreenshots(
-  harvested: readonly HarvestedScreenshot[],
-  pureFailureFlowNames: ReadonlySet<string>
-): HarvestedScreenshot[] {
-  const finalAttemptByPureFlow = new Map<string, number>();
-  for (const shot of harvested) {
-    if (!pureFailureFlowNames.has(shot.metadata.flowName)) {
-      continue;
-    }
-    const finalAttempt = finalAttemptByPureFlow.get(shot.metadata.flowName);
-    if (finalAttempt === undefined || shot.metadata.attemptIndex > finalAttempt) {
-      finalAttemptByPureFlow.set(shot.metadata.flowName, shot.metadata.attemptIndex);
-    }
-  }
-  return harvested.filter(shot => {
-    const finalAttempt = finalAttemptByPureFlow.get(shot.metadata.flowName);
-    return finalAttempt === undefined || shot.metadata.attemptIndex === finalAttempt;
-  });
-}

packages/build-tools/src/steps/functions/maestroTests.ts

@@ -1,5 +1,4 @@
-import { GenericArtifactType, SystemError, UserError } from '@expo/eas-build-job';
-import { bunyan } from '@expo/logger';
+import { SystemError, UserError } from '@expo/eas-build-job';
 import {
   BuildFunction,
   BuildRuntimePlatform,
@@ -9,26 +8,15 @@ import {
 } from '@expo/steps';
 import spawn from '@expo/turtle-spawn';
 import fs from 'fs/promises';
-import os from 'os';
 import path from 'path';
 import { z } from 'zod';
 
 import { buildFlowNameToPathMap } from './maestroFlowDiscovery';
 import {
   copyLatestAttemptXml,
-  junitFileHasFileAttrs,
   mergeJUnitReports,
-  parseFailedFlowsFromFileAttrs,
   parseFailedFlowsFromJUnit,
-  parseJUnitTestCases,
 } from './maestroResultParser';
-import {
-  type HarvestedScreenshot,
-  computePureFailureFlowNames,
-  harvestFailureScreenshotsAsync,
-  selectFailureScreenshots,
-} from './maestroScreenshots';
-import { CustomBuildContext } from '../../customBuildContext';
 import { sleepAsync } from '../../utils/retry';
 
 const FlowPathSchema = z.array(z.string().min(1)).min(1);
@@ -91,13 +79,12 @@ function buildMaestroArgs(args: {
   return out;
 }
 
-export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildFunction {
+export function createMaestroTestsBuildFunction(): BuildFunction {
   return new BuildFunction({
     namespace: 'eas',
     id: 'maestro_tests',
     name: 'Run Maestro Tests',
     __metricsId: 'eas/maestro_tests',
-    __hookId: 'maestro_tests',
     inputProviders: [
       BuildStepInput.createProvider({
         id: 'flow_path',
@@ -213,10 +200,13 @@ export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildF
         throw new SystemError('Failed to create JUnit report directory', { cause: err });
       }
 
-      // Legacy-only (Maestro < 2.6.0 reports carry no `file=` attribute): the
-      // flow scan is built lazily in the retry branch below and memoized so
-      // retries share one scan. Never runs when the report has `file=`.
-      let nameToPathPromise: Promise<Map<string, string> | null> | undefined;
+      // null → duplicate flow names; retry-failed-only disabled, fall through to
+      // dumb retry (re-run everything) on failure.
+      const nameToPath = await buildFlowNameToPathMap({
+        inputFlowPaths: flowPaths,
+        projectRoot: stepCtx.workingDirectory,
+        logger,
+      });
 
       // Retry loop. spawn-async error shapes:
       //   ENOENT/EACCES → infra (binary missing/not executable) → SystemError.
@@ -224,11 +214,10 @@ export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildF
       //   else (signal-only, OOM kill, unknown) → infra → SystemError, never
       //     downgraded to "tests failed".
       // Retry-failed-only (junit mode): after a failed attempt, subset to the failing
-      // flows. The failed-flow parsers return null when the JUnit cannot be
+      // flows. parseFailedFlowsFromJUnit returns null when the JUnit cannot be
       // trusted; we then fall through to dumb retry (re-run everything).
       let flowsToRun: string[] = flowPaths;
       let lastAttemptExitCode: number | null = null;
-      const harvested: HarvestedScreenshot[] = [];
 
       const totalAttempts = retries + 1;
       for (let attempt = 0; attempt <= retries; attempt++) {
@@ -251,8 +240,6 @@ export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildF
           `Running maestro (attempt ${attempt + 1}/${totalAttempts}): maestro ${maestroArgs.join(' ')}`
         );
 
-        const attemptStartedAtMs = Date.now();
-
         try {
           await spawn('maestro', maestroArgs, {
             cwd: stepCtx.workingDirectory,
@@ -272,44 +259,15 @@ export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildF
           }
         }
 
-        // Harvest this attempt's failure screenshots before any retry subsetting. Gated on
-        // junit: test-case-result rows (and therefore the summary icons) only exist for junit
-        // runs, so harvesting other formats would just create orphan artifacts the website hides.
-        if (outputFormat === 'junit') {
-          harvested.push(
-            ...(await harvestFailureScreenshotsAsync({
-              testsDirectory,
-              capturedSinceMs: attemptStartedAtMs,
-              attemptIndex: attempt,
-              logger,
-            }))
-          );
-        }
-
         if (lastAttemptExitCode === 0 || attempt === retries) {
           break;
         }
 
-        if (retryFailedOnly && outputFormat === 'junit' && outputPath) {
-          let failed: string[] | null;
-          if (await junitFileHasFileAttrs(outputPath)) {
-            failed = await parseFailedFlowsFromFileAttrs({
-              junitFile: outputPath,
-              workingDirectory: stepCtx.workingDirectory,
-            });
-          } else {
-            // Legacy (Maestro < 2.6.0): map failed testcase names back to flow
-            // paths via the flow-file scan. DELETE this arm once the fleet is
-            // on >= 2.6.0.
-            const nameToPath = await (nameToPathPromise ??= buildFlowNameToPathMap({
-              inputFlowPaths: flowPaths,
-              projectRoot: stepCtx.workingDirectory,
-              logger,
-            }));
-            failed = nameToPath
-              ? await parseFailedFlowsFromJUnit({ junitFile: outputPath, nameToPath })
-              : null;
-          }
+        if (retryFailedOnly && outputFormat === 'junit' && outputPath && nameToPath) {
+          const failed = await parseFailedFlowsFromJUnit({
+            junitFile: outputPath,
+            nameToPath,
+          });
           if (failed !== null && failed.length > 0) {
             flowsToRun = failed;
             logger.info(
@@ -358,12 +316,6 @@ export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildF
         }
       }
 
-      // Upload before the ERR_MAESTRO_TESTS_FAILED throw below so fully-failed runs (which need
-      // screenshots most) still upload. Harvest only ran for junit, so guard the same way.
-      if (outputFormat === 'junit') {
-        await uploadFailureScreenshotsAsync({ harvested, junitReportDirectory, ctx, logger });
-      }
-
       // The retry loop exits via success (0), numeric status (retryable),
       // or throw (infra). A non-null non-zero status means the user's tests
       // failed every attempt.
@@ -376,82 +328,3 @@ export function createMaestroTestsBuildFunction(ctx: CustomBuildContext): BuildF
     },
   });
 }
-
-// Reduce harvested failure screenshots to what's worth uploading, then upload them as workflow
-// artifacts. Best-effort and verdict-neutral: never throws, so a screenshot problem can't mask
-// the maestro test result. Caller guards on junit (harvest only runs for junit).
-async function uploadFailureScreenshotsAsync({
-  harvested,
-  junitReportDirectory,
-  ctx,
-  logger,
-}: {
-  harvested: HarvestedScreenshot[];
-  junitReportDirectory: string;
-  ctx: CustomBuildContext;
-  logger: bunyan;
-}): Promise<void> {
-  // Reduce to the attempts worth uploading — every failed attempt for flaky flows, only the final
-  // attempt for all-failed flows. See computePureFailureFlowNames / selectFailureScreenshots.
-  // Guard the JUnit re-parse so a malformed/missing report can't throw past here and mask the
-  // test verdict (the whole step is verdict-neutral for screenshots).
-  let selected: HarvestedScreenshot[];
-  try {
-    const pureFailureFlowNames = computePureFailureFlowNames(
-      await parseJUnitTestCases(junitReportDirectory)
-    );
-    selected = selectFailureScreenshots(harvested, pureFailureFlowNames);
-  } catch (err: any) {
-    logger.warn({ err }, 'Failed to classify failure screenshots; skipping screenshot upload.');
-    return;
-  }
-  if (selected.length === 0) {
-    return;
-  }
-
-  // Cap well under www's 50-artifact-per-job limit.
-  const MAX_SCREENSHOT_UPLOADS = 30;
-  const toUpload = selected.slice(0, MAX_SCREENSHOT_UPLOADS);
-  if (selected.length > toUpload.length) {
-    logger.warn(
-      `Found ${selected.length} failure screenshots; uploading only the first ${toUpload.length}.`
-    );
-  }
-
-  // Copy each shot to an ASCII-safe name outside testsDirectory (the originals contain a
-  // non-ASCII marker and testsDirectory is uploaded wholesale as the tarball).
-  let safeScreenshotDir: string;
-  try {
-    safeScreenshotDir = await fs.mkdtemp(path.join(os.tmpdir(), 'eas-maestro-screenshots-'));
-  } catch (err: any) {
-    logger.warn(
-      { err },
-      'Failed to create the failure-screenshot staging dir; skipping screenshot upload.'
-    );
-    return;
-  }
-
-  await Promise.all(
-    toUpload.map(async (shot, index) => {
-      try {
-        // `index` disambiguates two flows that fail within the same millisecond of an attempt.
-        const safePath = path.join(
-          safeScreenshotDir,
-          `failure-attempt-${shot.metadata.attemptIndex}-${index}-${shot.metadata.capturedAtMs}.png`
-        );
-        await fs.copyFile(shot.fileAbsPath, safePath);
-        await ctx.runtimeApi.uploadArtifact({
-          artifact: {
-            type: GenericArtifactType.OTHER,
-            name: shot.displayName,
-            paths: [safePath],
-            metadata: shot.metadata,
-          },
-          logger,
-        });
-      } catch (err: any) {
-        logger.warn({ err }, 'Failed to upload failure screenshot.');
-      }
-    })
-  );
-}

packages/build-tools/src/steps/functions/repack.ts

@@ -42,6 +42,11 @@ export function createRepackBuildFunction(): BuildFunction {
         required: false,
         allowedValueTypeName: BuildStepInputValueTypeName.STRING,
       }),
+      BuildStepInput.createProvider({
+        id: 'output_path',
+        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
+        required: false,
+      }),
       BuildStepInput.createProvider({
         id: 'embed_bundle_assets',
         allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
@@ -104,10 +109,9 @@ export function createRepackBuildFunction(): BuildFunction {
       stepsCtx.logger.info(`Created temporary working directory: ${workingDirectory}`);
 
       const sourceAppPath = inputs.source_app_path.value as string;
-      const outputPath = createOutputPath({
-        sourceAppPath,
-        tmpDir,
-      });
+      const outputPath =
+        (inputs.output_path.value as string) ??
+        path.join(tmpDir, `repacked-${randomUUID()}${path.extname(sourceAppPath)}`);
       const exportEmbedOptions = inputs.embed_bundle_assets.value
         ? {
             sourcemapOutput: undefined,
@@ -198,21 +202,6 @@ export function createRepackBuildFunction(): BuildFunction {
   });
 }
 
-function createOutputPath({
-  sourceAppPath,
-  tmpDir,
-}: {
-  sourceAppPath: string;
-  tmpDir: string;
-}): string {
-  const outputPath = path.join(tmpDir, `repacked-${randomUUID()}${path.extname(sourceAppPath)}`);
-  const extension = path.extname(outputPath);
-  if (extension.toLowerCase() !== '.aab') {
-    return outputPath;
-  }
-  return `${outputPath.slice(0, -extension.length)}.apk`;
-}
-
 /**
  * Install `@expo/repack-app` in a sandbox directory and import it.
  */

packages/build-tools/src/steps/functions/reportMaestroTestResults.ts

@@ -3,13 +3,7 @@ import { graphql } from 'gql.tada';
 import { z } from 'zod';
 
 import { buildFlowNameToPathMap } from './maestroFlowDiscovery';
-import {
-  MaestroFlowResult,
-  isFileAttrRun,
-  parseJUnitTestCases,
-  parseMaestroResults,
-  parseMaestroResultsFromFileAttrs,
-} from './maestroResultParser';
+import { MaestroFlowResult, parseMaestroResults } from './maestroResultParser';
 import { CustomBuildContext } from '../../customBuildContext';
 
 const FlowPathSchema = z.array(z.string().min(1)).min(1);
@@ -67,64 +61,47 @@ export function createReportMaestroTestResultsFunction(ctx: CustomBuildContext):
         return;
       }
 
-      try {
-        // Maestro >= 2.6.0 stamps every <testcase> with its flow's path in a
-        // `file=` attribute; older reports need the legacy flow-file scan to
-        // map testcase names back to paths.
-        const usedFileAttrs = isFileAttrRun(await parseJUnitTestCases(junitDirectory));
-
-        let flowResults: MaestroFlowResult[];
-        if (usedFileAttrs) {
-          flowResults = await parseMaestroResultsFromFileAttrs(junitDirectory);
+      const flowPathRaw = inputs.flow_path.value;
+      let nameToPath: Map<string, string> | null = null;
+      if (flowPathRaw !== undefined) {
+        const parsed = FlowPathSchema.safeParse(flowPathRaw);
+        if (parsed.success) {
+          nameToPath = await buildFlowNameToPathMap({
+            inputFlowPaths: parsed.data,
+            projectRoot: stepsCtx.workingDirectory,
+            logger,
+          });
         } else {
-          // Legacy (Maestro < 2.6.0) — DELETE this arm once the fleet is on >= 2.6.0.
-          const flowPathRaw = inputs.flow_path.value;
-          let nameToPath: Map<string, string> | null = null;
-          if (flowPathRaw !== undefined) {
-            const parsed = FlowPathSchema.safeParse(flowPathRaw);
-            if (parsed.success) {
-              nameToPath = await buildFlowNameToPathMap({
-                inputFlowPaths: parsed.data,
-                projectRoot: stepsCtx.workingDirectory,
-                logger,
-              });
-            } else {
-              logger.warn(
-                'Ignoring malformed flow_path input (expected a non-empty array of non-empty strings).'
-              );
-            }
-          }
-          flowResults = await parseMaestroResults(junitDirectory, nameToPath);
+          logger.warn(
+            'Ignoring malformed flow_path input (expected a non-empty array of non-empty strings).'
+          );
         }
+      }
 
+      try {
+        const flowResults = await parseMaestroResults(junitDirectory, nameToPath);
         if (flowResults.length === 0) {
           logger.info('No maestro test results found, skipping report');
           return;
         }
 
-        // Detect truly conflicting results: the same (path, retryCount) twice means two
-        // flow files resolved to the same path, which we can't disambiguate and the API
-        // rejects as a duplicate. Same path with different retryCount is expected
-        // (per-attempt results from retries).
+        // Detect truly conflicting results: same (name, retryCount) pair means different flow files
+        // share the same name (Maestro config override), which we can't disambiguate.
+        // Same name with different retryCount is expected (per-attempt results from retries).
         const seen = new Set<string>();
         const conflicting = new Set<string>();
         for (const r of flowResults) {
-          const key = `${r.path}:${r.retryCount}`;
+          const key = `${r.name}:${r.retryCount}`;
           if (seen.has(key)) {
-            conflicting.add(r.path);
+            conflicting.add(r.name);
           }
           seen.add(key);
         }
         if (conflicting.size > 0) {
-          const conflictList = [...conflicting].join(', ');
           logger.error(
-            usedFileAttrs
-              ? `The same flow file was reported more than once in a single attempt: ` +
-                  `${conflictList}. Skipping report. Check for duplicate flow_path entries ` +
-                  `or leftover XML files in the JUnit report directory.`
-              : `Duplicate Maestro flow names found: ${conflictList}. Skipping report. ` +
-                  `Give each flow a unique name, or upgrade Maestro to >= 2.6.0 (flows are ` +
-                  `then identified by file path, so duplicate names are fine).`
+            `Duplicate test case names found in JUnit output: ${[...conflicting].join(
+              ', '
+            )}. Skipping report. Ensure each Maestro flow has a unique name.`
           );
           return;
         }

packages/build-tools/src/steps/functions/restoreBuildCache.ts

@@ -206,16 +206,16 @@ export async function restoreGradleCacheAsync({
   }
 
   try {
-    // Enable build cache via user-level gradle.properties.
-    // This avoids mutating android/gradle.properties which affects fingerprinting.
-    const gradleUserHome = path.join(os.homedir(), '.gradle');
-    await fs.promises.mkdir(gradleUserHome, { recursive: true });
-    const userGradlePropertiesPath = path.join(gradleUserHome, 'gradle.properties');
-    await fs.promises.appendFile(userGradlePropertiesPath, '\norg.gradle.caching=true\n');
+    const gradlePropertiesPath = path.join(workingDirectory, 'android', 'gradle.properties');
+    const gradlePropertiesContent = await fs.promises.readFile(gradlePropertiesPath, 'utf-8');
+    await fs.promises.writeFile(
+      gradlePropertiesPath,
+      `${gradlePropertiesContent}\n\norg.gradle.caching=true\n`
+    );
 
-    // Configure cache cleanup via init script.
-    // Works with both Gradle 8 and 9 (org.gradle.cache.cleanup property was removed in Gradle 9).
-    const initScriptDir = path.join(gradleUserHome, 'init.d');
+    // Configure cache cleanup via init script (works with both Gradle 8 and 9,
+    // org.gradle.cache.cleanup property was removed in Gradle 9)
+    const initScriptDir = path.join(os.homedir(), '.gradle', 'init.d');
     await fs.promises.mkdir(initScriptDir, { recursive: true });
     await fs.promises.writeFile(
       path.join(initScriptDir, 'eas-cache-cleanup.gradle'),

packages/build-tools/src/steps/functions/restoreCache.ts

@@ -69,10 +69,6 @@ export function createRestoreCacheFunction(): BuildFunction {
           .filter(key => key !== '');
 
         const jobId = nullthrows(env.EAS_BUILD_ID, 'EAS_BUILD_ID is not set');
-        const expoApiServerURL = nullthrows(
-          stepsCtx.global.staticContext.expoApiServerURL,
-          'expoApiServerURL is not set'
-        );
         const robotAccessToken = nullthrows(
           stepsCtx.global.staticContext.job.secrets?.robotAccessToken,
           'robotAccessToken is not set'
@@ -81,7 +77,7 @@ export function createRestoreCacheFunction(): BuildFunction {
         const { archivePath, matchedKey } = await downloadCacheAsync({
           logger,
           jobId,
-          expoApiServerURL,
+          expoApiServerURL: stepsCtx.global.staticContext.expoApiServerURL,
           robotAccessToken,
           paths,
           key,

packages/build-tools/src/steps/functions/rolloutPosthogFlag.ts

@@ -1,279 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { bunyan } from '@expo/logger';
-import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
-import { z } from 'zod';
-
-import { PosthogClient } from '../utils/PosthogClient';
-import { PosthogUtils } from '../utils/PosthogUtils';
-
-const SEARCH_LIMIT = 200;
-
-const FeatureFlagGroupSchema = z.object({ properties: z.unknown().optional() }).passthrough();
-const FeatureFlagSchema = z
-  .object({
-    id: z.number(),
-    key: z.string(),
-    filters: z
-      .object({
-        groups: z.array(FeatureFlagGroupSchema).optional(),
-        payloads: z.record(z.string(), z.unknown()).optional(),
-      })
-      .passthrough()
-      .optional(),
-  })
-  .passthrough();
-const FlagSearchResponseSchema = z.object({ results: z.array(z.unknown()) });
-
-type FeatureFlagGroup = z.infer<typeof FeatureFlagGroupSchema>;
-type FeatureFlagFilters = NonNullable<z.infer<typeof FeatureFlagSchema>['filters']>;
-
-function isCatchAllGroup(group: FeatureFlagGroup): boolean {
-  const { properties } = group;
-  return (
-    properties === undefined ||
-    properties === null ||
-    (Array.isArray(properties) && properties.length === 0)
-  );
-}
-
-export function createRolloutPosthogFlagFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'posthog_flag_rollout',
-    name: 'Roll out a PostHog feature flag',
-    __metricsId: 'eas/posthog_flag_rollout',
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'flag',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'active',
-        allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'rollout_percentage',
-        allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'payload',
-        allowedValueTypeName: BuildStepInputValueTypeName.JSON,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'variant',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'api_key',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'project_id',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'ignore_error',
-        allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
-        required: false,
-      }),
-    ],
-    fn: async (stepCtx, { inputs, env, signal }) => {
-      const { logger } = stepCtx;
-      const ignoreError = Boolean(inputs.ignore_error.value);
-
-      const flagKey = inputs.flag.value as string;
-      const active = inputs.active.value as boolean | undefined;
-      const rolloutPercentage = inputs.rollout_percentage.value as number | undefined;
-      const payload = inputs.payload.value as Record<string, unknown> | undefined;
-      const variant = inputs.variant.value as string | undefined;
-      if (active === undefined && rolloutPercentage === undefined && payload === undefined) {
-        throw new UserError(
-          'EAS_POSTHOG_FLAG_NO_CHANGE',
-          'You need to provide "active", "rollout_percentage", or "payload" to change the feature flag.'
-        );
-      }
-      if (
-        rolloutPercentage !== undefined &&
-        (!Number.isInteger(rolloutPercentage) || rolloutPercentage < 0 || rolloutPercentage > 100)
-      ) {
-        throw new UserError(
-          'EAS_POSTHOG_FLAG_INVALID_ROLLOUT',
-          `"rollout_percentage" must be an integer between 0 and 100, got ${rolloutPercentage}.`
-        );
-      }
-
-      const result = PosthogClient.fromEnv({
-        apiKeyOverride: inputs.api_key.value as string | undefined,
-        projectIdOverride: inputs.project_id.value as string | undefined,
-        env,
-      });
-      if (!result.client) {
-        PosthogUtils.failOrLogError({
-          logger,
-          ignoreError,
-          error: PosthogUtils.missingCredentialsError(result.missing),
-        });
-        return;
-      }
-      const client = result.client;
-
-      await rolloutPosthogFlagAsync({
-        logger,
-        client,
-        flagKey,
-        active,
-        rolloutPercentage,
-        payload,
-        variant,
-        ignoreError,
-        signal,
-      });
-    },
-  });
-}
-
-async function rolloutPosthogFlagAsync({
-  logger,
-  client,
-  flagKey,
-  active,
-  rolloutPercentage,
-  payload,
-  variant,
-  ignoreError,
-  signal,
-}: {
-  logger: bunyan;
-  client: PosthogClient;
-  flagKey: string;
-  active: boolean | undefined;
-  rolloutPercentage: number | undefined;
-  payload: Record<string, unknown> | undefined;
-  variant: string | undefined;
-  ignoreError: boolean;
-  signal: AbortSignal | undefined;
-}): Promise<void> {
-  let searchResponse;
-  try {
-    searchResponse = await client.requestAsync(
-      'GET',
-      `/feature_flags/?limit=${SEARCH_LIMIT}&search=${encodeURIComponent(flagKey)}`,
-      {
-        action: `Looking up PostHog flag "${flagKey}"`,
-        forbiddenScope: 'feature_flag:read',
-        signal,
-      }
-    );
-  } catch (error) {
-    PosthogUtils.failOrLogError({ logger, ignoreError, error });
-    return;
-  }
-
-  let results: unknown[];
-  try {
-    results = FlagSearchResponseSchema.parse(await searchResponse.json()).results;
-  } catch (error) {
-    PosthogUtils.failOrLogError({
-      logger,
-      ignoreError,
-      error: new UserError(
-        'EAS_POSTHOG_FLAG_UNEXPECTED_RESPONSE',
-        `PostHog flag lookup for "${flagKey}" returned an unexpected response.`,
-        { cause: error }
-      ),
-    });
-    return;
-  }
-
-  const flag = results
-    .flatMap(result => {
-      const parsed = FeatureFlagSchema.safeParse(result);
-      return parsed.success ? [parsed.data] : [];
-    })
-    .find(candidate => candidate.key === flagKey);
-  if (!flag) {
-    PosthogUtils.failOrLogError({
-      logger,
-      ignoreError,
-      error: new UserError(
-        'EAS_POSTHOG_FLAG_NOT_FOUND',
-        `No PostHog feature flag with key "${flagKey}" was found. Check the "flag" input.`
-      ),
-    });
-    return;
-  }
-
-  const patch: Record<string, unknown> = {};
-  if (active !== undefined) {
-    patch.active = active;
-  }
-  let filters = flag.filters;
-  if (rolloutPercentage !== undefined) {
-    filters = buildRolloutFilters({ logger, flagKey, filters, rolloutPercentage });
-  }
-  if (payload !== undefined) {
-    filters = {
-      ...filters,
-      payloads: { ...filters?.payloads, [variant ?? 'true']: JSON.stringify(payload) },
-    };
-  }
-  if (rolloutPercentage !== undefined || payload !== undefined) {
-    patch.filters = filters;
-  }
-
-  try {
-    await client.requestAsync('PATCH', `/feature_flags/${flag.id}/`, {
-      action: `Updating PostHog flag "${flagKey}"`,
-      forbiddenScope: 'feature_flag:write',
-      body: patch,
-      signal,
-    });
-  } catch (error) {
-    PosthogUtils.failOrLogError({ logger, ignoreError, error });
-    return;
-  }
-
-  logger.info(`Updated PostHog feature flag "${flagKey}".`);
-}
-
-function buildRolloutFilters({
-  logger,
-  flagKey,
-  filters,
-  rolloutPercentage,
-}: {
-  logger: bunyan;
-  flagKey: string;
-  filters: FeatureFlagFilters | undefined;
-  rolloutPercentage: number;
-}): FeatureFlagFilters {
-  const groups = filters?.groups ?? [];
-  if (groups.length === 0) {
-    return { ...filters, groups: [{ properties: [], rollout_percentage: rolloutPercentage }] };
-  }
-
-  const catchAllIndex = groups.findIndex(isCatchAllGroup);
-  const hasCatchAll = catchAllIndex >= 0;
-  const targetIndex = hasCatchAll ? catchAllIndex : 0;
-  if (!hasCatchAll) {
-    logger.warn(
-      `Flag "${flagKey}" has no catch-all release-condition group; setting rollout_percentage on the first group, which is condition-scoped.`
-    );
-  } else if (groups.length > 1) {
-    logger.warn(
-      `Flag "${flagKey}" has ${groups.length} release-condition groups; setting rollout_percentage only on the catch-all group to preserve the others.`
-    );
-  }
-
-  const groupsWithRollout = groups.map((group, index) =>
-    index === targetIndex ? { ...group, rollout_percentage: rolloutPercentage } : group
-  );
-  return { ...filters, groups: groupsWithRollout };
-}

packages/build-tools/src/steps/functions/saveCache.ts

@@ -43,10 +43,6 @@ export function createSaveCacheFunction(): BuildFunction {
           .filter(path => path.length > 0);
         const key = z.string().parse(inputs.key.value);
         const jobId = nullthrows(env.EAS_BUILD_ID, 'EAS_BUILD_ID is not set');
-        const expoApiServerURL = nullthrows(
-          stepsCtx.global.staticContext.expoApiServerURL,
-          'expoApiServerURL is not set'
-        );
         const robotAccessToken = nullthrows(
           stepsCtx.global.staticContext.job.secrets?.robotAccessToken,
           'robotAccessToken is not set'
@@ -65,7 +61,7 @@ export function createSaveCacheFunction(): BuildFunction {
           await uploadPublicCacheAsync({
             logger,
             jobId,
-            expoApiServerURL,
+            expoApiServerURL: stepsCtx.global.staticContext.expoApiServerURL,
             robotAccessToken,
             archivePath,
             key,
@@ -77,7 +73,7 @@ export function createSaveCacheFunction(): BuildFunction {
           await uploadCacheAsync({
             logger,
             jobId,
-            expoApiServerURL,
+            expoApiServerURL: stepsCtx.global.staticContext.expoApiServerURL,
             robotAccessToken,
             archivePath,
             key,
@@ -145,6 +141,10 @@ export async function uploadCacheAsync({
       return;
     }
     const textResult = await asyncResult(response.text());
+    const errorMessage = extractValidationErrorMessage(textResult.value);
+    if (errorMessage) {
+      throw new Error(errorMessage);
+    }
     throw new Error(`Unexpected response from server (${response.status}): ${textResult.value}`);
   }
 
@@ -235,6 +235,19 @@ export async function uploadPublicCacheAsync({
   logger.info(`Uploaded cache archive to ${archivePath} (${formatBytes(size)}).`);
 }
 
+function extractValidationErrorMessage(body: string | undefined): string | undefined {
+  if (!body) {
+    return undefined;
+  }
+  try {
+    const { errors } = JSON.parse(body);
+    if (errors?.[0]?.code === 'VALIDATION_ERROR') {
+      return errors[0].message;
+    }
+  } catch {}
+  return undefined;
+}
+
 export async function compressCacheAsync({
   paths,
   workingDirectory,

packages/build-tools/src/steps/functions/startAgentDeviceRemoteSession.ts

@@ -14,30 +14,24 @@ import path from 'node:path';
 
 import { type CustomBuildContext } from '../../customBuildContext';
 import { Sentry } from '../../sentry';
-import { pollAgentDeviceArtifactsForUploadAsync } from '../utils/agentDeviceArtifacts';
 import {
   type DetachedProcessHandle,
   getDeviceRunSessionIdOrThrow,
   getNgrokAuthtokenOrThrow,
   getNgrokTunnelDomainOrThrow,
-  selectXcodeDeveloperDirectoryAsync,
   spawnDetached,
   startNgrokTunnelAsync,
   startServeSimWithTunnelAsync,
   uploadRemoteSessionConfigAsync,
-  waitForDeviceRunSessionStoppedAsync,
   waitForFileAsync,
 } from '../utils/remoteDeviceRunSession';
 
 const AGENT_DEVICE_PACKAGE_NAME = 'agent-device';
-const AGENT_DEVICE_REPO_URL = 'https://github.com/callstack/agent-device.git';
+const AGENT_DEVICE_REPO_URL = 'https://github.com/callstackincubator/agent-device.git';
 const SRC_DIR = '/tmp/agent-device-src';
 const DAEMON_JSON_PATH = path.join(os.homedir(), '.agent-device', 'daemon.json');
+const XCODE_DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
 const STARTUP_TIMEOUT_MS = 60_000;
-const AGENT_DEVICE_DAEMON_ENV = {
-  AGENT_DEVICE_DAEMON_SERVER_MODE: 'http',
-  AGENT_DEVICE_RETAIN_ARTIFACTS: '1',
-};
 
 export function createStartAgentDeviceRemoteSessionBuildFunction(
   ctx: CustomBuildContext
@@ -54,7 +48,7 @@ export function createStartAgentDeviceRemoteSessionBuildFunction(
         allowedValueTypeName: BuildStepInputValueTypeName.STRING,
       }),
     ],
-    fn: async ({ logger, global }, { inputs, env, signal }) => {
+    fn: async ({ logger, global }, { inputs, env }) => {
       // Fail fast before any expensive setup if the injected env
       // vars are missing: DEVICE_RUN_SESSION_ID (to report the remote config
       // back to the API server), EAS_SIMULATOR_NGROK_TUNNEL_DOMAIN (base domain
@@ -70,7 +64,8 @@ export function createStartAgentDeviceRemoteSessionBuildFunction(
       );
 
       if (runtimePlatform === BuildRuntimePlatform.DARWIN) {
-        await selectXcodeDeveloperDirectoryAsync({ env, logger });
+        logger.info(`Selecting Xcode developer directory: ${XCODE_DEVELOPER_DIR}.`);
+        await spawn('sudo', ['xcode-select', '-s', XCODE_DEVELOPER_DIR], { env, logger });
       }
 
       logger.info('Launching agent-device daemon.');
@@ -95,7 +90,7 @@ export function createStartAgentDeviceRemoteSessionBuildFunction(
       // on Darwin. Android sessions go without a preview URL.
       let webPreviewUrl: string | undefined;
       if (runtimePlatform === BuildRuntimePlatform.DARWIN) {
-        const { previewUrl } = await startServeSimWithTunnelAsync(ctx, {
+        const { previewUrl } = await startServeSimWithTunnelAsync({
           baseDomain: ngrokTunnelDomain,
           env,
           logger,
@@ -115,19 +110,11 @@ export function createStartAgentDeviceRemoteSessionBuildFunction(
         },
         logger,
       });
-      void pollAgentDeviceArtifactsForUploadAsync(ctx, {
-        deviceRunSessionId,
-        daemonUrl: `http://127.0.0.1:${daemonPort}`,
-        daemonToken,
-        logger,
-      });
 
-      await waitForDeviceRunSessionStoppedAsync({
-        ctx,
-        deviceRunSessionId,
-        logger,
-        signal,
-      });
+      logger.info('Remote session is live. Keeping the job alive until the session is stopped.');
+      // Keep the turtle job alive so the daemon and tunnel stay reachable
+      // until stopDeviceRunSession cancels the run.
+      await new Promise<never>(() => {});
     },
   });
 }
@@ -158,7 +145,7 @@ async function startAgentDeviceDaemonAsync({
     return spawnDetached({
       command: 'node',
       args: [daemonPath],
-      env: { ...env, ...AGENT_DEVICE_DAEMON_ENV },
+      env: { ...env, AGENT_DEVICE_DAEMON_SERVER_MODE: 'http' },
     });
   } catch (err) {
     const error = err instanceof Error ? err : new Error(String(err));
@@ -215,7 +202,7 @@ async function startAgentDeviceDaemonFromGitAsync({
     command: 'bun',
     args: ['run', 'src/daemon.ts'],
     cwd: SRC_DIR,
-    env: { ...env, ...AGENT_DEVICE_DAEMON_ENV },
+    env: { ...env, AGENT_DEVICE_DAEMON_SERVER_MODE: 'http' },
   });
 }
 

packages/build-tools/src/steps/functions/startArgentRemoteSession.ts

@@ -1,5 +1,4 @@
 import { SystemError } from '@expo/eas-build-job';
-import { type bunyan } from '@expo/logger';
 import {
   BuildFunction,
   BuildRuntimePlatform,
@@ -10,39 +9,26 @@ import spawn from '@expo/turtle-spawn';
 import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
-import semver from 'semver';
 import { z } from 'zod';
 
 import { CustomBuildContext } from '../../customBuildContext';
-import { Sentry } from '../../sentry';
-import { isProcessDescendantOfAsync } from '../../utils/processes';
-import { sleepAsync } from '../../utils/retry';
-import { pollArgentArtifactsForUploadAsync } from '../utils/argentArtifacts';
 import {
   getDeviceRunSessionIdOrThrow,
   getNgrokAuthtokenOrThrow,
   getNgrokTunnelDomainOrThrow,
-  selectXcodeDeveloperDirectoryAsync,
   spawnDetached,
   startNgrokTunnelAsync,
   startServeSimWithTunnelAsync,
   uploadRemoteSessionConfigAsync,
-  waitForDeviceRunSessionStoppedAsync,
+  waitForFileAsync,
 } from '../utils/remoteDeviceRunSession';
 
 const ARGENT_PACKAGE_NAME = '@swmansion/argent';
-export const MIN_ARGENT_REMOTE_SESSION_VERSION = '0.12.0';
-const ARGENT_ARTIFACTS_LIST_ENDPOINT_FLAG = 'artifacts-list-endpoint';
-const ARGENT_STATE_DIR = path.join(os.homedir(), '.argent');
+const ARGENT_STATE_FILE = path.join(os.homedir(), '.argent', 'tool-server.json');
+const XCODE_DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
 const STARTUP_TIMEOUT_MS = 60_000;
 
-const ArgentToolServerStateSchema = z.object({
-  port: z.number(),
-  pid: z.number(),
-  token: z.string().optional(),
-});
-
-type ArgentToolServerState = z.infer<typeof ArgentToolServerStateSchema>;
+const ArgentToolServerStateSchema = z.object({ port: z.number() });
 
 export function createStartArgentRemoteSessionBuildFunction(
   ctx: CustomBuildContext
@@ -59,7 +45,7 @@ export function createStartArgentRemoteSessionBuildFunction(
         allowedValueTypeName: BuildStepInputValueTypeName.STRING,
       }),
     ],
-    fn: async ({ logger, global }, { inputs, env, signal }) => {
+    fn: async ({ logger, global }, { inputs, env }) => {
       // Fail fast before any expensive setup if the injected env
       // vars are missing: DEVICE_RUN_SESSION_ID (to report the remote config
       // back to the API server), EAS_SIMULATOR_NGROK_TUNNEL_DOMAIN (base domain
@@ -69,7 +55,6 @@ export function createStartArgentRemoteSessionBuildFunction(
       const ngrokAuthtoken = getNgrokAuthtokenOrThrow(env);
 
       const packageVersion = inputs.package_version.value as string | undefined;
-      warnIfArgentPackageVersionCannotBeVerified({ packageVersion, logger });
       const versionSpec = packageVersion ?? 'latest';
       const { runtimePlatform } = global;
       logger.info(
@@ -77,214 +62,79 @@ export function createStartArgentRemoteSessionBuildFunction(
       );
 
       if (runtimePlatform === BuildRuntimePlatform.DARWIN) {
-        await selectXcodeDeveloperDirectoryAsync({ env, logger });
+        logger.info(`Selecting Xcode developer directory: ${XCODE_DEVELOPER_DIR}.`);
+        await spawn('sudo', ['xcode-select', '-s', XCODE_DEVELOPER_DIR], { env, logger });
       }
 
-      logger.info('Enabling the Argent artifacts list endpoint flag.');
-      await spawn(
-        'bunx',
-        [`${ARGENT_PACKAGE_NAME}@${versionSpec}`, 'enable', ARGENT_ARTIFACTS_LIST_ENDPOINT_FLAG],
-        { env, logger }
-      );
+      // Stale state from a previous run would mask the new server's port.
+      await fs.promises.rm(ARGENT_STATE_FILE, { force: true });
 
-      logger.info(`Launching ${ARGENT_PACKAGE_NAME}@${versionSpec} tool-server via bunx.`);
-      // Keep Argent itself in foreground mode under the detached bunx process. This preserves
-      // the bunx -> Argent CLI -> tool-server ancestry used to identify the matching state file.
-      const argentServer = spawnDetached({
+      logger.info(`Launching ${ARGENT_PACKAGE_NAME}@${versionSpec} via bunx.`);
+      // `argent mcp` is the public entry that triggers @argent/tools-client
+      // to spawn the tool-server detached + unref'd, so the tool-server
+      // outlives this MCP process. ARGENT_IDLE_TIMEOUT_MINUTES=0 disables the
+      // 30-min idle shutdown that would otherwise tear the tunnel down.
+      spawnDetached({
         command: 'bunx',
-        args: [
-          `${ARGENT_PACKAGE_NAME}@${versionSpec}`,
-          'server',
-          'start',
-          '--port',
-          '0',
-          '--idle-timeout',
-          '0',
-          '--force',
-        ],
-        env,
+        args: [`${ARGENT_PACKAGE_NAME}@${versionSpec}`, 'mcp'],
+        env: { ...env, ARGENT_IDLE_TIMEOUT_MINUTES: '0' },
       });
-      if (argentServer.pid === undefined) {
-        throw new SystemError(
-          'Failed to start Argent: could not determine the PID of the launched process.'
-        );
-      }
 
-      logger.info(`Waiting for argent tool-server state in ${ARGENT_STATE_DIR}.`);
-      let toolServerPort: number;
-      let toolServerToken: string | undefined;
-      try {
-        const toolServerState = await waitForArgentToolServerStateAsync({
-          stateDir: ARGENT_STATE_DIR,
-          ancestorPid: argentServer.pid,
+      logger.info(`Waiting for argent tool-server state at ${ARGENT_STATE_FILE}.`);
+      const { port: toolServerPort } = await waitForFileAsync({
+        filePath: ARGENT_STATE_FILE,
+        timeoutMs: STARTUP_TIMEOUT_MS,
+        description: 'argent tool-server state',
+        parse: parseArgentToolServerState,
+      });
+      logger.info(`Argent tool-server is listening on port ${toolServerPort}.`);
+
+      const toolsUrl = await startNgrokTunnelAsync({
+        port: toolServerPort,
+        subdomainPrefix: 'argent',
+        baseDomain: ngrokTunnelDomain,
+        authtoken: ngrokAuthtoken,
+        logger,
+      });
+      logger.info(`Tunnel is ready at ${toolsUrl}.`);
+
+      // serve-sim is iOS-only — Android sessions go without a preview URL.
+      let webPreviewUrl: string | undefined;
+      if (runtimePlatform === BuildRuntimePlatform.DARWIN) {
+        const serveSim = await startServeSimWithTunnelAsync({
+          baseDomain: ngrokTunnelDomain,
+          env,
+          logger,
           timeoutMs: STARTUP_TIMEOUT_MS,
         });
-        toolServerPort = toolServerState.port;
-        toolServerToken = toolServerState.token;
-      } catch (err) {
-        const output = argentServer.getOutput();
-        throw new SystemError(
-          `${
-            err instanceof Error ? err.message : `Timed out waiting for argent tool-server state.`
-          }${output ? `\nArgent tool-server output:\n${output}` : ''}`
-        );
+        webPreviewUrl = serveSim.previewUrl;
+        logger.info(`Web preview URL: ${webPreviewUrl}`);
       }
-      logger.info(`Argent tool-server is listening on port ${toolServerPort}.`);
-      const artifactPollAbortController = new AbortController();
-      const artifactPollSignal = signal
-        ? AbortSignal.any([signal, artifactPollAbortController.signal])
-        : artifactPollAbortController.signal;
-      const artifactPollingPromise = pollArgentArtifactsForUploadAsync(ctx, {
+
+      await uploadRemoteSessionConfigAsync({
+        ctx,
         deviceRunSessionId,
-        toolsUrl: `http://127.0.0.1:${toolServerPort}`,
-        toolsAuthToken: toolServerToken,
+        remoteConfig: {
+          toolsUrl,
+          ...(webPreviewUrl ? { webPreviewUrl } : {}),
+        },
         logger,
-        signal: artifactPollSignal,
       });
 
-      try {
-        const publicToolsUrl = await startNgrokTunnelAsync({
-          port: toolServerPort,
-          subdomainPrefix: 'argent',
-          baseDomain: ngrokTunnelDomain,
-          authtoken: ngrokAuthtoken,
-          rewriteHostHeader: true,
-          logger,
-        });
-        logger.info(`Tunnel is ready at ${publicToolsUrl}.`);
-
-        // serve-sim is iOS-only — Android sessions go without a preview URL.
-        let webPreviewUrl: string | undefined;
-        if (runtimePlatform === BuildRuntimePlatform.DARWIN) {
-          const serveSim = await startServeSimWithTunnelAsync(ctx, {
-            baseDomain: ngrokTunnelDomain,
-            env,
-            logger,
-            timeoutMs: STARTUP_TIMEOUT_MS,
-          });
-          webPreviewUrl = serveSim.previewUrl;
-          logger.info(`Web preview URL: ${webPreviewUrl}`);
-        }
-
-        await uploadRemoteSessionConfigAsync({
-          ctx,
-          deviceRunSessionId,
-          remoteConfig: {
-            toolsUrl: publicToolsUrl,
-            ...(toolServerToken ? { toolsAuthToken: toolServerToken } : {}),
-            ...(webPreviewUrl ? { webPreviewUrl } : {}),
-          },
-          logger,
-        });
-
-        await waitForDeviceRunSessionStoppedAsync({
-          ctx,
-          deviceRunSessionId,
-          logger,
-          signal,
-        });
-      } finally {
-        artifactPollAbortController.abort();
-        try {
-          await artifactPollingPromise;
-        } catch (err) {
-          const error = err instanceof Error ? err : new Error(String(err));
-          Sentry.capture('Could not finish Argent remote session artifact polling', error);
-          logger.warn({ err: error }, 'Could not finish Argent remote session artifact polling.');
-        }
-      }
+      logger.info('Remote session is live. Keeping the job alive until the session is stopped.');
+      // Keep the turtle job alive so the tool-server and tunnel stay reachable
+      // until stopDeviceRunSession cancels the run.
+      await new Promise<never>(() => {});
     },
   });
 }
 
-export function warnIfArgentPackageVersionCannotBeVerified({
-  packageVersion,
-  logger,
-}: {
-  packageVersion: string | undefined;
-  logger: bunyan;
-}): void {
-  if (!packageVersion || packageVersion === 'latest') {
-    return;
-  }
-
-  const validVersion = semver.valid(packageVersion);
-  if (!validVersion) {
-    logger.warn(
-      `Argent remote simulator sessions require ${ARGENT_PACKAGE_NAME}@${MIN_ARGENT_REMOTE_SESSION_VERSION} or newer, ` +
-        `but package_version "${packageVersion}" is not an exact semver version that EAS can verify. ` +
-        `Continuing and letting bunx resolve it.`
-    );
-    return;
-  }
-
-  if (semver.lt(validVersion, MIN_ARGENT_REMOTE_SESSION_VERSION)) {
-    throw new SystemError(
-      `Argent remote simulator sessions require ${ARGENT_PACKAGE_NAME}@${MIN_ARGENT_REMOTE_SESSION_VERSION} or newer. ` +
-        `The requested package_version "${packageVersion}" is too old for the EAS remote-session API. ` +
-        `Use "latest" or pass an exact version >= ${MIN_ARGENT_REMOTE_SESSION_VERSION}.`
-    );
-  }
-}
-
-function parseArgentToolServerState(raw: string): ArgentToolServerState {
-  let json: unknown;
-  try {
-    json = JSON.parse(raw);
-  } catch (err) {
-    throw new SystemError('Expected tool-server state to contain valid JSON.', { cause: err });
-  }
-  const result = ArgentToolServerStateSchema.safeParse(json);
+function parseArgentToolServerState(raw: string): { port: number } {
+  const result = ArgentToolServerStateSchema.safeParse(JSON.parse(raw));
   if (!result.success) {
     throw new SystemError(
-      `Expected tool-server state to contain { "port": <number>, "pid": <number>, ... }: ${result.error.message}`
+      `Expected tool-server state to contain { "port": <number>, ... }: ${result.error.message}`
     );
   }
   return result.data;
 }
-
-export async function waitForArgentToolServerStateAsync({
-  stateDir,
-  ancestorPid,
-  timeoutMs,
-  pollIntervalMs = 1_000,
-}: {
-  stateDir: string;
-  ancestorPid: number;
-  timeoutMs: number;
-  pollIntervalMs?: number;
-}): Promise<ArgentToolServerState> {
-  const deadline = Date.now() + timeoutMs;
-  let lastError: unknown;
-
-  while (Date.now() < deadline) {
-    try {
-      const stateFileNames = (await fs.promises.readdir(stateDir)).filter(
-        name => name.startsWith('tool-server') && name.endsWith('.json')
-      );
-      for (const stateFileName of stateFileNames) {
-        try {
-          const state = parseArgentToolServerState(
-            await fs.promises.readFile(path.join(stateDir, stateFileName), 'utf8')
-          );
-          if (await isProcessDescendantOfAsync(state.pid, ancestorPid)) {
-            return state;
-          }
-        } catch (err) {
-          if ((err as NodeJS.ErrnoException).code !== 'ENOENT' && !(err instanceof SystemError)) {
-            throw err;
-          }
-        }
-      }
-    } catch (err) {
-      lastError = err;
-    }
-    await sleepAsync(pollIntervalMs);
-  }
-
-  throw new SystemError(
-    `Timed out waiting for an argent tool-server state file belonging to process ${ancestorPid} in ${stateDir}${
-      lastError instanceof Error ? `: ${lastError.message}` : ''
-    }.`
-  );
-}

packages/build-tools/src/steps/functions/startIosSimulator.ts

@@ -31,12 +31,6 @@ export function createStartIosSimulatorBuildFunction(): BuildFunction {
         defaultValue: 1,
         allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
       }),
-      BuildStepInput.createProvider({
-        id: 'enable_accessibility_settings',
-        required: false,
-        defaultValue: false,
-        allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
-      }),
     ],
     fn: async ({ logger }, { inputs, env }) => {
       try {
@@ -61,18 +55,11 @@ export function createStartIosSimulatorBuildFunction(): BuildFunction {
         | undefined;
       const originalDeviceIdentifier =
         deviceIdentifierInput ?? (await findMostGenericIphoneUuidAsync({ env }));
-      const enableAccessibilitySettings = Boolean(inputs.enable_accessibility_settings.value);
 
       if (!originalDeviceIdentifier) {
         throw new Error('Could not find an iPhone among available simulator devices.');
       }
 
-      if (enableAccessibilitySettings) {
-        await IosSimulatorUtils.enableAccessibilitySettingsAsync({
-          deviceIdentifier: originalDeviceIdentifier,
-          env,
-        });
-      }
       const { udid } = await IosSimulatorUtils.startAsync({
         deviceIdentifier: originalDeviceIdentifier,
         env,
@@ -110,12 +97,6 @@ export function createStartIosSimulatorBuildFunction(): BuildFunction {
             env,
           });
 
-          if (enableAccessibilitySettings) {
-            await IosSimulatorUtils.enableAccessibilitySettingsAsync({
-              deviceIdentifier: cloneDeviceName,
-              env,
-            });
-          }
           const { udid: cloneUdid } = await IosSimulatorUtils.startAsync({
             deviceIdentifier: cloneDeviceName,
             env,

packages/build-tools/src/steps/functions/startIosSimulatorRecordings.ts

@@ -1,19 +0,0 @@
-import { BuildFunction, BuildRuntimePlatform } from '@expo/steps';
-
-import { IosSimulatorRecordingUtils } from '../utils/IosSimulatorRecordingUtils';
-
-export function createStartIosSimulatorRecordingsBuildFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'start_ios_simulator_recordings',
-    name: 'Start iOS Simulator recordings',
-    __metricsId: 'eas/start_ios_simulator_recordings',
-    supportedRuntimePlatforms: [BuildRuntimePlatform.DARWIN],
-    fn: async ({ logger }, { env }) => {
-      await IosSimulatorRecordingUtils.startAsync({
-        env,
-        logger,
-      });
-    },
-  });
-}

packages/build-tools/src/steps/functions/startServeSimRemoteSession.ts

@@ -1,15 +1,15 @@
 import { BuildFunction, BuildRuntimePlatform } from '@expo/steps';
+import spawn from '@expo/turtle-spawn';
 
 import { CustomBuildContext } from '../../customBuildContext';
 import {
   getDeviceRunSessionIdOrThrow,
   getNgrokTunnelDomainOrThrow,
-  selectXcodeDeveloperDirectoryAsync,
   startServeSimWithTunnelAsync,
   uploadRemoteSessionConfigAsync,
-  waitForDeviceRunSessionStoppedAsync,
 } from '../utils/remoteDeviceRunSession';
 
+const XCODE_DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
 const STARTUP_TIMEOUT_MS = 60_000;
 
 export function createStartServeSimRemoteSessionBuildFunction(
@@ -21,15 +21,16 @@ export function createStartServeSimRemoteSessionBuildFunction(
     name: 'Start serve-sim remote session',
     __metricsId: 'eas/start_serve_sim_remote_session',
     supportedRuntimePlatforms: [BuildRuntimePlatform.DARWIN],
-    fn: async ({ logger }, { env, signal }) => {
+    fn: async ({ logger }, { env }) => {
       const deviceRunSessionId = getDeviceRunSessionIdOrThrow(env);
       const ngrokTunnelDomain = getNgrokTunnelDomainOrThrow(env);
 
       logger.info('Starting serve-sim remote session.');
 
-      await selectXcodeDeveloperDirectoryAsync({ env, logger });
+      logger.info(`Selecting Xcode developer directory: ${XCODE_DEVELOPER_DIR}.`);
+      await spawn('sudo', ['xcode-select', '-s', XCODE_DEVELOPER_DIR], { env, logger });
 
-      const { previewUrl, streamUrl } = await startServeSimWithTunnelAsync(ctx, {
+      const { previewUrl, streamUrl } = await startServeSimWithTunnelAsync({
         baseDomain: ngrokTunnelDomain,
         env,
         logger,
@@ -45,12 +46,10 @@ export function createStartServeSimRemoteSessionBuildFunction(
         logger,
       });
 
-      await waitForDeviceRunSessionStoppedAsync({
-        ctx,
-        deviceRunSessionId,
-        logger,
-        signal,
-      });
+      logger.info('Remote session is live. Keeping the job alive until the session is stopped.');
+      // Keep the turtle job alive so the serve-sim tunnel stays reachable
+      // until stopDeviceRunSession cancels the run.
+      await new Promise<never>(() => {});
     },
   });
 }

packages/build-tools/src/steps/functions/uploadArtifact.ts

@@ -1,9 +1,4 @@
-import {
-  GenericArtifactType,
-  Job,
-  ManagedArtifactType,
-  isGenericArtifact,
-} from '@expo/eas-build-job';
+import { GenericArtifactType, Job, ManagedArtifactType } from '@expo/eas-build-job';
 import {
   BuildFunction,
   BuildStepInput,
@@ -70,11 +65,6 @@ export function createUploadArtifactBuildFunction(ctx: CustomBuildContext): Buil
         required: false,
         allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
       }),
-      BuildStepInput.createProvider({
-        id: 'metadata',
-        required: false,
-        allowedValueTypeName: BuildStepInputValueTypeName.JSON,
-      }),
     ],
     outputProviders: [
       BuildStepOutput.createProvider({
@@ -118,7 +108,7 @@ export function createUploadArtifactBuildFunction(ctx: CustomBuildContext): Buil
         throw result.reason;
       });
 
-      const artifactSpec = {
+      const artifact = {
         type: parseArtifactTypeInput({
           platform: ctx.job.platform,
           inputValue: `${inputs.type.value ?? ''}`,
@@ -126,22 +116,19 @@ export function createUploadArtifactBuildFunction(ctx: CustomBuildContext): Buil
         paths: artifactPaths,
         name: (inputs.name.value || inputs.key.value) as string,
       };
-      const artifact = isGenericArtifact(artifactSpec)
-        ? {
-            ...artifactSpec,
-            metadata: inputs.metadata.value as Record<string, unknown> | undefined,
-          }
-        : artifactSpec;
 
       try {
-        const { artifactId } = await ctx.runtimeApi.uploadArtifact({ artifact, logger });
+        const { artifactId } = await ctx.runtimeApi.uploadArtifact({
+          artifact,
+          logger,
+        });
 
         if (artifactId) {
           outputs.artifact_id.set(artifactId);
         }
       } catch (error) {
         if (inputs.ignore_error.value) {
-          logger.error({ err: error }, `Failed to upload ${artifact.type}. Ignoring error.`);
+          logger.error(`Failed to upload ${artifact.type}. Ignoring error.`, error);
           // Ignoring error.
           return;
         }

packages/build-tools/src/steps/functions/uploadDeviceRunSessionScreenRecordings.ts

@@ -1,111 +0,0 @@
-import { SystemError } from '@expo/eas-build-job';
-import {
-  BuildFunction,
-  BuildRuntimePlatform,
-  BuildStepInput,
-  BuildStepInputValueTypeName,
-} from '@expo/steps';
-import { createReadStream } from 'node:fs';
-import { readFile, stat } from 'node:fs/promises';
-import path from 'node:path';
-import limitFactory from 'promise-limit';
-import { z } from 'zod';
-
-import { type CustomBuildContext } from '../../customBuildContext';
-import { Sentry } from '../../sentry';
-import { formatBytes } from '../../utils/artifacts';
-import { uploadDeviceRunSessionArtifactAsync } from '../utils/deviceRunSessionArtifacts';
-import { getDeviceRunSessionIdOrThrow } from '../utils/remoteDeviceRunSession';
-
-const RecordingsSchema = z.array(
-  z.object({
-    udid: z.string(),
-    deviceName: z.string(),
-    runtimeDisplayName: z.string(),
-    directory: z.string(),
-  })
-);
-
-const RecordingManifestSchema = z.object({
-  firstFrameWallClock: z.object({
-    iso8601: z.string(),
-  }),
-  recording: z.string(),
-});
-
-export function createUploadDeviceRunSessionScreenRecordingsBuildFunction(
-  ctx: CustomBuildContext
-): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'upload_device_run_session_screen_recordings',
-    name: 'Upload device run session screen recordings',
-    __metricsId: 'eas/upload_device_run_session_screen_recordings',
-    supportedRuntimePlatforms: [BuildRuntimePlatform.DARWIN],
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'recordings_json',
-        required: false,
-        allowedValueTypeName: BuildStepInputValueTypeName.JSON,
-      }),
-    ],
-    fn: async ({ logger }, { env, inputs }) => {
-      const result = RecordingsSchema.safeParse(inputs.recordings_json.value ?? []);
-      if (!result.success) {
-        throw new SystemError('Invalid iOS Simulator recordings input.', {
-          cause: result.error,
-        });
-      }
-      const recordings = result.data;
-      if (recordings.length === 0) {
-        logger.info('No iOS Simulator recordings found; skipping uploads.');
-        return;
-      }
-
-      const deviceRunSessionId = getDeviceRunSessionIdOrThrow(env);
-
-      const limit = limitFactory(5);
-      await Promise.all(
-        recordings.map(recording =>
-          limit(async () => {
-            const displayName = `${recording.deviceName} screen recording`;
-            try {
-              const metadata = RecordingManifestSchema.parse(
-                JSON.parse(await readFile(path.join(recording.directory, 'session.json'), 'utf-8'))
-              );
-              const recordingPath = path.join(recording.directory, metadata.recording);
-              const { size } = await stat(recordingPath);
-              const recordingId = path.basename(recording.directory);
-              logger.info(
-                `Uploading screen recording for ${recording.deviceName} (${formatBytes(size)}).`
-              );
-              await uploadDeviceRunSessionArtifactAsync(ctx, {
-                deviceRunSessionId,
-                artifactId: recordingId,
-                name: displayName,
-                filename: `${recordingId}.mp4`,
-                kind: 'screen-recording',
-                metadata: {
-                  __eas_screen_recording: '1',
-                  udid: recording.udid,
-                  deviceName: recording.deviceName,
-                  runtimeDisplayName: recording.runtimeDisplayName,
-                  firstFrameAt: metadata.firstFrameWallClock.iso8601,
-                },
-                size,
-                stream: createReadStream(recordingPath),
-              });
-            } catch (err) {
-              const error = err instanceof Error ? err : new Error(String(err));
-              Sentry.capture('Could not upload iOS Simulator screen recording', error);
-              logger.warn(
-                { err: error },
-                `Could not upload screen recording for ${recording.deviceName}.`
-              );
-            }
-          })
-        )
-      );
-    },
-  });
-}

packages/build-tools/src/steps/functions/uploadPosthogSourcemaps.ts

@@ -1,89 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { PipeMode } from '@expo/logger';
-import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
-import spawn from '@expo/turtle-spawn';
-
-import { PosthogClient } from '../utils/PosthogClient';
-import { PosthogUtils } from '../utils/PosthogUtils';
-
-export function createUploadPosthogSourcemapsFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'posthog_upload_sourcemaps',
-    name: 'Upload source maps to PostHog',
-    __metricsId: 'eas/posthog_upload_sourcemaps',
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'directory',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-        defaultValue: 'dist',
-      }),
-      BuildStepInput.createProvider({
-        id: 'api_key',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'project_id',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'ignore_error',
-        allowedValueTypeName: BuildStepInputValueTypeName.BOOLEAN,
-        required: false,
-      }),
-    ],
-    fn: async (stepCtx, { inputs, env, signal }) => {
-      const { logger } = stepCtx;
-      const ignoreError = Boolean(inputs.ignore_error.value);
-
-      const result = PosthogClient.fromEnv({
-        apiKeyOverride: inputs.api_key.value as string | undefined,
-        projectIdOverride: inputs.project_id.value as string | undefined,
-        env,
-      });
-      if (!result.client) {
-        PosthogUtils.failOrLogError({
-          logger,
-          ignoreError,
-          error: PosthogUtils.missingCredentialsError(result.missing),
-        });
-        return;
-      }
-      const client = result.client;
-
-      const directory = inputs.directory.value as string;
-      const { host, env: cliEnv } = client.cliConfig();
-      logger.info(`Uploading source maps from "${directory}" to PostHog`);
-      try {
-        await spawn(
-          'npx',
-          ['-y', '@posthog/cli', '--host', host, 'hermes', 'upload', '--directory', directory],
-          {
-            logger,
-            // @posthog/cli writes all its logs, progress and success included, to stderr; tag them as stdout so they don't surface as build errors.
-            mode: PipeMode.COMBINED_AS_STDOUT,
-            cwd: stepCtx.workingDirectory,
-            env: { ...env, ...cliEnv },
-            signal,
-          }
-        );
-      } catch (error) {
-        PosthogUtils.failOrLogError({
-          logger,
-          ignoreError,
-          error: new UserError(
-            'EAS_POSTHOG_SOURCEMAPS_FAILED',
-            'Uploading source maps to PostHog failed.',
-            { cause: error }
-          ),
-        });
-        return;
-      }
-
-      logger.info('Uploaded source maps to PostHog');
-    },
-  });
-}

packages/build-tools/src/steps/functions/uploadToAsc.ts

@@ -23,7 +23,6 @@ export function createUploadToAscBuildFunction(): BuildFunction {
     id: 'upload_to_asc',
     name: 'Upload to App Store Connect',
     __metricsId: 'eas/upload_to_asc',
-    __hookId: 'submit',
     inputProviders: [
       BuildStepInput.createProvider({
         id: 'ipa_path',

packages/build-tools/src/steps/functions/waitForPosthogMetric.ts

@@ -1,185 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { bunyan } from '@expo/logger';
-import {
-  BuildFunction,
-  BuildStepInput,
-  BuildStepInputValueTypeName,
-  BuildStepOutput,
-} from '@expo/steps';
-
-import { PosthogClient, PosthogRetryableError } from '../utils/PosthogClient';
-import { PosthogUtils } from '../utils/PosthogUtils';
-
-const OPERATORS = {
-  lt: { symbol: '<', test: (value: number, threshold: number) => value < threshold },
-  lte: { symbol: '<=', test: (value: number, threshold: number) => value <= threshold },
-  gt: { symbol: '>', test: (value: number, threshold: number) => value > threshold },
-  gte: { symbol: '>=', test: (value: number, threshold: number) => value >= threshold },
-  eq: { symbol: '=', test: (value: number, threshold: number) => value === threshold },
-};
-
-type Operator = keyof typeof OPERATORS;
-
-export function createWaitForPosthogMetricFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'posthog_wait_for_metric',
-    name: 'Wait for a PostHog metric',
-    __metricsId: 'eas/posthog_wait_for_metric',
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'query',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'operator',
-        allowedValues: Object.keys(OPERATORS),
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'threshold',
-        allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'timeout_seconds',
-        allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
-        required: false,
-        defaultValue: PosthogUtils.DEFAULT_POLL_TIMEOUT_SECONDS,
-      }),
-      BuildStepInput.createProvider({
-        id: 'interval_seconds',
-        allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
-        required: false,
-        defaultValue: PosthogUtils.DEFAULT_POLL_INTERVAL_SECONDS,
-      }),
-      BuildStepInput.createProvider({
-        id: 'api_key',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'project_id',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-    ],
-    outputProviders: [BuildStepOutput.createProvider({ id: 'value', required: false })],
-    fn: async (stepCtx, { inputs, outputs, env, signal }) => {
-      const { logger } = stepCtx;
-
-      const operator = inputs.operator.value as string;
-      if (!Object.keys(OPERATORS).includes(operator)) {
-        throw new UserError(
-          'EAS_POSTHOG_METRIC_INVALID_OPERATOR',
-          `Invalid "operator" "${operator}". Must be one of: ${Object.keys(OPERATORS).join(', ')}.`
-        );
-      }
-      const timeoutSeconds = inputs.timeout_seconds.value as number;
-      const intervalSeconds = inputs.interval_seconds.value as number;
-      PosthogUtils.assertPollBoundsPositive({
-        timeoutSeconds,
-        intervalSeconds,
-        errorCode: 'EAS_POSTHOG_METRIC_INVALID_INTERVAL',
-      });
-
-      const result = PosthogClient.fromEnv({
-        apiKeyOverride: inputs.api_key.value as string | undefined,
-        projectIdOverride: inputs.project_id.value as string | undefined,
-        env,
-      });
-      if (!result.client) {
-        throw PosthogUtils.missingCredentialsError(result.missing);
-      }
-      const client = result.client;
-
-      const value = await waitForPosthogMetricAsync({
-        logger,
-        client,
-        query: inputs.query.value as string,
-        operator: operator as Operator,
-        threshold: inputs.threshold.value as number,
-        timeoutSeconds,
-        intervalSeconds,
-        signal,
-      });
-      outputs.value.set(String(value));
-    },
-  });
-}
-
-async function waitForPosthogMetricAsync({
-  logger,
-  client,
-  query,
-  operator,
-  threshold,
-  timeoutSeconds,
-  intervalSeconds,
-  signal,
-}: {
-  logger: bunyan;
-  client: PosthogClient;
-  query: string;
-  operator: Operator;
-  threshold: number;
-  timeoutSeconds: number;
-  intervalSeconds: number;
-  signal: AbortSignal | undefined;
-}): Promise<number> {
-  const deadline = Date.now() + timeoutSeconds * 1000;
-  const { symbol, test } = OPERATORS[operator];
-  const target = `${symbol} ${threshold}`;
-  let lastValue: number | undefined;
-
-  logger.info(
-    `Waiting for the PostHog metric to reach ${target}. Checking every ${intervalSeconds}s for up to ${timeoutSeconds}s.`
-  );
-
-  for (;;) {
-    let value: number | undefined = undefined;
-    try {
-      value = await queryMetricAsync({ logger, client, query, signal });
-    } catch (error) {
-      if (!(error instanceof PosthogRetryableError)) {
-        throw error;
-      }
-    }
-    if (value !== undefined) {
-      lastValue = value;
-      if (test(value, threshold)) {
-        logger.info(`Metric is ${value}. Target ${target} met.`);
-        return value;
-      }
-      logger.info(`Metric is ${value}. Still waiting for ${target}.`);
-    } else {
-      logger.info('The query has not returned a numeric value yet. Still waiting.');
-    }
-
-    if (!(await PosthogUtils.waitForNextPollAsync({ intervalSeconds, deadline, signal }))) {
-      throw new UserError(
-        'EAS_POSTHOG_METRIC_TIMEOUT',
-        lastValue !== undefined
-          ? `The PostHog metric did not reach ${target} within ${timeoutSeconds}s (last value: ${lastValue}).`
-          : `The PostHog query never returned a numeric value within ${timeoutSeconds}s. Check that the query returns a single number and that PostHog is reachable.`
-      );
-    }
-  }
-}
-
-async function queryMetricAsync({
-  logger,
-  client,
-  query,
-  signal,
-}: {
-  logger: bunyan;
-  client: PosthogClient;
-  query: string;
-  signal: AbortSignal | undefined;
-}): Promise<number | undefined> {
-  const cell = await client.runQueryAsync(query, logger, signal);
-  return typeof cell === 'number' && Number.isFinite(cell) ? cell : undefined;
-}

packages/build-tools/src/steps/functions/waitForPosthogQuery.ts

@@ -1,120 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { bunyan } from '@expo/logger';
-import { BuildFunction, BuildStepInput, BuildStepInputValueTypeName } from '@expo/steps';
-
-import { PosthogClient, PosthogRetryableError } from '../utils/PosthogClient';
-import { PosthogUtils } from '../utils/PosthogUtils';
-
-export function createWaitForPosthogQueryFunction(): BuildFunction {
-  return new BuildFunction({
-    namespace: 'eas',
-    id: 'posthog_wait_for_query',
-    name: 'Wait for a PostHog query',
-    __metricsId: 'eas/posthog_wait_for_query',
-    inputProviders: [
-      BuildStepInput.createProvider({
-        id: 'query',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: true,
-      }),
-      BuildStepInput.createProvider({
-        id: 'timeout_seconds',
-        allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
-        required: false,
-        defaultValue: PosthogUtils.DEFAULT_POLL_TIMEOUT_SECONDS,
-      }),
-      BuildStepInput.createProvider({
-        id: 'interval_seconds',
-        allowedValueTypeName: BuildStepInputValueTypeName.NUMBER,
-        required: false,
-        defaultValue: PosthogUtils.DEFAULT_POLL_INTERVAL_SECONDS,
-      }),
-      BuildStepInput.createProvider({
-        id: 'api_key',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-      BuildStepInput.createProvider({
-        id: 'project_id',
-        allowedValueTypeName: BuildStepInputValueTypeName.STRING,
-        required: false,
-      }),
-    ],
-    fn: async (stepCtx, { inputs, env, signal }) => {
-      const { logger } = stepCtx;
-
-      const timeoutSeconds = inputs.timeout_seconds.value as number;
-      const intervalSeconds = inputs.interval_seconds.value as number;
-      PosthogUtils.assertPollBoundsPositive({
-        timeoutSeconds,
-        intervalSeconds,
-        errorCode: 'EAS_POSTHOG_QUERY_INVALID_INTERVAL',
-      });
-
-      const result = PosthogClient.fromEnv({
-        apiKeyOverride: inputs.api_key.value as string | undefined,
-        projectIdOverride: inputs.project_id.value as string | undefined,
-        env,
-      });
-      if (!result.client) {
-        throw PosthogUtils.missingCredentialsError(result.missing);
-      }
-      const client = result.client;
-
-      await waitForPosthogQueryAsync({
-        logger,
-        client,
-        query: inputs.query.value as string,
-        timeoutSeconds,
-        intervalSeconds,
-        signal,
-      });
-    },
-  });
-}
-
-async function waitForPosthogQueryAsync({
-  logger,
-  client,
-  query,
-  timeoutSeconds,
-  intervalSeconds,
-  signal,
-}: {
-  logger: bunyan;
-  client: PosthogClient;
-  query: string;
-  timeoutSeconds: number;
-  intervalSeconds: number;
-  signal: AbortSignal | undefined;
-}): Promise<void> {
-  const deadline = Date.now() + timeoutSeconds * 1000;
-
-  logger.info(
-    `Waiting for the PostHog query to return true. Checking every ${intervalSeconds}s for up to ${timeoutSeconds}s.`
-  );
-
-  for (;;) {
-    let cell: unknown;
-    try {
-      cell = await client.runQueryAsync(query, logger, signal);
-    } catch (error) {
-      if (!(error instanceof PosthogRetryableError)) {
-        throw error;
-      }
-      cell = undefined;
-    }
-    if (cell === true || (typeof cell === 'number' && cell !== 0)) {
-      logger.info('Query returned true.');
-      return;
-    }
-    logger.info('Query is not true yet. Still waiting.');
-
-    if (!(await PosthogUtils.waitForNextPollAsync({ intervalSeconds, deadline, signal }))) {
-      throw new UserError(
-        'EAS_POSTHOG_QUERY_TIMEOUT',
-        `The PostHog query did not return true within ${timeoutSeconds}s. It must select a single boolean, e.g. "SELECT count() > 100 FROM events".`
-      );
-    }
-  }
-}

packages/build-tools/src/steps/utils/IosSimulatorRecordingUtils.ts

@@ -1,303 +0,0 @@
-import { type Env } from '@expo/eas-build-job';
-import { type bunyan } from '@expo/logger';
-import spawn from '@expo/turtle-spawn';
-import { type ChildProcess } from 'node:child_process';
-import { randomUUID } from 'node:crypto';
-import { access, mkdir, mkdtemp } from 'node:fs/promises';
-import os from 'node:os';
-import path from 'node:path';
-import { setTimeout } from 'node:timers/promises';
-
-import { Sentry } from '../../sentry';
-import { IosSimulatorUtils, type IosSimulatorUuid } from '../../utils/IosSimulatorUtils';
-
-const IOS_SIMULATOR_RECORDING_POLL_INTERVAL_MS = 2_000;
-const RECORD_SIM_FINISH_TIMEOUT_MS = 30_000;
-const RECORD_SIM_FORCE_STOP_TIMEOUT_MS = 5_000;
-const RECORD_SIM_MAX_ATTEMPTS_PER_BOOT = 3;
-const RECORD_SIM_COMMAND = 'record-sim';
-
-type IosSimulatorRecording = {
-  id: string;
-  udid: IosSimulatorUuid;
-  deviceName: string;
-  runtimeDisplayName: string;
-  outputDirectory: string;
-  startedAt: Date;
-  getOutput: () => string;
-};
-
-type ActiveIosSimulatorRecording = IosSimulatorRecording & {
-  recordingProcess: ChildProcess;
-  completionPromise: Promise<void>;
-};
-
-type IosSimulatorRecordingSession = {
-  env: Env;
-  logger: bunyan;
-  recordSimCommand: string;
-  recordingsRootDirectory: string;
-  activeRecordings: Map<IosSimulatorUuid, ActiveIosSimulatorRecording>;
-  completedRecordings: IosSimulatorRecording[];
-  recordingFailureCounts: Map<IosSimulatorUuid, number>;
-  pollingPromise: Promise<void>;
-  abortController: AbortController;
-};
-
-let activeIosSimulatorRecordingSession: IosSimulatorRecordingSession | null = null;
-
-export namespace IosSimulatorRecordingUtils {
-  export async function startAsync({ env, logger }: { env: Env; logger: bunyan }): Promise<void> {
-    if (activeIosSimulatorRecordingSession) {
-      logger.info('iOS Simulator screen recording polling is already running.');
-      return;
-    }
-
-    const recordSimCommand = await resolveRecordSimCommandAsync({ env });
-    if (!recordSimCommand) {
-      logger.warn(
-        'record-sim binary is not available; iOS Simulator screen recordings are disabled.'
-      );
-      return;
-    }
-
-    const recordingsRootDirectory = await mkdtemp(
-      path.join(os.tmpdir(), 'ios-simulator-recordings-')
-    );
-    const session: IosSimulatorRecordingSession = {
-      env,
-      logger,
-      recordSimCommand,
-      recordingsRootDirectory,
-      activeRecordings: new Map(),
-      completedRecordings: [],
-      recordingFailureCounts: new Map(),
-      pollingPromise: Promise.resolve(),
-      abortController: new AbortController(),
-    };
-    activeIosSimulatorRecordingSession = session;
-
-    logger.info('Started polling iOS Simulators for screen recordings.');
-    session.pollingPromise = pollIosSimulatorRecordingsAsync(session).catch(err => {
-      const error = err instanceof Error ? err : new Error(String(err));
-      Sentry.capture('iOS Simulator screen recording poller failed', error);
-      logger.warn({ err: error }, 'iOS Simulator screen recording poller failed.');
-    });
-  }
-
-  export async function finishAsync({ logger }: { logger: bunyan }): Promise<
-    {
-      udid: IosSimulatorUuid;
-      deviceName: string;
-      runtimeDisplayName: string;
-      directory: string;
-    }[]
-  > {
-    const session = activeIosSimulatorRecordingSession;
-    if (!session) {
-      logger.info('No iOS Simulator screen recordings are running.');
-      return [];
-    }
-    activeIosSimulatorRecordingSession = null;
-
-    session.abortController.abort();
-    await session.pollingPromise;
-    await Promise.all(
-      [...session.activeRecordings.values()].map(async recording => {
-        logger.info(`Stopping screen recording for ${recording.deviceName}.`);
-        recording.recordingProcess.kill('SIGINT');
-        const finished = await Promise.race([
-          recording.completionPromise.then(() => true),
-          setTimeout(RECORD_SIM_FINISH_TIMEOUT_MS, false, { ref: false }),
-        ]);
-        if (finished) {
-          return;
-        }
-
-        logger.warn(`Forcing iOS Simulator recording process for ${recording.deviceName} to stop.`);
-        recording.recordingProcess.kill('SIGKILL');
-        const killed = await Promise.race([
-          recording.completionPromise.then(() => true),
-          setTimeout(RECORD_SIM_FORCE_STOP_TIMEOUT_MS, false, { ref: false }),
-        ]);
-        if (!killed) {
-          logger.warn(
-            `iOS Simulator recording process for ${recording.deviceName} did not exit after SIGKILL.`
-          );
-          Sentry.capture(
-            `iOS Simulator recording process for ${recording.deviceName} did not exit after SIGKILL.`,
-            {
-              extras: {
-                output: recording.getOutput(),
-              },
-            }
-          );
-        }
-      })
-    );
-
-    const completedRecordings = [...session.completedRecordings].sort(
-      (a, b) => a.startedAt.getTime() - b.startedAt.getTime()
-    );
-    return completedRecordings.map(recording => ({
-      udid: recording.udid,
-      deviceName: recording.deviceName,
-      runtimeDisplayName: recording.runtimeDisplayName,
-      directory: recording.outputDirectory,
-    }));
-  }
-}
-
-async function pollIosSimulatorRecordingsAsync(
-  session: IosSimulatorRecordingSession
-): Promise<void> {
-  let listDevicesErrorCount = 0;
-
-  const signal = session.abortController.signal;
-
-  while (!signal.aborted) {
-    try {
-      const bootedDevices = await IosSimulatorUtils.getAvailableDevicesAsync({
-        env: session.env,
-        filter: 'booted',
-      });
-      if (signal.aborted) {
-        break;
-      }
-      listDevicesErrorCount = 0;
-
-      const bootedUdids = new Set(bootedDevices.map(device => device.udid));
-      for (const udid of session.recordingFailureCounts.keys()) {
-        if (!bootedUdids.has(udid)) {
-          session.recordingFailureCounts.delete(udid);
-        }
-      }
-
-      for (const device of bootedDevices) {
-        if (
-          session.activeRecordings.has(device.udid) ||
-          (session.recordingFailureCounts.get(device.udid) ?? 0) >= RECORD_SIM_MAX_ATTEMPTS_PER_BOOT
-        ) {
-          continue;
-        }
-        await startIosSimulatorRecordingAsync(session, {
-          udid: device.udid,
-          deviceName: device.name,
-          runtimeDisplayName: device.runtimeDisplayName,
-        });
-      }
-    } catch (err) {
-      const error = err instanceof Error ? err : new Error(String(err));
-      listDevicesErrorCount += 1;
-      if (listDevicesErrorCount === 1 || listDevicesErrorCount % 5 === 0) {
-        Sentry.capture('Could not poll iOS Simulators for screen recordings', error);
-        session.logger.warn(
-          { err: error, failedSimulatorListCount: listDevicesErrorCount },
-          'Could not poll iOS Simulators for screen recordings.'
-        );
-      }
-    }
-
-    if (!signal.aborted) {
-      try {
-        await setTimeout(IOS_SIMULATOR_RECORDING_POLL_INTERVAL_MS, undefined, {
-          signal,
-        });
-      } catch (err) {
-        if (!signal.aborted) {
-          throw err;
-        }
-      }
-    }
-  }
-}
-
-async function startIosSimulatorRecordingAsync(
-  session: IosSimulatorRecordingSession,
-  {
-    udid,
-    deviceName,
-    runtimeDisplayName,
-  }: {
-    udid: IosSimulatorUuid;
-    deviceName: string;
-    runtimeDisplayName: string;
-  }
-): Promise<void> {
-  const startedAt = new Date();
-  const recordingId = randomUUID();
-  const outputDirectory = path.join(session.recordingsRootDirectory, recordingId);
-  await mkdir(outputDirectory, { recursive: true });
-
-  session.logger.info(`Starting screen recording for ${deviceName}.`);
-  const recordingSpawn = spawn(
-    session.recordSimCommand,
-    ['--udid', udid, '--output', outputDirectory, '--segment-duration', '0'],
-    {
-      env: session.env,
-      stdio: ['ignore', 'pipe', 'pipe'],
-    }
-  );
-  const getOutput = captureProcessOutput(recordingSpawn.child);
-  const completionPromise = recordingSpawn
-    .then(() => undefined)
-    .catch((err: unknown) => {
-      session.recordingFailureCounts.set(udid, (session.recordingFailureCounts.get(udid) ?? 0) + 1);
-      const error = err instanceof Error ? err : new Error(String(err));
-      Sentry.capture('iOS Simulator screen recording process failed', error);
-      session.logger.warn(
-        { err: error, recordSimOutput: getOutput() },
-        `Screen recording process failed for ${deviceName}.`
-      );
-    })
-    .finally(() => {
-      session.activeRecordings.delete(udid);
-      session.completedRecordings.push({
-        id: recordingId,
-        udid,
-        deviceName,
-        runtimeDisplayName,
-        outputDirectory,
-        startedAt,
-        getOutput,
-      });
-    });
-
-  session.activeRecordings.set(udid, {
-    id: recordingId,
-    udid,
-    deviceName,
-    runtimeDisplayName,
-    outputDirectory,
-    recordingProcess: recordingSpawn.child,
-    completionPromise,
-    startedAt,
-    getOutput,
-  });
-}
-
-async function resolveRecordSimCommandAsync({ env }: { env: Env }): Promise<string | null> {
-  try {
-    await spawn('which', [RECORD_SIM_COMMAND], { env });
-    return RECORD_SIM_COMMAND;
-  } catch {}
-
-  const packagedRecordSimPath = path.join(__dirname, '..', '..', '..', 'bin', RECORD_SIM_COMMAND);
-  try {
-    await access(packagedRecordSimPath);
-    return packagedRecordSimPath;
-  } catch {
-    return null;
-  }
-}
-
-function captureProcessOutput(recordingProcess: ChildProcess): () => string {
-  let output = '';
-  const appendChunk = (chunk: Buffer | string): void => {
-    // Keep enough recorder stderr/stdout for diagnostics without retaining unbounded output.
-    output = `${output}${chunk.toString()}`.slice(-16_384);
-  };
-  recordingProcess.stdout?.on('data', appendChunk);
-  recordingProcess.stderr?.on('data', appendChunk);
-  return () => output;
-}

packages/build-tools/src/steps/utils/PosthogClient.ts

@@ -1,226 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { bunyan } from '@expo/logger';
-import { type BuildStepEnv } from '@expo/steps';
-import fetch, { Response } from 'node-fetch';
-import { z } from 'zod';
-
-import { PosthogUtils } from './PosthogUtils';
-
-const POSTHOG_DEFAULT_HOST = 'https://us.posthog.com';
-const SYSTEM_DISTINCT_ID = 'eas-workflow';
-
-const QueryResponseSchema = z.object({ results: z.array(z.array(z.unknown())) });
-
-export class PosthogRetryableError extends Error {}
-
-export class PosthogClient {
-  private constructor(
-    private readonly host: string,
-    private readonly apiKey: string,
-    private readonly projectId: string
-  ) {}
-
-  static fromEnv({
-    apiKeyOverride,
-    projectIdOverride,
-    env,
-  }: {
-    apiKeyOverride: string | undefined;
-    projectIdOverride: string | undefined;
-    env: BuildStepEnv;
-  }): { client: PosthogClient } | { client: undefined; missing: PosthogUtils.Credential[] } {
-    const apiKey = apiKeyOverride || env.POSTHOG_CLI_API_KEY;
-    const projectId = projectIdOverride || env.POSTHOG_CLI_PROJECT_ID;
-    if (!apiKey || !projectId) {
-      return {
-        client: undefined,
-        missing: [
-          ...(apiKey ? [] : [PosthogUtils.API_CREDENTIALS.apiKey]),
-          ...(projectId ? [] : [PosthogUtils.API_CREDENTIALS.projectId]),
-        ],
-      };
-    }
-    return {
-      client: new PosthogClient(
-        (env.POSTHOG_CLI_HOST || POSTHOG_DEFAULT_HOST).replace(/\/+$/, ''),
-        apiKey,
-        projectId
-      ),
-    };
-  }
-
-  static forIngestion({
-    apiKeyOverride,
-    hostOverride,
-    env,
-  }: {
-    apiKeyOverride: string | undefined;
-    hostOverride: string | undefined;
-    env: BuildStepEnv;
-  }): PosthogClient | undefined {
-    const apiKey = apiKeyOverride || env.EXPO_PUBLIC_POSTHOG_API_KEY || env.POSTHOG_API_KEY;
-    if (!apiKey) {
-      return undefined;
-    }
-    return new PosthogClient(
-      (hostOverride || env.EXPO_PUBLIC_POSTHOG_HOST || POSTHOG_DEFAULT_HOST).replace(/\/+$/, ''),
-      apiKey,
-      ''
-    );
-  }
-
-  async captureEventAsync({
-    event,
-    distinctId,
-    properties,
-    signal,
-  }: {
-    event: string;
-    distinctId: string | undefined;
-    properties: Record<string, unknown> | undefined;
-    signal: AbortSignal | undefined;
-  }): Promise<void> {
-    let response: Response;
-    try {
-      response = await fetch(`${this.host}/i/v0/e/`, {
-        method: 'POST',
-        headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({
-          api_key: this.apiKey,
-          event,
-          distinct_id: distinctId ?? SYSTEM_DISTINCT_ID,
-          properties:
-            distinctId !== undefined
-              ? properties
-              : { ...properties, $process_person_profile: false },
-          timestamp: new Date().toISOString(),
-        }),
-        signal,
-      });
-    } catch (error) {
-      if (signal?.aborted) {
-        throw error;
-      }
-      throw new UserError(
-        'EAS_POSTHOG_CAPTURE_FAILED',
-        `Sending PostHog event "${event}" failed.`,
-        {
-          cause: error,
-        }
-      );
-    }
-    if (!response.ok) {
-      throw new UserError(
-        'EAS_POSTHOG_CAPTURE_FAILED',
-        `Sending PostHog event "${event}" failed with ${await PosthogUtils.readErrorAsync(response)}.`
-      );
-    }
-  }
-
-  async requestAsync(
-    method: 'GET' | 'POST' | 'PATCH',
-    path: string,
-    {
-      action,
-      forbiddenScope,
-      body,
-      signal,
-    }: { action: string; forbiddenScope: string; body?: unknown; signal: AbortSignal | undefined }
-  ): Promise<Response> {
-    let response: Response;
-    try {
-      response = await fetch(this.apiUrl(path), {
-        method,
-        headers: this.authHeaders(),
-        body: body !== undefined ? JSON.stringify(body) : undefined,
-        signal,
-      });
-    } catch (error) {
-      if (signal?.aborted) {
-        throw error;
-      }
-      throw new UserError('EAS_POSTHOG_REQUEST_FAILED', `${action} failed.`, { cause: error });
-    }
-    if (response.status === 403) {
-      throw new UserError(
-        'EAS_POSTHOG_FORBIDDEN',
-        `${action} was forbidden (403). The personal API key likely lacks the "${forbiddenScope}" scope.`
-      );
-    }
-    if (!response.ok) {
-      throw new UserError(
-        'EAS_POSTHOG_REQUEST_FAILED',
-        `${action} failed with ${await PosthogUtils.readErrorAsync(response)}.`
-      );
-    }
-    return response;
-  }
-
-  async runQueryAsync(
-    query: string,
-    logger: bunyan,
-    signal: AbortSignal | undefined
-  ): Promise<unknown> {
-    let response: Response;
-    try {
-      response = await fetch(this.apiUrl('/query/'), {
-        method: 'POST',
-        headers: this.authHeaders(),
-        body: JSON.stringify({ query: { kind: 'HogQLQuery', query }, refresh: 'blocking' }),
-        signal,
-      });
-    } catch (error) {
-      if (signal?.aborted) {
-        throw error;
-      }
-      logger.debug(error);
-      logger.warn(
-        'Running the PostHog query failed with a network error; will retry on the next poll.'
-      );
-      throw new PosthogRetryableError();
-    }
-    if (response.status === 403) {
-      throw new UserError(
-        'EAS_POSTHOG_FORBIDDEN',
-        'Running the PostHog query was forbidden (403). The personal API key likely lacks the "query:read" scope.'
-      );
-    }
-    if (response.status >= 500 || response.status === 429) {
-      logger.warn(
-        `Running the PostHog query failed with status ${response.status}; will retry on the next poll.`
-      );
-      throw new PosthogRetryableError();
-    }
-    if (!response.ok) {
-      throw new UserError(
-        'EAS_POSTHOG_REQUEST_FAILED',
-        `Running the PostHog query failed with ${await PosthogUtils.readErrorAsync(response)}.`
-      );
-    }
-    let body: unknown;
-    try {
-      body = await response.json();
-    } catch (error) {
-      logger.debug(error);
-      logger.warn('The PostHog query response was not valid JSON; will retry on the next poll.');
-      throw new PosthogRetryableError();
-    }
-    const parsed = QueryResponseSchema.safeParse(body);
-    return parsed.success ? parsed.data.results[0]?.[0] : undefined;
-  }
-
-  cliConfig(): { host: string; env: Record<string, string> } {
-    return {
-      host: this.host,
-      env: { POSTHOG_CLI_API_KEY: this.apiKey, POSTHOG_CLI_PROJECT_ID: this.projectId },
-    };
-  }
-
-  private apiUrl(path: string): string {
-    return `${this.host}/api/projects/${encodeURIComponent(this.projectId)}${path}`;
-  }
-
-  private authHeaders(): Record<string, string> {
-    return { Authorization: `Bearer ${this.apiKey}`, 'Content-Type': 'application/json' };
-  }
-}

packages/build-tools/src/steps/utils/PosthogUtils.ts

@@ -1,103 +0,0 @@
-import { setTimeout as setTimeoutAsync } from 'node:timers/promises';
-
-import { UserError } from '@expo/eas-build-job';
-import { bunyan } from '@expo/logger';
-import { Response } from 'node-fetch';
-
-export namespace PosthogUtils {
-  export interface Credential {
-    label: string;
-    envVar: string;
-    input: string;
-  }
-
-  export const API_CREDENTIALS = {
-    apiKey: { label: 'personal API key', envVar: 'POSTHOG_CLI_API_KEY', input: 'api_key' },
-    projectId: { label: 'project id', envVar: 'POSTHOG_CLI_PROJECT_ID', input: 'project_id' },
-  } satisfies Record<string, Credential>;
-
-  export function missingCredentialsError(missing: Credential[]): UserError {
-    const labels = missing.map(credential => credential.label).join(', ');
-    const envVars = missing.map(credential => credential.envVar).join(', ');
-    const inputs = missing.map(credential => credential.input).join(', ');
-    return new UserError(
-      'EAS_POSTHOG_MISSING_CREDENTIALS',
-      `Missing PostHog credentials: ${labels}. Set the environment variables (${envVars}) or step inputs (${inputs}) on EAS, or re-run "eas integrations:posthog:connect" with error tracking enabled.`
-    );
-  }
-
-  export const DEFAULT_POLL_TIMEOUT_SECONDS = 600;
-  export const DEFAULT_POLL_INTERVAL_SECONDS = 30;
-
-  export function assertPollBoundsPositive({
-    timeoutSeconds,
-    intervalSeconds,
-    errorCode,
-  }: {
-    timeoutSeconds: number;
-    intervalSeconds: number;
-    errorCode: string;
-  }): void {
-    if (timeoutSeconds <= 0 || intervalSeconds <= 0) {
-      throw new UserError(
-        errorCode,
-        '"timeout_seconds" and "interval_seconds" must be greater than 0.'
-      );
-    }
-  }
-
-  export async function waitForNextPollAsync({
-    intervalSeconds,
-    deadline,
-    signal,
-  }: {
-    intervalSeconds: number;
-    deadline: number;
-    signal: AbortSignal | undefined;
-  }): Promise<boolean> {
-    const remainingMs = deadline - Date.now();
-    if (remainingMs <= 0) {
-      return false;
-    }
-    await setTimeoutAsync(Math.min(intervalSeconds * 1000, remainingMs), undefined, { signal });
-    return true;
-  }
-
-  export function failOrLogError({
-    logger,
-    ignoreError,
-    error,
-  }: {
-    logger: bunyan;
-    ignoreError: boolean;
-    error: unknown;
-  }): void {
-    if (
-      !ignoreError ||
-      (error instanceof UserError && error.errorCode === 'EAS_POSTHOG_FORBIDDEN')
-    ) {
-      throw error;
-    }
-    const message = error instanceof Error ? error.message : String(error);
-    logger.warn({ err: error }, `${message} Ignoring error.`);
-  }
-
-  export async function readErrorAsync(response: Response): Promise<string> {
-    const text = await response.text().catch(() => '');
-    if (text) {
-      try {
-        const body = JSON.parse(text) as unknown;
-        if (typeof body === 'object' && body !== null) {
-          const { detail } = body as Record<string, unknown>;
-          if (typeof detail === 'string' && detail !== '') {
-            return `status ${response.status}: ${detail} (${text})`;
-          }
-        }
-      } catch {
-        return `status ${response.status}: ${text}`;
-      }
-      return `status ${response.status}: ${text}`;
-    }
-    return `status ${response.status}`;
-  }
-}

packages/build-tools/src/steps/utils/__tests__/PosthogClient.test.ts

@@ -1,369 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { createLogger } from '@expo/logger';
-import fetch, { Response } from 'node-fetch';
-
-import { PosthogClient, PosthogRetryableError } from '../PosthogClient';
-
-jest.mock('@expo/logger');
-jest.mock('node-fetch');
-
-const fetchMock = jest.mocked(fetch);
-const logger = createLogger({ name: 'test' });
-
-function res({
-  ok = true,
-  status = 200,
-  json,
-  text,
-}: {
-  ok?: boolean;
-  status?: number;
-  json?: unknown;
-  text?: string;
-}): Response {
-  return {
-    ok,
-    status,
-    json: async () => json,
-    text: async () => text ?? (json !== undefined ? JSON.stringify(json) : ''),
-  } as unknown as Response;
-}
-
-const API_ENV = {
-  POSTHOG_CLI_API_KEY: 'phx_test',
-  POSTHOG_CLI_PROJECT_ID: '123',
-  POSTHOG_CLI_HOST: 'https://us.posthog.com',
-};
-
-afterEach(() => jest.resetAllMocks());
-
-describe('PosthogClient.fromEnv', () => {
-  it('builds a client from env vars', () => {
-    expect(
-      PosthogClient.fromEnv({
-        apiKeyOverride: undefined,
-        projectIdOverride: undefined,
-        env: API_ENV,
-      }).client
-    ).toBeInstanceOf(PosthogClient);
-  });
-
-  it('prefers overrides over env', async () => {
-    fetchMock.mockResolvedValue(res({ json: { results: [[1]] } }));
-    const { client } = PosthogClient.fromEnv({
-      apiKeyOverride: 'phx_override',
-      projectIdOverride: '999',
-      env: {},
-    });
-    await client?.runQueryAsync('select 1', logger, undefined);
-    const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('https://us.posthog.com/api/projects/999/query/');
-    expect((init?.headers as Record<string, string>).Authorization).toBe('Bearer phx_override');
-  });
-
-  it('exposes host and CLI env for subprocess uploads', () => {
-    const { client } = PosthogClient.fromEnv({
-      apiKeyOverride: 'phx_k',
-      projectIdOverride: '55',
-      env: { POSTHOG_CLI_HOST: 'https://eu.posthog.com' },
-    });
-    expect(client?.cliConfig()).toEqual({
-      host: 'https://eu.posthog.com',
-      env: { POSTHOG_CLI_API_KEY: 'phx_k', POSTHOG_CLI_PROJECT_ID: '55' },
-    });
-  });
-
-  it('reports both missing credentials when neither is provided', () => {
-    const result = PosthogClient.fromEnv({
-      apiKeyOverride: undefined,
-      projectIdOverride: undefined,
-      env: {},
-    });
-    expect(result.client).toBeUndefined();
-    expect(result).toMatchObject({
-      missing: [{ label: 'personal API key' }, { label: 'project id' }],
-    });
-  });
-
-  it('reports only the missing project id when the key is present', () => {
-    const result = PosthogClient.fromEnv({
-      apiKeyOverride: 'phx',
-      projectIdOverride: undefined,
-      env: {},
-    });
-    expect(result.client).toBeUndefined();
-    expect(result).toMatchObject({ missing: [{ label: 'project id' }] });
-  });
-
-  it('reports only the missing api key when the project id is present', () => {
-    const result = PosthogClient.fromEnv({
-      apiKeyOverride: undefined,
-      projectIdOverride: '1',
-      env: {},
-    });
-    expect(result.client).toBeUndefined();
-    expect(result).toMatchObject({ missing: [{ label: 'personal API key' }] });
-  });
-
-  it('falls back to the default host', async () => {
-    fetchMock.mockResolvedValue(res({ json: { results: [[1]] } }));
-    const { client } = PosthogClient.fromEnv({
-      apiKeyOverride: 'phx',
-      projectIdOverride: '1',
-      env: {},
-    });
-    await client?.runQueryAsync('select 1', logger, undefined);
-    expect(fetchMock.mock.calls[0][0]).toBe('https://us.posthog.com/api/projects/1/query/');
-  });
-});
-
-describe('PosthogClient.forIngestion', () => {
-  it('builds a client and normalizes a trailing-slash host', async () => {
-    fetchMock.mockResolvedValue(res({ ok: true, status: 200 }));
-    const client = PosthogClient.forIngestion({
-      apiKeyOverride: 'phc_x',
-      hostOverride: 'https://eu.posthog.com//',
-      env: {},
-    });
-    await client?.captureEventAsync({
-      event: 'e',
-      distinctId: 'u',
-      properties: undefined,
-      signal: undefined,
-    });
-    expect(fetchMock.mock.calls[0][0]).toBe('https://eu.posthog.com/i/v0/e/');
-  });
-
-  it('falls back to a non-public POSTHOG_API_KEY', () => {
-    expect(
-      PosthogClient.forIngestion({
-        apiKeyOverride: undefined,
-        hostOverride: undefined,
-        env: { POSTHOG_API_KEY: 'phc_secret' },
-      })
-    ).toBeInstanceOf(PosthogClient);
-  });
-
-  it('returns undefined when no key is available', () => {
-    expect(
-      PosthogClient.forIngestion({ apiKeyOverride: undefined, hostOverride: undefined, env: {} })
-    ).toBeUndefined();
-  });
-});
-
-describe('captureEventAsync', () => {
-  const client = PosthogClient.forIngestion({
-    apiKeyOverride: 'phc_x',
-    hostOverride: undefined,
-    env: {},
-  });
-
-  it('sends an anonymous system event when no distinct_id is given', async () => {
-    fetchMock.mockResolvedValue(res({ ok: true, status: 200 }));
-    await client?.captureEventAsync({
-      event: 'e',
-      distinctId: undefined,
-      properties: { a: 1 },
-      signal: undefined,
-    });
-    const body = JSON.parse(fetchMock.mock.calls[0][1]?.body as string);
-    expect(body.distinct_id).toBe('eas-workflow');
-    expect(body.properties).toEqual({ a: 1, $process_person_profile: false });
-  });
-
-  it('throws a UserError on a non-2xx response', async () => {
-    fetchMock.mockResolvedValue(res({ ok: false, status: 400, text: 'bad' }));
-    await expect(
-      client?.captureEventAsync({
-        event: 'e',
-        distinctId: 'u',
-        properties: undefined,
-        signal: undefined,
-      })
-    ).rejects.toThrow(/failed with status 400: bad/);
-  });
-
-  it('throws a UserError on a network error', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    await expect(
-      client?.captureEventAsync({
-        event: 'e',
-        distinctId: 'u',
-        properties: undefined,
-        signal: undefined,
-      })
-    ).rejects.toThrow(/Sending PostHog event "e" failed\.$/);
-  });
-
-  it('passes the signal and propagates without wrapping when aborted', async () => {
-    const controller = new AbortController();
-    controller.abort();
-    fetchMock.mockRejectedValue(new Error('The operation was aborted'));
-    await expect(
-      client?.captureEventAsync({
-        event: 'e',
-        distinctId: 'u',
-        properties: undefined,
-        signal: controller.signal,
-      })
-    ).rejects.toThrow('The operation was aborted');
-    expect(fetchMock.mock.calls[0][1]?.signal).toBe(controller.signal);
-  });
-});
-
-describe('requestAsync', () => {
-  const { client } = PosthogClient.fromEnv({
-    apiKeyOverride: undefined,
-    projectIdOverride: undefined,
-    env: API_ENV,
-  });
-
-  it('sends an authenticated request and returns the response', async () => {
-    fetchMock.mockResolvedValue(res({ ok: true, status: 200, json: { id: 1 } }));
-    const response = await client?.requestAsync('PATCH', '/feature_flags/1/', {
-      action: 'Updating flag',
-      forbiddenScope: 'feature_flag:write',
-      body: { active: true },
-      signal: undefined,
-    });
-    expect(response?.ok).toBe(true);
-    const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('https://us.posthog.com/api/projects/123/feature_flags/1/');
-    expect(init?.method).toBe('PATCH');
-    expect(JSON.parse(init?.body as string)).toEqual({ active: true });
-  });
-
-  it('throws a forbidden UserError with the named scope on 403', async () => {
-    fetchMock.mockResolvedValue(res({ ok: false, status: 403 }));
-    await expect(
-      client?.requestAsync('GET', '/feature_flags/', {
-        action: 'Looking up flag',
-        forbiddenScope: 'feature_flag:read',
-        signal: undefined,
-      })
-    ).rejects.toMatchObject({
-      errorCode: 'EAS_POSTHOG_FORBIDDEN',
-      message: expect.stringContaining('"feature_flag:read"'),
-    });
-  });
-
-  it('throws with the error detail on a non-2xx response', async () => {
-    fetchMock.mockResolvedValue(res({ ok: false, status: 400, json: { detail: 'nope' } }));
-    await expect(
-      client?.requestAsync('GET', '/feature_flags/', {
-        action: 'Looking up flag',
-        forbiddenScope: 'feature_flag:read',
-        signal: undefined,
-      })
-    ).rejects.toThrow(/Looking up flag failed with status 400: nope/);
-  });
-
-  it('throws on a network error', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    await expect(
-      client?.requestAsync('GET', '/feature_flags/', {
-        action: 'Looking up flag',
-        forbiddenScope: 'feature_flag:read',
-        signal: undefined,
-      })
-    ).rejects.toThrow(/Looking up flag failed\.$/);
-  });
-
-  it('passes the signal and propagates without wrapping when aborted', async () => {
-    const controller = new AbortController();
-    controller.abort();
-    fetchMock.mockRejectedValue(new Error('The operation was aborted'));
-    await expect(
-      client?.requestAsync('GET', '/feature_flags/', {
-        action: 'Looking up flag',
-        forbiddenScope: 'feature_flag:read',
-        signal: controller.signal,
-      })
-    ).rejects.toThrow('The operation was aborted');
-    expect(fetchMock.mock.calls[0][1]?.signal).toBe(controller.signal);
-  });
-});
-
-describe('runQueryAsync', () => {
-  const { client } = PosthogClient.fromEnv({
-    apiKeyOverride: undefined,
-    projectIdOverride: undefined,
-    env: API_ENV,
-  });
-
-  it('returns the top-left cell', async () => {
-    fetchMock.mockResolvedValue(res({ json: { results: [[42]] } }));
-    await expect(client?.runQueryAsync('select 1', logger, undefined)).resolves.toBe(42);
-  });
-
-  it('throws a retryable error on a network error', async () => {
-    fetchMock.mockRejectedValue(new Error('ECONNRESET'));
-    await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toBeInstanceOf(
-      PosthogRetryableError
-    );
-  });
-
-  it('passes the signal to fetch and propagates without retrying when aborted', async () => {
-    const controller = new AbortController();
-    controller.abort();
-    fetchMock.mockRejectedValue(new Error('The operation was aborted'));
-    await expect(client?.runQueryAsync('q', logger, controller.signal)).rejects.toThrow(
-      'The operation was aborted'
-    );
-    expect(fetchMock.mock.calls[0][1]?.signal).toBe(controller.signal);
-  });
-
-  it('throws a retryable error on 5xx and 429', async () => {
-    fetchMock.mockResolvedValueOnce(res({ ok: false, status: 500 }));
-    await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toBeInstanceOf(
-      PosthogRetryableError
-    );
-    fetchMock.mockResolvedValueOnce(res({ ok: false, status: 429 }));
-    await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toBeInstanceOf(
-      PosthogRetryableError
-    );
-  });
-
-  it('throws a retryable error on an invalid JSON body', async () => {
-    fetchMock.mockResolvedValue({
-      ok: true,
-      status: 200,
-      json: async () => {
-        throw new Error('bad json');
-      },
-    } as unknown as Response);
-    await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toBeInstanceOf(
-      PosthogRetryableError
-    );
-  });
-
-  it('returns undefined for a malformed result shape', async () => {
-    fetchMock.mockResolvedValue(res({ json: { results: 'nope' } }));
-    await expect(client?.runQueryAsync('q', logger, undefined)).resolves.toBeUndefined();
-  });
-
-  it('throws a forbidden UserError on 403', async () => {
-    fetchMock.mockResolvedValue(res({ ok: false, status: 403 }));
-    await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toMatchObject({
-      errorCode: 'EAS_POSTHOG_FORBIDDEN',
-      message: expect.stringContaining('"query:read"'),
-    });
-  });
-
-  it('throws with the error detail on a non-2xx response', async () => {
-    fetchMock.mockResolvedValue(res({ ok: false, status: 400, text: 'Malformed HogQL' }));
-    await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toThrow(
-      /failed with status 400: Malformed HogQL/
-    );
-  });
-});
-
-it('is a UserError subclass so the step surfaces it to the user', async () => {
-  const { client } = PosthogClient.fromEnv({
-    apiKeyOverride: undefined,
-    projectIdOverride: undefined,
-    env: API_ENV,
-  });
-  fetchMock.mockResolvedValue(res({ ok: false, status: 403 }));
-  await expect(client?.runQueryAsync('q', logger, undefined)).rejects.toBeInstanceOf(UserError);
-});

packages/build-tools/src/steps/utils/__tests__/PosthogUtils.test.ts

@@ -1,173 +0,0 @@
-import { UserError } from '@expo/eas-build-job';
-import { bunyan, createLogger } from '@expo/logger';
-import { Response } from 'node-fetch';
-
-import { PosthogUtils } from '../PosthogUtils';
-
-jest.mock('@expo/logger');
-
-const logger = createLogger({ name: 'test' }) as bunyan;
-
-function errorResponse({ status, text }: { status: number; text?: string }): Response {
-  return { status, text: async () => text ?? '' } as unknown as Response;
-}
-
-describe(PosthogUtils.readErrorAsync, () => {
-  it('surfaces a JSON detail followed by the raw body', async () => {
-    await expect(
-      PosthogUtils.readErrorAsync(errorResponse({ status: 400, text: '{"detail":"boom"}' }))
-    ).resolves.toBe('status 400: boom ({"detail":"boom"})');
-  });
-
-  it('falls back to the raw body for detail-less JSON', async () => {
-    await expect(
-      PosthogUtils.readErrorAsync(errorResponse({ status: 400, text: '{"other":1}' }))
-    ).resolves.toBe('status 400: {"other":1}');
-  });
-
-  it('ignores an empty-string detail', async () => {
-    await expect(
-      PosthogUtils.readErrorAsync(errorResponse({ status: 400, text: '{"detail":""}' }))
-    ).resolves.toBe('status 400: {"detail":""}');
-  });
-
-  it('falls back to the raw text for a non-JSON body', async () => {
-    await expect(
-      PosthogUtils.readErrorAsync(errorResponse({ status: 502, text: 'Bad Gateway' }))
-    ).resolves.toBe('status 502: Bad Gateway');
-  });
-
-  it('uses just the status when the body is empty', async () => {
-    await expect(
-      PosthogUtils.readErrorAsync(errorResponse({ status: 500, text: '' }))
-    ).resolves.toBe('status 500');
-  });
-
-  it('uses just the status when reading the body throws', async () => {
-    const response = {
-      status: 500,
-      text: async () => {
-        throw new Error('read fail');
-      },
-    } as unknown as Response;
-    await expect(PosthogUtils.readErrorAsync(response)).resolves.toBe('status 500');
-  });
-});
-
-describe(PosthogUtils.missingCredentialsError, () => {
-  it('names both missing credentials with their env vars and inputs', () => {
-    expect(
-      PosthogUtils.missingCredentialsError([
-        PosthogUtils.API_CREDENTIALS.apiKey,
-        PosthogUtils.API_CREDENTIALS.projectId,
-      ])
-    ).toMatchObject({
-      errorCode: 'EAS_POSTHOG_MISSING_CREDENTIALS',
-      message:
-        'Missing PostHog credentials: personal API key, project id. Set the environment variables (POSTHOG_CLI_API_KEY, POSTHOG_CLI_PROJECT_ID) or step inputs (api_key, project_id) on EAS, or re-run "eas integrations:posthog:connect" with error tracking enabled.',
-    });
-  });
-
-  it('names only the missing credential', () => {
-    expect(
-      PosthogUtils.missingCredentialsError([PosthogUtils.API_CREDENTIALS.projectId]).message
-    ).toBe(
-      'Missing PostHog credentials: project id. Set the environment variables (POSTHOG_CLI_PROJECT_ID) or step inputs (project_id) on EAS, or re-run "eas integrations:posthog:connect" with error tracking enabled.'
-    );
-  });
-});
-
-describe(PosthogUtils.assertPollBoundsPositive, () => {
-  it('throws with the given error code when a bound is not positive', () => {
-    expect(() =>
-      PosthogUtils.assertPollBoundsPositive({
-        timeoutSeconds: 0,
-        intervalSeconds: 30,
-        errorCode: 'EAS_POSTHOG_TEST_INTERVAL',
-      })
-    ).toThrow(/greater than 0/);
-    expect(() =>
-      PosthogUtils.assertPollBoundsPositive({
-        timeoutSeconds: 600,
-        intervalSeconds: -1,
-        errorCode: 'EAS_POSTHOG_TEST_INTERVAL',
-      })
-    ).toThrow(/greater than 0/);
-  });
-
-  it('does nothing when both bounds are positive', () => {
-    expect(() =>
-      PosthogUtils.assertPollBoundsPositive({
-        timeoutSeconds: 600,
-        intervalSeconds: 30,
-        errorCode: 'EAS_POSTHOG_TEST_INTERVAL',
-      })
-    ).not.toThrow();
-  });
-});
-
-describe(PosthogUtils.waitForNextPollAsync, () => {
-  it('returns false without sleeping when the deadline has passed', async () => {
-    await expect(
-      PosthogUtils.waitForNextPollAsync({
-        intervalSeconds: 30,
-        deadline: Date.now() - 1,
-        signal: undefined,
-      })
-    ).resolves.toBe(false);
-  });
-
-  it('sleeps for the clamped interval and returns true when time remains', async () => {
-    await expect(
-      PosthogUtils.waitForNextPollAsync({
-        intervalSeconds: 0.01,
-        deadline: Date.now() + 1000,
-        signal: undefined,
-      })
-    ).resolves.toBe(true);
-  });
-
-  it('rejects when the signal aborts during the sleep', async () => {
-    const controller = new AbortController();
-    const promise = PosthogUtils.waitForNextPollAsync({
-      intervalSeconds: 30,
-      deadline: Date.now() + 60_000,
-      signal: controller.signal,
-    });
-    controller.abort();
-    await expect(promise).rejects.toThrow();
-  });
-});
-
-describe(PosthogUtils.failOrLogError, () => {
-  it('throws the error when ignoreError is false', () => {
-    const error = new Error('boom');
-    expect(() => PosthogUtils.failOrLogError({ logger, ignoreError: false, error })).toThrow(
-      'boom'
-    );
-  });
-
-  it('warns and swallows the error when ignoreError is true', () => {
-    const warnMock = jest.spyOn(logger, 'warn');
-    const error = new Error('boom');
-
-    PosthogUtils.failOrLogError({ logger, ignoreError: true, error });
-
-    expect(warnMock).toHaveBeenCalledWith({ err: error }, 'boom Ignoring error.');
-  });
-
-  it('rethrows a forbidden error even when ignoreError is true', () => {
-    const error = new UserError('EAS_POSTHOG_FORBIDDEN', 'no scope');
-    expect(() => PosthogUtils.failOrLogError({ logger, ignoreError: true, error })).toThrow(
-      'no scope'
-    );
-  });
-
-  it('stringifies a non-Error value when swallowing', () => {
-    const warnMock = jest.spyOn(logger, 'warn');
-
-    PosthogUtils.failOrLogError({ logger, ignoreError: true, error: 'plain string' });
-
-    expect(warnMock).toHaveBeenCalledWith({ err: 'plain string' }, 'plain string Ignoring error.');
-  });
-});

packages/build-tools/src/steps/utils/__tests__/agentDeviceArtifacts.test.ts

@@ -1,255 +0,0 @@
-import { bunyan } from '@expo/logger';
-import fetch from 'node-fetch';
-import { Readable } from 'node:stream';
-
-import { CustomBuildContext } from '../../../customBuildContext';
-import { uploadDeviceRunSessionArtifactAsync } from '../deviceRunSessionArtifacts';
-import {
-  listAgentDeviceArtifactsAsync,
-  pollAgentDeviceArtifactsForUploadAsync,
-  uploadAgentDeviceArtifactAsync,
-} from '../agentDeviceArtifacts';
-
-jest.mock('../deviceRunSessionArtifacts');
-jest.mock('node-fetch');
-
-const { Response } = jest.requireActual('node-fetch') as typeof import('node-fetch');
-
-async function readStreamAsync(stream: NodeJS.ReadableStream): Promise<void> {
-  for await (const chunk of stream as Readable) {
-    void chunk;
-  }
-}
-
-async function flushPromisesAsync(): Promise<void> {
-  for (let i = 0; i < 10; i++) {
-    await jest.advanceTimersByTimeAsync(0);
-    await Promise.resolve();
-  }
-}
-
-function createLoggerMock(): bunyan {
-  return {
-    info: jest.fn(),
-    warn: jest.fn(),
-    error: jest.fn(),
-    debug: jest.fn(),
-  } as unknown as bunyan;
-}
-
-describe(listAgentDeviceArtifactsAsync, () => {
-  beforeEach(() => {
-    jest.mocked(fetch).mockReset();
-  });
-
-  it('lists agent-device artifacts with bearer auth', async () => {
-    jest.mocked(fetch).mockResolvedValue(
-      new Response(
-        JSON.stringify({
-          artifacts: [
-            {
-              id: 'artifact-id',
-              artifactType: 'agent-device-test-report',
-              filename: 'report.json',
-              mimeType: 'application/json',
-              sizeBytes: 123,
-              createdAt: '2026-07-02T12:00:00.000Z',
-              expiresAt: '2026-07-02T12:15:00.000Z',
-            },
-            {
-              id: 'untyped-artifact-id',
-              artifactType: null,
-              filename: 'untyped-report.json',
-              mimeType: 'application/json',
-              sizeBytes: 456,
-              createdAt: '2026-07-02T12:00:00.000Z',
-              expiresAt: '2026-07-02T12:15:00.000Z',
-            },
-          ],
-        })
-      )
-    );
-
-    const artifacts = await listAgentDeviceArtifactsAsync({
-      daemonUrl: 'http://127.0.0.1:1234',
-      daemonToken: 'daemon-token',
-    });
-
-    expect(artifacts).toEqual([
-      {
-        id: 'artifact-id',
-        artifactType: 'agent-device-test-report',
-        filename: 'report.json',
-      },
-      {
-        id: 'untyped-artifact-id',
-        artifactType: null,
-        filename: 'untyped-report.json',
-      },
-    ]);
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith('http://127.0.0.1:1234/artifacts', {
-      headers: { Authorization: 'Bearer daemon-token' },
-    });
-  });
-
-  it('reports artifact inventory as unsupported when the daemon does not expose the endpoint', async () => {
-    jest.mocked(fetch).mockResolvedValue(new Response('Not found', { status: 404 }));
-
-    await expect(
-      listAgentDeviceArtifactsAsync({
-        daemonUrl: 'http://127.0.0.1:1234',
-        daemonToken: 'daemon-token',
-      })
-    ).rejects.toThrow('agent-device daemon does not expose artifact inventory.');
-  });
-});
-
-describe(uploadAgentDeviceArtifactAsync, () => {
-  beforeEach(() => {
-    jest.mocked(fetch).mockReset();
-    jest.mocked(uploadDeviceRunSessionArtifactAsync).mockReset();
-  });
-
-  it('downloads an agent-device artifact and uploads it as a device run session artifact', async () => {
-    const data = Buffer.from('artifact-data');
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-
-    jest.mocked(fetch).mockResolvedValueOnce(new Response(Readable.from([data])));
-    jest
-      .mocked(uploadDeviceRunSessionArtifactAsync)
-      .mockImplementationOnce(async (_ctx, { stream }) => {
-        await readStreamAsync(stream);
-      });
-
-    await uploadAgentDeviceArtifactAsync(ctx, {
-      deviceRunSessionId: 'drs-id',
-      daemonUrl: 'http://127.0.0.1:1234',
-      daemonToken: 'daemon-token',
-      logger,
-      artifact: {
-        id: 'artifact-id',
-        artifactType: 'agent-device-test-report',
-        filename: 'report.json',
-      },
-    });
-
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith('http://127.0.0.1:1234/artifacts/artifact-id', {
-      headers: { Authorization: 'Bearer daemon-token' },
-    });
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledWith(ctx, {
-      deviceRunSessionId: 'drs-id',
-      artifactId: 'artifact-id',
-      name: 'report.json (artifact-id)',
-      filename: 'report.json',
-      kind: 'agent-device-test-report',
-      size: data.length,
-      stream: expect.anything(),
-    });
-  });
-
-  it('uploads null artifact types as an explicit undefined kind', async () => {
-    const data = Buffer.from('artifact-data');
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-
-    jest.mocked(fetch).mockResolvedValueOnce(new Response(Readable.from([data])));
-    jest
-      .mocked(uploadDeviceRunSessionArtifactAsync)
-      .mockImplementationOnce(async (_ctx, { stream }) => {
-        await readStreamAsync(stream);
-      });
-
-    await uploadAgentDeviceArtifactAsync(ctx, {
-      deviceRunSessionId: 'drs-id',
-      daemonUrl: 'http://127.0.0.1:1234',
-      daemonToken: 'daemon-token',
-      logger,
-      artifact: {
-        id: 'artifact-id',
-        artifactType: null,
-        filename: 'report.json',
-      },
-    });
-
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledWith(
-      ctx,
-      expect.objectContaining({
-        kind: undefined,
-      })
-    );
-  });
-});
-
-describe(pollAgentDeviceArtifactsForUploadAsync, () => {
-  beforeEach(() => {
-    jest.useFakeTimers();
-    jest.mocked(fetch).mockReset();
-    jest.mocked(uploadDeviceRunSessionArtifactAsync).mockReset();
-  });
-
-  afterEach(() => {
-    jest.clearAllTimers();
-    jest.useRealTimers();
-  });
-
-  it('retries an artifact after a failed upload', async () => {
-    const data = Buffer.from('artifact-data');
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-    const artifact = {
-      id: 'artifact-id',
-      filename: 'report.json',
-    };
-    const listResponse = () => new Response(JSON.stringify({ artifacts: [artifact] }));
-
-    jest
-      .mocked(fetch)
-      .mockResolvedValueOnce(listResponse())
-      .mockResolvedValueOnce(new Response(Readable.from([data])))
-      .mockResolvedValueOnce(listResponse())
-      .mockResolvedValueOnce(new Response(Readable.from([data])));
-    jest
-      .mocked(uploadDeviceRunSessionArtifactAsync)
-      .mockRejectedValueOnce(new Error('upload failed'))
-      .mockImplementationOnce(async (_ctx, { stream }) => {
-        await readStreamAsync(stream);
-      });
-
-    void pollAgentDeviceArtifactsForUploadAsync(ctx, {
-      deviceRunSessionId: 'drs-id',
-      daemonUrl: 'http://127.0.0.1:1234',
-      daemonToken: 'daemon-token',
-      logger,
-    });
-
-    await flushPromisesAsync();
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledTimes(1);
-
-    await jest.advanceTimersByTimeAsync(5_000);
-    await flushPromisesAsync();
-
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledTimes(2);
-  });
-
-  it('stops polling when the daemon does not expose artifact inventory', async () => {
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-
-    jest.mocked(fetch).mockResolvedValueOnce(new Response('Not found', { status: 404 }));
-
-    await expect(
-      pollAgentDeviceArtifactsForUploadAsync(ctx, {
-        deviceRunSessionId: 'drs-id',
-        daemonUrl: 'http://127.0.0.1:1234',
-        daemonToken: 'daemon-token',
-        logger,
-      })
-    ).resolves.toBeUndefined();
-
-    expect(jest.mocked(fetch)).toHaveBeenCalledTimes(1);
-    expect(logger.warn).toHaveBeenCalledWith(
-      'agent-device daemon does not expose artifact inventory; remote session artifact uploads are disabled.'
-    );
-  });
-});

packages/build-tools/src/steps/utils/__tests__/argentArtifacts.test.ts

@@ -1,280 +0,0 @@
-import { bunyan } from '@expo/logger';
-import fetch from 'node-fetch';
-import { Readable } from 'node:stream';
-
-import { CustomBuildContext } from '../../../customBuildContext';
-import { uploadDeviceRunSessionArtifactAsync } from '../deviceRunSessionArtifacts';
-import {
-  listArgentArtifactsAsync,
-  pollArgentArtifactsForUploadAsync,
-  uploadArgentArtifactAsync,
-} from '../argentArtifacts';
-
-jest.mock('../deviceRunSessionArtifacts');
-jest.mock('../../../sentry');
-jest.mock('node-fetch');
-
-const { Response } = jest.requireActual('node-fetch') as typeof import('node-fetch');
-
-async function readStreamAsync(stream: NodeJS.ReadableStream): Promise<void> {
-  for await (const chunk of stream as Readable) {
-    void chunk;
-  }
-}
-
-async function waitForAssertionAsync(assertion: () => void): Promise<void> {
-  const deadline = Date.now() + 1_000;
-  let lastError: unknown;
-  while (Date.now() < deadline) {
-    try {
-      assertion();
-      return;
-    } catch (err) {
-      lastError = err;
-      await new Promise(resolve => setTimeout(resolve, 10));
-    }
-  }
-  throw lastError;
-}
-
-function createLoggerMock(): bunyan {
-  return {
-    info: jest.fn(),
-    warn: jest.fn(),
-    error: jest.fn(),
-    debug: jest.fn(),
-  } as unknown as bunyan;
-}
-
-describe(listArgentArtifactsAsync, () => {
-  beforeEach(() => {
-    jest.mocked(fetch).mockReset();
-  });
-
-  it('lists Argent artifacts with bearer auth', async () => {
-    jest.mocked(fetch).mockResolvedValue(
-      new Response(
-        JSON.stringify({
-          artifacts: [
-            {
-              id: 'artifact-id',
-              filename: 'report.json',
-              mimeType: 'application/json',
-              isDirectory: false,
-            },
-          ],
-        })
-      )
-    );
-
-    const artifacts = await listArgentArtifactsAsync({
-      toolsUrl: 'http://127.0.0.1:1234',
-      toolsAuthToken: 'tools-token',
-    });
-
-    expect(artifacts).toEqual([
-      {
-        id: 'artifact-id',
-        filename: 'report.json',
-        mimeType: 'application/json',
-        isDirectory: false,
-      },
-    ]);
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith('http://127.0.0.1:1234/artifacts', {
-      headers: { Authorization: 'Bearer tools-token' },
-      signal: expect.any(AbortSignal),
-    });
-  });
-});
-
-describe(uploadArgentArtifactAsync, () => {
-  beforeEach(() => {
-    jest.mocked(fetch).mockReset();
-    jest.mocked(uploadDeviceRunSessionArtifactAsync).mockReset();
-  });
-
-  it('downloads an Argent artifact and uploads it as a device run session artifact', async () => {
-    const data = Buffer.from('artifact-data');
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-
-    jest.mocked(fetch).mockResolvedValueOnce(new Response(Readable.from([data])));
-    jest
-      .mocked(uploadDeviceRunSessionArtifactAsync)
-      .mockImplementationOnce(async (_ctx, { stream }) => {
-        await readStreamAsync(stream);
-      });
-
-    await uploadArgentArtifactAsync(ctx, {
-      deviceRunSessionId: 'drs-id',
-      toolsUrl: 'http://127.0.0.1:1234',
-      toolsAuthToken: 'tools-token',
-      logger,
-      artifact: {
-        id: 'artifact-id',
-        filename: 'report.json',
-        mimeType: 'application/json',
-      },
-    });
-
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith('http://127.0.0.1:1234/artifacts/artifact-id', {
-      headers: { Authorization: 'Bearer tools-token' },
-      signal: expect.any(AbortSignal),
-    });
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledWith(ctx, {
-      deviceRunSessionId: 'drs-id',
-      artifactId: 'artifact-id',
-      name: 'report.json (artifact-id)',
-      filename: 'report.json',
-      size: data.length,
-      stream: expect.anything(),
-    });
-  });
-});
-
-describe(pollArgentArtifactsForUploadAsync, () => {
-  beforeEach(() => {
-    jest.mocked(fetch).mockReset();
-    jest.mocked(uploadDeviceRunSessionArtifactAsync).mockReset();
-  });
-
-  it('stops polling when aborted, performs a final drain, and waits for uploads', async () => {
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-    const abortController = new AbortController();
-    let listCallCount = 0;
-
-    jest.mocked(fetch).mockImplementation(async url => {
-      const urlString = String(url);
-      if (urlString.endsWith('/artifacts')) {
-        listCallCount += 1;
-        return new Response(
-          JSON.stringify({
-            artifacts:
-              listCallCount === 1
-                ? [
-                    {
-                      id: 'artifact-a',
-                      filename: 'a.json',
-                      mimeType: 'application/json',
-                    },
-                  ]
-                : [
-                    {
-                      id: 'artifact-a',
-                      filename: 'a.json',
-                      mimeType: 'application/json',
-                    },
-                    {
-                      id: 'artifact-b',
-                      filename: 'b.json',
-                      mimeType: 'application/json',
-                    },
-                  ],
-          })
-        );
-      }
-      if (urlString.endsWith('/artifacts/artifact-a')) {
-        return new Response(Readable.from([Buffer.from('artifact-a-data')]));
-      }
-      if (urlString.endsWith('/artifacts/artifact-b')) {
-        return new Response(Readable.from([Buffer.from('artifact-b-data')]));
-      }
-      throw new Error(`Unexpected URL ${urlString}`);
-    });
-    jest
-      .mocked(uploadDeviceRunSessionArtifactAsync)
-      .mockImplementation(async (_ctx, { stream }) => {
-        await readStreamAsync(stream);
-      });
-
-    const pollingPromise = pollArgentArtifactsForUploadAsync(ctx, {
-      deviceRunSessionId: 'drs-id',
-      toolsUrl: 'http://127.0.0.1:1234',
-      toolsAuthToken: 'tools-token',
-      logger,
-      signal: abortController.signal,
-    });
-
-    await waitForAssertionAsync(() => {
-      expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledTimes(1);
-    });
-    abortController.abort();
-    await pollingPromise;
-
-    expect(listCallCount).toBe(2);
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledTimes(2);
-    expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenLastCalledWith(ctx, {
-      deviceRunSessionId: 'drs-id',
-      artifactId: 'artifact-b',
-      name: 'b.json (artifact-b)',
-      filename: 'b.json',
-      size: 'artifact-b-data'.length,
-      stream: expect.anything(),
-    });
-  });
-
-  it('throws when pending uploads do not finish before the cleanup timeout', async () => {
-    const logger = createLoggerMock();
-    const ctx = {} as unknown as CustomBuildContext;
-    const abortController = new AbortController();
-    const originalSetTimeout = global.setTimeout;
-    const setTimeoutSpy = jest
-      .spyOn(global, 'setTimeout')
-      .mockImplementation(((
-        callback: Parameters<typeof setTimeout>[0],
-        timeout?: number,
-        ...args: unknown[]
-      ) =>
-        originalSetTimeout(
-          callback,
-          timeout === 30_000 ? 0 : timeout,
-          ...args
-        )) as typeof setTimeout);
-
-    try {
-      jest.mocked(fetch).mockImplementation(async url => {
-        const urlString = String(url);
-        if (urlString.endsWith('/artifacts')) {
-          return new Response(
-            JSON.stringify({
-              artifacts: [
-                {
-                  id: 'artifact-a',
-                  filename: 'a.json',
-                  mimeType: 'application/json',
-                },
-              ],
-            })
-          );
-        }
-        if (urlString.endsWith('/artifacts/artifact-a')) {
-          return new Response(Readable.from([Buffer.from('artifact-a-data')]));
-        }
-        throw new Error(`Unexpected URL ${urlString}`);
-      });
-      jest
-        .mocked(uploadDeviceRunSessionArtifactAsync)
-        .mockImplementation(() => new Promise<void>(() => {}));
-
-      const pollingPromise = pollArgentArtifactsForUploadAsync(ctx, {
-        deviceRunSessionId: 'drs-id',
-        toolsUrl: 'http://127.0.0.1:1234',
-        toolsAuthToken: 'tools-token',
-        logger,
-        signal: abortController.signal,
-      });
-
-      await waitForAssertionAsync(() => {
-        expect(jest.mocked(uploadDeviceRunSessionArtifactAsync)).toHaveBeenCalledTimes(1);
-      });
-      abortController.abort();
-
-      await expect(pollingPromise).rejects.toThrow(
-        'Timed out after 30s waiting for Argent artifact uploads.'
-      );
-    } finally {
-      setTimeoutSpy.mockRestore();
-    }
-  });
-});

packages/build-tools/src/steps/utils/__tests__/deviceRunSessionArtifacts.test.ts

@@ -1,76 +0,0 @@
-import fetch from 'node-fetch';
-import { Readable } from 'node:stream';
-
-import { CustomBuildContext } from '../../../customBuildContext';
-import { uploadDeviceRunSessionArtifactAsync } from '../deviceRunSessionArtifacts';
-
-jest.mock('node-fetch');
-
-const { Response } = jest.requireActual('node-fetch') as typeof import('node-fetch');
-
-describe(uploadDeviceRunSessionArtifactAsync, () => {
-  beforeEach(() => {
-    jest.mocked(fetch).mockReset();
-  });
-
-  it('streams an artifact through a signed upload URL', async () => {
-    const stream = Readable.from(Buffer.from('artifact-data'));
-    const reportedSize = 1024;
-    const mutation = jest.fn().mockReturnValue({
-      toPromise: async () => ({
-        data: {
-          deviceRunSession: {
-            createArtifactUploadSession: {
-              uploadSession: {
-                url: 'https://uploads.expo.test/artifact',
-                headers: {
-                  'Content-Length': String(reportedSize),
-                  'Content-Type': 'application/octet-stream',
-                },
-              },
-            },
-          },
-        },
-      }),
-    });
-    const ctx = {
-      graphqlClient: {
-        mutation,
-      },
-    } as unknown as CustomBuildContext;
-
-    jest.mocked(fetch).mockResolvedValueOnce(new Response('', { status: 200 }));
-
-    await uploadDeviceRunSessionArtifactAsync(ctx, {
-      deviceRunSessionId: 'drs-id',
-      artifactId: 'artifact-id',
-      name: 'Artifact report.json (artifact-id)',
-      filename: 'report.json',
-      kind: 'agent-device-test-report',
-      metadata: { firstFrameRecordAt: 'test-time' },
-      size: reportedSize,
-      stream,
-    });
-
-    expect(mutation).toHaveBeenCalledWith(
-      expect.anything(),
-      expect.objectContaining({
-        deviceRunSessionId: 'drs-id',
-        input: {
-          name: 'Artifact report.json (artifact-id)',
-          filename: 'report.json',
-          kind: 'agent-device-test-report',
-          metadata: { firstFrameRecordAt: 'test-time' },
-          size: reportedSize,
-        },
-      })
-    );
-    expect(jest.mocked(fetch)).toHaveBeenCalledWith(
-      'https://uploads.expo.test/artifact',
-      expect.objectContaining({
-        method: 'PUT',
-        body: stream,
-      })
-    );
-  });
-});

packages/build-tools/src/steps/utils/__tests__/remoteDeviceRunSession.test.ts

@@ -1,281 +0,0 @@
-import { bunyan } from '@expo/logger';
-import { BuildStepEnv } from '@expo/steps';
-import { setTimeout as setTimeoutAsync } from 'node:timers/promises';
-
-import { CustomBuildContext } from '../../../customBuildContext';
-import { Sentry } from '../../../sentry';
-import { turtleFetch } from '../../../utils/turtleFetch';
-import {
-  fetchServeSimTurnArgsAsync,
-  turnIceServersToServeSimArgs,
-  waitForDeviceRunSessionStoppedAsync,
-} from '../remoteDeviceRunSession';
-
-jest.mock('node:timers/promises');
-jest.mock('../../../utils/turtleFetch');
-jest.mock('../../../sentry');
-
-function createLoggerMock(): bunyan {
-  return {
-    info: jest.fn(),
-    warn: jest.fn(),
-    error: jest.fn(),
-    debug: jest.fn(),
-  } as unknown as bunyan;
-}
-
-function createCtxMock(): CustomBuildContext {
-  return {
-    env: {
-      __API_SERVER_URL: 'https://api.expo.test',
-    },
-    job: {
-      secrets: { robotAccessToken: 'robot-token' },
-    },
-  } as unknown as CustomBuildContext;
-}
-
-function createStatusCtxMock(
-  results: (
-    | { status: 'NEW' | 'IN_PROGRESS' | 'STOPPED' | 'ERRORED' }
-    | { error: Error }
-    | { data: unknown }
-  )[]
-): CustomBuildContext {
-  const query = jest.fn(() => {
-    const result = results.shift();
-    if (!result) {
-      throw new Error('No mocked status result available');
-    }
-    return {
-      toPromise: async () => {
-        if ('error' in result) {
-          throw result.error;
-        }
-        if ('data' in result) {
-          return { data: result.data };
-        }
-        return {
-          data: {
-            deviceRunSessions: {
-              byId: {
-                id: 'drs-id',
-                status: result.status,
-              },
-            },
-          },
-        };
-      },
-    };
-  });
-
-  return {
-    graphqlClient: {
-      query,
-    },
-  } as unknown as CustomBuildContext;
-}
-
-function createEnvMock(): BuildStepEnv {
-  return { DEVICE_RUN_SESSION_ID: 'drs-id' } as unknown as BuildStepEnv;
-}
-
-describe(turnIceServersToServeSimArgs, () => {
-  it('returns no args for an empty ICE server list', () => {
-    expect(turnIceServersToServeSimArgs([])).toEqual([]);
-  });
-
-  it('builds --stun-url and --turn-url flags from Cloudflare ICE servers', () => {
-    expect(
-      turnIceServersToServeSimArgs([
-        { urls: ['stun:stun.cloudflare.com:3478', 'stun:stun.cloudflare.com:53'] },
-        {
-          urls: [
-            'turn:turn.cloudflare.com:3478?transport=udp',
-            'turns:turn.cloudflare.com:443?transport=tcp',
-          ],
-          username: 'user-123',
-          credential: 'cred-456',
-        },
-      ])
-    ).toEqual([
-      '--stun-url',
-      'stun:stun.cloudflare.com:3478,stun:stun.cloudflare.com:53',
-      '--turn-url',
-      'turn:turn.cloudflare.com:3478?transport=udp,turns:turn.cloudflare.com:443?transport=tcp',
-      '--turn-username',
-      'user-123',
-      '--turn-credential',
-      'cred-456',
-    ]);
-  });
-
-  it('emits only --turn-url flags when no credential-less (STUN) entry is present', () => {
-    expect(
-      turnIceServersToServeSimArgs([
-        {
-          urls: ['turns:turn.cloudflare.com:443?transport=tcp'],
-          username: 'u',
-          credential: 'c',
-        },
-      ])
-    ).toEqual([
-      '--turn-url',
-      'turns:turn.cloudflare.com:443?transport=tcp',
-      '--turn-username',
-      'u',
-      '--turn-credential',
-      'c',
-    ]);
-  });
-
-  it('emits only --stun-url when there is no credentialed TURN entry', () => {
-    expect(turnIceServersToServeSimArgs([{ urls: ['stun:stun.cloudflare.com:3478'] }])).toEqual([
-      '--stun-url',
-      'stun:stun.cloudflare.com:3478',
-    ]);
-  });
-});
-
-describe(fetchServeSimTurnArgsAsync, () => {
-  beforeEach(() => {
-    jest.mocked(turtleFetch).mockReset();
-  });
-
-  it('requests TURN ICE servers from the device run session endpoint and returns serve-sim args', async () => {
-    jest.mocked(turtleFetch).mockResolvedValue({
-      json: async () => ({
-        data: {
-          iceServers: [
-            { urls: ['stun:stun.cloudflare.com:3478'] },
-            {
-              urls: ['turns:turn.cloudflare.com:443?transport=tcp'],
-              username: 'u',
-              credential: 'c',
-            },
-          ],
-        },
-      }),
-    } as unknown as Awaited<ReturnType<typeof turtleFetch>>);
-
-    const args = await fetchServeSimTurnArgsAsync(createCtxMock(), {
-      env: createEnvMock(),
-      logger: createLoggerMock(),
-    });
-
-    expect(args).toEqual([
-      '--stun-url',
-      'stun:stun.cloudflare.com:3478',
-      '--turn-url',
-      'turns:turn.cloudflare.com:443?transport=tcp',
-      '--turn-username',
-      'u',
-      '--turn-credential',
-      'c',
-    ]);
-    expect(jest.mocked(turtleFetch)).toHaveBeenCalledWith(
-      'https://api.expo.test/v2/device-run-sessions/drs-id/turn-ice-servers',
-      'POST',
-      expect.objectContaining({
-        headers: { Authorization: 'Bearer robot-token' },
-      })
-    );
-  });
-
-  it('returns [] and warns when the request fails so serve-sim falls back to P2P/STUN', async () => {
-    jest.mocked(turtleFetch).mockRejectedValue(new Error('boom'));
-    const logger = createLoggerMock();
-
-    const args = await fetchServeSimTurnArgsAsync(createCtxMock(), {
-      env: createEnvMock(),
-      logger,
-    });
-
-    expect(args).toEqual([]);
-    expect(logger.warn).toHaveBeenCalled();
-    expect(jest.mocked(Sentry).capture).toHaveBeenCalled();
-  });
-});
-
-describe(waitForDeviceRunSessionStoppedAsync, () => {
-  beforeEach(() => {
-    jest.mocked(Sentry).capture.mockReset();
-    jest.mocked(setTimeoutAsync).mockReset();
-    jest.mocked(setTimeoutAsync).mockResolvedValue(undefined);
-  });
-
-  it('continues polling until the device run session is stopped', async () => {
-    const ctx = createStatusCtxMock([{ status: 'IN_PROGRESS' }, { status: 'STOPPED' }]);
-    const logger = createLoggerMock();
-
-    await waitForDeviceRunSessionStoppedAsync({
-      ctx,
-      deviceRunSessionId: 'drs-id',
-      logger,
-    });
-
-    expect(ctx.graphqlClient.query).toHaveBeenCalledTimes(2);
-    expect(logger.info).toHaveBeenCalledWith('Device run session drs-id was stopped.');
-  });
-
-  it('throws when the device run session errors', async () => {
-    const ctx = createStatusCtxMock([{ status: 'ERRORED' }]);
-
-    await expect(
-      waitForDeviceRunSessionStoppedAsync({
-        ctx,
-        deviceRunSessionId: 'drs-id',
-        logger: createLoggerMock(),
-      })
-    ).rejects.toThrow('Device run session drs-id errored.');
-  });
-
-  it('logs and retries transient polling errors', async () => {
-    const ctx = createStatusCtxMock([{ error: new Error('network down') }, { status: 'STOPPED' }]);
-    const logger = createLoggerMock();
-
-    await waitForDeviceRunSessionStoppedAsync({
-      ctx,
-      deviceRunSessionId: 'drs-id',
-      logger,
-    });
-
-    expect(ctx.graphqlClient.query).toHaveBeenCalledTimes(2);
-    expect(logger.warn).toHaveBeenCalledWith(
-      expect.objectContaining({ failedStatusPollCount: 1 }),
-      'Could not poll device run session status; will retry.'
-    );
-    expect(jest.mocked(Sentry).capture).toHaveBeenCalledWith(
-      'Could not poll device run session status',
-      expect.any(Error),
-      { level: 'warning' }
-    );
-  });
-
-  it('logs and retries when the status response is missing', async () => {
-    const ctx = createStatusCtxMock([
-      { data: { deviceRunSessions: { byId: null } } },
-      { status: 'STOPPED' },
-    ]);
-    const logger = createLoggerMock();
-
-    await waitForDeviceRunSessionStoppedAsync({
-      ctx,
-      deviceRunSessionId: 'drs-id',
-      logger,
-    });
-
-    expect(ctx.graphqlClient.query).toHaveBeenCalledTimes(2);
-    expect(logger.warn).toHaveBeenCalledWith(
-      expect.objectContaining({ failedStatusPollCount: 1 }),
-      'Could not poll device run session status; will retry.'
-    );
-    expect(jest.mocked(Sentry).capture).toHaveBeenCalledWith(
-      'Could not poll device run session status',
-      expect.objectContaining({
-        message: 'Device run session drs-id status response was missing.',
-      }),
-      { level: 'warning' }
-    );
-  });
-});

packages/build-tools/src/steps/utils/agentDeviceArtifacts.ts

@@ -1,193 +0,0 @@
-import { SystemError } from '@expo/eas-build-job';
-import { type bunyan } from '@expo/logger';
-import { createReadStream, createWriteStream } from 'node:fs';
-import { mkdtemp, rm, stat } from 'node:fs/promises';
-import fetch from 'node-fetch';
-import os from 'node:os';
-import path from 'node:path';
-import { pipeline } from 'node:stream/promises';
-import { z } from 'zod';
-
-import { CustomBuildContext } from '../../customBuildContext';
-import { Sentry } from '../../sentry';
-import { formatBytes } from '../../utils/artifacts';
-import { sleepAsync } from '../../utils/retry';
-import { uploadDeviceRunSessionArtifactAsync } from './deviceRunSessionArtifacts';
-
-const AGENT_DEVICE_ARTIFACT_UPLOAD_POLL_INTERVAL_MS = 5_000;
-
-const AgentDeviceArtifactSchema = z.object({
-  id: z.string(),
-  artifactType: z.string().nullish(),
-  filename: z.string(),
-});
-const AgentDeviceArtifactsListResponseSchema = z.object({
-  artifacts: z.array(AgentDeviceArtifactSchema),
-});
-
-export type AgentDeviceArtifact = z.infer<typeof AgentDeviceArtifactSchema>;
-
-class AgentDeviceArtifactsUnsupportedError extends SystemError {
-  constructor() {
-    super('agent-device daemon does not expose artifact inventory.');
-  }
-}
-
-export async function pollAgentDeviceArtifactsForUploadAsync(
-  ctx: CustomBuildContext,
-  {
-    deviceRunSessionId,
-    daemonUrl,
-    daemonToken,
-    logger,
-  }: {
-    deviceRunSessionId: string;
-    daemonUrl: string;
-    daemonToken: string;
-    logger: bunyan;
-  }
-): Promise<void> {
-  logger.info('Started polling agent-device daemon for artifacts.');
-  const uploadedArtifactIds = new Set<string>();
-  let listArtifactsErrorCount = 0;
-
-  for (;;) {
-    try {
-      const artifacts = await listAgentDeviceArtifactsAsync({ daemonUrl, daemonToken });
-      listArtifactsErrorCount = 0;
-      for (const artifact of artifacts) {
-        if (uploadedArtifactIds.has(artifact.id)) {
-          continue;
-        }
-        try {
-          await uploadAgentDeviceArtifactAsync(ctx, {
-            deviceRunSessionId,
-            daemonUrl,
-            daemonToken,
-            artifact,
-            logger,
-          });
-          uploadedArtifactIds.add(artifact.id);
-        } catch (err) {
-          const error = err instanceof Error ? err : new Error(String(err));
-          Sentry.capture('Could not upload agent-device remote session artifact', error);
-          logger.warn({ err: error }, 'Could not upload agent-device remote session artifact.');
-        }
-      }
-    } catch (err) {
-      if (err instanceof AgentDeviceArtifactsUnsupportedError) {
-        logger.warn(
-          'agent-device daemon does not expose artifact inventory; remote session artifact uploads are disabled.'
-        );
-        return;
-      }
-      const error = err instanceof Error ? err : new Error(String(err));
-      listArtifactsErrorCount += 1;
-      if (listArtifactsErrorCount === 1 || listArtifactsErrorCount % 5 === 0) {
-        Sentry.capture('Could not list agent-device remote session artifacts', error);
-        logger.warn(
-          { err: error, failedArtifactListCount: listArtifactsErrorCount },
-          'Could not list agent-device remote session artifacts.'
-        );
-      }
-    }
-    await sleepAsync(AGENT_DEVICE_ARTIFACT_UPLOAD_POLL_INTERVAL_MS);
-  }
-}
-
-export async function listAgentDeviceArtifactsAsync({
-  daemonUrl,
-  daemonToken,
-}: {
-  daemonUrl: string;
-  daemonToken: string;
-}): Promise<AgentDeviceArtifact[]> {
-  const response = await fetch(new URL('/artifacts', daemonUrl).toString(), {
-    headers: { Authorization: `Bearer ${daemonToken}` },
-  });
-  if (response.status === 404) {
-    throw new AgentDeviceArtifactsUnsupportedError();
-  }
-  if (!response.ok) {
-    throw new SystemError(
-      `Failed to list agent-device artifacts: ${response.status} ${response.statusText}`
-    );
-  }
-  const result = AgentDeviceArtifactsListResponseSchema.safeParse(await response.json());
-  if (!result.success) {
-    throw new SystemError(`Invalid agent-device artifacts response: ${result.error.message}`);
-  }
-  return result.data.artifacts;
-}
-
-export async function uploadAgentDeviceArtifactAsync(
-  ctx: CustomBuildContext,
-  {
-    deviceRunSessionId,
-    daemonUrl,
-    daemonToken,
-    artifact,
-    logger,
-  }: {
-    deviceRunSessionId: string;
-    daemonUrl: string;
-    daemonToken: string;
-    artifact: AgentDeviceArtifact;
-    logger: bunyan;
-  }
-): Promise<void> {
-  logger.info(`Downloading artifact ${artifact.filename}.`);
-  const temporaryDirectory = await mkdtemp(path.join(os.tmpdir(), 'agent-device-artifact-'));
-  try {
-    const temporaryArtifactPath = path.join(temporaryDirectory, path.basename(artifact.filename));
-    await downloadAgentDeviceArtifactToFileAsync({
-      artifact,
-      daemonUrl,
-      daemonToken,
-      destinationPath: temporaryArtifactPath,
-    });
-    const { size } = await stat(temporaryArtifactPath);
-    logger.info(`Uploading artifact ${artifact.filename} (${formatBytes(size)}).`);
-    await uploadDeviceRunSessionArtifactAsync(ctx, {
-      deviceRunSessionId,
-      artifactId: artifact.id,
-      name: `${artifact.filename} (${artifact.id})`,
-      filename: artifact.filename,
-      kind: artifact.artifactType ?? undefined,
-      size,
-      stream: createReadStream(temporaryArtifactPath),
-    });
-  } finally {
-    await rm(temporaryDirectory, { recursive: true, force: true });
-  }
-}
-
-async function downloadAgentDeviceArtifactToFileAsync({
-  artifact,
-  daemonUrl,
-  daemonToken,
-  destinationPath,
-}: {
-  artifact: AgentDeviceArtifact;
-  daemonUrl: string;
-  daemonToken: string;
-  destinationPath: string;
-}): Promise<void> {
-  const response = await fetch(
-    new URL(`/artifacts/${encodeURIComponent(artifact.id)}`, daemonUrl).toString(),
-    {
-      headers: { Authorization: `Bearer ${daemonToken}` },
-    }
-  );
-  if (!response.ok) {
-    throw new SystemError(
-      `Failed to download agent-device artifact ${artifact.id}: ${response.status} ${response.statusText}`
-    );
-  }
-  if (!response.body) {
-    throw new SystemError(
-      `Agent-device artifact ${artifact.id} response did not include a readable body.`
-    );
-  }
-  await pipeline(response.body, createWriteStream(destinationPath));
-}

packages/build-tools/src/steps/utils/android/gradle.ts

@@ -1,7 +1,8 @@
 import { Android } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
 import { BuildStepEnv } from '@expo/steps';
-import spawn from '@expo/turtle-spawn';
+import spawn, { SpawnPromise, SpawnResult } from '@expo/turtle-spawn';
+import assert from 'assert';
 import fs from 'fs-extra';
 import path from 'path';
 
@@ -22,18 +23,10 @@ export async function runGradleCommand({
 
   logger.info(`Running 'gradlew ${gradleCommand} ${verboseFlag}' in ${androidDir}`);
   await fs.chmod(path.join(androidDir, 'gradlew'), 0o755);
-  const shouldResetOOMScore = env.EAS_BUILD_RUNNER === 'eas-build' && process.platform === 'linux';
 
-  await spawn(
+  const spawnPromise = spawn(
     'bash',
-    [
-      '-c',
-      getGradleShellCommand({
-        gradleCommand,
-        oomScoreAdj: shouldResetOOMScore ? 0 : undefined,
-        verboseFlag,
-      }),
-    ],
+    ['-c', `./gradlew ${gradleCommand} --profile ${verboseFlag}`],
     {
       cwd: androidDir,
       logger,
@@ -51,20 +44,73 @@ export async function runGradleCommand({
       },
     }
   );
+  if (env.EAS_BUILD_RUNNER === 'eas-build' && process.platform === 'linux') {
+    adjustOOMScore(spawnPromise, logger);
+  }
+
+  await spawnPromise;
 }
 
-export function getGradleShellCommand({
-  gradleCommand,
-  oomScoreAdj,
-  verboseFlag,
-}: {
-  gradleCommand: string;
-  oomScoreAdj?: number;
-  verboseFlag: string;
-}): string {
-  const oomScoreAdjPrefix =
-    oomScoreAdj === undefined ? '' : `echo ${oomScoreAdj} > /proc/$$/oom_score_adj || true; `;
-  return `${oomScoreAdjPrefix}exec ./gradlew ${gradleCommand} --profile ${verboseFlag}`;
+/**
+ * OOM Killer sometimes kills worker server while build is exceeding memory limits.
+ * `oom_score_adj` is a value between -1000 and 1000 and it defaults to 0.
+ * It defines which process is more likely to get killed (higher value more likely).
+ *
+ * This function sets oom_score_adj for Gradle process and all its child processes.
+ */
+function adjustOOMScore(spawnPromise: SpawnPromise<SpawnResult>, logger: bunyan): void {
+  setTimeout(
+    async () => {
+      try {
+        assert(spawnPromise.child.pid);
+        const pids = await getParentAndDescendantProcessPidsAsync(spawnPromise.child.pid);
+        await Promise.all(
+          pids.map(async (pid: number) => {
+            // Value 800 is just a guess here. It's probably higher than most other
+            // process. I didn't want to set it any higher, because I'm not sure if OOM Killer
+            // can start killing processes when there is still enough memory left.
+            const oomScoreOverride = 800;
+            await fs.writeFile(`/proc/${pid}/oom_score_adj`, `${oomScoreOverride}\n`);
+          })
+        );
+      } catch (err: any) {
+        logger.debug({ err, stderr: err?.stderr }, 'Failed to override oom_score_adj');
+      }
+    },
+    // Wait 20 seconds to make sure all child processes are started
+    20000
+  );
+}
+
+async function getChildrenPidsAsync(parentPids: number[]): Promise<number[]> {
+  try {
+    const result = await spawn('pgrep', ['-P', parentPids.join(',')], {
+      stdio: 'pipe',
+    });
+    return result.stdout
+      .toString()
+      .split('\n')
+      .map(i => Number(i.trim()))
+      .filter(i => i);
+  } catch {
+    return [];
+  }
+}
+
+async function getParentAndDescendantProcessPidsAsync(ppid: number): Promise<number[]> {
+  const children = new Set<number>([ppid]);
+  let shouldCheckAgain = true;
+  while (shouldCheckAgain) {
+    const pids = await getChildrenPidsAsync([...children]);
+    shouldCheckAgain = false;
+    for (const pid of pids) {
+      if (!children.has(pid)) {
+        shouldCheckAgain = true;
+        children.add(pid);
+      }
+    }
+  }
+  return [...children];
 }
 
 export function resolveGradleCommand(job: Android.Job, command?: string): string {

packages/build-tools/src/steps/utils/argentArtifacts.ts

@@ -1,284 +0,0 @@
-import { SystemError } from '@expo/eas-build-job';
-import { type bunyan } from '@expo/logger';
-import { createReadStream, createWriteStream } from 'node:fs';
-import { mkdtemp, rm, stat } from 'node:fs/promises';
-import fetch from 'node-fetch';
-import os from 'node:os';
-import path from 'node:path';
-import { pipeline } from 'node:stream/promises';
-import { setTimeout as setTimeoutAsync } from 'node:timers/promises';
-import { z } from 'zod';
-
-import { CustomBuildContext } from '../../customBuildContext';
-import { Sentry } from '../../sentry';
-import { formatBytes } from '../../utils/artifacts';
-import { uploadDeviceRunSessionArtifactAsync } from './deviceRunSessionArtifacts';
-
-const ARGENT_ARTIFACT_UPLOAD_POLL_INTERVAL_MS = 5_000;
-const ARGENT_ARTIFACT_UPLOAD_CLEANUP_TIMEOUT_MS = 30_000;
-const ARGENT_ARTIFACT_FETCH_TIMEOUT_MS = 10_000;
-
-const ArgentArtifactSchema = z.object({
-  id: z.string(),
-  filename: z.string(),
-  mimeType: z.string(),
-  isDirectory: z.boolean().optional(),
-});
-const ArgentArtifactsListResponseSchema = z.object({
-  artifacts: z.array(ArgentArtifactSchema),
-});
-
-type ArgentArtifact = z.infer<typeof ArgentArtifactSchema>;
-
-export async function pollArgentArtifactsForUploadAsync(
-  ctx: CustomBuildContext,
-  {
-    deviceRunSessionId,
-    toolsUrl,
-    toolsAuthToken,
-    logger,
-    signal,
-  }: {
-    deviceRunSessionId: string;
-    toolsUrl: string;
-    toolsAuthToken?: string;
-    logger: bunyan;
-    signal: AbortSignal;
-  }
-): Promise<void> {
-  logger.info('Started polling Argent tool-server for artifacts.');
-  const seenArtifactIds = new Set<string>();
-  const pendingUploads = new Set<Promise<void>>();
-  let listArtifactsErrorCount = 0;
-
-  const queueArtifactUpload = (artifact: ArgentArtifact): void => {
-    if (seenArtifactIds.has(artifact.id)) {
-      return;
-    }
-    seenArtifactIds.add(artifact.id);
-    const uploadPromise = uploadArgentArtifactAsync(ctx, {
-      deviceRunSessionId,
-      toolsUrl,
-      toolsAuthToken,
-      artifact,
-      logger,
-    }).catch(err => {
-      const error = err instanceof Error ? err : new Error(String(err));
-      Sentry.capture('Could not upload Argent remote session artifact', error);
-      logger.warn({ err: error }, 'Could not upload Argent remote session artifact.');
-    });
-    pendingUploads.add(uploadPromise);
-    void uploadPromise.finally(() => {
-      pendingUploads.delete(uploadPromise);
-    });
-  };
-
-  const listArtifactsForUploadAsync = async ({
-    signal,
-  }: {
-    signal?: AbortSignal;
-  } = {}): Promise<ArgentArtifact[]> => {
-    try {
-      const artifacts = await listArgentArtifactsAsync({ toolsUrl, toolsAuthToken, signal });
-      listArtifactsErrorCount = 0;
-      return artifacts;
-    } catch (err) {
-      if (signal?.aborted) {
-        return [];
-      }
-
-      const error = err instanceof Error ? err : new Error(String(err));
-      listArtifactsErrorCount += 1;
-      if (listArtifactsErrorCount === 1 || listArtifactsErrorCount % 5 === 0) {
-        Sentry.capture('Could not list Argent remote session artifacts', error);
-        logger.warn(
-          { err: error, failedArtifactListCount: listArtifactsErrorCount },
-          'Could not list Argent remote session artifacts.'
-        );
-      }
-      return [];
-    }
-  };
-
-  const listAndQueueArtifactUploadsAsync = async ({
-    signal,
-  }: {
-    signal?: AbortSignal;
-  } = {}): Promise<void> => {
-    const artifacts = await listArtifactsForUploadAsync({ signal });
-    for (const artifact of artifacts) {
-      queueArtifactUpload(artifact);
-    }
-  };
-
-  while (!signal.aborted) {
-    await listAndQueueArtifactUploadsAsync({ signal });
-    await sleepUntilAbortedAsync(ARGENT_ARTIFACT_UPLOAD_POLL_INTERVAL_MS, signal);
-  }
-
-  logger.info('Argent artifact polling stopped; draining remaining artifacts.');
-  await listAndQueueArtifactUploadsAsync();
-  await waitForPendingUploadsAsync({
-    pendingUploads,
-    timeoutMs: ARGENT_ARTIFACT_UPLOAD_CLEANUP_TIMEOUT_MS,
-    logger,
-  });
-}
-
-export async function listArgentArtifactsAsync({
-  toolsUrl,
-  toolsAuthToken,
-  signal,
-}: {
-  toolsUrl: string;
-  toolsAuthToken?: string;
-  signal?: AbortSignal;
-}): Promise<ArgentArtifact[]> {
-  const response = await fetch(new URL('/artifacts', toolsUrl).toString(), {
-    headers: toolsAuthToken ? { Authorization: `Bearer ${toolsAuthToken}` } : {},
-    signal: createTimeoutSignal({ signal, timeoutMs: ARGENT_ARTIFACT_FETCH_TIMEOUT_MS }),
-  });
-  if (!response.ok) {
-    throw new SystemError(
-      `Failed to list Argent artifacts: ${response.status} ${response.statusText}`
-    );
-  }
-  const result = ArgentArtifactsListResponseSchema.safeParse(await response.json());
-  if (!result.success) {
-    throw new SystemError(`Invalid Argent artifacts response: ${result.error.message}`);
-  }
-  return result.data.artifacts;
-}
-
-export async function uploadArgentArtifactAsync(
-  ctx: CustomBuildContext,
-  {
-    deviceRunSessionId,
-    toolsUrl,
-    toolsAuthToken,
-    artifact,
-    logger,
-  }: {
-    deviceRunSessionId: string;
-    toolsUrl: string;
-    toolsAuthToken?: string;
-    artifact: ArgentArtifact;
-    logger: bunyan;
-  }
-): Promise<void> {
-  const filename = artifact.isDirectory ? `${artifact.filename}.tar.gz` : artifact.filename;
-  logger.info(`Downloading artifact ${filename}.`);
-  const temporaryDirectory = await mkdtemp(path.join(os.tmpdir(), 'argent-artifact-'));
-  try {
-    const temporaryArtifactPath = path.join(temporaryDirectory, path.basename(filename));
-    await downloadArgentArtifactToFileAsync({
-      artifact,
-      toolsUrl,
-      toolsAuthToken,
-      destinationPath: temporaryArtifactPath,
-    });
-    const { size } = await stat(temporaryArtifactPath);
-    logger.info(`Uploading artifact ${filename} (${formatBytes(size)}).`);
-    await uploadDeviceRunSessionArtifactAsync(ctx, {
-      deviceRunSessionId,
-      artifactId: artifact.id,
-      name: `${filename} (${artifact.id})`,
-      filename,
-      kind: undefined,
-      size,
-      stream: createReadStream(temporaryArtifactPath),
-    });
-  } finally {
-    await rm(temporaryDirectory, { recursive: true, force: true });
-  }
-}
-
-async function downloadArgentArtifactToFileAsync({
-  artifact,
-  toolsUrl,
-  toolsAuthToken,
-  destinationPath,
-}: {
-  artifact: ArgentArtifact;
-  toolsUrl: string;
-  toolsAuthToken?: string;
-  destinationPath: string;
-}): Promise<void> {
-  const response = await fetch(new URL(`/artifacts/${artifact.id}`, toolsUrl).toString(), {
-    headers: toolsAuthToken ? { Authorization: `Bearer ${toolsAuthToken}` } : {},
-    signal: createTimeoutSignal({
-      signal: undefined,
-      timeoutMs: ARGENT_ARTIFACT_FETCH_TIMEOUT_MS,
-    }),
-  });
-  if (!response.ok) {
-    throw new SystemError(
-      `Failed to download Argent artifact ${artifact.id}: ${response.status} ${response.statusText}`
-    );
-  }
-  if (!response.body) {
-    throw new SystemError(
-      `Argent artifact ${artifact.id} response did not include a readable body.`
-    );
-  }
-  await pipeline(response.body, createWriteStream(destinationPath));
-}
-
-async function sleepUntilAbortedAsync(timeoutMs: number, signal: AbortSignal): Promise<void> {
-  try {
-    await setTimeoutAsync(timeoutMs, undefined, { signal });
-  } catch (err) {
-    if (!signal.aborted) {
-      throw err;
-    }
-  }
-}
-
-function createTimeoutSignal({
-  signal,
-  timeoutMs,
-}: {
-  signal: AbortSignal | undefined;
-  timeoutMs: number;
-}): AbortSignal {
-  const timeoutSignal = AbortSignal.timeout(timeoutMs);
-  return signal ? AbortSignal.any([signal, timeoutSignal]) : timeoutSignal;
-}
-
-async function waitForPendingUploadsAsync({
-  pendingUploads,
-  timeoutMs,
-  logger,
-}: {
-  pendingUploads: Set<Promise<void>>;
-  timeoutMs: number;
-  logger: bunyan;
-}): Promise<void> {
-  if (pendingUploads.size === 0) {
-    return;
-  }
-
-  logger.info(`Waiting for ${pendingUploads.size} Argent artifact upload(s) to finish.`);
-  let timeout: NodeJS.Timeout | undefined;
-  try {
-    await Promise.race([
-      Promise.allSettled([...pendingUploads]),
-      new Promise<never>((_resolve, reject) => {
-        timeout = setTimeout(() => {
-          reject(
-            new SystemError(
-              `Timed out after ${Math.round(timeoutMs / 1000)}s waiting for Argent artifact uploads.`,
-              {
-                trackingCode: 'SIMULATOR_ARTIFACT_SLOW_UPLOAD',
-              }
-            )
-          );
-        }, timeoutMs);
-      }),
-    ]);
-  } finally {
-    if (timeout) {
-      clearTimeout(timeout);
-    }
-  }
-}

packages/build-tools/src/steps/utils/deviceRunSessionArtifacts.ts

@@ -1,106 +0,0 @@
-import { SystemError } from '@expo/eas-build-job';
-import { graphql } from 'gql.tada';
-import fetch, { Headers } from 'node-fetch';
-
-import { CustomBuildContext } from '../../customBuildContext';
-
-const CREATE_DEVICE_RUN_SESSION_ARTIFACT_UPLOAD_SESSION_MUTATION = graphql(`
-  mutation CreateDeviceRunSessionArtifactUploadSession(
-    $deviceRunSessionId: ID!
-    $input: CreateDeviceRunSessionArtifactUploadSessionInput!
-  ) {
-    deviceRunSession {
-      createArtifactUploadSession(deviceRunSessionId: $deviceRunSessionId, input: $input) {
-        uploadSession {
-          url
-          headers
-        }
-      }
-    }
-  }
-`);
-
-export async function uploadDeviceRunSessionArtifactAsync(
-  ctx: CustomBuildContext,
-  {
-    deviceRunSessionId,
-    artifactId,
-    name,
-    filename,
-    kind,
-    metadata,
-    size,
-    stream,
-  }: {
-    deviceRunSessionId: string;
-    artifactId: string;
-    name: string;
-    filename: string;
-    kind: string | undefined;
-    metadata?: Record<string, unknown>;
-    size: number;
-    stream: NodeJS.ReadableStream;
-  }
-): Promise<void> {
-  const uploadSession = await createDeviceRunSessionArtifactUploadSessionAsync(ctx, {
-    deviceRunSessionId,
-    artifactId,
-    name,
-    filename,
-    kind,
-    metadata,
-    size,
-  });
-  const response = await fetch(uploadSession.url, {
-    method: 'PUT',
-    headers: new Headers(uploadSession.headers as Record<string, string>),
-    body: stream,
-  });
-  if (!response.ok) {
-    throw new SystemError(
-      `Failed to upload device run session artifact ${artifactId}: ${response.status} ${response.statusText}`,
-      { cause: response }
-    );
-  }
-}
-
-async function createDeviceRunSessionArtifactUploadSessionAsync(
-  ctx: CustomBuildContext,
-  {
-    deviceRunSessionId,
-    artifactId,
-    name,
-    filename,
-    kind,
-    metadata,
-    size,
-  }: {
-    deviceRunSessionId: string;
-    artifactId: string;
-    name: string;
-    filename: string;
-    kind: string | undefined;
-    metadata?: Record<string, unknown>;
-    size: number;
-  }
-) {
-  const result = await ctx.graphqlClient
-    .mutation(CREATE_DEVICE_RUN_SESSION_ARTIFACT_UPLOAD_SESSION_MUTATION, {
-      deviceRunSessionId,
-      input: {
-        name,
-        filename,
-        ...(kind !== undefined ? { kind } : {}),
-        ...(metadata !== undefined ? { metadata } : {}),
-        size,
-      },
-    })
-    .toPromise();
-  if (result.error) {
-    throw new SystemError(
-      `Failed to create upload session for device run session artifact ${artifactId}: ${result.error.message}`,
-      { cause: result.error }
-    );
-  }
-  return result.data!.deviceRunSession.createArtifactUploadSession.uploadSession;
-}

packages/build-tools/src/steps/utils/remoteDeviceRunSession.ts

@@ -1,21 +1,14 @@
 import { SystemError } from '@expo/eas-build-job';
 import { bunyan } from '@expo/logger';
-import { BuildStepEnv, spawnAsync } from '@expo/steps';
+import { BuildStepEnv } from '@expo/steps';
 import spawn from '@expo/turtle-spawn';
 import * as ngrok from '@ngrok/ngrok';
 import { graphql } from 'gql.tada';
-import nullthrows from 'nullthrows';
-import { z } from 'zod';
 import { randomBytes } from 'node:crypto';
 import fs from 'node:fs';
-import { setTimeout as setTimeoutAsync } from 'node:timers/promises';
 
 import { CustomBuildContext } from '../../customBuildContext';
-import { Sentry } from '../../sentry';
 import { sleepAsync } from '../../utils/retry';
-import { turtleFetch } from '../../utils/turtleFetch';
-
-const XCODE_DEVELOPER_DIR = '/Applications/Xcode.app/Contents/Developer';
 
 const START_DEVICE_RUN_SESSION_MUTATION = graphql(`
   mutation StartDeviceRunSession($deviceRunSessionId: ID!, $remoteConfig: JSONObject!) {
@@ -31,19 +24,6 @@ const START_DEVICE_RUN_SESSION_MUTATION = graphql(`
   }
 `);
 
-const DEVICE_RUN_SESSION_STATUS_QUERY = graphql(`
-  query DeviceRunSessionStatus($deviceRunSessionId: ID!) {
-    deviceRunSessions {
-      byId(deviceRunSessionId: $deviceRunSessionId) {
-        id
-        status
-      }
-    }
-  }
-`);
-
-const DEVICE_RUN_SESSION_STATUS_POLL_INTERVAL_MS = 5_000;
-
 export function getDeviceRunSessionIdOrThrow(env: BuildStepEnv): string {
   const deviceRunSessionId = env.DEVICE_RUN_SESSION_ID;
   if (!deviceRunSessionId) {
@@ -80,194 +60,6 @@ export function getNgrokAuthtokenOrThrow(env: BuildStepEnv): string {
   return authtoken;
 }
 
-const TurnIceServersSchema = z.array(
-  z.object({
-    urls: z.array(z.string()),
-    username: z.string().optional(),
-    credential: z.string().optional(),
-  })
-);
-
-export type TurnIceServers = z.infer<typeof TurnIceServersSchema>;
-
-export async function selectXcodeDeveloperDirectoryAsync({
-  env,
-  logger,
-}: {
-  env: BuildStepEnv;
-  logger: bunyan;
-}): Promise<void> {
-  if (process.env.ENVIRONMENT === 'development') {
-    logger.info('Job running outside of EAS, not selecting Xcode developer directory.');
-    return;
-  }
-
-  logger.info(`Selecting Xcode developer directory: ${XCODE_DEVELOPER_DIR}.`);
-  await spawnAsync('sudo', ['xcode-select', '-s', XCODE_DEVELOPER_DIR], {
-    env,
-    logger,
-    stdio: ['ignore', 'pipe', 'pipe'],
-  });
-}
-
-export async function waitForDeviceRunSessionStoppedAsync({
-  ctx,
-  deviceRunSessionId,
-  logger,
-  signal,
-}: {
-  ctx: CustomBuildContext;
-  deviceRunSessionId: string;
-  logger: bunyan;
-  signal?: AbortSignal;
-}): Promise<void> {
-  logger.info(
-    `Remote session is live. Polling device run session ${deviceRunSessionId} until it is stopped.`
-  );
-  let pollErrorCount = 0;
-
-  while (!signal?.aborted) {
-    try {
-      const result = await ctx.graphqlClient
-        .query(DEVICE_RUN_SESSION_STATUS_QUERY, { deviceRunSessionId })
-        .toPromise();
-      if (result.error) {
-        throw result.error;
-      }
-
-      const status = result.data?.deviceRunSessions?.byId?.status;
-      if (!status) {
-        throw new Error(`Device run session ${deviceRunSessionId} status response was missing.`);
-      }
-      pollErrorCount = 0;
-      if (status === 'STOPPED') {
-        logger.info(`Device run session ${deviceRunSessionId} was stopped.`);
-        return;
-      }
-      if (status === 'ERRORED') {
-        throw new SystemError(`Device run session ${deviceRunSessionId} errored.`);
-      }
-    } catch (err) {
-      if (err instanceof SystemError) {
-        throw err;
-      }
-
-      const error = err instanceof Error ? err : new Error(String(err));
-      pollErrorCount += 1;
-      if (pollErrorCount === 1 || pollErrorCount % 5 === 0) {
-        Sentry.capture('Could not poll device run session status', error, { level: 'warning' });
-        logger.warn(
-          { err: error, failedStatusPollCount: pollErrorCount },
-          'Could not poll device run session status; will retry.'
-        );
-      }
-    }
-    await sleepUntilAbortedAsync(DEVICE_RUN_SESSION_STATUS_POLL_INTERVAL_MS, signal);
-  }
-}
-
-async function sleepUntilAbortedAsync(
-  timeoutMs: number,
-  signal: AbortSignal | undefined
-): Promise<void> {
-  try {
-    await setTimeoutAsync(timeoutMs, undefined, signal ? { signal } : undefined);
-  } catch (err) {
-    if (!signal?.aborted) {
-      throw err;
-    }
-  }
-}
-
-const TurnIceServersResponseSchema = z.object({
-  data: z.object({
-    iceServers: TurnIceServersSchema,
-  }),
-});
-
-/**
- * Translate Cloudflare ICE servers into serve-sim CLI flags: `--stun-url` (the
- * credential-less entries) and `--turn-url`/`--turn-username`/`--turn-credential`
- * (the entry carrying the short-lived credentials).
- */
-export function turnIceServersToServeSimArgs(iceServers: TurnIceServers): string[] {
-  const stunUrls = iceServers
-    .filter(server => !server.username && !server.credential)
-    .flatMap(server => server.urls);
-  const turnServer = iceServers.find(server => server.username && server.credential);
-
-  const args: string[] = [];
-  if (stunUrls.length > 0) {
-    args.push('--stun-url', stunUrls.join(','));
-  }
-  if (turnServer?.username && turnServer.credential && turnServer.urls.length > 0) {
-    args.push(
-      '--turn-url',
-      turnServer.urls.join(','),
-      '--turn-username',
-      turnServer.username,
-      '--turn-credential',
-      turnServer.credential
-    );
-  }
-  return args;
-}
-
-/**
- * Fetch short-lived Cloudflare TURN ICE servers for this job run from www
- * (minted on demand, mirroring how the worker fetches project clone URLs) and
- * translate them into serve-sim CLI flags.
- *
- * Best-effort: on any failure we log and return [] so serve-sim falls back to
- * its built-in P2P/STUN behavior. The credential is passed to serve-sim as a
- * process arg and deliberately not logged (turtle-spawn never logs argv and the
- * worker is single-tenant).
- */
-export async function fetchServeSimTurnArgsAsync(
-  ctx: CustomBuildContext,
-  { env, logger }: { env: BuildStepEnv; logger: bunyan }
-): Promise<string[]> {
-  try {
-    const deviceRunSessionId = getDeviceRunSessionIdOrThrow(env);
-    const expoApiServerUrl = nullthrows(ctx.env.__API_SERVER_URL, '__API_SERVER_URL is not set');
-    const robotAccessToken = nullthrows(
-      ctx.job.secrets?.robotAccessToken,
-      'robot access token is not set'
-    );
-
-    const response = await turtleFetch(
-      new URL(
-        `/v2/device-run-sessions/${deviceRunSessionId}/turn-ice-servers`,
-        expoApiServerUrl
-      ).toString(),
-      'POST',
-      {
-        headers: {
-          Authorization: `Bearer ${robotAccessToken}`,
-        },
-        timeout: 5000,
-        retries: 1,
-        logger,
-      }
-    );
-
-    const { data } = TurnIceServersResponseSchema.parse(await response.json());
-    const args = turnIceServersToServeSimArgs(data.iceServers);
-    if (args.length > 0) {
-      logger.info('Configured serve-sim with Cloudflare TURN ICE servers.');
-    }
-    return args;
-  } catch (err) {
-    const error = err instanceof Error ? err : new Error(String(err));
-    Sentry.capture('Could not fetch Cloudflare TURN ICE servers', error, { level: 'warning' });
-    logger.warn(
-      { err: error },
-      'Could not fetch Cloudflare TURN ICE servers; serve-sim will fall back to P2P/STUN.'
-    );
-    return [];
-  }
-}
-
 export async function uploadRemoteSessionConfigAsync({
   ctx,
   deviceRunSessionId,
@@ -293,8 +85,6 @@ export async function uploadRemoteSessionConfigAsync({
 }
 
 export type DetachedProcessHandle = {
-  /** PID of the directly spawned process, if the OS assigned one. */
-  pid: number | undefined;
   getOutput: () => string;
 };
 
@@ -327,25 +117,21 @@ export function spawnDetached({
   promise.child.stdout?.on('data', appendChunk);
   promise.child.stderr?.on('data', appendChunk);
 
-  return { pid: promise.child.pid, getOutput: () => output };
+  return { getOutput: () => output };
 }
 
-export async function startServeSimWithTunnelAsync(
-  ctx: CustomBuildContext,
-  {
-    baseDomain,
-    env,
-    logger,
-    timeoutMs,
-  }: {
-    baseDomain: string;
-    env: BuildStepEnv;
-    logger: bunyan;
-    timeoutMs: number;
-  }
-): Promise<{ previewUrl: string; streamUrl: string }> {
+export async function startServeSimWithTunnelAsync({
+  baseDomain,
+  env,
+  logger,
+  timeoutMs,
+}: {
+  baseDomain: string;
+  env: BuildStepEnv;
+  logger: bunyan;
+  timeoutMs: number;
+}): Promise<{ previewUrl: string; streamUrl: string }> {
   logger.info('Launching serve-sim with tunnel.');
-  const turnArgs = await fetchServeSimTurnArgsAsync(ctx, { env, logger });
   const serveSim = spawnDetached({
     command: 'npx',
     args: [
@@ -361,7 +147,6 @@ export async function startServeSimWithTunnelAsync(
       '0.55',
       '--codec',
       'webrtc',
-      ...turnArgs,
     ],
     env,
   });
@@ -403,26 +188,19 @@ export async function startNgrokTunnelAsync({
   subdomainPrefix,
   baseDomain,
   authtoken,
-  rewriteHostHeader,
   logger,
 }: {
   port: number;
   subdomainPrefix: string;
   baseDomain: string;
   authtoken: string;
-  rewriteHostHeader?: boolean;
   logger: bunyan;
 }): Promise<string> {
   const domain = `${subdomainPrefix}-${randomBytes(8).toString('hex')}.${baseDomain}`;
   logger.info(`Starting ngrok tunnel ${domain} -> http://localhost:${port}.`);
   // Run the ngrok agent in-process via the SDK; it keeps the session alive until
   // the process exits, and the step blocks forever to hold it open.
-  const listener = await ngrok.forward({
-    addr: port,
-    authtoken,
-    domain,
-    ...(rewriteHostHeader ? { request_header_add: [`Host:localhost:${port}`] } : {}),
-  });
+  const listener = await ngrok.forward({ addr: port, authtoken, domain });
   const url = listener.url();
   if (!url) {
     throw new SystemError(`ngrok tunnel for ${domain} did not return a public URL.`);

packages/build-tools/src/utils/AndroidEmulatorUtils.ts

@@ -329,9 +329,6 @@ export namespace AndroidEmulatorUtils {
       await emulatorPromise;
     }
     emulatorPromise.child.unref();
-    // The emulator is detached and managed through adb. Observe its process promise
-    // immediately so expected exits during retry cleanup do not become unhandled rejections.
-    void asyncResult(emulatorPromise);
 
     const serialId = await retryAsync(
       async () => {

packages/build-tools/src/utils/IosSimulatorUtils.ts

@@ -1,4 +1,3 @@
-import { ExpoError, SystemError, UserError } from '@expo/eas-build-job';
 import spawn, { SpawnPromise, SpawnResult } from '@expo/turtle-spawn';
 import fs from 'node:fs';
 import os from 'node:os';
@@ -32,11 +31,7 @@ export namespace IosSimulatorUtils {
     lastBootedAt?: string;
   };
 
-  type SimulatorDevice = XcrunSimctlDevice & {
-    runtime: string;
-    runtimeDisplayName: string;
-    displayName: string;
-  };
+  type SimulatorDevice = XcrunSimctlDevice & { runtime: string; displayName: string };
 
   type XcrunSimctlListDevicesJsonOutput = {
     devices: {
@@ -64,7 +59,6 @@ export namespace IosSimulatorUtils {
         ...devices.map(device => ({
           ...device,
           runtime,
-          runtimeDisplayName: formatRuntimeDisplayName(runtime),
           displayName: `${device.name} (${device.udid}) on ${runtime}`,
         }))
       );
@@ -98,67 +92,6 @@ export namespace IosSimulatorUtils {
     });
   }
 
-  export async function enableAccessibilitySettingsAsync({
-    deviceIdentifier,
-    env,
-  }: {
-    deviceIdentifier: IosSimulatorUuid | IosSimulatorName;
-    env: NodeJS.ProcessEnv;
-  }): Promise<void> {
-    try {
-      const devices = await getAvailableDevicesAsync({ env, filter: 'available' });
-      const device = devices.find(
-        device =>
-          device.isAvailable &&
-          (device.udid === deviceIdentifier || device.name === deviceIdentifier)
-      );
-      if (!device) {
-        throw new UserError(
-          'EAS_IOS_SIMULATOR_NOT_FOUND',
-          `Failed to find available iOS Simulator "${deviceIdentifier}" to update accessibility settings.`
-        );
-      }
-      if (device.state !== 'Shutdown') {
-        throw new UserError(
-          'EAS_IOS_SIMULATOR_NOT_SHUTDOWN',
-          `Expected iOS Simulator "${deviceIdentifier}" to be shutdown before updating accessibility settings, but it is ${device.state}.`
-        );
-      }
-
-      const plistPath = path.join(
-        device.dataPath,
-        'Library',
-        'Preferences',
-        'com.apple.Accessibility.plist'
-      );
-      await fs.promises.mkdir(path.dirname(plistPath), { recursive: true });
-
-      const plistExists = await fs.promises
-        .access(plistPath)
-        .then(() => true)
-        .catch(() => false);
-      if (!plistExists) {
-        await spawn('plutil', ['-create', 'binary1', plistPath], { env });
-      }
-
-      for (const key of [
-        'AutomationEnabled',
-        'IgnoreAXServerEntitlements',
-        'AccessibilityEnabled',
-        'ApplicationAccessibilityEnabled',
-      ]) {
-        await spawn('plutil', ['-replace', key, '-bool', 'true', plistPath], { env });
-      }
-    } catch (err) {
-      if (err instanceof ExpoError) {
-        throw err;
-      }
-      throw new SystemError('Failed to update iOS Simulator accessibility settings.', {
-        cause: err,
-      });
-    }
-  }
-
   export async function startAsync({
     deviceIdentifier,
     env,
@@ -231,32 +164,16 @@ export namespace IosSimulatorUtils {
     udid: IosSimulatorUuid;
     env: NodeJS.ProcessEnv;
   }): Promise<void> {
-    const launchctlDomains = ['user/foreground', 'system'];
-    let lastError: unknown;
-
-    for (const domain of launchctlDomains) {
-      const service = `${domain}/com.apple.apsd`;
-      try {
-        await spawn('xcrun', ['simctl', 'spawn', udid, 'launchctl', 'disable', service], { env });
-
-        try {
-          await spawn('xcrun', ['simctl', 'spawn', udid, 'launchctl', 'bootout', service], {
-            env,
-          });
-        } catch (err) {
-          // bootout can fail when apsd is already gone; verify the service state below.
-          lastError = err;
-        }
-
-        if (!(await isLaunchctlServiceLoadedAsync({ udid, env, serviceLabel: 'com.apple.apsd' }))) {
-          return;
-        }
-      } catch (err) {
-        lastError = err;
-      }
-    }
-
-    throw lastError ?? new SystemError('Unable to disable apsd in the Simulator.');
+    await spawn(
+      'xcrun',
+      ['simctl', 'spawn', udid, 'launchctl', 'disable', 'system/com.apple.apsd'],
+      { env }
+    );
+    await spawn(
+      'xcrun',
+      ['simctl', 'spawn', udid, 'launchctl', 'bootout', 'system/com.apple.apsd'],
+      { env }
+    );
   }
 
   export async function collectLogsAsync({
@@ -379,31 +296,6 @@ export namespace IosSimulatorUtils {
   }
 }
 
-function formatRuntimeDisplayName(runtimeIdentifier: string): string {
-  const match = /^com\.apple\.CoreSimulator\.SimRuntime\.([^-]+)-(.+)$/.exec(runtimeIdentifier);
-  return match ? `${match[1]} ${match[2].replaceAll('-', '.')}` : runtimeIdentifier;
-}
-
-async function isLaunchctlServiceLoadedAsync({
-  udid,
-  env,
-  serviceLabel,
-}: {
-  udid: IosSimulatorUuid;
-  env: NodeJS.ProcessEnv;
-  serviceLabel: string;
-}): Promise<boolean> {
-  try {
-    await spawn('xcrun', ['simctl', 'spawn', udid, 'launchctl', 'list', serviceLabel], { env });
-    return true;
-  } catch (err) {
-    if (err instanceof Error && 'status' in err && (err as { status: unknown }).status === 113) {
-      return false;
-    }
-    throw err;
-  }
-}
-
 function parseUdidFromBootstatusStdout(stdout: string): IosSimulatorUuid | null {
   const matches = stdout.match(/^Monitoring boot status for .+ \((.+)\)\.$/m);
   if (!matches) {

packages/build-tools/src/utils/__tests__/IosSimulatorUtils.test.ts

@@ -1,4 +1,3 @@
-import { SystemError, UserError } from '@expo/eas-build-job';
 import spawn from '@expo/turtle-spawn';
 import os from 'node:os';
 import path from 'node:path';
@@ -19,176 +18,9 @@ const mockedSpawn = jest.mocked(spawn);
 
 describe('IosSimulatorUtils', () => {
   beforeEach(() => {
-    mockedSpawn.mockReset();
     mockedSpawn.mockResolvedValue({ stdout: '', stderr: '' } as any);
   });
 
-  describe(IosSimulatorUtils.getAvailableDevicesAsync, () => {
-    it('adds a human-readable runtime display name', async () => {
-      mockedSpawn.mockResolvedValue({
-        stdout: JSON.stringify({
-          devices: {
-            'com.apple.CoreSimulator.SimRuntime.iOS-18-6': [
-              {
-                dataPath: '/tmp/eas-test-simulator-data',
-                dataPathSize: 1,
-                logPath: '/tmp/eas-test-simulator-logs',
-                udid: 'test-udid',
-                isAvailable: true,
-                deviceTypeIdentifier: 'com.apple.CoreSimulator.SimDeviceType.iPhone-16',
-                state: 'Booted',
-                name: 'iPhone 16',
-              },
-            ],
-          },
-        }),
-        stderr: '',
-      } as any);
-
-      await expect(
-        IosSimulatorUtils.getAvailableDevicesAsync({ env: process.env, filter: 'booted' })
-      ).resolves.toEqual([
-        expect.objectContaining({
-          name: 'iPhone 16',
-          runtimeDisplayName: 'iOS 18.6',
-        }),
-      ]);
-    });
-  });
-
-  describe(IosSimulatorUtils.startAsync, () => {
-    it('waits for boot completion without writing accessibility prefs', async () => {
-      mockedSpawn.mockImplementation((async (command: string, args: string[]) => {
-        if (command === 'xcrun' && args.join(' ') === 'simctl bootstatus test-udid -b') {
-          return {
-            stdout: 'Monitoring boot status for iPhone 15 (test-udid).\n',
-            stderr: '',
-          } as any;
-        }
-        return { stdout: '', stderr: '' } as any;
-      }) as any);
-
-      await IosSimulatorUtils.startAsync({
-        deviceIdentifier: 'test-udid' as any,
-        env: process.env,
-      });
-
-      expect(mockedSpawn).not.toHaveBeenCalledWith(
-        'xcrun',
-        ['simctl', 'list', 'devices', '--json', '--no-escape-slashes', 'test-udid'],
-        expect.anything()
-      );
-      expect(mockedSpawn).not.toHaveBeenCalledWith('plutil', expect.anything(), expect.anything());
-    });
-  });
-
-  describe(IosSimulatorUtils.enableAccessibilitySettingsAsync, () => {
-    function device(overrides: Record<string, unknown> = {}) {
-      return {
-        dataPath: '/tmp/eas-test-simulator-data',
-        dataPathSize: 1,
-        logPath: '/tmp/eas-test-simulator-logs',
-        udid: 'test-udid',
-        isAvailable: true,
-        deviceTypeIdentifier: 'com.apple.CoreSimulator.SimDeviceType.iPhone-15',
-        state: 'Shutdown',
-        name: 'iPhone 15',
-        ...overrides,
-      };
-    }
-
-    function mockAvailableDevices(devices: Record<string, unknown>[]) {
-      mockedSpawn.mockImplementation((async (command: string, args: string[]) => {
-        if (
-          command === 'xcrun' &&
-          args.join(' ') === 'simctl list devices --json --no-escape-slashes available'
-        ) {
-          return {
-            stdout: JSON.stringify({
-              devices: {
-                'com.apple.CoreSimulator.SimRuntime.iOS-18-0': devices,
-              },
-            }),
-            stderr: '',
-          } as any;
-        }
-        return { stdout: '', stderr: '' } as any;
-      }) as any);
-    }
-
-    it('writes accessibility prefs for an exact shutdown simulator match', async () => {
-      mockAvailableDevices([
-        device({
-          udid: 'test-udid-pro',
-          name: 'iPhone 17 Pro',
-          dataPath: '/tmp/eas-test-simulator-data-pro',
-        }),
-        device({ name: 'iPhone 17' }),
-      ]);
-
-      await expect(
-        IosSimulatorUtils.enableAccessibilitySettingsAsync({
-          deviceIdentifier: 'iPhone 17' as any,
-          env: process.env,
-        })
-      ).resolves.toBeUndefined();
-
-      for (const key of [
-        'AutomationEnabled',
-        'IgnoreAXServerEntitlements',
-        'AccessibilityEnabled',
-        'ApplicationAccessibilityEnabled',
-      ]) {
-        expect(mockedSpawn).toHaveBeenCalledWith(
-          'plutil',
-          [
-            '-replace',
-            key,
-            '-bool',
-            'true',
-            '/tmp/eas-test-simulator-data/Library/Preferences/com.apple.Accessibility.plist',
-          ],
-          { env: process.env }
-        );
-      }
-    });
-
-    it('throws UserError when no available simulator exactly matches the identifier', async () => {
-      mockAvailableDevices([device({ name: 'iPhone 17 Pro' })]);
-
-      await expect(
-        IosSimulatorUtils.enableAccessibilitySettingsAsync({
-          deviceIdentifier: 'iPhone 17' as any,
-          env: process.env,
-        })
-      ).rejects.toThrow(UserError);
-
-      expect(mockedSpawn).not.toHaveBeenCalledWith('plutil', expect.anything(), expect.anything());
-    });
-
-    it('throws UserError when the matched simulator is already booted', async () => {
-      mockAvailableDevices([device({ state: 'Booted' })]);
-
-      await expect(
-        IosSimulatorUtils.enableAccessibilitySettingsAsync({
-          deviceIdentifier: 'test-udid' as any,
-          env: process.env,
-        })
-      ).rejects.toThrow(UserError);
-    });
-
-    it('throws SystemError when pre-boot accessibility setup fails', async () => {
-      mockedSpawn.mockRejectedValue(new Error('Failed to list simulators'));
-
-      await expect(
-        IosSimulatorUtils.enableAccessibilitySettingsAsync({
-          deviceIdentifier: 'test-udid' as any,
-          env: process.env,
-        })
-      ).rejects.toThrow(SystemError);
-    });
-  });
-
   describe(IosSimulatorUtils.waitForReadyAsync, () => {
     it('takes the readiness screenshot into a writable temp file, not /dev/null', async () => {
       await IosSimulatorUtils.waitForReadyAsync({
@@ -211,75 +43,7 @@ describe('IosSimulatorUtils', () => {
   });
 
   describe(IosSimulatorUtils.disableApsdAsync, () => {
-    it('disables and boots out apsd in the simulator foreground user domain', async () => {
-      mockedSpawn.mockImplementation((async (_command: string, args: string[]) => {
-        if (args.join(' ') === 'simctl spawn test-udid launchctl list com.apple.apsd') {
-          throw Object.assign(new Error('apsd not loaded'), { status: 113 });
-        }
-        return { stdout: '', stderr: '' } as any;
-      }) as any);
-
-      await IosSimulatorUtils.disableApsdAsync({
-        udid: 'test-udid' as any,
-        env: process.env,
-      });
-
-      expect(mockedSpawn).toHaveBeenCalledWith(
-        'xcrun',
-        ['simctl', 'spawn', 'test-udid', 'launchctl', 'disable', 'user/foreground/com.apple.apsd'],
-        { env: process.env }
-      );
-      expect(mockedSpawn).toHaveBeenCalledWith(
-        'xcrun',
-        ['simctl', 'spawn', 'test-udid', 'launchctl', 'bootout', 'user/foreground/com.apple.apsd'],
-        { env: process.env }
-      );
-      expect(mockedSpawn).toHaveBeenCalledWith(
-        'xcrun',
-        ['simctl', 'spawn', 'test-udid', 'launchctl', 'list', 'com.apple.apsd'],
-        { env: process.env }
-      );
-      expect(mockedSpawn).not.toHaveBeenCalledWith(
-        'xcrun',
-        ['simctl', 'spawn', 'test-udid', 'launchctl', 'disable', 'system/com.apple.apsd'],
-        { env: process.env }
-      );
-    });
-
-    it('succeeds when bootout fails after apsd is already stopped', async () => {
-      mockedSpawn.mockImplementation((async (_command: string, args: string[]) => {
-        if (
-          args.join(' ') ===
-          'simctl spawn test-udid launchctl bootout user/foreground/com.apple.apsd'
-        ) {
-          throw Object.assign(new Error('bootout failed'), { status: 3 });
-        }
-        if (args.join(' ') === 'simctl spawn test-udid launchctl list com.apple.apsd') {
-          throw Object.assign(new Error('apsd not loaded'), { status: 113 });
-        }
-        return { stdout: '', stderr: '' } as any;
-      }) as any);
-
-      await expect(
-        IosSimulatorUtils.disableApsdAsync({
-          udid: 'test-udid' as any,
-          env: process.env,
-        })
-      ).resolves.toBeUndefined();
-    });
-
-    it('falls back to the system domain when the foreground user domain keeps apsd running', async () => {
-      let listCount = 0;
-      mockedSpawn.mockImplementation((async (_command: string, args: string[]) => {
-        if (args.join(' ') === 'simctl spawn test-udid launchctl list com.apple.apsd') {
-          listCount += 1;
-          if (listCount === 2) {
-            throw Object.assign(new Error('apsd not loaded'), { status: 113 });
-          }
-        }
-        return { stdout: '', stderr: '' } as any;
-      }) as any);
-
+    it('disables and boots out apsd in the simulator', async () => {
       await IosSimulatorUtils.disableApsdAsync({
         udid: 'test-udid' as any,
         env: process.env,
@@ -290,19 +54,11 @@ describe('IosSimulatorUtils', () => {
         ['simctl', 'spawn', 'test-udid', 'launchctl', 'disable', 'system/com.apple.apsd'],
         { env: process.env }
       );
-    });
-
-    it('throws a SystemError when apsd is still running after all disable attempts', async () => {
-      mockedSpawn.mockImplementation((async () => {
-        return { stdout: '', stderr: '' } as any;
-      }) as any);
-
-      await expect(
-        IosSimulatorUtils.disableApsdAsync({
-          udid: 'test-udid' as any,
-          env: process.env,
-        })
-      ).rejects.toThrow(SystemError);
+      expect(mockedSpawn).toHaveBeenCalledWith(
+        'xcrun',
+        ['simctl', 'spawn', 'test-udid', 'launchctl', 'bootout', 'system/com.apple.apsd'],
+        { env: process.env }
+      );
     });
   });
 });

packages/build-tools/src/utils/__tests__/expoUpdates.test.ts

@@ -104,33 +104,4 @@ describe(expoUpdates.configureExpoUpdatesIfInstalledAsync, () => {
     expect(iosSetChannelNativelyAsync).toBeCalledTimes(1);
     expect(getExpoUpdatesPackageVersionIfInstalledAsync).toBeCalledTimes(1);
   });
-
-  it('does not fail on missing EAS_BUILD_ID when logging fingerprint diffs', async () => {
-    jest.mocked(getExpoUpdatesPackageVersionIfInstalledAsync).mockResolvedValue('0.18.0');
-
-    const warn = jest.fn();
-    const managedCtx: BuildContext<BuildJob> = {
-      appConfig: {},
-      env: {},
-      job: {
-        platform: Platform.IOS,
-      },
-      logger: { warn },
-      metadata: {
-        runtimeVersion: 'runtime-version-from-local-machine',
-      },
-      getReactNativeProjectDirectory: () => '/app',
-    } as any;
-
-    await expect(
-      expoUpdates.configureExpoUpdatesIfInstalledAsync(managedCtx, {
-        resolvedRuntimeVersion: 'runtime-version-from-eas-build',
-        resolvedFingerprintSources: [],
-      })
-    ).rejects.toThrow(
-      'Runtime version calculated on local machine not equal to runtime version calculated during build.'
-    );
-
-    expect(warn).toHaveBeenCalledWith('Skipping fingerprint diff because EAS_BUILD_ID is not set');
-  });
 });

packages/build-tools/src/utils/__tests__/expoUpdatesEmbedded.test.ts

@@ -32,7 +32,6 @@ function zipEntryMap(entries: Record<string, true>): Record<string, { name: stri
 function makeCtx(overrides: {
   platform: Platform;
   simulator?: boolean;
-  developmentClient?: boolean;
   channel?: string;
   env?: Record<string, string>;
 }): BuildContext<any> {
@@ -41,12 +40,10 @@ function makeCtx(overrides: {
       ? {
           platform: Platform.IOS,
           simulator: overrides.simulator ?? false,
-          developmentClient: overrides.developmentClient ?? false,
           updates: overrides.channel ? { channel: overrides.channel } : undefined,
         }
       : {
           platform: Platform.ANDROID,
-          developmentClient: overrides.developmentClient ?? false,
           updates: overrides.channel ? { channel: overrides.channel } : undefined,
         };
 
@@ -195,20 +192,6 @@ describe('uploadEmbeddedBundleAsync', () => {
     expect(artifacts.findArtifacts).not.toHaveBeenCalled();
   });
 
-  it('skips development client builds', async () => {
-    const ctx = makeCtx({
-      platform: Platform.ANDROID,
-      developmentClient: true,
-      channel: 'development',
-    });
-
-    await uploadEmbeddedBundleAsync(ctx);
-
-    expect(ctx.markBuildPhaseSkipped).toHaveBeenCalled();
-    expect(ctx.markBuildPhaseHasWarnings).not.toHaveBeenCalled();
-    expect(artifacts.findArtifacts).not.toHaveBeenCalled();
-  });
-
   it('warns when bundle or manifest is missing from the archive', async () => {
     jest.mocked(artifacts.findArtifacts).mockResolvedValue(['/tmp/app-release.apk']);
     mockZipEntries.mockResolvedValue(

packages/build-tools/src/utils/__tests__/hookMetrics.test.ts

@@ -1,39 +0,0 @@
-import { Datadog } from '../../datadog';
-import { reportWorkflowHookMetricToDatadog } from '../hookMetrics';
-
-describe(reportWorkflowHookMetricToDatadog, () => {
-  const distributionSpy = jest.spyOn(Datadog, 'distribution').mockImplementation(() => {});
-
-  beforeEach(() => {
-    distributionSpy.mockClear();
-  });
-
-  it('emits one eas.workflow.hook distribution tagged by anchor/timing/result', () => {
-    reportWorkflowHookMetricToDatadog({
-      anchor: 'install_node_modules',
-      timing: 'before',
-      result: 'success',
-    });
-    expect(distributionSpy).toHaveBeenCalledTimes(1);
-    expect(distributionSpy).toHaveBeenCalledWith('eas.workflow.hook', 1, {
-      anchor: 'install_node_modules',
-      timing: 'before',
-      result: 'success',
-    });
-  });
-
-  it('adds the anchor_result tag on after events', () => {
-    reportWorkflowHookMetricToDatadog({
-      anchor: 'submit',
-      timing: 'after',
-      result: 'failed',
-      anchorResult: 'failed',
-    });
-    expect(distributionSpy).toHaveBeenCalledWith('eas.workflow.hook', 1, {
-      anchor: 'submit',
-      timing: 'after',
-      result: 'failed',
-      anchor_result: 'failed',
-    });
-  });
-});