address PR feedback

packages/eas-cli/src/build/__tests__/metadata-test.ts

@@ -0,0 +1,40 @@
+import { instance, mock, when } from 'ts-mockito';
+
+import { Client } from '../../vcs/vcs';
+import { getFormattedCommitMessageAsync } from '../metadata';
+
+describe(getFormattedCommitMessageAsync, () => {
+  it(`returns undefined if it's not a git project`, async () => {
+    const clientMock = mock<Client>();
+    when(clientMock.getLastCommitMessageAsync()).thenResolve(null);
+    const client = instance(clientMock);
+
+    await expect(getFormattedCommitMessageAsync(client)).resolves.toBe(undefined);
+  });
+
+  it('returns commit message', async () => {
+    const clientMock = mock<Client>();
+    when(clientMock.getLastCommitMessageAsync()).thenResolve('lorem ipsum');
+    const client = instance(clientMock);
+
+    await expect(getFormattedCommitMessageAsync(client)).resolves.toBe('lorem ipsum');
+  });
+
+  it('trims long commit messages', async () => {
+    const clientMock = mock<Client>();
+    when(clientMock.getLastCommitMessageAsync()).thenResolve('a'.repeat(1500));
+    const client = instance(clientMock);
+
+    await expect(getFormattedCommitMessageAsync(client)).resolves.toBe(`${'a'.repeat(1021)}...`);
+  });
+
+  it('replaces new lines with spaces', async () => {
+    const clientMock = mock<Client>();
+    when(clientMock.getLastCommitMessageAsync()).thenResolve(`Lorem\nipsum\ndolor\nsit\namet`);
+    const client = instance(clientMock);
+
+    await expect(getFormattedCommitMessageAsync(client)).resolves.toBe(
+      `Lorem ipsum dolor sit amet`
+    );
+  });
+});

packages/eas-cli/src/build/metadata.ts

@@ -17,6 +17,7 @@ import {
 import { ensureLoggedInAsync } from '../user/actions';
 import { easCliVersion } from '../utils/easCli';
 import { getVcsClient } from '../vcs';
+import { Client } from '../vcs/vcs';
 import { maybeResolveVersionsAsync as maybeResolveAndroidVersionsAsync } from './android/version';
 import { BuildContext } from './context';
 import { maybeResolveVersionsAsync as maybeResolveIosVersionsAsync } from './ios/version';
@@ -29,6 +30,8 @@ export async function collectMetadataAsync<T extends Platform>(
     ('simulator' in ctx.buildProfile && ctx.buildProfile.simulator
       ? 'simulator'
       : ctx.buildProfile.distribution) ?? 'store';
+
+  const vcsClient = getVcsClient();
   const metadata: Metadata = {
     trackingContext: ctx.trackingCtx,
     ...(await maybeResolveVersionsAsync(ctx)),
@@ -43,10 +46,10 @@ export async function collectMetadataAsync<T extends Platform>(
     appName: ctx.exp.name,
     appIdentifier: resolveAppIdentifier(ctx),
     buildProfile: ctx.buildProfileName,
-    gitCommitHash: await getVcsClient().getCommitHashAsync(),
-    isGitWorkingTreeDirty: await getVcsClient().hasUncommittedChangesAsync(),
+    gitCommitHash: await vcsClient.getCommitHashAsync(),
+    isGitWorkingTreeDirty: await vcsClient.hasUncommittedChangesAsync(),
     username: getUsername(ctx.exp, await ensureLoggedInAsync()),
-    message: ctx.message,
+    message: ctx.message ?? (await getFormattedCommitMessageAsync(vcsClient)),
     ...(ctx.platform === Platform.IOS && {
       iosEnterpriseProvisioning: resolveIosEnterpriseProvisioning(
         ctx as BuildContext<Platform.IOS>
@@ -146,3 +149,16 @@ function resolveIosEnterpriseProvisioning(
 ): IosEnterpriseProvisioning | undefined {
   return ctx.buildProfile.enterpriseProvisioning;
 }
+
+export async function getFormattedCommitMessageAsync(
+  vcsClient: Client
+): Promise<string | undefined> {
+  const maybeCommitMessage = (await vcsClient.getLastCommitMessageAsync())?.trim();
+  if (!maybeCommitMessage) {
+    return undefined;
+  }
+  const lines = maybeCommitMessage.split('\n');
+  const withoutEmptyLines = lines.filter(i => i);
+  const message = withoutEmptyLines.join(' ');
+  return message.length > 1024 ? message.substring(0, 1021) + '...' : message;
+}