Compare commits

..
Author SHA1 Message Date
Brent Vatne 29ce5dea3c CLI: report long commands' status to the terminal with OSC 7501
capture, capture:baseline, explore:binary, explore:session, report:upload
and doctor --capture tell a terminal that supports OSC 7501 whether they
are working (with the latest progress line), waiting on a yes/no, done or
failed, so a tab left in the background shows it. A failing exit code
reports an error, and a local review names the targets with no report.
Ctrl+C clears the status.

Only an interactive stderr gets the sequence: not a pipe, CI, TERM=dumb
or --json. Messages are redacted as stderr's diagnostics are, since the
terminal keeps a done or error record after the process exits;
environmentSecrets now also matches *_PRIVATE_KEY, as reportCiError does.

Spec: https://superlogical.com/rex/docs/build/program-status
2026-10-24 20:07:40 -07:00
Daehyeon MunandClaude Opus 5.5 90d5d52dab Viewer: Compare's Split centres each frame under its name in WebKit
WebKit sized each Split side by the stage's available width instead of the
frame's height × aspect-ratio width, so on a folded iPhone Duo (Safari and
Chrome alike) each side stayed half the stage and its frame sat at the left,
off centre under Before/After. The frame's width is now spelled out from its
height and aspect, so every engine shrinks the side to the frame.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-24 14:57:52 +07:00
Brent Vatne 7fa07d2cc0 PR template: ask for code examples, and something reviewers can try (#75) 2026-10-23 21:58:50 -07:00
Brent Vatne 6ad0d89c1f Release 0.22.1 (#73) 2026-10-23 18:00:07 -07:00
Brent Vatne fbe12fea58 Workflows: the launch decoder's time limit kills a hung apt-get (#72) 2026-10-23 17:56:30 -07:00
Brent Vatne ac30f4d691 Hosted repack: share a run's repack by native fingerprint, not by the build each job found (#71) 2026-10-23 17:56:25 -07:00
Brent Vatne af8796c749 Release 0.22.0 (#70) 2026-10-23 16:50:57 -07:00
Brent Vatne 51319403bb README: Screens picture and caption with the filmstrip, and capture timings (#69) 2026-10-23 16:48:09 -07:00
Brent Vatne eaba870ac9 CI capture: timings per job, and a review waiting on a baseline says what it is doing (#68) 2026-10-23 16:47:59 -07:00
Brent Vatne 40f53e026a Filmstrip: swipe with the gesture, the Inspector from the middle screen, centring, faded edges, and on a phone (#67) 2026-10-23 16:37:22 -07:00
27 changed files with 696 additions and 101 deletions

No files matched your search

+28
View File
@@ -16,6 +16,34 @@ Write "No visible change" if there is none.
| --- | --- |
| | |
## Code examples
<!--
Required for any change to how Explore is used or what it writes: a CLI command or flag,
config.yaml, a workflow template, a file format (a replay or flows file, report JSON), or a
public type. Show it in use as a reader would write it: the command with its flags, the config
or file it reads, and what it prints or writes, trimmed to the lines that matter. When existing
usage changes, show it before and after.
Write "No change to usage" if there is none.
-->
```sh
```
## Try it
<!--
Optional, but recommended: something a reviewer can open or run to see the change for themselves.
- A Viewer change: the Viewer preview comment on this PR links a live build. Name the report,
screen and steps to look at.
- A capture or report change: a hosted report from a run of this branch (explore:binary,
explore:session or capture with --upload), or an app pull request whose review ran this branch.
- Otherwise: the commands that run it from a checkout of this branch, for example
`npm ci && npm run build`, then `node dist/cli.js <command>`, with any app or file it needs.
Write "Nothing to try" if there is nothing a reviewer could run.
-->
## Testing
<!-- What you ran and what you checked by hand. -->
+4 -4
View File
@@ -153,10 +153,10 @@ Each new start logs the failed run's link and reason, for example `the hosted EA
1. `hostedRepackPeers` lists, in config order, the targets that repack the same app on EAS: one platform, EAS profile and bundle id. `capture:review`, `capture:review --compare` and `capture:baseline` pass them on.
- A capture gets a `RepackShare` when it has two or more peers and `GITHUB_RUN_ID`, `GITHUB_RUN_ATTEMPT` and `GITHUB_REPOSITORY` are set. Its scope is the run attempt, its leader is the first peer, and its rank is its place among the peers.
- A single target, a local review, `capture.repack: local`, and a native build this job made itself behave as before. Nobody else's key can match a native build this job made.
2. The build to repack is the newest finished build with the fingerprint that Explore did not repack itself (`existingBuild`, from 20 builds). If repacks carry their source's fingerprint, every job still picks the same build.
- A single target, a local review, `capture.repack: local`, and a native build this job made itself behave as before. The repack of a native build this job made carries no key, so it is never shared.
2. The build to repack is the newest finished build with the fingerprint that Explore did not repack itself (`existingBuild`, from 20 builds), else the newest repack. On a project that reviews often, the 20 are all repacks (euxy's 50 most recent `explore` builds were), so jobs that start minutes apart can pick different builds; the key below names the native code, not the build, so they still share.
3. Once the copy is staged, the capture takes a key (`hostedRepackShareKey`) from:
- the run attempt, the platform and the native build id;
- the run attempt, the platform and the native fingerprint;
- the EAS profile and environment name;
- a snapshot of the environment's variables: `eas env:list --format long` for the project and the account, which names each variable with its value (masked when sensitive or secret) and when it was last updated;
- the Explore release;
@@ -168,7 +168,7 @@ Each new start logs the failed run's link and reason, for example `the hosted EA
6. When the repack it follows fails, is cancelled or loses the key, the capture looks for another with the same key for 60 s, staggered the same way, before it repacks itself. That catches the leader's retry, which starts at once (#176).
7. It also repacks itself, with the retries above, when nothing appears in its wait, or when EAS fails to answer three times in a row. Looking stops while the budget still has 5 minutes for a repack of its own. A followed repack that does not finish within the budget fails the target. No capture waits on a job that cannot answer, and none waits past its budget.
Only a build whose marker is this capture's own key is used, and every input to the key is what this capture would itself have uploaded and built with. So two jobs share a repack only when their uploads, native build, profile, environment variables and Explore release are the same, in the same run attempt. The run attempt is in the scope, and a review's or a first attempt's repacks are never used by another run or attempt. That covers the baseline workflow, whose artifacts later reviews reuse, and "Re-run failed jobs" after an `EXPO_PUBLIC_*` value was fixed, which rebundles with the new value.
Only a build whose marker is this capture's own key is used, and every input to the key but one is what this capture would itself have uploaded and built with. So two jobs share a repack only when their uploads, native fingerprint, profile, environment variables and Explore release are the same, in the same run attempt. The one input that is not this capture's own is the source build: a follower runs the leader's repack of the build the leader found, which has the same fingerprint as its own but may be another build of it. `existingBuild` already treats builds of one fingerprint as interchangeable; what a repack keeps from its source beyond the native code the fingerprint covers (its Info.plist, and the toolchain it was built with) can differ between such builds. The run attempt is in the scope, and a review's or a first attempt's repacks are never used by another run or attempt. That covers the baseline workflow, whose artifacts later reviews reuse, and "Re-run failed jobs" after an `EXPO_PUBLIC_*` value was fixed, which rebundles with the new value.
What the key does not protect against: every input to it is public or predictable, and the pull request's head code runs in the capture job with `EXPO_TOKEN` (`app.config.*` under `eas config` and `eas fingerprint:generate`, and the app's build code on EAS). Head code could therefore make a build whose message carries the base side's marker, and base captures of the same run attempt in other matrix jobs would install it. That is within the trust the capture already gives EAS: the same credentials could publish a simulator build with a reused fingerprint, which every capture already reuses by fingerprint (the `build` stage above), and head code in one job can already tamper with that job's own base side on the runner. The run attempt in the scope keeps such a build out of every other run, including the baseline. Requiring the build's `initiatingActor` to be this job's own credentials would not exclude head code, which runs with the same token. Explore cannot tell offline which actor EAS records for a workflow's repack build, so it does not check it.
+4 -3
View File
@@ -22,10 +22,10 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
<a href="docs/screenshots/readme-screens-light.png">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-screens-dark.png">
<img width="100%" alt="The Screens view of a euxy review showing Changed 7 of All 19: the app/ route tree on the left, and beside it a grid of the changed screens in the same order, each with its route below the screenshot: a red dot for the removed /lane-editor, orange for the modified /new-pattern and /channel-surf, green for the new /lane-editor/0, and Changed in dark under /p and /patterns" src="docs/screenshots/readme-screens-light.png">
<img width="100%" alt="The Screens view of a euxy review showing Changed 7 of All 19: a Search field and the app/ route tree on the left, and beside it a grid of the changed screens in the same order, each with its route below the screenshot: a red dot for the removed /lane-editor, orange for the modified /new-pattern and /channel-surf, green for the new /lane-editor/0, and Changed in dark under /p, /patterns and a /p/ link; at the top right, a switch between Grid and Filmstrip" src="docs/screenshots/readme-screens-light.png">
</picture>
</a>
<strong>Screens</strong>: every capture in one grid, or only the changed ones, beside the route tree, with a dot for what changed.
<strong>Screens</strong>: every capture, or only the changed ones, in a grid or one at a time in a filmstrip, beside the route tree, with a dot for what changed.
</td>
<td width="50%" valign="top">
<a href="docs/screenshots/readme-pr-comment-light.png">
@@ -155,7 +155,7 @@ npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all --upload
- Your checkout, index and branches are never touched. Your uncommitted changes, untracked files included, are reviewed as `eas build` would upload them; `--committed`, or `cli.requireCommit: true` in `eas.json`, leaves them out.
- Installs run without credential environment variables, which keeps tokens out of reach of a registry a commit's `.npmrc` names; that is not a sandbox. A registry that needs `${NPM_TOKEN}` in the project's `.npmrc` must be authenticated in your own `~/.npmrc`.
- Captures are cached in `~/.cache/expo-explore`, so the same base is not captured twice (`--no-cache` skips it); a capture unused for 30 days goes, and the cache stays under 2 GB. Ctrl+C stops the run's simulator sessions and local devices; when a run is stopped harder than that, the next local run stops what it left running.
- Like a CI review, it builds on EAS (reusing a matching build) and, unless it captures on a local simulator, runs EAS Simulator sessions: expect several minutes and EAS usage.
- Like a CI review, it builds on EAS (reusing a matching build) and, unless it captures on a local simulator, runs EAS Simulator sessions: expect several minutes and EAS usage. A terminal that supports [OSC 7501](https://superlogical.com/rex/docs/build/program-status) shows whether the run is working, done or failed while you are in another tab; `explore:binary`, `report:upload` and `doctor --capture` report it too.
- Saved runs take up to 2 GB in all, the oldest going first. `reports add <report.zip>` keeps a report you downloaded, such as a PR's `explore-review` artifact.
</details>
@@ -579,6 +579,7 @@ sequenceDiagram
- The review workflow runs on open, non-draft PRs from the repository whose author has write access. Bots such as Devin go under `ci.trustedAuthors` in `.expo-explore/config.yaml`.
- A screen with a source change is **Modified** if its captures differ.
- If EAS fails to start a session, Explore starts a new one, up to five times within 30 minutes. On your machine, a local simulator can stand in for EAS Simulator.
- Each capture job's summary shows where its time went, phase by phase, and its diagnostics artifact keeps the timings (`timings.jsonl`). When a review waits for the baseline of its base commit, its log and the PR comment name the step that baseline job is in.
The same review runs for any two commits without a PR ([`explore-compare.yml`](#compare-any-two-commits), linking the report from the run summary) and on your machine (`capture`, [above](#quick-start)). The workflows' logic lives in `expo-explore ci:*` commands, so a fix reaches CI with the `@expo/explore` version the workflows pin.
Binary file not shown.

Before

Width:  |  Height:  |  Size: 315 KiB

After

Width:  |  Height:  |  Size: 324 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 316 KiB

After

Width:  |  Height:  |  Size: 326 KiB

+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "@expo/explore",
"version": "0.21.0",
"version": "0.22.1",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@expo/explore",
"version": "0.21.0",
"version": "0.22.1",
"license": "MIT",
"dependencies": {
"@expo/repack-app": "0.10.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/explore",
"version": "0.21.0",
"version": "0.22.1",
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
"license": "MIT",
"type": "module",
+17 -10
View File
@@ -119,9 +119,9 @@ const EXPLORE_REPACK_MESSAGE = /^expo-explore (?:ios|android) capture: route obs
/**
* The finished build to repack from `eas build:list --fingerprint-hash`: the newest one Explore did not repack itself,
* else the newest. A repack keeps its source build's native code, and may carry its fingerprint; preferring the build
* it came from has every job of a run pick the same one, which a shared repack's key needs (RepackShare), instead of a
* repack another job finished a minute earlier.
* else the newest. A repack keeps its source build's native code and carries its fingerprint, so on a project that
* reviews often every listed build is a repack, and this is the newest of them; jobs that look minutes apart can get
* different ones. A shared repack is keyed by the fingerprint, not by this build (hostedRepackShareKey).
*/
export function existingBuild(stdout: string): EasBuildDescriptor | undefined {
const value = parseJson(stdout, "eas build:list");
@@ -712,13 +712,18 @@ export async function stagedProjectDigest(root: string): Promise<string> {
/**
* The key a shared repack's build carries in its message: everything the repack is made from, so two jobs share one only
* when each would have uploaded the same bytes for the same native build, profile, EAS environment (by name and by a
* snapshot of its variables) and Explore release, in the same run attempt.
* when each would have uploaded the same bytes onto the same native code, for the same profile, EAS environment (by name
* and by a snapshot of its variables) and Explore release, in the same run attempt.
*
* The native code is named by its fingerprint, not by the build a job found to repack: the build lookup returns the
* newest build with that fingerprint, which is often an earlier repack, and it moves as repacks finish. In
* brentvatne/euxy#179 (review run 40042718931) a target that started late found the repack the others had just made,
* so its key matched none; it waited 3 minutes for a repack it could not find, then made another.
*/
export function hostedRepackShareKey(input: { scope: string; platform: "ios" | "android"; nativeBuildId: string; easProfile: string;
export function hostedRepackShareKey(input: { scope: string; platform: "ios" | "android"; fingerprint: string; easProfile: string;
environment: string; environmentVariables: string; project: string }): string {
return createHash("sha256").update(JSON.stringify({ contract: "expo-explore.repack-share.v2", explore: EXPLORE_VERSION, scope: input.scope,
platform: input.platform, nativeBuildId: input.nativeBuildId, easProfile: input.easProfile, environment: input.environment,
return createHash("sha256").update(JSON.stringify({ contract: "expo-explore.repack-share.v3", explore: EXPLORE_VERSION, scope: input.scope,
platform: input.platform, fingerprint: input.fingerprint, easProfile: input.easProfile, environment: input.environment,
environmentVariables: input.environmentVariables, project: input.project })).digest("hex").slice(0, 32);
}
@@ -870,6 +875,8 @@ async function prepareHostedRepack(options: {
easCommand: string;
project: string;
nativeBuildId: string;
/** The native fingerprint of that build, which keys a shared repack (hostedRepackShareKey). */
fingerprint: string;
easProfile: string;
repackProfile: RepackProfile;
easEnvironment: NodeJS.ProcessEnv;
@@ -930,7 +937,7 @@ async function prepareHostedRepack(options: {
if (variables === undefined) options.say(`EAS did not list the ${environment} environment's variables; repacking here without sharing the repack`);
else {
// The digest is taken before the workflow file is written: the file's message carries the key made from it.
const marker = hostedRepackShareMarker(hostedRepackShareKey({ scope: options.share.scope, platform, nativeBuildId: options.nativeBuildId,
const marker = hostedRepackShareMarker(hostedRepackShareKey({ scope: options.share.scope, platform, fingerprint: options.fingerprint,
easProfile: options.easProfile, environment, environmentVariables: variables, project: await stagedProjectDigest(staged) }));
const shared = await options.timings.measure("repack-share-wait", () => sharedHostedRepack({ share: options.share!, marker, platform, say: options.say, clock,
list: () => eas(["build:list", "--platform", platform, "--limit", String(SHARED_REPACK_LIST_LIMIT), "--json", "--non-interactive"], 2 * 60_000).stdout,
@@ -1012,7 +1019,7 @@ export async function prepareExactSourceBuild(options: {
if ((options.repack ?? "eas") === "eas") {
if (!options.easProfile) throw new Error("The hosted repack needs the capture build profile name.");
const hosted = await prepareHostedRepack({ platform, runner: options.runner, easCommand: options.easCommand, project: options.project,
nativeBuildId: options.nativeBuildId, easProfile: options.easProfile, repackProfile: options.repackProfile,
nativeBuildId: options.nativeBuildId, fingerprint: options.fingerprint, easProfile: options.easProfile, repackProfile: options.repackProfile,
easEnvironment: options.easEnvironment, restrictedEnvironment: options.repackEnvironment, provider: providers[0]!,
parameterKeys: captureObserverParameterKeys(options.routes), root, share: options.share, say: options.progress ?? (() => undefined),
timings: options.timings ?? silentTimings, onBlocking: options.onBlocking,
+1 -1
View File
@@ -608,7 +608,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
type BuiltApp = { fingerprint: string; nativeEasBuildId: string | null; easBuildId: string | null; app?: string; reused: boolean; version?: string; buildNumber?: string };
// What a hosted repack waits with and reports through: one deadline from the moment the session starts beside it, for
// the wait for another job's repack and every repack of its own. The repack is shared with this run's other matrix
// jobs only when it repacks a build EAS already had: a native build this job made is its own, so nobody else's key matches it.
// jobs only when it repacks a build EAS already had: a native build this job made is its own, so its repack carries no key and is never shared.
const repackWaits = (shared: boolean) => ({ ...(shared ? { share: options.repackShare } : {}), progress: say, now: options.now, sleep: options.sleep, timings, onBlocking: options.onBlocking,
signal: options.signal, deadline: (options.now ?? Date.now)() + HOSTED_REPACK_BUDGET_MS });
// `repacking` tells the captures sharing this build that their sessions can start too (sharedBuild).
+11
View File
@@ -5,6 +5,7 @@ import { resolve } from "node:path";
import { ExploreStore } from "./map/store.js";
import { QUERY_CONTRACT } from "./types.js";
import { EXPLORE_VERSION } from "./shared/package-paths.js";
import { enableProgramStatus, lastReportedStatus, reportFinished, reportStatus } from "./shared/program-status.js";
import { isTargetId } from "./config/explore-config.js";
import { command, resultContract, argumentError, validateCommandArguments, flag, has, setStore } from "./cli/args.js";
import { help } from "./cli/help.js";
@@ -69,6 +70,11 @@ const handlers: Record<string, () => Promise<void> | void> = {
/** Commands people type at a terminal; everything else answers agents and scripts in JSON. */
const HUMAN_COMMANDS = new Set(["setup", "doctor", "view", "help", "explore:binary", "explore:session", "report:upload", "reports"]);
/** Commands that run for minutes, so the terminal hears whether they are working, done or failed (see program-status). */
const LONG_COMMANDS = new Set(["capture:review", "capture:baseline", "explore:binary", "explore:session", "report:upload"]);
/** Stopped with Ctrl+C at the terminal: the person already knows, so the status is cleared rather than left as an error. */
const CANCELLED = new Set(["LOCAL_REVIEW_INTERRUPTED", "CAPTURE_CANCELLED"]);
function version(): void {
console.log(EXPLORE_VERSION);
}
@@ -77,10 +83,15 @@ try {
const handler = handlers[command];
if (!handler) argumentError(`Unknown command: ${command}`, undefined, "Run expo-explore help and choose a supported command.");
validateCommandArguments();
// Not with --json: under a pseudo-terminal the sequence would share a line with the JSON an agent parses.
if ((LONG_COMMANDS.has(command) || (command === "doctor" && has("capture"))) && !has("json")) { enableProgramStatus(); reportStatus("working"); }
const workspace = resolve(process.cwd(), flag("dir") ?? ".explore");
setStore(new ExploreStore(workspace));
await handler();
if (lastReportedStatus() === "working") reportFinished();
} catch (error) {
if (error instanceof CiError && CANCELLED.has(error.code)) reportStatus("clear");
else reportStatus("error", { message: error instanceof Error ? error.message : String(error) });
if (command.startsWith("capture:") || command.startsWith("source:") || command.startsWith("ci:") || command.startsWith("config:")) {
// The failure comment names the target from this: a capture, report or publication of one matrix target.
const target = (() => { try { return flag("target"); } catch { return undefined; } })();
+5 -2
View File
@@ -8,6 +8,7 @@ import { keepReports } from "./report-commands.js";
import { warnIgnoredExpiry } from "../config/explore-config.js";
import { argumentError, flag, flags, has, nonNegativeInteger, oneOf, output, positional, positiveInteger } from "./args.js";
import { readReplayPlan } from "../binary/replay.js";
import { reportFinished, reportStatus } from "../shared/program-status.js";
/** `--alias NAME` plus a fixed token from EXPLORE_PREVIEW_TOKEN: the hosted link stays the same from one run to the next (validated by the deploy). */
@@ -37,7 +38,7 @@ export async function exploreBinary(): Promise<void> {
const upload = simulator === "local" ? has("upload") : !has("no-upload");
const port = flag("port") === undefined ? undefined : nonNegativeInteger("port");
const started = Date.now();
const say = (message: string) => { process.stderr.write(`[explore ${Math.round((Date.now() - started) / 1000)}s] ${message}\n`); };
const say = (message: string) => { reportStatus("working", { message }); process.stderr.write(`[explore ${Math.round((Date.now() - started) / 1000)}s] ${message}\n`); };
const allowDestructive = flags("allow-destructive").flatMap(value => value.split(",")).map(value => value.trim()).filter(Boolean);
if (upload) await assertHostingExport();
const result = await runBinaryExploration({
@@ -77,6 +78,7 @@ export async function exploreBinary(): Promise<void> {
if (simulator === "eas" || hosted || has("no-open")) { console.log(`Next: ${summary.next.join(" | ")}`); return; }
const viewer = await startViewerServer({ root: outputDirectory, ...(port === undefined ? {} : { port }) });
console.log(`Viewer: ${viewer.url} (Ctrl+C to stop)`);
reportFinished();
openViewerInBrowser(viewer.url);
await waitForViewerShutdown(viewer);
}
@@ -100,7 +102,7 @@ export async function exploreSession(): Promise<void> {
const controller = flag("controller") === undefined ? undefined : oneOf("controller", ["agent-device", "argent"] as const);
const port = flag("port") === undefined ? undefined : nonNegativeInteger("port");
const started = Date.now();
const say = (message: string) => { process.stderr.write(`[explore ${Math.round((Date.now() - started) / 1000)}s] ${message}\n`); };
const say = (message: string) => { reportStatus("working", { message }); process.stderr.write(`[explore ${Math.round((Date.now() - started) / 1000)}s] ${message}\n`); };
const allowDestructive = flags("allow-destructive").flatMap(value => value.split(",")).map(value => value.trim()).filter(Boolean);
const envFile = await defaultSessionEnvFile(flag("env-file"));
if (has("upload")) await assertHostingExport();
@@ -140,6 +142,7 @@ export async function exploreSession(): Promise<void> {
if (hosted || has("no-open")) { console.log(`Next: ${summary.next.join(" | ")}`); return; }
const viewer = await startViewerServer({ root: outputDirectory, ...(port === undefined ? {} : { port }) });
console.log(`Viewer: ${viewer.url} (Ctrl+C to stop)`);
reportFinished();
openViewerInBrowser(viewer.url);
await waitForViewerShutdown(viewer);
}
+9 -1
View File
@@ -21,6 +21,7 @@ import { help } from "./help.js";
import { CiError } from "../shared/ci-errors.js";
import { cleanupAfterCapture, findOptionalBaseline, resolveCompareRefs, resolvePullRequest, writeCaptureOutputs, writeStepOutputs } from "../ci/workflow-steps.js";
import { stderrProgress } from "../shared/progress.js";
import { reportFinished, reportStatus } from "../shared/program-status.js";
import { appendTimingsSummary, timingsPathFor } from "../shared/timings.js";
import { maxParallelTargets } from "../ci/session-plan.js";
@@ -47,10 +48,12 @@ Fix the problems in steps 1–5 before a capture check.`);
}
if (!has("yes")) {
if (!process.stdin.isTTY || has("json")) argumentError("A capture check starts an EAS build and simulator session; pass --yes to confirm.", "yes");
reportStatus("blocked", { kind: "question", message: "Start a capture check on EAS?" });
const terminal = createInterface({ input: process.stdin, output: process.stderr });
const answer = await terminal.question(`This builds the app on EAS and runs an EAS Simulator session (EAS usage applies${report.mode === "agent" ? "; agent mode also uses your model API key or local claude/codex login" : ""}). Continue? (yes/no) `);
terminal.close();
if (!/^(y|yes)$/i.test(answer.trim())) return;
if (!/^(y|yes)$/i.test(answer.trim())) { reportStatus("clear"); return; }
reportStatus("working");
}
let result: Awaited<ReturnType<typeof runCaptureCheck>>;
try {
@@ -310,6 +313,8 @@ async function localReview(): Promise<void> {
}
// A target that failed outright has no report; the others still open, save and upload, and the command exits 1.
if (result.failures.length) process.exitCode = 1;
// The terminal keeps this record after the run, so it names what failed rather than what was open.
const finished = () => reportFinished(result.failures.length ? `No report for ${result.failures.map(({ target }) => target.id).join(", ")}` : undefined);
const summary = { ok: result.failures.length === 0, runId: result.runId, base: result.base, head: result.head,
...(result.failures.length ? { failures: result.failures.map(({ target, error }) => ({ target: target.id, code: error.code, message: error.message })) } : {}),
reports: result.reports.map(({ platform, target, directory, zip, changes, device }) => ({ platform, target: target.id, label: target.label, directory, zip,
@@ -331,15 +336,18 @@ async function localReview(): Promise<void> {
if (has("json")) output({ ...summary, ...(copied ? {} : { reports: summary.reports.map(({ directory: _directory, zip: _zip, ...report }) => report) }),
url: hosted.previewUrl, expiresAt: hosted.expiresAt });
else console.log(`Report: ${hosted.previewUrl}${hosted.expiresAt ? ` (until ${hosted.expiresAt.slice(0, 10)})` : ""}`);
finished();
return;
}
if (has("json") || has("no-open")) {
if (has("json")) output(summary);
else for (const report of result.reports) console.log(`${report.target.id}: ${report.zip}`);
finished();
return;
}
const server = await startLocalReportServer({ reports: zips, ...(has("port") ? { port: nonNegativeInteger("port") } : {}) });
console.log(`Viewer: ${server.url} (Ctrl+C to stop)`);
finished();
if (saved) console.log(`Saved as ${saved.id}: expo-explore reports reopens it, and reports upload ${saved.id} hosts it.`);
openViewerInBrowser(server.url);
await new Promise<void>(done => { process.once("SIGINT", () => done()); process.once("SIGTERM", () => done()); });
+1 -1
View File
@@ -57,7 +57,7 @@ export type CiErrorRenderOptions = { secrets?: readonly string[] };
/** The values of every variable that names a secret (a token, secret, password or API key), to redact from what Explore writes. */
export function environmentSecrets(environment: NodeJS.ProcessEnv): string[] {
return Object.entries(environment).filter(([key]) => /(?:TOKEN|SECRET|PASSWORD|API_KEY)/i.test(key)).flatMap(([, value]) => value ? [value] : []);
return Object.entries(environment).filter(([key]) => /(?:TOKEN|SECRET|PASSWORD|API_KEY|PRIVATE_KEY)/i.test(key)).flatMap(([, value]) => value ? [value] : []);
}
/** Redacts secret values, bearer and provider tokens, credentials in URLs, and signed-URL parameters from any text Explore writes. */
+63
View File
@@ -0,0 +1,63 @@
import { environmentSecrets, redactSecrets } from "./ci-errors.js";
/**
* Tells the terminal what a long command is doing with OSC 7501
* (https://superlogical.com/rex/docs/build/program-status), so a tab left in the background can show that a review is
* working, waiting on an answer, done or failed. Only an interactive stderr gets the sequence; a terminal that does not
* know it ignores it, as it does any unknown OSC (ECMA-48 §8.3.89). The spec's feature query is not sent: reading its
* reply would put stdin in raw mode under the command's own prompts.
*
* The terminal drops a `working` or `blocked` record when the process exits and keeps `done` and `error`, so an exit
* without a final report (a second Ctrl+C) leaves nothing behind.
*/
export type ProgramState = "working" | "blocked" | "done" | "error" | "clear";
export type BlockedKind = "permission" | "question" | "auth";
const APP = "expo-explore";
/** The spec allows 2048 bytes of decoded `msg`; 512 code points stay under it in any script. */
const MESSAGE_LIMIT = 512;
let write: ((text: string) => void) | undefined;
let last: ProgramState | undefined;
/**
* A message is redacted as stderr's diagnostics are, since a kept record outlives the process. Redacting comes first,
* so truncation cannot leave a partial secret the patterns no longer match.
*/
export function programStatusSequence(state: ProgramState, details: { message?: string; kind?: BlockedKind } = {}, environment: NodeJS.ProcessEnv = process.env): string {
const pairs = [`state=${state}`, `app=${APP}`];
if (state === "blocked" && details.kind) pairs.push(`kind=${details.kind}`);
const redacted = details.message === undefined ? undefined : redactSecrets(details.message, environmentSecrets(environment));
// The terminal discards a report whose message holds control characters, and shows one line.
const message = redacted?.replace(/[\p{Cc}\u2028\u2029]+/gu, " ").trim();
// By code points, so an emoji is not split; the first cut keeps Array.from off a long git stderr.
const shown = message && Array.from(message.slice(0, MESSAGE_LIMIT * 2)).slice(0, MESSAGE_LIMIT).join("");
if (shown) pairs.push(`msg=${Buffer.from(shown, "utf8").toString("base64")}`);
return `\x1b]7501;${pairs.join(":")}\x1b\\`;
}
/** CI is left out even under a pseudo-terminal (Buildkite, `docker run -t`), whose log would keep the raw sequences. */
export function terminalReportsStatus(stream: { isTTY?: boolean } = process.stderr, environment: NodeJS.ProcessEnv = process.env): boolean {
return stream.isTTY === true && environment.TERM !== "dumb" && !environment.CI;
}
/** Turns reports on for this process when stderr is a terminal; until then `reportStatus` writes nothing. */
export function enableProgramStatus(options: { write?: (text: string) => void } = {}): void {
if (options.write) write = options.write;
else if (terminalReportsStatus()) write = text => { process.stderr.write(text); };
}
export function reportStatus(state: ProgramState, details: { message?: string; kind?: BlockedKind } = {}): void {
last = state;
write?.(programStatusSequence(state, details));
}
/** `done`, or `error` when the command has already set a failing exit code (a review with a failed target). */
export function reportFinished(message?: string): void {
reportStatus(process.exitCode ? "error" : "done", message ? { message } : {});
}
/** The last state reported, so the command's end reports `done` only when nothing more specific came before it. */
export function lastReportedStatus(): ProgramState | undefined {
return last;
}
+6 -2
View File
@@ -1,7 +1,10 @@
import { reportStatus } from "./program-status.js";
/**
* One line per capture step on stderr, so a CI log or a terminal shows what Explore is doing while
* a build or a simulator session runs for minutes. Messages carry plan, route, and EAS identifiers
* only; never setup text, which can hold app-test secrets.
* a build or a simulator session runs for minutes; the same line becomes the terminal's status
* message (see program-status). Messages carry plan, route, and EAS identifiers only; never setup
* text, which can hold app-test secrets.
*/
export type Progress = (message: string) => void;
@@ -12,6 +15,7 @@ export function stderrProgress(options: { now?: () => number; write?: (text: str
const write = options.write ?? (text => { process.stderr.write(text); });
const started = now();
return message => {
reportStatus("working", { message });
const seconds = Math.max(0, Math.floor((now() - started) / 1000));
const elapsed = `${String(Math.floor(seconds / 60)).padStart(2, "0")}:${String(seconds % 60).padStart(2, "0")}`;
write(`[explore ${elapsed}] ${message}\n`);
+5 -3
View File
@@ -87,14 +87,16 @@ jobs:
shell: bash
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it. A package
# mirror can stall without failing, so each apt-get call has network timeouts and a time limit, and a stalled
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout.
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout. timeout runs
# under sudo so its signal reaches apt-get itself, and -k kills an apt-get that does not exit on it: without -k,
# timeout waits for the command however long it takes (brentvatne/euxy review run 40042718931 waited 7 minutes).
timeout-minutes: 10
run: |
set -euo pipefail
if ! command -v ffmpeg > /dev/null; then
apt=(sudo apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
apt=(apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
for attempt in 1 2; do
if timeout 120 "${apt[@]}" update && timeout 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if sudo timeout -k 10 120 "${apt[@]}" update && sudo timeout -k 10 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if [ "$attempt" = 2 ]; then echo '::error title=LAUNCH_DECODER_INSTALL_FAILED::apt-get could not install ffmpeg; rerun the job.'; exit 1; fi
echo "::warning title=LAUNCH_DECODER_INSTALL_RETRY::apt-get did not install ffmpeg on attempt $attempt; trying again."
done
+5 -3
View File
@@ -124,14 +124,16 @@ jobs:
shell: bash
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it. A package
# mirror can stall without failing, so each apt-get call has network timeouts and a time limit, and a stalled
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout.
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout. timeout runs
# under sudo so its signal reaches apt-get itself, and -k kills an apt-get that does not exit on it: without -k,
# timeout waits for the command however long it takes (brentvatne/euxy review run 40042718931 waited 7 minutes).
timeout-minutes: 10
run: |
set -euo pipefail
if ! command -v ffmpeg > /dev/null; then
apt=(sudo apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
apt=(apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
for attempt in 1 2; do
if timeout 120 "${apt[@]}" update && timeout 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if sudo timeout -k 10 120 "${apt[@]}" update && sudo timeout -k 10 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if [ "$attempt" = 2 ]; then echo '::error title=LAUNCH_DECODER_INSTALL_FAILED::apt-get could not install ffmpeg; rerun the job.'; exit 1; fi
echo "::warning title=LAUNCH_DECODER_INSTALL_RETRY::apt-get did not install ffmpeg on attempt $attempt; trying again."
done
+5 -3
View File
@@ -113,14 +113,16 @@ jobs:
shell: bash
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it. A package
# mirror can stall without failing, so each apt-get call has network timeouts and a time limit, and a stalled
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout.
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout. timeout runs
# under sudo so its signal reaches apt-get itself, and -k kills an apt-get that does not exit on it: without -k,
# timeout waits for the command however long it takes (brentvatne/euxy review run 40042718931 waited 7 minutes).
timeout-minutes: 10
run: |
set -euo pipefail
if ! command -v ffmpeg > /dev/null; then
apt=(sudo apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
apt=(apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
for attempt in 1 2; do
if timeout 120 "${apt[@]}" update && timeout 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if sudo timeout -k 10 120 "${apt[@]}" update && sudo timeout -k 10 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if [ "$attempt" = 2 ]; then echo '::error title=LAUNCH_DECODER_INSTALL_FAILED::apt-get could not install ffmpeg; rerun the job.'; exit 1; fi
echo "::warning title=LAUNCH_DECODER_INSTALL_RETRY::apt-get did not install ffmpeg on attempt $attempt; trying again."
done
+141 -1
View File
@@ -1493,8 +1493,40 @@ test("Screens' filmstrip: switched from the corner switch, stepped with the arro
await page.mouse.down({ clickCount: 2 });
await page.mouse.up({ clickCount: 2 });
await expect(middle).toHaveAttribute("data-screen-id", last);
// In the filmstrip the Inspector opens only from a click on the middle screen, so the one the first click opened closes.
await expect(inspector).toBeHidden();
// With the sidebar folded, the middle screen is at the centre of the canvas.
await expect(view.getByRole("button", { name: "Show sidebar" })).toBeVisible();
const centre = await middle.evaluate(element => { const box = element.getBoundingClientRect(); return box.left + box.width / 2; });
expect(Math.abs(centre - page.viewportSize()!.width / 2)).toBeLessThan(2);
// A sideways trackpad swipe moves the strip with it, and a short one springs back when it ends; a wheel notch steps.
const lastAt = ids.indexOf(last);
await middle.hover();
// Measured in the page two frames after the event: the swipe ends, and the strip settles, 100 ms after the last one.
const moved = await middle.evaluate(async element => {
element.dispatchEvent(new WheelEvent("wheel", { deltaX: -40, bubbles: true, cancelable: true }));
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
const box = element.getBoundingClientRect();
return { centre: box.left + box.width / 2, swiping: element.parentElement!.classList.contains("swiping") };
});
expect(moved.swiping).toBe(true);
expect(moved.centre - centre).toBeGreaterThan(20);
expect(moved.centre - centre).toBeLessThan(60);
await expect(strip.locator(".screens-strip-stage")).not.toHaveClass(/swiping/);
await expect(middle).toHaveAttribute("data-screen-id", last);
await expect.poll(() => middle.evaluate(element => { const box = element.getBoundingClientRect(); return Math.round(box.left + box.width / 2); }))
.toBe(Math.round(centre));
await page.mouse.wheel(0, -100);
await expect(middle).toHaveAttribute("data-screen-id", ids[lastAt - 1]!);
await page.waitForTimeout(300);
await page.mouse.wheel(100, 0);
await expect(middle).toHaveAttribute("data-screen-id", last);
// A click on the middle screen opens the Inspector; Esc closes it first, then steps back out to the grid.
await middle.locator(".screens-strip-target").click();
await expect(inspector).toBeVisible();
// Esc closes the Inspector first, then steps back out to the grid with the screen still picked.
await page.keyboard.press("Escape");
await expect(inspector).toBeHidden();
await expect(strip).toBeVisible();
@@ -1581,6 +1613,63 @@ test("Screens' filmstrip keeps Changed across a layout switch, opens only from a
await expect(page).toHaveURL(/[?&]layout=filmstrip/);
});
test("Screens' filmstrip gestures: a short flick lands where it carries the strip, and a step made during a swipe is not undone by it", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/screens");
const view = page.getByRole("main", { name: "Screens" });
await view.getByRole("button", { name: /^All/ }).click();
const ids = await view.locator(".screens-grid .screens-cell").evaluateAll(elements => elements.map(element => element.getAttribute("data-screen-id")!));
await page.getByRole("group", { name: "Screens layout" }).getByRole("button", { name: "Filmstrip" }).click();
const strip = view.getByRole("region", { name: "Filmstrip" });
const middle = strip.locator(".screens-strip-frame.focused");
const stage = strip.locator(".screens-strip-stage");
await expect(middle).toHaveAttribute("data-screen-id", ids[0]!);
const historyLength = await page.evaluate(() => history.length);
// A finger drags a quarter of a screen and lifts while still moving: the flick carries the strip past halfway, so it
// lands on the next screen though the finger never got there.
await stage.evaluate(async element => {
const box = element.getBoundingClientRect();
const y = box.top + box.height / 2, x = box.left + box.width * 0.6;
const pitch = (() => {
const [a, b] = [...element.querySelectorAll(".screens-strip-frame")].map(frame => { const r = frame.getBoundingClientRect(); return r.left + r.width / 2; });
return Math.abs(b! - a!);
})();
const fire = (type: string, at: number) => element.dispatchEvent(new PointerEvent(type, { pointerId: 9, pointerType: "touch", isPrimary: true,
clientX: at, clientY: y, bubbles: true, cancelable: true }));
fire("pointerdown", x);
const step = pitch / 16;
for (let n = 1; n <= 4; n++) { fire("pointermove", x - n * step); await new Promise(resolve => setTimeout(resolve, 16)); }
fire("pointerup", x - 4 * step);
});
await expect(middle).toHaveAttribute("data-screen-id", ids[1]!);
await expect(stage).not.toHaveClass(/swiping/);
// However many screens a swipe passes, it is one step back.
expect(await page.evaluate(() => history.length)).toBe(historyLength + 1);
// A short wheel swipe whose momentum is still coming in when ← steps back: the arrow's screen stays in the middle,
// neither settled over by the swipe nor dragged off by its momentum.
await middle.hover();
await page.evaluate(() => {
const stage = document.querySelector(".screens-strip-stage")!;
stage.dispatchEvent(new WheelEvent("wheel", { deltaX: 100, bubbles: true, cancelable: true }));
let left = 30;
const momentum = setInterval(() => {
stage.dispatchEvent(new WheelEvent("wheel", { deltaX: 1, bubbles: true, cancelable: true }));
if (--left === 0) clearInterval(momentum);
}, 16);
});
await page.keyboard.press("ArrowLeft");
await expect(middle).toHaveAttribute("data-screen-id", ids[0]!);
await page.waitForTimeout(900);
await expect(middle).toHaveAttribute("data-screen-id", ids[0]!);
await expect(stage).not.toHaveClass(/swiping/);
// A pinch (a wheel with Control) zooms; it does not move the strip.
await page.evaluate(() => document.querySelector(".screens-strip-stage")!.dispatchEvent(new WheelEvent("wheel", { deltaX: 400, ctrlKey: true, bubbles: true, cancelable: true })));
await page.waitForTimeout(300);
await expect(middle).toHaveAttribute("data-screen-id", ids[0]!);
});
test("Screens' layouts switch with G and E, and the sidebar folds by its own buttons and on each switch to the filmstrip", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/screens");
@@ -5559,6 +5648,56 @@ test.describe("phone layout", () => {
await expect(page.getByRole("navigation", { name: "Views" })).toBeVisible();
await expect(page.locator(".map-canvas")).toBeVisible();
});
test("the filmstrip on a phone: switched beside Changed / All, swiped by a finger, and its middle screen opens the Inspector", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/screens");
const view = page.getByRole("main", { name: "Screens" });
await view.getByRole("button", { name: /^All/ }).tap();
const layouts = view.getByRole("group", { name: "Screens layout" });
await expect(layouts.getByRole("button", { name: "Grid" })).toHaveAttribute("aria-pressed", "true");
await layouts.getByRole("button", { name: "Filmstrip" }).tap();
await expect(page).toHaveURL(/[?&]layout=filmstrip/);
const strip = view.getByRole("region", { name: "Filmstrip" });
const middle = strip.locator(".screens-strip-frame.focused");
const first = await middle.getAttribute("data-screen-id");
// The section chips give way to the path above the strip; the Tree still jumps anywhere.
await expect(view.locator(".screens-jump-chip:not(.tree)")).toHaveCount(0);
await expect(view.getByRole("button", { name: "Tree" })).toBeVisible();
await expectNoHorizontalOverflow(page);
// A finger dragged left moves the strip under it while it is down, and the strip settles on the next screen.
const stage = strip.locator(".screens-strip-stage");
const dragged = await stage.evaluate(async element => {
const box = element.getBoundingClientRect();
const y = box.top + box.height / 2, x = box.left + box.width * 0.7;
const fire = (type: string, at: number) => element.dispatchEvent(new PointerEvent(type, { pointerId: 7, pointerType: "touch", isPrimary: true,
clientX: at, clientY: y, bubbles: true, cancelable: true }));
const centre = () => { const frame = element.querySelector(".screens-strip-frame.focused")!.getBoundingClientRect(); return frame.left + frame.width / 2; };
const before = centre();
fire("pointerdown", x);
for (let step = 1; step <= 3; step++) { fire("pointermove", x - step * 20); await new Promise(resolve => setTimeout(resolve, 16)); }
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
const during = centre();
for (let step = 4; step <= 6; step++) { fire("pointermove", x - step * 20); await new Promise(resolve => setTimeout(resolve, 16)); }
fire("pointerup", x - 120);
return { moved: before - during, swiping: element.classList.contains("swiping") };
});
expect(dragged.moved).toBeGreaterThan(50);
expect(dragged.moved).toBeLessThan(70);
await expect(middle).not.toHaveAttribute("data-screen-id", first!);
await expect(stage).not.toHaveClass(/swiping/);
// A tap on the middle screen opens the Inspector; a tap on a neighbour only brings it to the middle.
const inspector = page.getByRole("complementary", { name: "Inspector panel" });
// The next screen peeks in at the right edge: a tap on the part that shows.
const next = strip.locator(".screens-strip-frame.focused + .screens-strip-frame");
const nextId = await next.getAttribute("data-screen-id");
await next.locator(".screens-strip-target").tap({ position: { x: 12, y: 60 } });
await expect(middle).toHaveAttribute("data-screen-id", nextId!);
await expect(inspector).toHaveCount(0);
await middle.locator(".screens-strip-target").tap();
await expect(inspector).toBeVisible();
});
});
test("the theme is Auto until the More menu picks one: it follows the system, and a pick outlives a reload", async ({ page }) => {
@@ -6098,4 +6237,5 @@ test.describe("a wide Inspector in a short window", () => {
await expect.poll(async () => (await frame.boundingBox())!.height).toBeLessThanOrEqual(421);
await expect.poll(async () => (await frame.boundingBox())!.height).toBeGreaterThan(300);
});
});
+17 -1
View File
@@ -243,7 +243,7 @@ async function fixture(t, settings = {}) {
if (listed === null) throw new Error('eas env:list exited with status 1: GraphQL request failed.');
return { stdout: listed ?? 'Environment: preview\nNo variables found for this environment.\n', stderr: '' };
}
if (command === 'build:list') return json(settings.reuse ? [{ id: 'native-build', ...buildMetadata }] : []);
if (command === 'build:list') return json(settings.reuse ? [{ id: settings.reusable ?? 'native-build', ...buildMetadata }] : []);
if (command === 'build') return json([{ id: 'built-app', fingerprint: { hash: 'source-fingerprint' }, ...buildMetadata }]);
if (command === 'env:pull') { writeFileSync(value(request, '--path'), '# Environment: preview\nEXPO_PUBLIC_ENDPOINT=sample\n'); return { stdout: '', stderr: '' }; }
if (command === 'build:download') {
@@ -2146,6 +2146,22 @@ test('two jobs of one run attempt that repack the same app share one hosted repa
assert.ok(lines.some(line => /using EAS build repacked-app, the hosted repack of this commit another target of this run made/.test(line)), lines.join('\n'));
});
test('a target that starts after the shared repack finished, and finds that repack as its build to repack, joins it', async t => {
const eas = easBuilds();
const leader = await fixture(t, { reuse: true, eas });
await runCiMap({ ...leader.options, ...share('iphone') });
eas.builds[0].status = 'FINISHED';
// The newest build with the fingerprint is now the leader's repack (brentvatne/euxy#179, review run 40042718931): a
// key made from the build each job found would differ, and this target would wait, then repack a repack itself.
const { f, lines, run } = await follow(t, eas, { reusable: 'repacked-app' });
const result = await run;
assert.equal(runs(f), 0, 'the late target does not repack');
assert.equal(shareLists(f), 1, 'its first look finds the finished repack');
assert.deepEqual(downloaded(f), ['repacked-app']);
assert.equal(result.easBuildId, 'repacked-app');
assert.ok(lines.some(line => /using EAS build repacked-app, the hosted repack of this commit another target of this run made/.test(line)), lines.join('\n'));
});
test("a target follows the leader's repack by its id while it runs, even once newer builds push it off the list", async t => {
const message = await leaderMessage(t);
const eas = easBuilds([{ id: 'leader-repack', status: 'IN_QUEUE', platform: 'IOS', message }]);
+6 -2
View File
@@ -129,13 +129,17 @@ test('the staged digest changes with any file, mode or link, and the share key w
await rm(join(root, 'entry.js')); await symlink('package.json', join(root, 'entry.js')); digests.push(await stagedProjectDigest(root));
await mkdir(join(root, 'empty')); digests.push(await stagedProjectDigest(root));
assert.equal(new Set(digests).size, digests.length);
const input = { scope: 'acme/example#39506405687.1', platform: 'ios', nativeBuildId: 'a81d5d80', easProfile: 'explore', environment: 'preview', environmentVariables: 'a'.repeat(64), project: digests[0] };
const input = { scope: 'acme/example#39506405687.1', platform: 'ios', fingerprint: 'ea9bf84e1a5b0900000ba7c1e6b1c7e272e1306f', easProfile: 'explore', environment: 'preview', environmentVariables: 'a'.repeat(64), project: digests[0] };
const key = hostedRepackShareKey(input);
assert.match(key, /^[0-9a-f]{32}$/);
for (const [name, other] of Object.entries({ scope: 'acme/example#39506405687.2', platform: 'android', nativeBuildId: 'b0000000', easProfile: 'other', environment: 'production',
for (const [name, other] of Object.entries({ scope: 'acme/example#39506405687.2', platform: 'android', fingerprint: 'fc2446ef4e6d0000000000000000000000000000', easProfile: 'other', environment: 'production',
environmentVariables: 'b'.repeat(64), project: digests[1] })) {
assert.notEqual(hostedRepackShareKey({ ...input, [name]: other }), key, name);
}
// Which build a job found to repack does not matter, only its native code: a target that starts after the others'
// repack finished finds that repack as its newest build of the fingerprint (brentvatne/euxy#179), and must still
// join it rather than make another.
assert.equal(hostedRepackShareKey({ ...input, nativeBuildId: '7f6b592a' }), hostedRepackShareKey({ ...input, nativeBuildId: '2ebcfd8d' }));
});
test("only a build whose message ends with this key, for this platform, is another job's repack", () => {
+76
View File
@@ -0,0 +1,76 @@
import assert from "node:assert/strict";
import test from "node:test";
import { enableProgramStatus, lastReportedStatus, programStatusSequence, reportFinished, reportStatus, terminalReportsStatus } from "../../dist/shared/program-status.js";
import { stderrProgress } from "../../dist/shared/progress.js";
const decode = sequence => {
assert.match(sequence, /^\x1b\]7501;.*\x1b\\$/);
return Object.fromEntries(sequence.slice(7, -2).split(":").map(pair => [pair.slice(0, pair.indexOf("=")), pair.slice(pair.indexOf("=") + 1)]));
};
const message = sequence => {
const { msg } = decode(sequence);
return msg === undefined ? undefined : Buffer.from(msg, "base64").toString("utf8");
};
test("a report names the state and the app, and carries its message as base64", () => {
assert.equal(programStatusSequence("done"), "\x1b]7501;state=done:app=expo-explore\x1b\\");
const pairs = decode(programStatusSequence("working", { message: "capturing Home — ✓" }));
assert.equal(pairs.state, "working");
assert.equal(Buffer.from(pairs.msg, "base64").toString("utf8"), "capturing Home — ✓");
});
test("only a blocked report carries its kind", () => {
assert.equal(decode(programStatusSequence("blocked", { kind: "question" })).kind, "question");
assert.equal(decode(programStatusSequence("working", { kind: "question" })).kind, undefined);
});
test("a message becomes one line without control characters, within the spec's size", () => {
const pairs = decode(programStatusSequence("error", { message: "build failed\n\x1b[31mexit 1\x1b[0m\t" }));
assert.equal(Buffer.from(pairs.msg, "base64").toString("utf8"), "build failed [31mexit 1 [0m");
assert.ok(Buffer.from(decode(programStatusSequence("working", { message: "あ".repeat(5000) })).msg, "base64").byteLength <= 2048);
// Cut by code points: an emoji at the limit is kept whole or dropped, never halved.
assert.equal(message(programStatusSequence("working", { message: `${"a".repeat(511)}😀😀` })), `${"a".repeat(511)}😀`);
assert.ok(Buffer.from(decode(programStatusSequence("working", { message: "😀".repeat(5000) })).msg, "base64").byteLength <= 2048);
assert.equal(decode(programStatusSequence("working", { message: " \n " })).msg, undefined);
assert.ok(programStatusSequence("working", { message: "x".repeat(5000) }).length <= 4096);
});
test("a message is redacted as stderr's diagnostics are", () => {
const environment = { EXPO_TOKEN: "expo-secret-value", SIGNING_PRIVATE_KEY: "private-key-value" };
const text = message(programStatusSequence("error", {
message: "git failed: https://user:[email protected]/o/r expo-secret-value private-key-value",
}, environment));
assert.doesNotMatch(text, /ghp_|expo-secret-value|private-key-value/);
assert.match(text, /\[REDACTED\]/);
});
test("only an interactive stderr that is not a dumb terminal or CI gets reports", () => {
assert.equal(terminalReportsStatus({ isTTY: true }, { TERM: "xterm-ghostty" }), true);
assert.equal(terminalReportsStatus({ isTTY: true }, { TERM: "dumb" }), false);
assert.equal(terminalReportsStatus({ isTTY: true }, { TERM: "xterm-256color", CI: "true" }), false);
assert.equal(terminalReportsStatus({ isTTY: false }, {}), false);
assert.equal(terminalReportsStatus({}, {}), false);
});
test("progress lines become the working status once reports are on", () => {
const written = [];
stderrProgress({ write: () => {} })("before");
enableProgramStatus({ write: text => written.push(text) });
stderrProgress({ write: () => {} })("planning routes");
reportStatus("done");
assert.deepEqual(written.map(decode).map(({ state, msg }) => [state, msg && Buffer.from(msg, "base64").toString("utf8")]),
[["working", "planning routes"], ["done", undefined]]);
assert.equal(lastReportedStatus(), "done");
});
test("a finished command reports done, or error once it has set a failing exit code", t => {
const written = [];
enableProgramStatus({ write: text => written.push(text) });
const exitCode = process.exitCode;
t.after(() => { process.exitCode = exitCode; });
process.exitCode = undefined;
reportFinished();
process.exitCode = 1;
reportFinished("No report for ios");
assert.deepEqual(written.map(text => [decode(text).state, message(text)]), [["done", undefined], ["error", "No report for ios"]]);
});
+10 -6
View File
@@ -888,6 +888,8 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
if (!rightCollapsedRef.current) inspectorDismissedRef.current = true;
setRightCollapsed((current) => !current);
}, []);
// A double-click that opens the filmstrip closes the Inspector its first click opened; it is not the reader dismissing it.
const closeInspector = useCallback(() => setRightCollapsed(true), []);
// Every canvas opens with the panel showing and the Inspector out of the way.
// The sidebar keeps whatever state the reader gave it; only the Inspector closes, because a
@@ -901,9 +903,9 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
// into the destination view.
// The report Screens' layout is remembered for: the loaded one, however it was loaded.
const runId = payload?.map.run.id;
/** Screens opens in the layout the reader last left it in for this report; phones have only their list. */
/** Screens opens in the layout the reader last left it in for this report. */
const rememberedScreensLayout = useCallback((canvas: CanvasView): Partial<Route> => (
canvas === "screens" && routeRef.current.canvas !== "screens" && !phoneRef.current ? { layout: readScreensLayout(runId) } : {}
canvas === "screens" && routeRef.current.canvas !== "screens" ? { layout: readScreensLayout(runId) } : {}
), [runId]);
const commitCanvasSelection = useCallback((canvas: CanvasView) => {
const current = routeRef.current;
@@ -950,8 +952,8 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
}, [navigate, runId]);
// A link that opens the filmstrip is remembered as a switch to it is.
useEffect(() => {
if (route.canvas === "screens" && route.layout === "filmstrip" && !phone) writeScreensLayout(runId, "filmstrip");
}, [phone, route.canvas, route.layout, runId]);
if (route.canvas === "screens" && route.layout === "filmstrip") writeScreensLayout(runId, "filmstrip");
}, [route.canvas, route.layout, runId]);
// The logo returns to the Map root, the equivalent of the "/map" URL.
const openMapHome = useCallback(() => {
@@ -1128,10 +1130,11 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
const pickedInPlaceRef = useRef<string | undefined>(undefined);
// The Screens tree and jump bar pick a screen in place: it is selected and scrolled to, and the
// Inspector stays as it was. A click on the screenshot, or I, opens it.
const pickScreenInPlace = useCallback((id: string) => {
const pickScreenInPlace = useCallback((id: string, options?: { replace?: boolean }) => {
const sameSelection = resolveScreenId(routeRef.current, contextRef.current) === id;
if (!sameSelection) pickedInPlaceRef.current = id;
navigate(screenPatch(id), { replace: sameSelection, focus: { target: "screen", id } });
// A swipe through the filmstrip is one step back, however many screens it passed.
navigate(screenPatch(id), { replace: sameSelection || options?.replace === true, focus: { target: "screen", id } });
}, [navigate, screenPatch]);
// On a phone the Inspector covers the map, so a tap selects the screen first (its ring, its
// connections, the Open hint) and only a second tap on the selected screen opens it.
@@ -1690,6 +1693,7 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
onClearSelection={clearSelectedScreen}
layout={route.layout ?? "grid"}
onChangeLayout={changeScreensLayout}
onCloseInspector={closeInspector}
/>
) : null}
{comparing && phone && diff && selectedScreenId && comparePicker ? (
@@ -316,9 +316,13 @@
.compare-stage.mode-flip .compare-frame-wrap,
.sidebar-review-stage.mode-flip .compare-frame-wrap,
.sidebar-review-stage.mode-split.landscape .compare-frame-wrap { display: flex; justify-content: center; }
/* The width is spelled out, not left to aspect-ratio: WebKit sizes a flex item by its height + aspect-ratio box's
available width rather than its ratio width, so Split's two sides stayed half the stage each and each frame sat at
the left of its side, off centre under its name (seen on a folded iPhone Duo). */
.compare-frame {
position: relative;
display: block;
width: calc(var(--compare-frame-height) * var(--compare-aspect));
height: var(--compare-frame-height);
aspect-ratio: var(--compare-aspect);
overflow: hidden;
+196 -36
View File
@@ -1,4 +1,4 @@
import { useLayoutEffect, useMemo, useState } from "react";
import { useEffect, useLayoutEffect, useMemo, useRef, useState, type CSSProperties, type PointerEvent, type WheelEvent } from "react";
import { ChevronRight } from "lucide-react";
import { artifactUrl, isLaunchScreen, type MapIndex, type Screen } from "../../utils/model";
import { primaryScreenshotForScreen, screenshotSize, type ScreenshotSize } from "../../utils/screen-images";
@@ -7,10 +7,29 @@ import { screenLabel } from "../../utils/screen-path";
import { treeNodeKey, type ScreenTree, type ScreenTreeIndex, type ScreenTreeNode } from "../../utils/screen-tree";
import { ScreenshotImage } from "../shared/screenshot-image";
/** A neighbour's size and opacity by its distance from the screen in the middle. */
const SCALES = [1, 0.74, 0.54, 0.4];
const OPACITIES = [1, 0.9, 0.6, 0.3];
/**
* A neighbour's size and opacity by its distance from the screen in the middle. The last, invisible, place is where a
* screen waits to come in, so a swipe or a step fades it in rather than popping it.
*/
const SCALES = [1, 0.74, 0.54, 0.4, 0.3];
const OPACITIES = [1, 0.9, 0.6, 0.3, 0];
const GAP = 32;
/** A swipe has ended once its wheel events (and the trackpad's momentum after it) stop for this long. */
const SWIPE_END_MS = 100;
/**
* At the end of a swipe the strip settles on the next screen in its direction once it has moved this far towards it,
* so one wheel notch steps a screen and a twitch springs back.
*/
const SWIPE_COMMIT = 0.2;
/** How far a finger moves before a touch is a swipe rather than a tap. */
const TAP_SLOP_PX = 8;
/** How far ahead a flick's speed carries the strip when the finger lifts: its velocity times this. */
const FLICK_MS = 160;
/**
* How long the strip takes to settle after a gesture: longer the further it has left to go, so that a short way home
* is not crossed at the speed of a whole step and a long one does not snap.
*/
const settleMs = (distance: number) => Math.round(260 + 260 * Math.min(1, distance));
/** An iPhone's portrait shape, for a run with no screenshot sizes at all. */
const FALLBACK_SIZE: ScreenshotSize = { imageWidth: 390, imageHeight: 844 };
@@ -30,10 +49,12 @@ export type ScreensFilmstripProps = {
/** The tree's dot class for a screen: its status, shown beside its name as the grid and the tree show it. */
dot: (id: string) => string | undefined;
dimmed: (id: string) => boolean;
/** Brings a screen to the middle without opening the Inspector. */
onPick: (id: string) => void;
/** Brings a screen to the middle without opening the Inspector; `replace` keeps it out of the history. */
onPick: (id: string, options?: { replace?: boolean }) => void;
/** Selects a screen and opens it in the Inspector, as a click on its card does. */
onOpen: (id: string) => void;
/** The phone layout: the middle screen takes most of the width, and a finger swipes the strip. */
phone?: boolean | undefined;
};
function labelOf(screen: Screen, index: MapIndex): string {
@@ -64,6 +85,24 @@ function useSize(): [(element: HTMLDivElement | null) => void, { width: number;
export function ScreensFilmstrip(props: ScreensFilmstripProps) {
const [stageRef, stage] = useSize();
const at = props.order.indexOf(props.focusedId);
// While a swipe lasts, the strip sits at a fractional position in `order`, following the gesture.
const [swipe, setSwipe] = useState<{ position: number; direction: number } | null>(null);
// Once the gesture lets go, the strip eases the rest of the way on a timing of its own (settleMs).
const [settling, setSettling] = useState<number | null>(null);
const settled = useRef<ReturnType<typeof setTimeout>>(undefined);
// The swipe's position as of the last wheel event, which can arrive before the render that shows the one before it.
const live = useRef<number | null>(null);
// A finger on the strip: where it went down, the strip's position then, and its latest speed in px/ms.
const touch = useRef<{ id: number; x: number; from: number; lastX: number; lastAt: number; velocity: number; moved: boolean } | null>(null);
// A swipe ends with the finger lifting over a screen; the click that follows is not a tap on it.
const swallowClick = useRef(false);
const swipeEnd = useRef<ReturnType<typeof setTimeout>>(undefined);
useEffect(() => () => { clearTimeout(swipeEnd.current); clearTimeout(settled.current); }, []);
// The gesture under way: the screens it has put in the middle, the last of them, and whether it has added its one
// history entry. A screen put in the middle by anything else (an arrow key, the tree, a click) ends it.
const gesture = useRef<{ shown: string; ids: Set<string>; pushed: boolean; start: number } | null>(null);
const focusedNow = useRef(props.focusedId);
useEffect(() => { focusedNow.current = props.focusedId; });
const focused = props.index.screens.get(props.focusedId);
// A row of the tree by its fold key, as the path above the frame names it.
@@ -91,36 +130,155 @@ export function ScreensFilmstrip(props: ScreensFilmstripProps) {
return size.imageWidth / size.imageHeight;
};
// Every frame is laid out as the middle one would be, filling the stage's height short of growing wider than half
// the stage, so a landscape capture beside portrait ones is as wide as it may be rather than as tall; then it is scaled
// the stage (on a phone, most of it, with the neighbours peeking in at the sides), so a landscape capture beside portrait ones is as wide as it may be rather than as tall; then it is scaled
// down around its centre, and the centres are spaced so the scaled frames sit a gap apart, the gap shrinking with them.
const frameSize = (screen: Screen) => {
const height = Math.max(0, Math.min(stage.height - 16, (stage.width * 0.5) / aspect(screen)));
const height = Math.max(0, Math.min(stage.height - 16, (stage.width * (props.phone ? 0.7 : 0.5)) / aspect(screen)));
return { width: height * aspect(screen), height };
};
const middle = frameSize(focused);
const frames: { id: string; screen: Screen; distance: number; x: number; width: number; height: number }[] = [
{ id: props.focusedId, screen: focused, distance: 0, x: 0, ...middle },
];
for (const direction of [-1, 1]) {
let edge = middle.width / 2;
for (let distance = 1; distance < SCALES.length; distance++) {
const id = props.order[at + direction * distance];
const screen = id ? props.index.screens.get(id) : undefined;
if (!id || !screen) break;
const size = frameSize(screen);
const scaled = size.width * SCALES[distance]!;
const centre = edge + GAP * SCALES[distance]! + scaled / 2;
frames.push({ id, screen, distance, x: direction * centre, ...size });
edge = centre + scaled / 2;
// Where each screen sits with the screen at `centre` in the middle: its distance and its centre's offset.
const layout = (centre: number) => {
const placed = new Map<string, { distance: number; x: number }>();
const middle = props.index.screens.get(props.order[centre] ?? "");
if (!middle) return placed;
placed.set(props.order[centre]!, { distance: 0, x: 0 });
for (const direction of [-1, 1]) {
let edge = frameSize(middle).width / 2;
for (let distance = 1; distance < SCALES.length; distance++) {
const id = props.order[centre + direction * distance];
const screen = id ? props.index.screens.get(id) : undefined;
if (!id || !screen) break;
const scaled = frameSize(screen).width * SCALES[distance]!;
const x = edge + GAP * SCALES[distance]! + scaled / 2;
placed.set(id, { distance, x: direction * x });
edge = x + scaled / 2;
}
}
}
return placed;
};
// A swipe someone else's step overtook (an arrow key, a click) no longer places the strip.
const swiping = swipe !== null && Math.round(swipe.position) === at;
const position = swiping ? swipe.position : at;
const base = Math.floor(position), fraction = position - base;
const from = layout(base), to = fraction > 0 ? layout(base + 1) : from;
const lerp = (a: number, b: number) => a + (b - a) * fraction;
const last = SCALES.length - 1;
// In the strip's order, so the frames' elements keep their order in the page as the middle changes: React moves an
// element that changes place among its siblings, and a moved element jumps instead of easing to where it goes.
const placeOf = new Map(props.order.map((id, place) => [id, place]));
const frames = [...new Set([...from.keys(), ...to.keys()])].sort((a, b) => placeOf.get(a)! - placeOf.get(b)!).flatMap(id => {
const screen = props.index.screens.get(id);
if (!screen) return [];
const a = from.get(id), b = to.get(id);
// A screen in only one of the two places is coming in or going out at the invisible end.
const distance = lerp(a?.distance ?? last, b?.distance ?? last);
const x = lerp(a?.x ?? b!.x, b?.x ?? a!.x);
const scale = lerp(SCALES[a?.distance ?? last]!, SCALES[b?.distance ?? last]!);
const opacity = lerp(OPACITIES[a?.distance ?? last]!, OPACITIES[b?.distance ?? last]!);
return [{ id, screen, distance, x, scale, opacity, ...frameSize(screen) }];
});
// The frames' gap at rest, which one screen of swipe travels.
const pitch = Math.abs(layout(at).get(props.order[at + 1] ?? props.order[at - 1] ?? "")?.x ?? frameSize(focused).width) || 1;
const clamp = (value: number) => Math.max(0, Math.min(props.order.length - 1, value));
const abandon = () => { clearTimeout(swipeEnd.current); gesture.current = null; live.current = null; };
const overtaken = () => !gesture.current || !gesture.current.ids.has(focusedNow.current);
// Where a gesture starts: where the one under way has the strip, or the screen in the middle for a new one.
const begin = (): number => {
if (!overtaken() && live.current !== null) return live.current;
abandon();
const index = props.order.indexOf(focusedNow.current);
const start = index < 0 ? at : index;
gesture.current = { shown: focusedNow.current, ids: new Set([focusedNow.current]), pushed: false, start };
return start;
};
// Puts a screen in the middle for the gesture: its first pick is one step back in the history, the rest replace it.
const show = (id: string) => {
const current = gesture.current;
if (!current || id === current.shown) return;
current.shown = id; current.ids.add(id);
props.onPick(id, current.pushed ? { replace: true } : undefined);
current.pushed = true;
};
// Puts the strip at `next` while a gesture lasts; the middle screen, and with it the path above, follows the swipe as
// it passes halfway.
const moveTo = (next: number, direction: number) => {
live.current = next;
setSwipe({ position: next, direction });
show(props.order[Math.round(next)]!);
};
// When the gesture ends, the strip settles on the next screen in its direction once it is SWIPE_COMMIT of the way
// there; `next` may be ahead of where the strip is, carried on by a flick.
const settle = (next: number, direction: number) => {
if (overtaken()) { abandon(); setSwipe(null); return; }
const index = clamp(direction > 0 ? Math.floor(next + 1 - SWIPE_COMMIT) : direction < 0 ? Math.ceil(next - 1 + SWIPE_COMMIT) : Math.round(next));
show(props.order[index]!);
gesture.current = null;
const ms = settleMs(Math.abs(index - (live.current ?? next)));
clearTimeout(settled.current);
setSettling(ms);
settled.current = setTimeout(() => setSettling(null), ms);
live.current = null;
setSwipe(null);
};
// A swipe along either axis moves the strip with it, so a mouse wheel works as well as a trackpad; it has ended when
// its events stop.
const onWheel = (event: WheelEvent) => {
// A pinch arrives as a wheel with Control held; it zooms the page, not the strip.
if (event.ctrlKey) return;
const delta = Math.abs(event.deltaX) > Math.abs(event.deltaY) ? event.deltaX : event.deltaY;
const pixels = event.deltaMode === 1 ? delta * 16 : event.deltaMode === 2 ? delta * stage.width : delta;
if (!pixels) return;
const next = clamp(begin() + pixels / pitch);
// The way the whole swipe went, not its last event: momentum's last 1px back must not turn a swipe around.
const direction = Math.sign(next - gesture.current!.start) || Math.sign(pixels);
moveTo(next, direction);
clearTimeout(swipeEnd.current);
swipeEnd.current = setTimeout(() => settle(next, direction), SWIPE_END_MS);
};
// A finger drags the strip under it; on lifting, a flick carries it on by its speed before it settles. A mouse
// keeps its clicks and wheel.
const onPointerDown = (event: PointerEvent) => {
// A browser that sent no click after the last swipe must not have this press's click swallowed, by finger or mouse.
swallowClick.current = false;
// A touch whose end never reached the strip (it slid off before it moved enough to be held) gives way to this one.
if (event.pointerType === "mouse" || touch.current?.id === event.pointerId) return;
touch.current = { id: event.pointerId, x: event.clientX, from: begin(), lastX: event.clientX, lastAt: event.timeStamp, velocity: 0, moved: false };
};
const onPointerMove = (event: PointerEvent) => {
const current = touch.current;
if (!current || current.id !== event.pointerId) return;
const dx = event.clientX - current.x;
if (!current.moved && Math.abs(dx) < TAP_SLOP_PX) return;
// A wheel swipe's settle waits until the finger takes over; a tap leaves it to settle.
if (!current.moved) { current.moved = true; clearTimeout(swipeEnd.current); event.currentTarget.setPointerCapture(event.pointerId); }
const elapsed = event.timeStamp - current.lastAt;
if (elapsed > 0) current.velocity = (event.clientX - current.lastX) / elapsed;
current.lastX = event.clientX; current.lastAt = event.timeStamp;
moveTo(clamp(current.from - dx / pitch), -Math.sign(dx));
};
const onPointerEnd = (event: PointerEvent) => {
const current = touch.current;
if (!current || current.id !== event.pointerId) return;
touch.current = null;
if (!current.moved) return;
swallowClick.current = true;
// A finger that stopped before lifting carries nothing on.
const velocity = event.timeStamp - current.lastAt > 80 ? 0 : current.velocity;
const next = clamp((live.current ?? position) - (velocity * FLICK_MS) / pitch);
settle(next, velocity ? -Math.sign(velocity) : -Math.sign(event.clientX - current.x));
};
const path = (props.shape.ancestors.get(props.focusedId) ?? []).flatMap(key => rowLabels.get(key) ?? []);
const plain = props.index.plainTitles || isLaunchScreen(focused);
const dot = props.dot(props.focusedId);
return (
<section className="screens-strip" aria-label="Filmstrip">
<section className={`screens-strip${props.phone ? " phone" : ""}`} aria-label="Filmstrip" onWheel={onWheel}
onPointerDown={onPointerDown} onPointerMove={onPointerMove} onPointerUp={onPointerEnd} onPointerCancel={onPointerEnd}
onClickCapture={(event) => { if (swallowClick.current) { swallowClick.current = false; event.preventDefault(); event.stopPropagation(); } }}>
<div className="screens-strip-path">
{path.map((label, position) => (
<span key={position} className="screens-strip-crumb" title={label}>
@@ -134,34 +292,36 @@ export function ScreensFilmstrip(props: ScreensFilmstripProps) {
</span>
</div>
<div ref={stageRef} className="screens-strip-stage">
{stage.width > 0 ? frames.map(({ id, screen, distance, x, width, height }) => {
<div ref={stageRef} className={`screens-strip-stage${swiping ? " swiping" : settling ? " settling" : ""}`}
style={settling ? ({ "--strip-settle-ms": `${settling}ms` } as CSSProperties) : undefined}>
{stage.width > 0 ? frames.map(({ id, screen, distance, x, scale, opacity, width, height }) => {
const artifact = primaryScreenshotForScreen(screen, props.index);
const url = artifactUrl(artifact);
const size = screenshotSize(artifact);
const placeholder = <span className="screens-strip-placeholder" aria-hidden="true" />;
const frameDiff = props.diff?.screens.get(id);
const scale = SCALES[distance]!;
const label = labelOf(screen, props.index);
const middle = id === props.focusedId;
const hidden = opacity === 0;
return (
<div key={id} id={props.frameId(id)} data-screen-id={id}
className={`screens-strip-frame${distance === 0 ? " focused" : ""}${frameDiff ? ` ${diffClass(frameDiff)}` : ""}${props.dimmed(id) ? " dimmed" : ""}`}
className={`screens-strip-frame${middle ? " focused" : ""}${frameDiff ? ` ${diffClass(frameDiff)}` : ""}${props.dimmed(id) ? " dimmed" : ""}`}
style={{
width,
height,
opacity: OPACITIES[distance],
zIndex: SCALES.length - distance,
opacity,
zIndex: Math.round((SCALES.length - distance) * 10),
transform: `translate(-50%, -50%) translateX(${x}px) scale(${scale})`,
}}>
{/* Only the middle frame is in the tab order: the arrows step the strip, and focus on a neighbour the stage
clips would scroll it off its centre. */}
<button type="button" className="screens-strip-target" aria-label={label} title={distance === 0 ? undefined : label}
tabIndex={distance === 0 ? undefined : -1}
aria-pressed={props.selectedId === id} aria-current={distance === 0 ? "true" : undefined}
onClick={() => (distance === 0 ? props.onOpen(id) : props.onPick(id))}>
<button type="button" className="screens-strip-target" aria-label={label} title={middle ? undefined : label}
tabIndex={middle ? undefined : -1} aria-hidden={hidden || undefined} disabled={hidden}
aria-pressed={props.selectedId === id} aria-current={middle ? "true" : undefined}
onClick={() => (middle ? props.onOpen(id) : props.onPick(id))}>
{/* A downloaded report's screenshot is a reference that ScreenshotImage resolves. */}
{url ? (
<ScreenshotImage src={url} alt="" draggable={false} decoding="async" loading={distance <= 1 ? "eager" : "lazy"}
<ScreenshotImage src={url} alt="" draggable={false} decoding="async" loading={distance <= 1.5 ? "eager" : "lazy"}
{...(size ? { width: size.imageWidth, height: size.imageHeight } : {})} fallback={placeholder} />
) : placeholder}
</button>
+46 -1
View File
@@ -335,6 +335,21 @@ button.screens-tree-row:hover { color: var(--text); background: var(--panel-hove
.screens-jump-chip > svg { width: 14px; height: 14px; }
.screens-jump-chip .path { font-family: var(--screens-mono); }
.screens-page.phone .screens-body { display: block; margin: 0; }
/* Grid or Filmstrip as two icons at the end of the Changed / All row. */
.screens-page.phone .screens-head { display: flex; align-items: center; gap: 8px; }
.screens-layout-toggle { display: inline-flex; flex: none; gap: 2px; margin-left: auto; padding: 3px; border-radius: 999px; background: var(--element); }
.screens-layout-toggle > button { display: grid; width: 40px; height: 28px; place-items: center; border-radius: 999px; color: var(--secondary); }
.screens-layout-toggle > button[aria-pressed="true"] { color: var(--text); background: var(--selected); }
.screens-layout-toggle svg { width: 16px; height: 16px; }
/* The phone's filmstrip fills what the bars leave: the head and the Tree button above it, the tab bar below. */
.screens-page.phone.filmstrip { display: flex; flex-direction: column; overflow: hidden; }
.screens-page.phone.filmstrip::before,
.screens-page.phone.filmstrip :is(.screens-head, .screens-jump) { flex: none; }
.screens-page.phone.filmstrip .screens-body { display: flex; min-height: 0; flex: 1; height: auto; }
.screens-page.phone.filmstrip .screens-sections { padding: 4px 0 0; }
.screens-strip.phone .screens-strip-path { padding: 0 16px; }
/* On a phone the fade is narrower, so the neighbours peeking in at the sides stay legible. */
.screens-strip.phone .screens-strip-stage { mask-image: linear-gradient(to right, transparent, #000 6%, #000 94%, transparent); }
/* Sections flow side by side, as on desktop, so a section of one screen leaves no empty row. Every
card takes a fraction of the page width, so cards from neighbouring sections share columns. */
.screens-page.phone .screens-sections { container-type: inline-size; gap: 32px 12px; padding: 20px 16px 0; }
@@ -383,6 +398,17 @@ button.screens-tree-row:hover { color: var(--text); background: var(--panel-hove
/* ── Filmstrip: one screen at a time, its neighbours smaller and fainter on either side ── */
/* The page stops scrolling; the strip fills the height between the pill and the bottom toolbar. */
.screens-page.filmstrip { overflow: hidden; padding-bottom: calc(84px * var(--ui-scale)); }
/* With the sidebar folded, its button floats where the sidebar starts and the strip takes the page's width, with the same
gap either side, so the middle screen sits at the centre of the canvas (beside an open Inspector, of what it leaves). */
.screens-page.filmstrip.side-folded { padding-left: 28px; }
.screens-page.filmstrip.side-folded .screens-side.collapsed {
position: absolute;
z-index: 3;
top: calc(var(--chrome-top) + var(--chrome-height) + 20px);
left: var(--canvas-chrome-inline-inset);
}
/* A sideways swipe steps the strip; it must not also take the browser back a page. */
html:has(.screens-page.filmstrip) { overscroll-behavior-x: none; }
.screens-page.filmstrip .screens-body { height: 100%; }
.screens-page.filmstrip .screens-side { max-height: 100%; }
.screens-page.filmstrip .screens-sections { display: flex; height: 100%; flex-wrap: nowrap; align-items: stretch; }
@@ -410,7 +436,18 @@ button.screens-tree-row:hover { color: var(--text); background: var(--panel-hove
.screens-strip-crumb.current > .screens-tree-dot[class*="diff-"] { background: var(--diff); }
.screens-strip-crumb-label { min-width: 0; overflow: hidden; text-overflow: ellipsis; }
.screens-strip-crumb-label.path { font-size: 12px; }
.screens-strip-stage { position: relative; width: 100%; min-height: 0; flex: 1; overflow: hidden; overflow: clip; }
.screens-strip-stage {
position: relative;
width: 100%;
min-height: 0;
flex: 1;
overflow: hidden;
overflow: clip;
/* The outer frames fade out towards the edges rather than being cut off. */
mask-image: linear-gradient(to right, transparent, #000 12%, #000 88%, transparent);
/* A finger's sideways swipe moves the strip, on any touch screen; an upward one still scrolls the page. */
touch-action: pan-y;
}
.screens-strip-frame {
position: absolute;
top: 50%;
@@ -419,6 +456,14 @@ button.screens-tree-row:hover { color: var(--text); background: var(--panel-hove
transition: transform 300ms cubic-bezier(0.2, 0.75, 0.2, 1), width 300ms cubic-bezier(0.2, 0.75, 0.2, 1), height 300ms cubic-bezier(0.2, 0.75, 0.2, 1), opacity 300ms ease;
will-change: transform;
}
/* During a swipe the frames follow the gesture directly; they ease only when it lets go and the strip settles. */
.screens-strip-stage.swiping .screens-strip-frame { transition: none; }
/* After it lets go, the strip eases home from rest: by then the gesture (and a trackpad's momentum) has slowed to
nearly nothing, and a curve that starts fast, as a step's does, would jerk it into motion. */
.screens-strip-stage.settling .screens-strip-frame {
transition-duration: var(--strip-settle-ms);
transition-timing-function: cubic-bezier(0.45, 0, 0.2, 1);
}
@media (prefers-reduced-motion: reduce) { .screens-strip-frame { transition: none; } }
.screens-strip-frame.dimmed:not(.focused) { opacity: calc(var(--dim-out) * 0.6) !important; }
.screens-strip-target {
+33 -18
View File
@@ -50,13 +50,15 @@ export type ScreensViewProps = {
onFindRequestDone?: (() => void) | undefined;
onSelectScreen: (id: string) => void;
/** The tree and jump bar pick a screen without opening the Inspector; a screenshot click selects it as the canvas does. */
onPickScreen?: ((id: string) => void) | undefined;
onPickScreen?: ((id: string, options?: { replace?: boolean }) => void) | undefined;
/** A click on the page around the cards clears the selection, as a click on a canvas's pane does. */
onClearSelection?: (() => void) | undefined;
/** Desktop only: every card in a grid, or one screen at a time in a filmstrip. */
/** Every card in a grid, or one screen at a time in a filmstrip. */
layout?: ScreensLayout | undefined;
/** A double-click on a card opens it in the filmstrip. */
onChangeLayout?: ((layout: ScreensLayout) => void) | undefined;
/** Closes the Inspector the first click of a double-click opened; in the filmstrip a click on its middle screen opens it. */
onCloseInspector?: (() => void) | undefined;
};
function statusOf(diff: BuildDiff | undefined, id: string): DiffStatus | undefined {
@@ -298,9 +300,9 @@ function Legend(props: { others: Appearance[] }) {
}
/**
* Screens as a page that scrolls. On desktop, one grid of every screen in the order of the tree beside it, or the same
* screens one at a time in a filmstrip (screens-filmstrip.tsx); on a phone, a section per route folder (or per tab,
* when there are no route files), with the tree behind a Tree button.
* Screens as a page that scrolls. On desktop, one grid of every screen in the order of the tree beside it; on a phone,
* a section per route folder (or per tab, when there are no route files), with the tree behind a Tree button. Either
* can show the same screens one at a time in a filmstrip (screens-filmstrip.tsx), which a finger swipes on a phone.
*/
export function ScreensView(props: ScreensViewProps) {
// The report's screens, as the Map draws them: a public report's routes it never captured are not among them.
@@ -336,7 +338,7 @@ export function ScreensView(props: ScreensViewProps) {
const treeOrder = useMemo(() => treeScreenOrder(tree), [tree]);
const order = props.phone ? sections.flatMap(section => section.screenIds) : treeOrder.filter(id => shown.has(id));
const others = [...new Set([...(props.changedElsewhere?.values() ?? [])].flat())];
const filmstrip = !props.phone && props.layout === "filmstrip";
const filmstrip = props.layout === "filmstrip";
// The filmstrip always has a screen in the middle: the selection when it is shown; else, when Changed or a find hides
// it, the nearest shown screen after it in the tree (before it, at the end), as the grid's arrows step from it; else
// the first screen.
@@ -631,6 +633,7 @@ export function ScreensView(props: ScreensViewProps) {
const openFilmstripRef = useRef<((id: string) => void) | undefined>(undefined);
openFilmstripRef.current = !props.phone && !filmstrip && props.onChangeLayout ? (id: string) => {
(props.onPickScreen ?? props.onSelectScreen)(id);
props.onCloseInspector?.();
props.onChangeLayout!("filmstrip");
} : undefined;
useEffect(() => {
@@ -677,6 +680,16 @@ export function ScreensView(props: ScreensViewProps) {
</div>
) : null;
// On a phone the switch is a pair of icons at the end of the Changed / All row.
const phoneLayoutSwitch = props.phone && props.onChangeLayout ? (
<div className="screens-layout-toggle" role="group" aria-label="Screens layout">
{([["grid", "Grid", <LayoutGrid key="grid" aria-hidden="true" />], ["filmstrip", "Filmstrip", <GalleryHorizontal key="filmstrip" aria-hidden="true" />]] as const)
.map(([value, label, icon]) => (
<button key={value} type="button" aria-label={label} aria-pressed={(filmstrip ? "filmstrip" : "grid") === value}
onClick={() => props.onChangeLayout!(value)}>{icon}</button>
))}
</div>
) : null;
const dimmed = (id: string) => Boolean(props.focus?.length) && !props.focus!.some((state) => state === focusStatusOf(props.diff?.screens.get(id)));
const cell = (id: string) => {
const screen = props.index.screens.get(id);
@@ -698,6 +711,14 @@ export function ScreensView(props: ScreensViewProps) {
) : null;
};
const strip = stripFocus ? (
<ScreensFilmstrip order={order} focusedId={stripFocus} selectedId={props.selectedScreenId}
index={props.index} diff={props.diff} tree={tree} shape={shape}
typicalSize={typicalSize} frameId={cardId} dimmed={dimmed} phone={props.phone}
dot={(id) => dotClass(props.diff, props.changedElsewhere, id)}
onPick={props.onPickScreen ?? props.onSelectScreen} onOpen={props.onSelectScreen} />
) : null;
// A find inside Changed can match only screens Changed hides; the empty state says so and offers All.
const noMatch = `No ${inChanged ? "changed " : ""}screens match “${findQuery.trim()}”`;
const matchedElsewhere = matches && inChanged ? [...matches].filter(id => !inFilter.has(id)).length : 0;
@@ -713,21 +734,22 @@ export function ScreensView(props: ScreensViewProps) {
return (
<>
{layoutSwitch}
<main ref={scroller} className={`screens-page${props.phone ? " phone" : ""}${filmstrip ? " filmstrip" : ""}`} aria-label="Screens" style={style}
<main ref={scroller} className={`screens-page${props.phone ? " phone" : ""}${filmstrip ? " filmstrip" : ""}${filmstrip && sideCollapsed && !props.phone ? " side-folded" : ""}`} aria-label="Screens" style={style}
onClick={(event) => {
// The filmstrip always shows a screen; clearing the pick there would only jump it back to the first.
if (!props.onClearSelection || !props.selectedScreenId || filmstrip) return;
if ((event.target as Element).closest("button, a, input, .screens-cell, .screens-side")) return;
props.onClearSelection();
}}>
{props.phone && filterChips ? <div className="screens-head">{filterChips}</div> : null}
{props.phone && (filterChips || phoneLayoutSwitch) ? <div className="screens-head">{filterChips}{phoneLayoutSwitch}</div> : null}
{props.phone ? (
<nav className="screens-jump" aria-label="Sections">
<button type="button" className="screens-jump-chip tree" onClick={() => setTreeOpen(true)}>
<ListTree aria-hidden="true" />Tree
</button>
{sections.map(section => {
{/* The filmstrip's path names where the screen is; the Tree jumps anywhere. */}
{filmstrip ? null : sections.map(section => {
const dot = section.screenIds.map(id => dotClass(props.diff, props.changedElsewhere, id)).find(Boolean);
return (
<a key={section.id} className="screens-jump-chip" href={`#${sectionAnchor(section.id)}`}
@@ -776,7 +798,7 @@ export function ScreensView(props: ScreensViewProps) {
</aside>
)}
<div className="screens-sections">
{props.phone ? sections.map(section => (
{props.phone ? strip ?? sections.map(section => (
<section key={section.id} id={sectionAnchor(section.id)} className="screens-section" aria-label={section.name ?? section.title}>
<header className="screens-section-head">
<h2>{section.name ?? section.title}</h2>
@@ -794,14 +816,7 @@ export function ScreensView(props: ScreensViewProps) {
<button type="button" className="screens-empty-all" onPointerDown={(event) => event.preventDefault()}
onClick={() => { setFilter("all"); focusFind(); }}>Show all</button></p>
: <p>Try part of a route, or press Esc to show every {inChanged ? "changed " : ""}screen.</p>}</div>
: stripFocus ? (
<ScreensFilmstrip order={order} focusedId={stripFocus} selectedId={props.selectedScreenId}
index={props.index} diff={props.diff} tree={tree} shape={shape}
typicalSize={typicalSize} frameId={cardId} dimmed={dimmed}
dot={(id) => dotClass(props.diff, props.changedElsewhere, id)}
onPick={props.onPickScreen ?? props.onSelectScreen} onOpen={props.onSelectScreen} />
)
: <div className="screens-grid">{order.map(cell)}</div>
: strip ?? <div className="screens-grid">{order.map(cell)}</div>
)}
</div>
</div>