Compare commits

..
Author SHA1 Message Date
Brent Vatne a03bfbdc6a Filmstrip: review fixes — double-clicks keep to their card, frames fit their own shape, Changed marks the folded sidebar
- A double-click opens the filmstrip only within 8px of the click that picked the card, and its second click selects nothing. A click on one card and a quick double-click elsewhere no longer opens the first, and a card the Inspector moves no longer leaves a stray selection behind.
- Each frame is fitted to its own screenshot's shape, so a landscape neighbour beside portrait screens is no longer a slab wider than the stage. Sizes ease as the strip moves.
- The middle frame keeps its screenshot's colours when the arrows focus it. The brightening that marks a focused pressed button elsewhere is off.
- When Changed or a find hides the selection, the middle is the nearest shown screen after it in the tree, as the grid's arrows step.
- The sidebar still folds on each switch to the filmstrip. Under Changed, the button left in its place has a dot in the changed colour and says so. Folding or opening the sidebar moves the keyboard to the button that replaces the one pressed.
- A neighbour's status outline covers every status the tree's dot shows.
2026-10-23 11:11:00 -07:00
Brent Vatne 4dcfa0c184 Screens: the sidebar folds away, folded by default in the filmstrip; G and E switch Grid and Filmstrip; the find field says Search
- A button in the tree's head folds the sidebar away, and a button left in its place opens it again.
- Each switch to the filmstrip starts with the sidebar folded, and each switch to the grid with it open.
- A find narrows the screens, so a switch with a query keeps the sidebar that shows it open, and folding the sidebar clears the query.
- `/` opens a folded sidebar and focuses the field.
- G and E switch Grid and Filmstrip on Screens, after Lightroom's Library keys. The switch's tooltips and the shortcuts list name them.
- The find field's placeholder is "Search".
2026-10-23 10:40:13 -07:00
Brent Vatne 0de1aa8f9c Filmstrip: the find field's arrows step from the middle screen; the layout switch keeps clear of a wide pill
- In the filmstrip, ↓ and ↑ in the find field step from the screen in the middle, as the page's arrows do, and no longer scroll the page under the strip.
- The layout switch hides below 540px of canvas, where even its icons would reach the pill, which grows to 420px.
2026-10-22 23:58:15 -07:00
Brent Vatne bbcca92a0f Filmstrip: the screenshots take the height; status beside the name; review fixes
- The caption, step buttons and scrubber under the strip are gone, so the screenshots take that height. The path above the strip ends in the screen's name, and ← / → and a click on a neighbour still step.
- The middle frame has no selection border. Its status is the tree's dot beside its name in the path, and neighbours keep their status outline.
- A long route keeps the path to one line. The screen's name truncates, ancestors are capped, and the full name is in the tooltip.
- A double-click opens the screen its first click picked, heard on the whole document. The first click opens the Inspector, which can reflow the grid or slide over the card before the second click lands.
- A layout switch replaces the history entry, as the change filter does, so Back leaves Screens rather than bringing back a layout the reader left.
- The layout switch keeps only its icons when the Inspector narrows the canvas, and hides when even those would not fit, as the Map's camera does.
2026-10-22 23:53:58 -07:00
Brent Vatne a5f395eea6 Screens: Grid / Filmstrip moves to a labelled switch at the top right; the sidebar is headed by its find field; review fixes
Layout switch
- Grid and Filmstrip are a labelled switch at the top right, in the pill's row, where the Map keeps its camera. It stays clear of the Inspector.
- The bottom bar goes back to one width on every section, and clicking the open Screens tab does nothing again.

Sidebar header
- The find field is always there at the head of the tree, with fold-all beside it and a `/` hint while it is empty.
- Changed / All sits under it only when there are changes, and the title row is gone.
- Esc in the field clears the query, then hands the keyboard back to the page.

Review fixes
- The filmstrip renders screenshots with ScreenshotImage, so downloaded reports and hosted previews resolve their screenshots instead of showing broken images.
- A layout switch keeps the focus request, so Changed and the find no longer reset to All when the selection is hidden.
- The remembered layout comes from the loaded report, whichever way it was loaded. It is read on entry from Search as well as from the toolbar.
- Only an explicit switch remembers the grid; a link that opens the filmstrip is remembered too.
- Only a double-click on a card's screenshot opens the filmstrip. The route under it copies a link and selects nothing.
- Only the middle frame is in the tab order, and the stage clips rather than hides its overflow, so focus cannot scroll it off centre.
- A click around the strip no longer clears the selection.
- The scrubber groups runs of top-level screens, so an app with many top-level routes shows a few groups, not one per route.
- A landscape frame no longer overflows a narrow stage.
- The current tick has aria-current.
2026-10-22 23:41:18 -07:00
Brent Vatne 500616b1b2 Screens: a filmstrip layout beside the grid, switched from the Screens tab; the sidebar's title shares a row with Find and fold-all
The filmstrip shows one screen at a time: the focused screen large in the middle, the screens before and after it smaller and fainter with distance, in the tree's order. Above it, the tree rows it was opened from; below it, its name, how it was reached and its place, and a scrubber with a tick per screen grouped by the tree's top rows, changed screens outlined.

- While Screens is open its tab in the bottom bar holds a Grid / Filmstrip switch, and clicking Screens again steps to the other layout.
- A double-click on a card opens it in the filmstrip. With the Inspector closed, Esc steps back out to the grid, keeping the selection.
- ← and → step the middle screen, and Return opens it in the Inspector, as in the grid.
- The layout is in the URL (`layout=filmstrip`) and remembered per report. Phones keep their list.

In the sidebar, "Explored app" now sits in the row with Find and fold-all. Changed / All follows under it only when there are changes, so a report without changes no longer has an empty row with two icons in the corner.
2026-10-22 22:59:32 -07:00
5 changed files with 9 additions and 39 deletions

No files matched your search

+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "@expo/explore",
"version": "0.21.0",
"version": "0.20.7",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@expo/explore",
"version": "0.21.0",
"version": "0.20.7",
"license": "MIT",
"dependencies": {
"@expo/repack-app": "0.10.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/explore",
"version": "0.21.0",
"version": "0.20.7",
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
"license": "MIT",
"type": "module",
+2 -12
View File
@@ -85,20 +85,10 @@ jobs:
- *install-explore
- name: Install the launch recording decoder
shell: bash
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it. A package
# mirror can stall without failing, so each apt-get call has network timeouts and a time limit, and a stalled
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout.
timeout-minutes: 10
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it.
run: |
set -euo pipefail
if ! command -v ffmpeg > /dev/null; then
apt=(sudo apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
for attempt in 1 2; do
if timeout 120 "${apt[@]}" update && timeout 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if [ "$attempt" = 2 ]; then echo '::error title=LAUNCH_DECODER_INSTALL_FAILED::apt-get could not install ffmpeg; rerun the job.'; exit 1; fi
echo "::warning title=LAUNCH_DECODER_INSTALL_RETRY::apt-get did not install ffmpeg on attempt $attempt; trying again."
done
fi
command -v ffmpeg > /dev/null || { sudo apt-get update -qq && sudo apt-get install -y -qq --no-install-recommends ffmpeg > /dev/null; }
ffmpeg -version | head -1
- name: Verify deterministic source planning
shell: bash
+2 -12
View File
@@ -122,20 +122,10 @@ jobs:
- *install-explore
- name: Install the launch recording decoder
shell: bash
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it. A package
# mirror can stall without failing, so each apt-get call has network timeouts and a time limit, and a stalled
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout.
timeout-minutes: 10
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it.
run: |
set -euo pipefail
if ! command -v ffmpeg > /dev/null; then
apt=(sudo apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
for attempt in 1 2; do
if timeout 120 "${apt[@]}" update && timeout 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if [ "$attempt" = 2 ]; then echo '::error title=LAUNCH_DECODER_INSTALL_FAILED::apt-get could not install ffmpeg; rerun the job.'; exit 1; fi
echo "::warning title=LAUNCH_DECODER_INSTALL_RETRY::apt-get did not install ffmpeg on attempt $attempt; trying again."
done
fi
command -v ffmpeg > /dev/null || { sudo apt-get update -qq && sudo apt-get install -y -qq --no-install-recommends ffmpeg > /dev/null; }
ffmpeg -version | head -1
- name: Verify deterministic source planning
env:
+2 -12
View File
@@ -111,20 +111,10 @@ jobs:
with: { ref: '${{ steps.pr.outputs.head }}', path: app-head, fetch-depth: 0, persist-credentials: false }
- name: Install the launch recording decoder
shell: bash
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it. A package
# mirror can stall without failing, so each apt-get call has network timeouts and a time limit, and a stalled
# attempt is tried once more: the step fails in minutes rather than holding the job to its timeout.
timeout-minutes: 10
# Launch recordings (capture.launch) are decoded with ffmpeg; GitHub's Ubuntu runners do not ship it.
run: |
set -euo pipefail
if ! command -v ffmpeg > /dev/null; then
apt=(sudo apt-get -qq -o Acquire::Retries=3 -o Acquire::http::Timeout=30 -o Acquire::https::Timeout=30 -o DPkg::Lock::Timeout=120)
for attempt in 1 2; do
if timeout 120 "${apt[@]}" update && timeout 120 "${apt[@]}" install -y --no-install-recommends ffmpeg > /dev/null; then break; fi
if [ "$attempt" = 2 ]; then echo '::error title=LAUNCH_DECODER_INSTALL_FAILED::apt-get could not install ffmpeg; rerun the job.'; exit 1; fi
echo "::warning title=LAUNCH_DECODER_INSTALL_RETRY::apt-get did not install ffmpeg on attempt $attempt; trying again."
done
fi
command -v ffmpeg > /dev/null || { sudo apt-get update -qq && sudo apt-get install -y -qq --no-install-recommends ffmpeg > /dev/null; }
ffmpeg -version | head -1
- name: Verify deterministic source planning
env: