Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
951d14dfe3 | ||
|
|
e8ca6b8fb4 | ||
|
|
18ba3d4069 | ||
|
|
da5cb12b16 | ||
|
|
ec75e37e45 | ||
|
|
1254a99841 | ||
|
|
c2bae00f31 | ||
|
|
65b79684f3 | ||
|
|
b8b43ee2c8 | ||
|
|
c59ccce32b | ||
|
|
c24049c443 | ||
|
|
cefeb8059a | ||
|
|
078902710b | ||
|
|
46ff99aad1 |
No files matched your search
@@ -76,9 +76,14 @@ jobs:
|
||||
| [$marker,
|
||||
"**Viewer preview** of \($sha)\(if $source != "" then " · reports from \($source)" else "" end)",
|
||||
"",
|
||||
"| Platform | Changes | Open |",
|
||||
"| Report | Changes | Open |",
|
||||
"| --- | --- | --- |",
|
||||
($reports[] | "| \(if .platform == "ios" then "iOS" else "Android" end)\(if .device then " · \(.device)" else "" end) | \(.changes // "–") | [Map](\($url)?platform=\(.platform)) · [Screens](\($url)?platform=\(.platform)#/screens) · [Compare](\($url)?platform=\(.platform)&view=compare) |"),
|
||||
# One row per target, named by its label; a target named after its platform keeps ?platform= links.
|
||||
($reports[]
|
||||
| (.target // .platform) as $id
|
||||
| "\(if $id == "ios" or $id == "android" then "platform" else "target" end)=\($id)" as $query
|
||||
| ((.label // (if .platform == "ios" then "iOS" else "Android" end)) | gsub("\\|"; "\\\\|")) as $name
|
||||
| "| \($name)\(if .device then " · \(.device)" else "" end) | \(.changes // "–") | [Map](\($url)?\($query)) · [Screens](\($url)?\($query)#/screens) · [Compare](\($url)?\($query)&view=compare) |"),
|
||||
"",
|
||||
"The link stays the same on every push. [Deploy run](\($run))"]
|
||||
| join("\n")' "$RUNNER_TEMP/preview.json" > "$RUNNER_TEMP/comment.md"
|
||||
|
||||
@@ -57,7 +57,7 @@ Each workflow starts with a `targets` job: it installs the pinned CLI and runs `
|
||||
| | Package hosted review bundle | `ci:report` writes the report directory. |
|
||||
| | Upload hosted review bundle | `explore-review-<run>-<attempt>-<target>`, kept 30 days. |
|
||||
| | Publish current PR hosted links | `ci:publish` re-checks that the artifact belongs to this PR, then updates the sticky comment with **Open** (the hosted Viewer) and **zip**. The comment is rendered from one hidden record per target (`<!-- expo-explore-record:<target>:… -->`, plus one history line for earlier runs); each job folds its own record into the ones the comment already carries and re-renders the whole comment, so parallel targets do not overwrite each other. Rows, report links and validation columns are labelled with the target's label (`iOS` and `Android` without `targets:`) and follow config order. |
|
||||
| `deploy` (only when `report.preview` is set; after every report job) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every target's capture and report artifacts, zips and encrypts each report, deploys it with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report** and the link's expiry. |
|
||||
| `deploy` (only when `report.preview` is set; after every report job) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every target's capture and report artifacts, writes each report's manifest and screenshots as static files under the link's token, deploys them with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report**. The link works as long as the EAS Hosting deployment. |
|
||||
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only the failed target's record when the run has several; the target is the id the failed job's diagnostics artifact name ends with, and its label comes from the record the capture job already posted. |
|
||||
|
||||
A reviewer downloads the report ZIP and drops it on the hosted Viewer; downloading needs read access to the repository.
|
||||
@@ -68,7 +68,7 @@ Validate baseline source → Install Explore → Verify deterministic source pla
|
||||
|
||||
### 2.4 `explore-compare.yml`
|
||||
|
||||
The same jobs as a PR review, for any `base` and `head` without a pull request. The `targets` job resolves both refs once with `ci:compare-refs` (a tag wins over a branch of the same name; the same commit twice fails with `COMPARE_SAME_COMMIT`) and passes the comparison to the capture jobs, which run `capture:review --compare` with no GitHub requests. The optional `scope` and `expires-in` inputs override `exploration.scope` and `report.preview.expiresAfter` for that run. The report job's `ci:publish` writes each target's **Open** and **zip** links to the run summary, and the deploy job adds the hosted link there; nothing comments on a pull request.
|
||||
The same jobs as a PR review, for any `base` and `head` without a pull request. The `targets` job resolves both refs once with `ci:compare-refs` (a tag wins over a branch of the same name; the same commit twice fails with `COMPARE_SAME_COMMIT`) and passes the comparison to the capture jobs, which run `capture:review --compare` with no GitHub requests. The optional `scope` input overrides `exploration.scope` for that run; `expires-in` is accepted and ignored. The report job's `ci:publish` writes each target's **Open** and **zip** links to the run summary, and the deploy job adds the hosted link there; nothing comments on a pull request.
|
||||
|
||||
## 3. Inside `capture:review` (`runCiReview`)
|
||||
|
||||
|
||||
@@ -3,29 +3,29 @@
|
||||
Explore maps your app: a screenshot of every screen, connected by the taps between them. On each pull request it captures the screens the PR changes, before and after, on EAS Simulator, and posts a visual review. On your Mac it can also run on a local simulator.
|
||||
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-hero-dark.png">
|
||||
<img alt="Explore's Map of a euxy pull request, zoomed in on the new About screen, marked Added among the modified Patterns screens, with its transitions highlighted and the Inspector open on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.png">
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-hero-dark.svg">
|
||||
<img alt="Explore's Map of a euxy pull request, animated: the screen cards appear row by row, the new About screen marked Added among the modified Patterns screens, the transitions between them wipe in, then a click selects About, its transitions light up and the Inspector slides in on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.svg">
|
||||
</picture>
|
||||
|
||||
**See a real report:** [euxy](https://explore-example--euxy.expo.app/p/rfcoic27ccgnrmzgijubxkmuzmptcrva?platform=ios), a MIDI sequencer, reviewed by Explore. It is redeployed with the current Viewer on every merge to main.
|
||||
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-compare-dark.svg">
|
||||
<img alt="The euxy Patterns screen wiping from its capture before the pull request to its capture after it: each pattern row's tempo moves out of the subtitle into its own column on the right, then the changed subtitles are outlined" src="docs/screenshots/readme-compare-light.svg">
|
||||
</picture>
|
||||
|
||||
**Compare**: each changed screen before and after, with the changed regions outlined.
|
||||
|
||||
<table>
|
||||
<tr>
|
||||
<td width="33%" valign="top">
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-compare-dark.png">
|
||||
<img width="100%" alt="The Compare view with the euxy Patterns screen's before and after captures side by side: each pattern row's tempo moved out of the subtitle into its own column on the right, the changed subtitles outlined in both" src="docs/screenshots/readme-compare-light.png">
|
||||
</picture>
|
||||
<strong>Compare</strong>: each changed screen before and after, with the changed regions outlined.
|
||||
</td>
|
||||
<td width="33%" valign="top">
|
||||
<td width="50%" valign="top">
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-screens-dark.png">
|
||||
<img width="100%" alt="The Screens view of a euxy review: the app/ route tree on the left under Changed 9 and All 19, and a grid of screen cards beside it in the same order, each with its route below the screenshot and a dot before it: green for the new /about, orange for modified screens such as /activity-log, /settings and /patterns, red for the removed /channel-surf" src="docs/screenshots/readme-screens-light.png">
|
||||
</picture>
|
||||
<strong>Screens</strong>: every capture in one grid, beside the route tree, with a dot for what changed.
|
||||
</td>
|
||||
<td width="33%" valign="top">
|
||||
<td width="50%" valign="top">
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-pr-comment-dark.png">
|
||||
<img width="100%" alt="Explore's GitHub PR comment on a euxy PR: the heading links to the iOS and Android reports, a table with one row per platform giving device, result and an Open link, the Added, Removed, Modified, Needs review and Source-affected screens as collapsed lists, fading out below them" src="docs/screenshots/readme-pr-comment-light.png">
|
||||
@@ -80,7 +80,10 @@ describes, never for a password in chat. Open the report, and if I need to log i
|
||||
something first, tell me the command.
|
||||
```
|
||||
|
||||
You need Node.js 24.12+. Reviewing a change needs an Expo account and an Expo SDK 57+ app with Expo Router or React Navigation: it is built on EAS and captured on EAS Simulator ([join the waitlist](https://expo.dev/services/simulators)) or, with Xcode, on a simulator on your Mac. Exploring a build needs a Claude Code or Codex login, and EAS Simulator or a simulator on your Mac; on your Mac, no Expo account. No API keys, no CI.
|
||||
You need Node.js 24.12+. Reviewing a change needs an Expo account and an Expo SDK 57+ app with Expo Router or React Navigation: it is built on EAS and captured on EAS Simulator or, with Xcode, on a simulator on your Mac. Exploring a build needs a Claude Code or Codex login, and EAS Simulator or a simulator on your Mac; on your Mac, no Expo account. No API keys, no CI.
|
||||
|
||||
> [!NOTE]
|
||||
> EAS Simulator is in preview. [Join the waitlist](https://expo.dev/services/simulators), or pass `--simulator local` to capture on a simulator on your Mac.
|
||||
|
||||
<details>
|
||||
<summary><strong>Run it yourself</strong></summary>
|
||||
@@ -123,6 +126,9 @@ Explore starts an EAS Simulator, installs the build, taps through the app with y
|
||||
|
||||
</details>
|
||||
|
||||
> [!WARNING]
|
||||
> A review runs both commits' code on your machine, as you: it installs their dependencies, evaluates the app config and bundles the JavaScript. Review only commits you would run yourself, and someone else's branch only if you trust it.
|
||||
|
||||
Every run is kept on your machine for 30 days. `npx @expo/explore reports` lists your local reviews, explorations and uploaded reports with their commits, and reopens or hosts one without capturing again:
|
||||
|
||||
<picture>
|
||||
@@ -139,9 +145,8 @@ npx @expo/explore capture --committed # HEAD alone
|
||||
npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all --upload
|
||||
```
|
||||
|
||||
- It checks out both commits as temporary worktrees, installs their dependencies, captures every configured platform or [target](#targets) on EAS Simulator or a [local simulator](#simulator), and opens the report in a local Viewer. `--target` or `--platform` picks some; they run at once, at most `--parallel N` at a time. `--upload` hosts it for 30 days (`--expires-in` changes that) and prints the link; `report:upload <report.zip>` hosts one you already have.
|
||||
- It checks out both commits as temporary worktrees, installs their dependencies, captures every configured platform or [target](#targets) on EAS Simulator or a [local simulator](#simulator), and opens the report in a local Viewer. `--target` or `--platform` picks some; they run at once, at most `--parallel N` at a time. `--upload` hosts it and prints the link; `report:upload <report.zip>` hosts one you already have.
|
||||
- Your checkout, index and branches are never touched. Your uncommitted changes, untracked files included, are reviewed as `eas build` would upload them; `--committed`, or `cli.requireCommit: true` in `eas.json`, leaves them out.
|
||||
- It runs both commits' code on your machine, as you: installing their dependencies, evaluating the app config, and bundling the JavaScript. That is what checking them out and running them would do, so review only commits you would run, and someone else's branch only if you trust it.
|
||||
- Installs run without credential environment variables, which keeps tokens out of reach of a registry a commit's `.npmrc` names; that is not a sandbox. A registry that needs `${NPM_TOKEN}` in the project's `.npmrc` must be authenticated in your own `~/.npmrc`.
|
||||
- Captures are cached in `~/.cache/expo-explore`, so the same base is not captured twice (`--no-cache` skips it); a capture unused for 30 days goes, and the cache stays under 2 GB. Ctrl+C stops the run's simulator sessions and local devices; when a run is stopped harder than that, the next local run stops what it left running.
|
||||
- Like a CI review, it builds on EAS (reusing a matching build) and, unless it captures on a local simulator, runs EAS Simulator sessions: expect several minutes and EAS usage.
|
||||
@@ -165,7 +170,7 @@ Pointed to a build, the [quick start](#quick-start) maps every screen of it, wit
|
||||
- A run stops after 15 minutes, 40 screens, or 150 actions (`--max-duration-minutes`, `--max-screens`, `--max-actions`).
|
||||
- Buttons that delete, pay, sign out, send, or leave the app are never tapped. `--allow-destructive "Reset filters"` allows one by its exact label.
|
||||
- `--hints "…"` tells the model what to focus on or how to sign in ([details](#sign-in-and-other-app-state)).
|
||||
- On EAS Simulator the report is hosted, and the link lasts 7 days (`--expires-in` takes 1d to 90d, or never); `--no-upload` keeps it local. On a local simulator it opens in the local Viewer (`--no-open` or `--json` skips that; `view --dir <folder>` opens it later), and `--upload` hosts it, which needs an EAS login. `--json` prints the result for scripts.
|
||||
- On EAS Simulator the report is hosted, and the link lasts as long as its EAS Hosting deployment (see [report access](docs/private-review.md#hosted-previews)); `--no-upload` keeps it local. On a local simulator it opens in the local Viewer (`--no-open` or `--json` skips that; `view --dir <folder>` opens it later), and `--upload` hosts it, which needs an EAS login. `--json` prints the result for scripts.
|
||||
- For a link that stays the same from run to run, pass `--alias NAME` and set `EXPLORE_PREVIEW_TOKEN` to a fixed token of 32 characters from a–z and 2–7 (`LC_ALL=C tr -dc a-z2-7 </dev/urandom | head -c 32`).
|
||||
- EAS Simulator sessions and hosted reports run under an EAS project named `expo-explore` in your account, created on first use (`--owner` and `--project` pick another).
|
||||
- Read a local result with `npx @expo/explore view --dir <folder>`, `screen:list`, or `gap:list`.
|
||||
@@ -222,7 +227,6 @@ By default reviewers download the report from GitHub. With hosted previews, the
|
||||
report:
|
||||
preview:
|
||||
hosting: eas # default: off
|
||||
expiresAfter: 30d # default 30d, max 365d, or never
|
||||
# project: acme-explore # default <repository name>-explore, created on first run
|
||||
```
|
||||
|
||||
@@ -230,7 +234,7 @@ report:
|
||||
- A [comparison of two commits](#compare-any-two-commits) links its hosted report from the run's summary instead of a PR comment. `capture --upload` on your machine deploys to the same project with your `eas login`.
|
||||
- `expo-explore report:upload <report.zip>...` hosts reports already on your machine the same way: a review's reports (one per platform or target, from `capture --output` or a downloaded `explore-review` artifact) or an `explore:binary` report.
|
||||
- `EXPO_TOKEN` must be able to create the EAS project, so use a [robot user's](https://docs.expo.dev/accounts/programmatic-access/) token.
|
||||
- The report is encrypted, and only a request carrying the link's token can open it. Treat the link like a shared file link; see [report access](docs/private-review.md#hosted-previews).
|
||||
- Every file of the report sits under the link's 160-bit token, so only someone with the link can open it. Treat the link like a shared file link. It works as long as its EAS Hosting deployment does: EAS deletes one without an alias after 30 days on the Free plan and 90 on paid plans, and you can delete it sooner (`eas deploy:delete`) or on your own schedule. Explore sets no expiry of its own; see [report access](docs/private-review.md#hosted-previews).
|
||||
|
||||
</details>
|
||||
|
||||
@@ -341,7 +345,7 @@ Explore pins each controller's version and starts the EAS session with it. Repor
|
||||
|
||||
Neither controller is installed with Explore. The first run that needs one downloads its pinned npm release (agent-device 1.6 MB, Argent 27 MB), checks it against the integrity hash Explore pins, and keeps it in `~/.cache/expo-explore/controllers` (`EXPLORE_CONTROLLER_CACHE` moves it). Behind a private registry, set `EXPLORE_NPM_REGISTRY` to a mirror of it.
|
||||
|
||||
Argent cannot switch the simulator's appearance yet ([software-mansion/argent#1509](https://github.com/software-mansion/argent/pull/1509)), so an Argent capture on EAS Simulator records one appearance: the one the app forces, else light. Explore warns when it skips one. On a [local simulator](#simulator) the host switches it, so every appearance the config asks for is captured.
|
||||
Argent cannot switch the simulator's appearance yet ([software-mansion/argent#1509](https://github.com/software-mansion/argent/pull/1509)), so the host switches it: on an iOS EAS Simulator session (`eas simulator:control appearance.set`) and on a [local simulator](#simulator), every appearance the config asks for is captured. An Argent capture on an Android EAS Simulator session records one appearance: the one the app forces, else light. Explore warns when it skips one.
|
||||
|
||||
</details>
|
||||
|
||||
@@ -372,7 +376,7 @@ For a review, builds still run on EAS. The app is repacked with the route observ
|
||||
|
||||
With `--controller argent`, Explore installs Argent's tool-server on first use with `npm ci` from a lockfile Explore ships, so every dependency is pinned (about 160 MB, in the controller cache), and starts one per device. The host switches the appearance, so a local Argent capture records every appearance the config asks for. Reports record where they were captured, and a baseline is reused only by a review captured the same way.
|
||||
|
||||
A foldable folds before the app first opens (`pose` on a [target](#targets)); with agent-device on a local simulator it folds just after, since agent-device folds only inside a session. With Argent, an opened iPhone Duo is captured upright, in landscape. After a fold, Argent's reader can stay on the panel that went dark; Explore then restarts its tool-server, and if that is not enough SpringBoard as well, and opens the app again.
|
||||
A foldable folds before the app first opens (`pose` on a [target](#targets)); with agent-device on a local simulator it folds just after, since agent-device folds only inside a session. With Argent, an opened iPhone Duo is captured upright, in landscape. After a fold, Argent's reader can stay on the panel that went dark, so Explore checks that the lit panel is read. If it isn't, Explore restarts the tool-server on a local simulator. On EAS Simulator, where the tool-server is the session's, it resets Argent's device helpers, then restarts SpringBoard and folds again. On EAS Simulator, an opened iPhone Duo usually needs that SpringBoard restart, which adds about a minute.
|
||||
|
||||
Each capture records what it starts on your Mac (simulators, emulators, controller daemons, tool-servers) and removes it when it ends. If a review or a local `explore:binary` run is stopped hard, the next local one stops what it left running; nothing Explore did not record is touched.
|
||||
|
||||
@@ -401,11 +405,11 @@ give me the report link.
|
||||
|
||||
There are a few ways to snapshot a release:
|
||||
|
||||
- **On demand:** in your repository's Actions tab, open **Expo Explore compare**, choose **Run workflow**, and set `base` to the last release's tag (`v1.3.0`), `head` to the new tag or release candidate (`v1.4.0-rc.1`), `scope` to `all` and `expires-in` to `never`. The run's summary links the report.
|
||||
- **On demand:** in your repository's Actions tab, open **Expo Explore compare**, choose **Run workflow**, and set `base` to the last release's tag (`v1.3.0`), `head` to the new tag or release candidate (`v1.4.0-rc.1`), and `scope` to `all`. The run's summary links the report.
|
||||
- **Automatically, on every tag:** add the `release-review.yml` in [The comparison workflow](#compare) below. It compares each tag, release candidates included, with the last stable tag, so a release candidate is reviewed against what people have now.
|
||||
- **On your machine, without CI:** `npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all --upload`, with your `eas login`. `npx @expo/explore reports` lists the runs you have kept.
|
||||
|
||||
`scope: all` captures every screen, not only those whose source changed, so the report shows the whole release with what changed since the last one marked; `expires-in: never` keeps its link.
|
||||
`scope: all` captures every screen, not only those whose source changed, so the report shows the whole release with what changed since the last one marked.
|
||||
|
||||
<details>
|
||||
<summary id="compare"><strong>The comparison workflow</strong></summary>
|
||||
@@ -438,16 +442,15 @@ jobs:
|
||||
base: '${{ needs.previous.outputs.tag }}'
|
||||
head: '${{ github.ref_name }}'
|
||||
scope: all # every screen, not only those whose source changed
|
||||
expires-in: never # keep the hosted link (with report.preview.hosting: eas)
|
||||
secrets: inherit
|
||||
```
|
||||
|
||||
- Pick whatever `base` the event calls for: `main` for a release branch, yesterday's tag for a nightly, the last stable tag for a release candidate.
|
||||
- `scope` and `expires-in` are optional and override `exploration.scope` and `report.preview.expiresAfter` for that run. Without them a comparison captures what a PR review would (`scope: changes` captures only screens whose source changed), and the hosted link expires like a PR's.
|
||||
- `scope` is optional and overrides `exploration.scope` for that run. Without it a comparison captures what a PR review would (`scope: changes` captures only screens whose source changed). The hosted link lasts as long as its deployment, like a PR's; `expires-in` from earlier versions of this workflow is accepted and ignored.
|
||||
- The run summary links each target's report (**Open** and **zip**, like a PR comment) and, with hosting, the hosted report.
|
||||
- `setup --workflows` installs it from 0.19.0; `npx @expo/explore@latest setup --workflows` adds it to an existing setup. The caller grants `contents: read` and `actions: read`; `secrets: inherit` passes `EXPO_TOKEN` and any app-test secrets.
|
||||
- Call it once per workflow run. A called workflow runs inside its caller's run, so a second call in the same run would reuse the first one's artifact names; use separate workflows instead.
|
||||
- When the baseline workflow captured `base` in the last 30 days, with the same config and Explore version, that capture is reused and only `head` is captured. The report artifact is kept 30 days; only a hosted link with `expires-in: never` lasts longer.
|
||||
- When the baseline workflow captured `base` in the last 30 days, with the same config and Explore version, that capture is reused and only `head` is captured. The report artifact is kept 30 days; a hosted link lasts as long as its EAS Hosting deployment (an aliased one until the alias moves).
|
||||
|
||||
</details>
|
||||
|
||||
@@ -501,7 +504,7 @@ The same link answers differently depending on who asks. It already carries the
|
||||
- Anything that does not ask for HTML (`curl`, `fetch`, agents' URL tools) gets a Markdown index of the report, also at `/llms.txt`.
|
||||
- The index links to a read-only JSON API under `/api/v1`: `/screens?status=modified,accessibility-only,added,removed`, `/screens/<id>`, `/transitions`, and `/raw` for the report file.
|
||||
- Reports without source also expose `/journeys`, `/gaps`, and `/frontier`.
|
||||
- A link to several targets takes `?target=<id>` and serves the first without it; `/reports.json` lists them (`?platform=ios|android` from older links still works). Expired links' report and API routes answer `410`.
|
||||
- A link to several targets takes `?target=<id>` and serves the first without it; `/reports.json` lists them (`?platform=ios|android` from older links still works).
|
||||
|
||||
```sh
|
||||
curl -s "$LINK/api/v1/screens?status=modified" | jq '.items[] | {route, status, review}'
|
||||
@@ -512,11 +515,28 @@ curl -s "$LINK/api/v1/screens?status=modified" | jq '.items[] | {route, status,
|
||||
<details>
|
||||
<summary><strong>How it works</strong></summary>
|
||||
|
||||
1. The review workflow runs on open, non-draft PRs from the repository whose author has write access. Bots such as Devin go under `ci.trustedAuthors` in `.expo-explore/config.yaml`.
|
||||
2. Explore reads the diff and your router source to pick the affected screens.
|
||||
3. It builds both revisions on EAS (reusing a build with the same native fingerprint) and captures each screen on EAS Simulator (or, on your machine, a local simulator), reusing a baseline of the base commit when one exists.
|
||||
4. It compares the captures. A screen with a source change is **Modified** if its captures differ.
|
||||
5. It uploads the report to GitHub Actions and posts a PR comment.
|
||||
```mermaid
|
||||
sequenceDiagram
|
||||
autonumber
|
||||
participant PR as Pull request
|
||||
participant GA as GitHub Actions
|
||||
participant B as EAS Build
|
||||
participant S as EAS Simulator
|
||||
PR->>GA: opened or updated
|
||||
GA->>GA: read the diff and router source, pick the affected screens
|
||||
GA->>B: build base and head
|
||||
Note over B: reuses a build with the same native fingerprint
|
||||
B-->>GA: simulator builds
|
||||
GA->>S: capture each affected screen, in each appearance
|
||||
Note over S: the base reuses its baseline when one exists
|
||||
S-->>GA: screenshots
|
||||
GA->>GA: compare the captures, outline the changed regions
|
||||
GA->>PR: upload the report, comment with its links
|
||||
```
|
||||
|
||||
- The review workflow runs on open, non-draft PRs from the repository whose author has write access. Bots such as Devin go under `ci.trustedAuthors` in `.expo-explore/config.yaml`.
|
||||
- A screen with a source change is **Modified** if its captures differ.
|
||||
- If EAS fails to start a session, Explore starts a new one, up to five times within 30 minutes. On your machine, a local simulator can stand in for EAS Simulator.
|
||||
|
||||
The same review runs for any two commits without a PR ([`explore-compare.yml`](#compare-any-two-commits), linking the report from the run summary) and on your machine (`capture`, [above](#quick-start)). The workflows' logic lives in `expo-explore ci:*` commands, so a fix reaches CI with the `@expo/explore` version the workflows pin.
|
||||
|
||||
@@ -533,8 +553,7 @@ Reports and baselines are kept for 30 days and diagnostics for 7. Hosted deploym
|
||||
- The launch is captured once per appearance and compared like any screen. The comment says how long the splash stayed as it first appeared, when it first changed (a native launch screen handing over to an app-drawn one, an animation starting on it), and when the first screen settled. `capture.launch: video` adds a recording; a launch too fast to observe is reported as "no splash observed".
|
||||
- On Android the splash usually shows only in the recording, which needs `ffmpeg`. The generated workflows install it.
|
||||
- Hosted acceptance of agent mode with an API key is incomplete.
|
||||
- With `capture.controller: argent` on EAS Simulator, each capture records one appearance (see [device controller](#controller)).
|
||||
- On EAS Simulator, an opened iPhone Duo can fail to capture when Argent's reader stays on the cover panel after the fold. A [local simulator](#simulator) recovers from it.
|
||||
- With `capture.controller: argent` on an Android EAS Simulator session, each capture records one appearance (see [device controller](#controller)).
|
||||
- A local simulator runs only on your machine; the CI workflows capture on EAS Simulator.
|
||||
- `explore:session` explores EAS Simulator sessions only.
|
||||
|
||||
|
||||
@@ -16,18 +16,18 @@ Hosted previews are off by default. When `report.preview.hosting: eas` is set, t
|
||||
|
||||
**What a reviewer needs.** Only the link. It looks like `https://acme-explore--k7f3z0d1q8.expo.app/p/f6r2…` and carries a 160-bit token generated for that run. It opens the Viewer and the report for one PR revision; it does not show the repository, other runs, or anything else in the Expo account.
|
||||
|
||||
**Several platforms or targets.** One deployment holds every target's report (a config without `targets` has one per platform). The link opens the first one (`?target=<id>` selects another, and `?platform=ios` or `?platform=android` from older links still works); the Viewer's menu lists the others from `/p/<token>/reports.json`, which names each target, its platform, label, device, and change count and nothing else. Every report and the listing sit behind the same token and expiry.
|
||||
**Several platforms or targets.** One deployment holds every target's report (a config without `targets` has one per platform). The link opens the first one (`?target=<id>` selects another, and `?platform=ios` or `?platform=android` from older links still works); the Viewer's menu lists the others from `/p/<token>/reports.json`, which names each target, its platform, label, device, and change count and nothing else. Every report and the listing sit behind the same token.
|
||||
|
||||
**What is protected, and how.**
|
||||
|
||||
- *The report bytes.* `ci:deploy` zips the report and encrypts it (AES-256-GCM) before upload. The key is stored only in that deployment's server environment; it never appears in a URL, a log line, or a comment. The files on the CDN are ciphertext.
|
||||
- *Access to the decrypted report.* A server route in the deployment checks the token and the expiry, fetches the ciphertext from its own deployment, decrypts it, and streams it to the browser. Without the exact token every path under the deployment answers `404`, including the Viewer itself; `ci:deploy` verifies this before it publishes the link.
|
||||
- *Expiry.* The expiry (`report.preview.expiresAfter`, 30 days by default, `never` to disable) is sealed into the deployment when it is created and enforced by the route, not by the browser. After it passes, the exact token still opens the Viewer for a browser, but the report routes, the Markdown index, and the agent API answer `410` and the Viewer says the link expired on that date; every other path still answers `404`. To revoke a link earlier, delete the deployment in the EAS Hosting dashboard; the CDN stops serving it within seconds and the route within a few minutes.
|
||||
- *Deletion.* Nothing is deleted automatically. Each review of a pull request deploys a new preview and the comment links the newest one (recorded in a hidden `<!-- expo-explore-deployments:… -->` line under the comment marker); earlier deployments and the deployments of closed pull requests stay until someone deletes them in the EAS Hosting dashboard or with `eas deploy:delete`, so a link keeps opening for as long as its expiry allows.
|
||||
- *The token.* Every path of a preview carries the link's 160-bit token: the page at `/p/<token>`, each target's manifest at `/p/<token>/targets/<target>.json`, and every screenshot at `/p/<token>/assets/<sha256>.<ext>`. Nobody can find a path without the token. With any other token, every path under the deployment answers `404`, including the Viewer itself; `ci:deploy` verifies this before it publishes the link.
|
||||
- *The report's files.* `ci:deploy` uploads the report as plain static files of the deployment, under the token. They are not encrypted: the token in their paths is what keeps them private, the same way it keeps the link private. EAS Hosting serves them directly, with its own default headers (the browser may cache a screenshot for an hour), and it cannot add `noindex` to them, so the deployment's `robots.txt` keeps crawlers away from them instead. The deployment's server route serves the page, the manifest the Viewer asks for, the target listing and the agent API, with `private, no-store` and `noindex`.
|
||||
- *How long a link works.* A link works as long as its EAS Hosting deployment exists. Explore sets no expiry of its own. EAS Hosting deletes a deployment after 30 days on the Free plan and 90 days on paid plans, **unless an alias points at it**: an aliased deployment (such as `--alias` uploads of `explore:binary`) is kept until the alias moves or is deleted. To end a link sooner, delete the deployment in the EAS Hosting dashboard or with `eas deploy:delete` (delete its alias first if it has one); the CDN stops serving its files within about five minutes. To expire links on your own schedule, delete deployments from a scheduled job. Deleting a deployment does not reach into a browser that already opened the link: what that browser cached stays until it ages out. `report.preview.expiresAfter` and `--expires-in` from earlier versions are accepted and ignored, with a warning.
|
||||
- *Deletion.* Explore deletes nothing. Each review of a pull request deploys a new preview and the comment links the newest one (recorded in a hidden `<!-- expo-explore-deployments:… -->` line under the comment marker); earlier deployments and the deployments of closed pull requests stay until EAS Hosting deletes them as above, or someone deletes them in the dashboard or with `eas deploy:delete`.
|
||||
- *The Viewer itself.* The Viewer's JavaScript is public and the same for every deployment; it holds no report data.
|
||||
- *Agent access.* The same link also answers as Markdown and as a JSON API (`/llms.txt`, `/api/v1/...`, see [the agent guide](../README.md#agents)) so a coding agent can read the report without a download. Those routes are served by the same server route from the same decrypted bytes, behind the same token, expiry, `private, no-store`, and `noindex`; they add no second credential and no new place where the report is stored.
|
||||
- *Agent access.* The same link also answers as Markdown and as a JSON API (`/llms.txt`, `/api/v1/...`, see [the agent guide](../README.md#agents)) so a coding agent can read the report without a download. Those routes read the same static files, behind the same token, with `private, no-store` and `noindex`; they add no second credential and no new place where the report is stored.
|
||||
|
||||
**What is not protected.** The link is a bearer credential. Anyone who receives it, by forwarding the comment, a notification email, or a chat message, can open the report until it expires. Members of the Expo account who can inspect the preview project's deployments can read the key. Expo's request logs record URL paths, so they record the token; they do not record the report. Keep the default drop flow when a leaked link would be a problem.
|
||||
**What is not protected.** The link is a bearer credential. Anyone who receives it, by forwarding the comment, a notification email, or a chat message, can open the report until the deployment is deleted. A screenshot's URL contains the token, so it is the link too: anyone who copies a screenshot's address can open the whole report. Members of the Expo account who can inspect the preview project's deployments can read its files. Expo's request logs record URL paths, so they record the token. Keep the default drop flow when a leaked link would be a problem.
|
||||
|
||||
**Comparison with the default.** The default flow uses GitHub's own permissions: a reviewer must be signed in to GitHub with read access to the repository to download the report. Hosted previews trade that check for one-click opening. Choose them when the review audience is the people who already see the PR.
|
||||
|
||||
|
||||
@@ -105,7 +105,7 @@ device:
|
||||
exploration:
|
||||
scope: changes # changes | all
|
||||
capture:
|
||||
# controller: agent-device # agent-device (default) | argent (one appearance per capture on EAS Simulator until Argent can switch it; --controller overrides it for one run)
|
||||
# controller: agent-device # agent-device (default) | argent (one appearance per capture on Android EAS Simulator until Argent can switch it; --controller overrides it for one run)
|
||||
# simulator: eas # eas (EAS Simulator, default) | local (a simulator or emulator Explore starts on this machine with Xcode or the Android SDK; --simulator overrides it for one run)
|
||||
maxMinutes: 30
|
||||
maxActions: 500
|
||||
@@ -286,7 +286,7 @@ The provider selects the runtime that owns the navigation loop:
|
||||
| `anthropic` | Claude Code through `@anthropic-ai/claude-agent-sdk` 0.3.285 and its platform-native package | `ANTHROPIC_API_KEY` |
|
||||
| `openai` | Codex app-server from `@openai/codex` 0.159.2 and its platform-native package | `OPENAI_API_KEY` |
|
||||
|
||||
Both runtimes use Explore's device tools to operate the existing EAS Simulator through official `agent-device` 0.21.28. The runtime and native binaries come from the pinned tools installation. CI does not use the development-only `node_modules/.bin/claude` executable or an interactive subscription login.
|
||||
Both runtimes use Explore's device tools to operate the existing EAS Simulator through official `agent-device` 0.21.29-nightly.20261018.74. The runtime and native binaries come from the pinned tools installation. CI does not use the development-only `node_modules/.bin/claude` executable or an interactive subscription login.
|
||||
|
||||
Create and commit the nonempty English prose file named by `agent.instructions`. The shared setup skill authors it from source and asks for missing test data or environment inputs. Describe how to reach the app's screens, necessary prerequisites, the representative state to use on both revisions, readiness signals, and actions to avoid. This file guides the runtime agent; it is not a list of mandatory YAML steps or a second screen inventory.
|
||||
|
||||
@@ -362,6 +362,16 @@ Capture uses the automatic GitHub token with `pull-requests: write`, so it can k
|
||||
|
||||
The sticky comment is one comment for the whole run: a header with the base and head commits, one row per captured platform (device, result, **Open** / **zip** / **run** links), every changed screen listed once with a link per platform, and a collapsed validation table with one column per platform. Each platform's job updates only its own hidden record in the comment, so iOS and Android jobs never overwrite each other. When a new run starts (a push, a rerun), the earlier run moves to a collapsed **Previous runs** list that keeps its head commit, result, report and run links; the last five runs are kept. A run that finishes after the PR moved on is still published, under previous runs, instead of failing. The failure job posts through the same renderer (`ci:failure`), so a crash before the pipeline's own comment still lands in that platform's row.
|
||||
|
||||
The comment can also draw a map of the change: the added, removed and visually changed screens, the screens one step before them, and the transitions among them, as a collapsed Mermaid flowchart that GitHub draws in place. It is off by default; turn it on with:
|
||||
|
||||
```yaml
|
||||
report:
|
||||
comment:
|
||||
map: true # default false
|
||||
```
|
||||
|
||||
The map leaves out screens whose source changed but whose captures match, and it is skipped when more than 30 routes changed or when the comment would be over GitHub's size limit.
|
||||
|
||||
PR review links always use [explore-preview.expo.app](https://explore-preview.expo.app/); no viewer-origin variable is needed or accepted by the CI publisher. Reports stay in GitHub Actions: the comment's **zip** link fetches the `explore-review-<run>-<attempt>.zip` artifact (GitHub asks for sign-in and repository read access), and the page that **Open** opens takes that ZIP by drag-and-drop or **Choose file**. Nothing is enabled per repository on Expo's side. See [report access](private-review.md).
|
||||
|
||||
Credentialed capture accepts open, non-draft, same-repository PRs whose authors have current write access, or are listed under `ci.trustedAuthors` in the default branch's `.expo-explore/config.yaml` (for bots such as `devin-ai-integration[bot]`). Fork PRs cannot receive capture credentials. Tools are loaded from the pinned reviewed commit, not the PR checkout. Build execution still runs the authorized application's code.
|
||||
|
||||
|
Before Width: | Height: | Size: 451 KiB |
@@ -0,0 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /patterns screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(1,4,9,0.6)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#151B23"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#151B23" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCANqAZIDASIAAhEBAxEB/8QAHAABAAICAwEAAAAAAAAAAAAAAAMFBAYBAgcI/8QAWBAAAQMDAQQECwQHBAUKBQQDAQACAwQFERIGEyExFEFR0QcVIjJSU2GBkZKTNFRxsQgjM2OhouEWQmLBJHJ1gtIYNkNVVrKz1OLwFzdzlJUmNThEg8Px/8QAGAEBAQEBAQAAAAAAAAAAAAAAAAEDAgT/xAAdEQEBAAMBAAMBAAAAAAAAAAAAEQECAwQSMUFR/9oADAMBAAIRAxEAPwD5UREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBFs2wdn2aut0kftXeZrbbaZgkdHTRa6ircXACKIHgHHOdTuAAXptz8CuzVB4X9sLRPUXCHZPZS3suVSWva6olbuI37priManOecHHIY9qDwxF6dtdsfspd/B5Dt9sZT19sp4Lj4suNurZxPuXFupkrHhoJaRwII5nhy449DsjsFs/tZc6faXa2K8Wm3UQqIDZ8g3KcgEQNeQQzBJy49nUeQecovVdtdiNjpdktlNsrGa/Z2gvVdJQ1NLXvNTuGscA6eNzWhz2AZyMZzwCu6fYTwZbVWvaaLZ2j2lo4rHbpa2n2jrZR0atdHgBroyxujWT5IB1ezIwg8PREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEReh+C3YDZbaenr7xthtdDZLXb3sjdSwDXW1TneaImYPPB4gO4jl1oPPEX0xUeDTwVMt5kqvB34VrbQacm7vpc7tvrHMy4hvXnR7l414T9iLNsXdaQbP7U0O0druEHSaeaA4ljZnGmVv913A+3gcgckGmIvQPA/4M5PCZtDFao5IY3SF+XzaiyJjG5c4hpBceLQACOJ4ngve/wDkWUn/AGlt3/4qf/ziD5ERfXf/ACLKT/tJbv8A8VP/AOcXgHhU8GtT4P8AaOstGGSvpHfrHQajG5hYx7ZAHZLQQ8Agk4IPEhBoaIiAiIgIiICIiAiIgIiIJaRwZVQucQAHtJJ6uK+jL54QNlLp4afCLQTXyljsW1tqit8F2YdcMM7aeIMc4j+4HBwJ6j2DJXzciD17aipsuwXgiOwlNtBar/d7rdm3GsltMxmp6eBjNLGCTABeSM+zjnqzjbJbPeC7a3wkSOddp9ntkKWGObc3ioa2eqeAAYg9uQ0F2SSMkDlgnh5UiD2HwsNprxe7Vc7xtlsxWWKKojoIbTs1O6R1so+JJjY6NoOA3ieZcR1YxttnqLBsfZ7xS3vwmWLarYQ0M8dssYeZqt0jsmI7osG4e0k+UCME9XV84ogIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgszQ2/pMEfTsxvYS93onsURpaPo1TJ0r9ZHIWxtx57e1YKIMuvp6aDddGqN9qbl3+ErI2a2iuGyV+ob7aZWRV1DKJYXPYHgEdoPAjGQqxEH0HV+HF9u2Lt+1Nr8I21VXttUTaaq01W7dQMx553OjS1mCNJack9mDjwKsq5q+rnq6l+ueeR0sjsAanOOScDgOJ6lCiD1DwD+Eel8HG1ENzqoRPGzeMki3jY3Pje0AlrnEN1AtacOIBGeIX0t/yuNiP+rLz9eg/80vhlEH3N/wArjYj/AKsvP16D/wA0vmbwzeEwbb7WXC7UDRTMrf1Zia9shZCGRsDXOHAuOgk6SQMgZPFeZIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIilhpZ6jO6ie/HMgcB+JQRIsw2qrAzu2fUb3rHlp5YDiSNzOzI5oI0REBERARSw0s9RndRPfjmQOA/Eqc2qLine truncated
|
||||
|
After Width: | Height: | Size: 107 KiB |
|
Before Width: | Height: | Size: 452 KiB |
@@ -0,0 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /patterns screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(17,17,17,0.14)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#F6F8FA"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#F6F8FA" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCANqAZIDASIAAhEBAxEB/8QAHQABAAEFAQEBAAAAAAAAAAAAAAECAwQFBgcICf/EAFkQAAEDAwICBwQHBAYFCgQDCQEAAgMEBREGEiExBxMUQVFSkSIyYaEVM1NxgZLhCCNisRgkNELR0xZWlJXBJTdDcnN1gqKz8Bdjk9QmNTY4RlV0g4Sy0vH/xAAYAQEBAQEBAAAAAAAAAAAAAAAAAQIDBP/EABoRAQEBAQEBAQAAAAAAAAAAAAARAQIDIQT/2gAMAwEAAhEDEQA/APpxERFEREBERAREQEREBERAREQEREBERARYl0u9uslI6sulfSUFMz3pqmVsbB+LiAuCuH7RnRXbZDHNq6mkcOH9XgmmHqxhHzQekIvKv6UPRP8A6zSf7vqf8tP6UPRP/rNJ/u+p/wAtB6qi8q/pQ9E/+s0n+76n/LT+lD0T/wCs0n+76n/LQeqovKv6UPRP/rNJ/u+p/wAtP6UPRP8A6zSf7vqf8tB6qi8q/pQ9E/8ArNJ/u+p/y0/pQ9E/+s0n+76n/LQeqovKv6UPRP8A6zSf7vqf8tP6UPRP/rNJ/u+p/wAtB6qi8vpv2mOiipeGN1W1hP2lFUMHqY8Lt9O6z03q2IyWG+W65hoy4U07XuZ/1mg5H4hBuUREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBFq9TXK4Wix1NZabTJeK9m1sFFHIIzK9zg0ZceDWjOSe4Aryaz9NOobTofXl91ZTW2W4aauLqCKChDmxPkO1rW5JJI3uHHngIPbUXkdFq/X+jdTaYpNcVFor6DUzzTf1KndC+3VRbubHkuO9p93J48M93HprprLVD7Vqf6F0ZXPudrnbTW9lW5rIrhuIHWtOR7DcknjxAxnOQA7ZF5PZ9Va6030lWLSOqrjZ73HfaSeoD6GmMD6F0TdxyMndGfdBOCT4YwadM9I2trl0s02nb9Z6KzWyutUlxpqPcZKpjWybGmVwO0OOCdoHAEDOcoPWkREBERAXE9LvSdQ9FWkZbzUMbUVkrupoqUnHXSkZ4+DQOJP4cyF2y+MP2wtRT3LpIpbNvPZrVRM2s7usk9pzvxb1Y/BB5NrLXWodfXZ901DcpqyZxOxhOI4R5WN5NH3fjkrQIiIIiICIiAiIgIiICIiAsm3XKttFbFXW+rno6qF26OaCQsew+II4hYyIPtX9nDp2m6RaaTTuopGfT9HH1kc4AaK2IcCcDgHt4ZxzBz3Fe5L83ujTUU+k9f2C8wPLDTVsW/H96Nztr2/i0uH4r9IUUREQEREBEXn/AEn681RpmooLRpHSc15udwY97aqc7KKla3mZH5HLI4Et4Hn3IPQEXzbT9JHSk+vEdL0g9Flyrt3C0sqcb3fZtfhoLu7G/wDFew9GetbxrK11Zv8Apiu09c6Cfs1RDOMxSOxndE7+83iPhxGCeaDsUXBdLnSTH0bWCW6SRyyNjDcMh2h8r3uw1oLgQ0cHEkg8BwHFeEf0y6r/AFcuH+9IP/tEH1oi+TP6ZdV/q5cP96Qf/aL3rou6R6bXunaS7ZfEyrb+7bPtEjXhz2ujJbgOILCQQBkEcAUHcoiICIiAiIgIiICIiAiIgLwGp6ML/qTSPSxZ+xS0lVdL/JXW0zjY2oDHMe0tJ4YdtLc8uK9+RB4pPUak6WdV6LbU6RvNgpNP1QudznuUIiY6oY3DI4eJ6wF2fa8F2t0uut9MWrVF1qKCl1AWTA2S321jhMYzhoEue8E5OM8A74AdsiDxHogq7jBqB9x1Lo3V79U3r2a281tGxlLSsALhDH7ZLIhgAcMuOCe7HS3CxXOT9oK13xlDO62Radlpn1Yb+7bKZiQwnxxxwvSUQEREBERAXxV+19Yprd0ox3NzD1FzoYnsf3FzMsc37wA0/wDiC+1VLine truncated
|
||||
|
After Width: | Height: | Size: 109 KiB |
|
Before Width: | Height: | Size: 847 KiB |
@@ -0,0 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /about and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.33%{opacity:0;transform:scale(.92)}8.08%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}4.00%{opacity:0;transform:scale(.92)}7.75%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}4.67%{opacity:0;transform:scale(.92)}8.42%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}6.08%{opacity:0;transform:scale(.92)}9.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}6.41%{opacity:0;transform:scale(.92)}10.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}6.75%{opacity:0;transform:scale(.92)}10.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}7.08%{opacity:0;transform:scale(.92)}10.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}3.66%{opacity:0;transform:scale(.92)}7.41%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}7.41%{opacity:0;transform:scale(.92)}11.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}7.75%{opacity:0;transform:scale(.92)}11.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}8.08%{opacity:0;transform:scale(.92)}11.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}8.42%{opacity:0;transform:scale(.92)}12.17%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}10.83%{clip-path:inset(0 0 100% 0)}21.67%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(978.5px,714.0px)}25.83%{opacity:0;transform:translate(978.5px,714.0px)}27.50%{opacity:1;transform:translate(978.5px,714.0px)}35.83%{opacity:1;transform:translate(718.5px,505.2px)}36.67%{opacity:1;transform:translate(718.5px,505.2px) scale(.82)}37.92%{opacity:1;transform:translate(718.5px,505.2px)}45.83%{opacity:0;transform:translate(718.5px,505.2px)}100.00%{opacity:0;transform:translate(718.5px,505.2px)}}.sel{animation:sel 12s ease-out infinite}@keyframes sel{0.00%{opacity:0}36.67%{opacity:0}39.17%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}37.08%{opacity:0;transform:translateX(48px)}42.08%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{opacity:0;animation:cover 12s linear infinite}@keyframes cover{0.00%{opacity:1}1.67%{opacity:0}94.17%{opacity:0}100.00%{opacity:1}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><image id="empty" width="1376" height="774" href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAALine truncated
|
||||
|
After Width: | Height: | Size: 1.4 MiB |
|
Before Width: | Height: | Size: 830 KiB |
@@ -0,0 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /about and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.33%{opacity:0;transform:scale(.92)}8.08%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}4.00%{opacity:0;transform:scale(.92)}7.75%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}4.67%{opacity:0;transform:scale(.92)}8.42%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}6.08%{opacity:0;transform:scale(.92)}9.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}6.41%{opacity:0;transform:scale(.92)}10.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}6.75%{opacity:0;transform:scale(.92)}10.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}7.08%{opacity:0;transform:scale(.92)}10.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}3.66%{opacity:0;transform:scale(.92)}7.41%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}7.41%{opacity:0;transform:scale(.92)}11.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}7.75%{opacity:0;transform:scale(.92)}11.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}8.08%{opacity:0;transform:scale(.92)}11.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}8.42%{opacity:0;transform:scale(.92)}12.17%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}10.83%{clip-path:inset(0 0 100% 0)}21.67%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(978.5px,714.0px)}25.83%{opacity:0;transform:translate(978.5px,714.0px)}27.50%{opacity:1;transform:translate(978.5px,714.0px)}35.83%{opacity:1;transform:translate(718.5px,505.2px)}36.67%{opacity:1;transform:translate(718.5px,505.2px) scale(.82)}37.92%{opacity:1;transform:translate(718.5px,505.2px)}45.83%{opacity:0;transform:translate(718.5px,505.2px)}100.00%{opacity:0;transform:translate(718.5px,505.2px)}}.sel{animation:sel 12s ease-out infinite}@keyframes sel{0.00%{opacity:0}36.67%{opacity:0}39.17%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}37.08%{opacity:0;transform:translateX(48px)}42.08%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{opacity:0;animation:cover 12s linear infinite}@keyframes cover{0.00%{opacity:1}1.67%{opacity:0}94.17%{opacity:0}100.00%{opacity:1}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><image id="empty" width="1376" height="774" href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAALine truncated
|
||||
|
After Width: | Height: | Size: 1.4 MiB |
|
Before Width: | Height: | Size: 642 KiB After Width: | Height: | Size: 640 KiB |
|
Before Width: | Height: | Size: 643 KiB After Width: | Height: | Size: 642 KiB |
@@ -1,12 +1,12 @@
|
||||
{
|
||||
"name": "@expo/explore",
|
||||
"version": "0.19.5",
|
||||
"version": "0.19.8",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "@expo/explore",
|
||||
"version": "0.19.5",
|
||||
"version": "0.19.8",
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@expo/repack-app": "0.10.1",
|
||||
@@ -29,7 +29,7 @@
|
||||
"@types/react-dom": "^19.2.4",
|
||||
"@vitejs/plugin-react": "^4.7.0",
|
||||
"@xyflow/react": "^12.11.3",
|
||||
"agent-device": "0.21.28",
|
||||
"agent-device": "0.21.29-nightly.20261018.74",
|
||||
"babel-plugin-react-compiler": "^1.0.0",
|
||||
"eslint": "^10.12.0",
|
||||
"eslint-plugin-react-hooks": "^7.1.1",
|
||||
@@ -48,7 +48,7 @@
|
||||
"optionalDependencies": {
|
||||
"@anthropic-ai/claude-agent-sdk": "0.3.285",
|
||||
"@openai/codex": "0.159.2",
|
||||
"eas-cli": "25.0.0"
|
||||
"eas-cli": "25.2.0"
|
||||
}
|
||||
},
|
||||
"node_modules/@0no-co/graphql.web": {
|
||||
@@ -1600,15 +1600,15 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@expo/eas-build-job": {
|
||||
"version": "25.0.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/eas-build-job/-/eas-build-job-25.0.0.tgz",
|
||||
"integrity": "sha512-Vuai42tVopKuK2KFyTWUsW9cL1YMY1dWhFAKz+evUV5AKaMCk4dYxOYZ6tBWNhIJ15bGK3p4N0YUomlAqubFWg==",
|
||||
"version": "25.2.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/eas-build-job/-/eas-build-job-25.2.0.tgz",
|
||||
"integrity": "sha512-RUp8sZniYWCiLQLGJrnMeAx8094BoejS6lm7EdSUs4nKkm6TtxyydRutGtoHlvBpvXOw3+OgimemqXUpmU5R8Q==",
|
||||
"license": "MIT",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
"@expo/logger": "25.0.0",
|
||||
"@expo/logger": "25.2.0",
|
||||
"@expo/results": "1.0.0",
|
||||
"@expo/turtle-spawn": "25.0.0",
|
||||
"@expo/turtle-spawn": "25.2.0",
|
||||
"joi": "^17.13.1",
|
||||
"semver": "^7.6.2",
|
||||
"zod": "^4.3.5"
|
||||
@@ -1642,14 +1642,14 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@expo/eas-json": {
|
||||
"version": "25.0.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/eas-json/-/eas-json-25.0.0.tgz",
|
||||
"integrity": "sha512-ilPw4O0Lnce/6lbu1GPwega8KF2GqTio9vuNFjNaGL78pfxz7GdktBsJ9JRaGtiM0LYdPa09W2FYb7DcMY8xWA==",
|
||||
"version": "25.2.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/eas-json/-/eas-json-25.2.0.tgz",
|
||||
"integrity": "sha512-ZikfZLZHadl5gzq5UZ7qWMTWFZNAO4K6NJC6iF8JmVh3kR1Blv+Zo2AolC0CYzSYOCyaRCZx+v2ZlJZeiVCf8w==",
|
||||
"license": "MIT",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
"@babel/code-frame": "7.23.5",
|
||||
"@expo/eas-build-job": "25.0.0",
|
||||
"@expo/eas-build-job": "25.2.0",
|
||||
"chalk": "4.1.2",
|
||||
"env-string": "1.0.1",
|
||||
"fs-extra": "11.2.0",
|
||||
@@ -1836,6 +1836,19 @@
|
||||
"node": ">=6"
|
||||
}
|
||||
},
|
||||
"node_modules/@expo/experimentation": {
|
||||
"version": "0.0.5",
|
||||
"resolved": "https://registry.npmjs.org/@expo/experimentation/-/experimentation-0.0.5.tgz",
|
||||
"integrity": "sha512-eQtx5f7tUDZLeq2EXYOkBX+KivYa73CjUMkrEFh5sNMOpCWynisbdSiaSdSLHALWzYKz3uc0QlgWTz3V/6JESQ==",
|
||||
"license": "MIT",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
"nullthrows": "^1.1.1"
|
||||
},
|
||||
"engines": {
|
||||
"node": ">=16"
|
||||
}
|
||||
},
|
||||
"node_modules/@expo/image-utils": {
|
||||
"version": "0.7.6",
|
||||
"resolved": "https://registry.npmjs.org/@expo/image-utils/-/image-utils-0.7.6.tgz",
|
||||
@@ -1900,9 +1913,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@expo/logger": {
|
||||
"version": "25.0.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/logger/-/logger-25.0.0.tgz",
|
||||
"integrity": "sha512-KcNOYmeJH8GESYEjbiewg+LU98XH/yBs368XlPqmEHVZekkbOONpIzPd5AFcFRWO1BW0c2nl/58BUI876UFT8A==",
|
||||
"version": "25.2.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/logger/-/logger-25.2.0.tgz",
|
||||
"integrity": "sha512-gtf/Lk9zE3k2wfEalAwioxDwvse69A2e/OhoDT7IRjlorRgcNJghr6V4FvDAZckQUkFR1IEHz2+FXvLKf9kjgg==",
|
||||
"license": "BUSL-1.1",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
@@ -2592,14 +2605,14 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@expo/steps": {
|
||||
"version": "25.0.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/steps/-/steps-25.0.0.tgz",
|
||||
"integrity": "sha512-+o04mm5akQJRX0j9TwwkdZiuNM9swLxw9DsDPtFhbWceg95gky/vc/0qF200kjZL4DEMfd/WhzngBW9aqJ0JQg==",
|
||||
"version": "25.2.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/steps/-/steps-25.2.0.tgz",
|
||||
"integrity": "sha512-KKM8STsb0dAdI6lyN7WHfczvDdQlCx+vF4unq/qFk6PZgZMvE9+IT8mh25fqgwxNcpR7Ti+xFCip2hhvpK2yng==",
|
||||
"license": "BUSL-1.1",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
"@expo/eas-build-job": "25.0.0",
|
||||
"@expo/logger": "25.0.0",
|
||||
"@expo/eas-build-job": "25.2.0",
|
||||
"@expo/logger": "25.2.0",
|
||||
"@expo/spawn-async": "^1.7.2",
|
||||
"arg": "^5.0.2",
|
||||
"fast-glob": "^3.3.2",
|
||||
@@ -2637,13 +2650,13 @@
|
||||
"optional": true
|
||||
},
|
||||
"node_modules/@expo/turtle-spawn": {
|
||||
"version": "25.0.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/turtle-spawn/-/turtle-spawn-25.0.0.tgz",
|
||||
"integrity": "sha512-XBQZ2azxh0IWozO5hCxIJt150LjIGbk6VZakeyA6UXPHp1ESenm97o0JIHOvzQNOgBV481muV88KmIWHGt0yIA==",
|
||||
"version": "25.2.0",
|
||||
"resolved": "https://registry.npmjs.org/@expo/turtle-spawn/-/turtle-spawn-25.2.0.tgz",
|
||||
"integrity": "sha512-1Lor7/+4T1JEb6kqu0dHstD+xOWTGbwA7QqWTBKYx4qtgtJ4Wbor17bzlp87KENAYDeWuX+7VHKxT66170m9wg==",
|
||||
"license": "BUSL-1.1",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
"@expo/logger": "25.0.0",
|
||||
"@expo/logger": "25.2.0",
|
||||
"@expo/spawn-async": "^1.7.2"
|
||||
}
|
||||
},
|
||||
@@ -4580,9 +4593,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/agent-device": {
|
||||
"version": "0.21.28",
|
||||
"resolved": "https://registry.npmjs.org/agent-device/-/agent-device-0.21.28.tgz",
|
||||
"integrity": "sha512-uGEENVhPzSpIACrVlt16O1mloODWJyAemTCT0boDb4L006JXN2rG747u1TRoQJudOpdP/Pm2urxNRHeECLMLfg==",
|
||||
"version": "0.21.29-nightly.20261018.74",
|
||||
"resolved": "https://registry.npmjs.org/agent-device/-/agent-device-0.21.29-nightly.20261018.74.tgz",
|
||||
"integrity": "sha512-7+ajWLr0J+8iLZ9q11ERbj6U14mC20umBK5BQQdw5aERA79yeXc3Ze6KmtvnILnWjEtoVkYQsXQasL8RL6Uatw==",
|
||||
"dev": true,
|
||||
"license": "MIT",
|
||||
"bin": {
|
||||
@@ -5722,9 +5735,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/eas-cli": {
|
||||
"version": "25.0.0",
|
||||
"resolved": "https://registry.npmjs.org/eas-cli/-/eas-cli-25.0.0.tgz",
|
||||
"integrity": "sha512-FBY3pIo/3L0s+8KK5ZpMKzlLrA5jOmr5kOpoOwkAXsxMrI4vo+LNoEsciRcOxjce9efc08GqEEPc/CxLRAWIvA==",
|
||||
"version": "25.2.0",
|
||||
"resolved": "https://registry.npmjs.org/eas-cli/-/eas-cli-25.2.0.tgz",
|
||||
"integrity": "sha512-FFA6fSl2bPet9D3Eslupig3icXjyBzAbrsLE5r67wbEbh/CPDZQ+Q4W5TrpRui0uqfF16w58EGsFUQoQ0te0KQ==",
|
||||
"license": "MIT",
|
||||
"optional": true,
|
||||
"dependencies": {
|
||||
@@ -5732,11 +5745,12 @@
|
||||
"@expo/code-signing-certificates": "0.0.5",
|
||||
"@expo/config": "55.0.10",
|
||||
"@expo/config-plugins": "55.0.7",
|
||||
"@expo/eas-build-job": "25.0.0",
|
||||
"@expo/eas-json": "25.0.0",
|
||||
"@expo/eas-build-job": "25.2.0",
|
||||
"@expo/eas-json": "25.2.0",
|
||||
"@expo/env": "^1.0.0",
|
||||
"@expo/experimentation": "0.0.5",
|
||||
"@expo/json-file": "8.3.3",
|
||||
"@expo/logger": "25.0.0",
|
||||
"@expo/logger": "25.2.0",
|
||||
"@expo/multipart-body-parser": "2.0.0",
|
||||
"@expo/osascript": "2.1.4",
|
||||
"@expo/package-manager": "1.9.10",
|
||||
@@ -5748,7 +5762,7 @@
|
||||
"@expo/results": "1.0.0",
|
||||
"@expo/rudder-sdk-node": "1.1.1",
|
||||
"@expo/spawn-async": "1.7.2",
|
||||
"@expo/steps": "25.0.0",
|
||||
"@expo/steps": "25.2.0",
|
||||
"@expo/timeago.js": "1.0.0",
|
||||
"@oclif/core": "^4.8.3",
|
||||
"@oclif/plugin-autocomplete": "^3.2.40",
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@expo/explore",
|
||||
"version": "0.19.5",
|
||||
"version": "0.19.8",
|
||||
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
|
||||
"license": "MIT",
|
||||
"type": "module",
|
||||
@@ -73,7 +73,7 @@
|
||||
"optionalDependencies": {
|
||||
"@anthropic-ai/claude-agent-sdk": "0.3.285",
|
||||
"@openai/codex": "0.159.2",
|
||||
"eas-cli": "25.0.0"
|
||||
"eas-cli": "25.2.0"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@anthropic-ai/claude-code": "2.1.285",
|
||||
@@ -83,7 +83,7 @@
|
||||
"@types/react-dom": "^19.2.4",
|
||||
"@vitejs/plugin-react": "^4.7.0",
|
||||
"@xyflow/react": "^12.11.3",
|
||||
"agent-device": "0.21.28",
|
||||
"agent-device": "0.21.29-nightly.20261018.74",
|
||||
"babel-plugin-react-compiler": "^1.0.0",
|
||||
"eslint": "^10.12.0",
|
||||
"eslint-plugin-react-hooks": "^7.1.1",
|
||||
|
||||
@@ -3,13 +3,14 @@
|
||||
//
|
||||
// node scripts/deploy-viewer-preview.mjs --fixtures DIR --alias pr-123 --project explore-viewer-pr [--owner expo-public]
|
||||
//
|
||||
// DIR holds reports.json ([{ platform, changes?, device? }], as a hosted preview's /reports.json lists them) and one
|
||||
// <platform>.zip per entry (scripts/refresh-viewer-preview-fixtures.sh writes both). EXPLORE_PREVIEW_TOKEN keeps an
|
||||
// earlier link's /p/<token>; without it the link gets a new one. EXPO_TOKEN must be able to deploy to the project.
|
||||
// DIR holds reports.json ([{ target?, platform, label?, changes?, device? }], as a hosted preview's /reports.json lists
|
||||
// them) and one <target>.zip per entry, or <platform>.zip for an entry without a target
|
||||
// (scripts/refresh-viewer-preview-fixtures.sh writes both). EXPLORE_PREVIEW_TOKEN keeps an earlier link's /p/<token>;
|
||||
// without it the link gets a new one. EXPO_TOKEN must be able to deploy to the project.
|
||||
import { readFile } from "node:fs/promises";
|
||||
import { join } from "node:path";
|
||||
import { parseArgs } from "node:util";
|
||||
import { deployFixturePreview } from "../dist/report/preview-deploy.js";
|
||||
import { deployFixturePreview, fixtureReports } from "../dist/report/preview-deploy.js";
|
||||
|
||||
const { values } = parseArgs({ options: { fixtures: { type: "string" }, alias: { type: "string" }, project: { type: "string" }, owner: { type: "string" } } });
|
||||
if (!values.fixtures || !values.alias || !values.project) {
|
||||
@@ -19,7 +20,7 @@ if (!values.fixtures || !values.alias || !values.project) {
|
||||
const listing = JSON.parse(await readFile(join(values.fixtures, "reports.json"), "utf8"));
|
||||
const token = process.env.EXPLORE_PREVIEW_TOKEN?.trim() || undefined;
|
||||
const result = await deployFixturePreview({
|
||||
reports: listing.map(({ platform, changes, device }) => ({ platform, zipPath: join(values.fixtures, `${platform}.zip`), changes, device })),
|
||||
reports: fixtureReports(listing, values.fixtures),
|
||||
project: values.project, alias: values.alias, ...(values.owner ? { owner: values.owner } : {}), ...(token ? { token } : {}),
|
||||
});
|
||||
console.log(JSON.stringify({ ...result, reports: listing }));
|
||||
@@ -0,0 +1,243 @@
|
||||
// The README's two animated SVGs, written by readme-screenshots.mjs. Each is a plain image: CSS keyframes on one loop,
|
||||
// every picture inlined as a JPEG data URI (an SVG shown with <img> loads nothing), and with prefers-reduced-motion
|
||||
// it shows its last frame, which is also what a viewer that does not animate SVG shows.
|
||||
//
|
||||
// readme-hero the Viewer's Map, built from real Viewer frames: the screens appear row by row, the transitions
|
||||
// wipe in from the top, then a click selects a screen and the Inspector slides in
|
||||
// readme-compare one modified screen wiping from its base capture to its head capture, the changed regions pulsing
|
||||
import { ZipReader, Uint8ArrayReader, Uint8ArrayWriter } from "@zip.js/zip.js";
|
||||
|
||||
/** The soft stage the PR comment picture sits on too (stagedComment in readme-screenshots.mjs), and its accents. */
|
||||
const STAGE = {
|
||||
light: { stage: "#F6F8FA", border: "#D1D9E0", shadow: "rgba(17,17,17,0.14)", text: "#1F2328", muted: "#59636E", accent: "#0969DA", region: "#D4520F" },
|
||||
dark: { stage: "#151B23", border: "#3D444D", shadow: "rgba(1,4,9,0.6)", text: "#F0F6FC", muted: "#9198A1", accent: "#4493F8", region: "#F0883E" },
|
||||
};
|
||||
const FONT = "-apple-system, BlinkMacSystemFont, 'Segoe UI', 'Noto Sans', Helvetica, Arial, sans-serif";
|
||||
const MONO = "ui-monospace, SFMono-Regular, 'SF Mono', Menlo, Consolas, monospace";
|
||||
const JPEG_QUALITY = 82;
|
||||
|
||||
const dataUri = jpeg => `data:image/jpeg;base64,${jpeg.toString("base64")}`;
|
||||
const escapeXml = text => text.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">").replace(/"/g, """);
|
||||
const box = ({ x, y, width, height }) => `x="${x}" y="${y}" width="${width}" height="${height}"`;
|
||||
|
||||
/** Keyframes given in seconds on a shared loop, so every element stays in step. */
|
||||
function keyframes(name, loop, frames) {
|
||||
return `@keyframes ${name}{${frames.map(([at, css]) => `${((at / loop) * 100).toFixed(2)}%{${css}}`).join("")}}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Photographs the hero's states from a Viewer page whose Map has its camera set and nothing selected: the Map without
|
||||
* its screens, without its edges, and whole; then it clicks `select`, which opens the Inspector without moving the
|
||||
* camera, and photographs that. Returns the frames and where each screen card, the Inspector and the selected card are.
|
||||
*/
|
||||
export async function captureHeroFrames(page, { select, viewport }) {
|
||||
const shoot = () => page.screenshot({ type: "jpeg", quality: JPEG_QUALITY });
|
||||
const neutral = () => page.mouse.move(viewport.width - 4, viewport.height - 4);
|
||||
const rect = locator => locator.boundingBox().then(b => b && { x: Math.round(b.x), y: Math.round(b.y), width: Math.round(b.width), height: Math.round(b.height) });
|
||||
const camera = () => page.locator(".react-flow__viewport").evaluate(el => el.style.transform);
|
||||
const target = page.locator(`.screen-screenshot-target[title="${select}"]`);
|
||||
|
||||
// A card under the pointer dims the others and highlights its edges; let that fade before the first frame.
|
||||
await neutral();
|
||||
await page.waitForTimeout(1000);
|
||||
const at = await camera();
|
||||
const selected = await rect(target);
|
||||
if (!selected) throw new Error(`The hero needs ${select} on the Map.`);
|
||||
const cards = [];
|
||||
for (const node of await page.locator(".react-flow__node").all()) {
|
||||
const b = await rect(node);
|
||||
if (b && b.x < viewport.width && b.y < viewport.height && b.x + b.width > 0 && b.y + b.height > 0) cards.push(b);
|
||||
}
|
||||
const full = await shoot();
|
||||
const hide = async css => {
|
||||
const style = await page.addStyleTag({ content: `${css} { visibility: hidden !important; }` });
|
||||
await page.waitForTimeout(300);
|
||||
return style;
|
||||
};
|
||||
const edges = await hide(".react-flow__edges, .react-flow__edge, .react-flow__edgelabel-renderer");
|
||||
const screensOnly = await shoot();
|
||||
const nodes = await hide(".react-flow__node");
|
||||
const empty = await shoot();
|
||||
for (const style of [edges, nodes]) await style.evaluate(el => el.remove());
|
||||
|
||||
await target.click();
|
||||
await neutral();
|
||||
await page.waitForTimeout(1500);
|
||||
const inspector = await rect(page.locator("aside.right-panel"));
|
||||
if (!inspector) throw new Error(`Selecting ${select} did not open the Inspector.`);
|
||||
if ((await camera()) !== at) throw new Error(`The Map's camera moved when ${select} was selected: ${at} → ${await camera()}.`);
|
||||
const inspecting = await shoot();
|
||||
return { viewport, empty, screensOnly, full, inspecting, cards, selected, inspector };
|
||||
}
|
||||
|
||||
/**
|
||||
* The hero: the frames from captureHeroFrames as a window on a rounded 1600×900 stage. Each screen
|
||||
* card is a clip of the screens-only frame, so what appears is exactly what the Viewer draws.
|
||||
*/
|
||||
export function heroSvg(frames, theme, alt) {
|
||||
const t = STAGE[theme];
|
||||
const LOOP = 12;
|
||||
const W = 1600, H = 900;
|
||||
const { viewport: v } = frames;
|
||||
const wx = (W - v.width) / 2, wy = (H - v.height) / 2;
|
||||
const css = [];
|
||||
const defs = [];
|
||||
const layers = [];
|
||||
const image = (id, jpeg) => defs.push(`<image id="${id}" width="${v.width}" height="${v.height}" href="${dataUri(jpeg)}"/>`);
|
||||
image("empty", frames.empty);
|
||||
image("screens", frames.screensOnly);
|
||||
image("full", frames.full);
|
||||
image("inspecting", frames.inspecting);
|
||||
|
||||
// Cards appear a row at a time, top to bottom, as the Map lays out taps from launch; a row's cards left to right.
|
||||
const PAD = 18;
|
||||
const rows = [...new Set(frames.cards.map(c => c.y))].sort((a, b) => a - b);
|
||||
frames.cards.forEach((card, i) => {
|
||||
const appear = 0.4 + rows.indexOf(card.y) * 0.35 + (card.x / v.width) * 0.3;
|
||||
const clip = { x: card.x - PAD, y: card.y - PAD, width: card.width + PAD * 2, height: card.height + PAD * 2 };
|
||||
defs.push(`<clipPath id="c${i}"><rect ${box(clip)}/></clipPath>`);
|
||||
css.push(`.c${i}{transform-origin:0 0;animation:c${i} ${LOOP}s cubic-bezier(.2,.8,.2,1) infinite}`);
|
||||
css.push(keyframes(`c${i}`, LOOP, [[0, "opacity:0;transform:scale(.92)"], [appear, "opacity:0;transform:scale(.92)"], [appear + 0.45, "opacity:1;transform:scale(1)"], [LOOP, "opacity:1;transform:scale(1)"]]));
|
||||
// Scaled about the card's centre: the class sits on a group whose origin is there.
|
||||
const cx = card.x + card.width / 2, cy = card.y + card.height / 2;
|
||||
layers.push(`<g transform="translate(${cx} ${cy})"><g class="c${i}"><g transform="translate(${-cx} ${-cy})" clip-path="url(#c${i})"><use href="#screens"/></g></g></g>`);
|
||||
});
|
||||
const settled = 0.4 + (rows.length - 1) * 0.35 + 0.75;
|
||||
|
||||
// The transitions wipe in from the top: the full frame over the cards, which it draws in the same places.
|
||||
const EDGES = settled - 0.2, EDGES_END = EDGES + 1.3;
|
||||
css.push(`.full{animation:full ${LOOP}s cubic-bezier(.45,0,.25,1) infinite}`);
|
||||
css.push(keyframes("full", LOOP, [[0, "clip-path:inset(0 0 100% 0)"], [EDGES, "clip-path:inset(0 0 100% 0)"], [EDGES_END, "clip-path:inset(0 0 0 0)"], [LOOP, "clip-path:inset(0 0 0 0)"]]));
|
||||
layers.push(`<use class="full" href="#full"/>`);
|
||||
|
||||
// A pointer glides to the selected card and clicks; the selection lands and the Inspector slides in.
|
||||
const { selected: s, inspector: p } = frames;
|
||||
const target = { x: s.x + s.width * 0.55, y: s.y + s.height * 0.45 };
|
||||
const start = { x: Math.min(v.width - 120, target.x + 260), y: Math.min(v.height - 60, target.y + 220) };
|
||||
const MOVE = EDGES_END + 0.5, CLICK = MOVE + 1.2;
|
||||
const pointer = (x, y, extra = "") => `transform:translate(${x.toFixed(1)}px,${y.toFixed(1)}px)${extra}`;
|
||||
css.push(`.ptr{opacity:0;animation:ptr ${LOOP}s cubic-bezier(.4,0,.2,1) infinite}`);
|
||||
css.push(keyframes("ptr", LOOP, [
|
||||
[0, `opacity:0;${pointer(start.x, start.y)}`], [MOVE, `opacity:0;${pointer(start.x, start.y)}`], [MOVE + 0.2, `opacity:1;${pointer(start.x, start.y)}`],
|
||||
[CLICK, `opacity:1;${pointer(target.x, target.y)}`], [CLICK + 0.1, `opacity:1;${pointer(target.x, target.y, " scale(.82)")}`],
|
||||
[CLICK + 0.25, `opacity:1;${pointer(target.x, target.y)}`], [CLICK + 1.2, `opacity:0;${pointer(target.x, target.y)}`], [LOOP, `opacity:0;${pointer(target.x, target.y)}`],
|
||||
]));
|
||||
defs.push(`<clipPath id="canvas"><rect x="0" y="0" width="${p.x}" height="${v.height}"/></clipPath>`);
|
||||
defs.push(`<clipPath id="panel"><rect ${box(p)}/></clipPath>`);
|
||||
css.push(`.sel{animation:sel ${LOOP}s ease-out infinite}`);
|
||||
css.push(keyframes("sel", LOOP, [[0, "opacity:0"], [CLICK + 0.1, "opacity:0"], [CLICK + 0.4, "opacity:1"], [LOOP, "opacity:1"]]));
|
||||
css.push(`.insp{animation:insp ${LOOP}s cubic-bezier(.2,.8,.2,1) infinite}`);
|
||||
css.push(keyframes("insp", LOOP, [[0, "opacity:0;transform:translateX(48px)"], [CLICK + 0.15, "opacity:0;transform:translateX(48px)"], [CLICK + 0.75, "opacity:1;transform:translateX(0)"], [LOOP, "opacity:1;transform:translateX(0)"]]));
|
||||
layers.push(`<use class="sel" href="#inspecting" clip-path="url(#canvas)"/>`);
|
||||
layers.push(`<g class="insp"><use href="#inspecting" clip-path="url(#panel)"/></g>`);
|
||||
layers.push(`<g class="ptr"><path d="M0 0L0 22L6 16.5L10.5 26L14 24.5L9.8 15.2L18 15.2Z" fill="#111" stroke="#fff" stroke-width="1.6" stroke-linejoin="round"/></g>`);
|
||||
|
||||
// The empty Map covers the reset: it fades in over the last frame, and the loop starts again beneath it.
|
||||
css.push(`.cover{opacity:0;animation:cover ${LOOP}s linear infinite}`);
|
||||
css.push(keyframes("cover", LOOP, [[0, "opacity:1"], [0.2, "opacity:0"], [LOOP - 0.7, "opacity:0"], [LOOP, "opacity:1"]]));
|
||||
layers.push(`<use class="cover" href="#empty"/>`);
|
||||
|
||||
css.push("@media (prefers-reduced-motion: reduce){*{animation:none!important}}");
|
||||
defs.push(`<clipPath id="window"><rect width="${v.width}" height="${v.height}" rx="14"/></clipPath>`);
|
||||
defs.push(`<filter id="shadow" x="-10%" y="-10%" width="120%" height="125%"><feDropShadow dx="0" dy="2" stdDeviation="2" flood-color="${t.shadow}" flood-opacity=".3"/><feDropShadow dx="0" dy="30" stdDeviation="35" flood-color="${t.shadow}"/></filter>`);
|
||||
defs.push(`<clipPath id="stage"><rect width="${W}" height="${H}" rx="22"/></clipPath>`);
|
||||
return `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 ${W} ${H}" width="${W}" height="${H}" role="img" aria-label="${escapeXml(alt)}">`
|
||||
+ `<style>${css.join("")}</style><defs>${defs.join("")}</defs>`
|
||||
+ `<g clip-path="url(#stage)"><rect width="${W}" height="${H}" fill="${t.stage}"/>`
|
||||
+ `<rect x="${wx}" y="${wy}" width="${v.width}" height="${v.height}" rx="14" fill="${t.stage}" filter="url(#shadow)"/>`
|
||||
+ `<g transform="translate(${wx} ${wy})"><g clip-path="url(#window)"><use href="#empty"/>${layers.join("")}</g>`
|
||||
+ `<rect x=".5" y=".5" width="${v.width - 1}" height="${v.height - 1}" rx="14" fill="none" stroke="${t.border}"/></g></g></svg>`;
|
||||
}
|
||||
|
||||
/** review.json and an asset reader from a sealed review report's bytes. */
|
||||
export async function openReport(bytes) {
|
||||
const reader = new ZipReader(new Uint8ArrayReader(new Uint8Array(bytes)));
|
||||
const entries = new Map((await reader.getEntries()).map(entry => [entry.filename, entry]));
|
||||
const read = async name => {
|
||||
const entry = entries.get(name);
|
||||
if (!entry) throw new Error(`The report has no ${name}.`);
|
||||
return Buffer.from(await entry.getData(new Uint8ArrayWriter()));
|
||||
};
|
||||
const review = JSON.parse((await read("review.json")).toString("utf8")).review;
|
||||
return { review, asset: sha => read(`assets/${sha}.png`) };
|
||||
}
|
||||
|
||||
/** A PNG as a JPEG at most `maxHeight` tall, drawn by the browser so the script needs no image library. */
|
||||
async function toJpeg(browser, png, maxHeight) {
|
||||
const page = await browser.newPage();
|
||||
try {
|
||||
const base64 = await page.evaluate(async ({ png, maxHeight, quality }) => {
|
||||
const bitmap = await createImageBitmap(await (await fetch(`data:image/png;base64,${png}`)).blob());
|
||||
const scale = Math.min(1, maxHeight / bitmap.height);
|
||||
const canvas = document.createElement("canvas");
|
||||
canvas.width = Math.round(bitmap.width * scale);
|
||||
canvas.height = Math.round(bitmap.height * scale);
|
||||
const context = canvas.getContext("2d");
|
||||
context.imageSmoothingQuality = "high";
|
||||
context.drawImage(bitmap, 0, 0, canvas.width, canvas.height);
|
||||
return canvas.toDataURL("image/jpeg", quality).split(",")[1];
|
||||
}, { png: png.toString("base64"), maxHeight, quality: JPEG_QUALITY / 100 });
|
||||
return Buffer.from(base64, "base64");
|
||||
} finally {
|
||||
await page.close();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* The surface of the Compare key `key` (the slug of the Viewer's #/compare/<key>, which is the route without its
|
||||
* slash) in `theme`, among the report's visually modified screens.
|
||||
*/
|
||||
export function compareSurface(review, key, theme) {
|
||||
const route = `/${key}`;
|
||||
const surface = review.surfaces.find(s => (s.head ?? s.base)?.route === route && s.colorScheme === theme && s.visual?.verdict === "modified");
|
||||
if (!surface) throw new Error(`No visually modified ${route} in ${theme} in this report; pass --compare <key> from a #/compare/<key> URL.`);
|
||||
return surface;
|
||||
}
|
||||
|
||||
/** The Compare picture: `surface`'s base capture wiping to its head capture, its changed regions outlined. */
|
||||
export async function compareSvg(browser, report, surface, theme, alt) {
|
||||
const t = STAGE[theme];
|
||||
const LOOP = 7;
|
||||
const W = 1000, H = 600;
|
||||
const { baseImage, headImage } = surface;
|
||||
const PH = 540, PW = Math.round(PH * headImage.width / headImage.height);
|
||||
const x = (W - PW) / 2, y = (H - PH) / 2;
|
||||
const k = PW / headImage.width;
|
||||
const before = dataUri(await toJpeg(browser, await report.asset(baseImage.sha256), PH * 2));
|
||||
const after = dataUri(await toJpeg(browser, await report.asset(headImage.sha256), PH * 2));
|
||||
const { pullRequest } = report.review;
|
||||
const css = [];
|
||||
// The After capture is revealed left to right, and the divider rides the edge of the reveal.
|
||||
css.push(`.after{animation:wipe ${LOOP}s cubic-bezier(.65,0,.35,1) infinite}`);
|
||||
css.push(keyframes("wipe", LOOP, [[0, "clip-path:inset(0 100% 0 0)"], [1.0, "clip-path:inset(0 100% 0 0)"], [2.6, "clip-path:inset(0 0 0 0)"], [5.8, "clip-path:inset(0 0 0 0)"], [6.8, "clip-path:inset(0 100% 0 0)"], [LOOP, "clip-path:inset(0 100% 0 0)"]]));
|
||||
css.push(`.divider{opacity:0;animation:divider ${LOOP}s cubic-bezier(.65,0,.35,1) infinite}`);
|
||||
css.push(keyframes("divider", LOOP, [[0, "transform:translateX(0);opacity:0"], [0.8, "transform:translateX(0);opacity:1"], [1.0, "transform:translateX(0);opacity:1"], [2.6, `transform:translateX(${PW}px);opacity:1`], [2.9, `transform:translateX(${PW}px);opacity:0`], [5.8, `transform:translateX(${PW}px);opacity:0`], [6.0, `transform:translateX(${PW}px);opacity:1`], [6.8, "transform:translateX(0);opacity:1"], [LOOP, "transform:translateX(0);opacity:0"]]));
|
||||
css.push(`.regions{animation:regions ${LOOP}s ease-in-out infinite}`);
|
||||
css.push(keyframes("regions", LOOP, [[0, "opacity:0"], [2.7, "opacity:0"], [3.1, "opacity:1"], [3.6, "opacity:.3"], [4.1, "opacity:1"], [5.7, "opacity:1"], [6.0, "opacity:0"], [LOOP, "opacity:0"]]));
|
||||
css.push(`.before-label{opacity:.3;animation:before-label ${LOOP}s linear infinite}.after-label{animation:after-label ${LOOP}s linear infinite}`);
|
||||
css.push(keyframes("before-label", LOOP, [[0, "opacity:1"], [1.8, "opacity:1"], [2.0, "opacity:.3"], [6.2, "opacity:.3"], [6.4, "opacity:1"], [LOOP, "opacity:1"]]));
|
||||
css.push(keyframes("after-label", LOOP, [[0, "opacity:.3"], [1.8, "opacity:.3"], [2.0, "opacity:1"], [6.2, "opacity:1"], [6.4, "opacity:.3"], [LOOP, "opacity:.3"]]));
|
||||
css.push("@media (prefers-reduced-motion: reduce){*{animation:none!important}}");
|
||||
const regions = surface.visual.regions.map(({ rect: r }) =>
|
||||
`<rect x="${(x + r.x * k - 3).toFixed(1)}" y="${(y + r.y * k - 3).toFixed(1)}" width="${(r.width * k + 6).toFixed(1)}" height="${(r.height * k + 6).toFixed(1)}" rx="3" fill="none" stroke="${t.region}" stroke-width="2"/>`).join("");
|
||||
const label = (cls, anchor, lx, title, sub, note) => `<g class="${cls}" font-family="${FONT}" text-anchor="${anchor}">`
|
||||
+ `<text x="${lx}" y="${y + PH / 2 - 14}" font-size="26" font-weight="700" fill="${t.text}">${title}</text>`
|
||||
+ `<text x="${lx}" y="${y + PH / 2 + 12}" font-family="${MONO}" font-size="13" fill="${t.muted}">${escapeXml(sub)}</text>`
|
||||
+ (note ? `<text x="${lx}" y="${y + PH / 2 + 36}" font-size="13" font-weight="600" fill="${t.region}">${note}</text>` : "") + "</g>";
|
||||
const count = surface.visual.regions.length;
|
||||
return `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 ${W} ${H}" width="${W}" height="${H}" role="img" aria-label="${escapeXml(alt)}">`
|
||||
+ `<style>${css.join("")}</style>`
|
||||
+ `<defs><clipPath id="stage"><rect width="${W}" height="${H}" rx="16"/></clipPath><clipPath id="phone"><rect x="${x}" y="${y}" width="${PW}" height="${PH}" rx="40"/></clipPath>`
|
||||
+ `<filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="${t.shadow}"/></filter></defs>`
|
||||
+ `<g clip-path="url(#stage)"><rect width="${W}" height="${H}" fill="${t.stage}"/>`
|
||||
+ `<rect x="${x}" y="${y}" width="${PW}" height="${PH}" rx="40" fill="${t.stage}" filter="url(#shadow)"/>`
|
||||
+ `<g clip-path="url(#phone)"><image href="${before}" x="${x}" y="${y}" width="${PW}" height="${PH}"/>`
|
||||
+ `<image class="after" href="${after}" x="${x}" y="${y}" width="${PW}" height="${PH}"/></g>`
|
||||
+ `<rect x="${x}" y="${y}" width="${PW}" height="${PH}" rx="40" fill="none" stroke="${t.border}"/>`
|
||||
+ `<g class="divider"><rect x="${x - 1.5}" y="${y}" width="3" height="${PH}" fill="${t.accent}"/><circle cx="${x}" cy="${y + PH / 2}" r="13" fill="${t.accent}"/>`
|
||||
+ `<path d="M${x - 5} ${y + PH / 2 - 4}l-3 4l3 4M${x + 5} ${y + PH / 2 - 4}l3 4l-3 4" stroke="#fff" stroke-width="1.8" fill="none" stroke-linecap="round" stroke-linejoin="round"/></g>`
|
||||
+ `<g class="regions">${regions}</g>`
|
||||
+ label("before-label", "end", x - 44, "Before", `${pullRequest.base.ref} ·${pullRequest.base.sha.slice(0, 7)}`)
|
||||
+ label("after-label", "start", x + PW + 44, "After", `PR #${pullRequest.number} · ${pullRequest.head.sha.slice(0, 7)}`, `${count} changed region${count === 1 ? "" : "s"}`)
|
||||
+ "</g></svg>";
|
||||
}
|
||||
@@ -1,4 +1,4 @@
|
||||
// Regenerates the Viewer screenshots in docs/screenshots from a review report, in light and dark
|
||||
// Regenerates the README's pictures in docs/screenshots from a review report, in light and dark
|
||||
// (the README shows them with <picture>; GitHub Mobile ignores the dark source and shows light). The reference app is euxy
|
||||
// (github.com/brentvatne/euxy): skills/readme-refresh/SKILL.md says which report to pass and how.
|
||||
//
|
||||
@@ -7,8 +7,10 @@
|
||||
//
|
||||
// --report a sealed review report (the hosted link's report.zip?platform=ios, or the PR's zip artifact)
|
||||
// --select the route selected on the hero Map (opens the Inspector); default /settings. The hero zooms in around it
|
||||
// (--zoom, default 73%) and is framed as a window on a soft stage, like the PR comment
|
||||
// --compare the Compare key of a modified screen: the slug in the Viewer's #/compare/<key> URL; default patterns
|
||||
// (--zoom, default 73%) and is an animated SVG of a window on a soft stage (readme-animations.mjs): the
|
||||
// Map's cards appear, its transitions wipe in, and a click on this screen opens the Inspector
|
||||
// --compare the Compare key of a modified screen: the slug in the Viewer's #/compare/<key> URL; default patterns.
|
||||
// It becomes readme-compare-*.svg, its before capture wiping to its after capture
|
||||
// --pr a GitHub PR URL whose Explore comment becomes readme-pr-comment-light.png (public repository): the comment
|
||||
// at its own size on a soft stage, cut off with a fade after the list of changed screens
|
||||
import { chromium } from "@playwright/test";
|
||||
@@ -16,6 +18,7 @@ import { readFile, writeFile } from "node:fs/promises";
|
||||
import { parseArgs } from "node:util";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { startReportViewer } from "../test/ci/lib/report-viewer.mjs";
|
||||
import { captureHeroFrames, compareSurface, compareSvg, heroSvg, openReport } from "./readme-animations.mjs";
|
||||
|
||||
const { values: args } = parseArgs({
|
||||
options: {
|
||||
@@ -33,15 +36,22 @@ if (!args.report) {
|
||||
|
||||
const out = fileURLToPath(new URL("../docs/screenshots/", import.meta.url));
|
||||
const SHOTS = [
|
||||
{ file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: "Fit canvas", select: args.select, zoom: Number(args.zoom), framed: true },
|
||||
{ file: "readme-compare", hash: `#/compare/${args.compare}`, viewport: { width: 1760, height: 1000 } },
|
||||
{ file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: "Fit canvas", select: args.select, zoom: Number(args.zoom), animated: true },
|
||||
{ file: "readme-screens", hash: "#/screens", viewport: { width: 1760, height: 1000 } },
|
||||
];
|
||||
|
||||
const bytes = await readFile(args.report);
|
||||
const report = await openReport(bytes);
|
||||
const { server, url } = await startReportViewer({ bytes, watch: false });
|
||||
const browser = await chromium.launch();
|
||||
try {
|
||||
for (const theme of ["light", "dark"]) {
|
||||
const surface = compareSurface(report.review, args.compare, theme);
|
||||
const path = `${out}readme-compare-${theme}.svg`;
|
||||
await writeFile(path, await compareSvg(browser, report, surface, theme,
|
||||
`The ${surface.head.route} screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined`));
|
||||
console.log(path);
|
||||
}
|
||||
for (const theme of ["light", "dark"]) for (const shot of SHOTS) {
|
||||
const context = await browser.newContext({ viewport: shot.viewport, deviceScaleFactor: 2, colorScheme: theme });
|
||||
await context.addInitScript(value => localStorage.setItem("expo-explore:theme", value), theme);
|
||||
@@ -54,8 +64,8 @@ try {
|
||||
await page.mouse.move(400, shot.viewport.height - 30);
|
||||
await page.waitForTimeout(1500);
|
||||
}
|
||||
if (shot.select) {
|
||||
// Selecting a screen opens the Inspector without moving the fitted camera.
|
||||
if (shot.select && !shot.animated) {
|
||||
// Selecting a screen opens the Inspector without moving the fitted camera. The animated hero selects it last.
|
||||
await page.locator(`.screen-screenshot-target[title="${shot.select}"]`).click();
|
||||
await page.mouse.move(400, shot.viewport.height - 30);
|
||||
await page.waitForTimeout(1500);
|
||||
@@ -76,12 +86,12 @@ try {
|
||||
await page.mouse.move(shot.viewport.width - 60, shot.viewport.height / 2);
|
||||
await page.waitForTimeout(1200);
|
||||
}
|
||||
if (shot.hash.startsWith("#/compare/") && !page.url().includes(shot.hash)) {
|
||||
throw new Error(`Compare key ${args.compare} is not a screen of this report (the Viewer went to ${page.url()}); pass --compare <key> from a #/compare/<key> URL.`);
|
||||
}
|
||||
const path = `${out}${shot.file}-${theme}.png`;
|
||||
if (shot.framed) await writeFile(path, await stagedWindow(browser, await page.screenshot(), shot.viewport, theme));
|
||||
else await page.screenshot({ path });
|
||||
const path = `${out}${shot.file}-${theme}.${shot.animated ? "svg" : "png"}`;
|
||||
if (shot.animated) {
|
||||
const frames = await captureHeroFrames(page, { select: shot.select, viewport: shot.viewport });
|
||||
await writeFile(path, heroSvg(frames, theme,
|
||||
`Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects ${shot.select} and the Inspector opens on it`));
|
||||
} else await page.screenshot({ path });
|
||||
console.log(path);
|
||||
await context.close();
|
||||
}
|
||||
@@ -114,26 +124,6 @@ try {
|
||||
await server.close?.();
|
||||
}
|
||||
|
||||
/**
|
||||
* A Viewer screenshot as a window on a rounded 1600×900 stage (drawn at 2x), with a hairline border and a soft shadow,
|
||||
* as the post about Explore frames it. The corners outside the stage stay transparent, so it sits on either GitHub theme.
|
||||
*/
|
||||
async function stagedWindow(browser, shot, viewport, theme) {
|
||||
const dark = theme === "dark";
|
||||
const stage = dark ? "#151B23" : "#F6F8FA";
|
||||
const border = dark ? "#3D444D" : "#D1D9E0";
|
||||
const shadow = dark ? "0 2px 4px rgba(1,4,9,0.4), 0 30px 70px rgba(1,4,9,0.6)" : "0 2px 4px rgba(17,17,17,0.04), 0 30px 70px rgba(17,17,17,0.14)";
|
||||
const context = await browser.newContext({ viewport: { width: 1600, height: 900 }, deviceScaleFactor: 2 });
|
||||
const page = await context.newPage();
|
||||
await page.setContent(`<!doctype html><html><body style="margin:0;background:transparent">
|
||||
<div id="stage" style="position:relative;width:1600px;height:900px;background:${stage};border-radius:22px;overflow:hidden">
|
||||
<img src="data:image/png;base64,${shot.toString("base64")}" style="position:absolute;left:${(1600 - viewport.width) / 2}px;top:${(900 - viewport.height) / 2}px;width:${viewport.width}px;height:${viewport.height}px;box-sizing:border-box;border:1px solid ${border};border-radius:14px;box-shadow:${shadow}">
|
||||
</div></body></html>`);
|
||||
const png = await page.locator("#stage").screenshot({ omitBackground: true });
|
||||
await context.close();
|
||||
return png;
|
||||
}
|
||||
|
||||
/**
|
||||
* The comment on a rounded stage as wide as the README column (880 px, drawn at 2x), with a soft shadow and a fade at
|
||||
* the cut. The corners outside the stage stay transparent, so the image sits on either GitHub theme.
|
||||
|
||||
@@ -18,11 +18,35 @@ trap 'rm -rf "$work"' EXIT
|
||||
if ! curl -fsS "$base/reports.json" -o "$work/listing.json"; then
|
||||
echo '[{"platform":"ios"}]' > "$work/listing.json"
|
||||
fi
|
||||
for platform in $(jq -r '.[].platform' "$work/listing.json"); do
|
||||
curl -fsS "$base/report.zip?platform=$platform" -o "$work/$platform.zip"
|
||||
unzip -tq "$work/$platform.zip" > /dev/null
|
||||
# One ZIP per target, named for it: <target>.zip, or <platform>.zip for a report from before targets. A target named
|
||||
# after its platform is selected with ?platform=, any other with ?target= (as viewer-links.ts targetParameter does).
|
||||
# A preview deployed before Explore wrote static files serves each target's ZIP; a newer one serves its manifest and
|
||||
# screenshots, so the ZIP is put back together here. Screenshot requests keep the target's query, which deployments
|
||||
# that answered them from the ZIP need and static files ignore.
|
||||
for key in $(jq -r '.[] | .target // .platform' "$work/listing.json"); do
|
||||
# The listing comes from the hosted preview: a key names files here, so it must be a target id.
|
||||
[[ "$key" =~ ^[a-z][a-z0-9-]{0,31}$ ]] || { echo "Not a target id in reports.json: $key" >&2; exit 2; }
|
||||
case "$key" in ios|android) query="platform=$key" ;; *) query="target=$key" ;; esac
|
||||
if curl -fsS "$base/report.zip?$query" -o "$work/$key.zip" 2> /dev/null; then
|
||||
unzip -tq "$work/$key.zip" > /dev/null
|
||||
continue
|
||||
fi
|
||||
report="$work/$key"
|
||||
mkdir -p "$report/assets"
|
||||
curl -fsS "$base/manifest.json?$query" -o "$work/$key.manifest.json"
|
||||
file="$(jq -r .file "$work/$key.manifest.json")"
|
||||
[[ "$file" == review.json || "$file" == exploration.json ]] || { echo "Not a report manifest: $key" >&2; exit 1; }
|
||||
jq -c .report "$work/$key.manifest.json" > "$report/$file"
|
||||
for asset in $(jq -r '.entries | keys[]' "$work/$key.manifest.json"); do
|
||||
[[ "$asset" =~ ^assets/[a-f0-9]{64}\.(png|jpg|mp4)$ ]] || { echo "Unexpected asset name: $asset" >&2; exit 1; }
|
||||
curl -fsS "$base/$asset?$query" -o "$report/$asset"
|
||||
[[ "$(shasum -a 256 "$report/$asset" | cut -c1-64)" == "${asset:7:64}" ]] || { echo "Checksum mismatch: $asset" >&2; exit 1; }
|
||||
done
|
||||
rm -f "$work/$key.zip"
|
||||
(cd "$report" && zip -qrX "$work/$key.zip" "$file" assets)
|
||||
unzip -tq "$work/$key.zip" > /dev/null
|
||||
done
|
||||
jq --arg source "$source_name" '[.[] | {platform, changes, device, source: $source} | with_entries(select(.value != null))]' "$work/listing.json" > "$work/reports.json"
|
||||
jq --arg source "$source_name" '[.[] | {target, platform, label, changes, device, source: $source} | with_entries(select(.value != null))]' "$work/listing.json" > "$work/reports.json"
|
||||
|
||||
gh release view "$tag" > /dev/null 2>&1 || gh release create "$tag" --prerelease --latest=false --title "Viewer preview fixtures" \
|
||||
--notes "Reports the Viewer preview workflow serves on every pull request. Refresh with scripts/refresh-viewer-preview-fixtures.sh."
|
||||
|
||||
@@ -28,7 +28,7 @@ Platform, bundle id, app name and version are read from the archive; do not pass
|
||||
3. `agent-device install` of the archive straight into the session (Argent: `reinstall-app`; locally `simctl install` or `adb install`), then `open <bundle id>`.
|
||||
4. The model explores through a small tool set (observe, act, capture, finish); app text is treated as untrusted and destructive controls (delete, reset, sign out, purchase, send, share) are blocked outside the model.
|
||||
5. The map and screenshots are written under `--output` (default `./explore-<archive>-<timestamp>`), plus `report/` for the Viewer.
|
||||
6. The report is sealed and deployed to EAS Hosting (`--no-upload` skips this; `--expires-in 7d|30d|never`). With `--simulator local` it opens in the local Viewer instead, which keeps running until stopped; `--json` and `--no-open` skip it, so with `--json` open it afterwards with `view --dir <output>` (in the background, since it serves until stopped). `--upload` hosts it, and that needs an EAS login.
|
||||
6. The report is deployed to EAS Hosting as files under the link's token (`--no-upload` skips this); the link lasts as long as the deployment. With `--simulator local` it opens in the local Viewer instead, which keeps running until stopped; `--json` and `--no-open` skip it, so with `--json` open it afterwards with `view --dir <output>` (in the background, since it serves until stopped). `--upload` hosts it, and that needs an EAS login.
|
||||
7. The exact session is stopped, or the local device deleted; a failure to stop reports `SESSION_CLEANUP_FAILED` with the command to stop it by hand. A local device a hard-stopped run left behind is removed by the next local run.
|
||||
|
||||
Budgets default to 15 minutes, 40 screens, 150 actions (`--max-duration-minutes`, `--max-screens`, `--max-actions`). Steer the model with `--hints "focus on the onboarding and settings"`, skip onboarding with `--launch-url myapp://home`, and allow a specific risky control with `--allow-destructive "Clear cache"`.
|
||||
@@ -111,7 +111,7 @@ With `--json` the last stdout line is the result:
|
||||
```json
|
||||
{ "ok": true, "app": { "name": "euxy", "bundleId": "dev.brent.euxy", "platform": "ios", "version": "1.2.0" },
|
||||
"exploration": { "stopReason": "finished", "screens": 9, "observations": 11, "actions": 23, "summary": "..." },
|
||||
"map": ".../explore-euxy-.../map.json", "report": ".../explore-euxy-.../report", "url": "https://....expo.app/p/<token>", "expiresAt": "..." }
|
||||
"map": ".../explore-euxy-.../map.json", "report": ".../explore-euxy-.../report", "url": "https://....expo.app/p/<token>", "expiresAt": null }
|
||||
```
|
||||
|
||||
Share `url` (it is the only copy of the access token; it is not written to disk). Then query the map locally without a model or device:
|
||||
|
||||
@@ -173,10 +173,10 @@ npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all
|
||||
|
||||
## Compare any two commits
|
||||
|
||||
`explore-compare.yml` (installed by `setup --workflows` from 0.19.0; run `npx @expo/explore@latest setup --workflows` to add it to an existing setup) reviews a `head` against a `base`, each a branch, tag or commit SHA, with no pull request. It captures, compares and reports like a PR review and links the report from the run's summary. Its inputs are `base`, `head`, and the optional `scope` (`changes` or `all`) and `expires-in` (such as `30d`, or `never`).
|
||||
`explore-compare.yml` (installed by `setup --workflows` from 0.19.0; run `npx @expo/explore@latest setup --workflows` to add it to an existing setup) reviews a `head` against a `base`, each a branch, tag or commit SHA, with no pull request. It captures, compares and reports like a PR review and links the report from the run's summary. Its inputs are `base`, `head`, and the optional `scope` (`changes` or `all`); `expires-in` from earlier versions is accepted and ignored, since a hosted link lasts as long as its EAS Hosting deployment.
|
||||
|
||||
- **Releases.** Unless the user asks otherwise, compare each release with the last stable release, with `scope: all` (every screen, so the report shows the whole release with what changed marked) and, when hosted previews are on, `expires-in: never` (the link outlives the 30-day artifact). For every tag as it is pushed, add the `release-review.yml` from the README's "Compare any two commits" section: it finds the newest earlier tag without a `-` (so a release candidate is compared with the last stable release) and calls `explore-compare.yml` with `secrets: inherit` and `permissions: { contents: read, actions: read }`. A nightly compares with yesterday's tag; a release branch with `main`.
|
||||
- **Once, on demand.** The workflow must be on the default branch to be dispatched: `gh workflow run explore-compare.yml -f base=<ref> -f head=<ref> -f scope=all -f expires-in=never`, or **Run workflow** under Actions → Expo Explore compare.
|
||||
- **Releases.** Unless the user asks otherwise, compare each release with the last stable release, with `scope: all` (every screen, so the report shows the whole release with what changed marked). A hosted link lasts as long as its EAS Hosting deployment (30 days on Free, 90 on paid plans, longer with an alias), which can outlive the 30-day artifact. For every tag as it is pushed, add the `release-review.yml` from the README's "Compare any two commits" section: it finds the newest earlier tag without a `-` (so a release candidate is compared with the last stable release) and calls `explore-compare.yml` with `secrets: inherit` and `permissions: { contents: read, actions: read }`. A nightly compares with yesterday's tag; a release branch with `main`.
|
||||
- **Once, on demand.** The workflow must be on the default branch to be dispatched: `gh workflow run explore-compare.yml -f base=<ref> -f head=<ref> -f scope=all`, or **Run workflow** under Actions → Expo Explore compare.
|
||||
- **Without CI.** `npx @expo/explore capture --base <ref> --head <ref> --scope all --upload` runs the same comparison on this machine (see the previous section).
|
||||
- Call the workflow once per workflow run (a second call in the same run reuses the first one's artifact names). A `base` the baseline workflow captured in the last 30 days is reused, so only `head` is captured.
|
||||
- To verify, run it once on the latest tag and open the run's summary: it lists each platform's result and links the report.
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
---
|
||||
name: readme-refresh
|
||||
description: Refresh Expo Explore's README.md with euxy (github.com/brentvatne/euxy) as the reference app. Regenerate every screenshot in docs/screenshots from a current euxy review report and PR comment, then re-read the README as a first-time user: the top level only says what Explore does, links the live euxy example, gives one quick-start prompt to copy that reviews a change to your own app or explores a build you point it to, and one for setting up CI; everything else lives in collapsibles. Use after a Viewer or PR-comment change that the README shows, a new command or setting, or a release that made a README claim stale. Not for the docs/ guides or the shipped skills.
|
||||
description: Refresh Expo Explore's README.md with euxy (github.com/brentvatne/euxy) as the reference app. Regenerate every screenshot and animated SVG in docs/screenshots from a current euxy review report and PR comment, then re-read the README as a first-time user: the top level only says what Explore does, links the live euxy example, gives one quick-start prompt to copy that reviews a change to your own app or explores a build you point it to, and one for setting up CI; everything else lives in collapsibles. Use after a Viewer or PR-comment change that the README shows, a new command or setting, or a release that made a README claim stale. Not for the docs/ guides or the shipped skills.
|
||||
---
|
||||
|
||||
# Refresh the README
|
||||
@@ -24,17 +24,25 @@ scripts/refresh-viewer-preview-fixtures.sh '<hosted link>' brentvatne/euxy#<n>
|
||||
|
||||
Do not pick a same-tree demo PR, where every change is noise. The refreshed fixtures reach the live example on the next push to main, or when you run **Example report** from GitHub Actions. `curl -s "<hosted link>/api/v1/screens?status=added,removed,modified&platform=ios"` lists what changed, which tells you which screen to select and compare.
|
||||
|
||||
## 2. Regenerate every screenshot
|
||||
## 2. Regenerate every screenshot and animation
|
||||
|
||||
```sh
|
||||
npm ci
|
||||
node scripts/readme-screenshots.mjs --report ~/euxy-report/ios.zip --select /settings --compare patterns --pr https://github.com/brentvatne/euxy/pull/<n>
|
||||
node scripts/readme-screenshots.mjs --report ~/euxy-report/ios.zip --select /about --compare patterns --pr https://github.com/brentvatne/euxy/pull/<n>
|
||||
```
|
||||
|
||||
- `--select` is the route selected on the hero Map (the Inspector opens on it): choose an added or clearly modified screen.
|
||||
- `--compare` is the key in the Viewer's `#/compare/<key>` URL for a **modified** screen with outlined regions (open the report, click the screen in Compare, copy the key). The script fails if the key is not in the report.
|
||||
- `--select` is the route the hero's pointer clicks on the Map (the Inspector opens on it): choose an added or clearly modified screen. The script zooms in around it, so it must be a screen the Map shows.
|
||||
- `--compare` is the key in the Viewer's `#/compare/<key>` URL for a **modified** screen with outlined regions (open the report, click the screen in Compare, copy the key): the route without its slash. The script fails if the report has no visually modified screen at that route.
|
||||
- `--pr` screenshots the Explore comment on that PR: the fixtures' `source`. Headless Chromium needs a colour emoji font for the result glyphs (`sudo apt-get install fonts-noto-color-emoji` on Debian/Ubuntu); a comment with hollow boxes where 🟩 should be is not acceptable.
|
||||
- The script serves the report through the Viewer's Vite dev server, so no build is needed. It writes a `-light` and a `-dark` PNG for every shot (the PR comment too: signed-out github.com follows `prefers-color-scheme`). The README shows each pair with `<picture>`: a `<source media="(prefers-color-scheme: dark)">` for the dark file and an `<img>` with the alt text and the light file, which is what GitHub Mobile shows (it ignores the dark source), so the light file is the one that must always be right.
|
||||
- The script serves the report through the Viewer's Vite dev server, so no build is needed. It writes a `-light` and a `-dark` file for every picture (the PR comment too: signed-out github.com follows `prefers-color-scheme`). The README shows each pair with `<picture>`: a `<source media="(prefers-color-scheme: dark)">` for the dark file and an `<img>` with the alt text and the light file, which is what GitHub Mobile shows (it ignores the dark source), so the light file is the one that must always be right.
|
||||
|
||||
Two of the pictures are animated SVGs, built by `scripts/readme-animations.mjs` in the same run; there is nothing else to run when the screenshots change:
|
||||
|
||||
- `readme-hero-*.svg` is made of real Viewer frames at the zoomed Map camera: the Map without screens, the screens without edges, the whole Map, and the Map after the pointer clicks `--select`. The cards appear row by row, the edges wipe in from the top, then the pointer clicks and the Inspector slides in. Each is about 1.4 MB: four 2x JPEG frames inlined, since an SVG shown with `<img>` can load nothing. Anything the Viewer draws on the Map or in the Inspector shows up here on the next run, so regenerate it after a Viewer change the hero shows.
|
||||
- `readme-compare-*.svg` is the `--compare` screen's base capture wiping to its head capture, with the report's changed regions pulsing. It is drawn from `review.json` and the report's assets, not from a Viewer screenshot, so a Viewer change does not stale it, but a new report does.
|
||||
- Both loop on CSS keyframes, and with `prefers-reduced-motion` they hold the last frame: Inspector open, regions outlined. That frame is also what a viewer that does not animate SVG shows, so it must read on its own.
|
||||
|
||||
Open each SVG in a browser before committing, light and dark, and watch a full loop: every card should appear once and land where the whole Map has it, with no hover highlight in the frames before the click; the pointer should click the `--select` card; the Inspector should open on that screen; Compare's outlines should sit on the changed text, not beside it. To look at one moment, pause the animations in the console: `document.getAnimations().forEach(a => { a.pause(); a.currentTime = 5000; })`. Keep the README's `<img>` and `<source>` pointing at the `.svg` files.
|
||||
|
||||
`docs/screenshots/readme-exploration-light.png` is the black-box map and comes from a euxy `explore:binary` run (`npx @expo/explore explore:binary <euxy simulator build> --no-upload`, then `expo-explore view --dir <output>` at 1760×1000, Map, Fit canvas). It has no dark variant and is a plain Markdown image. Regenerate it when the Map's rendering of edges or labels changed; otherwise keep it, and say so in the PR.
|
||||
|
||||
@@ -53,18 +61,18 @@ cd - && npm run build:cli && node scripts/readme-reports-rows.mjs > /tmp/reports
|
||||
- The script renders the picker as the CLI draws it (96 columns, the newest run selected) and writes the terminal body as HTML: each coloured piece is exactly its characters wide, so columns line up, and the wordmark is drawn as cell rectangles, since a design tool's font does not draw `█▀▄` cell for cell.
|
||||
- In Paper, replace the frame named "Terminal" inside each artboard's window with that HTML, check both artboards in a screenshot (crisp wordmark, aligned columns, the selected row highlighted to the end, coloured counts), and export both at 2x as `readme-reports-light.png` and `readme-reports-dark.png`. The window's title bar reads `npx @expo/explore reports`, as people run it.
|
||||
|
||||
Look at every PNG you produced before committing, light and dark: the selected screen should be the one you asked for, the Compare view must show Before and After with outlines, the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links and result glyphs. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
|
||||
Look at every PNG you produced before committing, light and dark: the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links and result glyphs. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
|
||||
|
||||
## 3. Pass over the content as a first-time user
|
||||
|
||||
Read the README top to bottom once without opening a collapsible. At that level it may only answer, in this order:
|
||||
|
||||
1. What Explore is (one short paragraph), the hero image, and the link to the live euxy example (`explore-example--euxy.expo.app`, redeployed on every merge to main by `.github/workflows/example-report.yml`). Under it, one table row of three pictures with a one-line caption each: Compare, Screens, and the PR comment (which says it needs CI), then the agent prompt collapsed as **Ask an agent about a report**. The hero is a zoomed Map framed as a window on a stage (`stagedWindow` in the script); the three below are plain.
|
||||
2. **Quick start**: one path. A single prompt to paste into Claude Code or Codex that reviews a change to the reader's own Expo app through the explore-setup skill's "Review a change on this machine" section, or, when they point it to a build (or the app is not an Expo project), explores a simulator build through the explore-binary skill. Then one sentence on what each case needs (a review needs an Expo account, is built on EAS, and is captured on EAS Simulator or a local simulator; exploring a build needs a Claude Code or Codex login and EAS Simulator or a local simulator, and no Expo account locally). Then one **Run it yourself** collapsible with both by hand: the numbered steps for a review, with nothing optional in them (make the app buildable on EAS: login, init, bundle identifier, a simulator profile named `explore`, and commit, since the before build is the last commit; then edit a screen near its top and run `capture`, or `capture --simulator local`), and the `explore:binary` commands, including `--simulator local`. Then the `reports` picker image (`readme-reports-*.png`) with one sentence on saved runs, at the top level, and one collapsible for other commits (`--committed`, `--base`/`--head`) and what a review does on the machine. Run the steps on a fresh `create-expo-app` before changing them.
|
||||
1. What Explore is (one short paragraph), the hero image, and the link to the live euxy example (`explore-example--euxy.expo.app`, redeployed on every merge to main by `.github/workflows/example-report.yml`). Under it, Compare at full width with a one-line caption, then one table row of two pictures with a one-line caption each: Screens and the PR comment (which says it needs CI), then the agent prompt collapsed as **Ask an agent about a report**. The hero is the animated zoomed Map, framed as a window on a stage, and Compare is the animated wipe (both from `readme-animations.mjs`); the Screens and PR comment pictures are PNGs. Compare gets its own row because a phone wiping from before to after is unreadable at a third of the column.
|
||||
2. **Quick start**: one path. A single prompt to paste into Claude Code or Codex that reviews a change to the reader's own Expo app through the explore-setup skill's "Review a change on this machine" section, or, when they point it to a build (or the app is not an Expo project), explores a simulator build through the explore-binary skill. Then one sentence on what each case needs (a review needs an Expo account, is built on EAS, and is captured on EAS Simulator or a local simulator; exploring a build needs a Claude Code or Codex login and EAS Simulator or a local simulator, and no Expo account locally), and under it one `> [!NOTE]` alert: EAS Simulator is in preview, with the waitlist link and `--simulator local` as the alternative. Then one **Run it yourself** collapsible with both by hand: the numbered steps for a review, with nothing optional in them (make the app buildable on EAS: login, init, bundle identifier, a simulator profile named `explore`, and commit, since the before build is the last commit; then edit a screen near its top and run `capture`, or `capture --simulator local`), and the `explore:binary` commands, including `--simulator local`. Right after **Run it yourself**, one `> [!WARNING]` alert: a review runs both commits' code on the reader's machine, so review only commits they would run. These are the README's only two alerts; do not add more, or they stop standing out. Then the `reports` picker image (`readme-reports-*.png`) with one sentence on saved runs, at the top level, and one collapsible for other commits (`--committed`, `--base`/`--head`) and what a review does on the machine. Run the steps on a fresh `create-expo-app` before changing them.
|
||||
3. **Map every screen of any app**: one sentence on what exploring a build shows (pointing back to the quick start, which runs it), then its collapsibles: its options, exploring a session already started, and what a run without source shows.
|
||||
4. **Set up CI**: one sentence, then two subsections, each a sentence on what it gives and a prompt to paste: **Review on every PR** (the setup prompt, then a few grouped collapsibles: Hosted previews first, then Manual setup (the setup prompt's steps done by hand, in order: setup, doctor, secrets, baseline, first PR), Capture modes: deterministic or agent, iOS, Android, or both, Keep your setup current) and **Compare any two commits** (a prompt that follows the explore-setup skill's "Compare any two commits" section, the ways to snapshot a release as bullets, then the comparison workflow collapsed).
|
||||
|
||||
Lead with prompts, not explanations: a reader should be able to copy something and see Explore work. Everything else, the manual commands, requirements, options, the manual setup, capture modes, hosted previews, iOS and Android, agent mode, repository settings, how agents read a report, how it works, limitations, contributing, goes into a `<details>` block under the section it belongs to, with a `<summary>` that says what the reader will find. Keep bullets to one or two sentences. Group related collapsibles rather than adding one per topic, so a section shows a handful, not nine. Requirements sit collapsed right under the example report link. Keep the collapsibles' `id` attributes that other docs link to (`#hosted-previews`, `#platforms`, `#compare`, `#agents`); the Terms and How agents read a report collapsibles live under Additional information, and keep the Inspiration section (screenmap and Revyl's Atlas).
|
||||
Lead with prompts, not explanations: a reader should be able to copy something and see Explore work. Everything else, the manual commands, requirements, options, the manual setup, capture modes, hosted previews, iOS and Android, agent mode, repository settings, how agents read a report, how it works, limitations, contributing, goes into a `<details>` block under the section it belongs to, with a `<summary>` that says what the reader will find. Keep bullets to one or two sentences. Group related collapsibles rather than adding one per topic, so a section shows a handful, not nine. Requirements sit collapsed right under the example report link. The **How it works** collapsible opens with a Mermaid `sequenceDiagram` of a PR review (pull request, GitHub Actions, EAS Build, EAS Simulator), followed by the facts it cannot show as bullets: who triggers a review, what Modified means, session retries. Check its steps against `CI-FLOW.md` and the `ci:*` commands, and edit the diagram's text, not a picture: GitHub draws it. Keep the collapsibles' `id` attributes that other docs link to (`#hosted-previews`, `#platforms`, `#compare`, `#agents`); the Terms and How agents read a report collapsibles live under Additional information, and keep the Inspiration section (screenmap and Revyl's Atlas).
|
||||
|
||||
Check that each prompt still works as written:
|
||||
- the skill links it names (`https://unpkg.com/@expo/explore/skills/...`) are files the package ships (`files` in `package.json`), and they open from the published release;
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
import { createHash, randomUUID } from "node:crypto";
|
||||
import { createRequire } from "node:module";
|
||||
import { lstat, mkdir, mkdtemp, readFile, realpath, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
@@ -17,13 +16,14 @@ import { agentDeviceLauncher, ensureArgentToolServer, ensureController } from ".
|
||||
import { agentDeviceClaims, approveLinkScheme, createLocalSimulator, deleteLocalEmulator, deleteLocalSimulator, hostEmulatorAbi, installOnLocalEmulator, installOnLocalSimulator, startLocalArgentServer,
|
||||
startLocalEmulator, stopLocalAgentDevice, stopLocalArgentServer, waitForLocalEmulator, waitForLocalSimulator, type LocalArgentServer } from "../capture/local-simulator.js";
|
||||
import { openLocalCaptureRecord, sweepLocalCaptures } from "../capture/local-registry.js";
|
||||
import { approveSessionUrlSchemes, simulatorControlActions, type EasCommand } from "../capture/simulator-control.js";
|
||||
import { DEFAULT_ANDROID_DEVICE } from "../config/explore-config.js";
|
||||
import { createExplorationInputs } from "../config/exploration-inputs.js";
|
||||
import { ExploreStore, getCoverage } from "../map/store.js";
|
||||
import { whoamiAccounts } from "../report/preview-deploy.js";
|
||||
import { CiError, serializeCiError, toCiError } from "../shared/ci-errors.js";
|
||||
import { packageBin } from "../shared/package-paths.js";
|
||||
import { assertDecodedPng, type DecodedFrame } from "../shared/png-evidence.js";
|
||||
import { assertDecodedPng, solidColour } from "../shared/png-evidence.js";
|
||||
import { CONTRACT, type ExploreMap, type Platform } from "../types.js";
|
||||
import { assertEmulatorCompatible, extractIosBundle, inspectArchive, type ArchiveKind, type InspectedArchive, readArchiveIcon } from "./archive.js";
|
||||
import { runBlackBoxExploration, type BlackBoxExplorerResult, type BlackBoxFrame, SYSTEM_DIALOG_PACKAGES } from "./explorer.js";
|
||||
@@ -277,6 +277,8 @@ export type ConnectedSessionExploration = {
|
||||
* serial (agent-device with a daemon of its own in `stateDirectory`, or a local Argent tool-server pinned to it).
|
||||
*/
|
||||
local?: { deviceId: string; osVersion: string; stateDirectory: string };
|
||||
/** Runs once the app is installed and before anything opens it, as an EAS session's link approval must. */
|
||||
afterInstall?: () => void;
|
||||
};
|
||||
|
||||
/** Drives an agent-device daemon we already hold a connection to: optional install, open, then the model-led exploration. */
|
||||
@@ -317,6 +319,7 @@ export async function exploreConnectedSession(ctx: ConnectedSessionExploration):
|
||||
try { controller(["install", install.path, "--json"], 15 * 60_000); }
|
||||
catch (error) { throw binaryError("APP_INSTALL_FAILED", `${controllerName} could not install the app: ${failureText(error)}`, "Check that the archive is a simulator build for this platform and under the size limit, then rerun.", { sessionId: connection.sessionId }); }
|
||||
}
|
||||
ctx.afterInstall?.();
|
||||
// On a local device, the first open also builds agent-device's iOS runner.
|
||||
const opened = controller(["open", bundleId, "--level", "full", "--json"], local ? 15 * 60_000 : 2 * 60_000);
|
||||
const openedDevice = openedSimulatorDevice(opened.stdout, bundleId, "initial app open", platform, controllerSession);
|
||||
@@ -714,7 +717,8 @@ export async function runBinaryExploration(options: BinaryExploreOptions): Promi
|
||||
let installPath = archive.path;
|
||||
if (archive.kind === "ios-tgz" || archive.kind === "ios-ipa") { say("unpacking the iOS bundle"); installPath = await extractIosBundle(archive, join(work, "bundle")); }
|
||||
const appIcon = await readArchiveIcon(archive);
|
||||
const exploreOn = (connection: SimulatorConnection, sessionJson: () => string, localDevice?: LocalDevice) => exploreConnectedSession({ connection, platform, device, bundleId,
|
||||
const exploreOn = (connection: SimulatorConnection, sessionJson: () => string, localDevice?: LocalDevice, afterInstall?: () => void) => exploreConnectedSession({ connection, platform, device, bundleId,
|
||||
...(afterInstall ? { afterInstall } : {}),
|
||||
...(appIcon ? { appIcon } : {}), app: { name: archive.appName, ...(archive.version ? { version: archive.version } : {}) },
|
||||
// A local device has the app installed by simctl or adb before the controller starts.
|
||||
...(localDevice ? { local: localDevice } : { install: { path: installPath, kind: archive.kind } }),
|
||||
@@ -770,7 +774,18 @@ export async function runBinaryExploration(options: BinaryExploreOptions): Promi
|
||||
if (handoff.validationError) throw handoff.validationError;
|
||||
if (!handoff.connection) throw new Error("Simulator handoff is missing its controller connection");
|
||||
await rm(dotenvPath, { force: true });
|
||||
({ runtime, exploration } = await exploreOn(handoff.connection, () => eas(["simulator:get", "--id", handoff.connection!.sessionId, "--json", "--non-interactive"], 2 * 60_000).stdout));
|
||||
// The app's own links open without iOS asking first, when the session's host can approve them (serve-sim 0.10.0).
|
||||
const verifiedSession = sessionId;
|
||||
const sessionEas: EasCommand = (args, commandOptions) => {
|
||||
const result = eas(args, commandOptions?.timeoutMs);
|
||||
if (result.status !== 0 && !commandOptions?.allowFailure) throw new Error(lastLine(result.stderr || result.stdout) || `eas ${args[0]} failed`);
|
||||
return result;
|
||||
};
|
||||
const afterInstall = platform === "ios" && archive.urlSchemes.length ? () => {
|
||||
const approved = approveSessionUrlSchemes(sessionEas, verifiedSession, simulatorControlActions(sessionEas, verifiedSession), bundleId, archive.urlSchemes);
|
||||
if (approved.length) say(`approved ${approved.map(item => `${item}://`).join(", ")} links on the session`);
|
||||
} : undefined;
|
||||
({ runtime, exploration } = await exploreOn(handoff.connection, () => eas(["simulator:get", "--id", handoff.connection!.sessionId, "--json", "--non-interactive"], 2 * 60_000).stdout, undefined, afterInstall));
|
||||
}
|
||||
} catch (error) {
|
||||
primaryError = toCiError(error, { code: "EXPLORE_BINARY_FAILED", stage: "exploration", nextAction: "Inspect the diagnostic, correct the failing prerequisite, and rerun explore:binary." });
|
||||
@@ -839,18 +854,7 @@ export function assertAppUrl(url: string, appSchemes: readonly string[] = []): v
|
||||
|
||||
export const BLANK_SCREENSHOT_MESSAGE = "The app blocks screen capture on this screen (Android FLAG_SECURE), so its screenshot came back blank.";
|
||||
|
||||
/** A capture-protected screen comes back as a single flat colour (black on Android); every 97th pixel is enough to tell. */
|
||||
export function solidColour(png: Buffer): boolean {
|
||||
let frame: DecodedFrame;
|
||||
try { frame = createRequire(import.meta.url.replace(/\?.*$/, ""))("pngjs").PNG.sync.read(png, { checkCRC: false }) as DecodedFrame; }
|
||||
catch { return false; }
|
||||
const { data } = frame;
|
||||
if (data.length < 4) return false;
|
||||
for (let offset = 0; offset + 3 < data.length; offset += 4 * 97) {
|
||||
if (data[offset] !== data[0] || data[offset + 1] !== data[1] || data[offset + 2] !== data[2]) return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
export { solidColour };
|
||||
|
||||
/** Setup commands whose last positional is free text (`fill <ref> <text>`, `type <text>`): move the flags ahead of a `--` separator. */
|
||||
export function guardPositionals(args: readonly string[]): string[] {
|
||||
|
||||
@@ -301,7 +301,8 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
|
||||
|
||||
/** Reads are resent after a transport failure (they change nothing); a UI action is sent once, after a health check. */
|
||||
const call = async (tool: string, args: Record<string, unknown> = {}, options?: { out?: string }): Promise<Record<string, unknown>> => {
|
||||
const withDevice = tool === "list-devices" ? args : { udid: state.udid, ...args };
|
||||
// Tools that name devices their own way (or none) take no udid.
|
||||
const withDevice = tool === "list-devices" || tool === "stop-all-simulator-servers" ? args : { udid: state.udid, ...args };
|
||||
for (let attempt = 0; ; attempt++) {
|
||||
try { return record(await context.call(tool, withDevice, options)); }
|
||||
catch (error) {
|
||||
@@ -619,6 +620,10 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
|
||||
const posture = positional[0];
|
||||
if (posture !== "closed" && posture !== "half-open" && posture !== "open") throw new BridgeFailure("INVALID_ARGS", "fold needs closed, half-open or open.");
|
||||
await beforeAction();
|
||||
// Helpers the tool-server started before a fold can leave the panel it lights black and unread: on a fresh EAS
|
||||
// session, whose tool-server started them at boot, the first fold opened to a black inner panel every time
|
||||
// without this, and read the panel at once with it. A local tool-server is Explore's own and starts clean.
|
||||
await call("stop-all-simulator-servers", { devices: [state.udid] });
|
||||
const folded = await call("fold", { posture });
|
||||
// The other panel lights at another size: every stored coordinate and element reference is stale.
|
||||
delete state.screen;
|
||||
@@ -630,16 +635,33 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
|
||||
const lit = record(folded.screen);
|
||||
if (finite(lit.width) && finite(lit.height) && lit.height > 0) {
|
||||
const litRatio = lit.width / lit.height;
|
||||
let followed = false;
|
||||
for (let poll = 0; poll < 10 && !followed; poll++) {
|
||||
const shape = (await tree()).screen;
|
||||
followed = !!shape && shape.height > 0 && Math.abs(shape.width / shape.height - litRatio) < 0.004;
|
||||
if (!followed) await context.sleep(1_000);
|
||||
const follows = async () => {
|
||||
for (let poll = 0; poll < 10; poll++) {
|
||||
const shape = (await tree()).screen;
|
||||
if (shape && shape.height > 0 && Math.abs(shape.width / shape.height - litRatio) < 0.004) return true;
|
||||
await context.sleep(1_000);
|
||||
}
|
||||
return false;
|
||||
};
|
||||
// A reader still stuck on the dark panel is reset once more (the device's helpers, as reset-reader does): it is
|
||||
// cheap and leaves the app alone. If that is not enough, capture restarts SpringBoard and folds again.
|
||||
if (!await follows() && !await call("stop-all-simulator-servers", { devices: [state.udid] }).then(follows, () => false)) {
|
||||
throw new BridgeFailure("CONTROLLER_FOLD_UNVERIFIED", `Argent kept reading the other panel after folding the device ${posture}, and after its device helpers were reset.`);
|
||||
}
|
||||
if (!followed) throw new BridgeFailure("CONTROLLER_FOLD_UNVERIFIED", `Argent kept reading the other panel after folding the device ${posture}.`);
|
||||
}
|
||||
return success({ action: "fold", pose: posture, ...(folded.panel !== undefined ? { panel: folded.panel } : {}) });
|
||||
}
|
||||
case "reset-reader": {
|
||||
// Stops the device's Argent helpers, among them the accessibility service describe reads through; the
|
||||
// tool-server starts fresh ones on the next call. It is how a reader stuck on the panel a fold turned off is
|
||||
// reset where the tool-server itself cannot be restarted, as on EAS (it started it; never stop it there).
|
||||
await ensureDevice();
|
||||
const stopped = await call("stop-all-simulator-servers", { devices: [state.udid] });
|
||||
delete state.screen;
|
||||
delete state.refs;
|
||||
state.generation += 1;
|
||||
return success({ action: "reset-reader", stopped: Array.isArray(stopped.stopped) ? stopped.stopped.filter(item => typeof item === "string") : [] });
|
||||
}
|
||||
case "apps": return success({ apps: [] });
|
||||
case "session": return success({ sessions: [] });
|
||||
// TODO(argent#1509): map `settings appearance <scheme>` to Argent's `set-appearance` once a release with it is pinned.
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { CiError } from "../shared/ci-errors.js";
|
||||
|
||||
export const EAS_CLI_VERSION = "25.0.0";
|
||||
export const EAS_CLI_VERSION = "25.2.0";
|
||||
export { AGENT_DEVICE_VERSION } from "../shared/agent-device-version.js";
|
||||
|
||||
export const CONTROLLER_SESSION = "expo-explore-runtime";
|
||||
|
||||
@@ -92,7 +92,7 @@ export function approveLinkScheme(options: { runner: CommandRunner; udid: string
|
||||
}
|
||||
|
||||
/** The pixel size of a PNG, from its header. */
|
||||
function pngSize(bytes: Buffer): { width: number; height: number } | undefined {
|
||||
export function pngSize(bytes: Buffer): { width: number; height: number } | undefined {
|
||||
if (bytes.length < 24 || bytes.toString("latin1", 12, 16) !== "IHDR") return undefined;
|
||||
return { width: bytes.readUInt32BE(16), height: bytes.readUInt32BE(20) };
|
||||
}
|
||||
@@ -294,8 +294,9 @@ export async function reservePort(port: number, environment: NodeJS.ProcessEnv):
|
||||
const abandoned = async (path: string) => {
|
||||
const info = await stat(path).catch(() => undefined);
|
||||
if (!info) return false;
|
||||
const owner = await readFile(join(path, "owner"), "utf8").catch(() => undefined);
|
||||
return owner === undefined ? Date.now() - info.mtimeMs > 10_000 : !processAlive(Number(owner));
|
||||
// writeFile creates the owner file before it writes the pid, so an empty one is a holder mid-write too.
|
||||
const owner = await readFile(join(path, "owner"), "utf8").catch(() => "");
|
||||
return owner === "" ? Date.now() - info.mtimeMs > 10_000 : !processAlive(Number(owner));
|
||||
};
|
||||
for (;;) {
|
||||
try { await mkdir(mutex); await writeFile(join(mutex, "owner"), String(process.pid)); break; }
|
||||
|
||||
@@ -22,14 +22,16 @@ import { loadAppIcon, loadCachedAppIcon, storeAppIcon } from "./app-icon.js";
|
||||
import { defaultRunner, runAgentControllerCommand } from "./controller.js";
|
||||
import { silentProgress, type Progress } from "../shared/progress.js";
|
||||
import { assertCaptureEasProfile, assertSimulatorAvailable, fingerprintFrom, hasEasEnvironmentFetchFailure, nativeBuildFrom, existingBuild, repackProfileFrom, prepareExactSourceBuild, type RepackMode } from "./eas-build.js";
|
||||
import { SIMULATOR_DOTENV_FILE_NAME, SIMULATOR_DOTENV_HEADER, simulatorSessionName, simulatorStartFailure, readSimulatorDotenvHandoff, assertSimulatorSessionIdentity, assertSimulatorStopped, collectRuntime, controllerVersion, simulatorOsVersion, type ActiveSimulatorRuntime, type SimulatorConnection } from "./simulator.js";
|
||||
import { SIMULATOR_DOTENV_FILE_NAME, SIMULATOR_DOTENV_HEADER, endedOwnSimulatorSession, liveSimulatorSessionsNamed, simulatorSessionName, simulatorStartFailure, readSimulatorDotenvHandoff, assertSimulatorSessionIdentity, assertSimulatorStopped, collectRuntime, controllerVersion, simulatorOsVersion, type ActiveSimulatorRuntime, type SimulatorConnection } from "./simulator.js";
|
||||
import { argentControllerInvocation } from "./controller-invocation.js";
|
||||
import { sharedBuild } from "./shared-build.js";
|
||||
import { LOCAL_EMULATOR_STATE_PREFIX, LOCAL_SIMULATOR_STATE_PREFIX, agentDeviceClaims, assertLocalEmulatorCompatible, createLocalSimulator, startLocalEmulator, waitForLocalEmulator, waitForLocalSimulator, deleteLocalEmulator,
|
||||
deleteLocalSimulator, hostEmulatorAbi, installOnLocalEmulator, installOnLocalSimulator, approveLinkScheme, localPoseShown,
|
||||
setLocalEmulatorAppearance, setLocalSimulatorAppearance, startLocalArgentServer, stopLocalAgentDevice, stopLocalArgentServer, type LocalArgentServer } from "./local-simulator.js";
|
||||
pngSize, setLocalEmulatorAppearance, setLocalSimulatorAppearance, startLocalArgentServer, stopLocalAgentDevice, stopLocalArgentServer, type LocalArgentServer } from "./local-simulator.js";
|
||||
import { ensureArgentToolServer } from "../shared/controller-cache.js";
|
||||
import { openLocalCaptureRecord } from "./local-registry.js";
|
||||
import { approveSessionUrlSchemes, simulatorControl, simulatorControlActions, type EasCommand } from "./simulator-control.js";
|
||||
import { solidColour } from "../shared/png-evidence.js";
|
||||
import { type UnattributedSetting } from "./unattributed.js";
|
||||
import { appScheme, hasConcreteRoutePath, unavailableRoute, capturePlannedRoutes, deviceArgs } from "./route-capture.js";
|
||||
|
||||
@@ -98,6 +100,20 @@ export type CiMapResult = {
|
||||
};
|
||||
|
||||
|
||||
/** New EAS sessions a capture starts in place of one EAS failed to start (ERRORED while booting, or never named). */
|
||||
const SESSION_START_RETRIES = 5;
|
||||
/**
|
||||
* The most time, from the first failed start, that replacement sessions may take, waits included. It keeps a review
|
||||
* inside its CI job (90 minutes for a baseline) with a native build, a repack and both captures still to run.
|
||||
*/
|
||||
const SESSION_RETRY_BUDGET_MS = 30 * 60_000;
|
||||
/** How long one `eas simulator:start` may take: eas-cli waits up to 15 minutes for a session, not counting the queue. */
|
||||
const SESSION_START_TIMEOUT_MS = 20 * 60_000;
|
||||
/** The wait before each of them: 10 s, doubling, at most 2 minutes. */
|
||||
export function sessionRetryDelayMs(retry: number): number {
|
||||
return Math.min(10_000 * 2 ** (retry - 1), 120_000);
|
||||
}
|
||||
|
||||
/**
|
||||
* Minutes an EAS session is asked for beyond the capture's own budget. The session starts beside the repack, and the
|
||||
* capture deadline only starts once the app is installed, so the session also has to outlast a slow or queued hosted
|
||||
@@ -113,6 +129,17 @@ function sessionDurationLimit(error: unknown): number | undefined {
|
||||
return match ? Math.floor(Number(match[1])) : undefined;
|
||||
}
|
||||
|
||||
/**
|
||||
* A start failure EAS may not repeat on the next try: a failed request, a dropped connection, a timeout, or no capacity
|
||||
* right now. An account's quota, plan or permissions are not, and fail at once rather than after every retry.
|
||||
*/
|
||||
function transientSessionStartFailure(error: unknown): boolean {
|
||||
if (error instanceof CiError && error.code === "CONTROLLER_REQUEST_TIMEOUT") return true;
|
||||
const message = error instanceof Error ? error.message : String(error);
|
||||
if (/not authori[sz]ed|unauthori[sz]ed|forbidden|permission|quota|billing|max duration/i.test(message)) return false;
|
||||
return /GraphQL request failed|ECONNRESET|ETIMEDOUT|EAI_AGAIN|socket hang up|timed out|\b50[234]\b|capacity/i.test(message);
|
||||
}
|
||||
|
||||
function positiveInteger(value: number, name: string): number {
|
||||
if (!Number.isInteger(value) || value <= 0) {
|
||||
throw new Error(`${name} must be a positive integer`);
|
||||
@@ -411,17 +438,26 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
say(`reading EAS build profile ${options.easProfile}`);
|
||||
const eas = (args: string[], timeoutMs = 5 * 60_000, cwd = project) => runner({ command: options.easCommand, args,
|
||||
cwd, environment: easEnvironment, timeoutMs });
|
||||
// `eas simulator:control` names the session by id, from the session's own project directory.
|
||||
const sessionEas: EasCommand = (args, commandOptions) => runner({ command: options.easCommand, args, cwd: simulatorProject, environment: easEnvironment,
|
||||
timeoutMs: commandOptions?.timeoutMs ?? 5 * 60_000, ...(commandOptions?.allowFailure ? { allowFailure: true } : {}) });
|
||||
// What the EAS session's host can do through simulator:control (iOS sessions on serve-sim 0.10.0 or later).
|
||||
let controlActions = new Set<string>();
|
||||
const configResult = eas(["config", "--platform", options.platform, "--profile", options.easProfile, "--json", "--non-interactive"]);
|
||||
const profile = repackProfileFrom(configResult.stdout);
|
||||
const configValue = parseJson(configResult.stdout, "eas config") as { appConfig: Record<string, unknown>; buildProfile: Record<string, unknown> };
|
||||
scheme ??= appScheme(configValue.appConfig.scheme);
|
||||
colorSchemes = resolveColorSchemes(options.appearance ?? "auto", configValue.appConfig, options.platform);
|
||||
// Argent cannot switch the appearance itself; on a local device the host switches it (simctl, adb), so it is kept.
|
||||
if (controller === "argent" && !local) {
|
||||
const single = argentColorSchemes(colorSchemes, configValue.appConfig, options.platform);
|
||||
if (single.skipped.length) say(`Argent cannot switch appearance yet (software-mansion/argent#1509); capturing ${single.schemes[0]} only, skipped ${single.skipped.join(", ")}`);
|
||||
colorSchemes = single.schemes;
|
||||
}
|
||||
// Argent cannot switch the appearance itself. On a local device the host switches it (simctl, adb); on an EAS iOS
|
||||
// session serve-sim does (appearance.set), which is known once the session starts; otherwise one appearance is captured.
|
||||
let argentSchemes = controller === "argent" && !local ? argentColorSchemes(colorSchemes, configValue.appConfig, options.platform) : undefined;
|
||||
const narrowToArgentScheme = () => {
|
||||
if (!argentSchemes) return;
|
||||
if (argentSchemes.skipped.length) say(`Argent cannot switch appearance on this session; capturing ${argentSchemes.schemes[0]} only, skipped ${argentSchemes.skipped.join(", ")}`);
|
||||
colorSchemes = argentSchemes.schemes;
|
||||
argentSchemes = undefined;
|
||||
};
|
||||
if (options.platform !== "ios") narrowToArgentScheme();
|
||||
app = { name: profile.projectIdentity.name, ...(profile.projectIdentity.version ? { version: profile.projectIdentity.version } : {}),
|
||||
...(profile.projectIdentity.buildNumber ? { buildNumber: profile.projectIdentity.buildNumber } : {}) };
|
||||
projectId = profile.projectIdentity.projectId;
|
||||
@@ -491,19 +527,23 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
}
|
||||
} catch (error) { await stopEarlyDevice().catch(() => undefined); throw error; }
|
||||
// The session is named before its app exists: an EAS session starts while the app is repacked (startSession).
|
||||
const sessionName = simulatorSessionName({ mapName: options.name, mapId: options.buildId, gitCommit: options.gitCommit, easBuildId: local ? "local" : "installed",
|
||||
runIdentity: JSON.stringify({ mapDirectory, outputDirectory, run: sourceEnvironment.GITHUB_RUN_ID, attempt: sourceEnvironment.GITHUB_RUN_ATTEMPT }) });
|
||||
// A session EAS failed to start is replaced once (see the session block), under a name of its own.
|
||||
const sessionNameFor = (retry: number) => simulatorSessionName({ mapName: options.name, mapId: options.buildId, gitCommit: options.gitCommit, easBuildId: local ? "local" : "installed",
|
||||
runIdentity: JSON.stringify({ mapDirectory, outputDirectory, run: sourceEnvironment.GITHUB_RUN_ID, attempt: sourceEnvironment.GITHUB_RUN_ATTEMPT, ...(retry ? { sessionRetry: retry } : {}) }) });
|
||||
let sessionRetries = 0;
|
||||
let sessionName = sessionNameFor(0);
|
||||
/**
|
||||
* Starts the EAS Simulator session in the background, empty, once the build to repack is known (not while a native
|
||||
* build runs, which can take most of an hour of session time). The app is installed through the controller when both
|
||||
* are ready. Resolves with the start command's failure, if any; the session block verifies what EAS handed over.
|
||||
*/
|
||||
const startSession = () => {
|
||||
const startSession = (retry?: { timeoutMs: number }) => {
|
||||
if (local || sessionStart) return;
|
||||
say(`starting an EAS Simulator session (${options.device}) while the app is repacked`);
|
||||
if (!retry) say(`starting an EAS Simulator session (${options.device}) while the app is repacked`);
|
||||
const request = (minutes: number) => ({ command: options.easCommand, args: ["simulator:start", "--name", sessionName, "--platform", options.platform, "--device", options.device,
|
||||
"--type", controller, "--package-version", controllerVersion(controller), "--public-link",
|
||||
"--max-duration-minutes", String(minutes), "--out-config-type", "dotenv", "--non-interactive"], cwd: simulatorProject, environment: easEnvironment, timeoutMs: 20 * 60_000 });
|
||||
"--max-duration-minutes", String(minutes), "--out-config-type", "dotenv", "--non-interactive"], cwd: simulatorProject, environment: easEnvironment,
|
||||
timeoutMs: retry?.timeoutMs ?? SESSION_START_TIMEOUT_MS });
|
||||
// An injected runner (tests) answers synchronously; a real start runs beside the repack.
|
||||
const start = async (minutes: number) => options.runner ? options.runner(request(minutes)) : runAgentControllerCommand(request(minutes), options.signal ?? new AbortController().signal);
|
||||
sessionStart = writeFile(dotenvPath, SIMULATOR_DOTENV_HEADER, { flag: "wx", mode: 0o600 })
|
||||
@@ -597,8 +637,72 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
throw new Error("The local device did not start before capture");
|
||||
} else {
|
||||
if (!localApp || !sessionStart) throw new Error("An EAS Simulator session needs the instrumented app on this machine");
|
||||
const startError = await sessionStart;
|
||||
const handoff = await readSimulatorDotenvHandoff(dotenvPath);
|
||||
let startError = await sessionStart;
|
||||
let handoff = await readSimulatorDotenvHandoff(dotenvPath);
|
||||
// EAS sometimes fails to start a session: it errors while booting, or the start request fails before a session is
|
||||
// named. After every failed start, whatever it may have left running is accounted for; then, when the failure is
|
||||
// provably EAS's, a new session replaces it, up to SESSION_START_RETRIES times within SESSION_RETRY_BUDGET_MS, with
|
||||
// a growing wait. A session Explore cannot prove is its own is never replaced or stopped: that stays a handoff
|
||||
// failure below, as does a lookup that fails.
|
||||
const clock = options.now ?? Date.now;
|
||||
const endedSessions: string[] = [];
|
||||
let ended: { sessionId: string; status: string } | undefined;
|
||||
let retryDeadline: number | undefined;
|
||||
for (;;) {
|
||||
const easRead = (args: string[]) => {
|
||||
try { return runner({ command: options.easCommand, args, cwd: project, environment: easEnvironment, timeoutMs: 2 * 60_000, allowFailure: true }).stdout; }
|
||||
catch { return ""; }
|
||||
};
|
||||
let reason: string | undefined;
|
||||
ended = undefined;
|
||||
if (handoff.sessionId) {
|
||||
const status = endedOwnSimulatorSession(easRead(["simulator:get", "--id", handoff.sessionId, "--json", "--non-interactive"]),
|
||||
{ sessionId: handoff.sessionId, sessionName, project: profile.projectIdentity, type: controller, platform: options.platform });
|
||||
if (status) {
|
||||
ended = { sessionId: handoff.sessionId, status };
|
||||
endedSessions.push(handoff.sessionId);
|
||||
reason = `EAS ended simulator session ${handoff.sessionId} (${status}) before it was ready`;
|
||||
}
|
||||
} else if (startError && transientSessionStartFailure(startError)) {
|
||||
// The failed request may still have created a session: any by this exact name is stopped, so none is left running.
|
||||
const live = liveSimulatorSessionsNamed(easRead(["simulator:list", "--name", sessionName, "--status", "new", "--status", "queued", "--status", "starting",
|
||||
"--status", "in-progress", "--limit", "100", "--json", "--non-interactive"]), sessionName, profile.projectIdentity);
|
||||
if (live) {
|
||||
for (const id of live) assertSimulatorStopped(eas(["simulator:stop", "--id", id, "--json", "--non-interactive"], 2 * 60_000).stdout, id);
|
||||
reason = `EAS could not start the simulator session (${simulatorStartFailure(startError, [options.expoToken]).message})`;
|
||||
}
|
||||
}
|
||||
if (!reason || sessionRetries >= SESSION_START_RETRIES) break;
|
||||
retryDeadline ??= clock() + SESSION_RETRY_BUDGET_MS;
|
||||
const delayMs = sessionRetryDelayMs(sessionRetries + 1);
|
||||
// A new start needs at least a minute of the budget after its wait; one started later could not finish in it.
|
||||
const startTimeoutMs = Math.min(SESSION_START_TIMEOUT_MS, retryDeadline - clock() - delayMs);
|
||||
if (startTimeoutMs < 60_000) break;
|
||||
sessionRetries += 1;
|
||||
say(`${reason}; starting a new EAS Simulator session in ${Math.round(delayMs / 1000)} s (${sessionRetries}/${SESSION_START_RETRIES})`);
|
||||
options.signal?.throwIfAborted();
|
||||
// Asynchronous and cancellable, so targets capturing beside this one keep running and Ctrl+C stops the wait.
|
||||
if (options.sleep) options.sleep(delayMs);
|
||||
else await new Promise<void>((resolve, reject) => {
|
||||
const timer = setTimeout(() => { options.signal?.removeEventListener("abort", abort); resolve(); }, delayMs);
|
||||
const abort = () => { clearTimeout(timer); reject(options.signal!.reason); };
|
||||
options.signal?.addEventListener("abort", abort, { once: true });
|
||||
});
|
||||
options.signal?.throwIfAborted();
|
||||
await rm(dotenvPath, { force: true });
|
||||
sessionName = sessionNameFor(sessionRetries);
|
||||
sessionStart = undefined;
|
||||
startSession({ timeoutMs: startTimeoutMs });
|
||||
startError = await sessionStart;
|
||||
handoff = await readSimulatorDotenvHandoff(dotenvPath);
|
||||
}
|
||||
// Every session EAS ended is its own failure to start, never a question of ownership.
|
||||
if (ended) throw new CiError({ code: "SIMULATOR_START_FAILED", stage: "session",
|
||||
message: `EAS could not start a simulator session: ${endedSessions.length === 1 ? `session ${ended.sessionId} ended (${ended.status}) before it was ready`
|
||||
: `${endedSessions.length} sessions ended before they were ready (the last, ${ended.sessionId}, ${ended.status})`}.`,
|
||||
nextAction: "Rerun Explore. If sessions keep failing to start, check the EAS Simulator status and the sessions' logs on expo.dev.",
|
||||
retryable: true, details: { attempts: sessionRetries + 1, endedSessions, ...(startError ? { startFailure: simulatorStartFailure(startError, [options.expoToken]) } : {}) },
|
||||
...(startError ? { cause: startError } : {}) });
|
||||
const startSecrets = [options.expoToken, ...(handoff.connection ? [handoff.connection.daemonAuthToken] : [])];
|
||||
const startFailure = startError ? simulatorStartFailure(startError, startSecrets) : undefined;
|
||||
if (handoff.sessionId) {
|
||||
@@ -628,6 +732,8 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
if (!handoff.connection) throw new Error("Simulator handoff is missing its controller connection");
|
||||
connection = handoff.connection;
|
||||
await rm(dotenvPath, { force: true });
|
||||
if (options.platform === "ios") controlActions = simulatorControlActions(sessionEas, sessionId);
|
||||
if (!controlActions.has("appearance.set")) narrowToArgentScheme();
|
||||
}
|
||||
const controllerConfig = join(simulatorProject, "agent-device.json");
|
||||
await writeFile(controllerConfig, "{}\n", { flag: "wx", mode: 0o400 });
|
||||
@@ -655,14 +761,22 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
say(`installing the app on session ${sessionId}`);
|
||||
runner({ command: controllerCommand, args: ["install", localApp, "--session", CONTROLLER_SESSION, ...deviceArgs({ platform: options.platform, deviceModel: options.device }),
|
||||
"--platform", options.platform, "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 15 * 60_000 });
|
||||
// Before any link opens, as a local capture does with simctl: the app's own links then open without the prompt.
|
||||
if (sessionId && scheme) {
|
||||
const approved = approveSessionUrlSchemes(sessionEas, sessionId, controlActions, options.bundleId, [scheme]);
|
||||
if (approved.length) say(`approved ${approved.map(item => `${item}://`).join(", ")} links on session ${sessionId}`);
|
||||
}
|
||||
}
|
||||
if (options.devicePose) {
|
||||
// A fold relights the other panel and resizes the window. It comes before the app is first opened or read, so the
|
||||
// controller's accessibility reader starts on the lit panel: Argent's, started on the outer panel, can stay there.
|
||||
say(`folding ${options.device} ${options.devicePose}`);
|
||||
const target = deviceArgs({ platform: options.platform, deviceModel: options.device, ...(localDevice() ? { provider: "local-simulator" as const, controllerDeviceId: localDevice()! } : {}) });
|
||||
// agent-device reads the hinge back after folding and fails to (locally and on EAS); its display is checked instead.
|
||||
const easAgentDevice = !!sessionId && controller === "agent-device";
|
||||
const fold = () => runner({ command: controllerCommand, args: ["fold", options.devicePose!, "--session", CONTROLLER_SESSION, ...target, "--platform", options.platform, "--json"],
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000, ...(localSimulator ? { allowFailure: true } : {}) });
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000, ...(localSimulator || easAgentDevice ? { allowFailure: true } : {}) });
|
||||
const pause = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
|
||||
if (localSimulator && controller === "argent") {
|
||||
// Argent folds without a session and checks the fold against its own reader; this machine also checks the display.
|
||||
fold();
|
||||
@@ -680,6 +794,59 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
...(options.sleep ? { sleep: options.sleep } : {}) })) throw new CiError({ code: "CONTROLLER_FOLD_UNVERIFIED", stage: "session",
|
||||
message: `${options.device} did not show the ${options.devicePose} display after folding: ${(folded.stderr || folded.stdout).trim().split("\n").at(-1) ?? ""}`.trim(),
|
||||
nextAction: "Rerun; if it persists, check that this Xcode's simulator supports folding the device." });
|
||||
} else if (easAgentDevice && sessionId) {
|
||||
// On EAS, agent-device also folds only inside a session, so the app opens first. The first fold of a fresh session
|
||||
// can leave the panel it lights black, as it does for Argent: the controller then reads the old panel and a
|
||||
// relaunch draws nothing. The display is the check, through the controller's own screenshot: in the pose's shape
|
||||
// and drawn. If it is not, SpringBoard is restarted, the app reopened and the device folded again, once.
|
||||
const open = (relaunch: boolean) => runner({ command: controllerCommand, args: ["open", options.bundleId, ...(relaunch ? ["--relaunch"] : []), "--session", CONTROLLER_SESSION,
|
||||
...target, "--platform", options.platform, "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 15 * 60_000 });
|
||||
const shown = async () => {
|
||||
if (options.devicePose !== "open" && options.devicePose !== "closed") return true;
|
||||
const file = join(simulatorProject, "pose.png");
|
||||
// The display relights and resizes over a moment after the hinge moves.
|
||||
for (let attempt = 0; attempt < 10; attempt += 1) {
|
||||
if (attempt) pause(1_000);
|
||||
runner({ command: controllerCommand, args: ["screenshot", file, "--session", CONTROLLER_SESSION, ...target, "--platform", options.platform, "--json"],
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000, allowFailure: true });
|
||||
const png = await readFile(file).catch(() => Buffer.alloc(0));
|
||||
await rm(file, { force: true });
|
||||
const size = pngSize(png);
|
||||
if (size && (options.devicePose === "open" ? size.width > size.height : size.height > size.width) && !solidColour(png)) return true;
|
||||
}
|
||||
return false;
|
||||
};
|
||||
open(false);
|
||||
fold();
|
||||
if (!await shown()) {
|
||||
if (!controlActions.has("springboard.restart")) throw new CiError({ code: "CONTROLLER_FOLD_UNVERIFIED", stage: "session",
|
||||
message: `${options.device} did not show the ${options.devicePose} display after folding.`, nextAction: "Rerun the capture on a new session." });
|
||||
say(`${options.device} did not draw the ${options.devicePose} display after the fold; restarting SpringBoard and folding ${options.devicePose} again`);
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart");
|
||||
pause(8_000);
|
||||
open(true);
|
||||
fold();
|
||||
if (!await shown()) throw new CiError({ code: "CONTROLLER_READER_STUCK", stage: "session",
|
||||
message: `${options.device} did not draw the ${options.devicePose} display after folding, nor after SpringBoard was restarted and it was folded again.`,
|
||||
nextAction: "Rerun the capture; if it keeps happening, report it to Explore with the session's link." });
|
||||
}
|
||||
} else if (controller === "argent" && sessionId && controlActions.has("springboard.restart")) {
|
||||
// The bridge has already reset Argent's device helpers once when its reader stayed on the dark panel. On EAS the
|
||||
// tool-server cannot be restarted, so the next step is SpringBoard, then the same fold and check again.
|
||||
try { fold(); }
|
||||
catch (error) {
|
||||
if (toCiError(error).code !== "CONTROLLER_FOLD_UNVERIFIED") throw error;
|
||||
say(`Argent kept reading the other panel after the fold; restarting SpringBoard and folding ${options.devicePose} again`);
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart");
|
||||
pause(8_000);
|
||||
try { fold(); }
|
||||
catch (retry) {
|
||||
if (toCiError(retry).code !== "CONTROLLER_FOLD_UNVERIFIED") throw retry;
|
||||
throw new CiError({ code: "CONTROLLER_READER_STUCK", stage: "session",
|
||||
message: `Argent's accessibility reader kept reading the panel the fold turned off, after its device helpers were reset and SpringBoard was restarted.`,
|
||||
nextAction: "Rerun the capture; if it keeps happening, report it to Explore: this session's Argent tool-server needs a restart that EAS cannot do yet.", cause: retry });
|
||||
}
|
||||
}
|
||||
} else fold();
|
||||
}
|
||||
runtimeStage = "runtime";
|
||||
@@ -690,9 +857,28 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
// (APP_NOT_READY). On this machine the capture runs that reader, so it recovers in two steps, each followed by one more
|
||||
// open: a fresh tool-server, whose reader starts on the lit panel; then, as XcodeBuildMCP#537 found for this panel,
|
||||
// SpringBoard restarted as well. The bridge's cached view of the device goes with the old server.
|
||||
// On EAS the tool-server is the session's and must never be stopped, so the recovery there resets Argent's device
|
||||
// helpers (reset-reader), then restarts SpringBoard as well, and then gives up with a reason rather than retrying.
|
||||
const easArgentRecovery = !local && controller === "argent" && !!sessionId && options.platform === "ios";
|
||||
for (let recovery = 0; ; recovery += 1) try { runtime = collect(); break; }
|
||||
catch (error) {
|
||||
if (!localArgent || recovery === 2 || toCiError(error).code !== "APP_NOT_READY") throw error;
|
||||
if (toCiError(error).code !== "APP_NOT_READY") throw error;
|
||||
if (easArgentRecovery && sessionId) {
|
||||
if (recovery === 2 || recovery === 1 && !controlActions.has("springboard.restart")) throw new CiError({ code: "CONTROLLER_READER_STUCK", stage: "session",
|
||||
message: "Argent's accessibility reader kept reading the panel the fold turned off, after its device helpers were reset"
|
||||
+ `${recovery === 2 ? " and SpringBoard was restarted" : ""}.`,
|
||||
nextAction: "Rerun the capture; if it keeps happening, report it to Explore: this session's Argent tool-server needs a restart that EAS cannot do yet.", cause: error });
|
||||
if (recovery === 1) {
|
||||
say("Argent still did not read the app; restarting SpringBoard, then resetting Argent's device helpers and opening the app again");
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart");
|
||||
// SpringBoard takes a moment to come back, and sends the app to the background; the next open brings it back.
|
||||
(options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); }))(8_000);
|
||||
} else say("Argent did not read the app after starting it; resetting Argent's device helpers and opening the app again");
|
||||
runner({ command: controllerCommand, args: ["reset-reader", "--session", CONTROLLER_SESSION, "--platform", options.platform, "--json"],
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000 });
|
||||
continue;
|
||||
}
|
||||
if (!localArgent || recovery === 2) throw error;
|
||||
say(recovery === 0 ? "Argent did not read the app after starting it; restarting Argent's tool-server and opening the app again"
|
||||
: "Argent still did not read the app; restarting SpringBoard and Argent's tool-server and opening the app again");
|
||||
stopLocalArgentServer(localArgent);
|
||||
@@ -729,10 +915,11 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
const passes: CaptureBundle["outcomes"][] = [];
|
||||
const recordingTools = launchSetting === "off" ? undefined : options.recordingTools === undefined ? ffmpegRecordingTools() : options.recordingTools ?? undefined;
|
||||
for (const [index, colorScheme] of colorSchemes.entries()) {
|
||||
// Argent cannot switch the appearance yet (software-mansion/argent#1509): on EAS its single pass runs as the device
|
||||
// starts, and on this machine the host switches it.
|
||||
// Argent cannot switch the appearance yet (software-mansion/argent#1509): the host does, simctl or adb on this
|
||||
// machine and serve-sim on an EAS iOS session; elsewhere its single pass runs as the device starts.
|
||||
if (controller !== "argent") runner({ command: controllerCommand, args: [...appearanceArgs(colorScheme), "--session", CONTROLLER_SESSION, ...deviceArgs(runtime), "--platform", options.platform],
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 60_000 });
|
||||
else if (sessionId && controlActions.has("appearance.set")) simulatorControl(sessionEas, sessionId, "appearance.set", [colorScheme]);
|
||||
else if (localSimulator) setLocalSimulatorAppearance({ runner, udid: localSimulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
|
||||
else if (localEmulator) setLocalEmulatorAppearance({ runner, serial: localEmulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
|
||||
// A scheme change recreates the Android activity in place, and the sheets it re-presents lose their inset; a
|
||||
|
||||
@@ -0,0 +1,42 @@
|
||||
import { isRecord } from "./common.js";
|
||||
|
||||
/** Runs the pinned EAS CLI with these arguments; throws when it exits non-zero unless `allowFailure` is set. */
|
||||
export type EasCommand = (args: string[], options?: { timeoutMs?: number; allowFailure?: boolean }) => { stdout: string; stderr?: string };
|
||||
|
||||
/**
|
||||
* The host actions an EAS Simulator iOS session offers through `eas simulator:control` (serve-sim's actions, 0.10.0 and
|
||||
* later for the ones Explore uses): an empty set when the session or the EAS CLI offers none, so a caller falls back to
|
||||
* what it did before them. The session is always named by id, never taken from a `.env.eas-simulator` beside it.
|
||||
*
|
||||
* These are a fallback: what the session's controller can do itself (agent-device or Argent: fold, appearance, a
|
||||
* reader reset) goes through the controller. Explore uses an action here only for what neither controller offers —
|
||||
* approving a link scheme, restarting SpringBoard, and Argent's appearance (software-mansion/argent#1509).
|
||||
*/
|
||||
export function simulatorControlActions(eas: EasCommand, sessionId: string): Set<string> {
|
||||
try {
|
||||
const listed = eas(["simulator:control", "--list", "--id", sessionId, "--json", "--non-interactive"], { timeoutMs: 2 * 60_000, allowFailure: true });
|
||||
const actions = JSON.parse(listed.stdout) as unknown;
|
||||
return new Set(isRecord(actions) ? Object.keys(actions) : []);
|
||||
} catch { return new Set(); }
|
||||
}
|
||||
|
||||
/** Runs one `eas simulator:control` action on the session; eas-cli fills in the device. Throws with EAS's reason. */
|
||||
export function simulatorControl(eas: EasCommand, sessionId: string, action: string, values: readonly string[] = []): void {
|
||||
// Values follow `--` so one that starts with a dash is never read as a flag.
|
||||
eas(["simulator:control", action, "--id", sessionId, "--json", "--non-interactive", "--", ...values], { timeoutMs: 2 * 60_000 });
|
||||
}
|
||||
|
||||
/**
|
||||
* Lets the app open its own links without iOS asking "Open in “App”?" first, like local captures do with simctl. A
|
||||
* session without the action keeps the controllers' prompt handling; http and https never prompt and are skipped.
|
||||
*/
|
||||
export function approveSessionUrlSchemes(eas: EasCommand, sessionId: string, actions: ReadonlySet<string>, bundleId: string, schemes: readonly string[]): string[] {
|
||||
if (!actions.has("app.approveUrlScheme")) return [];
|
||||
const approved: string[] = [];
|
||||
for (const scheme of new Set(schemes.map(value => value.toLowerCase()))) {
|
||||
if (scheme === "http" || scheme === "https" || !/^[a-z][a-z0-9+.-]*$/.test(scheme)) continue;
|
||||
simulatorControl(eas, sessionId, "app.approveUrlScheme", [bundleId, scheme]);
|
||||
approved.push(scheme);
|
||||
}
|
||||
return approved;
|
||||
}
|
||||
@@ -237,17 +237,7 @@ export function assertSimulatorSessionIdentity(
|
||||
) {
|
||||
throw new Error("eas simulator:get did not prove the exact expected simulator session");
|
||||
}
|
||||
// eas-cli 22.4.0 omits the `app` record; its `deviceRunSessionUrl` still binds the session
|
||||
// to one exact owner and slug, so accept either proof but never neither.
|
||||
const expectedSessionUrl = `https://expo.dev/accounts/${expectedProject.owner}`
|
||||
+ `/projects/${expectedProject.slug}/simulator-sessions/${expectedSessionId}`;
|
||||
const projectProven = isRecord(value.app)
|
||||
? value.app.id === expectedProject.projectId
|
||||
&& value.app.slug === expectedProject.slug
|
||||
&& isRecord(value.app.ownerAccount)
|
||||
&& value.app.ownerAccount.name === expectedProject.owner
|
||||
: value.deviceRunSessionUrl === expectedSessionUrl;
|
||||
if (!projectProven) {
|
||||
if (!sessionProjectProven(value, expectedSessionId, expectedProject)) {
|
||||
throw new Error("eas simulator:get did not prove the exact expected simulator session");
|
||||
}
|
||||
if (expectedConnection && !remoteConfigMatches(value.remoteConfig, expectedConnection)) {
|
||||
@@ -255,6 +245,46 @@ export function assertSimulatorSessionIdentity(
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* eas-cli 22.4.0 omits the `app` record; its `deviceRunSessionUrl` still binds the session to one exact owner and
|
||||
* slug, so either proof is accepted but never neither.
|
||||
*/
|
||||
function sessionProjectProven(value: Record<string, unknown>, sessionId: string, project: RepackProfile["projectIdentity"]): boolean {
|
||||
const expectedSessionUrl = `https://expo.dev/accounts/${project.owner}/projects/${project.slug}/simulator-sessions/${sessionId}`;
|
||||
return isRecord(value.app)
|
||||
? value.app.id === project.projectId && value.app.slug === project.slug && isRecord(value.app.ownerAccount) && value.app.ownerAccount.name === project.owner
|
||||
: value.deviceRunSessionUrl === expectedSessionUrl;
|
||||
}
|
||||
|
||||
/**
|
||||
* The status (ERRORED or STOPPED) of a session `eas simulator:get` shows EAS ended before Explore could use it, when it
|
||||
* is provably this capture's own: the exact id, name, type, platform and project. Only such a session is replaced by a
|
||||
* new one; anything less certain (undefined here) stays a handoff failure.
|
||||
*/
|
||||
export function endedOwnSimulatorSession(stdout: string, expected: { sessionId: string; sessionName: string; project: RepackProfile["projectIdentity"];
|
||||
type: "agent-device" | "argent"; platform: Platform }): "ERRORED" | "STOPPED" | undefined {
|
||||
let value: unknown;
|
||||
try { value = JSON.parse(stdout); } catch { return undefined; }
|
||||
return isRecord(value) && value.id === expected.sessionId && value.name === expected.sessionName && value.type === expected.type
|
||||
&& value.platform === expected.platform.toUpperCase() && (value.status === "ERRORED" || value.status === "STOPPED")
|
||||
&& sessionProjectProven(value, expected.sessionId, expected.project) ? value.status : undefined;
|
||||
}
|
||||
|
||||
/**
|
||||
* This project's sessions with exactly this name that EAS may still be starting or running, from
|
||||
* `eas simulator:list --json`: their ids when every one is provably this project's, or undefined when the listing
|
||||
* cannot be read or a session by that name cannot be proven Explore's, so a caller never assumes none exist.
|
||||
*/
|
||||
export function liveSimulatorSessionsNamed(stdout: string, sessionName: string, project: RepackProfile["projectIdentity"]): string[] | undefined {
|
||||
let value: unknown;
|
||||
try { value = JSON.parse(stdout); } catch { return undefined; }
|
||||
if (!isRecord(value) || !Array.isArray(value.sessions)) return undefined;
|
||||
const live = new Set(["NEW", "QUEUED", "STARTING", "IN_PROGRESS"]);
|
||||
const named = value.sessions.filter((session): session is Record<string, unknown> => isRecord(session) && session.name === sessionName && live.has(String(session.status)));
|
||||
if (named.some(session => typeof session.id !== "string" || !/^[A-Za-z0-9._-]{1,256}$/.test(session.id) || !sessionProjectProven(session, session.id, project))) return undefined;
|
||||
return named.map(session => session.id as string);
|
||||
}
|
||||
|
||||
/** The session's published controller endpoint is the one Explore holds: agent-device's daemon, or Argent's tool-server. */
|
||||
function remoteConfigMatches(remoteConfig: unknown, connection: SimulatorConnection): boolean {
|
||||
if (!isRecord(remoteConfig)) return false;
|
||||
|
||||
@@ -474,7 +474,8 @@ export async function runDoctor(options: DoctorOptions): Promise<DoctorReport> {
|
||||
checks.push(config.mode === "agent"
|
||||
? { step: 3, id: "mode", status: "pass", message: `Agent mode with ${config.agent!.provider} ${config.agent!.model}. Capture navigation uses the model and is billed to your ${config.agent!.provider} account.` }
|
||||
: { step: 3, id: "mode", status: "pass", message: "Deterministic mode: capture replays config.yaml without a model, so it needs no API key and has no AI charges." });
|
||||
if (runTargets(config, { controller: options.controller }).some(target => target.capture.controller === "argent")) checks.push(argentCheck(environment));
|
||||
const argentTargets = runTargets(config, { controller: options.controller }).filter(target => target.capture.controller === "argent");
|
||||
if (argentTargets.length) checks.push(argentCheck(environment, argentTargets.some(target => target.app.platform === "android" && target.capture.simulator !== "local")));
|
||||
if (config.capture.launch !== "off") {
|
||||
const ffmpeg = run("ffmpeg", ["-version"], project);
|
||||
checks.push(ffmpeg.status === 0
|
||||
@@ -630,13 +631,20 @@ export function summarizeCaptureCheck(plan: SourceCapturePlan, bundle: CaptureBu
|
||||
* Capture the committed HEAD the way the baseline workflow does, with the local EAS login. This is
|
||||
* the only doctor step that starts an EAS build and a simulator session.
|
||||
*/
|
||||
/** An Argent capture records one appearance, and fetches the pinned Argent release on first use. agent-device, the default, is not reported. */
|
||||
function argentCheck(environment: NodeJS.ProcessEnv): DoctorCheck {
|
||||
/**
|
||||
* Argent fetches its pinned release on first use, and cannot switch the appearance itself (software-mansion/argent#1509):
|
||||
* the host does, through `simulator:control` on an iOS EAS session or simctl and adb on this Mac. Only an Android EAS
|
||||
* session has no host to ask, so its captures record one appearance. agent-device, the default, is not reported.
|
||||
*/
|
||||
function argentCheck(environment: NodeJS.ProcessEnv, androidOnEas: boolean): DoctorCheck {
|
||||
const cached = controllerCached("argent", environment);
|
||||
return { step: 3, id: "controller", status: "warn", code: "CONTROLLER_APPEARANCE_FIXED",
|
||||
message: `Device controller: Argent ${ARGENT_VERSION} (${cached ? "cached on this machine" : "fetched from npm on the first capture, about 27 MB"}). `
|
||||
+ "Argent cannot switch the simulator's appearance yet (software-mansion/argent#1509), so each capture records one appearance: the app's forced one, else light.",
|
||||
nextAction: "Nothing to do unless you need dark-mode screenshots; use agent-device (the default) for those." };
|
||||
const release = `Device controller: Argent ${ARGENT_VERSION} (${cached ? "cached on this machine" : "fetched from npm on the first capture, about 27 MB"}). `;
|
||||
return androidOnEas
|
||||
? { step: 3, id: "controller", status: "warn", code: "CONTROLLER_APPEARANCE_FIXED",
|
||||
message: `${release}Argent cannot switch the appearance on an Android EAS Simulator session yet (software-mansion/argent#1509), so those captures record one appearance: the app's forced one, else light.`,
|
||||
nextAction: "Nothing to do unless you need dark-mode screenshots on Android; use agent-device (the default) for those." }
|
||||
: { step: 3, id: "controller", status: "pass",
|
||||
message: `${release}The simulator's host switches the appearance, so every appearance the config asks for is captured.` };
|
||||
}
|
||||
|
||||
export async function runCaptureCheck(options: { project: string; output: string; platform?: ExplorePlatform; controller?: string | undefined; simulator?: string | undefined; repack?: string | undefined; target?: string | undefined; environment?: NodeJS.ProcessEnv; runner?: CommandRunner; progress?: Progress }): Promise<CaptureCheckResult> {
|
||||
|
||||
@@ -150,7 +150,8 @@ async function prepareCiRun(options: Pick<PublicCiOptions, "baseProject" | "head
|
||||
links: viewerLinks({ repository: presentation.repository, headSha: presentation.head.sha, runId: environment.GITHUB_RUN_ID!,
|
||||
runAttempt: environment.GITHUB_RUN_ATTEMPT!, configPath: repositoryConfigPath }),
|
||||
startedAt: now(), updatedAt: now(), build: { platform: config.app.platform, easProfile: config.app.easProfile }, artifactOnly: true,
|
||||
...(config.target ? { target: config.target } : {}), ...(options.targets && options.targets.length > 1 ? { targets: options.targets } : {}) };
|
||||
...(config.target ? { target: config.target } : {}), ...(options.targets && options.targets.length > 1 ? { targets: options.targets } : {}),
|
||||
...(config.report?.comment?.map ? { map: true } : {}) };
|
||||
return { projects, output, state };
|
||||
}
|
||||
|
||||
@@ -267,7 +268,8 @@ export async function runCiReview(options: {
|
||||
const { projects, output, config, environment, state, assertCurrentHead, postComment } = options;
|
||||
const progress = options.progress ?? silentProgress;
|
||||
// The controllers are fetched before any EAS work, so a blocked download fails before a session is paid for. agent-device
|
||||
// also compares the screenshots. An injected runner (tests) runs no real controller.
|
||||
// also compares the screenshots. An injected runner (tests) stands in for the controllers' calls, but not for that
|
||||
// comparison: it still runs the real agent-device, which fetches itself on first use.
|
||||
if (!options.runner) await prefetchControllers(config, environment, progress);
|
||||
const pr = options.presentation;
|
||||
const now = options.now ?? Date.now;
|
||||
|
||||
@@ -5,18 +5,9 @@ import { openViewerInBrowser, startViewerServer, waitForViewerShutdown } from ".
|
||||
import { writeExplorationReport } from "../binary/report.js";
|
||||
import { assertHostingExport, deployExplorationReport, zipReportDirectory } from "../report/preview-deploy.js";
|
||||
import { keepReports } from "./report-commands.js";
|
||||
import { warnIgnoredExpiry } from "../config/explore-config.js";
|
||||
import { argumentError, flag, flags, has, nonNegativeInteger, oneOf, output, positional, positiveInteger } from "./args.js";
|
||||
|
||||
const MAX_EXPIRY_DAYS = 90;
|
||||
|
||||
/** `7d`, `30d`, `never`: how long the hosted link serves the report. */
|
||||
export function expiresInDays(value: string): number | null {
|
||||
if (value === "never") return null;
|
||||
const match = /^(\d{1,3})d$/.exec(value);
|
||||
const days = match ? Number(match[1]) : NaN;
|
||||
if (!Number.isSafeInteger(days) || days < 1 || days > MAX_EXPIRY_DAYS) argumentError(`--expires-in must be 1d to ${MAX_EXPIRY_DAYS}d, or never (got ${value})`, "expires-in");
|
||||
return days;
|
||||
}
|
||||
|
||||
/** `--alias NAME` plus a fixed token from EXPLORE_PREVIEW_TOKEN: the hosted link stays the same from one run to the next (validated by the deploy). */
|
||||
function stableLinkOptions(): { alias?: string; token?: string } {
|
||||
@@ -35,7 +26,7 @@ export async function exploreBinary(): Promise<void> {
|
||||
"Run expo-explore explore:binary <path to .apk, .app, .tar.gz, or simulator .ipa>.");
|
||||
if (has("upload") && has("no-upload")) argumentError("Pass either --upload or --no-upload", "no-upload");
|
||||
const outputDirectory = resolve(process.cwd(), flag("output") ?? defaultOutputDirectory(archive));
|
||||
const expiresAfterDays = expiresInDays(flag("expires-in") ?? "7d");
|
||||
if (has("expires-in")) warnIgnoredExpiry("--expires-in");
|
||||
const platform = flag("platform") === undefined ? undefined : oneOf("platform", ["ios", "android"] as const);
|
||||
const provider = flag("provider") === undefined ? undefined : oneOf("provider", ["anthropic", "openai"] as const);
|
||||
const controller = flag("controller") === undefined ? undefined : oneOf("controller", ["agent-device", "argent"] as const);
|
||||
@@ -66,7 +57,7 @@ export async function exploreBinary(): Promise<void> {
|
||||
if (upload) {
|
||||
say("hosting the report on EAS Hosting");
|
||||
const owner = result.session.owner || flag("owner");
|
||||
hosted = await deployExplorationReport({ reportPath: report.reportPath, platform: result.archive.platform, project: flag("project") ?? DEFAULT_BINARY_PROJECT, ...(owner ? { owner } : {}), expiresAfterDays, ...stableLinkOptions() });
|
||||
hosted = await deployExplorationReport({ reportPath: report.reportPath, platform: result.archive.platform, project: flag("project") ?? DEFAULT_BINARY_PROJECT, ...(owner ? { owner } : {}), ...stableLinkOptions() });
|
||||
say(`report: ${hosted.previewUrl}${hosted.expiresAt ? ` (expires ${hosted.expiresAt})` : ""}`);
|
||||
}
|
||||
const summary = { ok: true,
|
||||
@@ -101,7 +92,7 @@ export async function exploreSession(): Promise<void> {
|
||||
const session = positional() ?? flag("session");
|
||||
const bundleId = flag("bundle-id");
|
||||
const outputDirectory = resolve(process.cwd(), flag("output") ?? defaultOutputDirectory(bundleId ?? "session"));
|
||||
const expiresAfterDays = expiresInDays(flag("expires-in") ?? "7d");
|
||||
if (has("expires-in")) warnIgnoredExpiry("--expires-in");
|
||||
const platform = flag("platform") === undefined ? undefined : oneOf("platform", ["ios", "android"] as const);
|
||||
const provider = flag("provider") === undefined ? undefined : oneOf("provider", ["anthropic", "openai"] as const);
|
||||
const controller = flag("controller") === undefined ? undefined : oneOf("controller", ["agent-device", "argent"] as const);
|
||||
@@ -129,7 +120,7 @@ export async function exploreSession(): Promise<void> {
|
||||
let hosted: Awaited<ReturnType<typeof deployExplorationReport>> | undefined;
|
||||
if (has("upload")) {
|
||||
say("hosting the report on EAS Hosting");
|
||||
hosted = await deployExplorationReport({ reportPath: report.reportPath, platform: result.app.platform, project: flag("project") ?? DEFAULT_BINARY_PROJECT, ...(flag("owner") ? { owner: flag("owner")! } : {}), expiresAfterDays, ...stableLinkOptions() });
|
||||
hosted = await deployExplorationReport({ reportPath: report.reportPath, platform: result.app.platform, project: flag("project") ?? DEFAULT_BINARY_PROJECT, ...(flag("owner") ? { owner: flag("owner")! } : {}), ...stableLinkOptions() });
|
||||
say(`report: ${hosted.previewUrl}${hosted.expiresAt ? ` (expires ${hosted.expiresAt})` : ""}`);
|
||||
}
|
||||
const summary = { ok: true, app: result.app, device: { model: result.runtime.deviceModel, osVersion: result.runtime.osVersion },
|
||||
|
||||
@@ -15,7 +15,7 @@ import { installCiFiles } from "../ci/workflow-install.js";
|
||||
import { readRouteEntry } from "../ci/route-entry.js";
|
||||
import { buildVerifiedPlan } from "../ci/verified-plan.js";
|
||||
import { formatCaptureCheck, formatDoctorReport, referencedSecretNames, runCaptureCheck, runDoctor } from "../ci/doctor.js";
|
||||
import { readExploreConfig, readExploreInstructions, resolveTargetConfig, configTargets, isTargetId, withRunOverrides, previewDays, configPlatforms as listPlatforms, EXPLORE_PLATFORMS, DEFAULT_EXPLORE_CONFIG_PATH, PREVIEW_DEFAULT_DAYS, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { readExploreConfig, readExploreInstructions, resolveTargetConfig, configTargets, isTargetId, withRunOverrides, warnIgnoredExpiry, configPlatforms as listPlatforms, EXPLORE_PLATFORMS, DEFAULT_EXPLORE_CONFIG_PATH, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { argumentError, output, required, has, flag, flags, nonNegativeInteger, oneOf, positiveInteger } from "./args.js";
|
||||
import { help } from "./help.js";
|
||||
import { CiError } from "../shared/ci-errors.js";
|
||||
@@ -222,6 +222,8 @@ export async function captureReview(): Promise<void> {
|
||||
const configPath = flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH;
|
||||
const selection = targetSelection();
|
||||
const rawConfig = await readExploreConfig(headProject, configPath);
|
||||
// A release comparison's workflow may still pass --expires-in; ci:deploy says once that report.preview.expiresAfter is ignored.
|
||||
if (has("expires-in")) warnIgnoredExpiry("--expires-in");
|
||||
const config = withRunOverrides(resolveTargetConfig(rawConfig, selection), { scope: flag("scope"), expiresIn: flag("expires-in"), controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack") });
|
||||
if (has("pull-request") === has("compare")) argumentError("Pass --pull-request FILE for a pull request, or --compare FILE for any two commits.", has("compare") ? "compare" : "pull-request");
|
||||
// A matrix job names its target; its artifacts, report and comment section carry the target's id.
|
||||
@@ -245,6 +247,7 @@ export async function captureBaseline(): Promise<void> {
|
||||
/** `capture` (or `capture:review`) `[--base REF] [--head REF | --committed]`: a local review, opened in the Viewer or hosted with --upload. */
|
||||
async function localReview(): Promise<void> {
|
||||
const platform = platformFlag(), target = targetFlag();
|
||||
if (has("expires-in")) warnIgnoredExpiry("--expires-in");
|
||||
const parallel = has("parallel") ? positiveInteger("parallel") : undefined;
|
||||
const result = await runLocalReview({ project: flag("project") ?? process.cwd(), base: flag("base"), head: flag("head"), ...(target ? { target } : {}),
|
||||
...(parallel ? { parallel } : {}),
|
||||
@@ -276,9 +279,8 @@ async function localReview(): Promise<void> {
|
||||
...(result.head.uncommitted?.length ? { uncommittedFiles: result.head.uncommitted.length } : {}) });
|
||||
if (has("upload")) {
|
||||
const preview = result.config.report?.preview;
|
||||
const hosted = await deployLocalReports({ reports: zips, project: previewProjectSlug(result.repository, preview?.project), ...(preview?.owner ? { owner: preview.owner } : {}),
|
||||
// null is expiresAfter: never, which must not fall back to the default.
|
||||
expiresAfterDays: has("expires-in") ? previewDays(required("expires-in"), "--expires-in") : preview ? preview.expiresAfterDays : PREVIEW_DEFAULT_DAYS });
|
||||
if (preview?.expiresAfterIgnored) warnIgnoredExpiry("report.preview.expiresAfter");
|
||||
const hosted = await deployLocalReports({ reports: zips, project: previewProjectSlug(result.repository, preview?.project), ...(preview?.owner ? { owner: preview.owner } : {}) });
|
||||
// Hosted, the temporary copies are not needed (a failed upload keeps them for report:upload); --output keeps its own.
|
||||
const copied = has("output");
|
||||
if (!copied) await rm(result.work, { recursive: true, force: true });
|
||||
|
||||
@@ -18,7 +18,7 @@ const GET_STARTED = `Get started (run these in the Expo app's directory):
|
||||
doctor --capture [--project DIRECTORY] [--output DIRECTORY] [--target ID | --platform ios|android] [--controller agent-device|argent] [--simulator eas|local] [--repack eas|local] [--yes]
|
||||
(captures the committed HEAD like the baseline workflow, with your eas login, and reports each route)
|
||||
capture [--base REF] [--head REF | --committed] [--target ID | --platform ios|android] [--parallel N] [--scope all|changes]
|
||||
[--controller agent-device|argent] [--simulator eas|local] [--repack eas|local] [--upload [--expires-in 7d|30d|never]] [--no-open] [--no-cache] [--output DIRECTORY] [--project DIRECTORY]
|
||||
[--controller agent-device|argent] [--simulator eas|local] [--repack eas|local] [--upload] [--no-open] [--no-cache] [--output DIRECTORY] [--project DIRECTORY]
|
||||
(on this machine: checks out both commits in temporary worktrees, captures them with your eas login (in agent
|
||||
mode, also your local claude or codex login), and opens the report; the head is HEAD with your uncommitted changes, as eas build
|
||||
uploads them (--committed, or cli.requireCommit in eas.json, leaves them out); the base defaults to where HEAD
|
||||
@@ -39,7 +39,7 @@ const GET_STARTED = `Get started (run these in the Expo app's directory):
|
||||
(the runs kept on this machine: local reviews, explorations and uploaded reports, for 30 days or up to 2 GB;
|
||||
in a terminal, an arrow-key picker: Enter opens a run in the local Viewer, u hosts it, d deletes it;
|
||||
ID is a run's id from reports list, or latest; EXPLORE_INTRO=off skips the title animation)
|
||||
report:upload <report.zip | report directory>... [--owner ACCOUNT] [--project SLUG] [--expires-in 7d|30d|never] [--config FILE] [--json]
|
||||
report:upload <report.zip | report directory>... [--owner ACCOUNT] [--project SLUG] [--config FILE] [--json]
|
||||
(hosts reports already on this machine on EAS Hosting behind one link, with your eas login: one per platform
|
||||
of the same review, from capture:review --output or a downloaded explore-review artifact, or one explore:binary report)`;
|
||||
|
||||
@@ -55,7 +55,7 @@ const BINARY = `Prebuilt apps (no source needed; runs with your local claude or
|
||||
(a sign-in in --hints is written as {{secret:NAME}}: Explore types the value of the environment variable NAME,
|
||||
and the model and the report only see the reference)
|
||||
--max-duration-minutes N --max-screens N --max-actions N --provider anthropic|openai --model ID
|
||||
--owner ACCOUNT --project SLUG --expires-in 7d|30d|never --allow-destructive "Label,Other label"
|
||||
--owner ACCOUNT --project SLUG --allow-destructive "Label,Other label"
|
||||
--alias NAME (one EAS Hosting host per app that always serves the newest run; with EXPLORE_PREVIEW_TOKEN
|
||||
set to a fixed 32-character token, the hosted link is the same every run)
|
||||
(iOS needs a simulator build; a device .ipa and Android .aab are rejected before any device starts)
|
||||
|
||||
@@ -3,7 +3,7 @@ import { readFile, stat } from "node:fs/promises";
|
||||
import { basename, dirname, join, relative, resolve, sep } from "node:path";
|
||||
import { DEFAULT_BINARY_PROJECT } from "../binary/run.js";
|
||||
import { pruneCaptureCache, repositoryName } from "../ci/local-review.js";
|
||||
import { readExploreConfig, previewDays, DEFAULT_EXPLORE_CONFIG_PATH, PREVIEW_DEFAULT_DAYS, type ExploreConfig } from "../config/explore-config.js";
|
||||
import { readExploreConfig, warnIgnoredExpiry, DEFAULT_EXPLORE_CONFIG_PATH, type ExploreConfig } from "../config/explore-config.js";
|
||||
import { assertHostingExport, deployLocalReports, previewProjectSlug, readReportZip, zipReportDirectory, MAX_REPORT_BYTES, type ReportZipSummary } from "../report/preview-deploy.js";
|
||||
import { startLocalReportServer } from "../report/local-report-server.js";
|
||||
import { findSavedRun, listSavedRuns, pruneSavedRuns, readSavedReports, removeSavedRun, reportTarget, saveRun, savedRunsDirectory, SAVED_RUN_LIMITS, type SavedReport, type SavedRun } from "../report/saved-runs.js";
|
||||
@@ -11,10 +11,9 @@ import { openViewerInBrowser } from "../map/viewer-server.js";
|
||||
import { formatBytes, friendlyTime, kindLabel, runPicker, runTitle } from "./reports-picker.js";
|
||||
import { pickIntro } from "./title-intros.js";
|
||||
import { CiError, toCiError } from "../shared/ci-errors.js";
|
||||
import { argumentError, flag, has, nonNegativeInteger, output, positionals, required } from "./args.js";
|
||||
import { argumentError, flag, has, nonNegativeInteger, output, positionals } from "./args.js";
|
||||
|
||||
/** explore:binary's default: an exploration link is for a quick look. */
|
||||
const EXPLORATION_DEFAULT_DAYS = 7;
|
||||
|
||||
/** A report directory (review.json or exploration.json and assets/), its parent holding report.zip, or a report ZIP. */
|
||||
async function readReport(path: string): Promise<{ path: string; zip: Uint8Array; summary: ReportZipSummary }> {
|
||||
@@ -94,12 +93,12 @@ async function hostReports(reports: ReadReport[]): Promise<void> {
|
||||
const found = review ? await repositoryPreview(review.repository) : undefined;
|
||||
const preview = found?.preview;
|
||||
if (review) process.stderr.write(found ? `report.preview from ${found.source}\n`
|
||||
: `no config of ${review.repository} here: hosting with the defaults (pass --config, or --owner, --project and --expires-in)\n`);
|
||||
: `no config of ${review.repository} here: hosting with the defaults (pass --config, or --owner and --project)\n`);
|
||||
const project = flag("project") ?? (review ? previewProjectSlug(review.repository, preview?.project) : DEFAULT_BINARY_PROJECT);
|
||||
const owner = flag("owner") ?? preview?.owner;
|
||||
const expiresAfterDays = has("expires-in") ? previewDays(required("expires-in"), "--expires-in")
|
||||
: preview ? preview.expiresAfterDays : review ? PREVIEW_DEFAULT_DAYS : EXPLORATION_DEFAULT_DAYS;
|
||||
const hosted = await deployLocalReports({ project, ...(owner ? { owner } : {}), expiresAfterDays,
|
||||
if (has("expires-in")) warnIgnoredExpiry("--expires-in");
|
||||
else if (preview?.expiresAfterIgnored) warnIgnoredExpiry("report.preview.expiresAfter");
|
||||
const hosted = await deployLocalReports({ project, ...(owner ? { owner } : {}),
|
||||
reports: reports.map(report => ({ platform: report.summary.platform, target: report.summary.target, zip: report.zip,
|
||||
...(report.summary.changes === undefined ? {} : { changes: report.summary.changes }), ...(report.summary.device ? { device: report.summary.device } : {}) })),
|
||||
ownerHint: "Pass --owner with the Expo account that should host the report.",
|
||||
|
||||
@@ -104,7 +104,9 @@ export type ExploreConfig = {
|
||||
setup?: ExploreSetupAction[];
|
||||
agent?: { provider: "openai" | "anthropic"; model: string; instructions?: string };
|
||||
/** Hosted previews: one token-gated EAS Hosting deployment per review, see docs/private-review.md. */
|
||||
report?: { preview?: { hosting: "eas"; /** null: the link never expires; the deployment lives until someone deletes it. */ expiresAfterDays: number | null; owner?: string; project?: string } };
|
||||
report?: { preview?: { hosting: "eas"; /** `expiresAfter` was set; it no longer applies (see IGNORED_EXPIRY). */ expiresAfterIgnored?: true; owner?: string; project?: string };
|
||||
/** `map`: the PR comment draws a Mermaid map of the changed screens and the screens that lead to them. Off by default. */
|
||||
comment?: { map: boolean } };
|
||||
/**
|
||||
* `trustedAuthors`: GitHub logins (e.g. `devin-ai-integration[bot]`) whose same-repository pull
|
||||
* requests the review workflow captures although they lack write access. The workflow reads this
|
||||
@@ -113,8 +115,16 @@ export type ExploreConfig = {
|
||||
ci?: { trustedAuthors?: string[] };
|
||||
};
|
||||
|
||||
export const PREVIEW_MAX_DAYS = 365;
|
||||
export const PREVIEW_DEFAULT_DAYS = 30;
|
||||
/**
|
||||
* What `report.preview.expiresAfter` and `--expires-in` say now that Explore sets no expiry: a hosted preview lasts as long
|
||||
* as its EAS Hosting deployment. Both are still accepted, so configs and copied workflows keep working.
|
||||
*/
|
||||
export const IGNORED_EXPIRY = "no longer applies: a hosted preview lasts as long as its EAS Hosting deployment, which EAS deletes after 30 days on Free and 90 on paid plans unless an alias points at it. Delete the deployment (eas deploy:delete) to remove it sooner.";
|
||||
|
||||
/** Says once, on stderr (a warning annotation in GitHub Actions), that an expiry setting is ignored. */
|
||||
export function warnIgnoredExpiry(setting: string, environment: NodeJS.ProcessEnv = process.env): void {
|
||||
process.stderr.write(`${environment.GITHUB_ACTIONS === "true" ? "::warning::" : ""}${setting} ${IGNORED_EXPIRY}\n`);
|
||||
}
|
||||
|
||||
const MAX_CONFIG_BYTES = 64 * 1024;
|
||||
const UNSAFE_CHARACTERS = /[\u0000-\u001f\u007f]/;
|
||||
@@ -505,8 +515,8 @@ export function resolvePlatformConfig(config: ExploreConfig, platform: ExplorePl
|
||||
|
||||
/**
|
||||
* One run's choices over the reviewed config, from the workflow that started it: a release comparison can capture
|
||||
* every screen (`scope: all`) and keep its hosted link (`expiresIn: never`). `expiresIn` changes nothing when the
|
||||
* config hosts no report.
|
||||
* every screen (`scope: all`). `expiresIn` (`--expires-in`) is accepted from workflows written before Explore stopped
|
||||
* setting an expiry, and changes nothing.
|
||||
*/
|
||||
export function withRunOverrides(config: ExploreConfig, overrides: { scope?: string | undefined; expiresIn?: string | undefined; controller?: string | undefined; simulator?: string | undefined; repack?: string | undefined }): ExploreConfig {
|
||||
let result = config;
|
||||
@@ -528,11 +538,6 @@ export function withRunOverrides(config: ExploreConfig, overrides: { scope?: str
|
||||
if (overrides.scope !== "changes" && overrides.scope !== "all") fail("--scope must be changes or all", "--scope");
|
||||
result = { ...result, exploration: { ...result.exploration, scope: overrides.scope } };
|
||||
}
|
||||
if (overrides.expiresIn !== undefined) {
|
||||
// Validated even without hosting, so a typo in a release workflow surfaces before hosting is turned on.
|
||||
const expiresAfterDays = previewDays(overrides.expiresIn, "--expires-in");
|
||||
if (result.report?.preview) result = { ...result, report: { ...result.report, preview: { ...result.report.preview, expiresAfterDays } } };
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
@@ -544,18 +549,6 @@ export function captureRepack(config: ExploreConfig): "eas" | "local" {
|
||||
return config.capture.repack ?? (config.capture.simulator === "local" ? "local" : "eas");
|
||||
}
|
||||
|
||||
/** `expiresAfter` is a whole number of days (`30d`, `30 days`, or `30`), at most PREVIEW_MAX_DAYS, or `never` (null). */
|
||||
export function previewDays(value: unknown, field: string): number | null {
|
||||
if (value === undefined) return PREVIEW_DEFAULT_DAYS;
|
||||
if (typeof value === "string" && /^\s*never\s*$/i.test(value)) return null;
|
||||
const match = typeof value === "number" ? [null, String(value)] : typeof value === "string" ? /^\s*(\d{1,3})\s*(?:d|days?)?\s*$/i.exec(value) : null;
|
||||
const days = match ? Number(match[1]) : Number.NaN;
|
||||
if (!Number.isInteger(days) || days < 1 || days > PREVIEW_MAX_DAYS) {
|
||||
fail(`${field} must be between 1 and ${PREVIEW_MAX_DAYS} days, such as 30d, or never`, field);
|
||||
}
|
||||
return days;
|
||||
}
|
||||
|
||||
const GITHUB_LOGIN = /^[A-Za-z0-9](?:[A-Za-z0-9]|-(?=[A-Za-z0-9])){0,38}(?:\[bot\])?$/;
|
||||
export const TRUSTED_AUTHORS_MAX = 20;
|
||||
|
||||
@@ -588,9 +581,23 @@ function trustedAuthorList(value: unknown): string[] {
|
||||
function reportConfig(value: unknown): ExploreConfig["report"] {
|
||||
if (value === undefined) return undefined;
|
||||
const report = record(value, "report");
|
||||
exactKeys(report, ["preview"], "report");
|
||||
if (report.preview === undefined) return {};
|
||||
const preview = record(report.preview, "report.preview");
|
||||
exactKeys(report, ["preview", "comment"], "report");
|
||||
const comment = commentConfig(report.comment);
|
||||
const preview = previewConfig(report.preview);
|
||||
return { ...(preview ? { preview } : {}), ...(comment ? { comment } : {}) };
|
||||
}
|
||||
|
||||
function commentConfig(value: unknown): NonNullable<ExploreConfig["report"]>["comment"] {
|
||||
if (value === undefined) return undefined;
|
||||
const comment = record(value, "report.comment");
|
||||
exactKeys(comment, ["map"], "report.comment");
|
||||
if (typeof comment.map !== "boolean") fail("report.comment.map must be true or false", "report.comment.map");
|
||||
return { map: comment.map };
|
||||
}
|
||||
|
||||
function previewConfig(value: unknown): NonNullable<ExploreConfig["report"]>["preview"] {
|
||||
if (value === undefined) return undefined;
|
||||
const preview = record(value, "report.preview");
|
||||
exactKeys(preview, ["hosting", "expiresAfter", "owner", "project"], "report.preview");
|
||||
const owner = optionalText(preview.owner, "report.preview.owner", 64);
|
||||
if (owner !== undefined && !/^[a-z0-9][a-z0-9_-]*$/.test(owner)) {
|
||||
@@ -600,12 +607,13 @@ function reportConfig(value: unknown): ExploreConfig["report"] {
|
||||
if (project !== undefined && !/^[a-z0-9][a-z0-9-]*[a-z0-9]$/.test(project)) {
|
||||
fail("report.preview.project must be a lowercase EAS project slug", "report.preview.project");
|
||||
}
|
||||
return { preview: {
|
||||
return {
|
||||
hosting: literal(preview.hosting, ["eas"] as const, "report.preview.hosting"),
|
||||
expiresAfterDays: previewDays(preview.expiresAfter, "report.preview.expiresAfter"),
|
||||
// Accepted from configs written before Explore stopped setting an expiry; the commands that host say it is ignored.
|
||||
...(preview.expiresAfter === undefined ? {} : { expiresAfterIgnored: true as const }),
|
||||
...(owner === undefined ? {} : { owner }),
|
||||
...(project === undefined ? {} : { project }),
|
||||
} };
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -1,10 +1,10 @@
|
||||
/**
|
||||
* The agent-facing view of one hosted report: `/p/<token>/api/v1/...` JSON resources, the Markdown
|
||||
* index agents get when they fetch the token page without asking for HTML, and the block the Viewer
|
||||
* shell carries for fetchers that convert HTML to text. It reads the decrypted archive directly, so
|
||||
* it only picks the fields it publishes from the report JSON and treats everything else as untrusted.
|
||||
* shell carries for fetchers that convert HTML to text. It reads the report's own JSON (from a ZIP, or from the static
|
||||
* manifest a hosted preview serves), so it only picks the fields it publishes and treats everything else as untrusted.
|
||||
*/
|
||||
import { readZipDirectory, readZipEntry, type ZipEntry } from "./zip-reader.js";
|
||||
import { readZipDirectory, readZipEntry } from "./zip-reader.js";
|
||||
|
||||
export const AGENT_API_VERSION = "v1";
|
||||
/** The largest review.json or exploration.json a hosted report reads. */
|
||||
@@ -22,8 +22,10 @@ export type LoadedReport = {
|
||||
file: "review.json" | "exploration.json";
|
||||
raw: Uint8Array;
|
||||
json: Json;
|
||||
zip: Uint8Array;
|
||||
entries: Map<string, ZipEntry>;
|
||||
/** Every file of the report by name (`assets/<sha256>.png`), with its size. */
|
||||
entries: Map<string, { size: number }>;
|
||||
/** One file's bytes, at most `limit` of them; undefined when there is no such file or it is larger. Rejects when it cannot be read now. */
|
||||
read: (name: string, limit: number) => Promise<Uint8Array | undefined>;
|
||||
};
|
||||
|
||||
const rec = (value: unknown): Json => (typeof value === "object" && value !== null && !Array.isArray(value) ? value as Json : {});
|
||||
@@ -34,25 +36,40 @@ const bool = (value: unknown): boolean | undefined => (typeof value === "boolean
|
||||
const strings = (value: unknown): string[] => arr(value).filter((item): item is string => typeof item === "string");
|
||||
const defined = <T extends Json>(object: T): T => Object.fromEntries(Object.entries(object).filter(([, value]) => value !== undefined)) as T;
|
||||
|
||||
/** Parses the decrypted archive; undefined when it is not a report this API knows how to read. */
|
||||
/** Parses a report ZIP; undefined when it is not a report this API knows how to read. */
|
||||
export async function loadReport(zip: Uint8Array): Promise<LoadedReport | undefined> {
|
||||
const entries = readZipDirectory(zip);
|
||||
if (!entries) return undefined;
|
||||
const file = entries.has("review.json") ? "review.json" : entries.has("exploration.json") ? "exploration.json" : undefined;
|
||||
const directory = readZipDirectory(zip);
|
||||
if (!directory) return undefined;
|
||||
const file = directory.has("review.json") ? "review.json" : directory.has("exploration.json") ? "exploration.json" : undefined;
|
||||
if (!file) return undefined;
|
||||
const raw = await readZipEntry(zip, entries.get(file)!, MAX_METADATA_BYTES);
|
||||
const raw = await readZipEntry(zip, directory.get(file)!, MAX_METADATA_BYTES);
|
||||
if (!raw) return undefined;
|
||||
const read = async (name: string, limit: number) => {
|
||||
const entry = directory.get(name);
|
||||
return entry ? await readZipEntry(zip, entry, limit) : undefined;
|
||||
};
|
||||
return reportFrom(file, raw, directory, read);
|
||||
}
|
||||
|
||||
/** The report a metadata file describes, with its files and a way to read them; undefined when it is not a report this API reads. */
|
||||
export function reportFrom(file: string, raw: Uint8Array, entries: Map<string, { size: number }>, read: LoadedReport["read"]): LoadedReport | undefined {
|
||||
let parsed: unknown;
|
||||
try { parsed = JSON.parse(new TextDecoder().decode(raw)); } catch { return undefined; }
|
||||
return reportFromJson(file, raw, parsed, entries, read);
|
||||
}
|
||||
|
||||
/** `reportFrom` for a metadata file already parsed: `parsed` is `raw` as JSON. */
|
||||
export function reportFromJson(file: string, raw: Uint8Array, parsed: unknown, entries: Map<string, { size: number }>, read: LoadedReport["read"]): LoadedReport | undefined {
|
||||
if (file !== "review.json" && file !== "exploration.json") return undefined;
|
||||
const root = rec(parsed);
|
||||
if (file === "review.json") {
|
||||
const review = rec(root.review);
|
||||
if (review.contract !== "explore.review" || !Array.isArray(review.surfaces)) return undefined;
|
||||
return { kind: "pr-review", file, raw, json: review, zip, entries };
|
||||
return { kind: "pr-review", file, raw, json: review, entries, read };
|
||||
}
|
||||
const report = root.kind === "explore.exploration-report" ? root : rec(root.report);
|
||||
if (report.kind !== "explore.exploration-report" || typeof report.map !== "object") return undefined;
|
||||
return { kind: "exploration", file, raw, json: report, zip, entries };
|
||||
return { kind: "exploration", file, raw, json: report, entries, read };
|
||||
}
|
||||
|
||||
export type AgentContext = {
|
||||
@@ -465,9 +482,10 @@ export async function agentApiReply(context: AgentContext, loaded: LoadedReport,
|
||||
}
|
||||
case "assets": {
|
||||
if (id === undefined) return notFound();
|
||||
const entry = loaded.entries.get(`assets/${id}.png`);
|
||||
if (!entry) return notFound();
|
||||
const bytes = await readZipEntry(loaded.zip, entry, MAX_ASSET_BYTES);
|
||||
if (!loaded.entries.has(`assets/${id}.png`)) return notFound();
|
||||
let bytes: Uint8Array | undefined;
|
||||
try { bytes = await loaded.read(`assets/${id}.png`, MAX_ASSET_BYTES); }
|
||||
catch { return json({ error: "unavailable", message: "The screenshot could not be read; retry shortly" }, 503); }
|
||||
if (!bytes) return notFound();
|
||||
return { status: 200, contentType: "image/png", body: bytes as BodyInit, headers: { ETag: `"${id}"`, "Content-Length": String(bytes.byteLength) } };
|
||||
}
|
||||
|
||||
@@ -14,7 +14,8 @@ import { CiError, toCiError } from "../shared/ci-errors.js";
|
||||
|
||||
const CONTRACT = "explore.report-input";
|
||||
/** The reviewed config's hosted-preview request, carried to the credentialed deploy job. */
|
||||
export type CiPreviewRequest = { hosting: "eas"; expiresAfterDays: number | null; owner?: string; project?: string };
|
||||
/** The config's report.preview, handed from the capture job to the deploy job. */
|
||||
export type CiPreviewRequest = { hosting: "eas"; expiresAfterIgnored?: true; owner?: string; project?: string };
|
||||
export type CiReportInput = {
|
||||
contract: typeof CONTRACT;
|
||||
publicReview: PublicReview;
|
||||
@@ -64,7 +65,8 @@ async function readInputUnchecked(inputPath: string): Promise<CiReportInput> {
|
||||
}
|
||||
if (input.preview !== undefined) {
|
||||
const preview = input.preview;
|
||||
if (preview.hosting !== "eas" || (preview.expiresAfterDays !== null && (!Number.isInteger(preview.expiresAfterDays) || preview.expiresAfterDays < 1 || preview.expiresAfterDays > 365))
|
||||
// An `expiresAfterDays` from before Explore stopped setting an expiry is ignored.
|
||||
if (preview.hosting !== "eas"
|
||||
|| (preview.project !== undefined && !/^[a-z0-9][a-z0-9-]{0,62}[a-z0-9]$/.test(preview.project))
|
||||
|| (preview.owner !== undefined && !/^[a-z0-9][a-z0-9_-]{0,63}$/.test(preview.owner))) {
|
||||
throw new Error("Invalid hosted preview request");
|
||||
|
||||
@@ -7,11 +7,13 @@ import type { ExplorePlatform } from "../config/explore-config.js";
|
||||
import type { RunTarget } from "../types.js";
|
||||
import { reportTarget } from "./saved-runs.js";
|
||||
import { AGENT_API_VERSION, agentApiReply, agentIndexMarkdown, loadReport, prefersHtml, type AgentContext, type LoadedReport } from "./agent-api.js";
|
||||
import { manifestBody, previewAsset } from "./preview-manifest.js";
|
||||
|
||||
/**
|
||||
* Serve review reports on this machine the way a hosted report serves them: the built Viewer at `/p/<token>`, each
|
||||
* target's report at `/p/<token>/report.zip?target=…` (or `?platform=…`), and the list at `/p/<token>/reports.json`. The
|
||||
* Viewer already knows this layout, so nothing in it changes. An agent on this machine gets what it gets from a hosted
|
||||
* target's manifest at `/p/<token>/manifest.json?target=…` (or `?platform=…`) and its assets at
|
||||
* `/p/<token>/assets/<sha256>.<ext>`, the whole ZIP at `/p/<token>/report.zip`, and the list at `/p/<token>/reports.json`.
|
||||
* The Viewer already knows this layout, so nothing in it changes. An agent on this machine gets what it gets from a hosted
|
||||
* link: the Markdown index when it fetches `/p/<token>` without asking for HTML, `/p/<token>/llms.txt`, and the JSON
|
||||
* API at `/p/<token>/api/v1/...` (agent-api.ts, shared with the hosted Worker). Loopback only; anything else answers 404.
|
||||
*/
|
||||
@@ -67,6 +69,25 @@ export async function startLocalReportServer(options: { reports: LocalReport[];
|
||||
return send(reply.status, body, reply.contentType, { vary: "Accept", ...reply.headers });
|
||||
}
|
||||
if (isPage) return send(200, await readFile(resolve(viewerRoot, "index.html")), TYPES[".html"]);
|
||||
// What the Viewer opens (preview-manifest.ts, as a hosted preview serves it): the manifest, then each asset as it is
|
||||
// shown. An asset is named by its SHA-256 and carries no target, so it comes from whichever report holds it.
|
||||
const read = (entry: LocalReport) => {
|
||||
if (!loaded.has(entry)) loaded.set(entry, loadReport(entry.zip));
|
||||
return loaded.get(entry)!;
|
||||
};
|
||||
if (url.pathname === `${page}/manifest.json`) {
|
||||
const content = report ? await read(report) : undefined;
|
||||
return content ? send(200, manifestBody(content), TYPES[".json"]) : send(404, "Not found");
|
||||
}
|
||||
if (url.pathname.startsWith(`${page}/assets/`)) {
|
||||
const path = url.pathname.slice(page.length + 1);
|
||||
for (const entry of options.reports) {
|
||||
const content = await read(entry);
|
||||
const asset = content ? await previewAsset(content, path) : undefined;
|
||||
if (asset) return send(200, asset.bytes, asset.type);
|
||||
}
|
||||
return send(404, "Not found");
|
||||
}
|
||||
if (url.pathname === `${page}/report.zip`) return report ? send(200, report.zip, "application/zip") : send(404, "Not found");
|
||||
if (url.pathname === `${page}/reports.json` && options.reports.length > 1) return send(200, listing, TYPES[".json"]);
|
||||
// The Viewer's own assets, at the absolute paths its index.html names; never anything outside the build.
|
||||
|
||||
@@ -2,8 +2,8 @@ import type { PublicReview } from "../contracts/capture.js";
|
||||
import type { RunTarget } from "../types.js";
|
||||
import type { SimulatorRuntimeMetadata } from "../capture/run.js";
|
||||
import { CI_COMMENT_MARKER } from "./pr-comment.js";
|
||||
import { CHANGE_GROUPS, MAX_COMMENT_TARGETS, changeCountText, compareTargets, defaultTargetLabel, foldRecord, strongerGroup, historyLine, orderedRecords, readCommentRecords, recordLabel, recordLine, recordSummary, recordTarget,
|
||||
type ChangeGroup, type CommentTarget, type CommentRecords, type HistoryEntry, type PlatformRecord } from "./pr-comment-record.js";
|
||||
import { CHANGE_GROUPS, MAX_COMMENT_TARGETS, MAX_NAVIGATION_EDGES, MAX_NAVIGATION_NODES, changeCountText, compareTargets, defaultTargetLabel, foldRecord, strongerGroup, historyLine, orderedRecords, readCommentRecords, recordLabel, recordLine, recordSummary, recordTarget,
|
||||
type ChangeGroup, type CommentNavigation, type CommentTarget, type CommentRecords, type HistoryEntry, type NavigationGroup, type NavigationKind, type PlatformRecord } from "./pr-comment-record.js";
|
||||
import { isAccessibilityOnlyChange } from "../contracts/review-validation.js";
|
||||
import type { PublicCaptureHealth, PublicEvidenceSummary } from "../review/evidence-assessment.js";
|
||||
import type { ReviewPresentation } from "../contracts/review.js";
|
||||
@@ -57,6 +57,8 @@ export type PublicCommentState = {
|
||||
artifactOnly?: boolean;
|
||||
/** The PR moved while this run worked; the comment keeps its report under previous runs. */
|
||||
superseded?: boolean;
|
||||
/** report.comment.map: draw the map of the changed screens. */
|
||||
map?: true;
|
||||
};
|
||||
|
||||
type ReviewGroup = ChangeGroup;
|
||||
@@ -310,6 +312,8 @@ export function platformRecordOf(state: PublicCommentState, target?: CommentTarg
|
||||
const scheme = schemeOf(surface.id);
|
||||
record.changes.push({ id: surface.id, route: routeOf(surface), group, description: descriptionOf(surface, group), ...(scheme ? { scheme } : {}) });
|
||||
}
|
||||
const navigation = state.map ? navigationOf(state.review, new Map(record.changes.map(change => [change.id, change.group]))) : undefined;
|
||||
if (navigation) record.navigation = navigation;
|
||||
const notCompared = state.review.surfaces.filter(notComparedChange).length;
|
||||
if (notCompared) record.notCompared = notCompared;
|
||||
record.context = contextLines(state.review).filter(line => line.length);
|
||||
@@ -336,6 +340,104 @@ export function platformRecordOf(state: PublicCommentState, target?: CommentTarg
|
||||
return record;
|
||||
}
|
||||
|
||||
const NAVIGATION_GROUPS: NavigationGroup[] = ["added", "removed", "modified"];
|
||||
const NAVIGATION_KINDS: NavigationKind[] = ["push", "replace", "navigate", "dismissTo", "redirect"];
|
||||
|
||||
/** "/p/[d]" for the route file app/(tabs)/(patterns)/p/[d].tsx: the route without its groups, which a dynamic route's variants share. */
|
||||
function routePattern(route: NonNullable<Surface["head"]>): string {
|
||||
const path = `/${route.logicalPath.replace(/^\/+/, "")}`.split("/").filter(segment => !/^\(.*\)$/.test(segment)).join("/");
|
||||
return plainText(path.replace(/\/index$/, ""), MAX_ROUTE_LENGTH) || "/";
|
||||
}
|
||||
|
||||
/**
|
||||
* The map the comment draws: every route added, removed or changed visually (a screen whose source changed but looks
|
||||
* the same is not one), the routes one step before them, and the transitions among those. A route's appearances and
|
||||
* variants are one node. Switching tabs reaches every tab from every other, so tab transitions are not edges: the
|
||||
* routes a tab switch shows are grouped instead. Removed routes and the transitions into them come from the base.
|
||||
*/
|
||||
function navigationOf(review: PublicReview, groups: Map<string, ChangeGroup>): CommentNavigation | undefined {
|
||||
if (!review.navigation) return undefined;
|
||||
const keyOf = new Map<string, string>();
|
||||
const groupOf = new Map<string, NavigationGroup>();
|
||||
for (const surface of review.surfaces) {
|
||||
const route = surface.head ?? surface.base;
|
||||
if (!route || route.kind === "redirect") continue;
|
||||
const key = routePattern(route);
|
||||
keyOf.set(surface.id.replace(/@(light|dark)$/, ""), key);
|
||||
const group = groups.get(surface.id);
|
||||
if (group !== "added" && group !== "removed" && group !== "modified") continue;
|
||||
const current = groupOf.get(key);
|
||||
if (!current || NAVIGATION_GROUPS.indexOf(group) < NAVIGATION_GROUPS.indexOf(current)) groupOf.set(key, group);
|
||||
}
|
||||
if (!groupOf.size || groupOf.size > MAX_NAVIGATION_NODES) return undefined;
|
||||
const tabs = new Set<string>();
|
||||
const links = new Map<string, { from: string; to: string; kinds: Set<NavigationKind>; base: boolean }>();
|
||||
const add = (edge: NonNullable<PublicReview["navigation"]>["head"]["edges"][number], base: boolean) => {
|
||||
const from = keyOf.get(edge.from), to = keyOf.get(edge.to);
|
||||
if (!from || !to || from === to) return;
|
||||
if (edge.kind === "tab") { tabs.add(to); return; }
|
||||
const link = links.get(`${from}\n${to}`) ?? { from, to, kinds: new Set(), base };
|
||||
link.kinds.add(edge.kind);
|
||||
links.set(`${from}\n${to}`, link);
|
||||
};
|
||||
for (const edge of review.navigation.head.edges) add(edge, false);
|
||||
for (const edge of review.navigation.base.edges) if (groupOf.get(keyOf.get(edge.to) ?? "") === "removed") add(edge, true);
|
||||
// The routes that lead to the most changed ones first, while the map has room.
|
||||
const leads = new Map<string, number>();
|
||||
for (const link of links.values()) if (groupOf.has(link.to) && !groupOf.has(link.from)) leads.set(link.from, (leads.get(link.from) ?? 0) + 1);
|
||||
const before = [...leads].sort(([a, m], [b, n]) => n - m || (a < b ? -1 : 1)).slice(0, MAX_NAVIGATION_NODES - groupOf.size).map(([key]) => key);
|
||||
const keys = [...groupOf.keys(), ...before].sort();
|
||||
const index = new Map(keys.map((key, position) => [key, position]));
|
||||
const edges = [...links.values()].filter(link => index.has(link.from) && index.has(link.to))
|
||||
.sort((a, b) => Number(groupOf.has(b.to)) - Number(groupOf.has(a.to)) || index.get(a.from)! - index.get(b.from)! || index.get(a.to)! - index.get(b.to)!)
|
||||
.slice(0, MAX_NAVIGATION_EDGES)
|
||||
.sort((a, b) => index.get(a.from)! - index.get(b.from)! || index.get(a.to)! - index.get(b.to)!)
|
||||
.map(link => ({ from: index.get(link.from)!, to: index.get(link.to)!, kinds: NAVIGATION_KINDS.filter(kind => link.kinds.has(kind)), ...(link.base ? { base: true as const } : {}) }));
|
||||
if (!edges.length) return undefined;
|
||||
return { nodes: keys.map(key => ({ route: key, ...(groupOf.has(key) ? { group: groupOf.get(key)! } : {}), ...(tabs.has(key) ? { tab: true as const } : {}) })), edges };
|
||||
}
|
||||
|
||||
/** A route as a quoted Mermaid label, with Mermaid's entity codes for what would end the label, the line or the fence. */
|
||||
function mermaidLabel(route: string): string {
|
||||
return `"${plainText(route, MAX_ROUTE_LENGTH).replace(/#/g, "#35;").replace(/"/g, "#quot;").replace(/</g, "#lt;").replace(/>/g, "#gt;").replace(/`/g, "#96;")}"`;
|
||||
}
|
||||
|
||||
/** Outlines, not fills: GitHub draws Mermaid in the reader's theme, and a fixed fill is wrong in one of them. */
|
||||
const MAP_CLASSES: Record<NavigationGroup, string> = {
|
||||
added: "stroke:#1a7f37,stroke-width:3px",
|
||||
modified: "stroke:#bc4c00,stroke-width:3px",
|
||||
removed: "stroke:#cf222e,stroke-width:2px,stroke-dasharray:5 4",
|
||||
};
|
||||
|
||||
function mermaidMap(navigation: CommentNavigation): string[] {
|
||||
const node = (index: number) => `n${index}[${mermaidLabel(navigation.nodes[index]!.route)}]`;
|
||||
const tabs = navigation.nodes.flatMap((entry, index) => entry.tab ? [index] : []);
|
||||
const lines = ["```mermaid", "flowchart LR"];
|
||||
if (tabs.length) lines.push(` subgraph tabs["Tabs"]`, ...tabs.map(index => ` ${node(index)}`), " end");
|
||||
lines.push(...navigation.nodes.flatMap((entry, index) => entry.tab ? [] : [` ${node(index)}`]));
|
||||
lines.push(...navigation.edges.map(edge => ` n${edge.from} ${edge.base ? "-.->" : "-->"}|${edge.kinds.join(", ")}| n${edge.to}`));
|
||||
for (const group of ["added", "modified", "removed"] as const) {
|
||||
const members = navigation.nodes.flatMap((entry, index) => entry.group === group ? [`n${index}`] : []);
|
||||
if (members.length) lines.push(` classDef ${group} ${MAP_CLASSES[group]}`, ` class ${members.join(",")} ${group}`);
|
||||
}
|
||||
return [...lines, "```"];
|
||||
}
|
||||
|
||||
/** One collapsed map per distinct navigation: targets with the same routes share one, named when the targets' maps differ. */
|
||||
function mapSection(ready: PlatformRecord[]): string[] {
|
||||
const maps = new Map<string, { navigation: CommentNavigation; records: PlatformRecord[] }>();
|
||||
for (const record of ready) {
|
||||
if (!record.navigation) continue;
|
||||
const key = JSON.stringify(record.navigation);
|
||||
maps.set(key, { navigation: record.navigation, records: [...(maps.get(key)?.records ?? []), record] });
|
||||
}
|
||||
return [...maps.values()].flatMap(({ navigation, records }) => {
|
||||
const named = maps.size > 1 || records.length < ready.length ? `${records.map(labelOf).join(" · ")} · ` : "";
|
||||
return details(`${named}Map (${plural(navigation.nodes.length, "screen")})`, ["", ...mermaidMap(navigation), "",
|
||||
"Outlined: green added, orange changed, red dashed removed; the others lead to them. Tabs groups the screens a tab switch shows.", ""]);
|
||||
});
|
||||
}
|
||||
|
||||
const commitLink = (repository: string, sha: string) => link(inlineText(sha.slice(0, 8), 8), `https://github.com/${repository.split("/").map(encodeURIComponent).join("/")}/commit/${encodeURIComponent(sha)}`);
|
||||
|
||||
function surfaceLink(report: string, id: string): string | undefined {
|
||||
@@ -431,7 +533,7 @@ function renderChangeRow(row: ChangeRow, records: PlatformRecord[]): string {
|
||||
return `- ${route} — ${inlineText(row.description, MAX_DESCRIPTION_LENGTH)}${where.length ? ` · ${where.join(" · ")}` : ""}`;
|
||||
}
|
||||
|
||||
function changesSection(records: PlatformRecord[], rowCap: number): string[] {
|
||||
function changesSection(records: PlatformRecord[], rowCap: number, withMap: boolean): string[] {
|
||||
const ready = records.filter(record => record.phase === "ready");
|
||||
if (!ready.length) return [];
|
||||
const groups = changeRows(ready);
|
||||
@@ -454,6 +556,7 @@ function changesSection(records: PlatformRecord[], rowCap: number): string[] {
|
||||
content.push("");
|
||||
lines.push(...details(`${GROUP_LABEL[group]} (${rows.length})`, content));
|
||||
}
|
||||
if (withMap) lines.push(...mapSection(ready));
|
||||
const seen = new Set<string>();
|
||||
for (const record of ready) for (const line of record.context ?? []) {
|
||||
if (seen.has(line)) continue;
|
||||
@@ -594,13 +697,13 @@ export function renderCommentRecords(records: CommentRecords, existing?: string,
|
||||
...historySection("", records.history)].join("\n");
|
||||
const first = current[0]!;
|
||||
const repository = repositoryOf(first.links.run);
|
||||
const render = (rowCap: number): string => {
|
||||
const render = (rowCap: number, withMap: boolean): string => {
|
||||
const lines: string[] = [...hidden, heading(current), "",
|
||||
`<sub>base ${commitLink(repository, first.baseSha)} → ${commitLink(repository, first.headSha)}</sub>`, ""];
|
||||
if (first.superseded) lines.push(SUPERSEDED_NOTE, "");
|
||||
lines.push(`| | Device | Result | Report |`, `|---|---|---|---|`,
|
||||
...current.map(record => `| ${labelOf(record)} | ${deviceCell(record)} | ${resultCell(record)} | ${reportCell(record)} |`), "");
|
||||
lines.push(...changesSection(current, rowCap));
|
||||
lines.push(...changesSection(current, rowCap, withMap));
|
||||
lines.push(...validationSection(current));
|
||||
lines.push(...historySection(repository, records.history));
|
||||
const expiries = current.filter(record => record.phase === "ready" && record.links.expiresAt !== undefined).map(record => record.links.expiresAt);
|
||||
@@ -613,9 +716,11 @@ export function renderCommentRecords(records: CommentRecords, existing?: string,
|
||||
lines.push(footer.join(" · "));
|
||||
return lines.join("\n");
|
||||
};
|
||||
// The map goes first when the body is over budget, then the change lists shrink.
|
||||
let rowCap = MAX_ROWS_PER_GROUP;
|
||||
let body = render(rowCap);
|
||||
while (body.length > budget && rowCap > 1) { rowCap = Math.max(1, Math.floor(rowCap / 2)); body = render(rowCap); }
|
||||
let body = render(rowCap, true);
|
||||
if (body.length > budget) body = render(rowCap, false);
|
||||
while (body.length > budget && rowCap > 1) { rowCap = Math.max(1, Math.floor(rowCap / 2)); body = render(rowCap, false); }
|
||||
return body;
|
||||
}
|
||||
|
||||
|
||||
@@ -56,6 +56,23 @@ export function changeCountText(groups: readonly ChangeGroup[]): string {
|
||||
return [visual ? `${visual} visual change${visual === 1 ? "" : "s"}` : undefined, `${accessibility} accessibility only`].filter(Boolean).join(" · ");
|
||||
}
|
||||
|
||||
export type NavigationGroup = "added" | "modified" | "removed";
|
||||
export type NavigationKind = "push" | "replace" | "navigate" | "redirect" | "tab" | "dismissTo";
|
||||
const NAVIGATION_GROUPS: NavigationGroup[] = ["added", "modified", "removed"];
|
||||
const NAVIGATION_KINDS: NavigationKind[] = ["push", "replace", "navigate", "redirect", "tab", "dismissTo"];
|
||||
export const MAX_NAVIGATION_NODES = 30;
|
||||
export const MAX_NAVIGATION_EDGES = 80;
|
||||
|
||||
/**
|
||||
* The comment's map: one node per route that was added, removed or changed visually, and per route one step before
|
||||
* one of them; edges index `nodes`. `tab` marks a route a tab switch shows, `base` an edge into a removed route, which
|
||||
* only the base revision's navigation has.
|
||||
*/
|
||||
export type CommentNavigation = {
|
||||
nodes: { route: string; group?: NavigationGroup; tab?: true }[];
|
||||
edges: { from: number; to: number; kinds: NavigationKind[]; base?: true }[];
|
||||
};
|
||||
|
||||
export type SideHealth = { planned: number; captured: number; verified: number; unverified: number; unavailable: number };
|
||||
|
||||
export type PlatformRecord = {
|
||||
@@ -92,6 +109,7 @@ export type PlatformRecord = {
|
||||
notCompared?: number;
|
||||
/** Differences stated once rather than per screen (variants, app-wide source changes). */
|
||||
context?: string[];
|
||||
navigation?: CommentNavigation;
|
||||
diagnostics?: { side?: "base" | "head"; route: string; code: string; message: string; nextAction: string }[];
|
||||
diagnosticCount?: number;
|
||||
failure?: { step: string; message: string };
|
||||
@@ -236,6 +254,8 @@ export function parsePlatformRecord(value: unknown): PlatformRecord | undefined
|
||||
? [{ id: entry.id, route: entry.route, group: entry.group as ChangeGroup, description: entry.description, ...(isString(entry.scheme, 20) ? { scheme: entry.scheme } : {}) }] : []);
|
||||
if (changes.length <= 2000) record.changes = changes;
|
||||
}
|
||||
const navigation = parseNavigation(value.navigation);
|
||||
if (navigation) record.navigation = navigation;
|
||||
if (Array.isArray(value.context)) record.context = value.context.filter((entry): entry is string => isString(entry, 2000)).slice(0, 10);
|
||||
if (Array.isArray(value.diagnostics)) {
|
||||
record.diagnostics = value.diagnostics.flatMap((entry): NonNullable<PlatformRecord["diagnostics"]> => isRecord(entry) && isString(entry.route, 2000) && isString(entry.code, 200)
|
||||
@@ -249,6 +269,25 @@ export function parsePlatformRecord(value: unknown): PlatformRecord | undefined
|
||||
return record;
|
||||
}
|
||||
|
||||
function parseNavigation(value: unknown): CommentNavigation | undefined {
|
||||
if (!isRecord(value) || !Array.isArray(value.nodes) || !Array.isArray(value.edges) || value.nodes.length > MAX_NAVIGATION_NODES
|
||||
|| value.edges.length > MAX_NAVIGATION_EDGES) return undefined;
|
||||
const nodes: CommentNavigation["nodes"] = [];
|
||||
for (const node of value.nodes) {
|
||||
if (!isRecord(node) || !isString(node.route, 200) || !optional(node.group, (group): group is NavigationGroup => NAVIGATION_GROUPS.includes(group as NavigationGroup))
|
||||
|| !(node.tab === undefined || node.tab === true)) return undefined;
|
||||
nodes.push({ route: node.route, ...(node.group ? { group: node.group } : {}), ...(node.tab ? { tab: true } : {}) });
|
||||
}
|
||||
const edges: CommentNavigation["edges"] = [];
|
||||
const isNode = (index: unknown): index is number => isCount(index) && index < nodes.length;
|
||||
for (const edge of value.edges) {
|
||||
if (!isRecord(edge) || !isNode(edge.from) || !isNode(edge.to) || !Array.isArray(edge.kinds) || !edge.kinds.length
|
||||
|| !edge.kinds.every(kind => NAVIGATION_KINDS.includes(kind as NavigationKind)) || !(edge.base === undefined || edge.base === true)) return undefined;
|
||||
edges.push({ from: edge.from, to: edge.to, kinds: [...new Set(edge.kinds as NavigationKind[])], ...(edge.base ? { base: true } : {}) });
|
||||
}
|
||||
return nodes.length && edges.length ? { nodes, edges } : undefined;
|
||||
}
|
||||
|
||||
export function parseHistory(value: unknown): HistoryEntry[] {
|
||||
if (!Array.isArray(value)) return [];
|
||||
const entries: HistoryEntry[] = [];
|
||||
|
||||
@@ -1,14 +1,15 @@
|
||||
import { createCipheriv, createHash, randomBytes } from "node:crypto";
|
||||
import { createHash, randomBytes } from "node:crypto";
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { appendFile, cp, lstat, mkdir, mkdtemp, readdir, readFile, realpath, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join, relative, resolve, sep } from "node:path";
|
||||
import { Uint8ArrayReader, Uint8ArrayWriter, ZipWriter, configure } from "@zip.js/zip.js";
|
||||
import { MAX_METADATA_BYTES } from "./agent-api.js";
|
||||
import { loadReport, MAX_METADATA_BYTES } from "./agent-api.js";
|
||||
import { MAX_ASSET_BYTES, manifestBody, PREVIEW_ASSET } from "./preview-manifest.js";
|
||||
import { publishCiReportComment, readCiReportInput, type CiReportInput } from "./artifact.js";
|
||||
import { readZipDirectory, readZipEntry } from "./zip-reader.js";
|
||||
import { reviewChangeCount, reviewDevice } from "./pr-comment-body.js";
|
||||
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { isTargetId, warnIgnoredExpiry, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import type { RunTarget } from "../types.js";
|
||||
import { targetParameter } from "./viewer-links.js";
|
||||
import type { ArtifactReport } from "../contracts/artifact-report.js";
|
||||
@@ -21,21 +22,23 @@ import { TOOL_ROOT, packageBin } from "../shared/package-paths.js";
|
||||
/**
|
||||
* `ci:deploy`: publish one token-gated EAS Hosting deployment for a packaged review.
|
||||
*
|
||||
* The deployment is the prebuilt preview export of viewer-host (routes `/p/[token]`, see viewer-host/README.md)
|
||||
* plus the report ZIP encrypted with a key that only the deployment's Worker environment holds. The Worker
|
||||
* serves the Viewer and the decrypted report at `/p/<token>` and answers 404 to everything else; after
|
||||
* `expiresAt` (if any) the token page says the link expired. Deployments are never deleted automatically. The report job already published the GitHub artifact links, so a failed deployment leaves
|
||||
* the comment on the download-and-drop flow.
|
||||
* The deployment is the prebuilt preview export of viewer-host (routes `/p/[token]`, see viewer-host/README.md) plus
|
||||
* the report as static files under the link's token: each target's manifest at `p/<token>/targets/<target>.json` and
|
||||
* every screenshot at `p/<token>/assets/<sha256>.<ext>`. Nothing is encrypted; the 160-bit token in every path is what
|
||||
* keeps them private. The Worker serves the Viewer at `/p/<token>` and answers 404 to everything else. A deployment
|
||||
* lasts as long as EAS Hosting keeps it (it deletes deployments without an alias after 30 days on Free, 90 on paid
|
||||
* plans); Explore sets no expiry of its own. The report job already published the GitHub artifact links, so a failed
|
||||
* deployment leaves the comment on the download-and-drop flow.
|
||||
*/
|
||||
export type CommandRunner = (command: string, args: readonly string[], options: { cwd: string; env: NodeJS.ProcessEnv })
|
||||
=> { status: number | null; stdout: string; stderr: string };
|
||||
|
||||
export type PreviewReportInput = {
|
||||
/** Set by the matrix workflows; the preview then serves this report at report.zip?platform=<platform>. */
|
||||
/** Set by the matrix workflows; the preview then serves this report at manifest.json?platform=<platform>. */
|
||||
platform?: ExplorePlatform;
|
||||
/**
|
||||
* The capture target, set by the matrix workflows (wins over `platform`): the preview serves the report as
|
||||
* `<target id>.zip.enc` at report.zip?target=<id> (?platform=<id> for a target named after its platform).
|
||||
* `targets/<target id>.json`, selected by manifest.json?target=<id> (?platform=<id> for a target named after its platform).
|
||||
*/
|
||||
target?: RunTarget;
|
||||
inputPath: string;
|
||||
@@ -45,7 +48,7 @@ export type PreviewReportInput = {
|
||||
};
|
||||
|
||||
export type PreviewDeployOptions = (PreviewReportInput | {
|
||||
/** One report per platform from the same run, sealed into one deployment behind one token. */
|
||||
/** One report per platform from the same run, deployed together behind one token. */
|
||||
reports: PreviewReportInput[];
|
||||
}) & {
|
||||
environment?: NodeJS.ProcessEnv;
|
||||
@@ -81,7 +84,6 @@ export type PreviewDeployResult = {
|
||||
};
|
||||
|
||||
export const PREVIEW_EXPORT_PATH = join(TOOL_ROOT, "dist", "hosting-preview");
|
||||
const CIPHER_AAD = "expo-explore-preview/1";
|
||||
const BASE32 = "abcdefghijklmnopqrstuvwxyz234567";
|
||||
/** The largest report ZIP a hosted preview serves. */
|
||||
export const MAX_REPORT_BYTES = 256 * 1024 * 1024;
|
||||
@@ -93,7 +95,7 @@ export function platformTarget(platform: ExplorePlatform): RunTarget {
|
||||
return { id: platform, platform, label: PLATFORM_LABELS[platform] };
|
||||
}
|
||||
|
||||
/** The report.zip query that selects a target (see targetParameter): `?platform=ios` for configs without targets, as before. */
|
||||
/** The manifest.json query that selects a target (see targetParameter): `?platform=ios` for configs without targets, as before. */
|
||||
function targetQuery(target: RunTarget): string {
|
||||
const [key, value] = targetParameter(target.id);
|
||||
return `?${key}=${value}`;
|
||||
@@ -141,11 +143,21 @@ const DEPLOY_ATTEMPTS = 3;
|
||||
const ALIAS_LIMIT = /reached the limit of \d+ aliases[^\n]*/;
|
||||
const DEPLOY_RETRY_DELAYS_MS = [5_000, 15_000] as const;
|
||||
|
||||
/** The tail of what a command printed, stderr first, without the EXPO_TOKEN should eas ever echo it. */
|
||||
function commandOutput(result: ReturnType<CommandRunner>, token: string | undefined): string {
|
||||
/**
|
||||
* EAS Hosting serves static files with its own headers, so the screenshots and manifests cannot carry the Worker's
|
||||
* `noindex`; this keeps crawlers from fetching them. The page and API stay crawlable, so a crawler still sees their `noindex`.
|
||||
*/
|
||||
export const PREVIEW_ROBOTS = "User-agent: *\nDisallow: /p/*/assets/\nDisallow: /p/*/targets/\n";
|
||||
|
||||
/**
|
||||
* The tail of what a command printed, stderr first, without the secrets: the EXPO_TOKEN should eas ever echo it, and the
|
||||
* link's token, which every static file's path carries (eas names the file whose upload failed).
|
||||
*/
|
||||
function commandOutput(result: ReturnType<CommandRunner>, secrets: Array<string | undefined>): string {
|
||||
const lines = `${result.stderr}\n${result.stdout}`.split("\n").map(line => line.trimEnd()).filter(Boolean);
|
||||
const tail = lines.slice(-30).join("\n");
|
||||
return token ? tail.split(token).join("***") : tail;
|
||||
let tail = lines.slice(-30).join("\n");
|
||||
for (const secret of secrets) if (secret) tail = tail.split(secret).join("***");
|
||||
return tail;
|
||||
}
|
||||
|
||||
/** `eas whoami` has no JSON output; its account list is one `• name (Role: …)` line per account. */
|
||||
@@ -252,13 +264,6 @@ export async function readReportZip(zip: Uint8Array): Promise<ReportZipSummary>
|
||||
}
|
||||
|
||||
/** iv (12 bytes) || AES-256-GCM ciphertext || tag, authenticated with the preview AAD; what the Worker decrypts. */
|
||||
export function sealReport(plain: Uint8Array, key: Uint8Array, iv: Uint8Array): Uint8Array {
|
||||
const cipher = createCipheriv("aes-256-gcm", key, iv);
|
||||
cipher.setAAD(Buffer.from(CIPHER_AAD));
|
||||
const body = Buffer.concat([cipher.update(plain), cipher.final(), cipher.getAuthTag()]);
|
||||
return new Uint8Array(Buffer.concat([iv, body]));
|
||||
}
|
||||
|
||||
/** Fails fast when the Viewer export that hosted reports need is not installed, so a run does not explore for minutes before learning it cannot upload. */
|
||||
export async function assertHostingExport(exportPath: string = PREVIEW_EXPORT_PATH): Promise<void> {
|
||||
await assertExport(resolve(exportPath));
|
||||
@@ -272,12 +277,13 @@ async function assertExport(exportPath: string): Promise<void> {
|
||||
}
|
||||
}
|
||||
|
||||
type SealedReport = { entry: PreviewReportInput; input: CiReportInput; target?: RunTarget; zip: Uint8Array; sha256: string; file: string };
|
||||
/** A report to deploy; `file` names its manifest, `targets/<file>.json`: the target id, or `report` for a single unlisted one. */
|
||||
type DeployedReport = { entry: PreviewReportInput; input: CiReportInput; target?: RunTarget; zip: Uint8Array; sha256: string; file: string };
|
||||
|
||||
function previewError(code: string, message: string, nextAction: string): CiError { return new CiError({ code, stage: "preflight", message, nextAction }); }
|
||||
|
||||
/**
|
||||
* A device label for the platform switch, safe in the sealed .env: letters, digits and a few separators only. `eas
|
||||
* A device label for the platform switch, safe in the deployment's .env: letters, digits and a few separators only. `eas
|
||||
* deploy` reads that file with variable expansion, so a `$` (even single-quoted) would pull the deploying process's
|
||||
* environment into the label, and a `#` or a backslash would cut or corrupt the JSON around it.
|
||||
*/
|
||||
@@ -291,14 +297,25 @@ function listingLabel(label: string): string {
|
||||
|
||||
/** One EXPLORE_PREVIEW_REPORTS entry, keys in the order the Worker echoes them in reports.json. */
|
||||
export type PreviewListingEntry = { target: string; platform: ExplorePlatform; label?: string; path: string; changes?: number; device?: string };
|
||||
function listingEntry(target: RunTarget, path: string, changes?: number, device?: string): PreviewListingEntry {
|
||||
/** A listing entry before the deployment's token, and so its manifest's path, is known. */
|
||||
type ListingTarget = Omit<PreviewListingEntry, "path">;
|
||||
function listingEntry(target: RunTarget, changes?: number, device?: string): ListingTarget {
|
||||
const label = listingLabel(target.label), shown = device ? listingDevice(device) : "";
|
||||
return { target: target.id, platform: target.platform, ...(label ? { label } : {}), path, ...(changes === undefined ? {} : { changes }), ...(shown ? { device: shown } : {}) };
|
||||
return { target: target.id, platform: target.platform, ...(label ? { label } : {}), ...(changes === undefined ? {} : { changes }), ...(shown ? { device: shown } : {}) };
|
||||
}
|
||||
/** The entry with its manifest's path, where the Worker reads it from (`path` after `label`, as reports.json leaves it out). */
|
||||
function listedAt(entry: ListingTarget, path: string): PreviewListingEntry {
|
||||
const { changes, device, ...head } = entry;
|
||||
return { ...head, path, ...(changes === undefined ? {} : { changes }), ...(device === undefined ? {} : { device }) };
|
||||
}
|
||||
/** Where a deployment serves a target's manifest. */
|
||||
export function manifestPath(token: string, file: string): string {
|
||||
return `/p/${token}/targets/${file}.json`;
|
||||
}
|
||||
|
||||
/** The worker's EXPLORE_PREVIEW_REPORTS entries, in the order the workflow lists targets; also what reports.json must echo. */
|
||||
export function previewReportListing(reports: ReadonlyArray<Pick<SealedReport, "input" | "file"> & { target: RunTarget }>, reportDirectory: string): PreviewListingEntry[] {
|
||||
return reports.map(report => listingEntry(report.target, `/_report/${reportDirectory}/${report.file}`, reviewChangeCount(report.input.commentState), reviewDevice(report.input.commentState)));
|
||||
/** The worker's EXPLORE_PREVIEW_REPORTS entries without their paths, in the order the workflow lists targets. */
|
||||
export function previewReportListing(reports: ReadonlyArray<Pick<DeployedReport, "input"> & { target: RunTarget }>): ListingTarget[] {
|
||||
return reports.map(report => listingEntry(report.target, reviewChangeCount(report.input.commentState), reviewDevice(report.input.commentState)));
|
||||
}
|
||||
|
||||
export async function deployPreview(options: PreviewDeployOptions): Promise<PreviewDeployResult> {
|
||||
@@ -324,6 +341,8 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
|
||||
const first = inputs[0]!.input; const review = first.publicReview; const pr = review.pullRequest;
|
||||
if (!first.preview) throw new CiError({ code: "PREVIEW_NOT_CONFIGURED", stage: "preflight",
|
||||
message: "This review did not request a hosted preview", nextAction: "Set report.preview.hosting: eas in .expo-explore/config.yaml, or remove the deploy job." });
|
||||
// `expiresAfterDays` is what a capture from before Explore stopped setting an expiry recorded.
|
||||
if (first.preview.expiresAfterIgnored || "expiresAfterDays" in first.preview) warnIgnoredExpiry("report.preview.expiresAfter", environment);
|
||||
if (!environment.EXPO_TOKEN?.trim()) throw new CiError({ code: "EXPO_TOKEN_MISSING", stage: "preflight",
|
||||
message: "EXPO_TOKEN is required to deploy a hosted preview", nextAction: "Pass the EXPO_TOKEN secret to the deploy job; it must be able to create projects in the app's Expo account." });
|
||||
if (!environment.GITHUB_TOKEN?.trim()) throw new CiError({ code: "GITHUB_TOKEN_MISSING", stage: "preflight",
|
||||
@@ -339,27 +358,25 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
|
||||
const exportPath = resolve(options.exportPath ?? PREVIEW_EXPORT_PATH);
|
||||
await assertExport(exportPath);
|
||||
|
||||
const reports: SealedReport[] = [];
|
||||
const reports: DeployedReport[] = [];
|
||||
for (const { entry, input, target } of inputs) {
|
||||
let zip: Uint8Array;
|
||||
try { zip = await zipReportDirectory(entry.reportPath); }
|
||||
catch (error) { throw toCiError(error, { code: "REPORT_ZIP_FAILED", stage: "export",
|
||||
nextAction: "Pass the ci:report output directory downloaded from this run's explore-review artifact." }); }
|
||||
reports.push({ entry, input, ...(target ? { target } : {}), zip, sha256: createHash("sha256").update(zip).digest("hex"), file: multi && target ? `${target.id}.zip.enc` : "report.zip.enc" });
|
||||
reports.push({ entry, input, ...(target ? { target } : {}), zip, sha256: createHash("sha256").update(zip).digest("hex"), file: multi && target ? target.id : "report" });
|
||||
}
|
||||
|
||||
const reportDirectory = base32(random(10));
|
||||
const expiresAt = first.preview.expiresAfterDays === null ? null : now() + first.preview.expiresAfterDays * 86_400_000;
|
||||
const project = previewProjectSlug(pr.repository, first.preview.project);
|
||||
const listing = multi ? previewReportListing(reports.map(report => ({ ...report, target: report.target! })), reportDirectory) : undefined;
|
||||
let hosted: Awaited<ReturnType<typeof deploySealedReports>>;
|
||||
const listing = multi ? previewReportListing(reports.map(report => ({ ...report, target: report.target! }))) : undefined;
|
||||
let hosted: Awaited<ReturnType<typeof deployReports>>;
|
||||
try {
|
||||
hosted = await deploySealedReports({
|
||||
hosted = await deployReports({
|
||||
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: multi && report.target ? targetQuery(report.target) : "" })),
|
||||
reportDirectory, ...(listing ? { listing } : {}), project, ...(first.preview.owner ? { owner: first.preview.owner } : {}),
|
||||
...(listing ? { listing } : {}), project, ...(first.preview.owner ? { owner: first.preview.owner } : {}),
|
||||
ownerHint: "Set report.preview.owner in .expo-explore/config.yaml to the account that should hold the preview project.",
|
||||
projectHint: "Give EXPO_TOKEN's account permission to create projects, or set report.preview.project to an existing project it can deploy to.",
|
||||
expiresAt, exportPath, environment, run, transport, now, random, ...(options.sleep ? { sleep: options.sleep } : {}),
|
||||
exportPath, environment, run, transport, now, random, ...(options.sleep ? { sleep: options.sleep } : {}),
|
||||
// The runner masks secrets in job summaries too, so a masked token would reach a comparison's summary as ***.
|
||||
// Its link appears nowhere else (not in the log), as a PR's appears only in its comment, for the same readers.
|
||||
...(options.onSecret && pr.origin !== "compare" ? { onSecret: options.onSecret } : {}),
|
||||
@@ -376,15 +393,15 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
|
||||
}
|
||||
const previewUrl = hosted.previewUrl;
|
||||
// A comparison has no pull request: its link goes to the run's summary, which the same repository readers see.
|
||||
if (pr.origin === "compare") await writeCompareSummary(environment, pr, previewUrl, expiresAt, reports.map(report => report.input));
|
||||
if (pr.origin === "compare") await writeCompareSummary(environment, pr, previewUrl, reports.map(report => report.input));
|
||||
{
|
||||
let headSha = pr.head.sha;
|
||||
if (pr.origin !== "compare") for (const report of reports) {
|
||||
const published = await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
|
||||
...commentTarget(report), preview: { url: previewUrl, expiresAt } });
|
||||
...commentTarget(report), preview: { url: previewUrl, expiresAt: null } });
|
||||
headSha = published.headSha;
|
||||
}
|
||||
return { previewUrl, expiresAt: expiresAt === null ? null : new Date(expiresAt).toISOString(), deploymentId: hosted.deploymentId, deploymentUrl: hosted.deploymentUrl,
|
||||
return { previewUrl, expiresAt: null, deploymentId: hosted.deploymentId, deploymentUrl: hosted.deploymentUrl,
|
||||
project, owner: hosted.owner, reportSha256: reports[0]!.sha256, reportBytes: reports[0]!.zip.byteLength,
|
||||
reports: reports.map(report => ({ ...(report.entry.platform ? { platform: report.entry.platform } : {}), ...(report.target ? { target: report.target } : {}), artifactUrl: report.entry.artifactUrl,
|
||||
reportSha256: report.sha256, reportBytes: report.zip.byteLength })), headSha,
|
||||
@@ -393,13 +410,13 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
|
||||
}
|
||||
|
||||
/** Which comment section and artifact a report is: its target, or (single-report runs) none. */
|
||||
function commentTarget(report: SealedReport): { target?: string; platform?: ExplorePlatform } {
|
||||
function commentTarget(report: DeployedReport): { target?: string; platform?: ExplorePlatform } {
|
||||
if (report.target) return { target: report.target.id, platform: report.target.platform };
|
||||
return report.entry.platform ? { platform: report.entry.platform } : {};
|
||||
}
|
||||
|
||||
/** The comparison's job summary: what was compared, the hosted link, and each target's change count. */
|
||||
export function renderCompareSummary(comparison: CompareReviewPresentation, previewUrl: string, expiresAt: number | null, inputs: CiReportInput[]): string {
|
||||
export function renderCompareSummary(comparison: CompareReviewPresentation, previewUrl: string, inputs: CiReportInput[]): string {
|
||||
const platforms = inputs.map(input => {
|
||||
const changes = reviewChangeCount(input.commentState);
|
||||
const device = reviewDevice(input.commentState);
|
||||
@@ -407,15 +424,14 @@ export function renderCompareSummary(comparison: CompareReviewPresentation, prev
|
||||
return `- ${label}${device ? ` (${device})` : ""}: ${changes === undefined ? "no review" : `${changes} ${changes === 1 ? "change" : "changes"}`}`;
|
||||
});
|
||||
return [`### Explore: ${compareTitleMarkdown(comparison)}`, "",
|
||||
`[Open the report](${previewUrl}) · [${comparison.base.sha.slice(0, 8)}..${comparison.head.sha.slice(0, 8)}](${comparison.url})`
|
||||
+ (expiresAt === null ? "" : ` · link expires ${new Date(expiresAt).toISOString().slice(0, 10)}`), "",
|
||||
`[Open the report](${previewUrl}) · [${comparison.base.sha.slice(0, 8)}..${comparison.head.sha.slice(0, 8)}](${comparison.url})`, "",
|
||||
...platforms, ""].join("\n");
|
||||
}
|
||||
|
||||
async function writeCompareSummary(environment: NodeJS.ProcessEnv, comparison: CompareReviewPresentation, previewUrl: string, expiresAt: number | null, inputs: CiReportInput[]) {
|
||||
async function writeCompareSummary(environment: NodeJS.ProcessEnv, comparison: CompareReviewPresentation, previewUrl: string, inputs: CiReportInput[]) {
|
||||
const path = environment.GITHUB_STEP_SUMMARY;
|
||||
if (!path) return;
|
||||
await appendFile(path, renderCompareSummary(comparison, previewUrl, expiresAt, inputs));
|
||||
await appendFile(path, renderCompareSummary(comparison, previewUrl, inputs));
|
||||
}
|
||||
|
||||
type HostedReportInput = { zip: Uint8Array; sha256: string; file: string; query: string };
|
||||
@@ -427,12 +443,53 @@ export const HOSTING_ALIAS = /^[a-z0-9][a-z0-9-]{0,38}[a-z0-9]$/;
|
||||
export const HOSTED_TOKEN = /^[a-z2-7]{32}$/;
|
||||
|
||||
/**
|
||||
* Seal the report ZIPs, deploy the exported Viewer around them to EAS Hosting, and verify the live bytes.
|
||||
* Shared by the PR preview (`ci:deploy`) and standalone exploration reports; it knows nothing about GitHub.
|
||||
* Each report's manifest at `p/<token>/targets/<file>.json` and every asset once at `p/<token>/assets/<sha256>.<ext>`
|
||||
* (targets that share a screenshot share its file), under the export's client directory. Every asset's bytes must hash
|
||||
* to its name. `deployment` stamps every manifest, so a check can tell this deployment from one an alias still serves.
|
||||
* Returns, per report, the manifest written and one asset to fetch back.
|
||||
*/
|
||||
async function deploySealedReports(options: {
|
||||
reports: HostedReportInput[]; reportDirectory: string; listing?: ReturnType<typeof previewReportListing>; project: string; owner?: string;
|
||||
ownerHint: string; projectHint: string; expiresAt: number | null; exportPath: string; environment: NodeJS.ProcessEnv; run: typeof defaultRun;
|
||||
async function writeReportFiles(client: string, token: string, reports: HostedReportInput[], deployment: string): Promise<Array<{ manifest: string; asset?: string }>> {
|
||||
await writeFile(join(client, "robots.txt"), PREVIEW_ROBOTS);
|
||||
const root = join(client, "p", token);
|
||||
await mkdir(join(root, "targets"), { recursive: true });
|
||||
await mkdir(join(root, "assets"), { recursive: true });
|
||||
// Each asset's size as written: a target that shares the file must list the same size in its manifest.
|
||||
const assets = new Map<string, number>();
|
||||
const written: Array<{ manifest: string; asset?: string }> = [];
|
||||
for (const report of reports) {
|
||||
const loaded = await loadReport(report.zip);
|
||||
if (!loaded) throw deployError("REPORT_ZIP_FAILED", "The report ZIP is not a report the hosted Viewer can open.", "Pass the report directory or ZIP that Explore wrote.");
|
||||
const manifest = manifestBody(loaded, deployment);
|
||||
await writeFile(join(root, "targets", `${report.file}.json`), manifest);
|
||||
let first: string | undefined;
|
||||
for (const [name, entry] of loaded.entries) {
|
||||
const sha = PREVIEW_ASSET.exec(name)?.[1];
|
||||
if (!sha) continue;
|
||||
first ??= name;
|
||||
const bad = () => deployError("REPORT_ZIP_FAILED", `The report's ${name} is unreadable, larger than ${MAX_ASSET_BYTES / 1024 / 1024} MiB, or does not match its name.`,
|
||||
"Capture the report again; its screenshots are named by their SHA-256.");
|
||||
if (assets.has(name)) {
|
||||
if (assets.get(name) !== entry.size) throw bad();
|
||||
continue;
|
||||
}
|
||||
const bytes = await loaded.read(name, MAX_ASSET_BYTES);
|
||||
if (!bytes || bytes.byteLength !== entry.size || createHash("sha256").update(bytes).digest("hex") !== sha) throw bad();
|
||||
await writeFile(join(root, name), bytes);
|
||||
assets.set(name, bytes.byteLength);
|
||||
}
|
||||
written.push({ manifest, ...(first ? { asset: first } : {}) });
|
||||
}
|
||||
return written;
|
||||
}
|
||||
|
||||
/**
|
||||
* Write the report ZIPs as static files under the token, deploy the exported Viewer around them to EAS Hosting, and
|
||||
* verify what the Viewer opens. Shared by the PR preview (`ci:deploy`) and standalone reports; it knows nothing about GitHub.
|
||||
*/
|
||||
async function deployReports(options: {
|
||||
/** With `listing`, one entry per report in the same order. */
|
||||
reports: HostedReportInput[]; listing?: ListingTarget[]; project: string; owner?: string;
|
||||
ownerHint: string; projectHint: string; exportPath: string; environment: NodeJS.ProcessEnv; run: typeof defaultRun;
|
||||
transport: typeof fetch; now: () => number; random: (bytes: number) => Uint8Array; onSecret?: (secret: string) => void; verifyTimeoutMs: number;
|
||||
/** `eas deploy --alias`: a fixed host that always serves the newest deployment, for links that must not change between runs. */
|
||||
alias?: string;
|
||||
@@ -440,11 +497,12 @@ async function deploySealedReports(options: {
|
||||
token?: string;
|
||||
sleep?: (milliseconds: number) => Promise<void>;
|
||||
}): Promise<HostedDeployment> {
|
||||
const { reports, reportDirectory, listing, project, environment, run, transport, now, random, expiresAt } = options;
|
||||
const token = options.token ?? base32(random(20)); const key = random(32);
|
||||
const { reports, project, environment, run, transport, now, random } = options;
|
||||
const token = options.token ?? base32(random(20));
|
||||
options.onSecret?.(token);
|
||||
// `eas deploy` reads the sealed .env through @expo/env, where any variable already in its own environment wins,
|
||||
// even an empty one: an inherited EXPLORE_PREVIEW_* would replace the sealed value and every route would 404.
|
||||
const listing = options.listing?.map((entry, index) => listedAt(entry, manifestPath(token, reports[index]!.file)));
|
||||
// `eas deploy` reads the deployment's .env through @expo/env, where any variable already in its own environment wins,
|
||||
// even an empty one: an inherited EXPLORE_PREVIEW_* would replace the deployment's value and every route would 404.
|
||||
const easEnvironment = { ...Object.fromEntries(Object.entries(environment).filter(([name]) => !name.startsWith("EXPLORE_PREVIEW_"))),
|
||||
CI: "1", EXPO_NO_TELEMETRY: "1" };
|
||||
// Run the pinned CLI through this Node binary: the deploy job has no node on PATH for spawned shebang scripts to rely on.
|
||||
@@ -454,14 +512,10 @@ async function deploySealedReports(options: {
|
||||
const work = await mkdtemp(join(tmpdir(), "explore-preview-"));
|
||||
try {
|
||||
await cp(options.exportPath, join(work, "dist"), { recursive: true });
|
||||
const sealedDirectory = join(work, "dist", "client", "_report", reportDirectory);
|
||||
await mkdir(sealedDirectory, { recursive: true });
|
||||
for (const report of reports) await writeFile(join(sealedDirectory, report.file), sealReport(report.zip, key, random(12)));
|
||||
const written = await writeReportFiles(join(work, "dist", "client"), token, reports, base32(random(10)));
|
||||
await writeFile(join(work, ".env"), [
|
||||
`EXPLORE_PREVIEW_TOKEN=${token}`,
|
||||
`EXPLORE_PREVIEW_KEY=${Buffer.from(key).toString("base64")}`,
|
||||
...(expiresAt === null ? [] : [`EXPLORE_PREVIEW_EXPIRES_AT=${new Date(expiresAt).toISOString()}`]),
|
||||
listing ? `EXPLORE_PREVIEW_REPORTS=${JSON.stringify(listing)}` : `EXPLORE_PREVIEW_REPORT=/_report/${reportDirectory}/${reports[0]!.file}`,
|
||||
listing ? `EXPLORE_PREVIEW_REPORTS=${JSON.stringify(listing)}` : `EXPLORE_PREVIEW_REPORT=${manifestPath(token, reports[0]!.file)}`,
|
||||
"",
|
||||
].join("\n"), { mode: 0o600 });
|
||||
|
||||
@@ -502,15 +556,15 @@ async function deploySealedReports(options: {
|
||||
if (aliasLimit) {
|
||||
throw deployError("PREVIEW_ALIAS_LIMIT", `EAS Hosting could not assign the alias ${options.alias}: ${aliasLimit[0]}`,
|
||||
`Delete the aliases of closed pull requests on @${owner}/${project} (eas deploy:alias:delete pr-<n> --non-interactive) or raise the account's plan, then rerun the deploy job.`,
|
||||
{ retryable: false, details: { project, owner, alias: options.alias, output: commandOutput(deploy, environment.EXPO_TOKEN) } });
|
||||
{ retryable: false, details: { project, owner, alias: options.alias, output: commandOutput(deploy, [environment.EXPO_TOKEN, token]) } });
|
||||
}
|
||||
process.stderr.write(`eas deploy attempt ${attempt} of ${DEPLOY_ATTEMPTS} failed (exit ${deploy.status}):\n${commandOutput(deploy, environment.EXPO_TOKEN)}\n`);
|
||||
process.stderr.write(`eas deploy attempt ${attempt} of ${DEPLOY_ATTEMPTS} failed (exit ${deploy.status}):\n${commandOutput(deploy, [environment.EXPO_TOKEN, token])}\n`);
|
||||
if (attempt < DEPLOY_ATTEMPTS) await sleep(DEPLOY_RETRY_DELAYS_MS[attempt - 1] ?? DEPLOY_RETRY_DELAYS_MS.at(-1)!);
|
||||
}
|
||||
if (!deploymentUrl) {
|
||||
throw deployError("PREVIEW_DEPLOY_FAILED", `EAS Hosting deployment failed ${DEPLOY_ATTEMPTS} times: ${lastLine(deploy.stderr || deploy.stdout)}`,
|
||||
"Check the EAS Hosting status for the preview project and rerun the deploy job; the eas output of every attempt is in the job log.",
|
||||
{ retryable: true, details: { project, owner, attempts: DEPLOY_ATTEMPTS, output: commandOutput(deploy, environment.EXPO_TOKEN) } });
|
||||
{ retryable: true, details: { project, owner, attempts: DEPLOY_ATTEMPTS, output: commandOutput(deploy, [environment.EXPO_TOKEN, token]) } });
|
||||
}
|
||||
const aliasUrl = options.alias ? hostedOrigin(deployment.aliases?.find(candidate => candidate.name === options.alias)?.url) : undefined;
|
||||
if (options.alias && !aliasUrl) {
|
||||
@@ -518,7 +572,7 @@ async function deploySealedReports(options: {
|
||||
"Check the deployment's aliases in the EAS Hosting dashboard and rerun.", { retryable: true, details: { project, owner, alias: options.alias } });
|
||||
}
|
||||
const verify = (origin: string, alias = false) => verifyDeployment({ origin, token, transport, now, timeoutMs: options.verifyTimeoutMs, alias,
|
||||
reports: reports.map(report => ({ query: report.query, sha256: report.sha256, bytes: report.zip.byteLength })),
|
||||
reports: reports.map((report, index) => ({ query: report.query, ...written[index]! })),
|
||||
...(listing ? { listing: JSON.stringify(listing.map(({ path: _path, ...rest }) => rest)) } : {}) });
|
||||
const seconds = (milliseconds: number) => `${Math.round(milliseconds / 1000)} s after eas deploy returned`;
|
||||
const served = await verify(deploymentUrl.origin);
|
||||
@@ -539,7 +593,7 @@ async function deploySealedReports(options: {
|
||||
}
|
||||
}
|
||||
const previewUrl = `${linkOrigin}/p/${token}`;
|
||||
return { previewUrl, expiresAt: expiresAt === null ? null : new Date(expiresAt).toISOString(), deploymentId: deployment.identifier!, deploymentUrl: deploymentUrl.origin,
|
||||
return { previewUrl, expiresAt: null, deploymentId: deployment.identifier!, deploymentUrl: deploymentUrl.origin,
|
||||
...(aliasUrl ? { aliasUrl: aliasUrl.origin } : {}), project, owner };
|
||||
} finally {
|
||||
await rm(work, { recursive: true, force: true });
|
||||
@@ -554,7 +608,6 @@ export type ExplorationDeployOptions = {
|
||||
project: string;
|
||||
owner?: string;
|
||||
/** Days until the hosted link stops serving the report; null never expires. */
|
||||
expiresAfterDays: number | null;
|
||||
exportPath?: string;
|
||||
environment?: NodeJS.ProcessEnv;
|
||||
run?: typeof defaultRun;
|
||||
@@ -586,21 +639,20 @@ export async function deployExplorationReport(options: ExplorationDeployOptions)
|
||||
const random = options.random ?? (bytes => new Uint8Array(randomBytes(bytes)));
|
||||
const now = options.now ?? Date.now;
|
||||
const sha256 = createHash("sha256").update(zip).digest("hex");
|
||||
const reportDirectory = base32(random(10));
|
||||
const target = options.platform ? platformTarget(options.platform) : undefined;
|
||||
const file = target ? `${target.id}.zip.enc` : "report.zip.enc";
|
||||
const hosted = await deploySealedReports({ reports: [{ zip, sha256, file, query: target ? targetQuery(target) : "" }], reportDirectory,
|
||||
...(target ? { listing: [listingEntry(target, `/_report/${reportDirectory}/${file}`)] } : {}), project: options.project,
|
||||
const file = target ? target.id : "report";
|
||||
const hosted = await deployReports({ reports: [{ zip, sha256, file, query: target ? targetQuery(target) : "" }],
|
||||
...(target ? { listing: [listingEntry(target)] } : {}), project: options.project,
|
||||
...(options.owner ? { owner: options.owner } : {}), ownerHint: "Pass --owner with the Expo account that should host the report.",
|
||||
projectHint: "Give this EAS login permission to create projects under the owner, or pass --project with an existing slug.",
|
||||
expiresAt: options.expiresAfterDays === null ? null : now() + options.expiresAfterDays * 86_400_000, exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}),
|
||||
exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}),
|
||||
transport: options.transport ?? fetch, now, random, ...(options.onSecret ? { onSecret: options.onSecret } : {}), verifyTimeoutMs: options.verifyTimeoutMs ?? 180_000,
|
||||
...(options.alias ? { alias: options.alias } : {}), ...(options.token ? { token: options.token } : {}) });
|
||||
return { ...hosted, reportSha256: sha256, reportBytes: zip.byteLength };
|
||||
}
|
||||
|
||||
export type FixturePreviewOptions = {
|
||||
/** Report ZIPs as a hosted preview serves them from report.zip, one per target (`platform` alone: the platform's target), with what the switch says of each. */
|
||||
/** Report ZIPs as Explore writes them, one per target (`platform` alone: the platform's target), with what the switch says of each. */
|
||||
reports: Array<{ platform: ExplorePlatform; target?: RunTarget; zipPath: string; changes?: number; device?: string }>;
|
||||
project: string;
|
||||
owner?: string;
|
||||
@@ -632,23 +684,44 @@ export async function deployFixturePreview(options: FixturePreviewOptions): Prom
|
||||
const exportPath = resolve(options.exportPath ?? PREVIEW_EXPORT_PATH);
|
||||
await assertExport(exportPath);
|
||||
const random = options.random ?? (bytes => new Uint8Array(randomBytes(bytes)));
|
||||
const reportDirectory = base32(random(10));
|
||||
const reports = await Promise.all(options.reports.map(async report => {
|
||||
const zip = new Uint8Array(await readFile(report.zipPath));
|
||||
const target = report.target ?? platformTarget(report.platform);
|
||||
return { ...report, target, zip, sha256: createHash("sha256").update(zip).digest("hex"), file: `${target.id}.zip.enc` };
|
||||
return { ...report, target, zip, sha256: createHash("sha256").update(zip).digest("hex"), file: target.id };
|
||||
}));
|
||||
const listing = reports.map(report => listingEntry(report.target, `/_report/${reportDirectory}/${report.file}`, report.changes, report.device));
|
||||
return deploySealedReports({
|
||||
const listing = reports.map(report => listingEntry(report.target, report.changes, report.device));
|
||||
return deployReports({
|
||||
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: targetQuery(report.target) })),
|
||||
reportDirectory, listing, project: options.project, ...(options.owner ? { owner: options.owner } : {}),
|
||||
listing, project: options.project, ...(options.owner ? { owner: options.owner } : {}),
|
||||
ownerHint: "Pass --owner with the Expo account that holds the preview project.",
|
||||
projectHint: "Give EXPO_TOKEN's account permission to create projects, or pass --project with an existing slug.",
|
||||
expiresAt: null, exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}), transport: options.transport ?? fetch, now: options.now ?? Date.now, random,
|
||||
exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}), transport: options.transport ?? fetch, now: options.now ?? Date.now, random,
|
||||
...(options.onSecret ? { onSecret: options.onSecret } : {}), verifyTimeoutMs: options.verifyTimeoutMs ?? 180_000, alias: options.alias,
|
||||
...(options.token ? { token: options.token } : {}) });
|
||||
}
|
||||
|
||||
/**
|
||||
* The reports a fixture directory holds (scripts/refresh-viewer-preview-fixtures.sh writes it): its reports.json, as a
|
||||
* hosted preview's /reports.json lists them, with `<target>.zip` beside it for each entry. An entry without a target,
|
||||
* from fixtures refreshed before targets, is its platform's target with `<platform>.zip`.
|
||||
*/
|
||||
export function fixtureReports(listing: unknown, directory: string): FixturePreviewOptions["reports"] {
|
||||
const invalid = () => previewError("PREVIEW_REPORTS_INVALID", "The fixtures' reports.json does not list valid reports",
|
||||
"Refresh the fixtures with scripts/refresh-viewer-preview-fixtures.sh.");
|
||||
if (!Array.isArray(listing)) throw invalid();
|
||||
return listing.map((entry: unknown) => {
|
||||
if (typeof entry !== "object" || entry === null) throw invalid();
|
||||
const { platform, target: id, label, changes, device } = entry as Record<string, unknown>;
|
||||
if (platform !== "ios" && platform !== "android") throw invalid();
|
||||
const target = id === undefined ? undefined : readTarget({ id, platform, label });
|
||||
if (id !== undefined && !target) throw invalid();
|
||||
return {
|
||||
platform, ...(target ? { target } : {}), zipPath: join(directory, `${target?.id ?? platform}.zip`),
|
||||
...(typeof changes === "number" ? { changes } : {}), ...(typeof device === "string" ? { device } : {}),
|
||||
};
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* Report ZIPs on this machine behind one token (`capture:review --upload`, `report:upload`), one per target: the same
|
||||
* sealed deployment as a PR preview, from ZIPs instead of GitHub artifacts, with the local EAS login or EXPO_TOKEN.
|
||||
@@ -656,7 +729,7 @@ export async function deployFixturePreview(options: FixturePreviewOptions): Prom
|
||||
export async function deployLocalReports(options: {
|
||||
/** One per target; an entry without `target` is its platform's target, as before targets. */
|
||||
reports: Array<{ platform: ExplorePlatform; target?: RunTarget; zip: Uint8Array; changes?: number; device?: string }>;
|
||||
project: string; owner?: string; expiresAfterDays: number | null;
|
||||
project: string; owner?: string;
|
||||
/** What to change when the owner or project is not usable; defaults name report.preview in config.yaml. */
|
||||
ownerHint?: string; projectHint?: string;
|
||||
exportPath?: string; environment?: NodeJS.ProcessEnv; run?: CommandRunner; sleep?: (milliseconds: number) => Promise<void>;
|
||||
@@ -668,19 +741,18 @@ export async function deployLocalReports(options: {
|
||||
await assertExport(exportPath);
|
||||
const now = options.now ?? Date.now;
|
||||
const random = options.random ?? (bytes => new Uint8Array(randomBytes(bytes)));
|
||||
const reportDirectory = base32(random(10));
|
||||
// Always listed, even alone: the Worker takes an unlisted report for iOS, so an Android one would be mislabelled.
|
||||
const reports = options.reports.map(report => {
|
||||
const target = report.target ?? platformTarget(report.platform);
|
||||
return { ...report, target, sha256: createHash("sha256").update(report.zip).digest("hex"), file: `${target.id}.zip.enc` };
|
||||
return { ...report, target, sha256: createHash("sha256").update(report.zip).digest("hex"), file: target.id };
|
||||
});
|
||||
const listing = reports.map(report => listingEntry(report.target, `/_report/${reportDirectory}/${report.file}`, report.changes, report.device));
|
||||
return deploySealedReports({
|
||||
const listing = reports.map(report => listingEntry(report.target, report.changes, report.device));
|
||||
return deployReports({
|
||||
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: targetQuery(report.target) })),
|
||||
reportDirectory, listing, project: options.project, ...(options.owner ? { owner: options.owner } : {}),
|
||||
listing, project: options.project, ...(options.owner ? { owner: options.owner } : {}),
|
||||
ownerHint: options.ownerHint ?? "Set report.preview.owner in .expo-explore/config.yaml to the account that should hold the hosted reports.",
|
||||
projectHint: options.projectHint ?? "Make sure your Expo account can create projects, or set report.preview.project to an existing project you can deploy to.",
|
||||
expiresAt: options.expiresAfterDays === null ? null : now() + options.expiresAfterDays * 86_400_000, exportPath, environment,
|
||||
exportPath, environment,
|
||||
run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}), transport: options.transport ?? fetch, now, random,
|
||||
verifyTimeoutMs: options.verifyTimeoutMs ?? 180_000 });
|
||||
}
|
||||
@@ -754,7 +826,7 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
|
||||
}
|
||||
|
||||
/** The deployment must serve the Viewer and the exact reports at the token, and nothing anywhere else. */
|
||||
async function verifyDeployment(check: { origin: string; token: string; reports: Array<{ query: string; sha256: string; bytes: number }>; listing?: string;
|
||||
async function verifyDeployment(check: { origin: string; token: string; reports: Array<{ query: string; manifest: string; asset?: string }>; listing?: string;
|
||||
transport: typeof fetch; now: () => number; timeoutMs: number; alias?: boolean }): Promise<{ liveAfterMs: number }> {
|
||||
const get = async (path: string, accept = "*/*") => {
|
||||
try {
|
||||
@@ -767,12 +839,18 @@ async function verifyDeployment(check: { origin: string; token: string; reports:
|
||||
};
|
||||
// What the token serves differs from what was deployed: a listing or report that does not match, or undefined.
|
||||
const mismatch = async (): Promise<CiError | undefined> => {
|
||||
// What the Viewer opens: each target's manifest, exactly as written (its deployment stamp tells this deployment from
|
||||
// the one an alias still points at, even for an unchanged report), and one of its screenshots, a static file.
|
||||
for (const expected of check.reports) {
|
||||
const report = await get(`/p/${check.token}/report.zip${expected.query}`);
|
||||
const bytes = report.status === 200 ? new Uint8Array(await report.arrayBuffer()) : new Uint8Array();
|
||||
if (report.status !== 200 || bytes.byteLength !== expected.bytes || createHash("sha256").update(bytes).digest("hex") !== expected.sha256) {
|
||||
return deployError("PREVIEW_VERIFY_FAILED", "The hosted preview did not serve the exact report that was deployed.",
|
||||
"Rerun the deploy job; the deployment's sealed key or ciphertext did not match.", { details: { status: report.status, report: expected.query } });
|
||||
const manifest = await get(`/p/${check.token}/manifest.json${expected.query}`);
|
||||
const body = manifest.status === 200 ? await manifest.text() : "";
|
||||
const served = expected.asset ? await get(`/p/${check.token}/${expected.asset}`) : undefined;
|
||||
const assetBytes = served?.status === 200 ? new Uint8Array(await served.arrayBuffer()) : new Uint8Array();
|
||||
const sha = expected.asset ? PREVIEW_ASSET.exec(expected.asset)?.[1] : undefined;
|
||||
if (body !== expected.manifest || (sha && createHash("sha256").update(assetBytes).digest("hex") !== sha)) {
|
||||
return deployError("PREVIEW_VERIFY_FAILED", "The hosted preview did not serve the report's manifest and screenshots, which the Viewer opens.",
|
||||
"Rerun the deploy job; if it keeps failing, inspect the deployment in the EAS Hosting dashboard.",
|
||||
{ details: { status: manifest.status, ...(served ? { assetStatus: served.status } : {}), report: expected.query } });
|
||||
}
|
||||
}
|
||||
if (check.listing !== undefined) {
|
||||
@@ -809,11 +887,16 @@ async function verifyDeployment(check: { origin: string; token: string; reports:
|
||||
if (api.status !== 200 || !(api.headers.get("content-type") ?? "").startsWith("application/json")) {
|
||||
throw deployError("PREVIEW_VERIFY_FAILED", `The hosted preview did not answer the agent API (HTTP ${api.status}).`, "Rerun the deploy job; if the deployment keeps failing verification, inspect it in the EAS Hosting dashboard.", { retryable: true });
|
||||
}
|
||||
const robots = await get("/robots.txt");
|
||||
if (robots.status !== 200 || await robots.text() !== PREVIEW_ROBOTS) {
|
||||
throw deployError("PREVIEW_VERIFY_FAILED", `The hosted preview did not serve its robots.txt (HTTP ${robots.status}), which keeps crawlers away from the screenshots.`,
|
||||
"Rerun the deploy job; if it keeps failing, inspect the deployment in the EAS Hosting dashboard.", { retryable: true });
|
||||
}
|
||||
// The deployment itself serves exactly what was deployed or it failed; the alias was checked while it was polled.
|
||||
if (!check.alias) { const failure = await mismatch(); if (failure) throw failure; }
|
||||
const other = check.token.endsWith("a") ? `${check.token.slice(0, -1)}b` : `${check.token.slice(0, -1)}a`;
|
||||
// Errors name each probe by its shape: the near-miss token differs from the real one in its last character only.
|
||||
for (const [path, shape] of [["/", "/"], [`/p/${other}`, "/p/<wrong token>"], [`/p/${other}/report.zip`, "/p/<wrong token>/report.zip"],
|
||||
for (const [path, shape] of [["/", "/"], [`/p/${other}`, "/p/<wrong token>"], [`/p/${other}/manifest.json`, "/p/<wrong token>/manifest.json"],
|
||||
[`/p/${check.token}/viewer/index.html`, "/p/<token>/viewer/index.html"]] as const) {
|
||||
const response = await get(path);
|
||||
if (response.status !== 404) throw deployError("PREVIEW_VERIFY_FAILED", `The hosted preview answered HTTP ${response.status} without a valid token at ${shape}.`,
|
||||
|
||||
@@ -0,0 +1,75 @@
|
||||
/**
|
||||
* What a hosted or local report page serves the Viewer instead of the whole ZIP: the manifest (the report's metadata
|
||||
* file verbatim plus every asset's size) and each asset on request. `ci:deploy` writes them as a hosted preview's
|
||||
* static files, the local report server answers them from the ZIP, and the preview Worker reads the manifest back.
|
||||
*/
|
||||
import { reportFromJson, type LoadedReport } from "./agent-api.js";
|
||||
|
||||
/** The manifest format the Viewer accepts (viewer/src/utils/artifact-report.ts). */
|
||||
export const PREVIEW_MANIFEST_FORMAT = "explore.preview-manifest/1";
|
||||
/** `assets/<sha256>.<ext>`, the only asset names a report page serves. */
|
||||
export const PREVIEW_ASSET = /^assets\/([a-f0-9]{64})\.(png|jpg|mp4)$/;
|
||||
export const ASSET_TYPES: Record<string, string> = { png: "image/png", jpg: "image/jpeg", mp4: "video/mp4" };
|
||||
export const MAX_ASSET_BYTES = 32 * 1024 * 1024;
|
||||
|
||||
/**
|
||||
* The metadata file verbatim plus the size of every asset, so the Viewer opens the report before any screenshot.
|
||||
* Directory records are not assets. `deployment` names the hosted deployment that wrote it, so a check can tell a new
|
||||
* deployment of an unchanged report from the one an alias still points at.
|
||||
*/
|
||||
export function manifestBody(loaded: LoadedReport, deployment?: string): string {
|
||||
const entries: Record<string, number> = {};
|
||||
for (const [name, entry] of loaded.entries) if (name.startsWith("assets/") && !name.endsWith("/")) entries[name] = entry.size;
|
||||
const stamp = deployment ? `"deployment":${JSON.stringify(deployment)},` : "";
|
||||
return `{"format":"${PREVIEW_MANIFEST_FORMAT}",${stamp}"file":"${loaded.file}","entries":${JSON.stringify(entries)},"report":${new TextDecoder().decode(loaded.raw)}}`;
|
||||
}
|
||||
|
||||
/** The largest metadata file the Viewer opens (`ARTIFACT_LIMITS.metadata` in viewer/src/utils/artifact-report.ts). */
|
||||
export const MAX_PREVIEW_METADATA_BYTES = 8 * 1024 * 1024;
|
||||
/** A manifest is the metadata file plus one size per asset; the Viewer refuses a larger one. */
|
||||
export const MAX_MANIFEST_BYTES = MAX_PREVIEW_METADATA_BYTES + 2 * 1024 * 1024;
|
||||
const REPORT_KEY = ',"report":';
|
||||
|
||||
/**
|
||||
* The report a manifest describes, reading its assets through `readAsset`; undefined when it is not a manifest of a report.
|
||||
* The metadata is parsed once and kept as the manifest's own bytes. `manifestBody` writes `report` last, so its bytes are
|
||||
* the text between `,"report":` and the closing brace; any other layout is parsed whole and re-serialized.
|
||||
*/
|
||||
export function reportFromManifest(bytes: Uint8Array, readAsset: LoadedReport["read"]): LoadedReport | undefined {
|
||||
if (bytes.byteLength > MAX_MANIFEST_BYTES) return undefined;
|
||||
const text = new TextDecoder().decode(bytes);
|
||||
let header: unknown, report: unknown, raw: Uint8Array | undefined;
|
||||
const at = text.indexOf(REPORT_KEY);
|
||||
// A string cannot hold `,"report":` (its quotes are escaped); a nested key can, and then the header before it is not JSON on its own.
|
||||
if (at !== -1 && text.endsWith("}") && /^[\x20-\x7e]*$/.test(text.slice(0, at))) {
|
||||
try {
|
||||
header = JSON.parse(`${text.slice(0, at)}}`);
|
||||
report = JSON.parse(text.slice(at + REPORT_KEY.length, -1));
|
||||
raw = bytes.subarray(at + REPORT_KEY.length, bytes.byteLength - 1);
|
||||
} catch { header = undefined; }
|
||||
}
|
||||
if (raw === undefined) {
|
||||
try { header = JSON.parse(text); } catch { return undefined; }
|
||||
report = (header as { report?: unknown } | null)?.report;
|
||||
raw = new TextEncoder().encode(JSON.stringify(report));
|
||||
}
|
||||
if (!header || typeof header !== "object") return undefined;
|
||||
const { format, file, entries } = header as { format?: unknown; file?: unknown; entries?: unknown };
|
||||
if (format !== PREVIEW_MANIFEST_FORMAT || (file !== "review.json" && file !== "exploration.json")) return undefined;
|
||||
if (!entries || typeof entries !== "object" || Array.isArray(entries) || !report || typeof report !== "object") return undefined;
|
||||
const sizes = new Map<string, { size: number }>();
|
||||
for (const [name, size] of Object.entries(entries)) {
|
||||
if (!PREVIEW_ASSET.test(name) || !Number.isSafeInteger(size) || (size as number) < 0) return undefined;
|
||||
sizes.set(name, { size: size as number });
|
||||
}
|
||||
if (raw.byteLength > MAX_PREVIEW_METADATA_BYTES) return undefined;
|
||||
return reportFromJson(file, raw, report, sizes, (name, limit) => (sizes.has(name) ? readAsset(name, limit) : Promise.resolve(undefined)));
|
||||
}
|
||||
|
||||
/** One asset of the report with its content type; undefined when the report has no such asset. */
|
||||
export async function previewAsset(loaded: LoadedReport, path: string): Promise<{ bytes: Uint8Array; type: string } | undefined> {
|
||||
const match = PREVIEW_ASSET.exec(path);
|
||||
if (!match || !loaded.entries.has(path)) return undefined;
|
||||
const bytes = await loaded.read(path, MAX_ASSET_BYTES);
|
||||
return bytes ? { bytes, type: ASSET_TYPES[match[2]!]! } : undefined;
|
||||
}
|
||||
@@ -15,7 +15,7 @@ export type ViewerDeepLinks = {
|
||||
surface: (surfaceId: string) => string;
|
||||
};
|
||||
|
||||
/** A hosted preview: the Viewer and its decrypted report served from one token-gated EAS Hosting deployment. */
|
||||
/** A hosted preview: the Viewer and its report served from one token-gated EAS Hosting deployment. */
|
||||
export type PreviewLinks = ViewerDeepLinks & {
|
||||
/** Epoch milliseconds after which the deployment's Worker stops serving the report; null when the link does not expire. */
|
||||
expiresAt: number | null;
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/**
|
||||
* Reads the sealed report archive once it is decrypted: a ZIP written by `zipReportDirectory`
|
||||
* Reads a report ZIP (deploy, the local report server, the agent API): a ZIP written by `zipReportDirectory`
|
||||
* (review.json or exploration.json deflated, assets/<sha256>.png stored). Only the central directory
|
||||
* is trusted for sizes and offsets, every offset is bounds-checked, and entries are inflated on demand.
|
||||
*/
|
||||
|
||||
@@ -3,4 +3,4 @@
|
||||
* controller (`--package-version`), the daemon health check, and the screenshot diff tool must
|
||||
* all be this version; each caller checks it by exact equality.
|
||||
*/
|
||||
export const AGENT_DEVICE_VERSION = "0.21.28";
|
||||
export const AGENT_DEVICE_VERSION = "0.21.29-nightly.20261018.74";
|
||||
@@ -21,7 +21,7 @@ export type ControllerName = "agent-device" | "argent";
|
||||
/** Each controller's npm release, the file Explore runs from it, and the integrity npm publishes for it. */
|
||||
export const CONTROLLER_PACKAGES: Record<ControllerName, { name: string; version: string; bin: string; integrity: string }> = {
|
||||
"agent-device": { name: "agent-device", version: AGENT_DEVICE_VERSION, bin: "bin/agent-device.mjs",
|
||||
integrity: "sha512-uGEENVhPzSpIACrVlt16O1mloODWJyAemTCT0boDb4L006JXN2rG747u1TRoQJudOpdP/Pm2urxNRHeECLMLfg==" },
|
||||
integrity: "sha512-7+ajWLr0J+8iLZ9q11ERbj6U14mC20umBK5BQQdw5aERA79yeXc3Ze6KmtvnILnWjEtoVkYQsXQasL8RL6Uatw==" },
|
||||
argent: { name: "@swmansion/argent", version: ARGENT_VERSION, bin: "dist/cli.js",
|
||||
integrity: "sha512-XXWlWZJlHKqnAvNx3RDhuiVFQOPqh5EDB76+mFAyqC2mutC6irzw03+M/6S/WQ+Dzz2IYOkEfOzQnOOdhrGgJg==" },
|
||||
};
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { Buffer } from "node:buffer";
|
||||
import { createRequire } from "node:module";
|
||||
import { inflateSync } from "node:zlib";
|
||||
import { STATUS_BAR_BAND_PERCENT } from "../contracts/capture.js";
|
||||
|
||||
@@ -7,6 +8,22 @@ export { STATUS_BAR_BAND_PERCENT };
|
||||
/** Decoded RGBA pixels of one frame, as pngjs returns them (four bytes per pixel, row by row). */
|
||||
export type DecodedFrame = { width: number; height: number; data: Buffer };
|
||||
|
||||
/**
|
||||
* Whether a screenshot is a single flat colour: a capture-protected screen (black on Android), or a display that is lit
|
||||
* but not drawn (an iPhone Duo's inner panel after its first fold on EAS). Every 97th pixel is enough to tell.
|
||||
*/
|
||||
export function solidColour(png: Buffer): boolean {
|
||||
let frame: DecodedFrame;
|
||||
try { frame = createRequire(import.meta.url.replace(/\?.*$/, ""))("pngjs").PNG.sync.read(png, { checkCRC: false }) as DecodedFrame; }
|
||||
catch { return false; }
|
||||
const { data } = frame;
|
||||
if (data.length < 4) return false;
|
||||
for (let offset = 0; offset + 3 < data.length; offset += 4 * 97) {
|
||||
if (data[offset] !== data[0] || data[offset + 1] !== data[1] || data[offset + 2] !== data[2]) return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* Whether a coordinate tap at normalized height `y` would act on a changed frame. Differences inside
|
||||
* the status-bar band are ignored only when the tap lands below the band: a tap inside it acts on
|
||||
|
||||
@@ -11,8 +11,8 @@
|
||||
# secrets: inherit
|
||||
#
|
||||
# Call it once per workflow run: a called workflow shares its caller's run, and its artifact names come from the run.
|
||||
# The report links are written to the run's summary. For a release, pass scope: all to capture every screen,
|
||||
# and expires-in: never to keep the hosted link (report.preview.hosting: eas) working.
|
||||
# The report links are written to the run's summary. For a release, pass scope: all to capture every screen. A hosted
|
||||
# link (report.preview.hosting: eas) lasts as long as its EAS Hosting deployment; expires-in is accepted and ignored.
|
||||
name: Expo Explore compare
|
||||
on:
|
||||
workflow_dispatch:
|
||||
@@ -20,13 +20,13 @@ on:
|
||||
base: { description: 'Base: a branch, tag or commit SHA', required: true }
|
||||
head: { description: 'Head: a branch, tag or commit SHA', required: true }
|
||||
scope: { description: 'changes (screens whose source changed) or all; default: exploration.scope in config.yaml', required: false, default: '' }
|
||||
expires-in: { description: 'Hosted link lifetime such as 30d, or never; default: report.preview.expiresAfter', required: false, default: '' }
|
||||
expires-in: { description: 'Ignored: kept for workflows that pass it. A hosted preview lasts as long as its EAS Hosting deployment.', required: false, default: '' }
|
||||
workflow_call:
|
||||
inputs:
|
||||
base: { description: 'Base: a branch, tag or commit SHA', required: true, type: string }
|
||||
head: { description: 'Head: a branch, tag or commit SHA', required: true, type: string }
|
||||
scope: { description: 'changes (screens whose source changed) or all; default: exploration.scope in config.yaml', required: false, type: string, default: '' }
|
||||
expires-in: { description: 'Hosted link lifetime such as 30d, or never; default: report.preview.expiresAfter', required: false, type: string, default: '' }
|
||||
expires-in: { description: 'Ignored: kept for workflows that pass it. A hosted preview lasts as long as its EAS Hosting deployment.', required: false, type: string, default: '' }
|
||||
permissions: {}
|
||||
env:
|
||||
# The exact @expo/explore release CI installs. expo-explore setup --workflows sets it.
|
||||
|
||||
@@ -3,7 +3,7 @@ import test from "node:test";
|
||||
import { createHash } from "node:crypto";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { readFile } from "node:fs/promises";
|
||||
import { BlobReader, BlobWriter, Uint8ArrayReader, ZipReader, ZipWriter } from "@zip.js/zip.js";
|
||||
import { BlobReader, BlobWriter, Uint8ArrayReader, ZipReader, ZipWriter, Uint8ArrayWriter } from "@zip.js/zip.js";
|
||||
import { chromium, expect as playwrightExpect } from "@playwright/test";
|
||||
import { PNG } from "pngjs";
|
||||
import { createBrowserVite } from "../helpers/browser-vite.mjs";
|
||||
@@ -54,6 +54,18 @@ async function archive(report = reportFixture(), extra = [], imageBytes = png) {
|
||||
return Buffer.from(await (await writer.close()).arrayBuffer());
|
||||
}
|
||||
|
||||
/** The report ZIP as the preview Worker reads it: entry bytes by name, and the manifest it answers with. */
|
||||
async function unzipped(bytes) {
|
||||
const reader = new ZipReader(new Uint8ArrayReader(new Uint8Array(bytes)), { useWebWorkers: false });
|
||||
const files = new Map();
|
||||
for (const entry of await reader.getEntries()) files.set(entry.filename, await entry.getData(new Uint8ArrayWriter()));
|
||||
await reader.close();
|
||||
const file = files.has("review.json") ? "review.json" : "exploration.json";
|
||||
const entries = Object.fromEntries([...files].filter(([name]) => name.startsWith("assets/")).map(([name, data]) => [name, data.length]));
|
||||
const manifest = `{"format":"explore.preview-manifest/1","file":"${file}","entries":${JSON.stringify(entries)},"report":${new TextDecoder().decode(files.get(file))}}`;
|
||||
return { files, manifest };
|
||||
}
|
||||
|
||||
/**
|
||||
* Serve `/r` like the hosted Viewer: the page alone, no report endpoint; the ZIP comes from the
|
||||
* reviewer. `reportIdentity: null` opens the bare page without a linked run.
|
||||
@@ -61,19 +73,36 @@ async function archive(report = reportFixture(), extra = [], imageBytes = png) {
|
||||
async function harness(t, bytes, { app = false, open = true, name = fileName, reportIdentity = identity,
|
||||
query = "&focus=modified&screen=home&inspect=diff", fault, preview } = {}) {
|
||||
const pagePath = preview ? `/p/${preview.token}` : "/r";
|
||||
// What the preview Worker serves from the decrypted ZIP: the manifest the Viewer opens, and each asset on request.
|
||||
const served = preview && bytes ? await unzipped(bytes) : undefined;
|
||||
// `archives` by query gives a target its own report; every other query gets `bytes`.
|
||||
const servedBy = Object.fromEntries(await Promise.all(Object.entries(preview?.archives ?? {}).map(async ([search, zip]) => [search, await unzipped(zip)])));
|
||||
const servedFor = search => servedBy[search] ?? served;
|
||||
const vite = await createBrowserVite(t, { configFile: false,
|
||||
root: fileURLToPath(new URL("../../viewer", import.meta.url)), logLevel: "error", esbuild: { jsx: "automatic" },
|
||||
server: { host: "127.0.0.1", port: 0 }, plugins: [{ name: "report-page-fixture", configureServer(server) {
|
||||
server.middlewares.use((request, response, next) => {
|
||||
const url = new URL(request.url, "http://localhost");
|
||||
// A preview deployment's Worker: the decrypted report behind the token, or the same 404 as any other path.
|
||||
if (preview && url.pathname === `${pagePath}/report.zip`) {
|
||||
if (preview && url.pathname === `${pagePath}/manifest.json`) {
|
||||
preview.requests = (preview.requests ?? 0) + 1;
|
||||
preview.queries = [...(preview.queries ?? []), url.search];
|
||||
if (preview.status && preview.status !== 200) { response.statusCode = preview.status; return response.end(preview.body ?? "Not found"); }
|
||||
response.setHeader("content-type", "application/zip");
|
||||
response.setHeader("content-length", String(bytes.length));
|
||||
return response.end(bytes);
|
||||
response.setHeader("content-type", "application/json");
|
||||
// A slow target (`delays` by query) keeps its manifest in flight while the reviewer moves on.
|
||||
// `padding` makes the manifest larger than the Viewer reads.
|
||||
const manifest = servedFor(url.search).manifest;
|
||||
const body = preview.padding ? " ".repeat(preview.padding) + manifest : manifest;
|
||||
return void setTimeout(() => response.end(body), preview.delays?.[url.search] ?? 0);
|
||||
}
|
||||
if (preview && url.pathname.startsWith(`${pagePath}/assets/`)) {
|
||||
// Screenshot URLs name no target: any report of the deployment may hold one.
|
||||
const name = url.pathname.slice(pagePath.length + 1);
|
||||
const asset = [served, ...Object.values(servedBy)].map(report => report.files.get(name)).find(Boolean);
|
||||
if (!asset) { response.statusCode = 404; return response.end("Not found"); }
|
||||
response.setHeader("content-type", "application/octet-stream");
|
||||
response.setHeader("content-length", String(asset.length));
|
||||
return response.end(asset);
|
||||
}
|
||||
if (preview?.listing && url.pathname === `${pagePath}/reports.json`) {
|
||||
response.setHeader("content-type", "application/json");
|
||||
@@ -243,6 +272,8 @@ test("choosing the report file opens it with the link's selection and keeps Modi
|
||||
await expect(page.locator("html")).toHaveAttribute("data-theme", "light");
|
||||
await page.getByRole("button", { name: "Screens", exact: true }).click();
|
||||
const screenshot = page.locator(".screens-page img[data-screenshot-src]").first();
|
||||
// The placeholder is the screenshot's size too, so wait for the screenshot itself.
|
||||
await expect(screenshot).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect.poll(() => screenshot.evaluate(image => image.naturalWidth)).toBe(32);
|
||||
const screenshotUrl = await screenshot.getAttribute("src");
|
||||
assert.match(page.url(), /#\/screens/);
|
||||
@@ -299,6 +330,8 @@ test("a reload and a later per-screen link reopen the dropped report from the br
|
||||
await expect(page.getByText("Greeting changed from Hello to Welcome", { exact: true })).toBeVisible();
|
||||
await page.getByRole("button", { name: "Screens", exact: true }).click();
|
||||
const screenshot = page.locator(".screens-page img[data-screenshot-src]").first();
|
||||
// The placeholder is the screenshot's size too, so wait for the screenshot itself.
|
||||
await expect(screenshot).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect.poll(() => screenshot.evaluate(image => image.naturalWidth)).toBe(32);
|
||||
// Comment links to one screen carry the same run identity, so they open without a new drop.
|
||||
await page.goto(`${origin}/r?${new URLSearchParams(identity)}&screen=home&inspect=diff`);
|
||||
@@ -402,15 +435,6 @@ test("a hosted preview link downloads the report from its own token route, opens
|
||||
await expect(shell).toContainText("This preview link is not valid, or its deployment was deleted");
|
||||
await expect(expired.page.locator(".report-drop-input")).toHaveCount(0);
|
||||
assert.deepEqual(expired.errors, []);
|
||||
|
||||
// A deployment past its sealed expiry still opens and says when the link expired.
|
||||
const gone = await harness(t, await archive(), { app: true, reportIdentity: null,
|
||||
preview: { ...preview, token: "cdefghijklmnopqrstuvwxyz23456723", status: 410, body: JSON.stringify({ error: "expired", expiredAt: "2030-01-01T00:00:00.000Z" }) } });
|
||||
const goneShell = gone.page.locator(".report-loading-shell");
|
||||
await expect(goneShell).toHaveAttribute("data-loading-status", "failed");
|
||||
await expect(goneShell).toContainText("This preview link expired on Jan 1, 2030. Download the report from the pull request or workflow run instead");
|
||||
await expect(gone.page.locator(".report-drop-input")).toHaveCount(0);
|
||||
assert.deepEqual(gone.errors, []);
|
||||
});
|
||||
|
||||
test("a hosted run of several targets opens the linked target and switches between all of them in config order", { timeout: 60_000 }, async t => {
|
||||
@@ -431,7 +455,7 @@ test("a hosted run of several targets opens the linked target and switches betwe
|
||||
const { page, errors } = await harness(t, await archive(report), { app: true, reportIdentity: null, preview, query: "&target=duo-open" });
|
||||
const button = page.getByRole("button", { name: "Device: iPhone Duo (open). Open another device's report" });
|
||||
await expect(button).toBeVisible();
|
||||
assert.deepEqual(preview.queries, ["?target=duo-open"], "the Viewer asks the Worker for the linked target's report");
|
||||
assert.equal(preview.queries[0], "?target=duo-open", "the Viewer asks the Worker for the linked target's report");
|
||||
await button.click();
|
||||
const items = page.getByRole("menu", { name: "Device" }).getByRole("menuitemradio");
|
||||
await expect(items).toHaveCount(4);
|
||||
@@ -439,11 +463,15 @@ test("a hosted run of several targets opens the linked target and switches betwe
|
||||
[["iPhone 17", "false"], ["iPhone Duo (closed)", "false"], ["iPhone Duo (open)", "true"], ["Android", "false"]]);
|
||||
await expect(items.nth(3)).toContainText("2 changes · Pixel 9 16");
|
||||
await expect(items.nth(1)).toContainText("Same review, other device");
|
||||
await page.evaluate(() => { window.__samePage = true; });
|
||||
await items.nth(3).click();
|
||||
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "android");
|
||||
const next = new URL(page.url());
|
||||
assert.equal(next.searchParams.get("target"), null, "a target named after its platform is linked as before targets");
|
||||
await expect.poll(() => preview.queries.at(-1)).toBe("?platform=android");
|
||||
// The switch stays on the page: the Worker is asked for the other target's manifest (the prefetch may already have), not for a new page.
|
||||
await expect.poll(() => preview.queries).toContain("?platform=android");
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
assert.equal(await page.evaluate(() => window.__samePage), true, "the switch stays on the page instead of reloading it");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
@@ -454,14 +482,196 @@ test("a hosted report from before targets still switches platforms by ?platform=
|
||||
const { page, errors } = await harness(t, await archive(report), { app: true, reportIdentity: null, preview, query: "&platform=android" });
|
||||
const button = page.getByRole("button", { name: "Platform: Android. Open another platform's report" });
|
||||
await expect(button).toBeVisible();
|
||||
assert.deepEqual(preview.queries, ["?platform=android"]);
|
||||
assert.equal(preview.queries[0], "?platform=android");
|
||||
await button.click();
|
||||
const items = page.getByRole("menu", { name: "Platform" }).getByRole("menuitemradio");
|
||||
assert.deepEqual(await items.evaluateAll(rows => rows.map(row => [row.querySelector(".menu-row-label")?.firstChild?.textContent, row.getAttribute("aria-checked")])),
|
||||
[["iOS", "false"], ["Android", "true"]]);
|
||||
await expect(items.nth(0)).toContainText("3 changes");
|
||||
await page.evaluate(() => { window.__samePage = true; });
|
||||
await items.nth(0).click();
|
||||
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "ios");
|
||||
await expect.poll(() => preview.queries).toContain("?platform=ios");
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
assert.equal(await page.evaluate(() => window.__samePage), true, "the switch stays on the page instead of reloading it");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
/** A two-platform deployment whose iOS manifest is slow, opened on Android with the platform menu ready. */
|
||||
async function slowSwitchHarness(t, token, delay) {
|
||||
const report = reportFixture();
|
||||
report.review.runtime = { ...report.review.runtime, platform: "android", platforms: ["ios", "android"] };
|
||||
const preview = { token, listing: [{ platform: "ios" }, { platform: "android" }], delays: { "?platform=ios": delay } };
|
||||
const opened = await harness(t, await archive(report), { app: true, reportIdentity: null, preview, query: "&platform=android" });
|
||||
await expect(opened.page.locator(".app-shell")).toBeVisible();
|
||||
const switchToIos = async () => {
|
||||
await opened.page.getByRole("button", { name: "Platform: Android. Open another platform's report" }).click();
|
||||
await opened.page.getByRole("menu", { name: "Platform" }).getByRole("menuitemradio").nth(0).click();
|
||||
await opened.page.waitForURL(url => new URL(url).searchParams.get("platform") === "ios");
|
||||
};
|
||||
return { ...opened, preview, switchToIos };
|
||||
}
|
||||
|
||||
test("a switch the prefetch joins keeps the report it shows open", { timeout: 60_000 }, async t => {
|
||||
// The switch starts the iOS download before the prefetch does; the prefetch then waits on the same download.
|
||||
const { page, errors, preview, switchToIos } = await slowSwitchHarness(t, "fghijklmnopqrstuvwxyz23456723456", 2500);
|
||||
await switchToIos();
|
||||
await expect(page.locator(".app-shell")).toBeVisible({ timeout: 10_000 });
|
||||
assert.equal(preview.queries.filter(query => query === "?platform=ios").length, 1, "the switch and the prefetch share one download");
|
||||
const screenshot = page.locator(".map-canvas img[data-screenshot-src]").first();
|
||||
await expect(screenshot).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect.poll(() => screenshot.evaluate(image => image.naturalWidth)).toBe(32);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("switching back to a prefetched target shows the screenshots it showed before, without decoding them again", { timeout: 60_000 }, async t => {
|
||||
const { page, errors, preview, switchToIos } = await slowSwitchHarness(t, "hijklmnopqrstuvwxyz2345672345672", 0);
|
||||
const screenshot = page.locator(".map-canvas img[data-screenshot-src]").first();
|
||||
await expect(screenshot).toHaveAttribute("data-screenshot-state", "ready");
|
||||
const shown = await screenshot.getAttribute("src");
|
||||
await expect.poll(() => preview.queries).toContain("?platform=ios");
|
||||
await page.waitForTimeout(250);
|
||||
await switchToIos();
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
await expect(screenshot).toHaveAttribute("data-screenshot-state", "ready");
|
||||
assert.equal(preview.queries.filter(query => query === "?platform=ios").length, 1, "the switch opens the prefetched report without a download");
|
||||
const created = await page.evaluate(() => window.createdUrls.length);
|
||||
await page.goBack();
|
||||
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "android");
|
||||
await expect(screenshot).toHaveAttribute("data-screenshot-state", "ready");
|
||||
assert.equal(await screenshot.getAttribute("src"), shown, "the Android report kept the Blob URL it was showing");
|
||||
assert.equal(await page.evaluate(url => window.revokedUrls.includes(url), shown), false);
|
||||
assert.equal(await page.evaluate(() => window.createdUrls.length), created, "nothing was decoded again");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("Forward onto a target still downloading keeps the preview link and its place in history", { timeout: 60_000 }, async t => {
|
||||
const { page, errors, switchToIos } = await slowSwitchHarness(t, "jklmnopqrstuvwxyz234567234567234", 3000);
|
||||
await page.evaluate(() => { window.location.hash = "#/map?inspect=diff"; });
|
||||
const androidUrl = page.url();
|
||||
await switchToIos();
|
||||
const iosUrl = page.url();
|
||||
await page.goBack();
|
||||
await page.waitForURL(androidUrl);
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
// iOS is not kept yet: its download is still in flight.
|
||||
await page.goForward();
|
||||
await page.waitForTimeout(200);
|
||||
assert.equal(page.url(), iosUrl, "Forward lands on the iOS link, not a rewritten /map");
|
||||
await expect(page.locator(".app-shell")).toBeVisible({ timeout: 10_000 });
|
||||
assert.equal(new URL(page.url()).pathname, new URL(iosUrl).pathname);
|
||||
assert.equal(new URL(page.url()).searchParams.get("platform"), "ios");
|
||||
await page.goBack();
|
||||
await page.waitForTimeout(200);
|
||||
assert.equal(page.url(), androidUrl, "Back restores the Android entry as it was");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a hosted manifest larger than the Viewer reads is refused before it is parsed", { timeout: 60_000 }, async t => {
|
||||
const preview = { token: "klmnopqrstuvwxyz2345672345672345", padding: 11 * 1024 * 1024 };
|
||||
const { page, errors } = await harness(t, await archive(), { app: true, reportIdentity: null, preview, query: "" });
|
||||
const shell = page.locator(".report-loading-shell");
|
||||
await expect(shell).toHaveAttribute("data-loading-status", "failed");
|
||||
await expect(shell).toContainText("This report's index is larger than the Viewer opens.");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("D, ⌥1–⌥8 and ` switch targets from the keyboard, and the other report opens at the same place", { timeout: 60_000 }, async t => {
|
||||
const report = reportFixture();
|
||||
report.review.runtime = { ...report.review.runtime, platform: "android", platforms: ["ios", "android"] };
|
||||
const ios = reportFixture();
|
||||
ios.review.runtime = { ...ios.review.runtime, platform: "ios", platforms: ["ios", "android"] };
|
||||
const preview = { token: "ijklmnopqrstuvwxyz23456723456723", listing: [{ platform: "ios" }, { platform: "android" }],
|
||||
archives: { "?platform=ios": await archive(ios) } };
|
||||
// An Apple keyboard, where ⌥ digits reach the page (Linux browsers keep Alt+1–8 for their tabs).
|
||||
const { page, errors } = await harness(t, await archive(report), { app: true, reportIdentity: null, preview,
|
||||
query: "&platform=android&focus=modified&screen=home&inspect=diff",
|
||||
fault: () => { Object.defineProperty(Navigator.prototype, "platform", { get: () => "MacIntel" }); } });
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
await expect.poll(() => new URL(page.url()).hash).toMatch(/^#\/map\/home\?/);
|
||||
const place = new URL(page.url()).hash;
|
||||
await page.evaluate(() => { window.__samePage = true; });
|
||||
const target = () => new URL(page.url()).searchParams.get("platform");
|
||||
|
||||
// ` returns to the last target; before there is one, it opens the next in the menu.
|
||||
await page.keyboard.press("Backquote");
|
||||
await expect.poll(target).toBe("ios");
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
const carried = new URL(page.url()).hash;
|
||||
assert.equal(carried.split("?")[0], place.split("?")[0], "the other report opens at the same canvas and route");
|
||||
assert.equal(new URLSearchParams(carried.split("?")[1]).get("inspect"), "diff");
|
||||
assert.equal(new URLSearchParams(carried.split("?")[1]).get("screen"), null, "a screen id belongs to one report");
|
||||
await expect(page.locator(".map-canvas .is-selected")).toHaveCount(1);
|
||||
await page.keyboard.press("Backquote");
|
||||
await expect.poll(target).toBe("android");
|
||||
|
||||
// D opens the menu, which prints each target's ⌥ key.
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
await page.keyboard.press("KeyD");
|
||||
const items = page.getByRole("menu", { name: "Platform" }).getByRole("menuitemradio");
|
||||
await expect(items).toHaveCount(2);
|
||||
assert.deepEqual(await items.evaluateAll(rows => rows.map(row => row.querySelector(".menu-row-shortcut")?.textContent)), ["⌥1", "⌥2"]);
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(items).toHaveCount(0);
|
||||
|
||||
await page.keyboard.press("Alt+Digit1");
|
||||
await expect.poll(target).toBe("ios");
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
// The shown target's own key does nothing.
|
||||
await page.keyboard.press("Alt+Digit1");
|
||||
await page.keyboard.press("Alt+Digit2");
|
||||
await expect.poll(target).toBe("android");
|
||||
assert.equal(await page.evaluate(() => window.__samePage), true, "every switch stays on the page");
|
||||
|
||||
await page.keyboard.press("Shift+Slash");
|
||||
const dialog = page.getByRole("dialog", { name: "Keyboard shortcuts" });
|
||||
await expect(dialog).toContainText("Another platform's report");
|
||||
await expect(dialog).toContainText("⌥1–⌥2");
|
||||
await expect(dialog).toContainText("Back to the last platform");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a target switch keeps the chosen appearance when the other report was captured in it, and its own otherwise", { timeout: 60_000 }, async t => {
|
||||
/** A report of `platform`, with every surface also captured in dark when `dark`. */
|
||||
const report = (platform, dark) => {
|
||||
const fixture = reportFixture();
|
||||
fixture.review.runtime = { ...fixture.review.runtime, platform, platforms: ["ios", "android"], ...(dark ? { colorSchemes: ["light", "dark"] } : {}) };
|
||||
if (dark) fixture.review.surfaces.push({ ...structuredClone(fixture.review.surfaces[0]), id: "home@dark", colorScheme: "dark" });
|
||||
return fixture;
|
||||
};
|
||||
const preview = { token: "klmnopqrstuvwxyz2345672345672345", listing: [{ platform: "ios" }, { platform: "android" }],
|
||||
archives: { "?platform=ios": await archive(report("ios", false)), "?platform=android": await archive(report("android", true)) } };
|
||||
const { page, errors } = await harness(t, await archive(report("android", true)), { app: true, reportIdentity: null, preview, query: "&platform=android" });
|
||||
const target = () => new URL(page.url()).searchParams.get("platform");
|
||||
const appearance = page.getByRole("button", { name: /^Appearance: / });
|
||||
await expect(appearance).toHaveText(/Light/);
|
||||
await page.keyboard.press("Shift+KeyT");
|
||||
await expect(appearance).toHaveText(/Dark/);
|
||||
// iOS was captured in light only: it shows light and offers no switch.
|
||||
await page.keyboard.press("Backquote");
|
||||
await expect.poll(target).toBe("ios");
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
await expect(appearance).toHaveCount(0);
|
||||
// Back on Android, the choice still holds.
|
||||
await page.keyboard.press("Backquote");
|
||||
await expect.poll(target).toBe("android");
|
||||
await expect(appearance).toHaveText(/Dark/);
|
||||
// A reload of the tab keeps it as well.
|
||||
await page.reload();
|
||||
await expect(appearance).toHaveText(/Dark/);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("going back during a switch shows the report the page was on, and the slow one does not replace it", { timeout: 60_000 }, async t => {
|
||||
const { page, errors, switchToIos } = await slowSwitchHarness(t, "ghijklmnopqrstuvwxyz234567234567", 3000);
|
||||
await switchToIos();
|
||||
await page.goBack();
|
||||
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "android");
|
||||
await expect(page.locator(".app-shell")).toBeVisible({ timeout: 1500 });
|
||||
await page.locator(".app-shell").evaluate(shell => { shell.dataset.kept = "true"; });
|
||||
await page.waitForTimeout(3500);
|
||||
assert.equal(new URL(page.url()).searchParams.get("platform"), "android");
|
||||
await expect(page.locator(".app-shell")).toHaveAttribute("data-kept", "true");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
@@ -471,10 +681,12 @@ test("report links name their target: ?target=, ?platform= from before targets,
|
||||
const api = window.archiveApi;
|
||||
const attempt = fn => { try { return fn(); } catch (error) { return `error: ${error.message}`; } };
|
||||
const preview = "http://x/p/abcdefghijklmnopqrstuvwxyz234567";
|
||||
const manifest = page => api.previewManifestUrl(api.previewToken(page), api.reportTarget(page));
|
||||
return {
|
||||
target: api.previewReportUrl(new URL(`${preview}?target=duo-open`)),
|
||||
platform: api.previewReportUrl(new URL(`${preview}?platform=android`)),
|
||||
none: api.previewReportUrl(new URL(preview)),
|
||||
target: manifest(new URL(`${preview}?target=duo-open`)),
|
||||
platform: manifest(new URL(`${preview}?platform=android`)),
|
||||
none: manifest(new URL(preview)),
|
||||
asset: api.previewAssetUrl("abcdefghijklmnopqrstuvwxyz234567", `assets/${"a".repeat(64)}.png`),
|
||||
both: attempt(() => api.reportTarget(new URL(`${preview}?target=duo-open&platform=ios`))),
|
||||
invalid: attempt(() => api.reportTarget(new URL(`${preview}?target=Duo`))),
|
||||
reserved: attempt(() => api.reportTarget(new URL(`${preview}?target=report`))),
|
||||
@@ -485,9 +697,11 @@ test("report links name their target: ?target=, ?platform= from before targets,
|
||||
};
|
||||
});
|
||||
assert.deepEqual(result, {
|
||||
target: "/p/abcdefghijklmnopqrstuvwxyz234567/report.zip?target=duo-open",
|
||||
platform: "/p/abcdefghijklmnopqrstuvwxyz234567/report.zip?platform=android",
|
||||
none: "/p/abcdefghijklmnopqrstuvwxyz234567/report.zip",
|
||||
target: "/p/abcdefghijklmnopqrstuvwxyz234567/manifest.json?target=duo-open",
|
||||
platform: "/p/abcdefghijklmnopqrstuvwxyz234567/manifest.json?platform=android",
|
||||
none: "/p/abcdefghijklmnopqrstuvwxyz234567/manifest.json",
|
||||
// A screenshot is a static file named by its content, the same for every target.
|
||||
asset: `/p/abcdefghijklmnopqrstuvwxyz234567/assets/${"a".repeat(64)}.png`,
|
||||
both: "error: This report link needs one target, such as ios or android.",
|
||||
invalid: "error: This report link needs one target, such as ios or android.",
|
||||
reserved: "error: This report link needs one target, such as ios or android.",
|
||||
|
||||
@@ -102,7 +102,7 @@ test("a recorded review opens on the real map and before/after evidence and surv
|
||||
await expect(page.locator(".collapsed-pr")).toContainText("PR #1");
|
||||
// The map is one card per screen; changed screens carry their diff status on the card.
|
||||
await expect(page.locator(".map-canvas .react-flow__node-screen")).toHaveCount(33);
|
||||
await expect(page.locator('.map-canvas .screen-screenshot-target[title="/games"]')).toBeVisible();
|
||||
await expect(page.locator('.map-canvas .screen-node-title[aria-label="Copy deep link /games"]')).toBeVisible();
|
||||
await expect(page.getByText("No report open")).toHaveCount(0);
|
||||
const menu = await openChangesMenu(page);
|
||||
// Changes lists the screens with something to see: the three with pixel changes, the added and the removed one.
|
||||
|
||||
@@ -127,6 +127,13 @@ async function expectMapScreenSelectionDimming(
|
||||
}));
|
||||
const hoverTargetCount = options.hoverTargetCount ?? 1;
|
||||
expect(hoverableDimmedIndexes.length).toBeGreaterThanOrEqual(hoverTargetCount);
|
||||
// A card fades through its frame's --map-card-opacity (the node itself stays opaque over the
|
||||
// connectors). The property is not animated, so it reads what hover asks for at once.
|
||||
const cardOpacities = () => screens.evaluateAll((nodes) => Object.fromEntries(nodes.map((node) => [
|
||||
node.getAttribute("data-id") ?? "",
|
||||
getComputedStyle(node.querySelector(":scope > .canvas-active-frame")!).getPropertyValue("--map-card-opacity").trim(),
|
||||
])));
|
||||
const restingOpacities = await cardOpacities();
|
||||
let lastHoverTarget = dimmed.nth(hoverableDimmedIndexes[0]!);
|
||||
|
||||
for (const index of hoverableDimmedIndexes.slice(0, hoverTargetCount)) {
|
||||
@@ -149,7 +156,9 @@ async function expectMapScreenSelectionDimming(
|
||||
return label.startsWith(`Edge from ${nodeId} to `) || label.endsWith(` to ${nodeId}`);
|
||||
}).length, hoverTargetId!);
|
||||
expect(directEdgeCount).toBeGreaterThan(0);
|
||||
// The hovered screen and every screen it shares an edge with stay bright; the rest recede.
|
||||
// The hovered screen and every screen it shares an edge with are marked related; nothing on
|
||||
// the map recedes while hovering, so the only changes are the subject ring, the incident
|
||||
// edges and the neighbours' frames.
|
||||
const neighbourIds = await allEdges.evaluateAll((edges, nodeId) => {
|
||||
const ids = new Set<string>([nodeId]);
|
||||
for (const edge of edges) {
|
||||
@@ -166,14 +175,15 @@ async function expectMapScreenSelectionDimming(
|
||||
await expect.poll(() => brightNodes.evaluateAll((nodes) => (
|
||||
nodes.map((node) => node.getAttribute("data-id") ?? "").sort()
|
||||
))).toEqual(neighbourIds);
|
||||
const receded = page.locator(
|
||||
".map-canvas .react-flow__node-screen:not(.graph-node-hover-related)",
|
||||
const unrelated = page.locator(
|
||||
".map-canvas .react-flow__node-screen:not(.graph-node-hover-related):not(.canvas-node-exit)",
|
||||
);
|
||||
if (await receded.count() > 0) {
|
||||
await expect.poll(() => receded.first().evaluate(
|
||||
(node) => Number.parseFloat(getComputedStyle(node).opacity),
|
||||
)).toBeGreaterThan(0.5);
|
||||
}
|
||||
const unrelatedIds = await unrelated.evaluateAll((nodes) => nodes.map((node) => node.getAttribute("data-id") ?? ""));
|
||||
expect(unrelatedIds.length).toBeGreaterThan(0);
|
||||
const hoverOpacities = await cardOpacities();
|
||||
expect(unrelatedIds.map((id) => hoverOpacities[id])).toEqual(unrelatedIds.map((id) => restingOpacities[id]));
|
||||
expect(await unrelated.evaluateAll((nodes) => nodes.every((node) => getComputedStyle(node).filter === "none"))).toBe(true);
|
||||
await expect(page.locator(".map-canvas .screen-open-hint:visible")).toHaveCount(0);
|
||||
const activeEdges = page.locator(
|
||||
".map-canvas .react-flow__edge.graph-edge-hover-related",
|
||||
);
|
||||
@@ -1491,8 +1501,19 @@ test("Esc closes the Inspector first, then deselects; arrows and hjkl walk the m
|
||||
await expect(selected).toHaveCount(0);
|
||||
await expect(page).toHaveURL(/\/map$/);
|
||||
|
||||
// Nothing selected: the arrows are not map moves.
|
||||
await page.keyboard.press("ArrowDown");
|
||||
// Nothing selected: ↓ enters the map at its top, as → enters Screens at its first card; held, it
|
||||
// keeps walking down from there and stops where it is on release.
|
||||
await page.keyboard.down("ArrowDown");
|
||||
await expect(selected).toHaveCount(1);
|
||||
const entered = await selected.getAttribute("data-id");
|
||||
await expect.poll(() => selected.getAttribute("data-id"), { timeout: 4000 }).not.toBe(entered);
|
||||
await page.keyboard.up("ArrowDown");
|
||||
const walkedTo = await selected.getAttribute("data-id");
|
||||
await page.waitForTimeout(500);
|
||||
await expect(selected).toHaveAttribute("data-id", walkedTo!);
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(page.locator(".right-panel")).toHaveCount(0);
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(selected).toHaveCount(0);
|
||||
|
||||
await page.locator(".map-canvas .react-flow__node-screen .screen-screenshot-target").first().click();
|
||||
@@ -1508,6 +1529,67 @@ test("Esc closes the Inspector first, then deselects; arrows and hjkl walk the m
|
||||
await expect(selected).toHaveAttribute("data-id", child!);
|
||||
});
|
||||
|
||||
test("a held key stops when Esc, another key or a dialog takes the keyboard; a menu keeps its own arrows", async ({ page }) => {
|
||||
await page.goto("/map");
|
||||
const selected = page.locator(".map-canvas .react-flow__node-screen.selected");
|
||||
const inspector = page.locator(".right-panel");
|
||||
const search = page.getByRole("dialog", { name: "Search Explore" });
|
||||
const viewport = page.locator(".map-canvas .react-flow__viewport");
|
||||
const mod = process.platform === "darwin" ? "Meta" : "Control";
|
||||
|
||||
// Nothing selected and a menu open: ← and → on its item are the menu's, not the map's.
|
||||
await expect(selected).toHaveCount(0);
|
||||
await page.locator(".zoom-button").click();
|
||||
await expect(page.getByRole("menu")).toBeVisible();
|
||||
await page.keyboard.press("ArrowDown");
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(selected).toHaveCount(0);
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(page.getByRole("menu")).toHaveCount(0);
|
||||
|
||||
// Esc mid-walk closes the Inspector, and the walk does not reopen it on its next step.
|
||||
await page.locator(".map-canvas .react-flow__node-screen .screen-screenshot-target").first().click();
|
||||
await expect(inspector).toBeVisible();
|
||||
await page.keyboard.down("ArrowDown");
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(inspector).toHaveCount(0);
|
||||
await page.waitForTimeout(800);
|
||||
await expect(inspector).toHaveCount(0);
|
||||
await page.keyboard.up("ArrowDown");
|
||||
|
||||
// ⌘K mid-walk opens Search, and the selection behind it stays where it was.
|
||||
await page.keyboard.down("ArrowDown");
|
||||
await page.keyboard.press(`${mod}+k`);
|
||||
await expect(search).toBeVisible();
|
||||
const behind = await selected.getAttribute("data-id");
|
||||
await page.waitForTimeout(800);
|
||||
await expect(selected).toHaveAttribute("data-id", behind!);
|
||||
await page.keyboard.up("ArrowDown");
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(search).toHaveCount(0);
|
||||
|
||||
// A held + glides past the tap's one step and stops where it is on release.
|
||||
const zoomNow = async () => (await readCanvasCamera(viewport)).zoom;
|
||||
const before = await zoomNow();
|
||||
await page.keyboard.down("Equal");
|
||||
await expect.poll(zoomNow, { timeout: 4000 }).toBeGreaterThan(before * 1.2 * 1.2);
|
||||
await page.keyboard.up("Equal");
|
||||
const released = await zoomNow();
|
||||
await page.waitForTimeout(300);
|
||||
expect(await zoomNow()).toBeCloseTo(released, 3);
|
||||
|
||||
// Held −, then a click opens Search: the glide stops rather than zoom behind the dialog.
|
||||
await page.keyboard.down("Minus");
|
||||
await page.getByRole("button", { name: "Search", exact: true }).click();
|
||||
await expect(search).toBeVisible();
|
||||
await page.waitForTimeout(400);
|
||||
const atOpen = await zoomNow();
|
||||
await page.waitForTimeout(800);
|
||||
expect(await zoomNow()).toBeCloseTo(atOpen, 3);
|
||||
await page.keyboard.up("Minus");
|
||||
});
|
||||
|
||||
test("a drag that starts on a transition edge pans the map", async ({ page }) => {
|
||||
await page.goto("/map");
|
||||
const viewport = page.locator(".map-canvas .react-flow__viewport");
|
||||
@@ -1926,6 +2008,148 @@ test("fits the visible Map screenshot frame to the capture's intrinsic ratio", a
|
||||
expect(metrics.slotBackground).toBe("rgba(0, 0, 0, 0)");
|
||||
});
|
||||
|
||||
/** Each Map card's --map-card-opacity by id: what fades its frame. The property is not animated. */
|
||||
function mapCardOpacities(page: Page) {
|
||||
return page.locator(".map-canvas .react-flow__node-screen:not(.canvas-node-exit)").evaluateAll((nodes) => (
|
||||
Object.fromEntries(nodes.map((node) => [
|
||||
node.getAttribute("data-id") ?? "",
|
||||
getComputedStyle(node.querySelector(":scope > .canvas-active-frame")!).getPropertyValue("--map-card-opacity").trim(),
|
||||
]))
|
||||
));
|
||||
}
|
||||
|
||||
/** Waits until the Map camera stops moving. */
|
||||
async function expectMapCameraAtRest(page: Page) {
|
||||
await expect(page.locator(".map-canvas.canvas-focus-animating")).toHaveCount(0);
|
||||
const viewport = page.locator(".map-canvas .react-flow__viewport");
|
||||
let transform = "";
|
||||
await expect.poll(async () => {
|
||||
const next = await viewport.evaluate((element) => getComputedStyle(element).transform);
|
||||
const resting = next === transform;
|
||||
transform = next;
|
||||
return resting;
|
||||
}).toBe(true);
|
||||
}
|
||||
|
||||
/** The first `candidates` card whose screenshot is under the pointer near its top, with `room` above and below. */
|
||||
async function hoverableMapScreen(candidates: Locator, room = 80) {
|
||||
const index = await candidates.evaluateAll((nodes, room) => nodes.findIndex((node) => {
|
||||
const target = node.querySelector(".screen-screenshot-target")!.getBoundingClientRect();
|
||||
const hit = document.elementFromPoint(target.left + target.width / 2, target.top + target.height / 4);
|
||||
return hit !== null && node.contains(hit) && target.top > room && target.bottom < window.innerHeight - room;
|
||||
}), room);
|
||||
expect(index).toBeGreaterThanOrEqual(0);
|
||||
return candidates.nth(index);
|
||||
}
|
||||
|
||||
test("hovering a Map screen fades nothing and says Open in Inspector in a tooltip below the card that keeps to it", async ({ page }) => {
|
||||
await serveSyntheticWorkspace(page);
|
||||
await page.goto("/map");
|
||||
const screens = page.locator(".map-canvas .react-flow__node-screen:not(.canvas-node-exit)");
|
||||
await expect(screens.first()).toBeVisible();
|
||||
await expectMapCameraAtRest(page);
|
||||
const resting = await mapCardOpacities(page);
|
||||
// A screen at one end of a secondary transition, which rests a little faded.
|
||||
const secondaryEnds = await page.locator(".map-canvas .react-flow__edge.graph-edge-secondary").evaluateAll((edges) => (
|
||||
[...new Set(edges.flatMap((edge) => /^Edge from (.+) to (.+)$/.exec(edge.getAttribute("aria-label") ?? "")?.slice(1) ?? []))]
|
||||
));
|
||||
expect(secondaryEnds.length).toBeGreaterThan(0);
|
||||
const node = await hoverableMapScreen(page.locator(
|
||||
secondaryEnds.map((id) => `.map-canvas .react-flow__node-screen[data-id="${id}"]`).join(", "),
|
||||
));
|
||||
const target = node.locator(".screen-screenshot-target");
|
||||
const heading = node.locator(".screen-node-heading");
|
||||
// The tooltip says what a click does; no native title tooltip joins it.
|
||||
await expect(target).not.toHaveAttribute("title");
|
||||
// Near the card's top, so the pan below keeps the pointer on it.
|
||||
const box = (await target.boundingBox())!;
|
||||
await target.hover({ position: { x: box.width / 2, y: box.height / 4 } });
|
||||
await expect(page.locator(".connection-canvas-surface.canvas-hovering")).toHaveCount(1);
|
||||
const tooltip = page.locator(".tooltip", { hasText: "Open in Inspector" });
|
||||
await expect(tooltip).toBeVisible();
|
||||
const related = await page.locator(".map-canvas .react-flow__node-screen.graph-node-hover-related")
|
||||
.evaluateAll((nodes) => nodes.map((element) => element.getAttribute("data-id") ?? ""));
|
||||
const unrelated = Object.keys(resting).filter((id) => !related.includes(id));
|
||||
expect(unrelated.length).toBeGreaterThan(0);
|
||||
const hovering = await mapCardOpacities(page);
|
||||
expect(unrelated.map((id) => hovering[id])).toEqual(unrelated.map((id) => resting[id]));
|
||||
await expect(page.locator(".map-canvas .screen-open-hint:visible")).toHaveCount(0);
|
||||
// The transitions into and out of it come fully up, the secondary one too.
|
||||
const incident = page.locator(".map-canvas .react-flow__edge.graph-edge-hover-related");
|
||||
await expect(incident.and(page.locator(".graph-edge-secondary"))).not.toHaveCount(0);
|
||||
await expect.poll(() => incident.evaluateAll((edges) => edges.every((edge) => getComputedStyle(edge).opacity === "1"))).toBe(true);
|
||||
// The route heads a Map card, so the bubble sits below the screenshot, clear of both.
|
||||
const clearance = async () => {
|
||||
const [bubble, card, title] = await Promise.all([tooltip.boundingBox(), target.boundingBox(), heading.boundingBox()]);
|
||||
if (!bubble || !card || !title) return Number.NaN;
|
||||
const headingOverlap = bubble.y < title.y + title.height && title.y < bubble.y + bubble.height
|
||||
&& bubble.x < title.x + title.width && title.x < bubble.x + bubble.width;
|
||||
return headingOverlap ? -1 : bubble.y - (card.y + card.height);
|
||||
};
|
||||
expect(await clearance()).toBeGreaterThan(0);
|
||||
// Panning with the pointer still on the card moves the card by transform; the bubble follows it
|
||||
// rather than staying behind over the screenshot.
|
||||
const before = await target.boundingBox();
|
||||
await page.mouse.wheel(0, 40);
|
||||
await expect.poll(async () => (await target.boundingBox())!.y).toBeLessThan(before!.y - 10);
|
||||
await expect.poll(clearance).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
test("hovering a Map screen the Changes filter muted brings it and its neighbours back up, and nothing else", async ({ page }) => {
|
||||
await serveSyntheticWorkspace(page);
|
||||
await page.goto("/map?focus=modified");
|
||||
const muted = page.locator(".map-canvas .react-flow__node-screen.graph-node-muted:not(.canvas-node-exit)");
|
||||
await expect.poll(() => muted.count()).toBeGreaterThan(0);
|
||||
await expectMapCameraAtRest(page);
|
||||
const resting = await mapCardOpacities(page);
|
||||
const node = await hoverableMapScreen(muted, 0);
|
||||
const id = (await node.getAttribute("data-id"))!;
|
||||
expect(Number.parseFloat(resting[id]!)).toBeLessThan(1);
|
||||
await node.locator(".screen-screenshot-target").hover();
|
||||
await expect(node).toHaveClass(/graph-node-hover-subject/);
|
||||
const related = await page.locator(".map-canvas .react-flow__node-screen.graph-node-hover-related")
|
||||
.evaluateAll((nodes) => nodes.map((element) => element.getAttribute("data-id") ?? ""));
|
||||
expect(related).toContain(id);
|
||||
expect(related.length).toBeGreaterThan(1);
|
||||
const hovering = await mapCardOpacities(page);
|
||||
expect(related.map((relatedId) => hovering[relatedId])).toEqual(related.map(() => "1"));
|
||||
const unrelated = Object.keys(resting).filter((otherId) => !related.includes(otherId));
|
||||
expect(unrelated.length).toBeGreaterThan(0);
|
||||
expect(unrelated.map((otherId) => hovering[otherId])).toEqual(unrelated.map((otherId) => resting[otherId]));
|
||||
// The transitions between them come up with them.
|
||||
const edges = page.locator(".map-canvas .react-flow__edge.graph-edge-hover-related");
|
||||
await expect.poll(() => edges.count()).toBeGreaterThan(0);
|
||||
await expect.poll(() => edges.evaluateAll((elements) => elements.every((edge) => getComputedStyle(edge).opacity === "1"))).toBe(true);
|
||||
});
|
||||
|
||||
test("on Screens the Open in Inspector tooltip sits above the screenshot, clear of the route under it", async ({ page }) => {
|
||||
await serveSyntheticWorkspace(page);
|
||||
await page.goto("/screens");
|
||||
const card = page.locator(".screens-page .screen-screenshot-card:not(.selected)").nth(1);
|
||||
const target = card.locator(".screen-screenshot-target");
|
||||
await target.scrollIntoViewIfNeeded();
|
||||
await target.hover();
|
||||
const tooltip = page.locator(".tooltip", { hasText: "Open in Inspector" });
|
||||
await expect(tooltip).toBeVisible();
|
||||
const [bubble, screenshot, title] = await Promise.all([
|
||||
tooltip.boundingBox(), target.boundingBox(), card.locator(".screen-node-heading").boundingBox(),
|
||||
]);
|
||||
expect(bubble!.y + bubble!.height).toBeLessThanOrEqual(screenshot!.y);
|
||||
expect(title!.y).toBeGreaterThanOrEqual(screenshot!.y + screenshot!.height - 1);
|
||||
});
|
||||
|
||||
test("a narrow window with a mouse gets the phone map's Open pill on the selected screen, as it has no tooltips", async ({ page }) => {
|
||||
// The phone layout is a width, not a device: the first click there only selects, as a tap does.
|
||||
await page.setViewportSize({ width: 800, height: 820 });
|
||||
await serveSyntheticWorkspace(page);
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
expect(await page.evaluate(() => matchMedia("(hover: hover)").matches)).toBe(true);
|
||||
await expect(page.locator(".app-shell.phone-layout")).toHaveCount(1);
|
||||
const selected = page.locator(".map-canvas .react-flow__node-screen.selected");
|
||||
await expect(selected.locator(".screen-open-hint")).toBeVisible();
|
||||
await expect(page.locator(".map-canvas .screen-open-hint:visible")).toHaveCount(1);
|
||||
});
|
||||
|
||||
test("fits a landscape Map capture at render time without app-specific dimensions", async ({ page }) => {
|
||||
const source = viewerMapFixture() as ExploreMap;
|
||||
await serveMap(page, {
|
||||
@@ -2040,16 +2264,12 @@ test("canonicalizes the legacy Workspace route to Changes and reports the exact
|
||||
if (entry.status === "unchanged") return total;
|
||||
return total + (entry.currentScreenIds.length || entry.baselineScreenIds.length);
|
||||
}, 0);
|
||||
// The bottom bar's Compare button carries the count.
|
||||
const badge = page.locator(".canvas-toolbar .toolbar-badge");
|
||||
await expect(badge).toHaveText(String(expectedChanges));
|
||||
const menu = await openChangesMenu(page);
|
||||
await expect(menu.locator(".changes-panel-title .changes-panel-count")).toHaveText(String(expectedChanges));
|
||||
|
||||
// Without a baseline there is nothing to count. Compare still opens, and the view says why it is empty.
|
||||
await page.goto("/map?baseline=none");
|
||||
await expect(page).toHaveURL(/baseline=none/);
|
||||
await expect(badge).toHaveCount(0);
|
||||
const compare = page.getByRole("toolbar", { name: "Canvas tools" }).getByRole("button", { name: "Compare", exact: true });
|
||||
await expect(compare).not.toHaveAttribute("aria-disabled", "true");
|
||||
await compare.click();
|
||||
@@ -2700,6 +2920,31 @@ test("drives the shell from the keyboard, and says so on hover", async ({ page }
|
||||
}
|
||||
await expect(page.getByRole("button", { name: "Comments", exact: true })).toHaveCount(0);
|
||||
|
||||
// A held modifier shows, on each button it makes a chord with, the key that completes it: ⇧ puts
|
||||
// 1 on Fit canvas, ⌘ (Ctrl elsewhere) puts K on Search. Released, the hints go.
|
||||
const hints = page.locator(".key-hint");
|
||||
await expect(hints).toHaveCount(0);
|
||||
await page.keyboard.down("Shift");
|
||||
await expect(page.getByRole("button", { name: "Fit canvas" }).locator(".key-hint")).toHaveText("1");
|
||||
await expect(page.getByRole("button", { name: "Center canvas" }).locator(".key-hint")).toHaveText("2");
|
||||
await expect(page.getByRole("button", { name: "Search", exact: true }).locator(".key-hint")).toHaveCount(0);
|
||||
await page.keyboard.up("Shift");
|
||||
await expect(hints).toHaveCount(0);
|
||||
await page.keyboard.down(mod);
|
||||
await expect(page.getByRole("button", { name: "Search", exact: true }).locator(".key-hint")).toHaveText("K");
|
||||
await expect(page.getByRole("button", { name: "Fit canvas" }).locator(".key-hint")).toHaveCount(0);
|
||||
await page.keyboard.up(mod);
|
||||
await expect(hints).toHaveCount(0);
|
||||
// Focus that moves into a field by mouse, with ⇧ still down, takes the hints with it.
|
||||
await page.keyboard.down("Shift");
|
||||
await expect(page.getByRole("button", { name: "Fit canvas" }).locator(".key-hint")).toHaveText("1");
|
||||
await page.getByRole("button", { name: "Search", exact: true }).click();
|
||||
await expect(page.getByRole("dialog", { name: "Search Explore" })).toBeVisible();
|
||||
await expect(hints).toHaveCount(0);
|
||||
await page.keyboard.up("Shift");
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(page.getByRole("dialog", { name: "Search Explore" })).toHaveCount(0);
|
||||
|
||||
// ⌘B opens and closes the Changes menu.
|
||||
await page.keyboard.press(`${mod}+b`);
|
||||
await expect(page.locator(".changes-menu")).toBeVisible();
|
||||
@@ -2732,14 +2977,23 @@ test("drives the shell from the keyboard, and says so on hover", async ({ page }
|
||||
await expect(page.locator(".tooltip-key")).toHaveText("C");
|
||||
await page.getByRole("button", { name: "Expand inspector" }).hover();
|
||||
await expect(page.locator(".tooltip-key")).toHaveText("I");
|
||||
// The theme button has no key: it names the mode in force and nothing else.
|
||||
// The theme button names the mode in force, and T is its key.
|
||||
const themeButton = page.getByRole("button", { name: "Toggle theme" });
|
||||
await themeButton.hover();
|
||||
await expect(page.locator(".tooltip-content")).toContainText("Theme:");
|
||||
await expect(page.locator(".tooltip-key")).toHaveCount(0);
|
||||
await expect(page.locator(".tooltip-content")).toContainText("Theme: Auto");
|
||||
await expect(page.locator(".tooltip-key")).toHaveText("T");
|
||||
await page.mouse.move(0, 0);
|
||||
const initialTheme = await page.locator("html").getAttribute("data-theme");
|
||||
expect(initialTheme === "light" || initialTheme === "dark").toBe(true);
|
||||
const otherTheme = initialTheme === "dark" ? "light" : "dark";
|
||||
// T flips between dark and light from whatever Auto showed, and never steps back to Auto.
|
||||
await page.keyboard.press("t");
|
||||
await expect(page.locator("html")).toHaveAttribute("data-theme", otherTheme);
|
||||
await page.keyboard.press("t");
|
||||
await expect(page.locator("html")).toHaveAttribute("data-theme", initialTheme!);
|
||||
await themeButton.hover();
|
||||
await expect(page.locator(".tooltip-content")).toContainText(initialTheme === "dark" ? "Theme: Dark" : "Theme: Light");
|
||||
await page.mouse.move(0, 0);
|
||||
// The retired theme and inspector chords no longer answer.
|
||||
await page.keyboard.press(`${mod}+Alt+t`);
|
||||
await expect(page.locator("html")).toHaveAttribute("data-theme", initialTheme!);
|
||||
@@ -4202,6 +4456,25 @@ test("desktop Compare: one command bar with the modes in it, even gaps to both b
|
||||
for (let step = 1; step < before; step += 1) await page.keyboard.press("ArrowRight");
|
||||
await expect(position).toHaveText(new RegExp(`^${before} of `));
|
||||
|
||||
// In Swipe, [ and ] nudge the divider; held, ] keeps going until it is released or at the edge.
|
||||
await page.keyboard.press("2");
|
||||
const divider = compare.getByRole("slider");
|
||||
await expect(divider).toHaveAttribute("aria-valuenow", "50");
|
||||
await page.keyboard.press("BracketLeft");
|
||||
await expect(divider).toHaveAttribute("aria-valuenow", "45");
|
||||
const dividerAt = async () => Number(await divider.getAttribute("aria-valuenow"));
|
||||
await page.keyboard.down("BracketRight");
|
||||
await expect(divider).toHaveAttribute("aria-valuenow", "50");
|
||||
await expect.poll(dividerAt, { timeout: 4000 }).toBeGreaterThanOrEqual(65);
|
||||
await page.keyboard.up("BracketRight");
|
||||
const dividerHeld = await dividerAt();
|
||||
await page.waitForTimeout(600);
|
||||
expect(await dividerAt()).toBe(dividerHeld);
|
||||
await page.keyboard.down("BracketRight");
|
||||
await expect.poll(dividerAt, { timeout: 8000 }).toBe(100);
|
||||
await page.keyboard.up("BracketRight");
|
||||
await page.keyboard.press("1");
|
||||
|
||||
// The bar keeps one size whatever the route, so Next stays under the pointer: it can be clicked
|
||||
// again and again through screens whose routes differ in length.
|
||||
const nextButton = bar.getByRole("button", { name: "Next changed screen" });
|
||||
|
||||
@@ -27,7 +27,10 @@ export async function createBrowserVite(test, options) {
|
||||
});
|
||||
const requested = options.server;
|
||||
const port = requested?.port === 0 ? await freePort(requested.host ?? "127.0.0.1") : requested?.port;
|
||||
server = await createServer({ ...options, cacheDir,
|
||||
// A cold cacheDir optimizes dependencies as the page asks for them; one found late (the JSX dev runtime, which
|
||||
// esbuild's JSX imports) makes Vite reload the page, dropping whatever the test has done in it.
|
||||
const optimizeDeps = { ...options.optimizeDeps, include: [...(options.optimizeDeps?.include ?? []), "react/jsx-dev-runtime"] };
|
||||
server = await createServer({ ...options, cacheDir, optimizeDeps,
|
||||
...(requested ? { server: { ...requested, port, ...(requested.port === 0 ? { strictPort: true } : {}) } } : {}) });
|
||||
return server;
|
||||
}
|
||||
@@ -8,11 +8,13 @@ import { createHash } from 'node:crypto';
|
||||
import { PNG } from 'pngjs';
|
||||
import { AGENT_DEVICE_VERSION } from '../../dist/capture/run.js';
|
||||
import { CAPTURE_OBSERVER_IDENTIFIER } from '../../dist/capture/observer.js';
|
||||
import { controllerCacheRoot, ensureController } from '../../dist/shared/controller-cache.js';
|
||||
import { writeCaptureObserverPackages } from './capture-observer-fixture.mjs';
|
||||
|
||||
/**
|
||||
* In-process public CI fixture: a git project with base/head commits plus mocked `eas`, `repack-app`,
|
||||
* `agent-device` and GitHub transports, so a review runs end to end without network or a simulator.
|
||||
* `agent-device` and GitHub transports, so a review runs end to end without a simulator, and without network once the
|
||||
* real agent-device that compares screenshots is cached.
|
||||
*/
|
||||
|
||||
export const PROJECT_ID = '00000000-0000-4000-8000-000000000001';
|
||||
@@ -27,6 +29,17 @@ export const usageReceipt = (overrides = {}) => ({ provider: 'anthropic', model:
|
||||
totals: { inputTokens: 100, outputTokens: 20, cacheReadInputTokens: 40, estimatedCostUsd: 0.012 },
|
||||
models: [{ model: 'fixture-model', inputTokens: 100, outputTokens: 20, cacheReadInputTokens: 40, estimatedCostUsd: 0.012, costBasis: 'list' }],
|
||||
...overrides });
|
||||
|
||||
/**
|
||||
* The review's screenshot comparison runs the real agent-device, which fetches itself on first use. The fixture fetches
|
||||
* it once, with retries, into the machine's controller cache, so a review never downloads it mid-run.
|
||||
*/
|
||||
const CONTROLLER_CACHE = controllerCacheRoot(process.env);
|
||||
for (let attempt = 1; ; attempt++) {
|
||||
try { await ensureController('agent-device', { environment: { ...process.env, EXPLORE_CONTROLLER_CACHE: CONTROLLER_CACHE } }); break; }
|
||||
catch (error) { if (attempt === 3) throw error; await new Promise(resolve => setTimeout(resolve, attempt * 2_000)); }
|
||||
}
|
||||
|
||||
export async function readUsage(output) {
|
||||
const path = join(output, 'agent-usage.jsonl');
|
||||
assert.equal((await stat(path)).mode & 0o777, 0o600, 'usage receipts are private artifacts');
|
||||
@@ -103,7 +116,7 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
|
||||
const pr = { repositoryId: '123', repository: 'acme/example', number: 7, title: 'Source capture integration', url: 'https://github.com/acme/example/pull/7',
|
||||
base: { ref: 'main', sha: baseSha }, head: { ref: 'feature', sha: headSha } };
|
||||
const pullRequestPath = join(root, 'pull-request.json'); await writeFile(pullRequestPath, JSON.stringify(pr));
|
||||
const environment = { PATH: process.env.PATH, HOME: root, RUNNER_TEMP: root, EXPO_TOKEN: 'test-expo-secret', GITHUB_TOKEN: 'test-github-secret',
|
||||
const environment = { PATH: process.env.PATH, HOME: root, RUNNER_TEMP: root, EXPLORE_CONTROLLER_CACHE: CONTROLLER_CACHE, EXPO_TOKEN: 'test-expo-secret', GITHUB_TOKEN: 'test-github-secret',
|
||||
GITHUB_RUN_ID: '1234', GITHUB_RUN_ATTEMPT: '1', GITHUB_REPOSITORY: pr.repository, TOOLS_COMMIT: 'c'.repeat(40), EXPLORE_VIEWER_ORIGIN: 'https://viewer.example' };
|
||||
const requests = []; const comments = []; const sessions = new Map(); let currentSession; const idleDevice = { path: '/', scheme: 'light' }; let sessionCounter = 0; let repackedSha; let openFailed = false;
|
||||
const identity = (session) => ({ session: 'expo-explore-runtime', appBundleId: config.app.bundleId,
|
||||
@@ -179,7 +192,14 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
|
||||
}
|
||||
return ok(identity(device));
|
||||
}
|
||||
if (command === 'fold') return ok({ action: 'fold', pose: request.args[1] });
|
||||
if (command === 'fold') { device.pose = request.args[1]; return ok({ action: 'fold', pose: request.args[1] }); }
|
||||
// The display a fold lit, as a pose check reads it: landscape when opened, and drawn.
|
||||
if (command === 'screenshot' && request.args[1].endsWith('/pose.png')) {
|
||||
const display = new PNG(device.pose === 'open' ? { width: 24, height: 16 } : { width: 16, height: 24 });
|
||||
display.data[0] = 255;
|
||||
writeFileSync(request.args[1], PNG.sync.write(display));
|
||||
return ok({ path: request.args[1] });
|
||||
}
|
||||
if (command === 'install') {
|
||||
const app = request.args[1];
|
||||
device.build = platform === 'android' ? readFileSync(app, 'utf8') : readFileSync(join(app, 'build-id'), 'utf8');
|
||||
@@ -199,7 +219,7 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
|
||||
] });
|
||||
}
|
||||
if (command === 'settings') { if (request.args[1] === 'appearance') device.scheme = request.args[2]; return ok({ setting: request.args[1], value: request.args[2] }); }
|
||||
if (command === 'screenshot') { const color = createHash('sha256').update(`${device.path}:${device.scheme}:${device.path === '/home' ? device.build : 'unchanged-source'}`).digest(); const data = Buffer.alloc(16 * 24 * 4); for (let i = 0; i < data.length; i += 4) { data[i] = color[0]; data[i + 1] = color[1]; data[i + 2] = color[2]; data[i + 3] = 255; } writeFileSync(request.args[1], PNG.sync.write({ width: 16, height: 24, data })); return ok({ path: request.args[1] }); }
|
||||
if (command === 'screenshot') { const color = createHash('sha256').update(`${device.path}:${device.scheme}:${device.path === '/home' ? device.build : 'unchanged-source'}`).digest(); /* Hashed colours can land within the diff threshold, so /home's red channel keeps the base build apart from any other. */ if (device.path === '/home') color[0] = device.build?.endsWith(baseSha) ? 0 : 255; const data = Buffer.alloc(16 * 24 * 4); for (let i = 0; i < data.length; i += 4) { data[i] = color[0]; data[i + 1] = color[1]; data[i + 2] = color[2]; data[i + 3] = 255; } writeFileSync(request.args[1], PNG.sync.write({ width: 16, height: 24, data })); return ok({ path: request.args[1] }); }
|
||||
}
|
||||
throw new Error(`Unexpected mocked command: ${request.command} ${request.args.join(' ')}`);
|
||||
};
|
||||
|
||||
@@ -395,9 +395,18 @@ test("when Argent reads nothing while the prompt is up, Open is tapped from a sc
|
||||
assert.equal(context.state.deepLinkPromptAccepted, true);
|
||||
});
|
||||
|
||||
test("reset-reader stops the device's Argent helpers by its UDID and forgets what the old reader saw", async () => {
|
||||
const state = { generation: 3, udid: UDID, screen: { width: 402, height: 874 }, refs: { e1: {} } };
|
||||
const { calls, run } = harness("ios", { "stop-all-simulator-servers": { stopped: [`NativeDevtools:${UDID}`, `AXService:${UDID}`] } }, { state });
|
||||
const reset = await run(["reset-reader", ...flags("ios")]);
|
||||
assert.deepEqual(reset.json.data, { action: "reset-reader", stopped: [`NativeDevtools:${UDID}`, `AXService:${UDID}`] });
|
||||
assert.deepEqual(calls, [{ tool: "stop-all-simulator-servers", args: { devices: [UDID] } }]);
|
||||
assert.equal(state.screen, undefined); assert.equal(state.refs, undefined); assert.equal(state.generation, 4);
|
||||
});
|
||||
|
||||
test("fold moves a foldable to a pose and forgets the old panel's geometry", async () => {
|
||||
// Argent's fold answers with the panel it lit, in pixels; the inner panel is 2007 × 2853 (669 × 951 points).
|
||||
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": [DUO_HOME, DUO_OPEN_EDIT_LANE],
|
||||
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": [DUO_HOME, DUO_OPEN_EDIT_LANE], "stop-all-simulator-servers": { stopped: [] },
|
||||
fold: { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 } });
|
||||
await run(["snapshot", ...flags("ios")]);
|
||||
const generation = context.state.generation;
|
||||
@@ -407,12 +416,29 @@ test("fold moves a foldable to a pose and forgets the old panel's geometry", asy
|
||||
const fold = calls.findIndex(call => call.tool === "fold");
|
||||
assert.equal(calls.slice(0, fold).filter(call => call.tool === "ui-tree").length, reads, "nothing is read between the command and the fold");
|
||||
assert.deepEqual(calls[fold].args, { udid: "74195B53-4DBC-4EAA-9991-F98E5BB86BA8", posture: "open" });
|
||||
// The device's helpers are reset just before the fold, so the panel it lights is read by fresh ones.
|
||||
assert.deepEqual(calls[fold - 1], { tool: "stop-all-simulator-servers", args: { devices: ["74195B53-4DBC-4EAA-9991-F98E5BB86BA8"] } });
|
||||
assert.equal(context.state.screen, undefined);
|
||||
assert.equal(context.state.refs, undefined);
|
||||
assert.equal(context.state.generation, generation + 1);
|
||||
assert.equal((await run(["fold", "sideways", ...flags("ios")])).json.error.code, "INVALID_ARGS");
|
||||
});
|
||||
|
||||
test("a reader stuck on the dark panel after a fold is reset once more before the fold is called unverified", async () => {
|
||||
const fold = { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 };
|
||||
const stopped = { stopped: ["AXService:74195B53-4DBC-4EAA-9991-F98E5BB86BA8"] };
|
||||
// Ten reads still in the cover panel's shape (as on EAS, 2026-10-17), then the inner panel once the helpers restart.
|
||||
const recovers = harness("ios", { "list-devices": DUO_DEVICES, fold, "stop-all-simulator-servers": stopped, "ui-tree": [...Array(10).fill(DUO_HOME), DUO_OPEN_EDIT_LANE] });
|
||||
assert.deepEqual((await recovers.run(["fold", "open", ...flags("ios")])).json.data, { action: "fold", pose: "open" });
|
||||
assert.deepEqual(recovers.calls.filter(call => call.tool === "stop-all-simulator-servers").map(call => call.args), Array(2).fill({ devices: ["74195B53-4DBC-4EAA-9991-F98E5BB86BA8"] }));
|
||||
|
||||
const stuck = harness("ios", { "list-devices": DUO_DEVICES, fold, "stop-all-simulator-servers": stopped, "ui-tree": DUO_HOME });
|
||||
const failed = await stuck.run(["fold", "open", ...flags("ios")]);
|
||||
assert.equal(failed.json.error.code, "CONTROLLER_FOLD_UNVERIFIED");
|
||||
assert.match(failed.json.error.message, /after its device helpers were reset/);
|
||||
assert.equal(stuck.calls.filter(call => call.tool === "stop-all-simulator-servers").length, 2, "before the fold and once after, not in a loop");
|
||||
});
|
||||
|
||||
test("an alert that is not the link prompt is left for capture to answer", async () => {
|
||||
const other = { ...IOS_HOME, alertVisible: true, foregroundApp: "com.apple.springboard",
|
||||
roots: [{ type: "Alert", label: "Delete all data?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [
|
||||
@@ -534,9 +560,9 @@ test("a node its ancestor clips away is still reported hidden on iOS", () => {
|
||||
test("a fold whose panel Argent never reads fails clearly instead of capturing the dark panel", async () => {
|
||||
const lit = { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 };
|
||||
const blindClosed = { ...DUO_HOME, foregroundApp: undefined, roots: [{ role: "AXGroup", children: [] }] };
|
||||
const late = harness("ios", { "list-devices": DUO_DEVICES, fold: lit, "ui-tree": [blindClosed, blindClosed, DUO_OPEN_EDIT_LANE] });
|
||||
const late = harness("ios", { "list-devices": DUO_DEVICES, fold: lit, "stop-all-simulator-servers": { stopped: [] }, "ui-tree": [blindClosed, blindClosed, DUO_OPEN_EDIT_LANE] });
|
||||
assert.equal((await late.run(["fold", "open", ...flags("ios")])).exitCode, 0, "a reader that catches up within the wait is fine");
|
||||
const stuck = harness("ios", { "list-devices": DUO_DEVICES, fold: lit, "ui-tree": blindClosed });
|
||||
const stuck = harness("ios", { "list-devices": DUO_DEVICES, fold: lit, "stop-all-simulator-servers": { stopped: [] }, "ui-tree": blindClosed });
|
||||
const failed = await stuck.run(["fold", "open", ...flags("ios")]);
|
||||
assert.equal(failed.json.error.code, "CONTROLLER_FOLD_UNVERIFIED");
|
||||
assert.equal(stuck.calls.filter(call => call.tool === "fold").length, 1, "the session is not folded back and forth");
|
||||
|
||||
@@ -7,7 +7,7 @@ import test from "node:test";
|
||||
|
||||
const root = resolve(import.meta.dirname, "../..");
|
||||
const cli = join(root, "dist", "cli.js");
|
||||
const { defaultOutputDirectory, expiresInDays } = await import(join(root, "dist", "cli", "binary-commands.js"));
|
||||
const { defaultOutputDirectory } = await import(join(root, "dist", "cli", "binary-commands.js"));
|
||||
|
||||
function fail(args) {
|
||||
// Without an EAS login (as on CI) argument and archive errors must still come first.
|
||||
@@ -28,7 +28,6 @@ test("explore:binary is in the short help with its archive kinds and --no-upload
|
||||
test("explore:binary validates its arguments before touching EAS or a model", () => {
|
||||
assert.match(fail([]), /Pass the app archive/);
|
||||
assert.match(fail(["./app.apk", "--upload", "--no-upload"]), /either --upload or --no-upload/);
|
||||
assert.match(fail(["./app.apk", "--expires-in", "400d"]), /--expires-in must be 1d to 90d, or never/);
|
||||
assert.match(fail(["./app.apk", "--platform", "web"]), /platform/);
|
||||
assert.match(fail(["./app.apk", "--simulator", "cloud"]), /simulator/);
|
||||
// A local run needs no EAS login, so the archive is the first thing it checks.
|
||||
@@ -40,9 +39,10 @@ test("explore:binary validates its arguments before touching EAS or a model", ()
|
||||
assert.match(human.stderr, /Archive not found: .*does-not-exist\.apk\n→ Check the path/);
|
||||
});
|
||||
|
||||
test("expiry and output directory defaults", () => {
|
||||
assert.equal(expiresInDays("7d"), 7); assert.equal(expiresInDays("90d"), 90); assert.equal(expiresInDays("never"), null);
|
||||
assert.throws(() => expiresInDays("0d")); assert.throws(() => expiresInDays("7")); assert.throws(() => expiresInDays("91d"));
|
||||
test("--expires-in is accepted from older scripts and says it no longer applies; output directory defaults", () => {
|
||||
const ignored = spawnSync(process.execPath, [cli, "explore:binary", "./does-not-exist.apk", "--no-upload", "--expires-in", "400d"], { cwd: root, encoding: "utf8", env: { ...process.env, EXPO_TOKEN: "", EXPO_SESSION_SECRET: "", GITHUB_ACTIONS: "" } });
|
||||
assert.match(ignored.stderr, /^--expires-in no longer applies: a hosted preview lasts as long as its EAS Hosting deployment/m);
|
||||
assert.match(ignored.stderr, /Archive not found/, "and the run goes on");
|
||||
const now = new Date("2026-10-11T16:28:48.123Z");
|
||||
assert.equal(defaultOutputDirectory("/builds/euxy-ios.tar.gz", now), "explore-euxy-ios-20261011-1628");
|
||||
assert.equal(defaultOutputDirectory("My App (1).app", now), "explore-My-App-1-20261011-1628");
|
||||
|
||||
@@ -112,6 +112,10 @@ async function fixture(t, settings = {}) {
|
||||
const requests = [];
|
||||
let current = '/'; let snapshots = 0; let sessionName; let screenshotAttempts = 0; let splashLeft = 0; let recordingPath = ''; let alert = null; let appearance = 'light'; let alertReads = 0;
|
||||
let enteredName = false; let scrolledToContinue = false; let finishHidden = false; let wedgeCleared = false; let deviceLost = false; let relaunchedAfterForeign = false; let serverStarts = 0; let unreadableLeft = settings.unreadableAfterFold ?? 0;
|
||||
// startsErrored / startsUnnamed: how many session starts EAS fails, after naming the session (it ERRORS) or before.
|
||||
let starts = 0; let currentSession = 'session-1'; const erroredSessions = new Set(); let foldUnverifiedLeft = settings.foldUnverified ?? 0;
|
||||
// blackAfterFold: the first so many folds of an EAS agent-device session light the panel but draw nothing.
|
||||
let folds = 0;
|
||||
const deviceName = settings.android ? 'Pixel 7' : 'iPhone 17 Pro';
|
||||
const platform = settings.android ? 'android' : 'ios';
|
||||
// A local simulator is the one the capture created, named for Explore.
|
||||
@@ -141,7 +145,8 @@ async function fixture(t, settings = {}) {
|
||||
if (request.args[1]?.includes('server start')) {
|
||||
const port = 4100 + serverStarts++;
|
||||
writeFileSync(request.environment.EXPLORE_ARGENT_SERVER_LOG, ` (or: argent link --host 127.0.0.1 --port ${port} --token abc123)\n[t] Tools server listening on http://127.0.0.1:${port}\n`);
|
||||
return { stdout: `${4242 + serverStarts}\n`, stderr: '' };
|
||||
// A pid no process can have: stopping the server signals it for real.
|
||||
return { stdout: `${999_999_000 + serverStarts}\n`, stderr: '' };
|
||||
}
|
||||
return { stdout: '', stderr: '' };
|
||||
}
|
||||
@@ -182,6 +187,14 @@ async function fixture(t, settings = {}) {
|
||||
appConfig: { name: 'Example', slug: 'example', owner: 'acme', ...(settings.userInterfaceStyle ? { userInterfaceStyle: settings.userInterfaceStyle } : {}), scheme: settings.noScheme ? undefined : 'sample',
|
||||
...(settings.android ? { android: { package: 'com.example.app' } } : { ios: { bundleIdentifier: 'com.example.app' } }), extra: { eas: { projectId: PROJECT_ID } } } });
|
||||
if (command === 'simulator:availability') return json({ available: settings.available !== false });
|
||||
// controlActions: what the session's serve-sim offers through simulator:control (none unless a test names them).
|
||||
if (command === 'simulator:control') {
|
||||
assert.equal(value(request, '--id'), currentSession, 'simulator:control names the session');
|
||||
if (request.args.includes('--list')) return json(Object.fromEntries((settings.controlActions ?? []).map(action => [action, { type: 'object' }])));
|
||||
assert.ok((settings.controlActions ?? []).includes(request.args[1]), `${request.args[1]} is offered by the session`);
|
||||
if (request.args[1] === 'appearance.set') appearance = request.args.at(-1);
|
||||
return json({ id: currentSession, action: request.args[1], output: '' });
|
||||
}
|
||||
if (command === 'fingerprint:generate') return json({ hash: 'source-fingerprint' });
|
||||
const buildMetadata = settings.buildMetadata ? { appVersion: '2.1.0', appBuildVersion: '42' } : {};
|
||||
if (command === 'build:list') return json(settings.reuse ? [{ id: 'native-build', ...buildMetadata }] : []);
|
||||
@@ -211,13 +224,23 @@ async function fixture(t, settings = {}) {
|
||||
}
|
||||
if (command === 'simulator:start') {
|
||||
sessionName = value(request, '--name');
|
||||
writeFileSync(join(request.cwd, '.env.eas-simulator'), HEADER + "EAS_SIMULATOR_SESSION_ID='session-1'\n" + (settings.argent
|
||||
starts += 1; currentSession = `session-${starts}`;
|
||||
if (starts <= (settings.startsUnnamed ?? 0)) { writeFileSync(join(request.cwd, '.env.eas-simulator'), HEADER); throw new Error('GraphQL request failed.'); }
|
||||
if (starts <= (settings.startsErrored ?? 0)) erroredSessions.add(currentSession);
|
||||
writeFileSync(join(request.cwd, '.env.eas-simulator'), HEADER + `EAS_SIMULATOR_SESSION_ID='${currentSession}'\n` + (settings.argent
|
||||
? "ARGENT_TOOLS_URL='https://controller.example/session'\nARGENT_AUTH_TOKEN='" + DAEMON_TOKEN + "'\n"
|
||||
: "AGENT_DEVICE_DAEMON_BASE_URL='https://controller.example/session'\nAGENT_DEVICE_DAEMON_AUTH_TOKEN='" + DAEMON_TOKEN + "'\n"));
|
||||
if (settings.startFailure) throw new Error('start reported failure after allocation');
|
||||
if (erroredSessions.has(currentSession)) throw new Error('Simulator session errored while starting');
|
||||
return { stdout: 'ready', stderr: '' };
|
||||
}
|
||||
if (command === 'simulator:get') return json({ id: 'session-1', name: sessionName, type: settings.argent ? 'argent' : 'agent-device', platform: settings.android ? 'ANDROID' : 'IOS', status: 'IN_PROGRESS',
|
||||
// orphanFromFailedStart: a start that failed before naming the session had still created one.
|
||||
if (command === 'simulator:list') return json({ sessions: settings.orphanFromFailedStart && value(request, '--name') === sessionName ? [{ id: 'orphan-1', name: sessionName,
|
||||
type: settings.argent ? 'argent' : 'agent-device', status: 'STARTING', platform: 'IOS',
|
||||
// orphanUnproven: the session by that name does not show it belongs to this project.
|
||||
deviceRunSessionUrl: `https://expo.dev/accounts/${settings.orphanUnproven ? 'someone-else' : 'acme'}/projects/example/simulator-sessions/orphan-1` }] : [], pageInfo: {} });
|
||||
if (command === 'simulator:get') return json({ id: value(request, '--id'), name: sessionName, type: settings.argent ? 'argent' : 'agent-device', platform: settings.android ? 'ANDROID' : 'IOS',
|
||||
status: erroredSessions.has(value(request, '--id')) ? 'ERRORED' : 'IN_PROGRESS',
|
||||
app: { id: settings.wrongProject ? 'foreign-project' : PROJECT_ID, slug: 'example', ownerAccount: { name: 'acme' } },
|
||||
remoteConfig: { ...(settings.argent ? { toolsUrl: 'https://controller.example/session', toolsAuthToken: DAEMON_TOKEN }
|
||||
: { agentDeviceRemoteSessionUrl: 'https://controller.example/session', agentDeviceRemoteSessionToken: DAEMON_TOKEN }),
|
||||
@@ -226,7 +249,7 @@ async function fixture(t, settings = {}) {
|
||||
...(settings.previewApiUrl ? { previewApiUrl: settings.previewApiUrl } : {}) } });
|
||||
if (command === 'simulator:stop') {
|
||||
if (settings.stopFailure) throw new Error('stop unavailable');
|
||||
return json({ id: 'session-1', status: 'STOPPED' });
|
||||
return json({ id: value(request, '--id'), status: 'STOPPED' });
|
||||
}
|
||||
}
|
||||
if (request.command === 'fake-repack') {
|
||||
@@ -241,6 +264,7 @@ async function fixture(t, settings = {}) {
|
||||
// An Argent capture runs its per-run bridge in place of agent-device; the bridge answers in agent-device's envelopes.
|
||||
if (request.command === 'fake-controller' || (settings.argent && request.command.endsWith('/argent-controller'))) {
|
||||
if (command === '--version') return { stdout: settings.argent ? '0.29.0' : AGENT_DEVICE_VERSION, stderr: '' };
|
||||
if (command === 'reset-reader') return json({ success: true, data: { action: 'reset-reader', stopped: ['AXService:device'] } });
|
||||
if (command === 'open') {
|
||||
// unreadableAfterFold: Argent's reader stayed on the outer panel, so the first app opens find no readable app.
|
||||
if (unreadableLeft > 0 && !request.args[2]?.startsWith('sample://')) { unreadableLeft -= 1;
|
||||
@@ -274,6 +298,11 @@ async function fixture(t, settings = {}) {
|
||||
// An EAS session starts empty while the app is repacked; the controller installs the app from this machine.
|
||||
if (command === 'install') { assert.ok(existsSync(request.args[1]), 'the repacked app is on this machine'); return ok({ installed: true, appBundleId: 'com.example.app' }); }
|
||||
// agent-device 0.21.15 cannot read Xcode 27.1's hinge angle back, so a local fold reports a failure after folding.
|
||||
// foldUnverified: the bridge's reader stayed on the dark panel through its own reset, for that many folds.
|
||||
// The bridge exits non-zero, and the runner throws its structured error, as defaultRunner does.
|
||||
if (command === 'fold') folds += 1;
|
||||
if (command === 'fold' && foldUnverifiedLeft > 0) { foldUnverifiedLeft -= 1;
|
||||
throw controllerCommandFailure(json({ success: false, error: { code: 'CONTROLLER_FOLD_UNVERIFIED', message: 'Argent kept reading the other panel after folding the device open, and after its device helpers were reset.' } }).stdout, 'fold'); }
|
||||
if (command === 'fold') return settings.local ? json({ success: false, error: { code: 'COMMAND_FAILED', message: "CoreDevice reported no hinge angle sample: Unknown option '--device'" } })
|
||||
: ok({ action: 'fold', pose: request.args[1] });
|
||||
if (command === 'record' && settings.recording) {
|
||||
@@ -347,6 +376,13 @@ async function fixture(t, settings = {}) {
|
||||
if (request.args[1] === 'appearance') appearance = request.args[2];
|
||||
return ok({ setting: request.args[1], value: request.args[2] });
|
||||
}
|
||||
// The display after a fold, as agent-device's screenshot shows it on EAS: in the pose's shape, drawn or black.
|
||||
if (command === 'screenshot' && request.args[1]?.endsWith('/pose.png')) {
|
||||
const display = new PNG(settings.devicePose === 'open' ? { width: 30, height: 20 } : { width: 20, height: 30 });
|
||||
if (folds > (settings.blackAfterFold ?? 0)) display.data[0] = 255;
|
||||
writeFileSync(request.args[1], PNG.sync.write(display));
|
||||
return ok({ path: request.args[1] });
|
||||
}
|
||||
if (command === 'screenshot') {
|
||||
screenshotAttempts += 1;
|
||||
if (settings.firstScreenshotFails && screenshotAttempts === 1) throw new Error('temporary screenshot transport error');
|
||||
@@ -468,7 +504,7 @@ test('an Argent capture starts an argent session, drives it through the bridge,
|
||||
}
|
||||
// Argent cannot switch appearance yet: one pass, no `settings appearance`, and a warning naming what was skipped.
|
||||
assert.equal(f.requests.some(request => request.args[0] === 'settings'), false);
|
||||
assert.ok(lines.some(line => /Argent cannot switch appearance yet .*capturing light only, skipped dark/.test(line)), lines.join('\n'));
|
||||
assert.ok(lines.some(line => /Argent cannot switch appearance on this session; capturing light only, skipped dark/.test(line)), lines.join('\n'));
|
||||
const map = JSON.parse(await readFile(join(f.options.outputDirectory, 'screen-map.json'), 'utf8'));
|
||||
assert.equal(map.run.controller, 'argent');
|
||||
assert.equal(map.run.environment.colorSchemes, undefined);
|
||||
@@ -480,6 +516,150 @@ test('an Argent capture starts an argent session, drives it through the bridge,
|
||||
assert.equal(execution.controllerPackageVersion, '0.29.0');
|
||||
});
|
||||
|
||||
test('on an EAS iOS session with serve-sim\'s appearance.set, an Argent capture records every appearance', async t => {
|
||||
const f = await fixture(t, { argent: true, userInterfaceStyle: 'automatic', controlActions: ['appearance.set'] });
|
||||
const lines = [];
|
||||
assert.equal((await runCiMap({ ...f.options, progress: line => lines.push(line) })).runStatus, 'complete');
|
||||
assert.equal(lines.some(line => /Argent cannot switch appearance/.test(line)), false, lines.join('\n'));
|
||||
assert.deepEqual(f.requests.filter(request => request.args[0] === 'simulator:control' && request.args[1] === 'appearance.set').map(request => request.args.at(-1)), ['light', 'dark']);
|
||||
const map = JSON.parse(await readFile(join(f.options.outputDirectory, 'screen-map.json'), 'utf8'));
|
||||
assert.deepEqual(map.run.environment.colorSchemes, ['light', 'dark']);
|
||||
});
|
||||
|
||||
test('an EAS iOS session approves the app\'s link scheme after installing it and before any link opens', async t => {
|
||||
for (const argent of [false, true]) {
|
||||
const f = await fixture(t, { argent, controlActions: ['app.approveUrlScheme'] });
|
||||
assert.equal((await runCiMap(f.options)).runStatus, 'complete');
|
||||
const approve = f.requests.findIndex(request => request.args[0] === 'simulator:control' && request.args[1] === 'app.approveUrlScheme');
|
||||
assert.ok(approve >= 0, argent ? 'Argent' : 'agent-device');
|
||||
assert.deepEqual(f.requests[approve].args.slice(f.requests[approve].args.indexOf('--') + 1), ['com.example.app', 'sample']);
|
||||
const controller = f.requests.map((request, index) => ({ request, index })).filter(({ request }) => request.command === 'fake-controller' || request.command.endsWith('/argent-controller'));
|
||||
const install = controller.find(({ request }) => request.args[0] === 'install');
|
||||
const firstLink = controller.find(({ request }) => request.args[0] === 'open' && request.args[2]?.startsWith('sample://'));
|
||||
assert.ok(install.index < approve && approve < firstLink.index, 'installed, then approved, then the first link');
|
||||
}
|
||||
// A session whose serve-sim predates the action keeps the controllers' prompt handling, and is not asked.
|
||||
const older = await fixture(t, { argent: true });
|
||||
assert.equal((await runCiMap(older.options)).runStatus, 'complete');
|
||||
assert.equal(older.requests.some(request => request.args[0] === 'simulator:control' && !request.args.includes('--list')), false);
|
||||
});
|
||||
|
||||
test('when Argent cannot read the app after a fold on EAS, the capture resets its device helpers, then restarts SpringBoard, and never stops the tool-server', async t => {
|
||||
const actions = ['springboard.restart'];
|
||||
for (const [unreadable, completes, resets, restarts] of [[1, true, 1, 0], [2, true, 2, 1], [3, false, 2, 1]]) {
|
||||
const f = await fixture(t, { argent: true, devicePose: 'open', unreadableAfterFold: unreadable, controlActions: actions });
|
||||
const lines = [];
|
||||
const run = runCiMap({ ...f.options, progress: line => lines.push(line), sleep: () => {} });
|
||||
if (completes) assert.equal((await run).runStatus, 'complete', `${unreadable} unreadable opens`);
|
||||
else await assert.rejects(run, error => JSON.stringify(error).includes('CONTROLLER_READER_STUCK'));
|
||||
assert.equal(f.requests.filter(request => request.command.endsWith('/argent-controller') && request.args[0] === 'reset-reader').length, resets);
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'simulator:control' && request.args[1] === 'springboard.restart').length, restarts);
|
||||
assert.equal(f.requests.some(request => request.args.join(' ').includes('server stop')), false, 'the session\'s tool-server is never stopped');
|
||||
assert.ok(lines.some(line => /resetting Argent's device helpers/.test(line)), lines.join('\n'));
|
||||
}
|
||||
// Without springboard.restart (an older serve-sim), a second unreadable open is reported after the reset alone.
|
||||
const older = await fixture(t, { argent: true, devicePose: 'open', unreadableAfterFold: 2 });
|
||||
await assert.rejects(runCiMap({ ...older.options, sleep: () => {} }), error => JSON.stringify(error).includes('CONTROLLER_READER_STUCK'));
|
||||
});
|
||||
|
||||
test('when a fold on EAS leaves Argent reading the dark panel, the capture restarts SpringBoard and folds again, once', async t => {
|
||||
for (const [unverified, completes] of [[1, true], [2, false]]) {
|
||||
const f = await fixture(t, { argent: true, devicePose: 'open', foldUnverified: unverified, controlActions: ['springboard.restart'] });
|
||||
const run = runCiMap({ ...f.options, sleep: () => {} });
|
||||
if (completes) assert.equal((await run).runStatus, 'complete');
|
||||
else await assert.rejects(run, error => JSON.stringify(error).includes('CONTROLLER_READER_STUCK'));
|
||||
assert.equal(f.requests.filter(request => request.command.endsWith('/argent-controller') && request.args[0] === 'fold').length, 2);
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'simulator:control' && request.args[1] === 'springboard.restart').length, 1);
|
||||
}
|
||||
});
|
||||
|
||||
test('a session EAS ends while starting is replaced by a new one, under a name of its own, up to five times with a growing wait', async t => {
|
||||
const f = await fixture(t, { startsErrored: 1 });
|
||||
const lines = []; const waits = [];
|
||||
const result = await runCiMap({ ...f.options, progress: line => lines.push(line), sleep: ms => { waits.push(ms); } });
|
||||
assert.equal(result.runStatus, 'complete');
|
||||
const started = f.requests.filter(request => request.args[0] === 'simulator:start').map(request => value(request, '--name'));
|
||||
assert.equal(started.length, 2);
|
||||
assert.notEqual(started[0], started[1], 'the new session has a name of its own');
|
||||
assert.ok(lines.some(line => /EAS ended simulator session session-1 \(ERRORED\) before it was ready; starting a new EAS Simulator session in 10 s \(1\/5\)/.test(line)), lines.join('\n'));
|
||||
assert.equal(lines.filter(line => /while the app is repacked/.test(line)).length, 1, 'only the first start runs beside the repack');
|
||||
assert.equal(result.simulatorSessionId, 'session-2');
|
||||
assert.ok(waits.includes(10_000));
|
||||
// Five new sessions at most, waiting 10 s, 20 s, 40 s, 80 s and 120 s before them; then the failure to start is reported as one.
|
||||
const always = await fixture(t, { startsErrored: 6 });
|
||||
const backoff = [];
|
||||
await assert.rejects(runCiMap({ ...always.options, sleep: ms => { if (ms >= 10_000) backoff.push(ms); } }),
|
||||
error => error.code === 'SIMULATOR_START_FAILED' && /6 sessions ended before they were ready \(the last, session-6, ERRORED\)/.test(error.message)
|
||||
&& error.details.endedSessions.length === 6 && error.details.attempts === 6);
|
||||
assert.equal(always.requests.filter(request => request.args[0] === 'simulator:start').length, 6);
|
||||
assert.deepEqual(backoff, [10_000, 20_000, 40_000, 80_000, 120_000]);
|
||||
assert.equal(new Set(always.requests.filter(request => request.args[0] === 'simulator:start').map(request => value(request, '--name'))).size, 6, 'every session has its own name');
|
||||
// One session that ended is a failure to start too, not a question of ownership.
|
||||
const once = await fixture(t, { startsErrored: 6 });
|
||||
await assert.rejects(runCiMap({ ...once.options, sleep: () => {}, runner: request => {
|
||||
if (request.args[0] === 'simulator:start' && once.requests.filter(r => r.args[0] === 'simulator:start').length >= 1) throw new Error('Controller simulator:start exited with status 1: quota exhausted');
|
||||
return once.options.runner(request);
|
||||
} }), error => error.code === 'SIMULATOR_START_FAILED');
|
||||
});
|
||||
|
||||
test('new sessions stay within 30 minutes of the first failed start, each start capped by what is left', async t => {
|
||||
const f = await fixture(t, { startsErrored: 6 });
|
||||
let clock = Date.parse('2026-10-18T00:00:00Z');
|
||||
const timeouts = [];
|
||||
await assert.rejects(runCiMap({ ...f.options, now: () => clock, sleep: ms => { clock += ms; }, runner: request => {
|
||||
// Each start takes 10 minutes before EAS ends the session.
|
||||
if (request.args[0] === 'simulator:start') { timeouts.push(request.timeoutMs); clock += 10 * 60_000; }
|
||||
return f.options.runner(request);
|
||||
} }), error => error.code === 'SIMULATOR_START_FAILED');
|
||||
// The budget runs from the first failure, at 10:00, to 40:00. The start at 10:10 fits whole; those at 20:30 and 31:10
|
||||
// get only what is left (19:30, then 8:50); after 41:10 none starts.
|
||||
assert.deepEqual(timeouts, [20 * 60_000, 20 * 60_000, 19.5 * 60_000, (8 * 60 + 50) * 1000]);
|
||||
});
|
||||
|
||||
test('Ctrl+C while waiting for a new session stops the review instead of starting one', async t => {
|
||||
const f = await fixture(t, { startsErrored: 6 });
|
||||
const controller = new AbortController();
|
||||
await assert.rejects(runCiMap({ ...f.options, signal: controller.signal, sleep: () => controller.abort(new Error('interrupted')) }));
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'simulator:start').length, 1);
|
||||
});
|
||||
|
||||
test('a start that fails before naming a session stops any session of that name first, then starts a new one', async t => {
|
||||
const f = await fixture(t, { startsUnnamed: 1, orphanFromFailedStart: true });
|
||||
assert.equal((await runCiMap({ ...f.options, sleep: () => {} })).runStatus, 'complete');
|
||||
const order = f.requests.map(request => request.args[0] === 'simulator:stop' && value(request, '--id') === 'orphan-1' ? 'stop-orphan' : request.args[0] === 'simulator:start' ? 'start' : undefined).filter(Boolean);
|
||||
assert.deepEqual(order, ['start', 'stop-orphan', 'start']);
|
||||
// The last failed start is accounted for as well, though no new session follows it.
|
||||
const always = await fixture(t, { startsUnnamed: 6, orphanFromFailedStart: true });
|
||||
await assert.rejects(runCiMap({ ...always.options, sleep: () => {} }), error => error.code === 'SIMULATOR_START_FAILED');
|
||||
assert.equal(always.requests.filter(request => request.args[0] === 'simulator:stop' && value(request, '--id') === 'orphan-1').length, 6);
|
||||
});
|
||||
|
||||
test('a session of that name Explore cannot prove is its own is never stopped or replaced', async t => {
|
||||
const f = await fixture(t, { startsUnnamed: 1, orphanFromFailedStart: true, orphanUnproven: true });
|
||||
await assert.rejects(runCiMap({ ...f.options, sleep: () => {} }), error => error.code === 'SIMULATOR_START_FAILED');
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'simulator:start').length, 1);
|
||||
assert.equal(f.requests.some(request => request.args[0] === 'simulator:stop'), false);
|
||||
});
|
||||
|
||||
test('a session Explore cannot prove is its own is never replaced, even one that ERRORED', async t => {
|
||||
const f = await fixture(t, { wrongProject: true, startsErrored: 1 });
|
||||
await assert.rejects(runCiMap(f.options), error => /SESSION_HANDOFF_UNVERIFIED/.test(JSON.stringify(error)));
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'simulator:start').length, 1);
|
||||
});
|
||||
|
||||
test('account failures to start are not retried; temporary ones and timeouts are', async t => {
|
||||
for (const [message, retried] of [['GraphQL request failed: not authorized', false], ['quota exhausted', false], ['GraphQL request failed.', true], ['No simulator capacity for iPhone Duo', true]]) {
|
||||
const f = await fixture(t);
|
||||
let starts = 0;
|
||||
const run = runCiMap({ ...f.options, sleep: () => {}, runner: request => {
|
||||
if (request.args[0] === 'simulator:start' && ++starts === 1) { writeFileSync(join(request.cwd, '.env.eas-simulator'), HEADER); throw new Error(`Controller simulator:start exited with status 1: ${message}`); }
|
||||
return f.options.runner(request);
|
||||
} });
|
||||
if (retried) assert.equal((await run).runStatus, 'complete', message); else await assert.rejects(run, error => error.code === 'SIMULATOR_START_FAILED', message);
|
||||
assert.equal(starts, retried ? 2 : 1, message);
|
||||
}
|
||||
});
|
||||
|
||||
test('an Argent capture of an app pinned to dark is labelled dark and is not warned about', async t => {
|
||||
const f = await fixture(t, { argent: true, userInterfaceStyle: 'dark' });
|
||||
const lines = [];
|
||||
@@ -489,20 +669,45 @@ test('an Argent capture of an app pinned to dark is labelled dark and is not war
|
||||
assert.equal(execution.colorScheme, 'dark');
|
||||
});
|
||||
|
||||
test('device.pose folds the device first, before the app is opened, read or captured', async t => {
|
||||
for (const argent of [false, true]) {
|
||||
const f = await fixture(t, { devicePose: 'open', argent });
|
||||
assert.equal((await runCiMap(f.options)).runStatus, 'complete');
|
||||
const controller = f.requests.filter(request => request.command === 'fake-controller' || request.command.endsWith('/argent-controller'));
|
||||
const folds = controller.filter(request => request.args[0] === 'fold');
|
||||
assert.equal(folds.length, 1);
|
||||
assert.deepEqual(folds[0].args.slice(0, 2), ['fold', 'open']);
|
||||
const foldAt = controller.indexOf(folds[0]);
|
||||
// The fold comes first: the app is installed but not opened, read or captured before it, so the controller starts on the lit panel.
|
||||
assert.deepEqual(controller.slice(0, foldAt).map(request => request.args[0]).filter(command => command !== '--version' && command !== 'install'), []);
|
||||
// Argent's bridge is told the pose, so it captures the opened panel's landscape UI upright.
|
||||
if (argent) for (const request of controller) assert.equal(request.environment.EXPLORE_ARGENT_POSE, 'open');
|
||||
test('device.pose with Argent folds the device first, before the app is opened, read or captured', async t => {
|
||||
const f = await fixture(t, { devicePose: 'open', argent: true });
|
||||
assert.equal((await runCiMap(f.options)).runStatus, 'complete');
|
||||
const controller = f.requests.filter(request => request.command.endsWith('/argent-controller'));
|
||||
const folds = controller.filter(request => request.args[0] === 'fold');
|
||||
assert.equal(folds.length, 1);
|
||||
assert.deepEqual(folds[0].args.slice(0, 2), ['fold', 'open']);
|
||||
const foldAt = controller.indexOf(folds[0]);
|
||||
// The fold comes first: the app is installed but not opened, read or captured before it, so the controller starts on the lit panel.
|
||||
assert.deepEqual(controller.slice(0, foldAt).map(request => request.args[0]).filter(command => command !== '--version' && command !== 'install'), []);
|
||||
// Argent's bridge is told the pose, so it captures the opened panel's landscape UI upright.
|
||||
for (const request of controller) assert.equal(request.environment.EXPLORE_ARGENT_POSE, 'open');
|
||||
});
|
||||
|
||||
test('device.pose with agent-device on EAS opens the app, folds, and checks the display it lit', async t => {
|
||||
const f = await fixture(t, { devicePose: 'open' });
|
||||
assert.equal((await runCiMap({ ...f.options, sleep: () => {} })).runStatus, 'complete');
|
||||
const controller = f.requests.filter(request => request.command === 'fake-controller').map(request => request.args[0] === 'screenshot' && request.args[1].endsWith('/pose.png') ? 'pose' : request.args[0]);
|
||||
// agent-device folds only inside a session, so the app opens first; the fold's hinge readback is not trusted, the display is.
|
||||
assert.deepEqual(controller.filter(command => command !== '--version' && command !== 'install').slice(0, 3), ['open', 'fold', 'pose']);
|
||||
assert.equal(f.requests.some(request => request.args[0] === 'simulator:control' && request.args[1] === 'springboard.restart'), false);
|
||||
});
|
||||
|
||||
test('when an agent-device fold on EAS lights a black panel, the capture restarts SpringBoard, reopens the app and folds again, once', async t => {
|
||||
for (const [black, completes] of [[1, true], [2, false]]) {
|
||||
const f = await fixture(t, { devicePose: 'open', blackAfterFold: black, controlActions: ['springboard.restart'] });
|
||||
const lines = [];
|
||||
const run = runCiMap({ ...f.options, sleep: () => {}, progress: line => lines.push(line) });
|
||||
if (completes) assert.equal((await run).runStatus, 'complete');
|
||||
else await assert.rejects(run, error => JSON.stringify(error).includes('CONTROLLER_READER_STUCK'));
|
||||
const controller = f.requests.filter(request => request.command === 'fake-controller');
|
||||
assert.equal(controller.filter(request => request.args[0] === 'fold').length, 2);
|
||||
assert.ok(controller.some(request => request.args[0] === 'open' && request.args.includes('--relaunch')), 'the app is reopened after SpringBoard');
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'simulator:control' && request.args[1] === 'springboard.restart').length, 1);
|
||||
assert.ok(lines.some(line => /did not draw the open display after the fold; restarting SpringBoard/.test(line)), lines.join('\n'));
|
||||
}
|
||||
// Without springboard.restart (an older serve-sim), a black panel is reported at once.
|
||||
const older = await fixture(t, { devicePose: 'open', blackAfterFold: 1 });
|
||||
await assert.rejects(runCiMap({ ...older.options, sleep: () => {} }), error => JSON.stringify(error).includes('CONTROLLER_FOLD_UNVERIFIED'));
|
||||
});
|
||||
|
||||
test('a local simulator capture creates its own iOS simulator, installs the repacked app there, and deletes the simulator', async t => {
|
||||
|
||||
@@ -48,12 +48,12 @@ test('any two commits: a capture and report like a pull request\'s, with no pull
|
||||
environment: { ...f.environment, GITHUB_TOKEN: '', GITHUB_STEP_SUMMARY: targetSummary }, transport: async input => assert.fail(`no GitHub request: ${input}`) });
|
||||
assert.match(await readFile(targetSummary, 'utf8'), /^- iPhone Duo \\\[open\\\] report of `v1\.1\.0` vs `v1\.0\.0`: \[Open\]\(https:\/\/explore-preview\.expo\.app\/\?repo=acme%2Fexample&run=1234&attempt=1&target=duo-open&artifact=900\) · /);
|
||||
|
||||
const summary = renderCompareSummary(result.review.pullRequest, 'https://example.expo.app/p/token', null, [await readCiReportInput(result.inputPath)]);
|
||||
const summary = renderCompareSummary(result.review.pullRequest, 'https://example.expo.app/p/token', [await readCiReportInput(result.inputPath)]);
|
||||
assert.match(summary, /^### Explore: `v1\.1\.0` vs `v1\.0\.0`$/m);
|
||||
// Refs are code spans: one with ] ( ) would otherwise break the line's links. A caller's own title is one span.
|
||||
const odd = { ...result.review.pullRequest, base: { ...result.review.pullRequest.base, ref: 'x](evil)' }, title: 'v1.1.0 vs x](evil)' };
|
||||
assert.match(renderCompareSummary(odd, 'https://example.expo.app/p/token', null, []), /^### Explore: `v1\.1\.0` vs `x\]\(evil\)`$/m);
|
||||
assert.match(renderCompareSummary({ ...odd, title: 'Nightly `build`' }, 'https://example.expo.app/p/token', null, []), /^### Explore: `Nightly 'build'`$/m);
|
||||
assert.match(renderCompareSummary(odd, 'https://example.expo.app/p/token', []), /^### Explore: `v1\.1\.0` vs `x\]\(evil\)`$/m);
|
||||
assert.match(renderCompareSummary({ ...odd, title: 'Nightly `build`' }, 'https://example.expo.app/p/token', []), /^### Explore: `Nightly 'build'`$/m);
|
||||
|
||||
// capture:review's preview output starts the deploy job only when the reviewed config hosts the report.
|
||||
const outputs = join(f.root, 'outputs');
|
||||
|
||||
@@ -639,8 +639,12 @@ test("doctor checks each target where it runs: local tools for local targets, EA
|
||||
targets: { phone: { platform: "ios" }, cloud: { platform: "ios", device: "iPhone 17 Pro", simulator: "eas", controller: "argent" } } });
|
||||
assert.deepEqual(devices(mixed), ["iPhone 17"]);
|
||||
assert.equal(check(mixed, "eas-simulator")[0].status, "pass");
|
||||
// The target's Argent is reported as a top-level one would be.
|
||||
assert.equal(check(mixed, "controller")[0].code, "CONTROLLER_APPEARANCE_FIXED");
|
||||
// The target's Argent is reported as a top-level one would be: on an iOS EAS session the host switches its appearance.
|
||||
assert.equal(check(mixed, "controller")[0].status, "pass");
|
||||
// Only Argent on an Android EAS session records a single appearance.
|
||||
const android = await doctor({ ...baseConfig, targets: { phone: { platform: "ios" },
|
||||
droid: { platform: "android", device: "pixel_7", bundleId: "com.example.app", easProfile: "explore-android", controller: "argent" } } });
|
||||
assert.equal(check(android, "controller")[0].code, "CONTROLLER_APPEARANCE_FIXED");
|
||||
// --simulator and --controller decide for every target, as they do in a capture.
|
||||
const forced = await doctor({ ...baseConfig, targets: { phone: { platform: "ios", simulator: "local", controller: "argent" } } }, { simulator: "eas", controller: "agent-device" });
|
||||
assert.deepEqual(devices(forced), []);
|
||||
|
||||
@@ -130,7 +130,7 @@ function runtimeFor(side, map, expectedSamples = 3, capturedSamples = expectedSa
|
||||
observationId: observation.id,
|
||||
expectedSampleCount: expectedSamples,
|
||||
controllerPackageVersion: "0.20.2",
|
||||
easCliVersion: "25.0.0",
|
||||
easCliVersion: "25.2.0",
|
||||
},
|
||||
runtime: {
|
||||
kind: "eas-agent-device-raw",
|
||||
|
||||
@@ -173,24 +173,32 @@ test("agent instruction files must exist inside the repository", async (t) => {
|
||||
assert.equal((await readExploreConfig(project)).agent.instructions, ".expo-explore/instructions.md");
|
||||
});
|
||||
|
||||
test("report.preview opts into hosted previews with a bounded expiry and an optional project slug", () => {
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas" } } }).report,
|
||||
{ preview: { hosting: "eas", expiresAfterDays: 30 } });
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas", expiresAfter: "14 days", owner: "acme", project: "acme-explore" } } }).report,
|
||||
{ preview: { hosting: "eas", expiresAfterDays: 14, owner: "acme", project: "acme-explore" } });
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas", expiresAfter: 3 } } }).report?.preview?.expiresAfterDays, 3);
|
||||
assert.equal(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas", expiresAfter: "365d" } } }).report?.preview?.expiresAfterDays, 365);
|
||||
assert.equal(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas", expiresAfter: "never" } } }).report?.preview?.expiresAfterDays, null);
|
||||
test("report.preview opts into hosted previews with an optional owner and project slug; an expiry from older configs is ignored", () => {
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas" } } }).report, { preview: { hosting: "eas" } });
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas", owner: "acme", project: "acme-explore" } } }).report,
|
||||
{ preview: { hosting: "eas", owner: "acme", project: "acme-explore" } });
|
||||
// A hosted preview lasts as long as its EAS Hosting deployment: an old config's expiresAfter still validates, and is only noted.
|
||||
for (const expiresAfter of ["14 days", 3, "never", "forever"]) {
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { preview: { hosting: "eas", expiresAfter } } }).report, { preview: { hosting: "eas", expiresAfterIgnored: true } });
|
||||
}
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: {} }).report, {});
|
||||
assert.equal(validateExploreConfig(base()).report, undefined);
|
||||
for (const preview of [{ hosting: "vercel" }, { hosting: "eas", expiresAfter: "366d" }, { hosting: "eas", expiresAfter: "0d" }, { hosting: "eas", expiresAfter: "forever" },
|
||||
{ hosting: "eas", expiresAfter: "2 weeks" }, { hosting: "eas", project: "Acme" },
|
||||
for (const preview of [{ hosting: "vercel" }, { hosting: "eas", project: "Acme" },
|
||||
{ hosting: "eas", owner: "Acme Org" }, { hosting: "eas", token: "x" }, {}]) {
|
||||
assert.throws(() => validateExploreConfig({ ...base(), report: { preview } }), /Invalid .expo-explore\/config.yaml: report.preview/);
|
||||
}
|
||||
assert.throws(() => validateExploreConfig({ ...base(), report: { hosting: "eas" } }), /report/);
|
||||
});
|
||||
|
||||
test("report.comment.map opts the PR comment into its map of changed screens, beside or without a hosted preview", () => {
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { comment: { map: true } } }).report, { comment: { map: true } });
|
||||
assert.deepEqual(validateExploreConfig({ ...base(), report: { comment: { map: false }, preview: { hosting: "eas" } } }).report,
|
||||
{ comment: { map: false }, preview: { hosting: "eas" } });
|
||||
for (const comment of [{}, { map: "yes" }, { map: true, graph: true }, true]) {
|
||||
assert.throws(() => validateExploreConfig({ ...base(), report: { comment } }), /Invalid .expo-explore\/config.yaml: report.comment/);
|
||||
}
|
||||
});
|
||||
|
||||
test("platforms: a flat config is iOS-only and resolves to itself", () => {
|
||||
const config = validateExploreConfig(base());
|
||||
assert.deepEqual(configPlatforms(config), ["ios"]);
|
||||
|
||||
@@ -0,0 +1,28 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
|
||||
const { tsImport } = await import("tsx/esm/api");
|
||||
const { heldKeyHint, shortcutModifiers } = await tsImport("../../viewer/src/utils/held-modifiers.ts", import.meta.url);
|
||||
const { SHORTCUTS } = await tsImport("../../viewer/src/utils/shortcuts.ts", import.meta.url);
|
||||
|
||||
const held = (keys) => ({ shift: false, ctrl: false, meta: false, alt: false, ...keys });
|
||||
|
||||
test("holding a chord's modifiers shows the key that completes it; anything else shows nothing", () => {
|
||||
assert.equal(heldKeyHint(SHORTCUTS.canvasByNumber.map, held({ ctrl: true }), true), "1");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.canvasByNumber.compare, held({ ctrl: true }), true), "3");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.camera.fit, held({ shift: true }), true), "1");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.appearance.app, held({ shift: true }), true), "T");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.canvasByNumber.map, held({ shift: true }), true), undefined, "the wrong modifier");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.canvasByNumber.map, held({ ctrl: true, shift: true }), true), undefined, "an extra modifier");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.canvas.map, held({ ctrl: true }), true), undefined, "a plain key has no chord");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.canvasByNumber.map, held({}), true), undefined, "nothing held");
|
||||
});
|
||||
|
||||
test("mod is ⌘ on Apple keyboards and Ctrl elsewhere", () => {
|
||||
assert.equal(heldKeyHint(SHORTCUTS.app.search, held({ meta: true }), true), "K");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.app.search, held({ ctrl: true }), true), undefined);
|
||||
assert.equal(heldKeyHint(SHORTCUTS.app.search, held({ ctrl: true }), false), "K");
|
||||
assert.equal(heldKeyHint(SHORTCUTS.app.search, held({ meta: true }), false), undefined);
|
||||
assert.deepEqual(shortcutModifiers(SHORTCUTS.app.search, true), held({ meta: true }));
|
||||
assert.deepEqual(shortcutModifiers(SHORTCUTS.app.search, false), held({ ctrl: true }));
|
||||
});
|
||||
@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
|
||||
const { tsImport } = await import("tsx/esm/api");
|
||||
const { HOLD_INITIAL_DELAY_MS, HOLD_FIRST_INTERVAL_MS, HOLD_FLOOR_INTERVAL_MS, holdIntervalMs, holdSchedule } =
|
||||
const { HOLD_INITIAL_DELAY_MS, HOLD_FIRST_INTERVAL_MS, HOLD_FLOOR_INTERVAL_MS, createKeyHold, glideRate, holdIntervalMs, holdSchedule } =
|
||||
await tsImport("../../viewer/src/utils/key-hold.ts", import.meta.url);
|
||||
|
||||
test("a held paging key waits, then steps sooner and sooner down to a floor", () => {
|
||||
@@ -16,3 +16,70 @@ test("a held paging key waits, then steps sooner and sooner down to a floor", ()
|
||||
assert.ok(schedule.at(-1) < 2000, "six held steps fit in two seconds");
|
||||
assert.ok(HOLD_INITIAL_DELAY_MS > HOLD_FIRST_INTERVAL_MS, "the hold begins slower than it repeats");
|
||||
});
|
||||
|
||||
test("a held key steps on the schedule from its first step, and ends when a step finds nothing", (t) => {
|
||||
t.mock.timers.enable({ apis: ["setTimeout"] });
|
||||
const hold = createKeyHold();
|
||||
let steps = 0;
|
||||
hold.begin("ArrowRight", () => (steps += 1) < 3);
|
||||
assert.ok(hold.holding("ArrowRight"));
|
||||
assert.ok(!hold.holding("ArrowLeft"));
|
||||
t.mock.timers.tick(HOLD_INITIAL_DELAY_MS - 1);
|
||||
assert.equal(steps, 0, "nothing before the initial delay");
|
||||
t.mock.timers.tick(1);
|
||||
assert.equal(steps, 1, "the second step lands after the initial delay");
|
||||
t.mock.timers.tick(holdIntervalMs(1));
|
||||
assert.equal(steps, 2);
|
||||
t.mock.timers.tick(holdIntervalMs(2));
|
||||
assert.equal(steps, 3, "the third attempt finds nothing");
|
||||
assert.ok(!hold.holding("ArrowRight"), "and the hold ends by itself");
|
||||
t.mock.timers.tick(10_000);
|
||||
assert.equal(steps, 3, "no further steps");
|
||||
});
|
||||
|
||||
test("ending a hold, or beginning another key, stops the first", (t) => {
|
||||
t.mock.timers.enable({ apis: ["setTimeout"] });
|
||||
const hold = createKeyHold();
|
||||
let right = 0;
|
||||
let left = 0;
|
||||
hold.begin("ArrowRight", () => { right += 1; return true; });
|
||||
t.mock.timers.tick(HOLD_INITIAL_DELAY_MS);
|
||||
assert.equal(right, 1);
|
||||
hold.begin("ArrowLeft", () => { left += 1; return true; });
|
||||
assert.ok(!hold.holding("ArrowRight"));
|
||||
assert.ok(hold.holding("ArrowLeft"));
|
||||
// Mock timers run one scheduled round per tick; a hold schedules the next step from each step.
|
||||
t.mock.timers.tick(HOLD_INITIAL_DELAY_MS);
|
||||
t.mock.timers.tick(holdIntervalMs(1));
|
||||
assert.equal(right, 1, "the first key stopped stepping");
|
||||
assert.equal(left, 2);
|
||||
hold.end();
|
||||
assert.ok(!hold.holding("ArrowLeft"));
|
||||
t.mock.timers.tick(holdIntervalMs(2));
|
||||
t.mock.timers.tick(1000);
|
||||
assert.equal(left, 2);
|
||||
});
|
||||
|
||||
test("another key ends a hold, as the OS's own repeat stops; its own repeats and a modifier do not", () => {
|
||||
const key = (code, key = code, repeat = false) => ({ code, key, repeat });
|
||||
const hold = createKeyHold();
|
||||
hold.begin("ArrowDown", () => true);
|
||||
hold.interrupt(key("ArrowDown", "ArrowDown", true));
|
||||
hold.interrupt(key("ShiftLeft", "Shift"));
|
||||
hold.interrupt(key("MetaLeft", "Meta"));
|
||||
assert.ok(hold.holding("ArrowDown"), "its own repeat and a modifier leave it held");
|
||||
hold.interrupt(key("Escape"));
|
||||
assert.ok(!hold.holding("ArrowDown"), "Esc ends it");
|
||||
hold.begin("ArrowDown", () => true);
|
||||
hold.interrupt(key("KeyK", "k"));
|
||||
assert.ok(!hold.holding("ArrowDown"), "so does the K of ⌘K");
|
||||
hold.end();
|
||||
});
|
||||
|
||||
test("a glide picks up from rest, then eases from the stepped hold's first speed up to its top speed", () => {
|
||||
assert.equal(glideRate(0), 0, "it starts at rest, where the tap's step ended");
|
||||
assert.ok(Math.abs(glideRate(80) - 1000 / HOLD_FIRST_INTERVAL_MS) < 0.2, "within a few frames it moves a step per first interval");
|
||||
for (let at = 10; at <= 1200; at += 10) assert.ok(glideRate(at) >= glideRate(at - 10), `never slows, at ${at}ms`);
|
||||
assert.equal(glideRate(1000), 1000 / HOLD_FLOOR_INTERVAL_MS, "after a second, a step per floor interval");
|
||||
assert.equal(glideRate(5000), glideRate(1000), "and no faster");
|
||||
});
|
||||
@@ -8,6 +8,9 @@ import { join } from 'node:path';
|
||||
import { appEnvironment, captureCacheDirectory, defaultBase, installDependencies, keepCapture, localInstallCommand, localReviewConfig, reportRef, reviewHeadSource, runLocalReview, snapshotWorkingTree, stopRecordedSessions } from '../../dist/ci/local-review.js';
|
||||
import { mkdir, readdir } from 'node:fs/promises';
|
||||
import { startLocalReportServer } from '../../dist/report/local-report-server.js';
|
||||
import { loadReport } from '../../dist/report/agent-api.js';
|
||||
import { manifestBody } from '../../dist/report/preview-manifest.js';
|
||||
import { createHash } from 'node:crypto';
|
||||
import { fixture, git } from '../helpers/public-ci-fixture.mjs';
|
||||
import { writeCaptureObserverPackages } from '../helpers/capture-observer-fixture.mjs';
|
||||
|
||||
@@ -229,6 +232,30 @@ test('the local Viewer serves each target of a run, by ?target= or, for links fr
|
||||
[['phone', 'iPhone 17'], ['duo-open', 'iPhone Duo (open)'], ['android', 'Android']]);
|
||||
});
|
||||
|
||||
test('the local Viewer serves the manifest and assets the Viewer opens, the same bytes the hosted Worker serves', async t => {
|
||||
const viewerRoot = await scratch(t, 'explore-local-viewer-');
|
||||
await writeFile(join(viewerRoot, 'index.html'), '<!doctype html><title>Viewer</title>');
|
||||
const review = new Uint8Array(await readFile(new URL('../fixtures/example-review-artifact.zip', import.meta.url)));
|
||||
const reports = [{ platform: 'ios', zip: review }, { platform: 'android', zip: new Uint8Array([4]) }];
|
||||
const server = await startLocalReportServer({ reports, viewerRoot });
|
||||
t.after(() => server.close());
|
||||
const loaded = await loadReport(review);
|
||||
const manifest = await fetch(`${server.url}/manifest.json`);
|
||||
assert.equal(manifest.status, 200);
|
||||
assert.match(manifest.headers.get('content-type') ?? '', /^application\/json/);
|
||||
assert.equal(await manifest.text(), manifestBody(loaded));
|
||||
const [asset] = Object.keys(JSON.parse(manifestBody(loaded)).entries);
|
||||
// An asset is named by its SHA-256, as a hosted preview's static files are, so it carries no target and comes from whichever report holds it.
|
||||
const served = await fetch(`${server.url}/${asset}`);
|
||||
assert.equal(served.status, 200);
|
||||
assert.equal(served.headers.get('content-type'), 'image/png');
|
||||
assert.equal(createHash('sha256').update(new Uint8Array(await served.arrayBuffer())).digest('hex'), asset.slice('assets/'.length, 'assets/'.length + 64));
|
||||
assert.equal((await fetch(`${server.url}/${asset}?platform=android`)).status, 200, 'a target query changes nothing');
|
||||
for (const path of [`/assets/${'0'.repeat(64)}.png`, '/assets/review.json', '/manifest.json?platform=android', '/manifest.json?target=tablet']) {
|
||||
assert.equal((await fetch(`${server.url}${path}`)).status, 404, path);
|
||||
}
|
||||
});
|
||||
|
||||
test('a local review captures two commits of the repository in its own worktrees and packages a report', async t => {
|
||||
const f = await fixture(t, 'expo-router');
|
||||
t.mock.method(globalThis, 'fetch', async input => assert.fail(`Unmocked network request: ${input}`));
|
||||
|
||||
@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
|
||||
const { tsImport } = await import("tsx/esm/api");
|
||||
const { mapKeyDirection, mapKeyTarget } = await tsImport("../../viewer/src/utils/map-keyboard.ts", import.meta.url);
|
||||
const { mapKeyDirection, mapKeyEntry, mapKeyTarget } = await tsImport("../../viewer/src/utils/map-keyboard.ts", import.meta.url);
|
||||
|
||||
// A top-to-bottom map: root fans out to a, b, c on one rank; b leads on to d; e is a stray rank with no edges.
|
||||
// root
|
||||
@@ -100,3 +100,11 @@ test("a left-to-right map needs no special case: the keys read positions", () =>
|
||||
assert.equal(mapKeyTarget(rotated, "a", "down"), "b");
|
||||
assert.equal(mapKeyTarget(rotated, "c", "up"), "b");
|
||||
});
|
||||
|
||||
test("with nothing selected, an arrow enters the map at the edge it moves away from, as Screens' arrows do", () => {
|
||||
assert.equal(mapKeyEntry(structure, "down"), "root", "down starts at the top");
|
||||
assert.equal(mapKeyEntry(structure, "up"), "d", "up starts at the bottom; the leftmost of that rank");
|
||||
assert.equal(mapKeyEntry(structure, "right"), "a", "right starts at the left edge");
|
||||
assert.equal(mapKeyEntry(structure, "left"), "e", "left starts at the right edge");
|
||||
assert.equal(mapKeyEntry({ positions: new Map() }, "down"), undefined, "an empty map has no entry");
|
||||
});
|
||||
@@ -268,3 +268,13 @@ test("unknown values fall back without disturbing the rest", () => {
|
||||
{ ...base, canvas: "screens" },
|
||||
);
|
||||
});
|
||||
|
||||
test("another target's report opens at the same canvas and route, keeping only what means the same there", () => {
|
||||
assert.equal(nav.placeForAnotherTarget("#/compare/settings/profile?screen=s-12&variant=v2&baseline=build-0.9&inspect=diff&focus=modified,added&dir=in&expand=g1&evidence=logs"),
|
||||
"#/compare/settings/profile?inspect=diff&dir=in&focus=modified,added");
|
||||
assert.equal(nav.placeForAnotherTarget("#/map/home"), "#/map/home");
|
||||
assert.equal(nav.placeForAnotherTarget("#/screens?screen=s-3"), "#/screens");
|
||||
// No place, or a hash from before routes: the other report opens where a link to it would.
|
||||
assert.equal(nav.placeForAnotherTarget(""), "");
|
||||
assert.equal(nav.placeForAnotherTarget("#map"), "");
|
||||
});
|
||||
@@ -7,11 +7,12 @@ import test from "node:test";
|
||||
import { prepareCaptureReview } from "../../dist/review/capture-review.js";
|
||||
import { createSourceCapturePlan } from "../../dist/source/capture-plan.js";
|
||||
import { writeCiReportInput, exportCiReport } from "../../dist/report/artifact.js";
|
||||
import { collectPlatformReports, deployExplorationReport, deployFixturePreview, deployLocalReports, deployPreview, previewProjectSlug, readReportZip, sealReport, whoamiAccounts, zipReportDirectory } from "../../dist/report/preview-deploy.js";
|
||||
import { collectPlatformReports, deployExplorationReport, deployFixturePreview, deployLocalReports, fixtureReports, deployPreview, previewProjectSlug, readReportZip, whoamiAccounts, zipReportDirectory } from "../../dist/report/preview-deploy.js";
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { createDecipheriv } from "node:crypto";
|
||||
import { ZipReader, Uint8ArrayReader, TextWriter, configure } from "@zip.js/zip.js";
|
||||
import { viewerLinks } from "../../dist/report/viewer-links.js";
|
||||
import { loadReport } from "../../dist/report/agent-api.js";
|
||||
import { manifestBody } from "../../dist/report/preview-manifest.js";
|
||||
|
||||
const png = Buffer.from("iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+A8AAQUBAScY42YAAAAASUVORK5CYII=", "base64");
|
||||
const sha256 = createHash("sha256").update(png).digest("hex");
|
||||
@@ -21,7 +22,7 @@ const pr = { repositoryId: "123", repository: "expo/explore-playground", number:
|
||||
const artifactUrl = "https://github.com/expo/explore-playground/actions/runs/10/artifacts/20";
|
||||
const environment = { GITHUB_TOKEN: "test-token", GITHUB_RUN_ID: "10", GITHUB_RUN_ATTEMPT: "1", GITHUB_REPOSITORY: pr.repository };
|
||||
|
||||
async function fixture(t, { verified = true, preview = { hosting: "eas", expiresAfterDays: 7 }, presentation = pr } = {}) {
|
||||
async function fixture(t, { verified = true, preview = { hosting: "eas" }, presentation = pr } = {}) {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-artifact-ci-"));
|
||||
t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const files = new Map([["app/index.tsx", "export default function Home() { return null; }"]]);
|
||||
@@ -53,6 +54,12 @@ async function fixture(t, { verified = true, preview = { hosting: "eas", expires
|
||||
configure({ useWebWorkers: false });
|
||||
const TOKEN_RE = /^[a-z2-7]{32}$/;
|
||||
|
||||
/** The fixture report as an explore:binary exploration the Worker (and so the deploy check) can open: exploration.json, same assets. */
|
||||
async function asExploration(reportPath) {
|
||||
await rm(join(reportPath, "review.json"));
|
||||
await writeFile(join(reportPath, "exploration.json"), JSON.stringify({ kind: "explore.exploration-report", map: { screens: [] } }));
|
||||
}
|
||||
|
||||
async function exportFixture(t, options) {
|
||||
const { root, inputPath } = await fixture(t, options);
|
||||
const reportPath = join(root, "report");
|
||||
@@ -66,7 +73,7 @@ async function exportFixture(t, options) {
|
||||
}
|
||||
|
||||
/** A fake EAS CLI plus a fake deployment: `deploy` captures the sealed report and .env, then serves them like the Worker would. */
|
||||
function easFixture({ origin = "https://acme-explore--1lcbdcpwn3.expo.app", aliasOrigin = "https://acme-explore--bluesky.expo.app", accounts = ["brent-org"], failDeploy = false, aliasServes = true, aliasListing, existingComment } = {}) {
|
||||
function easFixture({ origin = "https://acme-explore--1lcbdcpwn3.expo.app", aliasOrigin = "https://acme-explore--bluesky.expo.app", accounts = ["brent-org"], failDeploy = false, aliasServes = true, aliasListing, existingComment, manifestServes = true, robotsServes = true } = {}) {
|
||||
let deploys = 0;
|
||||
let latestComment = existingComment;
|
||||
const calls = []; const captured = {};
|
||||
@@ -81,12 +88,19 @@ function easFixture({ origin = "https://acme-explore--1lcbdcpwn3.expo.app", alia
|
||||
if (args[0] === "deploy") {
|
||||
deploys += 1;
|
||||
if (failDeploy === "alias-limit") return { status: 1, stdout: "", stderr: "✔ Created deployment\n✖ Failed to assign pr-7 alias to deployment\nThis account has reached the limit of 5 aliases from the Free plan. Upgrade your plan to raise the limit on the amount of aliases you can create for your deployments. https://expo.dev/accounts/acme/settings/billing\nRequest ID: 341b47a1\n Error: GraphQL request failed." };
|
||||
// eas names the file whose upload failed, and every static file's path carries the link's token.
|
||||
if (failDeploy === "upload-path") {
|
||||
const token = /EXPLORE_PREVIEW_TOKEN=(\S+)/.exec(readFileSyncUtf8(join(options.cwd, ".env")))[1];
|
||||
return { status: 1, stdout: "", stderr: `Upload of "client/p/${token}/assets/${sha256}.png" failed: 502\n Upload failed` };
|
||||
}
|
||||
if (failDeploy === true || deploys <= failDeploy) return { status: 1, stdout: "", stderr: "Error: GraphQL request failed.\n Upload failed" };
|
||||
captured.env = Object.fromEntries(readFileSyncUtf8(join(options.cwd, ".env")).trim().split("\n").map(line => line.split(/=(.*)/s).slice(0, 2)));
|
||||
captured.listing = captured.env.EXPLORE_PREVIEW_REPORTS ? JSON.parse(captured.env.EXPLORE_PREVIEW_REPORTS) : [{ platform: "ios", path: captured.env.EXPLORE_PREVIEW_REPORT }];
|
||||
captured.sealedFiles = Object.fromEntries(captured.listing.map(entry => [entry.path, readFileSyncBytes(join(options.cwd, "dist", "client", entry.path))]));
|
||||
captured.sealed = captured.sealedFiles[captured.listing[0].path];
|
||||
// The report's static files, by the path EAS Hosting serves each at.
|
||||
const tokenDirectory = join(options.cwd, "dist", "client", "p", captured.env.EXPLORE_PREVIEW_TOKEN);
|
||||
captured.files = Object.fromEntries(readdirTree(tokenDirectory).map(file => [`/p/${captured.env.EXPLORE_PREVIEW_TOKEN}/${file}`, readFileSyncBytes(join(tokenDirectory, file))]));
|
||||
captured.hasViewer = existsSyncLocal(join(options.cwd, "dist", "client", "viewer", "index.html"));
|
||||
captured.robots = existsSyncLocal(join(options.cwd, "dist", "client", "robots.txt")) ? readFileSyncUtf8(join(options.cwd, "dist", "client", "robots.txt")) : undefined;
|
||||
const alias = args.includes("--alias") ? args[args.indexOf("--alias") + 1] : undefined;
|
||||
captured.alias = alias;
|
||||
const aliases = alias ? [{ id: "al1", url: aliasOrigin, name: alias }] : undefined;
|
||||
@@ -100,7 +114,10 @@ function easFixture({ origin = "https://acme-explore--1lcbdcpwn3.expo.app", alia
|
||||
// An alias that has not moved to the new deployment yet: it answers for an earlier token, so this one is 404.
|
||||
if (!aliasServes && url.origin === aliasOrigin) return new Response("Not found", { status: 404 });
|
||||
if (url.origin === origin || (captured.alias && url.origin === aliasOrigin)) {
|
||||
const match = /^\/p\/([a-z2-7]{32})(?:\/(report\.zip|reports\.json|api\/v1))?$/.exec(url.pathname);
|
||||
// EAS Hosting serves a deployment's static file before the Worker sees the request.
|
||||
if (captured.files?.[url.pathname]) return new Response(captured.files[url.pathname], { status: 200 });
|
||||
if (url.pathname === "/robots.txt" && captured.robots !== undefined && robotsServes) return new Response(captured.robots, { status: 200, headers: { "content-type": "text/plain" } });
|
||||
const match = /^\/p\/([a-z2-7]{32})(?:\/(reports\.json|manifest\.json|api\/v1))?$/.exec(url.pathname);
|
||||
if (!captured.env || !match || match[1] !== captured.env.EXPLORE_PREVIEW_TOKEN) return new Response("Not found", { status: 404 });
|
||||
// The token page negotiates like the real Worker: only a request that asks for HTML gets the shell.
|
||||
if (!match[2]) return (options.headers?.accept ?? "").includes("text/html")
|
||||
@@ -114,12 +131,9 @@ function easFixture({ origin = "https://acme-explore--1lcbdcpwn3.expo.app", alia
|
||||
const target = url.searchParams.get("target"), platform = url.searchParams.get("platform");
|
||||
const entry = target ? captured.listing.find(candidate => candidate.target === target)
|
||||
: platform ? captured.listing.find(candidate => candidate.target === platform) ?? captured.listing.find(candidate => candidate.platform === platform) : captured.listing[0];
|
||||
if (!entry) return new Response("Not found", { status: 404 });
|
||||
const key = Buffer.from(captured.env.EXPLORE_PREVIEW_KEY, "base64"); const sealed = Buffer.from(captured.sealedFiles[entry.path]);
|
||||
const decipher = createDecipheriv("aes-256-gcm", key, sealed.subarray(0, 12));
|
||||
decipher.setAAD(Buffer.from("expo-explore-preview/1")); decipher.setAuthTag(sealed.subarray(-16));
|
||||
const plain = Buffer.concat([decipher.update(sealed.subarray(12, -16)), decipher.final()]);
|
||||
return new Response(plain, { status: 200, headers: { "content-type": "application/zip" } });
|
||||
// The manifest the Viewer opens, from the target's static file; manifestServes: false is a Worker that cannot read it.
|
||||
const manifest = entry && manifestServes ? captured.files[entry.path] : undefined;
|
||||
return manifest ? new Response(manifest, { status: 200, headers: { "content-type": "application/json; charset=utf-8" } }) : new Response("Not found", { status: 404 });
|
||||
}
|
||||
const artifactNames = { 20: "explore-review-10-1", 21: "explore-review-10-1-ios", 22: "explore-review-10-1-android" };
|
||||
const byId = /\/actions\/artifacts\/(\d+)$/.exec(url.pathname);
|
||||
@@ -138,10 +152,13 @@ function easFixture({ origin = "https://acme-explore--1lcbdcpwn3.expo.app", alia
|
||||
return { run, transport, calls, requests, captured };
|
||||
}
|
||||
|
||||
import { readFileSync, existsSync } from "node:fs";
|
||||
import { readFileSync, existsSync, readdirSync } from "node:fs";
|
||||
const readFileSyncUtf8 = path => readFileSync(path, "utf8");
|
||||
const readFileSyncBytes = path => new Uint8Array(readFileSync(path));
|
||||
const existsSyncLocal = path => existsSync(path);
|
||||
/** Every file under a directory, as paths relative to it. */
|
||||
const readdirTree = (directory, prefix = "") => readdirSync(join(directory, prefix), { withFileTypes: true })
|
||||
.flatMap(entry => entry.isDirectory() ? readdirTree(directory, join(prefix, entry.name)) : [join(prefix, entry.name)]);
|
||||
const deployEnvironment = { ...environment, EXPO_TOKEN: "expo-test-token" };
|
||||
|
||||
test("ci:deploy seals the exact report, deploys it with the preview export, verifies the gate, and links Explore report", async t => {
|
||||
@@ -159,26 +176,35 @@ test("ci:deploy seals the exact report, deploys it with the preview export, veri
|
||||
assert.ok(eas.captured.hasViewer, "the preview export ships with the deployment");
|
||||
const token = eas.captured.env.EXPLORE_PREVIEW_TOKEN;
|
||||
assert.match(token, TOKEN_RE); assert.deepEqual(secrets, [token]);
|
||||
assert.equal(Buffer.from(eas.captured.env.EXPLORE_PREVIEW_KEY, "base64").length, 32);
|
||||
assert.equal(eas.captured.env.EXPLORE_PREVIEW_EXPIRES_AT, "2026-09-18T03:07:00.000Z");
|
||||
assert.match(eas.captured.env.EXPLORE_PREVIEW_REPORT, /^\/_report\/[a-z2-7]{16}\/report\.zip\.enc$/);
|
||||
// Nothing is sealed and nothing expires: the token in every path is what keeps the report private.
|
||||
assert.deepEqual(Object.keys(eas.captured.env).sort(), ["EXPLORE_PREVIEW_REPORT", "EXPLORE_PREVIEW_TOKEN"]);
|
||||
assert.equal(eas.captured.env.EXPLORE_PREVIEW_REPORT, `/p/${token}/targets/report.json`);
|
||||
assert.equal(result.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
|
||||
assert.deepEqual([result.project, result.owner, result.deploymentId, result.expiresAt], ["explore-playground-explore", "brent-org", "1lcbdcpwn3", "2026-09-18T03:07:00.000Z"]);
|
||||
assert.deepEqual([result.project, result.owner, result.deploymentId, result.expiresAt], ["explore-playground-explore", "brent-org", "1lcbdcpwn3", null]);
|
||||
const zip = await zipReportDirectory(reportPath);
|
||||
assert.equal(result.reportSha256, createHash("sha256").update(zip).digest("hex"));
|
||||
assert.equal(result.reportBytes, zip.byteLength);
|
||||
const sealed = eas.captured.sealed;
|
||||
assert.equal(sealed.byteLength, zip.byteLength + 12 + 16, "iv || ciphertext || tag, nothing else");
|
||||
assert.ok(!Buffer.from(sealed).includes(Buffer.from("review.json")), "the static file is ciphertext");
|
||||
// The static files: the manifest as the Viewer opens it, stamped with this deployment, and every screenshot under its SHA-256.
|
||||
const loaded = await loadReport(zip);
|
||||
const manifest = JSON.parse(new TextDecoder().decode(eas.captured.files[`/p/${token}/targets/report.json`]));
|
||||
assert.match(manifest.deployment, /^[a-z2-7]{16}$/);
|
||||
assert.equal(new TextDecoder().decode(eas.captured.files[`/p/${token}/targets/report.json`]), manifestBody(loaded, manifest.deployment));
|
||||
const assets = Object.keys(eas.captured.files).filter(path => path.includes("/assets/"));
|
||||
assert.deepEqual(assets.map(path => path.slice(`/p/${token}/`.length)).sort(), Object.keys(manifest.entries).sort());
|
||||
for (const path of assets) assert.equal(createHash("sha256").update(eas.captured.files[path]).digest("hex"), /([a-f0-9]{64})\./.exec(path)[1]);
|
||||
// EAS Hosting cannot put noindex on static files, so robots.txt keeps crawlers off the screenshots and manifests, not the page.
|
||||
assert.equal(eas.captured.robots, "User-agent: *\nDisallow: /p/*/assets/\nDisallow: /p/*/targets/\n");
|
||||
// Verification hit the gate and its negatives before the comment was published.
|
||||
const previewPaths = eas.requests.filter(request => request.url.origin === "https://acme-explore--1lcbdcpwn3.expo.app").map(request => request.url.pathname);
|
||||
const previewPaths = eas.requests.filter(request => request.url.origin === "https://acme-explore--1lcbdcpwn3.expo.app").map(request => request.url.pathname.replace(/[a-f0-9]{64}/, "<sha256>"));
|
||||
const wrong = token.endsWith("a") ? `${token.slice(0, -1)}b` : `${token.slice(0, -1)}a`;
|
||||
assert.deepEqual(previewPaths, [`/p/${token}`, `/p/${token}/api/v1`, `/p/${token}/report.zip`, "/", `/p/${wrong}`, `/p/${wrong}/report.zip`, `/p/${token}/viewer/index.html`]);
|
||||
// What the Viewer opens: the manifest, then one screenshot, a static file.
|
||||
assert.deepEqual(previewPaths, [`/p/${token}`, `/p/${token}/api/v1`, "/robots.txt", `/p/${token}/manifest.json`, `/p/${token}/assets/<sha256>.png`,
|
||||
"/", `/p/${wrong}`, `/p/${wrong}/manifest.json`, `/p/${token}/viewer/index.html`]);
|
||||
assert.ok(eas.requests.every(request => request.url.origin !== "https://acme-explore--1lcbdcpwn3.expo.app" || request.options.cache === "no-store"));
|
||||
const posted = eas.requests.find(request => request.options.method === "POST");
|
||||
const body = JSON.parse(posted.options.body).body;
|
||||
assert.match(body, new RegExp(`\\| \\[Open\\]\\(<https://acme-explore--1lcbdcpwn3\\.expo\\.app/p/${token}>\\) \\|`));
|
||||
assert.match(body, /Preview links work until Sep 18, 2026 \(UTC\) for anyone who has them\./);
|
||||
assert.match(body, /Preview links work for anyone who has them until the deployment is deleted\./);
|
||||
assert.doesNotMatch(body, /explore-preview\.expo\.app\/\?/);
|
||||
assert.ok(eas.requests.indexOf(posted) > eas.requests.findIndex(request => request.url.pathname === `/p/${token}/viewer/index.html`), "publish after verification");
|
||||
});
|
||||
@@ -207,16 +233,6 @@ test("the report ZIP is deterministic and mirrors the GitHub artifact layout", a
|
||||
await assert.rejects(zipReportDirectory(reportPath), /review\.json \(or exploration\.json\) and assets/, "a report carries exactly one root file");
|
||||
});
|
||||
|
||||
test("sealReport produces iv || AES-256-GCM ciphertext || tag bound to the preview AAD", () => {
|
||||
const key = new Uint8Array(32).fill(7); const iv = new Uint8Array(12).fill(9); const plain = Buffer.from("PK\u0003\u0004report");
|
||||
const sealed = Buffer.from(sealReport(plain, key, iv));
|
||||
assert.deepEqual(sealed.subarray(0, 12), Buffer.from(iv));
|
||||
const decipher = createDecipheriv("aes-256-gcm", key, iv); decipher.setAAD(Buffer.from("expo-explore-preview/1")); decipher.setAuthTag(sealed.subarray(-16));
|
||||
assert.deepEqual(Buffer.concat([decipher.update(sealed.subarray(12, -16)), decipher.final()]), plain);
|
||||
const wrongAad = createDecipheriv("aes-256-gcm", key, iv); wrongAad.setAAD(Buffer.from("other")); wrongAad.setAuthTag(sealed.subarray(-16));
|
||||
wrongAad.update(sealed.subarray(12, -16)); assert.throws(() => wrongAad.final());
|
||||
});
|
||||
|
||||
test("ci:deploy refuses to run without a preview request, EXPO_TOKEN, or the preview export, and reports EAS failures", async t => {
|
||||
const plain = await exportFixture(t, { preview: null });
|
||||
const eas = easFixture();
|
||||
@@ -302,12 +318,12 @@ test("the preview owner comes from config or the token's single account; several
|
||||
await assert.rejects(deployPreview({ inputPath, reportPath, artifactUrl, exportPath, environment: deployEnvironment, transport: several.transport, run: several.run, verifyTimeoutMs: 1 }),
|
||||
error => error.code === "PREVIEW_OWNER_AMBIGUOUS" && /brent-org, acme/.test(error.message) && /report\.preview\.owner/.test(error.nextAction));
|
||||
assert.deepEqual(several.calls.map(call => call.args[0]), ["whoami"]);
|
||||
const configured = await exportFixture(t, { preview: { hosting: "eas", expiresAfterDays: 7, owner: "acme", project: "wallet-explore" } });
|
||||
const configured = await exportFixture(t, { preview: { hosting: "eas", owner: "acme", project: "wallet-explore" } });
|
||||
const eas = easFixture({ accounts: ["brent-org", "acme"] });
|
||||
const result = await deployPreview({ inputPath: configured.inputPath, reportPath: configured.reportPath, artifactUrl, exportPath: configured.exportPath,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual([result.owner, result.project, eas.captured.appJson.expo.owner, eas.captured.appJson.expo.slug], ["acme", "wallet-explore", "acme", "wallet-explore"]);
|
||||
const wrong = await exportFixture(t, { preview: { hosting: "eas", expiresAfterDays: 7, owner: "nobody" } });
|
||||
const wrong = await exportFixture(t, { preview: { hosting: "eas", owner: "nobody" } });
|
||||
const other = easFixture();
|
||||
await assert.rejects(deployPreview({ inputPath: wrong.inputPath, reportPath: wrong.reportPath, artifactUrl, exportPath: wrong.exportPath,
|
||||
environment: deployEnvironment, transport: other.transport, run: other.run, verifyTimeoutMs: 1 }), error => error.code === "PREVIEW_OWNER_AMBIGUOUS" && /no access to the Expo account nobody/.test(error.message));
|
||||
@@ -329,16 +345,18 @@ test("ci:deploy fans several platforms' reports into one sealed deployment, veri
|
||||
const token = eas.captured.env.EXPLORE_PREVIEW_TOKEN;
|
||||
assert.equal(eas.captured.env.EXPLORE_PREVIEW_REPORT, undefined, "multi-platform deployments use the listing only");
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [
|
||||
{ target: "ios", platform: "ios", label: "iOS", path: "ios.zip.enc" }, { target: "android", platform: "android", label: "Android", path: "android.zip.enc" }], "the capturing-phase fixture has no review yet, so no change count");
|
||||
{ target: "ios", platform: "ios", label: "iOS", path: "ios.json" }, { target: "android", platform: "android", label: "Android", path: "android.json" }], "the capturing-phase fixture has no review yet, so no change count");
|
||||
assert.ok(!eas.captured.env.EXPLORE_PREVIEW_REPORTS.includes("#"), "dotenv treats # as a comment");
|
||||
const zips = [await zipReportDirectory(ios.reportPath), await zipReportDirectory(android.reportPath)];
|
||||
assert.deepEqual(result.reports.map(report => [report.platform, report.reportSha256, report.reportBytes, report.artifactUrl]),
|
||||
zips.map((zip, index) => [["ios", "android"][index], createHash("sha256").update(zip).digest("hex"), zip.byteLength, artifactUrl.replace(/20$/, String(21 + index))]));
|
||||
assert.equal(result.reportSha256, result.reports[0].reportSha256);
|
||||
const previewPaths = eas.requests.filter(request => request.url.origin === "https://acme-explore--1lcbdcpwn3.expo.app").map(request => request.url.pathname + request.url.search);
|
||||
const previewPaths = eas.requests.filter(request => request.url.origin === "https://acme-explore--1lcbdcpwn3.expo.app").map(request => (request.url.pathname + request.url.search).replace(/[a-f0-9]{64}/, "<sha256>"));
|
||||
const wrong = token.endsWith("a") ? `${token.slice(0, -1)}b` : `${token.slice(0, -1)}a`;
|
||||
assert.deepEqual(previewPaths, [`/p/${token}`, `/p/${token}/api/v1`, `/p/${token}/report.zip?platform=ios`, `/p/${token}/report.zip?platform=android`, `/p/${token}/reports.json`,
|
||||
"/", `/p/${wrong}`, `/p/${wrong}/report.zip`, `/p/${token}/viewer/index.html`]);
|
||||
assert.deepEqual(previewPaths, [`/p/${token}`, `/p/${token}/api/v1`, "/robots.txt",
|
||||
...["ios", "android"].flatMap(platform => [`/p/${token}/manifest.json?platform=${platform}`, `/p/${token}/assets/<sha256>.png`]),
|
||||
`/p/${token}/reports.json`,
|
||||
"/", `/p/${wrong}`, `/p/${wrong}/manifest.json`, `/p/${token}/viewer/index.html`]);
|
||||
const posted = eas.requests.filter(request => request.options.method === "POST" || request.options.method === "PATCH").map(request => JSON.parse(request.options.body).body);
|
||||
assert.equal(posted.length, 2, "the second platform updates the comment the first created");
|
||||
assert.match(posted[0], new RegExp(`\\| iOS \\| [^|]+\\| 🟩 [^|]+\\| \\[Open\\]\\(<https://acme-explore--1lcbdcpwn3\\.expo\\.app/p/${token}\\?platform=ios>\\)`));
|
||||
@@ -349,7 +367,7 @@ test("ci:deploy fans several platforms' reports into one sealed deployment, veri
|
||||
});
|
||||
|
||||
function captureListing(listing) {
|
||||
return listing.map(({ path, ...rest }) => ({ ...rest, path: path.replace(/^\/_report\/[a-z2-7]{16}\//, "") }));
|
||||
return listing.map(({ path, ...rest }) => ({ ...rest, path: path.replace(/^\/p\/[a-z2-7]{32}\/targets\//, "") }));
|
||||
}
|
||||
|
||||
test("collectPlatformReports pairs downloaded artifact directories by platform and looks up each report artifact's URL", async t => {
|
||||
@@ -395,8 +413,10 @@ test("ci:deploy leaves the deployments the previous comment linked alone; develo
|
||||
assert.ok(eas.requests.find(request => request.options.method === "PATCH"), "the comment was updated to link the new deployment");
|
||||
});
|
||||
|
||||
test("a never-expiring preview seals no EXPLORE_PREVIEW_EXPIRES_AT and the comment says the link lasts until the deployment is deleted", async t => {
|
||||
const { inputPath, reportPath, exportPath } = await exportFixture(t, { preview: { hosting: "eas", expiresAfterDays: null } });
|
||||
test("a preview sets no expiry of its own: an old config's expiresAfter is noted and ignored, and the comment says the link lasts until the deployment is deleted", async t => {
|
||||
const { inputPath, reportPath, exportPath } = await exportFixture(t, { preview: { hosting: "eas", expiresAfterIgnored: true } });
|
||||
const warnings = [];
|
||||
t.mock.method(process.stderr, "write", chunk => { warnings.push(String(chunk)); return true; });
|
||||
const eas = easFixture();
|
||||
const result = await deployPreview({ inputPath, reportPath, artifactUrl, exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.equal("EXPLORE_PREVIEW_EXPIRES_AT" in eas.captured.env, false);
|
||||
@@ -404,14 +424,23 @@ test("a never-expiring preview seals no EXPLORE_PREVIEW_EXPIRES_AT and the comme
|
||||
const body = JSON.parse(eas.requests.find(request => request.options.method === "PATCH" || request.options.method === "POST").options.body).body;
|
||||
assert.match(body, /^Preview links work for anyone who has them until the deployment is deleted\. · Managed via /m);
|
||||
assert.doesNotMatch(body, /works until/);
|
||||
assert.ok(warnings.some(line => line.includes("report.preview.expiresAfter no longer applies: a hosted preview lasts as long as its EAS Hosting deployment")), warnings.join(""));
|
||||
|
||||
// A capture from an earlier version recorded the expiry as expiresAfterDays: still accepted, and noted the same way.
|
||||
const legacy = await exportFixture(t, { preview: { hosting: "eas", expiresAfterDays: 7 } });
|
||||
warnings.length = 0;
|
||||
const again = easFixture();
|
||||
assert.equal((await deployPreview({ inputPath: legacy.inputPath, reportPath: legacy.reportPath, artifactUrl, exportPath: legacy.exportPath, environment: deployEnvironment,
|
||||
transport: again.transport, run: again.run, now: () => now, verifyTimeoutMs: 1 })).expiresAt, null);
|
||||
assert.ok(warnings.some(line => line.includes("report.preview.expiresAfter no longer applies")), warnings.join(""));
|
||||
});
|
||||
|
||||
test("a standalone report deploys to a fixed alias with a fixed token, verifies both hosts, and prints the alias link", async t => {
|
||||
const { reportPath, exportPath } = await exportFixture(t);
|
||||
await rename(join(reportPath, "review.json"), join(reportPath, "exploration.json"));
|
||||
await asExploration(reportPath);
|
||||
const eas = easFixture();
|
||||
const token = "b".repeat(32);
|
||||
const result = await deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", expiresAfterDays: null, exportPath, alias: "bluesky", token,
|
||||
const result = await deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "bluesky", token,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual(eas.calls[2].args, ["deploy", "--json", "--non-interactive", "--export-dir", "dist", "--alias", "bluesky"]);
|
||||
assert.equal(eas.captured.env.EXPLORE_PREVIEW_TOKEN, token, "the caller's token is sealed into the deployment");
|
||||
@@ -421,16 +450,16 @@ test("a standalone report deploys to a fixed alias with a fixed token, verifies
|
||||
const origins = new Set(eas.requests.filter(request => request.url.pathname.startsWith("/p/")).map(request => request.url.origin));
|
||||
assert.deepEqual([...origins].sort(), ["https://acme-explore--1lcbdcpwn3.expo.app", "https://acme-explore--bluesky.expo.app"], "the report is verified on the deployment and on the alias");
|
||||
|
||||
const plain = await deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", expiresAfterDays: 7, exportPath,
|
||||
const plain = await deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.equal(eas.captured.alias, undefined);
|
||||
assert.equal(plain.aliasUrl, undefined);
|
||||
assert.match(plain.previewUrl, /^https:\/\/acme-explore--1lcbdcpwn3\.expo\.app\/p\/[a-z2-7]{32}$/);
|
||||
assert.notEqual(plain.previewUrl, result.previewUrl, "without a fixed token the link is random");
|
||||
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", expiresAfterDays: null, exportPath, alias: "Blue Sky",
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "Blue Sky",
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, verifyTimeoutMs: 1 }), error => error.code === "PREVIEW_ALIAS_INVALID");
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", expiresAfterDays: null, exportPath, token: "short",
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, token: "short",
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, verifyTimeoutMs: 1 }), error => error.code === "PREVIEW_TOKEN_INVALID");
|
||||
});
|
||||
|
||||
@@ -453,11 +482,11 @@ test("a fixture preview seals each platform's ZIP as is behind one alias and lis
|
||||
assert.equal(eas.captured.alias, "pr-12");
|
||||
assert.equal("EXPLORE_PREVIEW_EXPIRES_AT" in eas.captured.env, false, "a fixture preview does not expire");
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [
|
||||
{ target: "android", platform: "android", label: "Android", changes: 12, device: "Pixel · light + dark", path: "android.zip.enc" },
|
||||
{ target: "ios", platform: "ios", label: "iOS", path: "ios.zip.enc" },
|
||||
{ target: "android", platform: "android", label: "Android", changes: 12, device: "Pixel · light + dark", path: "android.json" },
|
||||
{ target: "ios", platform: "ios", label: "iOS", path: "ios.json" },
|
||||
]);
|
||||
const served = eas.requests.filter(request => request.url.pathname === `/p/${token}/report.zip`).map(request => request.url.searchParams.get("platform"));
|
||||
assert.deepEqual([...new Set(served)].sort(), ["android", "ios"], "both platforms' bytes are verified");
|
||||
const served = eas.requests.filter(request => request.url.pathname === `/p/${token}/manifest.json`).map(request => request.url.searchParams.get("platform"));
|
||||
assert.deepEqual([...new Set(served)].sort(), ["android", "ios"], "both platforms' manifests are verified");
|
||||
|
||||
// The alias lagging the deployment past the budget is not a failed deployment: the deployment is verified, so the
|
||||
// link is the deployment's own origin and the job log carries a warning (every 2026-10-14 "HTTP 404" failure was this).
|
||||
@@ -496,9 +525,30 @@ test("a fixture preview seals each platform's ZIP as is behind one alias and lis
|
||||
error => error.code === "PREVIEW_ALIAS_INVALID");
|
||||
});
|
||||
|
||||
test("fixture reports name each target's ZIP, and a listing from before targets its platform's", () => {
|
||||
const listing = [
|
||||
{ target: "iphone", platform: "ios", label: "iPhone 17", changes: 11, device: "iPhone 17 26.5 · light + dark", source: "brentvatne/euxy#163" },
|
||||
{ target: "duo-open", platform: "ios", label: "iPhone Duo (open)", changes: 34 },
|
||||
{ target: "android", platform: "android", label: "Android", changes: 5 },
|
||||
];
|
||||
assert.deepEqual(fixtureReports(listing, "/fixtures"), [
|
||||
{ platform: "ios", target: { id: "iphone", platform: "ios", label: "iPhone 17" }, zipPath: "/fixtures/iphone.zip", changes: 11, device: "iPhone 17 26.5 · light + dark" },
|
||||
{ platform: "ios", target: { id: "duo-open", platform: "ios", label: "iPhone Duo (open)" }, zipPath: "/fixtures/duo-open.zip", changes: 34 },
|
||||
{ platform: "android", target: { id: "android", platform: "android", label: "Android" }, zipPath: "/fixtures/android.zip", changes: 5 },
|
||||
]);
|
||||
assert.deepEqual(fixtureReports([{ platform: "ios", changes: 3 }, { platform: "android" }], "/fixtures"), [
|
||||
{ platform: "ios", zipPath: "/fixtures/ios.zip", changes: 3 },
|
||||
{ platform: "android", zipPath: "/fixtures/android.zip" },
|
||||
]);
|
||||
// reports.json comes from a hosted preview: a target that is not an id never names a file.
|
||||
for (const bad of [[{ target: "../escape", platform: "ios" }], [{ platform: "web" }], [null], { platform: "ios" }]) {
|
||||
assert.throws(() => fixtureReports(bad, "/fixtures"), error => error.code === "PREVIEW_REPORTS_INVALID", JSON.stringify(bad));
|
||||
}
|
||||
});
|
||||
|
||||
test("a deployment that does not report the requested alias is a retryable deploy failure", async t => {
|
||||
const { reportPath, exportPath } = await exportFixture(t);
|
||||
await rename(join(reportPath, "review.json"), join(reportPath, "exploration.json"));
|
||||
await asExploration(reportPath);
|
||||
const eas = easFixture();
|
||||
const run = (node, [bin, ...args], options) => {
|
||||
const result = eas.run(node, [bin, ...args], options);
|
||||
@@ -506,7 +556,7 @@ test("a deployment that does not report the requested alias is a retryable deplo
|
||||
const { aliases: _aliases, ...rest } = JSON.parse(result.stdout);
|
||||
return { ...result, stdout: `${JSON.stringify(rest)}\n` };
|
||||
};
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", expiresAfterDays: null, exportPath, alias: "bluesky",
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "bluesky",
|
||||
environment: deployEnvironment, transport: eas.transport, run, now: () => now, verifyTimeoutMs: 1 }),
|
||||
error => error.code === "PREVIEW_DEPLOY_FAILED" && error.retryable === true && /did not report the alias bluesky/.test(error.message));
|
||||
});
|
||||
@@ -545,7 +595,7 @@ test("a comparison of two commits deploys the same way and links its report from
|
||||
assert.match(summary, /^### Explore: `v1\.4\.0` vs `v1\.3\.0`$/m);
|
||||
assert.ok(summary.includes(`[Open the report](${result.previewUrl})`));
|
||||
assert.ok(summary.includes(`(https://github.com/${pr.repository}/compare/${pr.base.sha}..${pr.head.sha})`));
|
||||
assert.match(summary, /link expires 2026-09-18/);
|
||||
assert.doesNotMatch(summary, /expires/, "a hosted preview lasts as long as its deployment");
|
||||
});
|
||||
|
||||
test("readReportZip reads a review ZIP's platform, run and labels, and rejects anything that is not a report", async t => {
|
||||
@@ -593,35 +643,35 @@ test("deployLocalReports hosts one review's platforms behind one link, labelled
|
||||
const zip = await zipReportDirectory(reportPath);
|
||||
const eas = easFixture();
|
||||
const result = await deployLocalReports({ reports: [{ platform: "ios", zip, changes: 3, device: "iPhone 17 26.5" }, { platform: "android", zip }],
|
||||
project: "acme-explore", expiresAfterDays: null, exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
project: "acme-explore", exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.match(result.previewUrl, /^https:\/\/acme-explore--1lcbdcpwn3\.expo\.app\/p\/[a-z2-7]{32}$/);
|
||||
assert.equal(result.owner, "brent-org", "the only account of the login holds the project");
|
||||
assert.equal(result.expiresAt, null);
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [
|
||||
{ target: "ios", platform: "ios", label: "iOS", changes: 3, device: "iPhone 17 26.5", path: "ios.zip.enc" },
|
||||
{ target: "android", platform: "android", label: "Android", path: "android.zip.enc" },
|
||||
{ target: "ios", platform: "ios", label: "iOS", changes: 3, device: "iPhone 17 26.5", path: "ios.json" },
|
||||
{ target: "android", platform: "android", label: "Android", path: "android.json" },
|
||||
]);
|
||||
await assert.rejects(deployLocalReports({ reports: [{ platform: "ios", zip }, { platform: "ios", zip }], project: "acme-explore", expiresAfterDays: 7, exportPath,
|
||||
await assert.rejects(deployLocalReports({ reports: [{ platform: "ios", zip }, { platform: "ios", zip }], project: "acme-explore", exportPath,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run }), error => error.code === "PREVIEW_REPORTS_INVALID");
|
||||
|
||||
// One Android report is still listed, so the Worker does not take it for iOS; a label with `#` cannot cut the sealed .env short.
|
||||
await deployLocalReports({ reports: [{ platform: "android", zip, changes: 1, device: "Pixel #9 <Pro>\n" }], project: "acme-explore", expiresAfterDays: 7, exportPath,
|
||||
await deployLocalReports({ reports: [{ platform: "android", zip, changes: 1, device: "Pixel #9 <Pro>\n" }], project: "acme-explore", exportPath,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.equal(eas.captured.env.EXPLORE_PREVIEW_REPORT, undefined);
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [{ target: "android", platform: "android", label: "Android", changes: 1, device: "Pixel 9 Pro", path: "android.zip.enc" }]);
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [{ target: "android", platform: "android", label: "Android", changes: 1, device: "Pixel 9 Pro", path: "android.json" }]);
|
||||
// eas deploy expands $VARIABLES in that .env, even single-quoted: a label never carries one in, nor a backslash.
|
||||
await deployLocalReports({ reports: [{ platform: "ios", zip, device: "iPhone ${EXPO_TOKEN} $EXPLORE_PREVIEW_KEY \\$ · light + dark" }], project: "acme-explore",
|
||||
expiresAfterDays: 7, exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [{ target: "ios", platform: "ios", label: "iOS", device: "iPhone EXPO_TOKEN EXPLORE_PREVIEW_KEY · light + dark", path: "ios.zip.enc" }]);
|
||||
exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [{ target: "ios", platform: "ios", label: "iOS", device: "iPhone EXPO_TOKEN EXPLORE_PREVIEW_KEY · light + dark", path: "ios.json" }]);
|
||||
});
|
||||
|
||||
test("an explore:binary report names its platform, so an Android exploration is not served as iOS", async t => {
|
||||
const { reportPath, exportPath } = await exportFixture(t);
|
||||
await rename(join(reportPath, "review.json"), join(reportPath, "exploration.json"));
|
||||
await asExploration(reportPath);
|
||||
const eas = easFixture();
|
||||
await deployExplorationReport({ reportPath, platform: "android", project: "acme-explore", owner: "brent-org", expiresAfterDays: 7, exportPath,
|
||||
await deployExplorationReport({ reportPath, platform: "android", project: "acme-explore", owner: "brent-org", exportPath,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [{ target: "android", platform: "android", label: "Android", path: "android.zip.enc" }]);
|
||||
assert.deepEqual(captureListing(eas.captured.listing), [{ target: "android", platform: "android", label: "Android", path: "android.json" }]);
|
||||
});
|
||||
|
||||
test("readReportZip stops inflating a report file once it passes the size its header declares", async () => {
|
||||
@@ -702,20 +752,20 @@ test("readReportZip names the report's target from review.runtime.target, and ig
|
||||
assert.equal((await readReportZip(await zipReportDirectory(reportPath))).target.label, "Duo HOME open 1", "a label is plain text, safe in the sealed .env");
|
||||
});
|
||||
|
||||
test("deployLocalReports hosts four targets, three of them iOS, as <target>.zip.enc selected by ?target=", async t => {
|
||||
test("deployLocalReports hosts four targets, three of them iOS, as targets/<target>.json selected by ?target=", async t => {
|
||||
const { reportPath, exportPath } = await exportFixture(t);
|
||||
const zip = await zipReportDirectory(reportPath);
|
||||
const eas = easFixture();
|
||||
await deployLocalReports({ reports: TARGETS.map((target, index) => ({ platform: target.platform, target, zip: new Uint8Array([...zip, ...new Array(index).fill(0)]), changes: index })),
|
||||
project: "acme-explore", expiresAfterDays: 7, exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual(captureListing(eas.captured.listing), TARGETS.map((target, index) => ({ target: target.id, platform: target.platform, label: target.label, path: `${target.id}.zip.enc`, changes: index })));
|
||||
const served = eas.requests.filter(request => request.url.pathname === `/p/${eas.captured.env.EXPLORE_PREVIEW_TOKEN}/report.zip`).map(request => request.url.search);
|
||||
project: "acme-explore", exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 });
|
||||
assert.deepEqual(captureListing(eas.captured.listing), TARGETS.map((target, index) => ({ target: target.id, platform: target.platform, label: target.label, path: `${target.id}.json`, changes: index })));
|
||||
const served = eas.requests.filter(request => request.url.pathname === `/p/${eas.captured.env.EXPLORE_PREVIEW_TOKEN}/manifest.json`).map(request => request.url.search);
|
||||
assert.deepEqual([...new Set(served)], ["?target=iphone", "?target=duo-closed", "?target=duo-open", "?platform=android"],
|
||||
"a target named after its platform keeps the ?platform= link it always had");
|
||||
for (const reports of [[{ platform: "ios", target: TARGETS[0], zip }, { platform: "ios", target: TARGETS[0], zip }],
|
||||
[{ platform: "ios", target: { id: "Bad", platform: "ios", label: "x" }, zip }],
|
||||
Array.from({ length: 9 }, (_, index) => ({ platform: "ios", target: { id: `t${index}`, platform: "ios", label: "x" }, zip }))]) {
|
||||
await assert.rejects(deployLocalReports({ reports, project: "acme-explore", expiresAfterDays: 7, exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run }),
|
||||
await assert.rejects(deployLocalReports({ reports, project: "acme-explore", exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run }),
|
||||
error => error.code === "PREVIEW_REPORTS_INVALID");
|
||||
}
|
||||
});
|
||||
@@ -743,9 +793,9 @@ test("ci:deploy pairs target-named artifacts, deploys them in config order, and
|
||||
const sealed = await deployPreview({ reports: entries.map(({ platform: _platform, ...entry }) => entry), exportPath: fixtures[0].exportPath, environment: deployEnvironment, transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 })
|
||||
.catch(error => error);
|
||||
// Publishing each target's comment section after the deployment is the comment code's (publishCiReportComment, which needs
|
||||
// the target to name the artifact); the deployment itself must have been sealed per target either way.
|
||||
// the target to name the artifact); the deployment itself must have been written per target either way.
|
||||
assert.deepEqual(captureListing(eas.captured.listing).map(entry => [entry.target, entry.platform, entry.label, entry.path]),
|
||||
TARGETS.map(target => [target.id, target.platform, target.label, `${target.id}.zip.enc`]), String(sealed?.message ?? ""));
|
||||
TARGETS.map(target => [target.id, target.platform, target.label, `${target.id}.json`]), String(sealed?.message ?? ""));
|
||||
|
||||
// An artifact named for one target that holds another's report is refused.
|
||||
await rm(join(root, "inputs", "explore-capture-10-1-duo-open"), { recursive: true });
|
||||
@@ -754,3 +804,44 @@ test("ci:deploy pairs target-named artifacts, deploys them in config order, and
|
||||
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport }),
|
||||
error => error.code === "PREVIEW_REPORTS_INVALID" && /holds the report of iphone/.test(error.message));
|
||||
});
|
||||
|
||||
test("ci:deploy fails a deployment whose Worker serves the ZIP but not the manifest and screenshots the Viewer opens", async t => {
|
||||
const { inputPath, reportPath, exportPath } = await exportFixture(t);
|
||||
const eas = easFixture({ manifestServes: false });
|
||||
await assert.rejects(deployPreview({ inputPath, reportPath, exportPath, artifactUrl, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 }),
|
||||
error => error.code === "PREVIEW_VERIFY_FAILED" && /manifest and screenshots/.test(error.message) && error.details.status === 404);
|
||||
const posted = eas.requests.filter(request => request.options.method === "POST" || request.options.method === "PATCH").map(request => JSON.parse(request.options.body).body);
|
||||
assert.ok(posted.every(body => !body.includes(`/p/${eas.captured.env.EXPLORE_PREVIEW_TOKEN}`)), posted.join("\n---\n"));
|
||||
});
|
||||
|
||||
test("a deployment that does not serve its robots.txt fails verification", async t => {
|
||||
const { inputPath, reportPath, exportPath } = await exportFixture(t);
|
||||
const eas = easFixture({ robotsServes: false });
|
||||
await assert.rejects(deployPreview({ inputPath, reportPath, exportPath, artifactUrl, environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 }),
|
||||
error => error.code === "PREVIEW_VERIFY_FAILED" && /robots\.txt/.test(error.message));
|
||||
});
|
||||
|
||||
test("eas output that names an upload's path keeps the link's token out of the log and the error", async t => {
|
||||
const { inputPath, reportPath, exportPath } = await exportFixture(t);
|
||||
const eas = easFixture({ failDeploy: "upload-path" });
|
||||
const logged = [];
|
||||
t.mock.method(process.stderr, "write", chunk => { logged.push(String(chunk)); return true; });
|
||||
const error = await deployPreview({ inputPath, reportPath, artifactUrl, exportPath, environment: deployEnvironment, transport: eas.transport, run: eas.run,
|
||||
now: () => now, verifyTimeoutMs: 1, sleep: async () => {} }).catch(caught => caught);
|
||||
assert.equal(error.code, "PREVIEW_DEPLOY_FAILED");
|
||||
assert.ok(logged.some(line => line.includes('Upload of "client/p/***/assets/')), logged.join(""));
|
||||
for (const text of [...logged, error.details.output, error.message]) assert.doesNotMatch(text, /p\/[a-z2-7]{32}\//, text);
|
||||
});
|
||||
|
||||
test("targets that share a screenshot must agree on its size, or the deploy refuses the report", async t => {
|
||||
const { reportPath, exportPath } = await exportFixture(t);
|
||||
const zip = await zipReportDirectory(reportPath);
|
||||
const broken = await mkdtemp(join(tmpdir(), "explore-broken-")); t.after(() => rm(broken, { recursive: true, force: true }));
|
||||
await cp(reportPath, broken, { recursive: true });
|
||||
await writeFile(join(broken, "assets", `${sha256}.png`), png.subarray(0, 10));
|
||||
const eas = easFixture();
|
||||
await assert.rejects(deployLocalReports({ reports: [{ platform: "ios", zip }, { platform: "android", zip: await zipReportDirectory(broken) }], project: "acme-explore", exportPath,
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 }),
|
||||
error => error.code === "REPORT_ZIP_FAILED" && error.message.includes(`assets/${sha256}.png`));
|
||||
assert.equal(eas.calls.filter(call => call.args[0] === "deploy").length, 0, "nothing is deployed");
|
||||
});
|
||||
@@ -31,8 +31,10 @@ for (const provider of ['expo-router', 'react-navigation']) {
|
||||
const before = f.requests.length;
|
||||
const output = join(f.root, 'review');
|
||||
const result = await runPublicCi({ baseProject: f.baseProject, headProject: f.headProject, pullRequestPath: f.pullRequestPath, output,
|
||||
config: f.config, environment: { ...f.environment, EXPLORE_CAPTURE_CACHE: baseline.directory }, transport: f.transport, runner: f.runner, now: f.now, sleep: f.sleep });
|
||||
config: { ...f.config, report: { comment: { map: true } } }, environment: { ...f.environment, EXPLORE_CAPTURE_CACHE: baseline.directory },
|
||||
transport: f.transport, runner: f.runner, now: f.now, sleep: f.sleep });
|
||||
const plan = JSON.parse(await readFile(join(output, 'execution-plan.json'), 'utf8'));
|
||||
assert.equal(JSON.parse(await readFile(result.inputPath, 'utf8')).commentState.map, true, 'report.comment.map reaches the comment the publish job renders');
|
||||
assert.equal(result.review.contract, 'explore.review');
|
||||
assert.equal(result.review.runtime.appVersion, '3.0.0', 'the Viewer header shows the captured app version');
|
||||
assert.equal(result.review.runtime.appBuildNumber, '7', 'the Viewer header shows the captured build number');
|
||||
@@ -122,6 +124,7 @@ test('unreachable screens do not fail CI: both revisions, the report and an Inco
|
||||
.map(line => line.replace('(home)', `(${result.review.surfaces.find(surface => surface.head?.route === '/home')?.id})`)).sort());
|
||||
assert.ok(progress.includes('2 screens are unavailable in this report'));
|
||||
const reportInput = JSON.parse(await readFile(join(output, 'report-input.json'), 'utf8'));
|
||||
assert.equal(reportInput.commentState.map, undefined, 'the comment draws no map unless the config asks for one');
|
||||
assert.equal(reportInput.publicReview.surfaces.filter(surface => surface.headOutcome && surface.headOutcome.status !== 'captured').length, 0);
|
||||
assert.equal(reportInput.publicReview.surfaces.filter(surface => surface.headOutcome?.landing === 'unverified' && surface.headImage).length, 1);
|
||||
assert.equal(reportInput.publicReview.surfaces.filter(surface => surface.baseOutcome && surface.baseOutcome.status !== 'captured').length, 1);
|
||||
|
||||
@@ -60,7 +60,7 @@ function state(overrides = {}) {
|
||||
phase: 'ready', pullRequest, mode: 'changes', executionMode: 'deterministic', configPath: '.expo-explore/config.yaml', links,
|
||||
startedAt: Date.parse('2026-09-11T03:00:48Z'), updatedAt: Date.parse('2026-09-11T03:07:00Z'),
|
||||
build: { appName: 'Example', appVersion: '1.4.0', appBuildNumber: '27', platform: 'ios', easProfile: 'explore', easBuildId: 'eas-build', reusedEasBuild: true },
|
||||
runtime: { provider: 'eas-simulator', controller: 'agent-device', controllerPackageVersion: '0.20.2', easCliVersion: '25.0.0', platform: 'ios', deviceModel: 'iPhone 17', osVersion: '26.5', locale: 'en-US', orientation: 'portrait', colorScheme: 'light', sessionLifecycle: 'stopped' },
|
||||
runtime: { provider: 'eas-simulator', controller: 'agent-device', controllerPackageVersion: '0.20.2', easCliVersion: '25.2.0', platform: 'ios', deviceModel: 'iPhone 17', osVersion: '26.5', locale: 'en-US', orientation: 'portrait', colorScheme: 'light', sessionLifecycle: 'stopped' },
|
||||
capture: { planned: { base: 3, head: 3 }, done: { base: 3, head: 3 }, baseFromCache: true },
|
||||
review: evidenceReview(),
|
||||
evidence: {
|
||||
@@ -588,3 +588,57 @@ test('a comment written by a per-platform version keeps parsing, and malformed t
|
||||
const many = Array.from({ length: 10 }, (_, index) => line(`t${index}`, { ...valid, target: `t${index}` }));
|
||||
assert.equal(parse(...many).length, 8, 'a comment holds at most one record per configurable target');
|
||||
});
|
||||
|
||||
test('with report.comment.map, the map draws the added, removed and visually changed screens, the screens one step before them, and tabs as a group', async () => {
|
||||
const { readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
|
||||
const edge = (from, to, kind) => ({ from, to, kind, sourceFile: 'src/app/_layout.tsx', provenance: 'source' });
|
||||
const graph = edges => ({ contract: 'explore.navigation', edges, modalSurfaceIds: [], unresolved: [] });
|
||||
const base = evidenceReview();
|
||||
const dark = surface('settings@dark', 'modified', { route: '/settings', extra: base.surfaces[2].review && { review: base.surfaces[2].review, visual: base.surfaces[2].visual } });
|
||||
const withNavigation = { ...base, surfaces: [...base.surfaces, dark], navigation: {
|
||||
// home is a redirect, not a screen; cats and settings are tabs; cats changed only in source, so it is drawn as the way to care-guide.
|
||||
head: graph([edge('cats', 'care-guide', 'push'), edge('cats', 'settings', 'tab'), edge('settings', 'cats', 'tab'), edge('home', 'cats', 'replace')]),
|
||||
base: graph([edge('cats', 'sweet-bee', 'push'), edge('cats', 'settings', 'tab')]),
|
||||
} };
|
||||
// Off by default: most reviews do not need it, so a config opts in with report.comment.map.
|
||||
assert.ok(!/<summary>Map/.test(renderPublicComment(state({ artifactOnly: true, review: withNavigation }))));
|
||||
assert.equal(platformRecordOf(state({ review: withNavigation })).navigation, undefined);
|
||||
const body = renderPublicComment(state({ artifactOnly: true, map: true, review: withNavigation }));
|
||||
assert.deepEqual(summaries(body), ['🟩 Added (1)', '🟥 Removed (1)', '🟧 Modified (2)', 'Map (4 screens)', 'Validation · iOS 🟩 8/8 captured']);
|
||||
const map = body.slice(body.indexOf('```mermaid'), body.indexOf('```\n', body.indexOf('```mermaid')) + 3);
|
||||
assert.equal(map, ['```mermaid', 'flowchart LR', ' subgraph tabs["Tabs"]', ' n0["/cats"]', ' n3["/settings"]', ' end',
|
||||
' n1["/cats/care-guide"]', ' n2["/cats/sweet-bee"]', ' n0 -->|push| n1', ' n0 -.->|push| n2',
|
||||
' classDef added stroke:#1a7f37,stroke-width:3px', ' class n1 added', ' classDef modified stroke:#bc4c00,stroke-width:3px', ' class n3 modified',
|
||||
' classDef removed stroke:#cf222e,stroke-width:2px,stroke-dasharray:5 4', ' class n2 removed', '```'].join('\n'));
|
||||
assert.ok(body.indexOf('<summary>🟧 Modified') < body.indexOf('<summary>Map') && body.indexOf('<summary>Map') < body.indexOf('<summary>Validation'));
|
||||
assert.match(body, /<summary>Map \(4 screens\)<\/summary>\n\n```mermaid\n/, 'a blank line opens the fence inside the collapsible');
|
||||
assert.deepEqual(readCommentRecords(body).current.ios.navigation, platformRecordOf(state({ map: true, review: withNavigation })).navigation, 'the map is carried in the record');
|
||||
|
||||
// A label cannot end itself, its line or the fence.
|
||||
const odd = { ...withNavigation, surfaces: withNavigation.surfaces.map(entry => entry.id === 'care-guide'
|
||||
? { ...entry, head: { ...entry.head, logicalPath: 'cats/"a"#<b>`c`' } } : entry) };
|
||||
assert.match(renderPublicComment(state({ map: true, review: odd })), /\n {2}n1\["\/cats\/#quot;a#quot;#35;#lt;b#gt;#96;c#96;"\]\n/);
|
||||
// No navigation, or nothing changed visually: no map.
|
||||
assert.ok(!summaries(renderPublicComment(state({ map: true }))).includes('Map (4 screens)'));
|
||||
const unchanged = { ...withNavigation, surfaces: withNavigation.surfaces.filter(entry => entry.status !== 'added' && entry.status !== 'removed' && !entry.id.startsWith('settings')) };
|
||||
assert.ok(!/<summary>Map/.test(renderPublicComment(state({ map: true, review: unchanged }))));
|
||||
});
|
||||
|
||||
test('the map is dropped before the change lists shrink, and a malformed map is dropped from the record', async () => {
|
||||
const { encodeRecordPayload } = await import('../../dist/report/pr-comment-record.js');
|
||||
const { readCommentRecords, renderCommentRecords } = await import('../../dist/report/pr-comment-body.js');
|
||||
const record = { ...platformRecordOf(state()), navigation: { nodes: [{ route: '/a', group: 'modified' }, { route: '/b' }], edges: [{ from: 1, to: 0, kinds: ['push'] }] } };
|
||||
const records = { current: { ios: record }, history: [] };
|
||||
assert.match(renderCommentRecords(records), /<summary>Map \(2 screens\)<\/summary>/);
|
||||
const tight = renderCommentRecords(records, undefined, renderCommentRecords(records).length - 1);
|
||||
assert.ok(!tight.includes('```mermaid'));
|
||||
assert.match(tight, /<summary>🟧 Modified \(1\)<\/summary>/);
|
||||
const parse = navigation => readCommentRecords(`<!-- expo-explore-record:ios:${encodeRecordPayload({ ...record, navigation })} -->`).current.ios;
|
||||
assert.deepEqual(parse(record.navigation).navigation, record.navigation);
|
||||
for (const navigation of [{ ...record.navigation, edges: [{ from: 0, to: 2, kinds: ['push'] }] }, { ...record.navigation, edges: [{ from: 0, to: 1, kinds: ['teleport'] }] },
|
||||
{ ...record.navigation, nodes: [{ route: '/a', group: 'needs-review' }, { route: '/b' }] }, { nodes: [], edges: [] }]) {
|
||||
const parsed = parse(navigation);
|
||||
assert.ok(parsed, 'the rest of the record still parses');
|
||||
assert.equal(parsed.navigation, undefined);
|
||||
}
|
||||
});
|
||||
@@ -13,7 +13,7 @@ const BASE_SHA = "a".repeat(40);
|
||||
const HEAD_SHA = "b".repeat(40);
|
||||
const PNG = Buffer.from("iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+A8AAQUBAScY42YAAAAASUVORK5CYII=", "base64");
|
||||
const EXECUTION = {
|
||||
provider: "eas-simulator", controller: "agent-device", controllerPackageVersion: AGENT_DEVICE_VERSION, easCliVersion: "25.0.0",
|
||||
provider: "eas-simulator", controller: "agent-device", controllerPackageVersion: AGENT_DEVICE_VERSION, easCliVersion: "25.2.0",
|
||||
platform: "ios", deviceModel: "iPhone 17", osVersion: "26.0", locale: "en-US", orientation: "portrait",
|
||||
colorScheme: "light", sessionLifecycle: "stopped",
|
||||
};
|
||||
|
||||
@@ -54,17 +54,14 @@ test("rejects comparisons that name another URL, a PR number, or one commit twic
|
||||
assert.throws(() => projectReviewPresentation({ ...comparison, repositoryId: "x" }), /decimal GitHub id/);
|
||||
});
|
||||
|
||||
test("a run's scope and link lifetime override the reviewed config only where the workflow set them", async () => {
|
||||
test("a run's scope overrides the reviewed config only where the workflow set it; a link lifetime from older workflows changes nothing", async () => {
|
||||
const { withRunOverrides } = await import("../../dist/config/explore-config.js");
|
||||
const config = { exploration: { scope: "changes" }, report: { preview: { hosting: "eas", expiresAfterDays: 30 } } };
|
||||
const config = { exploration: { scope: "changes" }, report: { preview: { hosting: "eas" } } };
|
||||
assert.deepEqual(withRunOverrides(config, {}), config);
|
||||
assert.deepEqual(withRunOverrides(config, { scope: "all", expiresIn: "never" }),
|
||||
{ exploration: { scope: "all" }, report: { preview: { hosting: "eas", expiresAfterDays: null } } });
|
||||
assert.equal(withRunOverrides(config, { expiresIn: "90d" }).report.preview.expiresAfterDays, 90);
|
||||
assert.deepEqual(withRunOverrides({ exploration: { scope: "changes" } }, { expiresIn: "never" }), { exploration: { scope: "changes" } }, "no hosting, nothing to expire");
|
||||
assert.deepEqual(withRunOverrides(config, { scope: "all", expiresIn: "never" }), { exploration: { scope: "all" }, report: { preview: { hosting: "eas" } } });
|
||||
// A hosted preview lasts as long as its EAS Hosting deployment, so --expires-in is accepted from older workflows and ignored, whatever it says.
|
||||
assert.deepEqual(withRunOverrides(config, { expiresIn: "forever" }), config);
|
||||
assert.throws(() => withRunOverrides(config, { scope: "everything" }), /--scope must be changes or all/);
|
||||
assert.throws(() => withRunOverrides(config, { expiresIn: "forever" }), /--expires-in/);
|
||||
assert.throws(() => withRunOverrides({ exploration: { scope: "changes" } }, { expiresIn: "forevr" }), /--expires-in/, "a typo fails even before hosting is on");
|
||||
});
|
||||
|
||||
test("a comparison links GitHub's direct two-dot diff, which matches what capture compares, also for a rollback", () => {
|
||||
|
||||
@@ -16,7 +16,7 @@ function execution(overrides = {}) {
|
||||
provider: "eas-simulator",
|
||||
controller: "agent-device",
|
||||
controllerPackageVersion: AGENT_DEVICE_VERSION,
|
||||
easCliVersion: "25.0.0",
|
||||
easCliVersion: "25.2.0",
|
||||
platform: "ios",
|
||||
deviceModel: "iPhone 17",
|
||||
osVersion: "26.0",
|
||||
@@ -189,7 +189,7 @@ test("projects one map surface into the five runtime evidence groups", () => {
|
||||
assert.equal(result.groups.interaction.transitionCount.value, 1);
|
||||
assert.equal(result.groups.ui.landmarks.value.length, 0);
|
||||
assert.equal(result.groups.environment.controllerPackageVersion?.value, AGENT_DEVICE_VERSION);
|
||||
assert.equal(result.groups.environment.easCliVersion?.value, "25.0.0");
|
||||
assert.equal(result.groups.environment.easCliVersion?.value, "25.2.0");
|
||||
});
|
||||
|
||||
test("normalizes multi-line labels and treats only open parser gaps as truncation", () => {
|
||||
|
||||
@@ -58,3 +58,15 @@ test("no two shortcuts share a chord", () => {
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
test("⌥1–⌥8 open a target by its place, with ⌥ alone; D and ` are plain keys", () => {
|
||||
assert.equal(SHORTCUTS.targetByNumber.length, 8);
|
||||
assert.ok(matchesShortcut(key("Digit2", { altKey: true }), SHORTCUTS.targetByNumber[1]));
|
||||
assert.ok(!matchesShortcut(key("Digit2"), SHORTCUTS.targetByNumber[1]), "a plain 2 is Compare's Swipe");
|
||||
assert.ok(!matchesShortcut(key("Digit2", { altKey: true, shiftKey: true }), SHORTCUTS.targetByNumber[1]));
|
||||
assert.ok(!matchesShortcut(key("Digit2", { altKey: true, ctrlKey: true }), SHORTCUTS.targetByNumber[1]));
|
||||
assert.equal(formatShortcut(SHORTCUTS.targetByNumber[0], true), "⌥1");
|
||||
assert.equal(formatShortcut(SHORTCUTS.targetByNumber[0], false), "Alt+1");
|
||||
assert.ok(matchesShortcut(key("KeyD"), SHORTCUTS.target.menu));
|
||||
assert.ok(matchesShortcut(key("Backquote"), SHORTCUTS.target.last));
|
||||
});
|
||||
@@ -0,0 +1,40 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
import { tsImport } from "tsx/esm/api";
|
||||
|
||||
const { approveSessionUrlSchemes, simulatorControl, simulatorControlActions } = await tsImport("../../src/capture/simulator-control.ts", import.meta.url);
|
||||
|
||||
function easFake(listed) {
|
||||
const calls = [];
|
||||
const eas = (args, options) => {
|
||||
calls.push({ args, options });
|
||||
if (args.includes("--list")) { if (listed instanceof Error) throw listed; return { stdout: listed }; }
|
||||
return { stdout: "{}" };
|
||||
};
|
||||
return { calls, eas };
|
||||
}
|
||||
|
||||
test("a session's control actions come from --list, by session id; an older session or CLI has none", () => {
|
||||
const { calls, eas } = easFake(JSON.stringify({ "appearance.set": {}, "springboard.restart": {} }));
|
||||
assert.deepEqual([...simulatorControlActions(eas, "session-1")], ["appearance.set", "springboard.restart"]);
|
||||
assert.deepEqual(calls[0].args, ["simulator:control", "--list", "--id", "session-1", "--json", "--non-interactive"]);
|
||||
assert.equal(calls[0].options.allowFailure, true);
|
||||
assert.equal(simulatorControlActions(easFake("Unknown command simulator:control").eas, "session-1").size, 0);
|
||||
assert.equal(simulatorControlActions(easFake(new Error("eas exited 1")).eas, "session-1").size, 0);
|
||||
});
|
||||
|
||||
test("an action's values follow --, so one that starts with a dash is never read as a flag", () => {
|
||||
const { calls, eas } = easFake("{}");
|
||||
simulatorControl(eas, "session-1", "clipboard.write", ["--not-a-flag"]);
|
||||
assert.deepEqual(calls[0].args, ["simulator:control", "clipboard.write", "--id", "session-1", "--json", "--non-interactive", "--", "--not-a-flag"]);
|
||||
});
|
||||
|
||||
test("link schemes are approved once each, lowercased, never http or https, and only when the session offers it", () => {
|
||||
const { calls, eas } = easFake("{}");
|
||||
const approved = approveSessionUrlSchemes(eas, "session-1", new Set(["app.approveUrlScheme"]), "dev.example.app", ["Example", "example", "https", "exp+example", "not a scheme"]);
|
||||
assert.deepEqual(approved, ["example", "exp+example"]);
|
||||
assert.deepEqual(calls.map(call => call.args.slice(-2)), [["dev.example.app", "example"], ["dev.example.app", "exp+example"]]);
|
||||
const none = easFake("{}");
|
||||
assert.deepEqual(approveSessionUrlSchemes(none.eas, "session-1", new Set(), "dev.example.app", ["example"]), []);
|
||||
assert.equal(none.calls.length, 0);
|
||||
});
|
||||
@@ -14,7 +14,7 @@ The Viewer verifies that a dropped ZIP is the report for the linked run attempt
|
||||
|
||||
## Environment
|
||||
|
||||
The central host reads no environment variables and holds no secrets. A preview deployment reads only the four `EXPLORE_PREVIEW_*` values sealed into it at deploy time (below).
|
||||
The central host reads no environment variables and holds no secrets. A preview deployment reads only the `EXPLORE_PREVIEW_*` values written into it at deploy time (below).
|
||||
|
||||
## Routes
|
||||
|
||||
@@ -25,22 +25,28 @@ The central host reads no environment variables and holds no secrets. A preview
|
||||
A hosted preview is one immutable EAS Hosting deployment per review, in the reviewed application's own EAS account, that opens the report without a download. Its export (`npm run export:preview`, written to `dist-preview/`) holds the identical staged Viewer under `/viewer/` and three API routes:
|
||||
|
||||
- `/p/<token>` serves the Viewer shell for exactly one 160-bit token (32 lowercase base32 characters) to requests that accept HTML; the shell's `#root` holds a text index of the report (title, counts, API links) until the Viewer renders, and a `Link` header names the JSON and Markdown alternates. Requests that do not prefer HTML (`Accept: */*`, `text/markdown`, `application/json`) get the same index as Markdown, so an agent handed the link finds the API by itself.
|
||||
- `/p/<token>/report.zip` fetches the encrypted report from this deployment's own static files, decrypts it, and streams the ZIP to the Viewer, which verifies and opens it exactly like a dropped file. `/p/<token>/reports.json` lists the capture targets (up to 8, each with its platform and label) a multi-target deployment serves; `?target=<id>` selects one on every other route, and `?platform=<p>`, from links before targets, selects the target named `<p>`, else the first of that platform.
|
||||
- `/p/<token>/llms.txt` is the Markdown index at a fixed path, and `/p/<token>/api/v1/...` is the read-only agent API (`src/server/agent-api.ts`): summary, `/screens[?status=]`, `/screens/<id>`, `/transitions`, and for exploration reports `/journeys`, `/gaps`, `/frontier`, `/assets/<sha256>`, `/raw`, with `?limit=`/`?cursor=` paging (50 default, 200 max). The Worker decrypts and parses the archive once per isolate (`src/server/report-zip.ts` reads the stored PNGs and the deflated report JSON) and answers from memory after that.
|
||||
- `/` and every other path, token, or method answer the same `404 Not found`, so a response never confirms that a deployment or token exists. After the sealed expiry the exact token still opens the Viewer shell for browsers, and every report route, including the Markdown index and the API, answers `410` with the expiry instant so the Viewer and agents can say the link expired.
|
||||
- `/p/<token>/manifest.json` is what the Viewer opens: the report's metadata file (`review.json` or `exploration.json`) verbatim plus the size of every asset, about 12 KB over the wire; the shell preloads it so it downloads alongside the Viewer bundle. The Worker answers it from its target's static manifest, passed through unparsed unless the isolate already holds it. `/p/<token>/reports.json` lists the capture targets (up to 8, each with its platform and label) a multi-target deployment serves; `?target=<id>` selects one on every other route, and `?platform=<p>`, from links before targets, selects the target named `<p>`, else the first of that platform.
|
||||
- `/p/<token>/llms.txt` is the Markdown index at a fixed path, and `/p/<token>/api/v1/...` is the read-only agent API (`src/server/agent-api.ts`): summary, `/screens[?status=]`, `/screens/<id>`, `/transitions`, and for exploration reports `/journeys`, `/gaps`, `/frontier`, `/assets/<sha256>`, `/raw`, with `?limit=`/`?cursor=` paging (50 default, 200 max). The Worker reads the target's static manifest when a request first needs it and keeps parsed manifests in memory within 32 MB; requests that arrive together share one fetch. `/api/v1/assets/<sha256>` reads the screenshot's static file.
|
||||
- `/` and every other path, token, or method answer the same `404 Not found`, so a response never confirms that a deployment or token exists. A static file the Worker cannot fetch this time answers `503`, which the Viewer retries.
|
||||
|
||||
`ci:deploy` seals the deployment by writing a deploy-time `.env` next to the export; EAS Hosting delivers it to the Worker and to nothing else:
|
||||
`ci:deploy` writes the report as static files of the deployment, under the token, and EAS Hosting serves them directly, before the Worker:
|
||||
|
||||
| Path | Content |
|
||||
| --- | --- |
|
||||
| `/p/<token>/targets/<target>.json` | one target's manifest (`report.json` for a single unlisted report), stamped with the deployment so `ci:deploy` can tell it from the one an alias still serves |
|
||||
| `/p/<token>/assets/<sha256>.<png\|jpg\|mp4>` | every screenshot and recording, once, shared by the targets that show it |
|
||||
|
||||
It also writes a deploy-time `.env` next to the export; EAS Hosting delivers it to the Worker and to nothing else:
|
||||
|
||||
| Variable | Value |
|
||||
| --- | --- |
|
||||
| `EXPLORE_PREVIEW_TOKEN` | the path token in the review comment's **Explore report** link |
|
||||
| `EXPLORE_PREVIEW_KEY` | base64 AES-256-GCM key, generated per deployment |
|
||||
| `EXPLORE_PREVIEW_EXPIRES_AT` | ISO 8601 instant; the report routes answer 410 from then on (unset: the link does not expire) |
|
||||
| `EXPLORE_PREVIEW_REPORT` | `/_report/<id>/report.zip.enc`, the ciphertext's static path |
|
||||
| `EXPLORE_PREVIEW_REPORT` | `/p/<token>/targets/report.json` (a single iOS report), or |
|
||||
| `EXPLORE_PREVIEW_REPORTS` | JSON listing each target, its platform, label, change count and device, and its manifest's path |
|
||||
|
||||
The report is encrypted before upload (12-byte IV, then AES-GCM ciphertext and tag, additional data `expo-explore-preview/1`) and the key never leaves the deployment environment, so the CDN serves only ciphertext and a token that leaks into a request log does not leak the report. A preview link is still a bearer link: anyone who has it can open the report until it expires. Expo account members who can read the project's deployments are inside that trust boundary. Report bytes are never embedded in the Worker bundle, because a deleted deployment's static files disappear within seconds while its Worker can keep answering for a few minutes.
|
||||
Nothing is encrypted: what keeps a report private is the 160-bit token in every path, the same as for the link itself. A preview link is a bearer link: anyone who has it can open the report until the deployment is deleted (EAS Hosting deletes one without an alias after 30 days on Free and 90 on paid plans), and Expo account members who can read the project's deployments are inside that trust boundary. Explore sets no expiry; `EXPLORE_PREVIEW_KEY` and `EXPLORE_PREVIEW_EXPIRES_AT` from earlier deployments belong to those deployments' own Workers.
|
||||
|
||||
`npm run verify:export:preview` loads the exported route bundles and checks the token, expiry, decryption, content negotiation, agent API, and 404 behavior against the sealed example report.
|
||||
`npm run verify:export:preview` loads the exported route bundles and checks the token, the manifest route, content negotiation, the agent API (including a screenshot read from its static file), and 404 behavior against the example report laid out as `ci:deploy` writes it.
|
||||
|
||||
## Validation and deployment
|
||||
|
||||
|
||||
@@ -79,32 +79,29 @@ if (!preview) {
|
||||
}
|
||||
}
|
||||
} else {
|
||||
// A preview deployment answers only its own token and serves the report decrypted from its own
|
||||
// static ciphertext until it expires (then the report route says 410); everything else is the same 404.
|
||||
// A preview deployment answers only its own token. ci:deploy writes the report as static files under it, which EAS
|
||||
// Hosting serves without the Worker; the Worker reads the manifest back for the shell's index and the agent API, and
|
||||
// everything else is the same 404.
|
||||
const token = "abcdefghijklmnopqrstuvwxyz234567";
|
||||
const keyBytes = webcrypto.getRandomValues(new Uint8Array(32));
|
||||
const reportPath = "/_report/abcdefghijklmnop/report.zip.enc";
|
||||
// A recorded PR review, so the exported Worker is seen to inflate the archive and answer the agent API.
|
||||
const plain = new Uint8Array(await readFile(new URL("../../test/fixtures/example-review-artifact.zip", import.meta.url)));
|
||||
const key = await webcrypto.subtle.importKey("raw", keyBytes, "AES-GCM", false, ["encrypt"]);
|
||||
const iv = webcrypto.getRandomValues(new Uint8Array(12));
|
||||
const cipher = new Uint8Array(await webcrypto.subtle.encrypt({ name: "AES-GCM", iv, additionalData: new TextEncoder().encode("expo-explore-preview/1") }, key, plain));
|
||||
const sealed = new Uint8Array(iv.byteLength + cipher.byteLength);
|
||||
sealed.set(iv); sealed.set(cipher, iv.byteLength);
|
||||
const env = {
|
||||
EXPLORE_PREVIEW_TOKEN: token,
|
||||
EXPLORE_PREVIEW_KEY: Buffer.from(keyBytes).toString("base64"),
|
||||
EXPLORE_PREVIEW_EXPIRES_AT: new Date(Date.now() + 60_000).toISOString(),
|
||||
EXPLORE_PREVIEW_REPORT: reportPath,
|
||||
};
|
||||
const reportPath = `/p/${token}/targets/report.json`;
|
||||
// A recorded PR review, laid out as ci:deploy writes it, so the exported Worker is seen to read it and answer the agent API.
|
||||
const { tsImport } = await import("tsx/esm/api");
|
||||
const { loadReport } = await tsImport("../../src/report/agent-api.ts", import.meta.url);
|
||||
const { manifestBody, PREVIEW_ASSET } = await tsImport("../../src/report/preview-manifest.ts", import.meta.url);
|
||||
const loaded = await loadReport(new Uint8Array(await readFile(new URL("../../test/fixtures/example-review-artifact.zip", import.meta.url))));
|
||||
const manifest = manifestBody(loaded, "verifyexport");
|
||||
const files = new Map([[reportPath, new TextEncoder().encode(manifest)]]);
|
||||
for (const name of loaded.entries.keys()) if (PREVIEW_ASSET.test(name)) files.set(`/p/${token}/${name}`, await loaded.read(name, 64 * 1024 * 1024));
|
||||
const env = { EXPLORE_PREVIEW_TOKEN: token, EXPLORE_PREVIEW_REPORT: reportPath };
|
||||
const origin = "https://acme-explore--deploy.expo.app";
|
||||
const fetched = [];
|
||||
const fetchStub = async (input) => {
|
||||
const url = new URL(typeof input === "string" ? input : input.url);
|
||||
fetched.push(url.href);
|
||||
return url.pathname === reportPath ? new Response(sealed) : new Response("missing", { status: 404 });
|
||||
fetched.push(url.pathname);
|
||||
const body = files.get(url.pathname);
|
||||
return body ? new Response(body, { headers: { "content-length": String(body.byteLength) } }) : new Response("missing", { status: 404 });
|
||||
};
|
||||
const globals = { fetch: fetchStub, crypto: webcrypto, TextDecoder, Blob, DecompressionStream };
|
||||
const globals = { fetch: fetchStub, crypto: webcrypto, TextDecoder, TextEncoder, Blob, DecompressionStream };
|
||||
|
||||
const index = loadRoute("/index", env, globals);
|
||||
for (const method of ["GET", "HEAD", "POST", "OPTIONS"]) {
|
||||
@@ -115,8 +112,9 @@ if (!preview) {
|
||||
for (const path of [`/p/${token}`, `/p/${token}/`, `/p/${token}?view=compare&screen=home`]) {
|
||||
const response = await handlers.GET(new Request(origin + path, { headers: { accept: "text/html,*/*;q=0.8" } }));
|
||||
const body = await response.text();
|
||||
const preload = `<link rel="preload" href="/p/${token}/manifest.json" as="fetch" crossorigin>`;
|
||||
if (response.status !== 200 || response.headers.get("cache-control") !== "private, no-store" || !body.includes("<section data-explore-agent-index")
|
||||
|| body.replace(/<div id="root">.*<\/div>/s, '<div id="root"></div>') !== stagedHtml) {
|
||||
|| !body.includes(preload) || body.replace(preload, "").replace(/<div id="root">.*<\/div>/s, '<div id="root"></div>') !== stagedHtml) {
|
||||
throw new Error(`Preview page ${path} must serve the complete staged Viewer carrying the agent index`);
|
||||
}
|
||||
const markdown = await handlers.GET(new Request(origin + path));
|
||||
@@ -124,31 +122,30 @@ if (!preview) {
|
||||
throw new Error(`Preview page ${path} must serve the Markdown index when HTML is not requested`);
|
||||
}
|
||||
}
|
||||
const served = await handlers.GET(new Request(`${origin}/p/${token}/manifest.json`));
|
||||
if (served.status !== 200 || await served.text() !== manifest) throw new Error(`Preview route ${page} must answer the static manifest the Viewer opens`);
|
||||
const summary = await handlers.GET(new Request(`${origin}/p/${token}/api/v1`));
|
||||
if (summary.status !== 200 || (await summary.json()).kind !== "pr-review") throw new Error(`Preview route ${page} must answer the agent API summary`);
|
||||
const changed = await handlers.GET(new Request(`${origin}/p/${token}/api/v1/screens?status=modified`));
|
||||
if (changed.status !== 200 || !((await changed.json()).total > 0)) throw new Error(`Preview route ${page} must list modified screens`);
|
||||
if (!(await (await handlers.GET(new Request(`${origin}/p/${token}/llms.txt`))).text()).startsWith("# Expo Explore report")) throw new Error(`Preview route ${page} must serve llms.txt`);
|
||||
const zip = await handlers.GET(new Request(`${origin}/p/${token}/report.zip`));
|
||||
if (zip.status !== 200 || zip.headers.get("content-type") !== "application/zip"
|
||||
|| Buffer.compare(Buffer.from(await zip.arrayBuffer()), Buffer.from(plain)) !== 0) {
|
||||
throw new Error(`Preview report route ${page} must stream the decrypted report`);
|
||||
const sha = [...loaded.entries.keys()].map(name => /^assets\/([a-f0-9]{64})\.png$/.exec(name)?.[1]).find(Boolean);
|
||||
const image = await handlers.GET(new Request(`${origin}/p/${token}/api/v1/assets/${sha}`));
|
||||
if (image.status !== 200 || Buffer.compare(Buffer.from(await image.arrayBuffer()), Buffer.from(files.get(`/p/${token}/assets/${sha}.png`))) !== 0) {
|
||||
throw new Error(`Preview route ${page} must serve a screenshot to the agent API from the static file`);
|
||||
}
|
||||
for (const path of [`/p/${token.replace("a", "b")}`, `/p/${token.replace("a", "b")}/report.zip`, `/p/${token.replace("a", "b")}/api/v1`, `/p/${token}/viewer/index.html`, `/p/${token}/other`, `/p/${token}/api/v1/other`, `/p/${token}/api/v2`, "/p/", `/P/${token}`]) {
|
||||
// Screenshots and manifests are static files EAS Hosting serves itself; the Worker answers none of their paths.
|
||||
for (const path of [`/p/${token.replace("a", "b")}`, `/p/${token.replace("a", "b")}/manifest.json`, `/p/${token.replace("a", "b")}/api/v1`, `/p/${token}/report.zip`,
|
||||
`/p/${token}/targets/report.json`, `/p/${token}/assets/${sha}.png`, `/p/${token}/viewer/index.html`, `/p/${token}/other`, `/p/${token}/api/v1/other`, `/p/${token}/api/v2`, "/p/", `/P/${token}`]) {
|
||||
if ((await handlers.GET(new Request(origin + path))).status !== 404) throw new Error(`Preview route ${page} incorrectly accepts ${path}`);
|
||||
}
|
||||
for (const method of ["HEAD", "POST", "PUT", "DELETE", "OPTIONS"]) {
|
||||
if ((await handlers[method](new Request(`${origin}/p/${token}`, { method }))).status !== 404) throw new Error(`Preview route ${page} must answer 404 to ${method}`);
|
||||
}
|
||||
const expired = loadRoute(page, { ...env, EXPLORE_PREVIEW_EXPIRES_AT: new Date(Date.now() - 1000).toISOString() }, globals);
|
||||
if ((await expired.GET(new Request(`${origin}/p/${token}`, { headers: { accept: "text/html" } }))).status !== 200) throw new Error(`Preview route ${page} must keep opening the Viewer after expiry`);
|
||||
for (const path of [`/p/${token}`, `/p/${token}/report.zip`, `/p/${token}/api/v1`, `/p/${token}/llms.txt`]) {
|
||||
if ((await expired.GET(new Request(origin + path))).status !== 410) throw new Error(`Preview route ${page} must answer 410 for ${path} after expiry`);
|
||||
}
|
||||
const unsealed = loadRoute(page, {}, globals);
|
||||
if ((await unsealed.GET(new Request(`${origin}/p/${token}`))).status !== 404) throw new Error(`Preview route ${page} must refuse to serve without a sealed configuration`);
|
||||
const unconfigured = loadRoute(page, {}, globals);
|
||||
if ((await unconfigured.GET(new Request(`${origin}/p/${token}`))).status !== 404) throw new Error(`Preview route ${page} must refuse to serve without a configuration`);
|
||||
}
|
||||
if (fetched.some(href => !href.endsWith(reportPath))) throw new Error("Preview routes fetched something other than the sealed report path");
|
||||
if (fetched.some(path => !path.startsWith(`/p/${token}/`))) throw new Error("Preview routes fetched something other than the deployment's own report files");
|
||||
}
|
||||
|
||||
process.stdout.write(
|
||||
|
||||
@@ -1,34 +1,32 @@
|
||||
/**
|
||||
* One hosted preview deployment per review: the Worker gates everything under `/p/<token>` with
|
||||
* a token and an expiry sealed into the deployment's environment at deploy time, fetches the
|
||||
* AES-256-GCM encrypted report from its own static files, decrypts it with a key that exists
|
||||
* only in that environment, and streams it. Static files on the CDN are ciphertext; the Viewer
|
||||
* bundle under /viewer/ is public and identical to the central host's.
|
||||
* One hosted preview deployment per review. `ci:deploy` writes the report as static files of the deployment under the
|
||||
* link's token: each target's manifest at `/p/<token>/targets/<target>.json` and every screenshot at
|
||||
* `/p/<token>/assets/<sha256>.<ext>`. EAS Hosting serves those files directly; nothing encrypts them, and what keeps
|
||||
* them private is the 160-bit token in their path. This Worker answers the rest of `/p/<token>`: the Viewer shell,
|
||||
* the manifest the Viewer asks for by target, the target list, and the agent API. The Viewer bundle under /viewer/ is
|
||||
* public and identical to the central host's.
|
||||
*/
|
||||
import { AGENT_API_VERSION, agentApiReply, agentIndexHtml, agentIndexMarkdown, loadReport, prefersHtml, type AgentContext, type LoadedReport } from "../../../src/report/agent-api";
|
||||
import { AGENT_API_VERSION, agentApiReply, agentIndexHtml, agentIndexMarkdown, prefersHtml, type AgentContext, type LoadedReport } from "../../../src/report/agent-api";
|
||||
import { MAX_ASSET_BYTES, MAX_MANIFEST_BYTES, reportFromManifest } from "../../../src/report/preview-manifest";
|
||||
|
||||
export type PreviewEnvironment = {
|
||||
/** Lowercase base32 path token the review comment links to. */
|
||||
EXPLORE_PREVIEW_TOKEN?: string | undefined;
|
||||
/** Base64 32-byte AES-GCM key. */
|
||||
EXPLORE_PREVIEW_KEY?: string | undefined;
|
||||
/** ISO 8601 instant after which the report routes answer 410 and the token page says the link expired; unset: never. */
|
||||
EXPLORE_PREVIEW_EXPIRES_AT?: string | undefined;
|
||||
/** Absolute path of the encrypted report inside this deployment, e.g. /_report/<id>/report.zip.enc (single-report deployments). */
|
||||
/** Path of the report's manifest inside this deployment, `/p/<token>/targets/report.json` (single-report deployments). */
|
||||
EXPLORE_PREVIEW_REPORT?: string | undefined;
|
||||
/**
|
||||
* JSON, one entry per capture target in config order:
|
||||
* `[{"target":"duo-open","platform":"ios","label":"iPhone Duo (open)","path":"/_report/<id>/duo-open.zip.enc","changes":3,"device":"iPhone Duo 26.0"}]`.
|
||||
* Deployments from before targets list `{"platform":"ios","path":"/_report/<id>/ios.zip.enc",…}`: the target is the platform.
|
||||
* `[{"target":"duo-open","platform":"ios","label":"iPhone Duo (open)","path":"/p/<token>/targets/duo-open.json","changes":3,"device":"iPhone Duo 26.0"}]`.
|
||||
* Deployments from before targets list `{"platform":"ios","path":"/p/<token>/targets/ios.json",…}`: the target is the platform.
|
||||
* Set instead of EXPLORE_PREVIEW_REPORT by deployments that serve several reports (or one that is not iOS).
|
||||
*/
|
||||
EXPLORE_PREVIEW_REPORTS?: string | undefined;
|
||||
};
|
||||
|
||||
export type PreviewPlatform = "ios" | "android";
|
||||
/** `target` names the report (and its file, `<target>.zip.enc`); `platform` is the device's. */
|
||||
/** `target` names the report (and its manifest, `targets/<target>.json`); `platform` is the device's. */
|
||||
export type PreviewReport = { target: string; platform: PreviewPlatform; label?: string; path: string; changes?: number; device?: string };
|
||||
export type PreviewConfig = { token: string; key: Uint8Array<ArrayBuffer>; expiresAt: number | null; reports: PreviewReport[] };
|
||||
export type PreviewConfig = { token: string; reports: PreviewReport[] };
|
||||
|
||||
export const PREVIEW_TOKEN = /^[a-z2-7]{32}$/;
|
||||
/** A capture target id, as the CLI's isTargetId accepts it: the Worker does not bundle the config reader. */
|
||||
@@ -36,20 +34,26 @@ const TARGET_ID = /^[a-z][a-z0-9-]{0,31}$/;
|
||||
export function isPreviewTargetId(value: unknown): value is string {
|
||||
return typeof value === "string" && TARGET_ID.test(value) && !["base", "head", "report"].includes(value) && !value.startsWith("install-");
|
||||
}
|
||||
const REPORT_PATH = /^\/_report\/[a-z2-7]{16,64}\/(report|[a-z][a-z0-9-]{0,31})\.zip\.enc$/;
|
||||
const REPORT_PATH = /^\/p\/([a-z2-7]{32})\/targets\/(report|[a-z][a-z0-9-]{0,31})\.json$/;
|
||||
const PLATFORMS: readonly PreviewPlatform[] = ["ios", "android"];
|
||||
/** As many targets as a config may name. */
|
||||
export const MAX_PREVIEW_REPORTS = 8;
|
||||
const PLAIN_TEXT = /[\u0000-\u001f\u007f<>[\]]/;
|
||||
|
||||
/** The target a manifest path names, when it is a manifest of this token's deployment. */
|
||||
function pathTarget(path: unknown, token: string): string | undefined {
|
||||
const match = typeof path === "string" ? REPORT_PATH.exec(path) : null;
|
||||
return match && match[1] === token ? match[2] : undefined;
|
||||
}
|
||||
|
||||
/**
|
||||
* The report list, strictly shaped: an unknown platform, an invalid or repeated target, a path that is not
|
||||
* `<target>.zip.enc`, an odd label or device, or extra keys reject the whole configuration.
|
||||
* The report list, strictly shaped: an unknown platform, an invalid or repeated target, a path that is not this token's
|
||||
* `targets/<target>.json`, an odd label or device, or extra keys reject the whole configuration.
|
||||
*/
|
||||
function parseReports(env: PreviewEnvironment): PreviewReport[] | undefined {
|
||||
function parseReports(env: PreviewEnvironment, token: string): PreviewReport[] | undefined {
|
||||
if (env.EXPLORE_PREVIEW_REPORTS === undefined) {
|
||||
const reportPath = env.EXPLORE_PREVIEW_REPORT ?? "";
|
||||
return REPORT_PATH.test(reportPath) ? [{ target: "ios", platform: "ios", path: reportPath }] : undefined;
|
||||
return pathTarget(reportPath, token) === "report" ? [{ target: "ios", platform: "ios", path: reportPath }] : undefined;
|
||||
}
|
||||
if (env.EXPLORE_PREVIEW_REPORT !== undefined || env.EXPLORE_PREVIEW_REPORTS.length > 8192) return undefined;
|
||||
let parsed: unknown;
|
||||
@@ -62,7 +66,7 @@ function parseReports(env: PreviewEnvironment): PreviewReport[] | undefined {
|
||||
// Listings from before targets name each report by its platform.
|
||||
const { target = platform, ...extra } = rest;
|
||||
if (Object.keys(extra).length || !PLATFORMS.includes(platform as PreviewPlatform) || !isPreviewTargetId(target)) return undefined;
|
||||
if (typeof path !== "string" || REPORT_PATH.exec(path)?.[1] !== target) return undefined;
|
||||
if (typeof path !== "string" || pathTarget(path, token) !== target) return undefined;
|
||||
if (changes !== undefined && (typeof changes !== "number" || !Number.isInteger(changes) || changes < 0 || changes > 100_000)) return undefined;
|
||||
if (device !== undefined && (typeof device !== "string" || device.length > 120 || PLAIN_TEXT.test(device))) return undefined;
|
||||
if (label !== undefined && (typeof label !== "string" || !label.trim() || label.length > 80 || PLAIN_TEXT.test(label))) return undefined;
|
||||
@@ -72,28 +76,13 @@ function parseReports(env: PreviewEnvironment): PreviewReport[] | undefined {
|
||||
}
|
||||
return reports;
|
||||
}
|
||||
/** 12-byte IV followed by the AES-GCM ciphertext and tag; `aad` binds the bytes to this format. */
|
||||
export const PREVIEW_CIPHER = { ivBytes: 12, aad: "expo-explore-preview/1" } as const;
|
||||
const MAX_REPORT_BYTES = 256 * 1024 * 1024;
|
||||
|
||||
function decodeBase64(value: string): Uint8Array<ArrayBuffer> | undefined {
|
||||
if (!/^[A-Za-z0-9+/]+={0,2}$/.test(value)) return undefined;
|
||||
try {
|
||||
const binary = atob(value);
|
||||
const bytes = new Uint8Array(binary.length);
|
||||
for (let index = 0; index < binary.length; index += 1) bytes[index] = binary.charCodeAt(index);
|
||||
return bytes;
|
||||
} catch { return undefined; }
|
||||
}
|
||||
|
||||
/** The deployment's sealed configuration, or undefined when any value is missing or malformed. */
|
||||
/** The deployment's configuration, or undefined when any value is missing or malformed. */
|
||||
export function previewConfig(env: PreviewEnvironment): PreviewConfig | undefined {
|
||||
const token = env.EXPLORE_PREVIEW_TOKEN ?? "";
|
||||
const key = decodeBase64(env.EXPLORE_PREVIEW_KEY ?? "");
|
||||
const expiresAt = env.EXPLORE_PREVIEW_EXPIRES_AT === undefined ? null : Date.parse(env.EXPLORE_PREVIEW_EXPIRES_AT);
|
||||
const reports = parseReports(env);
|
||||
if (!PREVIEW_TOKEN.test(token) || !key || key.byteLength !== 32 || (expiresAt !== null && !Number.isFinite(expiresAt)) || !reports) return undefined;
|
||||
return { token, key, expiresAt, reports };
|
||||
if (!PREVIEW_TOKEN.test(token)) return undefined;
|
||||
const reports = parseReports(env, token);
|
||||
return reports ? { token, reports } : undefined;
|
||||
}
|
||||
|
||||
function baseHeaders(contentType: string): Headers {
|
||||
@@ -112,9 +101,11 @@ export function previewNotFound(): Response {
|
||||
return new Response("Not found", { status: 404, headers: baseHeaders("text/plain; charset=utf-8") });
|
||||
}
|
||||
|
||||
/** After the sealed expiry the token page still opens, and the report routes say so instead of serving. */
|
||||
export function previewExpired(expiredAt: number): Response {
|
||||
return new Response(JSON.stringify({ error: "expired", expiredAt: new Date(expiredAt).toISOString() }), { status: 410, headers: baseHeaders("application/json; charset=utf-8") });
|
||||
/** A route whose static file could not be fetched this time; the same request works once it can, and the Viewer retries. */
|
||||
function previewUnavailable(): Response {
|
||||
const headers = baseHeaders("text/plain; charset=utf-8");
|
||||
headers.set("Retry-After", "1");
|
||||
return new Response("Unavailable", { status: 503, headers });
|
||||
}
|
||||
|
||||
/** Constant-time comparison of two equal-length ASCII tokens. */
|
||||
@@ -125,31 +116,38 @@ function sameToken(a: string, b: string): boolean {
|
||||
return difference === 0;
|
||||
}
|
||||
|
||||
/** A parsed manifest, kept so the shell and the agent API do not fetch and parse it on every request. */
|
||||
type ParsedManifest = { bytes: Uint8Array; loaded: LoadedReport };
|
||||
type ManifestResult = ParsedManifest | "unavailable" | undefined;
|
||||
|
||||
export type PreviewRequestOptions = {
|
||||
env: PreviewEnvironment;
|
||||
indexHtml: string;
|
||||
now?: () => number;
|
||||
/** Same-deployment fetch of static files; defaults to the global fetch. */
|
||||
fetchImpl?: typeof fetch;
|
||||
subtle?: SubtleCrypto;
|
||||
/** Decrypted and parsed reports by path, kept for the life of the isolate; defaults to a module-level cache. */
|
||||
cache?: Map<string, Promise<LoadedReport | undefined>>;
|
||||
/** Parsed manifests by path, least recently used first, within MANIFEST_CACHE_BYTES; defaults to a module-level cache. */
|
||||
cache?: Map<string, ParsedManifest>;
|
||||
/** Manifest fetches in flight by path, shared by the requests waiting for them; defaults to a module-level map. */
|
||||
loading?: Map<string, Promise<ManifestResult>>;
|
||||
};
|
||||
|
||||
const ROUTE = /^\/p\/([a-z2-7]{32})(?:\/|\/(report\.zip|reports\.json|llms\.txt)|(\/api\/v1(?:\/[A-Za-z0-9._:@-]{1,200}){0,2}\/?))?$/;
|
||||
const reportCache = new Map<string, Promise<LoadedReport | undefined>>();
|
||||
const ROUTE = /^\/p\/([a-z2-7]{32})(?:\/|\/(reports\.json|manifest\.json|llms\.txt)|(\/api\/v1(?:\/[A-Za-z0-9._:@-]{1,200}){0,2}\/?))?$/;
|
||||
/** Parsed manifests are kept within this much of the isolate's 128 MB. */
|
||||
const MANIFEST_CACHE_BYTES = 32 * 1024 * 1024;
|
||||
/** What a kept manifest holds: its bytes, and its parsed metadata at about 1.6 times their size. */
|
||||
const heldBytes = (manifest: ParsedManifest) => 3 * manifest.bytes.byteLength;
|
||||
const manifestCache = new Map<string, ParsedManifest>();
|
||||
const manifestLoading = new Map<string, Promise<ManifestResult>>();
|
||||
|
||||
/**
|
||||
* `GET /p/<token>` serves the Viewer shell to browsers and the report's Markdown index to anything
|
||||
* that does not ask for HTML (agents fetch with `Accept: text/markdown` or `*/*`); the shell itself
|
||||
* carries that index as text inside `#root` until the Viewer hydrates, and a `Link` header names the
|
||||
* JSON API. `GET /p/<token>/report.zip` streams the decrypted report (`?target=`, or `?platform=` in older
|
||||
* JSON API. `GET /p/<token>/manifest.json` answers one target's manifest (`?target=`, or `?platform=` in older
|
||||
* links, selects one of several; the first listed otherwise), `GET /p/<token>/reports.json` lists the targets the
|
||||
* deployment serves, `GET /p/<token>/llms.txt` is the Markdown index, and `GET /p/<token>/api/v1/...`
|
||||
* answers the agent API (see agent-api.ts). Every other method, path, or token is an identical 404,
|
||||
* so the response never confirms that a deployment or token exists. After the sealed expiry the exact
|
||||
* token still opens the Viewer shell, and the report routes answer 410 with the expiry instant, so the
|
||||
* Viewer can say the link expired rather than guess.
|
||||
* answers the agent API (see agent-api.ts). Screenshots are static files the Worker never sees. Every other method,
|
||||
* path, or token is an identical 404, so the response never confirms that a deployment or token exists.
|
||||
*/
|
||||
export async function previewResponse(request: Request, options: PreviewRequestOptions): Promise<Response> {
|
||||
const config = previewConfig(options.env);
|
||||
@@ -159,7 +157,6 @@ export async function previewResponse(request: Request, options: PreviewRequestO
|
||||
const match = ROUTE.exec(url.pathname);
|
||||
if (!match || !sameToken(match[1]!, config.token)) return previewNotFound();
|
||||
const route = match[2] ?? (match[3] ? "api" : undefined);
|
||||
const expired = config.expiresAt !== null && (options.now ?? Date.now)() >= config.expiresAt;
|
||||
const pageUrl = `${url.origin}/p/${config.token}`;
|
||||
const linkHeader = `<${pageUrl}/api/${AGENT_API_VERSION}>; rel="alternate"; type="application/json", <${pageUrl}/llms.txt>; rel="alternate"; type="text/markdown"`;
|
||||
const accept = request.headers.get("accept");
|
||||
@@ -167,21 +164,24 @@ export async function previewResponse(request: Request, options: PreviewRequestO
|
||||
const headers = baseHeaders("text/html; charset=utf-8");
|
||||
headers.set("Link", linkHeader);
|
||||
headers.set("Vary", "Accept");
|
||||
if (expired) return new Response(options.indexHtml, { headers });
|
||||
const loaded = await loadedReport(url.origin, selectReport(config, url), config, options);
|
||||
return new Response(loaded ? shellWithIndex(options.indexHtml, agentIndexHtml(agentContext(pageUrl, config, loaded.report), loaded.loaded)) : options.indexHtml, { headers });
|
||||
const selected = selectReport(config, url);
|
||||
const manifest = selected ? await parsedManifest(url.origin, selected, options) : undefined;
|
||||
if (!selected || !manifest || manifest === "unavailable") return new Response(options.indexHtml, { headers });
|
||||
const shell = shellWithIndex(options.indexHtml, agentIndexHtml(agentContext(pageUrl, config, selected), manifest.loaded));
|
||||
// The same URL the Viewer will fetch for this page: its target's query when the link names one, none otherwise.
|
||||
const requested = url.searchParams.get("target") ?? url.searchParams.get("platform");
|
||||
return new Response(shellWithPreload(shell, `/p/${config.token}/manifest.json${requested ? `?${targetQuery(requested)}` : ""}`), { headers });
|
||||
}
|
||||
if (expired) return previewExpired(config.expiresAt!);
|
||||
if (route === "reports.json") {
|
||||
const body = JSON.stringify(config.reports.map(({ path: _path, ...report }) => report));
|
||||
return new Response(body, { headers: baseHeaders("application/json; charset=utf-8") });
|
||||
}
|
||||
const report = selectReport(config, url);
|
||||
if (!report) return previewNotFound();
|
||||
if (route === "report.zip") return decryptedReport(url.origin, report.path, config, options);
|
||||
const loaded = await loadedReport(url.origin, report, config, options);
|
||||
if (!loaded) {
|
||||
if (route !== undefined) return previewNotFound();
|
||||
if (route === "manifest.json") return manifestResponse(url.origin, report, options);
|
||||
const manifest = await parsedManifest(url.origin, report, options);
|
||||
if (!manifest || manifest === "unavailable") {
|
||||
if (route !== undefined) return manifest === "unavailable" ? previewUnavailable() : previewNotFound();
|
||||
const headers = baseHeaders("text/html; charset=utf-8");
|
||||
headers.set("Link", linkHeader);
|
||||
headers.set("Vary", "Accept");
|
||||
@@ -192,9 +192,9 @@ export async function previewResponse(request: Request, options: PreviewRequestO
|
||||
const headers = baseHeaders("text/markdown; charset=utf-8");
|
||||
headers.set("Link", linkHeader);
|
||||
headers.set("Vary", "Accept");
|
||||
return new Response(agentIndexMarkdown(context, loaded.loaded), { headers });
|
||||
return new Response(agentIndexMarkdown(context, manifest.loaded), { headers });
|
||||
}
|
||||
const reply = await agentApiReply(context, loaded.loaded, match[3]!.slice("/api/v1".length).replace(/\/$/, ""), url.searchParams, accept);
|
||||
const reply = await agentApiReply(context, manifest.loaded, match[3]!.slice("/api/v1".length).replace(/\/$/, ""), url.searchParams, accept);
|
||||
const headers = baseHeaders(reply.contentType);
|
||||
headers.set("Vary", "Accept");
|
||||
for (const [key, value] of Object.entries(reply.headers ?? {})) headers.set(key, value);
|
||||
@@ -216,10 +216,26 @@ export function selectReport(config: PreviewConfig, url: URL): PreviewReport | u
|
||||
function agentContext(pageUrl: string, config: PreviewConfig, report: PreviewReport): AgentContext {
|
||||
return { pageUrl, platform: report.platform, platforms: [...new Set(config.reports.map(entry => entry.platform))], target: report.target,
|
||||
targets: config.reports.map(entry => ({ id: entry.target, platform: entry.platform, label: entry.label ?? (entry.target === entry.platform ? PLATFORM_LABELS[entry.platform] : entry.target) })),
|
||||
expiresAt: config.expiresAt === null ? null : new Date(config.expiresAt).toISOString() };
|
||||
// A hosted preview lasts as long as its EAS Hosting deployment; Explore sets no expiry of its own.
|
||||
expiresAt: null };
|
||||
}
|
||||
const PLATFORM_LABELS: Record<PreviewPlatform, string> = { ios: "iOS", android: "Android" };
|
||||
|
||||
/** `platform=<id>` for a target named after its platform (links from before targets), `target=<id>` otherwise. */
|
||||
function targetQuery(target: string): string {
|
||||
return `${target === "ios" || target === "android" ? "platform" : "target"}=${target}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Start the manifest download while the Viewer bundle is still loading: `crossorigin` makes the preload match
|
||||
* the Viewer's same-origin `fetch`, so the bytes arrive once.
|
||||
*/
|
||||
export function shellWithPreload(indexHtml: string, manifestPath: string): string {
|
||||
const link = `<link rel="preload" href="${manifestPath}" as="fetch" crossorigin>`;
|
||||
const at = indexHtml.indexOf("</head>") !== -1 ? indexHtml.indexOf("</head>") : indexHtml.indexOf("<script");
|
||||
return at === -1 ? indexHtml : `${indexHtml.slice(0, at)}${link}${indexHtml.slice(at)}`;
|
||||
}
|
||||
|
||||
/** The agent index as the shell's initial `#root` content; the Viewer replaces it when it renders. */
|
||||
export function shellWithIndex(indexHtml: string, indexBlock: string): string {
|
||||
const root = '<div id="root"></div>';
|
||||
@@ -228,44 +244,89 @@ export function shellWithIndex(indexHtml: string, indexBlock: string): string {
|
||||
return body === -1 ? indexHtml : `${indexHtml.slice(0, body)}${indexBlock}${indexHtml.slice(body)}`;
|
||||
}
|
||||
|
||||
async function loadedReport(origin: string, report: PreviewReport | undefined, config: PreviewConfig, options: PreviewRequestOptions): Promise<{ report: PreviewReport; loaded: LoadedReport } | undefined> {
|
||||
if (!report) return undefined;
|
||||
const cache = options.cache ?? reportCache;
|
||||
const key = `${origin}${report.path}`;
|
||||
let pending = cache.get(key);
|
||||
if (!pending) {
|
||||
pending = decryptedBytes(origin, report.path, config, options).then(bytes => (bytes ? loadReport(bytes) : undefined));
|
||||
cache.set(key, pending);
|
||||
pending.then(loaded => { if (!loaded) cache.delete(key); }, () => cache.delete(key));
|
||||
/**
|
||||
* One target's manifest for the Viewer. A kept one is answered from memory; otherwise the static file streams through
|
||||
* unparsed, so a prefetch of every target costs the isolate almost no CPU.
|
||||
*/
|
||||
async function manifestResponse(origin: string, report: PreviewReport, options: PreviewRequestOptions): Promise<Response> {
|
||||
const headers = baseHeaders("application/json; charset=utf-8");
|
||||
const kept = (options.cache ?? manifestCache).get(`${origin}${report.path}`);
|
||||
if (kept) return new Response(kept.bytes as BodyInit, { headers });
|
||||
const upstream = await staticFile(origin, report.path, options);
|
||||
if (upstream === "unavailable") return previewUnavailable();
|
||||
if (!upstream) return previewNotFound();
|
||||
return new Response(upstream.body, { headers });
|
||||
}
|
||||
|
||||
/** A static file of this deployment: "unavailable" when it cannot be fetched now, undefined when it is not there. */
|
||||
async function staticFile(origin: string, path: string, options: PreviewRequestOptions): Promise<Response | "unavailable" | undefined> {
|
||||
let upstream: Response;
|
||||
try { upstream = await (options.fetchImpl ?? fetch)(new URL(path, origin).href); }
|
||||
catch { return "unavailable"; }
|
||||
if (upstream.status >= 500) return "unavailable";
|
||||
if (upstream.status !== 200 || !upstream.body) {
|
||||
await upstream.body?.cancel();
|
||||
return undefined;
|
||||
}
|
||||
const loaded = await pending;
|
||||
return loaded ? { report, loaded } : undefined;
|
||||
return upstream;
|
||||
}
|
||||
|
||||
async function decryptedBytes(origin: string, reportPath: string, config: PreviewConfig, options: PreviewRequestOptions): Promise<Uint8Array | undefined> {
|
||||
const fetchImpl = options.fetchImpl ?? fetch;
|
||||
const subtle = options.subtle ?? crypto.subtle;
|
||||
const upstream = await fetchImpl(new URL(reportPath, origin).href, { headers: { accept: "application/octet-stream" } });
|
||||
if (upstream.status !== 200 || !upstream.body) return undefined;
|
||||
const declared = Number(upstream.headers.get("content-length") ?? "0");
|
||||
if (declared > MAX_REPORT_BYTES + PREVIEW_CIPHER.ivBytes + 16) return undefined;
|
||||
const sealed = new Uint8Array(await upstream.arrayBuffer());
|
||||
if (sealed.byteLength <= PREVIEW_CIPHER.ivBytes + 16 || sealed.byteLength > MAX_REPORT_BYTES + PREVIEW_CIPHER.ivBytes + 16) return undefined;
|
||||
try {
|
||||
const key = await subtle.importKey("raw", config.key, "AES-GCM", false, ["decrypt"]);
|
||||
return new Uint8Array(await subtle.decrypt(
|
||||
{ name: "AES-GCM", iv: sealed.subarray(0, PREVIEW_CIPHER.ivBytes), additionalData: new TextEncoder().encode(PREVIEW_CIPHER.aad) },
|
||||
key, sealed.subarray(PREVIEW_CIPHER.ivBytes)));
|
||||
} catch { return undefined; }
|
||||
/** At most `limit` bytes of a response, or undefined when it has more. */
|
||||
async function bodyBytes(response: Response, limit: number): Promise<Uint8Array | undefined> {
|
||||
const declared = Number(response.headers.get("content-length") ?? "0");
|
||||
if (declared > limit) {
|
||||
await response.body?.cancel();
|
||||
return undefined;
|
||||
}
|
||||
const bytes = new Uint8Array(await response.arrayBuffer());
|
||||
return bytes.byteLength > limit ? undefined : bytes;
|
||||
}
|
||||
|
||||
async function decryptedReport(origin: string, reportPath: string, config: PreviewConfig, options: PreviewRequestOptions): Promise<Response> {
|
||||
const plain = await decryptedBytes(origin, reportPath, config, options);
|
||||
if (!plain) return previewNotFound();
|
||||
const headers = baseHeaders("application/zip");
|
||||
headers.set("Content-Length", String(plain.byteLength));
|
||||
headers.set("Content-Disposition", 'inline; filename="report.zip"');
|
||||
return new Response(plain as BodyInit, { headers });
|
||||
/** One target's manifest, parsed: from the isolate's cache, or fetched now (requests that arrive together share one fetch). */
|
||||
async function parsedManifest(origin: string, report: PreviewReport, options: PreviewRequestOptions): Promise<ManifestResult> {
|
||||
const cache = options.cache ?? manifestCache;
|
||||
const loading = options.loading ?? manifestLoading;
|
||||
const key = `${origin}${report.path}`;
|
||||
const cached = cache.get(key);
|
||||
if (cached) {
|
||||
// Most recently used last, so the oldest is the first to go.
|
||||
cache.delete(key);
|
||||
cache.set(key, cached);
|
||||
return cached;
|
||||
}
|
||||
let pending = loading.get(key);
|
||||
if (!pending) {
|
||||
pending = fetchManifest(origin, report, options).catch(() => "unavailable" as const);
|
||||
loading.set(key, pending);
|
||||
void pending.finally(() => { if (loading.get(key) === pending) loading.delete(key); });
|
||||
}
|
||||
const parsed = await pending;
|
||||
if (parsed && parsed !== "unavailable" && !cache.has(key) && heldBytes(parsed) <= MANIFEST_CACHE_BYTES) {
|
||||
let held = heldBytes(parsed);
|
||||
for (const kept of cache.values()) held += heldBytes(kept);
|
||||
for (const [oldest, kept] of cache) {
|
||||
if (held <= MANIFEST_CACHE_BYTES) break;
|
||||
cache.delete(oldest);
|
||||
held -= heldBytes(kept);
|
||||
}
|
||||
cache.set(key, parsed);
|
||||
}
|
||||
return parsed;
|
||||
}
|
||||
|
||||
async function fetchManifest(origin: string, report: PreviewReport, options: PreviewRequestOptions): Promise<ManifestResult> {
|
||||
const upstream = await staticFile(origin, report.path, options);
|
||||
if (!upstream || upstream === "unavailable") return upstream;
|
||||
const bytes = await bodyBytes(upstream, MAX_MANIFEST_BYTES);
|
||||
if (!bytes) return undefined;
|
||||
// The agent API reads screenshots from the same static files the Viewer does, next to the manifest's target directory.
|
||||
const base = new URL(report.path.replace(/\/targets\/[^/]+$/, "/"), origin);
|
||||
const loaded = reportFromManifest(bytes, async (name, limit) => {
|
||||
const asset = await staticFile(origin, new URL(name, base).pathname, options);
|
||||
if (asset === "unavailable") throw new Error(`${name} is unavailable`);
|
||||
return asset ? bodyBytes(asset, Math.min(limit, MAX_ASSET_BYTES)) : undefined;
|
||||
});
|
||||
return loaded ? { bytes, loaded } : undefined;
|
||||
}
|
||||
|
||||
/** Requests the Viewer shell never issues; identical to the token-less answer. */
|
||||
|
||||
@@ -1,27 +1,18 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
import { webcrypto, createHash } from "node:crypto";
|
||||
import { createHash } from "node:crypto";
|
||||
import { deflateRawSync } from "node:zlib";
|
||||
import { readFileSync } from "node:fs";
|
||||
import { PREVIEW_CIPHER, previewResponse, type PreviewEnvironment } from "../src/server/preview";
|
||||
import { previewResponse, type PreviewEnvironment } from "../src/server/preview";
|
||||
import { agentApiReply, agentIndexMarkdown, loadReport, prefersHtml, prefersMarkdown } from "../../src/report/agent-api";
|
||||
import { manifestBody, MAX_MANIFEST_BYTES, reportFromManifest } from "../../src/report/preview-manifest";
|
||||
import { readZipDirectory } from "../../src/report/zip-reader";
|
||||
|
||||
const subtle = webcrypto.subtle as SubtleCrypto;
|
||||
const token = "abcdefghijklmnopqrstuvwxyz234567";
|
||||
const origin = "https://acme-explore--k7f3z0d1q8.expo.app";
|
||||
const html = '<!doctype html><html><body><div id="root"></div><script type="module" src="/viewer/assets/main.js"></script></body></html>';
|
||||
const keyBytes: Uint8Array<ArrayBuffer> = webcrypto.getRandomValues(new Uint8Array(32));
|
||||
const review = new Uint8Array(readFileSync(new URL("../../test/fixtures/example-review-artifact.zip", import.meta.url))) as Uint8Array<ArrayBuffer>;
|
||||
|
||||
async function sealed(plain: Uint8Array<ArrayBuffer>): Promise<Uint8Array<ArrayBuffer>> {
|
||||
const key = await subtle.importKey("raw", keyBytes, "AES-GCM", false, ["encrypt"]);
|
||||
const iv = webcrypto.getRandomValues(new Uint8Array(PREVIEW_CIPHER.ivBytes));
|
||||
const cipher = new Uint8Array(await subtle.encrypt({ name: "AES-GCM", iv, additionalData: new TextEncoder().encode(PREVIEW_CIPHER.aad) }, key, plain));
|
||||
const out = new Uint8Array(iv.byteLength + cipher.byteLength);
|
||||
out.set(iv); out.set(cipher, iv.byteLength);
|
||||
return out;
|
||||
}
|
||||
|
||||
/** A ZIP the way zipReportDirectory writes one: the JSON deflated, PNGs stored. */
|
||||
function zip(files: Record<string, Uint8Array>): Uint8Array<ArrayBuffer> {
|
||||
@@ -74,19 +65,26 @@ const explorationReport = {
|
||||
};
|
||||
const explorationZip = zip({ "exploration.json": new TextEncoder().encode(JSON.stringify(explorationReport)), [`assets/${pngSha}.png`]: png });
|
||||
|
||||
function deployment(files: Record<string, Uint8Array<ArrayBuffer>>, env: PreviewEnvironment, now?: () => number) {
|
||||
/** A hosted preview as ci:deploy writes it: each target's manifest at its path, and every asset once under the token. */
|
||||
async function deployment(reports: Record<string, Uint8Array>, env: PreviewEnvironment) {
|
||||
const files: Record<string, Uint8Array> = {};
|
||||
for (const [path, archive] of Object.entries(reports)) {
|
||||
const loaded = (await loadReport(archive))!;
|
||||
files[path] = new TextEncoder().encode(manifestBody(loaded));
|
||||
for (const name of loaded.entries.keys()) if (name.startsWith("assets/") && !name.endsWith("/")) files[`/p/${token}/${name}`] = (await loaded.read(name, 64 * 1024 * 1024))!;
|
||||
}
|
||||
const calls: string[] = [];
|
||||
const fetchImpl = (async (input: RequestInfo | URL) => {
|
||||
const url = new URL(typeof input === "string" ? input : input instanceof URL ? input.href : input.url);
|
||||
calls.push(url.href);
|
||||
const body = files[url.pathname];
|
||||
return body ? new Response(body, { headers: { "content-length": String(body.byteLength) } }) : new Response("missing", { status: 404 });
|
||||
return body ? new Response(body as BodyInit, { headers: { "content-length": String(body.byteLength) } }) : new Response("missing", { status: 404 });
|
||||
}) as typeof fetch;
|
||||
const options = { env, indexHtml: html, fetchImpl, subtle, cache: new Map(), ...(now ? { now } : {}) };
|
||||
return { calls, get: (path: string, accept?: string) => previewResponse(new Request(`${origin}/p/${token}${path}`, accept === undefined ? {} : { headers: { accept } }), options) };
|
||||
const options = { env, indexHtml: html, fetchImpl, cache: new Map(), loading: new Map() };
|
||||
return { calls, files, cache: options.cache, get: (path: string, accept?: string) => previewResponse(new Request(`${origin}/p/${token}${path}`, accept === undefined ? {} : { headers: { accept } }), options) };
|
||||
}
|
||||
|
||||
const reviewEnv: PreviewEnvironment = { EXPLORE_PREVIEW_TOKEN: token, EXPLORE_PREVIEW_KEY: Buffer.from(keyBytes).toString("base64"), EXPLORE_PREVIEW_EXPIRES_AT: "2030-01-01T00:00:00Z", EXPLORE_PREVIEW_REPORT: "/_report/abcdefghijklmnop/report.zip.enc" };
|
||||
const reviewEnv: PreviewEnvironment = { EXPLORE_PREVIEW_TOKEN: token, EXPLORE_PREVIEW_REPORT: `/p/${token}/targets/report.json` };
|
||||
|
||||
test("the archive reader accepts the deployed layout and rejects everything else", async () => {
|
||||
assert.ok(readZipDirectory(review)?.has("review.json"));
|
||||
@@ -98,7 +96,7 @@ test("the archive reader accepts the deployed layout and rejects everything else
|
||||
});
|
||||
|
||||
test("the token page negotiates: browsers get the shell carrying the agent index, everything else gets Markdown", async () => {
|
||||
const site = deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: await sealed(review) }, reviewEnv);
|
||||
const site = await deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: review }, reviewEnv);
|
||||
const browser = await site.get("?view=compare&screen=home", "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8");
|
||||
assert.equal(browser.status, 200);
|
||||
assert.match(browser.headers.get("content-type") ?? "", /^text\/html/);
|
||||
@@ -106,7 +104,7 @@ test("the token page negotiates: browsers get the shell carrying the agent index
|
||||
assert.ok(shell.startsWith("<!doctype html>"));
|
||||
assert.match(shell, /<div id="root"><section data-explore-agent-index style="[^"]*clip:rect\(0 0 0 0\)[^"]*"><h1>Expo Explore report: .* PR #\d+/);
|
||||
assert.match(shell, new RegExp(`href="${origin}/p/${token}/api/v1/screens\\?status=modified,accessibility-only,added,removed"`));
|
||||
assert.match(shell, /<\/section><\/div><script type="module"/);
|
||||
assert.match(shell, /<\/section><\/div><link rel="preload" [^>]*><script type="module"/);
|
||||
assert.equal(browser.headers.get("vary"), "Accept");
|
||||
assert.equal(browser.headers.get("link"), `<${origin}/p/${token}/api/v1>; rel="alternate"; type="application/json", <${origin}/p/${token}/llms.txt>; rel="alternate"; type="text/markdown"`);
|
||||
assert.equal(browser.headers.get("cache-control"), "private, no-store");
|
||||
@@ -118,19 +116,19 @@ test("the token page negotiates: browsers get the shell carrying the agent index
|
||||
assert.match(response.headers.get("content-type") ?? "", /^text\/markdown/, String(accept));
|
||||
const body = await response.text();
|
||||
assert.match(body, /^# Expo Explore report: /, String(accept));
|
||||
assert.match(body, /This link stops serving the report after 2030-01-01T00:00:00.000Z/);
|
||||
assert.ok(!body.includes("stops serving"), "a hosted preview lasts as long as its deployment; the index names no expiry");
|
||||
assert.ok(body.includes(`(${origin}/p/${token}/api/v1/screens?status=modified,accessibility-only,added,removed)`), body);
|
||||
assert.equal(response.headers.get("content-security-policy"), browser.headers.get("content-security-policy"));
|
||||
}
|
||||
const llms = await site.get("/llms.txt", "text/html");
|
||||
assert.match(llms.headers.get("content-type") ?? "", /^text\/markdown/);
|
||||
assert.equal(await llms.text(), await (await site.get("")).text());
|
||||
// The sealed file is decrypted and parsed once per isolate, not once per request.
|
||||
// The static manifest is fetched and parsed once per isolate, not once per request.
|
||||
assert.deepEqual(site.calls, [`${origin}${reviewEnv.EXPLORE_PREVIEW_REPORT}`]);
|
||||
});
|
||||
|
||||
test("the API serves a PR review: summary, filtered and paged screens, detail, transitions, assets, raw", async () => {
|
||||
const site = deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: await sealed(review) }, reviewEnv);
|
||||
const site = await deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: review }, reviewEnv);
|
||||
const summary = await (await site.get("/api/v1")).json();
|
||||
assert.equal(summary.kind, "pr-review");
|
||||
assert.equal(summary.contract, "explore.review");
|
||||
@@ -198,12 +196,15 @@ test("the API serves a PR review: summary, filtered and paged screens, detail, t
|
||||
|
||||
const raw = await site.get("/api/v1/raw");
|
||||
assert.equal(raw.status, 200);
|
||||
assert.equal((await raw.json()).review.contract, "explore.review", "raw is the file as written, review nested under `review`");
|
||||
assert.deepEqual(site.calls, [`${origin}${reviewEnv.EXPLORE_PREVIEW_REPORT}`]);
|
||||
const rawBytes = new Uint8Array(await raw.arrayBuffer());
|
||||
assert.deepEqual(rawBytes, (await loadReport(review))!.raw, "raw is review.json byte for byte, as the ZIP held it");
|
||||
assert.equal(JSON.parse(new TextDecoder().decode(rawBytes)).review.contract, "explore.review");
|
||||
// The manifest once, and the one screenshot asked for, read from the same static file the Viewer loads.
|
||||
assert.deepEqual(site.calls, [`${origin}${reviewEnv.EXPLORE_PREVIEW_REPORT}`, `${origin}/p/${token}/assets/${sha}.png`]);
|
||||
});
|
||||
|
||||
test("the API serves an exploration: screens with elements and transitions, journeys, gaps, frontier", async () => {
|
||||
const site = deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: await sealed(explorationZip) }, reviewEnv);
|
||||
const site = await deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: explorationZip }, reviewEnv);
|
||||
const index = await (await site.get("")).text();
|
||||
assert.match(index, /^# Expo Explore exploration: Euxy \(ios\)/);
|
||||
assert.ok(index.includes("mapped 2 screens, 1 transitions, 1 elements; 1 coverage gaps. Stopped: budget. Mapped the sequencer."), index);
|
||||
@@ -229,22 +230,9 @@ test("the API serves an exploration: screens with elements and transitions, jour
|
||||
assert.deepEqual(await (await site.get("/api/v1/raw")).json(), explorationReport);
|
||||
});
|
||||
|
||||
test("expiry, platforms and wrong tokens behave like the report routes", async () => {
|
||||
const after = () => Date.parse("2030-01-01T00:00:00Z");
|
||||
const expired = deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: await sealed(review) }, reviewEnv, after);
|
||||
const shell = await expired.get("", "text/html");
|
||||
assert.equal(shell.status, 200);
|
||||
assert.equal(await shell.text(), html, "the expired shell carries no report data");
|
||||
assert.equal((await expired.get("/api/v1/screens/", "text/html")).status, 410);
|
||||
for (const path of ["", "/llms.txt", "/api/v1", "/api/v1/screens", `/api/v1/assets/${"a".repeat(64)}`]) {
|
||||
const response = await expired.get(path);
|
||||
assert.equal(response.status, 410, path);
|
||||
assert.deepEqual(await response.json(), { error: "expired", expiredAt: "2030-01-01T00:00:00.000Z" });
|
||||
}
|
||||
assert.deepEqual(expired.calls, []);
|
||||
|
||||
const multiEnv: PreviewEnvironment = { ...reviewEnv, EXPLORE_PREVIEW_REPORT: undefined, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ platform: "ios", path: "/_report/abcdefghijklmnop/ios.zip.enc" }, { platform: "android", path: "/_report/abcdefghijklmnop/android.zip.enc" }]) };
|
||||
const multi = deployment({ "/_report/abcdefghijklmnop/ios.zip.enc": await sealed(review), "/_report/abcdefghijklmnop/android.zip.enc": await sealed(explorationZip) }, multiEnv);
|
||||
test("platforms and wrong tokens behave like the report routes", async () => {
|
||||
const multiEnv: PreviewEnvironment = { ...reviewEnv, EXPLORE_PREVIEW_REPORT: undefined, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ platform: "ios", path: `/p/${token}/targets/ios.json` }, { platform: "android", path: `/p/${token}/targets/android.json` }]) };
|
||||
const multi = await deployment({ [`/p/${token}/targets/ios.json`]: review, [`/p/${token}/targets/android.json`]: explorationZip }, multiEnv);
|
||||
const ios = await (await multi.get("/api/v1")).json();
|
||||
assert.equal(ios.kind, "pr-review");
|
||||
assert.deepEqual(ios.platforms, ["ios", "android"]);
|
||||
@@ -257,12 +245,12 @@ test("expiry, platforms and wrong tokens behave like the report routes", async (
|
||||
assert.match(await (await multi.get("?platform=android")).text(), /^# Expo Explore exploration/);
|
||||
assert.equal((await multi.get("/api/v1?platform=web")).status, 404);
|
||||
assert.equal((await multi.get("/api/v1?platform=ios&platform=android")).status, 404);
|
||||
assert.equal(multi.calls.length, 2, "each platform's report is decrypted once");
|
||||
assert.equal(multi.calls.length, 2, "each platform's manifest is fetched once");
|
||||
|
||||
const wrongToken = token.replace(/a/, "b");
|
||||
const site = deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: await sealed(review) }, reviewEnv);
|
||||
const site = await deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: review }, reviewEnv);
|
||||
for (const path of [`/p/${wrongToken}/api/v1`, `/p/${wrongToken}/llms.txt`, `/p/${token}/API/v1`, `/p/${token}/api/v1//screens`]) {
|
||||
const response = await previewResponse(new Request(`${origin}${path}`), { env: reviewEnv, indexHtml: html, fetchImpl: fetch, subtle, cache: new Map() });
|
||||
const response = await previewResponse(new Request(`${origin}${path}`), { env: reviewEnv, indexHtml: html, fetchImpl: fetch, cache: new Map() });
|
||||
assert.equal(response.status, 404, path);
|
||||
}
|
||||
assert.equal((await site.get("/api/v1", undefined)).status, 200);
|
||||
@@ -337,12 +325,12 @@ test("statuses follow the Viewer: accessibility-only, unavailable for a failed o
|
||||
|
||||
test("a deployment of several targets keeps each target in its links and names the others in the index", async () => {
|
||||
const listing = [
|
||||
{ target: "iphone", platform: "ios", label: "iPhone 17", path: "/_report/abcdefghijklmnop/iphone.zip.enc" },
|
||||
{ target: "duo-open", platform: "ios", label: "iPhone Duo (open)", path: "/_report/abcdefghijklmnop/duo-open.zip.enc" },
|
||||
{ target: "android", platform: "android", label: "Android", path: "/_report/abcdefghijklmnop/android.zip.enc" },
|
||||
{ target: "iphone", platform: "ios", label: "iPhone 17", path: `/p/${token}/targets/iphone.json` },
|
||||
{ target: "duo-open", platform: "ios", label: "iPhone Duo (open)", path: `/p/${token}/targets/duo-open.json` },
|
||||
{ target: "android", platform: "android", label: "Android", path: `/p/${token}/targets/android.json` },
|
||||
];
|
||||
const targetsEnv: PreviewEnvironment = { ...reviewEnv, EXPLORE_PREVIEW_REPORT: undefined, EXPLORE_PREVIEW_REPORTS: JSON.stringify(listing) };
|
||||
const site = deployment({ [listing[0]!.path]: await sealed(review), [listing[1]!.path]: await sealed(review), [listing[2]!.path]: await sealed(explorationZip) }, targetsEnv);
|
||||
const site = await deployment({ [listing[0]!.path]: review, [listing[1]!.path]: review, [listing[2]!.path]: explorationZip }, targetsEnv);
|
||||
const duo = await (await site.get("/api/v1?target=duo-open")).json();
|
||||
assert.equal(duo.kind, "pr-review");
|
||||
assert.deepEqual(duo.platforms, ["ios", "android"], "distinct platforms, as before targets");
|
||||
@@ -363,3 +351,113 @@ test("a deployment of several targets keeps each target in its links and names t
|
||||
assert.equal((await (await site.get("/api/v1?platform=android")).json()).kind, "exploration");
|
||||
assert.equal((await site.get("/api/v1?target=pixel")).status, 404);
|
||||
});
|
||||
|
||||
test("the manifest route answers each target's static manifest, the shell preloads it, and screenshots are not the Worker's", async () => {
|
||||
const site = await deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: review }, reviewEnv);
|
||||
const shell = await (await site.get("", "text/html")).text();
|
||||
assert.ok(shell.includes(`<link rel="preload" href="/p/${token}/manifest.json" as="fetch" crossorigin><script type="module"`), shell.slice(0, 400));
|
||||
const linked = await (await site.get("?target=ios&view=compare", "text/html")).text();
|
||||
assert.ok(linked.includes(`<link rel="preload" href="/p/${token}/manifest.json?platform=ios" as="fetch" crossorigin>`), linked.slice(0, 400));
|
||||
|
||||
const manifest = await site.get("/manifest.json");
|
||||
assert.equal(manifest.status, 200);
|
||||
assert.match(manifest.headers.get("content-type") ?? "", /^application\/json/);
|
||||
assert.equal(manifest.headers.get("cache-control"), "private, no-store");
|
||||
assert.equal(await manifest.text(), new TextDecoder().decode(site.files[reviewEnv.EXPLORE_PREVIEW_REPORT!]), "the static manifest, byte for byte");
|
||||
// Screenshots are static files EAS Hosting serves itself; a path the deployment does not hold is the Worker's 404.
|
||||
for (const path of ["/assets/" + "0".repeat(64) + ".png", "/report.zip", "/targets/report.json"]) {
|
||||
assert.equal((await site.get(path)).status, 404, path);
|
||||
}
|
||||
});
|
||||
|
||||
test("a ZIP's directory records are not assets: the manifest the Viewer validates names files only", async () => {
|
||||
const withDirectory = zip({ "exploration.json": new TextEncoder().encode(JSON.stringify(explorationReport)), "assets/": new Uint8Array(), [`assets/${pngSha}.png`]: png });
|
||||
assert.ok(readZipDirectory(withDirectory)!.has("assets/"));
|
||||
assert.deepEqual(JSON.parse(manifestBody((await loadReport(withDirectory))!)).entries, { [`assets/${pngSha}.png`]: png.byteLength });
|
||||
assert.equal(JSON.parse(manifestBody((await loadReport(withDirectory))!, "abc")).deployment, "abc", "a deployment stamps the manifests it writes");
|
||||
});
|
||||
|
||||
test("a static file the Worker cannot fetch this time answers 503, which the Viewer retries; one that is not there is a 404", async () => {
|
||||
const flaky = (status: number) => (path: string) => previewResponse(new Request(`${origin}/p/${token}${path}`), {
|
||||
env: reviewEnv, indexHtml: html, cache: new Map(), loading: new Map(), fetchImpl: (async () => new Response("upstream", { status })) as typeof fetch });
|
||||
for (const path of ["/manifest.json", "/api/v1", "/llms.txt"]) {
|
||||
const response = await flaky(502)(path);
|
||||
assert.equal(response.status, 503, path);
|
||||
assert.equal(response.headers.get("retry-after"), "1");
|
||||
assert.equal(response.headers.get("cache-control"), "private, no-store");
|
||||
assert.equal((await flaky(404)(path)).status, 404, path);
|
||||
}
|
||||
// The shell still opens; the Viewer then asks for the manifest and shows why it cannot.
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`, { headers: { accept: "text/html" } }), {
|
||||
env: reviewEnv, indexHtml: html, cache: new Map(), loading: new Map(), fetchImpl: (async () => new Response("upstream", { status: 502 })) as typeof fetch })).status, 200);
|
||||
const garbage = { env: reviewEnv, indexHtml: html, cache: new Map(), loading: new Map(),
|
||||
fetchImpl: (async () => new Response("not a manifest", { status: 200 })) as typeof fetch };
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/api/v1`), garbage)).status, 404, "a file that is not a manifest of a report");
|
||||
});
|
||||
|
||||
test("the shell and the agent API share one fetch of a manifest, kept within the cache's bytes; the manifest route only passes it through", async () => {
|
||||
const listing = ["iphone", "duo-open"].map(target => ({ target, platform: "ios", label: target, path: `/p/${token}/targets/${target}.json` }));
|
||||
const env: PreviewEnvironment = { ...reviewEnv, EXPLORE_PREVIEW_REPORT: undefined, EXPLORE_PREVIEW_REPORTS: JSON.stringify(listing) };
|
||||
const site = await deployment(Object.fromEntries(listing.map(entry => [entry.path, explorationZip])), env);
|
||||
// Requests that arrive together wait for one fetch.
|
||||
assert.deepEqual((await Promise.all([site.get("/api/v1?target=iphone"), site.get("/llms.txt?target=iphone"), site.get("?target=iphone", "text/html")])).map(response => response.status), [200, 200, 200]);
|
||||
assert.equal(site.calls.length, 1);
|
||||
// Kept now, so the Viewer's manifest request is answered from memory.
|
||||
assert.equal((await site.get("/manifest.json?target=iphone")).status, 200);
|
||||
assert.equal(site.calls.length, 1);
|
||||
// Not kept (a prefetch of another target): streamed through each time, never parsed.
|
||||
assert.equal((await site.get("/manifest.json?target=duo-open")).status, 200);
|
||||
assert.equal((await site.get("/manifest.json?target=duo-open")).status, 200);
|
||||
assert.equal(site.calls.length, 3);
|
||||
});
|
||||
|
||||
test("a manifest is parsed once and keeps the report's own bytes; another key order still opens; one the Viewer would refuse does not", async () => {
|
||||
const loaded = (await loadReport(review))!;
|
||||
const read = async () => undefined;
|
||||
const written = new TextEncoder().encode(manifestBody(loaded, "stamp"));
|
||||
const parsed = reportFromManifest(written, read)!;
|
||||
assert.equal(parsed.kind, "pr-review");
|
||||
assert.deepEqual(parsed.raw, loaded.raw);
|
||||
assert.equal(parsed.raw.buffer, written.buffer, "the report's bytes are a view of the manifest, not a copy");
|
||||
assert.equal(parsed.entries.size, [...loaded.entries.keys()].filter(name => name.startsWith("assets/")).length);
|
||||
// Another writer's layout: parsed whole, the report re-serialized.
|
||||
const reordered = JSON.parse(new TextDecoder().decode(written));
|
||||
const other = reportFromManifest(new TextEncoder().encode(JSON.stringify({ report: reordered.report, format: reordered.format, file: reordered.file, entries: reordered.entries })), read)!;
|
||||
assert.equal(other.kind, "pr-review");
|
||||
assert.deepEqual(other.json, parsed.json);
|
||||
// A nested `"report"` key before the report's own is not where the report starts.
|
||||
const nested = `{"format":"explore.preview-manifest/1","extra":{"a":1,"report":2},"file":"review.json","entries":{},"report":${new TextDecoder().decode(loaded.raw)}}`;
|
||||
const fromNested = reportFromManifest(new TextEncoder().encode(nested), read)!;
|
||||
assert.equal(fromNested.kind, "pr-review");
|
||||
assert.deepEqual(fromNested.json, parsed.json);
|
||||
for (const bad of ['{"format":"explore.preview-manifest/1","file":"review.json","entries":{"../x":1},"report":{}}', '{"format":"other","file":"review.json","entries":{},"report":{}}', "not json"]) {
|
||||
assert.equal(reportFromManifest(new TextEncoder().encode(bad), read), undefined, bad);
|
||||
}
|
||||
assert.equal(reportFromManifest(new Uint8Array(MAX_MANIFEST_BYTES + 1), read), undefined, "larger than the Viewer opens");
|
||||
});
|
||||
|
||||
test("an agent's screenshot the Worker cannot fetch this time is a 503; one the report does not hold is a 404", async () => {
|
||||
const site = await deployment({ [reviewEnv.EXPLORE_PREVIEW_REPORT!]: review }, reviewEnv);
|
||||
const loaded = (await loadReport(review))!;
|
||||
const name = [...loaded.entries.keys()].find(entry => /^assets\/[a-f0-9]{64}\.png$/.test(entry))!;
|
||||
const sha = name.slice(7, 71);
|
||||
const manifest = site.files[reviewEnv.EXPLORE_PREVIEW_REPORT!]!;
|
||||
const failing = (status: number) => previewResponse(new Request(`${origin}/p/${token}/api/v1/assets/${sha}`), { env: reviewEnv, indexHtml: html, cache: new Map(), loading: new Map(),
|
||||
fetchImpl: (async (input: RequestInfo | URL) => String(input).endsWith(".json") ? new Response(manifest as BodyInit) : new Response("upstream", { status })) as typeof fetch });
|
||||
const unavailable = await failing(502);
|
||||
assert.equal(unavailable.status, 503);
|
||||
assert.equal((await unavailable.json()).error, "unavailable");
|
||||
assert.equal((await failing(404)).status, 404);
|
||||
});
|
||||
|
||||
test("kept manifests count their parsed size against the cache: the oldest goes when the next would not fit", async () => {
|
||||
const big = (label: string) => zip({ "exploration.json": new TextEncoder().encode(JSON.stringify({ ...explorationReport, padding: label.repeat(6 * 1024 * 1024) })), [`assets/${pngSha}.png`]: png });
|
||||
const listing = ["first", "second"].map(target => ({ target, platform: "ios", label: target, path: `/p/${token}/targets/${target}.json` }));
|
||||
const env: PreviewEnvironment = { ...reviewEnv, EXPLORE_PREVIEW_REPORT: undefined, EXPLORE_PREVIEW_REPORTS: JSON.stringify(listing) };
|
||||
const site = await deployment({ [listing[0]!.path]: big("a"), [listing[1]!.path]: big("b") }, env);
|
||||
assert.equal((await site.get("/api/v1?target=first")).status, 200);
|
||||
assert.deepEqual([...site.cache.keys()], [`${origin}${listing[0]!.path}`]);
|
||||
// Two 6 MB manifests are about 36 MB once parsed, over the 32 MB the isolate keeps.
|
||||
assert.equal((await site.get("/api/v1?target=second")).status, 200);
|
||||
assert.deepEqual([...site.cache.keys()], [`${origin}${listing[1]!.path}`]);
|
||||
});
|
||||
@@ -1,150 +1,110 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
import { webcrypto } from "node:crypto";
|
||||
import { PREVIEW_CIPHER, previewConfig, previewResponse, type PreviewEnvironment } from "../src/server/preview";
|
||||
import { previewConfig, previewResponse, type PreviewEnvironment } from "../src/server/preview";
|
||||
|
||||
const subtle = webcrypto.subtle as SubtleCrypto;
|
||||
const token = "abcdefghijklmnopqrstuvwxyz234567";
|
||||
const html = '<!doctype html><script type="module" src="/viewer/assets/main.js"></script>';
|
||||
const report: Uint8Array<ArrayBuffer> = new TextEncoder().encode("PK\u0003\u0004 a small report archive stand-in");
|
||||
|
||||
async function sealed(keyBytes: Uint8Array<ArrayBuffer>, plain: Uint8Array<ArrayBuffer> = report): Promise<Uint8Array<ArrayBuffer>> {
|
||||
const key = await subtle.importKey("raw", keyBytes, "AES-GCM", false, ["encrypt"]);
|
||||
const iv = webcrypto.getRandomValues(new Uint8Array(PREVIEW_CIPHER.ivBytes));
|
||||
const cipher = new Uint8Array(await subtle.encrypt({ name: "AES-GCM", iv, additionalData: new TextEncoder().encode(PREVIEW_CIPHER.aad) }, key, plain));
|
||||
const out = new Uint8Array(iv.byteLength + cipher.byteLength);
|
||||
out.set(iv); out.set(cipher, iv.byteLength);
|
||||
return out;
|
||||
}
|
||||
|
||||
const keyBytes: Uint8Array<ArrayBuffer> = webcrypto.getRandomValues(new Uint8Array(32));
|
||||
const env: PreviewEnvironment = {
|
||||
EXPLORE_PREVIEW_TOKEN: token,
|
||||
EXPLORE_PREVIEW_KEY: Buffer.from(keyBytes).toString("base64"),
|
||||
EXPLORE_PREVIEW_EXPIRES_AT: "2030-01-01T00:00:00Z",
|
||||
EXPLORE_PREVIEW_REPORT: "/_report/abcdefghijklmnop/report.zip.enc",
|
||||
};
|
||||
const env: PreviewEnvironment = { EXPLORE_PREVIEW_TOKEN: token, EXPLORE_PREVIEW_REPORT: `/p/${token}/targets/report.json` };
|
||||
const origin = "https://acme-explore--k7f3z0d1q8.expo.app";
|
||||
/** The manifest route streams the static file through unparsed, so a stand-in names the report it is. */
|
||||
const standIn = (name: string) => new TextEncoder().encode(`manifest of ${name}`);
|
||||
|
||||
test("after the sealed expiry the exact token still opens the Viewer and the report routes answer 410 with the instant; no expiry means never", async () => {
|
||||
const options = { env, indexHtml: html, fetchImpl: staticFiles({ [env.EXPLORE_PREVIEW_REPORT!]: await sealed(keyBytes) }), subtle };
|
||||
const before = { ...options, now: () => Date.parse("2029-12-31T23:59:59Z") };
|
||||
const after = { ...options, now: () => Date.parse("2030-01-01T00:00:00Z") };
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`), before)).status, 200);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip`), before)).status, 200);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`, { headers: { accept: "text/html" } }), after)).status, 200, "a browser still gets the shell, which explains the expiry");
|
||||
for (const path of ["", "/report.zip", "/reports.json", "/report.zip?platform=ios"]) {
|
||||
const response = await previewResponse(new Request(`${origin}/p/${token}${path}`), after);
|
||||
assert.equal(response.status, 410, path);
|
||||
assert.equal(response.headers.get("cache-control"), "private, no-store", path);
|
||||
assert.deepEqual(await response.json(), { error: "expired", expiredAt: "2030-01-01T00:00:00.000Z" }, path);
|
||||
}
|
||||
const wrongToken = token.replace(/a/, "b");
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${wrongToken}/report.zip`), after)).status, 404, "a wrong token never learns about the expiry");
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`, { method: "POST" }), after)).status, 404);
|
||||
const never = { ...after, env: { ...env, EXPLORE_PREVIEW_EXPIRES_AT: undefined } };
|
||||
assert.equal(previewConfig(never.env)?.expiresAt, null);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip`), never)).status, 200);
|
||||
});
|
||||
|
||||
function staticFiles(files: Record<string, Uint8Array<ArrayBuffer>>): typeof fetch {
|
||||
function staticFiles(files: Record<string, Uint8Array>): typeof fetch {
|
||||
const calls: string[] = [];
|
||||
const impl = (async (input: RequestInfo | URL) => {
|
||||
const url = new URL(typeof input === "string" ? input : input instanceof URL ? input.href : input.url);
|
||||
calls.push(url.href);
|
||||
const body = files[url.pathname];
|
||||
return body ? new Response(body, { headers: { "content-length": String(body.byteLength) } }) : new Response("missing", { status: 404 });
|
||||
return body ? new Response(body as BodyInit, { headers: { "content-length": String(body.byteLength) } }) : new Response("missing", { status: 404 });
|
||||
}) as typeof fetch;
|
||||
(impl as typeof fetch & { calls: string[] }).calls = calls;
|
||||
return impl;
|
||||
}
|
||||
const options = (environment: PreviewEnvironment, files: Record<string, Uint8Array>) =>
|
||||
({ env: environment, indexHtml: html, fetchImpl: staticFiles(files), cache: new Map(), loading: new Map() });
|
||||
|
||||
test("the sealed configuration is read strictly", () => {
|
||||
assert.ok(previewConfig(env));
|
||||
test("the configuration is read strictly, and a report's manifest must sit under the deployment's own token", () => {
|
||||
assert.deepEqual(previewConfig(env), { token, reports: [{ target: "ios", platform: "ios", path: env.EXPLORE_PREVIEW_REPORT }] });
|
||||
const otherToken = token.replace(/a/, "b");
|
||||
for (const broken of [
|
||||
{ EXPLORE_PREVIEW_TOKEN: "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567" }, { EXPLORE_PREVIEW_TOKEN: token.slice(1) }, { EXPLORE_PREVIEW_TOKEN: undefined },
|
||||
{ EXPLORE_PREVIEW_KEY: Buffer.alloc(16).toString("base64") }, { EXPLORE_PREVIEW_KEY: "not base64!" },
|
||||
{ EXPLORE_PREVIEW_EXPIRES_AT: "soon" }, { EXPLORE_PREVIEW_REPORT: "/report.zip.enc" }, { EXPLORE_PREVIEW_REPORT: "/_report/../x/report.zip.enc" },
|
||||
{ EXPLORE_PREVIEW_REPORT: "/report.json" }, { EXPLORE_PREVIEW_REPORT: `/p/${otherToken}/targets/report.json` },
|
||||
{ EXPLORE_PREVIEW_REPORT: `/p/${token}/targets/../report.json` }, { EXPLORE_PREVIEW_REPORT: `/p/${token}/targets/ios.json` },
|
||||
{ EXPLORE_PREVIEW_REPORT: "/_report/abcdefghijklmnop/report.zip.enc" },
|
||||
]) assert.equal(previewConfig({ ...env, ...broken }), undefined, JSON.stringify(broken));
|
||||
});
|
||||
|
||||
test("the token page serves the Viewer shell and the report route streams the decrypted report", async () => {
|
||||
const fetchImpl = staticFiles({ [env.EXPLORE_PREVIEW_REPORT!]: await sealed(keyBytes) });
|
||||
const page = await previewResponse(new Request(`${origin}/p/${token}?view=compare&screen=home#/map`), { env, indexHtml: html, fetchImpl, subtle });
|
||||
test("the token page serves the Viewer shell, and the manifest route answers the target's static manifest", async () => {
|
||||
const files = { [env.EXPLORE_PREVIEW_REPORT!]: standIn("report") };
|
||||
const page = await previewResponse(new Request(`${origin}/p/${token}?view=compare&screen=home#/map`), options(env, files));
|
||||
assert.equal(page.status, 200);
|
||||
// A stand-in is not a manifest the index can read, so the shell is the plain Viewer.
|
||||
assert.equal(await page.text(), html);
|
||||
assert.equal(page.headers.get("cache-control"), "private, no-store");
|
||||
assert.equal(page.headers.get("referrer-policy"), "no-referrer");
|
||||
assert.match(page.headers.get("content-security-policy") ?? "", /frame-ancestors 'none'/);
|
||||
const slash = await previewResponse(new Request(`${origin}/p/${token}/`), { env, indexHtml: html, fetchImpl, subtle });
|
||||
assert.equal(slash.status, 200);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/`), options(env, files))).status, 200);
|
||||
|
||||
const zip = await previewResponse(new Request(`${origin}/p/${token}/report.zip`), { env, indexHtml: html, fetchImpl, subtle });
|
||||
assert.equal(zip.status, 200);
|
||||
assert.equal(zip.headers.get("content-type"), "application/zip");
|
||||
assert.equal(zip.headers.get("content-length"), String(report.byteLength));
|
||||
assert.deepEqual(new Uint8Array(await zip.arrayBuffer()), report);
|
||||
// Only the sealed report file is ever fetched, whether for the shell's inline index or the zip route.
|
||||
const calls = (fetchImpl as typeof fetch & { calls: string[] }).calls;
|
||||
assert.ok(calls.length >= 1 && calls.every(call => call === `${origin}${env.EXPLORE_PREVIEW_REPORT}`), calls.join());
|
||||
const manifest = await previewResponse(new Request(`${origin}/p/${token}/manifest.json`), options(env, files));
|
||||
assert.equal(manifest.status, 200);
|
||||
assert.equal(manifest.headers.get("content-type"), "application/json; charset=utf-8");
|
||||
assert.equal(manifest.headers.get("cache-control"), "private, no-store");
|
||||
assert.equal(await manifest.text(), "manifest of report");
|
||||
});
|
||||
|
||||
test("everything else is the same 404: wrong token, other paths, other methods, bad ciphertext, missing file", async () => {
|
||||
const good = await sealed(keyBytes);
|
||||
const files = { [env.EXPLORE_PREVIEW_REPORT!]: good };
|
||||
const options = { env, indexHtml: html, fetchImpl: staticFiles(files), subtle };
|
||||
test("everything else is the same 404: wrong token, other paths, other methods, a missing manifest; a failing fetch is a 503", async () => {
|
||||
const files = { [env.EXPLORE_PREVIEW_REPORT!]: standIn("report") };
|
||||
const wrongToken = token.replace(/a/, "b");
|
||||
for (const path of [`/p/${wrongToken}`, `/p/${wrongToken}/report.zip`, `/p/${token.toUpperCase()}`, `/p/${token}/viewer/assets/main.js`,
|
||||
`/p/${token}/other.zip`, `/p/${token}/report.zip/`, `/p/${token}x`, "/p", "/p/", "/", "/_report/abcdefghijklmnop/report.zip.enc", `/P/${token}`]) {
|
||||
const response = await previewResponse(new Request(origin + path), options);
|
||||
for (const path of [`/p/${wrongToken}`, `/p/${wrongToken}/manifest.json`, `/p/${token.toUpperCase()}`, `/p/${token}/viewer/assets/main.js`,
|
||||
`/p/${token}/report.zip`, `/p/${token}/assets/${"0".repeat(64)}.png`, `/p/${token}/targets/report.json`, `/p/${token}/manifest.json/`,
|
||||
`/p/${token}x`, "/p", "/p/", "/", `/P/${token}`]) {
|
||||
const response = await previewResponse(new Request(origin + path), options(env, files));
|
||||
assert.equal(response.status, 404, path);
|
||||
assert.equal(await response.text(), "Not found", path);
|
||||
assert.equal(response.headers.get("cache-control"), "private, no-store", path);
|
||||
}
|
||||
for (const method of ["HEAD", "POST", "PUT", "DELETE", "OPTIONS"]) {
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`, { method }), options)).status, 404, method);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`, { method }), options(env, files))).status, 404, method);
|
||||
}
|
||||
|
||||
const otherKey: Uint8Array<ArrayBuffer> = webcrypto.getRandomValues(new Uint8Array(32));
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip`), { ...options, fetchImpl: staticFiles({ [env.EXPLORE_PREVIEW_REPORT!]: await sealed(otherKey) }) })).status, 404);
|
||||
const tampered = Uint8Array.from(good); tampered[tampered.length - 1] = (tampered[tampered.length - 1] ?? 0) ^ 1;
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip`), { ...options, fetchImpl: staticFiles({ [env.EXPLORE_PREVIEW_REPORT!]: tampered }) })).status, 404);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip`), { ...options, fetchImpl: staticFiles({}) })).status, 404);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip`), { ...options, env: { ...env, EXPLORE_PREVIEW_KEY: undefined } })).status, 404);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/manifest.json`), options(env, {}))).status, 404, "a deployment missing its manifest");
|
||||
const failing = { ...options(env, files), fetchImpl: (async () => new Response("upstream", { status: 502 })) as typeof fetch };
|
||||
const unavailable = await previewResponse(new Request(`${origin}/p/${token}/manifest.json`), failing);
|
||||
assert.equal(unavailable.status, 503);
|
||||
assert.equal(unavailable.headers.get("retry-after"), "1");
|
||||
const throwing = { ...options(env, files), fetchImpl: (async () => { throw new TypeError("network"); }) as typeof fetch };
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/manifest.json`), throwing)).status, 503);
|
||||
});
|
||||
|
||||
test("a multi-platform deployment serves reports.json, one report per platform, and rejects loose configuration", async () => {
|
||||
const android: Uint8Array<ArrayBuffer> = new TextEncoder().encode("PK\u0003\u0004 android report stand-in");
|
||||
test("a multi-platform deployment serves reports.json, one manifest per platform, and rejects loose configuration", async () => {
|
||||
const reports = [
|
||||
{ platform: "ios", path: "/_report/abcdefghijklmnop/ios.zip.enc", changes: 3, device: "iPhone 17 Pro 26.0" },
|
||||
{ platform: "android", path: "/_report/abcdefghijklmnop/android.zip.enc", changes: 0, device: "Pixel 7 15" },
|
||||
{ platform: "ios", path: `/p/${token}/targets/ios.json`, changes: 3, device: "iPhone 17 Pro 26.0" },
|
||||
{ platform: "android", path: `/p/${token}/targets/android.json`, changes: 0, device: "Pixel 7 15" },
|
||||
];
|
||||
const { EXPLORE_PREVIEW_REPORT: _single, ...rest } = env;
|
||||
const multi: PreviewEnvironment = { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify(reports) };
|
||||
const fetchImpl = staticFiles({ [reports[0]!.path]: await sealed(keyBytes), [reports[1]!.path]: await sealed(keyBytes, android) });
|
||||
const options = { env: multi, indexHtml: html, fetchImpl, subtle };
|
||||
const files = { [reports[0]!.path]: standIn("ios"), [reports[1]!.path]: standIn("android") };
|
||||
// A listing from before targets names each report by its platform, which is then its target.
|
||||
assert.deepEqual(previewConfig(multi)?.reports, reports.map(entry => ({ target: entry.platform, ...entry })));
|
||||
|
||||
const list = await previewResponse(new Request(`${origin}/p/${token}/reports.json`), options);
|
||||
const list = await previewResponse(new Request(`${origin}/p/${token}/reports.json`), options(multi, files));
|
||||
assert.equal(list.status, 200);
|
||||
assert.equal(list.headers.get("content-type"), "application/json; charset=utf-8");
|
||||
assert.equal(list.headers.get("cache-control"), "private, no-store");
|
||||
assert.deepEqual(await list.json(), [{ target: "ios", platform: "ios", changes: 3, device: "iPhone 17 Pro 26.0" }, { target: "android", platform: "android", changes: 0, device: "Pixel 7 15" }]);
|
||||
|
||||
const first = await previewResponse(new Request(`${origin}/p/${token}/report.zip`), options);
|
||||
assert.deepEqual(new Uint8Array(await first.arrayBuffer()), report);
|
||||
const ios = await previewResponse(new Request(`${origin}/p/${token}/report.zip?platform=ios`), options);
|
||||
assert.deepEqual(new Uint8Array(await ios.arrayBuffer()), report);
|
||||
const second = await previewResponse(new Request(`${origin}/p/${token}/report.zip?platform=android`), options);
|
||||
assert.deepEqual(new Uint8Array(await second.arrayBuffer()), android);
|
||||
for (const path of ["/report.zip?platform=web", "/report.zip?platform=ios&platform=android", "/reports.json/", "/report.zip?platform="]) {
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}${path}`), options)).status, 404, path);
|
||||
}
|
||||
const manifest = async (query: string) => {
|
||||
const response = await previewResponse(new Request(`${origin}/p/${token}/manifest.json${query}`), options(multi, files));
|
||||
return response.status === 200 ? await response.text() : response.status;
|
||||
};
|
||||
assert.equal(await manifest(""), "manifest of ios");
|
||||
assert.equal(await manifest("?platform=ios"), "manifest of ios");
|
||||
assert.equal(await manifest("?platform=android"), "manifest of android");
|
||||
for (const query of ["?platform=web", "?platform=ios&platform=android", "?platform="]) assert.equal(await manifest(query), 404, query);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/reports.json/`), options(multi, files))).status, 404);
|
||||
// Single-report deployments still answer reports.json (one iOS entry) and ignore an unknown platform.
|
||||
const single = { env, indexHtml: html, fetchImpl: staticFiles({ [env.EXPLORE_PREVIEW_REPORT!]: await sealed(keyBytes) }), subtle };
|
||||
const single = options(env, { [env.EXPLORE_PREVIEW_REPORT!]: standIn("report") });
|
||||
assert.deepEqual(await (await previewResponse(new Request(`${origin}/p/${token}/reports.json`), single)).json(), [{ target: "ios", platform: "ios" }]);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/report.zip?platform=android`), single)).status, 404);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}/manifest.json?platform=android`), single)).status, 404);
|
||||
|
||||
const loose: Array<[string, unknown]> = [
|
||||
["both variables", { ...multi, EXPLORE_PREVIEW_REPORT: env.EXPLORE_PREVIEW_REPORT }],
|
||||
@@ -153,34 +113,32 @@ test("a multi-platform deployment serves reports.json, one report per platform,
|
||||
["duplicate platform", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([reports[0], reports[0]]) }],
|
||||
["unknown platform", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ platform: "web", path: reports[0]!.path }]) }],
|
||||
["foreign path", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ platform: "ios", path: "https://example.invalid/x" }]) }],
|
||||
["another token's path", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ ...reports[0], path: `/p/${token.replace(/a/, "b")}/targets/ios.json` }]) }],
|
||||
["extra key", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ ...reports[0], url: "x" }]) }],
|
||||
["bad changes", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ ...reports[0], changes: -1 }]) }],
|
||||
["markup device", { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify([{ ...reports[0], device: "<b>x</b>" }]) }],
|
||||
];
|
||||
for (const [name, value] of loose) {
|
||||
assert.equal(previewConfig(value as PreviewEnvironment), undefined, name);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`), { ...options, env: value as PreviewEnvironment })).status, 404, name);
|
||||
assert.equal((await previewResponse(new Request(`${origin}/p/${token}`), options(value as PreviewEnvironment, files))).status, 404, name);
|
||||
}
|
||||
});
|
||||
|
||||
test("a deployment of several targets, three of them iOS, selects by ?target= and still by ?platform=", async () => {
|
||||
const targets = [
|
||||
{ target: "iphone", platform: "ios", label: "iPhone 17", path: "/_report/abcdefghijklmnop/iphone.zip.enc", changes: 1 },
|
||||
{ target: "duo-closed", platform: "ios", label: "iPhone Duo (closed)", path: "/_report/abcdefghijklmnop/duo-closed.zip.enc" },
|
||||
{ target: "duo-open", platform: "ios", label: "iPhone Duo (open)", path: "/_report/abcdefghijklmnop/duo-open.zip.enc", device: "iPhone Duo 26.0" },
|
||||
{ target: "android", platform: "android", label: "Android", path: "/_report/abcdefghijklmnop/android.zip.enc" },
|
||||
{ target: "iphone", platform: "ios", label: "iPhone 17", path: `/p/${token}/targets/iphone.json`, changes: 1 },
|
||||
{ target: "duo-closed", platform: "ios", label: "iPhone Duo (closed)", path: `/p/${token}/targets/duo-closed.json` },
|
||||
{ target: "duo-open", platform: "ios", label: "iPhone Duo (open)", path: `/p/${token}/targets/duo-open.json`, device: "iPhone Duo 26.0" },
|
||||
{ target: "android", platform: "android", label: "Android", path: `/p/${token}/targets/android.json` },
|
||||
];
|
||||
const bodies = targets.map(entry => new TextEncoder().encode(`PK\u0003\u0004 ${entry.target} report stand-in`));
|
||||
const { EXPLORE_PREVIEW_REPORT: _single, ...rest } = env;
|
||||
const multi: PreviewEnvironment = { ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify(targets) };
|
||||
const files: Record<string, Uint8Array<ArrayBuffer>> = {};
|
||||
for (const [index, entry] of targets.entries()) files[entry.path] = await sealed(keyBytes, bodies[index]!);
|
||||
const options = { env: multi, indexHtml: html, fetchImpl: staticFiles(files), subtle };
|
||||
const files = Object.fromEntries(targets.map(entry => [entry.path, standIn(entry.target)]));
|
||||
assert.deepEqual(previewConfig(multi)?.reports, targets);
|
||||
assert.deepEqual(await (await previewResponse(new Request(`${origin}/p/${token}/reports.json`), options)).json(), targets.map(({ path: _path, ...entry }) => entry));
|
||||
assert.deepEqual(await (await previewResponse(new Request(`${origin}/p/${token}/reports.json`), options(multi, files))).json(), targets.map(({ path: _path, ...entry }) => entry));
|
||||
const served = async (query: string) => {
|
||||
const response = await previewResponse(new Request(`${origin}/p/${token}/report.zip${query}`), options);
|
||||
return response.status === 200 ? new TextDecoder().decode(await response.arrayBuffer()).split(" ")[1] : response.status;
|
||||
const response = await previewResponse(new Request(`${origin}/p/${token}/manifest.json${query}`), options(multi, files));
|
||||
return response.status === 200 ? (await response.text()).replace("manifest of ", "") : response.status;
|
||||
};
|
||||
assert.equal(await served(""), "iphone", "the first listed");
|
||||
assert.equal(await served("?target=duo-open"), "duo-open");
|
||||
@@ -191,14 +149,14 @@ test("a deployment of several targets, three of them iOS, selects by ?target= an
|
||||
assert.equal(await served(query), 404, query);
|
||||
}
|
||||
|
||||
const eight = Array.from({ length: 8 }, (_, index) => ({ target: `t${index}`, platform: "ios", path: `/_report/abcdefghijklmnop/t${index}.zip.enc` }));
|
||||
const eight = Array.from({ length: 8 }, (_, index) => ({ target: `t${index}`, platform: "ios", path: `/p/${token}/targets/t${index}.json` }));
|
||||
assert.equal(previewConfig({ ...rest, EXPLORE_PREVIEW_REPORTS: JSON.stringify(eight) })?.reports.length, 8);
|
||||
const loose: Array<[string, unknown]> = [
|
||||
["nine targets", [...eight, { target: "t8", platform: "ios", path: "/_report/abcdefghijklmnop/t8.zip.enc" }]],
|
||||
["nine targets", [...eight, { target: "t8", platform: "ios", path: `/p/${token}/targets/t8.json` }]],
|
||||
["duplicate target", [targets[0], { ...targets[1], target: "iphone", path: targets[0]!.path }]],
|
||||
["invalid id", [{ ...targets[0], target: "iPhone", path: "/_report/abcdefghijklmnop/iPhone.zip.enc" }]],
|
||||
["reserved id", [{ ...targets[0], target: "report", path: "/_report/abcdefghijklmnop/report.zip.enc" }]],
|
||||
["install id", [{ ...targets[0], target: "install-x", path: "/_report/abcdefghijklmnop/install-x.zip.enc" }]],
|
||||
["invalid id", [{ ...targets[0], target: "iPhone", path: `/p/${token}/targets/iPhone.json` }]],
|
||||
["reserved id", [{ ...targets[0], target: "report", path: `/p/${token}/targets/report.json` }]],
|
||||
["install id", [{ ...targets[0], target: "install-x", path: `/p/${token}/targets/install-x.json` }]],
|
||||
["path of another target", [{ ...targets[0], path: targets[1]!.path }]],
|
||||
["null target", [{ ...targets[0], target: null }]],
|
||||
["markup label", [{ ...targets[0], label: "<b>x</b>" }]],
|
||||
|
||||
@@ -1,9 +1,9 @@
|
||||
import { appearanceLabel, appearanceOptions, appearanceScope, filterComparisonAppearance, filterMapAppearance, filterReviewAppearance, type Appearance } from "./utils/appearance";
|
||||
import { appearanceLabel, appearanceOptions, appearanceScope, filterComparisonAppearance, filterMapAppearance, filterReviewAppearance, rememberAppearance, rememberedAppearance, type Appearance } from "./utils/appearance";
|
||||
import { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState, useSyncExternalStore } from "react";
|
||||
import { createPortal, flushSync } from "react-dom";
|
||||
import { AlertCircle, RefreshCw } from "lucide-react";
|
||||
import { Toaster } from "sonner";
|
||||
import { isEmbeddedArtifactUrl, optionalStorage, releaseEmbeddedArtifactUrl, resolveEmbeddedArtifactUrl, viewerLocation } from "./utils/embedded-report";
|
||||
import { isEmbeddedArtifactUrl, leaseEmbeddedArtifactUrl, optionalStorage, viewerLocation } from "./utils/embedded-report";
|
||||
import { REPORT_SOURCE } from "./utils/report-source";
|
||||
import { CanvasToolbar } from "./components/canvas/toolbar";
|
||||
import { CanvasCameraControls } from "./components/canvas/camera-controls";
|
||||
@@ -11,7 +11,7 @@ import { CanvasVisibleFrameProvider } from "./components/canvas/visible-frame-pr
|
||||
import { AppLoading } from "./components/shared/app-loading";
|
||||
import { ReportLoadingShell } from "./components/shared/report-loading-shell";
|
||||
import { screenLabel } from "./utils/screen-path";
|
||||
import { AppPill, PLATFORM_NAMES } from "./components/panels/app-pill";
|
||||
import { AppPill, PLATFORM_NAMES, targetSwitch } from "./components/panels/app-pill";
|
||||
import { changedScreens, focusCounts as countFocusStatuses, isCapturedChange, type ChangedScreen } from "./utils/changed-screens";
|
||||
import { MapView } from "./components/views/semantic-map";
|
||||
import { RightPanel } from "./components/panels/right";
|
||||
@@ -287,7 +287,8 @@ export function App() {
|
||||
{...(droppable ? { onOpenFile: openFile } : {})}
|
||||
{...(droppable && source.status === "failed" ? { onRetry: retry } : {})} />;
|
||||
}
|
||||
return <ViewerApp />;
|
||||
// A hosted preview switches targets in place; the new report gets a fresh Viewer.
|
||||
return <ViewerApp key={source.reportKey} />;
|
||||
}
|
||||
|
||||
function ViewerApp() {
|
||||
@@ -304,8 +305,15 @@ function ViewerApp() {
|
||||
const routeRef = useRef(route);
|
||||
const contextRef = useRef(EMPTY_ROUTE_CONTEXT);
|
||||
const [mapProjectionFitKey, setMapProjectionFitKey] = useState(0);
|
||||
// A report captured in several appearances shows one at a time; the primary (first captured) is the default.
|
||||
const [appearanceChoice, setAppearanceChoice] = useState<Appearance | undefined>();
|
||||
// A report captured in several appearances shows one at a time: the one this tab chose for the review (so a target
|
||||
// switch keeps it) when this report has it, the primary (first captured) otherwise.
|
||||
const [appearanceChoice, setAppearanceChoice] = useState<Appearance | undefined>(rememberedAppearance);
|
||||
const chooseAppearance = useCallback((appearance: Appearance) => {
|
||||
rememberAppearance(appearance);
|
||||
setAppearanceChoice(appearance);
|
||||
}, []);
|
||||
// For the ⇧T shortcut, which steps to the next captured appearance; set once they are known.
|
||||
const appearanceRef = useRef<{ options: readonly Appearance[]; current: Appearance | undefined }>({ options: [], current: undefined });
|
||||
const [handoffOpen, setHandoffOpen] = useState(false);
|
||||
/** Whether this page can hand the report off (a hosted preview); the A key reads it. */
|
||||
const handoffAvailableRef = useRef(false);
|
||||
@@ -371,6 +379,10 @@ function ViewerApp() {
|
||||
const toggleTheme = useCallback(() => {
|
||||
setThemePreference(current => current === "system" ? "dark" : current === "dark" ? "light" : "system");
|
||||
}, []);
|
||||
// The T key flips what is on screen, dark to light and back; only the button returns to Auto.
|
||||
const flipTheme = useCallback(() => {
|
||||
setThemePreference(current => (current === "system" ? preferredSystemTheme : current) === "dark" ? "light" : "dark");
|
||||
}, [preferredSystemTheme]);
|
||||
|
||||
const load = useCallback(async (silent = false) => {
|
||||
void silent;
|
||||
@@ -994,6 +1006,14 @@ function ViewerApp() {
|
||||
if (matchesShortcut(event, SHORTCUTS.app.handoff)) {
|
||||
if (!handoffAvailableRef.current) return;
|
||||
setHandoffOpen(true);
|
||||
} else if (matchesShortcut(event, SHORTCUTS.appearance.theme)) {
|
||||
flipTheme();
|
||||
} else if (matchesShortcut(event, SHORTCUTS.appearance.app)) {
|
||||
// Only a report captured in both schemes has another appearance to show.
|
||||
const { options, current } = appearanceRef.current;
|
||||
if (options.length < 2) return;
|
||||
const index = current ? options.indexOf(current) : -1;
|
||||
chooseAppearance(options[(index + 1) % options.length]!);
|
||||
} else if (matchesShortcut(event, SHORTCUTS.app.changes)) {
|
||||
setChangesOpen((open) => !open);
|
||||
} else if (matchesShortcut(event, SHORTCUTS.panel.right)) {
|
||||
@@ -1009,7 +1029,7 @@ function ViewerApp() {
|
||||
return () => {
|
||||
window.removeEventListener("keydown", onKeyDown);
|
||||
};
|
||||
}, [clearSelectedScreen, navigate, searchOpen, selectCanvas, toggleRightPanel]);
|
||||
}, [chooseAppearance, clearSelectedScreen, flipTheme, navigate, searchOpen, selectCanvas, toggleRightPanel]);
|
||||
|
||||
// A side-panel row or a deep link is a "go to": the camera fits that screen and the step is
|
||||
// kept. Screens inventory clicks only select in place; Map clicks also focus the chosen screen. Repeating a selected target refits it without adding history.
|
||||
@@ -1102,6 +1122,7 @@ function ViewerApp() {
|
||||
const baseline = builds.find((build) => build.id === route.baseline);
|
||||
const appearances = useMemo(() => appearanceOptions(payload?.map), [payload]);
|
||||
const appearance = appearanceChoice && appearances.includes(appearanceChoice) ? appearanceChoice : appearances[0];
|
||||
appearanceRef.current = { options: appearances, current: appearance };
|
||||
const appearanceMap = useMemo(() => payload ? filterMapAppearance(payload.map, appearance) : undefined, [appearance, payload]);
|
||||
const currentMap = useMemo(() => (
|
||||
appearanceMap && workspace && currentBuild
|
||||
@@ -1183,6 +1204,8 @@ function ViewerApp() {
|
||||
? { ...presentedMap, run: { ...presentedMap.run, name: workspace.catalog.name } }
|
||||
: presentedMap
|
||||
), [presentedMap, workspace]);
|
||||
// The shortcuts list names the target keys only where the pill can switch.
|
||||
const switchTargets = map ? targetSwitch(map.run, new URL(window.location.href)) : undefined;
|
||||
// Focus singles out diff states, so it means nothing without a baseline to diff against.
|
||||
const focusFilter = diff ? route.focus : [];
|
||||
const focusCounts = useMemo(() => countFocusStatuses(diff), [diff]);
|
||||
@@ -1369,18 +1392,20 @@ function ViewerApp() {
|
||||
icon?.setAttribute("href", appIcon ?? fallback);
|
||||
return;
|
||||
}
|
||||
// A report ZIP's icon is a reference the browser cannot load: the tab holds its Blob URL while it shows.
|
||||
// A report ZIP's icon is a reference the browser cannot load: the tab holds its Blob URL while it shows. The lease
|
||||
// releases it against the report that resolved it, even after a switch to another target's report.
|
||||
let state: "pending" | "shown" | "gone" = "pending";
|
||||
resolveEmbeddedArtifactUrl(appIcon, "eager").then(
|
||||
const lease = leaseEmbeddedArtifactUrl(appIcon, "eager");
|
||||
lease.url.then(
|
||||
(url) => {
|
||||
if (state === "gone") return void releaseEmbeddedArtifactUrl(appIcon);
|
||||
if (state === "gone") return void lease.release();
|
||||
state = "shown";
|
||||
icon?.setAttribute("href", url);
|
||||
},
|
||||
() => icon?.setAttribute("href", fallback),
|
||||
() => { if (state !== "gone") icon?.setAttribute("href", fallback); },
|
||||
);
|
||||
return () => {
|
||||
if (state === "shown") releaseEmbeddedArtifactUrl(appIcon);
|
||||
if (state === "shown") lease.release();
|
||||
state = "gone";
|
||||
};
|
||||
}, [index, map, selectedScreenId]);
|
||||
@@ -1513,7 +1538,7 @@ function ViewerApp() {
|
||||
index={index}
|
||||
{...(selectedScreenId ? { selectedScreenId } : {})}
|
||||
{...(review?.pullRequest ? { pullRequest: review.pullRequest } : {})}
|
||||
{...(appearances.length > 1 && appearance ? { appearance: { current: appearance, options: appearances, onChange: setAppearanceChoice } } : {})}
|
||||
{...(appearances.length > 1 && appearance ? { appearance: { current: appearance, options: appearances, onChange: chooseAppearance } } : {})}
|
||||
focus={focusFilter}
|
||||
focusCounts={focusCounts}
|
||||
{...(diff ? { diff } : {})}
|
||||
@@ -1605,7 +1630,6 @@ function ViewerApp() {
|
||||
) : <CanvasToolbar
|
||||
canvas={route.canvas}
|
||||
searchOpen={searchOpen}
|
||||
compareCount={compareOrder.length}
|
||||
{...(handoffAction ? { actions: handoffAction } : {})}
|
||||
onOpenShortcuts={() => setShortcutsOpen(true)}
|
||||
onSelectCanvas={selectCanvas}
|
||||
@@ -1614,7 +1638,8 @@ function ViewerApp() {
|
||||
</CanvasVisibleFrameProvider>
|
||||
{shortcutsOpen ? (
|
||||
<ShortcutsDialog
|
||||
context={{ canvas: route.canvas, review: reviewingInSidebar, hasChanges: compareOrder.length > 0, handoff: Boolean(handoffInput) }}
|
||||
context={{ canvas: route.canvas, review: reviewingInSidebar, hasChanges: compareOrder.length > 0, handoff: Boolean(handoffInput), appearances: appearances.length > 1,
|
||||
...(switchTargets ? { targets: switchTargets } : {}) }}
|
||||
onClose={() => setShortcutsOpen(false)}
|
||||
/>
|
||||
) : null}
|
||||
|
||||
@@ -3,6 +3,7 @@ import { Fullscreen, LocateFixed } from "lucide-react";
|
||||
import { runCanvasZoomCommand } from "../../utils/canvas-zoom";
|
||||
import { useCanvasZoom } from "../../hooks/use-canvas-zoom";
|
||||
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
|
||||
import { KeyHint } from "../shared/key-hint";
|
||||
import { Menu, type MenuItem } from "../shared/menu";
|
||||
import { Tooltip } from "../shared/tooltip";
|
||||
import { FullscreenToggleButton, ThemeToggleButton, type ShellActionsProps, type ShellTheme } from "../panels/shell-actions";
|
||||
@@ -86,6 +87,7 @@ function FitControl() {
|
||||
disabled={!camera}
|
||||
onClick={() => runCanvasZoomCommand(camera?.hasSelection() ? "selection" : "fit")}>
|
||||
<Fullscreen aria-hidden="true" />
|
||||
<KeyHint shortcut={SHORTCUTS.camera.fit} />
|
||||
</button>
|
||||
</Tooltip>
|
||||
);
|
||||
@@ -105,6 +107,7 @@ function RecenterControl() {
|
||||
disabled={!camera}
|
||||
onClick={() => runCanvasZoomCommand("recenter")}>
|
||||
<LocateFixed aria-hidden="true" />
|
||||
<KeyHint shortcut={SHORTCUTS.camera.center} />
|
||||
</button>
|
||||
</Tooltip>
|
||||
);
|
||||
|
||||
@@ -2,6 +2,7 @@ import type { CSSProperties, MouseEventHandler, ReactNode } from "react";
|
||||
import { ImageOff, PanelRight } from "lucide-react";
|
||||
import { diffClass, type DiffStatus } from "../../utils/build-diff";
|
||||
import { ScreenPathText } from "../shared/screen-path-text";
|
||||
import { Tooltip } from "../shared/tooltip";
|
||||
import { DEFAULT_SCREENSHOT_SIZE, ScreenshotImage } from "../shared/screenshot-image";
|
||||
import { CanvasActiveFrame } from "./active-frame";
|
||||
import { DiffFrame } from "./diff-frame";
|
||||
@@ -30,6 +31,8 @@ export type ScreenScreenshotCardProps = {
|
||||
loading?: "eager" | "lazy";
|
||||
leading?: ReactNode;
|
||||
trailing?: ReactNode;
|
||||
/** Where the "Open in Inspector" tooltip sits: away from the route heading, which is above the screenshot on the Map. */
|
||||
tooltipPlacement?: "top" | "bottom";
|
||||
/** Short lines about the screen, inside the card after its screenshot (Screens: how it was reached, where else it changed). */
|
||||
note?: ReactNode;
|
||||
onClick: MouseEventHandler<HTMLButtonElement>;
|
||||
@@ -89,10 +92,13 @@ export function ScreenScreenshotCard(props: ScreenScreenshotCardProps) {
|
||||
free of block children. */}
|
||||
<span className="screen-screenshot-slot">
|
||||
{props.leading}
|
||||
{/* With a pointer, what a click does is said once, zoom-independent, in the shared tooltip
|
||||
after its usual delay; the selected screen is already in the Inspector. The button has
|
||||
no title of its own, so no native tooltip joins it; the heading names the screen. */}
|
||||
<Tooltip label="Open in Inspector" placement={props.tooltipPlacement ?? "top"} disabled={Boolean(props.selected)}>
|
||||
<button
|
||||
type="button"
|
||||
className="screen-screenshot-target"
|
||||
title={props.plainTitle ? props.title : props.path}
|
||||
aria-label={props.ariaLabel ?? `Open ${props.plainTitle ? props.title : props.path}`}
|
||||
{...(props.ariaPressed !== undefined ? { "aria-pressed": props.ariaPressed } : {})}
|
||||
onClick={props.onClick}>
|
||||
@@ -110,16 +116,15 @@ export function ScreenScreenshotCard(props: ScreenScreenshotCardProps) {
|
||||
fallback={missing}
|
||||
/>
|
||||
) : missing}
|
||||
{/* On hover, says what a click does; on a phone's map, what the second tap does.
|
||||
See styles.css for when each wording shows. */}
|
||||
{/* On a phone's map, says what the second tap on the selected screen does. */}
|
||||
<span className="screen-open-hint" aria-hidden="true">
|
||||
<PanelRight />
|
||||
<span className="screen-open-hint-long">Open in Inspector</span>
|
||||
<span className="screen-open-hint-short">Open</span>
|
||||
<span>Open</span>
|
||||
</span>
|
||||
</span>
|
||||
</DiffFrame>
|
||||
</button>
|
||||
</Tooltip>
|
||||
{props.trailing}
|
||||
</span>
|
||||
{props.note ? <span className="screen-node-note">{props.note}</span> : null}
|
||||
|
||||
@@ -2,7 +2,8 @@ import { GitCompareArrows, Keyboard, LayoutGrid, Map, Search } from "lucide-reac
|
||||
import { type CSSProperties } from "react";
|
||||
import { Tooltip } from "../shared/tooltip";
|
||||
import { useCanvasVisibleFrame } from "./visible-frame-provider";
|
||||
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
|
||||
import { CANVAS_NUMBER_KEYS, formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
|
||||
import { KeyHint } from "../shared/key-hint";
|
||||
import {
|
||||
CANVAS_DESCRIPTIONS,
|
||||
CANVAS_LABELS,
|
||||
@@ -21,9 +22,6 @@ const TOOLBAR_MINIMUM_FRAME_WIDTH = 220;
|
||||
type CanvasToolbarProps = {
|
||||
canvas: CanvasView;
|
||||
searchOpen: boolean;
|
||||
/** How many changed screens Compare holds, shown as a badge on its button. Compare's own header
|
||||
steps through them. */
|
||||
compareCount?: number;
|
||||
/** Page-wide actions beside Search (Hand off to AI). */
|
||||
actions?: React.ReactNode;
|
||||
onSelectCanvas: (canvas: CanvasView) => void;
|
||||
@@ -60,6 +58,7 @@ export function CanvasToolbar(props: CanvasToolbarProps) {
|
||||
aria-expanded={props.searchOpen}
|
||||
onClick={props.onOpenSearch}>
|
||||
<Search />
|
||||
<KeyHint shortcut={SHORTCUTS.app.search} />
|
||||
</button>
|
||||
</Tooltip>
|
||||
{props.actions}
|
||||
@@ -88,9 +87,7 @@ export function CanvasToolbar(props: CanvasToolbarProps) {
|
||||
onClick={() => props.onSelectCanvas(id)}>
|
||||
{VIEW_ICONS[id]}
|
||||
<span className="toolbar-view-label" aria-hidden="true"><span>{CANVAS_LABELS[id]}</span></span>
|
||||
{id === "compare" && props.compareCount ? (
|
||||
<span className="toolbar-badge" aria-hidden="true">{props.compareCount}</span>
|
||||
) : null}
|
||||
{CANVAS_NUMBER_KEYS ? <KeyHint shortcut={SHORTCUTS.canvasByNumber[id]} /> : null}
|
||||
</button>
|
||||
</Tooltip>
|
||||
);
|
||||
|
||||
@@ -3,6 +3,7 @@ import { useReactFlow, useStore } from "@xyflow/react";
|
||||
import { publishZoom, registerZoomApi, runCanvasZoomCommand } from "../../utils/canvas-zoom";
|
||||
import { isTyping, matchesShortcut, SHORTCUTS } from "../../utils/shortcuts";
|
||||
import { useCanvasVisibleFrame } from "./visible-frame-provider";
|
||||
import { createKeyHold, glideWhileHeld, type KeyHold } from "../../utils/key-hold";
|
||||
import {
|
||||
canvasBoundsViewport,
|
||||
canvasPriorityProjectionBounds,
|
||||
@@ -15,6 +16,8 @@ import {
|
||||
} from "./camera";
|
||||
|
||||
const DURATION = 160;
|
||||
/** React Flow's zoomIn/zoomOut step, which a tap of + or − takes. */
|
||||
const KEY_ZOOM_STEP = 1.2;
|
||||
const PIXEL_WHEEL_ZOOM_RATE = 0.002;
|
||||
const LINE_WHEEL_ZOOM_RATE = 0.05;
|
||||
const PAGE_WHEEL_ZOOM_RATE = 1;
|
||||
@@ -36,6 +39,12 @@ function canvasOwnsKeyboardEvent(event: KeyboardEvent, canvas: HTMLElement): boo
|
||||
return focusOwned || canvas.matches(":hover");
|
||||
}
|
||||
|
||||
function plainZoomDirection(event: KeyboardEvent): 1 | -1 | undefined {
|
||||
if (event.key === "+" || event.key === "=") return 1;
|
||||
if (event.key === "-" || event.key === "_") return -1;
|
||||
return undefined;
|
||||
}
|
||||
|
||||
function modifiedZoomCommand(event: KeyboardEvent): "in" | "out" | "100" | undefined {
|
||||
if (event.code === "Equal" || event.code === "NumpadAdd") return "in";
|
||||
if (event.code === "Minus" || event.code === "NumpadSubtract") return "out";
|
||||
@@ -60,6 +69,12 @@ export function ZoomBridge(props: {
|
||||
fitMaxZoom?: number;
|
||||
}) {
|
||||
const { visibleFrame } = useCanvasVisibleFrame();
|
||||
// Outlives the effect below, which re-runs as the camera moves: a held key must not end just
|
||||
// because its own zoom step re-registered the listeners.
|
||||
const holdRef = useRef<KeyHold>(undefined);
|
||||
holdRef.current ??= createKeyHold();
|
||||
const hold = holdRef.current;
|
||||
useEffect(() => () => hold.end(), [hold]);
|
||||
const {
|
||||
zoomIn,
|
||||
zoomOut,
|
||||
@@ -201,8 +216,37 @@ export function ZoomBridge(props: {
|
||||
};
|
||||
registerZoomApi(api);
|
||||
|
||||
// A tap of + or − takes one eased step. Held, the OS key repeat is ignored (each repeat
|
||||
// restarting the easing made holding slower than tapping); once the tap's step has landed the
|
||||
// camera glides instead, frame by frame about the pane's centre, as zoomIn does, until the key
|
||||
// is released, the hold is interrupted, or the zoom reaches its limit.
|
||||
const zoomStep = (direction: 1 | -1): boolean => {
|
||||
const viewport = getViewport();
|
||||
const next = Math.min(maxZoom, Math.max(minZoom, viewport.zoom * KEY_ZOOM_STEP ** direction));
|
||||
if (next === viewport.zoom) return false;
|
||||
if (direction === 1) void zoomIn({ duration: DURATION });
|
||||
else void zoomOut({ duration: DURATION });
|
||||
return true;
|
||||
};
|
||||
const zoomGlide = (direction: 1 | -1) => (steps: number): boolean => {
|
||||
const viewport = getViewport();
|
||||
const zoom = Math.min(maxZoom, Math.max(minZoom, viewport.zoom * KEY_ZOOM_STEP ** (direction * steps)));
|
||||
if (zoom === viewport.zoom) return false;
|
||||
const scale = zoom / viewport.zoom;
|
||||
const centerX = canvasWidth / 2;
|
||||
const centerY = canvasHeight / 2;
|
||||
void setViewport({ zoom, x: centerX - (centerX - viewport.x) * scale, y: centerY - (centerY - viewport.y) * scale });
|
||||
return true;
|
||||
};
|
||||
|
||||
const onKeyDown = (event: KeyboardEvent) => {
|
||||
hold.interrupt(event);
|
||||
// Typing comes first: a held key's repeats belong to a field that took focus mid-hold.
|
||||
if (isTyping(event.target)) return;
|
||||
if (event.repeat && hold.holding(event.code)) {
|
||||
event.preventDefault();
|
||||
return;
|
||||
}
|
||||
|
||||
// Browser zoom and canvas zoom use the same familiar chord. The pointer/focus boundary
|
||||
// decides who owns it: canvas-owned events reset its camera; a focused panel or field keeps
|
||||
@@ -225,10 +269,18 @@ export function ZoomBridge(props: {
|
||||
event.preventDefault();
|
||||
return;
|
||||
}
|
||||
if (event.key === "+" || event.key === "=") runCanvasZoomCommand("in");
|
||||
else if (event.key === "-" || event.key === "_") runCanvasZoomCommand("out");
|
||||
else return;
|
||||
const direction = plainZoomDirection(event);
|
||||
if (!direction) return;
|
||||
event.preventDefault();
|
||||
onCameraGestureStart.current?.();
|
||||
if (!zoomStep(direction)) return;
|
||||
// The hold only tracks the key (released, interrupted, a field or dialog taking over); the
|
||||
// glide reads it every frame and stops with it.
|
||||
hold.begin(event.code, () => true);
|
||||
glideWhileHeld(hold, event.code, DURATION, zoomGlide(direction));
|
||||
};
|
||||
const onKeyUp = (event: KeyboardEvent) => {
|
||||
if (hold.holding(event.code)) hold.end();
|
||||
};
|
||||
|
||||
const onModifierWheel = (event: WheelEvent) => {
|
||||
@@ -292,9 +344,13 @@ export function ZoomBridge(props: {
|
||||
};
|
||||
|
||||
window.addEventListener("keydown", onKeyDown);
|
||||
window.addEventListener("keyup", onKeyUp);
|
||||
window.addEventListener("blur", hold.end);
|
||||
canvas?.addEventListener("wheel", onModifierWheel, { capture: true, passive: false });
|
||||
return () => {
|
||||
window.removeEventListener("keydown", onKeyDown);
|
||||
window.removeEventListener("keyup", onKeyUp);
|
||||
window.removeEventListener("blur", hold.end);
|
||||
canvas?.removeEventListener("wheel", onModifierWheel, { capture: true });
|
||||
if (wheelFrame.current !== undefined) cancelAnimationFrame(wheelFrame.current);
|
||||
wheelFrame.current = undefined;
|
||||
@@ -308,6 +364,7 @@ export function ZoomBridge(props: {
|
||||
getNodes,
|
||||
getNodesBounds,
|
||||
getViewport,
|
||||
hold,
|
||||
maxZoom,
|
||||
minZoom,
|
||||
props.fitPadding,
|
||||
|
||||
@@ -5,6 +5,7 @@ import { StatusGlyph } from "../shared/status-icon";
|
||||
import { Tooltip } from "../shared/tooltip";
|
||||
import { DIFF_LABELS, type DiffStatus } from "../../utils/build-diff";
|
||||
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
|
||||
import { KeyHint } from "../shared/key-hint";
|
||||
import { setMeasurementsShown, useMeasurementsShown } from "../../utils/measurements-setting";
|
||||
|
||||
/** A screen whose every changed area only moved: how far, per direction, and whether no other finding remains. */
|
||||
@@ -48,6 +49,7 @@ export function CompareNav(props: {
|
||||
<StatusGlyph status={props.status} accessibilityOnly={props.accessibilityOnly} label={props.statusLabel ?? DIFF_LABELS[props.status]} />
|
||||
{/* A route that does not fit loses its start, not the end that names the screen. */}
|
||||
<code className="compare-nav-route" title={props.title}><bdi>{props.route}</bdi></code>
|
||||
<KeyHint shortcut={SHORTCUTS.app.changes} />
|
||||
</button>
|
||||
</Tooltip>
|
||||
{props.stepsApart ? null : <CompareSteps {...props} />}
|
||||
|
||||
@@ -6,7 +6,7 @@ import type { MapIndex } from "../../utils/model";
|
||||
import type { ChangedScreen } from "../../utils/changed-screens";
|
||||
import { groupVisualRegions, layoutShiftSummary, type VisualChange } from "../../utils/visual-diff";
|
||||
import { formatShortcut, matchesShortcut, SHORTCUTS, shortcutsLive } from "../../utils/shortcuts";
|
||||
import { HOLD_INITIAL_DELAY_MS, holdIntervalMs } from "../../utils/key-hold";
|
||||
import { createKeyHold, glideWhileHeld, HOLD_INITIAL_DELAY_MS, type KeyHold } from "../../utils/key-hold";
|
||||
import { optionalStorage } from "../../utils/embedded-report";
|
||||
import { usePhoneLayout } from "../../utils/phone-layout";
|
||||
import { ToggleGroup } from "../shared/toggle-group";
|
||||
@@ -160,11 +160,12 @@ export function useCompareController(options: CompareControllerOptions) {
|
||||
};
|
||||
const flip = () => setFlipSide((side) => (side === "after" ? "before" : "after"));
|
||||
|
||||
const keyState = useRef({ previous, next, mode, activeArea, options });
|
||||
keyState.current = { previous, next, mode, activeArea, options };
|
||||
const keyState = useRef({ previous, next, mode, activeArea, options, swipePosition });
|
||||
keyState.current = { previous, next, mode, activeArea, options, swipePosition };
|
||||
|
||||
// Stepping to the previous or next changed screen; a held key keeps stepping, accelerating, until
|
||||
// it is released, the window loses focus, or the list ends. Reads the latest neighbours on each step.
|
||||
// it is released, the window loses focus, or the end is reached. The Swipe divider is continuous,
|
||||
// so a tap of [ or ] nudges it one step and a held one glides. Both read the latest state.
|
||||
const stepScreen = (direction: 1 | -1): boolean => {
|
||||
const state = keyState.current;
|
||||
const target = direction === 1 ? state.next : state.previous;
|
||||
@@ -172,34 +173,38 @@ export function useCompareController(options: CompareControllerOptions) {
|
||||
state.options.onSelectScreen(target.id);
|
||||
return true;
|
||||
};
|
||||
const hold = useRef<{ code: string; timer: ReturnType<typeof setTimeout> } | undefined>(undefined);
|
||||
const endHold = () => {
|
||||
if (!hold.current) return;
|
||||
clearTimeout(hold.current.timer);
|
||||
hold.current = undefined;
|
||||
const moveDivider = (direction: 1 | -1, steps = 1): boolean => {
|
||||
const state = keyState.current;
|
||||
if (state.mode !== "swipe") return false;
|
||||
const position = Math.max(0, Math.min(100, state.swipePosition + direction * SWIPE_STEP * steps));
|
||||
if (position === state.swipePosition) return false;
|
||||
state.swipePosition = position;
|
||||
setSwipePosition(position);
|
||||
return true;
|
||||
};
|
||||
const beginHold = (code: string, direction: 1 | -1) => {
|
||||
endHold();
|
||||
let step = 1;
|
||||
const tick = () => {
|
||||
if (!stepScreen(direction)) { endHold(); return; }
|
||||
hold.current = { code, timer: setTimeout(tick, holdIntervalMs(step)) };
|
||||
step += 1;
|
||||
};
|
||||
hold.current = { code, timer: setTimeout(tick, HOLD_INITIAL_DELAY_MS) };
|
||||
const holdRef = useRef<KeyHold>(undefined);
|
||||
holdRef.current ??= createKeyHold();
|
||||
const hold = holdRef.current;
|
||||
useEffect(() => hold.end, [hold]);
|
||||
// The hold only tracks the key; the glide reads it every frame and stops with it.
|
||||
const glideDivider = (code: string, direction: 1 | -1) => {
|
||||
hold.begin(code, () => true);
|
||||
glideWhileHeld(hold, code, HOLD_INITIAL_DELAY_MS, (steps) => moveDivider(direction, steps));
|
||||
};
|
||||
useEffect(() => endHold, []);
|
||||
|
||||
useEffect(() => {
|
||||
const onKeyDown = (event: KeyboardEvent) => {
|
||||
hold.interrupt(event);
|
||||
// The browser's own repeat of the held key is not a step; it must not scroll either.
|
||||
if (event.repeat && hold.holding(event.code)) { event.preventDefault(); return; }
|
||||
if (event.defaultPrevented || !shortcutsLive(event)) return;
|
||||
const state = keyState.current;
|
||||
const keys = SHORTCUTS.compare;
|
||||
const stepScreens = state.options.stepScreens !== false;
|
||||
if (stepScreens && matchesShortcut(event, keys.previousScreen)) {
|
||||
if (stepScreen(-1)) beginHold(event.code, -1);
|
||||
if (stepScreen(-1)) hold.begin(event.code, () => stepScreen(-1));
|
||||
} else if (stepScreens && matchesShortcut(event, keys.nextScreen)) {
|
||||
if (stepScreen(1)) beginHold(event.code, 1);
|
||||
if (stepScreen(1)) hold.begin(event.code, () => stepScreen(1));
|
||||
} else if (matchesShortcut(event, keys.nextArea)) {
|
||||
stepArea(1);
|
||||
} else if (matchesShortcut(event, keys.previousArea)) {
|
||||
@@ -220,10 +225,10 @@ export function useCompareController(options: CompareControllerOptions) {
|
||||
flip();
|
||||
} else if (matchesShortcut(event, keys.dividerLeft)) {
|
||||
if (state.mode !== "swipe") return;
|
||||
setSwipePosition((value) => Math.max(0, value - SWIPE_STEP));
|
||||
if (moveDivider(-1)) glideDivider(event.code, -1);
|
||||
} else if (matchesShortcut(event, keys.dividerRight)) {
|
||||
if (state.mode !== "swipe") return;
|
||||
setSwipePosition((value) => Math.min(100, value + SWIPE_STEP));
|
||||
if (moveDivider(1)) glideDivider(event.code, 1);
|
||||
} else if (matchesShortcut(event, keys.outlines)) {
|
||||
toggleOutlines();
|
||||
} else if (matchesShortcut(event, keys.whatChanged)) {
|
||||
@@ -234,15 +239,15 @@ export function useCompareController(options: CompareControllerOptions) {
|
||||
event.preventDefault();
|
||||
};
|
||||
const onKeyUp = (event: KeyboardEvent) => {
|
||||
if (hold.current && event.code === hold.current.code) endHold();
|
||||
if (hold.holding(event.code)) hold.end();
|
||||
};
|
||||
window.addEventListener("keydown", onKeyDown);
|
||||
window.addEventListener("keyup", onKeyUp);
|
||||
window.addEventListener("blur", endHold);
|
||||
window.addEventListener("blur", hold.end);
|
||||
return () => {
|
||||
window.removeEventListener("keydown", onKeyDown);
|
||||
window.removeEventListener("keyup", onKeyUp);
|
||||
window.removeEventListener("blur", endHold);
|
||||
window.removeEventListener("blur", hold.end);
|
||||
};
|
||||
});
|
||||
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { useEffect } from "react";
|
||||
import { createPortal } from "react-dom";
|
||||
import { X } from "lucide-react";
|
||||
import { CANVAS_NUMBER_KEYS, formatShortcut, SHORTCUTS, type Shortcut } from "../../utils/shortcuts";
|
||||
import { CANVAS_NUMBER_KEYS, formatShortcut, SHORTCUTS, TARGET_NUMBER_KEYS, type Shortcut } from "../../utils/shortcuts";
|
||||
import type { CanvasView } from "../../utils/navigation";
|
||||
import { useModalDialog } from "../../hooks/use-modal-dialog";
|
||||
|
||||
@@ -17,8 +17,23 @@ export type ShortcutContext = {
|
||||
hasChanges: boolean;
|
||||
/** The report can be handed off to an agent (a hosted preview). */
|
||||
handoff?: boolean;
|
||||
/** The report was captured in both light and dark, so the app's appearance can be switched. */
|
||||
appearances?: boolean;
|
||||
/** The run's other targets are one switch away; the pill calls them devices, or platforms in reports from before targets. */
|
||||
targets?: { noun: "device" | "platform"; count: number };
|
||||
};
|
||||
|
||||
function targetRows(targets: NonNullable<ShortcutContext["targets"]>): Row[] {
|
||||
const numbers = SHORTCUTS.targetByNumber.slice(0, Math.min(targets.count, SHORTCUTS.targetByNumber.length));
|
||||
return [
|
||||
{ label: `Another ${targets.noun}'s report`, keys: [SHORTCUTS.target.menu] },
|
||||
...(TARGET_NUMBER_KEYS && numbers.length > 1
|
||||
? [{ label: `A ${targets.noun} by its place in that menu`, keys: [`${formatShortcut(numbers[0]!)}–${formatShortcut(numbers.at(-1)!)}`] }]
|
||||
: []),
|
||||
{ label: `Back to the last ${targets.noun}`, keys: [SHORTCUTS.target.last] },
|
||||
];
|
||||
}
|
||||
|
||||
const COMPARE = SHORTCUTS.compare;
|
||||
|
||||
function reviewGroup(context: ShortcutContext): Group {
|
||||
@@ -69,19 +84,22 @@ export function shortcutGroups(context: ShortcutContext): Group[][] {
|
||||
{ label: "Search screens", keys: [SHORTCUTS.app.search] },
|
||||
...(context.handoff ? [{ label: "Hand off to AI", keys: [SHORTCUTS.app.handoff] }] : []),
|
||||
...(context.hasChanges ? [{ label: "Changed screens menu", keys: [SHORTCUTS.app.changes] }] : []),
|
||||
...(context.targets ? targetRows(context.targets) : []),
|
||||
],
|
||||
};
|
||||
const view: Group = {
|
||||
title: "View",
|
||||
rows: [
|
||||
...(context.canvas === "compare" ? [] : [{ label: "Show or hide the inspector", keys: [SHORTCUTS.panel.right] }]),
|
||||
{ label: "Viewer theme: dark or light", keys: [SHORTCUTS.appearance.theme] },
|
||||
...(context.appearances ? [{ label: "The app's appearance: light or dark", keys: [SHORTCUTS.appearance.app] }] : []),
|
||||
{ label: "Show this list", keys: ["?"] },
|
||||
],
|
||||
};
|
||||
const mapGroup: Group = {
|
||||
title: "Map",
|
||||
rows: [
|
||||
{ label: "Walk the map from the selected screen", keys: ["↑", "↓", "←", "→", "H J K L"] },
|
||||
{ label: "Walk the map, or enter it at an edge", keys: ["↑", "↓", "←", "→", "H J K L"] },
|
||||
{ label: "Undo or redo moving a card", keys: [SHORTCUTS.edit.undo, SHORTCUTS.edit.redo] },
|
||||
{ label: "Close the inspector, then deselect", keys: ["Esc"] },
|
||||
],
|
||||
|
||||
@@ -6,9 +6,12 @@ import { Menu } from "../shared/menu";
|
||||
import { isPreviewPath, isReportTargetId, previewReportsUrl, targetQuery } from "../../utils/artifact-report";
|
||||
import { ScreenshotImage } from "../shared/screenshot-image";
|
||||
import { artifactUrl } from "../../utils/model";
|
||||
import { REPORT_SOURCE } from "../../utils/report-source";
|
||||
import { Tooltip } from "../shared/tooltip";
|
||||
import { KeyHint } from "../shared/key-hint";
|
||||
import { formatShortcut, matchesShortcut, shortcutsLive, SHORTCUTS, TARGET_NUMBER_KEYS } from "../../utils/shortcuts";
|
||||
import { ChangesMenu } from "./changes-menu";
|
||||
import type { FocusStatus } from "../../utils/navigation";
|
||||
import { placeForAnotherTarget, type FocusStatus } from "../../utils/navigation";
|
||||
import type { ExploreMap, MapIndex } from "../../utils/model";
|
||||
import type { BuildDiff } from "../../utils/build-diff";
|
||||
import type { PullRequestPresentation } from "../../utils/review-model";
|
||||
@@ -20,7 +23,10 @@ type SiblingReport = { target: string; changes?: number; device?: string };
|
||||
/** One report of the run, as the switch offers it. */
|
||||
export type SwitchTarget = { id: string; platform: string; label: string };
|
||||
|
||||
/** The same review's report for another target: this page's URL with the target swapped (and the artifact id dropped). */
|
||||
/**
|
||||
* The same review's report for another target: this page's URL with the target swapped (and the artifact id dropped),
|
||||
* open at the same place where the other report has it.
|
||||
*/
|
||||
export function siblingReportUrl(page: URL, target: string): string | undefined {
|
||||
const preview = isPreviewPath(page.pathname);
|
||||
if (!preview && page.searchParams.get("origin") === "local") return undefined;
|
||||
@@ -33,10 +39,27 @@ export function siblingReportUrl(page: URL, target: string): string | undefined
|
||||
url.searchParams.set(key, value);
|
||||
url.searchParams.delete("artifact");
|
||||
url.searchParams.delete("screen");
|
||||
url.hash = "";
|
||||
url.hash = placeForAnotherTarget(page.hash);
|
||||
return url.href;
|
||||
}
|
||||
|
||||
/**
|
||||
* The target this tab showed before the current one, for `. Kept in session storage, since a report page that is not a
|
||||
* hosted preview loads again to switch; a Back or Forward between targets counts as a switch too.
|
||||
*/
|
||||
function useLastTarget(current: string): string | undefined {
|
||||
const [last, setLast] = useState<string>();
|
||||
useEffect(() => {
|
||||
const key = `explore.targets:${window.location.pathname}:${new URLSearchParams(window.location.search).get("run") ?? ""}`;
|
||||
let stored: { shown?: unknown; last?: unknown } = {};
|
||||
try { stored = JSON.parse(window.sessionStorage.getItem(key) ?? "{}") as typeof stored; } catch { /* Optional storage. */ }
|
||||
const previous = [stored.shown, stored.last].find((id): id is string => isReportTargetId(id) && id !== current);
|
||||
try { window.sessionStorage.setItem(key, JSON.stringify({ shown: current, ...(previous ? { last: previous } : {}) })); } catch { /* Optional storage. */ }
|
||||
setLast(previous);
|
||||
}, [current]);
|
||||
return last;
|
||||
}
|
||||
|
||||
/**
|
||||
* Every report of this report's run, in config order, and which one this is: `run.targets` with their labels, or for
|
||||
* reports from before targets one per platform of `run.platforms` (iOS first, as they list it). One report: none.
|
||||
@@ -51,6 +74,13 @@ export function runTargets(run: ExploreMap["run"]): { current: string; targets:
|
||||
return { current, targets: platforms.length > 1 ? platforms.map(platform => ({ id: platform, platform, label: PLATFORM_NAMES[platform]! })) : [] };
|
||||
}
|
||||
|
||||
/** What the shortcuts list says about switching: nothing when this page cannot open another target's report. */
|
||||
export function targetSwitch(run: ExploreMap["run"], page: URL): { noun: "device" | "platform"; count: number } | undefined {
|
||||
const { current, targets } = runTargets(run);
|
||||
if (!targets.some(target => target.id !== current && siblingReportUrl(page, target.id))) return undefined;
|
||||
return { noun: targets.every(target => target.id === target.platform) ? "platform" : "device", count: targets.length };
|
||||
}
|
||||
|
||||
/** On a hosted preview, the deployment lists what it serves per target; elsewhere only the targets' names are known. */
|
||||
function useSiblingReports(page: URL | undefined): SiblingReport[] | undefined {
|
||||
const [reports, setReports] = useState<SiblingReport[]>();
|
||||
@@ -143,19 +173,62 @@ export function AppPill(props: AppPillProps) {
|
||||
.filter(target => target.id !== run.current)
|
||||
.map(target => ({ target, url: page ? siblingReportUrl(page, target.id) : undefined, report: siblingReports?.find(report => report.target === target.id) }))
|
||||
.filter((entry): entry is { target: SwitchTarget; url: string; report: SiblingReport | undefined } => Boolean(entry.url));
|
||||
// The URL is read when the switch happens, so the other report opens where the reader is now.
|
||||
const openTarget = (id: string) => {
|
||||
setPlatformOpen(false);
|
||||
const url = siblingReportUrl(new URL(window.location.href), id);
|
||||
if (url && !REPORT_SOURCE.switchTarget(id, url)) window.location.assign(url);
|
||||
};
|
||||
// ⌥1–⌥8 follow the menu's order, the run's config order.
|
||||
const numberHint = (target: SwitchTarget) => {
|
||||
const shortcut = TARGET_NUMBER_KEYS ? SHORTCUTS.targetByNumber[run.targets.indexOf(target)] : undefined;
|
||||
return shortcut ? { shortcut: formatShortcut(shortcut) } : {};
|
||||
};
|
||||
const platformItems = siblings.length ? run.targets.flatMap(target => {
|
||||
if (target.id === run.current) return [{ kind: "item" as const, label: target.label, description: device || undefined, checked: true, onSelect: () => setPlatformOpen(false) }];
|
||||
if (target.id === run.current) return [{ kind: "item" as const, label: target.label, description: device || undefined, checked: true, ...numberHint(target), onSelect: () => setPlatformOpen(false) }];
|
||||
const sibling = siblings.find(entry => entry.target.id === target.id);
|
||||
return sibling ? [{
|
||||
kind: "item" as const, label: target.label,
|
||||
description: [sibling.report?.changes === undefined ? undefined : `${sibling.report.changes} ${sibling.report.changes === 1 ? "change" : "changes"}`, sibling.report?.device]
|
||||
.filter(Boolean).join(" · ") || (target.platform === platform ? "Same review, other device" : "Same review, other platform"),
|
||||
checked: false, onSelect: () => { setPlatformOpen(false); window.location.assign(sibling.url); },
|
||||
checked: false, ...numberHint(target), onSelect: () => openTarget(target.id),
|
||||
}] : [];
|
||||
}) : [];
|
||||
// A report whose target is not among the run's (a hand-edited one) still lists itself first, checked.
|
||||
if (siblings.length && !currentTarget) platformItems.unshift({ kind: "item" as const, label: targetLabel, description: device || undefined, checked: true, onSelect: () => setPlatformOpen(false) });
|
||||
|
||||
// D opens the menu, ⌥1–⌥8 open a target by its place in it, and ` returns to the last target shown (the next one in
|
||||
// the menu's order before there is one). The handler reads the current targets from a ref.
|
||||
const last = useLastTarget(run.current);
|
||||
const targetKeys = { siblings: siblings.map(entry => entry.target.id), order: run.targets.map(target => target.id), current: run.current, last, openTarget };
|
||||
const targetKeysRef = useRef(targetKeys);
|
||||
targetKeysRef.current = targetKeys;
|
||||
useEffect(() => {
|
||||
const onKeyDown = (event: KeyboardEvent) => {
|
||||
const { siblings, order, current, last, openTarget } = targetKeysRef.current;
|
||||
if (!siblings.length || !shortcutsLive(event)) return;
|
||||
if (matchesShortcut(event, SHORTCUTS.target.menu)) {
|
||||
event.preventDefault();
|
||||
setPlatformOpen(open => !open);
|
||||
return;
|
||||
}
|
||||
let id: string | undefined;
|
||||
if (matchesShortcut(event, SHORTCUTS.target.last)) {
|
||||
const start = order.indexOf(current);
|
||||
id = last && siblings.includes(last) ? last
|
||||
: order.map((_, step) => order[(start + 1 + step) % order.length]!).find(candidate => siblings.includes(candidate));
|
||||
} else if (TARGET_NUMBER_KEYS) {
|
||||
const place = SHORTCUTS.targetByNumber.findIndex(shortcut => matchesShortcut(event, shortcut));
|
||||
if (place === -1) return;
|
||||
id = order[place];
|
||||
} else return;
|
||||
event.preventDefault();
|
||||
if (id && siblings.includes(id)) openTarget(id);
|
||||
};
|
||||
window.addEventListener("keydown", onKeyDown);
|
||||
return () => window.removeEventListener("keydown", onKeyDown);
|
||||
}, []);
|
||||
|
||||
return (
|
||||
<div className="left-panel collapsed">
|
||||
<div ref={pillRef} className="left-panel-collapsed-pill">
|
||||
@@ -179,7 +252,7 @@ export function AppPill(props: AppPillProps) {
|
||||
</strong>
|
||||
{siblings.length ? (
|
||||
<>
|
||||
<Tooltip label={`${device || targetLabel} · open another ${noun}'s report`} placement="bottom">
|
||||
<Tooltip label={`${device || targetLabel} · open another ${noun}'s report`} shortcut={formatShortcut(SHORTCUTS.target.menu)} placement="bottom">
|
||||
<button ref={platformRef} type="button" className="collapsed-platform" aria-haspopup="menu" aria-expanded={platformOpen}
|
||||
aria-label={`${noun === "device" ? "Device" : "Platform"}: ${targetLabel}. Open another ${noun}'s report`}
|
||||
onClick={() => setPlatformOpen(open => !open)}>
|
||||
@@ -192,12 +265,13 @@ export function AppPill(props: AppPillProps) {
|
||||
) : null}
|
||||
{props.appearance ? (
|
||||
<>
|
||||
<Tooltip label="Appearance · the same screens captured in the other scheme" placement="bottom">
|
||||
<Tooltip label="Appearance · the same screens captured in the other scheme" shortcut={formatShortcut(SHORTCUTS.appearance.app)} placement="bottom">
|
||||
<button ref={appearanceRef} type="button" className="collapsed-platform" aria-haspopup="menu" aria-expanded={appearanceOpen}
|
||||
aria-label={`Appearance: ${appearanceLabel(props.appearance.current)}. Show the other appearance`}
|
||||
onClick={() => setAppearanceOpen(open => !open)}>
|
||||
{appearanceLabel(props.appearance.current)}
|
||||
<svg aria-hidden="true" width="8" height="8" viewBox="0 0 8 8"><path d="M1 2.5 4 5.5 7 2.5" fill="none" stroke="currentColor" strokeWidth="1.5" strokeLinecap="round" strokeLinejoin="round" /></svg>
|
||||
<KeyHint shortcut={SHORTCUTS.appearance.app} />
|
||||
</button>
|
||||
</Tooltip>
|
||||
<Menu items={appearanceItems} open={appearanceOpen} anchorRef={appearanceRef} ariaLabel="Appearance" onDismiss={() => setAppearanceOpen(false)} />
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import { useEffect, useState } from "react";
|
||||
import { Maximize, Minimize, Moon, Sun, SunMoon } from "lucide-react";
|
||||
import { Tooltip } from "../shared/tooltip";
|
||||
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
|
||||
import type { ThemePreference } from "../../utils/navigation";
|
||||
|
||||
export type ShellTheme = "light" | "dark";
|
||||
@@ -51,7 +52,7 @@ const THEME_LABELS: Record<ThemePreference, string> = {
|
||||
export function ThemeToggleButton(props: ShellActionsProps) {
|
||||
const Icon = props.themePreference === "system" ? SunMoon : props.themePreference === "dark" ? Moon : Sun;
|
||||
return (
|
||||
<Tooltip label={THEME_LABELS[props.themePreference]} placement="bottom">
|
||||
<Tooltip label={THEME_LABELS[props.themePreference]} shortcut={formatShortcut(SHORTCUTS.appearance.theme)} placement="bottom">
|
||||
<button
|
||||
type="button"
|
||||
className={props.className ?? "icon-button"}
|
||||
|
||||
@@ -0,0 +1,14 @@
|
||||
import { heldKeyHint, useHeldModifiers } from "../../utils/held-modifiers";
|
||||
import type { Shortcut } from "../../utils/shortcuts";
|
||||
|
||||
/**
|
||||
* The key that completes a chord, shown on a button's corner while the chord's modifiers are
|
||||
* held. Hold ⌃ and the toolbar's sections show 1, 2 and 3; release it and they are gone.
|
||||
* Nothing renders for a plain key or while nothing is held.
|
||||
*/
|
||||
export function KeyHint({ shortcut }: { shortcut: Shortcut }) {
|
||||
const held = useHeldModifiers();
|
||||
const key = heldKeyHint(shortcut, held);
|
||||
if (!key) return null;
|
||||
return <kbd className="key-hint" aria-hidden="true">{key}</kbd>;
|
||||
}
|
||||
@@ -162,7 +162,18 @@ export function Tooltip({
|
||||
if (bubbleRef.current) observer.observe(bubbleRef.current);
|
||||
window.addEventListener("resize", update);
|
||||
window.addEventListener("scroll", update, true);
|
||||
// A canvas pans and zooms its cards by transform, which neither observer reports: while open,
|
||||
// follow the anchor frame by frame so the bubble never stays behind over what it labels.
|
||||
let followed = "";
|
||||
let frame = requestAnimationFrame(function follow() {
|
||||
const anchor = anchorRef.current?.getBoundingClientRect();
|
||||
const key = anchor ? `${anchor.left} ${anchor.top} ${anchor.width} ${anchor.height}` : "";
|
||||
if (followed && key !== followed) update();
|
||||
followed = key;
|
||||
frame = requestAnimationFrame(follow);
|
||||
});
|
||||
return () => {
|
||||
cancelAnimationFrame(frame);
|
||||
observer.disconnect();
|
||||
window.removeEventListener("resize", update);
|
||||
window.removeEventListener("scroll", update, true);
|
||||
|
||||
@@ -9,7 +9,7 @@ import { screenTree, treeIndex, treeNodeKey, treeScreenOrder, type ScreenTree, t
|
||||
import type { Appearance } from "../../utils/appearance";
|
||||
import type { FocusRequest, FocusStatus } from "../../utils/navigation";
|
||||
import { shortcutsLive } from "../../utils/shortcuts";
|
||||
import { HOLD_INITIAL_DELAY_MS, holdIntervalMs } from "../../utils/key-hold";
|
||||
import { createKeyHold } from "../../utils/key-hold";
|
||||
import { placeholderScreen } from "../../utils/map-frame";
|
||||
import { ScreenScreenshotCard } from "../canvas/screen-screenshot-card";
|
||||
import { useCanvasVisibleFrame } from "../canvas/visible-frame-provider";
|
||||
@@ -393,28 +393,23 @@ export function ScreensView(props: ScreensViewProps) {
|
||||
pickRef.current(id);
|
||||
requestAnimationFrame(() => document.getElementById(cardId(id))?.querySelector<HTMLElement>(".screen-screenshot-target")?.focus({ preventScroll: true }));
|
||||
};
|
||||
let hold: { code: string; at: string; timer: ReturnType<typeof setTimeout> } | undefined;
|
||||
const endHold = () => {
|
||||
if (hold) clearTimeout(hold.timer);
|
||||
hold = undefined;
|
||||
};
|
||||
// A held arrow keeps stepping from the card the last step landed on, not the lagging pick.
|
||||
const hold = createKeyHold();
|
||||
const beginHold = (code: string, at: string) => {
|
||||
endHold();
|
||||
let step = 1;
|
||||
const tick = () => {
|
||||
const id = hold && next(code, hold.at);
|
||||
if (!hold || !id) { endHold(); return; }
|
||||
hold.begin(code, () => {
|
||||
const id = next(code, at);
|
||||
if (!id) return false;
|
||||
at = id;
|
||||
go(id);
|
||||
hold = { code, at: id, timer: setTimeout(tick, holdIntervalMs(step)) };
|
||||
step += 1;
|
||||
};
|
||||
hold = { code, at, timer: setTimeout(tick, HOLD_INITIAL_DELAY_MS) };
|
||||
return true;
|
||||
});
|
||||
};
|
||||
const onKeyDown = (event: globalThis.KeyboardEvent) => {
|
||||
hold.interrupt(event);
|
||||
const arrow = ["ArrowLeft", "ArrowRight", "ArrowUp", "ArrowDown"].includes(event.code);
|
||||
if (!arrow && event.key !== "Enter") return;
|
||||
// The browser's own repeat of a held arrow would scroll the page under the hold.
|
||||
if (event.repeat && hold?.code === event.code) { event.preventDefault(); return; }
|
||||
if (event.repeat && hold.holding(event.code)) { event.preventDefault(); return; }
|
||||
if (event.metaKey || event.ctrlKey || event.altKey || event.shiftKey || event.defaultPrevented || !shortcutsLive(event)) return;
|
||||
const target = event.target instanceof Element ? event.target : null;
|
||||
if (!arrow) {
|
||||
@@ -436,8 +431,9 @@ export function ScreensView(props: ScreensViewProps) {
|
||||
beginHold(event.code, id);
|
||||
};
|
||||
const onKeyUp = (event: globalThis.KeyboardEvent) => {
|
||||
if (hold && event.code === hold.code) endHold();
|
||||
if (hold.holding(event.code)) hold.end();
|
||||
};
|
||||
const endHold = hold.end;
|
||||
window.addEventListener("keydown", onKeyDown);
|
||||
window.addEventListener("keyup", onKeyUp);
|
||||
window.addEventListener("blur", endHold);
|
||||
|
||||
@@ -27,7 +27,8 @@ import type { FocusBehavior, FocusRequest, FocusStatus, MapDirection } from "../
|
||||
import { focusStatusOf } from "../../utils/changed-screens";
|
||||
import { displayPathForScreen } from "../../utils/screen-path";
|
||||
import { shortcutsLive } from "../../utils/shortcuts";
|
||||
import { mapKeyDirection, mapKeyTarget } from "../../utils/map-keyboard";
|
||||
import { arrowsOwnedBy, mapKeyDirection, mapKeyEntry, mapKeyTarget, type MapKeyDirection } from "../../utils/map-keyboard";
|
||||
import { createKeyHold } from "../../utils/key-hold";
|
||||
|
||||
const HOVER_CLEAR_DELAY = 180;
|
||||
const MAP_LAYOUT_REVISION = "flat-v1";
|
||||
@@ -114,6 +115,8 @@ function ScreenNodeCard({ data, selected }: NodeProps<ScreenGraphNode>) {
|
||||
imageHeight={data.screenshotSize?.imageHeight ?? data.frame.screen.height}
|
||||
placeholderSize={data.frame.screen}
|
||||
loading="lazy"
|
||||
// The route heads the card, so the tooltip goes below it.
|
||||
tooltipPlacement="bottom"
|
||||
leading={<Handle type="target" position={horizontal ? Position.Left : Position.Top} className="graph-handle" />}
|
||||
trailing={<Handle type="source" position={horizontal ? Position.Right : Position.Bottom} className="graph-handle" />}
|
||||
onMouseEnter={() => data.onHover(data.screen.id)}
|
||||
@@ -552,24 +555,51 @@ function ConnectionCanvas(props: MapViewProps) {
|
||||
if (hoverClearTimer.current !== undefined) window.clearTimeout(hoverClearTimer.current);
|
||||
applyHover(undefined);
|
||||
}, [applyHover]);
|
||||
// With a screen selected, the arrow keys (or h j k l) walk the map: along an edge in the
|
||||
// layout's flow, across to the neighbour on the same rank otherwise.
|
||||
// The arrow keys (or h j k l) walk the map from the selected screen: along an edge in the
|
||||
// layout's flow, across to the neighbour on the same rank otherwise. With nothing selected they
|
||||
// enter the map at its edge, as on the Screens page. A held key keeps walking.
|
||||
const { selectedScreenId } = props;
|
||||
const selectedRef = useRef(selectedScreenId);
|
||||
selectedRef.current = selectedScreenId;
|
||||
useEffect(() => {
|
||||
if (!selectedScreenId) return;
|
||||
const hold = createKeyHold();
|
||||
const move = (direction: MapKeyDirection, from: string | undefined): string | undefined => {
|
||||
const structure = structureRef.current;
|
||||
if (!structure) return undefined;
|
||||
return from ? mapKeyTarget(structure, from, direction) : mapKeyEntry(structure, direction);
|
||||
};
|
||||
const onKeyDown = (event: KeyboardEvent) => {
|
||||
if (event.defaultPrevented || !shortcutsLive(event)) return;
|
||||
hold.interrupt(event);
|
||||
if (event.repeat && hold.holding(event.code)) { event.preventDefault(); return; }
|
||||
if (event.defaultPrevented || !shortcutsLive(event) || arrowsOwnedBy(event.target)) return;
|
||||
const direction = mapKeyDirection(event);
|
||||
if (!direction) return;
|
||||
const structure = structureRef.current;
|
||||
if (!structure) return;
|
||||
if (!structureRef.current) return;
|
||||
event.preventDefault();
|
||||
const target = mapKeyTarget(structure, selectedScreenId, direction);
|
||||
if (target) selectScreen(target);
|
||||
let at = move(direction, selectedRef.current);
|
||||
if (!at) return;
|
||||
selectScreen(at);
|
||||
hold.begin(event.code, () => {
|
||||
const target = move(direction, at);
|
||||
if (!target) return false;
|
||||
at = target;
|
||||
selectScreen(target);
|
||||
return true;
|
||||
});
|
||||
};
|
||||
const onKeyUp = (event: KeyboardEvent) => {
|
||||
if (hold.holding(event.code)) hold.end();
|
||||
};
|
||||
window.addEventListener("keydown", onKeyDown);
|
||||
return () => window.removeEventListener("keydown", onKeyDown);
|
||||
}, [selectScreen, selectedScreenId]);
|
||||
window.addEventListener("keyup", onKeyUp);
|
||||
window.addEventListener("blur", hold.end);
|
||||
return () => {
|
||||
hold.end();
|
||||
window.removeEventListener("keydown", onKeyDown);
|
||||
window.removeEventListener("keyup", onKeyUp);
|
||||
window.removeEventListener("blur", hold.end);
|
||||
};
|
||||
}, [selectScreen]);
|
||||
|
||||
const onViewportChange = useCallback((event: CanvasViewportChangeEvent) => {
|
||||
viewportChangeHandler.current?.(event);
|
||||
|
||||
@@ -110,7 +110,7 @@
|
||||
/* How far an item the Changes filter does not cover falls back. Low enough to read as
|
||||
background at a glance, high enough that the canvas keeps its shape. */
|
||||
--dim-out: 0.35;
|
||||
--hover-recede: 0.6;
|
||||
--hover-neighbour-frame: color-mix(in srgb, var(--accent) 55%, var(--border-subtle));
|
||||
--shadow-xs: 0 1px 3px rgba(0, 0, 0, 0.025), 0 1px 2px rgba(0, 0, 0, 0.05);
|
||||
--shadow-md: 0 10px 20px rgba(0, 0, 0, 0.1), 0 3px 6px rgba(0, 0, 0, 0.05);
|
||||
|
||||
@@ -517,13 +517,14 @@ code {
|
||||
opacity: 1;
|
||||
--map-card-opacity: 1;
|
||||
}
|
||||
/* Hover isolates the subject and its directly incident transitions. These selectors come after
|
||||
diff focus so the pointer's immediate context is always the strongest signal. */
|
||||
.graph-canvas .react-flow__node.graph-node-hover-related {
|
||||
/* Hover never recedes anything, but where focus or a selection has already dimmed the map, the
|
||||
hovered screen and the screens it connects to come back up, with the transitions between them,
|
||||
so the neighbourhood reads. These come after both dimming rules so the pointer's context wins. */
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__node-screen.graph-node-hover-related {
|
||||
opacity: 1;
|
||||
--map-card-opacity: 1;
|
||||
filter: none;
|
||||
}
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__edge.graph-edge-hover-related { opacity: 1; }
|
||||
/* Re-layout: the canvas blinks out whole — nodes, edges and labels together — so the graph can
|
||||
change shape and the camera can cut unseen, then comes straight back. Both transitions live
|
||||
inside their class, so once the sequence ends the stylesheet owns opacity again. */
|
||||
@@ -555,6 +556,10 @@ code {
|
||||
/* The screenshot's positioned diff frame paints after the leading handle in tree order; lift
|
||||
both handles over the image while the diff label (z-index 2) still covers them. */
|
||||
.screen-screenshot-slot > .react-flow__handle { z-index: 1; }
|
||||
/* The tooltip anchor around the screenshot button is layout-transparent: it takes the slot's
|
||||
remaining height and hands it on, and stays static so the diff label and the handles keep
|
||||
anchoring to the slot (or, on Screens, the card). */
|
||||
.screen-screenshot-slot > .tooltip-anchor { position: static; display: flex; width: 100%; min-height: 0; flex: 1; flex-direction: column; }
|
||||
.screen-screenshot-target {
|
||||
display: flex;
|
||||
width: 100%;
|
||||
@@ -733,27 +738,23 @@ code {
|
||||
opacity: 1;
|
||||
}
|
||||
|
||||
/* Hover is transient canvas state. One container class dims the field; only the symmetric
|
||||
difference of related nodes/edges receives a class, avoiding a React commit across the graph.
|
||||
The hovered screen and the screens it connects to stay as they are; the rest recede a little,
|
||||
enough to read the neighbourhood without losing the map. */
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__node-screen {
|
||||
opacity: var(--hover-recede);
|
||||
--map-card-opacity: var(--hover-recede);
|
||||
transition: opacity 90ms ease;
|
||||
}
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__node-screen.graph-node-hover-related,
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__node-screen.graph-node-hover-subject {
|
||||
opacity: 1;
|
||||
--map-card-opacity: 1;
|
||||
}
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__edge { opacity: 0.3; }
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__edge.graph-edge-hover-related { opacity: 1; }
|
||||
/* Hover is transient canvas state. Nothing recedes: the pointer's screen gets its ring, the
|
||||
transitions into and out of it turn accent, and the screens at their other ends take a tinted
|
||||
frame, so the neighbourhood reads without the rest of the map changing. Only the symmetric
|
||||
difference of related nodes/edges receives a class, avoiding a React commit across the graph. */
|
||||
.connection-canvas-surface.canvas-hovering .graph-edge-hover-related .transition-edge-path {
|
||||
stroke: var(--accent) !important;
|
||||
stroke-width: 2.2 !important;
|
||||
stroke-dasharray: none !important;
|
||||
}
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__node-screen.graph-node-hover-related:not(.graph-node-hover-subject)
|
||||
.screen-screenshot-card:not(.selected, .diff-added, .diff-modified, .diff-removed) {
|
||||
--screen-frame: var(--hover-neighbour-frame);
|
||||
}
|
||||
.connection-canvas-surface.canvas-hovering .react-flow__node-screen.graph-node-hover-related:not(.graph-node-hover-subject)
|
||||
.screen-screenshot-card:not(.selected, .diff-added, .diff-modified, .diff-removed) .screen-node-image :is(img, .image-placeholder) {
|
||||
border-color: var(--hover-neighbour-frame);
|
||||
}
|
||||
|
||||
/* Semantic Map: an area is a meaningful destination, never an anonymous "X states" step. */
|
||||
.semantic-summary-node {
|
||||
@@ -925,10 +926,9 @@ code {
|
||||
transition-duration: 0ms;
|
||||
}
|
||||
|
||||
/* Hovering a screenshot says what a click does: it opens the screen in the Inspector. The hint
|
||||
sits in the middle of the screenshot, so it is always on the image whatever the slot's shape.
|
||||
With a pointer, an already selected screen is in the Inspector. On a phone's map the first tap
|
||||
only selects, so the hint sits on the selected screen and says what the next tap does. */
|
||||
/* The phone map's open hint. The first tap there only selects, so the pill sits in the middle of
|
||||
the selected screenshot (always on the image whatever the slot's shape) and says what the next
|
||||
tap does. In a wider window the card's tooltip carries the message and nothing covers the image. */
|
||||
.screen-screenshot-target { cursor: pointer; }
|
||||
.screen-open-hint {
|
||||
position: absolute;
|
||||
@@ -952,21 +952,12 @@ code {
|
||||
backdrop-filter: blur(6px);
|
||||
}
|
||||
.screen-open-hint > svg { width: 14px; height: 14px; flex: none; }
|
||||
.screen-open-hint-short { display: none; }
|
||||
@media (hover: hover) and (pointer: fine) {
|
||||
.screen-screenshot-card:not(.selected) .screen-screenshot-target:hover .screen-open-hint {
|
||||
display: inline-flex;
|
||||
animation: screen-open-hint-in 140ms ease-out;
|
||||
}
|
||||
}
|
||||
@media (hover: none) {
|
||||
.phone-layout .map-canvas .screen-screenshot-card.selected .screen-open-hint {
|
||||
display: inline-flex;
|
||||
animation: screen-open-hint-in 140ms ease-out;
|
||||
}
|
||||
/* Phone map screens are narrow, so the hint is one word there and stays on the screenshot. */
|
||||
.phone-layout .map-canvas .screen-open-hint-long { display: none; }
|
||||
.phone-layout .map-canvas .screen-open-hint-short { display: inline; }
|
||||
/* Only the phone layout's map shows the pill, on the selected screen, where a second tap or click
|
||||
opens the Inspector. That layout is a width, not a device, and has no tooltips, so a narrow
|
||||
desktop window shows it too. Elsewhere the screenshot button's tooltip says it instead. */
|
||||
.phone-layout .map-canvas .screen-screenshot-card.selected .screen-open-hint {
|
||||
display: inline-flex;
|
||||
animation: screen-open-hint-in 140ms ease-out;
|
||||
}
|
||||
@keyframes screen-open-hint-in { from { opacity: 0; transform: translate(-50%, -40%); } }
|
||||
@media (prefers-reduced-motion: reduce) { .screen-open-hint { animation: none !important; } }
|
||||
@@ -1064,30 +1055,36 @@ code {
|
||||
opacity 170ms ease-in-out calc(var(--toolbar-motion) * 0.35),
|
||||
filter 170ms ease-in-out calc(var(--toolbar-motion) * 0.35);
|
||||
}
|
||||
/* Compare's count of changed screens rides on its button's corner. */
|
||||
.toolbar-button:has(> .toolbar-badge) { position: relative; }
|
||||
.toolbar-badge {
|
||||
/* The key that completes a chord, on a button's corner while its modifier is held: hold ⌃ and
|
||||
the toolbar's sections show 1, 2 and 3. Quiet: a small key in the element colour. */
|
||||
.toolbar-button:has(> .key-hint), .camera-action-button:has(> .key-hint), .collapsed-platform:has(> .key-hint), .compare-nav-picker:has(> .key-hint) { position: relative; }
|
||||
.key-hint {
|
||||
position: absolute;
|
||||
top: -6px;
|
||||
right: -6px;
|
||||
display: flex;
|
||||
min-width: 18px;
|
||||
height: 18px;
|
||||
min-width: 16px;
|
||||
height: 16px;
|
||||
align-items: center;
|
||||
justify-content: center;
|
||||
padding: 0 5px;
|
||||
border-radius: 9px;
|
||||
/* Light theme's deep orange takes white text, as the Modified pill does; dark theme's light
|
||||
orange takes dark text. */
|
||||
color: #fff;
|
||||
background: var(--modified);
|
||||
box-shadow: 0 0 0 2px var(--surface);
|
||||
padding: 0 4px;
|
||||
border-radius: 5px;
|
||||
color: var(--text);
|
||||
background: var(--element);
|
||||
box-shadow: 0 0 0 2px var(--surface), 0 1px 2px rgb(0 0 0 / 0.12);
|
||||
font: inherit;
|
||||
font-size: 10px;
|
||||
font-weight: 700;
|
||||
font-weight: 600;
|
||||
line-height: 1;
|
||||
font-variant-numeric: tabular-nums;
|
||||
pointer-events: none;
|
||||
animation: key-hint-in 100ms ease-out;
|
||||
}
|
||||
:root[data-theme="dark"] .toolbar-badge { color: #0c0d0e; }
|
||||
@keyframes key-hint-in {
|
||||
from { opacity: 0; transform: translateY(2px); }
|
||||
to { opacity: 1; transform: none; }
|
||||
}
|
||||
@media (prefers-reduced-motion: reduce) { .key-hint { animation: none; } }
|
||||
/* Reduced motion: the bar takes its new width at once; only the names fade, without the blur. */
|
||||
@media (prefers-reduced-motion: reduce) {
|
||||
.toolbar-view-label,
|
||||
@@ -2386,7 +2383,6 @@ html [data-sonner-toaster][data-sonner-theme] {
|
||||
background: #000;
|
||||
}
|
||||
|
||||
|
||||
.image-placeholder-reason {
|
||||
display: block;
|
||||
max-width: 80%;
|
||||
|
||||
@@ -10,6 +10,25 @@ export function appearanceLabel(appearance: Appearance): string {
|
||||
return APPEARANCE_LABELS[appearance];
|
||||
}
|
||||
|
||||
/** The review a tab's choice belongs to: every target of one review shares the page path (and a report page's run). */
|
||||
function chosenAppearanceKey(): string {
|
||||
return `explore.appearance:${window.location.pathname}:${new URLSearchParams(window.location.search).get("run") ?? ""}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* The appearance this tab last chose for this review, so another target's report opens in it too when it was captured
|
||||
* in it (a switch in place remounts the Viewer, and a report page loads again). Kept in session storage, which may be off.
|
||||
*/
|
||||
export function rememberedAppearance(): Appearance | undefined {
|
||||
let stored: string | null = null;
|
||||
try { stored = window.sessionStorage.getItem(chosenAppearanceKey()); } catch { /* Optional storage. */ }
|
||||
return stored === "light" || stored === "dark" ? stored : undefined;
|
||||
}
|
||||
|
||||
export function rememberAppearance(appearance: Appearance): void {
|
||||
try { window.sessionStorage.setItem(chosenAppearanceKey(), appearance); } catch { /* Optional storage. */ }
|
||||
}
|
||||
|
||||
/** The appearances a report captured, primary first; one or none means the report has no appearance switch. */
|
||||
export function appearanceOptions(map: ExploreMap | undefined): Appearance[] {
|
||||
if (!map) return [];
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { BlobReader, ZipReader, type FileEntry } from "@zip.js/zip.js";
|
||||
import type { FileEntry } from "@zip.js/zip.js";
|
||||
import type { ArtifactReport } from "../../../src/contracts/artifact-report";
|
||||
import { normalizePublicReviewForReading } from "../../../src/contracts/review-validation";
|
||||
import { reportContractGap } from "../public/public-workspace";
|
||||
@@ -56,14 +56,24 @@ export function isPreviewPath(pathname: string): boolean {
|
||||
}
|
||||
|
||||
/**
|
||||
* A hosted preview: one EAS Hosting deployment per review whose Worker serves this Viewer at
|
||||
* `/p/<token>` and the decrypted report at `/p/<token>/report.zip`, for as long as the link is valid.
|
||||
* The token of a hosted preview page, `/p/<token>`: one EAS Hosting deployment per review, whose Worker serves this
|
||||
* Viewer there, each target's manifest at `/p/<token>/manifest.json`, and every screenshot as a static file.
|
||||
*/
|
||||
export function previewReportUrl(page: URL): string | undefined {
|
||||
const match = PREVIEW_PATH.exec(page.pathname);
|
||||
if (!match) return undefined;
|
||||
const target = reportTarget(page);
|
||||
return `/p/${match[1]}/report.zip${target ? `?${targetQuery(target)}` : ""}`;
|
||||
export function previewToken(page: URL): string | undefined {
|
||||
return PREVIEW_PATH.exec(page.pathname)?.[1];
|
||||
}
|
||||
|
||||
/** The manifest the Worker serves instead of the whole ZIP (`/p/<token>/manifest.json`). */
|
||||
export function previewManifestUrl(token: string, target?: string): string {
|
||||
return `/p/${token}/manifest.json${target ? `?${targetQuery(target)}` : ""}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* One asset of a hosted preview's report, a static file at `/p/<token>/assets/<sha256>.<ext>`. Named by its content, it
|
||||
* is the same file for every target that shows it, so it carries no target.
|
||||
*/
|
||||
export function previewAssetUrl(token: string, path: string): string {
|
||||
return `/p/${token}/${path}`;
|
||||
}
|
||||
|
||||
/** The hosted preview's list of the targets it serves (`/p/<token>/reports.json`). */
|
||||
@@ -213,7 +223,49 @@ function validateReport(value: unknown, expected?: ArtifactIdentity, fileName?:
|
||||
return { report: { ...report, review }, identity: expected ?? own };
|
||||
}
|
||||
|
||||
type ImageEntry = { entry: FileEntry; metadata: EmbeddedScreenshot; extension: "png" | "jpg" | "mp4" };
|
||||
/** Where an archive's bytes come from: a ZIP entry in this browser, or one asset of a hosted preview. */
|
||||
type SourceEntry = { size: number; read: (limit: number, mimeType: string) => Promise<Blob> };
|
||||
type ImageEntry = { entry: SourceEntry; metadata: EmbeddedScreenshot; extension: "png" | "jpg" | "mp4" };
|
||||
|
||||
function zipEntry(entry: FileEntry): SourceEntry {
|
||||
return { size: entry.uncompressedSize, read: (limit, mimeType) => readEntry(entry, limit, mimeType) };
|
||||
}
|
||||
|
||||
/** A hosted preview asset: fetched when a screenshot is first shown, kept by the browser's HTTP cache afterwards. */
|
||||
function remoteEntry(url: string, size: number): SourceEntry {
|
||||
return { size, read: async (limit, mimeType) => {
|
||||
if (size > limit) throw new Error(`Report asset is too large: ${url}`);
|
||||
let response: Response | undefined;
|
||||
for (let attempt = 0; attempt < 2; attempt += 1) {
|
||||
try { response = await fetch(url, { credentials: "same-origin" }); }
|
||||
catch (error) { if (attempt) throw error; continue; }
|
||||
if (response.ok || response.status < 500) break;
|
||||
}
|
||||
if (!response?.ok) throw new Error(`The report screenshot could not be downloaded (HTTP ${response?.status ?? 0}).`);
|
||||
const bytes = await response.arrayBuffer();
|
||||
if (bytes.byteLength !== size) throw new Error("The screenshot size does not match the report.");
|
||||
return new Blob([bytes], { type: mimeType });
|
||||
} };
|
||||
}
|
||||
|
||||
/** The report page's manifest (src/report/preview-manifest.ts): the metadata file plus every asset's size. */
|
||||
export const PREVIEW_MANIFEST_FORMAT = "explore.preview-manifest/1";
|
||||
type PreviewManifest = { format: typeof PREVIEW_MANIFEST_FORMAT; file: "review.json" | "exploration.json"; entries: Record<string, number>; report: unknown };
|
||||
|
||||
function validateManifest(value: unknown): PreviewManifest {
|
||||
const invalid = () => new ReportFileError("invalid", "The hosted report manifest is invalid.");
|
||||
if (!value || typeof value !== "object") throw invalid();
|
||||
const manifest = value as PreviewManifest;
|
||||
if (manifest.format !== PREVIEW_MANIFEST_FORMAT || !["review.json", "exploration.json"].includes(manifest.file)
|
||||
|| !manifest.entries || typeof manifest.entries !== "object" || Array.isArray(manifest.entries)
|
||||
|| !manifest.report || typeof manifest.report !== "object") throw invalid();
|
||||
const entries = Object.entries(manifest.entries);
|
||||
if (entries.length > ARTIFACT_LIMITS.entries) throw invalid();
|
||||
for (const [path, size] of entries) {
|
||||
if (!safePath(path) || !Number.isSafeInteger(size) || size < 0 || size > ARTIFACT_LIMITS.image) throw invalid();
|
||||
}
|
||||
return manifest;
|
||||
}
|
||||
/** Eager screenshots (the Inspector's) are decoded before lazy ones (canvas nodes and thumbnails). */
|
||||
export type ScreenshotPriority = "eager" | "lazy";
|
||||
type ImageLoad = {
|
||||
@@ -233,6 +285,8 @@ const DECODE_SLOTS = 4;
|
||||
*/
|
||||
export const RETAINED_SCREENSHOTS = 32;
|
||||
export const RETAINED_SCREENSHOT_BYTES = 128 * 1024 * 1024;
|
||||
/** A hosted preview's report in the background (another target is shown) keeps fewer, for a quick switch back. */
|
||||
export const BACKGROUND_RETAINED_SCREENSHOTS = 16;
|
||||
|
||||
/**
|
||||
* Compressed Blob + entry index. Screenshots are extracted when a caller asks for them; the last
|
||||
@@ -248,8 +302,9 @@ export class ArtifactReportArchive {
|
||||
private readonly queues: Record<ScreenshotPriority, ImageLoad[]> = { eager: [], lazy: [] };
|
||||
private disposed = false;
|
||||
private running = 0;
|
||||
private retainedLimit = RETAINED_SCREENSHOTS;
|
||||
|
||||
private constructor(private readonly reader: ZipReader<Blob>, report: ArtifactReport | ExplorationReport,
|
||||
private constructor(private readonly close: () => void, report: ArtifactReport | ExplorationReport,
|
||||
private readonly images: Map<string, ImageEntry>, readonly identity: ArtifactIdentity) {
|
||||
const assets = Object.fromEntries([...images].map(([sha, value]) => [sha, value.metadata]));
|
||||
this.data = report.kind === EXPLORATION_REPORT_KIND ? { contract: STANDALONE_REPORT_CONTRACT, exploration: report, assets }
|
||||
@@ -259,6 +314,8 @@ export class ArtifactReportArchive {
|
||||
/** Bind the ZIP to the linked run when there is one; a bare page takes the run the report names. */
|
||||
static async open(blob: Blob, identity?: ArtifactIdentity, fileName?: string): Promise<ArtifactReportArchive> {
|
||||
await checkReportFile(blob, fileName);
|
||||
// The ZIP reader is loaded on first use: a hosted preview opens its manifest and never needs it.
|
||||
const { BlobReader, ZipReader } = await import("@zip.js/zip.js");
|
||||
const reader = new ZipReader(new BlobReader(blob), { strictness: "strict", useWebWorkers: false });
|
||||
try {
|
||||
const files = new Map<string, FileEntry>();
|
||||
@@ -280,6 +337,30 @@ export class ArtifactReportArchive {
|
||||
}
|
||||
if (!entry.directory) files.set(entry.filename, entry);
|
||||
}
|
||||
const entries = new Map<string, SourceEntry>([...files].map(([name, entry]) => [name, zipEntry(entry)]));
|
||||
return await ArtifactReportArchive.fromEntries(entries, () => { void reader.close(); }, identity, fileName);
|
||||
} catch (error) {
|
||||
await reader.close();
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Open a hosted preview from its manifest alone: the metadata is validated like a ZIP's, and each asset is
|
||||
* fetched from `assetUrl(path)` when a screenshot is first shown, so the first paint waits for no screenshot.
|
||||
*/
|
||||
static async openManifest(value: unknown, assetUrl: (path: string) => string, identity?: ArtifactIdentity): Promise<ArtifactReportArchive> {
|
||||
const manifest = validateManifest(value);
|
||||
const text = JSON.stringify(manifest.report);
|
||||
const metadata = new Blob([text], { type: "application/json" });
|
||||
const entries = new Map<string, SourceEntry>();
|
||||
for (const [path, size] of Object.entries(manifest.entries)) entries.set(path, remoteEntry(assetUrl(path), size));
|
||||
entries.set(manifest.file, { size: metadata.size, read: () => Promise.resolve(metadata) });
|
||||
return ArtifactReportArchive.fromEntries(entries, () => {}, identity, "report.zip");
|
||||
}
|
||||
|
||||
private static async fromEntries(files: Map<string, SourceEntry>, close: () => void, identity?: ArtifactIdentity, fileName?: string): Promise<ArtifactReportArchive> {
|
||||
{
|
||||
const indexImages = (assets: ArtifactReport["assets"]): Map<string, ImageEntry> => {
|
||||
const images = new Map<string, ImageEntry>();
|
||||
const imagePaths = new Set<string>();
|
||||
@@ -290,34 +371,34 @@ export class ArtifactReportArchive {
|
||||
}
|
||||
const extension = /\.(png|jpg|mp4)$/.exec(asset.path)?.[1] as "png" | "jpg" | "mp4" | undefined;
|
||||
const entry = files.get(asset.path);
|
||||
if (!extension || !entry || entry.uncompressedSize <= 0 || entry.uncompressedSize > ARTIFACT_LIMITS.image) {
|
||||
if (!extension || !entry || entry.size <= 0 || entry.size > ARTIFACT_LIMITS.image) {
|
||||
throw new Error("A report screenshot is missing or invalid.");
|
||||
}
|
||||
images.set(asset.sha256, { entry, extension,
|
||||
metadata: { mimeType: extension === "png" ? "image/png" : extension === "mp4" ? "video/mp4" : "image/jpeg", byteLength: entry.uncompressedSize } });
|
||||
metadata: { mimeType: extension === "png" ? "image/png" : extension === "mp4" ? "video/mp4" : "image/jpeg", byteLength: entry.size } });
|
||||
imagePaths.add(asset.path);
|
||||
}
|
||||
return images;
|
||||
};
|
||||
const explorationEntry = files.get("exploration.json");
|
||||
if (explorationEntry && !files.has("review.json")) {
|
||||
if (explorationEntry.uncompressedSize > ARTIFACT_LIMITS.metadata) throw new ReportFileError("too-large", `${describe(fileName)} has an exploration index over the browser limit.`);
|
||||
if (explorationEntry.size > ARTIFACT_LIMITS.metadata) throw new ReportFileError("too-large", `${describe(fileName)} has an exploration index over the browser limit.`);
|
||||
let parsed: unknown;
|
||||
try { parsed = JSON.parse(await (await readEntry(explorationEntry, ARTIFACT_LIMITS.metadata, "application/json")).text()); }
|
||||
try { parsed = JSON.parse(await (await explorationEntry.read(ARTIFACT_LIMITS.metadata, "application/json")).text()); }
|
||||
catch { throw new ReportFileError("not-report", `${describe(fileName)} is not an Explore report: its exploration.json is not valid JSON.`); }
|
||||
const { report, identity: bound } = validateExplorationReport(parsed, identity, fileName);
|
||||
const images = indexImages(report.assets);
|
||||
for (const artifact of report.map.artifacts) {
|
||||
if (artifact.kind === "screenshot" && !images.has(artifact.sha256)) throw new Error("A captured screenshot is missing from the report image index.");
|
||||
}
|
||||
return new ArtifactReportArchive(reader, report, images, bound);
|
||||
return new ArtifactReportArchive(close, report, images, bound);
|
||||
}
|
||||
const metadata = files.get("review.json");
|
||||
if (!metadata || metadata.uncompressedSize > ARTIFACT_LIMITS.metadata) {
|
||||
if (!metadata || metadata.size > ARTIFACT_LIMITS.metadata) {
|
||||
throw new ReportFileError("not-report", `${describe(fileName)} is not an Explore report: it has no review.json. Download ${identity ? reportFileName(identity) : `the ${GENERIC_FILE_NAME} artifact`} from the workflow run.`);
|
||||
}
|
||||
let parsed: unknown;
|
||||
try { parsed = JSON.parse(await (await readEntry(metadata, ARTIFACT_LIMITS.metadata, "application/json")).text()); }
|
||||
try { parsed = JSON.parse(await (await metadata.read(ARTIFACT_LIMITS.metadata, "application/json")).text()); }
|
||||
catch { throw new ReportFileError("not-report", `${describe(fileName)} is not an Explore report: its review.json is not valid JSON.`); }
|
||||
const { report, identity: bound } = validateReport(parsed, identity, fileName);
|
||||
const images = indexImages(report.assets);
|
||||
@@ -326,10 +407,7 @@ export class ArtifactReportArchive {
|
||||
if (image && !images.has(image.sha256)) throw new Error("A captured screenshot is missing from the report image index.");
|
||||
}
|
||||
}
|
||||
return new ArtifactReportArchive(reader, report, images, bound);
|
||||
} catch (error) {
|
||||
await reader.close();
|
||||
throw error;
|
||||
return new ArtifactReportArchive(close, report, images, bound);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -345,6 +423,8 @@ export class ArtifactReportArchive {
|
||||
async resolve(reference: string, priority: ScreenshotPriority = "lazy"): Promise<string> {
|
||||
const sha256 = IMAGE_REFERENCE.exec(reference)?.[1];
|
||||
if (!sha256) return reference;
|
||||
// Shown again: back to the full allowance.
|
||||
this.retainedLimit = RETAINED_SCREENSHOTS;
|
||||
if (this.disposed || !this.images.has(sha256)) throw new Error("This report screenshot is unavailable.");
|
||||
const existing = this.loads.get(sha256);
|
||||
if (existing) {
|
||||
@@ -388,7 +468,22 @@ export class ArtifactReportArchive {
|
||||
this.loads.clear();
|
||||
this.retained.clear();
|
||||
this.retainedBytes = 0;
|
||||
void this.reader.close();
|
||||
this.close();
|
||||
}
|
||||
|
||||
/**
|
||||
* Let go of every screenshot of a report nobody is looking at; its index stays open for a quick return. The Viewer that
|
||||
* used them releases them against the report shown next, so the ones still in use are dropped here instead.
|
||||
*/
|
||||
trim(): void {
|
||||
for (const load of this.queues.eager.splice(0).concat(this.queues.lazy.splice(0))) {
|
||||
load.waiting?.drop(new Error("This screenshot is no longer in use."));
|
||||
}
|
||||
// What the Viewer was showing is kept as released, most recent last, so switching back shows it at once.
|
||||
this.retainedLimit = BACKGROUND_RETAINED_SCREENSHOTS;
|
||||
for (const load of this.loads.values()) if (load.url) this.retain(load.sha256, load.url);
|
||||
this.loads.clear();
|
||||
this.evictRetained();
|
||||
}
|
||||
|
||||
private async decode(load: ImageLoad): Promise<string> {
|
||||
@@ -396,7 +491,7 @@ export class ArtifactReportArchive {
|
||||
await this.acquireSlot(load);
|
||||
try {
|
||||
if (this.disposed) throw new Error("This report was closed.");
|
||||
const blob = await readEntry(image.entry, ARTIFACT_LIMITS.image, image.metadata.mimeType);
|
||||
const blob = await image.entry.read(ARTIFACT_LIMITS.image, image.metadata.mimeType);
|
||||
const bytes = await blob.arrayBuffer();
|
||||
const header = new Uint8Array(bytes, 0, Math.min(8, bytes.byteLength));
|
||||
const validImage = image.extension === "png"
|
||||
@@ -411,10 +506,11 @@ export class ArtifactReportArchive {
|
||||
if (actual !== load.sha256) throw new Error("The screenshot checksum does not match the report.");
|
||||
if (this.disposed) throw new Error("This report was closed.");
|
||||
const url = URL.createObjectURL(blob);
|
||||
if (load.users > 0) load.url = url;
|
||||
const current = this.loads.get(load.sha256) === load;
|
||||
if (current && load.users > 0) load.url = url;
|
||||
else {
|
||||
// Everyone let go while it decoded; keep the finished work for a quick return.
|
||||
this.loads.delete(load.sha256);
|
||||
// Everyone let go while it decoded, or the report was trimmed; keep the finished work for a quick return.
|
||||
if (current) this.loads.delete(load.sha256);
|
||||
this.retain(load.sha256, url);
|
||||
}
|
||||
return url;
|
||||
@@ -468,10 +564,22 @@ export class ArtifactReportArchive {
|
||||
/** Keep a released URL; beyond either limit the least recently released ones are revoked. */
|
||||
private retain(sha256: string, url: string): void {
|
||||
const bytes = this.images.get(sha256)!.metadata.byteLength;
|
||||
// A decode a trim left behind can finish after a later one for the same screenshot; nothing uses a kept URL, so the older one goes.
|
||||
const replaced = this.retained.get(sha256);
|
||||
if (replaced) {
|
||||
this.retained.delete(sha256);
|
||||
this.retainedBytes -= replaced.bytes;
|
||||
if (replaced.url !== url) URL.revokeObjectURL(replaced.url);
|
||||
}
|
||||
this.retained.set(sha256, { url, bytes });
|
||||
this.retainedBytes += bytes;
|
||||
this.evictRetained();
|
||||
}
|
||||
|
||||
/** Beyond either limit, the least recently released kept URLs are revoked. */
|
||||
private evictRetained(): void {
|
||||
for (const [oldest, old] of this.retained) {
|
||||
if (this.retained.size <= RETAINED_SCREENSHOTS && this.retainedBytes <= RETAINED_SCREENSHOT_BYTES) break;
|
||||
if (this.retained.size <= this.retainedLimit && this.retainedBytes <= RETAINED_SCREENSHOT_BYTES) break;
|
||||
this.retained.delete(oldest);
|
||||
this.retainedBytes -= old.bytes;
|
||||
URL.revokeObjectURL(old.url);
|
||||
@@ -482,7 +590,14 @@ export class ArtifactReportArchive {
|
||||
export let activeArtifactReport: ArtifactReportArchive | undefined;
|
||||
|
||||
function activate(archive: ArtifactReportArchive): ArtifactReportArchive {
|
||||
activeArtifactReport?.dispose();
|
||||
if (activeArtifactReport !== archive) activeArtifactReport?.dispose();
|
||||
activeArtifactReport = archive;
|
||||
return archive;
|
||||
}
|
||||
|
||||
/** Make an archive the one screenshots resolve from, keeping the previous one open (a hosted preview's other target). */
|
||||
export function showArchive(archive: ArtifactReportArchive): ArtifactReportArchive {
|
||||
if (activeArtifactReport !== archive) activeArtifactReport?.trim();
|
||||
activeArtifactReport = archive;
|
||||
return archive;
|
||||
}
|
||||
|
||||
@@ -21,6 +21,16 @@ export function resolveEmbeddedArtifactUrl(reference: string, priority: Screensh
|
||||
return Promise.resolve(reference);
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve, with a release bound to the report that resolved it: for a caller that may let go after a hosted preview has
|
||||
* switched to another target's report, whose screenshots it must not release.
|
||||
*/
|
||||
export function leaseEmbeddedArtifactUrl(reference: string, priority: ScreenshotPriority = "lazy"): { url: Promise<string>; release: () => void } {
|
||||
const archive = activeArtifactReport;
|
||||
if (!archive) return { url: resolveEmbeddedArtifactUrl(reference, priority), release: () => {} };
|
||||
return { url: archive.resolve(reference, priority), release: () => archive.release(reference) };
|
||||
}
|
||||
|
||||
/** Artifact screenshots release their Blob URL when no visible image or download uses it; the report keeps a few for a quick return. */
|
||||
export function releaseEmbeddedArtifactUrl(reference: string): boolean {
|
||||
if (!activeArtifactReport) return false;
|
||||
|
||||
@@ -0,0 +1,84 @@
|
||||
// Which modifier keys are down right now, so a button can show the key that completes a chord
|
||||
// with them: hold ⌃ and the toolbar's Map, Screens and Compare show 1, 2 and 3. One listener for
|
||||
// the window; components subscribe and re-render only when the set of held modifiers changes.
|
||||
import { useSyncExternalStore } from "react";
|
||||
import { APPLE, isTyping, type Shortcut } from "./shortcuts";
|
||||
|
||||
export type HeldModifiers = { shift: boolean; ctrl: boolean; meta: boolean; alt: boolean };
|
||||
|
||||
const NONE: HeldModifiers = { shift: false, ctrl: false, meta: false, alt: false };
|
||||
// The modifiers physically down, and the ones the hints show: none while focus is in a field,
|
||||
// where a held Shift is for a capital letter, not for a chord. Focus can move by mouse with a
|
||||
// modifier still down, so the shown set is worked out again on every focus change too.
|
||||
let physical: HeldModifiers = NONE;
|
||||
let held: HeldModifiers = NONE;
|
||||
const listeners = new Set<() => void>();
|
||||
|
||||
function same(left: HeldModifiers, right: HeldModifiers): boolean {
|
||||
return left.shift === right.shift && left.ctrl === right.ctrl && left.meta === right.meta && left.alt === right.alt;
|
||||
}
|
||||
|
||||
function publish() {
|
||||
const next = isTyping(document.activeElement) ? NONE : physical;
|
||||
if (same(held, next)) return;
|
||||
held = same(next, NONE) ? NONE : next;
|
||||
for (const listener of listeners) listener();
|
||||
}
|
||||
|
||||
function onKey(event: KeyboardEvent) {
|
||||
physical = { shift: event.shiftKey, ctrl: event.ctrlKey, meta: event.metaKey, alt: event.altKey };
|
||||
publish();
|
||||
}
|
||||
|
||||
function clear() {
|
||||
physical = NONE;
|
||||
publish();
|
||||
}
|
||||
|
||||
function subscribe(listener: () => void) {
|
||||
if (listeners.size === 0) {
|
||||
window.addEventListener("keydown", onKey, true);
|
||||
window.addEventListener("keyup", onKey, true);
|
||||
// A chord that leaves the page (⌘Tab, a browser shortcut) never sends its key up here.
|
||||
window.addEventListener("blur", clear);
|
||||
document.addEventListener("visibilitychange", clear);
|
||||
document.addEventListener("focusin", publish);
|
||||
document.addEventListener("focusout", publish);
|
||||
}
|
||||
listeners.add(listener);
|
||||
return () => {
|
||||
listeners.delete(listener);
|
||||
if (listeners.size > 0) return;
|
||||
window.removeEventListener("keydown", onKey, true);
|
||||
window.removeEventListener("keyup", onKey, true);
|
||||
window.removeEventListener("blur", clear);
|
||||
document.removeEventListener("visibilitychange", clear);
|
||||
document.removeEventListener("focusin", publish);
|
||||
document.removeEventListener("focusout", publish);
|
||||
physical = NONE;
|
||||
held = NONE;
|
||||
};
|
||||
}
|
||||
|
||||
export function useHeldModifiers(): HeldModifiers {
|
||||
return useSyncExternalStore(subscribe, () => held, () => NONE);
|
||||
}
|
||||
|
||||
/** The modifiers a shortcut needs, on this keyboard: ⌘ for `mod` on Apple keyboards, Ctrl elsewhere. */
|
||||
export function shortcutModifiers(shortcut: Shortcut, apple = APPLE): HeldModifiers {
|
||||
return {
|
||||
shift: Boolean(shortcut.shift),
|
||||
ctrl: Boolean(shortcut.ctrl) || (Boolean(shortcut.mod) && !apple),
|
||||
meta: Boolean(shortcut.mod) && apple,
|
||||
alt: Boolean(shortcut.alt),
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* The key that completes `shortcut` with exactly the modifiers held, or nothing: a plain key has no
|
||||
* chord to complete, and a held modifier that is not the shortcut's shows nothing for it.
|
||||
*/
|
||||
export function heldKeyHint(shortcut: Shortcut, held: HeldModifiers, apple = APPLE): string | undefined {
|
||||
if (same(held, NONE)) return undefined;
|
||||
return same(held, shortcutModifiers(shortcut, apple)) ? shortcut.key : undefined;
|
||||
}
|
||||