Compare commits

..
102 changed files with 737 additions and 4705 deletions

No files matched your search

+1 -6
View File
@@ -67,12 +67,9 @@ jobs:
shell: bash
env:
COMMENT_ID: ${{ steps.comment.outputs.id }}
# How long an alias can keep serving the previous push: an EAS Hosting edge that served it keeps it for about
# five minutes (FIXTURE_ALIAS_WAIT_MS in src/report/preview-deploy.ts).
ALIAS_CATCH_UP: 5 minutes
run: |
set -euo pipefail
jq -r --arg marker "$MARKER" --arg sha "${SHA:0:7}" --arg run "$RUN_URL" --arg catchup "$ALIAS_CATCH_UP" '
jq -r --arg marker "$MARKER" --arg sha "${SHA:0:7}" --arg run "$RUN_URL" '
.previewUrl as $url
| ([.reports[] | select(.platform == "android")] + [.reports[] | select(.platform != "android")]) as $reports
| ($reports[0].source // "") as $source
@@ -88,8 +85,6 @@ jobs:
| ((.label // (if .platform == "ios" then "iOS" else "Android" end)) | gsub("\\|"; "\\\\|")) as $name
| "| \($name)\(if .device then " · \(.device)" else "" end) | \(.changes // "–") | [Map](\($url)?\($query)) · [Screens](\($url)?\($query)#/screens) · [Compare](\($url)?\($query)&view=compare) |"),
"",
# The alias still served the previous push when the deploy stopped waiting for it: say so, and link the new deployment.
(if .aliasBehind then "> **Going live:** this link can take up to \($catchup) to show \($sha); until then it shows the previous push, or nothing on a new pull request. [This push'"'"'s deployment](\(.deploymentUrl)/p/\($url | split("/p/")[1])) is live now.\n" else empty end),
"The link stays the same on every push. [Deploy run](\($run))"]
| join("\n")' "$RUNNER_TEMP/preview.json" > "$RUNNER_TEMP/comment.md"
if [[ -n "$COMMENT_ID" ]]; then
+4 -4
View File
@@ -49,16 +49,16 @@ Each workflow starts with a `targets` job: it installs the pinned CLI and runs `
| | checkout `app-base`, `app-head` | Checks out the exact base and head SHAs with full history and without persisted credentials. |
| | Verify deterministic source planning | `source:verify` builds the capture plan from source alone in two fresh processes and compares the bytes. Runs before any build or simulator work and needs no credentials. |
| | Install app dependencies | `npm ci --ignore-scripts` in both checkouts (`APP_INSTALL_DIR` for monorepos). |
| | Find / Download optional exact-base evidence | `ci:find-baseline` looks for a finished run's `explore-baseline-<base sha>-<target>` artifact (a run another target's baseline failed in counts: a baseline job uploads its artifact only after its own steps passed) (target `ios` also accepts the older unsuffixed `explore-baseline-<base sha>`) from the baseline workflow on the default branch and downloads it as `EXPLORE_CAPTURE_CACHE`. Missing evidence is not an error. |
| | Find / Download optional exact-base evidence | `ci:find-baseline` looks for a successful `explore-baseline-<base sha>-<target>` artifact (target `ios` also accepts the older unsuffixed `explore-baseline-<base sha>`) from the baseline workflow on the default branch and downloads it as `EXPLORE_CAPTURE_CACHE`. Missing evidence is not an error. |
| | Capture review | `capture:review` (§3). `EXPO_TOKEN`, the provider key and the app's `{{secret:NAME}}` values reach only this step. The sticky PR comment is updated while it runs. It writes `preview=<hosting>` to the step outputs, which decides whether the deploy job runs. |
| | Stop capture sessions and check the checkouts | `ci:after-capture`, whenever the PR was resolved, success or not: stops the EAS Simulator sessions named in `head-session` / `base-session`, nothing else, then fails with `CHECKOUT_MODIFIED` if capture modified an app checkout. |
| | Upload captured review / diagnostics | `explore-capture-<run>-<attempt>-<target>` feeds the report job. On failure `explore-diagnostics-<run>-<attempt>-<target>` keeps plans, exports and agent diagnostics for 7 days. |
| report (matrix: target) | Download the capture, install Explore | Runs without Expo or model credentials, after every capture job, whether or not each succeeded (`!cancelled()`). Each leg downloads its own target's capture by an exact-name pattern: a target whose capture failed uploaded none, so its leg packages and publishes nothing, and the other targets' reports still reach the comment. |
| report (matrix: target) | Install Explore, download the capture | Runs without Expo or model credentials. |
| | Package hosted review bundle | `ci:report` writes the report directory. |
| | Upload hosted review bundle | `explore-review-<run>-<attempt>-<target>`, kept 30 days. |
| | Publish current PR hosted links | `ci:publish` re-checks that the artifact belongs to this PR, then updates the sticky comment with **Open** (the hosted Viewer) and **zip**. The comment is rendered from one hidden record per target (`<!-- expo-explore-record:<target>:… -->`, plus one history line for earlier runs); each job folds its own record into the ones the comment already carries and re-renders the whole comment, so parallel targets do not overwrite each other. Rows, report links and validation columns are labelled with the target's label (`iOS` and `Android` without `targets:`) and follow config order. |
| `deploy` (only when `report.preview` is set; after every report job, once any of them published) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every capture and report artifact the run has (a target whose capture or report job failed has none and is left out), writes each report's manifest and screenshots as static files under the link's token, deploys them with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report**. The link works as long as the EAS Hosting deployment. |
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only each failed target's record when the run has several; the target is the id the failed job's diagnostics artifact name ends with (or, when download-artifact extracted a lone artifact without its directory, the `target` its `error.json` records), and its label comes from the record the capture job already posted. Once the other targets published, the comment shows their reports and this failure, with no new-run line. |
| `deploy` (only when `report.preview` is set; after every report job) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every target's capture and report artifacts, writes each report's manifest and screenshots as static files under the link's token, deploys them with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report**. The link works as long as the EAS Hosting deployment. |
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only the failed target's record when the run has several; the target is the id the failed job's diagnostics artifact name ends with, and its label comes from the record the capture job already posted. |
A reviewer downloads the report ZIP and drops it on the hosted Viewer; downloading needs read access to the repository.
+9 -16
View File
@@ -4,36 +4,32 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-hero-dark.svg">
<img alt="Explore's Map of a euxy pull request, animated: the screen cards appear row by row, the new /lane-editor/0 marked Added beside the removed /lane-editor and the modified /new-pattern, the transitions between them wipe in, then a click selects /lane-editor/0: a blue ring circles it, its transitions turn blue while the rest fade to hairlines, and the Inspector slides in on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.svg">
<img alt="Explore's Map of a euxy pull request, animated: the screen cards appear row by row, the new About screen marked Added among the modified Patterns screens, the transitions between them wipe in, then a click selects About, its transitions light up and the Inspector slides in on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.svg">
</picture>
**See a real report:** [euxy](https://explore-example--euxy.expo.app/p/rfcoic27ccgnrmzgijubxkmuzmptcrva?platform=ios), a MIDI sequencer, reviewed by Explore. It is redeployed with the current Viewer on every merge to main.
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-compare-dark.svg">
<img alt="The euxy New Pattern sheet wiping from its capture before the pull request to its capture after it: the suggested pattern name and the row of pattern icons differ, and those regions are outlined on the after capture" src="docs/screenshots/readme-compare-light.svg">
<img alt="The euxy Patterns screen wiping from its capture before the pull request to its capture after it: each pattern row's tempo moves out of the subtitle into its own column on the right, then the changed subtitles are outlined" src="docs/screenshots/readme-compare-light.svg">
</picture>
**Compare**: each changed screen before and after, with the changed regions outlined on the after.
**Compare**: each changed screen before and after, with the changed regions outlined.
<table>
<tr>
<td width="50%" valign="top">
<a href="docs/screenshots/readme-screens-light.png">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-screens-dark.png">
<img width="100%" alt="The Screens view of a euxy review showing Changed 7 of All 19: the app/ route tree on the left, and beside it a grid of the changed screens in the same order, each with its route below the screenshot: a red dot for the removed /lane-editor, orange for the modified /new-pattern and /channel-surf, green for the new /lane-editor/0, and Changed in dark under /p and /patterns" src="docs/screenshots/readme-screens-light.png">
<img width="100%" alt="The Screens view of a euxy review: the app/ route tree on the left under Changed 9 and All 19, and a grid of screen cards beside it in the same order, each with its route below the screenshot and a dot before it: green for the new /about, orange for modified screens such as /activity-log, /settings and /patterns, red for the removed /channel-surf" src="docs/screenshots/readme-screens-light.png">
</picture>
</a>
<strong>Screens</strong>: every capture in one grid, or only the changed ones, beside the route tree, with a dot for what changed.
<strong>Screens</strong>: every capture in one grid, beside the route tree, with a dot for what changed.
</td>
<td width="50%" valign="top">
<a href="docs/screenshots/readme-pr-comment-light.png">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-pr-comment-dark.png">
<img width="100%" alt="Explore's GitHub PR comment on a euxy PR: the heading 2 screens changed with a Review in Explore link; a line of links to each device's report (iPhone 17, three iPhone Duo poses and Android) and to the two commits compared; then the changed screens as a list, /tempo with the text it added and the devices it is on, fading out below" src="docs/screenshots/readme-pr-comment-light.png">
<img width="100%" alt="Explore's GitHub PR comment on a euxy PR: a heading with how many screens changed and a Review in Explore link, a line naming each device with a link to its report, and the changed screens as a short list, fading out below them" src="docs/screenshots/readme-pr-comment-light.png">
</picture>
</a>
<strong>A comment on every PR</strong>: with <a href="#set-up-ci">CI</a>, the report links and the added, removed and modified screens.
</td>
</tr>
@@ -45,9 +41,7 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
Paste this into Claude Code, Codex, Cursor, or any tool that can fetch a URL. In the Viewer, **Hand off to AI** fills it in for you:
```text
Review the visual changes in PR #<number> of <owner>/<repo>.
Expo Explore report:
<report link>
Review the visual changes in this PR. Expo Explore report: <report link>
Fetch the link first. It explains the report's JSON API. Go through the changed screens,
compare the before and after screenshots, and tell me which changes look intended and
@@ -304,7 +298,7 @@ platforms:
easProfile: explore-android # android.buildType: apk in eas.json
```
- The workflows run one capture job per platform, and the PR gets one comment that links each platform's report and lists the changed screens of both.
- The workflows run one capture job per platform, and the PR gets one comment with a section per platform.
- A failed platform fails the check; the other platform's report still publishes.
- An Android-only app sets `app.platform: android` with no `platforms` map.
@@ -325,8 +319,7 @@ targets:
- A target takes the `app` fields it does not set, and `device.name` when it is of `app.platform`; a target of another platform sets its own `bundleId` and `easProfile` (an Android one's device defaults to `pixel_7`). `pose` is `closed`, `half-open` or `open`. `label` names it in reports (by default its device and pose).
- Ids are up to 32 lowercase letters, digits and dashes, start with a letter, and are not `base`, `head` or `report`. A config names at most 8 targets. A config with `platforms` has one target per platform, named `ios` and `android`.
- The workflows run one capture job per target. The PR comment links each target's report and says which targets a change is on, and each report links its sibling targets' reports.
- A review runs at most `capture.maxSessions` EAS Simulator sessions at once across its targets (default 5, a typical plan's limit); see the [config reference](docs/quickstart-ci.md#config-reference).
- The workflows run one capture job per target, the PR comment has a section per target, and each report links its sibling targets' reports.
- A target can also set its own `controller` and `simulator` over `capture`'s, such as Android on agent-device beside iOS targets on Argent. `--controller` and `--simulator` override every target's for one run.
- `capture --target duo-open` reviews one target on this machine; `--platform ios` the iOS ones. On your machine a review's targets run at once (at most `--parallel N`), and targets of one platform and EAS profile share each commit's build; in CI each target is its own job. A target that fails outright costs only its own report.
- A device controller that stops answering on one screen costs that route, up to three times per capture: Explore restarts the app, goes on with the next route, and records what happened in `capture-diagnostics/controller-recoveries.jsonl`.
+2 -2
View File
@@ -132,7 +132,7 @@ platforms:
easProfile: explore-android
```
Commands that capture or publish (`source:verify`, `capture:review`, `capture:baseline`, `ci:report`, `ci:publish`) take `--platform ios|android`; with one configured platform it is optional, with two it is required (`PLATFORM_REQUIRED`). `expo-explore config:platforms` prints the configured list as JSON, which the workflows use as their matrix. Artifacts carry the platform (`explore-capture-<run>-<attempt>-android`, `explore-baseline-<sha>-ios`); an iOS job still reuses an older unsuffixed baseline. The PR comment is one list of changed screens that says which platforms each is on, and a hosted preview serves both reports from one link.
Commands that capture or publish (`source:verify`, `capture:review`, `capture:baseline`, `ci:report`, `ci:publish`) take `--platform ios|android`; with one configured platform it is optional, with two it is required (`PLATFORM_REQUIRED`). `expo-explore config:platforms` prints the configured list as JSON, which the workflows use as their matrix. Artifacts carry the platform (`explore-capture-<run>-<attempt>-android`, `explore-baseline-<sha>-ios`); an iOS job still reuses an older unsuffixed baseline. The PR comment has one section per platform, and a hosted preview serves both reports from one link.
### Several devices (targets)
@@ -217,7 +217,7 @@ exploration:
- /c/[channel]
```
An excluded route stays in its neighbors' navigation context (a screen that links to it is still captured when it changes), but neither revision captures it, it is left off the report (the Map, Screens, search and the screen counts), and a change to it gets no before/after comparison. A name that matches no route at either compared revision fails the plan with `EXCLUDE_ROUTE_UNKNOWN`; `doctor` warns about it first. Prefer `parameters` or `setup` when a route does show a screen.
An excluded route stays in its neighbors' navigation context (a screen that links to it is still captured when it changes), but neither revision captures it, it is left off the map and the screen counts, and a change to it gets no before/after comparison. A name that matches no route at either compared revision fails the plan with `EXCLUDE_ROUTE_UNKNOWN`; `doctor` warns about it first. Prefer `parameters` or `setup` when a route does show a screen.
Capture handles iOS's confirmation to open a link in the expected app. After a form submits a password, iOS may offer to save or update it depending on the simulator's AutoFill state; capture declines that prompt with Not Now in both modes, never stores the credential, and records each decision in `capture-diagnostics/system-prompts.jsonl`. Do not script that tap in setup. Include required system-alert handling in setup or app instructions; Explore does not automatically grant application permissions.
+1 -1
View File
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /new-pattern screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(1,4,9,0.6)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#151B23"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#151B23" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCAQ4AfEDASIAAhEBAxEB/8QAHAABAAIDAQEBAAAAAAAAAAAAAAQFAgMGBwEI/8QAXxAAAQMDAQQFBggJCAYHBwMFAQACAwQFEQYSEyExFEFRUpEHImFxgbEVMjM0U2JykhYjQlRVc6HR0gg2dJOUssHhFxg1ZcLwJDdDRIKVsyUmVld1otOD4vEnRWOjw//EABYBAQEBAAAAAAAAAAAAAAAAAAABAv/EABgRAQEBAQEAAAAAAAAAAAAAAAABEUEh/9oADAMBAAIRAxEAPwD8qIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiD1PyJz6Bo7rQHUdokv16rrnDRUtDMB0SGN7mtM0gIw8+ccN4jhx7Vca9o/J/pfy36r/CC0vNqt4Y+is9uYII6iXYjwwloAYzi4kj9vJeceTUhvlF0sSQALvSZJ/XNXTfyj3Nf5adTOa4OBmjwQcj5JiDpf5Q9o0zTaz0Y+mtdFp613KzUlVVst1M1gjD5H7btloG04N6zxOAouiPJporWHlxZYbBc6q66SpYjWzTytLHysYwFzOIacF5Dc4HAn1qb/KIdb5dR+TwXCSXoP4N0AqXU+DI2PbftbOeG1jOMrX5NNW6E0F5d2zWCtrPwTrYHUBqq4YfHvGDLjwHmiQDiRwHqQdNozUmlfLTqq6eT6u0XYLTQTQzi0VdvpGx1FK6Pi0lw+NkDJ6jjHWuA015SH2FtLpJvk00VerhBMaMTVdrZLUVEm2RhzjzOeC9I8nvkvqPIrra66/1XXUEOn7ZDO6gniqWPdXueCGBjQc5LSeB6z2cVx/kRpqWjrNS+WDUEUbqOx7yWlhcfnFdJktaPs7Q9Rc0oMP5TrrBbr9ZtO2ux2O2XO3UYfdX2mlZBE+okDTsYaASGgZGe8vFVNvV4rdQ3etu9xmM9ZWzPnmkP5T3HJ9XPkoSAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICKdabcy5SvjdMItlu1yzlbKW0sqKWpnNS1phJAGPjYQVqKxfa2MtTK7pALnHGxj04Xy52tlBDBI2cS70ZxjkgsNBWex37V1ttuo7v8D2qeTZnrNnOwMEgdgycDaPAZyeS/TemZ9OQ7dF5IvI3HqmnpiY3326buOOZw5lkk3Fw9Rb6l+RF7T5JPKRd9RTWbye3/AF3cNNafi2mU9RQ4ile8nzInzc2tznBORxAPDGA9S1LLpmpcyh8rnkdj0lDUkRx322bt8cTzy25IR5vtLvSF+Y9eWey2DVtytunrv8MWynlLIawNxtjrHYcHhtDgcZC9G8rXlJvFjlvPk8smuK/UunXuY2Worw2SZr2k7cbZebmZAyeXDA4Zz40g9D8jGjWa01VbrSJWwS11XuN+WB5hjbE+V7mg8NotjwCeWV+tmfyZ9ItaA67alJHM9OAz7Nhfk3yJavj0bqy3XYwGpfQVZndTscA+WJ8MkT9jPAuAkyB14X67Z/KR0I5gc431hIyWm0zkjwaQgj/6tGkP0rqb+3j+BV2of5M2njZqw2283yOrbE50Rqp2zxFwGQHMLeIKu/8AWP0F373/AOU1H8CrtQfyk9JMs9WLXS3qtrXxObDE6gkhYXEYBc94Aa3tKD8T6hs76aZ9ZBAGUrmxOds/FjfIza2R6ODsKkV7qO8STzPoYZ2vpmtha/Y4te+NmzkHsyXYVEgIiICIiAiIgIiICIiAiIgIiLine truncated
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /patterns screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(1,4,9,0.6)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#151B23"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#151B23" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCANqAZIDASIAAhEBAxEB/8QAHAABAAICAwEAAAAAAAAAAAAAAAMFBAYBAgcI/8QAWBAAAQMDAQQECwQHBAUKBQQDAQACAwQFERIGEyExFEFR0QcVIjJSU2GBkZKTNFRxsQgjM2OhouEWQmLBJHJ1gtIYNkNVVrKz1OLwFzdzlJUmNThEg8Px/8QAGAEBAQEBAQAAAAAAAAAAAAAAAAEDAgT/xAAdEQEBAAMBAAMBAAAAAAAAAAAAEQECAwQSMUFR/9oADAMBAAIRAxEAPwD5UREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBFs2wdn2aut0kftXeZrbbaZgkdHTRa6ircXACKIHgHHOdTuAAXptz8CuzVB4X9sLRPUXCHZPZS3suVSWva6olbuI37priManOecHHIY9qDwxF6dtdsfspd/B5Dt9sZT19sp4Lj4suNurZxPuXFupkrHhoJaRwII5nhy449DsjsFs/tZc6faXa2K8Wm3UQqIDZ8g3KcgEQNeQQzBJy49nUeQecovVdtdiNjpdktlNsrGa/Z2gvVdJQ1NLXvNTuGscA6eNzWhz2AZyMZzwCu6fYTwZbVWvaaLZ2j2lo4rHbpa2n2jrZR0atdHgBroyxujWT5IB1ezIwg8PREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEReh+C3YDZbaenr7xthtdDZLXb3sjdSwDXW1TneaImYPPB4gO4jl1oPPEX0xUeDTwVMt5kqvB34VrbQacm7vpc7tvrHMy4hvXnR7l414T9iLNsXdaQbP7U0O0druEHSaeaA4ljZnGmVv913A+3gcgckGmIvQPA/4M5PCZtDFao5IY3SF+XzaiyJjG5c4hpBceLQACOJ4ngve/wDkWUn/AGlt3/4qf/ziD5ERfXf/ACLKT/tJbv8A8VP/AOcXgHhU8GtT4P8AaOstGGSvpHfrHQajG5hYx7ZAHZLQQ8Agk4IPEhBoaIiAiIgIiICIiAiIgIiIJaRwZVQucQAHtJJ6uK+jL54QNlLp4afCLQTXyljsW1tqit8F2YdcMM7aeIMc4j+4HBwJ6j2DJXzciD17aipsuwXgiOwlNtBar/d7rdm3GsltMxmp6eBjNLGCTABeSM+zjnqzjbJbPeC7a3wkSOddp9ntkKWGObc3ioa2eqeAAYg9uQ0F2SSMkDlgnh5UiD2HwsNprxe7Vc7xtlsxWWKKojoIbTs1O6R1so+JJjY6NoOA3ieZcR1YxttnqLBsfZ7xS3vwmWLarYQ0M8dssYeZqt0jsmI7osG4e0k+UCME9XV84ogIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgszQ2/pMEfTsxvYS93onsURpaPo1TJ0r9ZHIWxtx57e1YKIMuvp6aDddGqN9qbl3+ErI2a2iuGyV+ob7aZWRV1DKJYXPYHgEdoPAjGQqxEH0HV+HF9u2Lt+1Nr8I21VXttUTaaq01W7dQMx553OjS1mCNJack9mDjwKsq5q+rnq6l+ueeR0sjsAanOOScDgOJ6lCiD1DwD+Eel8HG1ENzqoRPGzeMki3jY3Pje0AlrnEN1AtacOIBGeIX0t/yuNiP+rLz9eg/80vhlEH3N/wArjYj/AKsvP16D/wA0vmbwzeEwbb7WXC7UDRTMrf1Zia9shZCGRsDXOHAuOgk6SQMgZPFeZIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIilhpZ6jO6ie/HMgcB+JQRIsw2qrAzu2fUb3rHlp5YDiSNzOzI5oI0REBERARSw0s9RndRPfjmQOA/Eqc2qLine truncated

Before

Width:  |  Height:  |  Size: 103 KiB

After

Width:  |  Height:  |  Size: 107 KiB

+1 -1
View File
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /new-pattern screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(17,17,17,0.14)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#F6F8FA"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#F6F8FA" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCAQ4AfEDASIAAhEBAxEB/8QAHQABAAEFAQEBAAAAAAAAAAAAAAUCAwQGBwEICf/EAGMQAAEDAwEEBAcHDgoGBwcFAQEAAgMEBREGEiExkQcTQVEUFSJSU2FxFjI1c4GxsggXMzRCcoKSk5ShwdHSGCM2VFVWYnSk4jdDdaKzwiQlRVeV4eMmRmaD0/DxJ0RjZKNl/8QAFgEBAQEAAAAAAAAAAAAAAAAAAAEC/8QAGhEBAQEBAQEBAAAAAAAAAAAAABEBIUECMf/aAAwDAQACEQMRAD8A62iIiiIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIi0npd163QGkJq2Eg3CpPg9I0+eRvcfU0ZPtwO1BhdI/TVYuj97qHBuN1xnwWJwAjzw23fc+ziuF336orXV2ld4JV01qhPCOlhaTj1ufk59mFzWqqp66plqqmV808zy+SR5y5zickkq0iNom6UdbzvLn6qu+T5tS5o5Aqj65etP61Xn87f+1a0iDZfrl60/rVefzt/7U+uXrT+tV5/O3/tWtIg2X65etP61Xn87f8AtT65etP61Xn87f8AtWtIg2X65etP61Xn87f+1Prl60/rVefzt/7VrSINl+uXrT+tV5/O3/tT65etP61Xn87f+1a0iDZfrl60/rVefzt/7U+uXrT+tV5/O3/tWtIg2X65etP61Xn87f8AtVTOk7W0bg5uqrzkd9U8/rWsIg6PZvqgdfWmVpkukdxiHGKrha4H8JuHfpXaejrp/susqmK2XOEWm5ykNjDn5imd3NceBPYD7MlfJ69BLSCCQRvBCD9BUXLegPpFk1ppyS3XGUyXS2bLHvccmaI+9f7dxB9gPaupIoiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiDk/TU/Wsdoutwt92Nms1thjkY6leW1FXIXNBG0DljRn5VIzs1hfdE6dhs10FDHU28S3C5yEvqG4Y3AZk52nZd5XZjOcrP6bWl3Rbfw0Ekws3D4xik9Hgjo8tIIIPiyPd/8sINO6KL5qSv6HXXKmfLeb2Hz9QK2cuMjg7cC5x/WrnSLrDU9p0TYqQRx23Ul9nio5OqdtCmLvflp37+A4nGTg7srD6F/HEHQrmyQwuugkqDTsqNzC/b3ZVzpSsupbjozTt+qKKKe92OpiraumpcuBH3ewN5OCGn2ZQYN+oLp0O3SwXan1Hd7nbq2rZR3KCvnMrXbX+sbngRvPyBbb0nakr4GUOldPzFl+vb+rjkYcGlhHv5iRvGBw9eccFpOrNU0XTPcdOae03DVzQx1jK24zSQuY2mjbxaSRx3n1Zwp2p0b0gUWvLvqe01GnZ3VjWwQG4CVzoIW8GNDcAZO88eHtQX+gysuVRbtQU1yutdc3UV2lpo5qyZ0r9huAN7icd66auM9ALNRiu1G6sNvFvNxqDOGNeJDU7QyW53dXjPHfwXZkBERAREQF80fVTXOSbUtptu1/FU9KZcf2nuwTyaF9Lr5o+qmtckOpLTctn+KqKUw5/tMdnHJwQcQRERBERAREQEREBERAREQEREBERAREQdO+p1uclB0l0sDXYZWQSwvHeNnaH6WhfXC+R/qdbXJcOkulna3LKOCWd57t2yP0uC+uEXBERARYlxrXUMbHti6zaOOPBUT3F8NRBEICRKASc8MoM5FhNr3OuDqTqTgD3+fUlBXurJJWOhMfVnjnigw9X3K62jTldXWS2+M7hCzMVNnG2c7z68DJwN5xhcIvsV7k2arpI6TX6fmnG2200G298TTw2mRbh8ufavpBcu6Line truncated
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /patterns screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(17,17,17,0.14)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#F6F8FA"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#F6F8FA" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCANqAZIDASIAAhEBAxEB/8QAHQABAAEFAQEBAAAAAAAAAAAAAAECAwQFBgcICf/EAFkQAAEDAwICBwQHBAYFCgQDCQEAAgMEBREGEiExBxMUQVFSkSIyYaEVM1NxgZLhCCNisRgkNELR0xZWlJXBJTdDcnN1gqKz8Bdjk9QmNTY4RlV0g4Sy0vH/xAAYAQEBAQEBAAAAAAAAAAAAAAAAAQIDBP/EABoRAQEBAQEBAQAAAAAAAAAAAAARAQIDIQT/2gAMAwEAAhEDEQA/APpxERFEREBERAREQEREBERAREQEREBERARYl0u9uslI6sulfSUFMz3pqmVsbB+LiAuCuH7RnRXbZDHNq6mkcOH9XgmmHqxhHzQekIvKv6UPRP8A6zSf7vqf8tP6UPRP/rNJ/u+p/wAtB6qi8q/pQ9E/+s0n+76n/LT+lD0T/wCs0n+76n/LQeqovKv6UPRP/rNJ/u+p/wAtP6UPRP8A6zSf7vqf8tB6qi8q/pQ9E/8ArNJ/u+p/y0/pQ9E/+s0n+76n/LQeqovKv6UPRP8A6zSf7vqf8tP6UPRP/rNJ/u+p/wAtB6qi8vpv2mOiipeGN1W1hP2lFUMHqY8Lt9O6z03q2IyWG+W65hoy4U07XuZ/1mg5H4hBuUREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBFq9TXK4Wix1NZabTJeK9m1sFFHIIzK9zg0ZceDWjOSe4Aryaz9NOobTofXl91ZTW2W4aauLqCKChDmxPkO1rW5JJI3uHHngIPbUXkdFq/X+jdTaYpNcVFor6DUzzTf1KndC+3VRbubHkuO9p93J48M93HprprLVD7Vqf6F0ZXPudrnbTW9lW5rIrhuIHWtOR7DcknjxAxnOQA7ZF5PZ9Va6030lWLSOqrjZ73HfaSeoD6GmMD6F0TdxyMndGfdBOCT4YwadM9I2trl0s02nb9Z6KzWyutUlxpqPcZKpjWybGmVwO0OOCdoHAEDOcoPWkREBERAXE9LvSdQ9FWkZbzUMbUVkrupoqUnHXSkZ4+DQOJP4cyF2y+MP2wtRT3LpIpbNvPZrVRM2s7usk9pzvxb1Y/BB5NrLXWodfXZ901DcpqyZxOxhOI4R5WN5NH3fjkrQIiIIiICIiAiIgIiICIiAsm3XKttFbFXW+rno6qF26OaCQsew+II4hYyIPtX9nDp2m6RaaTTuopGfT9HH1kc4AaK2IcCcDgHt4ZxzBz3Fe5L83ujTUU+k9f2C8wPLDTVsW/H96Nztr2/i0uH4r9IUUREQEREBEXn/AEn681RpmooLRpHSc15udwY97aqc7KKla3mZH5HLI4Et4Hn3IPQEXzbT9JHSk+vEdL0g9Flyrt3C0sqcb3fZtfhoLu7G/wDFew9GetbxrK11Zv8Apiu09c6Cfs1RDOMxSOxndE7+83iPhxGCeaDsUXBdLnSTH0bWCW6SRyyNjDcMh2h8r3uw1oLgQ0cHEkg8BwHFeEf0y6r/AFcuH+9IP/tEH1oi+TP6ZdV/q5cP96Qf/aL3rou6R6bXunaS7ZfEyrb+7bPtEjXhz2ujJbgOILCQQBkEcAUHcoiICIiAiIgIiICIiAiIgLwGp6ML/qTSPSxZ+xS0lVdL/JXW0zjY2oDHMe0tJ4YdtLc8uK9+RB4pPUak6WdV6LbU6RvNgpNP1QudznuUIiY6oY3DI4eJ6wF2fa8F2t0uut9MWrVF1qKCl1AWTA2S321jhMYzhoEue8E5OM8A74AdsiDxHogq7jBqB9x1Lo3V79U3r2a281tGxlLSsALhDH7ZLIhgAcMuOCe7HS3CxXOT9oK13xlDO62Radlpn1Yb+7bKZiQwnxxxwvSUQEREBERAXxV+19Yprd0ox3NzD1FzoYnsf3FzMsc37wA0/wDiC+1VLine truncated

Before

Width:  |  Height:  |  Size: 113 KiB

After

Width:  |  Height:  |  Size: 109 KiB

+1 -1
View File
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /lane-editor/0 and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.44%{opacity:0;transform:scale(.92)}8.19%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}7.86%{opacity:0;transform:scale(.92)}11.61%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}7.19%{opacity:0;transform:scale(.92)}10.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}9.27%{opacity:0;transform:scale(.92)}13.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}4.77%{opacity:0;transform:scale(.92)}8.52%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}8.19%{opacity:0;transform:scale(.92)}11.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}9.60%{opacity:0;transform:scale(.92)}13.35%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}9.94%{opacity:0;transform:scale(.92)}13.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}10.27%{opacity:0;transform:scale(.92)}14.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}10.61%{opacity:0;transform:scale(.92)}14.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}6.85%{opacity:0;transform:scale(.92)}10.60%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}10.94%{opacity:0;transform:scale(.92)}14.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c12{transform-origin:0 0;animation:c12 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c12{0.00%{opacity:0;transform:scale(.92)}11.27%{opacity:0;transform:scale(.92)}15.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c13{transform-origin:0 0;animation:c13 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c13{0.00%{opacity:0;transform:scale(.92)}11.61%{opacity:0;transform:scale(.92)}15.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c14{transform-origin:0 0;animation:c14 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c14{0.00%{opacity:0;transform:scale(.92)}7.52%{opacity:0;transform:scale(.92)}11.27%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}13.75%{clip-path:inset(0 0 100% 0)}24.58%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(853.5px,575.2px)}28.75%{opacity:0;transform:translate(853.5px,575.2px)}30.42%{opacity:1;transform:translate(853.5px,575.2px)}38.75%{opacity:1;transform:translate(593.5px,355.2px)}39.58%{opacity:1;transform:translate(593.5px,355.2px) scale(.82)}40.83%{opacity:1;transform:translate(593.5px,355.2px)}48.75%{opacity:0;transform:translate(593.5px,355.2px)}100.00%{opacity:0;transform:translate(593.5px,355.2px)}}.sel{animation:sel 12s linear infinite}@keyframes sel{0.00%{opacity:0}39.58%{opacity:0}40.42%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}40.00%{opacity:0;transform:translateX(48px)}45.00%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{oLine truncated
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /about and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.33%{opacity:0;transform:scale(.92)}8.08%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}4.00%{opacity:0;transform:scale(.92)}7.75%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}4.67%{opacity:0;transform:scale(.92)}8.42%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}6.08%{opacity:0;transform:scale(.92)}9.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}6.41%{opacity:0;transform:scale(.92)}10.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}6.75%{opacity:0;transform:scale(.92)}10.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}7.08%{opacity:0;transform:scale(.92)}10.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}3.66%{opacity:0;transform:scale(.92)}7.41%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}7.41%{opacity:0;transform:scale(.92)}11.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}7.75%{opacity:0;transform:scale(.92)}11.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}8.08%{opacity:0;transform:scale(.92)}11.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}8.42%{opacity:0;transform:scale(.92)}12.17%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}10.83%{clip-path:inset(0 0 100% 0)}21.67%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(978.5px,714.0px)}25.83%{opacity:0;transform:translate(978.5px,714.0px)}27.50%{opacity:1;transform:translate(978.5px,714.0px)}35.83%{opacity:1;transform:translate(718.5px,505.2px)}36.67%{opacity:1;transform:translate(718.5px,505.2px) scale(.82)}37.92%{opacity:1;transform:translate(718.5px,505.2px)}45.83%{opacity:0;transform:translate(718.5px,505.2px)}100.00%{opacity:0;transform:translate(718.5px,505.2px)}}.sel{animation:sel 12s ease-out infinite}@keyframes sel{0.00%{opacity:0}36.67%{opacity:0}39.17%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}37.08%{opacity:0;transform:translateX(48px)}42.08%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{opacity:0;animation:cover 12s linear infinite}@keyframes cover{0.00%{opacity:1}1.67%{opacity:0}94.17%{opacity:0}100.00%{opacity:1}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><image id="empty" width="1376" height="774" href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAALine truncated

Before

Width:  |  Height:  |  Size: 1.2 MiB

After

Width:  |  Height:  |  Size: 1.4 MiB

+1 -1
View File
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /lane-editor/0 and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.44%{opacity:0;transform:scale(.92)}8.19%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}7.86%{opacity:0;transform:scale(.92)}11.61%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}7.19%{opacity:0;transform:scale(.92)}10.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}9.27%{opacity:0;transform:scale(.92)}13.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}4.77%{opacity:0;transform:scale(.92)}8.52%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}8.19%{opacity:0;transform:scale(.92)}11.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}9.60%{opacity:0;transform:scale(.92)}13.35%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}9.94%{opacity:0;transform:scale(.92)}13.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}10.27%{opacity:0;transform:scale(.92)}14.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}10.61%{opacity:0;transform:scale(.92)}14.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}6.85%{opacity:0;transform:scale(.92)}10.60%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}10.94%{opacity:0;transform:scale(.92)}14.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c12{transform-origin:0 0;animation:c12 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c12{0.00%{opacity:0;transform:scale(.92)}11.27%{opacity:0;transform:scale(.92)}15.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c13{transform-origin:0 0;animation:c13 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c13{0.00%{opacity:0;transform:scale(.92)}11.61%{opacity:0;transform:scale(.92)}15.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c14{transform-origin:0 0;animation:c14 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c14{0.00%{opacity:0;transform:scale(.92)}7.52%{opacity:0;transform:scale(.92)}11.27%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}13.75%{clip-path:inset(0 0 100% 0)}24.58%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(853.5px,575.2px)}28.75%{opacity:0;transform:translate(853.5px,575.2px)}30.42%{opacity:1;transform:translate(853.5px,575.2px)}38.75%{opacity:1;transform:translate(593.5px,355.2px)}39.58%{opacity:1;transform:translate(593.5px,355.2px) scale(.82)}40.83%{opacity:1;transform:translate(593.5px,355.2px)}48.75%{opacity:0;transform:translate(593.5px,355.2px)}100.00%{opacity:0;transform:translate(593.5px,355.2px)}}.sel{animation:sel 12s linear infinite}@keyframes sel{0.00%{opacity:0}39.58%{opacity:0}40.42%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}40.00%{opacity:0;transform:translateX(48px)}45.00%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{oLine truncated
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /about and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.33%{opacity:0;transform:scale(.92)}8.08%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}4.00%{opacity:0;transform:scale(.92)}7.75%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}4.67%{opacity:0;transform:scale(.92)}8.42%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}6.08%{opacity:0;transform:scale(.92)}9.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}6.41%{opacity:0;transform:scale(.92)}10.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}6.75%{opacity:0;transform:scale(.92)}10.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}7.08%{opacity:0;transform:scale(.92)}10.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}3.66%{opacity:0;transform:scale(.92)}7.41%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}7.41%{opacity:0;transform:scale(.92)}11.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}7.75%{opacity:0;transform:scale(.92)}11.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}8.08%{opacity:0;transform:scale(.92)}11.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}8.42%{opacity:0;transform:scale(.92)}12.17%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}10.83%{clip-path:inset(0 0 100% 0)}21.67%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(978.5px,714.0px)}25.83%{opacity:0;transform:translate(978.5px,714.0px)}27.50%{opacity:1;transform:translate(978.5px,714.0px)}35.83%{opacity:1;transform:translate(718.5px,505.2px)}36.67%{opacity:1;transform:translate(718.5px,505.2px) scale(.82)}37.92%{opacity:1;transform:translate(718.5px,505.2px)}45.83%{opacity:0;transform:translate(718.5px,505.2px)}100.00%{opacity:0;transform:translate(718.5px,505.2px)}}.sel{animation:sel 12s ease-out infinite}@keyframes sel{0.00%{opacity:0}36.67%{opacity:0}39.17%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}37.08%{opacity:0;transform:translateX(48px)}42.08%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{opacity:0;animation:cover 12s linear infinite}@keyframes cover{0.00%{opacity:1}1.67%{opacity:0}94.17%{opacity:0}100.00%{opacity:1}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><image id="empty" width="1376" height="774" href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAALine truncated

Before

Width:  |  Height:  |  Size: 1.1 MiB

After

Width:  |  Height:  |  Size: 1.4 MiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 149 KiB

After

Width:  |  Height:  |  Size: 151 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 147 KiB

After

Width:  |  Height:  |  Size: 147 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 157 KiB

After

Width:  |  Height:  |  Size: 169 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 167 KiB

After

Width:  |  Height:  |  Size: 179 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 315 KiB

After

Width:  |  Height:  |  Size: 640 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 316 KiB

After

Width:  |  Height:  |  Size: 642 KiB

+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "@expo/explore",
"version": "0.20.2",
"version": "0.20.0-next.0",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@expo/explore",
"version": "0.20.2",
"version": "0.20.0-next.0",
"license": "MIT",
"dependencies": {
"@expo/repack-app": "0.10.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/explore",
"version": "0.20.2",
"version": "0.20.0-next.0",
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
"license": "MIT",
"type": "module",
+8 -30
View File
@@ -25,40 +25,19 @@ function keyframes(name, loop, frames) {
return `@keyframes ${name}{${frames.map(([at, css]) => `${((at / loop) * 100).toFixed(2)}%{${css}}`).join("")}}`;
}
/**
* The Map card of `route`: the screenshot button of the node whose id is that route's surface in `review`. The button
* is named after the screen's title, which is not the route when the report has plain titles.
*/
export function mapCard(page, review, route) {
const surface = review.surfaces.find(s => (s.head ?? s.base)?.route === route && s.colorScheme !== "dark");
if (!surface) throw new Error(`The report has no screen at ${route}.`);
return page.locator(`.react-flow__node-screen[data-id="${surface.id}"] .screen-screenshot-target`);
}
/**
* Photographs the hero's states from a Viewer page whose Map has its camera set and nothing selected: the Map without
* its screens, without its edges, and whole; then it clicks `select`, which opens the Inspector without moving the
* camera, and photographs that (`card` is its screenshot button, from mapCard). Returns the frames and where each screen card, the Inspector and the selected card are.
* camera, and photographs that. Returns the frames and where each screen card, the Inspector and the selected card are.
*/
export async function captureHeroFrames(page, { select, card: target, viewport }) {
export async function captureHeroFrames(page, { select, viewport }) {
const shoot = () => page.screenshot({ type: "jpeg", quality: JPEG_QUALITY });
// Park the pointer on bare canvas, found once the camera is set: over a card it takes a grey ring and darkens the
// card's transitions, over a transition it darkens that one, and over a control it can raise a tooltip.
const rest = await page.evaluate(({ width, height }) => {
for (let y = height - 120; y > 120; y -= 20) for (let x = 40; x < width - 40; x += 20) {
if (document.elementFromPoint(x, y)?.classList.contains("react-flow__pane")) return { x, y };
}
return null;
}, viewport);
if (!rest) throw new Error("The hero's Map has no bare canvas to park the pointer on.");
const neutral = async () => {
await page.mouse.move(rest.x, rest.y);
await page.waitForTimeout(200);
if (await page.locator(".canvas-hovering, .graph-node-hover-subject").count()) throw new Error("The pointer at rest still hovers the Map.");
};
const neutral = () => page.mouse.move(viewport.width - 4, viewport.height - 4);
const rect = locator => locator.boundingBox().then(b => b && { x: Math.round(b.x), y: Math.round(b.y), width: Math.round(b.width), height: Math.round(b.height) });
const camera = () => page.locator(".react-flow__viewport").evaluate(el => el.style.transform);
const target = page.locator(`.screen-screenshot-target[title="${select}"]`);
// A card under the pointer dims the others and highlights its edges; let that fade before the first frame.
await neutral();
await page.waitForTimeout(1000);
const at = await camera();
@@ -145,9 +124,8 @@ export function heroSvg(frames, theme, alt) {
]));
defs.push(`<clipPath id="canvas"><rect x="0" y="0" width="${p.x}" height="${v.height}"/></clipPath>`);
defs.push(`<clipPath id="panel"><rect ${box(p)}/></clipPath>`);
// The selection lands as the Viewer draws it, at once: a ring and its transitions in the accent, nothing fading.
css.push(`.sel{animation:sel ${LOOP}s linear infinite}`);
css.push(keyframes("sel", LOOP, [[0, "opacity:0"], [CLICK + 0.1, "opacity:0"], [CLICK + 0.2, "opacity:1"], [LOOP, "opacity:1"]]));
css.push(`.sel{animation:sel ${LOOP}s ease-out infinite}`);
css.push(keyframes("sel", LOOP, [[0, "opacity:0"], [CLICK + 0.1, "opacity:0"], [CLICK + 0.4, "opacity:1"], [LOOP, "opacity:1"]]));
css.push(`.insp{animation:insp ${LOOP}s cubic-bezier(.2,.8,.2,1) infinite}`);
css.push(keyframes("insp", LOOP, [[0, "opacity:0;transform:translateX(48px)"], [CLICK + 0.15, "opacity:0;transform:translateX(48px)"], [CLICK + 0.75, "opacity:1;transform:translateX(0)"], [LOOP, "opacity:1;transform:translateX(0)"]]));
layers.push(`<use class="sel" href="#inspecting" clip-path="url(#canvas)"/>`);
@@ -259,7 +237,7 @@ export async function compareSvg(browser, report, surface, theme, alt) {
+ `<g class="divider"><rect x="${x - 1.5}" y="${y}" width="3" height="${PH}" fill="${t.accent}"/><circle cx="${x}" cy="${y + PH / 2}" r="13" fill="${t.accent}"/>`
+ `<path d="M${x - 5} ${y + PH / 2 - 4}l-3 4l3 4M${x + 5} ${y + PH / 2 - 4}l3 4l-3 4" stroke="#fff" stroke-width="1.8" fill="none" stroke-linecap="round" stroke-linejoin="round"/></g>`
+ `<g class="regions">${regions}</g>`
+ label("before-label", "end", x - 44, "Before", `${pullRequest.base.ref} · ${pullRequest.base.sha.slice(0, 7)}`)
+ label("before-label", "end", x - 44, "Before", `${pullRequest.base.ref} ·${pullRequest.base.sha.slice(0, 7)}`)
+ label("after-label", "start", x + PW + 44, "After", `PR #${pullRequest.number} · ${pullRequest.head.sha.slice(0, 7)}`, `${count} changed region${count === 1 ? "" : "s"}`)
+ "</g></svg>";
}
+15 -28
View File
@@ -13,14 +13,12 @@
// It becomes readme-compare-*.svg, its before capture wiping to its after capture
// --pr a GitHub PR URL whose Explore comment becomes readme-pr-comment-light.png (public repository): the comment
// at its own size on a soft stage, cut off with a fade after the list of changed screens
// --only the pictures to write, comma-separated, of hero, compare, screens and pr-comment; default all of them (the
// PR comment only with --pr). --only pr-comment needs no --report
import { chromium } from "@playwright/test";
import { readFile, writeFile } from "node:fs/promises";
import { parseArgs } from "node:util";
import { fileURLToPath } from "node:url";
import { startReportViewer } from "../test/ci/lib/report-viewer.mjs";
import { captureHeroFrames, compareSurface, compareSvg, heroSvg, mapCard, openReport } from "./readme-animations.mjs";
import { captureHeroFrames, compareSurface, compareSvg, heroSvg, openReport } from "./readme-animations.mjs";
const { values: args } = parseArgs({
options: {
@@ -29,36 +27,25 @@ const { values: args } = parseArgs({
compare: { type: "string", default: "patterns" },
pr: { type: "string" },
zoom: { type: "string", default: "73" },
only: { type: "string" },
},
});
const PICTURES = ["hero", "compare", "screens", "pr-comment"];
const only = args.only?.split(",").map(name => name.trim()).filter(Boolean);
const unknown = only?.filter(name => !PICTURES.includes(name)) ?? [];
if (unknown.length) {
console.error(`Unknown --only ${unknown.join(", ")}; pass some of ${PICTURES.join(", ")}.`);
process.exit(2);
}
const wanted = name => !only || only.includes(name);
const fromReport = PICTURES.filter(name => name !== "pr-comment").some(wanted);
if (fromReport && !args.report) {
if (!args.report) {
console.error("Pass --report <review report zip>. See skills/readme-refresh/SKILL.md for where the euxy report comes from.");
process.exit(2);
}
const out = fileURLToPath(new URL("../docs/screenshots/", import.meta.url));
const SHOTS = [
{ name: "hero", file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: page => page.getByRole("button", { name: "Fit canvas" }), select: args.select, zoom: Number(args.zoom), animated: true },
// Screens shows its Changed filter, so the added, removed and modified dots are all in view wherever the tree sorts them.
{ name: "screens", file: "readme-screens", hash: "#/screens", viewport: { width: 1760, height: 1000 }, click: page => page.locator(".screens-chip", { hasText: "Changed" }) },
].filter(shot => wanted(shot.name));
{ file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: "Fit canvas", select: args.select, zoom: Number(args.zoom), animated: true },
{ file: "readme-screens", hash: "#/screens", viewport: { width: 1760, height: 1000 } },
];
const bytes = fromReport ? await readFile(args.report) : undefined;
const report = bytes && await openReport(bytes);
const { server, url } = bytes ? await startReportViewer({ bytes, watch: false }) : {};
const bytes = await readFile(args.report);
const report = await openReport(bytes);
const { server, url } = await startReportViewer({ bytes, watch: false });
const browser = await chromium.launch();
try {
for (const theme of wanted("compare") ? ["light", "dark"] : []) {
for (const theme of ["light", "dark"]) {
const surface = compareSurface(report.review, args.compare, theme);
const path = `${out}readme-compare-${theme}.svg`;
await writeFile(path, await compareSvg(browser, report, surface, theme,
@@ -73,20 +60,20 @@ try {
await page.waitForSelector(".react-flow__node, .compare-stage, .screens-cell", { timeout: 60_000 });
await page.waitForTimeout(4000);
if (shot.click) {
await shot.click(page).click();
await page.getByRole("button", { name: shot.click }).click();
await page.mouse.move(400, shot.viewport.height - 30);
await page.waitForTimeout(1500);
}
if (shot.select && !shot.animated) {
// Selecting a screen opens the Inspector without moving the fitted camera. The animated hero selects it last.
await mapCard(page, report.review, shot.select).click();
await page.locator(`.screen-screenshot-target[title="${shot.select}"]`).click();
await page.mouse.move(400, shot.viewport.height - 30);
await page.waitForTimeout(1500);
}
if (shot.zoom) {
// Zoom around the selected screen with the wheel, which keeps it under the pointer, then pan it left and up, clear
// of the minimap and the bottom bar. The camera stops at the first wheel step past the zoom asked for.
const box = await mapCard(page, report.review, shot.select).boundingBox();
const box = await page.locator(`.screen-screenshot-target[title="${shot.select}"]`).boundingBox();
await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2);
for (let step = 0; step < 60; step++) {
if (Number((await page.locator(".zoom-button span").first().textContent()).replace("%", "")) >= shot.zoom) break;
@@ -101,14 +88,14 @@ try {
}
const path = `${out}${shot.file}-${theme}.${shot.animated ? "svg" : "png"}`;
if (shot.animated) {
const frames = await captureHeroFrames(page, { select: shot.select, card: mapCard(page, report.review, shot.select), viewport: shot.viewport });
const frames = await captureHeroFrames(page, { select: shot.select, viewport: shot.viewport });
await writeFile(path, heroSvg(frames, theme,
`Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects ${shot.select} and the Inspector opens on it`));
} else await page.screenshot({ path });
console.log(path);
await context.close();
}
for (const theme of args.pr && wanted("pr-comment") ? ["light", "dark"] : []) {
for (const theme of args.pr ? ["light", "dark"] : []) {
// Signed-out github.com follows prefers-color-scheme.
const context = await browser.newContext({ viewport: { width: 1000, height: 1400 }, deviceScaleFactor: 2, colorScheme: theme });
const page = await context.newPage();
@@ -135,7 +122,7 @@ try {
}
} finally {
await browser.close();
await server?.close?.();
await server.close?.();
}
/**
+7 -7
View File
@@ -12,8 +12,8 @@ This is a repository-maintenance skill (it is not shipped in the npm package; `s
The README's screenshots and its live example (`https://explore-example--euxy.expo.app/p/<token>`, deployed by `.github/workflows/example-report.yml`) must show the same report. The example serves the `viewer-preview-fixtures` release, the same reports every pull request's Viewer preview uses, so start there:
```sh
gh release download viewer-preview-fixtures --pattern reports.json --output - | jq -r '.[0] | "\(.target) \(.source)"' # e.g. iphone brentvatne/euxy#163
mkdir -p ~/euxy-report && gh release download viewer-preview-fixtures --pattern iphone.zip --dir ~/euxy-report --clobber
gh release download viewer-preview-fixtures --pattern reports.json --output - | jq -r '.[0].source' # e.g. brentvatne/euxy#154
mkdir -p ~/euxy-report && gh release download viewer-preview-fixtures --pattern ios.zip --dir ~/euxy-report --clobber
```
Keep those fixtures when their euxy PR still shows a real change (an added or removed screen, modified screens with outlined regions). To move to a newer euxy PR, open its Explore comment and follow **iOS report** to the hosted link `https://euxy-explore--<id>.expo.app/p/<token>`. Then refresh the fixtures from that link and download them again:
@@ -28,13 +28,13 @@ Do not pick a same-tree demo PR, where every change is noise. The refreshed fixt
```sh
npm ci
node scripts/readme-screenshots.mjs --report ~/euxy-report/iphone.zip --select /lane-editor/0 --compare new-pattern --pr https://github.com/brentvatne/euxy/pull/<n>
node scripts/readme-screenshots.mjs --report ~/euxy-report/ios.zip --select /about --compare patterns --pr https://github.com/brentvatne/euxy/pull/<n>
```
- `--select` is the route the hero's pointer clicks on the Map (the Inspector opens on it): choose an added or clearly modified screen. The script zooms in around it, so it must be a screen the Map shows.
- `--compare` is the key in the Viewer's `#/compare/<key>` URL for a **modified** screen with outlined regions (open the report, click the screen in Compare, copy the key): the route without its slash. The script fails if the report has no visually modified screen at that route.
- `--pr` screenshots the Explore comment on that PR: the fixtures' `source`, or a newer euxy PR when that comment predates the current layout. `--only pr-comment --pr <url>` rewrites only the comment pictures (it needs no `--report`); `--only` takes any of `hero`, `compare`, `screens` and `pr-comment`. Headless Chromium needs a colour emoji font for the result glyphs (`sudo apt-get install fonts-noto-color-emoji` on Debian/Ubuntu); a comment with hollow boxes where 🟩 should be is not acceptable.
- The script serves the report through the Viewer's Vite dev server, so no build is needed. It writes a `-light` and a `-dark` file for every picture (the PR comment too: signed-out github.com follows `prefers-color-scheme`). The README shows each pair with `<picture>`: a `<source media="(prefers-color-scheme: dark)">` for the dark file and an `<img>` with the alt text and the light file, which is what GitHub Mobile shows (it ignores the dark source), so the light file is the one that must always be right. The Screens and PR comment pictures, shown at half the column, are each wrapped in an `<a>` to their light PNG so a reader can open them full size; GitHub links a plain Markdown image itself, but not a `<picture>`.
- `--pr` screenshots the Explore comment on that PR: the fixtures' `source`. Headless Chromium needs a colour emoji font for the result glyphs (`sudo apt-get install fonts-noto-color-emoji` on Debian/Ubuntu); a comment with hollow boxes where 🟩 should be is not acceptable.
- The script serves the report through the Viewer's Vite dev server, so no build is needed. It writes a `-light` and a `-dark` file for every picture (the PR comment too: signed-out github.com follows `prefers-color-scheme`). The README shows each pair with `<picture>`: a `<source media="(prefers-color-scheme: dark)">` for the dark file and an `<img>` with the alt text and the light file, which is what GitHub Mobile shows (it ignores the dark source), so the light file is the one that must always be right.
Two of the pictures are animated SVGs, built by `scripts/readme-animations.mjs` in the same run; there is nothing else to run when the screenshots change:
@@ -53,7 +53,7 @@ npx @expo/explore reports list # your sa
export EXPLORE_CACHE_DIR=$(mktemp -d) # a scratch store for the image, not your own runs
cd ~/code/euxy # inside euxy, so the commit messages are found
npx @expo/explore reports add ~/.cache/expo-explore/reports/<that id>/ios.zip
npx @expo/explore reports add ~/euxy-report/iphone.zip # the PR report from step 1
npx @expo/explore reports add ~/euxy-report/ios.zip # the PR report from step 1
npx @expo/explore reports add <an explore:binary report directory> # an exploration, so all three kinds show
cd - && npm run build:cli && node scripts/readme-reports-rows.mjs > /tmp/reports-rows.html
```
@@ -61,7 +61,7 @@ cd - && npm run build:cli && node scripts/readme-reports-rows.mjs > /tmp/reports
- The script renders the picker as the CLI draws it (96 columns, the newest run selected) and writes the terminal body as HTML: each coloured piece is exactly its characters wide, so columns line up, and the wordmark is drawn as cell rectangles, since a design tool's font does not draw `█▀▄` cell for cell.
- In Paper, replace the frame named "Terminal" inside each artboard's window with that HTML, check both artboards in a screenshot (crisp wordmark, aligned columns, the selected row highlighted to the end, coloured counts), and export both at 2x as `readme-reports-light.png` and `readme-reports-dark.png`. The window's title bar reads `npx @expo/explore reports`, as people run it.
Look at every PNG you produced before committing, light and dark: the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links, the line of device links and the list of changed screens. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
Look at every PNG you produced before committing, light and dark: the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links and result glyphs. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
## 3. Pass over the content as a first-time user
+8 -62
View File
@@ -5,7 +5,6 @@
* injected, so the translation is tested against recorded Argent output.
*/
import { CONTROLLER_SESSION } from "./common.js";
import { INPUT_METHOD_PACKAGES, KEYBOARD_WINDOW_IDENTIFIERS } from "./keyboard.js";
import type { DecodedFrame } from "../shared/png-evidence.js";
export type ArgentPlatform = "ios" | "android";
@@ -89,7 +88,7 @@ export function parseCommand(argv: readonly string[]): { positional: string[]; f
}
type ArgentNode = { role?: string; type?: string; label?: string; identifier?: string; value?: string; contentDescription?: string; disabled?: boolean;
frame?: Rect; traits?: string[]; hidden?: boolean; selected?: boolean; focused?: boolean; password?: boolean; bundleId?: string; children?: ArgentNode[] };
frame?: Rect; traits?: string[]; hidden?: boolean; selected?: boolean; password?: boolean; bundleId?: string; children?: ArgentNode[] };
export type ArgentTree = { schemaVersion?: number; source?: string; screen?: { width: number; height: number }; roots?: ArgentNode[];
truncated?: boolean; alertVisible?: boolean; keyboardVisible?: boolean; foregroundApp?: string };
@@ -138,11 +137,7 @@ export function snapshotFromTree(tree: ArgentTree, platform: ArgentPlatform, gen
if (root || !node.frame || ![node.frame.x, node.frame.y, node.frame.width, node.frame.height].every(finite)) return clip;
return clip && intersect(node.frame, clip);
};
const keyboard = platform === "ios" ? keyboardWindows(roots) : new Set<ArgentNode>();
/** `owner` marks every node of a window that is the system keyboard's, as agent-device marks an input method's nodes. */
type Owner = { bundleId?: string; systemKeyboard?: true };
const visit = (node: ArgentNode, depth: number, parentIndex: number | undefined, appRoot: boolean, clip: Rect | undefined, root: boolean, owner: Owner) => {
if (keyboard.has(node)) owner = { ...owner, systemKeyboard: true };
const visit = (node: ArgentNode, depth: number, parentIndex: number | undefined, appRoot: boolean, clip: Rect | undefined, root: boolean) => {
const frame = node.frame;
const inner = clipOf(node, clip, root);
const rect = frame && [frame.x, frame.y, frame.width, frame.height].every(finite) ? toPoints(frame) : undefined;
@@ -164,42 +159,19 @@ export function snapshotFromTree(tree: ArgentTree, platform: ArgentPlatform, gen
rect: appRoot ? { x: 0, y: 0, width: screen.width, height: screen.height } : rect,
...(label ? { label } : {}), ...(node.identifier ? { identifier: node.identifier } : {}),
...(node.value !== undefined ? { value: node.value } : {}), enabled, hittable: enabled && visible && !appRoot,
...(visible ? {} : { visible: false }), ...(node.selected || traits.includes("selected") ? { selected: true } : {}),
// The field with the keyboard focus, as agent-device marks it, so capture can wait for the keyboard it raises.
...(node.focused === true || traits.includes("isEditing") ? { focused: true } : {}),
...owner });
...(visible ? {} : { visible: false }), ...(node.selected || traits.includes("selected") ? { selected: true } : {}) });
refs[ref] = { rect: appRoot ? { x: 0, y: 0, width: screen.width, height: screen.height } : rect, type,
...(node.value !== undefined ? { value: node.value } : {}), ...(type === "SecureTextField" ? { secure: true } : {}) };
}
for (const child of node.children ?? []) visit(child, depth + 1, index, false, inner, false, owner);
for (const child of node.children ?? []) visit(child, depth + 1, index, false, inner, false);
};
for (const root of roots) {
const isAppRoot = platform === "ios" ? root.type === "Application" || nodes.length === 0 : root.bundleId === app;
// An Android input method's window names its package on each node, as agent-device's do, which marks the keyboard.
const inputMethod = platform === "android" && root.bundleId && INPUT_METHOD_PACKAGES.has(root.bundleId) ? root.bundleId : undefined;
visit(root, 0, undefined, isAppRoot, { x: 0, y: 0, width: 1, height: 1 }, true, inputMethod ? { bundleId: inputMethod } : {});
visit(root, 0, undefined, isAppRoot, { x: 0, y: 0, width: 1, height: 1 }, true);
}
return { nodes, refs, screen: { width: screen.width, height: screen.height } };
}
/**
* The windows iOS draws the software keyboard in. Argent lists each window as a child of its root, the app's first. A
* later window is the keyboard's when it holds XCTest's `Keyboard` element, which no app can give itself; an identifier
* never decides it alone, since an app can set any identifier on its own views (a second window of the app's with a
* `testID="inputView"` stays the app's). While such a window is up, UIKit also hosts the keyboard's input view
* placeholder in a window of its own: a later window whose only named node is an `inputView` belongs to it too.
*/
function keyboardWindows(roots: readonly ArgentNode[]): Set<ArgentNode> {
const holds = (node: ArgentNode, test: (node: ArgentNode) => boolean): boolean => test(node) || (node.children ?? []).some(child => holds(child, test));
const later = roots.flatMap(root => (root.children ?? []).slice(1));
const keyboard = later.filter(window => holds(window, node => node.type === "Keyboard"));
if (!keyboard.length) return new Set();
const named = (node: ArgentNode) => Boolean(node.label?.trim() || node.contentDescription?.trim() || node.value !== undefined
|| (node.identifier && !KEYBOARD_WINDOW_IDENTIFIERS.has(node.identifier)));
const placeholders = later.filter(window => !keyboard.includes(window) && holds(window, node => node.identifier === "inputView") && !holds(window, named));
return new Set([...keyboard, ...placeholders]);
}
function intersect(a: Rect, b: Rect): Rect | undefined {
const x = Math.max(a.x, b.x), y = Math.max(a.y, b.y);
const right = Math.min(a.x + a.width, b.x + b.width), bottom = Math.min(a.y + a.height, b.y + b.height);
@@ -244,21 +216,6 @@ const KEYBOARD_DISMISS_LABELS = ["Hide keyboard", "Dismiss keyboard", "Done"];
const KEYBOARD_TOP = 0.4;
const ALERT_PREFERRED_BUTTONS = ["Open", "OK", "Allow", "Allow While Using App", "Continue"];
const READ_TOOLS = new Set(["ui-tree", "list-devices", "screenshot", "foreground-app", "await-screen-idle", "describe"]);
/**
* Argent 0.29's answer when a service a tool depends on (the device's simulator-server, its accessibility service) did
* not start: the registry resolves a tool's services before it calls the tool, and wraps a start failure as
* "[Tool:<id>] Service dependency failed: …", so the tool itself never ran and resending it is safe, a UI action too.
* The tools the bridge sends that resolve a service while they run (keyboard, fill, restart-app, screen-recording-start)
* resolve it before they act, and run-sequence answers a step's failure in its result rather than raising it. A failed
* start leaves the service in the registry's ERROR state, so the next call starts it afresh.
*/
const SERVICE_DEPENDENCY_FAILED = "Service dependency failed:";
/**
* In brentvatne/euxy#172 (review run 39348956443) capture restarted SpringBoard and folded the iPhone Duo open again 8 s
* later; that fold's simulator-server did not become ready within Argent's 30 s, and the whole target failed. The resend
* comes after a pause, so a device still coming back from the restart has the time it needs.
*/
const DEPENDENCY_RETRY_DELAYS_MS = [3_000, 6_000] as const;
const SPRINGBOARD = "com.apple.springboard";
const ANDROID_SYSTEM_UI = "com.android.systemui";
const OPEN_IN_APP_PROMPT = /^Open in “.+”\?$/;
@@ -342,23 +299,14 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
const { positional, flags } = parseCommand(rest);
const bundleFlag = typeof flags["bundle-id"] === "string" ? flags["bundle-id"] : context.bundleId;
/**
* Reads are resent after a transport failure (they change nothing); a UI action is sent once, after a health check.
* Any tool, a UI action too, is resent when Argent could not start a service it depends on, which it raises before
* the tool runs (see SERVICE_DEPENDENCY_FAILED).
*/
/** Reads are resent after a transport failure (they change nothing); a UI action is sent once, after a health check. */
const call = async (tool: string, args: Record<string, unknown> = {}, options?: { out?: string }): Promise<Record<string, unknown>> => {
// Tools that name devices their own way (or none) take no udid.
const withDevice = tool === "list-devices" || tool === "stop-all-simulator-servers" ? args : { udid: state.udid, ...args };
for (let readRetry = 0, dependencyRetry = 0; ;) {
for (let attempt = 0; ; attempt++) {
try { return record(await context.call(tool, withDevice, options)); }
catch (error) {
if (error instanceof ArgentCallError && error.message.includes(`[Tool:${tool}] ${SERVICE_DEPENDENCY_FAILED}`)
&& dependencyRetry < DEPENDENCY_RETRY_DELAYS_MS.length) {
await context.sleep(DEPENDENCY_RETRY_DELAYS_MS[dependencyRetry++]!);
continue;
}
if (READ_TOOLS.has(tool) && readRetry < 2) { await context.sleep(1_000 * ++readRetry); continue; }
if (READ_TOOLS.has(tool) && attempt < 2) { await context.sleep(1_000 * (attempt + 1)); continue; }
throw error;
}
}
@@ -466,9 +414,7 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
converted.nodes.push({ depth: 1, index: converted.nodes.length, parentIndex: 0, type: "Alert", ref: `e${converted.nodes.length + 1}`,
rect: { x: 0, y: 0, width: converted.screen.width, height: converted.screen.height }, label: "System alert", enabled: true, hittable: false });
}
// Whether a keyboard shows, which Argent's Android tree does not hold: the input method's window is not in it.
return success({ nodes: converted.nodes, truncated: current.truncated === true, refsGeneration: state.generation,
...(typeof current.keyboardVisible === "boolean" ? { keyboardVisible: current.keyboardVisible } : {}),
...(current.foregroundApp ? { appBundleId: current.foregroundApp, appName: current.foregroundApp } : {}),
snapshotQuality: { state: "healthy", backend: "argent" } });
}
+4 -8
View File
@@ -5,7 +5,6 @@ import type {
ElementRole,
InputElement,
} from "../types.js";
import { INPUT_METHOD_PACKAGES, keyboardNodes } from "./keyboard.js";
export type ControllerParseResult = {
controller: Controller;
@@ -222,7 +221,10 @@ function nodeToElement(node: Record<string, unknown>): InputElement | undefined
const SYSTEM_UI_PACKAGES = new Set([
"android",
"com.android.systemui",
...INPUT_METHOD_PACKAGES,
"com.google.android.inputmethod.latin",
"com.samsung.android.honeyboard",
"com.touchtype.swiftkey",
"com.microsoft.swiftkey",
]);
export function isSystemUiNode(node: Record<string, unknown>): boolean {
@@ -238,12 +240,6 @@ function collectJsonElements(value: unknown, output: InputElement[], seen: Set<u
return;
}
const record = value as Record<string, unknown>;
// iOS's software keyboard is system UI too, like Android's: its keys and its Emoji and Dictate buttons are not the
// app's elements. A keyboard that rose on one side only made "Added button “Dictate”" lead a review whose real
// change was a field's label (brentvatne/euxy#172, review run 39362642343).
if (Array.isArray(record.nodes)) {
for (const node of keyboardNodes(record.nodes.filter((node): node is Record<string, unknown> => !!node && typeof node === "object" && !Array.isArray(node)))) seen.add(node);
}
const element = isSystemUiNode(record) ? undefined : nodeToElement(record);
if (element) output.push(element);
for (const [key, child] of Object.entries(record)) {
-146
View File
@@ -1,146 +0,0 @@
/**
* The system software keyboard in a controller snapshot (agent-device's flat `nodes`, which the Argent bridge also
* returns), and how long capture waits for it. Recognition is deliberately narrow: dropping one of the app's own elements
* hides a real change, which is worse than the keyboard noise this removes. A node is the keyboard's only when it, or a
* node above it, provably belongs to the system keyboard; nothing is inferred from where an element sits on the screen,
* and a `Key` alone proves nothing (React Native's `accessibilityRole="keyboardkey"` gives an app's PIN pad that type).
*/
type Rect = { x: number; y: number; width: number; height: number };
type SnapshotNode = Record<string, unknown>;
/** Android input methods: their windows name the IME's package, not the app's. */
export const INPUT_METHOD_PACKAGES: ReadonlySet<string> = new Set([
"com.google.android.inputmethod.latin",
"com.android.inputmethod.latin",
"com.samsung.android.honeyboard",
"com.touchtype.swiftkey",
"com.microsoft.swiftkey",
]);
/**
* UIKit's identifiers for the input view placeholder and the prediction bar. They mark a window as the keyboard's (see
* the Argent bridge's `keyboardWindows`); inside the app's own window an element with one of them is the app's.
*/
export const KEYBOARD_WINDOW_IDENTIFIERS: ReadonlySet<string> = new Set(["inputView", "SystemInputAssistantView"]);
/**
* The keyboard's native view classes, which agent-device's host accessibility bridge reports as `role`. The dock's Emoji
* and Dictate buttons (UIKeyboardDockItemButton) can sit outside the key plane's bounds, so they are named here.
*/
const KEYBOARD_VIEW_CLASSES = new Set(["UIKeyboardDockItemButton", "UIAccessibilityElementKBKey", "UIKeyboardLayoutStar",
"TUIPredictionView", "TUIPredictionViewCell", "_UIRemoteKeyboardPlaceholderView", "TUISystemInputAssistantView",
"TUISystemInputAssistantPageView"]);
const EDITABLE_TYPES = new Set(["textfield", "securetextfield", "searchfield", "textview"]);
const text = (value: unknown) => typeof value === "string" ? value : "";
function rectOf(node: SnapshotNode): Rect | undefined {
const rect = node.rect as Partial<Rect> | undefined;
return rect && [rect.x, rect.y, rect.width, rect.height].every(Number.isFinite) && rect.width! > 0 && rect.height! > 0 ? rect as Rect : undefined;
}
/**
* A node that belongs to the system keyboard by what it is, not where it is: XCTest's `Keyboard` element (both
* controllers), a node of a window the Argent bridge found to be the keyboard's (`systemKeyboard`), one of the keyboard's
* native view classes, or a node of an Android input method's window.
*/
function keyboardRoot(node: SnapshotNode): boolean {
return node.systemKeyboard === true || text(node.type).toLowerCase() === "keyboard" || KEYBOARD_VIEW_CLASSES.has(text(node.role))
|| INPUT_METHOD_PACKAGES.has(text(node.bundleId ?? node.packageName ?? node.package));
}
/** Every node that belongs to the system keyboard: those `keyboardRoot` names and the nodes beneath them. */
export function keyboardNodes(nodes: readonly SnapshotNode[]): Set<SnapshotNode> {
const owned = new Set<SnapshotNode>();
if (!nodes.some(keyboardRoot)) return owned;
// Only an explicit parent links a node to a keyboard above it: a node without one is no node's descendant.
const byIndex = new Map(nodes.filter(node => typeof node.index === "number").map(node => [node.index as number, node]));
for (const node of nodes) {
const seen = new Set<SnapshotNode>();
for (let current: SnapshotNode | undefined = node; current && !seen.has(current);
current = typeof current.parentIndex === "number" ? byIndex.get(current.parentIndex) : undefined) {
seen.add(current);
if (keyboardRoot(current)) { owned.add(node); break; }
}
}
return owned;
}
function union(rects: readonly Rect[]): Rect | undefined {
if (!rects.length) return undefined;
const x = Math.min(...rects.map(rect => rect.x)), y = Math.min(...rects.map(rect => rect.y));
return { x, y, width: Math.max(...rects.map(rect => rect.x + rect.width)) - x, height: Math.max(...rects.map(rect => rect.y + rect.height)) - y };
}
/**
* Where the visible keyboard is, from the nodes that span it (the `Keyboard` element, the keyboard window's input view and
* prediction bar, the native views, an input method's window), or undefined when none shows. Containers inside the
* keyboard can report a scroll extent past the screen, so not every node it owns counts.
*/
export function keyboardBounds(nodes: readonly SnapshotNode[]): Rect | undefined {
return union(nodes.filter(node => node.visible !== false && keyboardRoot(node) && (node.systemKeyboard !== true
|| text(node.type).toLowerCase() === "keyboard" || KEYBOARD_WINDOW_IDENTIFIERS.has(text(node.identifier)))).flatMap(node => rectOf(node) ?? []));
}
/**
* A text input that has the keyboard focus: agent-device reports `focused` from XCTest's keyboard focus and Android's
* focused flag; the Argent bridge passes on Argent's own.
*/
export function focusedTextInput(nodes: readonly SnapshotNode[]): boolean {
return nodes.some(node => node.focused === true && node.visible !== false
&& (EDITABLE_TYPES.has(text(node.type).toLowerCase()) || /EditText$/.test(text(node.type)) || node.editable === true));
}
/** A snapshot as the wait reads it: Argent also says whether a keyboard shows, which its Android tree cannot. */
export type KeyboardRead = { nodes: readonly SnapshotNode[]; keyboardVisible?: boolean };
/** Where the keyboard is in one read: its bounds, or only that one shows when the controller cannot place it. */
function keyboardPosition(read: KeyboardRead): string | undefined {
const bounds = keyboardBounds(read.nodes);
return bounds ? JSON.stringify(bounds) : read.keyboardVisible === true ? "visible" : undefined;
}
/**
* How capture waits for a focused field's keyboard. Reads are 250 ms apart at most, and at least two follow the first,
* so a controller whose snapshot takes a second or more still sees the keyboard rise. Waiting for a keyboard that has not
* appeared ends after a second; one that has appeared but has not yet held still is read until it does, up to six reads
* or four seconds, so a slow controller cannot keep the capture waiting.
*/
export const KEYBOARD_POLL_MS = 250;
const KEYBOARD_WAIT_MS = 1_000;
const KEYBOARD_CAP_MS = 4_000;
const KEYBOARD_MIN_READS = 2;
const KEYBOARD_MAX_READS = 6;
export type KeyboardSettle = {
/** `shown`: in the same place in two reads running. `unfocused`: the field let go and no keyboard shows. */
readonly outcome: "shown" | "moving" | "absent" | "unfocused";
readonly reads: number;
/** Whether to read the screen again, `elapsedMs` after the first read. */
more(elapsedMs: number): boolean;
read(next: KeyboardRead): void;
};
/**
* The wait for a screen whose text field has the focus, or undefined when none has it. A keyboard already up counts only
* once a later read finds it in the same place: one caught rising or going down is still moving.
*/
export function keyboardSettle(first: KeyboardRead): KeyboardSettle | undefined {
if (!focusedTextInput(first.nodes)) return undefined;
let previous = keyboardPosition(first), reads = 0;
let outcome: KeyboardSettle["outcome"] = previous ? "moving" : "absent";
return {
get outcome() { return outcome; },
get reads() { return reads; },
more: elapsedMs => (outcome === "moving" || outcome === "absent") && reads < KEYBOARD_MAX_READS
&& (reads < KEYBOARD_MIN_READS || (elapsedMs < KEYBOARD_CAP_MS && (outcome === "moving" || elapsedMs < KEYBOARD_WAIT_MS))),
read: next => {
reads += 1;
const position = keyboardPosition(next);
outcome = position && position === previous ? "shown" : position ? "moving" : focusedTextInput(next.nodes) ? "absent" : "unfocused";
previous = position;
},
};
}
+6 -59
View File
@@ -17,7 +17,6 @@ import { type CaptureSetupSnapshot, credentialSavePromptDecline, describeSetupAc
import { silentProgress } from "../shared/progress.js";
import type { CaptureSetupReady } from "../config/explore-config.js";
import { READINESS_POLL_MS, defaultReadinessSeconds } from "./readiness.js";
import { KEYBOARD_POLL_MS, keyboardSettle, type KeyboardRead, type KeyboardSettle } from "./keyboard.js";
import { CAPTURE_OBSERVER_IDENTIFIER, captureObserverMarkers, parseCaptureDestination, captureDestinationMatches } from "./observer.js";
import { type CiAgentRuntimeOptions, runCiAgentNavigation, assertAgentCaptureContext } from "./agent/runtime.js";
import { createExplorationInputs } from "../config/exploration-inputs.js";
@@ -93,11 +92,6 @@ function snapshotNodes(raw: string): Record<string, unknown>[] {
return data.nodes;
}
/** Whether the controller says a keyboard shows: Argent does, and its Android tree has no input method window to show it. */
function keyboardVisibility(data: Record<string, unknown>): { keyboardVisible?: boolean } {
return typeof data.keyboardVisible === "boolean" ? { keyboardVisible: data.keyboardVisible } : {};
}
/** The visible element each required label matched, so an image assessor can find icon-only controls. */
export function verifiedCaptureLabels(nodes: readonly Record<string, unknown>[], requiredLabels: readonly string[],
/** The screen's portrait height, when the screenshot is that screen turned a quarter clockwise (an opened iPhone Duo). */
@@ -383,7 +377,7 @@ export async function capturePlannedRoutes(options: {
lastSnapshot = raw;
const generation = typeof data.refsGeneration === "number" ? data.refsGeneration : undefined;
const decline = declined < 2 && generation ? credentialSavePromptDecline(nodes) : undefined;
if (!decline) return { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}), ...keyboardVisibility(data) };
if (!decline) return { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}) };
controller(["press", `@${String(decline.ref).replace(/^@/, "")}~s${generation}`, "--level", "full", "--json"]);
recordDeclinedPrompt("deterministic");
controller(["wait", "500", "--level", "full", "--json"]);
@@ -513,35 +507,6 @@ export async function capturePlannedRoutes(options: {
.sort());
/** The controller's own quiescence gate; a timeout is reported by the snapshot comparison below. */
const settle = () => { controller(["wait", "stable", "500", "8000", "--level", "full", "--json"], true); };
/**
* A screen that focused a text field shows the keyboard that field raises, as its users see it. The keyboard rises
* after the screen has settled, so the controller's quiescence gate can pass in between: in brentvatne/euxy#172
* (review run 39362642343) the rename sheet's base was captured with its cursor showing and no keyboard, its head with
* the keyboard up, and the 48% mismatch was the keyboard. The screen is read again until the keyboard is in the same
* place twice running (see keyboardSettle); a keyboard that never comes is not waited for long, and none is dismissed.
*/
const awaitKeyboard = (route: SourceRoute, first: KeyboardRead): readonly Record<string, unknown>[] => {
const settle = keyboardSettle(first);
if (!settle) return first.nodes;
const startedAt = clock();
let current = first, pollStartedAt = startedAt;
// A read counts for at least one poll interval, so a clock that stands still (a fake controller) still expires.
const elapsed = () => Math.max(clock() - startedAt, settle.reads * KEYBOARD_POLL_MS);
while (settle.more(elapsed())) {
(capture.sleep ?? pause)(KEYBOARD_POLL_MS - (clock() - pollStartedAt));
pollStartedAt = clock();
current = snapshot();
settle.read(current);
}
recordKeyboardWait(route.id, settle, elapsed());
return current.nodes;
};
const recordKeyboardWait = (route: string | undefined, settle: KeyboardSettle, elapsedMs: number) => {
const diagnostics = join(store.root, "capture-diagnostics");
mkdirSync(diagnostics, { recursive: true, mode: 0o700 });
appendFileSync(join(diagnostics, "keyboard.jsonl"), `${JSON.stringify({ ...(route ? { route } : { phase: "agent-observe" }), outcome: settle.outcome,
reads: settle.reads, elapsedMs, at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
};
const attempted = new Set<string>();
const captureCurrent = async (route: SourceRoute, attempt: number, before?: readonly Record<string, unknown>[],
unattributed?: NonNullable<CaptureBundle["outcomes"][string]["observed"]> & { message: string }) => {
@@ -549,11 +514,9 @@ export async function capturePlannedRoutes(options: {
attempted.add(route.id);
const temporary = await mkdtemp(join(store.root, ".capture-"));
try {
const arrived = before ?? waitForDestination(route, () => resolveDeepLinkConfirmation());
if (unattributed) assertNoAlert({ route, nodes: arrived });
else landing(arrived, route, inventory);
const accepted = unattributed ? arrived : awaitKeyboard(route, { nodes: arrived });
if (accepted !== arrived) landing(accepted, route, inventory);
const accepted = before ?? waitForDestination(route, () => resolveDeepLinkConfirmation());
if (unattributed) assertNoAlert({ route, nodes: accepted });
else landing(accepted, route, inventory);
assertSafeScreenshot(accepted);
const screenshot = join(temporary, "screen.png");
await writeFile(screenshot, "", { flag: "wx", mode: 0o600 });
@@ -700,7 +663,7 @@ export async function capturePlannedRoutes(options: {
const generation = typeof data.refsGeneration === "number" ? data.refsGeneration : undefined;
const decline = declined < 2 && generation ? credentialSavePromptDecline(nodes) : undefined;
if (!decline) {
const snapshot: CaptureSetupSnapshot = { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}), ...keyboardVisibility(data) };
const snapshot: CaptureSetupSnapshot = { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}) };
return { snapshot, raw };
}
await command(["press", `@${String(decline.ref).replace(/^@/, "")}~s${generation}`, "--level", "full", "--json"], signal);
@@ -806,32 +769,16 @@ export async function capturePlannedRoutes(options: {
}
}
};
/** The same wait for a focused field's keyboard as a route link's capture, before an observation's screenshot. */
const awaitKeyboardAsync = async (first: CaptureSetupSnapshot, signal: AbortSignal): Promise<CaptureSetupSnapshot> => {
const settle = keyboardSettle(first);
if (!settle) return first;
const startedAt = clock();
let current = first;
const elapsed = () => Math.max(clock() - startedAt, settle.reads * KEYBOARD_POLL_MS);
while (settle.more(elapsed())) {
await sleep(KEYBOARD_POLL_MS, undefined, { signal: liveSignal(signal) });
current = (await readSnapshot(signal)).snapshot;
settle.read(current);
}
recordKeyboardWait(undefined, settle, elapsed());
return current;
};
const observe = async (signal: AbortSignal, options?: { includeImage: boolean }) => {
await discard();
await appIdentity(signal);
const first = await readSnapshotThroughDeferral(signal);
let before = first.snapshot;
const before = first.snapshot;
if (first.retries > 0) {
await appendFile(join(dirname(tracePath), "accessibility-deferral.jsonl"), `${JSON.stringify({ retries: first.retries, waitedMs: first.deferredMs,
at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
}
if (options?.includeImage === false) return { snapshot: before };
before = await awaitKeyboardAsync(before, signal);
try { assertSafeScreenshot(before.nodes); }
catch (error) {
if (error instanceof CiError && error.code === "CAPTURE_SENSITIVE_INPUT") return { snapshot: before, imageUnavailable: { code: error.code, message: error.message } };
+6 -10
View File
@@ -454,8 +454,6 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
// `eas simulator:control` names the session by id, from the session's own project directory.
const sessionEas: EasCommand = (args, commandOptions) => runner({ command: options.easCommand, args, cwd: simulatorProject, environment: easEnvironment,
timeoutMs: commandOptions?.timeoutMs ?? 5 * 60_000, ...(commandOptions?.allowFailure ? { allowFailure: true } : {}) });
// A failed simulator:control action is sent again after a pause, which a test's clock replaces.
const controlOptions = { sleep: options.sleep };
// What the EAS session's host can do through simulator:control (iOS sessions on serve-sim 0.10.0 or later).
let controlActions = new Set<string>();
const configResult = eas(["config", "--platform", options.platform, "--profile", options.easProfile, "--json", "--non-interactive"]);
@@ -787,7 +785,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
"--platform", options.platform, "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 15 * 60_000 });
// Before any link opens, as a local capture does with simctl: the app's own links then open without the prompt.
if (sessionId && scheme) {
const approved = approveSessionUrlSchemes(sessionEas, sessionId, controlActions, options.bundleId, [scheme], controlOptions);
const approved = approveSessionUrlSchemes(sessionEas, sessionId, controlActions, options.bundleId, [scheme]);
if (approved.length) say(`approved ${approved.map(item => `${item}://`).join(", ")} links on session ${sessionId}`);
}
}
@@ -798,10 +796,8 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
const target = deviceArgs({ platform: options.platform, deviceModel: options.device, ...(localDevice() ? { provider: "local-simulator" as const, controllerDeviceId: localDevice()! } : {}) });
// agent-device reads the hinge back after folding and fails to (locally and on EAS); its display is checked instead.
const easAgentDevice = !!sessionId && controller === "agent-device";
// Argent's bridge sends a fold again, twice, when the simulator-server it needs did not start within Argent's 30 s,
// so a fold can take three of those waits and the panel checks after it: 4 minutes covers that.
const fold = () => runner({ command: controllerCommand, args: ["fold", options.devicePose!, "--session", CONTROLLER_SESSION, ...target, "--platform", options.platform, "--json"],
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 4 * 60_000, ...(localSimulator || easAgentDevice ? { allowFailure: true } : {}) });
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000, ...(localSimulator || easAgentDevice ? { allowFailure: true } : {}) });
const pause = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
if (localSimulator && controller === "argent") {
// Argent folds without a session and checks the fold against its own reader; this machine also checks the display.
@@ -848,7 +844,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
if (!controlActions.has("springboard.restart")) throw new CiError({ code: "CONTROLLER_FOLD_UNVERIFIED", stage: "session",
message: `${options.device} did not show the ${options.devicePose} display after folding.`, nextAction: "Rerun the capture on a new session." });
say(`${options.device} did not draw the ${options.devicePose} display after the fold; restarting SpringBoard and folding ${options.devicePose} again`);
simulatorControl(sessionEas, sessionId, "springboard.restart", [], controlOptions);
simulatorControl(sessionEas, sessionId, "springboard.restart");
pause(8_000);
open(true);
fold();
@@ -863,7 +859,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
catch (error) {
if (toCiError(error).code !== "CONTROLLER_FOLD_UNVERIFIED") throw error;
say(`Argent kept reading the other panel after the fold; restarting SpringBoard and folding ${options.devicePose} again`);
simulatorControl(sessionEas, sessionId, "springboard.restart", [], controlOptions);
simulatorControl(sessionEas, sessionId, "springboard.restart");
pause(8_000);
try { fold(); }
catch (retry) {
@@ -896,7 +892,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
nextAction: "Rerun the capture; if it keeps happening, report it to Explore: this session's Argent tool-server needs a restart that EAS cannot do yet.", cause: error });
if (recovery === 1) {
say("Argent still did not read the app; restarting SpringBoard, then resetting Argent's device helpers and opening the app again");
simulatorControl(sessionEas, sessionId, "springboard.restart", [], controlOptions);
simulatorControl(sessionEas, sessionId, "springboard.restart");
// SpringBoard takes a moment to come back, and sends the app to the background; the next open brings it back.
(options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); }))(8_000);
} else say("Argent did not read the app after starting it; resetting Argent's device helpers and opening the app again");
@@ -948,7 +944,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
// machine and serve-sim on an EAS iOS session; elsewhere its single pass runs as the device starts.
if (controller !== "argent") runner({ command: controllerCommand, args: [...appearanceArgs(colorScheme), "--session", CONTROLLER_SESSION, ...deviceArgs(runtime), "--platform", options.platform],
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 60_000 });
else if (sessionId && controlActions.has("appearance.set")) simulatorControl(sessionEas, sessionId, "appearance.set", [colorScheme], controlOptions);
else if (sessionId && controlActions.has("appearance.set")) simulatorControl(sessionEas, sessionId, "appearance.set", [colorScheme]);
else if (localSimulator) setLocalSimulatorAppearance({ runner, udid: localSimulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
else if (localEmulator) setLocalEmulatorAppearance({ runner, serial: localEmulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
// A scheme change recreates the Android activity in place, and the sheets it re-presents lose their inset; a
-2
View File
@@ -6,8 +6,6 @@ export type CaptureSetupSnapshot = {
nodes: readonly Record<string, unknown>[];
refsGeneration?: number;
truncated?: boolean;
/** Whether the controller says a software keyboard shows, when it says (Argent does). */
keyboardVisible?: boolean;
};
type Awaitable<T> = T | Promise<T>;
+5 -35
View File
@@ -20,53 +20,23 @@ export function simulatorControlActions(eas: EasCommand, sessionId: string): Set
} catch { return new Set(); }
}
/**
* Pauses before each resend of a failed action. Every action Explore runs is idempotent, and the session's host can fail
* one once: in brentvatne/euxy's baseline run 39348933440, `app.approveUrlScheme` failed in its `simctl spawn … defaults
* write`, which failed the dark-appearance session and with it the target's whole baseline.
*/
const SIMULATOR_CONTROL_RETRY_DELAYS_MS = [3_000, 6_000] as const;
/** Lets a test replace the pause between resends of a failed action. */
export type SimulatorControlOptions = { sleep?: ((milliseconds: number) => void) | undefined };
/**
* Runs one `eas simulator:control` action on the session; eas-cli fills in the device. A failed action is sent again
* after a pause; one that still fails throws with EAS's reason.
*/
export function simulatorControl(eas: EasCommand, sessionId: string, action: string, values: readonly string[] = [], options: SimulatorControlOptions = {}): void {
const sleep = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
/** Runs one `eas simulator:control` action on the session; eas-cli fills in the device. Throws with EAS's reason. */
export function simulatorControl(eas: EasCommand, sessionId: string, action: string, values: readonly string[] = []): void {
// Values follow `--` so one that starts with a dash is never read as a flag.
const args = ["simulator:control", action, "--id", sessionId, "--json", "--non-interactive", "--", ...values];
for (let retry = 0; ; retry += 1) {
try { eas(args, { timeoutMs: 2 * 60_000 }); return; }
catch (error) {
const delayMs = SIMULATOR_CONTROL_RETRY_DELAYS_MS[retry];
if (delayMs === undefined) throw error;
// A resend that succeeds would otherwise leave no trace of the failure in the job log.
process.stderr.write(`simulator:control ${action} failed (${firstLine(error)}); sending it again in ${delayMs / 1000} s\n`);
sleep(delayMs);
}
}
eas(["simulator:control", action, "--id", sessionId, "--json", "--non-interactive", "--", ...values], { timeoutMs: 2 * 60_000 });
}
/**
* Lets the app open its own links without iOS asking "Open in “App”?" first, like local captures do with simctl. A
* session without the action keeps the controllers' prompt handling; http and https never prompt and are skipped.
*/
export function approveSessionUrlSchemes(eas: EasCommand, sessionId: string, actions: ReadonlySet<string>, bundleId: string, schemes: readonly string[],
options: SimulatorControlOptions = {}): string[] {
export function approveSessionUrlSchemes(eas: EasCommand, sessionId: string, actions: ReadonlySet<string>, bundleId: string, schemes: readonly string[]): string[] {
if (!actions.has("app.approveUrlScheme")) return [];
const approved: string[] = [];
for (const scheme of new Set(schemes.map(value => value.toLowerCase()))) {
if (scheme === "http" || scheme === "https" || !/^[a-z][a-z0-9+.-]*$/.test(scheme)) continue;
simulatorControl(eas, sessionId, "app.approveUrlScheme", [bundleId, scheme], options);
simulatorControl(eas, sessionId, "app.approveUrlScheme", [bundleId, scheme]);
approved.push(scheme);
}
return approved;
}
/** The first line of a failure, for a log line. */
function firstLine(error: unknown): string {
return (error instanceof Error ? error.message : String(error)).split("\n", 1)[0]!.slice(0, 300);
}
+3 -6
View File
@@ -106,11 +106,8 @@ type GithubArtifact = { id: number; expired: boolean; workflow_run?: { id?: numb
type GithubRun = { conclusion: string | null; workflow_id: number; head_sha: string; head_branch: string; event: string; head_repository?: { full_name?: string } };
/**
* `ci:find-baseline`: the newest baseline-workflow artifact of exactly this commit, uploaded from the default branch of
* this repository by a finished run. Its id and run go to the step outputs for actions/download-artifact. A run that
* failed counts: a target's baseline job uploads its artifact only after every step before it passed, so another
* target's failure (one flaky simulator session, as in brentvatne/euxy#172) does not make this target's baseline
* unusable. A run still in progress or cancelled does not.
* `ci:find-baseline`: the newest successful baseline-workflow artifact of exactly this commit, uploaded from the
* default branch of this repository. Its id and run go to the step outputs for actions/download-artifact.
*/
export async function findBaselineArtifact(options: { sha: string; target?: string;
/** What callers from before targets pass: a platform is the id of its default target. */ platform?: string; environment?: Environment; transport?: typeof fetch }): Promise<{ id: number; run: number } | undefined> {
@@ -134,7 +131,7 @@ export async function findBaselineArtifact(options: { sha: string; target?: stri
for (const artifact of artifacts.filter(candidate => !candidate.expired).sort((a, b) => b.id - a.id)) {
if (!artifact.workflow_run?.id) continue;
const run = await githubGet<GithubRun>(`repos/${context.repository}/actions/runs/${artifact.workflow_run.id}`, context, transport);
if (!run || (run.conclusion !== "success" && run.conclusion !== "failure") || run.workflow_id !== workflow.id || run.head_sha !== options.sha
if (!run || run.conclusion !== "success" || run.workflow_id !== workflow.id || run.head_sha !== options.sha
|| run.head_branch !== repository.default_branch || !["push", "workflow_dispatch"].includes(run.event)
|| run.head_repository?.full_name !== context.repository) continue;
return { id: artifact.id, run: artifact.workflow_run.id };
-4
View File
@@ -5,7 +5,6 @@ import { resolve } from "node:path";
import { ExploreStore } from "./map/store.js";
import { QUERY_CONTRACT } from "./types.js";
import { EXPLORE_VERSION } from "./shared/package-paths.js";
import { isTargetId } from "./config/explore-config.js";
import { command, resultContract, argumentError, validateCommandArguments, flag, has, setStore } from "./cli/args.js";
import { help } from "./cli/help.js";
import { listScreens, getScreen, listElements, listObservations, getObservation, nextFrontier, listAttempts, getAttempt, listTransitions, getTransition, neighbors, pathQuery, listJourneys, getJourney, listFrontier, listGaps, summary, search, status, validate, exportArtifacts } from "./cli/map-commands.js";
@@ -82,11 +81,8 @@ try {
await handler();
} catch (error) {
if (command.startsWith("capture:") || command.startsWith("source:") || command.startsWith("ci:") || command.startsWith("config:")) {
// The failure comment names the target from this: a capture, report or publication of one matrix target.
const target = (() => { try { return flag("target"); } catch { return undefined; } })();
const diagnostic = await reportCiError(ciErrorForCommand(error, command), {
...(process.env.RUNNER_TEMP ? { diagnosticsPath: resolve(process.env.RUNNER_TEMP, "explore-diagnostics", "error.json") } : {}),
...(isTargetId(target) ? { target } : {}),
...(has("json") ? { write: (line: string) => { if (process.env.GITHUB_ACTIONS === "true") console.log(line); } } : {}),
});
if (has("json")) console.error(JSON.stringify({ contract: resultContract, command, ok: false, error: diagnostic.message, diagnostic }));
-5
View File
@@ -251,11 +251,6 @@ export type PublicSurfaceReview = {
description: string;
/** Every deterministic accessibility fact for this surface, in reviewer priority order. */
facts?: Array<{ category: string; templateId: string; bullet: string }>;
/**
* The screenshots match because the change is past the edge of the screen: every element its facts name reaches
* beyond the captured screen. Only on a `modified` verdict whose screenshots match.
*/
offScreen?: true;
};
/** An evidence-bound explanation. It never changes a deterministic comparison verdict. */
export type PublicChangeNote = {
-1
View File
@@ -57,7 +57,6 @@ function assertReviewFields(surface: Surface, enforceComparisonEvidence: boolean
|| (["modified", "unchanged", "variant"].includes(review.status) && (!surface.base || !surface.head))
|| (surface.sourceScope !== undefined && !["added", "removed"].includes(review.status)
&& !SCOPE_VERDICTS[surface.sourceScope]?.includes(review.status))
|| (review.offScreen !== undefined && (review.offScreen !== true || review.status !== "modified" || surface.visual?.verdict !== "unchanged"))
|| (review.facts !== undefined && (!Array.isArray(review.facts) || review.facts.length > 100
|| review.facts.some((fact) => !fact || typeof fact.category !== "string" || typeof fact.templateId !== "string"
|| typeof fact.bullet !== "string" || !fact.bullet.trim() || fact.bullet.length > MAX_REVIEW_DESCRIPTION)))) {
-73
View File
@@ -1,73 +0,0 @@
import type { PublicReview } from "./capture.js";
import { navigationCaptureContext } from "./navigation-graph.js";
type Surface = PublicReview["surfaces"][number];
type Side = "base" | "head";
/** Navigation is route-level: a secondary-appearance surface (`<id>@<scheme>`) rides on its route's entry. */
const SCHEME_SUFFIX = /@(light|dark)$/;
const routeOf = (id: string): string => id.replace(SCHEME_SUFFIX, "");
/**
* The surfaces a side planned to capture: every route in `all` mode, the changed routes and their navigation context in
* `changes` mode. Undefined without navigation, which leaves no route outside the context.
*/
export function captureContext(review: PublicReview, side: Side): ReadonlySet<string> | undefined {
const navigation = review.navigation?.[side];
if (!navigation) return undefined;
const inventory = review.surfaces.filter((surface) => surface[side]);
const routes = new Map<string, NonNullable<Surface[Side]>>();
for (const surface of inventory) {
const id = routeOf(surface.id);
if (!routes.has(id)) routes.set(id, { ...surface[side]!, id });
}
const selected = new Set(review.mode === "all" ? [...routes.keys()] : navigationCaptureContext(navigation,
inventory.filter((surface) => surface.status !== "unchanged").map((surface) => routeOf(surface.id)),
[...routes.values()]));
return new Set(inventory.filter((surface) => selected.has(routeOf(surface.id))).map((surface) => surface.id));
}
/** Both a screenshot of the planned route and a verified landing on it. */
export function verifiedCapture(surface: Surface, side: Side): boolean {
const outcome = side === "base" ? surface.baseOutcome : surface.headOutcome;
return Boolean(surface[side]?.kind === "screen" && (side === "base" ? surface.baseImage : surface.headImage)
&& outcome?.status === "captured" && outcome.landing === "verified");
}
/**
* Why a side that exists in its revision has no verified capture, as the report's capture gap: `accepted` when the run
* left it uncaptured on purpose (a redirect declaration, a route named in `exploration.exclude`, or a route outside the
* capture context), `open` for anything else, such as a capture that failed. Undefined for a verified capture or an
* absent side. `context` is the side's `captureContext`.
*/
export function captureGap(review: PublicReview, surface: Surface, side: Side,
context: ReadonlySet<string> | undefined): "accepted" | "open" | undefined {
const entry = surface[side];
if (!entry || verifiedCapture(surface, side)) return undefined;
const image = side === "base" ? surface.baseImage : surface.headImage;
const outcome = side === "base" ? surface.baseOutcome : surface.headOutcome;
const outsideCaptureContext = review.mode === "changes" && context !== undefined && !context.has(surface.id);
const deliberate = !image && !outcome && (entry.kind === "redirect" || surface.excluded === true || outsideCaptureContext
|| (!review.navigation?.[side] && review.mode === "changes" && surface.status === "unchanged"));
return deliberate ? "accepted" : "open";
}
/**
* The surfaces the run never captured on purpose: no screenshot of their own on either side, and every side that exists
* left uncaptured deliberately (`captureGap` is `accepted`). None is one of the report's screens. The Viewer leaves them
* out (viewer/src/utils/omitted-screens.ts reaches the same set from the map's gaps), and the PR comment skips them.
* A side with an open gap, such as a failed capture, keeps the surface: its failure is part of the report.
*/
export function neverCapturedSurfaceIds(review: PublicReview): ReadonlySet<string> {
// The Viewer refuses a review whose navigation names a route its inventory lacks; the comment still renders one,
// without a capture context, so no route counts as outside it.
const contextOf = (side: Side) => { try { return captureContext(review, side); } catch { return undefined; } };
const contexts = { base: contextOf("base"), head: contextOf("head") };
const omitted = new Set<string>();
for (const surface of review.surfaces) {
if (surface.baseImage || surface.headImage) continue;
const gaps = (["base", "head"] as const).map((side) => captureGap(review, surface, side, contexts[side]));
if (gaps.includes("accepted") && !gaps.includes("open")) omitted.add(surface.id);
}
return omitted;
}
+2 -6
View File
@@ -6,7 +6,6 @@ import {
type Observation,
type Screen,
} from "../types.js";
import { accessibilityFingerprintsComparable } from "./store.js";
/**
* Cross-run screen matching for PR-style comparisons (baseline = base branch map,
@@ -254,8 +253,7 @@ function matchEntry(match: Match): { entry: BuildComparisonEntry; review: Compar
// captured on both sides) hide a real change to the primary content.
const baselineHash = match.baseline.representative.fingerprints.accessibility;
const currentHash = match.current.representative.fingerprints.accessibility;
// Hashes from different fingerprint versions (an older Explore's map) say nothing about whether the trees differ.
const verdict = baselineHash && currentHash && accessibilityFingerprintsComparable(baselineHash, currentHash)
const verdict = baselineHash && currentHash
? (baselineHash === currentHash ? "unchanged" : "modified")
: "unknown";
const unchanged = verdict === "unchanged";
@@ -264,9 +262,7 @@ function matchEntry(match: Match): { entry: BuildComparisonEntry; review: Compar
? `Matched by ${signals}; the representative captures share an accessibility fingerprint, so the rendered tree is unchanged.`
: verdict === "modified"
? `Matched by ${signals}; the representative captures have different accessibility fingerprints, so the rendered tree changed.`
: baselineHash && currentHash
? `Matched by ${signals}; the representative captures were fingerprinted by different Explore versions, so the change state could not be verified from fingerprints.`
: `Matched by ${signals}; accessibility fingerprints are unavailable on at least one side, so the change state could not be verified from fingerprints.`;
: `Matched by ${signals}; accessibility fingerprints are unavailable on at least one side, so the change state could not be verified from fingerprints.`;
const entry: BuildComparisonEntry = {
id: `match-${match.current.screen.id}`,
relationship: "one-to-one",
+5 -23
View File
@@ -14,7 +14,6 @@ import { dirname, extname, isAbsolute, join, relative, resolve, sep } from "node
import { fileURLToPath } from "node:url";
import { Ajv2020, type ErrorObject, type ValidateFunction } from "ajv/dist/2020.js";
import { isSystemUiNode } from "../capture/controller-output.js";
import { keyboardNodes } from "../capture/keyboard.js";
import { validateNavigationGraph } from "../contracts/navigation-graph.js";
import {
CONTRACT,
@@ -68,26 +67,11 @@ export const normalizeSelector = (input?: string): string | undefined => {
return input.replace(/\s+/g, " ").trim() || undefined;
};
/** A ref names a node within one read; which field has the focus can change between two reads of one screen. */
const VOLATILE_SNAPSHOT_NODE_KEYS = new Set(["ref", "focused"]);
/**
* The accessibility fingerprint's algorithm, written as its prefix. Version 2 leaves the system keyboard and the focus out
* of the tree; a hash from before carries no prefix. Two fingerprints of different versions say nothing about whether the
* trees differ, so a comparison treats them as not comparable rather than changed (see accessibilityFingerprintsComparable).
*/
const ACCESSIBILITY_FINGERPRINT_VERSION = "a2";
export function accessibilityFingerprintsComparable(left: string, right: string): boolean {
const version = (hash: string) => /^(a\d+):/.exec(hash)?.[1] ?? "a1";
return version(left) === version(right);
}
const VOLATILE_SNAPSHOT_NODE_KEYS = new Set(["ref"]);
/** Canonical JSON of the node tree only: controller wrappers carry per-session diagnostics and
* ref generations that would otherwise make identical screens fingerprint differently, and Android
* system UI nodes (status bar clock and signal, keyboard) change between emulator sessions. The
* system keyboard on either platform is left out as the elements leave it out, so a keyboard up on
* one side only does not make two captures of one screen differ. */
* system UI nodes (status bar clock and signal, keyboard) change between emulator sessions. */
function normalizeJsonSnapshotNodes(input: string): string | undefined {
if (!/^\s*\{/.test(input)) return undefined;
let value: unknown;
@@ -102,12 +86,10 @@ function normalizeJsonSnapshotNodes(input: string): string | undefined {
if (!data || typeof data !== "object" || !Array.isArray((data as { nodes?: unknown }).nodes)) {
return undefined;
}
const nodes = (data as { nodes: unknown[] }).nodes;
const keyboard: Set<unknown> = keyboardNodes(nodes.filter((entry): entry is Record<string, unknown> => !!entry && typeof entry === "object" && !Array.isArray(entry)));
const canonical = (node: unknown): unknown => {
if (Array.isArray(node)) {
return node
.filter((entry) => !(entry && typeof entry === "object" && (isSystemUiNode(entry as Record<string, unknown>) || keyboard.has(entry))))
.filter((entry) => !(entry && typeof entry === "object" && isSystemUiNode(entry as Record<string, unknown>)))
.map(canonical);
}
if (!node || typeof node !== "object") return node;
@@ -118,7 +100,7 @@ function normalizeJsonSnapshotNodes(input: string): string | undefined {
.map(([key, entry]) => [key, canonical(entry)]),
);
};
return `nodes\0${JSON.stringify(canonical(nodes))}`;
return `nodes\0${JSON.stringify(canonical((data as { nodes: unknown[] }).nodes))}`;
}
export const normalizeSnapshot = (input: string): string =>
@@ -136,7 +118,7 @@ export async function fingerprintState(options: {
snapshotText?: string;
}): Promise<ObservationFingerprints> {
const accessibility = options.snapshotText
? `${ACCESSIBILITY_FINGERPRINT_VERSION}:${sha256(`snapshot\0${normalizeSnapshot(options.snapshotText)}`)}`
? sha256(`snapshot\0${normalizeSnapshot(options.snapshotText)}`)
: undefined;
const screenshot = options.screenshotPath ? await readFile(options.screenshotPath) : undefined;
const visual = screenshot ? sha256(Buffer.concat([Buffer.from("visual\0"), screenshot])) : undefined;
+3 -11
View File
@@ -8,7 +8,6 @@ import { compareTitleMarkdown, projectReviewPresentation, type CompareReviewPres
import { renderPublicComment, platformSectionMerge, reviewChangeCount, type PublicCommentState } from "./pr-comment-body.js";
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
import { upsertStickyComment } from "./pr-comment.js";
import { retryGitHubLookup } from "./github-lookup.js";
import { previewLinks, viewerLinks } from "./viewer-links.js";
import type { PublicReview } from "../contracts/capture.js";
import { CiError, toCiError } from "../shared/ci-errors.js";
@@ -137,8 +136,6 @@ export async function publishCiReportComment(options: {
preview?: { url: string; expiresAt: number | null };
/** Set by `ci:deploy` when the hosted preview failed: the comment falls back to the central Viewer and the ZIP. */
previewFailed?: boolean;
/** Pause between GitHub lookups that may succeed later; tests replace it so retries take no real time. */
sleep?: (milliseconds: number) => Promise<void>;
}) {
const environment = options.environment ?? process.env; const transport = options.transport ?? fetch;
const input = await readInput(options.inputPath); const review = input.publicReview; const pr = review.pullRequest;
@@ -189,21 +186,16 @@ export async function publishCiReportComment(options: {
catch (error) { throw new CiError({ code: "GITHUB_RESPONSE_INVALID", stage: "publication",
message: "GitHub returned invalid report metadata.", nextAction: "Rerun publication; if the response remains invalid, inspect the GitHub metadata request.", cause: error }); }
};
// A lookup is made again when GitHub may answer it later: no answer, a 5xx, or a 404 from the Actions API, which may
// not list a just-uploaded artifact yet. A bad token, a missing permission or a rate limit fails at once, as before.
const lookup = (path: string) => retryGitHubLookup(() => api(path), error => error instanceof CiError
&& (error.code === "GITHUB_NETWORK_FAILED" || error.code === "GITHUB_REQUEST_FAILED" && error.retryable
|| error.code === "GITHUB_RESOURCE_NOT_FOUND" && path.startsWith("actions/")), options.sleep);
const artifact = await lookup(`actions/artifacts/${new URL(options.artifactUrl).pathname.split("/").at(-1)}`);
const artifact = await api(`actions/artifacts/${new URL(options.artifactUrl).pathname.split("/").at(-1)}`);
if (artifact.expired || artifact.name !== `explore-review-${review.runId}-${review.runAttempt}${target ? `-${target}` : ""}` || String(artifact.workflow_run?.id) !== review.runId) {
throw new CiError({ code: artifact.expired ? "REPORT_ARTIFACT_EXPIRED" : "REPORT_ARTIFACT_MISMATCH", stage: "publication",
message: "The uploaded report artifact is unavailable or belongs to another run",
nextAction: artifact.expired ? "Rerun Explore to upload a fresh report artifact." : "Pass the final report artifact from this workflow run and attempt." });
}
const attempt = await lookup(`actions/runs/${review.runId}/attempts/${review.runAttempt}`);
const attempt = await api(`actions/runs/${review.runId}/attempts/${review.runAttempt}`);
if (String(attempt.id) !== review.runId || String(attempt.run_attempt) !== review.runAttempt) throw new CiError({ code: "REPORT_RUN_MISMATCH", stage: "publication",
message: "Report run attempt mismatch", nextAction: "Publish the artifact and report input from the same current workflow attempt." });
const current = await lookup(`pulls/${pr.number}`);
const current = await api(`pulls/${pr.number}`);
if (current.state !== "open" || current.head?.repo?.full_name !== pr.repository || current.head?.ref !== pr.head.ref) {
throw new CiError({ code: "PR_CHANGED", stage: "publication", message: "PR closed or changed branches before the report artifact was ready",
nextAction: "Run Explore for the current PR head and base before publishing a ready report." });
+41 -69
View File
@@ -15,7 +15,7 @@ export type FailureCommentOptions = {
runAttempt: string;
/** The directory the failure job downloaded diagnostics artifacts into (`<stage>/<artifact>/…/error.json`). */
diagnosticsPath?: string;
/** The failed target's id; otherwise every target the diagnostics artifacts name. */
/** The failed target's id; otherwise the one the first diagnostics artifact's name carries. */
target?: string;
/** What callers from before targets pass: a platform is the id of its default target. */
platform?: ExplorePlatform;
@@ -25,8 +25,6 @@ export type FailureCommentOptions = {
};
type Diagnostic = { code: string; stage: string; message: string; nextAction: string };
/** A failed target's diagnostic. `target` is absent when neither the artifact's name nor the file names one. */
export type LocatedFailure = { diagnostic?: Diagnostic; target?: string; platform?: ExplorePlatform };
const SHA = /^[0-9a-f]{40}$/;
// `explore-<kind>-<run>-<attempt>-<target>`: the kind has no digits, so the first number is the run and the rest is the target id.
const ARTIFACT_DIR = /^explore-[a-z-]+-\d+-\d+-([a-z][a-z0-9-]{0,31})$/;
@@ -36,14 +34,11 @@ const MAX_DIAGNOSTIC_BYTES = 32_768;
const CODE = /^[A-Z][A-Z0-9_]{1,63}$/;
const STAGE = /^[a-z][a-z0-9-]{0,63}$/;
function parseJson(text: string): Record<string, unknown> | undefined {
function parseDiagnostic(text: string, stage: string): Diagnostic | undefined {
let parsed: unknown;
try { parsed = JSON.parse(text); } catch { return undefined; }
return parsed && typeof parsed === "object" && !Array.isArray(parsed) ? parsed as Record<string, unknown> : undefined;
}
function parseDiagnostic(value: Record<string, unknown> | undefined, stage: string): Diagnostic | undefined {
if (!value) return undefined;
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return undefined;
const value = parsed as Record<string, unknown>;
const field = (name: string, max: number) => typeof value[name] === "string" && (value[name] as string).trim() && (value[name] as string).length <= max ? value[name] as string : undefined;
const code = field("code", 64), message = field("message", 4000), nextAction = field("nextAction", 4000), stageName = field("stage", 64) ?? stage;
if (!code || !CODE.test(code) || !message || !nextAction || !STAGE.test(stageName)) return undefined;
@@ -51,51 +46,32 @@ function parseDiagnostic(value: Record<string, unknown> | undefined, stage: stri
return { code, stage: stageName, message, nextAction };
}
/** Reads one error.json; `named` is the target its artifact directory names, else the one the file records. */
async function readFailure(path: string, stage: string, named: string | undefined): Promise<LocatedFailure | undefined> {
const info = await lstat(path).catch(() => undefined);
if (!info) return undefined;
const located = (target: string | undefined): LocatedFailure => ({ ...(target ? { target } : {}), ...(target === "ios" || target === "android" ? { platform: target as ExplorePlatform } : {}) });
if (!info.isFile() || info.size > MAX_DIAGNOSTIC_BYTES) return located(named);
const value = parseJson(await readFile(path, "utf8"));
const target = named ?? (isTargetId(value?.target) ? value.target : undefined);
const diagnostic = parseDiagnostic(value, stage);
return diagnostic ? { diagnostic, ...located(target) } : located(target);
}
/**
* Every failed target's error.json and the target it belongs to (`ios` or `android` for a config without targets, and
* for artifacts of versions before targets). actions/download-artifact puts each artifact a pattern matches in a
* directory named after it, except when the pattern matches exactly one: that one lands in the stage's directory
* itself, and the file names its target. A report failure's diagnostic takes precedence over its target's capture
* diagnostic; a present but unreadable file yields the generic failure rather than an earlier stage's error, and only
* The error.json a failed job left behind and the target its artifact name carries (`ios` or `android` for a config
* without targets, and for artifacts of versions before targets). A report failure's diagnostic takes precedence over
* capture's; a present but unreadable file yields the generic failure rather than an earlier stage's error, and only
* regular files count (never symlinks out of the artifact). `platform` is set when the target id is a platform's.
*/
export async function locateFailureDiagnostics(root: string): Promise<LocatedFailure[]> {
const failures: LocatedFailure[] = [];
const seen = new Set<string>();
export async function locateFailureDiagnostic(root: string): Promise<{ diagnostic?: Diagnostic; target: string; platform?: ExplorePlatform } | undefined> {
for (const [stage, file] of [["report", "error.json"], ["capture", join("explore-diagnostics", "error.json")]] as const) {
const entries = await readdir(join(root, stage), { withFileTypes: true }).catch(() => []);
const candidates = [...entries.filter(entry => entry.isDirectory() && artifactTarget(entry.name)).sort((a, b) => a.name.localeCompare(b.name))
.map(entry => ({ path: join(root, stage, entry.name, file), named: artifactTarget(entry.name) })), { path: join(root, stage, file), named: undefined }];
for (const { path, named } of candidates) {
const located = await readFailure(path, stage, named);
if (!located || seen.has(located.target ?? "")) continue;
seen.add(located.target ?? "");
failures.push(located);
for (const entry of entries.filter(entry => entry.isDirectory() && artifactTarget(entry.name)).sort((a, b) => a.name.localeCompare(b.name))) {
const path = join(root, stage, entry.name, file);
const info = await lstat(path).catch(() => undefined);
if (!info) continue;
const target = artifactTarget(entry.name)!;
const located: { target: string; platform?: ExplorePlatform } = { target, ...(target === "ios" || target === "android" ? { platform: target as ExplorePlatform } : {}) };
if (!info.isFile() || info.size > MAX_DIAGNOSTIC_BYTES) return located;
const diagnostic = parseDiagnostic(await readFile(path, "utf8"), stage);
return diagnostic ? { diagnostic, ...located } : located;
}
}
return failures;
}
/** The first failure locateFailureDiagnostics finds: a report failure before a capture failure. */
export async function locateFailureDiagnostic(root: string): Promise<LocatedFailure | undefined> {
return (await locateFailureDiagnostics(root))[0];
return undefined;
}
/**
* The failure job's comment: a job died outside Explore's own progress comments (install, checkout, a crash
* before the pipeline posted), so the sticky comment gets a failed record for each failed target from the same
* before the pipeline posted), so the sticky comment gets a failed record for that target from the same
* renderer every other writer uses. Nothing is posted when the PR is closed; a PR that moved on is marked
* superseded so the failure lands under previous runs.
*/
@@ -118,31 +94,27 @@ export async function publishFailureComment(options: FailureCommentOptions): Pro
return { posted: false, reason: "The PR is no longer an open same-repository PR." };
}
const superseded = pr.head?.sha !== options.headSha || pr.base?.sha !== options.baseSha;
const located = options.diagnosticsPath ? await locateFailureDiagnostics(options.diagnosticsPath) : [];
// Each failed target gets its own failed record: since one target's failed capture no longer stops the others'
// reports (brentvatne/euxy#172), several targets of one run can fail in different jobs.
const failures: LocatedFailure[] = requested !== undefined ? [{ ...(located.find(failure => failure.target === requested) ?? located[0]), target: requested }]
: located.length ? located : [{}];
for (const { target, diagnostic } of failures) {
// The failure job knows a target by its id alone; the comment's own record for that id supplies its label and platform.
const platform: ExplorePlatform | undefined = target === "ios" || target === "android" ? target : undefined;
const configPath = options.configPath ?? ".expo-explore/config.yaml";
const now = Date.now();
const state: PublicCommentState = {
phase: "failed", mode: "changes", executionMode: "deterministic", configPath,
pullRequest: { repositoryId: String(pr.base?.repo?.id ?? ""), repository: options.repository, number: options.pullNumber, title: String(pr.title ?? ""), url: String(pr.html_url ?? ""),
base: { ref: String(pr.base?.ref ?? ""), sha: options.baseSha }, head: { ref: String(pr.head?.ref ?? ""), sha: options.headSha } },
// No artifact URL, so no Viewer link: the target would only pick a report that this failure never uploaded.
links: viewerLinks({ repository: options.repository, headSha: options.headSha, runId: options.runId, runAttempt: options.runAttempt, configPath }),
startedAt: now, updatedAt: now, artifactOnly: true,
...(platform ? { build: { platform, easProfile: "" } } : {}),
failure: { step: diagnostic?.stage ?? "workflow", message: diagnostic
? `${diagnostic.code}: ${diagnostic.message} Next action: ${diagnostic.nextAction}`
: "Explore could not finish this review. See the run for the error code, cause, and next action. Fix the reported issue and rerun Explore." },
...(superseded ? { superseded: true } : {}),
};
await upsertStickyComment({ repository: options.repository, issueNumber: options.pullNumber, body: renderPublicComment(state, undefined, target),
...platformSectionMerge(state, target), token, fetchImpl: transport });
}
const located = options.diagnosticsPath ? await locateFailureDiagnostic(options.diagnosticsPath) : undefined;
const target = requested ?? located?.target;
// The failure job knows a target by its id alone; the comment's own record for that id supplies its label and platform.
const platform: ExplorePlatform | undefined = target === "ios" || target === "android" ? target : undefined;
const configPath = options.configPath ?? ".expo-explore/config.yaml";
const now = Date.now();
const diagnostic = located?.diagnostic;
const state: PublicCommentState = {
phase: "failed", mode: "changes", executionMode: "deterministic", configPath,
pullRequest: { repositoryId: String(pr.base?.repo?.id ?? ""), repository: options.repository, number: options.pullNumber, title: String(pr.title ?? ""), url: String(pr.html_url ?? ""),
base: { ref: String(pr.base?.ref ?? ""), sha: options.baseSha }, head: { ref: String(pr.head?.ref ?? ""), sha: options.headSha } },
// No artifact URL, so no Viewer link: the target would only pick a report that this failure never uploaded.
links: viewerLinks({ repository: options.repository, headSha: options.headSha, runId: options.runId, runAttempt: options.runAttempt, configPath }),
startedAt: now, updatedAt: now, artifactOnly: true,
...(platform ? { build: { platform, easProfile: "" } } : {}),
failure: { step: diagnostic?.stage ?? "workflow", message: diagnostic
? `${diagnostic.code}: ${diagnostic.message} Next action: ${diagnostic.nextAction}`
: "Explore could not finish this review. See the run for the error code, cause, and next action. Fix the reported issue and rerun Explore." },
...(superseded ? { superseded: true } : {}),
};
await upsertStickyComment({ repository: options.repository, issueNumber: options.pullNumber, body: renderPublicComment(state, undefined, target),
...platformSectionMerge(state, target), token, fetchImpl: transport });
return { posted: true, ...(superseded ? { superseded: true } : {}) };
}
-25
View File
@@ -1,25 +0,0 @@
/**
* Pauses between attempts of a GitHub lookup that may succeed later, 45 seconds in all. GitHub's Actions API is
* eventually consistent just after an upload: in brentvatne/euxy's review run 39348956443, the duo-closed report job's
* `actions/artifacts/<id>` answered 404 for the artifact that job had just uploaded, while the other four targets'
* jobs found theirs.
*/
const GITHUB_LOOKUP_RETRY_DELAYS_MS = [3_000, 6_000, 12_000, 24_000] as const;
/**
* Runs a read-only GitHub lookup again after each pause while `transient` says its failure may clear on its own. The
* caller decides what is transient; any other failure, or the last one, is thrown as it is.
*/
export async function retryGitHubLookup<T>(lookup: () => Promise<T>, transient: (error: unknown) => boolean,
sleep: (milliseconds: number) => Promise<void> = milliseconds => new Promise<void>(done => setTimeout(done, milliseconds))): Promise<T> {
for (let retry = 0; ; retry += 1) {
try { return await lookup(); }
catch (error) {
const delayMs = GITHUB_LOOKUP_RETRY_DELAYS_MS[retry];
if (delayMs === undefined || !transient(error)) throw error;
// A lookup that succeeds later would otherwise leave no trace of the failure in the job log.
process.stderr.write(`GitHub lookup failed (${(error instanceof Error ? error.message : String(error)).split("\n", 1)[0]}); trying again in ${delayMs / 1000} s\n`);
await sleep(delayMs);
}
}
}
+7 -37
View File
@@ -5,7 +5,6 @@ import { CI_COMMENT_MARKER } from "./pr-comment.js";
import { CHANGE_GROUPS, MAX_COMMENT_TARGETS, MAX_NAVIGATION_EDGES, MAX_NAVIGATION_NODES, compareTargets, defaultTargetLabel, foldRecord, strongerGroup, historyLine, orderedPrevious, orderedRecords, previousLine, readCommentRecords, recordLabel, recordLine, recordSummary,
type ChangeGroup, type CommentNavigation, type CommentTarget, type CommentRecords, type HistoryEntry, type NavigationGroup, type NavigationKind, type PlatformRecord } from "./pr-comment-record.js";
import { isAccessibilityOnlyChange } from "../contracts/review-validation.js";
import { neverCapturedSurfaceIds } from "../contracts/surface-capture.js";
import type { PublicCaptureHealth, PublicEvidenceSummary } from "../review/evidence-assessment.js";
import type { ReviewPresentation } from "../contracts/review.js";
import type { ViewerLinks } from "./viewer-links.js";
@@ -143,16 +142,6 @@ function notComparedChange(surface: Surface): boolean {
return verified && (!surface.review || surface.visual?.reason === "diff-failed");
}
/**
* An accessibility-only change whose elements lie past the edge of the screen (the review's `offScreen`), so another
* target's row can say the change is there, off-screen, rather than missing. Like notComparedChange, a comparison that
* failed or a redirect is not one.
*/
function offScreenChange(surface: Surface): boolean {
return surface.review?.offScreen === true && isAccessibilityOnlyChange(surface) && surface.visual?.reason !== "diff-failed"
&& (surface.head ?? surface.base)?.kind !== "redirect";
}
function routeOf(surface: Surface): string {
return plainText(surface.head?.route || surface.base?.route || surface.id, MAX_ROUTE_LENGTH);
}
@@ -305,15 +294,12 @@ export function platformRecordOf(state: PublicCommentState, target?: CommentTarg
if (state.review) {
const evidenceBased = state.review.surfaces.some(surface => surface.review);
record.changes = [];
// A route the run never captured on purpose is not one of the report's screens, here as in the Viewer.
const omitted = neverCapturedSurfaceIds(state.review);
for (const surface of state.review.surfaces) {
if (omitted.has(surface.id)) continue;
if ((surface.head ?? surface.base)?.kind === "redirect") continue;
const group = groupOf(surface, evidenceBased);
if (group === "unlisted") continue;
const scheme = schemeOf(surface.id);
record.changes.push({ id: surface.id, route: routeOf(surface), group, description: descriptionOf(surface, group), ...(scheme ? { scheme } : {}),
...(group === "accessibility-only" && offScreenChange(surface) ? { offScreen: true as const } : {}) });
record.changes.push({ id: surface.id, route: routeOf(surface), group, description: descriptionOf(surface, group), ...(scheme ? { scheme } : {}) });
}
const navigation = state.map ? navigationOf(state.review, new Map(record.changes.map(change => [change.id, change.group]))) : undefined;
if (navigation) record.navigation = navigation;
@@ -362,10 +348,9 @@ function navigationOf(review: PublicReview, groups: Map<string, ChangeGroup>): C
if (!review.navigation) return undefined;
const keyOf = new Map<string, string>();
const groupOf = new Map<string, NavigationGroup>();
const omitted = neverCapturedSurfaceIds(review);
for (const surface of review.surfaces) {
const route = surface.head ?? surface.base;
if (!route || omitted.has(surface.id)) continue;
if (!route || route.kind === "redirect") continue;
const key = routePattern(route);
keyOf.set(surface.id.replace(/@(light|dark)$/, ""), key);
const group = groups.get(surface.id);
@@ -573,24 +558,10 @@ function renderChangeRow(row: ChangeRow, ready: PlatformRecord[]): string {
text = `${route} · ${description}`;
}
const tag = row.group === "accessibility-only" ? "accessibility only" : row.group === "needs-review" ? "needs review" : undefined;
return `- ${[text, tag, ...whereNote(row, ready)].filter(Boolean).join(" · ")}`;
}
/**
* Where a screen's change shows. A target whose screenshots match because the changed elements lie past the edge of the
* screen has the change, off-screen, so it is named apart: "iPhone 17, Android only · off-screen on iPhone Duo (closed)"
* for Tempo's footnote below the fold of its sheet in brentvatne/euxy#172 (review run 39362642343). The targets that show
* it are still named the shorter way among the others (none when all of them do); without such a target the note is what
* it always was.
*/
function whereNote(row: ChangeRow, ready: PlatformRecord[]): string[] {
const offScreen = row.group === "modified"
? row.targets.filter(record => record.changes?.some(change => change.id === row.id && change.offScreen === true)) : [];
const shown = row.targets.filter(record => !offScreen.includes(record));
// A target with screens it has no verdict on may have changed this one too: name where it changed, not where it did not.
const unsure = ready.some(record => !row.targets.includes(record) && gaps(record).length);
const visible = unsure ? `on ${shown.map(labelOf).join(", ")}` : targetsNote(shown, ready.filter(record => !offScreen.includes(record)));
return [visible, offScreen.length ? `off-screen on ${offScreen.map(labelOf).join(", ")}` : undefined].filter((part): part is string => Boolean(part));
const where = ready.some(record => !row.targets.includes(record) && gaps(record).length)
? `on ${row.targets.map(labelOf).join(", ")}` : targetsNote(row.targets, ready);
return `- ${[text, tag, where].filter(Boolean).join(" · ")}`;
}
/** "Android only" / "not on Android": the targets a screen changed on, when not all of them, named the shorter way. */
@@ -747,9 +718,8 @@ export function reviewDevice(state: { runtime?: Pick<SimulatorRuntimeMetadata, "
export function reviewChanges(review: PublicReview): Map<string, ChangeGroup> {
const evidenceBased = review.surfaces.some(surface => surface.review);
const changes = new Map<string, ChangeGroup>();
const omitted = neverCapturedSurfaceIds(review);
for (const surface of review.surfaces) {
if (omitted.has(surface.id)) continue;
if ((surface.head ?? surface.base)?.kind === "redirect") continue;
const group = groupOf(surface, evidenceBased);
if (group !== "unlisted") changes.set(surface.id, group);
}
+3 -7
View File
@@ -103,11 +103,8 @@ export type PlatformRecord = {
accessibility?: { compared: number; described: number; failed: number };
routes?: number;
};
/**
* The review's changed surfaces, one per surface; `scheme` for a secondary appearance (`<route>@<scheme>`). `offScreen`
* marks an accessibility-only change whose elements lie past the edge of the screen.
*/
changes?: { id: string; route: string; group: ChangeGroup; description: string; scheme?: string; offScreen?: true }[];
/** The review's changed surfaces, one per surface; `scheme` for a secondary appearance (`<route>@<scheme>`). */
changes?: { id: string; route: string; group: ChangeGroup; description: string; scheme?: string }[];
/** Screens whose source changed and whose captures were verified, but that got no verdict: the comparison did not run or failed. */
notCompared?: number;
/** Differences stated once rather than per screen (variants, app-wide source changes). */
@@ -273,8 +270,7 @@ export function parsePlatformRecord(value: unknown): PlatformRecord | undefined
if (Array.isArray(value.changes)) {
const changes = value.changes.flatMap((entry): NonNullable<PlatformRecord["changes"]> => isRecord(entry) && isString(entry.id, 220) && isString(entry.route, 2000)
&& CHANGE_GROUPS.includes(entry.group as ChangeGroup) && isString(entry.description, 2000)
? [{ id: entry.id, route: entry.route, group: entry.group as ChangeGroup, description: entry.description, ...(isString(entry.scheme, 20) ? { scheme: entry.scheme } : {}),
...(entry.offScreen === true && entry.group === "accessibility-only" ? { offScreen: true as const } : {}) }] : []);
? [{ id: entry.id, route: entry.route, group: entry.group as ChangeGroup, description: entry.description, ...(isString(entry.scheme, 20) ? { scheme: entry.scheme } : {}) }] : []);
if (changes.length <= 2000) record.changes = changes;
}
const navigation = parseNavigation(value.navigation);
+20 -81
View File
@@ -7,7 +7,6 @@ import { Uint8ArrayReader, Uint8ArrayWriter, ZipWriter, configure } from "@zip.j
import { loadReport, MAX_METADATA_BYTES } from "./agent-api.js";
import { MAX_ASSET_BYTES, manifestBody, PREVIEW_ASSET } from "./preview-manifest.js";
import { publishCiReportComment, readCiReportInput, type CiReportInput } from "./artifact.js";
import { retryGitHubLookup } from "./github-lookup.js";
import { readZipDirectory, readZipEntry } from "./zip-reader.js";
import { reviewChangeCount, reviewDevice } from "./pr-comment-body.js";
import { isTargetId, warnIgnoredExpiry, type ExplorePlatform } from "../config/explore-config.js";
@@ -55,7 +54,7 @@ export type PreviewDeployOptions = (PreviewReportInput | {
environment?: NodeJS.ProcessEnv;
transport?: typeof fetch;
run?: CommandRunner;
/** Pause between `eas deploy` attempts and between GitHub lookups that may succeed later; tests replace it so retries take no real time. */
/** Pause between `eas deploy` attempts; tests replace it so retries take no real time. */
sleep?: (milliseconds: number) => Promise<void>;
/** The preview export (client/ and server/); defaults to the one shipped in this package. */
exportPath?: string;
@@ -387,7 +386,7 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
if (pr.origin !== "compare") for (const report of reports) {
try {
await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
...commentTarget(report), previewFailed: true, ...(options.sleep ? { sleep: options.sleep } : {}) });
...commentTarget(report), previewFailed: true });
} catch { /* the deployment failure is the one to report */ }
}
throw error;
@@ -399,7 +398,7 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
let headSha = pr.head.sha;
if (pr.origin !== "compare") for (const report of reports) {
const published = await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
...commentTarget(report), preview: { url: previewUrl, expiresAt: null }, ...(options.sleep ? { sleep: options.sleep } : {}) });
...commentTarget(report), preview: { url: previewUrl, expiresAt: null } });
headSha = published.headSha;
}
return { previewUrl, expiresAt: null, deploymentId: hosted.deploymentId, deploymentUrl: hosted.deploymentUrl,
@@ -436,9 +435,7 @@ async function writeCompareSummary(environment: NodeJS.ProcessEnv, comparison: C
}
type HostedReportInput = { zip: Uint8Array; sha256: string; file: string; query: string };
export type HostedDeployment = { previewUrl: string; expiresAt: string | null; deploymentId: string; deploymentUrl: string; aliasUrl?: string;
/** The link is the alias, which still served an earlier deployment when the wait for it ran out. */
aliasBehind?: true; project: string; owner: string };
export type HostedDeployment = { previewUrl: string; expiresAt: string | null; deploymentId: string; deploymentUrl: string; aliasUrl?: string; project: string; owner: string };
/** EAS Hosting alias names: lowercase slugs, as `eas deploy --alias` normalises them. */
export const HOSTING_ALIAS = /^[a-z0-9][a-z0-9-]{0,38}[a-z0-9]$/;
@@ -498,13 +495,6 @@ async function deployReports(options: {
alias?: string;
/** A caller-chosen `/p/<token>`; with `alias`, the hosted link is identical from one run to the next. */
token?: string;
/** How long the alias has to serve this deployment once the deployment does; `verifyTimeoutMs` by default. */
aliasWaitMs?: number;
/**
* Link the alias even when it still serves an earlier deployment after `aliasWaitMs`, for a link whose readers are
* told it can lag, rather than the deployment's own host.
*/
linkBehindAlias?: boolean;
sleep?: (milliseconds: number) => Promise<void>;
}): Promise<HostedDeployment> {
const { reports, project, environment, run, transport, now, random } = options;
@@ -581,8 +571,7 @@ async function deployReports(options: {
throw deployError("PREVIEW_DEPLOY_FAILED", `EAS Hosting deployed ${deploymentUrl.origin} but did not report the alias ${options.alias}.`,
"Check the deployment's aliases in the EAS Hosting dashboard and rerun.", { retryable: true, details: { project, owner, alias: options.alias } });
}
const verify = (origin: string, alias = false) => verifyDeployment({ origin, token, transport, now, alias,
timeoutMs: alias ? options.aliasWaitMs ?? options.verifyTimeoutMs : options.verifyTimeoutMs,
const verify = (origin: string, alias = false) => verifyDeployment({ origin, token, transport, now, timeoutMs: options.verifyTimeoutMs, alias,
reports: reports.map((report, index) => ({ query: report.query, ...written[index]! })),
...(listing ? { listing: JSON.stringify(listing.map(({ path: _path, ...rest }) => rest)) } : {}) });
const seconds = (milliseconds: number) => `${Math.round(milliseconds / 1000)} s after eas deploy returned`;
@@ -592,9 +581,7 @@ async function deployReports(options: {
// taken longer than the whole budget (every verification failure of 2026-10-14 was the alias, with the deployment
// serving in 1 s). The deployment is verified and immutable, so when the alias is still behind the pull request
// links the deployment instead of failing the job; the alias catches up on its own and the next push relinks it.
// With `linkBehindAlias` it links the alias anyway, and its readers are told the link can lag.
let linkOrigin = deploymentUrl.origin;
let aliasBehind = false;
if (aliasUrl) {
try {
const alias = await verify(aliasUrl.origin, true);
@@ -602,16 +589,12 @@ async function deployReports(options: {
linkOrigin = aliasUrl.origin;
} catch (error) {
if ((error as { code?: string }).code !== "PREVIEW_ALIAS_BEHIND") throw error;
aliasBehind = Boolean(options.linkBehindAlias);
if (aliasBehind) linkOrigin = aliasUrl.origin;
process.stderr.write(`::warning::${(error as Error).message} ${aliasBehind
? `The pull request links it anyway, until it catches up, beside the deployment ${deploymentUrl.origin}.`
: `The pull request links the deployment ${deploymentUrl.origin} instead.`}\n`);
process.stderr.write(`::warning::${(error as Error).message} The pull request links the deployment ${deploymentUrl.origin} instead.\n`);
}
}
const previewUrl = `${linkOrigin}/p/${token}`;
return { previewUrl, expiresAt: null, deploymentId: deployment.identifier!, deploymentUrl: deploymentUrl.origin,
...(aliasUrl ? { aliasUrl: aliasUrl.origin } : {}), ...(aliasBehind ? { aliasBehind: true as const } : {}), project, owner };
...(aliasUrl ? { aliasUrl: aliasUrl.origin } : {}), project, owner };
} finally {
await rm(work, { recursive: true, force: true });
}
@@ -685,20 +668,8 @@ export type FixturePreviewOptions = {
random?: (bytes: number) => Uint8Array;
onSecret?: (secret: string) => void;
verifyTimeoutMs?: number;
/** How long the alias has to serve the new deployment before the link is the alias anyway; FIXTURE_ALIAS_WAIT_MS by default. */
aliasWaitMs?: number;
};
/**
* How long a fixture preview waits for its alias. An edge of EAS Hosting that served an alias keeps serving the
* deployment it named for about five minutes (307–314 s, measured 2026-10-19 redeploying back to back from one machine),
* so a deploy whose check reaches an edge that served the alias in the last five minutes, to the previous deploy's check
* or to a reviewer, finds it behind; otherwise it has moved within seconds. Waiting the whole verification budget for
* that held a third of the pull requests' deploy jobs for three minutes, only to link the deployment instead. The pull
* request's comment says when the alias is behind.
*/
export const FIXTURE_ALIAS_WAIT_MS = 20_000;
/**
* Host fixed reports behind a fixed alias with this checkout's Viewer: the Explore repository's own pull requests
* preview their Viewer changes on real data. No GitHub token, no expiry; each run replaces what the alias serves.
@@ -726,7 +697,6 @@ export async function deployFixturePreview(options: FixturePreviewOptions): Prom
projectHint: "Give EXPO_TOKEN's account permission to create projects, or pass --project with an existing slug.",
exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}), transport: options.transport ?? fetch, now: options.now ?? Date.now, random,
...(options.onSecret ? { onSecret: options.onSecret } : {}), verifyTimeoutMs: options.verifyTimeoutMs ?? 180_000, alias: options.alias,
aliasWaitMs: options.aliasWaitMs ?? FIXTURE_ALIAS_WAIT_MS, linkBehindAlias: true,
...(options.token ? { token: options.token } : {}) });
}
@@ -790,43 +760,23 @@ export async function deployLocalReports(options: {
/** explore-(capture|review)-<run>-<attempt>-<target id>; the id starts with a letter, so the run and attempt end unambiguously. */
const ARTIFACT_DIRECTORY = /^explore-(capture|review)-\d+-\d+-([a-z][a-z0-9-]{0,31})$/;
/**
* The target a lone artifact holds. actions/download-artifact puts each artifact a pattern matches in a directory named
* after it, except when the pattern matches exactly one, which it extracts into the download path itself: then only the
* report names its target (its platform for configs without targets).
*/
async function unnamedArtifactTarget(root: string, kind: "capture" | "review"): Promise<string | undefined> {
const file = join(root, kind === "capture" ? "report-input.json" : "review.json");
if (!(await lstat(file).catch(() => undefined))?.isFile()) return undefined;
const runtime = kind === "capture" ? (await readCiReportInput(file)).publicReview.runtime
: (JSON.parse(await readFile(file, "utf8")) as Partial<ArtifactReport>).review?.runtime;
const id = readTarget(runtime?.target)?.id ?? runtime?.platform;
return isTargetId(id) ? id : undefined;
}
/**
* The fan-in deploy job's inputs: actions/download-artifact puts each explore-capture-<run>-<attempt>-<target>
* directory under --inputs and each explore-review-… directory under --reports (the target is the platform for
* configs without targets). Pairs them by target, in the order the run's review lists its targets, and looks up each
* report artifact's URL on the run, since matrix jobs cannot hand their artifact URLs forward. A target whose capture
* failed uploaded no capture artifact, and one whose report job failed no report artifact: the preview serves the
* targets that have both, and the review workflow's failure job names the others on the comment.
* report artifact's URL on the run, since matrix jobs cannot hand their artifact URLs forward.
*/
export async function collectPlatformReports(options: { inputsPath: string; reportsPath: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch;
/** Pause between artifact lookups that may succeed later; tests replace it so retries take no real time. */
sleep?: (milliseconds: number) => Promise<void> }): Promise<PreviewReportInput[]> {
export async function collectPlatformReports(options: { inputsPath: string; reportsPath: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch }): Promise<PreviewReportInput[]> {
const environment = options.environment ?? process.env; const transport = options.transport ?? fetch;
const directories = async (root: string, kind: "capture" | "review") => {
const found = new Map<string, string>();
// A pattern that matched nothing leaves no directory behind.
for (const name of (await readdir(root).catch(() => [] as string[])).sort()) {
for (const name of (await readdir(root)).sort()) {
const match = ARTIFACT_DIRECTORY.exec(name);
if (!match || match[1] !== kind || !isTargetId(match[2])) continue;
if (found.has(match[2]!)) throw previewError("PREVIEW_REPORTS_INVALID", `Several ${kind} artifacts for ${match[2]} were downloaded`,
"Download only this run attempt's artifacts into the --inputs and --reports directories.");
found.set(match[2]!, join(root, name));
}
if (!found.size) { const id = await unnamedArtifactTarget(root, kind); if (id) found.set(id, root); }
return found;
};
const inputs = await directories(options.inputsPath, "capture"); const reports = await directories(options.reportsPath, "review");
@@ -837,9 +787,8 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
const entries: PreviewReportInput[] = [];
for (const [id, inputDirectory] of inputs) {
const reportPath = reports.get(id);
// In brentvatne/euxy#172 (review run 39348956443) one target's failed job kept every other target's report off the
// PR; a target without a report is left out of the preview instead.
if (!reportPath) { process.stderr.write(`The ${id} capture has no report artifact (its report job failed), so the preview leaves it out.\n`); continue; }
if (!reportPath) throw previewError("PREVIEW_REPORTS_INCOMPLETE", `The ${id} capture has no report artifact to deploy`,
"Rerun the workflow; the report job for that target did not upload its explore-review artifact.");
const inputPath = join(inputDirectory, "report-input.json");
const runtime = (await readCiReportInput(inputPath)).publicReview.runtime;
// A report from before targets names only its platform, and its artifact is named after it.
@@ -849,8 +798,6 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
const target = named ?? (id === "ios" || id === "android" ? platformTarget(id) : { id, platform: runtime.platform ?? "ios", label: id });
entries.push({ ...(id === target.platform ? { platform: target.platform } : {}), target, inputPath, reportPath, artifactUrl: "" });
}
if (!entries.length) throw previewError("PREVIEW_REPORTS_INCOMPLETE", "No target's capture has a report artifact to deploy",
"Rerun the workflow; the report jobs did not upload their explore-review artifacts.");
// Config order, as the review lists its targets (or, before targets, its platforms); directory order otherwise.
const listed = (await readCiReportInput(entries[0]!.inputPath)).publicReview.runtime;
const order: string[] = listed.targets?.map(target => target.id) ?? listed.platforms ?? [];
@@ -865,22 +812,14 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
for (const entry of entries) {
const name = `explore-review-${review.runId}-${review.runAttempt}-${entry.target!.id}`;
const url = `https://api.github.com/repos/${repository}/actions/runs/${review.runId}/artifacts?per_page=100&name=${encodeURIComponent(name)}`;
// The run's artifact list can lag an upload, as the artifact lookup of a report job's publication does, so an
// empty list, a 404, a 5xx or no answer is looked up again; a bad token or a missing permission fails at once.
const artifact = await retryGitHubLookup(async () => {
const response = await transport(url, { headers: { accept: "application/vnd.github+json", authorization: `Bearer ${environment.GITHUB_TOKEN ?? ""}`,
"x-github-api-version": "2022-11-28" }, signal: AbortSignal.timeout(60_000) });
const body = response.ok ? await response.json() as { artifacts?: Array<{ id?: unknown; name?: unknown; expired?: unknown }> } : undefined;
const found = body?.artifacts?.find(candidate => candidate.name === name && candidate.expired !== true);
if (!found || typeof found.id !== "number" || !Number.isSafeInteger(found.id) || found.id <= 0) {
throw deployError("REPORT_ARTIFACT_MISSING", `The run has no artifact named ${name} (HTTP ${response.status}).`,
"Rerun the workflow so every target's report job uploads its artifact before the deploy job runs.", { retryable: true, details: { status: response.status } });
}
return found;
}, error => {
const status = error instanceof CiError ? error.details?.status : undefined;
return !(error instanceof CiError) || typeof status === "number" && (status === 200 || status === 404 || status >= 500);
}, options.sleep);
const response = await transport(url, { headers: { accept: "application/vnd.github+json", authorization: `Bearer ${environment.GITHUB_TOKEN ?? ""}`,
"x-github-api-version": "2022-11-28" }, signal: AbortSignal.timeout(60_000) });
const body = response.ok ? await response.json() as { artifacts?: Array<{ id?: unknown; name?: unknown; expired?: unknown }> } : undefined;
const artifact = body?.artifacts?.find(candidate => candidate.name === name && candidate.expired !== true);
if (!artifact || typeof artifact.id !== "number" || !Number.isSafeInteger(artifact.id) || artifact.id <= 0) {
throw deployError("REPORT_ARTIFACT_MISSING", `The run has no artifact named ${name} (HTTP ${response.status}).`,
"Rerun the workflow so every target's report job uploads its artifact before the deploy job runs.", { retryable: true });
}
entry.artifactUrl = `https://github.com/${repository}/actions/runs/${review.runId}/artifacts/${artifact.id}`;
}
return entries;
-1
View File
@@ -716,7 +716,6 @@ export async function assessPublicEvidence(options: {
const summary = summarizeReviewerChanges({ changes: result.reviewerChanges });
accessibilityCounts.compared += 1;
review = decideReview(scope, visual, summary);
if (result.offScreen && review.status === "modified" && visual.verdict === "unchanged") review = { ...review, offScreen: true };
if (review.facts?.length) accessibilityCounts.described += 1;
} catch (error) {
accessibilityCounts.failed += 1;
-52
View File
@@ -93,8 +93,6 @@ export type EvidenceComparatorResult = {
visualAssessment?: VisualEvidenceAssessment;
/** Feed directly to summarizeReviewerChanges. */
reviewerChanges: ReviewerChangeInput[];
/** The screenshots match, and every element the changes name lies at least partly past the edge of the screen. */
offScreen?: true;
};
type SupportedInput = Extract<ReviewerChangeInput, { assessment: "supported" }>;
@@ -619,54 +617,6 @@ function outermost(elements: readonly ObservedElement[]): ObservedElement[] {
});
}
/**
* The screen in its accessibility tree's units: the element at the origin with the screenshot's shape (either way round,
* since a frame turned to show an opened iPhone Duo upright keeps the tree on the panel's portrait axes), the largest if
* several. Both controllers report the app's root that way. Without the screenshot's size there is no telling which
* element is the screen.
*/
function viewportOf(side: ResolvedSide): ElementBounds | undefined {
const image = side.map.artifacts.find(artifact => artifact.id === side.observation.screenshotArtifactId);
if (!image?.width || !image.height) return undefined;
const { width, height } = image;
const shaped = (bounds: ElementBounds) => Math.abs(bounds.width * height - bounds.height * width) <= 0.01 * width * height
|| Math.abs(bounds.width * width - bounds.height * height) <= 0.01 * width * height;
return side.observation.elements.flatMap(element => boundsOf(element) ?? [])
.filter(bounds => Math.abs(bounds.x) < 1 && Math.abs(bounds.y) < 1 && bounds.width > 0 && bounds.height > 0 && shaped(bounds))
.sort((a, b) => b.width * b.height - a.width * a.height)[0];
}
/**
* Whether the screenshots cannot show the changes because the elements they name lie past the edge of the screen: each
* change names at least one element, and more than half of each named element's area is beyond the screen on its side.
* Both controllers leave an element wholly outside the screen out of the tree (the Argent bridge as agent-device does),
* so a change past the edge can only show as an element straddling it, as Tempo's footnote below the fold of its sheet
* on the closed iPhone Duo in brentvatne/euxy#172 (review run 39362642343) would. Mostly outside, not merely crossing
* an edge: a control nudged a point or two past the edge is still on the screen, and its change stays "accessibility
* only". A change whose elements have no bounds never qualifies.
*/
function changesOffScreen(facts: readonly SupportedInput[], base: ResolvedSide, head: ResolvedSide): boolean {
const changes = facts.filter(fact => !["unstable-text", "no-visible-change", "visual-changed"].includes(fact.change.kind));
if (!changes.length) return false;
const viewports = { base: viewportOf(base), head: viewportOf(head) };
const outside = (reference: string) => {
const [, side, id] = /^(base|head):element:(.+)$/.exec(reference) ?? [];
if (side !== "base" && side !== "head") return undefined;
const viewport = viewports[side];
const element = (side === "base" ? base : head).observation.elements.find(candidate => candidate.elementId === id);
const bounds = element && boundsOf(element);
if (!viewport || !bounds) return false;
const visibleWidth = Math.max(0, Math.min(bounds.x + bounds.width, viewport.x + viewport.width) - Math.max(bounds.x, viewport.x));
const visibleHeight = Math.max(0, Math.min(bounds.y + bounds.height, viewport.y + viewport.height) - Math.max(bounds.y, viewport.y));
const area = bounds.width * bounds.height;
return area > 0 && visibleWidth * visibleHeight < area / 2;
};
return changes.every(fact => {
const named = fact.evidenceRefs.map(outside).filter((value): value is boolean => value !== undefined);
return named.length > 0 && named.every(Boolean);
});
}
function specificByLabel(elements: readonly ObservedElement[]): ObservedElement[] {
const byLabel = new Map<string, ObservedElement>();
const unlabelled: ObservedElement[] = [];
@@ -1326,7 +1276,6 @@ function commonResult(input: CommonSurfaceComparatorInput): EvidenceComparatorRe
const status: "modified" | "unchanged" = hasRuntimeDelta || reasons.length > 0
? "modified"
: "unchanged";
const offScreen = input.visualAssessment.status === "unchanged" && changesOffScreen(facts, base, head);
return {
surfaceId: input.impact.id,
status,
@@ -1339,7 +1288,6 @@ function commonResult(input: CommonSurfaceComparatorInput): EvidenceComparatorRe
),
visualAssessment: input.visualAssessment,
reviewerChanges,
...(offScreen ? { offScreen: true as const } : {}),
};
}
+1 -7
View File
@@ -148,12 +148,6 @@ export async function reportCiError(error: unknown, options: {
env?: NodeJS.ProcessEnv;
secrets?: readonly string[];
diagnosticsPath?: string;
/**
* The matrix target the failed command ran for, written into the diagnostics file. actions/download-artifact puts an
* artifact in a directory named after it only when a pattern matches several, so the failure job cannot always read
* the target from where the file lands.
*/
target?: string;
write?: (value: string) => void;
} = {}): Promise<CiErrorData> {
const env = options.env ?? process.env;
@@ -172,7 +166,7 @@ export async function reportCiError(error: unknown, options: {
if (env.GITHUB_STEP_SUMMARY) outputs.push({ label: "job summary", operation: appendFile(env.GITHUB_STEP_SUMMARY, `${renderCiErrorSummary(error, renderOptions)}\n`) });
if (options.diagnosticsPath) outputs.push({ label: "diagnostics file", operation: (async () => {
await mkdir(dirname(options.diagnosticsPath!), { recursive: true });
await writeFile(options.diagnosticsPath!, `${JSON.stringify(options.target ? { ...diagnostic, target: options.target } : diagnostic, null, 2)}\n`);
await writeFile(options.diagnosticsPath!, `${JSON.stringify(diagnostic, null, 2)}\n`);
})() });
const results = await Promise.allSettled(outputs.map(output => output.operation));
for (const [index, result] of results.entries()) {
+7 -33
View File
@@ -219,12 +219,8 @@ jobs:
${{ runner.temp }}/explore-review/agent-usage.jsonl
retention-days: 7
if-no-files-found: ignore
# Each target's report runs once its own capture uploaded one, whatever the other targets' captures did, as in the
# review workflow (brentvatne/euxy#172): needs.capture.result is the whole matrix's, so each leg looks for its own
# artifact, and a target whose capture failed packages and links nothing. !cancelled() keeps a cancelled run stopped.
report:
needs: [targets, capture]
if: needs.targets.result == 'success' && !cancelled()
strategy:
fail-fast: false
matrix:
@@ -233,34 +229,19 @@ jobs:
timeout-minutes: 20
permissions:
contents: read
outputs:
# "true" from every leg that linked its report, so "true" once any did: the deploy job runs only then.
published: ${{ steps.publish.outputs.published }}
env:
TARGET: ${{ matrix.target }}
steps:
# Downloading by name fails when the artifact is missing. A pattern that matches nothing downloads nothing and
# succeeds, so only a download that went wrong fails this step; its one match is extracted into the path itself.
- name: Download this target's captured review
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-review
- name: Check that this target's capture succeeded
id: captured
shell: bash
run: |
set -euo pipefail
if [[ -f "$RUNNER_TEMP/explore-review/report-input.json" ]]; then echo "found=true" >> "$GITHUB_OUTPUT"
else echo "The $TARGET capture uploaded no review: its capture job failed."; fi
- *setup-node
- *install-explore
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-review
- name: Package the report
if: steps.captured.outputs.found == 'true'
shell: bash
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --target "$TARGET"
- name: Upload the report
if: steps.captured.outputs.found == 'true'
id: report
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
@@ -269,15 +250,10 @@ jobs:
retention-days: 30
if-no-files-found: error
- name: Link the report from the run summary
if: steps.captured.outputs.found == 'true'
id: publish
env:
ARTIFACT_URL: ${{ steps.report.outputs.artifact-url }}
shell: bash
run: |
set -euo pipefail
node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
echo "published=true" >> "$GITHUB_OUTPUT"
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
- name: Upload report failure diagnostics
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
@@ -288,10 +264,9 @@ jobs:
if-no-files-found: ignore
# Hosted report (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment serving every target's report.
# This is the only job after capture that holds EXPO_TOKEN; it writes the link to the run summary.
# It runs once any target linked its report, and serves the targets that did; a failed target has no report to wait for.
deploy:
needs: [targets, capture, report]
if: needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()
if: needs.capture.outputs.preview == 'eas'
runs-on: ubuntu-22.04
timeout-minutes: 20
permissions:
@@ -300,8 +275,7 @@ jobs:
steps:
- *setup-node
- *install-explore
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>),
# or a lone artifact's files in the path itself; ci:deploy reads both.
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>).
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*
+9 -37
View File
@@ -207,14 +207,8 @@ jobs:
${{ runner.temp }}/explore-review/agent-usage.jsonl
retention-days: 7
if-no-files-found: ignore
# Each target's report runs once its own capture uploaded one, whatever the other targets' captures did: in
# brentvatne/euxy#172 (run 39348956443) one flaky simulator session failed one of five captures, and with the report
# waiting on every capture the PR got no report at all. needs.capture.result is the whole matrix's, so each leg looks
# for its own artifact instead; a target whose capture failed uploaded none, packages and publishes nothing here, and
# is named by the failure job. !cancelled() lets the legs run after a failed capture leg, but not in a cancelled run.
report:
needs: [targets, capture]
if: needs.targets.result == 'success' && !cancelled()
strategy:
fail-fast: false
matrix:
@@ -225,34 +219,19 @@ jobs:
contents: read
actions: read
pull-requests: write
outputs:
# "true" from every leg that published, so "true" once any did: the deploy job runs only then.
published: ${{ steps.publish.outputs.published }}
env:
TARGET: ${{ matrix.target }}
steps:
# Downloading by name fails when the artifact is missing. A pattern that matches nothing downloads nothing and
# succeeds, so only a download that went wrong fails this step; its one match is extracted into the path itself.
- name: Download this target's captured review
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-review
- name: Check that this target's capture succeeded
id: captured
shell: bash
run: |
set -euo pipefail
if [[ -f "$RUNNER_TEMP/explore-review/report-input.json" ]]; then echo "found=true" >> "$GITHUB_OUTPUT"
else echo "The $TARGET capture uploaded no review: its capture job failed, and the failure job reports it."; fi
- *setup-node
- *install-explore
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-review
- name: Package hosted review bundle
if: steps.captured.outputs.found == 'true'
shell: bash
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --target "$TARGET"
- name: Upload hosted review bundle
if: steps.captured.outputs.found == 'true'
id: viewer
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
@@ -261,16 +240,11 @@ jobs:
retention-days: 30
if-no-files-found: error
- name: Publish current PR hosted links
if: steps.captured.outputs.found == 'true'
id: publish
env:
GITHUB_TOKEN: ${{ github.token }}
ARTIFACT_URL: ${{ steps.viewer.outputs.artifact-url }}
shell: bash
run: |
set -euo pipefail
node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
echo "published=true" >> "$GITHUB_OUTPUT"
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
- name: Upload report failure diagnostics
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
@@ -282,10 +256,9 @@ jobs:
# Hosted preview (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment per review, serving every target's report.
# This is the only job after capture that holds EXPO_TOKEN; the report job stays credential-free and has already
# published the Download report link, so a failed deployment leaves the comment on the download-and-drop flow.
# It runs once any target published its report, and serves the targets that did; a failed target has no report to wait for.
deploy:
needs: [targets, capture, report]
if: needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()
if: needs.capture.outputs.preview == 'eas'
runs-on: ubuntu-22.04
timeout-minutes: 20
permissions:
@@ -295,8 +268,7 @@ jobs:
steps:
- *setup-node
- *install-explore
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>),
# or a lone artifact's files in the path itself; ci:deploy reads both.
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>).
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*
@@ -345,6 +317,6 @@ jobs:
shell: bash
run: |
set -euo pipefail
# The diagnostics artifacts are data files from this run and attempt, never executable report code; each
# error.json names its failed target, which gets a failed record, and the comment keeps every other target's result.
# The diagnostics artifacts are data files from this run and attempt, never executable report code;
# the first error.json names the failed target, and the comment keeps every other target's result.
node "$TOOLS/dist/cli.js" ci:failure --pr "${PR_NUMBER:-0}" --head "${HEAD_SHA:-}" --base "${BASE_SHA:-}" --diagnostics "$RUNNER_TEMP/explore-failure"
+11 -851
View File
@@ -196,7 +196,7 @@ test("the pill shows the app's own icon when the report has one, and the Expo ma
report.review.runtime.appIcon = { url: `https://artifact.expo-explore.invalid/${iconSha}.png`, sha256: iconSha, width: 4, height: 4 };
report.assets.push({ sha256: iconSha, path: iconPath });
const withIcon = await harness(t, await archive(report, [{ name: iconPath, bytes: iconBytes }]), { app: true });
const logo = withIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map of Fixture", exact: true });
const logo = withIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map", exact: true });
await expect(logo.locator("img.panel-app-icon")).toHaveJSProperty("naturalWidth", 4);
await expect(logo.locator(".expo-mark")).toHaveCount(0);
// The tab shows it too, from a Blob URL: the ZIP's own reference is not one the browser can load.
@@ -206,7 +206,7 @@ test("the pill shows the app's own icon when the report has one, and the Expo ma
assert.deepEqual(withIcon.errors, []);
const withoutIcon = await harness(t, await archive(), { app: true });
const mark = withoutIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map of Fixture", exact: true });
const mark = withoutIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map", exact: true });
await expect(mark.locator(".expo-mark")).toHaveCount(1);
await expect(mark.locator("img")).toHaveCount(0);
assert.deepEqual(withoutIcon.errors, []);
@@ -647,259 +647,6 @@ test("a switch to a target whose screenshots have another shape lays the map out
assert.deepEqual(errors, []);
});
/**
* The phone header as drawn, once a resize's fit has run. Its shown controls, each of the row's clipped at the row's
* edges: how many pairs overlap, how many run past the row's end (past the window on a desktop, whose row does not
* clip), and the page's overflow; the target label's parts cut without a fade or faded though whole; the room around
* the row's first and last controls for a focus ring; and the name's width against its text's and its minimum.
*/
function phoneHeader(page) {
return page.locator(".left-panel-collapsed-pill").evaluate(async pill => {
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
const row = pill.querySelector(".collapsed-app-identity");
const clip = row.getBoundingClientRect();
const end = getComputedStyle(row).overflowX === "clip" ? clip.right - parseFloat(getComputedStyle(row).paddingRight) : innerWidth;
const shown = [...pill.querySelectorAll(".panel-logo-button, .collapsed-app-identity > strong, .collapsed-platform, .collapsed-pr, .collapsed-search")]
.filter(node => node.checkVisibility({ visibilityProperty: true }));
const boxes = shown.map(node => {
const box = node.getBoundingClientRect();
return row.contains(node) ? { left: Math.max(box.left, clip.left), right: Math.min(box.right, clip.right) } : box;
});
let overlaps = 0;
for (const [index, a] of boxes.entries()) for (const b of boxes.slice(index + 1)) if (a.left < b.right - 1 && b.left < a.right - 1) overlaps += 1;
const items = shown.filter(node => row.contains(node));
const past = items.filter(node => node.getBoundingClientRect().right > end + 1).length;
const parts = [...row.querySelectorAll(".collapsed-target .collapsed-platform-label, .collapsed-target .collapsed-platform-label-text, .collapsed-target .collapsed-platform-label-suffix")];
const cut = node => node.scrollWidth > node.offsetWidth;
const faded = node => getComputedStyle(node).maskImage !== "none";
const controls = items.filter(node => node.matches(".collapsed-platform, .collapsed-pr"));
const ring = controls.length ? Math.floor(Math.min(controls[0].getBoundingClientRect().left - clip.left, clip.right - controls.at(-1).getBoundingClientRect().right)) : 4;
const name = row.querySelector(":scope > strong");
const minimum = parseFloat(getComputedStyle(row).getPropertyValue("--collapsed-name-min")) || 64;
return {
overlaps, past, overflow: document.documentElement.scrollWidth - innerWidth,
unfaded: parts.filter(node => cut(node) && !faded(node)).length, fadedWhole: parts.filter(node => faded(node) && !cut(node)).length,
ring, targetCut: parts.some(cut),
name: name.checkVisibility({ visibilityProperty: true }) ? { width: name.getBoundingClientRect().width, text: name.scrollWidth, minimum: Math.min(minimum, name.scrollWidth) } : undefined,
};
});
}
/** What a header that fits shows: nothing overlaps or runs past the row, and a label fades exactly where it is cut. */
const FITS = { overlaps: 0, past: 0, overflow: 0, unfaded: 0, fadedWhole: 0 };
const fitOf = ({ overlaps, past, overflow, unfaded, fadedWhole }) => ({ overlaps, past, overflow, unfaded, fadedWhole });
/**
* A report of two targets, `label` the shown one's, for the phone header: `icon` adds the app's icon (`"broken"`, one
* whose bytes are no image), `appearances` a second chip, and the pull request is #1234.
*/
async function phoneReport({ label, appName = "Acme Super Long Application Name", icon = false, appearances = false }) {
const targets = [{ id: "shown", platform: "ios", label }, { id: "other", platform: "ios", label: "iPhone 17" }];
const report = reportFixture();
report.review.runtime = { ...report.review.runtime, appName, platform: "ios", platforms: ["ios"], target: targets[0], targets,
...(appearances ? { colorSchemes: ["light", "dark"] } : {}) };
report.review.pullRequest.number = 1234;
const extra = [];
if (icon) {
const image = new PNG({ width: 4, height: 4 });
image.data.fill(180);
const bytes = icon === "broken" ? new TextEncoder().encode("not an image") : PNG.sync.write(image);
const sha = createHash("sha256").update(bytes).digest("hex");
report.review.runtime.appIcon = { url: `https://artifact.expo-explore.invalid/${sha}.png`, sha256: sha, width: 4, height: 4 };
report.assets.push({ sha256: sha, path: `assets/${sha}.png` });
extra.push({ name: `assets/${sha}.png`, bytes });
}
return archive(report, extra);
}
test("at a phone's width the header leaves out the app's name, then the pull request link, then fades the target's device; nothing overlaps", { timeout: 60_000 }, async t => {
const targets = [{ id: "iphone", platform: "ios", label: "iPhone 17" }, { id: "duo-half", platform: "ios", label: "iPhone 17 Pro Max Duo (half-open, outer)" }];
const icon = new PNG({ width: 4, height: 4 });
icon.data.fill(180);
const iconBytes = PNG.sync.write(icon);
const iconSha = createHash("sha256").update(iconBytes).digest("hex");
const report = reportFixture();
// An icon to name the app once its name is left out; two appearances for the second chip; the longest target.
report.review.runtime = {
...report.review.runtime, platform: "ios", platforms: ["ios"], target: targets[1], targets, colorSchemes: ["light", "dark"],
appIcon: { url: `https://artifact.expo-explore.invalid/${iconSha}.png`, sha256: iconSha, width: 4, height: 4 },
};
report.assets.push({ sha256: iconSha, path: `assets/${iconSha}.png` });
report.review.pullRequest.number = 1234;
const { page, errors } = await harness(t, await archive(report, [{ name: `assets/${iconSha}.png`, bytes: iconBytes }]), { app: true });
const pill = page.locator(".left-panel-collapsed-pill");
const name = pill.locator(".collapsed-app-identity > strong");
const target = pill.locator(".collapsed-target");
const device = target.locator(".collapsed-platform-label-text");
const pose = target.locator(".collapsed-platform-label-suffix");
const pr = pill.locator(".collapsed-pr");
const layout = async () => fitOf(await phoneHeader(page));
const clipped = locator => locator.evaluate(node => node.scrollWidth - node.offsetWidth > 1);
const whole = async () => ({ device: !await clipped(device), pose: !await clipped(pose) });
const dropped = () => pill.locator(".collapsed-app-identity").evaluate(node => node.dataset.drop ?? "");
// The fit measures text: the Viewer's font must be in before the row's widths mean anything.
await page.evaluate(() => document.fonts.ready);
// A desktop window's pill is sized by its content and shows the whole row.
await page.setViewportSize({ width: 1180, height: 820 });
await expect(name).toBeVisible();
await expect(target).toHaveText("iPhone 17 Pro Max Duo (half-open, outer)");
await expect(pr).toHaveText("PR #1234");
await expect(pr).toBeVisible();
expect(await whole()).toEqual({ device: true, pose: true });
expect(await dropped()).toBe("");
await expect.poll(layout).toEqual(FITS);
// A small tablet has no room for the name beside Search: the row leaves it out (the icon still names the app) and
// keeps the whole target and a shorter link.
await page.setViewportSize({ width: 560, height: 932 });
await expect(name).toBeHidden();
await expect(pr).toHaveText("#1234");
await expect(pr).toBeVisible();
await expect(target).toHaveText("iPhone 17 Pro Max Duo (half-open, outer)");
expect(await whole()).toEqual({ device: true, pose: true });
await expect.poll(layout).toEqual(FITS);
const search = pill.getByRole("button", { name: "Search", exact: true });
const finger = await search.boundingBox();
assert.ok(finger.width >= 44 && finger.height >= 44, `Search is ${finger.width}×${finger.height}`);
// A large phone's width leaves out the link too (Search keeps "Open pull request") before it touches the target.
await page.setViewportSize({ width: 500, height: 844 });
await expect(pr).toBeHidden();
await expect(target).toHaveText("iPhone 17 Pro Max Duo (half-open, outer)");
expect(await whole()).toEqual({ device: true, pose: true });
await expect.poll(layout).toEqual(FITS);
await page.keyboard.press("ControlOrMeta+KeyK");
const palette = page.getByRole("dialog", { name: "Search Explore" });
await palette.getByRole("combobox", { name: "Search screens and commands" }).fill("pull request");
await expect(palette.getByRole("option", { name: /^Open pull request #1234 on GitHub/ })).toBeVisible();
await page.keyboard.press("Escape");
await expect(palette).toBeHidden();
// An iPhone's width fades the device's name; the pose stays whole and nothing overlaps.
await page.setViewportSize({ width: 390, height: 844 });
await expect(pill.locator(".collapsed-app-identity")).toHaveAttribute("data-drop", /squeeze/);
await expect(pill.locator(".collapsed-app-identity")).not.toHaveAttribute("data-drop", /pose/);
expect(await whole()).toEqual({ device: false, pose: true });
await expect.poll(layout).toEqual(FITS);
// Narrower than the pose beside two chips: the pose fades too, inside its chip, never over the appearance chip.
await page.setViewportSize({ width: 320, height: 568 });
await expect(pill.locator(".collapsed-app-identity")).toHaveAttribute("data-drop", /pose/);
await expect(pill.locator(".collapsed-platform").nth(1)).toHaveText("Light");
await expect.poll(layout).toEqual(FITS);
// Widened again, the row takes everything back: the desktop's pill is sized by its content and leaves nothing out
// (its own width rule ellipsizes the name beside so long a target; the fit does not touch it).
await page.setViewportSize({ width: 1180, height: 820 });
await expect(name).toHaveCSS("visibility", "visible");
await expect(name).toHaveCSS("position", "static");
await expect(pr).toHaveText("PR #1234");
await expect(pr).toBeVisible();
expect(await whole()).toEqual({ device: true, pose: true });
expect(await dropped()).toBe("");
assert.deepEqual(errors, []);
});
test("a phone's row without the app's icon cuts the name down to its minimum before it squeezes the target, and fades a label only where it is cut", { timeout: 90_000 }, async t => {
const { page, errors } = await harness(t, await phoneReport({ label: "iPhone 16 Pro (open)" }), { app: true });
const row = page.locator(".left-panel-collapsed-pill .collapsed-app-identity");
await expect(row.locator(".collapsed-target")).toHaveText("iPhone 16 Pro (open)");
await page.evaluate(() => document.fonts.ready);
// An iPhone's width has room for the whole target beside a cut name: the name gives way, the target keeps its label.
await page.setViewportSize({ width: 390, height: 844 });
await expect(row).not.toHaveAttribute("data-drop", /squeeze/);
const iphone = await phoneHeader(page);
assert.equal(iphone.targetCut, false);
assert.ok(iphone.name && iphone.name.width > iphone.name.minimum + 1 && iphone.name.width < iphone.name.text, `the name is ${JSON.stringify(iphone.name)}`);
// At every phone width, the target is cut only once the name is at its minimum, and only what is cut fades.
for (const width of [320, 340, 360, 375, 390, 414, 430, 460, 480, 560, 700]) {
await page.setViewportSize({ width, height: 844 });
const header = await phoneHeader(page);
assert.deepEqual(fitOf(header), FITS, `at ${width}px`);
if (header.name) assert.ok(header.name.width >= header.name.minimum - 1, `at ${width}px the name is ${JSON.stringify(header.name)}`);
if (header.targetCut && header.name) assert.ok(header.name.width <= header.name.minimum + 1, `at ${width}px the target is cut beside ${JSON.stringify(header.name)}`);
}
assert.deepEqual(errors, []);
});
test("a phone's header with Hand off fits its row at an iPhone's widths, with or without the app's icon", { timeout: 120_000 }, async t => {
// The hosted preview's header: Hand off sits before Search, so the row has less room than at /r.
const reports = [
{ label: "iPhone 16 Pro (open)", icon: false, appearances: true },
{ label: "iPhone 16 Pro (open)", icon: true, appearances: true },
{ label: "iOS", icon: false, appearances: true },
];
for (const [index, options] of reports.entries()) {
const preview = { token: `${"qrstuvwxyz234567234567234567".slice(0, 28)}${"abcd".slice(index, index + 1)}bcd` };
const { page, errors } = await harness(t, await phoneReport(options), { app: true, reportIdentity: null, preview, query: "" });
const pill = page.locator(".left-panel-collapsed-pill");
await expect(pill.locator(".collapsed-target")).toHaveText(options.label);
await page.evaluate(() => document.fonts.ready);
for (const width of [320, 360, 390, 430, 460]) {
await page.setViewportSize({ width, height: 844 });
await expect(pill.getByRole("button", { name: "Hand off to AI" })).toBeVisible();
const header = await phoneHeader(page);
const where = `${JSON.stringify(options)} at ${width}px`;
assert.deepEqual(fitOf(header), FITS, where);
// The row's end chip has room for its focus ring (2px, 2px out) and its key hint.
assert.ok(header.ring >= 4, `${where}: ${header.ring}px around the row's controls`);
// A name the row keeps is readable; one it leaves out is still the Map button's.
if (header.name) assert.ok(header.name.width >= header.name.minimum - 1, `${where}: the name is ${JSON.stringify(header.name)}`);
else await expect(pill.getByRole("button", { name: "Map of Acme Super Long Application Name", exact: true })).toBeVisible();
// A short label is no squeeze's to give: it shows whole.
if (options.label === "iOS") assert.equal(header.targetCut, false, where);
}
assert.deepEqual(errors, []);
await page.close();
}
});
test("a phone's row keeps the app's name when its icon cannot be read and the Expo mark stands in", { timeout: 60_000 }, async t => {
const { page, errors } = await harness(t, await phoneReport({ label: "iPhone 17 Pro Max Duo (half-open, outer)", icon: "broken", appearances: true }), { app: true });
const pill = page.locator(".left-panel-collapsed-pill");
await expect(pill.locator(".panel-logo-button .expo-mark")).toHaveCount(1);
await expect(pill.locator(".panel-logo-button img")).toHaveCount(0);
await page.evaluate(() => document.fonts.ready);
// With the icon, this width leaves the name out; the Expo mark does not name the app, so the name stays, cut.
await page.setViewportSize({ width: 560, height: 932 });
await expect(pill.locator(".collapsed-app-identity > strong")).toBeVisible();
const header = await phoneHeader(page);
assert.deepEqual(fitOf(header), FITS);
assert.ok(header.name && header.name.width >= header.name.minimum - 1, `the name is ${JSON.stringify(header.name)}`);
assert.deepEqual(errors, []);
});
test("a phone's fit that waits on the fonts does nothing once the window is a desktop's", { timeout: 60_000 }, async t => {
// The fonts arrive only when the test says, after the window has crossed to the desktop layout.
const fault = () => {
let release;
const ready = new Promise(resolve => { release = () => resolve(document.fonts); });
Object.defineProperty(document.fonts, "ready", { configurable: true, get: () => ready });
window.releaseFonts = release;
};
const bytes = await phoneReport({ label: "iPhone 16 Pro (open)", icon: true, appearances: true });
const { page, errors } = await harness(t, bytes, { app: true, open: false, fault });
await page.setViewportSize({ width: 390, height: 844 });
await chooseFile(page, bytes);
const pill = page.locator(".left-panel-collapsed-pill");
const row = pill.locator(".collapsed-app-identity");
await expect(row).toHaveAttribute("data-drop", /name/);
await page.setViewportSize({ width: 1180, height: 820 });
await expect(pill.locator(".collapsed-pr")).toHaveText("PR #1234");
await page.evaluate(async () => {
window.releaseFonts();
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
});
await expect(row).not.toHaveAttribute("data-drop");
await expect(pill.locator(".collapsed-pr")).toBeVisible();
await expect(pill.locator(".collapsed-app-identity > strong")).toBeVisible();
assert.deepEqual(errors, []);
});
test("a hosted manifest larger than the Viewer reads is refused before it is parsed", { timeout: 60_000 }, async t => {
const preview = { token: "klmnopqrstuvwxyz2345672345672345", padding: 11 * 1024 * 1024 };
const { page, errors } = await harness(t, await archive(), { app: true, reportIdentity: null, preview, query: "" });
@@ -1599,7 +1346,7 @@ test("transition thumbnails without a readable screenshot show the variant thumb
assert.deepEqual(errors, []);
});
test("a docs-only report with zero images and no EAS build has no screens to show, and its link to a route says why", async t => {
test("a docs-only report with zero images and no EAS build opens Screens without a visual verdict", async t => {
const report = reportFixture();
report.review.mode = "changes";
report.review.runtime.projectId = "";
@@ -1612,11 +1359,12 @@ test("a docs-only report with zero images and no EAS build has no screens to sho
report.assets = [];
const { page, errors } = await harness(t, await archive(report), { app: true });
await expect(page.locator(".app-shell")).toBeVisible();
// The change reaches no screen, so the one route was never captured: the Map and Screens say so instead of an empty page.
const empty = page.locator(".map-empty");
await expect(empty.getByRole("heading")).toHaveText("No screens were captured");
// The link names /home, and the Inspector says why it has no screenshot: the icon above a short label and the report's
// reason for the gap, centred in a phone-shaped preview frame.
await page.getByRole("button", { name: "Screens", exact: true }).click();
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(1);
await expect(page.locator(".screens-page .diff-frame.diff-not-compared")).toHaveCount(1);
// The Inspector's missing screenshot matches the canvas node: the icon above a short label and
// the report's reason for the gap, centred in a phone-shaped preview frame.
await page.locator(".screens-page .screen-screenshot-target").click();
const placeholder = page.locator(".inspector .inspector-preview .screenshot-placeholder");
await expect(placeholder.locator("span")).toHaveText("No screenshot");
await expect(placeholder.locator(".screenshot-placeholder-detail")).toHaveText("Not compared; no capture was recorded");
@@ -1642,98 +1390,10 @@ test("a docs-only report with zero images and no EAS build has no screens to sho
await expect(page.locator(".collapsed-change-count")).toHaveCount(0);
await expect(page.locator(".changes-screen-row")).toHaveCount(0);
await expect(page.locator(".diff-frame.diff-modified, .diff-frame.diff-unchanged")).toHaveCount(0);
await page.getByRole("button", { name: "Screens", exact: true }).click();
await expect(empty.getByRole("heading")).toHaveText("No screens were captured");
await expect(page.locator(".screens-cell, .screens-tree-row")).toHaveCount(0);
assert.equal(await page.evaluate(() => window.createdUrls.length), 0);
assert.deepEqual(errors, []);
});
/** A report with Home (modified) and Profile (not compared) captured, a new route named in exploration.exclude, and a redirect. */
function omittedRoutesReport() {
const report = reportFixture();
const home = report.review.surfaces[0];
const route = (id, path, extra = {}) => ({ ...home.head, id, route: path, path, routeFile: `app/${id}.tsx`, logicalPath: `app/${id}.tsx`, ...extra });
const redirect = route("start", "/start", { kind: "redirect", redirectTo: "/home" });
report.review.surfaces.push(
{ id: "profile", status: "unchanged", base: route("profile", "/profile"), head: route("profile", "/profile"),
baseImage: { ...home.baseImage }, headImage: { ...home.headImage }, baseOutcome: { ...home.baseOutcome }, headOutcome: { ...home.headOutcome } },
{ id: "channel", status: "added", excluded: true, base: null, head: route("channel", "/c/[channel]") },
{ id: "start", status: "unchanged", base: { ...redirect }, head: redirect });
return report;
}
test("a public report's excluded route and redirect are not among its screens: Screens, its counts, find, search and the changes leave them out", { timeout: 60_000 }, async t => {
const { page, errors } = await harness(t, await archive(omittedRoutesReport()), { app: true, query: "&screen=home" });
await expect(page.locator(".map-canvas .react-flow__node")).toHaveCount(2);
// The excluded route is new in this change, but it was never captured: it is not a change to review.
const menu = await openChangesMenu(page);
await expect(menu.getByRole("group", { name: "Filter changes" }).getByRole("button")).toHaveText(["Modified 1"]);
await expect(menu.getByText("/c/[channel]")).toHaveCount(0);
await page.keyboard.press("Escape");
await page.getByRole("button", { name: "Screens", exact: true }).click();
const cells = page.locator(".screens-page .screens-cell");
await expect(cells).toHaveCount(2);
await expect(page.locator(".screens-tree-row[data-screen-id]")).toHaveCount(2);
for (const id of ["channel", "start"]) await expect(page.locator(`[data-screen-id="${id}"]`)).toHaveCount(0);
await expect(page.locator(".screens-filter .screens-chip")).toHaveText(["Changed1", "All2"]);
// ← and → step through the two screens and no others.
await page.locator(".screens-page").click({ position: { x: 4, y: 4 } });
await page.keyboard.press("ArrowRight");
await expect(page.locator(".screens-cell .screen-screenshot-card.selected")).toHaveCount(1);
const picked = async () => page.locator(".screens-cell:has(.screen-screenshot-card.selected)").getAttribute("data-screen-id");
const first = await picked();
await page.keyboard.press("ArrowRight");
await expect.poll(picked).not.toBe(first);
const second = await picked();
await page.keyboard.press("ArrowRight");
await expect.poll(picked).toBe(second);
assert.deepEqual([first, second].sort(), ["home", "profile"]);
// `/` finds the report's screens only.
await page.keyboard.press("/");
const find = page.getByRole("searchbox", { name: "Find screens" });
await expect(find).toBeFocused();
for (const query of ["channel", "start"]) {
await find.fill(query);
await expect(page.locator(".screens-find-empty")).toHaveText(`No screens match “${query}”`);
await expect(cells).toHaveCount(0);
}
await find.fill("profile");
await expect(cells).toHaveCount(1);
await page.keyboard.press("Escape");
await page.keyboard.press("Escape");
// So does the command palette's screen search.
await page.keyboard.press("ControlOrMeta+KeyK");
const palette = page.getByRole("dialog", { name: "Search Explore" });
const box = palette.getByRole("combobox", { name: "Search screens and commands" });
await expect(box).toBeFocused();
await box.fill("/c/");
await expect(palette.getByRole("option")).toHaveCount(0);
await box.fill("/st");
await expect(palette.getByRole("option")).toHaveCount(0);
await box.fill("/pro");
await expect(palette.getByRole("option")).toHaveText([/\/profile/]);
assert.deepEqual(errors, []);
});
test("a link to an excluded route opens it in the Inspector, which says why it has no screenshot, on the Map and on Screens", { timeout: 60_000 }, async t => {
const { page, errors } = await harness(t, await archive(omittedRoutesReport()), { app: true, query: "&screen=channel" });
const detail = page.locator(".inspector .inspector-preview .screenshot-placeholder-detail");
await expect(detail).toHaveText("Excluded by exploration.exclude; never captured");
await expect(page.locator(".map-canvas .react-flow__node")).toHaveCount(2);
await expect(page.locator(".map-canvas .react-flow__node.selected")).toHaveCount(0);
// The same link on Screens, opened afresh: no card is picked, and the Inspector explains the route.
await page.goto(page.url().replace("#/map/", "#/screens/"));
await page.reload();
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(2);
await expect(page.locator(".screens-cell .screen-screenshot-card.selected")).toHaveCount(0);
await expect(detail).toHaveText("Excluded by exploration.exclude; never captured");
assert.deepEqual(errors, []);
});
test("unverified capture diagnostics stay separate from verified Needs review, and source changes nobody compared are not changes", async t => {
const report = reportFixture();
const home = report.review.surfaces[0];
@@ -1847,11 +1507,10 @@ test("a recorded pull-request artifact opens its verified verdicts and every scr
await expect(menu.getByText(route, { exact: true })).toBeVisible();
}
// Its two redirect declarations (/ and /scan/select-photo) were never captured: they are not among its screens.
await page.getByRole("button", { name: "Screens", exact: true }).click();
const frames = page.locator(".screens-page .diff-frame");
await expect(frames).toHaveCount(33);
for (const [status, count] of [["modified", 3], ["added", 1], ["removed", 1], ["unchanged", 28], ["not-compared", 0]]) {
await expect(frames).toHaveCount(35);
for (const [status, count] of [["modified", 3], ["added", 1], ["removed", 1], ["unchanged", 28], ["not-compared", 2]]) {
await expect(page.locator(`.screens-page .diff-frame.diff-${status}`)).toHaveCount(count);
}
const screenshots = page.locator(".screens-page img[data-screenshot-src]");
@@ -2027,502 +1686,3 @@ test("a near-square landscape pair in a short window keeps both halves on screen
}
assert.deepEqual(errors, []);
});
/** A capture in a colour of its own, so every side of every screen is a screenshot of its own. */
function tintedCapture(seed) {
const picture = new PNG({ width: 32, height: 64 });
for (let offset = 0; offset < picture.data.length; offset += 4) picture.data.set([(seed * 53) % 256, (seed * 101 + 40) % 256, (seed * 151 + 90) % 256, 255], offset);
const bytes = PNG.sync.write(picture);
const digest = createHash("sha256").update(bytes).digest("hex");
return { bytes, sha256: digest, path: `assets/${digest}.png`, reference: `expo-explore-asset:${digest}.png`,
record: { url: `https://artifact.expo-explore.invalid/${digest}.png`, sha256: digest, width: 32, height: 64 } };
}
/**
* `count` modified screens, screen-1 to screen-<count>, each with a Before and an After of its own. `seed` gives
* another target its own captures. `screens[i]` holds screen-(i + 1)'s `before` and `after`. `sameAfter: { i: j }`
* gives the screen at index i the After of the one at index j.
*/
async function changedScreensArchive(count, { seed = 1, runtime, sameAfter = {} } = {}) {
const report = reportFixture();
const home = report.review.surfaces[0];
const route = id => ({ ...home.head, id, route: `/${id}`, path: `/${id}`, routeFile: `app/${id}.tsx`, logicalPath: `app/${id}.tsx` });
const extra = [];
const screens = [];
report.assets = [];
report.review.surfaces = Array.from({ length: count }, (_, index) => {
const id = `screen-${index + 1}`;
const before = tintedCapture(seed * 100 + index * 2);
const after = sameAfter[index] !== undefined ? screens[sameAfter[index]].after : tintedCapture(seed * 100 + index * 2 + 1);
screens.push({ id, before, after });
for (const capture of [before, after]) {
if (report.assets.some(asset => asset.sha256 === capture.sha256)) continue;
report.assets.push({ sha256: capture.sha256, path: capture.path });
extra.push({ name: capture.path, bytes: capture.bytes });
}
return { ...structuredClone(home), id, base: route(id), head: route(id),
baseImage: { ...home.baseImage, ...before.record }, headImage: { ...home.headImage, ...after.record } };
});
const empty = { contract: "explore.navigation", edges: [], modalSurfaceIds: [], unresolved: [] };
report.review.navigation = { base: structuredClone(empty), head: empty };
if (runtime) report.review.runtime = { ...report.review.runtime, ...runtime };
return { bytes: await archive(report, extra), screens };
}
/** Records each screenshot request (reference, priority, when) and release on the page's report archives. */
async function recordScreenshotReads(page) {
await page.evaluate(async () => {
const { ArtifactReportArchive } = await import("/src/utils/artifact-report.ts");
window.reads = [];
window.releases = [];
const { resolve, release } = ArtifactReportArchive.prototype;
ArtifactReportArchive.prototype.resolve = function (reference, priority) {
window.reads.push({ reference, priority: priority ?? "lazy", at: performance.now() });
return resolve.call(this, reference, priority);
};
ArtifactReportArchive.prototype.release = function (reference) {
window.releases.push({ reference, at: performance.now() });
return release.call(this, reference);
};
});
}
/** How many uses of each screenshot the shown report counts, by reference. */
const screenshotUses = page => page.evaluate(async () => {
const { activeArtifactReport } = await import("/src/utils/artifact-report.ts");
return Object.fromEntries([...activeArtifactReport.loads.values()].map(load => [`expo-explore-asset:${load.sha256}.png`, load.users]));
});
/** How many mounted images show each screenshot, by reference. */
const mountedScreenshots = page => page.evaluate(() => {
const counts = {};
for (const image of document.querySelectorAll("img[data-screenshot-src]")) counts[image.dataset.screenshotSrc] = (counts[image.dataset.screenshotSrc] ?? 0) + 1;
return counts;
});
/** Every use the report counts belongs to an image on the page; nothing else holds a screenshot. */
async function expectBalancedUses(page, message) {
await expect.poll(async () => {
const uses = await screenshotUses(page);
const mounted = await mountedScreenshots(page);
return Object.entries(uses).filter(([reference, users]) => users > (mounted[reference] ?? 0));
}, { message }).toEqual([]);
}
test("Compare reads the next screen's screenshots once it rests on a screen, never while an arrow is held, and they are released when it moves on", { timeout: 90_000 }, async t => {
const { bytes, screens } = await changedScreensArchive(9);
const { page, errors } = await harness(t, bytes, { app: true, open: false, query: "&view=compare&screen=screen-1" });
await recordScreenshotReads(page);
await chooseFile(page, bytes);
const compare = page.locator(".compare-section");
await expect(compare.locator(".compare-frame img")).toHaveCount(2);
for (const image of await compare.locator(".compare-frame img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
const position = compare.locator(".compare-nav-position");
await expect(position).toHaveText(/^1 of 9$/);
const shownAt = await page.evaluate(() => Math.min(...window.reads.filter(read => read.priority === "eager").map(read => read.at)));
// Resting on screen-1, its neighbour in the direction of travel (screen-2) is read, after the settle delay, as a
// prefetch that leaves the next step's slots free.
const prefetchesOf = screen => page.evaluate(references => window.reads.filter(read => read.priority === "prefetch" && references.includes(read.reference)),
[screen.before.reference, screen.after.reference]);
await expect.poll(async () => (await prefetchesOf(screens[1])).length).toBe(2);
assert.ok((await prefetchesOf(screens[1]))[0].at - shownAt >= 240, "Nothing is read before Compare rests on the screen");
assert.equal((await page.evaluate(() => window.reads.filter(read => read.priority === "prefetch"))).length, 2, "Only the neighbour is read");
await expect.poll(() => screenshotUses(page)).toMatchObject({ [screens[1].before.reference]: 1, [screens[1].after.reference]: 1 });
// The step finds its pictures decoded: nothing new is decoded for them.
await expect.poll(() => page.evaluate(() => window.createdUrls.length)).toBe(4);
await page.keyboard.press("ArrowRight");
await expect(position).toHaveText(/^2 of 9$/);
for (const image of await compare.locator(".compare-frame img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
assert.equal(await page.evaluate(() => window.createdUrls.length), 4, "The prefetched screenshots were shown without a new decode");
// A held arrow steps past several screens; nothing is read for a neighbour until it is released.
await expect.poll(async () => (await prefetchesOf(screens[2])).length).toBe(2);
const downAt = await page.evaluate(() => performance.now());
await page.keyboard.down("ArrowRight");
await expect.poll(async () => Number((await position.textContent()).split(" ")[0]), { timeout: 4000 }).toBeGreaterThanOrEqual(6);
// The stage is marked while the key repeats, so the screenshots it passes appear without a fade.
await expect(compare.locator(".compare-stage")).toHaveAttribute("data-screenshot-instant", "");
await page.waitForTimeout(150);
const upAt = await page.evaluate(() => performance.now());
await page.keyboard.up("ArrowRight");
await expect(compare.locator(".compare-stage")).not.toHaveAttribute("data-screenshot-instant", /.*/);
const heldPrefetches = await page.evaluate(({ downAt, upAt }) => window.reads.filter(read => read.priority === "prefetch" && read.at > downAt && read.at <= upAt), { downAt, upAt });
assert.deepEqual(heldPrefetches, [], "No neighbour was read while the arrow was held");
const landed = Number((await position.textContent()).split(" ")[0]);
const next = screens[landed];
if (next) await expect.poll(async () => (await prefetchesOf(next)).length).toBe(2);
// Leaving Compare lets go of every screenshot it, and its prefetch, held.
await page.getByRole("group", { name: "Canvas view" }).getByRole("button", { name: "Screens", exact: true }).click();
await expect(page.locator(".screens-page")).toBeVisible();
await expect(compare).toHaveCount(0);
await expectBalancedUses(page, "Every use left after Compare belongs to an image on Screens");
const uses = await screenshotUses(page);
for (const screen of screens) assert.equal(uses[screen.before.reference] ?? 0, 0, `${screen.id}'s Before is no longer in use`);
assert.deepEqual(errors, []);
});
test("a prefetch never holds a slot the screen the reviewer steps to needs, whichever way the step goes", { timeout: 20_000 }, async t => {
const { page, errors } = await harness(t);
const { bytes, shas } = await multiImageArchive(8);
const result = await page.evaluate(async ({ bytes, identity, shas, probe }) => {
const archive = await window.openReport(bytes, identity);
const decodes = new Function(`return (${probe})()`)();
const [shown, shownToo, ahead, aheadToo, behind, behindToo, later, laterToo] = shas.map(sha => archive.reference(sha));
const settle = () => new Promise(resolve => setTimeout(resolve, 30));
// The screen on show is still being read when Compare rests on it: its neighbour's prefetches wait.
const visible = [archive.resolve(shown, "eager"), archive.resolve(shownToo, "eager")];
await decodes.until(() => decodes.held() === 2);
const waited = [archive.resolve(ahead, "prefetch"), archive.resolve(aheadToo, "prefetch")].map(read => read.then(() => "read", error => error.message));
await settle();
const heldWhileShownReads = decodes.held();
// The reviewer steps the other way before they start: they are dropped, unread.
archive.release(ahead);
archive.release(aheadToo);
const stepped = [archive.resolve(behind, "eager"), archive.resolve(behindToo, "eager")];
await decodes.until(() => decodes.held() === 4);
decodes.all();
await Promise.all([...visible, ...stepped]);
const dropped = await Promise.all(waited);
// Resting on that screen, its own neighbour's prefetches start, in the slots its reads have finished with.
const running = [archive.resolve(later, "prefetch"), archive.resolve(laterToo, "prefetch")];
await decodes.until(() => decodes.held() === 2);
// The reviewer steps the other way while they run: they keep their slots, and the screen stepped to starts at once.
archive.release(later);
archive.release(laterToo);
archive.release(shown);
archive.release(shownToo);
const back = [archive.resolve(shown, "eager"), archive.resolve(shownToo, "eager")];
await settle();
const heldAfterStep = decodes.held();
decodes.all();
await Promise.all([...running, ...back]);
return { heldWhileShownReads, dropped, heldAfterStep, hashed: decodes.hashed() };
}, { bytes, identity, shas, probe: decodeProbe.toString() });
assert.equal(result.heldWhileShownReads, 2, "The prefetches waited while the shown screen was still being read");
assert.deepEqual(result.dropped, ["This screenshot is no longer in use.", "This screenshot is no longer in use."]);
assert.ok(!result.hashed.includes(shas[2]) && !result.hashed.includes(shas[3]), "A prefetch let go before it started was never read");
assert.equal(result.heldAfterStep, 2, "The screen stepped to was read at once, beside the running prefetches");
assert.deepEqual(errors, []);
});
test("Flip reads a screen's Before only once its After has loaded, and flipping reads nothing new", { timeout: 90_000 }, async t => {
const { bytes, screens } = await changedScreensArchive(4);
const { page, errors } = await harness(t, bytes, { app: true, open: false, query: "&view=compare&screen=screen-1" });
await page.addInitScript(() => localStorage.setItem("expo-explore:compare-mode", "flip"));
await page.reload();
await recordScreenshotReads(page);
await chooseFile(page, bytes);
const frame = page.locator(".compare-section .compare-flip-frame");
await expect(frame.locator(".compare-flip-layer")).toHaveCount(2);
for (const image of await frame.locator("img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
// The side off screen is hidden, its spinner with it.
await expect(frame.locator(".compare-flip-layer[data-side='before']")).toHaveAttribute("aria-hidden", "true");
await expect(frame.locator(".compare-flip-layer[data-side='before']")).toHaveCSS("visibility", "hidden");
// The next screen's After is held back: its Before is not read meanwhile, and only After's layer is mounted.
await page.evaluate(after => {
const digest = crypto.subtle.digest.bind(crypto.subtle);
const hex = buffer => Array.from(new Uint8Array(buffer), byte => byte.toString(16).padStart(2, "0")).join("");
window.heldAfter = [];
crypto.subtle.digest = async (algorithm, data) => {
const value = await digest(algorithm, data);
if (hex(value) === after) await new Promise(resolve => window.heldAfter.push(resolve));
return value;
};
}, screens[1].after.sha256);
const readsOf = reference => page.evaluate(reference => window.reads.filter(read => read.reference === reference && read.priority !== "prefetch").length, reference);
await page.keyboard.press("ArrowRight");
await expect(page.locator(".compare-section .compare-nav-position")).toHaveText(/^2 of 4$/);
await expect(frame.locator(".compare-flip-layer")).toHaveCount(1);
await page.waitForTimeout(150);
assert.equal(await readsOf(screens[1].before.reference), 0, "Before is not read while After loads");
await page.evaluate(() => window.heldAfter.splice(0).forEach(release => release()));
await expect(frame.locator(".compare-flip-layer")).toHaveCount(2);
for (const image of await frame.locator("img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
// StrictMode mounts each image's lease twice in development.
assert.ok(await readsOf(screens[1].before.reference) > 0, "Before is read once After has loaded");
// Flipping swaps the two decoded sides at once.
const reads = await page.evaluate(() => window.reads.length);
await page.keyboard.press("KeyX");
await expect(frame.locator(".compare-flip-layer[data-side='before']")).not.toHaveAttribute("aria-hidden", /.*/);
await expect(frame.locator(".compare-flip-layer[data-side='after']")).toHaveCSS("visibility", "hidden");
await expect(frame.locator(".compare-flip-layer[data-side='before'] img")).toHaveCSS("opacity", "1");
await page.keyboard.press("KeyX");
await expect(frame.locator(".compare-flip-layer[data-side='after']")).not.toHaveAttribute("aria-hidden", /.*/);
assert.equal(await page.evaluate(() => window.reads.length), reads, "A flip reads nothing");
assert.deepEqual(errors, []);
});
test("a Map card's backing draws the frame its screenshot waits and fades in over, and steps aside for No screenshot", { timeout: 60_000 }, async t => {
const { page, errors } = await harness(t, await archive(), { app: true, fault: holdScreenshotHashes() });
await expect(page.locator(".app-shell")).toBeVisible();
const slot = page.locator(".map-canvas .screen-node-image").first();
const image = slot.locator("img[data-screenshot-src]");
const backing = slot.locator(".screenshot-backing");
await expect(image).toHaveAttribute("data-screenshot-state", "loading");
await expect(image).toHaveCSS("opacity", "0");
await expect(backing).toHaveCSS("visibility", "visible");
const frames = () => slot.evaluate(element => {
const box = node => { const { left, top, width, height } = node.getBoundingClientRect(); return [left, top, width, height].map(value => Math.round(value * 10) / 10); };
const style = node => { const { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow } = getComputedStyle(node); return { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow }; };
const [img, backing] = [element.querySelector("img"), element.querySelector(".screenshot-backing")];
return { image: box(img), backing: box(backing), imageStyle: style(img), backingStyle: style(backing) };
});
// The link selects Home, so the frame carries the selection ring past the Modified status.
await expect(page.locator(".map-canvas .react-flow__node-screen.selected")).toHaveCount(1);
// The ring follows the canvas zoom, and the backing's ring eases to it as the opening camera settles.
await expect.poll(async () => { const { backingStyle, imageStyle } = await frames(); return backingStyle.boxShadow === imageStyle.boxShadow; }).toBe(true);
const waiting = await frames();
assert.deepEqual(waiting.backing, waiting.image, "The backing sits exactly where the image does");
assert.deepEqual(waiting.backingStyle, waiting.imageStyle, "and draws the same frame: fill, border, radius, status and ring");
assert.match(waiting.backingStyle.boxShadow, /rgb\(5, 136, 240\)/);
await page.evaluate(() => window.releaseScreenshotHashes());
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
assert.deepEqual((await frames()).image, waiting.image, "Loading moved nothing");
// Once the picture has faded in, the backing hides.
await expect(backing).toHaveCSS("visibility", "hidden");
await expect(image).toHaveCSS("opacity", "1");
assert.deepEqual(errors, []);
});
test("a Map card whose screenshot cannot be read shows No screenshot in one frame, its backing hidden", async t => {
const damaged = Buffer.from(png);
damaged[damaged.length - 1] ^= 1;
const { page, errors } = await harness(t, await archive(reportFixture(), [], damaged), { app: true });
await expect(page.locator(".app-shell")).toBeVisible();
const slot = page.locator(".map-canvas .screen-node-image").first();
await expect(slot.locator(".image-placeholder")).toHaveText("No screenshot");
await expect(slot.locator(".screenshot-backing")).toHaveCSS("visibility", "hidden");
assert.deepEqual(errors, []);
});
test("on a phone, a Screens card's screenshot keeps its height while it loads and once it has", { timeout: 60_000 }, async t => {
const { bytes } = await changedScreensArchive(2);
const { page, errors } = await harness(t, bytes, { app: true, open: false, fault: holdScreenshotHashes(tintedCapture(100).bytes.length) });
await page.setViewportSize({ width: 390, height: 844 });
await chooseFile(page, bytes);
await expect(page.locator(".app-shell")).toBeVisible();
await page.goto(`${page.url().split("#")[0]}#/screens`);
const slot = page.locator(".screens-cell .screen-node-image.has-screenshot").first();
await expect(slot).toBeVisible();
const height = () => slot.evaluate(element => [element.getBoundingClientRect().height, element.querySelector("img").getBoundingClientRect().height]);
const [waiting, waitingImage] = await height();
assert.ok(waiting > 100 && Math.abs(waiting - waitingImage) < 1, `The waiting screenshot holds the slot open: ${waiting}, ${waitingImage}`);
// The image is the frame here, and hidden while it loads: its backing draws the same frame in its place.
await expect(slot.locator("img")).toHaveCSS("opacity", "0");
const backing = slot.locator(".screenshot-backing");
await expect(backing).toHaveCSS("visibility", "visible");
const frames = await slot.evaluate(element => {
const box = node => { const { left, top, width, height } = node.getBoundingClientRect(); return [left, top, width, height].map(value => Math.round(value)); };
const style = node => { const { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow } = getComputedStyle(node); return { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow }; };
const [img, backing] = [element.querySelector("img"), element.querySelector(".screenshot-backing")];
return { image: box(img), backing: box(backing), imageStyle: style(img), backingStyle: style(backing) };
});
assert.deepEqual(frames.backing, frames.image);
assert.deepEqual(frames.backingStyle, frames.imageStyle, "The backing draws the image's frame: border, fill, radius, status and ring");
assert.notEqual(frames.backingStyle.backgroundColor, "rgba(0, 0, 0, 0)");
// Selected, the backing carries the image's ring while the screenshot still loads (a changed screen's is its status).
await page.goto(`${page.url().split("#")[0]}#/screens?screen=screen-1`);
const selected = page.locator(".screens-cell .screen-screenshot-card.selected .screen-node-image");
await expect(selected.locator("img")).toHaveAttribute("data-screenshot-state", "loading");
const rings = await selected.evaluate(element => [element.querySelector("img"), element.querySelector(".screenshot-backing")]
.map(node => getComputedStyle(node).boxShadow));
assert.equal(rings[1], rings[0]);
assert.notEqual(rings[1], "none");
await page.evaluate(() => window.releaseScreenshotHashes());
await expect(slot.locator("img")).toHaveAttribute("data-screenshot-state", "ready");
assert.deepEqual(await height(), [waiting, waitingImage]);
assert.deepEqual(errors, []);
});
test("a target switch blanks every card whose screenshot differs, never showing the other target's picture, and switching back reuses the kept pictures", { timeout: 90_000 }, async t => {
const runtime = { platform: "android", platforms: ["ios", "android"] };
const android = await changedScreensArchive(3, { seed: 1, runtime });
const ios = await changedScreensArchive(3, { seed: 2, runtime: { ...runtime, platform: "ios" } });
const preview = { token: "pqrstuvwxyz234567234567234567234", listing: [{ platform: "ios" }, { platform: "android" }],
archives: { "?platform=ios": ios.bytes } };
const { page, errors } = await harness(t, android.bytes, { app: true, reportIdentity: null, preview, query: "&platform=android" });
await expect(page.locator(".app-shell")).toBeVisible();
const cards = page.locator(".map-canvas img[data-screenshot-src]");
await expect(cards).toHaveCount(3);
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "ready");
const shown = await cards.evaluateAll(images => Object.fromEntries(images.map(image => [image.getAttribute("src"), image.dataset.screenshotSrc])));
// Hold iOS's screenshots back so the switch is caught while they load.
await page.evaluate(sizes => {
const digest = crypto.subtle.digest.bind(crypto.subtle);
window.heldIos = [];
window.releaseIos = () => window.heldIos.splice(0).forEach(release => release());
window.holdIos = true;
crypto.subtle.digest = (algorithm, data) => window.holdIos && sizes.includes(data.byteLength)
? new Promise(resolve => window.heldIos.push(() => resolve(digest(algorithm, data)))) : digest(algorithm, data);
}, ios.screens.flatMap(screen => [screen.before.bytes.length, screen.after.bytes.length]));
// Every frame from the switch on: no card shows a picture under another screenshot's name, and a waiting one is hidden.
await page.evaluate(shown => {
window.staleFrames = [];
window.sampling = true;
const sample = () => {
for (const image of document.querySelectorAll(".map-canvas img[data-screenshot-src]")) {
const source = shown[image.getAttribute("src")];
const opacity = Number(getComputedStyle(image).opacity);
if (source && source !== image.dataset.screenshotSrc && opacity > 0) window.staleFrames.push({ source, named: image.dataset.screenshotSrc, opacity });
if (image.dataset.screenshotState === "loading" && opacity > 0) window.staleFrames.push({ waiting: image.dataset.screenshotSrc, opacity });
}
if (window.sampling) requestAnimationFrame(sample);
};
requestAnimationFrame(sample);
}, shown);
await page.getByRole("button", { name: "Platform: Android. Open another platform's report" }).click();
await page.getByRole("menu", { name: "Platform" }).getByRole("menuitemradio").nth(0).click();
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "ios");
await expect(cards.first()).toHaveAttribute("data-screenshot-src", ios.screens[0].after.reference);
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "loading");
await page.waitForTimeout(200);
await page.evaluate(() => { window.holdIos = false; window.releaseIos(); });
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "ready");
await page.evaluate(() => { window.sampling = false; });
assert.deepEqual(await page.evaluate(() => window.staleFrames), [], "No frame showed Android's picture on iOS's cards, or a waiting picture");
await expectBalancedUses(page, "After the switch, the iOS report counts only the cards' uses");
// Back to Android: its kept pictures come back without a new decode.
const created = await page.evaluate(() => window.createdUrls.length);
await page.goBack();
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "android");
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "ready");
const back = await cards.evaluateAll(images => Object.fromEntries(images.map(image => [image.getAttribute("src"), image.dataset.screenshotSrc])));
assert.deepEqual(back, shown, "Android's cards show the Blob URLs they showed before");
assert.equal(await page.evaluate(() => window.createdUrls.length), created, "nothing was decoded again");
await expectBalancedUses(page, "After switching back, the Android report counts only the cards' uses");
assert.deepEqual(errors, []);
});
test("a prefetch the reviewer steps onto starts at once when a slot is free, instead of waiting for a running read", { timeout: 20_000 }, async t => {
const { page, errors } = await harness(t);
const { bytes, shas } = await multiImageArchive(4);
const result = await page.evaluate(async ({ bytes, identity, shas, probe }) => {
const archive = await window.openReport(bytes, identity);
const decodes = new Function(`return (${probe})()`)();
const [shown, shownToo, next, nextToo] = shas.map(sha => archive.reference(sha));
// The screen on show is still being read after the rest: the next screen's prefetches wait behind the reserve.
const visible = [archive.resolve(shown, "eager"), archive.resolve(shownToo, "eager")];
await decodes.until(() => decodes.held() === 2);
const prefetched = [archive.resolve(next, "prefetch"), archive.resolve(nextToo, "prefetch")];
await new Promise(resolve => setTimeout(resolve, 30));
const heldBeforeStep = decodes.held();
// The reviewer steps onto that screen: its reads start in the two free slots, beside the running ones.
const stepped = [archive.resolve(next, "eager"), archive.resolve(nextToo, "eager")];
await new Promise(resolve => setTimeout(resolve, 30));
const heldAfterStep = decodes.held();
decodes.all();
await Promise.all([...visible, ...prefetched, ...stepped]);
return { heldBeforeStep, heldAfterStep, shared: await prefetched[0] === await stepped[0] };
}, { bytes, identity, shas, probe: decodeProbe.toString() });
assert.equal(result.heldBeforeStep, 2, "The prefetches waited behind the reserve");
assert.equal(result.heldAfterStep, 4, "Stepped onto, they started at once");
assert.equal(result.shared, true);
assert.deepEqual(errors, []);
});
test("a prefetch read that never finishes does not stop Compare reading the next screens ahead", { timeout: 90_000 }, async t => {
const { bytes, screens } = await changedScreensArchive(5);
const { page, errors } = await harness(t, bytes, { app: true, open: false, query: "&view=compare&screen=screen-1" });
await recordScreenshotReads(page);
// Screen-2's Before never finishes verifying.
await page.evaluate(stuck => {
const digest = crypto.subtle.digest.bind(crypto.subtle);
const hex = buffer => Array.from(new Uint8Array(buffer), byte => byte.toString(16).padStart(2, "0")).join("");
crypto.subtle.digest = async (algorithm, data) => {
const value = await digest(algorithm, data);
if (hex(value) === stuck) await new Promise(() => {});
return value;
};
}, screens[1].before.sha256);
await chooseFile(page, bytes);
const compare = page.locator(".compare-section");
await expect(compare.locator(".compare-frame img[data-screenshot-state='ready']")).toHaveCount(2);
const prefetchesOf = screen => page.evaluate(references => window.reads.filter(read => read.priority === "prefetch" && references.includes(read.reference)).length,
[screen.before.reference, screen.after.reference]);
await expect.poll(() => prefetchesOf(screens[1])).toBe(2);
await page.keyboard.press("ArrowRight");
await expect(compare.locator(".compare-nav-position")).toHaveText(/^2 of 5$/);
await expect.poll(() => prefetchesOf(screens[2])).toBe(2);
await page.keyboard.press("ArrowRight");
await expect(compare.locator(".compare-nav-position")).toHaveText(/^3 of 5$/);
await expect.poll(() => prefetchesOf(screens[3])).toBe(2);
assert.deepEqual(errors, []);
});
/** Opens Compare in Flip at `screen`, recording screenshot reads. */
async function openFlip(t, bytes, screen) {
const opened = await harness(t, bytes, { app: true, open: false, query: `&view=compare&screen=${screen}` });
await opened.page.addInitScript(() => localStorage.setItem("expo-explore:compare-mode", "flip"));
await opened.page.reload();
await recordScreenshotReads(opened.page);
return opened;
}
/** Holds back verifying the screenshot with this hash until `window.releaseHeld()`. */
const holdScreenshot = (page, sha256) => page.evaluate(held => {
const digest = crypto.subtle.digest.bind(crypto.subtle);
const hex = buffer => Array.from(new Uint8Array(buffer), byte => byte.toString(16).padStart(2, "0")).join("");
const waiting = [];
window.releaseHeld = () => waiting.splice(0).forEach(release => release());
crypto.subtle.digest = async (algorithm, data) => {
const value = await digest(algorithm, data);
if (hex(value) === held) await new Promise(resolve => waiting.push(resolve));
return value;
};
}, sha256);
test("Flip reads the next screen's Before when a step keeps the After it shows, which fires no load", { timeout: 90_000 }, async t => {
// Screen-2 keeps screen-1's After beside a Before of its own.
const { bytes, screens } = await changedScreensArchive(3, { sameAfter: { 1: 0 } });
const { page, errors } = await openFlip(t, bytes, "screen-1");
await chooseFile(page, bytes);
const frame = page.locator(".compare-section .compare-flip-frame");
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
await page.keyboard.press("ArrowRight");
await expect(page.locator(".compare-section .compare-nav-position")).toHaveText(/^2 of 3$/);
await expect(frame.locator(".compare-flip-layer[data-side='before'] img")).toHaveAttribute("data-screenshot-src", screens[1].before.reference);
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
assert.deepEqual(errors, []);
});
test("Flip stepped from Before shows the next screen's After from its first frame and reads its Before only once After is ready", { timeout: 90_000 }, async t => {
const { bytes, screens } = await changedScreensArchive(3);
const { page, errors } = await openFlip(t, bytes, "screen-1");
await chooseFile(page, bytes);
const frame = page.locator(".compare-section .compare-flip-frame");
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
await page.keyboard.press("KeyX");
await expect(frame).toHaveAttribute("data-side", "before");
await holdScreenshot(page, screens[1].after.sha256);
// Every frame from the step: which side the frame shows, and which layers are mounted.
await page.evaluate(() => {
window.flipFrames = [];
const sample = () => {
const element = document.querySelector(".compare-flip-frame");
window.flipFrames.push({ route: document.querySelector(".compare-nav-route")?.textContent, side: element?.dataset.side,
layers: [...(element?.querySelectorAll(".compare-flip-layer") ?? [])].map(layer => layer.dataset.side).join(",") });
if (window.flipFrames.length < 20) requestAnimationFrame(sample);
};
requestAnimationFrame(sample);
});
await page.keyboard.press("ArrowRight");
await expect.poll(() => page.evaluate(() => window.flipFrames.length)).toBe(20);
const stepped = (await page.evaluate(() => window.flipFrames)).filter(sample => sample.route === "/screen-2");
assert.ok(stepped.length > 0);
assert.deepEqual([...new Set(stepped.map(sample => `${sample.side}:${sample.layers}`))], ["after:after"],
"From its first frame screen-2 shows After alone");
const readsOf = reference => page.evaluate(reference => window.reads.filter(read => read.reference === reference && read.priority !== "prefetch").length, reference);
assert.equal(await readsOf(screens[1].before.reference), 0, "Before waits for After");
await page.evaluate(() => window.releaseHeld());
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
assert.deepEqual(errors, []);
});
+3 -11
View File
@@ -242,14 +242,6 @@ test("Compare steps through changed screens and their changed areas", { timeout:
await expect(outlines.nth(1)).toHaveClass(/active/);
await page.keyboard.press("k");
await expect(outlines.nth(0)).toHaveClass(/active/);
// Esc in the bottom bar's More menu closes the menu and only the menu.
const more = page.getByRole("button", { name: "More", exact: true });
await more.click();
await expect(page.getByRole("menu", { name: "More" })).toBeVisible();
await page.keyboard.press("Escape");
await expect(page.getByRole("menu", { name: "More" })).toHaveCount(0);
await expect(more).toBeFocused();
await expect(outlines.nth(0)).toHaveClass(/active/);
await page.keyboard.press("Escape");
await expect(compare.locator(".visual-change-outline.active")).toHaveCount(0);
@@ -318,7 +310,7 @@ test("Compare steps through changed screens and their changed areas", { timeout:
/** The Inspector's one frame for a screen outside the review, and its Swipe frame for a changed one, in this viewport. */
async function inspectorFrames(page, url) {
const games = "expo-tabs-games-index-2c6605360b11";
const unchanged = "expo-tabs-scan-index-2bbf42237cc6";
const index = "expo-index-02872ff9f2ca";
const open = async id => {
await page.goto(`${url}#/screens`);
const all = page.getByRole("button", { name: /^All/ }).first();
@@ -333,14 +325,14 @@ async function inspectorFrames(page, url) {
const swipeImage = page.locator(".sidebar-review-stage img").first();
await expect(swipeImage).toBeVisible();
const changed = await swipeImage.boundingBox();
await open(unchanged);
await open(index);
const single = page.locator(".sidebar-review-off .variant-preview");
await expect(single).toBeVisible();
return { changed, single: await single.boundingBox() };
}
test("the Inspector frames an unchanged screen at the size of a changed screen's Swipe frame", { timeout: 90_000 }, async t => {
// /scan is unchanged; /games is modified. The single frame used to take at most half the panel, the
// / is unchanged (not compared); /games is modified. The single frame used to take at most half the panel, the
// width of one frame of a Before/After pair, while Swipe and Flip fill the panel up to 70 % (phone: 52 %) of the window.
for (const viewport of [{ width: 1024, height: 820 }, { width: 390, height: 844 }]) {
const { page, url, errors } = await openReport(t, viewport);
+2 -211
View File
@@ -48,8 +48,6 @@ const entry = `
import { useEffect, useState } from "react";
import { createRoot } from "react-dom/client";
import { ScreenshotImage } from "/src/components/shared/screenshot-image.tsx";
// The Viewer's own rules hide a waiting screenshot and fade a ready one in.
if (window.fixture.styles) await import("/src/styles.css");
function Harness() {
const [state, setState] = useState(window.fixture);
@@ -68,13 +66,10 @@ function Harness() {
return <main style={{ position: "relative", height: state.layout === "scroll" ? 3300 : 300,
width: 600, overflow: state.layout === "pan" ? "hidden" : undefined }}>
{state.normalSource && <ScreenshotImage src={state.normalSource} alt="Hosted screenshot"
width={24} height={18} decoding="async" onLoad={loaded} {...(state.holdPrevious ? { holdPrevious: true } : {})}
{...(state.fallback ? { fallback: <span data-testid="hosted-fallback">No hosted screenshot</span> } : {})} />}
width={24} height={18} decoding="async" onLoad={loaded} />}
<div data-testid="positioner" style={{ position: "absolute", left: 20,
top: state.layout === "scroll" ? 3000 : 30,
transform: state.layout === "pan" ? "translateX(2500px)" : undefined }}
{...(state.instant ? { "data-screenshot-instant": "" } : {})}
{...(state.thumbnail ? { className: "variant-thumbnail", "aria-selected": "false" } : {})}>
transform: state.layout === "pan" ? "translateX(2500px)" : undefined }}>
{state.mounted !== false && <ScreenshotImage src={state.source} alt="Captured checkout"
width={120} height={80} loading={state.loading} decoding="async" className="captured-image"
data-screen="checkout" onLoad={loaded} onError={failed}
@@ -111,18 +106,6 @@ async function fixture(t, options = {}) {
response.end(firstImage);
return;
}
// A hosted screenshot that is not there.
if (request.url === "/__missing.png") {
response.statusCode = 404;
response.end("Not found");
return;
}
// A hosted screenshot that takes a while to arrive.
if (request.url === "/__slow.png") {
response.setHeader("Content-Type", "image/png");
setTimeout(() => response.end(secondImage), 600);
return;
}
if (request.url !== "/") return next();
response.setHeader("Content-Type", "text/html");
response.end('<!doctype html><html><head><style>body{margin:0}</style></head><body><div id="root"></div><script type="module" src="/__screenshot_image.tsx"></script></body></html>');
@@ -180,15 +163,7 @@ async function fixture(t, options = {}) {
window.pendingScreenshots.delete(source);
for (const { reject } of pending) reject(new Error("Screenshot resolution failed"));
};
if (fixture.decode === "manual") {
// The test settles each decode; one it never settles stands in for a decode that hangs.
window.pendingDecodes = [];
HTMLImageElement.prototype.decode = function () {
return new Promise((resolve, reject) => window.pendingDecodes.push({ image: this, resolve, reject }));
};
}
}, { source: firstSource, layout: "visible", ...options });
if (options.reducedMotion) await page.emulateMedia({ reducedMotion: "reduce" });
await page.goto(`http://127.0.0.1:${address.port}/`);
await page.waitForFunction(() => window.harnessReady);
return { page, image: page.getByRole("img", { name: "Captured checkout", exact: true }) };
@@ -530,187 +505,3 @@ test("an image that leaves and re-enters the viewport within one render is ready
await expect(image).not.toHaveAttribute("aria-busy", /.*/);
assert.equal(await page.evaluate(() => window.imageLoads.length), 1, "No second load event fired");
});
/** The image's opacity and state in each of the next `frames` frames, from the frame after `change` runs. */
async function framesAfter(page, change, frames = 4, selector = "img[alt='Captured checkout']") {
return page.evaluate(({ change, frames, selector }) => new Promise(resolve => {
const samples = [];
new Function(change)();
const sample = () => {
const image = document.querySelector(selector);
samples.push(image ? { source: image.dataset.screenshotSrc ?? image.getAttribute("src"),
state: image.dataset.screenshotState, opacity: getComputedStyle(image).opacity } : undefined);
if (samples.length < frames) requestAnimationFrame(sample);
else resolve(samples);
};
requestAnimationFrame(sample);
}), { change, frames, selector });
}
/** The reveal animation on the image, paused and sought to `at` milliseconds: its opacity there. */
async function revealOpacityAt(image, at) {
return image.evaluate((element, at) => {
const [animation] = element.getAnimations().filter(animation => animation.animationName === "screenshot-reveal");
if (!animation) return undefined;
animation.pause();
animation.currentTime = at;
return Number(getComputedStyle(element).opacity);
}, at);
}
test("a waiting screenshot is hidden from its first frame, and one that fills its empty frame fades in", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true });
await expect.poll(() => page.evaluate(() => window.resolverCalls)).toEqual([firstSource]);
await expect(image).toHaveCSS("opacity", "0");
await resolveImage(page, firstSource);
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
assert.equal(await revealOpacityAt(image, 0), 0, "The fade starts from nothing");
const midway = await revealOpacityAt(image, 80);
assert.ok(midway > 0 && midway < 1, `Halfway through the fade the picture is partly shown (${midway})`);
await image.evaluate(element => element.getAnimations().forEach(animation => animation.finish()));
await expect(image).toHaveCSS("opacity", "1");
// Another source: the picture before is hidden in the very frame the new source lands, never faded out.
const samples = await framesAfter(page, `window.updateScreenshot({ source: ${JSON.stringify(secondSource)} })`);
const landed = samples.filter(sample => sample?.source === secondSource);
assert.ok(landed.length > 0, "The new source landed within a few frames");
assert.deepEqual(landed.map(sample => sample.opacity), landed.map(() => "0"));
assert.deepEqual(samples.filter(sample => sample?.source !== secondSource).map(sample => sample.opacity),
samples.filter(sample => sample?.source !== secondSource).map(() => "1"), "Until then, the shown picture is the one it names");
assert.deepEqual(await image.evaluate(element => element.getAnimations().map(animation => animation.constructor.name)), [],
"Nothing animates the hiding");
});
test("a loaded screenshot is shown only once it has decoded, or after a short wait for a decode that hangs", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true, decode: "manual" });
await resolveImage(page, firstSource);
// The caller hears the load at once (Compare takes its shape from it); the picture waits for its pixels.
await expect.poll(() => page.evaluate(() => window.imageLoads.length)).toBe(1);
await expect.poll(() => page.evaluate(() => window.pendingDecodes.length)).toBe(1);
await page.waitForTimeout(100);
await expect(image).toHaveAttribute("data-screenshot-state", "loading");
await expect(image).toHaveCSS("opacity", "0");
await page.evaluate(() => window.pendingDecodes.shift().resolve());
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
// A decode that never settles: shown anyway, with its fade.
await page.evaluate(source => window.updateScreenshot({ source }), secondSource);
await resolveImage(page, secondSource, secondImage);
await expect.poll(() => page.evaluate(() => window.pendingDecodes.length)).toBe(1);
const loadedAt = await page.evaluate(() => performance.now());
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
const waited = await page.evaluate(() => performance.now()) - loadedAt;
assert.ok(waited >= 200, `The hung decode was waited for before the picture was shown (${Math.round(waited)}ms)`);
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
assert.equal(await image.evaluate(element => element.naturalWidth), 4);
});
test("a screenshot the report still holds decoded fades in when it is shown again", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true });
const url = await blobUrl(page, firstImage);
await expect.poll(() => page.evaluate(() => window.resolverCalls)).toEqual([firstSource]);
await page.evaluate(({ source, url }) => window.resolveScreenshot(source, url), { source: firstSource, url });
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
// Shown again (Compare stepping back to it, a view mounting again) while the report still holds its decoded URL.
await page.evaluate(() => window.updateScreenshot({ mounted: false }));
await expect(image).toHaveCount(0);
await page.evaluate(({ source, url }) => {
window.immediateScreenshots.set(source, url);
window.updateScreenshot({ mounted: true });
}, { source: firstSource, url });
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
assert.equal(await revealOpacityAt(image, 0), 0);
});
test("an ordinary URL is a new image for each source and never shows the one before while it loads", { timeout: 30_000 }, async t => {
const { page } = await fixture(t, { loading: "eager", styles: true, normalSource: "/__normal.png" });
const hosted = page.getByRole("img", { name: "Hosted screenshot", exact: true });
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
await expect(hosted).toHaveAttribute("data-screenshot-reveal", "");
await hosted.evaluate(element => { element.dataset.first = "true"; });
const samples = await framesAfter(page, "window.updateScreenshot({ normalSource: '/__slow.png' })", 6, "img[alt='Hosted screenshot']");
const landed = samples.filter(sample => sample?.source === "/__slow.png");
assert.ok(landed.length > 0);
assert.deepEqual(landed.map(sample => [sample.state, sample.opacity]), landed.map(() => ["loading", "0"]));
await expect(hosted).not.toHaveAttribute("data-first", /.*/);
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
await expect(hosted).toHaveAttribute("data-screenshot-reveal", "");
await expectDecoded(hosted, 4, 5);
});
test("a held picture stays shown while its replacement loads, and the replacement appears without a fade", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true, holdPrevious: true, fallback: true });
await resolveImage(page, firstSource);
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await page.evaluate(source => window.updateScreenshot({ source }), secondSource);
await expect(image).toHaveAttribute("data-screenshot-held", "");
await expect(image).toHaveCSS("opacity", "1");
await resolveImage(page, secondSource, secondImage);
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await expectDecoded(image, 4, 5);
await expect(image).not.toHaveAttribute("data-screenshot-reveal", /.*/);
await expect(image).not.toHaveAttribute("data-screenshot-held", /.*/);
assert.deepEqual(await image.evaluate(element => element.getAnimations().length), 0);
});
test("inside an instant stage a picture appears at once", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true, instant: true });
await resolveImage(page, firstSource);
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await expect(image).not.toHaveAttribute("data-screenshot-reveal", /.*/);
await expect(image).toHaveCSS("opacity", "1");
});
test("with reduced motion a screenshot appears without a fade", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true, reducedMotion: true });
await resolveImage(page, firstSource);
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
// The Viewer's reduced-motion rule leaves every transition a hundredth of a millisecond long; the fade is gone.
assert.deepEqual(await image.evaluate(element => element.getAnimations().map(animation => animation.animationName).filter(Boolean)), []);
await expect(image).toHaveCSS("opacity", "1");
});
test("an unselected variant thumbnail that changes source hides at once, despite its own dimmed opacity and its transition", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true, thumbnail: true });
await resolveImage(page, firstSource);
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
await image.evaluate(element => element.getAnimations().forEach(animation => animation.finish()));
await expect(image).toHaveCSS("opacity", "0.35");
const samples = await framesAfter(page, `window.updateScreenshot({ source: ${JSON.stringify(secondSource)} })`);
const landed = samples.filter(sample => sample?.source === secondSource);
assert.ok(landed.length > 0);
assert.deepEqual(landed.map(sample => sample.opacity), landed.map(() => "0"));
});
test("an ordinary URL that cannot be loaded shows the fallback, and a held one gives way to it", { timeout: 30_000 }, async t => {
const { page } = await fixture(t, { loading: "eager", styles: true, fallback: true, holdPrevious: true, normalSource: "/__normal.png" });
const hosted = page.getByRole("img", { name: "Hosted screenshot", exact: true });
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
// The app icon's case: a held picture whose replacement is missing ends on the fallback, not on the picture before.
await page.evaluate(() => window.updateScreenshot({ normalSource: "/__missing.png" }));
await expect(page.getByTestId("hosted-fallback")).toHaveText("No hosted screenshot");
await expect(hosted).toHaveCount(0);
// A new source tries again.
await page.evaluate(() => window.updateScreenshot({ normalSource: "/__normal.png" }));
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
await expect(page.getByTestId("hosted-fallback")).toHaveCount(0);
});
test("re-rendering an image that waits for its decode starts no second wait", { timeout: 30_000 }, async t => {
const { page, image } = await fixture(t, { loading: "eager", styles: true, decode: "manual" });
await resolveImage(page, firstSource);
await expect.poll(() => page.evaluate(() => window.pendingDecodes.length)).toBe(1);
// Renders while the decode is pending find the image loaded but not shown yet.
for (let render = 0; render < 5; render++) {
await page.evaluate(render => window.updateScreenshot({ render }), render);
await page.evaluate(() => new Promise(resolve => requestAnimationFrame(resolve)));
}
assert.equal(await page.evaluate(() => window.pendingDecodes.length), 1, "One decode wait for the one picture");
await page.evaluate(() => window.pendingDecodes.shift().resolve());
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
});
+5 -46
View File
@@ -5,13 +5,11 @@ import { chromium, expect } from "@playwright/test";
import { PNG } from "pngjs";
import { createBrowserVite } from "../helpers/browser-vite.mjs";
function pngBytes(width, height, color) {
function png(width, height, color) {
const image = new PNG({ width, height });
for (let index = 0; index < image.data.length; index += 4) image.data.set([...color, 255], index);
return PNG.sync.write(image);
return `data:image/png;base64,${PNG.sync.write(image).toString("base64")}`;
}
const png = (width, height, color) => `data:image/png;base64,${pngBytes(width, height, color).toString("base64")}`;
const GREEN = [40, 200, 40];
// Split over one screen with two changed areas and a card that moved 40% of the width right (at 60% in After, so
// at 20% in Before), and a second screen with one changed area elsewhere. The status bar CI left out is a foldable's
@@ -47,9 +45,7 @@ function Harness() {
window.addEventListener("keydown", onKey);
return () => window.removeEventListener("keydown", onKey);
}, []);
// The second screen has screenshots of its own when the test gives it some.
const diff = { id: "s" + screen, status: "modified", beforeScreenshot: screen && window.nextBefore || window.before,
afterScreenshot: screen && window.nextAfter || window.after };
const diff = { id: "s" + screen, status: "modified", beforeScreenshot: window.before, afterScreenshot: window.after };
return (
<div className={"compare-stage mode-" + mode} style={{ width: 800, height: 500, display: "flex" }}>
<CompareStage key="stage" mode={mode} diff={diff} title="Share" areas={screens[screen]} activeArea={active}
@@ -61,7 +57,7 @@ function Harness() {
createRoot(document.getElementById("root")).render(<Harness />);
`;
async function openSplit(t, contextOptions = {}, images = {}) {
async function openSplit(t, contextOptions = {}) {
const vite = await createBrowserVite(t, {
configFile: false, root: fileURLToPath(new URL("../../viewer", import.meta.url)),
logLevel: "error", esbuild: { jsx: "automatic" },
@@ -71,12 +67,6 @@ async function openSplit(t, contextOptions = {}, images = {}) {
load: id => id === "/__split-outlines.tsx" ? entry : undefined,
configureServer(server) {
server.middlewares.use((request, response, next) => {
// The next screen's Before, which takes a while to arrive.
if (request.url === "/__slow-before.png") {
response.setHeader("Content-Type", "image/png");
setTimeout(() => response.end(pngBytes(100, 100, GREEN)), 1000);
return;
}
if (new URL(request.url, "http://localhost").pathname !== "/") return next();
response.setHeader("Content-Type", "text/html");
response.end('<!doctype html><html><body style="margin:0"><div id="root"></div><script type="module" src="/__split-outlines.tsx"></script></body></html>');
@@ -92,7 +82,7 @@ async function openSplit(t, contextOptions = {}, images = {}) {
const errors = [];
page.on("pageerror", error => errors.push(error.message));
t.after(() => assert.deepEqual(errors, []));
await page.addInitScript(images => Object.assign(window, images), { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]), ...images });
await page.addInitScript(images => Object.assign(window, images), { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]) });
await page.goto(`http://127.0.0.1:${vite.httpServer.address().port}/`);
const outline = (side, index) => page.locator(`[data-side="${side}"] .visual-change-outline`).nth(index);
await expect(outline("after", 0)).toBeVisible();
@@ -153,34 +143,3 @@ test("A screen without hover keeps Before's outlines, as it cannot reveal one",
await expect.poll(() => opacity(outline("before", 0))).toBe(1);
await expect.poll(() => opacity(outline("before", 2))).toBe(1);
});
test("Stepping never shows the screen before's pictures under the next one's outlines: a side still loading is an empty frame", { timeout: 30_000 }, async t => {
const images = { before: png(100, 100, [200, 40, 40]), after: png(100, 100, [40, 40, 200]),
nextBefore: "/__slow-before.png", nextAfter: png(100, 100, [200, 200, 40]) };
const { page } = await openSplit(t, {}, images);
for (const side of ["before", "after"]) await expect(page.locator(`[data-side="${side}"] img`)).toHaveAttribute("data-screenshot-state", "ready");
// Every frame from the step on: the screen the outlines belong to, and any picture of the screen before still showing.
await page.evaluate(previous => {
window.stepFrames = [];
const sample = () => {
const outlines = document.querySelectorAll('[data-side="after"] .visual-change-outline').length;
const stale = [...document.querySelectorAll(".compare-frame img")].filter(image => previous.includes(image.getAttribute("src"))
&& Number(getComputedStyle(image).opacity) > 0).length;
window.stepFrames.push({ outlines, stale });
if (window.stepFrames.length < 30) requestAnimationFrame(sample);
};
requestAnimationFrame(sample);
}, [images.before, images.after]);
await page.keyboard.press("n");
await expect.poll(() => page.evaluate(() => window.stepFrames.length)).toBe(30);
const frames = await page.evaluate(() => window.stepFrames);
assert.ok(frames.some(frame => frame.outlines === 1), "The step landed while the frames were sampled");
assert.deepEqual(frames.filter(frame => frame.outlines === 1 && frame.stale > 0), [], "No frame showed a picture of the screen before under the next one's outlines");
// Before is still loading: its frame is empty, After's shows the new screen.
const before = page.locator('[data-side="before"] img');
await expect(before).toHaveAttribute("data-screenshot-state", "loading");
await expect(before).toHaveCSS("opacity", "0");
await expect(page.locator('[data-side="after"] img')).toHaveAttribute("data-screenshot-state", "ready");
await expect(before).toHaveAttribute("data-screenshot-state", "ready", { timeout: 5000 });
});
+6 -53
View File
@@ -5,15 +5,11 @@ import { chromium, expect } from "@playwright/test";
import { PNG } from "pngjs";
import { createBrowserVite } from "../helpers/browser-vite.mjs";
function pngBytes(width, height, color) {
function png(width, height, color) {
const image = new PNG({ width, height });
for (let index = 0; index < image.data.length; index += 4) image.data.set([...color, 255], index);
return PNG.sync.write(image);
return `data:image/png;base64,${PNG.sync.write(image).toString("base64")}`;
}
const png = (width, height, color) => `data:image/png;base64,${pngBytes(width, height, color).toString("base64")}`;
const RED = [200, 40, 40];
const BLUE = [40, 40, 200];
// A card that moved 40% of the width right: it is at 60% in After, so it was at 20% in Before.
const entry = `
@@ -23,11 +19,11 @@ import "/src/styles.css";
const changes = [{ x: 60, y: 30, width: 30, height: 30, share: 100, regionCount: 1,
move: { x: 40, y: 0, amount: { x: 400, y: 0 }, unit: "px" } }];
createRoot(document.getElementById("root")).render(<div style={{ width: 400, display: "flex" }}>
<SwipeCompare title="Share" before={window.before} after={window.after} imageAspect={1} changes={changes} position={window.position ?? 50} />
<SwipeCompare title="Share" before={window.before} after={window.after} imageAspect={1} changes={changes} position={50} />
</div>);
`;
async function openSwipe(t, images) {
test("Swipe draws a moved area where its content was on Before's half and where it is on After's", { timeout: 30_000 }, async t => {
const vite = await createBrowserVite(t, {
configFile: false, root: fileURLToPath(new URL("../../viewer", import.meta.url)),
logLevel: "error", esbuild: { jsx: "automatic" },
@@ -37,12 +33,6 @@ async function openSwipe(t, images) {
load: id => id === "/__swipe-outlines.tsx" ? entry : undefined,
configureServer(server) {
server.middlewares.use((request, response, next) => {
// A Before that takes a while to arrive.
if (request.url === "/__slow-before.png") {
response.setHeader("Content-Type", "image/png");
setTimeout(() => response.end(pngBytes(100, 100, RED)), 1000);
return;
}
if (new URL(request.url, "http://localhost").pathname !== "/") return next();
response.setHeader("Content-Type", "text/html");
response.end('<!doctype html><html><body style="margin:0"><div id="root"></div><script type="module" src="/__swipe-outlines.tsx"></script></body></html>');
@@ -57,23 +47,9 @@ async function openSwipe(t, images) {
const page = await browser.newPage({ viewport: { width: 600, height: 600 } });
const errors = [];
page.on("pageerror", error => errors.push(error.message));
t.after(() => assert.deepEqual(errors, []));
await page.addInitScript(images => Object.assign(window, images), images);
await page.addInitScript(images => Object.assign(window, images), { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]) });
await page.goto(`http://127.0.0.1:${vite.httpServer.address().port}/`);
return page;
}
/** The colour on screen at `x` (a share of the frame's width), a fifth of the way down the Swipe frame, clear of the divider's handle. */
async function colourAt(page, x) {
const box = await page.locator(".visual-swipe").boundingBox();
const shot = PNG.sync.read(await page.screenshot({ clip: { x: box.x + box.width * x, y: box.y + box.height / 5, width: 1, height: 1 } }));
return [...shot.data.subarray(0, 3)];
}
const near = (colour, expected) => colour.every((value, index) => Math.abs(value - expected[index]) <= 6);
test("Swipe draws a moved area where its content was on Before's half and where it is on After's", { timeout: 30_000 }, async t => {
const page = await openSwipe(t, { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]) });
const frame = page.locator(".visual-swipe");
const before = page.locator(".visual-swipe-outlines.before .visual-change-outline.moved");
const after = page.locator(".visual-swipe-outlines.after .visual-change-outline.moved");
@@ -84,28 +60,5 @@ test("Swipe draws a moved area where its content was on Before's half and where
// Each side's outlines show only over its own half of the frame.
const clips = await page.locator(".visual-swipe-outlines").evaluateAll(spans => spans.map(span => getComputedStyle(span).clipPath));
assert.deepEqual(clips.map(clip => clip.startsWith("inset(")), [true, true]);
assert.deepEqual(errors, []);
});
test("Swipe never shows After on Before's half: while Before loads, its half is the empty frame", { timeout: 30_000 }, async t => {
const page = await openSwipe(t, { before: "/__slow-before.png", after: png(100, 100, BLUE) });
const before = page.locator("img.visual-swipe-before");
await expect(page.locator("img.visual-swipe-after")).toHaveAttribute("data-screenshot-state", "ready");
await expect(before).toHaveAttribute("data-screenshot-state", "loading");
await page.evaluate(() => document.getAnimations().forEach(animation => animation.finish()));
assert.ok(near(await colourAt(page, 0.75), BLUE), "After shows on its own half");
const waiting = await colourAt(page, 0.25);
assert.ok(!near(waiting, BLUE) && !near(waiting, RED), `Before's half is the empty frame while Before loads: ${waiting}`);
await expect(before).toHaveAttribute("data-screenshot-state", "ready");
await page.evaluate(() => document.getAnimations().forEach(animation => animation.finish()));
assert.ok(near(await colourAt(page, 0.25), RED));
assert.ok(near(await colourAt(page, 0.75), BLUE));
});
for (const [position, shown] of [[0, BLUE], [100, RED]]) {
test(`Swipe at ${position}% shows only ${position ? "Before" : "After"}, across the whole frame`, { timeout: 30_000 }, async t => {
const page = await openSwipe(t, { before: png(100, 100, RED), after: png(100, 100, BLUE), position });
for (const side of ["before", "after"]) await expect(page.locator(`img.visual-swipe-${side}`)).toHaveAttribute("data-screenshot-state", "ready");
await page.evaluate(() => document.getAnimations().forEach(animation => animation.finish()));
for (const x of [0.03, 0.5, 0.97]) assert.ok(near(await colourAt(page, x), shown), `${position}%: ${x} of the way across`);
});
}
+19 -50
View File
@@ -178,63 +178,32 @@ test.describe("Inspector resize", () => {
await expect.poll(() => panelWidth(page)).toBe(500);
});
test.describe("in a window too narrow for the toolbar beside a half-window Inspector", () => {
test.describe("in a window too narrow for the toolbar beside a wide Inspector", () => {
test.use({ viewport: { width: 820, height: 800 } });
/** The widest the panel may be here: the window less the bottom bar and a 12px gap either side. */
async function widestBesideToolbar(page: Page) {
const toolbarBox = (await page.getByRole("toolbar", { name: "Canvas tools" }).boundingBox())!;
return Math.floor(820 - (toolbarBox.width + 2 * 12));
}
async function expectToolbarBesidePanel(page: Page) {
test("the toolbar never moves past the canvas' left edge", async ({ page }) => {
await page.goto("/map?screen=area-0-screen-1");
await expect(panel(page)).toBeVisible();
const toolbar = page.getByRole("toolbar", { name: "Canvas tools" });
await expect(toolbar).toBeVisible();
await expect(toolbar.getByRole("button", { name: "More", exact: true })).toBeVisible();
const toolbarBox = (await toolbar.boundingBox())!;
const panelBox = (await panel(page).boundingBox())!;
expect(toolbarBox.x).toBeGreaterThanOrEqual(12 - 1);
expect(toolbarBox.x + toolbarBox.width + 12).toBeLessThanOrEqual(panelBox.x + 1);
}
test("End stops the Inspector where the toolbar still fits beside it, with More in reach", async ({ page }) => {
await page.goto("/map?screen=area-0-screen-1");
await expect(panel(page)).toBeVisible();
const widest = await widestBesideToolbar(page);
// Half the window would be 410; the toolbar needs more of the canvas than that leaves.
expect(widest).toBeLessThan(410);
expect(widest).toBeGreaterThan(320);
await expect(handle(page)).toHaveAttribute("aria-valuemax", String(widest));
await handle(page).focus();
await page.keyboard.press("End");
await expect.poll(() => panelWidth(page)).toBe(widest);
await expect(handle(page)).toHaveAttribute("aria-valuenow", String(widest));
await page.keyboard.press("ArrowLeft");
await expect.poll(() => panelWidth(page)).toBe(widest);
await expectToolbarBesidePanel(page);
// Narrowed again, the toolbar keeps its gap to the panel.
await expect.poll(() => panelWidth(page)).toBe(410);
// Either it fits between the window's edge and the panel, or it gives way, as it does when
// the panels leave the canvas too little room.
await expect.poll(async () => {
if (await toolbar.count() === 0) return true;
const toolbarBox = (await toolbar.boundingBox())!;
const panelBox = (await panel(page).boundingBox())!;
return toolbarBox.x >= 0 && toolbarBox.x + toolbarBox.width <= panelBox.x;
}).toBe(true);
// Narrowed again, the toolbar returns.
await page.keyboard.press("Home");
await expect.poll(() => panelWidth(page)).toBe(320);
await expectToolbarBesidePanel(page);
});
test("a drag or a saved width stops there too", async ({ page }) => {
await page.goto("/map?screen=area-0-screen-1");
await expect(panel(page)).toBeVisible();
const widest = await widestBesideToolbar(page);
await dragEdge(page, -300);
await expect.poll(() => panelWidth(page)).toBe(widest);
expect(await storedWidth(page)).toBe(String(widest));
await expectToolbarBesidePanel(page);
await page.evaluate((key) => localStorage.setItem(key, "800"), STORAGE_KEY);
await page.reload();
await expect(panel(page)).toBeVisible();
await expect.poll(() => panelWidth(page)).toBe(widest);
await expectToolbarBesidePanel(page);
// A wider window gives the saved width more room again.
await page.setViewportSize({ width: 1280, height: 800 });
await expect.poll(() => panelWidth(page)).toBe(640);
await expect(toolbar).toBeVisible();
const toolbarBox = (await toolbar.boundingBox())!;
const panelBox = (await panel(page).boundingBox())!;
expect(toolbarBox.x).toBeGreaterThanOrEqual(0);
expect(toolbarBox.x + toolbarBox.width + 12).toBeCloseTo(panelBox.x, 0);
});
});
+127 -526
View File
@@ -197,20 +197,15 @@ async function expectMapSelectionRing(page: Page) {
await page.mouse.move(1, 1);
}
/** Picks a theme in the bottom bar's More menu, then closes the menu. */
/** The camera chrome's theme button steps Auto → Dark → Light; press it until the page shows the option. */
async function chooseTheme(page: Page, option: "light" | "dark") {
await page.getByRole("button", { name: "More", exact: true }).click();
const menu = page.getByRole("menu", { name: "More" });
await menu.getByRole("menuitemradio", { name: option === "light" ? "Light" : "Dark", exact: true }).click();
await page.keyboard.press("Escape");
await expect(menu).toHaveCount(0);
await expect(page.locator("html")).toHaveAttribute("data-theme", option);
}
/** There is no button to bring the Inspector back; a selection, Return or I opens it. */
async function openInspector(page: Page) {
await page.keyboard.press("i");
await expect(page.locator(".right-panel")).toBeVisible();
const root = page.locator("html");
for (let presses = 0; presses < 3; presses += 1) {
if (await root.getAttribute("data-theme") === option) return;
await page.getByRole("button", { name: "Toggle theme" }).click();
await page.waitForTimeout(50);
}
await expect(root).toHaveAttribute("data-theme", option);
}
/** Bottom toolbar → persistent canvas view control. */
@@ -1254,7 +1249,7 @@ test("does not send viewer cookies to a cross-origin static workspace", async ({
test("the logo returns to the Map root", async ({ page }) => {
await page.goto("/screens?screen=settings-root");
await page.locator(".left-panel-collapsed-pill").getByRole("button", { name: /^Map of / }).click();
await page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map", exact: true }).click();
await expect(page).toHaveURL(/\/map$/);
await expect(page.locator(".map-canvas")).toBeVisible();
});
@@ -1673,7 +1668,7 @@ test("collapses the Inspector when a screen is cleared but still allows an empty
await expect.poll(() => new URL(page.url()).searchParams.has("screen")).toBe(false);
await expect(page.locator(".right-panel")).toHaveCount(0);
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.locator(".right-panel")).toBeVisible();
await expect.poll(() => new URL(page.url()).searchParams.has("screen")).toBe(false);
});
@@ -1859,12 +1854,13 @@ test("keeps persistent canvas chrome out of the sliding canvas snapshot", async
await page.setViewportSize({ width: 1600, height: 900 });
await page.goto("/map");
await expect(page.locator(".canvas-minimap-shell")).toBeVisible();
await expect(page.locator(".app-content > .canvas-camera-controls")).toBeVisible();
await expect(page.locator(".right-float")).toBeVisible();
const transitionNames = await page.locator([
".canvas-minimap-shell",
".app-content > .canvas-camera-controls",
".canvas-toolbar",
".right-float",
].join(",")).evaluateAll((elements) => elements.map((element) => ({
className: element.className,
viewTransitionName: getComputedStyle(element).viewTransitionName,
@@ -1873,6 +1869,7 @@ test("keeps persistent canvas chrome out of the sliding canvas snapshot", async
expect.objectContaining({ viewTransitionName: "canvas-minimap" }),
expect.objectContaining({ viewTransitionName: "canvas-camera-controls" }),
expect.objectContaining({ viewTransitionName: "canvas-toolbar" }),
expect.objectContaining({ viewTransitionName: "right-floating-controls" }),
]));
const animations = await captureCanvasViewAnimations(page, "Screens");
@@ -1893,6 +1890,7 @@ test("keeps persistent canvas chrome out of the sliding canvas snapshot", async
const movingPersistentChrome = animations.filter((animation) => (
animation.pseudoElement?.includes("(canvas-camera-controls)")
|| animation.pseudoElement?.includes("(canvas-toolbar)")
|| animation.pseudoElement?.includes("(right-floating-controls)")
));
expect(movingPersistentChrome).toEqual([]);
});
@@ -1918,7 +1916,7 @@ test("centres selected screens after panel changes and makes the primary Fit sel
await expectSelectedScreenCentered(page);
await expectPanelFitMatchesPrimaryFit(page, canvas);
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.locator(".right-panel")).toBeVisible();
await expectSelectedScreenCentered(page);
await expectPanelFitMatchesPrimaryFit(page, canvas);
@@ -2257,7 +2255,7 @@ test("keeps current Map and Screens projections overlap-free without deleting sc
await expect(page).toHaveURL(/\/screens/);
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(SCREEN_COUNT);
await expect.poll(() => overlapCount(".screens-page .screens-cell")).toBe(0);
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.locator(".right-panel")).toBeVisible();
await expect.poll(() => overlapCount(".screens-page .screens-cell")).toBe(0);
});
@@ -2339,7 +2337,7 @@ test("shows the minimap on the Map without a visibility preference", async ({ pa
test("keeps minimap and canvas chrome inside the responsive visible frame", async ({ page }) => {
await page.setViewportSize({ width: 900, height: 820 });
await page.goto("/map");
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
const minimap = page.getByTestId("canvas-minimap");
const toolbar = page.getByRole("toolbar", { name: "Canvas tools" });
@@ -2379,7 +2377,6 @@ test("keeps minimap and canvas chrome inside the responsive visible frame", asyn
const cameraBeforeTheme = await viewport.getAttribute("style");
const maskBeforePanel = await minimap.locator(".canvas-minimap-visible-mask path").getAttribute("d");
const lightBackground = await minimap.evaluate((element) => getComputedStyle(element).backgroundColor);
// The bar has moved clear of the Inspector, so its More menu is in reach.
await chooseTheme(page, "dark");
await expect(page.locator("html")).toHaveAttribute("data-theme", "dark");
await expect(viewport).toHaveAttribute("style", cameraBeforeTheme!);
@@ -2493,9 +2490,7 @@ test("animates panel Fits once in both directions", async ({ page }) => {
}).__panelFitCameraObserver = observer;
});
// Closed, the Inspector has no button: I opens it.
if (buttonName === "Expand inspector") await page.keyboard.press("i");
else await page.getByRole("button", { name: buttonName, exact: true }).click();
await page.getByRole("button", { name: buttonName, exact: true }).click();
await expectLayout();
await page.waitForTimeout(520);
const samples = await page.evaluate(() => {
@@ -2629,9 +2624,7 @@ test("refits every unselected canvas when the Inspector opens or closes", async
host.__overviewPanelCamera = { values, observer };
}, canvas);
// Closed, the Inspector has no button: I opens it.
if (buttonName === "Expand inspector") await page.keyboard.press("i");
else await page.getByRole("button", { name: buttonName, exact: true }).click();
await page.getByRole("button", { name: buttonName, exact: true }).click();
if (buttonName === "Expand inspector") {
await expect(page.locator(".right-panel")).toBeVisible();
} else {
@@ -2723,7 +2716,7 @@ test("starts the opening Inspector Fit immediately and settles in one flight", a
.__inspectorPaintSamples = samples;
});
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.locator(".right-panel")).toBeVisible();
await page.waitForTimeout(600);
const samples = await page.evaluate(() => (
@@ -2765,41 +2758,47 @@ test("starts the opening Inspector Fit immediately and settles in one flight", a
expect(moving[0]!.elapsed - visible[0]!.elapsed).toBeLessThan(80);
});
test("aligns the pill and the Map's camera controls on one center line, mirrored at the edges", async ({ page }) => {
test("aligns the pill, camera controls, and collapsed Inspector chrome on one center line", async ({ page }) => {
await page.goto("/map?screen=settings-root");
await page.getByRole("button", { name: "Close inspector" }).click();
const pill = page.locator(".left-panel-collapsed-pill");
const camera = page.getByRole("group", { name: "Canvas camera controls" });
const fit = camera.getByRole("button", { name: "Fit canvas", exact: true });
const inspector = page.locator(".right-float");
const share = camera.getByRole("button", { name: "Toggle theme", exact: true });
await expect(pill).toBeVisible();
await expect(camera).toBeVisible();
// The closed Inspector leaves nothing behind in the top right.
await expect(page.getByRole("button", { name: "Expand inspector" })).toHaveCount(0);
await expect(inspector).toBeVisible();
const [pillBox, cameraBox, fitBox] = await Promise.all([
const [pillBox, cameraBox, inspectorBox, shareBox] = await Promise.all([
pill.boundingBox(),
camera.boundingBox(),
fit.boundingBox(),
inspector.boundingBox(),
share.boundingBox(),
]);
expect(pillBox).not.toBeNull();
expect(cameraBox).not.toBeNull();
expect(fitBox).not.toBeNull();
expect(inspectorBox).not.toBeNull();
expect(shareBox).not.toBeNull();
expect(Math.abs(pillBox!.y - 14)).toBeLessThanOrEqual(1);
expect(Math.abs(pillBox!.height - 42)).toBeLessThanOrEqual(1);
expect(Math.abs(cameraBox!.y - 14)).toBeLessThanOrEqual(1);
expect(Math.abs(cameraBox!.height - 42)).toBeLessThanOrEqual(1);
expect(Math.abs(fitBox!.height - 32)).toBeLessThanOrEqual(1);
expect(Math.abs(pillBox!.y + pillBox!.height / 2 - (cameraBox!.y + cameraBox!.height / 2))).toBeLessThanOrEqual(1);
// The controls sit as far from the right edge as the pill does from the left.
expect(Math.abs(page.viewportSize()!.width - (cameraBox!.x + cameraBox!.width) - pillBox!.x)).toBeLessThanOrEqual(1);
expect(Math.abs(inspectorBox!.y - 14)).toBeLessThanOrEqual(1);
expect(Math.abs(inspectorBox!.height - 42)).toBeLessThanOrEqual(1);
expect(Math.abs(shareBox!.height - 32)).toBeLessThanOrEqual(1);
const centerLine = cameraBox!.y + cameraBox!.height / 2;
for (const box of [pillBox!, inspectorBox!]) {
expect(Math.abs(box.y + box.height / 2 - centerLine)).toBeLessThanOrEqual(1);
}
});
test("floats the pill over the canvas and remembers the Inspector across a reload", async ({ page }) => {
await page.goto("/map");
await expect(page.locator(".right-panel")).toHaveCount(0);
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
// The pill and the Inspector share one panel surface.
const expandedPanelBackground = await page.locator(".left-panel-collapsed-pill").evaluate(
(element) => getComputedStyle(element).backgroundColor,
@@ -2811,7 +2810,7 @@ test("floats the pill over the canvas and remembers the Inspector across a reloa
expect(expandedCameraShadow).not.toBe("none");
const collapsedPanel = page.locator(".left-panel.collapsed");
await expect(collapsedPanel).toBeVisible();
await expect(collapsedPanel.getByRole("button", { name: /^Map of / })).toBeVisible();
await expect(collapsedPanel.getByRole("button", { name: "Map", exact: true })).toBeVisible();
await expect(collapsedPanel.locator(".collapsed-app-identity strong")).toBeVisible();
// There is no sidebar to open: the pill is the only left chrome.
await expect(page.getByRole("button", { name: /^(Expand|Collapse) panel$/ })).toHaveCount(0);
@@ -2834,20 +2833,31 @@ test("floats the pill over the canvas and remembers the Inspector across a reloa
await page.getByRole("button", { name: "Close inspector" }).click();
await expect(page.locator(".right-panel")).toHaveCount(0);
const canvasActions = page.getByRole("toolbar", { name: "Canvas actions" });
const cameraControls = page.getByRole("group", { name: "Canvas camera controls" });
const canvasToolbar = page.getByRole("toolbar", { name: "Canvas tools" });
const minimap = page.getByTestId("canvas-minimap");
// Closed, the Inspector leaves no toolbar of its own; the camera controls stay one floating group.
await expect(page.getByRole("toolbar", { name: "Canvas actions" })).toHaveCount(0);
await expect(canvasActions).toBeVisible();
await expect(cameraControls).toBeVisible();
await expect(canvasToolbar).toBeVisible();
await expect(minimap).toBeVisible();
await expect(canvasActions).toHaveCSS("background-color", expandedPanelBackground);
await expect(cameraControls).toHaveCSS("background-color", expandedPanelBackground);
await expect(cameraControls).toHaveCSS("border-top-width", "1px");
await expect(cameraControls.locator(".camera-control-divider").first()).toBeVisible();
await expect(canvasActions).toHaveCSS("border-top-width", "0px");
await expect(cameraControls).toHaveCSS("border-top-width", "0px");
await expect(cameraControls.locator(".camera-control-divider").first()).toBeHidden();
const [actionsBox, cameraBox] = await Promise.all([
canvasActions.boundingBox(),
cameraControls.boundingBox(),
]);
expect(actionsBox).not.toBeNull();
expect(cameraBox).not.toBeNull();
const toolbarJoin = actionsBox!.x - (cameraBox!.x + cameraBox!.width);
expect(toolbarJoin).toBeGreaterThanOrEqual(-1.5);
expect(toolbarJoin).toBeLessThanOrEqual(0.5);
const [leftShadow, rightShadow, toolbarShadow, toolbarBox, minimapBox] = await Promise.all([
page.locator(".left-panel-collapsed-pill").evaluate((element) => getComputedStyle(element).boxShadow),
cameraControls.evaluate((element) => getComputedStyle(element).boxShadow),
cameraControls.evaluate((element) => getComputedStyle(element, "::before").boxShadow),
canvasToolbar.evaluate((element) => getComputedStyle(element).boxShadow),
canvasToolbar.boundingBox(),
minimap.boundingBox(),
@@ -2864,7 +2874,7 @@ test("floats the pill over the canvas and remembers the Inspector across a reloa
await page.reload();
await expect(page.locator(".left-panel.collapsed")).toBeVisible();
await expect(page.locator(".right-panel")).toHaveCount(0);
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.locator(".right-panel")).toBeVisible();
});
@@ -2900,24 +2910,20 @@ test("keeps stateful shell control geometry stable across visual state changes",
expect(Math.abs(pillAlignment.logo - pillAlignment.pill)).toBeLessThanOrEqual(1);
expect(Math.abs(pillAlignment.name - pillAlignment.pill)).toBeLessThanOrEqual(1);
// Closed, the Inspector has no button; open, an X closes it.
await expect(page.getByRole("button", { name: "Expand inspector" })).toHaveCount(0);
await openInspector(page);
const rightClosed = await geometry(page.getByRole("button", { name: "Expand inspector" }));
await expect(page.getByRole("button", { name: "Expand inspector" })
.locator("svg.lucide-panel-right")).toHaveCount(1);
await page.getByRole("button", { name: "Expand inspector" }).click();
const rightOpen = await geometry(page.getByRole("button", { name: "Close inspector" }));
// Open, the same button shows an X that closes the Inspector.
await expect(page.getByRole("button", { name: "Close inspector" })
.locator("svg.lucide-x")).toHaveCount(1);
expect(rightOpen).toEqual(rightClosed);
// The More button keeps its size whether its menu is open or not, and the theme switch keeps
// its size whichever theme is checked.
const more = page.getByRole("button", { name: "More", exact: true });
const moreClosed = await geometry(more);
await more.click();
const moreOpen = await geometry(more);
expect(moreOpen).toEqual(moreClosed);
const themes = page.getByRole("menu", { name: "More" }).getByRole("group", { name: "Theme" });
const lightTheme = await geometry(themes);
await themes.getByRole("menuitemradio", { name: "Dark", exact: true }).click();
await expect(page.locator("html")).toHaveAttribute("data-theme", "dark");
const darkTheme = await geometry(themes);
const themeButton = page.getByRole("button", { name: "Toggle theme" });
const lightTheme = await geometry(themeButton);
await themeButton.click();
const darkTheme = await geometry(themeButton);
expect(darkTheme).toEqual(lightTheme);
});
@@ -2930,7 +2936,7 @@ test("migrates the legacy shared panel preference once into the Inspector prefer
right: localStorage.getItem("expo-explore:right-panel-collapsed"),
}))).toEqual({ legacy: null, right: "true" });
await openInspector(page);
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.locator(".right-panel")).toBeVisible();
});
@@ -3004,18 +3010,14 @@ test("drives the shell from the keyboard, and says so on hover", async ({ page }
// Every remaining shortcut is discoverable: the tooltip prints the key next to the label.
await compareButton.hover();
await expect(page.locator(".tooltip-key")).toHaveText("C");
await page.getByRole("button", { name: "Expand inspector" }).hover();
await expect(page.locator(".tooltip-key")).toHaveText("I");
// The theme button names the mode in force, and T is its key.
const themeButton = page.getByRole("button", { name: "Toggle theme" });
await themeButton.hover();
await expect(page.locator(".tooltip-content")).toContainText("Theme: Auto");
await expect(page.locator(".tooltip-key")).toHaveText("T");
await page.mouse.move(0, 0);
// The More menu's theme row checks the mode in force, and prints T as its key.
const themeChoice = async () => {
await page.getByRole("button", { name: "More", exact: true }).click();
const menu = page.getByRole("menu", { name: "More" });
await expect(menu.getByRole("group", { name: "Theme" }).locator("kbd")).toHaveText("T");
const checked = await menu.getByRole("menuitemradio", { checked: true }).getAttribute("aria-label");
await page.keyboard.press("Escape");
await expect(menu).toHaveCount(0);
return checked;
};
expect(await themeChoice()).toBe("Auto");
const initialTheme = await page.locator("html").getAttribute("data-theme");
expect(initialTheme === "light" || initialTheme === "dark").toBe(true);
const otherTheme = initialTheme === "dark" ? "light" : "dark";
@@ -3024,7 +3026,9 @@ test("drives the shell from the keyboard, and says so on hover", async ({ page }
await expect(page.locator("html")).toHaveAttribute("data-theme", otherTheme);
await page.keyboard.press("t");
await expect(page.locator("html")).toHaveAttribute("data-theme", initialTheme!);
expect(await themeChoice()).toBe(initialTheme === "dark" ? "Dark" : "Light");
await themeButton.hover();
await expect(page.locator(".tooltip-content")).toContainText(initialTheme === "dark" ? "Theme: Dark" : "Theme: Light");
await page.mouse.move(0, 0);
// The retired theme and inspector chords no longer answer.
await page.keyboard.press(`${mod}+Alt+t`);
await expect(page.locator("html")).toHaveAttribute("data-theme", initialTheme!);
@@ -3076,8 +3080,8 @@ test("keeps fixed objects and canvas pan after a reload", async ({ page }) => {
test("delays the first tooltip, then shows subsequent tooltips instantly", async ({ page }) => {
await page.goto("/map");
const menu = page.locator(".left-panel-collapsed-pill").getByRole("button", { name: /^Map of / });
const changes = page.getByRole("button", { name: "Fit canvas", exact: true });
const menu = page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map", exact: true });
const changes = page.getByRole("button", { name: "Expand inspector" });
const tooltip = page.locator(".tooltip");
await menu.hover();
@@ -3087,7 +3091,7 @@ test("delays the first tooltip, then shows subsequent tooltips instantly", async
await expect(tooltip).not.toHaveAttribute("data-instant", "");
await changes.hover();
await expect(tooltip).toContainText("Fit canvas", { timeout: 150 });
await expect(tooltip).toContainText("Expand inspector", { timeout: 150 });
await expect(tooltip).toHaveAttribute("data-instant", "");
await expect(tooltip).toHaveCSS("animation-name", "none");
@@ -3096,7 +3100,7 @@ test("delays the first tooltip, then shows subsequent tooltips instantly", async
await changes.hover();
await page.waitForTimeout(150);
await expect(tooltip).toHaveCount(0);
await expect(tooltip).toContainText("Fit canvas");
await expect(tooltip).toContainText("Expand inspector");
await expect(tooltip).not.toHaveAttribute("data-instant", "");
});
@@ -3125,10 +3129,9 @@ test("follows system theme and polls lightweight status instead of the full map"
await chooseTheme(page, "light");
await expect(page.locator("html")).toHaveAttribute("data-theme", "light");
expect(await page.evaluate(() => localStorage.getItem("expo-explore:theme"))).toBe("light");
// The More menu checks the mode in force.
await page.getByRole("button", { name: "More", exact: true }).click();
await expect(page.getByRole("menuitemradio", { name: "Light", exact: true })).toHaveAttribute("aria-checked", "true");
await page.keyboard.press("Escape");
// The button shows the mode in force (Light), not the next one.
await expect(page.getByRole("button", { name: "Toggle theme" })
.locator("svg.lucide-sun")).toBeVisible();
await page.waitForTimeout(5_500);
expect(mapRequests).toBe(1);
@@ -3147,30 +3150,11 @@ test("Screens adds the screens a live map gains", async ({ page }) => {
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(30, { timeout: 7_000 });
});
test("a local map keeps a screen whose capture gap was accepted on its Map, in Screens and in find", async ({ page }) => {
// A public report leaves such a route out (omitted-screens.ts); a local run's screens are all its own.
const payload = await liveMapPayload(3, 100);
payload.map.gaps.push({ id: "accepted", screenId: "live-screen-2", kind: "coverage", status: "accepted",
message: "Redirect declaration; no screenshot selected", createdAt: payload.map.run.createdAt });
await serveMap(page, payload);
await page.goto("/map");
await expect(page.locator(".react-flow__node-screen")).toHaveCount(3);
await page.goto("/screens");
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(3);
await expect(page.locator('.screens-page .screens-tree-row[data-screen-id="live-screen-2"]')).toHaveCount(1);
await page.keyboard.press("/");
const field = page.getByRole("main", { name: "Screens" }).getByRole("searchbox", { name: "Find screens" });
await expect(field).toBeFocused();
await field.fill("screen 2");
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(1);
await expect(page.locator('.screens-page .screens-cell[data-screen-id="live-screen-2"]')).toHaveCount(1);
});
test("zooms Map inspection up to 25600% without exceeding the ceiling", async ({ page }) => {
test.setTimeout(30_000);
await page.goto("/map");
await expect(page.locator(".map-canvas.canvas-projection-animating")).toHaveCount(0);
await expect(page.getByRole("group", { name: "Canvas camera controls" })).toBeVisible();
await expect(page.locator(".right-float")).toBeVisible();
await page.keyboard.press("Shift+0");
await expect(page.getByRole("button", { name: "Zoom — 100%" })).toBeVisible();
@@ -3191,11 +3175,10 @@ test("zooms Map inspection up to 25600% without exceeding the ceiling", async ({
await expect(zoom).toBeVisible();
expect(scaleFromTransform(await viewport.getAttribute("style"))).toBe(256);
const zoomBox = await zoom.boundingBox();
const cameraBox = await page.getByRole("group", { name: "Canvas camera controls" }).boundingBox();
const shareBox = await page.locator(".right-float").boundingBox();
expect(zoomBox).not.toBeNull();
expect(cameraBox).not.toBeNull();
expect(zoomBox!.x + zoomBox!.width).toBeLessThanOrEqual(cameraBox!.x + cameraBox!.width);
expect(cameraBox!.x + cameraBox!.width).toBeLessThanOrEqual(page.viewportSize()!.width);
expect(shareBox).not.toBeNull();
expect(zoomBox!.x + zoomBox!.width).toBeLessThanOrEqual(shareBox!.x);
await page.keyboard.press("Shift+0");
await expect(page.getByRole("button", { name: "Zoom — 100%" })).toBeVisible();
@@ -3499,13 +3482,15 @@ test("restores the fitted camera after internal navigation on the Map", async ({
});
});
test("the Map's top right holds only fit, center and zoom; theme and full screen are not in the inspector header", async ({ page }) => {
test("keeps theme and full screen in the persistent canvas controls, not the inspector header", async ({ page }) => {
await page.goto("/map");
// Closed, the Inspector leaves no toggle behind: the camera controls are all there is.
// Collapsed inspector: the camera controls and the panel toggle form one toolbar.
const collapsedCamera = page.getByRole("group", { name: "Canvas camera controls" });
await expect(collapsedCamera.getByRole("button")).toHaveCount(3);
await expect(page.getByRole("button", { name: "Expand inspector" })).toHaveCount(0);
await openInspector(page);
await expect(collapsedCamera.getByRole("button", { name: "Toggle theme", exact: true })).toBeVisible();
await expect(collapsedCamera.getByRole("button", { name: "Enter full screen", exact: true })).toBeVisible();
await expect(page.locator(".right-float button")).toHaveCount(1);
await expect(page.locator(".right-float button")).toHaveAccessibleName("Expand inspector");
await page.getByRole("button", { name: "Expand inspector" }).click();
await expect(page.getByRole("button", { name: /Share/ })).toHaveCount(0);
await expect(page.locator(".right-head button")).toHaveCount(1);
await expect(page.locator(".right-head button")).toHaveAccessibleName("Close inspector");
@@ -3523,19 +3508,18 @@ test("the Map's top right holds only fit, center and zoom; theme and full screen
await expect(cameraControls).toBeVisible();
await expect(cameraControls).not.toHaveCSS("background-color", "rgba(0, 0, 0, 0)");
await expect(cameraControls).toHaveCSS("border-top-width", "1px");
await expect(cameraControls.locator(".camera-control-divider")).toHaveCount(1);
await expect(cameraControls.locator(".camera-control-divider")).toHaveCount(3);
const cameraButtons = cameraControls.getByRole("button");
await expect(cameraButtons).toHaveCount(3);
await expect(cameraButtons.nth(0)).toHaveAccessibleName("Fit canvas");
await expect(cameraButtons.nth(1)).toHaveAccessibleName("Center canvas");
await expect(cameraButtons.nth(2)).toHaveAccessibleName(/^Zoom — /);
await expect(page.getByRole("button", { name: /Toggle theme|full screen/ })).toHaveCount(0);
await expect(cameraButtons).toHaveCount(5);
await expect(cameraButtons.nth(3)).toHaveAccessibleName("Toggle theme");
await expect(cameraButtons.nth(4)).toHaveAccessibleName("Enter full screen");
for (const button of await cameraButtons.all()) {
await expect(button).toHaveCSS("border-top-width", "0px");
await expect(button).toHaveCSS("background-color", "rgba(0, 0, 0, 0)");
}
await expect(page.locator(".app-content > .canvas-camera-controls")).toHaveCount(1);
await expect(page.locator(".right-panel .canvas-camera-controls")).toHaveCount(0);
await expect(page.locator(".right-panel .canvas-camera-controls, .right-float .canvas-camera-controls"))
.toHaveCount(0);
const zoomButton = cameraControls.getByRole("button", { name: /^Zoom — / });
await expect(zoomButton).toBeVisible();
await expect(zoomButton.locator("svg")).toHaveCount(0);
@@ -3576,13 +3560,6 @@ test("the Map's top right holds only fit, center and zoom; theme and full screen
await expect.poll(() => viewport.getAttribute("style")).not.toBe(panned);
await expect.poll(async () => scaleFromTransform(await viewport.getAttribute("style")))
.toBeCloseTo(pannedScale, 6);
// The flight to the centre dips the scale on its way, and a drag interrupts it where it is: let it
// land first, the camera unchanged across two frames. The check above can pass on the flight's
// first frame, before the dip shows.
await expect.poll(() => viewport.evaluate((element) => new Promise<boolean>((resolve) => {
const before = element.getAttribute("style");
requestAnimationFrame(() => requestAnimationFrame(() => resolve(element.getAttribute("style") === before)));
}))).toBe(true);
// The keyboard shortcut performs the same scale-preserving camera action.
await page.mouse.move(panPoint.x, panPoint.y);
@@ -3596,10 +3573,11 @@ test("the Map's top right holds only fit, center and zoom; theme and full screen
await expect.poll(async () => scaleFromTransform(await viewport.getAttribute("style")))
.toBeCloseTo(pannedScale, 6);
// The theme changes the page theme without changing the route.
// The theme toggle changes the page theme without changing the route.
const canonical = page.url();
const themeBefore = await page.locator("html").getAttribute("data-theme");
await chooseTheme(page, themeBefore === "dark" ? "light" : "dark");
await cameraControls.getByRole("button", { name: "Toggle theme", exact: true }).click();
await expect(page.locator("html")).not.toHaveAttribute("data-theme", themeBefore!);
await expect(page).toHaveURL(canonical);
await expect(page.getByRole("dialog")).toHaveCount(0);
@@ -4111,10 +4089,10 @@ test("reload max-fits the comparison overview with the Inspector collapsed", asy
await page.setViewportSize({ width: 1600, height: 900 });
await page.goto("/map");
await expect(page.locator(".react-flow__node-screen")).toHaveCount(SCREEN_COUNT);
await expect(page.locator(".right-panel")).toHaveCount(0);
await expect(page.getByRole("button", { name: "Expand inspector" })).toBeVisible();
await page.reload();
await expect(page.locator(".react-flow__node-screen")).toHaveCount(SCREEN_COUNT);
await expect(page.locator(".right-panel")).toHaveCount(0);
await expect(page.getByRole("button", { name: "Expand inspector" })).toBeVisible();
const viewport = page.locator(".map-canvas .react-flow__viewport");
await expect(viewport).toBeVisible();
@@ -4439,93 +4417,6 @@ test("pull-request comment deep links open the Changes filter and a surface's Di
expect(new URL(page.url()).searchParams.get("workspace")).toBe(workspaceUrl);
});
/**
* Records, every frame, the route Compare names and the screenshots it shows: those at any opacity above nothing,
* not on a hidden Flip side. An image still loading counts as the source it had before, which the browser keeps
* painting until the new one is there. `staleCompareFrames` then checks each frame showed only its own screen's.
*/
async function sampleCompareFrames(page: Page, root: string) {
await page.evaluate((root) => {
const record = window as unknown as { compareFrames: { route: string; shown: string[] }[]; sampling: boolean };
record.compareFrames = [];
record.sampling = true;
const sample = () => {
const scope = document.querySelector(root);
const route = scope?.querySelector(".compare-nav-route")?.textContent ?? "";
const shown = [...(scope?.querySelectorAll<HTMLImageElement>(".compare-stage img") ?? [])]
.filter((image) => Number(getComputedStyle(image).opacity) > 0 && getComputedStyle(image).visibility !== "hidden")
.map((image) => image.complete && image.naturalWidth > 0 ? image.getAttribute("src") ?? "" : "(still loading)");
record.compareFrames.push({ route, shown });
if (record.sampling) requestAnimationFrame(sample);
};
requestAnimationFrame(sample);
}, root);
}
/** Every screenshot the stage holds for the route on show, once its pictures have loaded. */
async function settledCompareScreen(page: Page, root: string) {
const stage = page.locator(`${root} .compare-stage`);
await expect(stage.locator("img[data-screenshot-state='loading']")).toHaveCount(0);
return stage.evaluate((element, root) => ({
route: document.querySelector(root)?.querySelector(".compare-nav-route")?.textContent ?? "",
sources: [...element.querySelectorAll("img")].map((image) => image.getAttribute("src") ?? ""),
}), root);
}
/** The sampled frames in which a picture showed under a route it does not belong to. */
async function staleCompareFrames(page: Page, screens: { route: string; sources: string[] }[]) {
const frames = await page.evaluate(() => {
const record = window as unknown as { compareFrames: { route: string; shown: string[] }[]; sampling: boolean };
record.sampling = false;
return record.compareFrames;
});
const sources = new Map<string, Set<string>>();
for (const screen of screens) sources.set(screen.route, new Set([...(sources.get(screen.route) ?? []), ...screen.sources]));
expect(new Set(frames.map((frame) => frame.route)).size, "The steps were sampled").toBeGreaterThan(1);
return frames.filter((frame) => frame.shown.some((source) => !sources.get(frame.route)?.has(source)));
}
test("a screenshot whose URL cannot be loaded shows No screenshot in its frame on the Map and in the Inspector", async ({ page }) => {
await page.route((url) => url.pathname === "/api/artifacts/artifacts/area-0-screen-1-0.svg", (route) => route.fulfill({ status: 404, body: "" }));
await page.goto("/map");
const card = (title: string) => page.locator(".map-canvas .react-flow__node").filter({ hasText: title }).locator(".screen-node-image");
const missing = card("/onboarding-step-2").locator(".image-placeholder");
await expect(missing).toContainText("No screenshot");
await expect(card("/onboarding-step-2").locator("img")).toHaveCount(0);
// The placeholder takes the frame the screenshot would have had, like the screenshot beside it.
const neighbour = card("/onboarding-step-1").locator("img");
await expect(neighbour).toHaveAttribute("data-screenshot-state", "ready");
const size = (locator: Locator) => locator.evaluate((element) => [element.offsetWidth, element.offsetHeight]);
expect(await size(missing)).toEqual(await size(neighbour));
await expect(card("/onboarding-step-2").locator(".screenshot-backing")).toHaveCSS("visibility", "hidden");
await page.locator(".map-canvas .react-flow__node").filter({ hasText: "/onboarding-step-2" }).locator(".screen-screenshot-target").click();
await expect(page.locator(".right-panel .inspector-preview .screenshot-placeholder")).toContainText("No screenshot");
});
test("stepping Compare by key or by its buttons never shows the screen before's pictures under the next one's name", async ({ page }) => {
await page.setViewportSize({ width: 1440, height: 860 });
await serveWorkspace(page);
await page.goto("/compare?screen=current-profile");
const root = ".compare-section";
const bar = page.locator(`${root} .compare-bar`);
await expect(bar).toBeVisible();
for (const mode of ["1", "2", "3"]) {
await page.keyboard.press(mode);
const screens = [await settledCompareScreen(page, root)];
await sampleCompareFrames(page, root);
await page.keyboard.press("ArrowRight");
screens.push(await settledCompareScreen(page, root));
await bar.getByRole("button", { name: "Previous changed screen" }).click();
screens.push(await settledCompareScreen(page, root));
await bar.getByRole("button", { name: "Next changed screen" }).click();
screens.push(await settledCompareScreen(page, root));
await page.keyboard.press("ArrowLeft");
screens.push(await settledCompareScreen(page, root));
expect(await staleCompareFrames(page, screens), `Mode ${mode}`).toEqual([]);
}
});
test("desktop Compare: one command bar with the modes in it, even gaps to both bars", async ({ page }) => {
await page.setViewportSize({ width: 1440, height: 860 });
await serveWorkspace(page);
@@ -4795,10 +4686,10 @@ test.describe("phone layout", () => {
await page.goto("/map");
const tabs = page.getByRole("navigation", { name: "Views" });
await expect(tabs).toBeVisible();
// Desktop chrome is gone: the floating toolbar with its More menu, the camera controls and the
// minimap.
// Desktop chrome is gone: the floating toolbar with its shortcuts button, the camera controls
// and the minimap.
await expect(page.getByRole("toolbar", { name: "Canvas tools" })).toHaveCount(0);
await expect(page.getByRole("button", { name: "More", exact: true })).toHaveCount(0);
await expect(page.getByRole("button", { name: "Keyboard shortcuts" })).toHaveCount(0);
await expect(page.locator(".canvas-camera-controls")).toHaveCount(0);
await expect(tabs.getByRole("button", { name: /Compare/ })).toBeEnabled();
@@ -5000,24 +4891,6 @@ test.describe("phone layout", () => {
}
});
test("stepping Compare from the header never shows the screen before's pictures under the next one's name", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/map");
await page.getByRole("navigation", { name: "Views" }).getByRole("button", { name: /Compare/ }).tap();
const root = ".phone-compare";
const compare = page.locator(root);
await expect(compare).toBeVisible();
const next = compare.getByRole("button", { name: "Next changed screen" });
const previous = compare.getByRole("button", { name: "Previous changed screen" });
const screens = [await settledCompareScreen(page, root)];
await sampleCompareFrames(page, root);
for (const step of [next, next, previous]) {
await step.tap();
screens.push(await settledCompareScreen(page, root));
}
expect(await staleCompareFrames(page, screens)).toEqual([]);
});
test("Compare is full screen, opens in Flip and steps from the header", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/map");
@@ -5331,312 +5204,40 @@ test.describe("phone layout", () => {
});
});
test("the theme is Auto until the More menu picks one: it follows the system, and a pick outlives a reload", async ({ page }) => {
test("the theme is Auto until the toggle picks one: it follows the system, then steps Dark → Light → Auto and keeps the pick", async ({ page }) => {
await page.emulateMedia({ colorScheme: "dark" });
await page.goto("/map");
const html = page.locator("html");
const more = page.getByRole("button", { name: "More", exact: true });
const menu = page.getByRole("menu", { name: "More" });
const theme = (name: "Auto" | "Light" | "Dark") => menu.getByRole("menuitemradio", { name, exact: true });
const button = page.getByRole("button", { name: "Toggle theme" });
await expect(html).toHaveAttribute("data-theme", "dark");
await more.click();
await expect(theme("Auto")).toHaveAttribute("aria-checked", "true");
await expect(button).toHaveAttribute("data-theme-preference", "system");
await button.hover();
await expect(page.locator(".tooltip-content")).toContainText("Theme: Auto (system)");
// Auto tracks the system while it is in force.
await page.emulateMedia({ colorScheme: "light" });
await expect(html).toHaveAttribute("data-theme", "light");
// A pick applies at once and keeps the menu open, so the switch shows it.
await theme("Dark").click();
await button.click();
await expect(html).toHaveAttribute("data-theme", "dark");
await expect(theme("Dark")).toHaveAttribute("aria-checked", "true");
await expect(theme("Auto")).toHaveAttribute("aria-checked", "false");
await theme("Light").click();
await expect(button).toHaveAttribute("data-theme-preference", "dark");
await expect(page.locator(".tooltip-content")).toContainText("Theme: Dark");
await button.click();
await expect(html).toHaveAttribute("data-theme", "light");
await theme("Auto").click();
await expect(theme("Auto")).toHaveAttribute("aria-checked", "true");
await expect(button).toHaveAttribute("data-theme-preference", "light");
await button.click();
await expect(button).toHaveAttribute("data-theme-preference", "system");
await expect(html).toHaveAttribute("data-theme", "light");
await page.emulateMedia({ colorScheme: "dark" });
await expect(html).toHaveAttribute("data-theme", "dark");
// A picked theme outlives a reload and ignores the system.
await theme("Light").click();
await page.keyboard.press("Escape");
await button.click();
await expect(button).toHaveAttribute("data-theme-preference", "dark");
await button.click();
await expect(button).toHaveAttribute("data-theme-preference", "light");
await page.reload();
await expect(html).toHaveAttribute("data-theme", "light");
await page.getByRole("button", { name: "More", exact: true }).click();
await expect(theme("Light")).toHaveAttribute("aria-checked", "true");
});
/** Stands in for the browser's full screen, which headless Chromium cannot enter, and records the calls. */
async function stubFullscreen(page: Page) {
await page.addInitScript(() => {
const host = window as typeof window & { __fullscreenCalls: string[] };
host.__fullscreenCalls = [];
let element: Element | null = null;
Object.defineProperty(Document.prototype, "fullscreenElement", { configurable: true, get: () => element });
Element.prototype.requestFullscreen = function requestFullscreen() {
host.__fullscreenCalls.push("enter");
element = document.documentElement;
document.dispatchEvent(new Event("fullscreenchange"));
return Promise.resolve();
};
Document.prototype.exitFullscreen = function exitFullscreen() {
host.__fullscreenCalls.push("exit");
element = null;
document.dispatchEvent(new Event("fullscreenchange"));
return Promise.resolve();
};
});
}
function fullscreenCalls(page: Page) {
return page.evaluate(() => (window as typeof window & { __fullscreenCalls: string[] }).__fullscreenCalls);
}
/** The visible buttons in the window's top-right corner, where the camera controls sit on the Map. */
async function topRightButtons(page: Page) {
return page.evaluate(() => [...document.querySelectorAll<HTMLElement>("button, [role='button']")]
.filter((element) => {
const box = element.getBoundingClientRect();
if (box.width === 0 || box.height === 0 || getComputedStyle(element).visibility === "hidden") return false;
return box.bottom <= 80 && box.right >= window.innerWidth - 240;
})
.map((element) => element.getAttribute("aria-label") ?? element.textContent?.trim() ?? ""));
}
test("the bottom bar's More menu holds the theme, full screen and keyboard shortcuts, each with its key", async ({ page }) => {
await stubFullscreen(page);
await page.emulateMedia({ colorScheme: "light" });
await page.goto("/map");
const toolbar = page.getByRole("toolbar", { name: "Canvas tools" });
const more = toolbar.getByRole("button", { name: "More", exact: true });
// The keyboard button became More; it is the bar's last button.
await expect(toolbar.getByRole("button", { name: "Keyboard shortcuts" })).toHaveCount(0);
await expect(toolbar.getByRole("button").last()).toHaveAccessibleName("More");
await expect(more).toHaveAttribute("aria-haspopup", "menu");
await expect(more).toHaveAttribute("aria-expanded", "false");
await more.click();
const menu = page.getByRole("menu", { name: "More" });
await expect(menu).toBeVisible();
await expect(more).toHaveAttribute("aria-expanded", "true");
// It opens above the bar, anchored to the button.
const [menuBox, moreBox, toolbarBox] = await Promise.all([menu.boundingBox(), more.boundingBox(), toolbar.boundingBox()]);
expect(menuBox!.y + menuBox!.height).toBeLessThan(toolbarBox!.y);
expect(Math.abs(menuBox!.x + menuBox!.width - (moreBox!.x + moreBox!.width))).toBeLessThanOrEqual(2);
// Rows: Theme (a group of three radio items), Full screen, Keyboard shortcuts, in sentence case.
const themes = menu.getByRole("group", { name: "Theme" });
expect(await themes.getByRole("menuitemradio").evaluateAll((items) => items.map((item) => item.getAttribute("aria-label"))))
.toEqual(["Auto", "Light", "Dark"]);
await expect(menu.getByRole("menuitem")).toHaveCount(2);
await expect(menu.getByRole("menuitem").nth(0)).toHaveAccessibleName("Full screen");
await expect(menu.getByRole("menuitem").nth(1)).toHaveAccessibleName("Keyboard shortcuts");
await expect(menu.getByRole("menuitemcheckbox")).toHaveAccessibleName("Inspector");
await expect(menu.locator(".more-menu-label")).toHaveText(["Theme", "Full screen", "Inspector", "Keyboard shortcuts"]);
await expect(menu.locator("kbd")).toHaveText(["T", "F", "I", "?"]);
for (const label of await menu.locator(".more-menu-label").all()) {
await expect(label).toHaveCSS("text-transform", "none");
}
// It opens on the current theme; the arrows walk the rows and the switch, Esc closes it and
// returns focus to More.
await expect(themes.getByRole("menuitemradio", { name: "Auto" })).toBeFocused();
await expect(themes.getByRole("menuitemradio", { name: "Auto" })).toHaveAttribute("aria-checked", "true");
await page.keyboard.press("ArrowRight");
await expect(themes.getByRole("menuitemradio", { name: "Light" })).toBeFocused();
await page.keyboard.press("ArrowDown");
await expect(menu.getByRole("menuitem", { name: "Full screen" })).toBeFocused();
await page.keyboard.press("ArrowDown");
await expect(menu.getByRole("menuitemcheckbox", { name: "Inspector" })).toBeFocused();
await page.keyboard.press("ArrowDown");
await expect(menu.getByRole("menuitem", { name: "Keyboard shortcuts" })).toBeFocused();
await page.keyboard.press("ArrowDown");
await expect(themes.getByRole("menuitemradio", { name: "Auto" })).toBeFocused();
await page.keyboard.press("Escape");
await expect(menu).toHaveCount(0);
await expect(more).toBeFocused();
await expect(more).toHaveAttribute("aria-expanded", "false");
// The switch sets the theme and keeps the menu open; T still flips it, and the switch follows.
await more.click();
await themes.getByRole("menuitemradio", { name: "Dark" }).click();
await expect(page.locator("html")).toHaveAttribute("data-theme", "dark");
await expect(themes.getByRole("menuitemradio", { name: "Dark" })).toHaveAttribute("aria-checked", "true");
await expect(menu).toBeVisible();
await page.keyboard.press("t");
await expect(page.locator("html")).toHaveAttribute("data-theme", "light");
await expect(themes.getByRole("menuitemradio", { name: "Light" })).toHaveAttribute("aria-checked", "true");
// Full screen: the row enters it and closes the menu; the row then offers the way out.
await menu.getByRole("menuitem", { name: "Full screen" }).click();
await expect(menu).toHaveCount(0);
expect(await fullscreenCalls(page)).toEqual(["enter"]);
await more.click();
await expect(menu.getByRole("menuitem", { name: "Exit full screen" })).toBeVisible();
await page.keyboard.press("Escape");
// F is the same toggle from the keyboard.
await page.keyboard.press("f");
expect(await fullscreenCalls(page)).toEqual(["enter", "exit"]);
await page.keyboard.press("f");
expect(await fullscreenCalls(page)).toEqual(["enter", "exit", "enter"]);
await more.click();
await expect(menu.getByRole("menuitem", { name: "Exit full screen" })).toBeVisible();
await page.keyboard.press("Escape");
await page.keyboard.press("f");
// Keyboard shortcuts opens the reference, which lists F.
await more.click();
await menu.getByRole("menuitem", { name: "Keyboard shortcuts" }).click();
await expect(menu).toHaveCount(0);
const dialog = page.getByRole("dialog", { name: "Keyboard shortcuts" });
await expect(dialog).toBeVisible();
await expect(dialog.locator(".shortcuts-row", { hasText: "Enter or exit full screen" }).locator("kbd")).toHaveText("F");
await page.keyboard.press("Escape");
await expect(dialog).toHaveCount(0);
// ? still opens it too.
await page.keyboard.press("?");
await expect(dialog).toBeVisible();
});
for (const [setup, withoutFullscreen] of [
// iPhone Safari has no element full screen.
["no element full screen", async (page: Page) => page.addInitScript(() => {
delete (Element.prototype as Partial<Element>).requestFullscreen;
})],
// A frame not allowed full screen (an embedded Viewer) has the method, but every request fails.
["a frame without full screen", async (page: Page) => {
await stubFullscreen(page);
await page.addInitScript(() => {
Object.defineProperty(Document.prototype, "fullscreenEnabled", { configurable: true, get: () => false });
});
}],
] as const) {
test(`without the browser's full screen (${setup}), the More menu, F and the shortcuts leave it out`, async ({ page }) => {
await withoutFullscreen(page);
await page.goto("/map");
await page.getByRole("button", { name: "More", exact: true }).click();
const menu = page.getByRole("menu", { name: "More" });
await expect(menu.getByRole("menuitem")).toHaveCount(1);
await expect(menu.getByRole("menuitem", { name: /full screen/i })).toHaveCount(0);
await expect(menu.locator("kbd")).toHaveText(["T", "I", "?"]);
await page.keyboard.press("Escape");
await page.keyboard.press("f");
expect(await page.evaluate(() => (window as typeof window & { __fullscreenCalls?: string[] }).__fullscreenCalls ?? [])).toEqual([]);
await page.keyboard.press("?");
await expect(page.getByRole("dialog", { name: "Keyboard shortcuts" })).not.toContainText("full screen");
});
}
test("the More menu's keys are its own: on Compare, ← → step no screen behind it, and ? hands focus back to More", async ({ page }) => {
await page.setViewportSize({ width: 1440, height: 860 });
await serveWorkspace(page);
await page.goto("/compare?screen=current-profile");
const compare = page.locator(".compare-section");
const route = compare.locator(".compare-bar .compare-nav-route");
await expect(route).toHaveText("/current-profile");
const more = page.getByRole("button", { name: "More", exact: true });
const menu = page.getByRole("menu", { name: "More" });
// Compare has no Inspector, so the menu leaves its row out.
await more.click();
await expect(menu.getByRole("menuitemcheckbox", { name: "Inspector" })).toHaveCount(0);
// ← and → on a row that is not the theme switch do nothing, and step no screen behind the menu.
await page.keyboard.press("ArrowDown");
await expect(menu.getByRole("menuitem").first()).toBeFocused();
await page.keyboard.press("ArrowRight");
await page.keyboard.press("ArrowLeft");
await page.keyboard.press("ArrowRight");
await expect(menu).toBeVisible();
await expect(route).toHaveText("/current-profile");
await expect(page).toHaveURL(/screen=current-profile/);
await page.keyboard.press("Escape");
await expect(menu).toHaveCount(0);
// ? opens the shortcuts as the row does; closing them returns focus to More.
await more.click();
await page.keyboard.press("?");
const dialog = page.getByRole("dialog", { name: "Keyboard shortcuts" });
await expect(dialog).toBeVisible();
await expect(menu).toHaveCount(0);
await page.keyboard.press("Escape");
await expect(dialog).toHaveCount(0);
await expect(more).toBeFocused();
});
test("with nothing selected, the More menu's Inspector row opens the Inspector, and the open menu follows the bar it moves", async ({ page }) => {
await page.setViewportSize({ width: 1000, height: 820 });
await page.goto("/map");
const more = page.getByRole("button", { name: "More", exact: true });
const menu = page.getByRole("menu", { name: "More" });
const inspector = page.locator(".right-panel");
await expect(inspector).toHaveCount(0);
await more.click();
const row = menu.getByRole("menuitemcheckbox", { name: "Inspector" });
await expect(row).toHaveAttribute("aria-checked", "false");
await expect(row).toHaveAttribute("aria-keyshortcuts", "I");
await row.click();
await expect(menu).toHaveCount(0);
await expect(inspector).toBeVisible();
await more.click();
await expect(row).toHaveAttribute("aria-checked", "true");
await row.click();
await expect(inspector).toHaveCount(0);
// I opens the Inspector with the menu up; the bar moves left out of its way, and the menu with it.
await more.click();
await expect(menu).toBeVisible();
const before = (await more.boundingBox())!;
await page.keyboard.press("i");
await expect(inspector).toBeVisible();
await expect.poll(async () => (await more.boundingBox())!.x).toBeLessThan(before.x - 1);
await expect(menu).toBeVisible();
await expect.poll(async () => {
const [menuBox, moreBox] = await Promise.all([menu.boundingBox(), more.boundingBox()]);
return Math.abs(menuBox!.x + menuBox!.width - (moreBox!.x + moreBox!.width));
}).toBeLessThanOrEqual(2);
});
test("in a window too short for it, the More menu scrolls", async ({ page }) => {
await page.setViewportSize({ width: 1180, height: 150 });
await page.goto("/map");
await page.getByRole("button", { name: "More", exact: true }).click();
const popover = page.locator(".menu-popover.more-menu");
await expect(popover).toBeVisible();
expect(await popover.evaluate((element) => element.scrollHeight > element.clientHeight)).toBe(true);
const box = (await popover.boundingBox())!;
expect(box.y + box.height).toBeLessThanOrEqual(150);
await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2);
await page.mouse.wheel(0, 200);
await expect.poll(() => popover.evaluate((element) => element.scrollTop)).toBeGreaterThan(0);
await expect(page.getByRole("menu", { name: "More" }).getByRole("menuitem", { name: "Keyboard shortcuts" })).toBeInViewport({ ratio: 1 });
});
test("the top right is the camera's alone: fit, center and zoom on the Map, nothing on Screens or Compare", async ({ page }) => {
await page.setViewportSize({ width: 1440, height: 900 });
await serveWorkspace(page);
await page.goto("/map");
const camera = page.getByRole("group", { name: "Canvas camera controls" });
await expect(camera).toBeVisible();
expect(await topRightButtons(page)).toEqual(["Fit canvas", "Center canvas", expect.stringMatching(/^Zoom — \d+%$/)]);
// With the Inspector open the camera keeps to the canvas beside it; the Inspector's header has
// only its own actions.
await openInspector(page);
await expect(camera.getByRole("button")).toHaveCount(3);
await page.getByRole("button", { name: "Close inspector" }).click();
await expect(page.locator(".right-panel")).toHaveCount(0);
await chooseCanvasView(page, "Screens");
await expect(page).toHaveURL(/\/screens/);
await expect(page.locator(".screens-page .screens-cell").first()).toBeVisible();
await expect(page.locator(".canvas-camera-controls")).toHaveCount(0);
expect(await topRightButtons(page)).toEqual([]);
await page.goto("/compare?screen=current-profile");
await expect(page.getByRole("region", { name: /^Compare / })).toBeVisible();
await expect(page.locator(".canvas-camera-controls")).toHaveCount(0);
expect(await topRightButtons(page)).toEqual([]);
await expect(page.getByRole("button", { name: "Toggle theme" })).toHaveAttribute("data-theme-preference", "light");
});
test("/ finds screens on the Screens page: the tree and the grid narrow to the query, Enter picks the first match, Esc clears then closes", async ({ page }) => {
+2 -45
View File
@@ -293,7 +293,7 @@ test("action rejects unsupported Node versions before installing tools", async t
test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it runs only for a requested hosted preview", () => {
const deploy = review.jobs.deploy;
assert.deepEqual(deploy.needs, ["targets", "capture", "report"]);
assert.equal(deploy.if, "needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()");
assert.equal(deploy.if, "needs.capture.outputs.preview == 'eas'");
assert.deepEqual(deploy.permissions, { contents: "read", actions: "read", "pull-requests": "write" });
const step = deploy.steps.find(step => step.name === "Deploy the hosted preview and publish its Explore report links");
assert.equal(step.env.EXPO_TOKEN, "${{ secrets.EXPO_TOKEN }}");
@@ -305,8 +305,7 @@ test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it
assert.deepEqual(downloads.map(step => step.with.pattern), ["explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*", "explore-review-${{ github.run_id }}-${{ github.run_attempt }}-*"]);
assert.ok(downloads.every(step => step.with.name === undefined && step.with["merge-multiple"] === undefined));
assert.doesNotMatch(JSON.stringify(deploy), /OPENAI_API_KEY|ANTHROPIC_API_KEY/);
// A report job hands forward only whether it published; its artifact URL is looked up again (matrix outputs keep one leg's value).
assert.deepEqual(review.jobs.report.outputs, { published: "${{ steps.publish.outputs.published }}" });
assert.equal(review.jobs.report.outputs, undefined);
// capture:review writes preview=<hosting> to the step outputs from the reviewed config.
assert.equal(review.jobs.capture.outputs.preview, "${{ steps.capture.outputs.preview }}");
assert.match(review.jobs.capture.steps.find(step => step.id === "capture").run, /capture:review/);
@@ -315,48 +314,6 @@ test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it
assert.match(review.jobs.failure.if, /needs\.deploy\.result == 'failure'/);
});
test("one target's failed capture keeps neither the other targets' reports nor the preview off the PR (brentvatne/euxy#172)", async t => {
for (const workflow of [review, compare]) {
const report = workflow.jobs.report;
// A plain needs: [capture] skips every report once one capture leg fails; !cancelled() runs them, except in a cancelled run.
assert.equal(report.if, "needs.targets.result == 'success' && !cancelled()");
assert.deepEqual(report.needs, ["targets", "capture"]);
const [download, check] = report.steps;
assert.ok(download.uses.startsWith("actions/download-artifact@"));
// A pattern without a wildcard names this leg's artifact alone, and matching nothing is not a failure, as a name is.
assert.deepEqual(download.with, { pattern: "explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}", path: "${{ runner.temp }}/explore-review" });
assert.equal(download["continue-on-error"], undefined, "a download that went wrong still fails the leg");
assert.equal(check.id, "captured");
const explore = report.steps.filter(step => /cli\.js" ci:(report|publish)/.test(step.run ?? "") || step.uses?.startsWith("actions/upload-artifact@") && step.if !== "always()");
assert.equal(explore.length, 3);
for (const step of explore) assert.equal(step.if, "steps.captured.outputs.found == 'true'", step.name);
const publish = report.steps.find(step => step.id === "publish");
assert.match(publish.run, /ci:publish[^\n]*\n\s*echo "published=true" >> "\$GITHUB_OUTPUT"/, "published only once ci:publish succeeded");
assert.deepEqual(report.outputs, { published: "${{ steps.publish.outputs.published }}" });
assert.equal(workflow.jobs.deploy.if, "needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()");
assert.deepEqual(workflow.jobs.deploy.needs, ["targets", "capture", "report"]);
// The check reads what the download left: this target's report input, or nothing.
const root = await mkdtemp(join(tmpdir(), "explore-report-check-"));
t.after(() => rm(root, { recursive: true, force: true }));
const runCheck = async () => {
const output = join(root, "output"); await writeFile(output, "");
const result = spawnSync("bash", ["-c", check.run], { encoding: "utf8", env: { ...process.env, RUNNER_TEMP: root, GITHUB_OUTPUT: output, TARGET: "duo-open" } });
assert.equal(result.status, 0, result.stderr);
return { output: await readFile(output, "utf8"), stdout: result.stdout };
};
const failed = await runCheck();
assert.equal(failed.output, "");
assert.match(failed.stdout, /The duo-open capture uploaded no review: its capture job failed/);
await mkdir(join(root, "explore-review"), { recursive: true });
await writeFile(join(root, "explore-review", "report-input.json"), "{}");
assert.equal((await runCheck()).output, "found=true\n");
}
// The failure job still runs when a capture leg failed, and names that target from its diagnostics.
const failure = review.jobs.failure;
assert.match(failure.if, /^always\(\) && \(.*needs\.capture\.result == 'failure'.*needs\.report\.result == 'failure'/);
for (const step of failure.steps.filter(step => step.uses?.startsWith("actions/download-artifact@"))) assert.equal(step["continue-on-error"], true, step.name);
});
test("closing a pull request runs nothing: hosted previews stay until a developer deletes them", () => {
assert.ok(!review.on.pull_request_target.types.includes("closed"));
assert.doesNotMatch(review.jobs.targets.if, /closed/);
-38
View File
@@ -201,8 +201,6 @@ test("Android fill uses Argent's fill and requires it to verify the text", async
const snapshot = await run(["snapshot", ...flags("android")]);
const node = snapshot.json.data.nodes.find(item => item.type === "TextField");
assert.ok(node, "the rename fixture has an EditText");
assert.equal(node.focused, true, "the focused field is marked, as agent-device marks it");
assert.equal(snapshot.json.data.keyboardVisible, false, "whether a keyboard shows, which the Android tree cannot say, is passed on");
assert.equal((await run(["fill", node.ref, ...flags("android"), "--", "Groove"])).exitCode, 0);
assert.deepEqual(calls.find(call => call.tool === "fill").args, { udid: "emulator-5554", text: "Groove" });
const unverified = await run(["fill", node.ref, ...flags("android"), "--", "Groove"]);
@@ -441,42 +439,6 @@ test("a reader stuck on the dark panel after a fold is reset once more before th
assert.equal(stuck.calls.filter(call => call.tool === "stop-all-simulator-servers").length, 2, "before the fold and once after, not in a loop");
});
// brentvatne/euxy#172, review run 39348956443: the fold after capture restarted SpringBoard failed with this, before it ran.
const DEPENDENCY_FAILED = "argent run fold failed: [Tool:fold] Service dependency failed: [SimulatorServer:74195B53-4DBC-4EAA-9991-F98E5BB86BA8] Timed out waiting for simulator-server to become ready";
test("a fold whose simulator-server did not start is sent again after a pause, and then folds", async () => {
const lit = { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 };
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": DUO_OPEN_EDIT_LANE, "stop-all-simulator-servers": { stopped: [] },
fold: [new ArgentCallError(DEPENDENCY_FAILED, true), lit] });
const pauses = [];
context.sleep = async milliseconds => { pauses.push(milliseconds); };
assert.deepEqual((await run(["fold", "open", ...flags("ios")])).json.data, { action: "fold", pose: "open" });
assert.equal(calls.filter(call => call.tool === "fold").length, 2);
assert.deepEqual(pauses, [3_000], "one pause before the fold is sent again");
});
test("a fold whose simulator-server never starts fails as it did before, after two more tries", async () => {
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": DUO_OPEN_EDIT_LANE, "stop-all-simulator-servers": { stopped: [] },
fold: new ArgentCallError(DEPENDENCY_FAILED, true) });
const pauses = [];
context.sleep = async milliseconds => { pauses.push(milliseconds); };
const failed = await run(["fold", "open", ...flags("ios")]);
assert.deepEqual(failed.json.error, { code: "ARGENT_TOOL_FAILED", message: DEPENDENCY_FAILED });
assert.equal(calls.filter(call => call.tool === "fold").length, 3);
assert.deepEqual(pauses, [3_000, 6_000]);
});
test("a UI action that failed for another reason is still sent once, even when its message mentions a dependency", async () => {
// Only the tool's own wrap counts: a nested tool's dependency failure is not this tool failing to start.
for (const message of ["argent run gesture-tap failed: [Tool:gesture-tap] simulator-server answered 500",
"argent run gesture-tap failed: [Tool:gesture-tap] [Tool:keyboard] Service dependency failed: [SimulatorServer:x] Timed out"]) {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-tap": new ArgentCallError(message, true) });
const pressed = await run(["press", "10", "10", ...flags("ios")]);
assert.deepEqual(pressed.json.error, { code: "ARGENT_TOOL_FAILED", message });
assert.equal(calls.filter(call => call.tool === "gesture-tap").length, 1, message);
}
});
test("an alert that is not the link prompt is left for capture to answer", async () => {
const other = { ...IOS_HOME, alertVisible: true, foregroundApp: "com.apple.springboard",
roots: [{ type: "Alert", label: "Delete all data?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [
-16
View File
@@ -173,22 +173,6 @@ test("CI argument failures preserve JSON output, annotation, summary, and diagno
assert.match(await readFile(summary, "utf8"), /Next action/);
});
test("a failed command's diagnostics file names the matrix target it ran for, so the failure comment can", async (t) => {
const root = await mkdtemp(join(tmpdir(), "explore-cli-target-"));
t.after(() => rm(root, { recursive: true, force: true }));
const cli = new URL("../../src/cli.ts", import.meta.url);
const run = target => {
const result = spawnSync(process.execPath, ["--import", "tsx", cli.pathname, "ci:report", "--input", join(root, "missing.json"), "--output", join(root, "out"), "--target", target],
{ encoding: "utf8", env: { ...process.env, GITHUB_ACTIONS: "true", RUNNER_TEMP: root } });
assert.equal(result.status, 1, result.stderr);
return readFile(join(root, "explore-diagnostics/error.json"), "utf8").then(JSON.parse);
};
const written = await run("duo-closed");
assert.equal(written.target, "duo-closed");
assert.equal(written.code, "REPORT_INPUT_INVALID");
assert.equal((await run("../ios")).target, undefined, "only a valid target id is written");
});
test("source worker failures emit a structured diagnostic without a raw stack", () => {
const worker = new URL("../../src/source/plan-worker.ts", import.meta.url);
const result = spawnSync(process.execPath, ["--import", "tsx", worker.pathname], { input: "{", encoding: "utf8" });
-56
View File
@@ -69,18 +69,6 @@ const unreadableSurface = () => json({ success: false, error: { code: 'COMMAND_F
details: { hint: 'com.apple.SafariViewService hosts the surface presented over the app, and this capture targeted that surface. No snapshot backend could read this screen (XCTest-backed snapshot tiers were deferred after recent slow accessibility work on this screen).' } } });
/**
* The iOS 26 keyboard as agent-device reports it: the Keyboard element with its keys beneath it, and the dock's Emoji and
* Dictate buttons, which its host bridge names by their view class (brentvatne/euxy#172, review run 39362642343).
*/
const softKeyboard = [
{ index: 900, type: 'Application', rect: { x: 0, y: 0, width: 402, height: 874 }, visible: true },
{ index: 902, parentIndex: 900, type: 'Keyboard', rect: { x: 0, y: 583, width: 402, height: 233 }, visible: true },
{ index: 903, parentIndex: 902, type: 'Key', label: 'Q', rect: { x: 5, y: 590, width: 39, height: 54 }, visible: true },
{ index: 905, parentIndex: 900, type: 'Button', role: 'UIKeyboardDockItemButton', label: 'Emoji', rect: { x: 8, y: 806, width: 68, height: 68 }, visible: true },
{ index: 906, parentIndex: 900, type: 'Button', role: 'UIKeyboardDockItemButton', label: 'Dictate', identifier: 'dictation', rect: { x: 325, y: 806, width: 68, height: 68 }, visible: true },
];
function agentFixture(actions, observedRequests = []) {
return { instructions: 'Capture each selected route in its normal loaded state.', contexts: {},
provider: { provider: 'anthropic', model: 'test-model', preflight: async () => {}, run: async request => {
@@ -129,8 +117,6 @@ async function fixture(t, settings = {}) {
let enteredName = false; let scrolledToContinue = false; let finishHidden = false; let wedgeCleared = false; let deviceLost = false; let relaunchedAfterForeign = false; let serverStarts = 0; let unreadableLeft = settings.unreadableAfterFold ?? 0;
// startsErrored / startsUnnamed: how many session starts EAS fails, after naming the session (it ERRORS) or before.
let starts = 0; let currentSession = 'session-1'; const erroredSessions = new Set(); let foldUnverifiedLeft = settings.foldUnverified ?? 0;
// focusedField: the screen at `path` focuses its text field, and the keyboard is up from the `keyboardFrom`th read of it.
let focusedReads = 0;
// blackAfterFold: the first so many folds of an EAS agent-device session light the panel but draw nothing.
let folds = 0;
const deviceName = settings.android ? 'Pixel 7' : 'iPhone 17 Pro';
@@ -383,8 +369,6 @@ async function fixture(t, settings = {}) {
] : []),
...(settings.statefulSetup && current === '/transient' ? [{ type: 'Button', label: 'Finish', ref: 'e103', enabled: true, visible: !finishHidden }] : []),
...(alert ? [{ type: 'Alert', label: alert.message }, ...alert.items.map((label, index) => ({ type: 'Button', label, ref: `e${index + 1}`, enabled: true, visible: true }))] : []),
...(settings.focusedField?.path === current ? [{ type: 'TextField', label: 'Pattern name', focused: true, visible: true, rect: { x: 23, y: 386, width: 355, height: 50 } },
...(++focusedReads >= (settings.focusedField.keyboardFrom ?? Infinity) ? softKeyboard : [])] : []),
...(settings.missingObserver || settings.missingObserverAt === current ? [] : [observer]),
// A second active destination is ambiguous; the host AX bridge's identical copy is not.
...(settings.duplicateObserver ? [{ ...observer, label: JSON.stringify({ provider: 'expo-router', pathname: '/other', segments: ['other'], parameters: {} }) }] : []),
@@ -1197,46 +1181,6 @@ test('every app link settles before the screen is read', async t => {
assert.ok(opened >= 0 && settled > opened && settled < read, 'the settle runs between the link and the first read');
});
const keyboardLog = async f => (await readFile(join(f.options.mapDirectory, 'capture-diagnostics', 'keyboard.jsonl'), 'utf8'))
.trim().split('\n').map(line => JSON.parse(line));
test('a screen whose text field has the focus is captured once its keyboard is up and still, and the keyboard is not one of its elements', async t => {
// euxy#172 (review run 39362642343): the rename sheet focuses its field, and the keyboard rises after the sheet settles.
const f = await fixture(t, { routes: [route('rename')], focusedField: { path: '/rename', keyboardFrom: 2 } });
const result = await runCiMap(f.options);
assert.equal(result.outcomes[f.ids.rename].status, 'captured');
assert.equal(result.outcomes[f.ids.rename].attempts, 1);
assert.deepEqual((await keyboardLog(f)).map(line => [line.route, line.outcome, line.reads]), [[f.ids.rename, 'shown', 2]],
'read until the keyboard was up in the same place twice');
const calls = f.requests.filter(request => request.command === 'fake-controller').map(request => request.args[0]);
const shot = calls.lastIndexOf('screenshot');
assert.deepEqual(calls.slice(shot - 3, shot), ['snapshot', 'snapshot', 'snapshot'], 'the destination read, then the keyboard reads, then the screenshot');
const map = await readExportedMap(f.options.outputDirectory);
const labels = map.observations.flatMap(observation => observation.elements.map(element => element.label));
assert.ok(labels.includes('Pattern name'));
for (const label of ['Q', 'Emoji', 'Dictate']) assert.equal(labels.includes(label), false, `${label} is the keyboard's, not the app's`);
});
test('a focused field whose keyboard never rises is captured after about a second and at least two reads, without it', async t => {
const f = await fixture(t, { routes: [route('rename')], focusedField: { path: '/rename' } });
const result = await runCiMap(f.options);
assert.equal(result.outcomes[f.ids.rename].status, 'captured');
const [line] = await keyboardLog(f);
assert.equal(line.outcome, 'absent');
assert.ok(line.reads >= 2 && line.reads <= 6 && line.elapsedMs >= 1000, `gave up after ${line.reads} reads in ${line.elapsedMs} ms`);
assert.equal(f.operations().includes('keyboard'), false, 'the keyboard is never dismissed or summoned');
// A screen without a focused field is not read again.
const plain = await fixture(t, { routes: [route('home')] });
await runCiMap(plain.options);
assert.equal(existsSync(join(plain.options.mapDirectory, 'capture-diagnostics', 'keyboard.jsonl')), false);
});
test('a keyboard already up when the screen is read is captured once a later read finds it in the same place', async t => {
const f = await fixture(t, { routes: [route('rename')], focusedField: { path: '/rename', keyboardFrom: 1 } });
assert.equal((await runCiMap(f.options)).outcomes[f.ids.rename].status, 'captured');
assert.deepEqual((await keyboardLog(f)).map(line => [line.outcome, line.reads]), [['shown', 1]]);
});
test('an application Open button is never an implicit confirmation action', async t => {
const f = await fixture(t, { routes: [route('home')], appOpenButton: true });
const result = await runCiMap(f.options);
-12
View File
@@ -331,15 +331,3 @@ test("compare CLI emits a comparison, review, and catalog that reload as a works
));
assert.deepEqual(shared.baselineScreenIds, ["shared-home"]);
});
test("fingerprints from different Explore versions are not comparable: the match needs review instead of reading as changed", async () => {
// A map saved by Explore 0.20.x hashes the tree with the keyboard and the focus in it, unprefixed; a2 hashes leave them out.
const baseline = makeMap("main-eeeeeee", [{ id: "home", route: "/", acc: "0".repeat(64) }]);
const current = makeMap("pr-3-fffffff", [{ id: "home", route: "/", acc: `a2:${"1".repeat(64)}` }]);
const { comparison, review } = generateComparison(baseline, current);
await validateComparisonDocument(comparison, baseline, current);
const home = review.entries.find((entry) => entry.entryId === "match-home");
assert.equal(home.needsReview, true);
assert.match(entryById(comparison, "match-home").rationale, /different Explore versions/);
assert.ok(home.notes.some((note) => /compare the screenshots/.test(note)));
});
-45
View File
@@ -823,48 +823,3 @@ test("a capture's snapshot backend is read from its saved controller response",
assert.equal(snapshotBackend(directory, map("artifacts/accessibility/missing.json"), "o"), undefined);
assert.equal(snapshotBackend(directory, map("../outside.json"), "o"), undefined);
});
/**
* Tempo on the closed iPhone Duo in brentvatne/euxy#172 (review run 39362642343): a 1398 × 2034 screenshot of a
* 466 × 678 pt screen, and a footnote whose text changed below the fold of its scrolling sheet, so the screenshots match.
* The published review carries no accessibility tree, so the footnote's real bounds are unknown: these tests pin the
* rule (more than half of the changed element past the screen's edge), not where euxy's footnote was.
*/
function tempoSide(sideName, footnote, footnoteBounds, image = { width: 1398, height: 2034 }) {
const evidence = side(sideName, [
element({ elementId: "app", role: "other", label: "euxy", actions: [], actionable: false, bounds: { x: 0, y: 0, width: 466, height: 678, unit: "points" } }),
element({ elementId: "title", role: "text", label: "Base Resolution", actions: [], actionable: false, bounds: { x: 26, y: 560, width: 300, height: 24, unit: "points" } }),
element({ elementId: `${sideName}-footnote`, role: "text", label: footnote, actions: [], actionable: false, bounds: footnoteBounds }),
]);
if (image) {
evidence.map.artifacts.push({ id: `${sideName}-shot`, kind: "screenshot", path: `${sideName}.png`, sha256: "0".repeat(64), mimeType: "image/png", ...image, createdAt: "2026-09-01T01:00:00.000Z" });
evidence.map.observations[0].screenshotArtifactId = `${sideName}-shot`;
}
return evidence;
}
const NEW_LANES = "Changes apply live while playing. Base resolution sets the step grid for new lanes.";
const ADD_NEXT = "Changes apply live while playing. Base resolution sets the step grid for lanes you add next.";
// Its top 12 pt on the screen, 28 pt below the bottom edge: 70% past it.
const mostlyBelow = { x: 26, y: 666, width: 414, height: 40, unit: "points" };
const offScreenOf = (bounds, assessment = visual("unchanged"), image) => compareSurfaceEvidence({ impact: impact(),
base: tempoSide("base", NEW_LANES, bounds, image), head: tempoSide("head", ADD_NEXT, bounds, image), visualAssessment: assessment }).offScreen;
test("matching screenshots of a change whose elements lie mostly past the screen's edge are off-screen", () => {
assert.equal(offScreenOf(mostlyBelow), true);
// A turned frame (an opened iPhone Duo shown upright) keeps the tree on the portrait axes: the screen is still found.
assert.equal(offScreenOf(mostlyBelow, visual("unchanged"), { width: 2034, height: 1398 }), true);
});
test("a change on the screen, partly on it, with differing screenshots, or with no screen to measure against is never off-screen", () => {
const cases = {
"an on-screen text change": [{ x: 26, y: 600, width: 414, height: 40, unit: "points" }],
// Its top 28 pt on the screen, 12 pt below: mostly visible, so matching pixels prove nothing about it.
"a footnote mostly on the screen": [{ x: 26, y: 650, width: 414, height: 40, unit: "points" }],
// A control nudged 2 pt past the left edge, otherwise wholly visible.
"a control just crossing an edge": [{ x: -2, y: 600, width: 300, height: 40, unit: "points" }],
"screenshots that differ": [mostlyBelow, visual("modified")],
"no screenshot size": [mostlyBelow, visual("unchanged"), null],
"a changed element without bounds": [undefined],
};
for (const [name, args] of Object.entries(cases)) assert.equal(offScreenOf(...args), undefined, name);
});
-10
View File
@@ -17,16 +17,6 @@ test("the bounds are in the panel's own pixels when the chrome is zoomed", () =>
assert.deepEqual(inspectorWidthBounds(1600, 0), inspectorWidthBounds(1600, 1));
});
test("the Inspector stops where the canvas keeps the bottom bar's room, never below the minimum", () => {
// 820 - 424 leaves 396, less than half of 820.
assert.deepEqual(inspectorWidthBounds(820, 1, 424), { min: INSPECTOR_WIDTH_MIN, max: 396 });
// In a wide window half of it is the tighter cap.
assert.deepEqual(inspectorWidthBounds(1440, 1, 424), { min: INSPECTOR_WIDTH_MIN, max: 720 });
// The room is in window pixels, the width in the panel's own: (1000 - 530) / 1.25 = 376.
assert.deepEqual(inspectorWidthBounds(1000, 1.25, 530), { min: INSPECTOR_WIDTH_MIN, max: 376 });
assert.deepEqual(inspectorWidthBounds(700, 1, 424), { min: INSPECTOR_WIDTH_MIN, max: INSPECTOR_WIDTH_MIN });
});
test("a width is clamped to the bounds and rounded to whole pixels", () => {
const bounds = { min: 320, max: 720 };
assert.equal(clampInspectorWidth(100, bounds), 320);
-23
View File
@@ -60,29 +60,6 @@ test("ending a hold, or beginning another key, stops the first", (t) => {
assert.equal(left, 2);
});
test("a hold says when it ends, however it ends, and whether any key is held", (t) => {
t.mock.timers.enable({ apis: ["setTimeout"] });
const hold = createKeyHold();
const ended = [];
assert.ok(!hold.holding());
hold.begin("ArrowRight", () => true, () => ended.push("released"));
assert.ok(hold.holding());
hold.release("ArrowLeft");
assert.deepEqual(ended, [], "another key going up leaves it held");
hold.release("ArrowRight");
hold.begin("ArrowLeft", () => true, () => ended.push("replaced"));
hold.begin("ArrowRight", () => true, () => ended.push("ended"));
hold.end();
let steps = 0;
hold.begin("ArrowDown", () => (steps += 1) < 2, () => ended.push("at the end"));
t.mock.timers.tick(HOLD_INITIAL_DELAY_MS);
t.mock.timers.tick(holdIntervalMs(1));
assert.deepEqual(ended, ["released", "replaced", "ended", "at the end"]);
assert.ok(!hold.holding());
hold.end();
assert.equal(ended.length, 4, "an ended hold does not end again");
});
test("another key ends a hold, as the OS's own repeat stops; its own repeats and a modifier do not", () => {
const key = (code, key = code, repeat = false) => ({ code, key, repeat });
const hold = createKeyHold();
-201
View File
@@ -1,201 +0,0 @@
import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import test from "node:test";
import { tsImport } from "tsx/esm/api";
const { snapshotFromTree } = await tsImport("../../src/capture/argent-driver.ts", import.meta.url);
const { focusedTextInput, keyboardBounds, keyboardNodes, keyboardSettle } = await tsImport("../../src/capture/keyboard.ts", import.meta.url);
const { parseControllerOutput } = await tsImport("../../src/capture/controller-output.ts", import.meta.url);
const { normalizeSnapshot } = await tsImport("../../src/map/store.ts", import.meta.url);
const fixture = name => JSON.parse(readFileSync(new URL(`../fixtures/argent-0.29/${name}`, import.meta.url), "utf8"));
// euxy's rename sheet on iOS 26 under Argent 0.29, its field focused and the keyboard up: the head of brentvatne/euxy#172
// (review run 39362642343). Its root holds three windows: the app's, the input view placeholder's, and the keyboard's.
const RENAME_KEYBOARD_UP = fixture("fixture-ios-ui-tree-rename.json");
// The same sheet a moment earlier, as the base was captured: the field focused and its cursor showing, no keyboard yet.
const RENAME_KEYBOARD_DOWN = { ...RENAME_KEYBOARD_UP, keyboardVisible: false,
roots: [{ ...RENAME_KEYBOARD_UP.roots[0], children: RENAME_KEYBOARD_UP.roots[0].children.slice(0, 1) }] };
const ANDROID_RENAME = fixture("fixture-android-ui-tree-rename.json");
const nodesOf = tree => snapshotFromTree(tree, "ios", 1).nodes;
const labelsOf = nodes => parseControllerOutput("agent-device", JSON.stringify({ success: true, data: { nodes } })).elements.map(element => element.label);
const nameOf = node => node.label ?? node.identifier;
const rect = (x, y, width, height) => ({ x, y, width, height });
test("the iOS keyboard Argent reports is its own windows: the input view placeholder's and the keyboard's, Emoji and Dictate included", () => {
const nodes = nodesOf(RENAME_KEYBOARD_UP);
assert.deepEqual(keyboardBounds(nodes), rect(0, 539, 402, 335), "the input view and prediction bar down to the bottom edge");
const owned = [...keyboardNodes(nodes)];
const names = owned.map(nameOf).filter(Boolean);
for (const name of ["inputView", "SystemInputAssistantView", "Typing Predictions", "Q", "shift", "Emoji", "Dictate"]) assert.ok(names.includes(name), name);
assert.ok(owned.every(node => node.systemKeyboard === true), "only nodes of the keyboard's windows");
// Every element of the app's window stays, those behind the keyboard's band among them.
const app = nodesOf(RENAME_KEYBOARD_DOWN).map(nameOf).filter(Boolean);
for (const name of app) assert.ok(nodes.some(node => nameOf(node) === name && !keyboardNodes(nodes).has(node)), name);
assert.ok(app.includes("AdditionalDimmingOverlay") && app.includes("Tab Bar") && app.includes("Clear name"));
});
test("a keyboard up on one side only leaves the elements and the accessibility fingerprint unchanged", () => {
// In euxy#172 the review led with "Added button “Dictate”", “Emoji” and “inputView” over the label change.
const up = nodesOf(RENAME_KEYBOARD_UP), down = nodesOf(RENAME_KEYBOARD_DOWN);
assert.deepEqual(labelsOf(up), labelsOf(down));
for (const name of ["Dictate", "Emoji", "inputView", "Q"]) assert.equal(labelsOf(up).includes(name), false, name);
// The bridge numbers nodes in order, so the app's own nodes keep their indices when the keyboard's windows follow them.
const snapshot = nodes => JSON.stringify({ success: true, data: { nodes: nodes.map(({ ref: _ref, ...node }) => node) } });
assert.equal(normalizeSnapshot(snapshot(up)), normalizeSnapshot(snapshot(down)));
});
test("the text field with the focus is passed on from Argent", () => {
const up = nodesOf(RENAME_KEYBOARD_UP), down = nodesOf(RENAME_KEYBOARD_DOWN);
assert.equal(up.filter(node => node.focused === true).map(node => node.type).join(), "TextField");
assert.equal(focusedTextInput(up), true);
assert.equal(focusedTextInput(down), true);
assert.equal(keyboardBounds(down), undefined);
assert.equal(focusedTextInput(nodesOf(fixture("fixture-ios-ui-tree-home.json"))), false);
});
test("an element the app identifies as inputView in its own window is the app's", () => {
// A chat composer with testID="inputView", no keyboard up.
const app = RENAME_KEYBOARD_DOWN.roots[0].children[0];
const composer = { role: "AXGroup", type: "Other", identifier: "inputView", frame: rect(0, 0.8, 1, 0.1),
children: [{ role: "AXButton", type: "Button", label: "Send", frame: rect(0.8, 0.82, 0.15, 0.05), children: [] }] };
const tree = { ...RENAME_KEYBOARD_DOWN, roots: [{ ...RENAME_KEYBOARD_DOWN.roots[0], children: [{ ...app, children: [...app.children, composer] }] }] };
const nodes = nodesOf(tree);
assert.equal(keyboardNodes(nodes).size, 0);
assert.equal(keyboardBounds(nodes), undefined);
assert.ok(labelsOf(nodes).includes("inputView") && labelsOf(nodes).includes("Send"));
});
test("a second window of the app's own, its testID inputView included, is the app's; the keyboard's windows need a Keyboard", () => {
// The app's second UIWindow (a toast or a floating composer) with a view identified as inputView and a Save button.
const window = { role: "AXGroup", type: "Application", frame: rect(0, 0, 1, 1), children: [
{ role: "AXGroup", type: "Other", identifier: "inputView", frame: rect(0, 0.8, 1, 0.1),
children: [{ role: "AXButton", type: "Button", label: "Save", frame: rect(0.8, 0.82, 0.15, 0.05), children: [] }] }] };
const [app, placeholder, keyboard] = RENAME_KEYBOARD_UP.roots[0].children;
const withWindows = windows => nodesOf({ ...RENAME_KEYBOARD_UP, roots: [{ ...RENAME_KEYBOARD_UP.roots[0], children: [app, ...windows] }] });
for (const windows of [[window], [window, keyboard], [window, placeholder, keyboard]]) {
const labels = labelsOf(withWindows(windows));
assert.ok(labels.includes("Save") && labels.includes("inputView"), `kept beside ${windows.length - 1} keyboard windows`);
}
// Without the keyboard's own window, an input view placeholder window proves nothing.
assert.ok(labelsOf(withWindows([placeholder])).includes("inputView"));
assert.equal(keyboardNodes(withWindows([placeholder])).size, 0);
// With it, the placeholder is the keyboard's too, as in the real tree.
assert.equal(labelsOf(withWindows([placeholder, keyboard])).includes("inputView"), false);
});
test("agent-device's keyboard is its Keyboard element and what is under it, and its host bridge's keyboard view classes", () => {
// XCTest: the Keyboard directly under the Application, beside the app's own controls in the same band.
const xctest = [
{ index: 0, type: "Application", label: "Example", rect: rect(0, 0, 402, 874) },
{ index: 1, parentIndex: 0, type: "TextField", label: "Pattern name", focused: true, rect: rect(23, 386, 355, 50) },
{ index: 2, parentIndex: 0, type: "Keyboard", rect: rect(0, 583, 402, 233) },
{ index: 3, parentIndex: 2, type: "Key", label: "Q", rect: rect(5, 590, 39, 54) },
{ index: 4, parentIndex: 0, type: "Button", label: "Home tab", rect: rect(0, 800, 134, 74) },
{ index: 5, parentIndex: 0, type: "Other", label: "Formatting toolbar", rect: rect(0, 540, 402, 43) },
{ index: 6, parentIndex: 0, type: "Button", label: "Emoji", rect: rect(8, 300, 68, 40) },
];
assert.deepEqual(keyboardBounds(xctest), rect(0, 583, 402, 233));
assert.deepEqual(labelsOf(xctest), ["Example", "Pattern name", "Home tab", "Formatting toolbar", "Emoji"]);
// The host bridge names the dock's buttons by class, wherever they sit.
const hostBridge = [
{ type: "TextField", role: "RCTUITextField", label: "Pattern name", focused: true, rect: rect(23, 386, 355, 50) },
{ type: "Button", role: "UIKeyboardDockItemButton", label: "Dictate", rect: rect(325, 806, 68, 68) },
{ type: "Other", role: "UIAccessibilityElementKBKey", label: "Q", rect: rect(5, 590, 39, 54) },
{ type: "Button", role: "RCTViewComponentView", label: "Profile tab", rect: rect(268, 800, 134, 74) },
];
assert.ok(keyboardBounds(hostBridge));
assert.deepEqual(labelsOf(hostBridge), ["Pattern name", "Profile tab"]);
});
test("nothing without a parent link is taken for the keyboard's, and keys alone are no keyboard", () => {
// agent-device's flat shape: no parentIndex. The Keyboard element goes; nothing can be proven to be under it.
const flat = [
{ type: "Keyboard", rect: rect(0, 583, 402, 233) },
{ type: "Key", label: "Q", rect: rect(5, 590, 39, 54) },
{ type: "Button", label: "Profile tab", rect: rect(268, 800, 134, 74) },
];
assert.deepEqual(labelsOf(flat), ["Q", "Profile tab"]);
// An app's own PIN pad (accessibilityRole="keyboardkey") and its footer action, with no system keyboard up.
const pinPad = [
{ index: 0, type: "Application", label: "Example", rect: rect(0, 0, 402, 874) },
{ index: 1, parentIndex: 0, type: "SecureTextField", label: "PIN", focused: true, rect: rect(23, 200, 355, 50) },
...["1", "2", "3"].map((digit, offset) => ({ index: 2 + offset, parentIndex: 0, type: "Key", label: digit, rect: rect(offset * 134, 600, 134, 70) })),
{ index: 5, parentIndex: 0, type: "Button", label: "App footer action", rect: rect(0, 800, 402, 74) },
];
assert.equal(keyboardNodes(pinPad).size, 0);
assert.equal(keyboardBounds(pinPad), undefined);
assert.deepEqual(labelsOf(pinPad), ["Example", "PIN", "1", "2", "3", "App footer action"]);
});
test("in landscape the keyboard is told apart the same way, the app's bottom bar kept", () => {
const landscape = [
{ index: 0, type: "Application", label: "Example", rect: rect(0, 0, 874, 402) },
{ index: 1, parentIndex: 0, type: "TextField", label: "Search", focused: true, rect: rect(100, 60, 674, 40) },
{ index: 2, parentIndex: 0, type: "Keyboard", rect: rect(0, 230, 874, 172) },
{ index: 3, parentIndex: 2, type: "Key", label: "Q", rect: rect(60, 236, 70, 38) },
{ index: 4, parentIndex: 0, type: "TabBar", label: "Tab Bar", rect: rect(0, 352, 874, 50) },
];
assert.deepEqual(keyboardBounds(landscape), rect(0, 230, 874, 172));
assert.deepEqual(labelsOf(landscape), ["Example", "Search", "Tab Bar"]);
});
test("an Android input method's window is the keyboard under Argent, AOSP's included, and Argent says when one shows", () => {
const ime = pkg => ({ role: "FrameLayout", type: "android.widget.FrameLayout", bundleId: pkg, frame: rect(0, 0.6, 1, 0.4),
children: [{ role: "Button", type: "android.widget.Button", contentDescription: "q", frame: rect(0.01, 0.65, 0.09, 0.06), children: [] }] });
const before = snapshotFromTree(ANDROID_RENAME, "android", 1, "dev.brent.euxy").nodes;
assert.equal(focusedTextInput(before), true, "Argent marks the focused EditText");
assert.equal(keyboardBounds(before), undefined);
for (const pkg of ["com.google.android.inputmethod.latin", "com.android.inputmethod.latin"]) {
const after = snapshotFromTree({ ...ANDROID_RENAME, keyboardVisible: true, roots: [...ANDROID_RENAME.roots, ime(pkg)] }, "android", 1, "dev.brent.euxy").nodes;
assert.deepEqual(keyboardBounds(after), rect(0, 960, 720, 640), pkg);
assert.deepEqual(labelsOf(after), labelsOf(before), pkg);
}
});
test("the wait reads until the keyboard is in one place twice, at least twice, at most six times", () => {
const field = { type: "TextField", label: "Pattern name", focused: true, rect: rect(23, 386, 355, 50) };
const keyboardAt = y => [field, { index: 9, type: "Keyboard", rect: rect(0, y, 402, 874 - y) }];
// Already up when the screen was read: one more read must find it in the same place.
const up = keyboardSettle({ nodes: keyboardAt(583) });
assert.equal(up.more(0), true, "a keyboard already up may still be rising");
up.read({ nodes: keyboardAt(583) });
assert.deepEqual([up.outcome, up.reads, up.more(250)], ["shown", 1, false]);
// Caught rising: it moves between reads, then holds.
const rising = keyboardSettle({ nodes: [field] });
for (const y of [700, 583, 583]) rising.read({ nodes: keyboardAt(y) });
assert.deepEqual([rising.outcome, rising.reads], ["shown", 3]);
// A slow controller: the second read is owed even after a second has passed.
const slow = keyboardSettle({ nodes: [field] });
slow.read({ nodes: [field] });
assert.equal(slow.more(2_500), true);
slow.read({ nodes: [field] });
assert.deepEqual([slow.outcome, slow.more(5_000)], ["absent", false], "no keyboard came: captured without one");
// A slow first read without a keyboard, then the keyboard first seen still moving: read on until it holds.
const late = keyboardSettle({ nodes: [field] });
late.read({ nodes: [field] });
late.read({ nodes: keyboardAt(700) });
assert.deepEqual([late.outcome, late.more(2_500)], ["moving", true], "a moving keyboard is not given up on after a second");
late.read({ nodes: keyboardAt(583) });
late.read({ nodes: keyboardAt(583) });
assert.deepEqual([late.outcome, late.reads], ["shown", 4]);
// But not past four seconds, however few reads that was.
const stalled = keyboardSettle({ nodes: [field] });
stalled.read({ nodes: [field] });
stalled.read({ nodes: keyboardAt(700) });
assert.equal(stalled.more(4_000), false);
// Six reads at most, however fast they come.
const busy = keyboardSettle({ nodes: [field] });
for (let read = 0; busy.more(0); read++) busy.read({ nodes: keyboardAt(read % 2 ? 583 : 700) });
assert.deepEqual([busy.outcome, busy.reads], ["moving", 6]);
// The field let go and no keyboard shows: nothing more to wait for.
const released = keyboardSettle({ nodes: [field] });
released.read({ nodes: [{ ...field, focused: false }] });
assert.deepEqual([released.outcome, released.more(0)], ["unfocused", false]);
// Argent on Android says a keyboard shows without placing it: it shows twice running.
const android = keyboardSettle({ nodes: [field] });
android.read({ nodes: [field], keyboardVisible: true });
android.read({ nodes: [field], keyboardVisible: true });
assert.equal(android.outcome, "shown");
assert.equal(keyboardSettle({ nodes: [{ ...field, focused: false }] }), undefined, "a screen without a focused field is not waited on");
});
+9 -98
View File
@@ -7,7 +7,7 @@ import test from "node:test";
import { prepareCaptureReview } from "../../dist/review/capture-review.js";
import { createSourceCapturePlan } from "../../dist/source/capture-plan.js";
import { writeCiReportInput, exportCiReport } from "../../dist/report/artifact.js";
import { collectPlatformReports, deployExplorationReport, deployFixturePreview, deployLocalReports, FIXTURE_ALIAS_WAIT_MS, fixtureReports, deployPreview, previewProjectSlug, readReportZip, whoamiAccounts, zipReportDirectory } from "../../dist/report/preview-deploy.js";
import { collectPlatformReports, deployExplorationReport, deployFixturePreview, deployLocalReports, fixtureReports, deployPreview, previewProjectSlug, readReportZip, whoamiAccounts, zipReportDirectory } from "../../dist/report/preview-deploy.js";
import { spawnSync } from "node:child_process";
import { ZipReader, Uint8ArrayReader, TextWriter, configure } from "@zip.js/zip.js";
import { viewerLinks } from "../../dist/report/viewer-links.js";
@@ -387,76 +387,11 @@ test("collectPlatformReports pairs downloaded artifact directories by platform a
const lookups = eas.requests.filter(request => request.url.pathname.endsWith("/actions/runs/10/artifacts"));
assert.deepEqual(lookups.map(request => request.url.searchParams.get("name")), ["explore-review-10-1-android", "explore-review-10-1-ios"]);
assert.ok(lookups.every(request => request.options.headers.authorization === "Bearer test-token"));
// A target whose report job failed (brentvatne/euxy#172) is left out; the others still deploy, without waiting for it.
await rm(join(root, "reports", "explore-review-10-1-android"), { recursive: true });
const before = eas.requests.length;
const remaining = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: eas.transport });
assert.deepEqual(remaining.map(entry => entry.target.id), ["ios"]);
assert.deepEqual(eas.requests.slice(before).map(request => request.url.searchParams.get("name")), ["explore-review-10-1-ios"], "no lookup for the target without a report");
await rm(join(root, "reports", "explore-review-10-1-ios"), { recursive: true });
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: eas.transport }),
error => error.code === "PREVIEW_REPORTS_INCOMPLETE");
});
test("collectPlatformReports reads a lone target's artifacts, which download-artifact extracts into the path itself", async t => {
const fixture = await asTarget(await exportFixture(t), TARGETS[2]);
const root = await mkdtemp(join(tmpdir(), "explore-fanin-lone-")); t.after(() => rm(root, { recursive: true, force: true }));
// Four of five captures failed, so each pattern matched one artifact: its files sit in --inputs and --reports themselves.
await mkdir(join(root, "inputs"), { recursive: true }); await cp(fixture.inputPath, join(root, "inputs", "report-input.json"));
await cp(fixture.reportPath, join(root, "reports"), { recursive: true });
const eas = easFixture();
const transport = async (input, options) => {
const url = new URL(input);
if (url.pathname.endsWith("/actions/runs/10/artifacts") && url.searchParams.get("name") === "explore-review-10-1-duo-open") {
return new Response(JSON.stringify({ artifacts: [{ id: 33, name: "explore-review-10-1-duo-open" }] }), { status: 200 });
}
return eas.transport(input, options);
};
const [entry, ...rest] = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport });
assert.deepEqual(rest, []);
assert.deepEqual([entry.target.id, entry.inputPath, entry.reportPath, entry.artifactUrl.split("/").at(-1)],
["duo-open", join(root, "inputs", "report-input.json"), join(root, "reports"), "33"]);
// A pattern that matched nothing left no directory: there is nothing to deploy, and that is said plainly.
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "missing"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport }),
error => error.code === "PREVIEW_REPORTS_MISSING");
});
test("collectPlatformReports looks up a report artifact the run does not list yet again, but not one its token cannot read", async t => {
const ios = await exportFixture(t);
const root = await mkdtemp(join(tmpdir(), "explore-fanin-late-")); t.after(() => rm(root, { recursive: true, force: true }));
const { cp } = await import("node:fs/promises");
await mkdir(join(root, "inputs", "explore-capture-10-1-ios"), { recursive: true }); await cp(ios.inputPath, join(root, "inputs", "explore-capture-10-1-ios", "report-input.json"));
await cp(ios.reportPath, join(root, "reports", "explore-review-10-1-ios"), { recursive: true });
const eas = easFixture();
const listing = answers => {
const lookups = [];
const transport = async (input, options) => {
const url = new URL(input);
if (!url.pathname.endsWith("/actions/runs/10/artifacts")) return eas.transport(input, options);
lookups.push(url);
const answer = answers[Math.min(lookups.length, answers.length) - 1];
return answer ? new Response(JSON.stringify(answer.body ?? {}), { status: answer.status }) : eas.transport(input, options);
};
return { lookups, transport };
};
const pauses = [];
const sleep = async milliseconds => { pauses.push(milliseconds); };
// The list lags the report job's upload: empty, then a 404, then the artifact.
const late = listing([{ status: 200, body: { artifacts: [] } }, { status: 404 }, undefined]);
const [entry] = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: late.transport, sleep });
assert.equal(entry.artifactUrl, artifactUrl.replace(/20$/, "21"));
assert.equal(late.lookups.length, 3);
assert.equal(pauses.length, 2);
const denied = listing([{ status: 403 }]);
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: denied.transport, sleep }),
error => error.code === "REPORT_ARTIFACT_MISSING" && /HTTP 403/.test(error.message));
assert.equal(denied.lookups.length, 1);
const never = listing([{ status: 200, body: { artifacts: [] } }]);
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: never.transport, sleep }),
error => error.code === "REPORT_ARTIFACT_MISSING");
assert.equal(never.lookups.length, 5);
});
const now = Date.UTC(2026, 8, 11, 3, 7);
const STALE_COMMENT = `<!-- expo-explore-ci -->
Explore review for abc · Managed via config
@@ -521,20 +456,6 @@ test("a standalone report deploys to a fixed alias with a fixed token, verifies
assert.match(plain.previewUrl, /^https:\/\/acme-explore--1lcbdcpwn3\.expo\.app\/p\/[a-z2-7]{32}$/);
assert.notEqual(plain.previewUrl, result.previewUrl, "without a fixed token the link is random");
// A standalone report's alias that is still behind after the whole budget: its link is the deployment, which
// serves this run, and nothing says the alias is behind (only a fixture preview's comment explains a lagging link).
const behind = easFixture({ aliasServes: false });
let clock = now;
const quiet = process.stderr.write.bind(process.stderr);
process.stderr.write = () => true;
let fallback;
try {
fallback = await deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "bluesky", token,
environment: deployEnvironment, transport: behind.transport, run: behind.run, now: () => (clock += 31_000), verifyTimeoutMs: 60_000 });
} finally { process.stderr.write = quiet; }
assert.equal(fallback.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
assert.equal(fallback.aliasBehind, undefined);
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "Blue Sky",
environment: deployEnvironment, transport: eas.transport, run: eas.run, verifyTimeoutMs: 1 }), error => error.code === "PREVIEW_ALIAS_INVALID");
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, token: "short",
@@ -566,28 +487,21 @@ test("a fixture preview seals each platform's ZIP as is behind one alias and lis
const served = eas.requests.filter(request => request.url.pathname === `/p/${token}/manifest.json`).map(request => request.url.searchParams.get("platform"));
assert.deepEqual([...new Set(served)].sort(), ["android", "ios"], "both platforms' manifests are verified");
// The alias lagging the deployment is not a failed deployment (every 2026-10-14 "HTTP 404" failure was this): the
// deployment is verified, so after FIXTURE_ALIAS_WAIT_MS, not the whole verification budget, the pull request links
// the alias anyway, says it is behind, and the job log carries a warning.
// The alias lagging the deployment past the budget is not a failed deployment: the deployment is verified, so the
// link is the deployment's own origin and the job log carries a warning (every 2026-10-14 "HTTP 404" failure was this).
const behind = easFixture({ aliasOrigin: "https://explore-viewer-pr--pr-12.expo.app", aliasServes: false });
// Each poll really waits 3 s, so the clock moves 7 s a reading: the 20 s wait is three polls, not twenty.
let clock = now; const ticking = () => (clock += 7_000);
let clock = now; const ticking = () => (clock += 31_000);
const quiet = process.stderr.write.bind(process.stderr); const logged = [];
process.stderr.write = chunk => { logged.push(String(chunk)); return true; };
let linked;
try {
linked = await deployFixturePreview({ reports: [{ platform: "ios", zipPath: join(root, "ios.zip") }], project: "explore-viewer-pr", owner: "brent-org", alias: "pr-12", token,
exportPath, environment: deployEnvironment, transport: behind.transport, run: behind.run, now: ticking, verifyTimeoutMs: 180_000 });
exportPath, environment: deployEnvironment, transport: behind.transport, run: behind.run, now: ticking, verifyTimeoutMs: 60_000 });
} finally { process.stderr.write = quiet; }
assert.equal(linked.previewUrl, `https://explore-viewer-pr--pr-12.expo.app/p/${token}`);
assert.equal(linked.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
assert.equal(linked.aliasUrl, "https://explore-viewer-pr--pr-12.expo.app");
assert.equal(linked.aliasBehind, true);
assert.equal(linked.deploymentUrl, "https://acme-explore--1lcbdcpwn3.expo.app", "the comment links the verified deployment beside the alias");
assert.equal(logged.filter(line => /^Deployment https:\/\/acme-explore--1lcbdcpwn3\.expo\.app serves this run's report \(\d+ s after eas deploy returned\)\./.test(line)).length, 1);
const warning = logged.find(line => /^::warning::The alias https:\/\/explore-viewer-pr--pr-12\.expo\.app still answers HTTP 404 \d+ s after eas deploy returned\. The pull request links it anyway, until it catches up, beside the deployment https:\/\/acme-explore--1lcbdcpwn3\.expo\.app\./.test(line));
assert.ok(warning, logged.join(""));
const waited = Number(/HTTP 404 (\d+) s/.exec(warning)[1]);
assert.ok(waited >= FIXTURE_ALIAS_WAIT_MS / 1000 && waited < FIXTURE_ALIAS_WAIT_MS / 1000 + 15, `gave up on the alias after ${waited} s, not the 180 s budget`);
assert.equal(logged.filter(line => /^::warning::The alias https:\/\/explore-viewer-pr--pr-12\.expo\.app still answers HTTP 404 \d+ s after eas deploy returned\. The pull request links the deployment https:\/\/acme-explore--1lcbdcpwn3\.expo\.app instead\./.test(line)).length, 1);
assert.ok(behind.requests.some(request => request.url.origin === "https://explore-viewer-pr--pr-12.expo.app"), "the alias was polled");
// The example report keeps one token and the same fixtures, so an alias still on the previous deployment serves the
@@ -599,8 +513,7 @@ test("a fixture preview seals each platform's ZIP as is behind one alias and lis
linked = await deployFixturePreview({ reports: [{ platform: "ios", zipPath: join(root, "ios.zip") }], project: "explore-viewer-pr", owner: "brent-org", alias: "pr-12", token,
exportPath, environment: deployEnvironment, transport: stale.transport, run: stale.run, now: ticking, verifyTimeoutMs: 60_000 });
} finally { process.stderr.write = quiet; }
assert.equal(linked.previewUrl, `https://explore-viewer-pr--pr-12.expo.app/p/${token}`);
assert.equal(linked.aliasBehind, true);
assert.equal(linked.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
assert.equal(logged.filter(line => /^::warning::The alias https:\/\/explore-viewer-pr--pr-12\.expo\.app still serves an earlier deployment \d+ s after eas deploy returned\./.test(line)).length, 1);
await assert.rejects(deployFixturePreview({ reports: [{ platform: "ios", zipPath: join(root, "ios.zip") }, { platform: "ios", zipPath: join(root, "ios.zip") }],
@@ -876,9 +789,7 @@ test("ci:deploy pairs target-named artifacts, deploys them in config order, and
const entries = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport });
assert.deepEqual(entries.map(entry => [entry.target.id, entry.platform, entry.artifactUrl.split("/").at(-1)]),
[["iphone", undefined, "31"], ["duo-closed", undefined, "32"], ["duo-open", undefined, "33"], ["android", "android", "34"]], "config order, not directory order");
// The fixture serves none of these artifacts by id, so each comment's artifact lookup answers 404 through all its retries.
const sealed = await deployPreview({ reports: entries.map(({ platform: _platform, ...entry }) => entry), exportPath: fixtures[0].exportPath, environment: deployEnvironment, transport, run: eas.run, now: () => now, verifyTimeoutMs: 1,
sleep: async () => {} })
const sealed = await deployPreview({ reports: entries.map(({ platform: _platform, ...entry }) => entry), exportPath: fixtures[0].exportPath, environment: deployEnvironment, transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 })
.catch(error => error);
// Publishing each target's comment section after the deployment is the comment code's (publishCiReportComment, which needs
// the target to name the artifact); the deployment itself must have been written per target either way.
-134
View File
@@ -679,80 +679,6 @@ test('a config without targets writes the same records and comment as before tar
assert.deepEqual(Object.keys(readCommentRecords(after).current), ['ios', 'android']);
});
/**
* brentvatne/euxy#172, review run 39362642343: five targets, two strings changed. Tempo's footnote sits low in a
* scrolling sheet. On the closed iPhone Duo the accessibility tree has the new text but the screenshots match: the
* footnote runs past the bottom of the screen (`offScreen`, from the elements' bounds). On the half-open and opened Duo
* neither the tree nor the pixels have it. Android captures no dark appearance.
*/
const euxyTargets = [{ id: 'iphone', platform: 'ios', label: 'iPhone 17' }, { id: 'duo-closed', platform: 'ios', label: 'iPhone Duo (closed)' },
{ id: 'duo-half-open', platform: 'ios', label: 'iPhone Duo (half-open)' }, { id: 'duo-open', platform: 'ios', label: 'iPhone Duo (open)' },
{ id: 'android', platform: 'android', label: 'Android' }];
const footnote = 'Added text “Changes apply live while playing. Base resolution sets the step grid for lanes you add next.”.';
const footnoteText = 'Added text “Changes apply live while playing\\. Base resolution sets the step grid for lanes you add next\\.”';
function euxyReview(target, options = {}) {
const own = { sourceImpact: ['own'], sourceScope: 'screen' };
const matched = { verdict: 'unchanged', reason: 'matched', mismatchPercentage: 0, threshold: 0.1, tool: '[email protected]' };
const changed = (description, mismatchPercentage) => ({ ...own,
review: { status: 'modified', description, facts: [{ category: 'element', templateId: 'element.added', bullet: description }] },
visual: { verdict: 'modified', reason: 'repeated-cross-build-delta', mismatchPercentage, threshold: 0.1, tool: '[email protected]' } });
const inTreeOnly = { ...changed(footnote, 0), visual: matched };
if (options.offScreen !== false) inTreeOnly.review.offScreen = true;
if (options.diffFailed) inTreeOnly.visual = { ...matched, reason: 'diff-failed' };
const unseen = { ...own, review: { status: 'unchanged', description: 'No visible change' }, visual: matched };
const tempo = target === 'duo-closed' ? inTreeOnly : ['duo-half-open', 'duo-open'].includes(target) ? unseen : changed(footnote, 0.11);
const rename = changed('Added text “Pattern name”.', 0.16);
const schemes = target === 'android' ? [''] : ['', '@dark'];
return review(schemes.flatMap(scheme => [
surface(`tempo${scheme}`, 'modified', { route: '/tempo', extra: structuredClone(tempo) }),
surface(`rename-pattern${scheme}`, 'modified', { route: '/rename-pattern', extra: structuredClone(rename) }),
]));
}
async function euxyRows(reviewOf = euxyReview) {
const { platformSectionMerge } = await import('../../dist/report/pr-comment-body.js');
let body;
for (const target of euxyTargets) body = platformSectionMerge(state({ artifactOnly: true, target, targets: euxyTargets, review: reviewOf(target.id),
build: { ...state().build, platform: target.platform }, runtime: { ...state().runtime, platform: target.platform, deviceModel: target.label } }), target.id).merge(body);
return { body, rows: listOf(body).map(line => line.replace(/\(<[^>]+>\)/, '')) };
}
test('a change whose elements run past the screen on a device is named off-screen there, beside the devices that show it (euxy#172)', async () => {
const { body, rows } = await euxyRows();
assert.deepEqual(rows, [
`- [\`/tempo\`] · ${footnoteText} · iPhone 17, Android only · off-screen on iPhone Duo \\(closed\\)`,
`- [\`/rename-pattern\`] · Added text “Pattern name”`,
`- [\`/tempo\`] (dark) · ${footnoteText} · iPhone 17 only · off-screen on iPhone Duo \\(closed\\)`,
`- [\`/rename-pattern\`] (dark) · Added text “Pattern name” · not on Android`,
], 'the half-open and opened Duo have no trace of it, so they stay among the devices it is not on');
const { readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
assert.deepEqual(readCommentRecords(body).current['duo-closed'].changes.filter(change => change.offScreen).map(change => change.id), ['tempo', 'tempo@dark'],
'the mark survives the comment round trip');
});
test('without geometry that puts it past the screen, or with a failed comparison, a device keeps today\'s wording', async () => {
// The review euxy#172 published: the closed Duo's change is accessibility-only, with nothing saying where its elements are.
const { rows } = await euxyRows(target => euxyReview(target, { offScreen: false }));
assert.equal(rows[0], `- [\`/tempo\`] · ${footnoteText} · not on iPhone Duo \\(half\\-open\\), iPhone Duo \\(open\\)`);
assert.equal(rows[2], `- [\`/tempo\`] (dark) · ${footnoteText} · iPhone 17, iPhone Duo \\(closed\\) only`);
// A comparison that failed is no verdict at all: the closed Duo is not counted among the devices with the change.
const failed = await euxyRows(target => euxyReview(target, { diffFailed: true }));
assert.match(failed.rows[0], / · on iPhone 17, Android$/);
assert.doesNotMatch(failed.rows.join('\n'), /off-screen/);
});
test('a change one platform has and another lacks keeps "only" and "not on"', async () => {
// An iOS-only branch in a shared screen file: Android's capture of the screen shows no change, and says nothing off-screen.
const iosOnly = target => {
const reviewed = euxyReview(target);
if (target === 'android') for (const entry of reviewed.surfaces) Object.assign(entry, { review: { status: 'unchanged', description: 'No visible change' },
visual: { verdict: 'unchanged', reason: 'matched', mismatchPercentage: 0, threshold: 0.1, tool: '[email protected]' } });
return reviewed;
};
const { rows } = await euxyRows(iosOnly);
assert.equal(rows[0], `- [\`/tempo\`] · ${footnoteText} · iPhone 17 only · off-screen on iPhone Duo \\(closed\\)`);
assert.match(rows.find(row => row.startsWith('- [`/rename-pattern`] ·')), / · not on Android$/);
});
test('several targets share a comment: named in config order in the subtitle, each linking its report, keyed by id in the records and history', async () => {
const { platformSectionMerge, readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
const [iphone, closed, open, android] = duoTargets;
@@ -784,53 +710,6 @@ test('several targets share a comment: named in config order in the subtitle, ea
assert.match(next, /\n- \[bbbbbbbb\]\(<[^>]+>\) · iPhone 17 🟩 3 changes \(.*?\) · iPhone Duo \\\(closed\\\) ⏳ did not finish \(.*?\) · iPhone Duo \\\(open\\\) 🟩 3 changes \(.*?\) · Pixel 7 🟩 3 changes /);
});
test('one of five targets failed: the comment shows the four reports and that failure, and no new-run banner (brentvatne/euxy#172)', async t => {
const { platformSectionMerge, readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
const { publishFailureComment } = await import('../../dist/report/failure-comment.js');
const { mkdir, mkdtemp, rm, writeFile } = await import('node:fs/promises');
const { tmpdir } = await import('node:os');
const { join } = await import('node:path');
const targets = [...duoTargets, { id: 'pixel-dark', platform: 'android', label: 'Pixel 7 (dark)' }];
const configPath = '.expo-explore/config.yaml';
const firstAttempt = viewerLinks({ artifactUrl: 'https://github.com/expo/explore-playground/actions/runs/42/artifacts/7650', repository: pullRequest.repository, headSha, runId: '42', runAttempt: '1', configPath });
const working = viewerLinks({ repository: pullRequest.repository, headSha, runId: '42', runAttempt: '2', configPath });
// Attempt 1 published every target; attempt 2 captured them all at once, and the iPhone Duo (open) session failed.
let body;
for (const target of targets) body = platformSectionMerge(targetState(target, { targets, links: firstAttempt }), target.id).merge(body);
for (const target of targets) body = platformSectionMerge(targetState(target, { targets, links: working, phase: 'capturing', review: undefined, evidence: undefined,
capture: { planned: { base: 3, head: 3 }, done: { base: 3, head: 1 }, baseFromCache: false, current: 'head' } }), target.id).merge(body);
assert.match(visible(body), /New run in progress/);
for (const target of targets.filter(target => target.id !== 'duo-open')) body = platformSectionMerge(targetState(target, { targets }), target.id).merge(body);
const root = await mkdtemp(join(tmpdir(), 'explore-one-failed-')); t.after(() => rm(root, { recursive: true, force: true }));
for (const target of targets) await mkdir(join(root, 'capture', `explore-diagnostics-42-2-${target.id}`, 'explore-diagnostics'), { recursive: true });
await writeFile(join(root, 'capture', 'explore-diagnostics-42-2-duo-open', 'explore-diagnostics', 'error.json'), JSON.stringify({ code: 'ARGENT_TOOL_FAILED', stage: 'session',
message: 'fold: argent run fold failed: [Tool:fold] Service dependency failed', nextAction: 'Rerun the capture.', retryable: false, target: 'duo-open' }));
let comments = [{ id: 5, user: { login: 'github-actions[bot]' }, body }];
const transport = async (input, init = {}) => {
const url = new URL(input);
if (url.pathname === '/repos/expo/explore-playground/pulls/1') return Response.json({ state: 'open', draft: false, title: pullRequest.title, html_url: pullRequest.url,
base: { ref: 'main', sha: baseSha, repo: { id: 1, full_name: pullRequest.repository } }, head: { ref: pullRequest.head.ref, sha: headSha, repo: { full_name: pullRequest.repository } } });
if (url.pathname === '/repos/expo/explore-playground/issues/1/comments') return Response.json(comments);
if (url.pathname === '/repos/expo/explore-playground/issues/comments/5' && init.method === 'PATCH') {
comments = [{ ...comments[0], body: JSON.parse(init.body).body }]; return Response.json({ id: 5 });
}
throw new Error(`unexpected request ${init.method ?? 'GET'} ${url}`);
};
assert.deepEqual(await publishFailureComment({ repository: pullRequest.repository, pullNumber: 1, headSha, baseSha, runId: '42', runAttempt: '2', diagnosticsPath: root,
environment: { GITHUB_TOKEN: 'test-token' }, transport }), { posted: true });
const final = comments[0].body;
assert.doesNotMatch(visible(final), /New run in progress|New run failed/);
assert.equal(readCommentRecords(final).previous, undefined, "attempt 1's records go once every target of attempt 2 finished");
const records = readCommentRecords(final).current;
assert.deepEqual(targets.map(target => [records[target.id].runAttempt, records[target.id].phase]),
[['2', 'ready'], ['2', 'ready'], ['2', 'failed'], ['2', 'ready'], ['2', 'ready']]);
assert.match(statusOf(final, 'iPhone Duo \\(open\\)'), /^\*\*iPhone Duo \\\(open\\\) failed\*\* · session · ARGENT\\_TOOL\\_FAILED\\: fold\\: argent run fold failed/);
// Each published target links its report; the failure's record is the newest, so it sets the updated time.
assert.ok(subtitleOf(final).startsWith(`<sub>[iPhone 17](<${reportUrl}>) · [iPhone Duo \\(closed\\)](<${reportUrl}>) · iPhone Duo \\(open\\) · [Pixel 7](<${reportUrl}>) · [Pixel 7 \\(dark\\)](<${reportUrl}>) · ${commits} · updated `), subtitleOf(final));
assert.equal(titleOf(final), `### 3 screens changed · [Review in Explore](<${reportUrl}>)`);
});
test('a comment written by a per-platform version keeps parsing, and malformed target records are dropped', async () => {
const { platformSectionMerge, readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
const { encodeRecordPayload } = await import('../../dist/report/pr-comment-record.js');
@@ -917,16 +796,3 @@ test('an excluded route is neither listed nor counted as an app-wide screen', ()
const body = renderPublicComment(state({ review: review([...evidenceReview().surfaces, excluded]) }));
assert.doesNotMatch(body, /\/channel|App-wide source changes|not compared/);
});
test('an excluded route that is new is not one of the changed screens, nor of the ones the list links to', () => {
const screens = Array.from({ length: 11 }, (_, index) => surface(`screen-${index}`, 'modified', { extra: {
review: { status: 'modified', description: `Changed ${index}` },
visual: { verdict: 'modified', reason: 'repeated-cross-build-delta', mismatchPercentage: 1, threshold: 0.1, tool: '[email protected]' },
} }));
const excluded = surface('channel', 'added', { route: '/c/[channel]', extra: { excluded: true } });
for (const key of ['baseImage', 'headImage', 'baseOutcome', 'headOutcome']) delete excluded[key];
const body = renderPublicComment(state({ review: review([...screens, excluded]) }));
assert.equal(titleOf(body), `### 11 screens changed · [Review in Explore](<${reportUrl}>)`);
assert.equal(listOf(body).at(-1), `- [1 more screen in the report](<${reportUrl}>)`);
assert.doesNotMatch(body, /\/c\/\[channel\]/);
});
@@ -320,15 +320,3 @@ test("an excluded surface carries no capture evidence", () => {
excluded.surfaces[1].excluded = false;
assert.throws(() => assertPublicReview(excluded), /excluded surface carries capture evidence/);
});
test("a review says its change is off-screen only on a modified verdict whose screenshots match", () => {
const offScreen = (status, verdict) => {
const input = review();
input.surfaces[0].review = { status, description: status === "modified" ? "Added text “lanes you add next”." : "No visible change", offScreen: true };
input.surfaces[0].visual = { verdict, reason: verdict === "unchanged" ? "matched" : "repeated-cross-build-delta", mismatchPercentage: verdict === "unchanged" ? 0 : 3, threshold: 0.1, tool: "[email protected]" };
return input;
};
assert.doesNotThrow(() => assertPublicReview(offScreen("modified", "unchanged")));
assert.throws(() => assertPublicReview(offScreen("modified", "modified")), /inconsistent/);
assert.throws(() => assertPublicReview(offScreen("unchanged", "unchanged")), /inconsistent/);
});
+7 -162
View File
@@ -13,13 +13,6 @@ const { presentScreensByPath, presentBuildDiff } = await tsImport(
const { artifactUrl, indexMap } = await tsImport("../../viewer/src/utils/model.ts", import.meta.url);
const { primaryScreenshotForScreen } = await tsImport("../../viewer/src/utils/screen-images.ts", import.meta.url);
const { buildObservedGraph, buildViewerGraph, projectFullGraph } = await tsImport("../../viewer/src/utils/graph-model.ts", import.meta.url);
const { omittedScreenIds, omittedSourceScreenIds, reportScreens, withoutOmittedScreens } = await tsImport("../../viewer/src/utils/omitted-screens.ts", import.meta.url);
const { reviewChanges } = await import("../../dist/report/pr-comment-body.js");
const { neverCapturedSurfaceIds } = await tsImport("../../src/contracts/surface-capture.ts", import.meta.url);
const { buildSearchItems } = await tsImport("../../viewer/src/utils/search.ts", import.meta.url);
/** The Map as the Viewer draws a map without a comparison: its own screens, less the ones it never captured. */
const viewerGraph = (map, index = indexMap(map)) => buildViewerGraph(map, index, omittedScreenIds(map));
function entry(id, route, variant = "default", extra = {}) {
return {
@@ -131,10 +124,10 @@ test("source navigation projects directional context and route variants without
assert.equal(payload.coverage.transitions, 0);
for (const collection of ["transitions", "actionAttempts", "journeys"]) assert.deepEqual(payload.map[collection], []);
assert.equal(buildObservedGraph(payload.map, indexMap(payload.map)).groups.length, 0);
const graph = viewerGraph(payload.map);
assert.deepEqual(graph.screens.map(screen => screen.id).sort(), ["camera-alias", "games-free", "games-pro", "scan-breed", "scan-mood"]);
assert.equal(graph.groups.length, 2);
assert.ok(graph.groups.every(group => group.transitionIds.length === 0 && group.sourceEdges.length > 0));
const viewerGraph = buildViewerGraph(payload.map, indexMap(payload.map));
assert.deepEqual(viewerGraph.screens.map(screen => screen.id).sort(), ["camera-alias", "games-free", "games-pro", "scan-breed", "scan-mood"]);
assert.equal(viewerGraph.groups.length, 2);
assert.ok(viewerGraph.groups.every(group => group.transitionIds.length === 0 && group.sourceEdges.length > 0));
const presentation = presentScreensByPath(payload.map);
const scan = presentation.map.screens.find(screen => screen.route === "/scan/instruction");
assert.equal(scan.variantIds.length, 2);
@@ -146,7 +139,7 @@ test("source navigation projects directional context and route variants without
test("public map omits redirects and unselected changes routes while retaining selected failures", () => {
const review = verifyImages(fixture("changes"));
const current = workspaceSides(publicReviewToWorkspace(review)).current;
const graph = viewerGraph(current.map);
const graph = buildViewerGraph(current.map, indexMap(current.map));
assert.deepEqual(graph.screens.map(screen => screen.id).sort(), ["care-guide", "games-free"]);
assert.equal(current.map.screens.length, 7, "the published source inventory remains available");
@@ -156,7 +149,7 @@ test("public map omits redirects and unselected changes routes while retaining s
status: "failed", attempts: 1, landing: "unverified", reason: "Capture failed",
};
const failedMap = workspaceSides(publicReviewToWorkspace(failed)).current.map;
const failedGraph = viewerGraph(failedMap);
const failedGraph = buildViewerGraph(failedMap, indexMap(failedMap));
assert.equal(failedGraph.screens.some(screen => screen.id === "scan-mood"), true);
assert.equal(failedGraph.screens.some(screen => screen.id === "home"), false);
});
@@ -840,7 +833,7 @@ test("an excluded route leaves the map with an accepted gap, like a redirect", (
excluded.excluded = true;
for (const side of ["base", "head"]) { delete excluded[`${side}Image`]; delete excluded[`${side}Outcome`]; }
const { current } = workspaceSides(publicReviewToWorkspace(review));
const graph = viewerGraph(current.map);
const graph = buildViewerGraph(current.map, indexMap(current.map));
assert.equal(graph.screens.some(screen => screen.id === "games-pro"), false, "never captured, so not a card on the map");
assert.ok(current.map.screens.some(screen => screen.id === "games-pro"), "the inventory still knows the route");
const gap = current.map.gaps.find(gap => gap.screenId === "games-pro");
@@ -892,151 +885,3 @@ test("a screen's note is its first open gap of any kind, and an accepted gap onl
assert.equal(indexMap({ ...current.map, gaps: [resolved, accepted] }).screenNotes.get("games-free"), accepted.message);
assert.equal(indexMap({ ...current.map, gaps: [resolved] }).screenNotes.has("games-free"), false);
});
/** What the Viewer leaves out of a review and the comparison it then shows, computed as app.tsx does. */
function viewerOmission(review) {
const workspace = publicReviewToWorkspace(review);
const diff = diffFor(review);
const presentation = presentScreensByPath(diff.map);
const omitted = omittedScreenIds(diff.map, { diff, presentation });
const presented = presentBuildDiff(diff, presentation);
// The surfaces the Viewer leaves out, before path grouping: a removed screen goes back to its surface id.
const removed = new Map(review.surfaces.map(surface => [removedScreenId(workspace.catalog.defaultBaselineBuildId, surface.id), surface.id]));
const surfaces = new Set([...omittedSourceScreenIds(diff.map, diff)].map(id => removed.get(id) ?? id));
return { diff, presentation, omitted, presented, shown: withoutOmittedScreens(presented, omitted), surfaces,
graph: buildViewerGraph(presentation.map, presentation.index, omitted) };
}
test("a public report's never-captured routes are not its screens anywhere; a captured screen and a local map keep theirs", () => {
const review = verifyImages(fixture());
// A new route named in exploration.exclude, and a route that was a redirect and is now a captured screen.
review.surfaces.push({ id: "channel", status: "added", excluded: true, base: null, head: entry("channel", "/c/[channel]") });
const nowCaptured = review.surfaces.find(surface => surface.id === "games-pro");
nowCaptured.status = "modified";
nowCaptured.base = entry("games-pro", "/games", "pro", { kind: "redirect", redirectTo: "/games" });
delete nowCaptured.baseImage; delete nowCaptured.baseOutcome;
const { presentation, presented, omitted, shown, graph } = viewerOmission(review);
assert.equal(presented.screens.get("channel").status, "added", "the comparison alone would count it as a change");
assert.deepEqual([...omitted].sort(), ["channel", "home"], "the excluded route and the redirect; the route captured now stays");
assert.deepEqual(reportScreens(presentation.map.screens, omitted).map(screen => screen.id).sort(),
graph.screens.map(screen => screen.id).sort(), "Screens lists what the Map draws");
assert.deepEqual(buildSearchItems({ screens: reportScreens(presentation.map.screens, omitted) }).filter(item => omitted.has(item.screenId)), []);
assert.deepEqual([...shown.screens.keys()].filter(id => omitted.has(id)), []);
assert.equal(shown.counts.added, presented.counts.added - 1);
assert.equal(shown.counts["not-compared"], presented.counts["not-compared"] - 1);
assert.equal(Object.values(shown.counts).reduce((sum, count) => sum + count, 0), shown.screens.size);
assert.ok(shown.index.screens.has("channel"), "a link to it still opens it");
assert.equal(shown.index.screenNotes.get("channel"), "Excluded by exploration.exclude; never captured");
// A captured route whose excluded variant joins it on one card stays on the Map and in Screens.
const variants = navigationReview();
const pro = variants.surfaces.find(surface => surface.id === "games-pro");
pro.excluded = true;
for (const side of ["base", "head"]) { delete pro[`${side}Image`]; delete pro[`${side}Outcome`]; }
const { current } = workspaceSides(publicReviewToWorkspace(variants));
const family = presentScreensByPath(current.map);
const familyOmitted = omittedScreenIds(current.map, { presentation: family });
const games = family.map.screens.find(screen => screen.route === "/games");
assert.equal(games.variantIds.length, 2);
assert.ok(reportScreens(family.map.screens, familyOmitted).includes(games));
assert.ok(buildViewerGraph(family.map, family.index, familyOmitted).screens.includes(games));
// A local map with the same gaps lists every screen.
const diff = diffFor(review);
const local = { ...diff.map, run: { ...diff.map.run, id: "local-run" } };
assert.equal(omittedScreenIds(local, { diff, presentation: presentScreensByPath(local) }).size, 0);
});
test("an open capture gap keeps a screen that also has an accepted one, from the baseline or from a sibling", () => {
// `/scan/camera` was a redirect and is now a screen whose capture failed: the comparison retargets the baseline's
// accepted redirect gap onto it, beside the head's open failure.
const redirected = verifyImages(fixture());
const camera = redirected.surfaces.find(surface => surface.id === "camera-alias");
camera.status = "modified";
camera.base = entry("camera-alias", "/scan/camera?action=mood", "mood", { kind: "redirect", redirectTo: "/games" });
delete camera.baseImage; delete camera.baseOutcome; delete camera.headImage;
camera.headOutcome = { status: "failed", attempts: 2, landing: "unverified", reason: "timeout" };
const baseline = viewerOmission(redirected);
assert.deepEqual(baseline.diff.map.gaps.filter(gap => gap.screenId === "camera-alias").map(gap => gap.status).sort(), ["accepted", "open"]);
assert.equal(baseline.omitted.has("camera-alias"), false);
assert.equal(baseline.shown.screens.get("camera-alias").status, "unavailable");
assert.equal(baseline.shown.counts.unavailable, 1, "the failed capture is still counted");
assert.ok(baseline.graph.screens.some(screen => screen.id === "camera-alias"));
assert.equal(neverCapturedSurfaceIds(redirected).has("camera-alias"), false);
// `/games` free's capture failed and `/games` pro is excluded: both gaps land on the one `/games` card.
const sibling = verifyImages(fixture());
const pro = sibling.surfaces.find(surface => surface.id === "games-pro");
pro.excluded = true;
for (const side of ["base", "head"]) { delete pro[`${side}Image`]; delete pro[`${side}Outcome`]; }
const free = sibling.surfaces.find(surface => surface.id === "games-free");
delete free.headImage;
free.headOutcome = { status: "failed", attempts: 2, landing: "unverified", reason: "timeout" };
const merged = viewerOmission(sibling);
assert.equal(merged.omitted.has("games-free"), false);
assert.equal(merged.shown.screens.get("games-free").status, "unavailable");
assert.equal(merged.shown.counts.unavailable, 1);
assert.ok(merged.surfaces.has("games-pro"), "the excluded variant itself is still never captured");
assert.equal(merged.surfaces.has("games-free"), false);
});
test("a removed screen keeps its card when the route that replaces it on the same path is a redirect or excluded", () => {
for (const replacement of [
{ kind: "redirect", entry: entry("sweet-bee-new", "/games/sweet-bee", "default", { kind: "redirect", redirectTo: "/games" }) },
{ kind: "excluded", entry: entry("sweet-bee-new", "/games/sweet-bee"), excluded: true },
]) {
const review = verifyImages(fixture());
review.surfaces.push({ id: "sweet-bee-new", status: "added", base: null, head: replacement.entry,
...(replacement.excluded ? { excluded: true } : {}) });
const { omitted, shown, graph, surfaces, presentation } = viewerOmission(review);
const card = presentation.representativeIdByScreenId.get("sweet-bee-new");
assert.equal(omitted.has(card), false, `${replacement.kind}: the removed screen's capture keeps the card`);
assert.ok(shown.screens.get(card)?.beforeScreenshot, `${replacement.kind}: Compare and Changes keep the removed screenshot`);
assert.ok(graph.screens.some(screen => screen.id === card));
assert.ok(surfaces.has("sweet-bee-new"), `${replacement.kind}: the replacement on its own is never captured`);
assert.equal(surfaces.has("sweet-bee"), false);
assert.equal(reviewChanges(review).get("sweet-bee"), "removed", "the comment lists the removal the Viewer shows");
}
});
test("a captured screen that becomes a redirect keeps its card and its screenshot from before", () => {
const review = verifyImages(fixture());
const camera = review.surfaces.find(surface => surface.id === "camera-alias");
camera.status = "modified";
camera.head = entry("camera-alias", "/scan/camera?action=mood", "mood", { kind: "redirect", redirectTo: "/games" });
delete camera.headImage; delete camera.headOutcome;
const { omitted, shown, graph, surfaces } = viewerOmission(review);
assert.equal(omitted.has("camera-alias"), false);
assert.ok(shown.screens.get("camera-alias").beforeScreenshot);
assert.ok(graph.screens.some(screen => screen.id === "camera-alias"));
assert.equal(surfaces.has("camera-alias"), false);
assert.equal(neverCapturedSurfaceIds(review).has("camera-alias"), false);
});
test("the Viewer leaves out exactly the surfaces the PR comment skips", () => {
const review = verifyImages(fixture());
review.surfaces.push(
{ id: "channel", status: "added", excluded: true, base: null, head: entry("channel", "/c/[channel]") },
{ id: "old-start", status: "removed", base: entry("old-start", "/start", "default", { kind: "redirect", redirectTo: "/games" }), head: null },
{ id: "sweet-bee-new", status: "added", base: null, head: entry("sweet-bee-new", "/games/sweet-bee", "default", { kind: "redirect", redirectTo: "/games" }) },
);
const camera = review.surfaces.find(surface => surface.id === "camera-alias");
camera.head = entry("camera-alias", "/scan/camera?action=mood", "mood", { kind: "redirect", redirectTo: "/games" });
camera.status = "modified";
delete camera.headImage; delete camera.headOutcome;
const skipped = neverCapturedSurfaceIds(review);
assert.deepEqual([...skipped].sort(), ["channel", "home", "old-start", "sweet-bee-new"]);
assert.deepEqual([...viewerOmission(review).surfaces].sort(), [...skipped].sort());
const listed = reviewChanges(review);
for (const id of skipped) assert.equal(listed.has(id), false, `${id} is not a listed change`);
assert.equal(listed.get("care-guide"), "added");
assert.equal(listed.get("sweet-bee"), "removed");
const changes = verifyImages(fixture("changes"));
assert.deepEqual([...viewerOmission(changes).surfaces].sort(), [...neverCapturedSurfaceIds(changes)].sort());
const navigated = navigationReview();
assert.deepEqual([...viewerOmission(navigated).surfaces].sort(), [...neverCapturedSurfaceIds(navigated)].sort());
assert.ok(neverCapturedSurfaceIds(navigated).size > 0);
});
-4
View File
@@ -113,10 +113,6 @@ test("the palette's commands follow the canvas: Compare steps changes with the a
assert.ok(!ids(compare).includes("go:compare"));
assert.ok(ids(compare).includes("go:map"));
// Full screen, where the browser has it, prints F; without it there is no command.
assert.equal(commandItems({ ...base, canvas: "map", fullscreen: false }, actions).find((item) => item.id === "command:view:fullscreen").shortcut, "F");
assert.ok(!ids(map).includes("view:fullscreen"));
// A phone has no keyboard shortcuts to list.
assert.ok(ids(map).includes("go:shortcuts"));
assert.ok(!ids(commandItems({ ...base, canvas: "map", phone: true }, actions)).includes("go:shortcuts"));
-8
View File
@@ -70,11 +70,3 @@ test("⌥1–⌥8 open a target by its place, with ⌥ alone; D and ` are plain
assert.ok(matchesShortcut(key("KeyD"), SHORTCUTS.target.menu));
assert.ok(matchesShortcut(key("Backquote"), SHORTCUTS.target.last));
});
test("F is full screen, a plain key: ⌘F stays the browser's find", () => {
assert.equal(formatShortcut(SHORTCUTS.view.fullscreen, true), "F");
assert.ok(matchesShortcut(key("KeyF"), SHORTCUTS.view.fullscreen));
assert.ok(!matchesShortcut(key("KeyF", { metaKey: true }), SHORTCUTS.view.fullscreen));
assert.ok(!matchesShortcut(key("KeyF", { ctrlKey: true }), SHORTCUTS.view.fullscreen));
assert.ok(!matchesShortcut(key("KeyF", { shiftKey: true }), SHORTCUTS.view.fullscreen));
});
-37
View File
@@ -38,40 +38,3 @@ test("link schemes are approved once each, lowercased, never http or https, and
assert.deepEqual(approveSessionUrlSchemes(none.eas, "session-1", new Set(), "dev.example.app", ["example"]), []);
assert.equal(none.calls.length, 0);
});
// The host can fail an action once, as `app.approveUrlScheme` did in its `simctl spawn … defaults write` (euxy run 39348933440).
function flakyEas(failures) {
const calls = [];
const eas = args => {
calls.push(args);
if (calls.length <= failures) throw new Error("eas simulator:control exited with status 1: The simulator could not run app.approveUrlScheme");
return { stdout: "{}" };
};
return { calls, eas };
}
test("an action that fails once is sent again after a pause", () => {
const { calls, eas } = flakyEas(1);
const pauses = [];
simulatorControl(eas, "session-1", "app.approveUrlScheme", ["dev.example.app", "example"], { sleep: milliseconds => pauses.push(milliseconds) });
assert.equal(calls.length, 2);
assert.deepEqual(calls[1], calls[0]);
assert.equal(pauses.length, 1);
});
test("an action that keeps failing throws EAS's reason after its last attempt, with no pause after it", () => {
const { calls, eas } = flakyEas(Infinity);
const pauses = [];
assert.throws(() => simulatorControl(eas, "session-1", "app.approveUrlScheme", ["dev.example.app", "example"], { sleep: milliseconds => pauses.push(milliseconds) }),
/could not run app\.approveUrlScheme/);
assert.equal(calls.length, 3);
assert.equal(pauses.length, calls.length - 1);
assert.ok(pauses.every(milliseconds => milliseconds > 0 && milliseconds <= 10_000));
});
test("a link scheme the host fails to approve once is approved on the next attempt", () => {
const { calls, eas } = flakyEas(1);
const approved = approveSessionUrlSchemes(eas, "session-1", new Set(["app.approveUrlScheme"]), "dev.example.app", ["example"], { sleep: () => {} });
assert.deepEqual(approved, ["example"]);
assert.equal(calls.length, 2);
});
+2 -33
View File
@@ -133,14 +133,11 @@ test("report export rejects path traversal and symlink images from downloaded ev
});
function transportFixture({ stale = false, expired = false, artifactName = "explore-review-10-1", artifactRun = 10, attempt = 1,
status, headers, artifactNotFound = 0 } = {}) {
status, headers } = {}) {
const calls = [];
let artifactLookups = 0;
const transport = async (input, options = {}) => {
const url = new URL(input); calls.push({ url, options });
if (status) return new Response("private-upstream-error", { status, headers });
// GitHub can answer 404 for an artifact its run uploaded moments ago (euxy run 39348956443).
if (url.pathname.endsWith("/actions/artifacts/20") && (artifactLookups += 1) <= artifactNotFound) return new Response("Not Found", { status: 404 });
if (url.pathname.endsWith("/actions/artifacts/20")) return Response.json({ id: 20, name: artifactName, expired, workflow_run: { id: artifactRun } });
if (url.pathname.endsWith("/actions/runs/10/attempts/1")) return Response.json({ id: 10, run_attempt: attempt, status: "in_progress", conclusion: null });
if (url.pathname.endsWith("/pulls/1")) return Response.json({ state: "open", base: pr.base,
@@ -194,8 +191,7 @@ test("report publication separates credential, permission, rate limit, and servi
[503, {}, "GITHUB_REQUEST_FAILED", true, /service status/],
]) {
const { transport, calls } = transportFixture({ status, headers });
const pauses = [];
await assert.rejects(publishCiReportComment({ inputPath, artifactUrl, environment, transport, sleep: async milliseconds => { pauses.push(milliseconds); } }), error => {
await assert.rejects(publishCiReportComment({ inputPath, artifactUrl, environment, transport }), error => {
assert.equal(error.code, code);
assert.equal(error.stage, "publication");
assert.equal(error.retryable, retryable);
@@ -204,36 +200,9 @@ test("report publication separates credential, permission, rate limit, and servi
return true;
});
assert.equal(calls.some(call => call.options.method === "POST"), false);
// Only a 5xx is looked up again; a bad token, a missing permission and a rate limit fail on the first answer.
assert.equal(calls.length, status >= 500 ? 5 : 1, `${status} ${JSON.stringify(headers)}`);
assert.equal(pauses.length, calls.length - 1);
}
});
test("an artifact GitHub does not list yet is looked up again, and one it never lists keeps the not-found failure", async t => {
const { inputPath } = await fixture(t);
const late = transportFixture({ artifactNotFound: 1 });
const pauses = [];
await publishCiReportComment({ inputPath, artifactUrl, environment, transport: late.transport, sleep: async milliseconds => { pauses.push(milliseconds); } });
assert.equal(late.calls.filter(call => call.url.pathname.endsWith("/actions/artifacts/20")).length, 2);
assert.equal(pauses.length, 1);
assert.ok(late.calls.some(call => call.options.method === "POST"), "the comment is published once the artifact is found");
const missing = transportFixture({ artifactNotFound: Infinity });
const waited = [];
await assert.rejects(publishCiReportComment({ inputPath, artifactUrl, environment, transport: missing.transport, sleep: async milliseconds => { waited.push(milliseconds); } }), error => {
assert.equal(error.code, "GITHUB_RESOURCE_NOT_FOUND");
assert.equal(error.message, "Report publication GitHub check failed (404)");
assert.match(error.nextAction, /artifact ID/);
return true;
});
assert.equal(missing.calls.length, 5);
assert.equal(waited.length, 4, "no pause after the last lookup");
const total = waited.reduce((sum, milliseconds) => sum + milliseconds, 0);
assert.ok(total >= 30_000 && total <= 60_000, `${total} ms of pauses`);
assert.equal(missing.calls.some(call => call.options.method === "POST"), false);
});
test("stale PRs, expired artifacts, foreign artifacts, and replayed attempts cannot announce Ready", async t => {
const { inputPath } = await fixture(t);
const moved = transportFixture({ stale: true });
-13
View File
@@ -97,16 +97,3 @@ test("accessibility fingerprints ignore Android system UI nodes", async () => {
assert.equal(sameApp.accessibility, base.accessibility);
assert.notEqual(changedApp.accessibility, base.accessibility);
});
test("accessibility fingerprints are versioned, and leave out the system keyboard and which field has the focus", async () => {
const snapshot = (focused, keyboard) => JSON.stringify({ success: true, data: { nodes: [
{ index: 0, type: "Application", label: "euxy", rect: { x: 0, y: 0, width: 402, height: 874 } },
{ index: 1, parentIndex: 0, type: "TextField", label: "Pattern name", ...(focused ? { focused: true } : {}), rect: { x: 23, y: 386, width: 355, height: 50 } },
...(keyboard ? [{ index: 2, parentIndex: 0, type: "Keyboard", rect: { x: 0, y: 583, width: 402, height: 233 } },
{ index: 3, parentIndex: 2, type: "Key", label: "Q", rect: { x: 5, y: 590, width: 39, height: 54 } }] : []),
] } });
const resting = await fingerprintState({ snapshotText: snapshot(false, false) });
assert.match(resting.accessibility, /^a2:[0-9a-f]{64}$/);
assert.equal((await fingerprintState({ snapshotText: snapshot(true, false) })).accessibility, resting.accessibility, "focus alone does not change the tree");
assert.equal((await fingerprintState({ snapshotText: snapshot(true, true) })).accessibility, resting.accessibility, "nor does the keyboard");
});
+3 -71
View File
@@ -67,7 +67,7 @@ test("baseline restore rejects foreign workflows, revisions, branches, and unfin
event: "push", head_repository: { full_name: "acme/app" } };
const mutations = [
{ workflow_id: 99 }, { head_sha: "b".repeat(40) }, { head_branch: "feature" },
{ conclusion: null }, { conclusion: "cancelled" }, { head_repository: { full_name: "fork/app" } }, { event: "pull_request_target" },
{ conclusion: null }, { head_repository: { full_name: "fork/app" } }, { event: "pull_request_target" },
];
const runs = Object.fromEntries(mutations.map((mutation, i) => [i + 30, { ...valid, ...mutation, id: i + 30 }]));
runs[20] = valid;
@@ -90,20 +90,6 @@ test("baseline restore rejects foreign workflows, revisions, branches, and unfin
assert.deepEqual(names, [`explore-baseline-${"a".repeat(40)}-ios`, `explore-baseline-${"a".repeat(40)}`], "iOS also accepts the unsuffixed name older baselines used");
});
test("a target's baseline from a run another target's baseline failed in is still reused (brentvatne/euxy#172)", async () => {
// The baseline job uploads its artifact only after its own steps passed, so the run's failure is another target's.
const run = { id: 20, workflow_id: 77, conclusion: "failure", head_sha: "a".repeat(40), head_branch: "main", event: "push", head_repository: { full_name: "acme/app" } };
const transport = async input => {
const url = new URL(input);
if (url.pathname === "/repos/acme/app") return Response.json({ default_branch: "main" });
if (url.pathname === "/repos/acme/app/actions/workflows/explore-baseline.yml") return Response.json({ id: 77 });
if (url.pathname === "/repos/acme/app/actions/artifacts") return Response.json({ artifacts: [{ id: 20, workflow_run: { id: 20 }, expired: false }] });
if (url.pathname === "/repos/acme/app/actions/runs/20") return Response.json(run);
throw new Error(`unexpected request ${url}`);
};
assert.deepEqual(await findBaselineArtifact({ sha: "a".repeat(40), target: "iphone", environment, transport }), { id: 20, run: 20 });
});
test("a target's baseline is named after its id; only target ios also reuses the unsuffixed name", async () => {
const lookups = async target => {
const names = [];
@@ -159,19 +145,10 @@ async function reportFailure(t, { capture, report, comments = [], pr = samplePr(
const url = new URL(input);
assert.equal(init.headers?.authorization, "Bearer test-token");
if (url.pathname === "/repos/acme/app/pulls/91") return Response.json(pr);
// The comments as GitHub holds them, so a second write merges into the first.
if (url.pathname === "/repos/acme/app/issues/91/comments" && (init.method ?? "GET") === "GET") return Response.json(comments);
if (url.pathname === "/repos/acme/app/issues/91/comments" && init.method === "POST") {
const body = JSON.parse(init.body).body;
writes.push({ action: "create", body }); comments = [...comments, { id: 100, user: { login: "github-actions[bot]" }, body }];
return Response.json({ id: 100 });
}
if (url.pathname === "/repos/acme/app/issues/91/comments" && init.method === "POST") { writes.push({ action: "create", body: JSON.parse(init.body).body }); return Response.json({ id: 100 }); }
const update = /^\/repos\/acme\/app\/issues\/comments\/(\d+)$/.exec(url.pathname);
if (update && init.method === "PATCH") {
const body = JSON.parse(init.body).body;
writes.push({ action: "update", comment_id: Number(update[1]), body }); comments = comments.map(comment => comment.id === Number(update[1]) ? { ...comment, body } : comment);
return Response.json({ id: Number(update[1]) });
}
if (update && init.method === "PATCH") { writes.push({ action: "update", comment_id: Number(update[1]), body: JSON.parse(init.body).body }); return Response.json({ id: Number(update[1]) }); }
throw new Error(`unexpected request ${init.method ?? "GET"} ${url}`);
};
const result = await publishFailureComment({ repository: "acme/app", pullNumber: 91, headSha: head, baseSha: base, runId: "1234", runAttempt: "1",
@@ -319,51 +296,6 @@ test("a failed target is named by its artifact and keeps the label and config or
assert.equal(located.diagnostic.code, "APP_INPUT_MISSING");
});
test("a lone failed job's diagnostics, which download-artifact extracts without its artifact's directory, still name the target (euxy#172 attempt 1)", async t => {
// Run 39348956443 attempt 1: only duo-closed's report job failed (ci:publish's artifact lookup answered 404), so the
// failure job's pattern matched one artifact, extracted into report/ itself, and the comment said "iOS failed".
const report = { ...sampleDiagnostic(), code: "GITHUB_RESOURCE_NOT_FOUND", stage: "publication", message: "Report publication GitHub check failed (404)", target: "duo-closed" };
const [write] = await reportFailure(t, { mutateFiles: async directory => {
await mkdir(join(directory, "explore-failure", "report"), { recursive: true });
await writeFile(join(directory, "explore-failure", "report", "error.json"), JSON.stringify(report));
} });
assert.match(write.body, /^<!-- expo-explore-record:duo-closed:/m);
assert.match(write.body, /^\*\*duo\\-closed failed\*\* · publication · GITHUB\\_RESOURCE\\_NOT\\_FOUND/m);
assert.doesNotMatch(write.body, /iOS failed/);
// A capture diagnostics artifact on its own keeps its explore-diagnostics directory; a target id the file names is checked.
const [capture] = await reportFailure(t, { mutateFiles: async directory => {
await mkdir(join(directory, "explore-failure", "capture", "explore-diagnostics"), { recursive: true });
await writeFile(join(directory, "explore-failure", "capture", "explore-diagnostics", "error.json"), JSON.stringify({ ...sampleDiagnostic(), target: "duo-open" }));
} });
assert.match(capture.body, /^\*\*duo\\-open failed\*\* · capture\\-head · APP\\_INPUT\\_MISSING/m);
const [invalid] = await reportFailure(t, { mutateFiles: async directory => {
await mkdir(join(directory, "explore-failure", "report"), { recursive: true });
await writeFile(join(directory, "explore-failure", "report", "error.json"), JSON.stringify({ ...report, target: "../ios" }));
} });
assert.match(invalid.body, /^<!-- expo-explore-record:ios:/m, "an invalid target id is no target: the record falls back to ios, as before targets");
});
test("every failed target of a run gets its own failed record, and a target's report failure outranks its capture's", async t => {
const { locateFailureDiagnostics } = await import("../../dist/report/failure-comment.js");
const writes = await reportFailure(t, { mutateFiles: async directory => {
const root = join(directory, "explore-failure");
// Every capture leg uploads diagnostics; only the failed ones hold an error.json.
for (const target of ["iphone", "duo-closed", "duo-open", "android"]) await mkdir(join(root, "capture", `explore-diagnostics-1234-1-${target}`, "explore-diagnostics"), { recursive: true });
await writeFile(join(root, "capture", "explore-diagnostics-1234-1-duo-open", "explore-diagnostics", "error.json"), JSON.stringify({ ...sampleDiagnostic(), code: "CONTROLLER_READER_STUCK", stage: "session" }));
await writeFile(join(root, "capture", "explore-diagnostics-1234-1-android", "explore-diagnostics", "error.json"), JSON.stringify(sampleDiagnostic()));
await mkdir(join(root, "report", "explore-report-diagnostics-1234-1-android"), { recursive: true });
await writeFile(join(root, "report", "explore-report-diagnostics-1234-1-android", "error.json"), JSON.stringify({ ...sampleDiagnostic(), code: "REPORT_EXPORT_FAILED", stage: "export" }));
const located = await locateFailureDiagnostics(root);
assert.deepEqual(located.map(failure => [failure.target, failure.diagnostic.code]), [["android", "REPORT_EXPORT_FAILED"], ["duo-open", "CONTROLLER_READER_STUCK"]]);
} });
assert.equal(writes.length, 2);
assert.equal(writes[1].action, "update", "the second failure merges into the comment the first created");
assert.match(writes[1].body, /^\*\*Android failed\*\* · export · REPORT\\_EXPORT\\_FAILED/m);
assert.match(writes[1].body, /^\*\*duo\\-open failed\*\* · session · CONTROLLER\\_READER\\_STUCK/m);
assert.doesNotMatch(writes[1].body, /APP\\_INPUT\\_MISSING/);
assert.deepEqual(writes.result, { posted: true });
});
test("ci.trustedAuthors on the default branch admits listed authors without write access, nobody else", async t => {
const block = "app:\n bundleId: com.acme.app\nci:\n trustedAuthors:\n - devin-ai-integration[bot] # reviews\n - 'Renovate[bot]'\nreport:\n preview:\n hosting: eas\n";
const flow = "ci: # bots\n trustedAuthors: [\"devin-ai-integration[bot]\", 'renovate[bot]'] # quoted: plain scalars cannot hold [ ] in flow style\n";
+18 -38
View File
@@ -7,13 +7,12 @@ import { isEmbeddedArtifactUrl, leaseEmbeddedArtifactUrl, optionalStorage, viewe
import { REPORT_SOURCE } from "./utils/report-source";
import { CanvasToolbar } from "./components/canvas/toolbar";
import { CanvasCameraControls } from "./components/canvas/camera-controls";
import { MoreMenu } from "./components/canvas/more-menu";
import { CanvasVisibleFrameProvider } from "./components/canvas/visible-frame-provider";
import { AppLoading } from "./components/shared/app-loading";
import { ReportLoadingShell } from "./components/shared/report-loading-shell";
import { screenLabel } from "./utils/screen-path";
import { AppPill, PLATFORM_NAMES, runTargets, siblingReportUrl, targetSwitch } from "./components/panels/app-pill";
import { fullscreenSupported, useFullscreen } from "./components/panels/shell-actions";
import { useFullscreen } from "./components/panels/shell-actions";
import { getCanvasZoomState, runCanvasZoomCommand } from "./utils/canvas-zoom";
import { commandItems, suggestedCommands } from "./utils/commands";
import { changedScreens, focusCounts as countFocusStatuses, isCapturedChange, type ChangedScreen } from "./utils/changed-screens";
@@ -73,7 +72,6 @@ import {
isBlackBoxMap,
} from "./utils/graph-model";
import { buildSearchItems, suggestedSearchItems } from "./utils/search";
import { omittedScreenIds, reportScreens, withoutOmittedScreens } from "./utils/omitted-screens";
import {
presentBuildDiff,
presentScreensByPath,
@@ -385,8 +383,11 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
const revisionRef = useRef<{ runId: string; revision: number } | undefined>(undefined);
const pollingRef = useRef(false);
const theme = themePreference === "system" ? preferredSystemTheme : themePreference;
// The T key flips what is on screen, dark to light and back; only the More menu's theme switch
// (or the palette) returns to Auto.
// Auto → Dark → Light → Auto, as the button's tooltip spells out.
const toggleTheme = useCallback(() => {
setThemePreference(current => current === "system" ? "dark" : current === "dark" ? "light" : "system");
}, []);
// The T key flips what is on screen, dark to light and back; only the button returns to Auto.
const flipTheme = useCallback(() => {
setThemePreference(current => (current === "system" ? preferredSystemTheme : current) === "dark" ? "light" : "dark");
}, [preferredSystemTheme]);
@@ -1042,10 +1043,6 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
setHandoffOpen(true);
} else if (matchesShortcut(event, SHORTCUTS.appearance.theme)) {
flipTheme();
} else if (matchesShortcut(event, SHORTCUTS.view.fullscreen)) {
// The More menu and the palette offer full screen only where the browser has it.
if (phoneRef.current || !fullscreenSupported()) return;
toggleFullscreen();
} else if (matchesShortcut(event, SHORTCUTS.appearance.app)) {
// Only a report captured in both schemes has another appearance to show.
const { options, current } = appearanceRef.current;
@@ -1067,7 +1064,7 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
return () => {
window.removeEventListener("keydown", onKeyDown);
};
}, [chooseAppearance, clearSelectedScreen, flipTheme, navigate, searchOpen, selectCanvas, toggleFullscreen, toggleRightPanel]);
}, [chooseAppearance, clearSelectedScreen, flipTheme, navigate, searchOpen, selectCanvas, toggleRightPanel]);
// A side-panel row or a deep link is a "go to": the camera fits that screen and the step is
// kept. Screens inventory clicks only select in place; Map clicks also focus the chosen screen. Repeating a selected target refits it without adding history.
@@ -1199,18 +1196,11 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
() => (reviewedMap ? presentScreensByPath(reviewedMap) : undefined),
[reviewedMap],
);
// A route the report never captured is not one of its screens, so the comparison names it nowhere (omitted-screens.ts).
const omittedIds = useMemo(
() => (reviewedMap && screenPresentation
? omittedScreenIds(reviewedMap, { diff: sourceDiff, presentation: screenPresentation })
: new Set<string>()),
[reviewedMap, screenPresentation, sourceDiff],
);
const diff = useMemo(
() => (sourceDiff && screenPresentation
? withoutOmittedScreens(presentBuildDiff(sourceDiff, screenPresentation), omittedIds)
? presentBuildDiff(sourceDiff, screenPresentation)
: undefined),
[omittedIds, screenPresentation, sourceDiff],
[screenPresentation, sourceDiff],
);
// The Screens page says which screens changed in an appearance other than the one shown.
const changedElsewhere = useMemo(() => {
@@ -1230,9 +1220,7 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
comparison: filterComparisonAppearance(wholeComparison, otherScope),
...(wholeReview ? { review: filterReviewAppearance(wholeReview, otherScope) } : {}),
});
const otherPresentation = presentScreensByPath(otherDiff.map);
const presented = withoutOmittedScreens(presentBuildDiff(otherDiff, otherPresentation),
omittedScreenIds(otherDiff.map, { diff: otherDiff, presentation: otherPresentation }));
const presented = presentBuildDiff(otherDiff, presentScreensByPath(otherDiff.map));
for (const [id, entry] of presented.screens) {
if (["modified", "added", "removed"].includes(entry.status)) changed.set(id, [...(changed.get(id) ?? []), option]);
}
@@ -1270,10 +1258,9 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
: !baseline ? "This report has no baseline build to compare against."
: !diff ? "The baseline is still loading."
: "No screen looks different from the baseline.";
// Search finds the report's screens, as Screens lists them; a link to one it never captured still opens it.
const searchIndex = useMemo(
() => map ? buildSearchItems({ screens: reportScreens(map.screens, omittedIds) }) : [],
[map, omittedIds],
() => map ? buildSearchItems({ screens: map.screens }) : [],
[map],
);
const openChangedScreen = useCallback((screenId: string) => {
const current = routeRef.current;
@@ -1587,7 +1574,7 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
theme: themePreference,
appearances: appearances.length > 1 ? appearances.map((option) => ({ id: option, label: appearanceLabel(option), current: option === appearance })) : [],
inspector: phone || comparingScreens ? undefined : { open: !rightCollapsed },
fullscreen: !phone && fullscreenSupported() ? fullscreen : undefined,
fullscreen: !phone && typeof document.documentElement.requestFullscreen === "function" ? fullscreen : undefined,
targets: (() => {
const run = runTargets(map.run);
const noun = run.targets.every((target) => target.id === target.platform) ? "platform" as const : "device" as const;
@@ -1645,7 +1632,6 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
index={index}
diff={diff}
routeFiles={routeFiles}
omittedScreenIds={omittedIds}
changedElsewhere={changedElsewhere}
selectedScreenId={selectedScreenId}
{...(focusRequest ? { focusRequest } : {})}
@@ -1698,7 +1684,6 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
direction="TB"
focus={focusFilter}
projectionFitKey={mapProjectionFitKey}
omittedScreenIds={omittedIds}
{...(diff ? { diff } : {})}
{...(selectedScreenId ? { selectedScreenId } : {})}
{...(focusRequest ? { focusRequest } : {})}
@@ -1707,8 +1692,10 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
/>
)}
</div>
{/* Top right holds the camera only, so only the Map has anything there. */}
{phone || route.canvas !== "map" ? null : <CanvasCameraControls />}
{phone ? null : (
<CanvasCameraControls inspectorCollapsed={comparing ? false : rightCollapsed} theme={theme} themePreference={themePreference} onToggleTheme={toggleTheme}
camera={route.canvas === "map"} />
)}
{phone ? (
<PhoneTabBar
canvas={route.canvas}
@@ -1719,13 +1706,7 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
canvas={route.canvas}
searchOpen={searchOpen}
{...(handoffAction ? { actions: handoffAction } : {})}
more={<MoreMenu
themePreference={themePreference}
onChangeTheme={setThemePreference}
{...(fullscreenSupported() ? { fullscreen: { active: fullscreen, onToggle: toggleFullscreen } } : {})}
{...(comparingScreens ? {} : { inspector: { open: !rightCollapsed, onToggle: toggleRightPanel } })}
onOpenShortcuts={() => setShortcutsOpen(true)}
/>}
onOpenShortcuts={() => setShortcutsOpen(true)}
onSelectCanvas={selectCanvas}
onOpenSearch={() => setSearchOpen(true)}
/>}
@@ -1733,7 +1714,6 @@ const ViewerApp = memo(function ViewerApp({ reportKey }: { reportKey: number })
{shortcutsOpen ? (
<ShortcutsDialog
context={{ canvas: route.canvas, review: reviewingInSidebar, hasChanges: compareOrder.length > 0, handoff: Boolean(handoffInput), appearances: appearances.length > 1,
fullscreen: !phone && fullscreenSupported(),
...(switchTargets ? { targets: switchTargets } : {}) }}
onClose={() => setShortcutsOpen(false)}
/>
@@ -6,9 +6,20 @@ import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
import { KeyHint } from "../shared/key-hint";
import { Menu, type MenuItem } from "../shared/menu";
import { Tooltip } from "../shared/tooltip";
import { FullscreenToggleButton, ThemeToggleButton, type ShellActionsProps, type ShellTheme } from "../panels/shell-actions";
import { useCanvasVisibleFrame } from "./visible-frame-provider";
import { setFollowSelection, useFollowSelection } from "../../utils/follow-selection";
type CanvasCameraControlsProps = {
/** Makes room for the collapsed inspector controls at the window edge. */
inspectorCollapsed: boolean;
theme: ShellTheme;
themePreference: ShellActionsProps["themePreference"];
onToggleTheme: () => void;
/** Fit, center and zoom act on a canvas; a page (Screens) or Compare shows only the page actions. */
camera?: boolean;
};
const CAMERA_CONTROLS_MINIMUM_FRAME_WIDTH = 240;
function ZoomControl() {
@@ -103,11 +114,11 @@ function RecenterControl() {
}
/**
* Camera actions belong to the canvas, not to either inspector panel: fit, center and the zoom
* level, top right on the Map. Screens and Compare have no camera, so nothing renders there; the
* page-wide theme and full screen live in the bottom bar's "More" menu.
* Camera actions belong to the canvas, not to either inspector panel. The page-level theme and
* full screen actions share the toolbar, so it stays in one place whether the inspector is open
* or not.
*/
export function CanvasCameraControls() {
export function CanvasCameraControls({ inspectorCollapsed, theme, themePreference, onToggleTheme, camera = true }: CanvasCameraControlsProps) {
const { visibleFrame } = useCanvasVisibleFrame();
if (visibleFrame && visibleFrame.width < CAMERA_CONTROLS_MINIMUM_FRAME_WIDTH) return null;
const style = visibleFrame ? ({
@@ -115,12 +126,24 @@ export function CanvasCameraControls() {
} as CSSProperties) : undefined;
return (
<div className="canvas-camera-controls" style={style} role="group" aria-label="Canvas camera controls">
<div
className={`canvas-camera-controls${inspectorCollapsed ? " inspector-collapsed" : ""}`}
style={style}
role="group"
aria-label="Canvas camera controls">
<div className="canvas-camera-controls-inner">
<FitControl />
<RecenterControl />
<span className="camera-control-divider" aria-hidden="true" />
<ZoomControl />
{camera ? (
<>
<FitControl />
<span className="camera-control-divider" aria-hidden="true" />
<RecenterControl />
<span className="camera-control-divider" aria-hidden="true" />
<ZoomControl />
<span className="camera-control-divider" aria-hidden="true" />
</>
) : null}
<ThemeToggleButton theme={theme} themePreference={themePreference} onToggleTheme={onToggleTheme} className="camera-action-button" />
<FullscreenToggleButton className="camera-action-button" />
</div>
</div>
);
-180
View File
@@ -1,180 +0,0 @@
import { useCallback, useId, useRef, useState, type KeyboardEvent, type ReactNode } from "react";
import { Check, Ellipsis, Keyboard, Maximize, Minimize, Monitor, Moon, PanelRight, Sun } from "lucide-react";
import { Menu } from "../shared/menu";
import { Tooltip } from "../shared/tooltip";
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
import type { ThemePreference } from "../../utils/navigation";
const THEME_OPTIONS: { id: ThemePreference; label: string; title: string; icon: ReactNode }[] = [
{ id: "system", label: "Auto", title: "Auto (system)", icon: <Monitor /> },
{ id: "light", label: "Light", title: "Light", icon: <Sun /> },
{ id: "dark", label: "Dark", title: "Dark", icon: <Moon /> },
];
export type MoreMenuProps = {
themePreference: ThemePreference;
onChangeTheme: (theme: ThemePreference) => void;
/** Full screen's state and toggle; left out where the browser has no full screen. */
fullscreen?: { active: boolean; onToggle: () => void } | undefined;
/** The Inspector's state and toggle; left out where there is no Inspector (Compare). */
inspector?: { open: boolean; onToggle: () => void } | undefined;
onOpenShortcuts: () => void;
};
/**
* The bottom bar's last button: the page-wide settings that have no place on a canvas. Every row
* reads the same way, icon, label, control and key: the Viewer's theme (Auto, Light, Dark; T
* flips light and dark), full screen (F), the Inspector (I) and the keyboard shortcuts (?).
*/
export function MoreMenu(props: MoreMenuProps) {
const [open, setOpen] = useState(false);
const buttonRef = useRef<HTMLButtonElement>(null);
const listRef = useRef<HTMLDivElement>(null);
// The menu opens on the current theme, as a choice menu opens on its current choice.
const currentThemeRef = useRef<HTMLButtonElement>(null);
const themeLabelId = useId();
const close = useCallback(() => setOpen(false), []);
// ↑ and ↓ move between rows (the theme row's stop is its current choice), ← and → between the
// three themes. Tab leaves the menu, as it does a native one. The menu's keys are its own: Esc
// and the arrows are marked used, so a canvas behind it (Compare's screens and areas) leaves them.
// ? opens the shortcuts as the row does, so the dialog hands focus back to More.
const onKeyDown = (event: KeyboardEvent<HTMLDivElement>) => {
const list = listRef.current;
if (!list) return;
if (event.key === "Tab") {
close();
return;
}
if (event.key === "Escape") {
event.preventDefault();
close();
return;
}
if (event.key === "?" && !event.metaKey && !event.ctrlKey && !event.altKey) {
event.preventDefault();
close();
props.onOpenShortcuts();
return;
}
const active = document.activeElement as HTMLElement | null;
if (event.key === "ArrowLeft" || event.key === "ArrowRight") {
event.preventDefault();
const radios = [...list.querySelectorAll<HTMLElement>('[role="menuitemradio"]')];
const at = active ? radios.indexOf(active) : -1;
if (at < 0) return;
radios[(at + (event.key === "ArrowRight" ? 1 : -1) + radios.length) % radios.length]?.focus();
return;
}
if (!["ArrowDown", "ArrowUp", "Home", "End"].includes(event.key)) return;
event.preventDefault();
const rows = [...list.querySelectorAll<HTMLElement>("[data-more-row]")];
if (rows.length === 0) return;
const at = rows.findIndex((row) => active && row.contains(active));
const next = event.key === "Home" ? 0
: event.key === "End" ? rows.length - 1
: (Math.max(at, event.key === "ArrowDown" ? -1 : 0) + (event.key === "ArrowDown" ? 1 : -1) + rows.length) % rows.length;
const row = rows[next];
const stop = row?.matches('[role="menuitem"], [role="menuitemcheckbox"]') ? row
: row?.querySelector<HTMLElement>('[aria-checked="true"]') ?? row?.querySelector<HTMLElement>('[role="menuitemradio"]');
stop?.focus();
};
return (
<>
<Tooltip label="More" placement="top" disabled={open}>
<button
ref={buttonRef}
type="button"
className={`toolbar-button${open ? " active" : ""}`}
aria-label="More"
aria-haspopup="menu"
aria-expanded={open}
onClick={() => setOpen((current) => !current)}>
<Ellipsis />
</button>
</Tooltip>
<Menu open={open} anchorRef={buttonRef} initialFocusRef={currentThemeRef} align="end" className="more-menu" onDismiss={close}>
<div ref={listRef} className="more-menu-list" role="menu" aria-label="More" onKeyDown={onKeyDown}>
<div className="more-menu-row" role="group" aria-labelledby={themeLabelId} data-more-row>
<span className="more-menu-icon" aria-hidden="true"><Moon /></span>
<span className="more-menu-label" id={themeLabelId}>Theme</span>
<span className="more-theme-switch">
{THEME_OPTIONS.map((option) => {
const checked = props.themePreference === option.id;
return (
<button
key={option.id}
ref={checked ? currentThemeRef : undefined}
type="button"
className="more-theme-option"
role="menuitemradio"
aria-checked={checked}
aria-label={option.label}
title={option.title}
tabIndex={-1}
onClick={() => props.onChangeTheme(option.id)}>
{option.icon}
</button>
);
})}
</span>
<kbd className="more-menu-key" aria-hidden="true">{formatShortcut(SHORTCUTS.appearance.theme)}</kbd>
</div>
{props.fullscreen ? (
<button
type="button"
className="more-menu-row more-menu-item"
role="menuitem"
tabIndex={-1}
aria-keyshortcuts={SHORTCUTS.view.fullscreen.key}
data-more-row
onClick={() => {
props.fullscreen?.onToggle();
close();
}}>
<span className="more-menu-icon" aria-hidden="true">{props.fullscreen.active ? <Minimize /> : <Maximize />}</span>
<span className="more-menu-label">{props.fullscreen.active ? "Exit full screen" : "Full screen"}</span>
<kbd className="more-menu-key" aria-hidden="true">{formatShortcut(SHORTCUTS.view.fullscreen)}</kbd>
</button>
) : null}
{props.inspector ? (
<button
type="button"
className="more-menu-row more-menu-item"
role="menuitemcheckbox"
aria-checked={props.inspector.open}
tabIndex={-1}
aria-keyshortcuts={SHORTCUTS.panel.right.key}
data-more-row
onClick={() => {
props.inspector?.onToggle();
close();
}}>
<span className="more-menu-icon" aria-hidden="true"><PanelRight /></span>
<span className="more-menu-label">Inspector</span>
{props.inspector.open ? <span className="more-menu-check" aria-hidden="true"><Check /></span> : null}
<kbd className="more-menu-key" aria-hidden="true">{formatShortcut(SHORTCUTS.panel.right)}</kbd>
</button>
) : null}
<button
type="button"
className="more-menu-row more-menu-item"
role="menuitem"
tabIndex={-1}
aria-haspopup="dialog"
aria-keyshortcuts="?"
data-more-row
onClick={() => {
close();
props.onOpenShortcuts();
}}>
<span className="more-menu-icon" aria-hidden="true"><Keyboard /></span>
<span className="more-menu-label">Keyboard shortcuts</span>
<kbd className="more-menu-key" aria-hidden="true">?</kbd>
</button>
</div>
</Menu>
</>
);
}
@@ -29,12 +29,6 @@ export type ScreenScreenshotCardProps = {
/** The frame of a screen without a screenshot: its run's screenshots, so it lines up beside them. */
placeholderSize?: { width: number; height: number };
loading?: "eager" | "lazy";
/**
* Frame the screenshot from behind while it loads and fades in, where the frame and its rings are drawn on the image
* itself: the Map, and Screens on a phone. Screens' wells frame their own screenshots on wider windows. Only a
* screenshot of recorded size has one.
*/
backing?: boolean;
leading?: ReactNode;
trailing?: ReactNode;
/** Say "Open in Inspector" in a tooltip over the screenshot (Screens). The Map's cards go without. */
@@ -53,13 +47,13 @@ export type ScreenScreenshotCardProps = {
export function ScreenScreenshotCard(props: ScreenScreenshotCardProps) {
// The placeholder takes the frame of the image it stands in for: a failed screenshot keeps the
// frame it waited in, and a screen without one is framed like a phone screenshot beside it.
const sized = Boolean(props.screenshot && props.imageWidth && props.imageHeight);
const frame = sized
? { width: props.imageWidth!, height: props.imageHeight! }
const frame = props.screenshot && props.imageWidth && props.imageHeight
? { width: props.imageWidth, height: props.imageHeight }
: props.placeholderSize ?? DEFAULT_SCREENSHOT_SIZE;
const frameStyle = { "--screenshot-width": frame.width, "--screenshot-height": frame.height } as CSSProperties;
const missing = (
<span className="image-placeholder" style={frameStyle}>
<span
className="image-placeholder"
style={{ "--screenshot-width": frame.width, "--screenshot-height": frame.height } as CSSProperties}>
<ImageOff aria-hidden="true" size={20} />
No screenshot
{props.missingReason ? <small className="image-placeholder-reason">{props.missingReason}</small> : null}
@@ -110,7 +104,6 @@ export function ScreenScreenshotCard(props: ScreenScreenshotCardProps) {
onClick={props.onClick}>
<DiffFrame status={props.diff} accessibilityOnly={props.accessibilityOnly}>
<span className={`screen-node-image${props.screenshot ? " has-screenshot" : " is-missing"}`}>
{props.backing && sized ? <span className="screenshot-backing" style={frameStyle} aria-hidden="true" /> : null}
{props.screenshot ? (
<ScreenshotImage
src={props.screenshot}
@@ -121,6 +114,7 @@ export function ScreenScreenshotCard(props: ScreenScreenshotCardProps) {
decoding="async"
loading={props.loading ?? "lazy"}
fallback={missing}
holdPrevious
/>
) : missing}
{/* On a phone's map, says what the second tap on the selected screen does. */}
+10 -14
View File
@@ -1,8 +1,7 @@
import { GitCompareArrows, LayoutGrid, Map, Search } from "lucide-react";
import { GitCompareArrows, Keyboard, LayoutGrid, Map, Search } from "lucide-react";
import { type CSSProperties, useLayoutEffect, useState } from "react";
import { Tooltip } from "../shared/tooltip";
import { useCanvasVisibleFrame } from "./visible-frame-provider";
import { setToolbarRoom } from "../../utils/inspector-width";
import { CANVAS_NUMBER_KEYS, formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
import { KeyHint } from "../shared/key-hint";
import {
@@ -27,8 +26,7 @@ type CanvasToolbarProps = {
actions?: React.ReactNode;
onSelectCanvas: (canvas: CanvasView) => void;
onOpenSearch: () => void;
/** The bar's last button: the "More" menu with theme, full screen and keyboard shortcuts. */
more: React.ReactNode;
onOpenShortcuts: () => void;
};
/** Room kept between the toolbar and an Inspector wide enough to reach it. */
@@ -49,21 +47,14 @@ export function CanvasToolbar(props: CanvasToolbarProps) {
observer.observe(element);
return () => observer.disconnect();
}, [element]);
// The Inspector stops short of covering the bar: it may widen only as far as leaves the canvas
// room for the bar and a gap either side.
useLayoutEffect(() => {
if (ownWidth > 0) setToolbarRoom(ownWidth + 2 * TOOLBAR_PANEL_GAP);
}, [ownWidth]);
// When responsive panels leave less room than the toolbar itself, hiding it is the only
// collision-free layout. It returns as soon as either panel is collapsed. The Inspector's width is
// capped to leave the bar its room, so this is a last resort: a desktop window (820px and up)
// always fits the bar beside the narrowest Inspector.
// collision-free layout. It returns as soon as either panel is collapsed.
if (visibleFrame && visibleFrame.width < TOOLBAR_MINIMUM_FRAME_WIDTH) return null;
// The toolbar is the canvas' persistent mode switcher. Panel geometry may raise it to avoid
// bottom chrome, but must not pull it away from the window's stable horizontal centre. Only an
// Inspector that would cover it (widened by the reader, or a narrow window's overlay) pushes it
// left, and by just that much, never past the canvas' left edge: with no room left between the
// two, it hides as it does above, which the Inspector's cap keeps from happening.
// two, it hides as it does above.
let shift = 0;
if (visibleFrame && typeof window !== "undefined") {
const centredLeft = window.innerWidth / 2 - ownWidth / 2;
@@ -133,7 +124,12 @@ export function CanvasToolbar(props: CanvasToolbarProps) {
<span className="toolbar-divider" aria-hidden="true" />
{props.more}
<Tooltip label="Keyboard shortcuts" shortcut="?" placement="top">
<button type="button" className="toolbar-button" aria-label="Keyboard shortcuts"
aria-haspopup="dialog" onClick={props.onOpenShortcuts}>
<Keyboard />
</button>
</Tooltip>
</div>
</div>
);
@@ -327,24 +327,13 @@
border-radius: 14px;
background: var(--subtle);
}
.compare-frame > img,
.compare-flip-layer > img {
.compare-frame > img {
display: block;
width: 100%;
height: 100%;
object-fit: contain;
}
.compare-flip-frame { cursor: pointer; }
/* Flip's two sides fill the frame, one over the other; the frame takes its size from its aspect ratio, not from them.
The side off screen is hidden, spinner and all, and a flip shows it at once. */
.compare-flip-layer {
position: absolute;
inset: 0;
display: flex;
align-items: center;
justify-content: center;
}
.compare-flip-layer[aria-hidden="true"] { visibility: hidden; }
.compare-flip-frame:focus-visible { outline: 2px solid var(--accent); outline-offset: 3px; }
.compare-swipe .visual-swipe { width: auto; height: var(--compare-frame-height); }
@@ -9,7 +9,6 @@ import { formatShortcut, matchesShortcut, SHORTCUTS, shortcutsLive } from "../..
import { createKeyHold, DIVIDER_GLIDE, glideWhileHeld, type KeyHold } from "../../utils/key-hold";
import { optionalStorage } from "../../utils/embedded-report";
import { usePhoneLayout } from "../../utils/phone-layout";
import { useNeighborScreenshots } from "../../hooks/use-neighbor-screenshots";
import { ToggleGroup } from "../shared/toggle-group";
import { Tooltip } from "../shared/tooltip";
import { DEFAULT_SCREENSHOT_RATIO, ScreenshotImage, ScreenshotPlaceholder } from "../shared/screenshot-image";
@@ -134,10 +133,7 @@ export function useCompareController(options: CompareControllerOptions) {
const mode: CompareMode = comparable ? (phone ? phoneMode : desktopMode) : "flip";
const outlines = useOutlinesShown();
const [activeArea, setActiveArea] = useState<number>();
// Flip's side belongs to the screen it was chosen on: each screen starts on After, from its very
// first render, so a step never shows the next screen's Before for a frame.
const [flipped, setFlipped] = useState<{ screenId: string; side: "before" | "after" }>();
const flipSide = flipped?.screenId === options.screenId ? flipped.side : "after";
const [flipSide, setFlipSide] = useState<"before" | "after">("after");
const [swipePosition, setSwipePosition] = useState(50);
const [factsOpen, setFactsOpen] = useState(false);
// The frame takes the recorded screenshot's shape at once, then the loaded image's (they agree
@@ -154,11 +150,10 @@ export function useCompareController(options: CompareControllerOptions) {
setLoadedAspect({ screenId: options.screenId, aspect: value });
}, [options.screenId, hasAfter]);
// Each screen starts whole: no area selected, After showing, the facts closed. A side flipped to on
// another screen is already not this one's (above); it is dropped, so coming back starts on After.
// Each screen starts whole: no area selected, After showing, the facts closed.
useEffect(() => {
setActiveArea(undefined);
setFlipped(undefined);
setFlipSide("after");
setFactsOpen(false);
}, [options.screenId]);
@@ -176,7 +171,7 @@ export function useCompareController(options: CompareControllerOptions) {
return Math.min(areas.length - 1, Math.max(0, current + step));
});
};
const flip = () => setFlipped({ screenId: options.screenId, side: flipSide === "after" ? "before" : "after" });
const flip = () => setFlipSide((side) => (side === "after" ? "before" : "after"));
const keyState = useRef({ previous, next, mode, activeArea, options, swipePosition });
keyState.current = { previous, next, mode, activeArea, options, swipePosition };
@@ -204,17 +199,6 @@ export function useCompareController(options: CompareControllerOptions) {
holdRef.current ??= createKeyHold();
const hold = holdRef.current;
useEffect(() => hold.end, [hold]);
// A held key steps faster than a screenshot fades in, so while it repeats each screen's pictures appear at once:
// the stage is marked for ScreenshotImage directly, without a render of its own.
const stageRef = useRef<HTMLDivElement>(null);
const stepHeld = (direction: 1 | -1): boolean => {
const stepped = stepScreen(direction);
if (stepped) stageRef.current?.setAttribute("data-screenshot-instant", "");
return stepped;
};
const endHeldSteps = () => stageRef.current?.removeAttribute("data-screenshot-instant");
useNeighborScreenshots({ diff: options.diff, order: options.order, screenId: options.screenId,
enabled: options.stepScreens !== false, hold });
// A tap of [ or ] moves the divider one step; held, it keeps going from the same motion. The hold only
// tracks the key; the glide reads it every frame and stops with it.
const glideDivider = (code: string, direction: 1 | -1) => {
@@ -231,9 +215,9 @@ export function useCompareController(options: CompareControllerOptions) {
const keys = SHORTCUTS.compare;
const stepScreens = state.options.stepScreens !== false;
if (stepScreens && matchesShortcut(event, keys.previousScreen)) {
if (stepScreen(-1)) hold.begin(event.code, () => stepHeld(-1), endHeldSteps);
if (stepScreen(-1)) hold.begin(event.code, () => stepScreen(-1));
} else if (stepScreens && matchesShortcut(event, keys.nextScreen)) {
if (stepScreen(1)) hold.begin(event.code, () => stepHeld(1), endHeldSteps);
if (stepScreen(1)) hold.begin(event.code, () => stepScreen(1));
} else if (matchesShortcut(event, keys.nextArea)) {
stepArea(1);
} else if (matchesShortcut(event, keys.previousArea)) {
@@ -295,7 +279,7 @@ export function useCompareController(options: CompareControllerOptions) {
screen, screenDiff, route, position, previous, next, comparable, areas, facts, split, layoutShift, measurable,
mode, chosenMode, modesDisabled, chooseMode, modeOptions, outlines, shownOutlines, statusBarIgnored, homeIndicatorIgnored, systemRegions, toggleOutlines,
activeArea, setActiveArea, stepArea, flipSide, flip, swipePosition, setSwipePosition,
aspect, setAspect, factsOpen, setFactsOpen, stageRef,
aspect, setAspect, factsOpen, setFactsOpen,
};
}
@@ -409,7 +393,7 @@ export function CompareSection(props: CompareSectionProps) {
</div>
</header>
<div ref={compare.stageRef} className={`compare-stage mode-${mode}`}>
<div className={`compare-stage mode-${mode}`}>
{/* Every mode names Before and After in a row above the screenshots. */}
<CompareStage
mode={mode}
@@ -488,21 +472,6 @@ export function CompareStage(props: StageProps) {
// An outline taken out from under the pointer reports no leave, so another screen, mode or outline
// toggle drops the hover rather than lighting an area the pointer is not on.
useLayoutEffect(() => setHoverIndex(undefined), [props.areas, props.mode, props.showOutlines]);
// Flip keeps both sides mounted, so flipping is an instant swap of two decoded pictures. The side off screen mounts
// once the side on screen is ready for this pair of screenshots, or on the first flip to it, so a held key stepping
// through Flip reads one side of each screen it passes, not two.
const pair = `${before ?? ""} ${after ?? ""}`;
const [flipPair, setFlipPair] = useState<string>();
const flipBoth = flipPair === pair;
if (props.mode === "flip" && props.flipSide === "before" && flipPair !== pair) setFlipPair(pair);
// The side on screen loads (CompareImage reports it), or a step kept its screenshot (the same After beside another
// Before), which fires no load: it is ready as it is.
const flipFrameRef = useRef<HTMLButtonElement>(null);
useLayoutEffect(() => {
if (props.mode !== "flip" || flipPair === pair) return;
const shown = flipFrameRef.current?.querySelector(`.compare-flip-layer[data-side="${props.flipSide}"] img`);
if (shown?.getAttribute("data-screenshot-state") === "ready") setFlipPair(pair);
}, [props.mode, props.flipSide, flipPair, pair]);
if (!before && !after) {
const reason = diff.captureNotes?.after ?? diff.captureNotes?.before;
return (
@@ -546,7 +515,6 @@ export function CompareStage(props: StageProps) {
}
if (props.mode === "flip" && before && after) {
const showing = props.flipSide;
const sides = (["before", "after"] as const).filter((side) => side === showing || flipBoth);
return (
<figure className="compare-side">
{/* Both names, with the one on screen lit; the other one flips to it. */}
@@ -559,21 +527,10 @@ export function CompareStage(props: StageProps) {
))}
</figcaption>
<div className="compare-frame-wrap">
<button ref={flipFrameRef} type="button" className="compare-frame compare-flip-frame" data-side={showing}
<button type="button" className="compare-frame compare-flip-frame" data-side={showing}
aria-label={`Show ${showing === "after" ? "Before" : "After"}`} onClick={props.onFlip}>
{/* Each side is a layer of its own, with its spinner and its no-screenshot state; the one off screen
is hidden, and its pictures land without a fade, so a flip shows the other side at once. */}
{sides.map((side) => (
<span key={side} className="compare-flip-layer" data-side={side}
{...(side === showing ? {} : { "aria-hidden": true, "data-screenshot-instant": "" })}>
<CompareImage src={side === "after" ? after : before} alt={`${props.title}, ${side}`}
placeholder="No screenshot" side={side}
onAspect={(aspect, loaded) => {
if (loaded === showing) setFlipPair(pair);
props.onAspect(aspect, loaded);
}} />
</span>
))}
<CompareImage src={showing === "after" ? after : before} alt={`${props.title}, ${showing}`}
placeholder="No screenshot" side={showing} onAspect={props.onAspect} />
{props.overlay}
</button>
</div>
@@ -19,8 +19,6 @@ export type ShortcutContext = {
handoff?: boolean;
/** The report was captured in both light and dark, so the app's appearance can be switched. */
appearances?: boolean;
/** The browser can put the Viewer in full screen. */
fullscreen?: boolean;
/** The run's other targets are one switch away; the pill calls them devices, or platforms in reports from before targets. */
targets?: { noun: "device" | "platform"; count: number };
};
@@ -96,7 +94,6 @@ export function shortcutGroups(context: ShortcutContext): Group[][] {
...(context.canvas === "compare" ? [] : [{ label: "Show or hide the inspector", keys: [SHORTCUTS.panel.right] }]),
{ label: "Viewer theme: dark or light", keys: [SHORTCUTS.appearance.theme] },
...(context.appearances ? [{ label: "The app's appearance: light or dark", keys: [SHORTCUTS.appearance.app] }] : []),
...(context.fullscreen ? [{ label: "Enter or exit full screen", keys: [SHORTCUTS.view.fullscreen] }] : []),
{ label: "Show this list", keys: ["?"] },
],
};
@@ -122,7 +119,7 @@ export function shortcutGroups(context: ShortcutContext): Group[][] {
return [here, [goTo, view]];
}
/** The keyboard reference, opened with "?" or from the More menu at the end of the bottom bar. */
/** The keyboard reference, opened with "?" or the button at the end of the bottom bar. */
export function ShortcutsDialog(props: { context: ShortcutContext; onClose: () => void }) {
const dialogRef = useModalDialog(true, props.onClose);
useEffect(() => {
+8 -101
View File
@@ -1,5 +1,5 @@
import { appearanceLabel, type Appearance } from "../../utils/appearance";
import { useEffect, useLayoutEffect, useRef, useState, useSyncExternalStore, type ReactNode } from "react";
import { useEffect, useRef, useState, useSyncExternalStore, type ReactNode } from "react";
import { LoaderCircle, Search } from "lucide-react";
import { toast } from "sonner";
import { ExpoLogo } from "../shared/expo-logo";
@@ -13,7 +13,6 @@ import { KeyHint } from "../shared/key-hint";
import { formatShortcut, matchesShortcut, shortcutsLive, SHORTCUTS, TARGET_NUMBER_KEYS } from "../../utils/shortcuts";
import { ChangesMenu } from "./changes-menu";
import { placeForAnotherTarget, type FocusStatus } from "../../utils/navigation";
import { usePhoneLayout } from "../../utils/phone-layout";
import type { ExploreMap, MapIndex } from "../../utils/model";
import type { BuildDiff } from "../../utils/build-diff";
import type { PullRequestPresentation } from "../../utils/review-model";
@@ -104,25 +103,6 @@ function useSiblingReports(page: URL | undefined): SiblingReport[] | undefined {
return reports;
}
/**
* A chip's label, truncating from its end when the chip is squeezed, except a trailing parenthetical: a target's
* pose, "iPhone Duo (open)", keeps "(open)" and loses letters of the device.
*/
function ChipLabel({ text }: { text: string }) {
const suffix = /^(.*\S) (\(.+\))$/.exec(text);
return (
<span className="collapsed-platform-label">
<span className="collapsed-platform-label-text">{suffix ? suffix[1] : text}</span>
{suffix ? <span className="collapsed-platform-label-suffix">{` ${suffix[2]}`}</span> : null}
</span>
);
}
/** Whether an element's text runs past its box: scrollWidth is an integer, so a sub-pixel overrun is no cut. */
function cut(element: HTMLElement | null): boolean {
return Boolean(element && element.scrollWidth > element.offsetWidth);
}
type AppPillProps = {
/** The phone layout puts Search in the pill, at its trailing edge. */
onOpenSearch?: (() => void) | undefined;
@@ -156,8 +136,6 @@ type AppPillProps = {
export function AppPill(props: AppPillProps) {
const pillRef = useRef<HTMLDivElement>(null);
const platformRef = useRef<HTMLButtonElement>(null);
const phone = usePhoneLayout();
const identityRef = useRef<HTMLDivElement>(null);
const [platformOpen, setPlatformOpen] = useState(false);
// A target still downloading: this report stays up, the trigger and the menu row say so. One that failed says why.
const { switching, switchError } = useSyncExternalStore(REPORT_SOURCE.subscribe, REPORT_SOURCE.getSnapshot, REPORT_SOURCE.getSnapshot);
@@ -172,9 +150,6 @@ export function AppPill(props: AppPillProps) {
const applicationName = props.map.run.name;
// The app's own icon when the report carries one; the Expo mark otherwise.
const appIcon = artifactUrl(props.map.run.appIcon);
// An icon that cannot be read shows the Expo mark instead, which does not name the app: the icon it was for.
const [failedIcon, setFailedIcon] = useState<string>();
const iconShown = Boolean(appIcon) && failedIcon !== appIcon;
const platform = props.map.run.platform;
const environment = props.map.run.environment ?? {};
const device = [
@@ -195,72 +170,6 @@ export function AppPill(props: AppPillProps) {
const run = runTargets(props.map.run);
const currentTarget = run.targets.find(target => target.id === run.current);
const targetLabel = currentTarget?.label ?? PLATFORM_NAMES[platform] ?? platform;
// The phone's header is the window's width. When the row cannot fit, it gives way in order: the app's name (left
// out while the app's own icon names it, or else cut down to its minimum), then the pull request link (Search keeps
// "Open pull request"); only then does the target's chip shrink, holding the name at its minimum: its device first,
// its pose only once the device is gone, so the label never runs out of its chip over the next. A name without its
// icon is left out last, when even the shrunk chip leaves it no room. Each step is laid out and measured in turn
// from the first, so the result is a function of the row's width alone, never of the last result. A label fades at
// its end only where it is cut. The desktop's pill is sized by its content, so it leaves nothing out.
const appearanceCurrent = props.appearance?.current;
useLayoutEffect(() => {
const row = identityRef.current;
if (!row) return;
if (!phone) {
delete row.dataset.drop;
delete row.dataset.fade;
return;
}
let disposed = false;
const fit = () => {
if (disposed) return;
const name = row.querySelector<HTMLElement>(":scope > strong");
const target = row.querySelector<HTMLElement>(".collapsed-target");
const label = target?.querySelector<HTMLElement>(".collapsed-platform-label") ?? null;
const device = target?.querySelector<HTMLElement>(".collapsed-platform-label-text") ?? null;
const pose = target?.querySelector<HTMLElement>(".collapsed-platform-label-suffix") ?? null;
const style = getComputedStyle(row);
const minimum = parseFloat(style.getPropertyValue("--collapsed-name-min")) || 0;
// A chip no wider than its squeezed minimum has nothing to give: squeezing it would only widen it.
row.dataset.drop = "";
const squeezable = Boolean(target && target.getBoundingClientRect().width > (parseFloat(style.getPropertyValue("--collapsed-target-min")) || 0));
const steps = [
...(name && iconShown ? ["name"] : []),
...(row.querySelector(".collapsed-pr") ? ["pr"] : []),
...(squeezable ? ["squeeze"] : []),
...(squeezable && pose ? ["pose"] : []),
...(name && !iconShown ? ["name"] : []),
];
// With `drops` left out, nothing runs past the row's end, a name that stays shows whole beside its icon and at
// least its minimum without, and a squeezed label still shows its whole pose.
const fits = (drops: string[]) => {
row.dataset.drop = drops.join(" ");
const end = row.getBoundingClientRect().right - parseFloat(style.paddingRight);
if (Array.from(row.children).some(item => item.getBoundingClientRect().right > end + 0.5)) return false;
if (name && !drops.includes("name") && !drops.includes("squeeze")) {
if (iconShown ? cut(name) : name.getBoundingClientRect().width < Math.min(minimum, name.scrollWidth) - 0.5) return false;
}
return !drops.includes("squeeze") || drops.includes("pose") || !cut(label);
};
let count = 0;
while (count < steps.length && !fits(steps.slice(0, count))) count += 1;
if (count === steps.length) row.dataset.drop = steps.join(" ");
if (!row.dataset.drop) delete row.dataset.drop;
const fade = [...(cut(device) ? ["device"] : []), ...(cut(pose) ? ["pose"] : [])];
if (fade.length) row.dataset.fade = fade.join(" ");
else delete row.dataset.fade;
};
fit();
// The row's room, and its items' widths: a font arriving after the first paint changes the latter alone.
const observer = new ResizeObserver(fit);
for (const node of [row, ...row.children]) observer.observe(node);
void document.fonts.ready.then(fit);
return () => {
disposed = true;
observer.disconnect();
};
}, [targetLabel, appearanceCurrent, pullRequest, phone, iconShown]);
// Platform-named targets (every report from before targets) switch platforms; named targets switch devices.
const noun = run.targets.every(target => target.id === target.platform) ? "platform" : "device";
const siblings = run.targets
@@ -332,17 +241,15 @@ export function AppPill(props: AppPillProps) {
<div className="left-panel collapsed">
<div ref={pillRef} className="left-panel-collapsed-pill">
<Tooltip label="Map">
{/* The button names the app as well: the icon has no text of its own, and a phone's row can leave the name out. */}
<button type="button" className="panel-logo-button" aria-label={`Map of ${applicationName}`} onClick={props.onOpenMap}>
<button type="button" className="panel-logo-button" aria-label="Map" onClick={props.onOpenMap}>
{appIcon ? (
<ScreenshotImage className="panel-app-icon" src={appIcon} alt="" loading="eager" draggable={false}
fallback={<ExpoLogo mark />} holdPrevious onError={() => setFailedIcon(appIcon)} />
fallback={<ExpoLogo mark />} holdPrevious />
) : <ExpoLogo mark />}
</button>
</Tooltip>
<span className="panel-logo-divider" aria-hidden="true" />
{/* The phone's fit (above) sets data-drop and data-fade on the row itself. */}
<div ref={identityRef} className="collapsed-app-identity">
<div className="collapsed-app-identity">
<strong title={appTitle}>
{repositoryUrl ? (
<a className="collapsed-app-name" href={repositoryUrl} target="_blank" rel="noreferrer noopener"
@@ -354,11 +261,11 @@ export function AppPill(props: AppPillProps) {
{siblings.length ? (
<>
<Tooltip label={`${device || targetLabel} · open another ${noun}'s report`} shortcut={formatShortcut(SHORTCUTS.target.menu)} placement="bottom">
<button ref={platformRef} type="button" className="collapsed-platform collapsed-target" aria-haspopup="menu" aria-expanded={platformOpen}
<button ref={platformRef} type="button" className="collapsed-platform" aria-haspopup="menu" aria-expanded={platformOpen}
aria-label={`${noun === "device" ? "Device" : "Platform"}: ${targetLabel}. Open another ${noun}'s report`}
aria-busy={switching ? true : undefined}
onClick={() => setPlatformOpen(open => !open)}>
<ChipLabel text={targetLabel} />
{targetLabel}
{switching
? <LoaderCircle aria-hidden="true" className="collapsed-platform-busy" />
: <svg aria-hidden="true" width="8" height="8" viewBox="0 0 8 8"><path d="M1 2.5 4 5.5 7 2.5" fill="none" stroke="currentColor" strokeWidth="1.5" strokeLinecap="round" strokeLinejoin="round" /></svg>}
@@ -373,7 +280,7 @@ export function AppPill(props: AppPillProps) {
<button ref={appearanceRef} type="button" className="collapsed-platform" aria-haspopup="menu" aria-expanded={appearanceOpen}
aria-label={`Appearance: ${appearanceLabel(props.appearance.current)}. Show the other appearance`}
onClick={() => setAppearanceOpen(open => !open)}>
<ChipLabel text={appearanceLabel(props.appearance.current)} />
{appearanceLabel(props.appearance.current)}
<svg aria-hidden="true" width="8" height="8" viewBox="0 0 8 8"><path d="M1 2.5 4 5.5 7 2.5" fill="none" stroke="currentColor" strokeWidth="1.5" strokeLinecap="round" strokeLinejoin="round" /></svg>
<KeyHint shortcut={SHORTCUTS.appearance.app} />
</button>
@@ -400,7 +307,7 @@ export function AppPill(props: AppPillProps) {
target="_blank"
rel="noreferrer noopener"
aria-label={`PR #${pullRequest.number} on GitHub`}>
{phone ? `#${pullRequest.number}` : `PR #${pullRequest.number}`}
PR #{pullRequest.number}
</a>
</Tooltip>
) : pullRequest ? (
@@ -2,8 +2,8 @@ import {
useCallback, useRef, useSyncExternalStore, type CSSProperties, type KeyboardEvent, type PointerEvent, type RefObject,
} from "react";
import {
clampInspectorWidth, getToolbarRoom, inspectorWidthBounds, INSPECTOR_WIDTH_MAX, INSPECTOR_WIDTH_MIN, INSPECTOR_WIDTH_STEP,
setInspectorWidth, subscribeToToolbarRoom, useInspectorWidth,
clampInspectorWidth, inspectorWidthBounds, INSPECTOR_WIDTH_MAX, INSPECTOR_WIDTH_MIN, INSPECTOR_WIDTH_STEP,
setInspectorWidth, useInspectorWidth,
type InspectorWidthBounds,
} from "../../utils/inspector-width";
@@ -31,22 +31,8 @@ function subscribeToWindow(onChange: () => void): () => void {
return () => window.removeEventListener("resize", onChange);
}
/** The widest the panel can be now: it follows the window, `--ui-scale` and the bottom bar's width. */
function currentBounds(): InspectorWidthBounds {
return inspectorWidthBounds(window.innerWidth, uiScale(), getToolbarRoom());
}
function subscribeToBounds(onChange: () => void): () => void {
const unsubscribeToolbar = subscribeToToolbarRoom(onChange);
const unsubscribeWindow = subscribeToWindow(onChange);
return () => {
unsubscribeToolbar();
unsubscribeWindow();
};
}
function widestWidth(): number {
return currentBounds().max;
return inspectorWidthBounds(window.innerWidth, uiScale()).max;
}
type Drag = {
@@ -68,7 +54,7 @@ type Drag = {
*/
export function useInspectorResize(panelRef: RefObject<HTMLElement | null>) {
const width = useInspectorWidth();
const widest = useSyncExternalStore(subscribeToBounds, widestWidth, () => INSPECTOR_WIDTH_MAX);
const widest = useSyncExternalStore(subscribeToWindow, widestWidth, () => INSPECTOR_WIDTH_MAX);
const fallback = useSyncExternalStore(subscribeToWindow, defaultWidth, () => 400);
const drag = useRef<Drag | null>(null);
@@ -106,7 +92,7 @@ export function useInspectorResize(panelRef: RefObject<HTMLElement | null>) {
const startWidth = panelWidth(panel);
drag.current = {
pointerId: event.pointerId, startX: event.clientX, startWidth, scale,
bounds: currentBounds(), last: startWidth,
bounds: inspectorWidthBounds(window.innerWidth, scale), last: startWidth,
inline: panel.style.getPropertyValue("--inspector-width"),
};
event.currentTarget.setPointerCapture(event.pointerId);
@@ -140,7 +126,7 @@ export function useInspectorResize(panelRef: RefObject<HTMLElement | null>) {
const onKeyDown = (event: KeyboardEvent<HTMLElement>) => {
const panel = panelRef.current;
if (!panel) return;
const bounds = currentBounds();
const bounds = inspectorWidthBounds(window.innerWidth, uiScale());
const current = panelWidth(panel);
let next: number;
switch (event.key) {
+18 -9
View File
@@ -1,5 +1,5 @@
import { useEffect, useRef } from "react";
import { GitCompareArrows, ScanSearch, X } from "lucide-react";
import { GitCompareArrows, PanelRight, ScanSearch, X } from "lucide-react";
import { Tooltip } from "../shared/tooltip";
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
import { InspectorPanel } from "./inspector";
@@ -59,25 +59,34 @@ export function RightPanel(props: RightPanelProps) {
if (scrollRef.current) scrollRef.current.scrollTop = 0;
}, [screenId]);
// Closed, the Inspector leaves no button behind: a selection, Return or I opens it. Open, an X
// closes it.
if (props.collapsed) return null;
// Collapsed, the panel icon brings the Inspector back; open, an X closes it.
const panelButton = (
<Tooltip label="Close inspector" shortcut={formatShortcut(SHORTCUTS.panel.right)} placement="bottom-end">
<Tooltip
label={props.collapsed ? "Expand inspector" : "Close inspector"}
shortcut={formatShortcut(SHORTCUTS.panel.right)}
placement="bottom-end">
<button
type="button"
className="icon-button"
aria-label="Close inspector"
aria-expanded
aria-label={props.collapsed ? "Expand inspector" : "Close inspector"}
aria-expanded={!props.collapsed}
onClick={props.onToggleCollapsed}>
<X aria-hidden="true" />
{props.collapsed ? <PanelRight aria-hidden="true" /> : <X aria-hidden="true" />}
</button>
</Tooltip>
);
if (props.collapsed) {
return (
<div className="right-float" role="toolbar" aria-label="Canvas actions">
{panelButton}
</div>
);
}
// One header row: the screen's status and path, then the close button. On a phone the close
// button leads the row instead, away from the screen stepper's arrows. Theme and full screen
// live in the bottom bar's "More" menu.
// live in the canvas camera controls.
return (
<aside ref={panelRef} className="right-panel" data-drag-sheet aria-label="Inspector panel" style={phone ? undefined : resize.style}>
{phone ? null : <div className="right-panel-resize" {...resize.handleProps} />}
+60 -13
View File
@@ -1,18 +1,25 @@
import { useCallback, useEffect, useState } from "react";
import { useEffect, useState } from "react";
import { Maximize, Minimize, Moon, Sun, SunMoon } from "lucide-react";
import { Tooltip } from "../shared/tooltip";
import { formatShortcut, SHORTCUTS } from "../../utils/shortcuts";
import type { ThemePreference } from "../../utils/navigation";
export type ShellTheme = "light" | "dark";
export type ShellActionsProps = {
/** The theme on screen: the preference, or the system's when that is Auto. */
theme: ShellTheme;
themePreference: ThemePreference;
/** Steps Auto → Dark → Light → Auto. */
onToggleTheme: () => void;
/** The host toolbar's button class, so the actions match their neighbours. */
className?: string;
};
function fullscreenActive(): boolean {
return typeof document !== "undefined" && document.fullscreenElement !== null;
}
/**
* Whether this browser can put the page in full screen at all: iPhone Safari has no element full
* screen, and a frame that was not allowed it (an embedded Viewer) refuses every request.
*/
export function fullscreenSupported(): boolean {
return typeof document !== "undefined" && typeof document.documentElement.requestFullscreen === "function"
&& document.fullscreenEnabled !== false;
}
/** Tracks the page-level fullscreen state, including exits triggered by the browser itself. */
export function useFullscreen(): [boolean, () => void] {
const [active, setActive] = useState(fullscreenActive);
@@ -23,14 +30,54 @@ export function useFullscreen(): [boolean, () => void] {
return () => document.removeEventListener("fullscreenchange", sync);
}, []);
const toggle = useCallback(() => {
const toggle = () => {
if (document.fullscreenElement) {
void document.exitFullscreen().catch(() => {});
return;
}
if (!fullscreenSupported()) return;
if (typeof document.documentElement.requestFullscreen !== "function") return;
void document.documentElement.requestFullscreen().catch(() => {});
}, []);
};
return [active, toggle];
}
const THEME_LABELS: Record<ThemePreference, string> = {
system: "Theme: Auto (system)",
dark: "Theme: Dark",
light: "Theme: Light",
};
/** The theme button shows the current preference; a press steps Auto → Dark → Light. */
export function ThemeToggleButton(props: ShellActionsProps) {
const Icon = props.themePreference === "system" ? SunMoon : props.themePreference === "dark" ? Moon : Sun;
return (
<Tooltip label={THEME_LABELS[props.themePreference]} shortcut={formatShortcut(SHORTCUTS.appearance.theme)} placement="bottom">
<button
type="button"
className={props.className ?? "icon-button"}
aria-label="Toggle theme"
data-theme-preference={props.themePreference}
onClick={props.onToggleTheme}>
<Icon aria-hidden="true" />
</button>
</Tooltip>
);
}
export function FullscreenToggleButton(props: Pick<ShellActionsProps, "className">) {
const [active, toggle] = useFullscreen();
const label = active ? "Exit full screen" : "Enter full screen";
return (
<Tooltip label={label} placement="bottom">
<button
type="button"
className={props.className ?? "icon-button"}
aria-label={label}
aria-pressed={active}
onClick={toggle}>
{active ? <Minimize aria-hidden="true" /> : <Maximize aria-hidden="true" />}
</button>
</Tooltip>
);
}
@@ -109,10 +109,7 @@
object-fit: cover;
pointer-events: none;
}
/* Each side shows only its own half of the frame, so a side still loading leaves its half empty
instead of showing the other side's picture there. */
.visual-swipe-before { clip-path: inset(0 calc(100% - var(--swipe-position)) 0 0); }
.visual-swipe-after { clip-path: inset(0 0 0 var(--swipe-position)); }
/* With a moved area, each side's outlines over its own half (see ChangeOutlines). */
.visual-swipe-outlines { position: absolute; z-index: 1; inset: 0; pointer-events: none; }
.visual-swipe-outlines.before { --outline-before: 1; clip-path: inset(0 calc(100% - var(--swipe-position)) 0 0); }
@@ -94,7 +94,7 @@ export function PhoneCompare(props: CompareControllerOptions & {
/>
</div>
<div ref={compare.stageRef} className={`compare-stage phone-compare-stage mode-${mode}`}
<div className={`compare-stage phone-compare-stage mode-${mode}`}
style={{ "--compare-aspect": compare.aspect } as CSSProperties}
onPointerDownCapture={(event) => { pressed.current = { x: event.clientX, y: event.clientY }; }}
onClickCapture={stepFromEdge}>
+3 -16
View File
@@ -375,14 +375,6 @@
}
.collapsed-search > svg { width: 20px; height: 20px; }
.collapsed-search:active { background: var(--panel-hover); }
/* Hand off sits before Search: only Search fills the pill's trailing padding. */
.phone-layout .handoff-icon-button.collapsed-search { margin-right: -6px; }
/* Whatever the row cannot fit is clipped at its end, never drawn under Hand off and Search. The clip edge sits 6px
out from its items, where Search's box (and Hand off's) begins, so an end chip's focus ring and key hint show. */
.phone-layout .collapsed-app-identity { overflow-x: clip; overflow-y: visible; margin-inline: -6px; padding-inline: 6px; }
/* The 24px chips keep their size; their hit area is the pill's height. */
.phone-layout .collapsed-platform { position: relative; }
.phone-layout .collapsed-platform::before { content: ""; position: absolute; inset: -10px 0; }
/* Text links and titles keep their size; their hit area grows into the space around them. */
.phone-layout .collapsed-app-name,
.phone-layout .collapsed-pr,
@@ -539,6 +531,8 @@
.changes-menu .panel-search-clear { width: 44px; height: 44px; }
/* The minimap repeats what a phone already shows whole, and covers a sixth of it. */
.phone-layout .canvas-minimap-shell { display: none; }
/* With nothing selected there is no Inspector to reopen. */
.phone-layout .right-float { display: none; }
/* The Inspector slides up over the whole screen; a drag down on its header puts it away. */
.phone-layout .right-panel {
/* The sheet is the window's width; the desktop's half-window limit is not for it. */
@@ -570,7 +564,7 @@
/* A screen without a screenshot: on the Map the placeholder is sized by its slot's height, which a
Screens grid cell does not have. Here it takes the cell's width and a screenshot's proportions,
so it lines up with the screenshots beside it. */
.screens-cell .screen-node-image:has(> :is(.image-placeholder, .screenshot-backing)) { container-type: normal; }
.screens-cell .screen-node-image:has(> .image-placeholder) { container-type: normal; }
.screens-cell .screen-node-image > .image-placeholder {
/* Like the image beside it: the screenshot's proportions inside the frame's 1px border. */
box-sizing: content-box;
@@ -579,13 +573,6 @@
aspect-ratio: var(--screenshot-width) / var(--screenshot-height);
font-size: var(--phone-caption-size, 12px);
}
/* A screenshot's backing fills the image box exactly: the image sets the cell's height from its own
proportions, and the backing draws its frame there while it loads. */
.screens-cell .screen-node-image > .screenshot-backing {
box-sizing: border-box;
width: 100%;
height: 100%;
}
/* Pinch and double-tap zoom the page on a phone; only the map canvas zooms, and it handles that itself. */
.phone-layout { touch-action: pan-x pan-y; }
@@ -64,10 +64,7 @@
.image-lightbox-step:disabled { opacity: 0.3; cursor: default; }
.image-lightbox-close:focus-visible,
.image-lightbox-step:focus-visible { outline: 2px solid var(--accent); outline-offset: 2px; }
/* The image is all the stage shows, and it is hidden while it loads: the spinner centres in the
stage meanwhile, in the bar's light text colour. */
.image-lightbox-stage {
position: relative;
display: flex;
min-height: 0;
flex: 1;
@@ -85,4 +82,3 @@
object-fit: contain;
box-shadow: 0 20px 60px rgb(0 0 0 / 0.5);
}
.image-lightbox-stage > .screenshot-loading { color: rgb(237 238 240 / 0.6); }
@@ -58,7 +58,7 @@ export function ImageLightbox(props: { images: readonly LightboxImage[]; initial
<ChevronLeft aria-hidden="true" />
</button>
) : null}
<ScreenshotImage key={image.src} src={image.src} alt={image.alt} loading="eager" indicator="spinner" draggable={false} />
<ScreenshotImage key={image.src} src={image.src} alt={image.alt} loading="eager" draggable={false} />
{multiple ? (
<button type="button" className="image-lightbox-step" aria-label="Next image"
disabled={index === props.images.length - 1} onClick={() => move(1)}>
+1 -18
View File
@@ -237,29 +237,12 @@ export function Menu({ items = [], children, initialFocusRef, open, ariaLabel, c
if (initialFocusRef && event.target instanceof Node
&& !popoverRef.current?.contains(event.target) && !anchorRef?.current?.contains(event.target)) dismissRef.current();
};
// A trigger can also move with no scroll or resize, as the bottom bar does when the Inspector
// opens beside it; an anchored menu checks where its trigger is once a frame while it is open.
let frame = 0;
let anchorAt = "";
const follow = () => {
const rect = anchorRef?.current?.getBoundingClientRect();
const at = rect ? `${rect.left},${rect.top}` : "";
if (at !== anchorAt) {
if (anchorAt) place();
anchorAt = at;
}
frame = requestAnimationFrame(follow);
};
window.addEventListener("pointerdown", onPointerDown);
window.addEventListener("keydown", onKeyDown);
window.addEventListener("resize", place);
if (anchorRef) {
window.addEventListener("scroll", onScroll, true);
follow();
}
if (anchorRef) window.addEventListener("scroll", onScroll, true);
window.addEventListener("focusin", onFocusIn);
return () => {
cancelAnimationFrame(frame);
window.removeEventListener("pointerdown", onPointerDown);
window.removeEventListener("keydown", onKeyDown);
window.removeEventListener("resize", place);
@@ -1,22 +0,0 @@
import type { ExploreMap } from "../../utils/model";
/**
* The Map and Screens with no screen to show. A run that observed none says what stopped it; a public report whose routes
* were all deliberately left uncaptured (omitted-screens.ts) says so, rather than showing an empty page.
*/
export function NoScreens(props: { map: ExploreMap }) {
const recorded = props.map.screens.length > 0;
const blockers = props.map.gaps.filter((gap) => gap.status === "open" && !gap.screenId).map((gap) => gap.message);
return (
<div className="graph-canvas canvas-empty">
<div className="page-empty compact-empty map-empty" role="status">
<h2>{recorded ? "No screens were captured" : "No screens were recorded"}</h2>
{recorded
? <p>Every route in this report is a redirect, is named in exploration.exclude, or is outside what the change reaches.</p>
: blockers.length > 0
? blockers.map((message) => <p key={message}>{message}</p>)
: <p>The run ended before any screen of the app was observed.</p>}
</div>
</div>
);
}
@@ -10,21 +10,16 @@ export const DEFAULT_SCREENSHOT_SIZE = { width: 390, height: Math.round(390 / DE
type ScreenshotImageProps = ImgHTMLAttributes<HTMLImageElement> & {
/** Large previews centre a spinner while an embedded screenshot resolves; small images wait as a quiet empty frame. */
indicator?: "spinner";
/** Stands in for a screenshot that cannot be read or loaded: the caller's own no-screenshot state. */
/** Stands in for an embedded screenshot that cannot be read: the caller's own no-screenshot state. */
fallback?: ReactNode;
/**
* Keeps the picture of the source before on screen until the new one has decoded, and shows the new one without a
* fade: for the app icon, which changes only when another target's report is shown and should not blink. Never for a
* screenshot. A view that steps between screens or draws changes over the picture would show the screen before under
* the new one, and a card would show the other target's or appearance's capture as this one's: a screenshot goes
* blank while its replacement loads.
* Keeps the picture of the source before on screen until the new one has decoded: for a map card, whose source
* changes only when the report's other appearance or target swaps every screenshot at once. Never for a view that
* steps between screens or draws changes over the picture, where it would show the screen before under the new one.
*/
holdPrevious?: boolean;
};
/** How long a loaded screenshot waits for its decode before it is shown anyway. */
const DECODE_WAIT_MS = 300;
type ScreenshotState = "loading" | "ready" | "failed";
function dimension(value: number | string | undefined): number | undefined {
@@ -43,45 +38,16 @@ function waitingSource(width: number | string | undefined, height: number | stri
return `data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='${w}' height='${h}'/%3E`;
}
/** The picture each image is waiting to decode, so a load and a re-render waiting for the same one share a wait. */
const decodeWaits = new WeakMap<HTMLImageElement, string>();
/**
* Calls `show` once `image` has decoded `picture`, so the picture fades in on its own pixels rather than on an empty
* box its decode fills in partway; one whose decode does not settle soon is shown anyway. A rejected decode is a
* broken image, whose error event follows, or a source replaced meanwhile, which is shown on its own load. One wait
* runs per image and picture: a second call while it runs adds nothing.
*/
function whenDecoded(image: HTMLImageElement, picture: string, show: () => void) {
if (decodeWaits.get(image) === picture) return;
decodeWaits.set(image, picture);
let settled = false;
const settle = (shown: boolean) => {
if (settled) return;
settled = true;
clearTimeout(timer);
if (decodeWaits.get(image) === picture) decodeWaits.delete(image);
if (shown && image.isConnected && image.getAttribute("src") === picture) show();
};
const timer = setTimeout(() => settle(true), DECODE_WAIT_MS);
image.decode().then(() => settle(true), () => settle(image.complete && image.naturalWidth > 0));
}
/**
* Decode embedded evidence near the viewport; ordinary image URLs keep native loading. While a
* screenshot loads, the image is hidden over its frame (an embedded one keeps its size and, with
* `indicator`, shows a spinner) and never shows its alt text or the picture of the source before;
* a screenshot that cannot be read or loaded shows `fallback`. A picture that fills an empty frame
* fades in, unless it lands inside `[data-screenshot-instant]` (Compare stepping under a held key,
* Flip's hidden side), where it appears at once.
* Decode embedded evidence near the viewport; ordinary image URLs keep native loading. While an
* embedded screenshot resolves, the image shows an empty frame (and, with `indicator`, a spinner)
* and never its alt text; a screenshot that cannot be read shows `fallback`.
*/
export function ScreenshotImage({ src, loading, indicator, fallback, holdPrevious, onLoad, onError, ...props }: ScreenshotImageProps) {
const imageRef = useRef<HTMLImageElement>(null);
const [resolved, setResolved] = useState<{ source: string; url: string }>();
const [failed, setFailed] = useState<string>();
const [shown, setShown] = useState<string>();
// The picture shown, when it fades in: it filled an empty frame outside an instant stage.
const [revealed, setRevealed] = useState<string>();
const [lastSource, setLastSource] = useState(src);
// With `holdPrevious`, the picture of the source before, kept on screen until the new one has decoded.
const [held, setHeld] = useState<string>();
@@ -94,7 +60,6 @@ export function ScreenshotImage({ src, loading, indicator, fallback, holdPreviou
setHeld(holdPrevious && failed !== lastSource ? shown ?? held : undefined);
setResolved(undefined);
setShown(undefined);
setRevealed(undefined);
setFailed(undefined);
}
@@ -157,56 +122,39 @@ export function ScreenshotImage({ src, loading, indicator, fallback, holdPreviou
};
}, [embedded, src, loading]);
// An ordinary URL is its own picture; an embedded one is the URL its report resolved it to.
const url = !embedded ? src : resolved?.source === src ? resolved.url : undefined;
const url = embedded && resolved?.source === src ? resolved.url : undefined;
const state: ScreenshotState = failed === src ? "failed" : url && shown === url ? "ready" : "loading";
const displayed = state !== "failed" ? url ?? held : undefined;
// Shown once decoded. Replacing a held picture is no reveal: it stays up until the new one is there.
const show = (image: HTMLImageElement, picture: string) => whenDecoded(image, picture, () => {
setShown(picture);
setRevealed(held || image.closest("[data-screenshot-instant]") ? undefined : picture);
setHeld(undefined);
});
// Re-committing the URL the image already shows (it left the viewport and came back before a
// render, and the report still held the URL) fires no load event: the loaded image is shown once
// its decode settles, as a load would show it.
// render, and the report still held the URL) fires no load event: the decoded image is ready.
useLayoutEffect(() => {
const image = imageRef.current;
if (!displayed || displayed !== url || shown === displayed || !image || image.getAttribute("src") !== displayed) return;
if (image.complete && image.naturalWidth > 0) show(image, displayed);
});
if (image.complete && image.naturalWidth > 0) {
setShown(displayed);
setHeld(undefined);
}
}, [displayed, url, shown]);
if (!embedded) return <img {...props} ref={imageRef} loading={loading} src={src} onLoad={onLoad} onError={onError} />;
if (state === "failed" && fallback !== undefined) return <>{fallback}</>;
// The caller hears the screenshot's own load and error events and a failed resolve (dispatched
// above, so untrusted), never the stand-in's.
const isScreenshot = (event: SyntheticEvent<HTMLImageElement>) => Boolean(url) && event.currentTarget.getAttribute("src") === url;
const status = {
"data-screenshot-state": state,
// A held picture stays shown while the new one loads; every other waiting image is hidden at once.
"data-screenshot-held": state === "loading" && held ? "" : undefined,
"data-screenshot-reveal": state === "ready" && revealed === url ? "" : undefined,
onLoad: (event: SyntheticEvent<HTMLImageElement>) => {
if (!isScreenshot(event)) return;
show(event.currentTarget, url!);
onLoad?.(event);
},
};
// An ordinary URL loads natively. Each source is an image of its own, so the browser never paints the picture of
// the source before while the new one loads; a held one keeps its element, which keeps painting it.
if (!embedded) {
return <img key={holdPrevious ? undefined : src} {...props} {...status} ref={imageRef} loading={loading} src={src}
onError={event => {
if (event.currentTarget.getAttribute("src") === src) { setFailed(src); setHeld(undefined); }
onError?.(event);
}} />;
}
return (
<>
<img {...props} {...status} ref={imageRef} loading={loading}
<img {...props} ref={imageRef} loading={loading}
src={displayed ?? waitingSource(props.width, props.height)}
data-screenshot-src={src}
data-screenshot-state={state}
aria-busy={state === "loading" || undefined}
onLoad={event => {
if (!isScreenshot(event)) return;
setShown(url);
setHeld(undefined);
onLoad?.(event);
}}
onError={event => {
if (event.nativeEvent.isTrusted) {
// The held picture's URL was revoked since (the report let it go): nothing to show until the new one.
+9 -21
View File
@@ -12,9 +12,7 @@ import { shortcutsLive } from "../../utils/shortcuts";
import { normalizeSearchText } from "../../utils/search";
import { createKeyHold } from "../../utils/key-hold";
import { placeholderScreen } from "../../utils/map-frame";
import { reportScreens } from "../../utils/omitted-screens";
import { ScreenScreenshotCard } from "../canvas/screen-screenshot-card";
import { NoScreens } from "../shared/no-screens";
import { useCanvasVisibleFrame } from "../canvas/visible-frame-provider";
import { PhoneSheet } from "../phone/phone-chrome";
import { PanelSearch } from "../shared/panel-search";
@@ -35,8 +33,6 @@ export type ScreensViewProps = {
/** The other appearances each screen changed in, when the report captured several. */
changedElsewhere?: ReadonlyMap<string, Appearance[]> | undefined;
selectedScreenId?: string | undefined;
/** The routes a public report never captured: not listed, counted or found, as on the Map (omitted-screens.ts). */
omittedScreenIds?: ReadonlySet<string> | undefined;
/** A request (search, the Changes menu) to bring a screen into view; a new key asks again for the same screen. */
focusRequest?: FocusRequest | undefined;
/** The Changes menu's status filter: screens outside it are dimmed, as on the Map. */
@@ -157,8 +153,6 @@ function ScreenCell(props: {
dimmed: boolean;
/** The run's screenshot shape, which a screen without a screenshot is framed in. */
typicalSize?: ScreenshotSize | undefined;
/** A phone's cell, whose screenshot is its own frame: no well frames it while it loads. */
phone?: boolean | undefined;
onSelect: () => void;
}) {
const artifact = primaryScreenshotForScreen(props.screen, props.index);
@@ -181,7 +175,6 @@ function ScreenCell(props: {
selected={props.selected}
ariaPressed={props.selected}
loading="lazy"
backing={props.phone === true}
onClick={props.onSelect}
{...(props.via || props.elsewhere?.length ? { note: <>
{props.via ? <span className="screens-cell-via">via “{props.via}”</span> : null}
@@ -276,21 +269,19 @@ function Legend(props: { others: Appearance[] }) {
* phone, a section per route folder (or per tab, when there are no route files), with the tree behind a Tree button.
*/
export function ScreensView(props: ScreensViewProps) {
// The report's screens, as the Map draws them: a public report's routes it never captured are not among them.
const screens = useMemo(() => reportScreens(props.map.screens, props.omittedScreenIds ?? new Set()), [props.map.screens, props.omittedScreenIds]);
const tree: ScreenTree = useMemo(
() => screenTree(screens, props.index, props.routeFiles),
[props.index, screens, props.routeFiles],
() => screenTree(props.map.screens, props.index, props.routeFiles),
[props.index, props.map.screens, props.routeFiles],
);
const typicalSize = useMemo(
() => typicalScreenshotSize(screens.map(screen => screenshotSize(primaryScreenshotForScreen(screen, props.index)))),
[props.index, screens],
() => typicalScreenshotSize(props.map.screens.map(screen => screenshotSize(primaryScreenshotForScreen(screen, props.index)))),
[props.index, props.map.screens],
);
const changedIds = useMemo(
() => new Set(screens
() => new Set(props.map.screens
.filter(screen => isChanged(props.diff, screen.id) || (props.changedElsewhere?.get(screen.id)?.length ?? 0) > 0)
.map(screen => screen.id)),
[props.changedElsewhere, props.diff, screens],
[props.changedElsewhere, props.diff, props.map.screens],
);
const [filter, setFilter] = useState<Filter>(props.phone && changedIds.size > 0 ? "changed" : "all");
const [treeOpen, setTreeOpen] = useState(false);
@@ -299,9 +290,9 @@ export function ScreensView(props: ScreensViewProps) {
const [query, setQuery] = useState("");
// The phone layout has no field to show or clear a query, so a query typed on desktop does not narrow it.
const findQuery = findOpen && !props.phone ? query : "";
const matches = useMemo(() => findMatches(screens, props.index, findQuery), [props.index, screens, findQuery]);
const matches = useMemo(() => findMatches(props.map.screens, props.index, findQuery), [props.index, props.map.screens, findQuery]);
const inChanged = filter === "changed" && changedIds.size > 0;
const inFilter = inChanged ? changedIds : new Set(screens.map(screen => screen.id));
const inFilter = inChanged ? changedIds : new Set(props.map.screens.map(screen => screen.id));
const shown = matches ? new Set([...inFilter].filter(id => matches.has(id))) : inFilter;
const sections = tree.sections
.map(section => ({ ...section, screenIds: section.screenIds.filter(id => shown.has(id)) }))
@@ -415,7 +406,7 @@ export function ScreensView(props: ScreensViewProps) {
setFilter(value);
}}>
{value === "changed" ? "Changed" : "All"}
<span className="screens-chip-count">{value === "changed" ? changedIds.size : screens.length}</span>
<span className="screens-chip-count">{value === "changed" ? changedIds.size : props.map.screens.length}</span>
</button>
))}
</div>
@@ -572,8 +563,6 @@ export function ScreensView(props: ScreensViewProps) {
? ({ "--screens-right-inset": `calc(100% - ${visibleFrame.x + visibleFrame.width}px)` } as CSSProperties)
: undefined;
if (screens.length === 0) return <NoScreens map={props.map} />;
const cell = (id: string) => {
const screen = props.index.screens.get(id);
return screen ? (
@@ -581,7 +570,6 @@ export function ScreensView(props: ScreensViewProps) {
elsewhere={isChanged(props.diff, id) ? undefined : props.changedElsewhere?.get(id)}
via={tree.via.get(id)}
typicalSize={typicalSize}
phone={props.phone}
selected={props.selectedScreenId === id}
dimmed={Boolean(props.focus?.length) && !props.focus!.some((state) => state === focusStatusOf(props.diff?.screens.get(id)))}
onSelect={() => props.onSelectScreen(id)} />
+15 -12
View File
@@ -8,7 +8,6 @@ import {
} from "../canvas/stage";
import type { ProjectionMotionMetadata } from "../canvas/projection-motion";
import { ScreenScreenshotCard } from "../canvas/screen-screenshot-card";
import { NoScreens } from "../shared/no-screens";
import { TransitionEdge, type TransitionGraphEdge } from "../canvas/transition-edge";
import {
buildViewerGraph,
@@ -117,7 +116,6 @@ function ScreenNodeCard({ data, selected }: NodeProps<ScreenGraphNode>) {
imageHeight={data.screenshotSize?.imageHeight ?? data.frame.screen.height}
placeholderSize={data.frame.screen}
loading="lazy"
backing
// The ring says which screen is which; a click opening it in the Inspector needs no tooltip.
inspectorTooltip={false}
leading={<Handle type="target" position={horizontal ? Position.Left : Position.Top} className="graph-handle" />}
@@ -482,11 +480,7 @@ type BaseCanvasProps = {
onSelectScreen: (id: string, options?: { replace?: boolean }) => void;
onClearSelection?: () => void;
};
export type MapViewProps = BaseCanvasProps & {
projectionFitKey?: number;
/** The routes a public report never captured: not drawn (omitted-screens.ts). */
omittedScreenIds?: ReadonlySet<string> | undefined;
};
export type MapViewProps = BaseCanvasProps & { projectionFitKey?: number };
function ConnectionCanvas(props: MapViewProps) {
const surfaceRef = useRef<HTMLDivElement>(null);
@@ -499,10 +493,7 @@ function ConnectionCanvas(props: MapViewProps) {
});
const previousLayout = useRef<{ nodes: CanvasGraphNode[]; edges: TransitionGraphEdge[] } | undefined>(undefined);
const observedGraph = useMemo(
() => buildViewerGraph(props.map, props.index, props.omittedScreenIds),
[props.index, props.map, props.omittedScreenIds],
);
const observedGraph = useMemo(() => buildViewerGraph(props.map, props.index), [props.index, props.map]);
const projection = useMemo(() => projectFullGraph(observedGraph), [observedGraph]);
const structure = useMemo(
() => projectedStructure(projection, props.index, isBlackBoxMap(props.map)),
@@ -666,7 +657,19 @@ function ConnectionCanvas(props: MapViewProps) {
.sort((left, right) => left.depth - right.depth || left.y - right.y || left.x - right.x || left.index - right.index)
.map(({ id }) => id), [layout.nodes]);
const phone = usePhoneLayout();
if (observedGraph.screens.length === 0) return <NoScreens map={props.map} />;
if (props.map.screens.length === 0) {
const blockers = props.map.gaps.filter((gap) => gap.status === "open" && !gap.screenId).map((gap) => gap.message);
return (
<div className="graph-canvas canvas-empty">
<div className="page-empty compact-empty map-empty">
<h2>No screens were recorded</h2>
{blockers.length > 0
? blockers.map((message) => <p key={message}>{message}</p>)
: <p>The run ended before any screen of the app was observed.</p>}
</div>
</div>
);
}
return (
<div ref={surfaceRef} className="connection-canvas-surface map-surface">
<CanvasStage
@@ -1,65 +0,0 @@
import { useEffect, useRef } from "react";
import type { BuildDiff } from "../utils/build-diff";
import type { ChangedScreen } from "../utils/changed-screens";
import { isEmbeddedArtifactUrl, leaseEmbeddedArtifactUrl } from "../utils/embedded-report";
import type { KeyHold } from "../utils/key-hold";
/** How long Compare rests on a screen before it reads the next one's screenshots. */
export const NEIGHBOR_SETTLE_MS = 250;
export type NeighborScreenshotsOptions = {
diff: BuildDiff;
order: readonly ChangedScreen[];
screenId: string;
/** Compare steps between screens; the Inspector, which stays on its screen, reads no neighbour. */
enabled: boolean;
/** The keys that step: no neighbour is read while one is held. */
hold: KeyHold;
};
/**
* Reads the screenshots of the screen Compare would step to next, in the direction it last stepped (by key, the
* header's buttons, a tap or the picker), once it has rested on a screen. The next step usually finds them decoded,
* so its pictures fade in within a frame of the step. Each is one use of the report's screenshot until Compare moves
* on, then released; nothing is decoded outside the page's own images.
*
* A held key steps past screens faster than they could be read, so nothing is read until it is released. The reads
* are the report's prefetches: one starts only while two slots stay free for the step the reviewer takes, so
* speculative work never holds more than two, whatever earlier prefetches are still reading, and one that has not
* started when Compare moves on is dropped unread.
*/
export function useNeighborScreenshots({ diff, order, screenId, enabled, hold }: NeighborScreenshotsOptions) {
const position = order.findIndex((entry) => entry.id === screenId);
const last = useRef<{ position: number; direction: 1 | -1 }>({ position, direction: 1 });
useEffect(() => {
if (!enabled || position < 0) return;
const previous = last.current;
const direction = position === previous.position ? previous.direction : position > previous.position ? 1 : -1;
last.current = { position, direction };
const neighbor = order[position + direction];
const screen = neighbor ? diff.screens.get(neighbor.id) : undefined;
const sources = new Set([screen?.beforeScreenshot, screen?.afterScreenshot]
.filter((source): source is string => Boolean(source && isEmbeddedArtifactUrl(source))));
if (sources.size === 0) return;
const leases: { release: () => boolean; held: boolean }[] = [];
let timer: ReturnType<typeof setTimeout>;
const read = () => {
if (hold.holding()) {
timer = setTimeout(read, NEIGHBOR_SETTLE_MS);
return;
}
for (const source of sources) {
const leased = leaseEmbeddedArtifactUrl(source, "prefetch");
const lease = { release: leased.release, held: true };
leases.push(lease);
// A read that failed (a report switched away from, or a prefetch dropped) holds nothing to release.
void leased.url.catch(() => { lease.held = false; });
}
};
timer = setTimeout(read, NEIGHBOR_SETTLE_MS);
return () => {
clearTimeout(timer);
for (const lease of leases) if (lease.held) lease.release();
};
}, [enabled, position, order, diff, hold]);
}
+15 -6
View File
@@ -24,7 +24,7 @@ export function reportContractGap(gap: ReviewContractGap): void {
console.warn(`Explore report: ${where} failed the review contract (${gap.message}); ${gap.dropped} omitted.`);
}
import { sourceImpactSentences } from "../../../src/contracts/source-change";
import { captureContext, captureGap, verifiedCapture } from "../../../src/contracts/surface-capture";
import { navigationCaptureContext } from "../../../src/contracts/navigation-graph";
import { projectSourceNavigation } from "../utils/source-navigation";
type Side = "base" | "head";
@@ -89,6 +89,12 @@ function unattributedSummary(surface: Surface, side: Side): string {
return "destination unverified";
}
function verifiedCapture(surface: Surface, side: Side): boolean {
const outcome = side === "base" ? surface.baseOutcome : surface.headOutcome;
return Boolean(surface[side]?.kind === "screen" && imageFor(surface, side)
&& outcome?.status === "captured" && outcome.landing === "verified");
}
function comparisonReview(surface: Surface): Surface["review"] {
if (surface.status === "added" || surface.status === "removed") {
return surface.review?.status === surface.status ? surface.review : undefined;
@@ -211,7 +217,10 @@ function sidePayload(review: PublicReview, side: Side): { map: ExploreMap; cover
const id = routeOf(surface.id);
if (!routes.has(id)) routes.set(id, { ...surface[side]!, id });
}
const selected = captureContext(review, side);
const selectedRoutes = navigation ? new Set(review.mode === "all" ? [...routes.keys()] : navigationCaptureContext(navigation,
inventory.filter(surface => surface.status !== "unchanged").map(surface => routeOf(surface.id)),
[...routes.values()])) : undefined;
const selected = selectedRoutes ? new Set(inventory.filter(surface => selectedRoutes.has(routeOf(surface.id))).map(surface => surface.id)) : undefined;
// Planned structural groups describe the full inventory, including routes outside the
// capture budget. Keep their placeholders available in every canvas.
const declared = inventory;
@@ -347,11 +356,11 @@ function sidePayload(review: PublicReview, side: Side): { map: ExploreMap; cover
screenshotArtifactId: artifact.id,
});
}
// The gap's status is the one the PR comment reads too (surface-capture.ts), so both leave out the same routes.
const gap = captureGap(review, surface, side, selected);
if (gap) {
if (!verifiedCapture(surface, side)) {
const outcome = side === "base" ? surface.baseOutcome : surface.headOutcome;
const outsideCaptureContext = review.mode === "changes" && selected !== undefined && !selected.has(surface.id);
const deliberatelyOmitted = gap === "accepted";
const deliberatelyOmitted = !image && !outcome && (entry.kind === "redirect" || surface.excluded === true || outsideCaptureContext
|| (!navigation && review.mode === "changes" && surface.status === "unchanged"));
map.gaps.push({
id: `capture:${side}:${surface.id}`,
screenId: surface.id,
+79 -145
View File
@@ -133,10 +133,13 @@
--icon-hit-min: 32px;
/* Chevrons, carets and status glyphs that sit inline next to text. */
--icon-glyph-inline: 14px;
/* Floating canvas chrome shares a y=30px center line. Reserve space for the visible actions only. */
/* Floating canvas chrome shares a y=30px center line. The collapsed inspector joins the
camera controls into one compact toolbar. Reserve space for the visible actions only. */
--floating-chrome-top: 14px;
--floating-chrome-height: 42px;
--canvas-chrome-inline-inset: 12px;
--right-float-edge: 12px;
--right-float-width: calc(var(--icon-btn-md) + 6px);
--left-collapsed-pill-width: 420px;
--left-collapsed-pill-height: var(--floating-chrome-height);
--left-collapsed-pill-top: var(--floating-chrome-top);
@@ -154,8 +157,6 @@
/* The bottom bar resizes with the same timing as the canvas it switches. */
--toolbar-motion: 220ms;
--toolbar-easing: ease-in-out;
/* A screenshot fades in over its empty frame once its pixels are decoded. */
--screenshot-reveal: 160ms;
}
:root[data-theme="dark"] {
@@ -303,14 +304,16 @@ code {
}
:root[data-canvas-transition-direction]::view-transition-group(app-pill),
:root[data-canvas-transition-direction]::view-transition-group(canvas-camera-controls),
:root[data-canvas-transition-direction]::view-transition-group(canvas-toolbar) {
:root[data-canvas-transition-direction]::view-transition-group(canvas-toolbar),
:root[data-canvas-transition-direction]::view-transition-group(right-floating-controls) {
z-index: 101;
animation: none;
}
:root[data-canvas-transition-direction]::view-transition-image-pair(canvas-minimap),
:root[data-canvas-transition-direction]::view-transition-image-pair(app-pill),
:root[data-canvas-transition-direction]::view-transition-image-pair(canvas-camera-controls),
:root[data-canvas-transition-direction]::view-transition-image-pair(canvas-toolbar) {
:root[data-canvas-transition-direction]::view-transition-image-pair(canvas-toolbar),
:root[data-canvas-transition-direction]::view-transition-image-pair(right-floating-controls) {
isolation: isolate;
}
:root[data-canvas-transition-direction]::view-transition-old(canvas-view-content),
@@ -322,7 +325,9 @@ code {
:root[data-canvas-transition-direction]::view-transition-old(canvas-toolbar),
:root[data-canvas-transition-direction]::view-transition-old(phone-top-actions),
:root[data-canvas-transition-direction]::view-transition-new(canvas-toolbar),
:root[data-canvas-transition-direction]::view-transition-new(phone-top-actions) {
:root[data-canvas-transition-direction]::view-transition-new(phone-top-actions),
:root[data-canvas-transition-direction]::view-transition-old(right-floating-controls),
:root[data-canvas-transition-direction]::view-transition-new(right-floating-controls) {
mix-blend-mode: normal;
}
:root[data-canvas-transition-direction="forward"]::view-transition-old(canvas-view-content) {
@@ -345,13 +350,15 @@ code {
}
:root[data-canvas-transition-direction]::view-transition-old(app-pill),
:root[data-canvas-transition-direction]::view-transition-old(canvas-camera-controls),
:root[data-canvas-transition-direction]::view-transition-old(canvas-toolbar) {
:root[data-canvas-transition-direction]::view-transition-old(canvas-toolbar),
:root[data-canvas-transition-direction]::view-transition-old(right-floating-controls) {
animation: none;
opacity: 0;
}
:root[data-canvas-transition-direction]::view-transition-new(app-pill),
:root[data-canvas-transition-direction]::view-transition-new(canvas-camera-controls),
:root[data-canvas-transition-direction]::view-transition-new(canvas-toolbar) {
:root[data-canvas-transition-direction]::view-transition-new(canvas-toolbar),
:root[data-canvas-transition-direction]::view-transition-new(right-floating-controls) {
animation: none;
opacity: 1;
}
@@ -636,10 +643,9 @@ code {
/* A screen without a screenshot, or whose screenshot could not be read, frames its placeholder
where an image of --screenshot-width x --screenshot-height would sit under the rules above:
contained in the slot inside its border, never enlarged. It lines up with the screenshots
beside it, and a failed screenshot keeps the frame it waited in. A Map card's screenshot waits
over a backing of the same frame (below; a phone's Screens cell sizes it in phone.css). */
.screen-node-image:has(> :is(.image-placeholder, .screenshot-backing)) { container-type: size; }
.screen-node-image > :is(.image-placeholder, .screenshot-backing) {
beside it, and a failed screenshot keeps the frame it waited in. */
.screen-node-image:has(> .image-placeholder) { container-type: size; }
.screen-node-image > .image-placeholder {
--frame-border: 1px;
display: flex;
box-sizing: content-box;
@@ -673,28 +679,8 @@ code {
specificity. The Map leaves the border to the status and rings the card from outside instead. */
.screen-node-image:hover img,
.screen-screenshot-card.selected .screen-node-image img { border-color: var(--accent); box-shadow: 0 0 0 2px var(--accent); }
.screen-node-image:hover > :is(.image-placeholder, .screenshot-backing),
.screen-screenshot-card.selected .screen-node-image > :is(.image-placeholder, .screenshot-backing) { border-color: var(--accent); box-shadow: 0 0 0 2px var(--accent); }
/* A Map card, and a Screens card on a phone, draws its frame (fill, border, status and rings) on
the image itself, which is hidden while it loads. The backing draws the same frame under it, in
the image's geometry, while the image waits and while it fades in, so the frame and its rings
hold steady; then it hides. The fading image leaves its rings to the backing, so their soft lift
is not drawn twice, and takes them back in the frame the backing hides. */
.screen-node-image > .screenshot-backing {
position: absolute;
inset: 0;
margin: auto;
pointer-events: none;
visibility: hidden;
}
.screen-node-image:has(> .screenshot-backing) > img { position: relative; }
.screen-node-image:has(> img[data-screenshot-state="loading"]) > .screenshot-backing { visibility: visible; }
.screen-node-image:has(> img[data-screenshot-reveal]) > .screenshot-backing { animation: screenshot-backing var(--screenshot-reveal) step-end; }
.screen-node-image:has(> .screenshot-backing) > img[data-screenshot-reveal] {
animation: screenshot-reveal var(--screenshot-reveal) ease-out, screenshot-backed var(--screenshot-reveal) step-end;
}
@keyframes screenshot-backing { from, to { visibility: visible; } }
@keyframes screenshot-backed { from, to { box-shadow: none; } }
.screen-node-image:hover > .image-placeholder,
.screen-screenshot-card.selected .screen-node-image > .image-placeholder { border-color: var(--accent); box-shadow: 0 0 0 2px var(--accent); }
.canvas-active-frame {
position: relative;
display: block;
@@ -749,11 +735,11 @@ code {
--ring-status: 0px;
}
.map-surface .screen-screenshot-card:is(.diff-added, .diff-modified, .diff-removed) { --ring-status: 2px; }
.map-surface .screen-screenshot-card .screen-node-image :is(img, .image-placeholder, .screenshot-backing) {
.map-surface .screen-screenshot-card .screen-node-image :is(img, .image-placeholder) {
border-color: var(--border-subtle);
box-shadow: none;
}
.map-surface .react-flow__node-screen:is(.selected, .graph-node-hover-subject) .screen-screenshot-card .screen-node-image :is(img, .image-placeholder, .screenshot-backing) {
.map-surface .react-flow__node-screen:is(.selected, .graph-node-hover-subject) .screen-screenshot-card .screen-node-image :is(img, .image-placeholder) {
box-shadow:
0 0 0 var(--ring-status) var(--diff, transparent),
0 0 0 calc(var(--ring-status) + 4 * var(--ring-unit)) var(--screen),
@@ -1176,6 +1162,33 @@ code {
.inspector-resizing .right-panel-resize::before { opacity: 1; transition-delay: 0ms; }
/* While the edge is dragged nothing else may select or change the cursor. */
.inspector-resizing, .inspector-resizing * { cursor: col-resize !important; user-select: none !important; }
/* When minimised, the inspector actions join the camera controls as one floating toolbar. */
.right-float {
position: fixed;
z-index: 100;
top: var(--chrome-top);
right: var(--right-float-edge);
width: calc(var(--right-float-width) * var(--ui-scale));
height: var(--chrome-height);
display: flex;
align-items: center;
gap: 2px;
padding: calc(3px * var(--ui-scale));
border: 0;
border-radius: 0 calc(8px * var(--ui-scale)) calc(8px * var(--ui-scale)) 0;
background: var(--side-panel-surface);
box-shadow: none;
/* No backdrop blur: the surface is opaque, and a blurred backdrop leaves this toolbar's view
transition snapshot stale, so a button that moves into its place paints late. */
view-transition-name: right-floating-controls;
}
.right-float > * { zoom: var(--ui-scale); }
.right-float .icon-button.active { color: var(--text); background: var(--element); }
.right-float .icon-button[disabled] { color: var(--border); cursor: default; background: transparent; }
.right-float .icon-button:hover {
border-color: transparent;
background: var(--panel-hover);
}
.right-head {
display: flex;
flex: none;
@@ -1234,8 +1247,7 @@ code {
position: absolute;
z-index: 20;
top: var(--chrome-top);
/* Mirrors the pill: the same inset from the canvas' right edge as the pill's from its left. */
right: calc(var(--canvas-visible-right-inset, 0px) + var(--canvas-chrome-inline-inset));
right: calc(var(--canvas-visible-right-inset, 0px) + 8px);
display: inline-flex;
height: var(--chrome-height);
align-items: center;
@@ -1246,9 +1258,30 @@ code {
color: var(--text);
background: var(--side-panel-surface);
box-shadow: var(--floating-chrome-shadow);
/* No backdrop blur: with it, the view transition's snapshot of these controls painted late. */
/* No backdrop blur, as on .right-float: with it, entering Compare painted full screen late. */
view-transition-name: canvas-camera-controls;
}
.canvas-camera-controls.inspector-collapsed {
right: calc(
var(--canvas-visible-right-inset, 0px) +
var(--right-float-edge) + var(--right-float-width) * var(--ui-scale) - 1px
);
border: 0;
border-radius: calc(8px * var(--ui-scale)) 0 0 calc(8px * var(--ui-scale));
box-shadow: none;
}
.canvas-camera-controls.inspector-collapsed::before {
position: absolute;
z-index: -1;
top: 0;
right: calc((var(--right-float-width) * var(--ui-scale) - 1px) * -1);
bottom: 0;
left: 0;
border-radius: calc(8px * var(--ui-scale));
box-shadow: var(--floating-chrome-shadow);
content: "";
pointer-events: none;
}
.canvas-camera-controls .camera-action-button,
.canvas-camera-controls .zoom-button {
border: 0;
@@ -1272,6 +1305,7 @@ code {
flex: none;
background: var(--border-subtle);
}
.canvas-camera-controls.inspector-collapsed .camera-control-divider { display: none; }
.canvas-camera-controls .zoom-button:focus-visible {
outline: 2px solid var(--accent);
outline-offset: 1px;
@@ -1371,17 +1405,12 @@ code {
align-items: center;
justify-content: center;
}
/* The frame holds the fill, so a screenshot that is hidden while it loads leaves its frame in place.
Nothing clips to it: an outline's ring and measurement may cross the frame's edge. */
.inspector-diff-preview:has(> img) {
border-radius: 9px;
background: var(--subtle);
}
.inspector-diff-preview img {
display: block;
width: 100%;
height: 100%;
border-radius: 9px;
background: var(--subtle);
object-fit: cover;
}
/* The frame line is drawn over the screenshot's edge, not inside its box, so the image fills
@@ -1728,9 +1757,9 @@ code {
border-color: var(--diff);
box-shadow: 0 0 0 2px var(--diff);
}
.screen-screenshot-card .diff-frame.diff-added .screen-node-image > :is(.image-placeholder, .screenshot-backing),
.screen-screenshot-card .diff-frame.diff-modified .screen-node-image > :is(.image-placeholder, .screenshot-backing),
.screen-screenshot-card .diff-frame.diff-removed .screen-node-image > :is(.image-placeholder, .screenshot-backing) {
.screen-screenshot-card .diff-frame.diff-added .screen-node-image > .image-placeholder,
.screen-screenshot-card .diff-frame.diff-modified .screen-node-image > .image-placeholder,
.screen-screenshot-card .diff-frame.diff-removed .screen-node-image > .image-placeholder {
border-color: var(--diff);
box-shadow: 0 0 0 2px var(--diff);
}
@@ -1807,24 +1836,6 @@ code {
@media (prefers-reduced-motion: reduce) {
.screenshot-loading > svg { animation: none; }
}
/* A screenshot that is loading or could not be read is hidden at once, in the same frame as its
new source, so no view paints the picture of the source before (the browser keeps painting it
until the new one loads) under a new screen's name or outlines; its frame stays. Hiding never
fades, and outranks a view's own image opacity, such as a dimmed variant thumbnail's. A held
picture (the app icon) stays shown until the new one is there. */
:root img:is([data-screenshot-state="loading"]:not([data-screenshot-held]), [data-screenshot-state="failed"]) {
opacity: 0;
transition: none;
}
/* A picture that fills an empty frame fades in. An animation, not a transition: the image can be
ready before its first paint, and it keeps a view's own resting opacity. */
img[data-screenshot-reveal] { animation: screenshot-reveal var(--screenshot-reveal) ease-out; }
@keyframes screenshot-reveal { from { opacity: 0; } }
@media (prefers-reduced-motion: reduce) {
img[data-screenshot-reveal],
.screen-node-image:has(> .screenshot-backing) > img[data-screenshot-reveal],
.screen-node-image:has(> img[data-screenshot-reveal]) > .screenshot-backing { animation: none; }
}
.status-badge { display: inline-flex; align-items: center; width: fit-content; padding: 4px 7px; border-radius: 6px; color: var(--secondary); background: var(--element); font-size: 10px; font-weight: 500; line-height: 1.2; text-transform: capitalize; }
.status-badge.info { color: var(--accent-strong); background: var(--accent-soft); }
.status-badge.success { color: var(--success); background: var(--success-soft); }
@@ -2090,61 +2101,6 @@ img[data-screenshot-reveal] { animation: screenshot-reveal var(--screenshot-reve
.menu-row-shortcut { flex: none; margin-left: 16px; color: var(--tertiary); font-size: 11px; }
.menu-separator { height: 1px; margin: 4px 6px; background: var(--popover-line); }
/* ── More menu (the bottom bar's "…") ───────────────────────────────────── */
/* The menu is anchored to its button, but clears the bar the button sits in. The popover itself
is the surface, as the Changes menu's is: an anchored popover scrolls, and would clip a shadow
drawn by the list inside it. Only a window too short for the menu scrolls it. */
.menu-popover.more-menu {
overflow-x: hidden !important;
border: 1px solid var(--popover-line);
border-radius: calc(9px * var(--ui-scale));
background: var(--popover);
box-shadow: var(--popover-shadow);
translate: 0 calc(-12px * var(--ui-scale));
}
/* Rows read icon, label, control, key, in the menu's own type and colours. */
.more-menu-list { display: flex; width: 248px; flex-direction: column; padding: 4px; }
.more-menu-row {
display: flex;
width: 100%;
min-height: 34px;
align-items: center;
gap: 8px;
padding: 4px 6px 4px 8px;
border-radius: 5px;
color: var(--text);
background: transparent;
font-size: 12px;
text-align: left;
}
.more-menu-item:hover,
.more-menu-item:focus-visible { background: var(--popover-hover); outline: none; }
.more-menu-icon { display: flex; width: 16px; flex: none; align-items: center; justify-content: center; color: var(--secondary); }
.more-menu-icon > svg { width: 15px; height: 15px; }
.more-menu-label { min-width: 0; flex: 1; white-space: nowrap; }
.more-menu-check { display: flex; flex: none; color: var(--secondary); }
.more-menu-check > svg { width: 14px; height: 14px; }
/* The key column lines up down the menu, whatever the row holds before it. */
.more-menu-key { min-width: 22px; flex: none; text-align: center; }
/* A compact three-way switch: Auto, Light, Dark, on the segmented control's track and thumb. */
.more-theme-switch { display: flex; flex: none; gap: 2px; padding: 2px; border-radius: 7px; background: var(--segment-track); }
.more-theme-option {
display: flex;
width: 26px;
height: 22px;
align-items: center;
justify-content: center;
border-radius: 5px;
color: var(--tertiary);
background: transparent;
transition: color 120ms ease, background 120ms ease;
}
.more-theme-option > svg { width: 14px; height: 14px; }
.more-theme-option:hover { color: var(--text); }
.more-theme-option[aria-checked="true"] { color: var(--text); background: var(--segment-thumb); box-shadow: 0 1px 2px rgb(0 0 0 / 0.12); }
.more-theme-option:focus-visible { outline: 2px solid var(--accent); outline-offset: 0; }
/* ── Feedback dialog ────────────────────────────────────────────────────── */
.dialog-backdrop {
@@ -2291,8 +2247,7 @@ img[data-screenshot-reveal] { animation: screenshot-reveal var(--screenshot-reve
.search-command-result-copy code { color: inherit; font-size: inherit; }
.search-command-section + .search-command-section { margin-top: 4px; }
.search-command-section > .search-command-section-label { padding: 8px 8px 4px; }
.search-command-result-key,
.more-menu-key {
.search-command-result-key {
padding: 2px 6px;
border: 1px solid var(--border);
border-radius: 5px;
@@ -2448,28 +2403,7 @@ html [data-sonner-toaster][data-sonner-theme] {
flex: none; display: inline-flex; height: 24px; align-items: center; gap: 6px; margin: 0; padding: 0 8px 0 10px; border: 0; border-radius: 7px;
background: var(--element); color: var(--secondary); font: inherit; font-size: 12.5px; font-weight: 500; line-height: 16px; white-space: nowrap; cursor: pointer;
}
.collapsed-platform > svg { flex: none; width: 9px; height: 9px; }
/* What the phone's fit leaves out (AppPill's data-drop) is not drawn. */
.phone-layout .collapsed-app-identity[data-drop~="name"] > strong { display: none; }
.phone-layout .collapsed-app-identity[data-drop~="pr"] > .tooltip-anchor:has(> .collapsed-pr) { display: none; }
.collapsed-platform-label { display: flex; min-width: 0; overflow: hidden; }
.collapsed-platform-label-text { min-width: 0; overflow: hidden; }
.collapsed-platform-label-suffix { flex: none; white-space: pre; }
/* The name a phone's row keeps gives way first, cut to its end down to its minimum, and the target's chip after it,
down to its own; the fit reads both. */
.phone-layout .collapsed-app-identity { --collapsed-name-min: 64px; --collapsed-target-min: 72px; }
/* The target's label is the pill's one long configured text: once the phone's row has left out all it can, the name
holds at its minimum and the target's chip shrinks instead. */
.phone-layout .collapsed-app-identity[data-drop~="squeeze"] > strong { flex: none; max-width: var(--collapsed-name-min); }
.phone-layout .collapsed-app-identity[data-drop~="squeeze"] .collapsed-target { flex: 0 1 auto; min-width: var(--collapsed-target-min); }
.phone-layout .collapsed-app-identity[data-drop~="squeeze"] > .tooltip-anchor:has(> .collapsed-target) { flex: 0 1 auto; min-width: var(--collapsed-target-min); }
.phone-layout .collapsed-app-identity[data-drop~="pose"] .collapsed-target .collapsed-platform-label-suffix { flex: 0 1 auto; min-width: 0; overflow: hidden; }
/* The device's text gives way before the pose: it takes what the pose leaves, if anything. */
.phone-layout .collapsed-app-identity[data-drop~="pose"] .collapsed-target .collapsed-platform-label-text { flex: 1 1 0; }
/* A cut device or pose (AppPill's data-fade) fades out at its end rather than ending in "…" and the slack an ellipsis
leaves; the full name is a tap away in its menu. */
.phone-layout .collapsed-app-identity[data-fade~="device"] .collapsed-target .collapsed-platform-label-text,
.phone-layout .collapsed-app-identity[data-fade~="pose"] .collapsed-target .collapsed-platform-label-suffix { mask-image: linear-gradient(to right, #000 calc(100% - 16px), transparent); }
.collapsed-platform > svg { width: 9px; height: 9px; }
.collapsed-platform > .collapsed-platform-busy { width: 11px; height: 11px; animation: spin 1s linear infinite; }
.collapsed-platform:hover, .collapsed-platform[aria-expanded="true"] { color: var(--text); background: var(--hover); }
.collapsed-platform:focus-visible { outline: 2px solid var(--accent); outline-offset: 2px; }
+14 -52
View File
@@ -266,12 +266,8 @@ function validateManifest(value: unknown): PreviewManifest {
}
return manifest;
}
/**
* Eager screenshots (the Inspector's) are decoded before lazy ones (canvas nodes and thumbnails), and both before a
* prefetch (the screen Compare would step to next), which only takes a slot while PREFETCH_RESERVE others stay free.
*/
export type ScreenshotPriority = "eager" | "lazy" | "prefetch";
const PRIORITY_RANK: Record<ScreenshotPriority, number> = { eager: 0, lazy: 1, prefetch: 2 };
/** Eager screenshots (the Inspector's) are decoded before lazy ones (canvas nodes and thumbnails). */
export type ScreenshotPriority = "eager" | "lazy";
type ImageLoad = {
sha256: string;
users: number;
@@ -283,12 +279,6 @@ type ImageLoad = {
};
const DECODE_SLOTS = 4;
/**
* The slots a prefetch leaves free: a running read keeps its slot after it is let go, so these are what the two
* screenshots of the screen the reviewer does step to start in, whichever way that is. A prefetch waiting for a slot
* is dropped, unread, when it is let go first.
*/
const PREFETCH_RESERVE = 2;
/**
* Released screenshots keep their Blob URL, up to this many and this many bytes in all, so panning
* back needs no new decode.
@@ -309,7 +299,7 @@ export class ArtifactReportArchive {
/** Decoded screenshots nobody uses, least recently released first, and their total size. */
private readonly retained = new Map<string, { url: string; bytes: number }>();
private retainedBytes = 0;
private readonly queues: Record<ScreenshotPriority, ImageLoad[]> = { eager: [], lazy: [], prefetch: [] };
private readonly queues: Record<ScreenshotPriority, ImageLoad[]> = { eager: [], lazy: [] };
private disposed = false;
private running = 0;
private retainedLimit = RETAINED_SCREENSHOTS;
@@ -428,8 +418,7 @@ export class ArtifactReportArchive {
/**
* A verified Blob URL for an embedded screenshot. Each call is one use until `release`. At most
* four screenshots are read and hashed at once; eager requests wait ahead of lazy ones, and both
* ahead of a prefetch.
* four screenshots are read and hashed at once; eager requests wait ahead of lazy ones.
*/
async resolve(reference: string, priority: ScreenshotPriority = "lazy"): Promise<string> {
const sha256 = IMAGE_REFERENCE.exec(reference)?.[1];
@@ -440,7 +429,7 @@ export class ArtifactReportArchive {
const existing = this.loads.get(sha256);
if (existing) {
existing.users++;
if (PRIORITY_RANK[priority] < PRIORITY_RANK[existing.priority]) this.promote(existing, priority);
if (priority === "eager" && existing.priority === "lazy") this.promote(existing);
return existing.pending;
}
const kept = this.retained.get(sha256);
@@ -471,7 +460,7 @@ export class ArtifactReportArchive {
dispose(): void {
this.disposed = true;
for (const load of this.waitingLoads()) {
for (const load of this.queues.eager.splice(0).concat(this.queues.lazy.splice(0))) {
load.waiting?.drop(new Error("This report was closed."));
}
for (const load of this.loads.values()) if (load.url) URL.revokeObjectURL(load.url);
@@ -487,7 +476,7 @@ export class ArtifactReportArchive {
* used them releases them against the report shown next, so the ones still in use are dropped here instead.
*/
trim(): void {
for (const load of this.waitingLoads()) {
for (const load of this.queues.eager.splice(0).concat(this.queues.lazy.splice(0))) {
load.waiting?.drop(new Error("This screenshot is no longer in use."));
}
// What the Viewer was showing is kept as released, most recent last, so switching back shows it at once.
@@ -534,7 +523,7 @@ export class ArtifactReportArchive {
}
private acquireSlot(load: ImageLoad): Promise<void> {
if (this.running < this.slotsFor(load)) {
if (this.running < DECODE_SLOTS) {
this.running++;
return Promise.resolve();
}
@@ -544,11 +533,6 @@ export class ArtifactReportArchive {
});
}
/** How many slots may be running when `load` starts: all of them, or for a prefetch all but the reserve. */
private slotsFor(load: ImageLoad): number {
return load.priority === "prefetch" ? DECODE_SLOTS - PREFETCH_RESERVE : DECODE_SLOTS;
}
/** Hand a finished decode's slot to the next waiting load that someone still uses. */
private releaseSlot(): void {
for (let load = this.nextWaiting(); load; load = this.nextWaiting()) {
@@ -565,38 +549,16 @@ export class ArtifactReportArchive {
this.running--;
}
/**
* The next waiting load the slot being handed on may start. A prefetch waits while the other running loads would
* leave less than the reserve free, unless it was let go, which drops it.
*/
private nextWaiting(): ImageLoad | undefined {
const load = this.queues.eager[0] ?? this.queues.lazy[0] ?? this.queues.prefetch[0];
if (load && load.users > 0 && this.running > this.slotsFor(load)) return undefined;
return load ? this.queues[load.priority].shift() : undefined;
return this.queues.eager.shift() ?? this.queues.lazy.shift();
}
private waitingLoads(): ImageLoad[] {
return this.queues.eager.splice(0).concat(this.queues.lazy.splice(0), this.queues.prefetch.splice(0));
}
/**
* Move a load up to `priority`. A prefetch waiting for its reserve that the reviewer has stepped to starts at once
* when a slot is free, rather than waiting for a running read to finish.
*/
private promote(load: ImageLoad, priority: ScreenshotPriority): void {
const queue = this.queues[load.priority];
load.priority = priority;
const index = queue.indexOf(load);
private promote(load: ImageLoad): void {
load.priority = "eager";
const index = this.queues.lazy.indexOf(load);
if (index < 0) return;
queue.splice(index, 1);
if (load.waiting && this.running < this.slotsFor(load)) {
const waiting = load.waiting;
delete load.waiting;
this.running++;
waiting.start();
return;
}
this.queues[priority].push(load);
this.queues.lazy.splice(index, 1);
this.queues.eager.push(load);
}
/** Keep a released URL; beyond either limit the least recently released ones are revoked. */
+1 -2
View File
@@ -102,8 +102,7 @@ export function commandItems(context: CommandContext, actions: CommandActions):
{ keywords: ["app", "appearance", "scheme", "captured"], shortcut: !appearance.current && context.appearances.length === 2 ? key(SHORTCUTS.appearance.app) : undefined });
}
if (context.fullscreen !== undefined) {
add("view:fullscreen", "View", context.fullscreen ? "Exit full screen" : "Enter full screen", actions.toggleFullscreen,
{ keywords: ["fullscreen", "window", "focus"], shortcut: key(SHORTCUTS.view.fullscreen) });
add("view:fullscreen", "View", context.fullscreen ? "Exit full screen" : "Enter full screen", actions.toggleFullscreen, { keywords: ["fullscreen", "window", "focus"] });
}
for (const target of context.targets) {
+8 -9
View File
@@ -123,16 +123,15 @@ export function buildObservedGraph(map: ExploreMap, index: MapIndex): ObservedGr
};
}
const NONE: ReadonlySet<string> = new Set();
/**
* The Viewer can overlay declarations; the observed graph and event indexes stay intact. A public report preserves its
* complete source inventory, but the routes it never captured are not its screens: `omitted` names them, the one set
* every view of the report takes (omitted-screens.ts). The launch is never among them: it is where the app starts,
* drawn above the start screens with a synthetic edge into each of them.
*/
export function buildViewerGraph(map: ExploreMap, index: MapIndex, omitted: ReadonlySet<string> = NONE): ObservedGraph {
/** The Viewer can overlay declarations; the observed graph and event indexes stay intact. */
export function buildViewerGraph(map: ExploreMap, index: MapIndex): ObservedGraph {
const observed = buildObservedGraph(map, index);
// A public report preserves its complete source inventory, but an accepted capture gap
// marks a redirect or a route outside changes-mode selection. Neither is a screen image. The app
// launch is not a route, so its accepted "no splash observed" gap keeps it on the map: it is where
// the app starts, drawn above the start screens with a synthetic edge into each of them.
const omitted = new Set<string>();
if (map.run.id.startsWith("public:")) for (const gap of map.gaps) if (gap.status === "accepted" && gap.screenId && !isLaunchScreen({ id: gap.screenId })) omitted.add(gap.screenId);
const screens = observed.screens.filter(screen => !omitted.has(screen.id));
const visibleIds = new Set(screens.map(screen => screen.id));
const launchEdges = launchGroups(screens);
+4 -28
View File
@@ -43,39 +43,15 @@ export function useInspectorWidth(): number | undefined {
);
}
/** The room the bottom bar needs beside the Inspector, in window pixels: its measured width and a gap either side. */
let toolbarRoom = 0;
const toolbarListeners = new Set<() => void>();
/** The bottom bar reports the room it needs whenever its measured width changes (with `--ui-scale` too). */
export function setToolbarRoom(room: number) {
if (room === toolbarRoom) return;
toolbarRoom = room;
for (const listener of toolbarListeners) listener();
}
export function getToolbarRoom(): number {
return toolbarRoom;
}
export function subscribeToToolbarRoom(onChange: () => void): () => void {
toolbarListeners.add(onChange);
return () => toolbarListeners.delete(onChange);
}
export type InspectorWidthBounds = { min: number; max: number };
/**
* The widths the panel may take in a window `windowWidth` wide: at most half of it, so the canvas
* keeps the other half, and never so wide that the canvas beside it loses the `toolbarRoom` the
* bottom bar needs (window pixels), in the panel's own (unscaled) pixels when the chrome is zoomed
* by `scale`. Neither cap goes below the minimum.
* keeps the other half, in the panel's own (unscaled) pixels when the chrome is zoomed by `scale`.
*/
export function inspectorWidthBounds(windowWidth: number, scale = 1, room = 0): InspectorWidthBounds {
const zoom = scale > 0 ? scale : 1;
const half = Math.floor(windowWidth / 2 / zoom);
const besideBar = Math.floor((windowWidth - room) / zoom);
return { min: INSPECTOR_WIDTH_MIN, max: Math.max(INSPECTOR_WIDTH_MIN, Math.min(INSPECTOR_WIDTH_MAX, half, besideBar)) };
export function inspectorWidthBounds(windowWidth: number, scale = 1): InspectorWidthBounds {
const half = Math.floor(windowWidth / 2 / (scale > 0 ? scale : 1));
return { min: INSPECTOR_WIDTH_MIN, max: Math.max(INSPECTOR_WIDTH_MIN, Math.min(INSPECTOR_WIDTH_MAX, half)) };
}
export function clampInspectorWidth(width: number, bounds: InspectorWidthBounds): number {
+13 -16
View File
@@ -41,10 +41,9 @@ export type KeyPress = {
export type KeyHold = {
/**
* Starts holding `code` after its first step already landed. `step` takes the next step and
* says whether there was one; the hold ends by itself when there is not. `onEnd` hears the hold
* end, however it ends.
* says whether there was one; the hold ends by itself when there is not.
*/
begin: (code: string, step: () => boolean, onEnd?: () => void) => KeyPress;
begin: (code: string, step: () => boolean) => KeyPress;
/** Ends the hold as an interruption: another key, blur, a field or dialog taking the keyboard. */
end: () => void;
/** Ends the hold because `code` went up, if it is the key being held. */
@@ -54,8 +53,8 @@ export type KeyHold = {
* not end it, so ⇧ or ⌘ can join a held key. Call it first in the listener, before any guard.
*/
interrupt: (event: KeyboardEvent) => void;
/** Whether `code` is the key being held, or without one, whether any key is. */
holding: (code?: string) => boolean;
/** Whether `code` is the key being held. */
holding: (code: string) => boolean;
};
const MODIFIER_KEYS = new Set(["Shift", "Control", "Alt", "Meta"]);
@@ -116,20 +115,18 @@ export function glideWhileHeld(press: KeyPress, move: (steps: number) => boolean
/** One held key at a time, timed on the schedule above. */
export function createKeyHold(): KeyHold {
let current: { code: string; timer: ReturnType<typeof setTimeout>; press: { held: boolean; released: boolean }; onEnd?: (() => void) | undefined } | undefined;
let current: { code: string; timer: ReturnType<typeof setTimeout>; press: { held: boolean; released: boolean } } | undefined;
const finish = (released: boolean) => {
const ended = current;
current = undefined;
if (ended) {
clearTimeout(ended.timer);
ended.press.held = false;
ended.press.released = released;
ended.onEnd?.();
if (current) {
clearTimeout(current.timer);
current.press.held = false;
current.press.released = released;
}
current = undefined;
};
const end = () => finish(false);
return {
begin(code, step, onEnd) {
begin(code, step) {
end();
let count = 1;
const tick = () => {
@@ -140,7 +137,7 @@ export function createKeyHold(): KeyHold {
count += 1;
};
const state = { held: true, released: false };
current = { code, timer: setTimeout(tick, HOLD_INITIAL_DELAY_MS), press: state, onEnd };
current = { code, timer: setTimeout(tick, HOLD_INITIAL_DELAY_MS), press: state };
return {
get held() { return state.held; },
get released() { return state.released; },
@@ -154,6 +151,6 @@ export function createKeyHold(): KeyHold {
interrupt(event) {
if (current && !event.repeat && event.code !== current.code && !MODIFIER_KEYS.has(event.key)) end();
},
holding: (code) => (code === undefined ? current !== undefined : current?.code === code),
holding: (code) => current?.code === code,
};
}
Loaded 100 of 102 files, more files were not shown because too many files have changed in this diff. Show more