Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e4b1a14175 | ||
|
|
2452093cce | ||
|
|
e3675e1a20 | ||
|
|
9fd9a82c6e | ||
|
|
6015041803 | ||
|
|
7ab038cf98 | ||
|
|
0cc9363dfd | ||
|
|
ed31b0c767 | ||
|
|
b1edd7ea81 | ||
|
|
50230b7f93 | ||
|
|
33f31da08e | ||
|
|
7fc0f34c9b | ||
|
|
6daf0a4391 | ||
|
|
1796a9b810 | ||
|
|
87aec5b820 | ||
|
|
89f18cad05 | ||
|
|
bb8b73e16e | ||
|
|
7360502e86 | ||
|
|
6539b5c002 | ||
|
|
422cf8caf4 | ||
|
|
b281c734f4 | ||
|
|
c99c26f9bb | ||
|
|
9150a24cd9 | ||
|
|
2c5f8f85a3 | ||
|
|
23227ca55c | ||
|
|
ed1bf34434 | ||
|
|
bdf9e597d3 |
No files matched your search
@@ -61,7 +61,13 @@ jobs:
|
||||
env:
|
||||
# npm cannot generate provenance for a private repository.
|
||||
NPM_CONFIG_PROVENANCE: "false"
|
||||
run: npm publish --access public
|
||||
VERSION: ${{ steps.version.outputs.version }}
|
||||
shell: bash
|
||||
# A prerelease (0.20.0-next.0) goes to the next tag, so latest keeps the last release.
|
||||
run: |
|
||||
set -euo pipefail
|
||||
if [[ "$VERSION" == *-* ]]; then tag=next; else tag=latest; fi
|
||||
npm publish --access public --tag "$tag"
|
||||
- name: Tag the release
|
||||
if: steps.version.outputs.publish == 'true'
|
||||
env:
|
||||
|
||||
@@ -67,9 +67,12 @@ jobs:
|
||||
shell: bash
|
||||
env:
|
||||
COMMENT_ID: ${{ steps.comment.outputs.id }}
|
||||
# How long an alias can keep serving the previous push: an EAS Hosting edge that served it keeps it for about
|
||||
# five minutes (FIXTURE_ALIAS_WAIT_MS in src/report/preview-deploy.ts).
|
||||
ALIAS_CATCH_UP: 5 minutes
|
||||
run: |
|
||||
set -euo pipefail
|
||||
jq -r --arg marker "$MARKER" --arg sha "${SHA:0:7}" --arg run "$RUN_URL" '
|
||||
jq -r --arg marker "$MARKER" --arg sha "${SHA:0:7}" --arg run "$RUN_URL" --arg catchup "$ALIAS_CATCH_UP" '
|
||||
.previewUrl as $url
|
||||
| ([.reports[] | select(.platform == "android")] + [.reports[] | select(.platform != "android")]) as $reports
|
||||
| ($reports[0].source // "") as $source
|
||||
@@ -85,6 +88,8 @@ jobs:
|
||||
| ((.label // (if .platform == "ios" then "iOS" else "Android" end)) | gsub("\\|"; "\\\\|")) as $name
|
||||
| "| \($name)\(if .device then " · \(.device)" else "" end) | \(.changes // "–") | [Map](\($url)?\($query)) · [Screens](\($url)?\($query)#/screens) · [Compare](\($url)?\($query)&view=compare) |"),
|
||||
"",
|
||||
# The alias still served the previous push when the deploy stopped waiting for it: say so, and link the new deployment.
|
||||
(if .aliasBehind then "> **Going live:** this link can take up to \($catchup) to show \($sha); until then it shows the previous push, or nothing on a new pull request. [This push'"'"'s deployment](\(.deploymentUrl)/p/\($url | split("/p/")[1])) is live now.\n" else empty end),
|
||||
"The link stays the same on every push. [Deploy run](\($run))"]
|
||||
| join("\n")' "$RUNNER_TEMP/preview.json" > "$RUNNER_TEMP/comment.md"
|
||||
if [[ -n "$COMMENT_ID" ]]; then
|
||||
|
||||
@@ -49,16 +49,16 @@ Each workflow starts with a `targets` job: it installs the pinned CLI and runs `
|
||||
| | checkout `app-base`, `app-head` | Checks out the exact base and head SHAs with full history and without persisted credentials. |
|
||||
| | Verify deterministic source planning | `source:verify` builds the capture plan from source alone in two fresh processes and compares the bytes. Runs before any build or simulator work and needs no credentials. |
|
||||
| | Install app dependencies | `npm ci --ignore-scripts` in both checkouts (`APP_INSTALL_DIR` for monorepos). |
|
||||
| | Find / Download optional exact-base evidence | `ci:find-baseline` looks for a successful `explore-baseline-<base sha>-<target>` artifact (target `ios` also accepts the older unsuffixed `explore-baseline-<base sha>`) from the baseline workflow on the default branch and downloads it as `EXPLORE_CAPTURE_CACHE`. Missing evidence is not an error. |
|
||||
| | Find / Download optional exact-base evidence | `ci:find-baseline` looks for a finished run's `explore-baseline-<base sha>-<target>` artifact (a run another target's baseline failed in counts: a baseline job uploads its artifact only after its own steps passed) (target `ios` also accepts the older unsuffixed `explore-baseline-<base sha>`) from the baseline workflow on the default branch and downloads it as `EXPLORE_CAPTURE_CACHE`. Missing evidence is not an error. |
|
||||
| | Capture review | `capture:review` (§3). `EXPO_TOKEN`, the provider key and the app's `{{secret:NAME}}` values reach only this step. The sticky PR comment is updated while it runs. It writes `preview=<hosting>` to the step outputs, which decides whether the deploy job runs. |
|
||||
| | Stop capture sessions and check the checkouts | `ci:after-capture`, whenever the PR was resolved, success or not: stops the EAS Simulator sessions named in `head-session` / `base-session`, nothing else, then fails with `CHECKOUT_MODIFIED` if capture modified an app checkout. |
|
||||
| | Upload captured review / diagnostics | `explore-capture-<run>-<attempt>-<target>` feeds the report job. On failure `explore-diagnostics-<run>-<attempt>-<target>` keeps plans, exports and agent diagnostics for 7 days. |
|
||||
| report (matrix: target) | Install Explore, download the capture | Runs without Expo or model credentials. |
|
||||
| report (matrix: target) | Download the capture, install Explore | Runs without Expo or model credentials, after every capture job, whether or not each succeeded (`!cancelled()`). Each leg downloads its own target's capture by an exact-name pattern: a target whose capture failed uploaded none, so its leg packages and publishes nothing, and the other targets' reports still reach the comment. |
|
||||
| | Package hosted review bundle | `ci:report` writes the report directory. |
|
||||
| | Upload hosted review bundle | `explore-review-<run>-<attempt>-<target>`, kept 30 days. |
|
||||
| | Publish current PR hosted links | `ci:publish` re-checks that the artifact belongs to this PR, then updates the sticky comment with **Open** (the hosted Viewer) and **zip**. The comment is rendered from one hidden record per target (`<!-- expo-explore-record:<target>:… -->`, plus one history line for earlier runs); each job folds its own record into the ones the comment already carries and re-renders the whole comment, so parallel targets do not overwrite each other. Rows, report links and validation columns are labelled with the target's label (`iOS` and `Android` without `targets:`) and follow config order. |
|
||||
| `deploy` (only when `report.preview` is set; after every report job) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every target's capture and report artifacts, writes each report's manifest and screenshots as static files under the link's token, deploys them with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report**. The link works as long as the EAS Hosting deployment. |
|
||||
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only the failed target's record when the run has several; the target is the id the failed job's diagnostics artifact name ends with, and its label comes from the record the capture job already posted. |
|
||||
| `deploy` (only when `report.preview` is set; after every report job, once any of them published) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every capture and report artifact the run has (a target whose capture or report job failed has none and is left out), writes each report's manifest and screenshots as static files under the link's token, deploys them with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report**. The link works as long as the EAS Hosting deployment. |
|
||||
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only each failed target's record when the run has several; the target is the id the failed job's diagnostics artifact name ends with (or, when download-artifact extracted a lone artifact without its directory, the `target` its `error.json` records), and its label comes from the record the capture job already posted. Once the other targets published, the comment shows their reports and this failure, with no new-run line. |
|
||||
|
||||
A reviewer downloads the report ZIP and drops it on the hosted Viewer; downloading needs read access to the repository.
|
||||
|
||||
|
||||
@@ -4,32 +4,36 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
|
||||
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-hero-dark.svg">
|
||||
<img alt="Explore's Map of a euxy pull request, animated: the screen cards appear row by row, the new About screen marked Added among the modified Patterns screens, the transitions between them wipe in, then a click selects About, its transitions light up and the Inspector slides in on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.svg">
|
||||
<img alt="Explore's Map of a euxy pull request, animated: the screen cards appear row by row, the new /lane-editor/0 marked Added beside the removed /lane-editor and the modified /new-pattern, the transitions between them wipe in, then a click selects /lane-editor/0: a blue ring circles it, its transitions turn blue while the rest fade to hairlines, and the Inspector slides in on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.svg">
|
||||
</picture>
|
||||
|
||||
**See a real report:** [euxy](https://explore-example--euxy.expo.app/p/rfcoic27ccgnrmzgijubxkmuzmptcrva?platform=ios), a MIDI sequencer, reviewed by Explore. It is redeployed with the current Viewer on every merge to main.
|
||||
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-compare-dark.svg">
|
||||
<img alt="The euxy Patterns screen wiping from its capture before the pull request to its capture after it: each pattern row's tempo moves out of the subtitle into its own column on the right, then the changed subtitles are outlined" src="docs/screenshots/readme-compare-light.svg">
|
||||
<img alt="The euxy New Pattern sheet wiping from its capture before the pull request to its capture after it: the suggested pattern name and the row of pattern icons differ, and those regions are outlined on the after capture" src="docs/screenshots/readme-compare-light.svg">
|
||||
</picture>
|
||||
|
||||
**Compare**: each changed screen before and after, with the changed regions outlined.
|
||||
**Compare**: each changed screen before and after, with the changed regions outlined on the after.
|
||||
|
||||
<table>
|
||||
<tr>
|
||||
<td width="50%" valign="top">
|
||||
<a href="docs/screenshots/readme-screens-light.png">
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-screens-dark.png">
|
||||
<img width="100%" alt="The Screens view of a euxy review: the app/ route tree on the left under Changed 9 and All 19, and a grid of screen cards beside it in the same order, each with its route below the screenshot and a dot before it: green for the new /about, orange for modified screens such as /activity-log, /settings and /patterns, red for the removed /channel-surf" src="docs/screenshots/readme-screens-light.png">
|
||||
<img width="100%" alt="The Screens view of a euxy review showing Changed 7 of All 19: the app/ route tree on the left, and beside it a grid of the changed screens in the same order, each with its route below the screenshot: a red dot for the removed /lane-editor, orange for the modified /new-pattern and /channel-surf, green for the new /lane-editor/0, and Changed in dark under /p and /patterns" src="docs/screenshots/readme-screens-light.png">
|
||||
</picture>
|
||||
<strong>Screens</strong>: every capture in one grid, beside the route tree, with a dot for what changed.
|
||||
</a>
|
||||
<strong>Screens</strong>: every capture in one grid, or only the changed ones, beside the route tree, with a dot for what changed.
|
||||
</td>
|
||||
<td width="50%" valign="top">
|
||||
<a href="docs/screenshots/readme-pr-comment-light.png">
|
||||
<picture>
|
||||
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-pr-comment-dark.png">
|
||||
<img width="100%" alt="Explore's GitHub PR comment on a euxy PR: a heading with how many screens changed and a Review in Explore link, a line naming each device with a link to its report, and the changed screens as a short list, fading out below them" src="docs/screenshots/readme-pr-comment-light.png">
|
||||
<img width="100%" alt="Explore's GitHub PR comment on a euxy PR: the heading 2 screens changed with a Review in Explore link; a line of links to each device's report (iPhone 17, three iPhone Duo poses and Android) and to the two commits compared; then the changed screens as a list, /tempo with the text it added and the devices it is on, fading out below" src="docs/screenshots/readme-pr-comment-light.png">
|
||||
</picture>
|
||||
</a>
|
||||
<strong>A comment on every PR</strong>: with <a href="#set-up-ci">CI</a>, the report links and the added, removed and modified screens.
|
||||
</td>
|
||||
</tr>
|
||||
@@ -41,7 +45,9 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
|
||||
Paste this into Claude Code, Codex, Cursor, or any tool that can fetch a URL. In the Viewer, **Hand off to AI** fills it in for you:
|
||||
|
||||
```text
|
||||
Review the visual changes in this PR. Expo Explore report: <report link>
|
||||
Review the visual changes in PR #<number> of <owner>/<repo>.
|
||||
Expo Explore report:
|
||||
<report link>
|
||||
|
||||
Fetch the link first. It explains the report's JSON API. Go through the changed screens,
|
||||
compare the before and after screenshots, and tell me which changes look intended and
|
||||
@@ -298,7 +304,7 @@ platforms:
|
||||
easProfile: explore-android # android.buildType: apk in eas.json
|
||||
```
|
||||
|
||||
- The workflows run one capture job per platform, and the PR gets one comment with a section per platform.
|
||||
- The workflows run one capture job per platform, and the PR gets one comment that links each platform's report and lists the changed screens of both.
|
||||
- A failed platform fails the check; the other platform's report still publishes.
|
||||
- An Android-only app sets `app.platform: android` with no `platforms` map.
|
||||
|
||||
@@ -319,7 +325,8 @@ targets:
|
||||
|
||||
- A target takes the `app` fields it does not set, and `device.name` when it is of `app.platform`; a target of another platform sets its own `bundleId` and `easProfile` (an Android one's device defaults to `pixel_7`). `pose` is `closed`, `half-open` or `open`. `label` names it in reports (by default its device and pose).
|
||||
- Ids are up to 32 lowercase letters, digits and dashes, start with a letter, and are not `base`, `head` or `report`. A config names at most 8 targets. A config with `platforms` has one target per platform, named `ios` and `android`.
|
||||
- The workflows run one capture job per target, the PR comment has a section per target, and each report links its sibling targets' reports.
|
||||
- The workflows run one capture job per target. The PR comment links each target's report and says which targets a change is on, and each report links its sibling targets' reports.
|
||||
- A review runs at most `capture.maxSessions` EAS Simulator sessions at once across its targets (default 5, a typical plan's limit); see the [config reference](docs/quickstart-ci.md#config-reference).
|
||||
- A target can also set its own `controller` and `simulator` over `capture`'s, such as Android on agent-device beside iOS targets on Argent. `--controller` and `--simulator` override every target's for one run.
|
||||
- `capture --target duo-open` reviews one target on this machine; `--platform ios` the iOS ones. On your machine a review's targets run at once (at most `--parallel N`), and targets of one platform and EAS profile share each commit's build; in CI each target is its own job. A target that fails outright costs only its own report.
|
||||
- A device controller that stops answering on one screen costs that route, up to three times per capture: Explore restarts the app, goes on with the next route, and records what happened in `capture-diagnostics/controller-recoveries.jsonl`.
|
||||
@@ -580,7 +587,7 @@ npm test
|
||||
|
||||
- `npm test` rebuilds the CLI and the Viewer first, because the node tests run the compiled `dist/`. After one `npm run build`, `npm run test:node` skips the rebuild.
|
||||
- The agent runtimes and `eas-cli` are optional dependencies that only capture needs. Do not install with `--omit=optional`, which also drops esbuild's platform package.
|
||||
- To release, bump `version` in `package.json` and merge to main. The [publish workflow](.github/workflows/publish.yml) publishes any version npm does not have yet.
|
||||
- To release, bump `version` in `package.json` and merge to main. The [publish workflow](.github/workflows/publish.yml) publishes any version npm does not have yet. A prerelease version such as `0.20.0-next.0` goes to the `next` tag, so `latest` stays on the last release.
|
||||
|
||||
```sh
|
||||
npx playwright install chromium
|
||||
|
||||
@@ -157,6 +157,10 @@ runs:
|
||||
EXPO_TOKEN: ${{ inputs.expo_token }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
if [[ ! -e "$OUTPUT/head-session" && ! -L "$OUTPUT/head-session" && ! -e "$OUTPUT/base-session" && ! -L "$OUTPUT/base-session" ]]; then exit 0; fi
|
||||
node "$TOOLS/scripts/cleanup-ci-sessions.mjs" --eas "$TOOLS/node_modules/.bin/eas" \
|
||||
--session-file "$OUTPUT/head-session" --session-file "$OUTPUT/base-session"
|
||||
# A side that captures an appearance in a session of its own records it as <side>-session-<scheme>.
|
||||
files=()
|
||||
for name in head-session base-session head-session-light head-session-dark base-session-light base-session-dark; do
|
||||
if [[ -e "$OUTPUT/$name" || -L "$OUTPUT/$name" ]]; then files+=(--session-file "$OUTPUT/$name"); fi
|
||||
done
|
||||
if (( ${#files[@]} == 0 )); then exit 0; fi
|
||||
node "$TOOLS/scripts/cleanup-ci-sessions.mjs" --eas "$TOOLS/node_modules/.bin/eas" "${files[@]}"
|
||||
@@ -103,6 +103,8 @@ exploration:
|
||||
capture:
|
||||
maxMinutes: 30
|
||||
maxActions: 500
|
||||
# maxSessions: 5 # the most EAS Simulator sessions one review runs at once, across all its targets and sides (default: 5, a typical plan's concurrent simulator limit). Each target's job gets floor(maxSessions / targets) sessions, at least one, and sessions left over go to foldable targets (pose): one target gets 5 (head and base at once, light and dark in their own sessions when that pays), two get 2 each, five get 1 each (head, then base). Below the number of targets, only that many target jobs run at once (the workflow's max-parallel, and a local review's targets), one session each. A side spreads its light and dark passes over separate sessions only when that saves it at least a minute, so the ceiling is a limit, not a target: a 3-route target stays on two sessions. euxy's four targets: 8 is two per target, 16 captures each appearance in its own session (measured: an iPhone side 6:12 → 4:26, one repack shared by its sessions, ~3.5 session-minutes more per side).
|
||||
# On a starter plan (one simulator per platform), set maxSessions to the plan's limit, e.g. 2 for an iOS and an Android target.
|
||||
repack: eas # eas (hosted workflow job; the default on EAS Simulator) | local (repack-app on the runner; the default with simulator: local)
|
||||
appearance: auto # auto (follow the app's userInterfaceStyle: automatic captures light and dark) | dark | light | [dark, light]
|
||||
launch: screenshot # screenshot (relaunch the app per appearance and keep its splash and first settled frame, default) | video (also keep a launch recording in the report) | off
|
||||
|
||||
@@ -109,6 +109,8 @@ capture:
|
||||
# simulator: eas # eas (EAS Simulator, default) | local (a simulator or emulator Explore starts on this machine with Xcode or the Android SDK; --simulator overrides it for one run)
|
||||
maxMinutes: 30
|
||||
maxActions: 500
|
||||
# maxSessions: 5 # the most EAS Simulator sessions one review runs at once, across all its targets and sides (default: 5, a typical plan's concurrent simulator limit). Each target's job gets floor(maxSessions / targets) sessions, at least one, and sessions left over go to foldable targets (pose): one target gets 5 (head and base at once, light and dark in their own sessions when that pays), two get 2 each, five get 1 each (head, then base). Below the number of targets, only that many target jobs run at once (the workflow's max-parallel, and a local review's targets), one session each. A side spreads its light and dark passes over separate sessions only when that saves it at least a minute, so the ceiling is a limit, not a target: a 3-route target stays on two sessions. euxy's four targets: 8 is two per target, 16 captures each appearance in its own session (measured: an iPhone side 6:12 → 4:26, one repack shared by its sessions, ~3.5 session-minutes more per side).
|
||||
# On a starter plan (one simulator per platform), set maxSessions to the plan's limit, e.g. 2 for an iOS and an Android target.
|
||||
repack: eas # eas (hosted EAS workflow job, the default on EAS Simulator) | local (repack-app on the runner, the default with simulator: local; --repack overrides it for one run)
|
||||
appearance: auto # auto (follow the app's userInterfaceStyle: automatic captures light and dark) | dark | light | [dark, light]
|
||||
launch: screenshot # screenshot (relaunch the app per appearance and keep its splash and first settled frame, default) | video (also keep a launch recording in the report) | off
|
||||
@@ -130,7 +132,7 @@ platforms:
|
||||
easProfile: explore-android
|
||||
```
|
||||
|
||||
Commands that capture or publish (`source:verify`, `capture:review`, `capture:baseline`, `ci:report`, `ci:publish`) take `--platform ios|android`; with one configured platform it is optional, with two it is required (`PLATFORM_REQUIRED`). `expo-explore config:platforms` prints the configured list as JSON, which the workflows use as their matrix. Artifacts carry the platform (`explore-capture-<run>-<attempt>-android`, `explore-baseline-<sha>-ios`); an iOS job still reuses an older unsuffixed baseline. The PR comment has one section per platform, and a hosted preview serves both reports from one link.
|
||||
Commands that capture or publish (`source:verify`, `capture:review`, `capture:baseline`, `ci:report`, `ci:publish`) take `--platform ios|android`; with one configured platform it is optional, with two it is required (`PLATFORM_REQUIRED`). `expo-explore config:platforms` prints the configured list as JSON, which the workflows use as their matrix. Artifacts carry the platform (`explore-capture-<run>-<attempt>-android`, `explore-baseline-<sha>-ios`); an iOS job still reuses an older unsuffixed baseline. The PR comment is one list of changed screens that says which platforms each is on, and a hosted preview serves both reports from one link.
|
||||
|
||||
### Several devices (targets)
|
||||
|
||||
@@ -215,7 +217,7 @@ exploration:
|
||||
- /c/[channel]
|
||||
```
|
||||
|
||||
An excluded route stays in its neighbors' navigation context (a screen that links to it is still captured when it changes), but neither revision captures it, it is left off the map and the screen counts, and a change to it gets no before/after comparison. A name that matches no route at either compared revision fails the plan with `EXCLUDE_ROUTE_UNKNOWN`; `doctor` warns about it first. Prefer `parameters` or `setup` when a route does show a screen.
|
||||
An excluded route stays in its neighbors' navigation context (a screen that links to it is still captured when it changes), but neither revision captures it, it is left off the report (the Map, Screens, search and the screen counts), and a change to it gets no before/after comparison. A name that matches no route at either compared revision fails the plan with `EXCLUDE_ROUTE_UNKNOWN`; `doctor` warns about it first. Prefer `parameters` or `setup` when a route does show a screen.
|
||||
|
||||
Capture handles iOS's confirmation to open a link in the expected app. After a form submits a password, iOS may offer to save or update it depending on the simulator's AutoFill state; capture declines that prompt with Not Now in both modes, never stores the credential, and records each decision in `capture-diagnostics/system-prompts.jsonl`. Do not script that tap in setup. Include required system-alert handling in setup or app instructions; Explore does not automatically grant application permissions.
|
||||
|
||||
|
||||
@@ -1 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /patterns screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(1,4,9,0.6)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#151B23"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#151B23" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCANqAZIDASIAAhEBAxEB/8QAHAABAAICAwEAAAAAAAAAAAAAAAMFBAYBAgcI/8QAWBAAAQMDAQQECwQHBAUKBQQDAQACAwQFERIGEyExFEFR0QcVIjJSU2GBkZKTNFRxsQgjM2OhouEWQmLBJHJ1gtIYNkNVVrKz1OLwFzdzlJUmNThEg8Px/8QAGAEBAQEBAQAAAAAAAAAAAAAAAAEDAgT/xAAdEQEBAAMBAAMBAAAAAAAAAAAAEQECAwQSMUFR/9oADAMBAAIRAxEAPwD5UREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBFs2wdn2aut0kftXeZrbbaZgkdHTRa6ircXACKIHgHHOdTuAAXptz8CuzVB4X9sLRPUXCHZPZS3suVSWva6olbuI37priManOecHHIY9qDwxF6dtdsfspd/B5Dt9sZT19sp4Lj4suNurZxPuXFupkrHhoJaRwII5nhy449DsjsFs/tZc6faXa2K8Wm3UQqIDZ8g3KcgEQNeQQzBJy49nUeQecovVdtdiNjpdktlNsrGa/Z2gvVdJQ1NLXvNTuGscA6eNzWhz2AZyMZzwCu6fYTwZbVWvaaLZ2j2lo4rHbpa2n2jrZR0atdHgBroyxujWT5IB1ezIwg8PREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEReh+C3YDZbaenr7xthtdDZLXb3sjdSwDXW1TneaImYPPB4gO4jl1oPPEX0xUeDTwVMt5kqvB34VrbQacm7vpc7tvrHMy4hvXnR7l414T9iLNsXdaQbP7U0O0druEHSaeaA4ljZnGmVv913A+3gcgckGmIvQPA/4M5PCZtDFao5IY3SF+XzaiyJjG5c4hpBceLQACOJ4ngve/wDkWUn/AGlt3/4qf/ziD5ERfXf/ACLKT/tJbv8A8VP/AOcXgHhU8GtT4P8AaOstGGSvpHfrHQajG5hYx7ZAHZLQQ8Agk4IPEhBoaIiAiIgIiICIiAiIgIiIJaRwZVQucQAHtJJ6uK+jL54QNlLp4afCLQTXyljsW1tqit8F2YdcMM7aeIMc4j+4HBwJ6j2DJXzciD17aipsuwXgiOwlNtBar/d7rdm3GsltMxmp6eBjNLGCTABeSM+zjnqzjbJbPeC7a3wkSOddp9ntkKWGObc3ioa2eqeAAYg9uQ0F2SSMkDlgnh5UiD2HwsNprxe7Vc7xtlsxWWKKojoIbTs1O6R1so+JJjY6NoOA3ieZcR1YxttnqLBsfZ7xS3vwmWLarYQ0M8dssYeZqt0jsmI7osG4e0k+UCME9XV84ogIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgszQ2/pMEfTsxvYS93onsURpaPo1TJ0r9ZHIWxtx57e1YKIMuvp6aDddGqN9qbl3+ErI2a2iuGyV+ob7aZWRV1DKJYXPYHgEdoPAjGQqxEH0HV+HF9u2Lt+1Nr8I21VXttUTaaq01W7dQMx553OjS1mCNJack9mDjwKsq5q+rnq6l+ueeR0sjsAanOOScDgOJ6lCiD1DwD+Eel8HG1ENzqoRPGzeMki3jY3Pje0AlrnEN1AtacOIBGeIX0t/yuNiP+rLz9eg/80vhlEH3N/wArjYj/AKsvP16D/wA0vmbwzeEwbb7WXC7UDRTMrf1Zia9shZCGRsDXOHAuOgk6SQMgZPFeZIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIilhpZ6jO6ie/HMgcB+JQRIsw2qrAzu2fUb3rHlp5YDiSNzOzI5oI0REBERARSw0s9RndRPfjmQOA/Eqc2qLine truncated
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /new-pattern screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(1,4,9,0.6)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#151B23"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#151B23" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCAQ4AfEDASIAAhEBAxEB/8QAHAABAAIDAQEBAAAAAAAAAAAAAAQFAgMGBwEI/8QAXxAAAQMDAQQFBggJCAYHBwMFAQACAwQFEQYSEyExFEFRUpEHImFxgbEVMjM0U2JykhYjQlRVc6HR0gg2dJOUssHhFxg1ZcLwJDdDRIKVsyUmVld1otOD4vEnRWOjw//EABYBAQEBAAAAAAAAAAAAAAAAAAABAv/EABgRAQEBAQEAAAAAAAAAAAAAAAABEUEh/9oADAMBAAIRAxEAPwD8qIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiD1PyJz6Bo7rQHUdokv16rrnDRUtDMB0SGN7mtM0gIw8+ccN4jhx7Vca9o/J/pfy36r/CC0vNqt4Y+is9uYII6iXYjwwloAYzi4kj9vJeceTUhvlF0sSQALvSZJ/XNXTfyj3Nf5adTOa4OBmjwQcj5JiDpf5Q9o0zTaz0Y+mtdFp613KzUlVVst1M1gjD5H7btloG04N6zxOAouiPJporWHlxZYbBc6q66SpYjWzTytLHysYwFzOIacF5Dc4HAn1qb/KIdb5dR+TwXCSXoP4N0AqXU+DI2PbftbOeG1jOMrX5NNW6E0F5d2zWCtrPwTrYHUBqq4YfHvGDLjwHmiQDiRwHqQdNozUmlfLTqq6eT6u0XYLTQTQzi0VdvpGx1FK6Pi0lw+NkDJ6jjHWuA015SH2FtLpJvk00VerhBMaMTVdrZLUVEm2RhzjzOeC9I8nvkvqPIrra66/1XXUEOn7ZDO6gniqWPdXueCGBjQc5LSeB6z2cVx/kRpqWjrNS+WDUEUbqOx7yWlhcfnFdJktaPs7Q9Rc0oMP5TrrBbr9ZtO2ux2O2XO3UYfdX2mlZBE+okDTsYaASGgZGe8vFVNvV4rdQ3etu9xmM9ZWzPnmkP5T3HJ9XPkoSAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICKdabcy5SvjdMItlu1yzlbKW0sqKWpnNS1phJAGPjYQVqKxfa2MtTK7pALnHGxj04Xy52tlBDBI2cS70ZxjkgsNBWex37V1ttuo7v8D2qeTZnrNnOwMEgdgycDaPAZyeS/TemZ9OQ7dF5IvI3HqmnpiY3326buOOZw5lkk3Fw9Rb6l+RF7T5JPKRd9RTWbye3/AF3cNNafi2mU9RQ4ile8nzInzc2tznBORxAPDGA9S1LLpmpcyh8rnkdj0lDUkRx322bt8cTzy25IR5vtLvSF+Y9eWey2DVtytunrv8MWynlLIawNxtjrHYcHhtDgcZC9G8rXlJvFjlvPk8smuK/UunXuY2Worw2SZr2k7cbZebmZAyeXDA4Zz40g9D8jGjWa01VbrSJWwS11XuN+WB5hjbE+V7mg8NotjwCeWV+tmfyZ9ItaA67alJHM9OAz7Nhfk3yJavj0bqy3XYwGpfQVZndTscA+WJ8MkT9jPAuAkyB14X67Z/KR0I5gc431hIyWm0zkjwaQgj/6tGkP0rqb+3j+BV2of5M2njZqw2283yOrbE50Rqp2zxFwGQHMLeIKu/8AWP0F373/AOU1H8CrtQfyk9JMs9WLXS3qtrXxObDE6gkhYXEYBc94Aa3tKD8T6hs76aZ9ZBAGUrmxOds/FjfIza2R6ODsKkV7qO8STzPoYZ2vpmtha/Y4te+NmzkHsyXYVEgIiICIiAiIgIiICIiAiIgIiLine truncated
|
||||
|
Before Width: | Height: | Size: 107 KiB After Width: | Height: | Size: 103 KiB |
@@ -1 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /patterns screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(17,17,17,0.14)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#F6F8FA"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#F6F8FA" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCANqAZIDASIAAhEBAxEB/8QAHQABAAEFAQEBAAAAAAAAAAAAAAECAwQFBgcICf/EAFkQAAEDAwICBwQHBAYFCgQDCQEAAgMEBREGEiExBxMUQVFSkSIyYaEVM1NxgZLhCCNisRgkNELR0xZWlJXBJTdDcnN1gqKz8Bdjk9QmNTY4RlV0g4Sy0vH/xAAYAQEBAQEBAAAAAAAAAAAAAAAAAQIDBP/EABoRAQEBAQEBAQAAAAAAAAAAAAARAQIDIQT/2gAMAwEAAhEDEQA/APpxERFEREBERAREQEREBERAREQEREBERARYl0u9uslI6sulfSUFMz3pqmVsbB+LiAuCuH7RnRXbZDHNq6mkcOH9XgmmHqxhHzQekIvKv6UPRP8A6zSf7vqf8tP6UPRP/rNJ/u+p/wAtB6qi8q/pQ9E/+s0n+76n/LT+lD0T/wCs0n+76n/LQeqovKv6UPRP/rNJ/u+p/wAtP6UPRP8A6zSf7vqf8tB6qi8q/pQ9E/8ArNJ/u+p/y0/pQ9E/+s0n+76n/LQeqovKv6UPRP8A6zSf7vqf8tP6UPRP/rNJ/u+p/wAtB6qi8vpv2mOiipeGN1W1hP2lFUMHqY8Lt9O6z03q2IyWG+W65hoy4U07XuZ/1mg5H4hBuUREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBFq9TXK4Wix1NZabTJeK9m1sFFHIIzK9zg0ZceDWjOSe4Aryaz9NOobTofXl91ZTW2W4aauLqCKChDmxPkO1rW5JJI3uHHngIPbUXkdFq/X+jdTaYpNcVFor6DUzzTf1KndC+3VRbubHkuO9p93J48M93HprprLVD7Vqf6F0ZXPudrnbTW9lW5rIrhuIHWtOR7DcknjxAxnOQA7ZF5PZ9Va6030lWLSOqrjZ73HfaSeoD6GmMD6F0TdxyMndGfdBOCT4YwadM9I2trl0s02nb9Z6KzWyutUlxpqPcZKpjWybGmVwO0OOCdoHAEDOcoPWkREBERAXE9LvSdQ9FWkZbzUMbUVkrupoqUnHXSkZ4+DQOJP4cyF2y+MP2wtRT3LpIpbNvPZrVRM2s7usk9pzvxb1Y/BB5NrLXWodfXZ901DcpqyZxOxhOI4R5WN5NH3fjkrQIiIIiICIiAiIgIiICIiAsm3XKttFbFXW+rno6qF26OaCQsew+II4hYyIPtX9nDp2m6RaaTTuopGfT9HH1kc4AaK2IcCcDgHt4ZxzBz3Fe5L83ujTUU+k9f2C8wPLDTVsW/H96Nztr2/i0uH4r9IUUREQEREBEXn/AEn681RpmooLRpHSc15udwY97aqc7KKla3mZH5HLI4Et4Hn3IPQEXzbT9JHSk+vEdL0g9Flyrt3C0sqcb3fZtfhoLu7G/wDFew9GetbxrK11Zv8Apiu09c6Cfs1RDOMxSOxndE7+83iPhxGCeaDsUXBdLnSTH0bWCW6SRyyNjDcMh2h8r3uw1oLgQ0cHEkg8BwHFeEf0y6r/AFcuH+9IP/tEH1oi+TP6ZdV/q5cP96Qf/aL3rou6R6bXunaS7ZfEyrb+7bPtEjXhz2ujJbgOILCQQBkEcAUHcoiICIiAiIgIiICIiAiIgLwGp6ML/qTSPSxZ+xS0lVdL/JXW0zjY2oDHMe0tJ4YdtLc8uK9+RB4pPUak6WdV6LbU6RvNgpNP1QudznuUIiY6oY3DI4eJ6wF2fa8F2t0uut9MWrVF1qKCl1AWTA2S321jhMYzhoEue8E5OM8A74AdsiDxHogq7jBqB9x1Lo3V79U3r2a281tGxlLSsALhDH7ZLIhgAcMuOCe7HS3CxXOT9oK13xlDO62Radlpn1Yb+7bKZiQwnxxxwvSUQEREBERAXxV+19Yprd0ox3NzD1FzoYnsf3FzMsc37wA0/wDiC+1VLine truncated
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1000 600" width="1000" height="600" role="img" aria-label="The /new-pattern screen of euxy wiping from its capture before the pull request to its capture after it, with the changed regions outlined"><style>.after{animation:wipe 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes wipe{0.00%{clip-path:inset(0 100% 0 0)}14.29%{clip-path:inset(0 100% 0 0)}37.14%{clip-path:inset(0 0 0 0)}82.86%{clip-path:inset(0 0 0 0)}97.14%{clip-path:inset(0 100% 0 0)}100.00%{clip-path:inset(0 100% 0 0)}}.divider{opacity:0;animation:divider 7s cubic-bezier(.65,0,.35,1) infinite}@keyframes divider{0.00%{transform:translateX(0);opacity:0}11.43%{transform:translateX(0);opacity:1}14.29%{transform:translateX(0);opacity:1}37.14%{transform:translateX(248px);opacity:1}41.43%{transform:translateX(248px);opacity:0}82.86%{transform:translateX(248px);opacity:0}85.71%{transform:translateX(248px);opacity:1}97.14%{transform:translateX(0);opacity:1}100.00%{transform:translateX(0);opacity:0}}.regions{animation:regions 7s ease-in-out infinite}@keyframes regions{0.00%{opacity:0}38.57%{opacity:0}44.29%{opacity:1}51.43%{opacity:.3}58.57%{opacity:1}81.43%{opacity:1}85.71%{opacity:0}100.00%{opacity:0}}.before-label{opacity:.3;animation:before-label 7s linear infinite}.after-label{animation:after-label 7s linear infinite}@keyframes before-label{0.00%{opacity:1}25.71%{opacity:1}28.57%{opacity:.3}88.57%{opacity:.3}91.43%{opacity:1}100.00%{opacity:1}}@keyframes after-label{0.00%{opacity:.3}25.71%{opacity:.3}28.57%{opacity:1}88.57%{opacity:1}91.43%{opacity:.3}100.00%{opacity:.3}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><clipPath id="stage"><rect width="1000" height="600" rx="16"/></clipPath><clipPath id="phone"><rect x="376" y="30" width="248" height="540" rx="40"/></clipPath><filter id="shadow" x="-20%" y="-20%" width="140%" height="140%"><feDropShadow dx="0" dy="8" stdDeviation="14" flood-color="rgba(17,17,17,0.14)"/></filter></defs><g clip-path="url(#stage)"><rect width="1000" height="600" fill="#F6F8FA"/><rect x="376" y="30" width="248" height="540" rx="40" fill="#F6F8FA" filter="url(#shadow)"/><g clip-path="url(#phone)"><image href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9YWVogAAAAAAAA9tYAAQAAAADTLXBhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABtbHVjAAAAAAAAAAEAAAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAYEBAUEBAYFBQUGBgYHCQ4JCQgICRINDQoOFRIWFhUSFBQXGiEcFxgfGRQUHScdHyIjJSUlFhwpLCgkKyEkJST/2wBDAQYGBgkICREJCREkGBQYJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCT/wAARCAQ4AfEDASIAAhEBAxEB/8QAHQABAAEFAQEBAAAAAAAAAAAAAAUCAwQGBwEICf/EAGMQAAEDAwEEBAcHDgoGBwcFAQEAAgMEBREGEiExkQcTQVEUFSJSU2FxFjI1c4GxsggXMzRCcoKSk5ShwdHSGCM2VFVWYnSk4jdDdaKzwiQlRVeV4eMmRmaD0/DxJ0RjZKNl/8QAFgEBAQEAAAAAAAAAAAAAAAAAAAEC/8QAGhEBAQEBAQEBAAAAAAAAAAAAABEBIUECMf/aAAwDAQACEQMRAD8A62iIiiIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIi0npd163QGkJq2Eg3CpPg9I0+eRvcfU0ZPtwO1BhdI/TVYuj97qHBuN1xnwWJwAjzw23fc+ziuF336orXV2ld4JV01qhPCOlhaTj1ufk59mFzWqqp66plqqmV808zy+SR5y5zickkq0iNom6UdbzvLn6qu+T5tS5o5Aqj65etP61Xn87f+1a0iDZfrl60/rVefzt/7U+uXrT+tV5/O3/tWtIg2X65etP61Xn87f8AtT65etP61Xn87f8AtWtIg2X65etP61Xn87f+1Prl60/rVefzt/7VrSINl+uXrT+tV5/O3/tT65etP61Xn87f+1a0iDZfrl60/rVefzt/7U+uXrT+tV5/O3/tWtIg2X65etP61Xn87f8AtVTOk7W0bg5uqrzkd9U8/rWsIg6PZvqgdfWmVpkukdxiHGKrha4H8JuHfpXaejrp/susqmK2XOEWm5ykNjDn5imd3NceBPYD7MlfJ69BLSCCQRvBCD9BUXLegPpFk1ppyS3XGUyXS2bLHvccmaI+9f7dxB9gPaupIoiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiAiIgIiICIiDk/TU/Wsdoutwt92Nms1thjkY6leW1FXIXNBG0DljRn5VIzs1hfdE6dhs10FDHU28S3C5yEvqG4Y3AZk52nZd5XZjOcrP6bWl3Rbfw0Ekws3D4xik9Hgjo8tIIIPiyPd/8sINO6KL5qSv6HXXKmfLeb2Hz9QK2cuMjg7cC5x/WrnSLrDU9p0TYqQRx23Ul9nio5OqdtCmLvflp37+A4nGTg7srD6F/HEHQrmyQwuugkqDTsqNzC/b3ZVzpSsupbjozTt+qKKKe92OpiraumpcuBH3ewN5OCGn2ZQYN+oLp0O3SwXan1Hd7nbq2rZR3KCvnMrXbX+sbngRvPyBbb0nakr4GUOldPzFl+vb+rjkYcGlhHv5iRvGBw9eccFpOrNU0XTPcdOae03DVzQx1jK24zSQuY2mjbxaSRx3n1Zwp2p0b0gUWvLvqe01GnZ3VjWwQG4CVzoIW8GNDcAZO88eHtQX+gysuVRbtQU1yutdc3UV2lpo5qyZ0r9huAN7icd66auM9ALNRiu1G6sNvFvNxqDOGNeJDU7QyW53dXjPHfwXZkBERAREQF80fVTXOSbUtptu1/FU9KZcf2nuwTyaF9Lr5o+qmtckOpLTctn+KqKUw5/tMdnHJwQcQRERBERAREQEREBERAREQEREBERAREQdO+p1uclB0l0sDXYZWQSwvHeNnaH6WhfXC+R/qdbXJcOkulna3LKOCWd57t2yP0uC+uEXBERARYlxrXUMbHti6zaOOPBUT3F8NRBEICRKASc8MoM5FhNr3OuDqTqTgD3+fUlBXurJJWOhMfVnjnigw9X3K62jTldXWS2+M7hCzMVNnG2c7z68DJwN5xhcIvsV7k2arpI6TX6fmnG2200G298TTw2mRbh8ufavpBcu6Line truncated
|
||||
|
Before Width: | Height: | Size: 109 KiB After Width: | Height: | Size: 113 KiB |
@@ -1 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /about and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.33%{opacity:0;transform:scale(.92)}8.08%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}4.00%{opacity:0;transform:scale(.92)}7.75%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}4.67%{opacity:0;transform:scale(.92)}8.42%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}6.08%{opacity:0;transform:scale(.92)}9.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}6.41%{opacity:0;transform:scale(.92)}10.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}6.75%{opacity:0;transform:scale(.92)}10.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}7.08%{opacity:0;transform:scale(.92)}10.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}3.66%{opacity:0;transform:scale(.92)}7.41%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}7.41%{opacity:0;transform:scale(.92)}11.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}7.75%{opacity:0;transform:scale(.92)}11.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}8.08%{opacity:0;transform:scale(.92)}11.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}8.42%{opacity:0;transform:scale(.92)}12.17%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}10.83%{clip-path:inset(0 0 100% 0)}21.67%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(978.5px,714.0px)}25.83%{opacity:0;transform:translate(978.5px,714.0px)}27.50%{opacity:1;transform:translate(978.5px,714.0px)}35.83%{opacity:1;transform:translate(718.5px,505.2px)}36.67%{opacity:1;transform:translate(718.5px,505.2px) scale(.82)}37.92%{opacity:1;transform:translate(718.5px,505.2px)}45.83%{opacity:0;transform:translate(718.5px,505.2px)}100.00%{opacity:0;transform:translate(718.5px,505.2px)}}.sel{animation:sel 12s ease-out infinite}@keyframes sel{0.00%{opacity:0}36.67%{opacity:0}39.17%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}37.08%{opacity:0;transform:translateX(48px)}42.08%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{opacity:0;animation:cover 12s linear infinite}@keyframes cover{0.00%{opacity:1}1.67%{opacity:0}94.17%{opacity:0}100.00%{opacity:1}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><image id="empty" width="1376" height="774" href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAALine truncated
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /lane-editor/0 and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.44%{opacity:0;transform:scale(.92)}8.19%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}7.86%{opacity:0;transform:scale(.92)}11.61%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}7.19%{opacity:0;transform:scale(.92)}10.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}9.27%{opacity:0;transform:scale(.92)}13.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}4.77%{opacity:0;transform:scale(.92)}8.52%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}8.19%{opacity:0;transform:scale(.92)}11.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}9.60%{opacity:0;transform:scale(.92)}13.35%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}9.94%{opacity:0;transform:scale(.92)}13.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}10.27%{opacity:0;transform:scale(.92)}14.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}10.61%{opacity:0;transform:scale(.92)}14.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}6.85%{opacity:0;transform:scale(.92)}10.60%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}10.94%{opacity:0;transform:scale(.92)}14.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c12{transform-origin:0 0;animation:c12 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c12{0.00%{opacity:0;transform:scale(.92)}11.27%{opacity:0;transform:scale(.92)}15.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c13{transform-origin:0 0;animation:c13 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c13{0.00%{opacity:0;transform:scale(.92)}11.61%{opacity:0;transform:scale(.92)}15.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c14{transform-origin:0 0;animation:c14 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c14{0.00%{opacity:0;transform:scale(.92)}7.52%{opacity:0;transform:scale(.92)}11.27%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}13.75%{clip-path:inset(0 0 100% 0)}24.58%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(853.5px,575.2px)}28.75%{opacity:0;transform:translate(853.5px,575.2px)}30.42%{opacity:1;transform:translate(853.5px,575.2px)}38.75%{opacity:1;transform:translate(593.5px,355.2px)}39.58%{opacity:1;transform:translate(593.5px,355.2px) scale(.82)}40.83%{opacity:1;transform:translate(593.5px,355.2px)}48.75%{opacity:0;transform:translate(593.5px,355.2px)}100.00%{opacity:0;transform:translate(593.5px,355.2px)}}.sel{animation:sel 12s linear infinite}@keyframes sel{0.00%{opacity:0}39.58%{opacity:0}40.42%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}40.00%{opacity:0;transform:translateX(48px)}45.00%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{oLine truncated
|
||||
|
Before Width: | Height: | Size: 1.4 MiB After Width: | Height: | Size: 1.2 MiB |
@@ -1 +1 @@
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /about and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.33%{opacity:0;transform:scale(.92)}8.08%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}4.00%{opacity:0;transform:scale(.92)}7.75%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}4.67%{opacity:0;transform:scale(.92)}8.42%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}6.08%{opacity:0;transform:scale(.92)}9.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}6.41%{opacity:0;transform:scale(.92)}10.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}6.75%{opacity:0;transform:scale(.92)}10.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}7.08%{opacity:0;transform:scale(.92)}10.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}3.66%{opacity:0;transform:scale(.92)}7.41%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}7.41%{opacity:0;transform:scale(.92)}11.16%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}7.75%{opacity:0;transform:scale(.92)}11.50%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}8.08%{opacity:0;transform:scale(.92)}11.83%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}8.42%{opacity:0;transform:scale(.92)}12.17%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}10.83%{clip-path:inset(0 0 100% 0)}21.67%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(978.5px,714.0px)}25.83%{opacity:0;transform:translate(978.5px,714.0px)}27.50%{opacity:1;transform:translate(978.5px,714.0px)}35.83%{opacity:1;transform:translate(718.5px,505.2px)}36.67%{opacity:1;transform:translate(718.5px,505.2px) scale(.82)}37.92%{opacity:1;transform:translate(718.5px,505.2px)}45.83%{opacity:0;transform:translate(718.5px,505.2px)}100.00%{opacity:0;transform:translate(718.5px,505.2px)}}.sel{animation:sel 12s ease-out infinite}@keyframes sel{0.00%{opacity:0}36.67%{opacity:0}39.17%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}37.08%{opacity:0;transform:translateX(48px)}42.08%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{opacity:0;animation:cover 12s linear infinite}@keyframes cover{0.00%{opacity:1}1.67%{opacity:0}94.17%{opacity:0}100.00%{opacity:1}}@media (prefers-reduced-motion: reduce){*{animation:none!important}}</style><defs><image id="empty" width="1376" height="774" href="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gHYSUNDX1BST0ZJTEUAAQEAAAHIAAAAAAQwAABtbnRyUkdCIFhZWiAH4AABAAEAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAACRyWFlaAAABFAAAABRnWFlaAAABKAAAABRiWFlaAAABPAAAABR3dHB0AAABUAAAABRyVFJDAAABZAAAAChnVFJDAAABZAAAAChiVFJDAAABZAAAAChjcHJ0AAABjAAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAAgAAAAcAHMAUgBHAEJYWVogAAAAAAAAb6IAADj1AAADkFhZWiAALine truncated
|
||||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1600 900" width="1600" height="900" role="img" aria-label="Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects /lane-editor/0 and the Inspector opens on it"><style>.c0{transform-origin:0 0;animation:c0 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c0{0.00%{opacity:0;transform:scale(.92)}4.44%{opacity:0;transform:scale(.92)}8.19%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c1{transform-origin:0 0;animation:c1 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c1{0.00%{opacity:0;transform:scale(.92)}7.86%{opacity:0;transform:scale(.92)}11.61%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c2{transform-origin:0 0;animation:c2 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c2{0.00%{opacity:0;transform:scale(.92)}7.19%{opacity:0;transform:scale(.92)}10.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c3{transform-origin:0 0;animation:c3 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c3{0.00%{opacity:0;transform:scale(.92)}9.27%{opacity:0;transform:scale(.92)}13.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c4{transform-origin:0 0;animation:c4 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c4{0.00%{opacity:0;transform:scale(.92)}4.77%{opacity:0;transform:scale(.92)}8.52%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c5{transform-origin:0 0;animation:c5 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c5{0.00%{opacity:0;transform:scale(.92)}8.19%{opacity:0;transform:scale(.92)}11.94%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c6{transform-origin:0 0;animation:c6 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c6{0.00%{opacity:0;transform:scale(.92)}9.60%{opacity:0;transform:scale(.92)}13.35%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c7{transform-origin:0 0;animation:c7 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c7{0.00%{opacity:0;transform:scale(.92)}9.94%{opacity:0;transform:scale(.92)}13.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c8{transform-origin:0 0;animation:c8 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c8{0.00%{opacity:0;transform:scale(.92)}10.27%{opacity:0;transform:scale(.92)}14.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c9{transform-origin:0 0;animation:c9 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c9{0.00%{opacity:0;transform:scale(.92)}10.61%{opacity:0;transform:scale(.92)}14.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c10{transform-origin:0 0;animation:c10 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c10{0.00%{opacity:0;transform:scale(.92)}6.85%{opacity:0;transform:scale(.92)}10.60%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c11{transform-origin:0 0;animation:c11 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c11{0.00%{opacity:0;transform:scale(.92)}10.94%{opacity:0;transform:scale(.92)}14.69%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c12{transform-origin:0 0;animation:c12 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c12{0.00%{opacity:0;transform:scale(.92)}11.27%{opacity:0;transform:scale(.92)}15.02%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c13{transform-origin:0 0;animation:c13 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c13{0.00%{opacity:0;transform:scale(.92)}11.61%{opacity:0;transform:scale(.92)}15.36%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.c14{transform-origin:0 0;animation:c14 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes c14{0.00%{opacity:0;transform:scale(.92)}7.52%{opacity:0;transform:scale(.92)}11.27%{opacity:1;transform:scale(1)}100.00%{opacity:1;transform:scale(1)}}.full{animation:full 12s cubic-bezier(.45,0,.25,1) infinite}@keyframes full{0.00%{clip-path:inset(0 0 100% 0)}13.75%{clip-path:inset(0 0 100% 0)}24.58%{clip-path:inset(0 0 0 0)}100.00%{clip-path:inset(0 0 0 0)}}.ptr{opacity:0;animation:ptr 12s cubic-bezier(.4,0,.2,1) infinite}@keyframes ptr{0.00%{opacity:0;transform:translate(853.5px,575.2px)}28.75%{opacity:0;transform:translate(853.5px,575.2px)}30.42%{opacity:1;transform:translate(853.5px,575.2px)}38.75%{opacity:1;transform:translate(593.5px,355.2px)}39.58%{opacity:1;transform:translate(593.5px,355.2px) scale(.82)}40.83%{opacity:1;transform:translate(593.5px,355.2px)}48.75%{opacity:0;transform:translate(593.5px,355.2px)}100.00%{opacity:0;transform:translate(593.5px,355.2px)}}.sel{animation:sel 12s linear infinite}@keyframes sel{0.00%{opacity:0}39.58%{opacity:0}40.42%{opacity:1}100.00%{opacity:1}}.insp{animation:insp 12s cubic-bezier(.2,.8,.2,1) infinite}@keyframes insp{0.00%{opacity:0;transform:translateX(48px)}40.00%{opacity:0;transform:translateX(48px)}45.00%{opacity:1;transform:translateX(0)}100.00%{opacity:1;transform:translateX(0)}}.cover{oLine truncated
|
||||
|
Before Width: | Height: | Size: 1.4 MiB After Width: | Height: | Size: 1.1 MiB |
|
Before Width: | Height: | Size: 151 KiB After Width: | Height: | Size: 149 KiB |
|
Before Width: | Height: | Size: 147 KiB After Width: | Height: | Size: 147 KiB |
|
Before Width: | Height: | Size: 169 KiB After Width: | Height: | Size: 157 KiB |
|
Before Width: | Height: | Size: 179 KiB After Width: | Height: | Size: 167 KiB |
|
Before Width: | Height: | Size: 640 KiB After Width: | Height: | Size: 315 KiB |
|
Before Width: | Height: | Size: 642 KiB After Width: | Height: | Size: 316 KiB |
@@ -1,12 +1,12 @@
|
||||
{
|
||||
"name": "@expo/explore",
|
||||
"version": "0.19.8",
|
||||
"version": "0.20.2",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "@expo/explore",
|
||||
"version": "0.19.8",
|
||||
"version": "0.20.2",
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@expo/repack-app": "0.10.1",
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@expo/explore",
|
||||
"version": "0.19.8",
|
||||
"version": "0.20.2",
|
||||
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
|
||||
"license": "MIT",
|
||||
"type": "module",
|
||||
@@ -50,7 +50,7 @@
|
||||
"test:node": "node --test test/node/*.test.mjs",
|
||||
"test:hosting": "npm --prefix viewer-host run typecheck && npm --prefix viewer-host test",
|
||||
"test:viewer:artifacts": "node --test test/browser/artifact-report.browser.mjs test/browser/artifact-cache.browser.mjs",
|
||||
"test:viewer:browser": "node --test test/browser/screenshot-image.browser.mjs test/browser/swipe-outlines.browser.mjs test/browser/inspector-notes.browser.mjs test/browser/inspector-variants.browser.mjs test/browser/inspector-source-navigation.browser.mjs test/browser/map-edge-presentation.browser.mjs test/browser/local-ci-view.browser.mjs test/browser/report-viewer.browser.mjs",
|
||||
"test:viewer:browser": "node --test test/browser/screenshot-image.browser.mjs test/browser/swipe-outlines.browser.mjs test/browser/split-outlines.browser.mjs test/browser/inspector-notes.browser.mjs test/browser/inspector-variants.browser.mjs test/browser/inspector-source-navigation.browser.mjs test/browser/map-edge-presentation.browser.mjs test/browser/local-ci-view.browser.mjs test/browser/report-viewer.browser.mjs",
|
||||
"test:viewer:e2e": "npm run test:viewer:browser && playwright test",
|
||||
"typecheck": "tsc -p tsconfig.json --noEmit && tsc -p viewer/tsconfig.json --noEmit",
|
||||
"lint": "eslint .",
|
||||
|
||||
@@ -10,7 +10,8 @@ const SESSION_ID = /^[A-Za-z0-9][A-Za-z0-9._-]{0,199}$/;
|
||||
|
||||
/** Stop only exact sessions whose ownership the capture coordinator already verified. */
|
||||
export async function cleanupCiSessions({ sessionFiles, easCommand, environment = process.env, runCommand = spawnSync }) {
|
||||
if (!Array.isArray(sessionFiles) || sessionFiles.length > 3) throw new Error('Provide at most three explicit session handoff files.');
|
||||
// head, base and baseline, each with a session per appearance pass (light, dark) beside its own.
|
||||
if (!Array.isArray(sessionFiles) || sessionFiles.length > 9) throw new Error('Provide at most nine explicit session handoff files.');
|
||||
const temporary = await realpath(environment.RUNNER_TEMP || tmpdir());
|
||||
const result = { stopped: [], failures: [] };
|
||||
let project;
|
||||
|
||||
@@ -25,19 +25,40 @@ function keyframes(name, loop, frames) {
|
||||
return `@keyframes ${name}{${frames.map(([at, css]) => `${((at / loop) * 100).toFixed(2)}%{${css}}`).join("")}}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* The Map card of `route`: the screenshot button of the node whose id is that route's surface in `review`. The button
|
||||
* is named after the screen's title, which is not the route when the report has plain titles.
|
||||
*/
|
||||
export function mapCard(page, review, route) {
|
||||
const surface = review.surfaces.find(s => (s.head ?? s.base)?.route === route && s.colorScheme !== "dark");
|
||||
if (!surface) throw new Error(`The report has no screen at ${route}.`);
|
||||
return page.locator(`.react-flow__node-screen[data-id="${surface.id}"] .screen-screenshot-target`);
|
||||
}
|
||||
|
||||
/**
|
||||
* Photographs the hero's states from a Viewer page whose Map has its camera set and nothing selected: the Map without
|
||||
* its screens, without its edges, and whole; then it clicks `select`, which opens the Inspector without moving the
|
||||
* camera, and photographs that. Returns the frames and where each screen card, the Inspector and the selected card are.
|
||||
* camera, and photographs that (`card` is its screenshot button, from mapCard). Returns the frames and where each screen card, the Inspector and the selected card are.
|
||||
*/
|
||||
export async function captureHeroFrames(page, { select, viewport }) {
|
||||
export async function captureHeroFrames(page, { select, card: target, viewport }) {
|
||||
const shoot = () => page.screenshot({ type: "jpeg", quality: JPEG_QUALITY });
|
||||
const neutral = () => page.mouse.move(viewport.width - 4, viewport.height - 4);
|
||||
// Park the pointer on bare canvas, found once the camera is set: over a card it takes a grey ring and darkens the
|
||||
// card's transitions, over a transition it darkens that one, and over a control it can raise a tooltip.
|
||||
const rest = await page.evaluate(({ width, height }) => {
|
||||
for (let y = height - 120; y > 120; y -= 20) for (let x = 40; x < width - 40; x += 20) {
|
||||
if (document.elementFromPoint(x, y)?.classList.contains("react-flow__pane")) return { x, y };
|
||||
}
|
||||
return null;
|
||||
}, viewport);
|
||||
if (!rest) throw new Error("The hero's Map has no bare canvas to park the pointer on.");
|
||||
const neutral = async () => {
|
||||
await page.mouse.move(rest.x, rest.y);
|
||||
await page.waitForTimeout(200);
|
||||
if (await page.locator(".canvas-hovering, .graph-node-hover-subject").count()) throw new Error("The pointer at rest still hovers the Map.");
|
||||
};
|
||||
const rect = locator => locator.boundingBox().then(b => b && { x: Math.round(b.x), y: Math.round(b.y), width: Math.round(b.width), height: Math.round(b.height) });
|
||||
const camera = () => page.locator(".react-flow__viewport").evaluate(el => el.style.transform);
|
||||
const target = page.locator(`.screen-screenshot-target[title="${select}"]`);
|
||||
|
||||
// A card under the pointer dims the others and highlights its edges; let that fade before the first frame.
|
||||
await neutral();
|
||||
await page.waitForTimeout(1000);
|
||||
const at = await camera();
|
||||
@@ -124,8 +145,9 @@ export function heroSvg(frames, theme, alt) {
|
||||
]));
|
||||
defs.push(`<clipPath id="canvas"><rect x="0" y="0" width="${p.x}" height="${v.height}"/></clipPath>`);
|
||||
defs.push(`<clipPath id="panel"><rect ${box(p)}/></clipPath>`);
|
||||
css.push(`.sel{animation:sel ${LOOP}s ease-out infinite}`);
|
||||
css.push(keyframes("sel", LOOP, [[0, "opacity:0"], [CLICK + 0.1, "opacity:0"], [CLICK + 0.4, "opacity:1"], [LOOP, "opacity:1"]]));
|
||||
// The selection lands as the Viewer draws it, at once: a ring and its transitions in the accent, nothing fading.
|
||||
css.push(`.sel{animation:sel ${LOOP}s linear infinite}`);
|
||||
css.push(keyframes("sel", LOOP, [[0, "opacity:0"], [CLICK + 0.1, "opacity:0"], [CLICK + 0.2, "opacity:1"], [LOOP, "opacity:1"]]));
|
||||
css.push(`.insp{animation:insp ${LOOP}s cubic-bezier(.2,.8,.2,1) infinite}`);
|
||||
css.push(keyframes("insp", LOOP, [[0, "opacity:0;transform:translateX(48px)"], [CLICK + 0.15, "opacity:0;transform:translateX(48px)"], [CLICK + 0.75, "opacity:1;transform:translateX(0)"], [LOOP, "opacity:1;transform:translateX(0)"]]));
|
||||
layers.push(`<use class="sel" href="#inspecting" clip-path="url(#canvas)"/>`);
|
||||
@@ -237,7 +259,7 @@ export async function compareSvg(browser, report, surface, theme, alt) {
|
||||
+ `<g class="divider"><rect x="${x - 1.5}" y="${y}" width="3" height="${PH}" fill="${t.accent}"/><circle cx="${x}" cy="${y + PH / 2}" r="13" fill="${t.accent}"/>`
|
||||
+ `<path d="M${x - 5} ${y + PH / 2 - 4}l-3 4l3 4M${x + 5} ${y + PH / 2 - 4}l3 4l-3 4" stroke="#fff" stroke-width="1.8" fill="none" stroke-linecap="round" stroke-linejoin="round"/></g>`
|
||||
+ `<g class="regions">${regions}</g>`
|
||||
+ label("before-label", "end", x - 44, "Before", `${pullRequest.base.ref} ·${pullRequest.base.sha.slice(0, 7)}`)
|
||||
+ label("before-label", "end", x - 44, "Before", `${pullRequest.base.ref} · ${pullRequest.base.sha.slice(0, 7)}`)
|
||||
+ label("after-label", "start", x + PW + 44, "After", `PR #${pullRequest.number} · ${pullRequest.head.sha.slice(0, 7)}`, `${count} changed region${count === 1 ? "" : "s"}`)
|
||||
+ "</g></svg>";
|
||||
}
|
||||
@@ -13,12 +13,14 @@
|
||||
// It becomes readme-compare-*.svg, its before capture wiping to its after capture
|
||||
// --pr a GitHub PR URL whose Explore comment becomes readme-pr-comment-light.png (public repository): the comment
|
||||
// at its own size on a soft stage, cut off with a fade after the list of changed screens
|
||||
// --only the pictures to write, comma-separated, of hero, compare, screens and pr-comment; default all of them (the
|
||||
// PR comment only with --pr). --only pr-comment needs no --report
|
||||
import { chromium } from "@playwright/test";
|
||||
import { readFile, writeFile } from "node:fs/promises";
|
||||
import { parseArgs } from "node:util";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { startReportViewer } from "../test/ci/lib/report-viewer.mjs";
|
||||
import { captureHeroFrames, compareSurface, compareSvg, heroSvg, openReport } from "./readme-animations.mjs";
|
||||
import { captureHeroFrames, compareSurface, compareSvg, heroSvg, mapCard, openReport } from "./readme-animations.mjs";
|
||||
|
||||
const { values: args } = parseArgs({
|
||||
options: {
|
||||
@@ -27,25 +29,36 @@ const { values: args } = parseArgs({
|
||||
compare: { type: "string", default: "patterns" },
|
||||
pr: { type: "string" },
|
||||
zoom: { type: "string", default: "73" },
|
||||
only: { type: "string" },
|
||||
},
|
||||
});
|
||||
if (!args.report) {
|
||||
const PICTURES = ["hero", "compare", "screens", "pr-comment"];
|
||||
const only = args.only?.split(",").map(name => name.trim()).filter(Boolean);
|
||||
const unknown = only?.filter(name => !PICTURES.includes(name)) ?? [];
|
||||
if (unknown.length) {
|
||||
console.error(`Unknown --only ${unknown.join(", ")}; pass some of ${PICTURES.join(", ")}.`);
|
||||
process.exit(2);
|
||||
}
|
||||
const wanted = name => !only || only.includes(name);
|
||||
const fromReport = PICTURES.filter(name => name !== "pr-comment").some(wanted);
|
||||
if (fromReport && !args.report) {
|
||||
console.error("Pass --report <review report zip>. See skills/readme-refresh/SKILL.md for where the euxy report comes from.");
|
||||
process.exit(2);
|
||||
}
|
||||
|
||||
const out = fileURLToPath(new URL("../docs/screenshots/", import.meta.url));
|
||||
const SHOTS = [
|
||||
{ file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: "Fit canvas", select: args.select, zoom: Number(args.zoom), animated: true },
|
||||
{ file: "readme-screens", hash: "#/screens", viewport: { width: 1760, height: 1000 } },
|
||||
];
|
||||
{ name: "hero", file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: page => page.getByRole("button", { name: "Fit canvas" }), select: args.select, zoom: Number(args.zoom), animated: true },
|
||||
// Screens shows its Changed filter, so the added, removed and modified dots are all in view wherever the tree sorts them.
|
||||
{ name: "screens", file: "readme-screens", hash: "#/screens", viewport: { width: 1760, height: 1000 }, click: page => page.locator(".screens-chip", { hasText: "Changed" }) },
|
||||
].filter(shot => wanted(shot.name));
|
||||
|
||||
const bytes = await readFile(args.report);
|
||||
const report = await openReport(bytes);
|
||||
const { server, url } = await startReportViewer({ bytes, watch: false });
|
||||
const bytes = fromReport ? await readFile(args.report) : undefined;
|
||||
const report = bytes && await openReport(bytes);
|
||||
const { server, url } = bytes ? await startReportViewer({ bytes, watch: false }) : {};
|
||||
const browser = await chromium.launch();
|
||||
try {
|
||||
for (const theme of ["light", "dark"]) {
|
||||
for (const theme of wanted("compare") ? ["light", "dark"] : []) {
|
||||
const surface = compareSurface(report.review, args.compare, theme);
|
||||
const path = `${out}readme-compare-${theme}.svg`;
|
||||
await writeFile(path, await compareSvg(browser, report, surface, theme,
|
||||
@@ -60,20 +73,20 @@ try {
|
||||
await page.waitForSelector(".react-flow__node, .compare-stage, .screens-cell", { timeout: 60_000 });
|
||||
await page.waitForTimeout(4000);
|
||||
if (shot.click) {
|
||||
await page.getByRole("button", { name: shot.click }).click();
|
||||
await shot.click(page).click();
|
||||
await page.mouse.move(400, shot.viewport.height - 30);
|
||||
await page.waitForTimeout(1500);
|
||||
}
|
||||
if (shot.select && !shot.animated) {
|
||||
// Selecting a screen opens the Inspector without moving the fitted camera. The animated hero selects it last.
|
||||
await page.locator(`.screen-screenshot-target[title="${shot.select}"]`).click();
|
||||
await mapCard(page, report.review, shot.select).click();
|
||||
await page.mouse.move(400, shot.viewport.height - 30);
|
||||
await page.waitForTimeout(1500);
|
||||
}
|
||||
if (shot.zoom) {
|
||||
// Zoom around the selected screen with the wheel, which keeps it under the pointer, then pan it left and up, clear
|
||||
// of the minimap and the bottom bar. The camera stops at the first wheel step past the zoom asked for.
|
||||
const box = await page.locator(`.screen-screenshot-target[title="${shot.select}"]`).boundingBox();
|
||||
const box = await mapCard(page, report.review, shot.select).boundingBox();
|
||||
await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2);
|
||||
for (let step = 0; step < 60; step++) {
|
||||
if (Number((await page.locator(".zoom-button span").first().textContent()).replace("%", "")) >= shot.zoom) break;
|
||||
@@ -88,14 +101,14 @@ try {
|
||||
}
|
||||
const path = `${out}${shot.file}-${theme}.${shot.animated ? "svg" : "png"}`;
|
||||
if (shot.animated) {
|
||||
const frames = await captureHeroFrames(page, { select: shot.select, viewport: shot.viewport });
|
||||
const frames = await captureHeroFrames(page, { select: shot.select, card: mapCard(page, report.review, shot.select), viewport: shot.viewport });
|
||||
await writeFile(path, heroSvg(frames, theme,
|
||||
`Explore's Map of a euxy pull request: the screen cards appear row by row, the transitions between them wipe in, then a click selects ${shot.select} and the Inspector opens on it`));
|
||||
} else await page.screenshot({ path });
|
||||
console.log(path);
|
||||
await context.close();
|
||||
}
|
||||
for (const theme of args.pr ? ["light", "dark"] : []) {
|
||||
for (const theme of args.pr && wanted("pr-comment") ? ["light", "dark"] : []) {
|
||||
// Signed-out github.com follows prefers-color-scheme.
|
||||
const context = await browser.newContext({ viewport: { width: 1000, height: 1400 }, deviceScaleFactor: 2, colorScheme: theme });
|
||||
const page = await context.newPage();
|
||||
@@ -122,7 +135,7 @@ try {
|
||||
}
|
||||
} finally {
|
||||
await browser.close();
|
||||
await server.close?.();
|
||||
await server?.close?.();
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -12,8 +12,8 @@ This is a repository-maintenance skill (it is not shipped in the npm package; `s
|
||||
The README's screenshots and its live example (`https://explore-example--euxy.expo.app/p/<token>`, deployed by `.github/workflows/example-report.yml`) must show the same report. The example serves the `viewer-preview-fixtures` release, the same reports every pull request's Viewer preview uses, so start there:
|
||||
|
||||
```sh
|
||||
gh release download viewer-preview-fixtures --pattern reports.json --output - | jq -r '.[0].source' # e.g. brentvatne/euxy#154
|
||||
mkdir -p ~/euxy-report && gh release download viewer-preview-fixtures --pattern ios.zip --dir ~/euxy-report --clobber
|
||||
gh release download viewer-preview-fixtures --pattern reports.json --output - | jq -r '.[0] | "\(.target) \(.source)"' # e.g. iphone brentvatne/euxy#163
|
||||
mkdir -p ~/euxy-report && gh release download viewer-preview-fixtures --pattern iphone.zip --dir ~/euxy-report --clobber
|
||||
```
|
||||
|
||||
Keep those fixtures when their euxy PR still shows a real change (an added or removed screen, modified screens with outlined regions). To move to a newer euxy PR, open its Explore comment and follow **iOS report** to the hosted link `https://euxy-explore--<id>.expo.app/p/<token>`. Then refresh the fixtures from that link and download them again:
|
||||
@@ -28,13 +28,13 @@ Do not pick a same-tree demo PR, where every change is noise. The refreshed fixt
|
||||
|
||||
```sh
|
||||
npm ci
|
||||
node scripts/readme-screenshots.mjs --report ~/euxy-report/ios.zip --select /about --compare patterns --pr https://github.com/brentvatne/euxy/pull/<n>
|
||||
node scripts/readme-screenshots.mjs --report ~/euxy-report/iphone.zip --select /lane-editor/0 --compare new-pattern --pr https://github.com/brentvatne/euxy/pull/<n>
|
||||
```
|
||||
|
||||
- `--select` is the route the hero's pointer clicks on the Map (the Inspector opens on it): choose an added or clearly modified screen. The script zooms in around it, so it must be a screen the Map shows.
|
||||
- `--compare` is the key in the Viewer's `#/compare/<key>` URL for a **modified** screen with outlined regions (open the report, click the screen in Compare, copy the key): the route without its slash. The script fails if the report has no visually modified screen at that route.
|
||||
- `--pr` screenshots the Explore comment on that PR: the fixtures' `source`. Headless Chromium needs a colour emoji font for the result glyphs (`sudo apt-get install fonts-noto-color-emoji` on Debian/Ubuntu); a comment with hollow boxes where 🟩 should be is not acceptable.
|
||||
- The script serves the report through the Viewer's Vite dev server, so no build is needed. It writes a `-light` and a `-dark` file for every picture (the PR comment too: signed-out github.com follows `prefers-color-scheme`). The README shows each pair with `<picture>`: a `<source media="(prefers-color-scheme: dark)">` for the dark file and an `<img>` with the alt text and the light file, which is what GitHub Mobile shows (it ignores the dark source), so the light file is the one that must always be right.
|
||||
- `--pr` screenshots the Explore comment on that PR: the fixtures' `source`, or a newer euxy PR when that comment predates the current layout. `--only pr-comment --pr <url>` rewrites only the comment pictures (it needs no `--report`); `--only` takes any of `hero`, `compare`, `screens` and `pr-comment`. Headless Chromium needs a colour emoji font for the result glyphs (`sudo apt-get install fonts-noto-color-emoji` on Debian/Ubuntu); a comment with hollow boxes where 🟩 should be is not acceptable.
|
||||
- The script serves the report through the Viewer's Vite dev server, so no build is needed. It writes a `-light` and a `-dark` file for every picture (the PR comment too: signed-out github.com follows `prefers-color-scheme`). The README shows each pair with `<picture>`: a `<source media="(prefers-color-scheme: dark)">` for the dark file and an `<img>` with the alt text and the light file, which is what GitHub Mobile shows (it ignores the dark source), so the light file is the one that must always be right. The Screens and PR comment pictures, shown at half the column, are each wrapped in an `<a>` to their light PNG so a reader can open them full size; GitHub links a plain Markdown image itself, but not a `<picture>`.
|
||||
|
||||
Two of the pictures are animated SVGs, built by `scripts/readme-animations.mjs` in the same run; there is nothing else to run when the screenshots change:
|
||||
|
||||
@@ -53,7 +53,7 @@ npx @expo/explore reports list # your sa
|
||||
export EXPLORE_CACHE_DIR=$(mktemp -d) # a scratch store for the image, not your own runs
|
||||
cd ~/code/euxy # inside euxy, so the commit messages are found
|
||||
npx @expo/explore reports add ~/.cache/expo-explore/reports/<that id>/ios.zip
|
||||
npx @expo/explore reports add ~/euxy-report/ios.zip # the PR report from step 1
|
||||
npx @expo/explore reports add ~/euxy-report/iphone.zip # the PR report from step 1
|
||||
npx @expo/explore reports add <an explore:binary report directory> # an exploration, so all three kinds show
|
||||
cd - && npm run build:cli && node scripts/readme-reports-rows.mjs > /tmp/reports-rows.html
|
||||
```
|
||||
@@ -61,7 +61,7 @@ cd - && npm run build:cli && node scripts/readme-reports-rows.mjs > /tmp/reports
|
||||
- The script renders the picker as the CLI draws it (96 columns, the newest run selected) and writes the terminal body as HTML: each coloured piece is exactly its characters wide, so columns line up, and the wordmark is drawn as cell rectangles, since a design tool's font does not draw `█▀▄` cell for cell.
|
||||
- In Paper, replace the frame named "Terminal" inside each artboard's window with that HTML, check both artboards in a screenshot (crisp wordmark, aligned columns, the selected row highlighted to the end, coloured counts), and export both at 2x as `readme-reports-light.png` and `readme-reports-dark.png`. The window's title bar reads `npx @expo/explore reports`, as people run it.
|
||||
|
||||
Look at every PNG you produced before committing, light and dark: the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links and result glyphs. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
|
||||
Look at every PNG you produced before committing, light and dark: the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links, the line of device links and the list of changed screens. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
|
||||
|
||||
## 3. Pass over the content as a first-time user
|
||||
|
||||
|
||||
@@ -0,0 +1,99 @@
|
||||
/**
|
||||
* Runs the Argent bridge's commands on a worker thread of this process, through a synchronous runner, so the
|
||||
* capture's command-at-a-time control flow keeps one bridge and one tool-server connection for the whole run
|
||||
* instead of starting a process per command. Commands for any other executable go to the fallback runner.
|
||||
*/
|
||||
import { Worker } from "node:worker_threads";
|
||||
import { commandOutcome } from "./controller.js";
|
||||
import type { CommandRequest, CommandResult, CommandRunner } from "./run.js";
|
||||
import { BRIDGE_HEADER_BYTES, BRIDGE_KIND_UNAVAILABLE, BRIDGE_SLOT_KIND, BRIDGE_SLOT_LENGTH, BRIDGE_SLOT_READY, type BridgeRequest, type BridgeWorkerData } from "./argent-bridge-worker.js";
|
||||
|
||||
/** Room for one answer: an accessibility tree of a large screen is a few megabytes. */
|
||||
const BRIDGE_BUFFER_BYTES = 64 * 1024 * 1024;
|
||||
/** How long a command gets when its request names no timeout. */
|
||||
const DEFAULT_COMMAND_TIMEOUT_MS = 10 * 60_000;
|
||||
/** After a timeout, how long the thread gets to confirm it dropped the command. */
|
||||
const ABORT_GRACE_MS = 15_000;
|
||||
|
||||
export type ArgentBridgeRunner = {
|
||||
runner: CommandRunner;
|
||||
/** Whether commands still go to the thread (false after it proved unavailable or stopped answering). */
|
||||
readonly active: boolean;
|
||||
close(): void;
|
||||
};
|
||||
|
||||
export function startArgentBridgeRunner(options: {
|
||||
/** The bridge executable the callers name; its commands run on the thread. */
|
||||
command: string;
|
||||
/** The bridge's environment, as argentControllerInvocation builds it. */
|
||||
environment: NodeJS.ProcessEnv;
|
||||
fallback: CommandRunner;
|
||||
/** Tests: a module exporting `createArgentClient` in place of the pinned Argent release's client. */
|
||||
clientModule?: string;
|
||||
progress?: (message: string) => void;
|
||||
}): ArgentBridgeRunner {
|
||||
const shared = new SharedArrayBuffer(BRIDGE_HEADER_BYTES + BRIDGE_BUFFER_BYTES);
|
||||
const header = new Int32Array(shared, 0, BRIDGE_HEADER_BYTES / 4);
|
||||
const bytes = new Uint8Array(shared, BRIDGE_HEADER_BYTES);
|
||||
const workerData: BridgeWorkerData = { shared, ...(options.clientModule ? { clientModule: options.clientModule } : {}) };
|
||||
let worker: Worker | undefined;
|
||||
// The environment the thread runs with: a copy, so a caller that changes the session's (a restarted local
|
||||
// tool-server's URL and token) is seen by the next command, which starts a thread with the new one.
|
||||
let environment: NodeJS.ProcessEnv = {};
|
||||
const start = (from: NodeJS.ProcessEnv) => {
|
||||
environment = { ...from };
|
||||
try {
|
||||
const started = new Worker(new URL("./argent-bridge-worker.js", import.meta.url), { workerData, env: environment });
|
||||
// A thread that crashes stops serving; the commands after it run per command.
|
||||
started.on("error", error => { if (worker === started) stop(`the Argent bridge thread failed (${error.message}); running the bridge per command`); });
|
||||
worker = started;
|
||||
} catch (error) { options.progress?.(`the Argent bridge thread could not start (${(error as Error).message}); running the bridge per command`); }
|
||||
};
|
||||
let sequence = 0;
|
||||
const stop = (reason: string) => {
|
||||
if (!worker) return;
|
||||
options.progress?.(reason);
|
||||
void worker.terminate();
|
||||
worker = undefined;
|
||||
};
|
||||
const changed = (next: NodeJS.ProcessEnv) => {
|
||||
const keys = new Set([...Object.keys(environment), ...Object.keys(next)]);
|
||||
return [...keys].some(key => environment[key] !== next[key]);
|
||||
};
|
||||
const waitFor = (id: number, timeoutMs: number): boolean => {
|
||||
const deadline = Date.now() + timeoutMs;
|
||||
for (;;) {
|
||||
// The value waited on is the one just compared: an answer stored after the comparison wakes the wait at once.
|
||||
const ready = Atomics.load(header, BRIDGE_SLOT_READY);
|
||||
if (ready === id) return true;
|
||||
const remaining = deadline - Date.now();
|
||||
if (remaining <= 0) return false;
|
||||
Atomics.wait(header, BRIDGE_SLOT_READY, ready, remaining);
|
||||
}
|
||||
};
|
||||
start(options.environment);
|
||||
const runner: CommandRunner = (request: CommandRequest): CommandResult => {
|
||||
// A recording runs per command, in the session's own directory: Argent's client saves one under the project its
|
||||
// working directory is in, and this thread's is the caller's checkout. The state file carries it between hosts.
|
||||
if (!worker || request.command !== options.command || request.args[0] === "record") return options.fallback(request);
|
||||
if (changed(request.environment)) { void worker.terminate(); worker = undefined; start(request.environment); }
|
||||
if (!worker) return options.fallback(request);
|
||||
const id = ++sequence;
|
||||
Atomics.store(header, BRIDGE_SLOT_READY, 0);
|
||||
worker.postMessage({ id, argv: request.args, ...(request.timeoutMs !== undefined ? { timeoutMs: request.timeoutMs } : {}) } satisfies BridgeRequest);
|
||||
const timeoutMs = request.timeoutMs ?? DEFAULT_COMMAND_TIMEOUT_MS;
|
||||
if (!waitFor(id, timeoutMs)) {
|
||||
worker.postMessage({ abort: id } satisfies BridgeRequest);
|
||||
if (!waitFor(id, ABORT_GRACE_MS)) stop("the Argent bridge thread stopped answering; running the bridge per command");
|
||||
throw Object.assign(new Error(`${request.command} ${request.args[0] ?? ""} timed out after ${timeoutMs} ms`), { code: "ETIMEDOUT" });
|
||||
}
|
||||
const text = Buffer.from(bytes.subarray(0, Atomics.load(header, BRIDGE_SLOT_LENGTH))).toString("utf8");
|
||||
if (Atomics.load(header, BRIDGE_SLOT_KIND) === BRIDGE_KIND_UNAVAILABLE) {
|
||||
stop(`the Argent bridge thread is unavailable (${text}); running the bridge per command`);
|
||||
return options.fallback(request);
|
||||
}
|
||||
const result = JSON.parse(text) as { exitCode: number; stdout: string };
|
||||
return commandOutcome(request, { status: result.exitCode, stdout: result.stdout, stderr: "" });
|
||||
};
|
||||
return { runner, get active() { return worker !== undefined; }, close: () => { if (worker) { void worker.terminate(); worker = undefined; } } };
|
||||
}
|
||||
@@ -0,0 +1,144 @@
|
||||
/**
|
||||
* The Argent bridge on a worker thread: one bridge and one tool-server connection for a whole capture, instead of a
|
||||
* process (and a TLS handshake) per command. The capture thread posts a command and blocks on the shared buffer;
|
||||
* this thread runs it through Argent's own client library (the code `argent run` uses) and writes the answer back.
|
||||
*/
|
||||
import { isMainThread, parentPort, workerData } from "node:worker_threads";
|
||||
import { copyFile, mkdir, open, writeFile } from "node:fs/promises";
|
||||
import { dirname, join } from "node:path";
|
||||
import { pathToFileURL } from "node:url";
|
||||
import { ArgentCallError, type ArgentCall } from "./argent-driver.js";
|
||||
import { argentBridgeSettings, createArgentBridge, type ArgentBridge } from "./argent-bridge.js";
|
||||
import { ensureController } from "../shared/controller-cache.js";
|
||||
|
||||
/** The shared buffer: four Int32 header slots, then the UTF-8 answer. */
|
||||
export const BRIDGE_HEADER_BYTES = 16;
|
||||
export const BRIDGE_SLOT_READY = 0;
|
||||
export const BRIDGE_SLOT_LENGTH = 1;
|
||||
export const BRIDGE_SLOT_KIND = 2;
|
||||
export const BRIDGE_KIND_RESULT = 0;
|
||||
/** The bridge cannot run on this thread (Argent's client did not load); the host falls back to the process bridge. */
|
||||
export const BRIDGE_KIND_UNAVAILABLE = 1;
|
||||
|
||||
export type BridgeWorkerData = { shared: SharedArrayBuffer; clientModule?: string };
|
||||
export type BridgeRequest = { id: number; argv: readonly string[]; timeoutMs?: number } | { abort: number };
|
||||
|
||||
const ARGENT_CALL_TIMEOUT_MS = 180_000;
|
||||
|
||||
/** Argent's programmatic client, as `dist/client.js` of the pinned release exports it. */
|
||||
type ArgentClient = { callTool(name: string, args: Record<string, unknown>, options?: { signal?: AbortSignal }): Promise<{ data: unknown; note?: string }> };
|
||||
|
||||
/** Whether some bytes begin as a PNG or a JPEG does: `--out` is a screenshot, and nothing else is taken for one. */
|
||||
function isImage(head: Uint8Array): boolean {
|
||||
const png = [0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a], jpeg = [0xff, 0xd8, 0xff];
|
||||
return [png, jpeg].some(signature => signature.every((byte, index) => head[index] === byte));
|
||||
}
|
||||
|
||||
/** Whether a path names a file that is an image by its content. */
|
||||
async function imageFile(path: string): Promise<boolean> {
|
||||
const file = await open(path, "r").catch(() => undefined);
|
||||
if (!file) return false;
|
||||
try {
|
||||
if (!(await file.stat()).isFile()) return false;
|
||||
const head = new Uint8Array(8);
|
||||
const { bytesRead } = await file.read(head, 0, head.length, 0);
|
||||
return isImage(head.subarray(0, bytesRead));
|
||||
} finally { await file.close(); }
|
||||
}
|
||||
|
||||
/** The first string in a tool's answer that names an image file: the materialized screenshot (`path` first). */
|
||||
async function materializedFile(data: unknown): Promise<string | undefined> {
|
||||
const candidates: string[] = [];
|
||||
const walk = (value: unknown, key?: string) => {
|
||||
if (typeof value === "string") { if (key === "path") candidates.unshift(value); else candidates.push(value); }
|
||||
else if (Array.isArray(value)) value.forEach(item => walk(item));
|
||||
else if (value && typeof value === "object") Object.entries(value).forEach(([k, v]) => walk(v, k));
|
||||
};
|
||||
walk(data);
|
||||
for (const candidate of candidates) {
|
||||
if (candidate.startsWith("/") && await imageFile(candidate)) return candidate;
|
||||
}
|
||||
return undefined;
|
||||
}
|
||||
|
||||
async function loadClient(environment: NodeJS.ProcessEnv, clientModule?: string): Promise<ArgentClient> {
|
||||
const module = clientModule ?? join(dirname(await ensureController("argent", { environment })), "client.js");
|
||||
const loaded = await import(pathToFileURL(module).href) as { createArgentClient?: () => ArgentClient };
|
||||
if (typeof loaded.createArgentClient !== "function") throw new Error(`${module} does not export createArgentClient`);
|
||||
return loaded.createArgentClient();
|
||||
}
|
||||
|
||||
/** The in-thread Argent call: the client's `callTool`, with `--out` served from the artifact it materialized. */
|
||||
export function argentClientCall(client: ArgentClient, signal: () => AbortSignal): ArgentCall {
|
||||
return async (tool, args, options) => {
|
||||
const active = signal();
|
||||
if (active.aborted) throw new ArgentCallError(`argent run ${tool} was not sent: the command was given up.`, false);
|
||||
let answer: { data: unknown };
|
||||
try { answer = await client.callTool(tool, args, { signal: AbortSignal.any([active, AbortSignal.timeout(ARGENT_CALL_TIMEOUT_MS)]) }); }
|
||||
catch (error) { throw new ArgentCallError(`argent run ${tool} failed: ${(error instanceof Error ? error.message : String(error)).slice(0, 800)}`, true); }
|
||||
if (!options?.out) return answer.data;
|
||||
const file = await materializedFile(answer.data);
|
||||
if (!file) {
|
||||
const url = (answer.data as { url?: unknown } | null)?.url;
|
||||
if (typeof url !== "string") throw new ArgentCallError(`argent run ${tool} did not write ${options.out}`, true);
|
||||
const response = await fetch(url, { signal: signal() });
|
||||
if (!response.ok) throw new ArgentCallError(`argent run ${tool} did not write ${options.out}: ${response.status}`, true);
|
||||
const body = Buffer.from(await response.arrayBuffer());
|
||||
if (!isImage(body)) throw new ArgentCallError(`argent run ${tool} did not write ${options.out}: the answer is not an image`, true);
|
||||
await mkdir(dirname(options.out), { recursive: true });
|
||||
await writeFile(options.out, body);
|
||||
return { path: options.out };
|
||||
}
|
||||
await mkdir(dirname(options.out), { recursive: true });
|
||||
if (file !== options.out) await copyFile(file, options.out);
|
||||
return { path: options.out };
|
||||
};
|
||||
}
|
||||
|
||||
if (!isMainThread && parentPort && (workerData as Partial<BridgeWorkerData> | null)?.shared instanceof SharedArrayBuffer) {
|
||||
const port = parentPort;
|
||||
const { shared, clientModule } = workerData as BridgeWorkerData;
|
||||
const header = new Int32Array(shared, 0, BRIDGE_HEADER_BYTES / 4);
|
||||
const bytes = new Uint8Array(shared, BRIDGE_HEADER_BYTES);
|
||||
const answer = (id: number, kind: number, text: string) => {
|
||||
let encoded = Buffer.from(text, "utf8");
|
||||
if (encoded.length > bytes.length) {
|
||||
encoded = Buffer.from(JSON.stringify({ exitCode: 1, stdout: JSON.stringify({ success: false,
|
||||
error: { code: "COMMAND_FAILED", message: `The controller's answer (${encoded.length} bytes) exceeds the bridge buffer.` } }) }));
|
||||
}
|
||||
bytes.set(encoded);
|
||||
Atomics.store(header, BRIDGE_SLOT_LENGTH, encoded.length);
|
||||
Atomics.store(header, BRIDGE_SLOT_KIND, kind);
|
||||
Atomics.store(header, BRIDGE_SLOT_READY, id);
|
||||
Atomics.notify(header, BRIDGE_SLOT_READY);
|
||||
};
|
||||
const controllers = new Map<number, AbortController>();
|
||||
let current: AbortController | undefined;
|
||||
const settings = argentBridgeSettings(process.env);
|
||||
const bridge: Promise<ArgentBridge> = settings && settings.toolsUrl
|
||||
? loadClient(process.env, clientModule).then(client => createArgentBridge(settings, argentClientCall(client, () => current?.signal ?? new AbortController().signal), "thread"))
|
||||
: Promise.reject(new Error("The Argent bridge needs EXPLORE_ARGENT_STATE, EXPLORE_ARGENT_PLATFORM and ARGENT_TOOLS_URL."));
|
||||
bridge.catch(() => undefined);
|
||||
let queue: Promise<unknown> = Promise.resolve();
|
||||
port.on("message", (request: BridgeRequest) => {
|
||||
if ("abort" in request) { controllers.get(request.abort)?.abort(new Error("The capture gave up waiting for this command.")); return; }
|
||||
const controller = new AbortController();
|
||||
controllers.set(request.id, controller);
|
||||
queue = queue.then(async () => {
|
||||
current = controller;
|
||||
try {
|
||||
const ready = await bridge.catch(error => { throw Object.assign(error as Error, { unavailable: true }); });
|
||||
if (controller.signal.aborted) throw controller.signal.reason;
|
||||
const result = await ready.run(request.argv);
|
||||
answer(request.id, BRIDGE_KIND_RESULT, JSON.stringify(result));
|
||||
} catch (error) {
|
||||
const message = error instanceof Error ? error.message : String(error);
|
||||
if ((error as { unavailable?: boolean }).unavailable) answer(request.id, BRIDGE_KIND_UNAVAILABLE, message);
|
||||
else answer(request.id, BRIDGE_KIND_RESULT, JSON.stringify({ exitCode: 1, stdout: JSON.stringify({ success: false, error: { code: "COMMAND_FAILED", message } }) }));
|
||||
} finally {
|
||||
controllers.delete(request.id);
|
||||
current = undefined;
|
||||
}
|
||||
});
|
||||
});
|
||||
}
|
||||
@@ -0,0 +1,137 @@
|
||||
/**
|
||||
* The Argent bridge behind both of its hosts: the command-line worker Explore spawns per command, and the
|
||||
* in-process worker thread that keeps one bridge (and one tool-server connection) for a whole capture. Each command
|
||||
* reads the shared state file, runs through `runBridgeCommand`, and writes the state back, so the two hosts can
|
||||
* take turns on one session.
|
||||
*/
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { appendFile, copyFile, mkdir, readFile, realpath, rename, rm, writeFile } from "node:fs/promises";
|
||||
import { dirname, join } from "node:path";
|
||||
import { createRequire } from "node:module";
|
||||
import type { DecodedFrame } from "../shared/png-evidence.js";
|
||||
import { runBridgeCommand, type ArgentBridgeState, type ArgentCall, type ArgentPlatform, type ArgentTree, type BridgeResult } from "./argent-driver.js";
|
||||
import { ARGENT_VERSION } from "../shared/argent-version.js";
|
||||
|
||||
export type ArgentBridgeSettings = {
|
||||
environment: NodeJS.ProcessEnv;
|
||||
statePath: string;
|
||||
platform: ArgentPlatform;
|
||||
toolsUrl: string | undefined;
|
||||
};
|
||||
|
||||
/** Reads the settings the bridge takes from its environment; absent when they are incomplete. */
|
||||
export function argentBridgeSettings(environment: NodeJS.ProcessEnv): ArgentBridgeSettings | undefined {
|
||||
const statePath = environment.EXPLORE_ARGENT_STATE;
|
||||
const platform = environment.EXPLORE_ARGENT_PLATFORM;
|
||||
if (!statePath || (platform !== "ios" && platform !== "android")) return undefined;
|
||||
return { environment, statePath, platform, toolsUrl: environment.ARGENT_TOOLS_URL };
|
||||
}
|
||||
|
||||
async function readState(path: string): Promise<ArgentBridgeState> {
|
||||
try { return JSON.parse(await readFile(path, "utf8")) as ArgentBridgeState; }
|
||||
catch { return { generation: 0 }; }
|
||||
}
|
||||
|
||||
/** Written whole and renamed into place, so a command stopped mid-write never leaves a torn state. */
|
||||
async function writeState(path: string, state: ArgentBridgeState): Promise<void> {
|
||||
const temporary = `${path}.${process.pid}.tmp`;
|
||||
await writeFile(temporary, JSON.stringify(state), { mode: 0o600 });
|
||||
await rename(temporary, path);
|
||||
}
|
||||
|
||||
/** A call's arguments for the debug log: text that could be typed into a field is logged by length only. */
|
||||
function loggedArgs(args: Record<string, unknown>): Record<string, unknown> {
|
||||
return Object.fromEntries(Object.entries(args).map(([key, value]) => key === "text" && typeof value === "string" ? [key, `<${value.length} characters>`]
|
||||
: key === "steps" && Array.isArray(value) ? [key, `<${value.length} steps>`] : [key, value]));
|
||||
}
|
||||
|
||||
/** What a call answered, for the debug log: a tree's shape, not its contents. */
|
||||
function summarize(tool: string, value: unknown): unknown {
|
||||
if (!value || typeof value !== "object") return value;
|
||||
if (tool !== "ui-tree") return Object.keys(value);
|
||||
const tree = value as ArgentTree;
|
||||
let nodes = 0;
|
||||
const walk = (node: { children?: unknown[] }) => { nodes++; (node.children ?? []).forEach(child => walk(child as { children?: unknown[] })); };
|
||||
(tree.roots ?? []).forEach(walk);
|
||||
return { foregroundApp: tree.foregroundApp, alertVisible: tree.alertVisible, keyboardVisible: tree.keyboardVisible, truncated: tree.truncated,
|
||||
screen: tree.screen, nodes, roots: (tree.roots ?? []).map(root => [root.type ?? null, root.bundleId ?? null, (root.children ?? []).length]) };
|
||||
}
|
||||
|
||||
export type ArgentBridge = {
|
||||
/** Runs one agent-device-shaped command against the session. */
|
||||
run(argv: readonly string[]): Promise<BridgeResult>;
|
||||
};
|
||||
|
||||
/**
|
||||
* One bridge over the given Argent call. `host` names the process running it in the debug log.
|
||||
*/
|
||||
export function createArgentBridge(settings: ArgentBridgeSettings, call: ArgentCall, host: "process" | "thread"): ArgentBridge {
|
||||
const { environment, statePath, platform, toolsUrl } = settings;
|
||||
const logPath = environment.EXPLORE_ARGENT_LOG_DIR
|
||||
? join(environment.EXPLORE_ARGENT_LOG_DIR, `argent-${platform}-${environment.EXPLORE_ARGENT_LOG_NAME ?? "bridge"}.jsonl`) : undefined;
|
||||
return {
|
||||
async run(argv) {
|
||||
// EXPLORE_ARGENT_LOG_DIR (opt-in): every Argent call this bridge makes, how long it took, and the shape of what it read.
|
||||
const log = async (entry: Record<string, unknown>) => {
|
||||
if (!logPath) return;
|
||||
await appendFile(logPath, `${JSON.stringify({ at: new Date().toISOString(), host, command: argv[0], ...entry })}\n`, { mode: 0o600 }).catch(() => undefined);
|
||||
};
|
||||
const state = await readState(statePath);
|
||||
const result = await runBridgeCommand(argv, {
|
||||
state, platform, version: ARGENT_VERSION,
|
||||
...(environment.EXPLORE_ARGENT_BUNDLE_ID ? { bundleId: environment.EXPLORE_ARGENT_BUNDLE_ID } : {}),
|
||||
...(environment.EXPLORE_ARGENT_DEVICE ? { device: environment.EXPLORE_ARGENT_DEVICE } : {}),
|
||||
// An opened foldable's inner panel shows its UI in landscape (Argent's fold: "Unfolded, the UI is landscape").
|
||||
...(platform === "ios" && ["open", "half-open"].includes(environment.EXPLORE_ARGENT_POSE ?? "") ? { landscape: true } : {}),
|
||||
call: async (tool, args, options) => {
|
||||
const started = Date.now();
|
||||
try {
|
||||
const value = await call(tool, args, options);
|
||||
await log({ tool, args: loggedArgs(args), ms: Date.now() - started, summary: summarize(tool, value) });
|
||||
return value;
|
||||
} catch (error) {
|
||||
await log({ tool, args: loggedArgs(args), ms: Date.now() - started, error: (error instanceof Error ? error.message : String(error)).slice(0, 400) });
|
||||
throw error;
|
||||
}
|
||||
},
|
||||
reachable: async () => {
|
||||
let ok = false;
|
||||
try {
|
||||
const token = environment.ARGENT_AUTH_TOKEN;
|
||||
// The same URL Argent's own client checks: ARGENT_TOOLS_URL may carry a path, which /tools is appended to.
|
||||
const response = await fetch(`${(toolsUrl ?? "").replace(/\/+$/, "")}/tools`, { headers: token ? { authorization: `Bearer ${token}` } : {}, signal: AbortSignal.timeout(5_000) });
|
||||
await response.body?.cancel();
|
||||
ok = response.status < 500;
|
||||
} catch { ok = false; }
|
||||
if (!ok) await log({ tool: "reachable", ok });
|
||||
return ok;
|
||||
},
|
||||
sleep: milliseconds => new Promise(resolve => setTimeout(resolve, milliseconds)),
|
||||
orientVideo: async path => {
|
||||
const probed = spawnSync("ffprobe", ["-v", "error", "-select_streams", "v:0", "-show_entries", "stream=width,height", "-of", "csv=p=0:s=x", path], { encoding: "utf8", timeout: 30_000 });
|
||||
const [width, height] = (probed.stdout ?? "").trim().split("x").map(Number);
|
||||
if (probed.status !== 0 || !width || !height || width >= height) return;
|
||||
const turned = `${path}.upright.mp4`;
|
||||
const ffmpeg = spawnSync("ffmpeg", ["-nostdin", "-y", "-loglevel", "error", "-i", path, "-vf", "transpose=clock", "-an", turned], { encoding: "utf8", timeout: 120_000 });
|
||||
if (ffmpeg.status === 0) await rename(turned, path);
|
||||
else await rm(turned, { force: true });
|
||||
},
|
||||
scratchImage: { path: join(dirname(statePath), "argent-scratch.png"), read: async path => {
|
||||
const { PNG } = createRequire(import.meta.url)("pngjs") as { PNG: { sync: { read(bytes: Buffer, options: { checkCRC: boolean }): DecodedFrame } } };
|
||||
return PNG.sync.read(await readFile(path), { checkCRC: false });
|
||||
} },
|
||||
moveFile: async (from, to) => {
|
||||
const source = await realpath(from);
|
||||
const roots = await Promise.all([environment.HOME, process.cwd()].filter((root): root is string => !!root).map(root => realpath(root).catch(() => root)));
|
||||
if (!roots.some(root => source.startsWith(`${root}/`))) throw new Error(`Argent returned a recording outside its own directories: ${from}`);
|
||||
await mkdir(dirname(to), { recursive: true });
|
||||
try { await rename(from, to); }
|
||||
catch { await copyFile(from, to); await rm(from, { force: true }); }
|
||||
},
|
||||
});
|
||||
await writeState(statePath, state);
|
||||
await log({ result: result.exitCode === 0 ? "ok" : result.stdout.slice(0, 300) });
|
||||
return result;
|
||||
},
|
||||
};
|
||||
}
|
||||
@@ -2,71 +2,30 @@
|
||||
* The Argent controller's command line: Explore runs it where it would run agent-device, with the same
|
||||
* arguments. Each command becomes `argent run <tool> --args <json>` calls, as EAS Simulator recommends
|
||||
* driving an `argent` session, with the session's ARGENT_TOOLS_URL and ARGENT_AUTH_TOKEN in the environment.
|
||||
* A capture keeps the same bridge on a worker thread instead (argent-bridge-host); this entry serves the callers
|
||||
* that run one command at a time.
|
||||
*/
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { appendFile, copyFile, mkdir, readFile, realpath, rename, rm, stat, writeFile } from "node:fs/promises";
|
||||
import { dirname, join } from "node:path";
|
||||
import { createRequire } from "node:module";
|
||||
import type { DecodedFrame } from "../shared/png-evidence.js";
|
||||
import { ArgentCallError, runBridgeCommand, type ArgentBridgeState, type ArgentPlatform, type ArgentTree } from "./argent-driver.js";
|
||||
import { ARGENT_VERSION } from "../shared/argent-version.js";
|
||||
import { stat } from "node:fs/promises";
|
||||
import { ArgentCallError } from "./argent-driver.js";
|
||||
import { argentBridgeSettings, createArgentBridge } from "./argent-bridge.js";
|
||||
import { ensureController } from "../shared/controller-cache.js";
|
||||
|
||||
const ARGENT_CALL_TIMEOUT_MS = 180_000;
|
||||
|
||||
async function readState(path: string): Promise<ArgentBridgeState> {
|
||||
try { return JSON.parse(await readFile(path, "utf8")) as ArgentBridgeState; }
|
||||
catch { return { generation: 0 }; }
|
||||
}
|
||||
|
||||
/** Written whole and renamed into place, so a command stopped mid-write never leaves a torn state. */
|
||||
async function writeState(path: string, state: ArgentBridgeState): Promise<void> {
|
||||
const temporary = `${path}.${process.pid}.tmp`;
|
||||
await writeFile(temporary, JSON.stringify(state), { mode: 0o600 });
|
||||
await rename(temporary, path);
|
||||
}
|
||||
|
||||
/** A call's arguments for the debug log: text that could be typed into a field is logged by length only. */
|
||||
function loggedArgs(args: Record<string, unknown>): Record<string, unknown> {
|
||||
return Object.fromEntries(Object.entries(args).map(([key, value]) => key === "text" && typeof value === "string" ? [key, `<${value.length} characters>`]
|
||||
: key === "steps" && Array.isArray(value) ? [key, `<${value.length} steps>`] : [key, value]));
|
||||
}
|
||||
|
||||
/** What a call answered, for the debug log: a tree's shape, not its contents. */
|
||||
function summarize(tool: string, value: unknown): unknown {
|
||||
if (!value || typeof value !== "object") return value;
|
||||
if (tool !== "ui-tree") return Object.keys(value);
|
||||
const tree = value as ArgentTree;
|
||||
let nodes = 0;
|
||||
const walk = (node: { children?: unknown[] }) => { nodes++; (node.children ?? []).forEach(child => walk(child as { children?: unknown[] })); };
|
||||
(tree.roots ?? []).forEach(walk);
|
||||
return { foregroundApp: tree.foregroundApp, alertVisible: tree.alertVisible, keyboardVisible: tree.keyboardVisible, truncated: tree.truncated,
|
||||
screen: tree.screen, nodes, roots: (tree.roots ?? []).map(root => [root.type ?? null, root.bundleId ?? null, (root.children ?? []).length]) };
|
||||
}
|
||||
|
||||
async function main(): Promise<number> {
|
||||
const environment = process.env;
|
||||
const statePath = environment.EXPLORE_ARGENT_STATE;
|
||||
const platform = environment.EXPLORE_ARGENT_PLATFORM as ArgentPlatform | undefined;
|
||||
const toolsUrl = environment.ARGENT_TOOLS_URL;
|
||||
if (!statePath || (platform !== "ios" && platform !== "android")) {
|
||||
const settings = argentBridgeSettings(environment);
|
||||
if (!settings) {
|
||||
process.stdout.write(JSON.stringify({ success: false, error: { code: "INVALID_ARGS", message: "The Argent controller needs EXPLORE_ARGENT_STATE and EXPLORE_ARGENT_PLATFORM." } }));
|
||||
return 1;
|
||||
}
|
||||
const argv = process.argv.slice(2);
|
||||
if (argv[0] !== "--version" && !toolsUrl) {
|
||||
if (argv[0] !== "--version" && !settings.toolsUrl) {
|
||||
// Without a URL the Argent client would start a local tool-server; Explore only drives the session's own.
|
||||
process.stdout.write(JSON.stringify({ success: false, error: { code: "INVALID_ARGS", message: "ARGENT_TOOLS_URL is not set for the Argent controller." } }));
|
||||
return 1;
|
||||
}
|
||||
// EXPLORE_ARGENT_LOG_DIR (opt-in): every Argent call this bridge makes, how long it took, and the shape of what it read.
|
||||
const logPath = environment.EXPLORE_ARGENT_LOG_DIR
|
||||
? join(environment.EXPLORE_ARGENT_LOG_DIR, `argent-${platform}-${environment.EXPLORE_ARGENT_LOG_NAME ?? "bridge"}.jsonl`) : undefined;
|
||||
const log = async (entry: Record<string, unknown>) => {
|
||||
if (!logPath) return;
|
||||
await appendFile(logPath, `${JSON.stringify({ at: new Date().toISOString(), command: argv[0], ...entry })}\n`, { mode: 0o600 }).catch(() => undefined);
|
||||
};
|
||||
const state = await readState(statePath);
|
||||
let cli: string;
|
||||
try { cli = argv[0] === "--version" ? "" : await ensureController("argent", { environment, progress: message => process.stderr.write(`[explore] ${message}\n`) }); }
|
||||
catch (error) {
|
||||
@@ -93,65 +52,9 @@ async function main(): Promise<number> {
|
||||
catch { throw new ArgentCallError(`argent run ${tool} did not answer with JSON`, true); }
|
||||
};
|
||||
|
||||
const result = await runBridgeCommand(argv, {
|
||||
state, platform, version: ARGENT_VERSION,
|
||||
...(environment.EXPLORE_ARGENT_BUNDLE_ID ? { bundleId: environment.EXPLORE_ARGENT_BUNDLE_ID } : {}),
|
||||
...(environment.EXPLORE_ARGENT_DEVICE ? { device: environment.EXPLORE_ARGENT_DEVICE } : {}),
|
||||
// An opened foldable's inner panel shows its UI in landscape (Argent's fold: "Unfolded, the UI is landscape").
|
||||
...(platform === "ios" && ["open", "half-open"].includes(environment.EXPLORE_ARGENT_POSE ?? "") ? { landscape: true } : {}),
|
||||
call: async (tool, args, options) => {
|
||||
const started = Date.now();
|
||||
try {
|
||||
const value = await callArgent(tool, args, options);
|
||||
await log({ tool, args: loggedArgs(args), ms: Date.now() - started, summary: summarize(tool, value) });
|
||||
return value;
|
||||
} catch (error) {
|
||||
await log({ tool, args: loggedArgs(args), ms: Date.now() - started, error: (error instanceof Error ? error.message : String(error)).slice(0, 400) });
|
||||
throw error;
|
||||
}
|
||||
},
|
||||
reachable: async () => {
|
||||
let ok = false;
|
||||
try {
|
||||
const token = environment.ARGENT_AUTH_TOKEN;
|
||||
// The same URL Argent's own client checks: ARGENT_TOOLS_URL may carry a path, which /tools is appended to.
|
||||
const response = await fetch(`${(toolsUrl ?? "").replace(/\/+$/, "")}/tools`, { headers: token ? { authorization: `Bearer ${token}` } : {}, signal: AbortSignal.timeout(5_000) });
|
||||
await response.body?.cancel();
|
||||
ok = response.status < 500;
|
||||
} catch { ok = false; }
|
||||
if (!ok) await log({ tool: "reachable", ok });
|
||||
return ok;
|
||||
},
|
||||
sleep: milliseconds => new Promise(resolve => setTimeout(resolve, milliseconds)),
|
||||
orientVideo: async path => {
|
||||
// Turned with ffmpeg, which observing a launch needs anyway; without it the recording is left as it is.
|
||||
const probed = spawnSync("ffprobe", ["-v", "error", "-select_streams", "v:0", "-show_entries", "stream=width,height", "-of", "csv=p=0:s=x", path], { encoding: "utf8", timeout: 30_000 });
|
||||
const [width, height] = (probed.stdout ?? "").trim().split("x").map(Number);
|
||||
if (probed.status !== 0 || !width || !height || width >= height) return;
|
||||
const turned = `${path}.upright.mp4`;
|
||||
const ffmpeg = spawnSync("ffmpeg", ["-nostdin", "-y", "-loglevel", "error", "-i", path, "-vf", "transpose=clock", "-an", turned], { encoding: "utf8", timeout: 120_000 });
|
||||
if (ffmpeg.status === 0) await rename(turned, path);
|
||||
else await rm(turned, { force: true });
|
||||
},
|
||||
scratchImage: { path: join(dirname(statePath), "argent-scratch.png"), read: async path => {
|
||||
const { PNG } = createRequire(import.meta.url)("pngjs") as { PNG: { sync: { read(bytes: Buffer, options: { checkCRC: boolean }): DecodedFrame } } };
|
||||
return PNG.sync.read(await readFile(path), { checkCRC: false });
|
||||
} },
|
||||
moveFile: async (from, to) => {
|
||||
// Argent's client downloads a recording under its HOME or the working directory; nothing else is moved.
|
||||
const source = await realpath(from);
|
||||
const roots = await Promise.all([environment.HOME, process.cwd()].filter((root): root is string => !!root).map(root => realpath(root).catch(() => root)));
|
||||
if (!roots.some(root => source.startsWith(`${root}/`))) throw new Error(`Argent returned a recording outside its own directories: ${from}`);
|
||||
await mkdir(dirname(to), { recursive: true });
|
||||
try { await rename(from, to); }
|
||||
catch { await copyFile(from, to); await rm(from, { force: true }); }
|
||||
},
|
||||
});
|
||||
await writeState(statePath, state);
|
||||
await log({ result: result.exitCode === 0 ? "ok" : result.stdout.slice(0, 300) });
|
||||
const result = await createArgentBridge(settings, callArgent, "process").run(argv);
|
||||
process.stdout.write(result.stdout);
|
||||
return result.exitCode;
|
||||
}
|
||||
|
||||
process.exitCode = await main();
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
* injected, so the translation is tested against recorded Argent output.
|
||||
*/
|
||||
import { CONTROLLER_SESSION } from "./common.js";
|
||||
import { INPUT_METHOD_PACKAGES, KEYBOARD_WINDOW_IDENTIFIERS } from "./keyboard.js";
|
||||
import type { DecodedFrame } from "../shared/png-evidence.js";
|
||||
|
||||
export type ArgentPlatform = "ios" | "android";
|
||||
@@ -88,7 +89,7 @@ export function parseCommand(argv: readonly string[]): { positional: string[]; f
|
||||
}
|
||||
|
||||
type ArgentNode = { role?: string; type?: string; label?: string; identifier?: string; value?: string; contentDescription?: string; disabled?: boolean;
|
||||
frame?: Rect; traits?: string[]; hidden?: boolean; selected?: boolean; password?: boolean; bundleId?: string; children?: ArgentNode[] };
|
||||
frame?: Rect; traits?: string[]; hidden?: boolean; selected?: boolean; focused?: boolean; password?: boolean; bundleId?: string; children?: ArgentNode[] };
|
||||
export type ArgentTree = { schemaVersion?: number; source?: string; screen?: { width: number; height: number }; roots?: ArgentNode[];
|
||||
truncated?: boolean; alertVisible?: boolean; keyboardVisible?: boolean; foregroundApp?: string };
|
||||
|
||||
@@ -137,7 +138,11 @@ export function snapshotFromTree(tree: ArgentTree, platform: ArgentPlatform, gen
|
||||
if (root || !node.frame || ![node.frame.x, node.frame.y, node.frame.width, node.frame.height].every(finite)) return clip;
|
||||
return clip && intersect(node.frame, clip);
|
||||
};
|
||||
const visit = (node: ArgentNode, depth: number, parentIndex: number | undefined, appRoot: boolean, clip: Rect | undefined, root: boolean) => {
|
||||
const keyboard = platform === "ios" ? keyboardWindows(roots) : new Set<ArgentNode>();
|
||||
/** `owner` marks every node of a window that is the system keyboard's, as agent-device marks an input method's nodes. */
|
||||
type Owner = { bundleId?: string; systemKeyboard?: true };
|
||||
const visit = (node: ArgentNode, depth: number, parentIndex: number | undefined, appRoot: boolean, clip: Rect | undefined, root: boolean, owner: Owner) => {
|
||||
if (keyboard.has(node)) owner = { ...owner, systemKeyboard: true };
|
||||
const frame = node.frame;
|
||||
const inner = clipOf(node, clip, root);
|
||||
const rect = frame && [frame.x, frame.y, frame.width, frame.height].every(finite) ? toPoints(frame) : undefined;
|
||||
@@ -159,19 +164,42 @@ export function snapshotFromTree(tree: ArgentTree, platform: ArgentPlatform, gen
|
||||
rect: appRoot ? { x: 0, y: 0, width: screen.width, height: screen.height } : rect,
|
||||
...(label ? { label } : {}), ...(node.identifier ? { identifier: node.identifier } : {}),
|
||||
...(node.value !== undefined ? { value: node.value } : {}), enabled, hittable: enabled && visible && !appRoot,
|
||||
...(visible ? {} : { visible: false }), ...(node.selected || traits.includes("selected") ? { selected: true } : {}) });
|
||||
...(visible ? {} : { visible: false }), ...(node.selected || traits.includes("selected") ? { selected: true } : {}),
|
||||
// The field with the keyboard focus, as agent-device marks it, so capture can wait for the keyboard it raises.
|
||||
...(node.focused === true || traits.includes("isEditing") ? { focused: true } : {}),
|
||||
...owner });
|
||||
refs[ref] = { rect: appRoot ? { x: 0, y: 0, width: screen.width, height: screen.height } : rect, type,
|
||||
...(node.value !== undefined ? { value: node.value } : {}), ...(type === "SecureTextField" ? { secure: true } : {}) };
|
||||
}
|
||||
for (const child of node.children ?? []) visit(child, depth + 1, index, false, inner, false);
|
||||
for (const child of node.children ?? []) visit(child, depth + 1, index, false, inner, false, owner);
|
||||
};
|
||||
for (const root of roots) {
|
||||
const isAppRoot = platform === "ios" ? root.type === "Application" || nodes.length === 0 : root.bundleId === app;
|
||||
visit(root, 0, undefined, isAppRoot, { x: 0, y: 0, width: 1, height: 1 }, true);
|
||||
// An Android input method's window names its package on each node, as agent-device's do, which marks the keyboard.
|
||||
const inputMethod = platform === "android" && root.bundleId && INPUT_METHOD_PACKAGES.has(root.bundleId) ? root.bundleId : undefined;
|
||||
visit(root, 0, undefined, isAppRoot, { x: 0, y: 0, width: 1, height: 1 }, true, inputMethod ? { bundleId: inputMethod } : {});
|
||||
}
|
||||
return { nodes, refs, screen: { width: screen.width, height: screen.height } };
|
||||
}
|
||||
|
||||
/**
|
||||
* The windows iOS draws the software keyboard in. Argent lists each window as a child of its root, the app's first. A
|
||||
* later window is the keyboard's when it holds XCTest's `Keyboard` element, which no app can give itself; an identifier
|
||||
* never decides it alone, since an app can set any identifier on its own views (a second window of the app's with a
|
||||
* `testID="inputView"` stays the app's). While such a window is up, UIKit also hosts the keyboard's input view
|
||||
* placeholder in a window of its own: a later window whose only named node is an `inputView` belongs to it too.
|
||||
*/
|
||||
function keyboardWindows(roots: readonly ArgentNode[]): Set<ArgentNode> {
|
||||
const holds = (node: ArgentNode, test: (node: ArgentNode) => boolean): boolean => test(node) || (node.children ?? []).some(child => holds(child, test));
|
||||
const later = roots.flatMap(root => (root.children ?? []).slice(1));
|
||||
const keyboard = later.filter(window => holds(window, node => node.type === "Keyboard"));
|
||||
if (!keyboard.length) return new Set();
|
||||
const named = (node: ArgentNode) => Boolean(node.label?.trim() || node.contentDescription?.trim() || node.value !== undefined
|
||||
|| (node.identifier && !KEYBOARD_WINDOW_IDENTIFIERS.has(node.identifier)));
|
||||
const placeholders = later.filter(window => !keyboard.includes(window) && holds(window, node => node.identifier === "inputView") && !holds(window, named));
|
||||
return new Set([...keyboard, ...placeholders]);
|
||||
}
|
||||
|
||||
function intersect(a: Rect, b: Rect): Rect | undefined {
|
||||
const x = Math.max(a.x, b.x), y = Math.max(a.y, b.y);
|
||||
const right = Math.min(a.x + a.width, b.x + b.width), bottom = Math.min(a.y + a.height, b.y + b.height);
|
||||
@@ -216,6 +244,21 @@ const KEYBOARD_DISMISS_LABELS = ["Hide keyboard", "Dismiss keyboard", "Done"];
|
||||
const KEYBOARD_TOP = 0.4;
|
||||
const ALERT_PREFERRED_BUTTONS = ["Open", "OK", "Allow", "Allow While Using App", "Continue"];
|
||||
const READ_TOOLS = new Set(["ui-tree", "list-devices", "screenshot", "foreground-app", "await-screen-idle", "describe"]);
|
||||
/**
|
||||
* Argent 0.29's answer when a service a tool depends on (the device's simulator-server, its accessibility service) did
|
||||
* not start: the registry resolves a tool's services before it calls the tool, and wraps a start failure as
|
||||
* "[Tool:<id>] Service dependency failed: …", so the tool itself never ran and resending it is safe, a UI action too.
|
||||
* The tools the bridge sends that resolve a service while they run (keyboard, fill, restart-app, screen-recording-start)
|
||||
* resolve it before they act, and run-sequence answers a step's failure in its result rather than raising it. A failed
|
||||
* start leaves the service in the registry's ERROR state, so the next call starts it afresh.
|
||||
*/
|
||||
const SERVICE_DEPENDENCY_FAILED = "Service dependency failed:";
|
||||
/**
|
||||
* In brentvatne/euxy#172 (review run 39348956443) capture restarted SpringBoard and folded the iPhone Duo open again 8 s
|
||||
* later; that fold's simulator-server did not become ready within Argent's 30 s, and the whole target failed. The resend
|
||||
* comes after a pause, so a device still coming back from the restart has the time it needs.
|
||||
*/
|
||||
const DEPENDENCY_RETRY_DELAYS_MS = [3_000, 6_000] as const;
|
||||
const SPRINGBOARD = "com.apple.springboard";
|
||||
const ANDROID_SYSTEM_UI = "com.android.systemui";
|
||||
const OPEN_IN_APP_PROMPT = /^Open in “.+”\?$/;
|
||||
@@ -299,14 +342,23 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
|
||||
const { positional, flags } = parseCommand(rest);
|
||||
const bundleFlag = typeof flags["bundle-id"] === "string" ? flags["bundle-id"] : context.bundleId;
|
||||
|
||||
/** Reads are resent after a transport failure (they change nothing); a UI action is sent once, after a health check. */
|
||||
/**
|
||||
* Reads are resent after a transport failure (they change nothing); a UI action is sent once, after a health check.
|
||||
* Any tool, a UI action too, is resent when Argent could not start a service it depends on, which it raises before
|
||||
* the tool runs (see SERVICE_DEPENDENCY_FAILED).
|
||||
*/
|
||||
const call = async (tool: string, args: Record<string, unknown> = {}, options?: { out?: string }): Promise<Record<string, unknown>> => {
|
||||
// Tools that name devices their own way (or none) take no udid.
|
||||
const withDevice = tool === "list-devices" || tool === "stop-all-simulator-servers" ? args : { udid: state.udid, ...args };
|
||||
for (let attempt = 0; ; attempt++) {
|
||||
for (let readRetry = 0, dependencyRetry = 0; ;) {
|
||||
try { return record(await context.call(tool, withDevice, options)); }
|
||||
catch (error) {
|
||||
if (READ_TOOLS.has(tool) && attempt < 2) { await context.sleep(1_000 * (attempt + 1)); continue; }
|
||||
if (error instanceof ArgentCallError && error.message.includes(`[Tool:${tool}] ${SERVICE_DEPENDENCY_FAILED}`)
|
||||
&& dependencyRetry < DEPENDENCY_RETRY_DELAYS_MS.length) {
|
||||
await context.sleep(DEPENDENCY_RETRY_DELAYS_MS[dependencyRetry++]!);
|
||||
continue;
|
||||
}
|
||||
if (READ_TOOLS.has(tool) && readRetry < 2) { await context.sleep(1_000 * ++readRetry); continue; }
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -414,7 +466,9 @@ export async function runBridgeCommand(argv: readonly string[], context: ArgentB
|
||||
converted.nodes.push({ depth: 1, index: converted.nodes.length, parentIndex: 0, type: "Alert", ref: `e${converted.nodes.length + 1}`,
|
||||
rect: { x: 0, y: 0, width: converted.screen.width, height: converted.screen.height }, label: "System alert", enabled: true, hittable: false });
|
||||
}
|
||||
// Whether a keyboard shows, which Argent's Android tree does not hold: the input method's window is not in it.
|
||||
return success({ nodes: converted.nodes, truncated: current.truncated === true, refsGeneration: state.generation,
|
||||
...(typeof current.keyboardVisible === "boolean" ? { keyboardVisible: current.keyboardVisible } : {}),
|
||||
...(current.foregroundApp ? { appBundleId: current.foregroundApp, appName: current.foregroundApp } : {}),
|
||||
snapshotQuality: { state: "healthy", backend: "argent" } });
|
||||
}
|
||||
|
||||
@@ -5,6 +5,7 @@ import type {
|
||||
ElementRole,
|
||||
InputElement,
|
||||
} from "../types.js";
|
||||
import { INPUT_METHOD_PACKAGES, keyboardNodes } from "./keyboard.js";
|
||||
|
||||
export type ControllerParseResult = {
|
||||
controller: Controller;
|
||||
@@ -221,10 +222,7 @@ function nodeToElement(node: Record<string, unknown>): InputElement | undefined
|
||||
const SYSTEM_UI_PACKAGES = new Set([
|
||||
"android",
|
||||
"com.android.systemui",
|
||||
"com.google.android.inputmethod.latin",
|
||||
"com.samsung.android.honeyboard",
|
||||
"com.touchtype.swiftkey",
|
||||
"com.microsoft.swiftkey",
|
||||
...INPUT_METHOD_PACKAGES,
|
||||
]);
|
||||
|
||||
export function isSystemUiNode(node: Record<string, unknown>): boolean {
|
||||
@@ -240,6 +238,12 @@ function collectJsonElements(value: unknown, output: InputElement[], seen: Set<u
|
||||
return;
|
||||
}
|
||||
const record = value as Record<string, unknown>;
|
||||
// iOS's software keyboard is system UI too, like Android's: its keys and its Emoji and Dictate buttons are not the
|
||||
// app's elements. A keyboard that rose on one side only made "Added button “Dictate”" lead a review whose real
|
||||
// change was a field's label (brentvatne/euxy#172, review run 39362642343).
|
||||
if (Array.isArray(record.nodes)) {
|
||||
for (const node of keyboardNodes(record.nodes.filter((node): node is Record<string, unknown> => !!node && typeof node === "object" && !Array.isArray(node)))) seen.add(node);
|
||||
}
|
||||
const element = isSystemUiNode(record) ? undefined : nodeToElement(record);
|
||||
if (element) output.push(element);
|
||||
for (const [key, child] of Object.entries(record)) {
|
||||
|
||||
@@ -14,20 +14,25 @@ export function defaultRunner(request: CommandRequest): CommandResult {
|
||||
...(request.timeoutMs ? { timeout: request.timeoutMs } : {}),
|
||||
});
|
||||
if (result.error) throw result.error;
|
||||
return commandOutcome(request, { status: result.status, stdout: result.stdout ?? "", stderr: result.stderr ?? "" });
|
||||
}
|
||||
|
||||
/** A finished command's output, or the error its exit status and output describe. */
|
||||
export function commandOutcome(request: CommandRequest, result: { status: number | null; stdout: string; stderr: string }): CommandResult {
|
||||
if (result.status !== 0 && !request.allowFailure) {
|
||||
const sessionIndex = request.args.indexOf("--session");
|
||||
// Our own session or a caller's session attached by explore:session: both answer --json failures with a structured error.
|
||||
const structuredFailure = (sessionIndex >= 0 && request.args[sessionIndex + 1] === CONTROLLER_SESSION) || request.args.includes("--json")
|
||||
? controllerCommandFailure(result.stdout ?? "", request.args[0] ?? "command") : undefined;
|
||||
? controllerCommandFailure(result.stdout, request.args[0] ?? "command") : undefined;
|
||||
if (structuredFailure) throw structuredFailure;
|
||||
const subcommand = typeof request.args[0] === "string" ? ` ${request.args[0]}` : "";
|
||||
const detail = failureDetail(`${result.stderr ?? ""}\n${result.stdout ?? ""}`);
|
||||
const detail = failureDetail(`${result.stderr}\n${result.stdout}`);
|
||||
throw new Error(
|
||||
`${request.command}${subcommand} exited with status ${result.status ?? "unknown"}`
|
||||
+ (detail ? `: ${detail}` : ""),
|
||||
);
|
||||
}
|
||||
return { stdout: result.stdout ?? "", stderr: result.stderr ?? "" };
|
||||
return { stdout: result.stdout, stderr: result.stderr };
|
||||
}
|
||||
|
||||
/** Keep the CLI tool host responsive while a remote controller request is in flight. */
|
||||
|
||||
@@ -0,0 +1,146 @@
|
||||
/**
|
||||
* The system software keyboard in a controller snapshot (agent-device's flat `nodes`, which the Argent bridge also
|
||||
* returns), and how long capture waits for it. Recognition is deliberately narrow: dropping one of the app's own elements
|
||||
* hides a real change, which is worse than the keyboard noise this removes. A node is the keyboard's only when it, or a
|
||||
* node above it, provably belongs to the system keyboard; nothing is inferred from where an element sits on the screen,
|
||||
* and a `Key` alone proves nothing (React Native's `accessibilityRole="keyboardkey"` gives an app's PIN pad that type).
|
||||
*/
|
||||
|
||||
type Rect = { x: number; y: number; width: number; height: number };
|
||||
type SnapshotNode = Record<string, unknown>;
|
||||
|
||||
/** Android input methods: their windows name the IME's package, not the app's. */
|
||||
export const INPUT_METHOD_PACKAGES: ReadonlySet<string> = new Set([
|
||||
"com.google.android.inputmethod.latin",
|
||||
"com.android.inputmethod.latin",
|
||||
"com.samsung.android.honeyboard",
|
||||
"com.touchtype.swiftkey",
|
||||
"com.microsoft.swiftkey",
|
||||
]);
|
||||
|
||||
/**
|
||||
* UIKit's identifiers for the input view placeholder and the prediction bar. They mark a window as the keyboard's (see
|
||||
* the Argent bridge's `keyboardWindows`); inside the app's own window an element with one of them is the app's.
|
||||
*/
|
||||
export const KEYBOARD_WINDOW_IDENTIFIERS: ReadonlySet<string> = new Set(["inputView", "SystemInputAssistantView"]);
|
||||
|
||||
/**
|
||||
* The keyboard's native view classes, which agent-device's host accessibility bridge reports as `role`. The dock's Emoji
|
||||
* and Dictate buttons (UIKeyboardDockItemButton) can sit outside the key plane's bounds, so they are named here.
|
||||
*/
|
||||
const KEYBOARD_VIEW_CLASSES = new Set(["UIKeyboardDockItemButton", "UIAccessibilityElementKBKey", "UIKeyboardLayoutStar",
|
||||
"TUIPredictionView", "TUIPredictionViewCell", "_UIRemoteKeyboardPlaceholderView", "TUISystemInputAssistantView",
|
||||
"TUISystemInputAssistantPageView"]);
|
||||
|
||||
const EDITABLE_TYPES = new Set(["textfield", "securetextfield", "searchfield", "textview"]);
|
||||
|
||||
const text = (value: unknown) => typeof value === "string" ? value : "";
|
||||
|
||||
function rectOf(node: SnapshotNode): Rect | undefined {
|
||||
const rect = node.rect as Partial<Rect> | undefined;
|
||||
return rect && [rect.x, rect.y, rect.width, rect.height].every(Number.isFinite) && rect.width! > 0 && rect.height! > 0 ? rect as Rect : undefined;
|
||||
}
|
||||
|
||||
/**
|
||||
* A node that belongs to the system keyboard by what it is, not where it is: XCTest's `Keyboard` element (both
|
||||
* controllers), a node of a window the Argent bridge found to be the keyboard's (`systemKeyboard`), one of the keyboard's
|
||||
* native view classes, or a node of an Android input method's window.
|
||||
*/
|
||||
function keyboardRoot(node: SnapshotNode): boolean {
|
||||
return node.systemKeyboard === true || text(node.type).toLowerCase() === "keyboard" || KEYBOARD_VIEW_CLASSES.has(text(node.role))
|
||||
|| INPUT_METHOD_PACKAGES.has(text(node.bundleId ?? node.packageName ?? node.package));
|
||||
}
|
||||
|
||||
/** Every node that belongs to the system keyboard: those `keyboardRoot` names and the nodes beneath them. */
|
||||
export function keyboardNodes(nodes: readonly SnapshotNode[]): Set<SnapshotNode> {
|
||||
const owned = new Set<SnapshotNode>();
|
||||
if (!nodes.some(keyboardRoot)) return owned;
|
||||
// Only an explicit parent links a node to a keyboard above it: a node without one is no node's descendant.
|
||||
const byIndex = new Map(nodes.filter(node => typeof node.index === "number").map(node => [node.index as number, node]));
|
||||
for (const node of nodes) {
|
||||
const seen = new Set<SnapshotNode>();
|
||||
for (let current: SnapshotNode | undefined = node; current && !seen.has(current);
|
||||
current = typeof current.parentIndex === "number" ? byIndex.get(current.parentIndex) : undefined) {
|
||||
seen.add(current);
|
||||
if (keyboardRoot(current)) { owned.add(node); break; }
|
||||
}
|
||||
}
|
||||
return owned;
|
||||
}
|
||||
|
||||
function union(rects: readonly Rect[]): Rect | undefined {
|
||||
if (!rects.length) return undefined;
|
||||
const x = Math.min(...rects.map(rect => rect.x)), y = Math.min(...rects.map(rect => rect.y));
|
||||
return { x, y, width: Math.max(...rects.map(rect => rect.x + rect.width)) - x, height: Math.max(...rects.map(rect => rect.y + rect.height)) - y };
|
||||
}
|
||||
|
||||
/**
|
||||
* Where the visible keyboard is, from the nodes that span it (the `Keyboard` element, the keyboard window's input view and
|
||||
* prediction bar, the native views, an input method's window), or undefined when none shows. Containers inside the
|
||||
* keyboard can report a scroll extent past the screen, so not every node it owns counts.
|
||||
*/
|
||||
export function keyboardBounds(nodes: readonly SnapshotNode[]): Rect | undefined {
|
||||
return union(nodes.filter(node => node.visible !== false && keyboardRoot(node) && (node.systemKeyboard !== true
|
||||
|| text(node.type).toLowerCase() === "keyboard" || KEYBOARD_WINDOW_IDENTIFIERS.has(text(node.identifier)))).flatMap(node => rectOf(node) ?? []));
|
||||
}
|
||||
|
||||
/**
|
||||
* A text input that has the keyboard focus: agent-device reports `focused` from XCTest's keyboard focus and Android's
|
||||
* focused flag; the Argent bridge passes on Argent's own.
|
||||
*/
|
||||
export function focusedTextInput(nodes: readonly SnapshotNode[]): boolean {
|
||||
return nodes.some(node => node.focused === true && node.visible !== false
|
||||
&& (EDITABLE_TYPES.has(text(node.type).toLowerCase()) || /EditText$/.test(text(node.type)) || node.editable === true));
|
||||
}
|
||||
|
||||
/** A snapshot as the wait reads it: Argent also says whether a keyboard shows, which its Android tree cannot. */
|
||||
export type KeyboardRead = { nodes: readonly SnapshotNode[]; keyboardVisible?: boolean };
|
||||
|
||||
/** Where the keyboard is in one read: its bounds, or only that one shows when the controller cannot place it. */
|
||||
function keyboardPosition(read: KeyboardRead): string | undefined {
|
||||
const bounds = keyboardBounds(read.nodes);
|
||||
return bounds ? JSON.stringify(bounds) : read.keyboardVisible === true ? "visible" : undefined;
|
||||
}
|
||||
|
||||
/**
|
||||
* How capture waits for a focused field's keyboard. Reads are 250 ms apart at most, and at least two follow the first,
|
||||
* so a controller whose snapshot takes a second or more still sees the keyboard rise. Waiting for a keyboard that has not
|
||||
* appeared ends after a second; one that has appeared but has not yet held still is read until it does, up to six reads
|
||||
* or four seconds, so a slow controller cannot keep the capture waiting.
|
||||
*/
|
||||
export const KEYBOARD_POLL_MS = 250;
|
||||
const KEYBOARD_WAIT_MS = 1_000;
|
||||
const KEYBOARD_CAP_MS = 4_000;
|
||||
const KEYBOARD_MIN_READS = 2;
|
||||
const KEYBOARD_MAX_READS = 6;
|
||||
|
||||
export type KeyboardSettle = {
|
||||
/** `shown`: in the same place in two reads running. `unfocused`: the field let go and no keyboard shows. */
|
||||
readonly outcome: "shown" | "moving" | "absent" | "unfocused";
|
||||
readonly reads: number;
|
||||
/** Whether to read the screen again, `elapsedMs` after the first read. */
|
||||
more(elapsedMs: number): boolean;
|
||||
read(next: KeyboardRead): void;
|
||||
};
|
||||
|
||||
/**
|
||||
* The wait for a screen whose text field has the focus, or undefined when none has it. A keyboard already up counts only
|
||||
* once a later read finds it in the same place: one caught rising or going down is still moving.
|
||||
*/
|
||||
export function keyboardSettle(first: KeyboardRead): KeyboardSettle | undefined {
|
||||
if (!focusedTextInput(first.nodes)) return undefined;
|
||||
let previous = keyboardPosition(first), reads = 0;
|
||||
let outcome: KeyboardSettle["outcome"] = previous ? "moving" : "absent";
|
||||
return {
|
||||
get outcome() { return outcome; },
|
||||
get reads() { return reads; },
|
||||
more: elapsedMs => (outcome === "moving" || outcome === "absent") && reads < KEYBOARD_MAX_READS
|
||||
&& (reads < KEYBOARD_MIN_READS || (elapsedMs < KEYBOARD_CAP_MS && (outcome === "moving" || elapsedMs < KEYBOARD_WAIT_MS))),
|
||||
read: next => {
|
||||
reads += 1;
|
||||
const position = keyboardPosition(next);
|
||||
outcome = position && position === previous ? "shown" : position ? "moving" : focusedTextInput(next.nodes) ? "absent" : "unfocused";
|
||||
previous = position;
|
||||
},
|
||||
};
|
||||
}
|
||||
@@ -17,6 +17,7 @@ import { type CaptureSetupSnapshot, credentialSavePromptDecline, describeSetupAc
|
||||
import { silentProgress } from "../shared/progress.js";
|
||||
import type { CaptureSetupReady } from "../config/explore-config.js";
|
||||
import { READINESS_POLL_MS, defaultReadinessSeconds } from "./readiness.js";
|
||||
import { KEYBOARD_POLL_MS, keyboardSettle, type KeyboardRead, type KeyboardSettle } from "./keyboard.js";
|
||||
import { CAPTURE_OBSERVER_IDENTIFIER, captureObserverMarkers, parseCaptureDestination, captureDestinationMatches } from "./observer.js";
|
||||
import { type CiAgentRuntimeOptions, runCiAgentNavigation, assertAgentCaptureContext } from "./agent/runtime.js";
|
||||
import { createExplorationInputs } from "../config/exploration-inputs.js";
|
||||
@@ -92,6 +93,11 @@ function snapshotNodes(raw: string): Record<string, unknown>[] {
|
||||
return data.nodes;
|
||||
}
|
||||
|
||||
/** Whether the controller says a keyboard shows: Argent does, and its Android tree has no input method window to show it. */
|
||||
function keyboardVisibility(data: Record<string, unknown>): { keyboardVisible?: boolean } {
|
||||
return typeof data.keyboardVisible === "boolean" ? { keyboardVisible: data.keyboardVisible } : {};
|
||||
}
|
||||
|
||||
/** The visible element each required label matched, so an image assessor can find icon-only controls. */
|
||||
export function verifiedCaptureLabels(nodes: readonly Record<string, unknown>[], requiredLabels: readonly string[],
|
||||
/** The screen's portrait height, when the screenshot is that screen turned a quarter clockwise (an opened iPhone Duo). */
|
||||
@@ -377,7 +383,7 @@ export async function capturePlannedRoutes(options: {
|
||||
lastSnapshot = raw;
|
||||
const generation = typeof data.refsGeneration === "number" ? data.refsGeneration : undefined;
|
||||
const decline = declined < 2 && generation ? credentialSavePromptDecline(nodes) : undefined;
|
||||
if (!decline) return { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}) };
|
||||
if (!decline) return { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}), ...keyboardVisibility(data) };
|
||||
controller(["press", `@${String(decline.ref).replace(/^@/, "")}~s${generation}`, "--level", "full", "--json"]);
|
||||
recordDeclinedPrompt("deterministic");
|
||||
controller(["wait", "500", "--level", "full", "--json"]);
|
||||
@@ -507,6 +513,35 @@ export async function capturePlannedRoutes(options: {
|
||||
.sort());
|
||||
/** The controller's own quiescence gate; a timeout is reported by the snapshot comparison below. */
|
||||
const settle = () => { controller(["wait", "stable", "500", "8000", "--level", "full", "--json"], true); };
|
||||
/**
|
||||
* A screen that focused a text field shows the keyboard that field raises, as its users see it. The keyboard rises
|
||||
* after the screen has settled, so the controller's quiescence gate can pass in between: in brentvatne/euxy#172
|
||||
* (review run 39362642343) the rename sheet's base was captured with its cursor showing and no keyboard, its head with
|
||||
* the keyboard up, and the 48% mismatch was the keyboard. The screen is read again until the keyboard is in the same
|
||||
* place twice running (see keyboardSettle); a keyboard that never comes is not waited for long, and none is dismissed.
|
||||
*/
|
||||
const awaitKeyboard = (route: SourceRoute, first: KeyboardRead): readonly Record<string, unknown>[] => {
|
||||
const settle = keyboardSettle(first);
|
||||
if (!settle) return first.nodes;
|
||||
const startedAt = clock();
|
||||
let current = first, pollStartedAt = startedAt;
|
||||
// A read counts for at least one poll interval, so a clock that stands still (a fake controller) still expires.
|
||||
const elapsed = () => Math.max(clock() - startedAt, settle.reads * KEYBOARD_POLL_MS);
|
||||
while (settle.more(elapsed())) {
|
||||
(capture.sleep ?? pause)(KEYBOARD_POLL_MS - (clock() - pollStartedAt));
|
||||
pollStartedAt = clock();
|
||||
current = snapshot();
|
||||
settle.read(current);
|
||||
}
|
||||
recordKeyboardWait(route.id, settle, elapsed());
|
||||
return current.nodes;
|
||||
};
|
||||
const recordKeyboardWait = (route: string | undefined, settle: KeyboardSettle, elapsedMs: number) => {
|
||||
const diagnostics = join(store.root, "capture-diagnostics");
|
||||
mkdirSync(diagnostics, { recursive: true, mode: 0o700 });
|
||||
appendFileSync(join(diagnostics, "keyboard.jsonl"), `${JSON.stringify({ ...(route ? { route } : { phase: "agent-observe" }), outcome: settle.outcome,
|
||||
reads: settle.reads, elapsedMs, at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
|
||||
};
|
||||
const attempted = new Set<string>();
|
||||
const captureCurrent = async (route: SourceRoute, attempt: number, before?: readonly Record<string, unknown>[],
|
||||
unattributed?: NonNullable<CaptureBundle["outcomes"][string]["observed"]> & { message: string }) => {
|
||||
@@ -514,9 +549,11 @@ export async function capturePlannedRoutes(options: {
|
||||
attempted.add(route.id);
|
||||
const temporary = await mkdtemp(join(store.root, ".capture-"));
|
||||
try {
|
||||
const accepted = before ?? waitForDestination(route, () => resolveDeepLinkConfirmation());
|
||||
if (unattributed) assertNoAlert({ route, nodes: accepted });
|
||||
else landing(accepted, route, inventory);
|
||||
const arrived = before ?? waitForDestination(route, () => resolveDeepLinkConfirmation());
|
||||
if (unattributed) assertNoAlert({ route, nodes: arrived });
|
||||
else landing(arrived, route, inventory);
|
||||
const accepted = unattributed ? arrived : awaitKeyboard(route, { nodes: arrived });
|
||||
if (accepted !== arrived) landing(accepted, route, inventory);
|
||||
assertSafeScreenshot(accepted);
|
||||
const screenshot = join(temporary, "screen.png");
|
||||
await writeFile(screenshot, "", { flag: "wx", mode: 0o600 });
|
||||
@@ -663,7 +700,7 @@ export async function capturePlannedRoutes(options: {
|
||||
const generation = typeof data.refsGeneration === "number" ? data.refsGeneration : undefined;
|
||||
const decline = declined < 2 && generation ? credentialSavePromptDecline(nodes) : undefined;
|
||||
if (!decline) {
|
||||
const snapshot: CaptureSetupSnapshot = { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}) };
|
||||
const snapshot: CaptureSetupSnapshot = { nodes, truncated: false, ...(generation ? { refsGeneration: generation } : {}), ...keyboardVisibility(data) };
|
||||
return { snapshot, raw };
|
||||
}
|
||||
await command(["press", `@${String(decline.ref).replace(/^@/, "")}~s${generation}`, "--level", "full", "--json"], signal);
|
||||
@@ -769,16 +806,32 @@ export async function capturePlannedRoutes(options: {
|
||||
}
|
||||
}
|
||||
};
|
||||
/** The same wait for a focused field's keyboard as a route link's capture, before an observation's screenshot. */
|
||||
const awaitKeyboardAsync = async (first: CaptureSetupSnapshot, signal: AbortSignal): Promise<CaptureSetupSnapshot> => {
|
||||
const settle = keyboardSettle(first);
|
||||
if (!settle) return first;
|
||||
const startedAt = clock();
|
||||
let current = first;
|
||||
const elapsed = () => Math.max(clock() - startedAt, settle.reads * KEYBOARD_POLL_MS);
|
||||
while (settle.more(elapsed())) {
|
||||
await sleep(KEYBOARD_POLL_MS, undefined, { signal: liveSignal(signal) });
|
||||
current = (await readSnapshot(signal)).snapshot;
|
||||
settle.read(current);
|
||||
}
|
||||
recordKeyboardWait(undefined, settle, elapsed());
|
||||
return current;
|
||||
};
|
||||
const observe = async (signal: AbortSignal, options?: { includeImage: boolean }) => {
|
||||
await discard();
|
||||
await appIdentity(signal);
|
||||
const first = await readSnapshotThroughDeferral(signal);
|
||||
const before = first.snapshot;
|
||||
let before = first.snapshot;
|
||||
if (first.retries > 0) {
|
||||
await appendFile(join(dirname(tracePath), "accessibility-deferral.jsonl"), `${JSON.stringify({ retries: first.retries, waitedMs: first.deferredMs,
|
||||
at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
|
||||
}
|
||||
if (options?.includeImage === false) return { snapshot: before };
|
||||
before = await awaitKeyboardAsync(before, signal);
|
||||
try { assertSafeScreenshot(before.nodes); }
|
||||
catch (error) {
|
||||
if (error instanceof CiError && error.code === "CAPTURE_SENSITIVE_INPUT") return { snapshot: before, imageUnavailable: { code: error.code, message: error.message } };
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { appearanceArgs, argentColorSchemes, bundleColorSchemes, mergeSchemeOutcomes, resolveColorSchemes, routeIdOfScreen, type AppearanceSetting, type ColorScheme } from "./appearance.js";
|
||||
import { appearanceArgs, argentColorSchemes, bundleColorSchemes, mergeSchemeOutcomes, resolveColorSchemes, routeIdOfScreen, schemeScreenId, type AppearanceSetting, type ColorScheme } from "./appearance.js";
|
||||
import { assertNoCaptureHealthIssues, captureHealthIssues, partitionCaptureHealthIssues } from "./health.js";
|
||||
import { type RouteResetSetting } from "./route-reset.js";
|
||||
import { defaultReadinessSeconds } from "./readiness.js";
|
||||
@@ -24,6 +24,7 @@ import { silentProgress, type Progress } from "../shared/progress.js";
|
||||
import { assertCaptureEasProfile, assertSimulatorAvailable, fingerprintFrom, hasEasEnvironmentFetchFailure, nativeBuildFrom, existingBuild, repackProfileFrom, prepareExactSourceBuild, type RepackMode } from "./eas-build.js";
|
||||
import { SIMULATOR_DOTENV_FILE_NAME, SIMULATOR_DOTENV_HEADER, endedOwnSimulatorSession, liveSimulatorSessionsNamed, simulatorSessionName, simulatorStartFailure, readSimulatorDotenvHandoff, assertSimulatorSessionIdentity, assertSimulatorStopped, collectRuntime, controllerVersion, simulatorOsVersion, type ActiveSimulatorRuntime, type SimulatorConnection } from "./simulator.js";
|
||||
import { argentControllerInvocation } from "./controller-invocation.js";
|
||||
import { startArgentBridgeRunner, type ArgentBridgeRunner } from "./argent-bridge-host.js";
|
||||
import { sharedBuild } from "./shared-build.js";
|
||||
import { LOCAL_EMULATOR_STATE_PREFIX, LOCAL_SIMULATOR_STATE_PREFIX, agentDeviceClaims, assertLocalEmulatorCompatible, createLocalSimulator, startLocalEmulator, waitForLocalEmulator, waitForLocalSimulator, deleteLocalEmulator,
|
||||
deleteLocalSimulator, hostEmulatorAbi, installOnLocalEmulator, installOnLocalSimulator, approveLinkScheme, localPoseShown,
|
||||
@@ -72,6 +73,12 @@ export type CiMapOptions = {
|
||||
buildShare?: string;
|
||||
/** Which appearances to capture; `auto` (default) follows the app's `userInterfaceStyle`. */
|
||||
appearance?: AppearanceSetting;
|
||||
/**
|
||||
* One session's share of the appearance passes when a side splits them across sessions: `capture` names the passes
|
||||
* this run makes, out of the `all` it would make alone, so frames keep the ids of a single run (`<id>@dark`) and the
|
||||
* exports merge. Absent: every resolved appearance.
|
||||
*/
|
||||
appearancePass?: { all: readonly ColorScheme[]; capture: readonly ColorScheme[] };
|
||||
/** Whether to observe the app launch (splash screen) per appearance; `video` also keeps the recording. Defaults to `off`. */
|
||||
launch?: LaunchSetting;
|
||||
/** Decodes launch recordings; defaults to ffmpeg when installed. */
|
||||
@@ -218,7 +225,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
});
|
||||
const routes = inventory.filter(route => selected.has(route.id));
|
||||
const setup = revisionSetup(options.setup ?? [], plan, side);
|
||||
const runner = options.runner ?? defaultRunner;
|
||||
let runner = options.runner ?? defaultRunner;
|
||||
const sourceEnvironment = options.environment ?? process.env;
|
||||
const controller = options.controller ?? "agent-device";
|
||||
const local = options.simulator === "local";
|
||||
@@ -353,7 +360,11 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
let captureFailure: unknown;
|
||||
const finish = async (): Promise<CiMapResult> => {
|
||||
if (!(await store.exists())) await store.initialize(map, false);
|
||||
const incomplete = captureFailure !== undefined || selectedIds.some(id => outcomes[id]?.status !== "captured" || outcomes[id]?.landing !== "verified")
|
||||
// A session making only secondary passes owns the `<id>@<scheme>` frames of those passes, not the primary ones.
|
||||
const ownFrameIds = options.appearancePass && !options.appearancePass.capture.includes(colorSchemes[0]!)
|
||||
? selectedIds.flatMap(id => colorSchemes.filter(scheme => options.appearancePass!.capture.includes(scheme)).map(scheme => schemeScreenId(id, scheme)))
|
||||
: selectedIds;
|
||||
const incomplete = captureFailure !== undefined || ownFrameIds.some(id => outcomes[id]?.status !== "captured" || outcomes[id]?.landing !== "verified")
|
||||
|| map.gaps.some(gap => gap.status === "open");
|
||||
map.run.status = incomplete || map.screens.length === 0 ? "partial" : "complete";
|
||||
if (routes.length === 0) map.run.stopReason = "No source targets require capture.";
|
||||
@@ -422,7 +433,9 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
if (options.agent) assertAgentAcceptance(bundle, map, { required: true });
|
||||
// The side that produces the evidence checks it the way the review will: an integrity defect fails here, naming
|
||||
// its codes, instead of on the consuming side after both captures. Unavailable screens are not defects.
|
||||
assertNoCaptureHealthIssues(partitionCaptureHealthIssues(captureHealthIssues(bundle, selectedIds)).integrity);
|
||||
// A session capturing only a secondary appearance has no primary frames by design; the merged export is checked instead.
|
||||
const partialPass = options.appearancePass !== undefined && !options.appearancePass.capture.includes(colorSchemes[0]!);
|
||||
if (!partialPass) assertNoCaptureHealthIssues(partitionCaptureHealthIssues(captureHealthIssues(bundle, selectedIds)).integrity);
|
||||
await writeFile(join(outputDirectory, "bundle.json"), `${JSON.stringify(bundle, null, 2)}\n`, { flag: "wx" });
|
||||
if (metadata) await writeFile(join(outputDirectory, "execution.json"), `${JSON.stringify(metadata, null, 2)}\n`, { flag: "wx" });
|
||||
assertCheckout();
|
||||
@@ -441,6 +454,8 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
// `eas simulator:control` names the session by id, from the session's own project directory.
|
||||
const sessionEas: EasCommand = (args, commandOptions) => runner({ command: options.easCommand, args, cwd: simulatorProject, environment: easEnvironment,
|
||||
timeoutMs: commandOptions?.timeoutMs ?? 5 * 60_000, ...(commandOptions?.allowFailure ? { allowFailure: true } : {}) });
|
||||
// A failed simulator:control action is sent again after a pause, which a test's clock replaces.
|
||||
const controlOptions = { sleep: options.sleep };
|
||||
// What the EAS session's host can do through simulator:control (iOS sessions on serve-sim 0.10.0 or later).
|
||||
let controlActions = new Set<string>();
|
||||
const configResult = eas(["config", "--platform", options.platform, "--profile", options.easProfile, "--json", "--non-interactive"]);
|
||||
@@ -481,6 +496,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
let localOsVersion: string | undefined;
|
||||
// Argent's tool-server on this machine, when Argent drives a local device.
|
||||
let localArgent: LocalArgentServer | undefined;
|
||||
let argentBridge: ArgentBridgeRunner | undefined;
|
||||
const localDevice = () => localSimulator ?? localEmulator;
|
||||
// A local device starts booting now and finishes while the app is built and repacked; the session waits for it.
|
||||
let localEmulatorStart: Awaited<ReturnType<typeof startLocalEmulator>> | undefined;
|
||||
@@ -563,7 +579,8 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
const appDirectory = !options.buildShare ? await realpath(await mkdtemp(join(tmpdir(), "expo-explore-app-"))) : undefined;
|
||||
let localApp: string | undefined;
|
||||
type BuiltApp = { fingerprint: string; nativeEasBuildId: string | null; easBuildId: string | null; app?: string; reused: boolean; version?: string; buildNumber?: string };
|
||||
const buildApp = async (keepApp: string): Promise<BuiltApp> => {
|
||||
// `repacking` tells the captures sharing this build that their sessions can start too (sharedBuild).
|
||||
const buildApp = async (keepApp: string, repacking?: () => Promise<void>): Promise<BuiltApp> => {
|
||||
options.signal?.throwIfAborted();
|
||||
say("computing the native fingerprint");
|
||||
const fingerprintResult = eas(["fingerprint:generate", "--platform", options.platform, "--build-profile", options.easProfile, "--json", "--non-interactive"]);
|
||||
@@ -573,7 +590,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
"--fingerprint-hash", sourceFingerprint, ...(options.platform === "ios" ? ["--simulator"] : []), "--limit", "1", "--json", "--non-interactive"]).stdout);
|
||||
if (reusable) {
|
||||
say(`reusing EAS build ${reusable.id} (fingerprint ${sourceFingerprint.slice(0, 12)}); repacking it with this commit's JavaScript and the route observer`);
|
||||
startSession();
|
||||
startSession(); await repacking?.();
|
||||
const repacked = await prepareExactSourceBuild({ platform: options.platform, runner, easCommand: options.easCommand, repackCommand: options.repackCommand,
|
||||
project, nativeBuildId: reusable.id, fingerprint: sourceFingerprint, repackProfile: profile, easEnvironment, repackEnvironment: restrictedEnvironment, routes: inventory, repack: options.repack, easProfile: options.easProfile, keepApp });
|
||||
if (!repacked) throw new CiError({ code: "CAPTURE_OBSERVER_BUILD_UNSUPPORTED", stage: "instrumentation",
|
||||
@@ -587,7 +604,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
: `no finished simulator build has fingerprint ${sourceFingerprint.slice(0, 12)}; building on EAS and waiting for it to finish`);
|
||||
const built = nativeBuildFrom(eas(["build", "--platform", options.platform, "--profile", options.easProfile, "--wait", "--json", "--non-interactive"], 45 * 60_000).stdout);
|
||||
say(`EAS build ${built.id} finished; repacking it with the route observer`);
|
||||
startSession();
|
||||
startSession(); await repacking?.();
|
||||
const repacked = await prepareExactSourceBuild({ platform: options.platform, runner, easCommand: options.easCommand, repackCommand: options.repackCommand,
|
||||
project, nativeBuildId: built.id, fingerprint: built.fingerprint, repackProfile: profile, easEnvironment, repackEnvironment: restrictedEnvironment, routes: inventory, repack: options.repack, easProfile: options.easProfile, keepApp });
|
||||
if (!repacked) throw new CiError({ code: "CAPTURE_OBSERVER_BUILD_UNSUPPORTED", stage: "instrumentation",
|
||||
@@ -603,9 +620,11 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
? await sharedBuild({ directory: options.buildShare, appName, ...(options.signal ? { signal: options.signal } : {}), build: buildApp, owner: options.outputDirectory,
|
||||
key: { platform: options.platform, easProfile: options.easProfile, bundleId: options.bundleId, gitCommit: options.gitCommit, repack: options.repack ?? "eas", local,
|
||||
routes: inventory.map(route => route.id) },
|
||||
waiting: () => say("using the build another target of this review is preparing for this commit") })
|
||||
waiting: () => say("using the build another target of this review is preparing for this commit"),
|
||||
// The session is named before its app exists, so a waiter's session boots while the other capture repacks.
|
||||
repacking: () => startSession() })
|
||||
: await buildApp(join(appDirectory!, appName));
|
||||
// A capture that used another target's build starts its session now.
|
||||
// A capture that used another capture's build has its session started above; this starts the rest.
|
||||
startSession();
|
||||
fingerprint = built.fingerprint; nativeEasBuildId = built.nativeEasBuildId; easBuildId = built.easBuildId; localApp = built.app; reusedEasBuild = built.reused;
|
||||
if (!app.version && built.version) app.version = built.version;
|
||||
@@ -756,6 +775,11 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
AGENT_DEVICE_SESSION: CONTROLLER_SESSION, AGENT_DEVICE_SESSION_LOCK: "reject", AGENT_DEVICE_PLATFORM: options.platform };
|
||||
// Every controller call below goes to the session's controller; for Argent that is the bridge.
|
||||
const controllerCommand = argent?.command ?? options.agentDeviceCommand;
|
||||
// The capture's commands keep one bridge on a worker thread (EXPLORE_ARGENT_BRIDGE=process: one process per command, as before).
|
||||
if (argent && !options.runner && sourceEnvironment.EXPLORE_ARGENT_BRIDGE !== "process") {
|
||||
argentBridge = startArgentBridgeRunner({ command: argent.command, environment: argent.environment, fallback: defaultRunner, progress: say });
|
||||
runner = argentBridge.runner;
|
||||
}
|
||||
if (!local && localApp) {
|
||||
// The session started empty while the app was repacked; the controller installs it now.
|
||||
say(`installing the app on session ${sessionId}`);
|
||||
@@ -763,7 +787,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
"--platform", options.platform, "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 15 * 60_000 });
|
||||
// Before any link opens, as a local capture does with simctl: the app's own links then open without the prompt.
|
||||
if (sessionId && scheme) {
|
||||
const approved = approveSessionUrlSchemes(sessionEas, sessionId, controlActions, options.bundleId, [scheme]);
|
||||
const approved = approveSessionUrlSchemes(sessionEas, sessionId, controlActions, options.bundleId, [scheme], controlOptions);
|
||||
if (approved.length) say(`approved ${approved.map(item => `${item}://`).join(", ")} links on session ${sessionId}`);
|
||||
}
|
||||
}
|
||||
@@ -774,8 +798,10 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
const target = deviceArgs({ platform: options.platform, deviceModel: options.device, ...(localDevice() ? { provider: "local-simulator" as const, controllerDeviceId: localDevice()! } : {}) });
|
||||
// agent-device reads the hinge back after folding and fails to (locally and on EAS); its display is checked instead.
|
||||
const easAgentDevice = !!sessionId && controller === "agent-device";
|
||||
// Argent's bridge sends a fold again, twice, when the simulator-server it needs did not start within Argent's 30 s,
|
||||
// so a fold can take three of those waits and the panel checks after it: 4 minutes covers that.
|
||||
const fold = () => runner({ command: controllerCommand, args: ["fold", options.devicePose!, "--session", CONTROLLER_SESSION, ...target, "--platform", options.platform, "--json"],
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000, ...(localSimulator || easAgentDevice ? { allowFailure: true } : {}) });
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 4 * 60_000, ...(localSimulator || easAgentDevice ? { allowFailure: true } : {}) });
|
||||
const pause = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
|
||||
if (localSimulator && controller === "argent") {
|
||||
// Argent folds without a session and checks the fold against its own reader; this machine also checks the display.
|
||||
@@ -822,7 +848,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
if (!controlActions.has("springboard.restart")) throw new CiError({ code: "CONTROLLER_FOLD_UNVERIFIED", stage: "session",
|
||||
message: `${options.device} did not show the ${options.devicePose} display after folding.`, nextAction: "Rerun the capture on a new session." });
|
||||
say(`${options.device} did not draw the ${options.devicePose} display after the fold; restarting SpringBoard and folding ${options.devicePose} again`);
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart");
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart", [], controlOptions);
|
||||
pause(8_000);
|
||||
open(true);
|
||||
fold();
|
||||
@@ -837,7 +863,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
catch (error) {
|
||||
if (toCiError(error).code !== "CONTROLLER_FOLD_UNVERIFIED") throw error;
|
||||
say(`Argent kept reading the other panel after the fold; restarting SpringBoard and folding ${options.devicePose} again`);
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart");
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart", [], controlOptions);
|
||||
pause(8_000);
|
||||
try { fold(); }
|
||||
catch (retry) {
|
||||
@@ -870,7 +896,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
nextAction: "Rerun the capture; if it keeps happening, report it to Explore: this session's Argent tool-server needs a restart that EAS cannot do yet.", cause: error });
|
||||
if (recovery === 1) {
|
||||
say("Argent still did not read the app; restarting SpringBoard, then resetting Argent's device helpers and opening the app again");
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart");
|
||||
simulatorControl(sessionEas, sessionId, "springboard.restart", [], controlOptions);
|
||||
// SpringBoard takes a moment to come back, and sends the app to the background; the next open brings it back.
|
||||
(options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); }))(8_000);
|
||||
} else say("Argent did not read the app after starting it; resetting Argent's device helpers and opening the app again");
|
||||
@@ -914,12 +940,15 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
// Every pass sets the appearance explicitly, so a capture does not inherit whatever the simulator last used.
|
||||
const passes: CaptureBundle["outcomes"][] = [];
|
||||
const recordingTools = launchSetting === "off" ? undefined : options.recordingTools === undefined ? ffmpegRecordingTools() : options.recordingTools ?? undefined;
|
||||
const capturedSchemes = options.appearancePass ? colorSchemes.filter(scheme => options.appearancePass!.capture.includes(scheme)) : colorSchemes;
|
||||
for (const [index, colorScheme] of colorSchemes.entries()) {
|
||||
// A pass another session makes leaves its slot empty, so the passes stay aligned with the appearances they merge by.
|
||||
if (!capturedSchemes.includes(colorScheme)) { passes.push({}); continue; }
|
||||
// Argent cannot switch the appearance yet (software-mansion/argent#1509): the host does, simctl or adb on this
|
||||
// machine and serve-sim on an EAS iOS session; elsewhere its single pass runs as the device starts.
|
||||
if (controller !== "argent") runner({ command: controllerCommand, args: [...appearanceArgs(colorScheme), "--session", CONTROLLER_SESSION, ...deviceArgs(runtime), "--platform", options.platform],
|
||||
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 60_000 });
|
||||
else if (sessionId && controlActions.has("appearance.set")) simulatorControl(sessionEas, sessionId, "appearance.set", [colorScheme]);
|
||||
else if (sessionId && controlActions.has("appearance.set")) simulatorControl(sessionEas, sessionId, "appearance.set", [colorScheme], controlOptions);
|
||||
else if (localSimulator) setLocalSimulatorAppearance({ runner, udid: localSimulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
|
||||
else if (localEmulator) setLocalEmulatorAppearance({ runner, serial: localEmulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
|
||||
// A scheme change recreates the Android activity in place, and the sheets it re-presents lose their inset; a
|
||||
@@ -944,16 +973,22 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
...deviceArgs(runtime), "--platform", options.platform, "--level", "full", "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 60_000 });
|
||||
runtime.colorScheme = colorScheme;
|
||||
if (colorSchemes.length > 1) say(`appearance ${colorScheme} (${index + 1}/${colorSchemes.length})`);
|
||||
passes.push(await capturePlannedRoutes({ capture: { ...options, agentDeviceCommand: controllerCommand, setup, progress: say }, routes: missingRoutes, inventory, scheme, appName: app.name, runtime,
|
||||
passes.push(await capturePlannedRoutes({ capture: { ...options, ...(argentBridge && !options.agent ? { runner: argentBridge.runner } : {}), agentDeviceCommand: controllerCommand, setup, progress: say }, routes: missingRoutes, inventory, scheme, appName: app.name, runtime,
|
||||
connection, environment: controllerEnvironment, store, map, acceptedFrames, outcomes: index === 0 ? outcomes : {},
|
||||
...(colorSchemes.length > 1 ? { appearance: { scheme: colorScheme, primary: index === 0 } } : {}) }));
|
||||
}
|
||||
runtime.colorScheme = colorSchemes[0]!;
|
||||
Object.assign(outcomes, mergeSchemeOutcomes(passes, colorSchemes));
|
||||
// A session without the primary pass keeps each outcome as its pass recorded it, under `<id>@<scheme>`: the export
|
||||
// merge recombines them with the primary pass's (mergeSchemeOutcomes), which only then can tell an unattributed
|
||||
// frame beside a primary one from a lost route.
|
||||
if (options.appearancePass && !capturedSchemes.includes(colorSchemes[0]!)) {
|
||||
for (const [index, pass] of passes.entries()) for (const [id, outcome] of Object.entries(pass)) outcomes[schemeScreenId(id, colorSchemes[index])] = outcome;
|
||||
} else Object.assign(outcomes, mergeSchemeOutcomes(passes, colorSchemes));
|
||||
} catch (error) { primaryError = toCiError(error, { code: `CAPTURE_${runtimeStage.toUpperCase()}_FAILED`, stage: runtimeStage,
|
||||
nextAction: "Inspect the capture diagnostic, correct the failing prerequisite, and rerun Explore." }); }
|
||||
finally {
|
||||
if (appDirectory) await rm(appDirectory, { recursive: true, force: true });
|
||||
argentBridge?.close();
|
||||
if (localArgent) stopLocalArgentServer(localArgent);
|
||||
if (localEmulator) {
|
||||
try {
|
||||
@@ -1017,7 +1052,10 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
|
||||
throw primaryError;
|
||||
}
|
||||
setStage("export");
|
||||
const captured = selectedIds.filter(id => outcomes[id]?.status === "captured").length;
|
||||
say(`${captured} of ${selectedIds.length} ${selectedIds.length === 1 ? "route" : "routes"} captured`);
|
||||
const ownSchemes = options.appearancePass && !options.appearancePass.capture.includes(colorSchemes[0]!)
|
||||
? colorSchemes.filter(scheme => options.appearancePass!.capture.includes(scheme)) : undefined;
|
||||
const captured = selectedIds.filter(id => ownSchemes
|
||||
? ownSchemes.every(scheme => outcomes[schemeScreenId(id, scheme)]?.status === "captured") : outcomes[id]?.status === "captured").length;
|
||||
say(`${captured} of ${selectedIds.length} ${selectedIds.length === 1 ? "route" : "routes"} captured${ownSchemes ? ` in ${ownSchemes.join(", ")}` : ""}`);
|
||||
return finish();
|
||||
}
|
||||
@@ -6,6 +6,8 @@ export type CaptureSetupSnapshot = {
|
||||
nodes: readonly Record<string, unknown>[];
|
||||
refsGeneration?: number;
|
||||
truncated?: boolean;
|
||||
/** Whether the controller says a software keyboard shows, when it says (Argent does). */
|
||||
keyboardVisible?: boolean;
|
||||
};
|
||||
|
||||
type Awaitable<T> = T | Promise<T>;
|
||||
|
||||
@@ -19,21 +19,23 @@ const POLL_MS = 2_000;
|
||||
|
||||
/**
|
||||
* Runs `build` once per key across every capture sharing `directory`; the app it leaves goes in the build's folder
|
||||
* (`keepApp`), which outlives each capture. A waiter is told so it can say whose build it uses.
|
||||
* (`keepApp`), which outlives each capture. A waiter is told so it can say whose build it uses, and told again
|
||||
* (`repacking`) once the builder calls its `repacking` (the native build is known and is being repacked), or the
|
||||
* build is done: a waiter starts its session then, not while a native build may run for most of an hour.
|
||||
*/
|
||||
export async function sharedBuild<T extends object>(options: { directory: string; key: SharedBuildKey; appName: string; signal?: AbortSignal;
|
||||
build: (keepApp: string) => Promise<T>; waiting?: () => void;
|
||||
build: (keepApp: string, repacking: () => Promise<void>) => Promise<T>; waiting?: () => void; repacking?: () => void;
|
||||
/** Who builds it (the capture's output directory), so a review can fail its waiters if that capture dies (abandonSharedBuilds). */
|
||||
owner?: string }): Promise<T> {
|
||||
const folder = join(options.directory, sharedBuildId(options.key));
|
||||
const result = join(folder, "result.json"), failure = join(folder, "failure.json");
|
||||
const result = join(folder, "result.json"), failure = join(folder, "failure.json"), repack = join(folder, "repacking");
|
||||
await mkdir(options.directory, { recursive: true });
|
||||
let owner = true;
|
||||
try { await mkdir(folder); } catch (error) { if ((error as NodeJS.ErrnoException).code !== "EEXIST") throw error; owner = false; }
|
||||
if (owner) {
|
||||
if (options.owner) await writeFile(join(folder, "owner"), options.owner);
|
||||
try {
|
||||
const built = await options.build(join(folder, options.appName));
|
||||
const built = await options.build(join(folder, options.appName), () => writeFile(repack, "").catch(() => undefined));
|
||||
await writeFile(`${result}.tmp`, JSON.stringify(built));
|
||||
await rename(`${result}.tmp`, result);
|
||||
return built;
|
||||
@@ -44,9 +46,11 @@ export async function sharedBuild<T extends object>(options: { directory: string
|
||||
}
|
||||
}
|
||||
options.waiting?.();
|
||||
let repackSeen = false;
|
||||
for (;;) {
|
||||
options.signal?.throwIfAborted();
|
||||
const done = await readFile(result, "utf8").catch(() => undefined);
|
||||
if (!repackSeen && (done !== undefined || existsSync(repack))) { repackSeen = true; options.repacking?.(); }
|
||||
if (done !== undefined) return JSON.parse(done) as T;
|
||||
const failed = await readFile(failure, "utf8").catch(() => undefined);
|
||||
if (failed !== undefined) {
|
||||
|
||||
@@ -20,23 +20,53 @@ export function simulatorControlActions(eas: EasCommand, sessionId: string): Set
|
||||
} catch { return new Set(); }
|
||||
}
|
||||
|
||||
/** Runs one `eas simulator:control` action on the session; eas-cli fills in the device. Throws with EAS's reason. */
|
||||
export function simulatorControl(eas: EasCommand, sessionId: string, action: string, values: readonly string[] = []): void {
|
||||
/**
|
||||
* Pauses before each resend of a failed action. Every action Explore runs is idempotent, and the session's host can fail
|
||||
* one once: in brentvatne/euxy's baseline run 39348933440, `app.approveUrlScheme` failed in its `simctl spawn … defaults
|
||||
* write`, which failed the dark-appearance session and with it the target's whole baseline.
|
||||
*/
|
||||
const SIMULATOR_CONTROL_RETRY_DELAYS_MS = [3_000, 6_000] as const;
|
||||
|
||||
/** Lets a test replace the pause between resends of a failed action. */
|
||||
export type SimulatorControlOptions = { sleep?: ((milliseconds: number) => void) | undefined };
|
||||
|
||||
/**
|
||||
* Runs one `eas simulator:control` action on the session; eas-cli fills in the device. A failed action is sent again
|
||||
* after a pause; one that still fails throws with EAS's reason.
|
||||
*/
|
||||
export function simulatorControl(eas: EasCommand, sessionId: string, action: string, values: readonly string[] = [], options: SimulatorControlOptions = {}): void {
|
||||
const sleep = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
|
||||
// Values follow `--` so one that starts with a dash is never read as a flag.
|
||||
eas(["simulator:control", action, "--id", sessionId, "--json", "--non-interactive", "--", ...values], { timeoutMs: 2 * 60_000 });
|
||||
const args = ["simulator:control", action, "--id", sessionId, "--json", "--non-interactive", "--", ...values];
|
||||
for (let retry = 0; ; retry += 1) {
|
||||
try { eas(args, { timeoutMs: 2 * 60_000 }); return; }
|
||||
catch (error) {
|
||||
const delayMs = SIMULATOR_CONTROL_RETRY_DELAYS_MS[retry];
|
||||
if (delayMs === undefined) throw error;
|
||||
// A resend that succeeds would otherwise leave no trace of the failure in the job log.
|
||||
process.stderr.write(`simulator:control ${action} failed (${firstLine(error)}); sending it again in ${delayMs / 1000} s\n`);
|
||||
sleep(delayMs);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Lets the app open its own links without iOS asking "Open in “App”?" first, like local captures do with simctl. A
|
||||
* session without the action keeps the controllers' prompt handling; http and https never prompt and are skipped.
|
||||
*/
|
||||
export function approveSessionUrlSchemes(eas: EasCommand, sessionId: string, actions: ReadonlySet<string>, bundleId: string, schemes: readonly string[]): string[] {
|
||||
export function approveSessionUrlSchemes(eas: EasCommand, sessionId: string, actions: ReadonlySet<string>, bundleId: string, schemes: readonly string[],
|
||||
options: SimulatorControlOptions = {}): string[] {
|
||||
if (!actions.has("app.approveUrlScheme")) return [];
|
||||
const approved: string[] = [];
|
||||
for (const scheme of new Set(schemes.map(value => value.toLowerCase()))) {
|
||||
if (scheme === "http" || scheme === "https" || !/^[a-z][a-z0-9+.-]*$/.test(scheme)) continue;
|
||||
simulatorControl(eas, sessionId, "app.approveUrlScheme", [bundleId, scheme]);
|
||||
simulatorControl(eas, sessionId, "app.approveUrlScheme", [bundleId, scheme], options);
|
||||
approved.push(scheme);
|
||||
}
|
||||
return approved;
|
||||
}
|
||||
|
||||
/** The first line of a failure, for a log line. */
|
||||
function firstLine(error: unknown): string {
|
||||
return (error instanceof Error ? error.message : String(error)).split("\n", 1)[0]!.slice(0, 300);
|
||||
}
|
||||
@@ -28,6 +28,9 @@ const recipeKey = ({ inventory, profile, config, toolsCommit }: Recipe) => {
|
||||
|
||||
/** Only settings that can change captured runtime evidence belong in the recipe. */
|
||||
export function captureRecipeConfig(config: ExploreConfig, instructionsSha256?: string): string {
|
||||
// How many sessions capture the evidence (capture.maxSessions) does not change it.
|
||||
const { maxSessions: _maxSessions, ...capture } = config.capture;
|
||||
void _maxSessions;
|
||||
return canonicalJson({
|
||||
observer: CAPTURE_OBSERVER_HASH,
|
||||
mode: config.mode,
|
||||
@@ -36,7 +39,7 @@ export function captureRecipeConfig(config: ExploreConfig, instructionsSha256?:
|
||||
...(config.app.scheme === undefined ? {} : { scheme: config.app.scheme }) },
|
||||
device: config.device, parameters: config.parameters, setup: config.setup ?? [],
|
||||
// The repack as it resolves, so a config that leaves it to the default keeps the recipe it had when the default was written out.
|
||||
capture: { ...config.capture, repack: captureRepack(config) },
|
||||
capture: { ...capture, repack: captureRepack(config) },
|
||||
// agent-device recipes stay as they were; an Argent capture is keyed to the Argent release that drove it.
|
||||
...(config.capture.controller === "argent" ? { controllerVersion: ARGENT_VERSION } : {}),
|
||||
});
|
||||
|
||||
@@ -0,0 +1,83 @@
|
||||
import { copyFile, mkdir, readdir, readFile, writeFile, appendFile, lstat } from "node:fs/promises";
|
||||
import { dirname, join, relative } from "node:path";
|
||||
|
||||
import { bundleColorSchemes, mergeSchemeOutcomes, routeIdOfScreen, type ColorScheme } from "../capture/appearance.js";
|
||||
import type { CaptureOutcome } from "../contracts/capture.js";
|
||||
import type { CaptureBundle } from "../contracts/capture.js";
|
||||
import type { ExploreMap } from "../types.js";
|
||||
|
||||
const LIST_FIELDS = ["artifacts", "screens", "variants", "observations", "elements", "actionAttempts", "transitions", "journeys", "frontier", "gaps"] as const;
|
||||
|
||||
async function readJson<T>(path: string): Promise<T> { return JSON.parse(await readFile(path, "utf8")) as T; }
|
||||
|
||||
async function copyTree(source: string, destination: string, skip: (relativePath: string) => boolean, root = source): Promise<void> {
|
||||
for (const entry of await readdir(source, { withFileTypes: true })) {
|
||||
const from = join(source, entry.name), to = join(destination, entry.name), rel = relative(root, from);
|
||||
if (skip(rel)) continue;
|
||||
if (entry.isDirectory()) { await mkdir(to, { recursive: true }); await copyTree(from, to, skip, root); continue; }
|
||||
if (!entry.isFile()) continue;
|
||||
if ((await lstat(to).catch(() => undefined))) continue;
|
||||
await mkdir(dirname(to), { recursive: true });
|
||||
await copyFile(from, to);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Fold the exports of a side's secondary appearance sessions into its primary export, in place: the frames, outcomes,
|
||||
* launch evidence and map records of each `<id>@<scheme>` screen, and their files. Each session captured its passes as
|
||||
* one run would (`appearancePass`), so records only append; a secondary export never replaces a primary record.
|
||||
*/
|
||||
export async function mergeCaptureExports(primary: string, secondaries: readonly { directory: string; scheme: ColorScheme }[]): Promise<void> {
|
||||
if (secondaries.length === 0) return;
|
||||
const bundle = await readJson<CaptureBundle>(join(primary, "bundle.json"));
|
||||
const map = await readJson<ExploreMap>(join(primary, "screen-map.json"));
|
||||
const known = { screens: new Set(map.screens.map(screen => screen.id)), artifacts: new Set(map.artifacts.map(artifact => artifact.id)) };
|
||||
// The outcomes recombine as one run's passes do (mergeSchemeOutcomes): a secondary pass records a verified frame under
|
||||
// `<id>@<scheme>` and a lost route under `<id>`, which the merge folds into the primary record the same way.
|
||||
const schemes = bundleColorSchemes(bundle);
|
||||
const passes: Record<string, CaptureOutcome>[] = schemes.map(() => ({}));
|
||||
for (const [id, outcome] of Object.entries(bundle.outcomes)) if (!routeIdOfScreen(id).scheme) passes[0]![id] = outcome;
|
||||
for (const { directory: secondary, scheme } of secondaries) {
|
||||
const other = await readJson<CaptureBundle>(join(secondary, "bundle.json"));
|
||||
const pass = passes[schemes.indexOf(scheme)];
|
||||
// A session that could not show its appearance (Argent without appearance.set captures one) has nothing to add, as
|
||||
// one run would have no pass for it.
|
||||
if (!pass && !bundleColorSchemes(other).includes(scheme)) continue;
|
||||
if (!pass) throw new Error(`The ${scheme} session's export is not an appearance of the primary export (${schemes.join(", ")})`);
|
||||
for (const [id, outcome] of Object.entries(other.outcomes)) pass[routeIdOfScreen(id).routeId] = outcome;
|
||||
const otherMap = await readJson<ExploreMap>(join(secondary, "screen-map.json"));
|
||||
for (const [id, image] of Object.entries(other.images)) if (routeIdOfScreen(id).scheme && !bundle.images[id]) bundle.images[id] = image;
|
||||
for (const [scheme, record] of Object.entries(other.launch ?? {})) { bundle.launch ??= {}; bundle.launch[scheme] ??= record; }
|
||||
for (const [id, context] of Object.entries(other.captureContexts ?? {})) { bundle.captureContexts ??= {}; bundle.captureContexts[id] ??= context; }
|
||||
for (const field of LIST_FIELDS) {
|
||||
const records = (otherMap[field] ?? []) as Array<Record<string, unknown>>;
|
||||
const target = ((map as unknown as Record<string, unknown[]>)[field] ??= []);
|
||||
for (const record of records) {
|
||||
if (field === "screens" && known.screens.has(record.id as string)) continue;
|
||||
if (field === "artifacts" && known.artifacts.has(record.id as string)) continue;
|
||||
if (field === "screens") known.screens.add(record.id as string);
|
||||
if (field === "artifacts") known.artifacts.add(record.id as string);
|
||||
target.push(record);
|
||||
}
|
||||
}
|
||||
// Files: artifacts and launch evidence are new paths; diagnostics append to the primary's lines.
|
||||
await copyTree(secondary, primary, rel => rel === "bundle.json" || rel === "screen-map.json" || rel === "screen-map.schema.json" || rel === "manifest.json"
|
||||
|| rel === "execution.json" || rel.startsWith("capture-diagnostics"));
|
||||
const diagnostics = join(secondary, "capture-diagnostics");
|
||||
for (const entry of await readdir(diagnostics, { withFileTypes: true }).catch(() => [])) {
|
||||
if (!entry.isFile()) continue;
|
||||
const to = join(primary, "capture-diagnostics", entry.name);
|
||||
await mkdir(dirname(to), { recursive: true });
|
||||
if (entry.name.endsWith(".jsonl")) await appendFile(to, await readFile(join(diagnostics, entry.name)));
|
||||
else if (!(await lstat(to).catch(() => undefined))) await copyFile(join(diagnostics, entry.name), to);
|
||||
}
|
||||
}
|
||||
// An open gap a secondary pass left makes the run partial, as it does one run's (a complete run has none).
|
||||
if (map.gaps.some(gap => gap.status === "open")) map.run.status = "partial";
|
||||
const manifest = await readJson<{ files: unknown[] }>(join(primary, "manifest.json"));
|
||||
manifest.files = map.artifacts.map(artifact => ({ path: artifact.path, sha256: artifact.sha256, bytes: artifact.bytes, mimeType: artifact.mimeType }));
|
||||
await writeFile(join(primary, "screen-map.json"), JSON.stringify(map));
|
||||
bundle.outcomes = mergeSchemeOutcomes(passes, schemes);
|
||||
await writeFile(join(primary, "bundle.json"), JSON.stringify(bundle));
|
||||
await writeFile(join(primary, "manifest.json"), `${JSON.stringify(manifest, null, 2)}\n`);
|
||||
}
|
||||
@@ -1,14 +1,14 @@
|
||||
import type { RunTarget } from "../types.js";
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { randomBytes } from "node:crypto";
|
||||
import { readFileSync } from "node:fs";
|
||||
import { readFileSync, readdirSync } from "node:fs";
|
||||
import { copyFile, cp, lstat, mkdir, mkdtemp, readdir, readFile, realpath, rename, rm, stat, utimes, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join, relative, resolve } from "node:path";
|
||||
import { runCiReview } from "./pipeline.js";
|
||||
import { resolveCommit } from "./workflow-steps.js";
|
||||
import { ciLayout, installCommand, type PackageManager } from "./workflow-install.js";
|
||||
import { configPlatforms, readExploreConfig, resolveTargetConfig, configTargets, withRunOverrides, DEFAULT_EXPLORE_CONFIG_PATH, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { configPlatforms, readExploreConfig, resolveTargetConfig, configTargets, posedTargets, withRunOverrides, DEFAULT_EXPLORE_CONFIG_PATH, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { AGENT_PROVIDERS, defaultExploreConfig } from "../config/setup.js";
|
||||
import type { PrepareCiExplorationOptions } from "../capture/agent/exploration.js";
|
||||
import { createCiAgentSession } from "../capture/agent/session.js";
|
||||
@@ -26,6 +26,7 @@ import { abandonSharedBuilds } from "../capture/shared-build.js";
|
||||
import { exploreCacheRoot } from "../shared/cache-root.js";
|
||||
import { packageBin } from "../shared/package-paths.js";
|
||||
import { silentProgress, type Progress } from "../shared/progress.js";
|
||||
import { maxParallelTargets } from "./session-plan.js";
|
||||
|
||||
/**
|
||||
* `capture:review --base REF [--head REF]` on a laptop: the same review CI runs (`runCiReview`), on two commits of the
|
||||
@@ -44,7 +45,7 @@ export type LocalReviewOptions = {
|
||||
platform?: ExplorePlatform | undefined;
|
||||
/** `--target`: capture this config.yaml target alone; with `platform`, the targets of that platform. */
|
||||
target?: string | undefined;
|
||||
/** `--parallel`: how many targets capture at once (each runs a simulator or emulator per side); all of them by default. */
|
||||
/** `--parallel`: how many targets capture at once (each runs a simulator or emulator per side); by default all of them, up to capture.maxSessions. */
|
||||
parallel?: number | undefined;
|
||||
scope?: string | undefined;
|
||||
expiresIn?: string | undefined;
|
||||
@@ -285,8 +286,15 @@ export async function keepCapture(exported: string, target: string): Promise<boo
|
||||
}
|
||||
}
|
||||
|
||||
/** The session state files a review writes: `<side>-session`, and `<side>-session-<scheme>` for appearance passes in their own sessions. */
|
||||
function sessionStateFiles(output: string): string[] {
|
||||
const rank = (name: string) => ["head", "base", "baseline"].indexOf(name.split("-")[0]!);
|
||||
try { return readdirSync(output).filter(name => /^(head|base|baseline)-session(-[a-z]+)?$/.test(name)).sort((a, b) => rank(a) - rank(b) || a.localeCompare(b)); }
|
||||
catch { return []; }
|
||||
}
|
||||
|
||||
function recordedSessionIds(outputs: string[]): string[] {
|
||||
return outputs.flatMap(output => ["head-session", "base-session"].flatMap(name => {
|
||||
return outputs.flatMap(output => sessionStateFiles(output).flatMap(name => {
|
||||
try { const id = readFileSync(join(output, name), "utf8").trim(); return /^[A-Za-z0-9][A-Za-z0-9._-]{0,199}$/.test(id) ? [id] : []; } catch { return []; }
|
||||
}));
|
||||
}
|
||||
@@ -307,7 +315,7 @@ export async function stopRecordedSessions(outputs: string[], environment: NodeJ
|
||||
simctl: (args: string[]) => { status: number | null } = args => spawnSync("xcrun", ["simctl", ...args], { env: environment, encoding: "utf8", timeout: 120_000 }),
|
||||
adb: (args: string[]) => { status: number | null } = args => spawnSync(androidTools(environment).adb, args, { env: environment, encoding: "utf8", timeout: 60_000 })): Promise<string[]> {
|
||||
const stopped: string[] = [];
|
||||
for (const output of outputs) for (const name of ["head-session", "base-session"]) {
|
||||
for (const output of outputs) for (const name of sessionStateFiles(output)) {
|
||||
const file = join(output, name);
|
||||
const id = (await readFile(file, "utf8").catch(() => "")).trim();
|
||||
if (!/^[A-Za-z0-9][A-Za-z0-9._-]{0,199}$/.test(id)) continue;
|
||||
@@ -479,7 +487,7 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
|
||||
target, ...(targets.length > 1 ? { targets } : {}) };
|
||||
progress(`${target.id}: reviewing${target.id === platform ? "" : ` (${target.label})`}`);
|
||||
const result = await runCiReview({ projects, output, config, presentation, runId, runAttempt: "1", state, environment: platformEnvironment,
|
||||
...(platforms.length > 1 ? { platforms } : {}), ...(targets.length > 1 ? { targets } : {}),
|
||||
...(platforms.length > 1 ? { platforms } : {}), ...(targets.length > 1 ? { targets } : {}), posedTargets: posedTargets(rawConfig),
|
||||
// Targets of one platform capture the same commits from the same build; it is built and repacked once.
|
||||
...(targets.length > 1 ? { buildShare: join(work, ".builds") } : {}),
|
||||
subscription, useLocalEasSession, progress: message => progress(`${target.id}: ${message}`),
|
||||
@@ -537,7 +545,8 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
|
||||
await abandonSharedBuilds(join(work, ".builds"), owner => owner === join(work, target.id, `${side}-export`), failure.code);
|
||||
}
|
||||
};
|
||||
const settled = await settleLimited(targets, options.parallel ?? targets.length,
|
||||
// Each target needs a simulator session: no more run at once than capture.maxSessions, unless --parallel says.
|
||||
const settled = await settleLimited(targets, options.parallel ?? maxParallelTargets(rawConfig.capture.maxSessions, targets.length),
|
||||
target => captureTarget(target).catch(async (error: unknown) => { await releaseBuilds(target, error).catch(() => undefined); throw error; }));
|
||||
// One target that fails costs that target's report, not the others': they are kept, and the failure is named.
|
||||
// Only an interrupted review, or one where every target failed, fails as a whole.
|
||||
|
||||
@@ -1,13 +1,18 @@
|
||||
import { systemRegions } from "../contracts/capture.js";
|
||||
import type { RunTarget } from "../types.js";
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { mkdir, open, readFile, realpath, writeFile } from "node:fs/promises";
|
||||
import { execFile, spawnSync } from "node:child_process";
|
||||
import { mkdir, mkdtemp, open, readFile, realpath, rm, writeFile } from "node:fs/promises";
|
||||
import { join, relative, resolve, isAbsolute } from "node:path";
|
||||
import { tmpdir } from "node:os";
|
||||
import { setTimeout as delay } from "node:timers/promises";
|
||||
import { promisify } from "node:util";
|
||||
import { buildVerifiedPlan } from "./verified-plan.js";
|
||||
import { runCiMap, type CommandRunner } from "../capture/run.js";
|
||||
import { routeIdOfScreen } from "../capture/appearance.js";
|
||||
import { runCiMap, type CiMapOptions, type CommandRunner } from "../capture/run.js";
|
||||
import { resolveColorSchemes, routeIdOfScreen, type ColorScheme } from "../capture/appearance.js";
|
||||
import { baseEnvironment } from "../capture/common.js";
|
||||
import { DEFAULT_MAX_SESSIONS, planSideSessions, sessionShare } from "./session-plan.js";
|
||||
import { mergeCaptureExports } from "./export-merge.js";
|
||||
import { abandonSharedBuilds } from "../capture/shared-build.js";
|
||||
import { prepareCaptureReview, readCaptureBundle } from "../review/capture-review.js";
|
||||
import { quarantineReviewContract } from "../contracts/review-validation.js";
|
||||
import { agentCaptureConstraints } from "../capture/agent/source-context.js";
|
||||
@@ -64,6 +69,8 @@ async function recipe(config: ExploreConfig, plan: SourceCapturePlan, side: "bas
|
||||
/** The capture's clock and host-side pause; tests pair them with an injected runner so readiness budgets are not real time. */
|
||||
type CaptureClock = { now?: (() => number) | undefined; sleep?: ((milliseconds: number) => void) | undefined };
|
||||
|
||||
const execFileAsync = promisify(execFile);
|
||||
|
||||
function captureOptions(config: ExploreConfig, environment: NodeJS.ProcessEnv, runner?: CommandRunner, clock: CaptureClock = {}) {
|
||||
return { ...(runner && clock.now ? { now: clock.now } : {}), ...(runner && clock.sleep ? { sleep: clock.sleep } : {}), platform: config.app.platform, bundleId: config.app.bundleId,
|
||||
...(config.app.scheme ? { scheme: config.app.scheme } : {}), device: config.device.name, ...(config.device.pose ? { devicePose: config.device.pose } : {}),
|
||||
@@ -85,6 +92,87 @@ async function prefetchControllers(config: ExploreConfig, environment: NodeJS.Pr
|
||||
if (config.capture.controller === "argent" && config.capture.simulator === "local") await ensureArgentToolServer({ environment, progress });
|
||||
}
|
||||
|
||||
/**
|
||||
* The appearances a capture of this side renders, read before any session starts so the sessions can divide them. The
|
||||
* app config comes from `eas config` in a child process, as the capture reads it, with the capture's restricted
|
||||
* environment: never evaluated in this process, which holds the review's secrets. Unknown: undefined.
|
||||
*/
|
||||
async function expectedColorSchemes(config: ExploreConfig, project: string, environment: NodeJS.ProcessEnv, easCommand: string): Promise<ColorScheme[] | undefined> {
|
||||
// Argent switches the appearance only through serve-sim on an EAS iOS session; elsewhere it captures one.
|
||||
if (config.capture.controller === "argent" && config.capture.simulator !== "local" && config.app.platform !== "ios") return undefined;
|
||||
if (config.capture.appearance !== "auto") return resolveColorSchemes(config.capture.appearance, undefined, config.app.platform);
|
||||
const easEnvironment = { ...baseEnvironment(environment), ...(environment.EXPO_TOKEN ? { EXPO_TOKEN: environment.EXPO_TOKEN } : {}) };
|
||||
try {
|
||||
const { stdout } = await execFileAsync(easCommand, ["config", "--platform", config.app.platform, "--profile", config.app.easProfile, "--json", "--non-interactive"],
|
||||
{ cwd: project, env: easEnvironment, timeout: 5 * 60_000, maxBuffer: 16 * 1024 * 1024 });
|
||||
const app = (JSON.parse(stdout) as { appConfig?: Record<string, unknown> }).appConfig;
|
||||
return app && typeof app === "object" ? resolveColorSchemes("auto", app, config.app.platform) : undefined;
|
||||
} catch {
|
||||
// The capture reads the same config and reports why it cannot; until then the side keeps one session.
|
||||
return undefined;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Run one side's capture: in one session, or when `passes` splits its appearances, one worker session per pass. The
|
||||
* primary pass exports to `mapOptions.outputDirectory`; the others beside it, named by their appearances, then merge.
|
||||
*/
|
||||
async function captureSideInSessions(mapOptions: CiMapOptions, passes: readonly (readonly ColorScheme[])[] | undefined,
|
||||
progress: Progress, signal: AbortSignal | undefined, worker: boolean): Promise<Awaited<ReturnType<typeof runCiMap>>> {
|
||||
const runOnWorker = (passOptions: CiMapOptions) =>
|
||||
runCiMapOnWorker((({ progress: _progress, runner: _runner, agent: _agent, signal: _signal, ...rest }) => rest)(passOptions), progress, signal);
|
||||
if (!passes || passes.length <= 1) return worker ? runOnWorker(mapOptions) : runCiMap(mapOptions);
|
||||
const schemes = passes.flat();
|
||||
progress(`${mapOptions.side}: capturing ${passes.map(pass => pass.join("+")).join(" and ")} in separate sessions`);
|
||||
// The passes install the same app: they share one build and repack, as the targets of a local review do.
|
||||
const ownBuildShare = mapOptions.buildShare ? undefined : await mkdtemp(join(tmpdir(), "expo-explore-builds-"));
|
||||
const buildShare = mapOptions.buildShare ?? ownBuildShare!;
|
||||
const settled = await Promise.allSettled(passes.map(async (pass, index) => {
|
||||
const suffix = index === 0 ? "" : `-${pass.join("-")}`;
|
||||
const outputDirectory = `${mapOptions.outputDirectory}${suffix}`;
|
||||
try {
|
||||
return await runOnWorker({ ...mapOptions, mapDirectory: `${mapOptions.mapDirectory}${suffix}`, outputDirectory, buildShare,
|
||||
...(mapOptions.sessionStatePath ? { sessionStatePath: `${mapOptions.sessionStatePath}${suffix}` } : {}), appearancePass: { all: schemes, capture: pass } });
|
||||
} catch (error) {
|
||||
// A pass that dies mid-build must not leave the others polling for its result.
|
||||
await abandonSharedBuilds(buildShare, owner => owner === outputDirectory, toCiError(error).code).catch(() => undefined);
|
||||
throw error;
|
||||
}
|
||||
}));
|
||||
// The build folder holds the repacked app, which the sessions have installed.
|
||||
if (ownBuildShare) await rm(ownBuildShare, { recursive: true, force: true });
|
||||
for (const outcome of settled) if (outcome.status === "rejected") throw outcome.reason;
|
||||
await mergeCaptureExports(mapOptions.outputDirectory, passes.slice(1).map(pass => ({ directory: `${mapOptions.outputDirectory}-${pass.join("-")}`, scheme: pass[0]! })));
|
||||
return (settled[0] as PromiseFulfilledResult<Awaited<ReturnType<typeof runCiMap>>>).value;
|
||||
}
|
||||
|
||||
/**
|
||||
* This target's share of `capture.maxSessions`: the targets are this review's (`targets`), or the config's one, and
|
||||
* `posedTargets` (foldables) take the sessions that do not divide evenly.
|
||||
*/
|
||||
function targetSessionShare(config: ExploreConfig, targets: readonly RunTarget[] | undefined, posedTargets: readonly string[] | undefined): number {
|
||||
const targetIds: string[] = (targets ?? []).map(target => target.id);
|
||||
if (targetIds.length === 0) targetIds.push(...(config.targets ? Object.keys(config.targets) : [config.target?.id ?? "default"]));
|
||||
return sessionShare({ maxSessions: config.capture.maxSessions, targets: targetIds, target: config.target?.id ?? targetIds[0]!,
|
||||
prefer: id => posedTargets?.includes(id) ? 1 : 0 });
|
||||
}
|
||||
|
||||
/**
|
||||
* The appearance passes one side spreads over sessions of its own, out of its target's share of `capture.maxSessions`;
|
||||
* undefined keeps the side in one session. The side's app config is read only when its share and routes could pay for
|
||||
* a split.
|
||||
*/
|
||||
export async function sideAppearancePasses(config: ExploreConfig, environment: NodeJS.ProcessEnv,
|
||||
input: { share: number; sides: 1 | 2; routes: number; project: string; easCommand?: string }): Promise<ColorScheme[][] | undefined> {
|
||||
// A pass observes its launch only when capture.launch asks for it.
|
||||
const plan = (schemes: readonly ColorScheme[]) => planSideSessions({ share: input.share, sides: input.sides, routes: input.routes, schemes,
|
||||
...(config.capture.launch === "off" ? { launchSeconds: 0 } : {}) }).passes;
|
||||
if (plan(["light", "dark"]).length < 2) return undefined;
|
||||
const schemes = await expectedColorSchemes(config, input.project, environment, input.easCommand ?? packageBin("eas-cli", "eas"));
|
||||
const passes = schemes ? plan(schemes) : [];
|
||||
return passes.length > 1 ? passes.map(pass => [...pass]) : undefined;
|
||||
}
|
||||
|
||||
export function captureSidesConcurrently(input: { plan: SourceCapturePlan; agent: boolean; injectedRunner: boolean; baselineMayExist: boolean }): boolean {
|
||||
return !input.agent && !input.injectedRunner && !input.baselineMayExist
|
||||
&& input.plan.headCaptureSurfaceIds.length > 0 && input.plan.baseCaptureSurfaceIds.length > 0;
|
||||
@@ -112,6 +200,8 @@ export type PublicCiOptions = {
|
||||
platforms?: ExplorePlatform[];
|
||||
/** Every target config.yaml captures, in config order; recorded in the report so the Viewer links the sibling targets' reports. */
|
||||
targets?: RunTarget[];
|
||||
/** The targets with a device pose (foldables), which take the sessions `capture.maxSessions` does not divide evenly. */
|
||||
posedTargets?: readonly string[];
|
||||
baseProject: string; headProject: string; pullRequestPath: string; output: string;
|
||||
config: ExploreConfig; configPath?: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch;
|
||||
now?: () => number; sleep?: (milliseconds: number) => void; onComment?: (state: PublicCommentState, body: string) => void;
|
||||
@@ -254,6 +344,8 @@ export async function runCiReview(options: {
|
||||
platforms?: ExplorePlatform[];
|
||||
/** Every target config.yaml captures; `config.target` is the one this review captures. */
|
||||
targets?: RunTarget[];
|
||||
/** The targets with a device pose (foldables), which take the sessions `capture.maxSessions` does not divide evenly. */
|
||||
posedTargets?: readonly string[];
|
||||
/** A folder shared with the other targets' reviews, so the targets of one platform build each commit once. */
|
||||
buildShare?: string;
|
||||
measure?: Parameters<typeof assessPublicEvidence>[0]["measure"];
|
||||
@@ -309,7 +401,20 @@ export async function runCiReview(options: {
|
||||
// A baseline that may be restored needs the head runtime profile first; otherwise both sides capture at once.
|
||||
const baselineMayExist = plan.baseCaptureSurfaceIds.length > 0 && await captureArtifactCacheMayMatch({ ...cacheRecipes.base,
|
||||
...(environment.EXPLORE_CAPTURE_CACHE ? { sourceDirectory: environment.EXPLORE_CAPTURE_CACHE } : {}), commit: pr.base.sha });
|
||||
const concurrent = captureSidesConcurrently({ plan, agent: !!exploration.agent, injectedRunner: !!options.runner, baselineMayExist });
|
||||
const share = targetSessionShare(config, options.targets, options.posedTargets);
|
||||
// A share of one session captures the sides in turn.
|
||||
const concurrent = captureSidesConcurrently({ plan, agent: !!exploration.agent, injectedRunner: !!options.runner, baselineMayExist }) && share >= 2;
|
||||
// Each side's appearances split by its own app config: a pull request can change userInterfaceStyle. Sides taken in
|
||||
// turn (a baseline may be restored) each have the whole share. Passes run on worker threads, which cannot take an
|
||||
// injected runner or an agent session.
|
||||
const sidePasses = { head: undefined as ColorScheme[][] | undefined, base: undefined as ColorScheme[][] | undefined };
|
||||
if (!exploration.agent && !options.runner) await Promise.all((["head", "base"] as const).map(async side => {
|
||||
sidePasses[side] = await sideAppearancePasses(config, environment, { share, sides: concurrent ? 2 : 1, routes: plan[`${side}CaptureSurfaceIds`].length, project: projects[side] });
|
||||
}));
|
||||
const split = (["head", "base"] as const).filter(side => sidePasses[side]);
|
||||
progress(`sessions: ${share} of ${config.capture.maxSessions ?? DEFAULT_MAX_SESSIONS} for this target; `
|
||||
+ (split.length ? `${split.join(" and ")} ${split.length === 1 ? "captures its" : "capture their"} appearances in separate sessions`
|
||||
: concurrent ? "one session per side" : "the sides in turn"));
|
||||
const captureSide = async (side: "head" | "base") => {
|
||||
const directory = join(output, `${side}-export`);
|
||||
const selectedIds = plan[`${side}CaptureSurfaceIds`];
|
||||
@@ -329,9 +434,8 @@ export async function runCiReview(options: {
|
||||
name: config.app.name ?? pr.repository, buildId: pr.origin === "local" ? `local-${pr.runId}-${side}` : pr.origin === "compare" ? `compare-${options.runId}-${side}` : `pr-${pr.number}-${side}`, buildVersion: pr[side].sha.slice(0, 8), gitCommit: pr[side].sha,
|
||||
planPath: join(output, "execution-plan.json"), side, sessionStatePath: join(output, `${side}-session`), ...(options.buildShare ? { buildShare: options.buildShare } : {}),
|
||||
...(reuseDirectory ? { reuseDirectory } : {}), ...(options.signal ? { signal: options.signal } : {}) };
|
||||
const captured = concurrent
|
||||
? await runCiMapOnWorker((({ progress: _progress, runner: _runner, agent: _agent, signal: _signal, ...rest }) => rest)(mapOptions), progress, options.signal)
|
||||
: await runCiMap(mapOptions);
|
||||
// A restored baseline already holds every appearance pass, so it never splits.
|
||||
const captured = await captureSideInSessions(mapOptions, reuseDirectory ? undefined : sidePasses[side], progress, options.signal, concurrent);
|
||||
const bundle = await readCaptureBundle(directory);
|
||||
bundle.profile = cacheRecipe.profile;
|
||||
await writeFile(join(directory, "bundle.json"), JSON.stringify(bundle));
|
||||
@@ -464,6 +568,10 @@ export async function runCiReview(options: {
|
||||
}
|
||||
|
||||
export async function runBaselineCi(options: { platform?: ExplorePlatform; project: string; sha: string; output: string; config: ExploreConfig; environment?: NodeJS.ProcessEnv; runner?: CommandRunner;
|
||||
/** Every target config.yaml captures, so this baseline takes its target's share of `capture.maxSessions`. */
|
||||
targets?: RunTarget[];
|
||||
/** The targets with a device pose (foldables), which take the sessions `capture.maxSessions` does not divide evenly. */
|
||||
posedTargets?: readonly string[];
|
||||
now?: () => number; sleep?: (milliseconds: number) => void;
|
||||
agentSessionFactory?: PrepareCiExplorationOptions["createSession"]; progress?: Progress;
|
||||
/** Use the local `eas login` session instead of EXPO_TOKEN (expo-explore doctor --capture). */
|
||||
@@ -489,12 +597,19 @@ export async function runBaselineCi(options: { platform?: ExplorePlatform; proje
|
||||
onUsage: recordAgentUsage(output, () => usagePhase), ...(options.subscription ? { subscription: true } : {}) });
|
||||
const directory = join(output, "baseline-export");
|
||||
usagePhase = "capture-baseline";
|
||||
const result = await runCiMap({ ...captureOptions(options.config, environment, options.runner, { now: options.now, sleep: options.sleep }), progress,
|
||||
const baselineOptions: CiMapOptions = { ...captureOptions(options.config, environment, options.runner, { now: options.now, sleep: options.sleep }), progress,
|
||||
...(options.useLocalEasSession ? { useLocalEasSession: true } : {}),
|
||||
...(exploration.agent ? { agent: exploration.agent } : {}), project: options.project,
|
||||
mapDirectory: join(output, "baseline-map"), outputDirectory: directory, name: options.config.app.name ?? options.config.app.bundleId,
|
||||
buildId: `baseline-${options.sha.slice(0, 12)}`, buildVersion: options.sha.slice(0, 8), gitCommit: options.sha,
|
||||
side: "head", planPath: join(output, "execution-plan.json"), sessionStatePath: join(output, "baseline-session") });
|
||||
side: "head", planPath: join(output, "execution-plan.json"), sessionStatePath: join(output, "baseline-session") };
|
||||
const share = targetSessionShare(options.config, options.targets, options.posedTargets);
|
||||
// Passes on worker threads cannot take an injected runner or an agent session.
|
||||
const passes = !options.runner && !exploration.agent
|
||||
? await sideAppearancePasses(options.config, environment, { share, sides: 1, routes: plan.headCaptureSurfaceIds.length, project: options.project }) : undefined;
|
||||
progress(`sessions: ${share} of ${options.config.capture.maxSessions ?? DEFAULT_MAX_SESSIONS} for this target; `
|
||||
+ (passes ? `capturing ${passes.map(pass => pass.join("+")).join(" and ")} in separate sessions` : "one session"));
|
||||
const result = await captureSideInSessions(baselineOptions, passes, progress, undefined, passes !== undefined);
|
||||
const cacheRecipe = await recipe(options.config, plan, "head", environment, exploration.instructionsSha256);
|
||||
if (options.subscription) cacheRecipe.toolsCommit += ":local-subscription";
|
||||
const bundle = await readCaptureBundle(directory); bundle.profile = cacheRecipe.profile;
|
||||
|
||||
@@ -0,0 +1,70 @@
|
||||
import type { ColorScheme } from "../capture/appearance.js";
|
||||
|
||||
/** One route capture on a remote session, with the bridge thread (observed ~5 s; 9.4 s before it). */
|
||||
export const ROUTE_SECONDS = 5;
|
||||
/** Observing the app launch once per appearance. */
|
||||
export const LAUNCH_SECONDS = 28;
|
||||
/** A pass moves to its own session only when that shortens the side by at least this much. */
|
||||
export const SPLIT_MIN_SAVING_SECONDS = 60;
|
||||
/**
|
||||
* `capture.maxSessions` when the config sets none: the simulators a typical EAS plan runs at once. A starter plan runs
|
||||
* one per platform, so its config sets the ceiling lower (2 for an iOS and an Android target).
|
||||
*/
|
||||
export const DEFAULT_MAX_SESSIONS = 5;
|
||||
|
||||
export type SessionShareInput = {
|
||||
/** `capture.maxSessions`: the review-wide ceiling; absent means DEFAULT_MAX_SESSIONS. */
|
||||
maxSessions: number | undefined;
|
||||
/** The review's target ids in config order, and the one this job captures. */
|
||||
targets: readonly string[];
|
||||
target: string;
|
||||
/** Targets a split pays off most for take the sessions that do not divide evenly: foldables and large screens first. */
|
||||
prefer?: (target: string) => number;
|
||||
};
|
||||
|
||||
/**
|
||||
* This job's share of the review's session ceiling: the ceiling divided over the targets, the remainder going to the
|
||||
* preferred targets (foldables) in config order, and unused when there are none. Never below 1 (a side then captures after the other): under a ceiling below the
|
||||
* number of targets, at most that many target jobs run at once (maxParallelTargets).
|
||||
*/
|
||||
export function sessionShare(input: SessionShareInput): number {
|
||||
const count = Math.max(1, input.targets.length);
|
||||
const ceiling = input.maxSessions ?? DEFAULT_MAX_SESSIONS;
|
||||
const base = Math.floor(ceiling / count);
|
||||
let remainder = ceiling - base * count;
|
||||
// A session left over goes to a preferred target only; without one it stays unused (two targets of five: two each).
|
||||
const ranked = input.targets.filter(id => (input.prefer?.(id) ?? 0) > 0)
|
||||
.sort((a, b) => input.prefer!(b) - input.prefer!(a) || input.targets.indexOf(a) - input.targets.indexOf(b));
|
||||
const extra = new Set<string>();
|
||||
for (const id of ranked) { if (remainder <= 0) break; extra.add(id); remainder -= 1; }
|
||||
return Math.max(1, base + (extra.has(input.target) ? 1 : 0));
|
||||
}
|
||||
|
||||
/** How many target jobs one review runs at once: each needs a session, so never more than the ceiling. */
|
||||
export function maxParallelTargets(maxSessions: number | undefined, targets: number): number {
|
||||
return Math.max(1, Math.min(targets, maxSessions ?? DEFAULT_MAX_SESSIONS));
|
||||
}
|
||||
|
||||
export type SidePlan = {
|
||||
/** Whether head and base capture at the same time. */
|
||||
concurrentSides: boolean;
|
||||
/** The appearance passes of one side, each on its own session; one entry means the side keeps a single session. */
|
||||
passes: readonly (readonly ColorScheme[])[];
|
||||
};
|
||||
|
||||
/**
|
||||
* How one target's job spends its share of sessions: both sides at once when it has two, and a side's appearance passes
|
||||
* in separate sessions only when the pass moved out shortens the side by at least a minute (a session costs its fixed
|
||||
* boot and install time, so a few routes are not worth one). Sessions the work cannot fill stay unused: the ceiling is
|
||||
* a limit, not a target.
|
||||
*/
|
||||
export function planSideSessions(input: { share: number; sides: 1 | 2; routes: number; schemes: readonly ColorScheme[];
|
||||
minSavingSeconds?: number; routeSeconds?: number; launchSeconds?: number }): SidePlan {
|
||||
const minSaving = input.minSavingSeconds ?? SPLIT_MIN_SAVING_SECONDS, perRoute = input.routeSeconds ?? ROUTE_SECONDS, launch = input.launchSeconds ?? LAUNCH_SECONDS;
|
||||
const concurrentSides = input.sides === 1 || input.share >= 2;
|
||||
const perSide = Math.floor(input.share / (concurrentSides ? input.sides : 1));
|
||||
const schemes = [...input.schemes];
|
||||
const passSeconds = input.routes * perRoute + launch;
|
||||
const splitAppearances = schemes.length > 1 && perSide >= schemes.length && passSeconds >= minSaving;
|
||||
return { concurrentSides, passes: splitAppearances ? schemes.map(scheme => [scheme]) : [schemes] };
|
||||
}
|
||||
@@ -106,8 +106,11 @@ type GithubArtifact = { id: number; expired: boolean; workflow_run?: { id?: numb
|
||||
type GithubRun = { conclusion: string | null; workflow_id: number; head_sha: string; head_branch: string; event: string; head_repository?: { full_name?: string } };
|
||||
|
||||
/**
|
||||
* `ci:find-baseline`: the newest successful baseline-workflow artifact of exactly this commit, uploaded from the
|
||||
* default branch of this repository. Its id and run go to the step outputs for actions/download-artifact.
|
||||
* `ci:find-baseline`: the newest baseline-workflow artifact of exactly this commit, uploaded from the default branch of
|
||||
* this repository by a finished run. Its id and run go to the step outputs for actions/download-artifact. A run that
|
||||
* failed counts: a target's baseline job uploads its artifact only after every step before it passed, so another
|
||||
* target's failure (one flaky simulator session, as in brentvatne/euxy#172) does not make this target's baseline
|
||||
* unusable. A run still in progress or cancelled does not.
|
||||
*/
|
||||
export async function findBaselineArtifact(options: { sha: string; target?: string;
|
||||
/** What callers from before targets pass: a platform is the id of its default target. */ platform?: string; environment?: Environment; transport?: typeof fetch }): Promise<{ id: number; run: number } | undefined> {
|
||||
@@ -131,7 +134,7 @@ export async function findBaselineArtifact(options: { sha: string; target?: stri
|
||||
for (const artifact of artifacts.filter(candidate => !candidate.expired).sort((a, b) => b.id - a.id)) {
|
||||
if (!artifact.workflow_run?.id) continue;
|
||||
const run = await githubGet<GithubRun>(`repos/${context.repository}/actions/runs/${artifact.workflow_run.id}`, context, transport);
|
||||
if (!run || run.conclusion !== "success" || run.workflow_id !== workflow.id || run.head_sha !== options.sha
|
||||
if (!run || (run.conclusion !== "success" && run.conclusion !== "failure") || run.workflow_id !== workflow.id || run.head_sha !== options.sha
|
||||
|| run.head_branch !== repository.default_branch || !["push", "workflow_dispatch"].includes(run.event)
|
||||
|| run.head_repository?.full_name !== context.repository) continue;
|
||||
return { id: artifact.id, run: artifact.workflow_run.id };
|
||||
@@ -196,7 +199,8 @@ export async function cleanupAfterCapture(options: { output: string; checkouts:
|
||||
const environment = options.environment ?? process.env;
|
||||
const result: { stopped: string[]; failures: Array<{ code: string; message: string; nextAction: string }> } = { stopped: [], failures: [] };
|
||||
const sessionFiles: string[] = [];
|
||||
for (const name of ["head-session", "base-session", "baseline-session"]) {
|
||||
// A side that captures an appearance in a session of its own (capture.maxSessions) records it as `<side>-session-<scheme>`.
|
||||
for (const name of ["head", "base", "baseline"].flatMap(side => ["", "-light", "-dark"].map(scheme => `${side}-session${scheme}`))) {
|
||||
const path = resolve(options.output, name);
|
||||
try { await lstat(path); sessionFiles.push(path); } catch { /* That side never started a session. */ }
|
||||
}
|
||||
|
||||
@@ -5,6 +5,7 @@ import { resolve } from "node:path";
|
||||
import { ExploreStore } from "./map/store.js";
|
||||
import { QUERY_CONTRACT } from "./types.js";
|
||||
import { EXPLORE_VERSION } from "./shared/package-paths.js";
|
||||
import { isTargetId } from "./config/explore-config.js";
|
||||
import { command, resultContract, argumentError, validateCommandArguments, flag, has, setStore } from "./cli/args.js";
|
||||
import { help } from "./cli/help.js";
|
||||
import { listScreens, getScreen, listElements, listObservations, getObservation, nextFrontier, listAttempts, getAttempt, listTransitions, getTransition, neighbors, pathQuery, listJourneys, getJourney, listFrontier, listGaps, summary, search, status, validate, exportArtifacts } from "./cli/map-commands.js";
|
||||
@@ -81,8 +82,11 @@ try {
|
||||
await handler();
|
||||
} catch (error) {
|
||||
if (command.startsWith("capture:") || command.startsWith("source:") || command.startsWith("ci:") || command.startsWith("config:")) {
|
||||
// The failure comment names the target from this: a capture, report or publication of one matrix target.
|
||||
const target = (() => { try { return flag("target"); } catch { return undefined; } })();
|
||||
const diagnostic = await reportCiError(ciErrorForCommand(error, command), {
|
||||
...(process.env.RUNNER_TEMP ? { diagnosticsPath: resolve(process.env.RUNNER_TEMP, "explore-diagnostics", "error.json") } : {}),
|
||||
...(isTargetId(target) ? { target } : {}),
|
||||
...(has("json") ? { write: (line: string) => { if (process.env.GITHUB_ACTIONS === "true") console.log(line); } } : {}),
|
||||
});
|
||||
if (has("json")) console.error(JSON.stringify({ contract: resultContract, command, ok: false, error: diagnostic.message, diagnostic }));
|
||||
|
||||
@@ -15,12 +15,13 @@ import { installCiFiles } from "../ci/workflow-install.js";
|
||||
import { readRouteEntry } from "../ci/route-entry.js";
|
||||
import { buildVerifiedPlan } from "../ci/verified-plan.js";
|
||||
import { formatCaptureCheck, formatDoctorReport, referencedSecretNames, runCaptureCheck, runDoctor } from "../ci/doctor.js";
|
||||
import { readExploreConfig, readExploreInstructions, resolveTargetConfig, configTargets, isTargetId, withRunOverrides, warnIgnoredExpiry, configPlatforms as listPlatforms, EXPLORE_PLATFORMS, DEFAULT_EXPLORE_CONFIG_PATH, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { readExploreConfig, readExploreInstructions, resolveTargetConfig, configTargets, posedTargets, isTargetId, withRunOverrides, warnIgnoredExpiry, configPlatforms as listPlatforms, EXPLORE_PLATFORMS, DEFAULT_EXPLORE_CONFIG_PATH, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { argumentError, output, required, has, flag, flags, nonNegativeInteger, oneOf, positiveInteger } from "./args.js";
|
||||
import { help } from "./help.js";
|
||||
import { CiError } from "../shared/ci-errors.js";
|
||||
import { cleanupAfterCapture, findOptionalBaseline, resolveCompareRefs, resolvePullRequest, writeCaptureOutputs, writeStepOutputs } from "../ci/workflow-steps.js";
|
||||
import { stderrProgress } from "../shared/progress.js";
|
||||
import { maxParallelTargets } from "../ci/session-plan.js";
|
||||
|
||||
export async function doctor(): Promise<void> {
|
||||
if (has("help")) return help();
|
||||
@@ -159,10 +160,14 @@ export async function configPlatforms(): Promise<void> {
|
||||
output({ ok: true, platforms: configTargets(config).map(target => target.id) });
|
||||
}
|
||||
|
||||
/** The targets config.yaml captures, in order, with their platforms and labels: the review workflow's matrix. */
|
||||
/**
|
||||
* The targets config.yaml captures, in order, with their platforms and labels: the review workflow's matrix, and how
|
||||
* many of its jobs run at once (`maxParallel`), since each needs a session of capture.maxSessions.
|
||||
*/
|
||||
export async function configTargetList(): Promise<void> {
|
||||
const config = await readExploreConfig(flag("project") ?? process.cwd(), flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH);
|
||||
output({ ok: true, targets: configTargets(config) });
|
||||
const targets = configTargets(config);
|
||||
output({ ok: true, targets, maxParallel: maxParallelTargets(config.capture.maxSessions, targets.length) });
|
||||
}
|
||||
|
||||
async function exists(path: string): Promise<boolean> {
|
||||
@@ -229,7 +234,7 @@ export async function captureReview(): Promise<void> {
|
||||
// A matrix job names its target; its artifacts, report and comment section carry the target's id.
|
||||
const named = selection.target !== undefined || selection.platform !== undefined;
|
||||
const common = { ...(named ? { target: config.target!.id } : {}), ...(selection.platform ? { platform: selection.platform } : {}),
|
||||
platforms: listPlatforms(rawConfig), targets: configTargets(rawConfig), baseProject: required("base-project"), headProject,
|
||||
platforms: listPlatforms(rawConfig), targets: configTargets(rawConfig), posedTargets: posedTargets(rawConfig), baseProject: required("base-project"), headProject,
|
||||
output: required("output"), config, configPath, progress: stderrProgress() };
|
||||
const result = has("compare") ? await runCompareCi({ ...common, comparePath: required("compare") })
|
||||
: await runPublicCi({ ...common, pullRequestPath: required("pull-request") });
|
||||
@@ -240,8 +245,9 @@ export async function captureReview(): Promise<void> {
|
||||
|
||||
export async function captureBaseline(): Promise<void> {
|
||||
const project = required("project");
|
||||
const config = withRunOverrides(resolveTargetConfig(await readExploreConfig(project, flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH), targetSelection()), { controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack") });
|
||||
output({ ok: true, ...await runBaselineCi({ platform: config.app.platform, project, sha: required("sha"), output: required("output"), config, progress: stderrProgress() }) });
|
||||
const rawConfig = await readExploreConfig(project, flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH);
|
||||
const config = withRunOverrides(resolveTargetConfig(rawConfig, targetSelection()), { controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack") });
|
||||
output({ ok: true, ...await runBaselineCi({ platform: config.app.platform, project, sha: required("sha"), output: required("output"), config, targets: configTargets(rawConfig), posedTargets: posedTargets(rawConfig), progress: stderrProgress() }) });
|
||||
}
|
||||
|
||||
/** `capture` (or `capture:review`) `[--base REF] [--head REF | --committed]`: a local review, opened in the Viewer or hosted with --upload. */
|
||||
|
||||
@@ -31,7 +31,7 @@ const GET_STARTED = `Get started (run these in the Expo app's directory):
|
||||
machine, instead of EAS Simulator, and removes it afterwards (or set capture.simulator in config.yaml); builds
|
||||
still run on EAS, and the host switches appearance for either controller; the app is repacked with the route
|
||||
observer on this machine too (--repack eas, or capture.repack, keeps the hosted EAS job);
|
||||
with targets in config.yaml it reviews them at once (--parallel N at most N at a time; the targets of a platform
|
||||
with targets in config.yaml it reviews them at once, up to capture.maxSessions (--parallel N at most N at a time; the targets of a platform
|
||||
share each commit's build), --target ID one of them, --platform those of a platform)
|
||||
view [--catalog FILE] [--port N] [--no-open]
|
||||
(opens a report in the Viewer)
|
||||
|
||||
@@ -94,6 +94,11 @@ export type ExploreConfig = {
|
||||
/** `exclude` names routes, as `requiresRoute` does, that stay in the map but are never captured. */
|
||||
exploration: { scope: "changes" | "all"; exclude?: string[] };
|
||||
capture: { maxMinutes: number; maxActions: number;
|
||||
/**
|
||||
* The most EAS Simulator sessions one review may run at once, across its targets and sides; absent:
|
||||
* DEFAULT_MAX_SESSIONS (5). Below the number of targets, that many target jobs run at once, one session each.
|
||||
*/
|
||||
maxSessions?: number;
|
||||
/** Where the route observer is bundled into the app, when the config chooses; captureRepack gives the default. */
|
||||
repack?: "eas" | "local"; appearance: AppearanceSetting; launch: LaunchSetting; reset: RouteResetSetting; unattributed: UnattributedSetting; readinessSeconds?: number;
|
||||
/** The device controller; absent means agent-device, so configs that never chose one keep their cache recipes. */
|
||||
@@ -295,7 +300,7 @@ export function validateExploreConfig(value: unknown): ExploreConfig {
|
||||
const exploration = optionalRecord(root.exploration, "exploration");
|
||||
exactKeys(exploration, ["scope", "exclude"], "exploration");
|
||||
const capture = optionalRecord(root.capture, "capture");
|
||||
exactKeys(capture, ["maxMinutes", "maxActions", "repack", "appearance", "launch", "reset", "unattributed", "readinessSeconds", "controller", "simulator"], "capture");
|
||||
exactKeys(capture, ["maxMinutes", "maxActions", "maxSessions", "repack", "appearance", "launch", "reset", "unattributed", "readinessSeconds", "controller", "simulator"], "capture");
|
||||
const controller = literal(capture.controller, ["agent-device", "argent"] as const, "capture.controller", "agent-device");
|
||||
const simulator = literal(capture.simulator, ["eas", "local"] as const, "capture.simulator", "eas");
|
||||
const mode = literal(root.mode, ["deterministic", "agent"] as const, "mode", "deterministic");
|
||||
@@ -342,6 +347,7 @@ export function validateExploreConfig(value: unknown): ExploreConfig {
|
||||
capture: {
|
||||
maxMinutes: positiveInteger(capture.maxMinutes, "capture.maxMinutes", 30),
|
||||
maxActions: positiveInteger(capture.maxActions, "capture.maxActions", 500),
|
||||
...(capture.maxSessions === undefined ? {} : { maxSessions: positiveInteger(capture.maxSessions, "capture.maxSessions", 2) }),
|
||||
...(capture.repack === undefined ? {} : { repack: literal(capture.repack, ["eas", "local"] as const, "capture.repack") }),
|
||||
appearance: parseAppearance(capture.appearance, "capture.appearance"),
|
||||
launch: parseLaunchSetting(capture.launch, "capture.launch"),
|
||||
@@ -440,6 +446,11 @@ export function configTargets(config: ExploreConfig): RunTarget[] {
|
||||
label: target.label ?? `${target.device ?? (target.platform === config.app.platform ? config.device.name : DEFAULT_ANDROID_DEVICE)}${target.pose ? ` (${target.pose})` : ""}` }));
|
||||
}
|
||||
|
||||
/** The targets with a device pose (foldables): they take the sessions `capture.maxSessions` does not divide evenly. */
|
||||
export function posedTargets(config: ExploreConfig): string[] {
|
||||
return Object.entries(config.targets ?? {}).filter(([, target]) => target.pose).map(([id]) => id);
|
||||
}
|
||||
|
||||
/**
|
||||
* The flat configuration capture consumes for one target, with `target` naming it. `--target` names one; `--platform`
|
||||
* names the target of that platform, when only one has it; with neither, the config must have a single target.
|
||||
|
||||
@@ -251,6 +251,11 @@ export type PublicSurfaceReview = {
|
||||
description: string;
|
||||
/** Every deterministic accessibility fact for this surface, in reviewer priority order. */
|
||||
facts?: Array<{ category: string; templateId: string; bullet: string }>;
|
||||
/**
|
||||
* The screenshots match because the change is past the edge of the screen: every element its facts name reaches
|
||||
* beyond the captured screen. Only on a `modified` verdict whose screenshots match.
|
||||
*/
|
||||
offScreen?: true;
|
||||
};
|
||||
/** An evidence-bound explanation. It never changes a deterministic comparison verdict. */
|
||||
export type PublicChangeNote = {
|
||||
|
||||
@@ -57,6 +57,7 @@ function assertReviewFields(surface: Surface, enforceComparisonEvidence: boolean
|
||||
|| (["modified", "unchanged", "variant"].includes(review.status) && (!surface.base || !surface.head))
|
||||
|| (surface.sourceScope !== undefined && !["added", "removed"].includes(review.status)
|
||||
&& !SCOPE_VERDICTS[surface.sourceScope]?.includes(review.status))
|
||||
|| (review.offScreen !== undefined && (review.offScreen !== true || review.status !== "modified" || surface.visual?.verdict !== "unchanged"))
|
||||
|| (review.facts !== undefined && (!Array.isArray(review.facts) || review.facts.length > 100
|
||||
|| review.facts.some((fact) => !fact || typeof fact.category !== "string" || typeof fact.templateId !== "string"
|
||||
|| typeof fact.bullet !== "string" || !fact.bullet.trim() || fact.bullet.length > MAX_REVIEW_DESCRIPTION)))) {
|
||||
|
||||
@@ -0,0 +1,73 @@
|
||||
import type { PublicReview } from "./capture.js";
|
||||
import { navigationCaptureContext } from "./navigation-graph.js";
|
||||
|
||||
type Surface = PublicReview["surfaces"][number];
|
||||
type Side = "base" | "head";
|
||||
|
||||
/** Navigation is route-level: a secondary-appearance surface (`<id>@<scheme>`) rides on its route's entry. */
|
||||
const SCHEME_SUFFIX = /@(light|dark)$/;
|
||||
const routeOf = (id: string): string => id.replace(SCHEME_SUFFIX, "");
|
||||
|
||||
/**
|
||||
* The surfaces a side planned to capture: every route in `all` mode, the changed routes and their navigation context in
|
||||
* `changes` mode. Undefined without navigation, which leaves no route outside the context.
|
||||
*/
|
||||
export function captureContext(review: PublicReview, side: Side): ReadonlySet<string> | undefined {
|
||||
const navigation = review.navigation?.[side];
|
||||
if (!navigation) return undefined;
|
||||
const inventory = review.surfaces.filter((surface) => surface[side]);
|
||||
const routes = new Map<string, NonNullable<Surface[Side]>>();
|
||||
for (const surface of inventory) {
|
||||
const id = routeOf(surface.id);
|
||||
if (!routes.has(id)) routes.set(id, { ...surface[side]!, id });
|
||||
}
|
||||
const selected = new Set(review.mode === "all" ? [...routes.keys()] : navigationCaptureContext(navigation,
|
||||
inventory.filter((surface) => surface.status !== "unchanged").map((surface) => routeOf(surface.id)),
|
||||
[...routes.values()]));
|
||||
return new Set(inventory.filter((surface) => selected.has(routeOf(surface.id))).map((surface) => surface.id));
|
||||
}
|
||||
|
||||
/** Both a screenshot of the planned route and a verified landing on it. */
|
||||
export function verifiedCapture(surface: Surface, side: Side): boolean {
|
||||
const outcome = side === "base" ? surface.baseOutcome : surface.headOutcome;
|
||||
return Boolean(surface[side]?.kind === "screen" && (side === "base" ? surface.baseImage : surface.headImage)
|
||||
&& outcome?.status === "captured" && outcome.landing === "verified");
|
||||
}
|
||||
|
||||
/**
|
||||
* Why a side that exists in its revision has no verified capture, as the report's capture gap: `accepted` when the run
|
||||
* left it uncaptured on purpose (a redirect declaration, a route named in `exploration.exclude`, or a route outside the
|
||||
* capture context), `open` for anything else, such as a capture that failed. Undefined for a verified capture or an
|
||||
* absent side. `context` is the side's `captureContext`.
|
||||
*/
|
||||
export function captureGap(review: PublicReview, surface: Surface, side: Side,
|
||||
context: ReadonlySet<string> | undefined): "accepted" | "open" | undefined {
|
||||
const entry = surface[side];
|
||||
if (!entry || verifiedCapture(surface, side)) return undefined;
|
||||
const image = side === "base" ? surface.baseImage : surface.headImage;
|
||||
const outcome = side === "base" ? surface.baseOutcome : surface.headOutcome;
|
||||
const outsideCaptureContext = review.mode === "changes" && context !== undefined && !context.has(surface.id);
|
||||
const deliberate = !image && !outcome && (entry.kind === "redirect" || surface.excluded === true || outsideCaptureContext
|
||||
|| (!review.navigation?.[side] && review.mode === "changes" && surface.status === "unchanged"));
|
||||
return deliberate ? "accepted" : "open";
|
||||
}
|
||||
|
||||
/**
|
||||
* The surfaces the run never captured on purpose: no screenshot of their own on either side, and every side that exists
|
||||
* left uncaptured deliberately (`captureGap` is `accepted`). None is one of the report's screens. The Viewer leaves them
|
||||
* out (viewer/src/utils/omitted-screens.ts reaches the same set from the map's gaps), and the PR comment skips them.
|
||||
* A side with an open gap, such as a failed capture, keeps the surface: its failure is part of the report.
|
||||
*/
|
||||
export function neverCapturedSurfaceIds(review: PublicReview): ReadonlySet<string> {
|
||||
// The Viewer refuses a review whose navigation names a route its inventory lacks; the comment still renders one,
|
||||
// without a capture context, so no route counts as outside it.
|
||||
const contextOf = (side: Side) => { try { return captureContext(review, side); } catch { return undefined; } };
|
||||
const contexts = { base: contextOf("base"), head: contextOf("head") };
|
||||
const omitted = new Set<string>();
|
||||
for (const surface of review.surfaces) {
|
||||
if (surface.baseImage || surface.headImage) continue;
|
||||
const gaps = (["base", "head"] as const).map((side) => captureGap(review, surface, side, contexts[side]));
|
||||
if (gaps.includes("accepted") && !gaps.includes("open")) omitted.add(surface.id);
|
||||
}
|
||||
return omitted;
|
||||
}
|
||||
@@ -6,6 +6,7 @@ import {
|
||||
type Observation,
|
||||
type Screen,
|
||||
} from "../types.js";
|
||||
import { accessibilityFingerprintsComparable } from "./store.js";
|
||||
|
||||
/**
|
||||
* Cross-run screen matching for PR-style comparisons (baseline = base branch map,
|
||||
@@ -253,7 +254,8 @@ function matchEntry(match: Match): { entry: BuildComparisonEntry; review: Compar
|
||||
// captured on both sides) hide a real change to the primary content.
|
||||
const baselineHash = match.baseline.representative.fingerprints.accessibility;
|
||||
const currentHash = match.current.representative.fingerprints.accessibility;
|
||||
const verdict = baselineHash && currentHash
|
||||
// Hashes from different fingerprint versions (an older Explore's map) say nothing about whether the trees differ.
|
||||
const verdict = baselineHash && currentHash && accessibilityFingerprintsComparable(baselineHash, currentHash)
|
||||
? (baselineHash === currentHash ? "unchanged" : "modified")
|
||||
: "unknown";
|
||||
const unchanged = verdict === "unchanged";
|
||||
@@ -262,7 +264,9 @@ function matchEntry(match: Match): { entry: BuildComparisonEntry; review: Compar
|
||||
? `Matched by ${signals}; the representative captures share an accessibility fingerprint, so the rendered tree is unchanged.`
|
||||
: verdict === "modified"
|
||||
? `Matched by ${signals}; the representative captures have different accessibility fingerprints, so the rendered tree changed.`
|
||||
: `Matched by ${signals}; accessibility fingerprints are unavailable on at least one side, so the change state could not be verified from fingerprints.`;
|
||||
: baselineHash && currentHash
|
||||
? `Matched by ${signals}; the representative captures were fingerprinted by different Explore versions, so the change state could not be verified from fingerprints.`
|
||||
: `Matched by ${signals}; accessibility fingerprints are unavailable on at least one side, so the change state could not be verified from fingerprints.`;
|
||||
const entry: BuildComparisonEntry = {
|
||||
id: `match-${match.current.screen.id}`,
|
||||
relationship: "one-to-one",
|
||||
|
||||
@@ -14,6 +14,7 @@ import { dirname, extname, isAbsolute, join, relative, resolve, sep } from "node
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { Ajv2020, type ErrorObject, type ValidateFunction } from "ajv/dist/2020.js";
|
||||
import { isSystemUiNode } from "../capture/controller-output.js";
|
||||
import { keyboardNodes } from "../capture/keyboard.js";
|
||||
import { validateNavigationGraph } from "../contracts/navigation-graph.js";
|
||||
import {
|
||||
CONTRACT,
|
||||
@@ -67,11 +68,26 @@ export const normalizeSelector = (input?: string): string | undefined => {
|
||||
return input.replace(/\s+/g, " ").trim() || undefined;
|
||||
};
|
||||
|
||||
const VOLATILE_SNAPSHOT_NODE_KEYS = new Set(["ref"]);
|
||||
/** A ref names a node within one read; which field has the focus can change between two reads of one screen. */
|
||||
const VOLATILE_SNAPSHOT_NODE_KEYS = new Set(["ref", "focused"]);
|
||||
|
||||
/**
|
||||
* The accessibility fingerprint's algorithm, written as its prefix. Version 2 leaves the system keyboard and the focus out
|
||||
* of the tree; a hash from before carries no prefix. Two fingerprints of different versions say nothing about whether the
|
||||
* trees differ, so a comparison treats them as not comparable rather than changed (see accessibilityFingerprintsComparable).
|
||||
*/
|
||||
const ACCESSIBILITY_FINGERPRINT_VERSION = "a2";
|
||||
|
||||
export function accessibilityFingerprintsComparable(left: string, right: string): boolean {
|
||||
const version = (hash: string) => /^(a\d+):/.exec(hash)?.[1] ?? "a1";
|
||||
return version(left) === version(right);
|
||||
}
|
||||
|
||||
/** Canonical JSON of the node tree only: controller wrappers carry per-session diagnostics and
|
||||
* ref generations that would otherwise make identical screens fingerprint differently, and Android
|
||||
* system UI nodes (status bar clock and signal, keyboard) change between emulator sessions. */
|
||||
* system UI nodes (status bar clock and signal, keyboard) change between emulator sessions. The
|
||||
* system keyboard on either platform is left out as the elements leave it out, so a keyboard up on
|
||||
* one side only does not make two captures of one screen differ. */
|
||||
function normalizeJsonSnapshotNodes(input: string): string | undefined {
|
||||
if (!/^\s*\{/.test(input)) return undefined;
|
||||
let value: unknown;
|
||||
@@ -86,10 +102,12 @@ function normalizeJsonSnapshotNodes(input: string): string | undefined {
|
||||
if (!data || typeof data !== "object" || !Array.isArray((data as { nodes?: unknown }).nodes)) {
|
||||
return undefined;
|
||||
}
|
||||
const nodes = (data as { nodes: unknown[] }).nodes;
|
||||
const keyboard: Set<unknown> = keyboardNodes(nodes.filter((entry): entry is Record<string, unknown> => !!entry && typeof entry === "object" && !Array.isArray(entry)));
|
||||
const canonical = (node: unknown): unknown => {
|
||||
if (Array.isArray(node)) {
|
||||
return node
|
||||
.filter((entry) => !(entry && typeof entry === "object" && isSystemUiNode(entry as Record<string, unknown>)))
|
||||
.filter((entry) => !(entry && typeof entry === "object" && (isSystemUiNode(entry as Record<string, unknown>) || keyboard.has(entry))))
|
||||
.map(canonical);
|
||||
}
|
||||
if (!node || typeof node !== "object") return node;
|
||||
@@ -100,7 +118,7 @@ function normalizeJsonSnapshotNodes(input: string): string | undefined {
|
||||
.map(([key, entry]) => [key, canonical(entry)]),
|
||||
);
|
||||
};
|
||||
return `nodes\0${JSON.stringify(canonical((data as { nodes: unknown[] }).nodes))}`;
|
||||
return `nodes\0${JSON.stringify(canonical(nodes))}`;
|
||||
}
|
||||
|
||||
export const normalizeSnapshot = (input: string): string =>
|
||||
@@ -118,7 +136,7 @@ export async function fingerprintState(options: {
|
||||
snapshotText?: string;
|
||||
}): Promise<ObservationFingerprints> {
|
||||
const accessibility = options.snapshotText
|
||||
? sha256(`snapshot\0${normalizeSnapshot(options.snapshotText)}`)
|
||||
? `${ACCESSIBILITY_FINGERPRINT_VERSION}:${sha256(`snapshot\0${normalizeSnapshot(options.snapshotText)}`)}`
|
||||
: undefined;
|
||||
const screenshot = options.screenshotPath ? await readFile(options.screenshotPath) : undefined;
|
||||
const visual = screenshot ? sha256(Buffer.concat([Buffer.from("visual\0"), screenshot])) : undefined;
|
||||
|
||||
@@ -8,6 +8,7 @@ import { compareTitleMarkdown, projectReviewPresentation, type CompareReviewPres
|
||||
import { renderPublicComment, platformSectionMerge, reviewChangeCount, type PublicCommentState } from "./pr-comment-body.js";
|
||||
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
|
||||
import { upsertStickyComment } from "./pr-comment.js";
|
||||
import { retryGitHubLookup } from "./github-lookup.js";
|
||||
import { previewLinks, viewerLinks } from "./viewer-links.js";
|
||||
import type { PublicReview } from "../contracts/capture.js";
|
||||
import { CiError, toCiError } from "../shared/ci-errors.js";
|
||||
@@ -136,6 +137,8 @@ export async function publishCiReportComment(options: {
|
||||
preview?: { url: string; expiresAt: number | null };
|
||||
/** Set by `ci:deploy` when the hosted preview failed: the comment falls back to the central Viewer and the ZIP. */
|
||||
previewFailed?: boolean;
|
||||
/** Pause between GitHub lookups that may succeed later; tests replace it so retries take no real time. */
|
||||
sleep?: (milliseconds: number) => Promise<void>;
|
||||
}) {
|
||||
const environment = options.environment ?? process.env; const transport = options.transport ?? fetch;
|
||||
const input = await readInput(options.inputPath); const review = input.publicReview; const pr = review.pullRequest;
|
||||
@@ -186,16 +189,21 @@ export async function publishCiReportComment(options: {
|
||||
catch (error) { throw new CiError({ code: "GITHUB_RESPONSE_INVALID", stage: "publication",
|
||||
message: "GitHub returned invalid report metadata.", nextAction: "Rerun publication; if the response remains invalid, inspect the GitHub metadata request.", cause: error }); }
|
||||
};
|
||||
const artifact = await api(`actions/artifacts/${new URL(options.artifactUrl).pathname.split("/").at(-1)}`);
|
||||
// A lookup is made again when GitHub may answer it later: no answer, a 5xx, or a 404 from the Actions API, which may
|
||||
// not list a just-uploaded artifact yet. A bad token, a missing permission or a rate limit fails at once, as before.
|
||||
const lookup = (path: string) => retryGitHubLookup(() => api(path), error => error instanceof CiError
|
||||
&& (error.code === "GITHUB_NETWORK_FAILED" || error.code === "GITHUB_REQUEST_FAILED" && error.retryable
|
||||
|| error.code === "GITHUB_RESOURCE_NOT_FOUND" && path.startsWith("actions/")), options.sleep);
|
||||
const artifact = await lookup(`actions/artifacts/${new URL(options.artifactUrl).pathname.split("/").at(-1)}`);
|
||||
if (artifact.expired || artifact.name !== `explore-review-${review.runId}-${review.runAttempt}${target ? `-${target}` : ""}` || String(artifact.workflow_run?.id) !== review.runId) {
|
||||
throw new CiError({ code: artifact.expired ? "REPORT_ARTIFACT_EXPIRED" : "REPORT_ARTIFACT_MISMATCH", stage: "publication",
|
||||
message: "The uploaded report artifact is unavailable or belongs to another run",
|
||||
nextAction: artifact.expired ? "Rerun Explore to upload a fresh report artifact." : "Pass the final report artifact from this workflow run and attempt." });
|
||||
}
|
||||
const attempt = await api(`actions/runs/${review.runId}/attempts/${review.runAttempt}`);
|
||||
const attempt = await lookup(`actions/runs/${review.runId}/attempts/${review.runAttempt}`);
|
||||
if (String(attempt.id) !== review.runId || String(attempt.run_attempt) !== review.runAttempt) throw new CiError({ code: "REPORT_RUN_MISMATCH", stage: "publication",
|
||||
message: "Report run attempt mismatch", nextAction: "Publish the artifact and report input from the same current workflow attempt." });
|
||||
const current = await api(`pulls/${pr.number}`);
|
||||
const current = await lookup(`pulls/${pr.number}`);
|
||||
if (current.state !== "open" || current.head?.repo?.full_name !== pr.repository || current.head?.ref !== pr.head.ref) {
|
||||
throw new CiError({ code: "PR_CHANGED", stage: "publication", message: "PR closed or changed branches before the report artifact was ready",
|
||||
nextAction: "Run Explore for the current PR head and base before publishing a ready report." });
|
||||
|
||||
@@ -15,7 +15,7 @@ export type FailureCommentOptions = {
|
||||
runAttempt: string;
|
||||
/** The directory the failure job downloaded diagnostics artifacts into (`<stage>/<artifact>/…/error.json`). */
|
||||
diagnosticsPath?: string;
|
||||
/** The failed target's id; otherwise the one the first diagnostics artifact's name carries. */
|
||||
/** The failed target's id; otherwise every target the diagnostics artifacts name. */
|
||||
target?: string;
|
||||
/** What callers from before targets pass: a platform is the id of its default target. */
|
||||
platform?: ExplorePlatform;
|
||||
@@ -25,6 +25,8 @@ export type FailureCommentOptions = {
|
||||
};
|
||||
|
||||
type Diagnostic = { code: string; stage: string; message: string; nextAction: string };
|
||||
/** A failed target's diagnostic. `target` is absent when neither the artifact's name nor the file names one. */
|
||||
export type LocatedFailure = { diagnostic?: Diagnostic; target?: string; platform?: ExplorePlatform };
|
||||
const SHA = /^[0-9a-f]{40}$/;
|
||||
// `explore-<kind>-<run>-<attempt>-<target>`: the kind has no digits, so the first number is the run and the rest is the target id.
|
||||
const ARTIFACT_DIR = /^explore-[a-z-]+-\d+-\d+-([a-z][a-z0-9-]{0,31})$/;
|
||||
@@ -34,11 +36,14 @@ const MAX_DIAGNOSTIC_BYTES = 32_768;
|
||||
const CODE = /^[A-Z][A-Z0-9_]{1,63}$/;
|
||||
const STAGE = /^[a-z][a-z0-9-]{0,63}$/;
|
||||
|
||||
function parseDiagnostic(text: string, stage: string): Diagnostic | undefined {
|
||||
function parseJson(text: string): Record<string, unknown> | undefined {
|
||||
let parsed: unknown;
|
||||
try { parsed = JSON.parse(text); } catch { return undefined; }
|
||||
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return undefined;
|
||||
const value = parsed as Record<string, unknown>;
|
||||
return parsed && typeof parsed === "object" && !Array.isArray(parsed) ? parsed as Record<string, unknown> : undefined;
|
||||
}
|
||||
|
||||
function parseDiagnostic(value: Record<string, unknown> | undefined, stage: string): Diagnostic | undefined {
|
||||
if (!value) return undefined;
|
||||
const field = (name: string, max: number) => typeof value[name] === "string" && (value[name] as string).trim() && (value[name] as string).length <= max ? value[name] as string : undefined;
|
||||
const code = field("code", 64), message = field("message", 4000), nextAction = field("nextAction", 4000), stageName = field("stage", 64) ?? stage;
|
||||
if (!code || !CODE.test(code) || !message || !nextAction || !STAGE.test(stageName)) return undefined;
|
||||
@@ -46,32 +51,51 @@ function parseDiagnostic(text: string, stage: string): Diagnostic | undefined {
|
||||
return { code, stage: stageName, message, nextAction };
|
||||
}
|
||||
|
||||
/** Reads one error.json; `named` is the target its artifact directory names, else the one the file records. */
|
||||
async function readFailure(path: string, stage: string, named: string | undefined): Promise<LocatedFailure | undefined> {
|
||||
const info = await lstat(path).catch(() => undefined);
|
||||
if (!info) return undefined;
|
||||
const located = (target: string | undefined): LocatedFailure => ({ ...(target ? { target } : {}), ...(target === "ios" || target === "android" ? { platform: target as ExplorePlatform } : {}) });
|
||||
if (!info.isFile() || info.size > MAX_DIAGNOSTIC_BYTES) return located(named);
|
||||
const value = parseJson(await readFile(path, "utf8"));
|
||||
const target = named ?? (isTargetId(value?.target) ? value.target : undefined);
|
||||
const diagnostic = parseDiagnostic(value, stage);
|
||||
return diagnostic ? { diagnostic, ...located(target) } : located(target);
|
||||
}
|
||||
|
||||
/**
|
||||
* The error.json a failed job left behind and the target its artifact name carries (`ios` or `android` for a config
|
||||
* without targets, and for artifacts of versions before targets). A report failure's diagnostic takes precedence over
|
||||
* capture's; a present but unreadable file yields the generic failure rather than an earlier stage's error, and only
|
||||
* Every failed target's error.json and the target it belongs to (`ios` or `android` for a config without targets, and
|
||||
* for artifacts of versions before targets). actions/download-artifact puts each artifact a pattern matches in a
|
||||
* directory named after it, except when the pattern matches exactly one: that one lands in the stage's directory
|
||||
* itself, and the file names its target. A report failure's diagnostic takes precedence over its target's capture
|
||||
* diagnostic; a present but unreadable file yields the generic failure rather than an earlier stage's error, and only
|
||||
* regular files count (never symlinks out of the artifact). `platform` is set when the target id is a platform's.
|
||||
*/
|
||||
export async function locateFailureDiagnostic(root: string): Promise<{ diagnostic?: Diagnostic; target: string; platform?: ExplorePlatform } | undefined> {
|
||||
export async function locateFailureDiagnostics(root: string): Promise<LocatedFailure[]> {
|
||||
const failures: LocatedFailure[] = [];
|
||||
const seen = new Set<string>();
|
||||
for (const [stage, file] of [["report", "error.json"], ["capture", join("explore-diagnostics", "error.json")]] as const) {
|
||||
const entries = await readdir(join(root, stage), { withFileTypes: true }).catch(() => []);
|
||||
for (const entry of entries.filter(entry => entry.isDirectory() && artifactTarget(entry.name)).sort((a, b) => a.name.localeCompare(b.name))) {
|
||||
const path = join(root, stage, entry.name, file);
|
||||
const info = await lstat(path).catch(() => undefined);
|
||||
if (!info) continue;
|
||||
const target = artifactTarget(entry.name)!;
|
||||
const located: { target: string; platform?: ExplorePlatform } = { target, ...(target === "ios" || target === "android" ? { platform: target as ExplorePlatform } : {}) };
|
||||
if (!info.isFile() || info.size > MAX_DIAGNOSTIC_BYTES) return located;
|
||||
const diagnostic = parseDiagnostic(await readFile(path, "utf8"), stage);
|
||||
return diagnostic ? { diagnostic, ...located } : located;
|
||||
const candidates = [...entries.filter(entry => entry.isDirectory() && artifactTarget(entry.name)).sort((a, b) => a.name.localeCompare(b.name))
|
||||
.map(entry => ({ path: join(root, stage, entry.name, file), named: artifactTarget(entry.name) })), { path: join(root, stage, file), named: undefined }];
|
||||
for (const { path, named } of candidates) {
|
||||
const located = await readFailure(path, stage, named);
|
||||
if (!located || seen.has(located.target ?? "")) continue;
|
||||
seen.add(located.target ?? "");
|
||||
failures.push(located);
|
||||
}
|
||||
}
|
||||
return undefined;
|
||||
return failures;
|
||||
}
|
||||
|
||||
/** The first failure locateFailureDiagnostics finds: a report failure before a capture failure. */
|
||||
export async function locateFailureDiagnostic(root: string): Promise<LocatedFailure | undefined> {
|
||||
return (await locateFailureDiagnostics(root))[0];
|
||||
}
|
||||
|
||||
/**
|
||||
* The failure job's comment: a job died outside Explore's own progress comments (install, checkout, a crash
|
||||
* before the pipeline posted), so the sticky comment gets a failed record for that target from the same
|
||||
* before the pipeline posted), so the sticky comment gets a failed record for each failed target from the same
|
||||
* renderer every other writer uses. Nothing is posted when the PR is closed; a PR that moved on is marked
|
||||
* superseded so the failure lands under previous runs.
|
||||
*/
|
||||
@@ -94,27 +118,31 @@ export async function publishFailureComment(options: FailureCommentOptions): Pro
|
||||
return { posted: false, reason: "The PR is no longer an open same-repository PR." };
|
||||
}
|
||||
const superseded = pr.head?.sha !== options.headSha || pr.base?.sha !== options.baseSha;
|
||||
const located = options.diagnosticsPath ? await locateFailureDiagnostic(options.diagnosticsPath) : undefined;
|
||||
const target = requested ?? located?.target;
|
||||
// The failure job knows a target by its id alone; the comment's own record for that id supplies its label and platform.
|
||||
const platform: ExplorePlatform | undefined = target === "ios" || target === "android" ? target : undefined;
|
||||
const configPath = options.configPath ?? ".expo-explore/config.yaml";
|
||||
const now = Date.now();
|
||||
const diagnostic = located?.diagnostic;
|
||||
const state: PublicCommentState = {
|
||||
phase: "failed", mode: "changes", executionMode: "deterministic", configPath,
|
||||
pullRequest: { repositoryId: String(pr.base?.repo?.id ?? ""), repository: options.repository, number: options.pullNumber, title: String(pr.title ?? ""), url: String(pr.html_url ?? ""),
|
||||
base: { ref: String(pr.base?.ref ?? ""), sha: options.baseSha }, head: { ref: String(pr.head?.ref ?? ""), sha: options.headSha } },
|
||||
// No artifact URL, so no Viewer link: the target would only pick a report that this failure never uploaded.
|
||||
links: viewerLinks({ repository: options.repository, headSha: options.headSha, runId: options.runId, runAttempt: options.runAttempt, configPath }),
|
||||
startedAt: now, updatedAt: now, artifactOnly: true,
|
||||
...(platform ? { build: { platform, easProfile: "" } } : {}),
|
||||
failure: { step: diagnostic?.stage ?? "workflow", message: diagnostic
|
||||
? `${diagnostic.code}: ${diagnostic.message} Next action: ${diagnostic.nextAction}`
|
||||
: "Explore could not finish this review. See the run for the error code, cause, and next action. Fix the reported issue and rerun Explore." },
|
||||
...(superseded ? { superseded: true } : {}),
|
||||
};
|
||||
await upsertStickyComment({ repository: options.repository, issueNumber: options.pullNumber, body: renderPublicComment(state, undefined, target),
|
||||
...platformSectionMerge(state, target), token, fetchImpl: transport });
|
||||
const located = options.diagnosticsPath ? await locateFailureDiagnostics(options.diagnosticsPath) : [];
|
||||
// Each failed target gets its own failed record: since one target's failed capture no longer stops the others'
|
||||
// reports (brentvatne/euxy#172), several targets of one run can fail in different jobs.
|
||||
const failures: LocatedFailure[] = requested !== undefined ? [{ ...(located.find(failure => failure.target === requested) ?? located[0]), target: requested }]
|
||||
: located.length ? located : [{}];
|
||||
for (const { target, diagnostic } of failures) {
|
||||
// The failure job knows a target by its id alone; the comment's own record for that id supplies its label and platform.
|
||||
const platform: ExplorePlatform | undefined = target === "ios" || target === "android" ? target : undefined;
|
||||
const configPath = options.configPath ?? ".expo-explore/config.yaml";
|
||||
const now = Date.now();
|
||||
const state: PublicCommentState = {
|
||||
phase: "failed", mode: "changes", executionMode: "deterministic", configPath,
|
||||
pullRequest: { repositoryId: String(pr.base?.repo?.id ?? ""), repository: options.repository, number: options.pullNumber, title: String(pr.title ?? ""), url: String(pr.html_url ?? ""),
|
||||
base: { ref: String(pr.base?.ref ?? ""), sha: options.baseSha }, head: { ref: String(pr.head?.ref ?? ""), sha: options.headSha } },
|
||||
// No artifact URL, so no Viewer link: the target would only pick a report that this failure never uploaded.
|
||||
links: viewerLinks({ repository: options.repository, headSha: options.headSha, runId: options.runId, runAttempt: options.runAttempt, configPath }),
|
||||
startedAt: now, updatedAt: now, artifactOnly: true,
|
||||
...(platform ? { build: { platform, easProfile: "" } } : {}),
|
||||
failure: { step: diagnostic?.stage ?? "workflow", message: diagnostic
|
||||
? `${diagnostic.code}: ${diagnostic.message} Next action: ${diagnostic.nextAction}`
|
||||
: "Explore could not finish this review. See the run for the error code, cause, and next action. Fix the reported issue and rerun Explore." },
|
||||
...(superseded ? { superseded: true } : {}),
|
||||
};
|
||||
await upsertStickyComment({ repository: options.repository, issueNumber: options.pullNumber, body: renderPublicComment(state, undefined, target),
|
||||
...platformSectionMerge(state, target), token, fetchImpl: transport });
|
||||
}
|
||||
return { posted: true, ...(superseded ? { superseded: true } : {}) };
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
/**
|
||||
* Pauses between attempts of a GitHub lookup that may succeed later, 45 seconds in all. GitHub's Actions API is
|
||||
* eventually consistent just after an upload: in brentvatne/euxy's review run 39348956443, the duo-closed report job's
|
||||
* `actions/artifacts/<id>` answered 404 for the artifact that job had just uploaded, while the other four targets'
|
||||
* jobs found theirs.
|
||||
*/
|
||||
const GITHUB_LOOKUP_RETRY_DELAYS_MS = [3_000, 6_000, 12_000, 24_000] as const;
|
||||
|
||||
/**
|
||||
* Runs a read-only GitHub lookup again after each pause while `transient` says its failure may clear on its own. The
|
||||
* caller decides what is transient; any other failure, or the last one, is thrown as it is.
|
||||
*/
|
||||
export async function retryGitHubLookup<T>(lookup: () => Promise<T>, transient: (error: unknown) => boolean,
|
||||
sleep: (milliseconds: number) => Promise<void> = milliseconds => new Promise<void>(done => setTimeout(done, milliseconds))): Promise<T> {
|
||||
for (let retry = 0; ; retry += 1) {
|
||||
try { return await lookup(); }
|
||||
catch (error) {
|
||||
const delayMs = GITHUB_LOOKUP_RETRY_DELAYS_MS[retry];
|
||||
if (delayMs === undefined || !transient(error)) throw error;
|
||||
// A lookup that succeeds later would otherwise leave no trace of the failure in the job log.
|
||||
process.stderr.write(`GitHub lookup failed (${(error instanceof Error ? error.message : String(error)).split("\n", 1)[0]}); trying again in ${delayMs / 1000} s\n`);
|
||||
await sleep(delayMs);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -5,6 +5,7 @@ import { CI_COMMENT_MARKER } from "./pr-comment.js";
|
||||
import { CHANGE_GROUPS, MAX_COMMENT_TARGETS, MAX_NAVIGATION_EDGES, MAX_NAVIGATION_NODES, compareTargets, defaultTargetLabel, foldRecord, strongerGroup, historyLine, orderedPrevious, orderedRecords, previousLine, readCommentRecords, recordLabel, recordLine, recordSummary,
|
||||
type ChangeGroup, type CommentNavigation, type CommentTarget, type CommentRecords, type HistoryEntry, type NavigationGroup, type NavigationKind, type PlatformRecord } from "./pr-comment-record.js";
|
||||
import { isAccessibilityOnlyChange } from "../contracts/review-validation.js";
|
||||
import { neverCapturedSurfaceIds } from "../contracts/surface-capture.js";
|
||||
import type { PublicCaptureHealth, PublicEvidenceSummary } from "../review/evidence-assessment.js";
|
||||
import type { ReviewPresentation } from "../contracts/review.js";
|
||||
import type { ViewerLinks } from "./viewer-links.js";
|
||||
@@ -142,6 +143,16 @@ function notComparedChange(surface: Surface): boolean {
|
||||
return verified && (!surface.review || surface.visual?.reason === "diff-failed");
|
||||
}
|
||||
|
||||
/**
|
||||
* An accessibility-only change whose elements lie past the edge of the screen (the review's `offScreen`), so another
|
||||
* target's row can say the change is there, off-screen, rather than missing. Like notComparedChange, a comparison that
|
||||
* failed or a redirect is not one.
|
||||
*/
|
||||
function offScreenChange(surface: Surface): boolean {
|
||||
return surface.review?.offScreen === true && isAccessibilityOnlyChange(surface) && surface.visual?.reason !== "diff-failed"
|
||||
&& (surface.head ?? surface.base)?.kind !== "redirect";
|
||||
}
|
||||
|
||||
function routeOf(surface: Surface): string {
|
||||
return plainText(surface.head?.route || surface.base?.route || surface.id, MAX_ROUTE_LENGTH);
|
||||
}
|
||||
@@ -294,12 +305,15 @@ export function platformRecordOf(state: PublicCommentState, target?: CommentTarg
|
||||
if (state.review) {
|
||||
const evidenceBased = state.review.surfaces.some(surface => surface.review);
|
||||
record.changes = [];
|
||||
// A route the run never captured on purpose is not one of the report's screens, here as in the Viewer.
|
||||
const omitted = neverCapturedSurfaceIds(state.review);
|
||||
for (const surface of state.review.surfaces) {
|
||||
if ((surface.head ?? surface.base)?.kind === "redirect") continue;
|
||||
if (omitted.has(surface.id)) continue;
|
||||
const group = groupOf(surface, evidenceBased);
|
||||
if (group === "unlisted") continue;
|
||||
const scheme = schemeOf(surface.id);
|
||||
record.changes.push({ id: surface.id, route: routeOf(surface), group, description: descriptionOf(surface, group), ...(scheme ? { scheme } : {}) });
|
||||
record.changes.push({ id: surface.id, route: routeOf(surface), group, description: descriptionOf(surface, group), ...(scheme ? { scheme } : {}),
|
||||
...(group === "accessibility-only" && offScreenChange(surface) ? { offScreen: true as const } : {}) });
|
||||
}
|
||||
const navigation = state.map ? navigationOf(state.review, new Map(record.changes.map(change => [change.id, change.group]))) : undefined;
|
||||
if (navigation) record.navigation = navigation;
|
||||
@@ -348,9 +362,10 @@ function navigationOf(review: PublicReview, groups: Map<string, ChangeGroup>): C
|
||||
if (!review.navigation) return undefined;
|
||||
const keyOf = new Map<string, string>();
|
||||
const groupOf = new Map<string, NavigationGroup>();
|
||||
const omitted = neverCapturedSurfaceIds(review);
|
||||
for (const surface of review.surfaces) {
|
||||
const route = surface.head ?? surface.base;
|
||||
if (!route || route.kind === "redirect") continue;
|
||||
if (!route || omitted.has(surface.id)) continue;
|
||||
const key = routePattern(route);
|
||||
keyOf.set(surface.id.replace(/@(light|dark)$/, ""), key);
|
||||
const group = groups.get(surface.id);
|
||||
@@ -558,10 +573,24 @@ function renderChangeRow(row: ChangeRow, ready: PlatformRecord[]): string {
|
||||
text = `${route} · ${description}`;
|
||||
}
|
||||
const tag = row.group === "accessibility-only" ? "accessibility only" : row.group === "needs-review" ? "needs review" : undefined;
|
||||
return `- ${[text, tag, ...whereNote(row, ready)].filter(Boolean).join(" · ")}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Where a screen's change shows. A target whose screenshots match because the changed elements lie past the edge of the
|
||||
* screen has the change, off-screen, so it is named apart: "iPhone 17, Android only · off-screen on iPhone Duo (closed)"
|
||||
* for Tempo's footnote below the fold of its sheet in brentvatne/euxy#172 (review run 39362642343). The targets that show
|
||||
* it are still named the shorter way among the others (none when all of them do); without such a target the note is what
|
||||
* it always was.
|
||||
*/
|
||||
function whereNote(row: ChangeRow, ready: PlatformRecord[]): string[] {
|
||||
const offScreen = row.group === "modified"
|
||||
? row.targets.filter(record => record.changes?.some(change => change.id === row.id && change.offScreen === true)) : [];
|
||||
const shown = row.targets.filter(record => !offScreen.includes(record));
|
||||
// A target with screens it has no verdict on may have changed this one too: name where it changed, not where it did not.
|
||||
const where = ready.some(record => !row.targets.includes(record) && gaps(record).length)
|
||||
? `on ${row.targets.map(labelOf).join(", ")}` : targetsNote(row.targets, ready);
|
||||
return `- ${[text, tag, where].filter(Boolean).join(" · ")}`;
|
||||
const unsure = ready.some(record => !row.targets.includes(record) && gaps(record).length);
|
||||
const visible = unsure ? `on ${shown.map(labelOf).join(", ")}` : targetsNote(shown, ready.filter(record => !offScreen.includes(record)));
|
||||
return [visible, offScreen.length ? `off-screen on ${offScreen.map(labelOf).join(", ")}` : undefined].filter((part): part is string => Boolean(part));
|
||||
}
|
||||
|
||||
/** "Android only" / "not on Android": the targets a screen changed on, when not all of them, named the shorter way. */
|
||||
@@ -718,8 +747,9 @@ export function reviewDevice(state: { runtime?: Pick<SimulatorRuntimeMetadata, "
|
||||
export function reviewChanges(review: PublicReview): Map<string, ChangeGroup> {
|
||||
const evidenceBased = review.surfaces.some(surface => surface.review);
|
||||
const changes = new Map<string, ChangeGroup>();
|
||||
const omitted = neverCapturedSurfaceIds(review);
|
||||
for (const surface of review.surfaces) {
|
||||
if ((surface.head ?? surface.base)?.kind === "redirect") continue;
|
||||
if (omitted.has(surface.id)) continue;
|
||||
const group = groupOf(surface, evidenceBased);
|
||||
if (group !== "unlisted") changes.set(surface.id, group);
|
||||
}
|
||||
|
||||
@@ -103,8 +103,11 @@ export type PlatformRecord = {
|
||||
accessibility?: { compared: number; described: number; failed: number };
|
||||
routes?: number;
|
||||
};
|
||||
/** The review's changed surfaces, one per surface; `scheme` for a secondary appearance (`<route>@<scheme>`). */
|
||||
changes?: { id: string; route: string; group: ChangeGroup; description: string; scheme?: string }[];
|
||||
/**
|
||||
* The review's changed surfaces, one per surface; `scheme` for a secondary appearance (`<route>@<scheme>`). `offScreen`
|
||||
* marks an accessibility-only change whose elements lie past the edge of the screen.
|
||||
*/
|
||||
changes?: { id: string; route: string; group: ChangeGroup; description: string; scheme?: string; offScreen?: true }[];
|
||||
/** Screens whose source changed and whose captures were verified, but that got no verdict: the comparison did not run or failed. */
|
||||
notCompared?: number;
|
||||
/** Differences stated once rather than per screen (variants, app-wide source changes). */
|
||||
@@ -270,7 +273,8 @@ export function parsePlatformRecord(value: unknown): PlatformRecord | undefined
|
||||
if (Array.isArray(value.changes)) {
|
||||
const changes = value.changes.flatMap((entry): NonNullable<PlatformRecord["changes"]> => isRecord(entry) && isString(entry.id, 220) && isString(entry.route, 2000)
|
||||
&& CHANGE_GROUPS.includes(entry.group as ChangeGroup) && isString(entry.description, 2000)
|
||||
? [{ id: entry.id, route: entry.route, group: entry.group as ChangeGroup, description: entry.description, ...(isString(entry.scheme, 20) ? { scheme: entry.scheme } : {}) }] : []);
|
||||
? [{ id: entry.id, route: entry.route, group: entry.group as ChangeGroup, description: entry.description, ...(isString(entry.scheme, 20) ? { scheme: entry.scheme } : {}),
|
||||
...(entry.offScreen === true && entry.group === "accessibility-only" ? { offScreen: true as const } : {}) }] : []);
|
||||
if (changes.length <= 2000) record.changes = changes;
|
||||
}
|
||||
const navigation = parseNavigation(value.navigation);
|
||||
|
||||
@@ -7,6 +7,7 @@ import { Uint8ArrayReader, Uint8ArrayWriter, ZipWriter, configure } from "@zip.j
|
||||
import { loadReport, MAX_METADATA_BYTES } from "./agent-api.js";
|
||||
import { MAX_ASSET_BYTES, manifestBody, PREVIEW_ASSET } from "./preview-manifest.js";
|
||||
import { publishCiReportComment, readCiReportInput, type CiReportInput } from "./artifact.js";
|
||||
import { retryGitHubLookup } from "./github-lookup.js";
|
||||
import { readZipDirectory, readZipEntry } from "./zip-reader.js";
|
||||
import { reviewChangeCount, reviewDevice } from "./pr-comment-body.js";
|
||||
import { isTargetId, warnIgnoredExpiry, type ExplorePlatform } from "../config/explore-config.js";
|
||||
@@ -54,7 +55,7 @@ export type PreviewDeployOptions = (PreviewReportInput | {
|
||||
environment?: NodeJS.ProcessEnv;
|
||||
transport?: typeof fetch;
|
||||
run?: CommandRunner;
|
||||
/** Pause between `eas deploy` attempts; tests replace it so retries take no real time. */
|
||||
/** Pause between `eas deploy` attempts and between GitHub lookups that may succeed later; tests replace it so retries take no real time. */
|
||||
sleep?: (milliseconds: number) => Promise<void>;
|
||||
/** The preview export (client/ and server/); defaults to the one shipped in this package. */
|
||||
exportPath?: string;
|
||||
@@ -386,7 +387,7 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
|
||||
if (pr.origin !== "compare") for (const report of reports) {
|
||||
try {
|
||||
await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
|
||||
...commentTarget(report), previewFailed: true });
|
||||
...commentTarget(report), previewFailed: true, ...(options.sleep ? { sleep: options.sleep } : {}) });
|
||||
} catch { /* the deployment failure is the one to report */ }
|
||||
}
|
||||
throw error;
|
||||
@@ -398,7 +399,7 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
|
||||
let headSha = pr.head.sha;
|
||||
if (pr.origin !== "compare") for (const report of reports) {
|
||||
const published = await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
|
||||
...commentTarget(report), preview: { url: previewUrl, expiresAt: null } });
|
||||
...commentTarget(report), preview: { url: previewUrl, expiresAt: null }, ...(options.sleep ? { sleep: options.sleep } : {}) });
|
||||
headSha = published.headSha;
|
||||
}
|
||||
return { previewUrl, expiresAt: null, deploymentId: hosted.deploymentId, deploymentUrl: hosted.deploymentUrl,
|
||||
@@ -435,7 +436,9 @@ async function writeCompareSummary(environment: NodeJS.ProcessEnv, comparison: C
|
||||
}
|
||||
|
||||
type HostedReportInput = { zip: Uint8Array; sha256: string; file: string; query: string };
|
||||
export type HostedDeployment = { previewUrl: string; expiresAt: string | null; deploymentId: string; deploymentUrl: string; aliasUrl?: string; project: string; owner: string };
|
||||
export type HostedDeployment = { previewUrl: string; expiresAt: string | null; deploymentId: string; deploymentUrl: string; aliasUrl?: string;
|
||||
/** The link is the alias, which still served an earlier deployment when the wait for it ran out. */
|
||||
aliasBehind?: true; project: string; owner: string };
|
||||
|
||||
/** EAS Hosting alias names: lowercase slugs, as `eas deploy --alias` normalises them. */
|
||||
export const HOSTING_ALIAS = /^[a-z0-9][a-z0-9-]{0,38}[a-z0-9]$/;
|
||||
@@ -495,6 +498,13 @@ async function deployReports(options: {
|
||||
alias?: string;
|
||||
/** A caller-chosen `/p/<token>`; with `alias`, the hosted link is identical from one run to the next. */
|
||||
token?: string;
|
||||
/** How long the alias has to serve this deployment once the deployment does; `verifyTimeoutMs` by default. */
|
||||
aliasWaitMs?: number;
|
||||
/**
|
||||
* Link the alias even when it still serves an earlier deployment after `aliasWaitMs`, for a link whose readers are
|
||||
* told it can lag, rather than the deployment's own host.
|
||||
*/
|
||||
linkBehindAlias?: boolean;
|
||||
sleep?: (milliseconds: number) => Promise<void>;
|
||||
}): Promise<HostedDeployment> {
|
||||
const { reports, project, environment, run, transport, now, random } = options;
|
||||
@@ -571,7 +581,8 @@ async function deployReports(options: {
|
||||
throw deployError("PREVIEW_DEPLOY_FAILED", `EAS Hosting deployed ${deploymentUrl.origin} but did not report the alias ${options.alias}.`,
|
||||
"Check the deployment's aliases in the EAS Hosting dashboard and rerun.", { retryable: true, details: { project, owner, alias: options.alias } });
|
||||
}
|
||||
const verify = (origin: string, alias = false) => verifyDeployment({ origin, token, transport, now, timeoutMs: options.verifyTimeoutMs, alias,
|
||||
const verify = (origin: string, alias = false) => verifyDeployment({ origin, token, transport, now, alias,
|
||||
timeoutMs: alias ? options.aliasWaitMs ?? options.verifyTimeoutMs : options.verifyTimeoutMs,
|
||||
reports: reports.map((report, index) => ({ query: report.query, ...written[index]! })),
|
||||
...(listing ? { listing: JSON.stringify(listing.map(({ path: _path, ...rest }) => rest)) } : {}) });
|
||||
const seconds = (milliseconds: number) => `${Math.round(milliseconds / 1000)} s after eas deploy returned`;
|
||||
@@ -581,7 +592,9 @@ async function deployReports(options: {
|
||||
// taken longer than the whole budget (every verification failure of 2026-10-14 was the alias, with the deployment
|
||||
// serving in 1 s). The deployment is verified and immutable, so when the alias is still behind the pull request
|
||||
// links the deployment instead of failing the job; the alias catches up on its own and the next push relinks it.
|
||||
// With `linkBehindAlias` it links the alias anyway, and its readers are told the link can lag.
|
||||
let linkOrigin = deploymentUrl.origin;
|
||||
let aliasBehind = false;
|
||||
if (aliasUrl) {
|
||||
try {
|
||||
const alias = await verify(aliasUrl.origin, true);
|
||||
@@ -589,12 +602,16 @@ async function deployReports(options: {
|
||||
linkOrigin = aliasUrl.origin;
|
||||
} catch (error) {
|
||||
if ((error as { code?: string }).code !== "PREVIEW_ALIAS_BEHIND") throw error;
|
||||
process.stderr.write(`::warning::${(error as Error).message} The pull request links the deployment ${deploymentUrl.origin} instead.\n`);
|
||||
aliasBehind = Boolean(options.linkBehindAlias);
|
||||
if (aliasBehind) linkOrigin = aliasUrl.origin;
|
||||
process.stderr.write(`::warning::${(error as Error).message} ${aliasBehind
|
||||
? `The pull request links it anyway, until it catches up, beside the deployment ${deploymentUrl.origin}.`
|
||||
: `The pull request links the deployment ${deploymentUrl.origin} instead.`}\n`);
|
||||
}
|
||||
}
|
||||
const previewUrl = `${linkOrigin}/p/${token}`;
|
||||
return { previewUrl, expiresAt: null, deploymentId: deployment.identifier!, deploymentUrl: deploymentUrl.origin,
|
||||
...(aliasUrl ? { aliasUrl: aliasUrl.origin } : {}), project, owner };
|
||||
...(aliasUrl ? { aliasUrl: aliasUrl.origin } : {}), ...(aliasBehind ? { aliasBehind: true as const } : {}), project, owner };
|
||||
} finally {
|
||||
await rm(work, { recursive: true, force: true });
|
||||
}
|
||||
@@ -668,8 +685,20 @@ export type FixturePreviewOptions = {
|
||||
random?: (bytes: number) => Uint8Array;
|
||||
onSecret?: (secret: string) => void;
|
||||
verifyTimeoutMs?: number;
|
||||
/** How long the alias has to serve the new deployment before the link is the alias anyway; FIXTURE_ALIAS_WAIT_MS by default. */
|
||||
aliasWaitMs?: number;
|
||||
};
|
||||
|
||||
/**
|
||||
* How long a fixture preview waits for its alias. An edge of EAS Hosting that served an alias keeps serving the
|
||||
* deployment it named for about five minutes (307–314 s, measured 2026-10-19 redeploying back to back from one machine),
|
||||
* so a deploy whose check reaches an edge that served the alias in the last five minutes, to the previous deploy's check
|
||||
* or to a reviewer, finds it behind; otherwise it has moved within seconds. Waiting the whole verification budget for
|
||||
* that held a third of the pull requests' deploy jobs for three minutes, only to link the deployment instead. The pull
|
||||
* request's comment says when the alias is behind.
|
||||
*/
|
||||
export const FIXTURE_ALIAS_WAIT_MS = 20_000;
|
||||
|
||||
/**
|
||||
* Host fixed reports behind a fixed alias with this checkout's Viewer: the Explore repository's own pull requests
|
||||
* preview their Viewer changes on real data. No GitHub token, no expiry; each run replaces what the alias serves.
|
||||
@@ -697,6 +726,7 @@ export async function deployFixturePreview(options: FixturePreviewOptions): Prom
|
||||
projectHint: "Give EXPO_TOKEN's account permission to create projects, or pass --project with an existing slug.",
|
||||
exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}), transport: options.transport ?? fetch, now: options.now ?? Date.now, random,
|
||||
...(options.onSecret ? { onSecret: options.onSecret } : {}), verifyTimeoutMs: options.verifyTimeoutMs ?? 180_000, alias: options.alias,
|
||||
aliasWaitMs: options.aliasWaitMs ?? FIXTURE_ALIAS_WAIT_MS, linkBehindAlias: true,
|
||||
...(options.token ? { token: options.token } : {}) });
|
||||
}
|
||||
|
||||
@@ -760,23 +790,43 @@ export async function deployLocalReports(options: {
|
||||
/** explore-(capture|review)-<run>-<attempt>-<target id>; the id starts with a letter, so the run and attempt end unambiguously. */
|
||||
const ARTIFACT_DIRECTORY = /^explore-(capture|review)-\d+-\d+-([a-z][a-z0-9-]{0,31})$/;
|
||||
|
||||
/**
|
||||
* The target a lone artifact holds. actions/download-artifact puts each artifact a pattern matches in a directory named
|
||||
* after it, except when the pattern matches exactly one, which it extracts into the download path itself: then only the
|
||||
* report names its target (its platform for configs without targets).
|
||||
*/
|
||||
async function unnamedArtifactTarget(root: string, kind: "capture" | "review"): Promise<string | undefined> {
|
||||
const file = join(root, kind === "capture" ? "report-input.json" : "review.json");
|
||||
if (!(await lstat(file).catch(() => undefined))?.isFile()) return undefined;
|
||||
const runtime = kind === "capture" ? (await readCiReportInput(file)).publicReview.runtime
|
||||
: (JSON.parse(await readFile(file, "utf8")) as Partial<ArtifactReport>).review?.runtime;
|
||||
const id = readTarget(runtime?.target)?.id ?? runtime?.platform;
|
||||
return isTargetId(id) ? id : undefined;
|
||||
}
|
||||
|
||||
/**
|
||||
* The fan-in deploy job's inputs: actions/download-artifact puts each explore-capture-<run>-<attempt>-<target>
|
||||
* directory under --inputs and each explore-review-… directory under --reports (the target is the platform for
|
||||
* configs without targets). Pairs them by target, in the order the run's review lists its targets, and looks up each
|
||||
* report artifact's URL on the run, since matrix jobs cannot hand their artifact URLs forward.
|
||||
* report artifact's URL on the run, since matrix jobs cannot hand their artifact URLs forward. A target whose capture
|
||||
* failed uploaded no capture artifact, and one whose report job failed no report artifact: the preview serves the
|
||||
* targets that have both, and the review workflow's failure job names the others on the comment.
|
||||
*/
|
||||
export async function collectPlatformReports(options: { inputsPath: string; reportsPath: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch }): Promise<PreviewReportInput[]> {
|
||||
export async function collectPlatformReports(options: { inputsPath: string; reportsPath: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch;
|
||||
/** Pause between artifact lookups that may succeed later; tests replace it so retries take no real time. */
|
||||
sleep?: (milliseconds: number) => Promise<void> }): Promise<PreviewReportInput[]> {
|
||||
const environment = options.environment ?? process.env; const transport = options.transport ?? fetch;
|
||||
const directories = async (root: string, kind: "capture" | "review") => {
|
||||
const found = new Map<string, string>();
|
||||
for (const name of (await readdir(root)).sort()) {
|
||||
// A pattern that matched nothing leaves no directory behind.
|
||||
for (const name of (await readdir(root).catch(() => [] as string[])).sort()) {
|
||||
const match = ARTIFACT_DIRECTORY.exec(name);
|
||||
if (!match || match[1] !== kind || !isTargetId(match[2])) continue;
|
||||
if (found.has(match[2]!)) throw previewError("PREVIEW_REPORTS_INVALID", `Several ${kind} artifacts for ${match[2]} were downloaded`,
|
||||
"Download only this run attempt's artifacts into the --inputs and --reports directories.");
|
||||
found.set(match[2]!, join(root, name));
|
||||
}
|
||||
if (!found.size) { const id = await unnamedArtifactTarget(root, kind); if (id) found.set(id, root); }
|
||||
return found;
|
||||
};
|
||||
const inputs = await directories(options.inputsPath, "capture"); const reports = await directories(options.reportsPath, "review");
|
||||
@@ -787,8 +837,9 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
|
||||
const entries: PreviewReportInput[] = [];
|
||||
for (const [id, inputDirectory] of inputs) {
|
||||
const reportPath = reports.get(id);
|
||||
if (!reportPath) throw previewError("PREVIEW_REPORTS_INCOMPLETE", `The ${id} capture has no report artifact to deploy`,
|
||||
"Rerun the workflow; the report job for that target did not upload its explore-review artifact.");
|
||||
// In brentvatne/euxy#172 (review run 39348956443) one target's failed job kept every other target's report off the
|
||||
// PR; a target without a report is left out of the preview instead.
|
||||
if (!reportPath) { process.stderr.write(`The ${id} capture has no report artifact (its report job failed), so the preview leaves it out.\n`); continue; }
|
||||
const inputPath = join(inputDirectory, "report-input.json");
|
||||
const runtime = (await readCiReportInput(inputPath)).publicReview.runtime;
|
||||
// A report from before targets names only its platform, and its artifact is named after it.
|
||||
@@ -798,6 +849,8 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
|
||||
const target = named ?? (id === "ios" || id === "android" ? platformTarget(id) : { id, platform: runtime.platform ?? "ios", label: id });
|
||||
entries.push({ ...(id === target.platform ? { platform: target.platform } : {}), target, inputPath, reportPath, artifactUrl: "" });
|
||||
}
|
||||
if (!entries.length) throw previewError("PREVIEW_REPORTS_INCOMPLETE", "No target's capture has a report artifact to deploy",
|
||||
"Rerun the workflow; the report jobs did not upload their explore-review artifacts.");
|
||||
// Config order, as the review lists its targets (or, before targets, its platforms); directory order otherwise.
|
||||
const listed = (await readCiReportInput(entries[0]!.inputPath)).publicReview.runtime;
|
||||
const order: string[] = listed.targets?.map(target => target.id) ?? listed.platforms ?? [];
|
||||
@@ -812,14 +865,22 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
|
||||
for (const entry of entries) {
|
||||
const name = `explore-review-${review.runId}-${review.runAttempt}-${entry.target!.id}`;
|
||||
const url = `https://api.github.com/repos/${repository}/actions/runs/${review.runId}/artifacts?per_page=100&name=${encodeURIComponent(name)}`;
|
||||
const response = await transport(url, { headers: { accept: "application/vnd.github+json", authorization: `Bearer ${environment.GITHUB_TOKEN ?? ""}`,
|
||||
"x-github-api-version": "2022-11-28" }, signal: AbortSignal.timeout(60_000) });
|
||||
const body = response.ok ? await response.json() as { artifacts?: Array<{ id?: unknown; name?: unknown; expired?: unknown }> } : undefined;
|
||||
const artifact = body?.artifacts?.find(candidate => candidate.name === name && candidate.expired !== true);
|
||||
if (!artifact || typeof artifact.id !== "number" || !Number.isSafeInteger(artifact.id) || artifact.id <= 0) {
|
||||
throw deployError("REPORT_ARTIFACT_MISSING", `The run has no artifact named ${name} (HTTP ${response.status}).`,
|
||||
"Rerun the workflow so every target's report job uploads its artifact before the deploy job runs.", { retryable: true });
|
||||
}
|
||||
// The run's artifact list can lag an upload, as the artifact lookup of a report job's publication does, so an
|
||||
// empty list, a 404, a 5xx or no answer is looked up again; a bad token or a missing permission fails at once.
|
||||
const artifact = await retryGitHubLookup(async () => {
|
||||
const response = await transport(url, { headers: { accept: "application/vnd.github+json", authorization: `Bearer ${environment.GITHUB_TOKEN ?? ""}`,
|
||||
"x-github-api-version": "2022-11-28" }, signal: AbortSignal.timeout(60_000) });
|
||||
const body = response.ok ? await response.json() as { artifacts?: Array<{ id?: unknown; name?: unknown; expired?: unknown }> } : undefined;
|
||||
const found = body?.artifacts?.find(candidate => candidate.name === name && candidate.expired !== true);
|
||||
if (!found || typeof found.id !== "number" || !Number.isSafeInteger(found.id) || found.id <= 0) {
|
||||
throw deployError("REPORT_ARTIFACT_MISSING", `The run has no artifact named ${name} (HTTP ${response.status}).`,
|
||||
"Rerun the workflow so every target's report job uploads its artifact before the deploy job runs.", { retryable: true, details: { status: response.status } });
|
||||
}
|
||||
return found;
|
||||
}, error => {
|
||||
const status = error instanceof CiError ? error.details?.status : undefined;
|
||||
return !(error instanceof CiError) || typeof status === "number" && (status === 200 || status === 404 || status >= 500);
|
||||
}, options.sleep);
|
||||
entry.artifactUrl = `https://github.com/${repository}/actions/runs/${review.runId}/artifacts/${artifact.id}`;
|
||||
}
|
||||
return entries;
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { unattributedIssue } from "../capture/health.js";
|
||||
import { appearancePairs, bundleColorSchemes } from "../capture/appearance.js";
|
||||
import { appearancePairs, bundleColorSchemes, type ColorScheme } from "../capture/appearance.js";
|
||||
import { launchSurfaceId, systemRegions as defaultSystemRegions, type SystemRegion } from "../contracts/capture.js";
|
||||
import { readFileSync, statSync } from "node:fs";
|
||||
import { stat } from "node:fs/promises";
|
||||
@@ -27,7 +27,9 @@ import {
|
||||
} from "./visual-evidence.js";
|
||||
import { AGENT_DEVICE_VERSION } from "../shared/agent-device-version.js";
|
||||
import { STATUS_BAR_BAND_PERCENT, decodePng, differentPixelsInRect, maxColorDistance, type DecodedFrame } from "../shared/png-evidence.js";
|
||||
import { measureRegionMoves, type RegionMove, type RegionShift } from "./region-shift.js";
|
||||
import type { RegionMove, RegionShift } from "./region-shift.js";
|
||||
import { measureRegionMovesInWorker } from "./region-shift-worker.js";
|
||||
import { availableParallelism } from "node:os";
|
||||
|
||||
export const DEFAULT_VISUAL_THRESHOLD = 0.1;
|
||||
export const DEFAULT_EVIDENCE_TIME_BUDGET_MS = 10 * 60_000;
|
||||
@@ -194,7 +196,7 @@ export function publishMeasuredRegions(all: readonly VisualDiffRegion[], shifts:
|
||||
async function withRegionShifts(basePath: string, headPath: string, all: readonly VisualDiffRegion[], published: NonNullable<PublicVisualVerdict["regions"]>):
|
||||
Promise<Pick<PublicVisualVerdict, "regions" | "allRegionsMoved">> {
|
||||
try {
|
||||
const { shifts, moves, width, height } = await measureRegionMoves(basePath, headPath,
|
||||
const { shifts, moves, width, height } = await measureRegionMovesInWorker(basePath, headPath,
|
||||
all.map(region => ({ ...region.rect, dominantChange: region.dominantChange })));
|
||||
if (moves.length) return publishMeasuredRegions(all, shifts, moves, width, height);
|
||||
const shiftOf = new Map(all.map((region, index) => [region.rect, shifts[index]] as const));
|
||||
@@ -406,6 +408,40 @@ function impactFor(surface: PlanSurface, presence: ComparatorSurfaceImpact["pres
|
||||
};
|
||||
}
|
||||
|
||||
/** The screenshot pairs `assessPublicEvidence` compares: both sides captured and landed, in the loop's order. */
|
||||
function comparablePairs(options: { plan: SourceCapturePlan; base: PublicEvidenceSide; head: PublicEvidenceSide }, colorSchemes: readonly ColorScheme[],
|
||||
baseColorSchemes: readonly ColorScheme[]): Array<{ id: string; basePath: string; headPath: string }> {
|
||||
const pairs: Array<{ id: string; basePath: string; headPath: string }> = [];
|
||||
for (const surface of options.plan.surfaces) {
|
||||
if (surface.baseSurface?.kind !== "screen" || surface.headSurface?.kind !== "screen" || (!surface.baseCapture && !surface.headCapture)) continue;
|
||||
for (const { id, baseId } of appearancePairs(surface.id, colorSchemes, baseColorSchemes)) {
|
||||
if (baseId === null) continue;
|
||||
const basePath = localImagePath(options.base, baseId);
|
||||
const headPath = localImagePath(options.head, id);
|
||||
if (!basePath || !headPath || captureDiagnostic(surface, "base", options.base, baseId) || captureDiagnostic(surface, "head", options.head, id)) continue;
|
||||
pairs.push({ id, basePath, headPath });
|
||||
}
|
||||
}
|
||||
return pairs;
|
||||
}
|
||||
|
||||
/** Runs tasks at most `size` at a time, each started in the order it was queued. */
|
||||
function concurrencyLimit(size: number): <T>(task: () => Promise<T>) => Promise<T> {
|
||||
let active = 0;
|
||||
const queue: Array<() => void> = [];
|
||||
const next = () => { if (active < size) queue.shift()?.(); };
|
||||
return task => new Promise((resolve, reject) => {
|
||||
queue.push(() => {
|
||||
active += 1;
|
||||
task().then(resolve, reject).finally(() => { active -= 1; next(); });
|
||||
});
|
||||
next();
|
||||
});
|
||||
}
|
||||
|
||||
/** The limit the reviews in this process share when none is given: a local review compares its targets at once. */
|
||||
let processLimit: ReturnType<typeof concurrencyLimit> | undefined;
|
||||
|
||||
function localImagePath(side: PublicEvidenceSide, id: string): string | undefined {
|
||||
const frame = side.bundle.images[id];
|
||||
return frame ? localEvidencePath(side, frame.path) : undefined;
|
||||
@@ -499,6 +535,8 @@ export async function assessPublicEvidence(options: {
|
||||
timeBudgetMs?: number;
|
||||
now?: () => number;
|
||||
measure?: (baselinePath: string, currentPath: string) => Promise<ScreenshotDiffMeasurement>;
|
||||
/** How many screenshot pairs compare at once. Absent: one per available CPU, shared by every review in this process. */
|
||||
concurrency?: number;
|
||||
}): Promise<PublicEvidenceResult> {
|
||||
const threshold = options.threshold ?? DEFAULT_VISUAL_THRESHOLD;
|
||||
const system = options.systemRegions ?? defaultSystemRegions({ platform: options.platform });
|
||||
@@ -517,6 +555,34 @@ export async function assessPublicEvidence(options: {
|
||||
const measure = options.measure ?? (async (baselinePath: string, currentPath: string) => (
|
||||
await diffScreenshots({ baselinePath, currentPath, command: options.agentDeviceCommand, threshold })
|
||||
));
|
||||
type ComparedPair = { visual: PublicVisualVerdict; assessment: VisualEvidenceAssessment };
|
||||
/** One pair's measurement, verdict and region moves: the work that runs ahead of the surface loop. */
|
||||
const comparePair = async (basePath: string, headPath: string): Promise<ComparedPair> => {
|
||||
const raw = await measure(basePath, headPath);
|
||||
const { measurement, ignoredStatusBar: ignoredTop, ignoredHomeIndicator: ignoredBottom } = ignoreSystemRegions(raw, system, systemBandFrameLoader(raw, threshold));
|
||||
const assessment = assessVisualMeasurements({
|
||||
baselineSamples: 1,
|
||||
currentSamples: 1,
|
||||
requiredSamples: 1,
|
||||
baselineWithin: [],
|
||||
currentWithin: [],
|
||||
crossBuild: [measurement],
|
||||
representative: measurement,
|
||||
});
|
||||
const visual = visualVerdict(assessment, threshold);
|
||||
// Measuring moves is extra: once the comparison budget is spent, regions go out unmeasured.
|
||||
if (visual.verdict === "modified" && visual.regions?.length && now() <= deadline) {
|
||||
Object.assign(visual, await withRegionShifts(basePath, headPath, measurement.regions, visual.regions));
|
||||
}
|
||||
if (ignoredTop > 0) visual.ignoredStatusBarRegions = ignoredTop;
|
||||
if (ignoredBottom > 0) visual.ignoredHomeIndicatorRegions = ignoredBottom;
|
||||
if (ignoredTop > 0 || ignoredBottom > 0) visual.systemRegions = system.map((area) => ({ ...area }));
|
||||
return { visual, assessment };
|
||||
};
|
||||
/** A pair compared if the budget has not expired when its turn to start comes; undefined when it has. */
|
||||
const compareInBudget = async (basePath: string, headPath: string): Promise<ComparedPair | undefined> => (
|
||||
now() > deadline ? undefined : await comparePair(basePath, headPath)
|
||||
);
|
||||
const visualCounts = { compared: 0, modified: 0, unchanged: 0, needsReview: 0, failed: 0, errors: [] as string[] };
|
||||
const accessibilityCounts = { compared: 0, described: 0, failed: 0, skipped: 0, errors: [] as string[] };
|
||||
const reviewCounts = { modified: 0, needsReview: 0, variants: 0, unchanged: 0 };
|
||||
@@ -533,6 +599,20 @@ export async function assessPublicEvidence(options: {
|
||||
|
||||
const colorSchemes = bundleColorSchemes(options.head.bundle);
|
||||
const baseColorSchemes = bundleColorSchemes(options.base.bundle);
|
||||
// The pairs the loop below compares start now, a few at a time: each is a comparator process and a pixel search
|
||||
// that take seconds on a large screenshot, so they overlap instead of queueing behind one another. The loop reads
|
||||
// them in its own order, so the result does not depend on which finishes first. A pair whose turn comes after the
|
||||
// budget expired is not started; one started in time is waited for and used.
|
||||
const ahead = new Map<string, Promise<ComparedPair | undefined>>();
|
||||
if (visualAvailable) {
|
||||
const limit = options.concurrency !== undefined ? concurrencyLimit(Math.max(1, Math.floor(options.concurrency)))
|
||||
: processLimit ??= concurrencyLimit(availableParallelism());
|
||||
for (const { id, basePath, headPath } of comparablePairs(options, colorSchemes, baseColorSchemes)) {
|
||||
const started = limit(() => compareInBudget(basePath, headPath));
|
||||
started.catch(() => undefined);
|
||||
ahead.set(id, started);
|
||||
}
|
||||
}
|
||||
for (const surface of options.plan.surfaces) {
|
||||
for (const side of ["base", "head"] as const) {
|
||||
if (!surface[`${side}Capture`] || surface[`${side}Surface`]?.kind !== "screen") continue;
|
||||
@@ -598,48 +678,29 @@ export async function assessPublicEvidence(options: {
|
||||
continue;
|
||||
}
|
||||
|
||||
let visual: PublicVisualVerdict;
|
||||
let assessment: VisualEvidenceAssessment | undefined;
|
||||
if (now() > deadline) {
|
||||
let compared: ComparedPair | undefined;
|
||||
try {
|
||||
compared = await (ahead.get(id) ?? compareInBudget(basePath, headPath));
|
||||
} catch (error) {
|
||||
visualCounts.failed += 1;
|
||||
const diagnostic = comparisonError(id, error, { code: "VISUAL_COMPARISON_FAILED", stage: "compare",
|
||||
message: "Screenshot comparison failed.", nextAction: "Check the screenshot files and the agent-device comparison diagnostics, then rerun comparison.", retryable: true });
|
||||
recordError(visualCounts.errors, id, diagnostic.message);
|
||||
continue;
|
||||
}
|
||||
if (!compared) {
|
||||
visualCounts.failed += 1;
|
||||
const diagnostic = comparisonError(id, undefined, { code: "VISUAL_COMPARISON_BUDGET_EXHAUSTED", stage: "compare",
|
||||
message: "The time budget expired before screenshot comparison.",
|
||||
nextAction: "Increase the evidence comparison time budget or reduce the number of selected routes, then rerun comparison.", retryable: true });
|
||||
recordError(visualCounts.errors, id, diagnostic.message);
|
||||
continue;
|
||||
} else {
|
||||
try {
|
||||
const raw = await measure(basePath, headPath);
|
||||
const { measurement, ignoredStatusBar: ignoredTop, ignoredHomeIndicator: ignoredBottom } = ignoreSystemRegions(raw, system, systemBandFrameLoader(raw, threshold));
|
||||
assessment = assessVisualMeasurements({
|
||||
baselineSamples: 1,
|
||||
currentSamples: 1,
|
||||
requiredSamples: 1,
|
||||
baselineWithin: [],
|
||||
currentWithin: [],
|
||||
crossBuild: [measurement],
|
||||
representative: measurement,
|
||||
});
|
||||
visual = visualVerdict(assessment, threshold);
|
||||
// Measuring moves is extra: once the comparison budget is spent, regions go out unmeasured.
|
||||
if (visual.verdict === "modified" && visual.regions?.length && now() <= deadline) {
|
||||
Object.assign(visual, await withRegionShifts(basePath, headPath, measurement.regions, visual.regions));
|
||||
}
|
||||
if (ignoredTop > 0) visual.ignoredStatusBarRegions = ignoredTop;
|
||||
if (ignoredBottom > 0) visual.ignoredHomeIndicatorRegions = ignoredBottom;
|
||||
if (ignoredTop > 0 || ignoredBottom > 0) visual.systemRegions = system.map((area) => ({ ...area }));
|
||||
visualCounts.compared += 1;
|
||||
if (visual.verdict === "modified") visualCounts.modified += 1;
|
||||
else if (visual.verdict === "unchanged") visualCounts.unchanged += 1;
|
||||
else visualCounts.needsReview += 1;
|
||||
} catch (error) {
|
||||
visualCounts.failed += 1;
|
||||
const diagnostic = comparisonError(id, error, { code: "VISUAL_COMPARISON_FAILED", stage: "compare",
|
||||
message: "Screenshot comparison failed.", nextAction: "Check the screenshot files and the agent-device comparison diagnostics, then rerun comparison.", retryable: true });
|
||||
recordError(visualCounts.errors, id, diagnostic.message);
|
||||
continue;
|
||||
}
|
||||
}
|
||||
const { visual, assessment } = compared;
|
||||
visualCounts.compared += 1;
|
||||
if (visual.verdict === "modified") visualCounts.modified += 1;
|
||||
else if (visual.verdict === "unchanged") visualCounts.unchanged += 1;
|
||||
else visualCounts.needsReview += 1;
|
||||
|
||||
const scope = surfaceSourceScope(surface) ?? "none";
|
||||
let review: PublicSurfaceReview | undefined;
|
||||
@@ -655,6 +716,7 @@ export async function assessPublicEvidence(options: {
|
||||
const summary = summarizeReviewerChanges({ changes: result.reviewerChanges });
|
||||
accessibilityCounts.compared += 1;
|
||||
review = decideReview(scope, visual, summary);
|
||||
if (result.offScreen && review.status === "modified" && visual.verdict === "unchanged") review = { ...review, offScreen: true };
|
||||
if (review.facts?.length) accessibilityCounts.described += 1;
|
||||
} catch (error) {
|
||||
accessibilityCounts.failed += 1;
|
||||
|
||||
@@ -93,6 +93,8 @@ export type EvidenceComparatorResult = {
|
||||
visualAssessment?: VisualEvidenceAssessment;
|
||||
/** Feed directly to summarizeReviewerChanges. */
|
||||
reviewerChanges: ReviewerChangeInput[];
|
||||
/** The screenshots match, and every element the changes name lies at least partly past the edge of the screen. */
|
||||
offScreen?: true;
|
||||
};
|
||||
|
||||
type SupportedInput = Extract<ReviewerChangeInput, { assessment: "supported" }>;
|
||||
@@ -617,6 +619,54 @@ function outermost(elements: readonly ObservedElement[]): ObservedElement[] {
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* The screen in its accessibility tree's units: the element at the origin with the screenshot's shape (either way round,
|
||||
* since a frame turned to show an opened iPhone Duo upright keeps the tree on the panel's portrait axes), the largest if
|
||||
* several. Both controllers report the app's root that way. Without the screenshot's size there is no telling which
|
||||
* element is the screen.
|
||||
*/
|
||||
function viewportOf(side: ResolvedSide): ElementBounds | undefined {
|
||||
const image = side.map.artifacts.find(artifact => artifact.id === side.observation.screenshotArtifactId);
|
||||
if (!image?.width || !image.height) return undefined;
|
||||
const { width, height } = image;
|
||||
const shaped = (bounds: ElementBounds) => Math.abs(bounds.width * height - bounds.height * width) <= 0.01 * width * height
|
||||
|| Math.abs(bounds.width * width - bounds.height * height) <= 0.01 * width * height;
|
||||
return side.observation.elements.flatMap(element => boundsOf(element) ?? [])
|
||||
.filter(bounds => Math.abs(bounds.x) < 1 && Math.abs(bounds.y) < 1 && bounds.width > 0 && bounds.height > 0 && shaped(bounds))
|
||||
.sort((a, b) => b.width * b.height - a.width * a.height)[0];
|
||||
}
|
||||
|
||||
/**
|
||||
* Whether the screenshots cannot show the changes because the elements they name lie past the edge of the screen: each
|
||||
* change names at least one element, and more than half of each named element's area is beyond the screen on its side.
|
||||
* Both controllers leave an element wholly outside the screen out of the tree (the Argent bridge as agent-device does),
|
||||
* so a change past the edge can only show as an element straddling it, as Tempo's footnote below the fold of its sheet
|
||||
* on the closed iPhone Duo in brentvatne/euxy#172 (review run 39362642343) would. Mostly outside, not merely crossing
|
||||
* an edge: a control nudged a point or two past the edge is still on the screen, and its change stays "accessibility
|
||||
* only". A change whose elements have no bounds never qualifies.
|
||||
*/
|
||||
function changesOffScreen(facts: readonly SupportedInput[], base: ResolvedSide, head: ResolvedSide): boolean {
|
||||
const changes = facts.filter(fact => !["unstable-text", "no-visible-change", "visual-changed"].includes(fact.change.kind));
|
||||
if (!changes.length) return false;
|
||||
const viewports = { base: viewportOf(base), head: viewportOf(head) };
|
||||
const outside = (reference: string) => {
|
||||
const [, side, id] = /^(base|head):element:(.+)$/.exec(reference) ?? [];
|
||||
if (side !== "base" && side !== "head") return undefined;
|
||||
const viewport = viewports[side];
|
||||
const element = (side === "base" ? base : head).observation.elements.find(candidate => candidate.elementId === id);
|
||||
const bounds = element && boundsOf(element);
|
||||
if (!viewport || !bounds) return false;
|
||||
const visibleWidth = Math.max(0, Math.min(bounds.x + bounds.width, viewport.x + viewport.width) - Math.max(bounds.x, viewport.x));
|
||||
const visibleHeight = Math.max(0, Math.min(bounds.y + bounds.height, viewport.y + viewport.height) - Math.max(bounds.y, viewport.y));
|
||||
const area = bounds.width * bounds.height;
|
||||
return area > 0 && visibleWidth * visibleHeight < area / 2;
|
||||
};
|
||||
return changes.every(fact => {
|
||||
const named = fact.evidenceRefs.map(outside).filter((value): value is boolean => value !== undefined);
|
||||
return named.length > 0 && named.every(Boolean);
|
||||
});
|
||||
}
|
||||
|
||||
function specificByLabel(elements: readonly ObservedElement[]): ObservedElement[] {
|
||||
const byLabel = new Map<string, ObservedElement>();
|
||||
const unlabelled: ObservedElement[] = [];
|
||||
@@ -1276,6 +1326,7 @@ function commonResult(input: CommonSurfaceComparatorInput): EvidenceComparatorRe
|
||||
const status: "modified" | "unchanged" = hasRuntimeDelta || reasons.length > 0
|
||||
? "modified"
|
||||
: "unchanged";
|
||||
const offScreen = input.visualAssessment.status === "unchanged" && changesOffScreen(facts, base, head);
|
||||
return {
|
||||
surfaceId: input.impact.id,
|
||||
status,
|
||||
@@ -1288,6 +1339,7 @@ function commonResult(input: CommonSurfaceComparatorInput): EvidenceComparatorRe
|
||||
),
|
||||
visualAssessment: input.visualAssessment,
|
||||
reviewerChanges,
|
||||
...(offScreen ? { offScreen: true as const } : {}),
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,33 @@
|
||||
import { Worker, isMainThread, parentPort, workerData } from "node:worker_threads";
|
||||
import { measureRegionMoves, type Rect } from "./region-shift.js";
|
||||
|
||||
type MeasuredRegions = Awaited<ReturnType<typeof measureRegionMoves>>;
|
||||
type RegionMoveWork = { regionMoveWork: true; basePath: string; headPath: string; regions: ReadonlyArray<Rect & { dominantChange?: string }> };
|
||||
type RegionMoveReply = { measured: MeasuredRegions } | { error: string };
|
||||
|
||||
/**
|
||||
* Measures region shifts and large moves on a worker thread, so several screenshot pairs search at once while the
|
||||
* main thread stays free: the search is CPU-bound and takes seconds on a tablet-sized screenshot. Falls back to the
|
||||
* calling thread when no worker can start.
|
||||
*/
|
||||
export async function measureRegionMovesInWorker(basePath: string, headPath: string, regions: RegionMoveWork["regions"]): Promise<MeasuredRegions> {
|
||||
const work: RegionMoveWork = { regionMoveWork: true, basePath, headPath, regions };
|
||||
let worker: Worker;
|
||||
try { worker = new Worker(new URL("./region-shift-worker.js", import.meta.url), { workerData: work }); }
|
||||
catch { return measureRegionMoves(basePath, headPath, regions); }
|
||||
return new Promise((resolve, reject) => {
|
||||
let settled = false;
|
||||
const finish = (outcome: () => void) => { if (!settled) { settled = true; outcome(); } };
|
||||
worker.once("message", (reply: RegionMoveReply) => finish(() => "error" in reply ? reject(new Error(reply.error)) : resolve(reply.measured)));
|
||||
// A worker that fails to load or dies before answering is a worker that did not start: the calling thread measures.
|
||||
worker.once("error", () => finish(() => resolve(measureRegionMoves(basePath, headPath, regions))));
|
||||
worker.once("exit", () => finish(() => resolve(measureRegionMoves(basePath, headPath, regions))));
|
||||
});
|
||||
}
|
||||
|
||||
if (!isMainThread && parentPort && (workerData as Partial<RegionMoveWork> | null)?.regionMoveWork === true) {
|
||||
const port = parentPort;
|
||||
const work = workerData as RegionMoveWork;
|
||||
measureRegionMoves(work.basePath, work.headPath, work.regions)
|
||||
.then(measured => port.postMessage({ measured } satisfies RegionMoveReply), (error: unknown) => port.postMessage({ error: (error as Error).message } satisfies RegionMoveReply));
|
||||
}
|
||||
@@ -4,7 +4,7 @@ import type { DecodedFrame } from "../shared/png-evidence.js";
|
||||
|
||||
/** How far a region's content moved from Before to After, in screenshot pixels (right and down are positive). */
|
||||
export type RegionShift = { x: number; y: number };
|
||||
type Rect = { x: number; y: number; width: number; height: number };
|
||||
export type Rect = { x: number; y: number; width: number; height: number };
|
||||
|
||||
/**
|
||||
* The farthest a region is searched for, in screenshot pixels: layout drift, not a different screen. Drift adds up
|
||||
@@ -63,16 +63,38 @@ function at(source: Image, x: number, y: number, channel?: number): number {
|
||||
return value(x0, y0) * (1 - fx) * (1 - fy) + value(x1, y0) * fx * (1 - fy) + value(x0, y1) * (1 - fx) * fy + value(x1, y1) * fx * fy;
|
||||
}
|
||||
|
||||
/** How badly After's region matches Before shifted by (sx, sy). A whole-pixel shift reads Before's pixels directly. */
|
||||
function mismatch(base: Image, head: Image, rect: Rect, sx: number, sy: number): number {
|
||||
/**
|
||||
* How badly After's region matches Before shifted by (sx, sy): the summed luminance difference, row by row. A sum
|
||||
* that passes `limit` stops early and returns a value above it: such a fit is neither the best, nor a tie, nor an
|
||||
* ambiguity, so its exact error is never read. Whole-pixel shifts read the pixel directly (the bilinear weights are
|
||||
* exactly 1 and 0 there); fractional ones interpolate like `at`.
|
||||
*/
|
||||
function mismatch(base: Image, head: Image, rect: Rect, sx: number, sy: number, limit = Infinity): number {
|
||||
const { width, height, luminance } = base;
|
||||
const maxX = width - 1, maxY = height - 1;
|
||||
const headLuminance = head.luminance, headWidth = head.width;
|
||||
const whole = Number.isInteger(sx) && Number.isInteger(sy);
|
||||
let error = 0;
|
||||
for (let y = rect.y; y < rect.y + rect.height; y += 1) {
|
||||
const by = Math.min(base.height - 1, Math.max(0, y - sy));
|
||||
for (let x = rect.x; x < rect.x + rect.width; x += 1) {
|
||||
const before = whole ? base.luminance[by * base.width + Math.min(base.width - 1, Math.max(0, x - sx))]! : at(base, x - sx, y - sy);
|
||||
error += Math.abs(before - head.luminance[y * head.width + x]!);
|
||||
const headRow = y * headWidth;
|
||||
if (whole) {
|
||||
const row = Math.min(maxY, Math.max(0, y - sy)) * width;
|
||||
for (let x = rect.x; x < rect.x + rect.width; x += 1) {
|
||||
error += Math.abs(luminance[row + Math.min(maxX, Math.max(0, x - sx))]! - headLuminance[headRow + x]!);
|
||||
}
|
||||
} else {
|
||||
const cy = Math.min(maxY, Math.max(0, y - sy));
|
||||
const y0 = Math.floor(cy), y1 = Math.min(maxY, y0 + 1), fy = cy - y0;
|
||||
const row0 = y0 * width, row1 = y1 * width;
|
||||
for (let x = rect.x; x < rect.x + rect.width; x += 1) {
|
||||
const cx = Math.min(maxX, Math.max(0, x - sx));
|
||||
const x0 = Math.floor(cx), x1 = Math.min(maxX, x0 + 1), fx = cx - x0;
|
||||
const sample = luminance[row0 + x0]! * (1 - fx) * (1 - fy) + luminance[row0 + x1]! * fx * (1 - fy)
|
||||
+ luminance[row1 + x0]! * (1 - fx) * fy + luminance[row1 + x1]! * fx * fy;
|
||||
error += Math.abs(sample - headLuminance[headRow + x]!);
|
||||
}
|
||||
}
|
||||
if (error > limit) return error;
|
||||
}
|
||||
return error;
|
||||
}
|
||||
@@ -113,18 +135,29 @@ function regionShift(base: Image, head: Image, region: Rect): RegionShift | unde
|
||||
const unshifted = mismatch(base, head, rect, 0, 0);
|
||||
if (unshifted === 0) return undefined;
|
||||
// Whole pixels first, every pixel counting: sampling every other row aliases on thin shapes (text, hairlines).
|
||||
// A fit worse than the best so far by more than the ambiguity margin cannot become the best, tie with it, or make
|
||||
// it ambiguous; its measurement stops as soon as that is known. The margin is taken from the worst fit the tie
|
||||
// could choose, since a tie goes to the smallest move, not the least error.
|
||||
const whole: Fit[] = [];
|
||||
let least = unshifted;
|
||||
for (let sy = -MAX_SHIFT_Y; sy <= MAX_SHIFT_Y; sy += 1) {
|
||||
for (let sx = -MAX_SHIFT_X; sx <= MAX_SHIFT_X; sx += 1) whole.push({ sx, sy, error: mismatch(base, head, rect, sx, sy) });
|
||||
for (let sx = -MAX_SHIFT_X; sx <= MAX_SHIFT_X; sx += 1) {
|
||||
const error = sx === 0 && sy === 0 ? unshifted : mismatch(base, head, rect, sx, sy, (least * TIE + 1e-6) * AMBIGUOUS + 1e-6);
|
||||
least = Math.min(least, error);
|
||||
whole.push({ sx, sy, error });
|
||||
}
|
||||
}
|
||||
const coarse = bestOf(whole);
|
||||
if (whole.some(fit => Math.abs(fit.sy - coarse.sy) >= 2 && fit.error <= coarse.error * AMBIGUOUS + 1e-6)) return undefined;
|
||||
// Then sixths of a pixel around it, from whole-number steps so a move up and a move down round alike.
|
||||
const fine: Fit[] = [];
|
||||
least = coarse.error;
|
||||
for (let iy = -STEPS_PER_PIXEL; iy <= STEPS_PER_PIXEL; iy += 1) {
|
||||
for (let ix = -STEPS_PER_PIXEL; ix <= STEPS_PER_PIXEL; ix += 1) {
|
||||
const sx = coarse.sx + ix / STEPS_PER_PIXEL, sy = coarse.sy + iy / STEPS_PER_PIXEL;
|
||||
fine.push({ sx, sy, error: ix === 0 && iy === 0 ? coarse.error : mismatch(base, head, rect, sx, sy) });
|
||||
const error = ix === 0 && iy === 0 ? coarse.error : mismatch(base, head, rect, sx, sy, least * TIE + 1e-6);
|
||||
least = Math.min(least, error);
|
||||
fine.push({ sx, sy, error });
|
||||
}
|
||||
}
|
||||
const best = bestOf(fine);
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { execFile } from "node:child_process";
|
||||
import { lstat, readFile, realpath } from "node:fs/promises";
|
||||
import { isAbsolute } from "node:path";
|
||||
|
||||
@@ -133,30 +133,34 @@ export async function diffScreenshots(options: {
|
||||
|| !isAbsolute(options.command)
|
||||
|| /[\u0000-\u001f\u007f]/.test(options.command)
|
||||
) throw new Error("agent-device command must be an absolute path");
|
||||
const result = spawnSync(
|
||||
options.command,
|
||||
[
|
||||
"--json",
|
||||
"diff",
|
||||
"screenshot",
|
||||
"--baseline",
|
||||
baselinePath,
|
||||
currentPath,
|
||||
"--threshold",
|
||||
String(threshold),
|
||||
],
|
||||
{
|
||||
encoding: "utf8",
|
||||
shell: false,
|
||||
timeout: options.timeoutMs ?? 60_000,
|
||||
env: {
|
||||
PATH: process.env.PATH,
|
||||
const result = await new Promise<{ error: (Error & { code?: unknown }) | null; stdout: string; stderr: string }>(resolve => {
|
||||
execFile(
|
||||
options.command,
|
||||
[
|
||||
"--json",
|
||||
"diff",
|
||||
"screenshot",
|
||||
"--baseline",
|
||||
baselinePath,
|
||||
currentPath,
|
||||
"--threshold",
|
||||
String(threshold),
|
||||
],
|
||||
{
|
||||
encoding: "utf8",
|
||||
shell: false,
|
||||
timeout: options.timeoutMs ?? 60_000,
|
||||
env: {
|
||||
PATH: process.env.PATH,
|
||||
},
|
||||
maxBuffer: 4 * 1024 * 1024,
|
||||
},
|
||||
maxBuffer: 4 * 1024 * 1024,
|
||||
},
|
||||
);
|
||||
if (result.error) throw new Error(`Could not run screenshot diff: ${result.error.message}`);
|
||||
if (result.status !== 0) {
|
||||
(error, stdout, stderr) => resolve({ error, stdout, stderr }),
|
||||
);
|
||||
});
|
||||
// execFile reports a non-zero exit as an error carrying the exit status; a spawn failure or timeout carries none.
|
||||
if (result.error && typeof result.error.code !== "number") throw new Error(`Could not run screenshot diff: ${result.error.message}`);
|
||||
if (result.error) {
|
||||
const detail = (result.stderr || result.stdout || "unknown error").trim().slice(0, 500);
|
||||
throw new Error(`Screenshot diff failed: ${detail}`);
|
||||
}
|
||||
|
||||
@@ -148,6 +148,12 @@ export async function reportCiError(error: unknown, options: {
|
||||
env?: NodeJS.ProcessEnv;
|
||||
secrets?: readonly string[];
|
||||
diagnosticsPath?: string;
|
||||
/**
|
||||
* The matrix target the failed command ran for, written into the diagnostics file. actions/download-artifact puts an
|
||||
* artifact in a directory named after it only when a pattern matches several, so the failure job cannot always read
|
||||
* the target from where the file lands.
|
||||
*/
|
||||
target?: string;
|
||||
write?: (value: string) => void;
|
||||
} = {}): Promise<CiErrorData> {
|
||||
const env = options.env ?? process.env;
|
||||
@@ -166,7 +172,7 @@ export async function reportCiError(error: unknown, options: {
|
||||
if (env.GITHUB_STEP_SUMMARY) outputs.push({ label: "job summary", operation: appendFile(env.GITHUB_STEP_SUMMARY, `${renderCiErrorSummary(error, renderOptions)}\n`) });
|
||||
if (options.diagnosticsPath) outputs.push({ label: "diagnostics file", operation: (async () => {
|
||||
await mkdir(dirname(options.diagnosticsPath!), { recursive: true });
|
||||
await writeFile(options.diagnosticsPath!, `${JSON.stringify(diagnostic, null, 2)}\n`);
|
||||
await writeFile(options.diagnosticsPath!, `${JSON.stringify(options.target ? { ...diagnostic, target: options.target } : diagnostic, null, 2)}\n`);
|
||||
})() });
|
||||
const results = await Promise.allSettled(outputs.map(output => output.operation));
|
||||
for (const [index, result] of results.entries()) {
|
||||
|
||||
@@ -1,33 +1,57 @@
|
||||
import { posix } from "node:path";
|
||||
import ts from "typescript";
|
||||
|
||||
/** The `@/*` import alias a tsconfig maps to one project directory, such as `src/` or the root. */
|
||||
/** The import aliases a tsconfig maps to project directories, such as `@/*` to `src/` and `@/assets/*` to `assets/`. */
|
||||
export type TsconfigAlias = {
|
||||
/** Directory prefix that replaces `@/`, with a trailing slash or empty for the project root. */
|
||||
target: string;
|
||||
/** Each alias prefix (`@/`, `@/assets/`) and the directory prefix that replaces it, longest prefix first. */
|
||||
prefixes: readonly { prefix: string; target: string }[];
|
||||
/** `baseUrl` is the project root: a bare specifier no alias matches is looked up there before it is taken for a package. */
|
||||
baseUrl?: true;
|
||||
/** Set when the tsconfig asks for module resolution the static analysis cannot follow. */
|
||||
unsupported?: string;
|
||||
};
|
||||
|
||||
const SINGLE_DIRECTORY_TARGET = /^(?:\.\/)?((?:[\w.-]+\/)*)\*$/;
|
||||
// A relative-looking key (`./*`, `/*`) is never applied: TypeScript and Metro resolve relative specifiers directly.
|
||||
const PREFIX_KEY = /^([^*./][^*]*\/)\*$/;
|
||||
const DEFAULT: TsconfigAlias = { prefixes: [{ prefix: "@/", target: "src/" }] };
|
||||
|
||||
/**
|
||||
* Static analysis follows one alias, `@/*`, pointing at a single directory (`./*`, `src/*`, `./src/*`),
|
||||
* which is what create-expo-app and the Expo docs set up. Anything else is reported, not guessed.
|
||||
* Static analysis follows `paths` entries of the form `prefix/*` that each point at a single directory (`./*`, `src/*`,
|
||||
* `./assets/*`), which covers create-expo-app's `@/*` and the extra entries apps add beside it. Anything else is
|
||||
* reported, not guessed.
|
||||
*/
|
||||
export function readTsconfigAlias(configText: string | undefined): TsconfigAlias {
|
||||
if (configText === undefined) return { target: "src/" };
|
||||
if (configText === undefined) return DEFAULT;
|
||||
const parsed = ts.parseConfigFileTextToJson("tsconfig.json", configText);
|
||||
const options = parsed.config?.compilerOptions ?? {};
|
||||
const unsupported = { target: "src/", unsupported: "custom module resolution is not statically supported" };
|
||||
const unsupported = { ...DEFAULT, unsupported: "custom module resolution is not statically supported" };
|
||||
if (parsed.error) return unsupported;
|
||||
if (options.baseUrl && ![".", "./"].includes(options.baseUrl)) return unsupported;
|
||||
if (parsed.config?.extends && parsed.config.extends !== "expo/tsconfig.base") return unsupported;
|
||||
const baseUrl = options.baseUrl ? { baseUrl: true as const } : {};
|
||||
const entries = Object.entries(options.paths ?? {}) as [string, unknown][];
|
||||
if (entries.length === 0) return { target: "src/" };
|
||||
if (entries.length > 1 || entries[0]![0] !== "@/*") return unsupported;
|
||||
const targets = entries[0]![1];
|
||||
if (!Array.isArray(targets) || targets.length !== 1 || typeof targets[0] !== "string") return unsupported;
|
||||
const match = SINGLE_DIRECTORY_TARGET.exec(targets[0]);
|
||||
if (!match || match[1]!.split("/").includes("..")) return unsupported;
|
||||
return { target: match[1]! };
|
||||
if (entries.length === 0) return { ...DEFAULT, ...baseUrl };
|
||||
const prefixes: { prefix: string; target: string }[] = [];
|
||||
for (const [key, targets] of entries) {
|
||||
const prefix = PREFIX_KEY.exec(key)?.[1];
|
||||
if (!prefix || !Array.isArray(targets) || targets.length !== 1 || typeof targets[0] !== "string") return unsupported;
|
||||
const match = SINGLE_DIRECTORY_TARGET.exec(targets[0]);
|
||||
if (!match || match[1]!.split("/").some(segment => segment === "." || segment === "..")) return unsupported;
|
||||
prefixes.push({ prefix, target: match[1]! });
|
||||
}
|
||||
// TypeScript picks the pattern with the longest prefix, so `@/assets/x` goes to `assets/`, not `src/assets/`.
|
||||
return { prefixes: prefixes.sort((a, b) => b.prefix.length - a.prefix.length), ...baseUrl };
|
||||
}
|
||||
|
||||
/** The project path an aliased specifier names, before extensions, or undefined when no alias matches it. */
|
||||
export function resolveTsconfigAlias(alias: TsconfigAlias, specifier: string): string | undefined {
|
||||
const entry = alias.prefixes.find(({ prefix }) => specifier.startsWith(prefix));
|
||||
// Normalized as Metro joins it: `@app/a/../b` is `src/b`, and a trailing slash still finds `index`.
|
||||
return entry ? posix.normalize(`${entry.target}${specifier.slice(entry.prefix.length)}`).replace(/\/$/, "") : undefined;
|
||||
}
|
||||
|
||||
/** The project path a bare specifier names under a root `baseUrl`, or undefined; a miss there is a package, not a gap. */
|
||||
export function resolveTsconfigBaseUrl(alias: TsconfigAlias, specifier: string): string | undefined {
|
||||
return alias.baseUrl && !/^[./]/.test(specifier) ? specifier : undefined;
|
||||
}
|
||||
@@ -3,7 +3,7 @@ import { spawnSync } from "node:child_process";
|
||||
import ts from "typescript";
|
||||
import type { SourceChange } from "./git-diff.js";
|
||||
import { validateSourceRoutes, type SourceRoute } from "../contracts/source-route.js";
|
||||
import { readTsconfigAlias } from "../shared/tsconfig-alias.js";
|
||||
import { readTsconfigAlias, resolveTsconfigAlias, resolveTsconfigBaseUrl } from "../shared/tsconfig-alias.js";
|
||||
|
||||
/** Repository path → file text at one exact commit. Non-source files carry an empty string. */
|
||||
export type SourceSnapshot = ReadonlyMap<string, string>;
|
||||
@@ -50,11 +50,12 @@ export function surfaceDependencies(routes: readonly SourceRoute[], files: Sourc
|
||||
if (alias.unsupported) unresolved.add("Custom TypeScript module resolution requires conservative capture");
|
||||
const cache = new Map<string, string[]>();
|
||||
const resolveModule = (importer: string, specifier: string): string | undefined => {
|
||||
const base = specifier.startsWith("@/") ? `${alias.target}${specifier.slice(2)}`
|
||||
: specifier.startsWith(".") ? posix.normalize(posix.join(posix.dirname(importer), specifier))
|
||||
: undefined;
|
||||
const base = resolveTsconfigAlias(alias, specifier)
|
||||
?? (specifier.startsWith(".") ? posix.normalize(posix.join(posix.dirname(importer), specifier))
|
||||
: resolveTsconfigBaseUrl(alias, specifier));
|
||||
if (!base) return undefined;
|
||||
const extensions = ["tsx", "ts", "jsx", "js"].flatMap(ext => [`.${platform}.${ext}`, ...(platform === "web" ? [] : [`.native.${ext}`]), `.${ext}`]).concat([".mjs", ".cjs", ".json"]);
|
||||
// Metro tries a platform suffix with every extension before the next suffix, so `Foo.ios.ts` beats `Foo.tsx`.
|
||||
const extensions = [`.${platform}`, ...(platform === "web" ? [] : [".native"]), ""].flatMap(suffix => ["tsx", "ts", "jsx", "js"].map(ext => `${suffix}.${ext}`)).concat([".mjs", ".cjs", ".json"]);
|
||||
return [...extensions.map((ext) => base + ext), base,
|
||||
...extensions.map((ext) => `${base}/index${ext}`)].find((candidate) => !/(?:^|\/)surfaces?\.json$/.test(candidate) && files.has(candidate));
|
||||
};
|
||||
@@ -78,7 +79,8 @@ export function surfaceDependencies(routes: readonly SourceRoute[], files: Sourc
|
||||
const specifier = node.text;
|
||||
const resolved = resolveModule(path, specifier);
|
||||
if (resolved) dependencies.push(resolved);
|
||||
else if (specifier.startsWith(".") || specifier.startsWith("@/") || specifier.startsWith("~")) {
|
||||
// An alias that matches but finds no file (an .svg, a scale variant) is local code this analysis cannot follow, not a package.
|
||||
else if (specifier.startsWith(".") || resolveTsconfigAlias(alias, specifier) !== undefined || specifier.startsWith("@/") || specifier.startsWith("~")) {
|
||||
unresolved.add(`Unresolved runtime import: ${path} -> ${specifier}`);
|
||||
}
|
||||
// Bare npm packages are covered by lockfile/package changes.
|
||||
@@ -103,7 +105,7 @@ export function surfaceDependencies(routes: readonly SourceRoute[], files: Sourc
|
||||
const pending = [surface.routeFile, ...surface.sourceFiles];
|
||||
let directory = posix.dirname(surface.routeFile);
|
||||
while (directory !== "." && directory !== "/") {
|
||||
const suffixes = ["tsx", "ts", "jsx", "js"].flatMap(extension => [`.${platform}.${extension}`, ...(platform === "web" ? [] : [`.native.${extension}`]), `.${extension}`]);
|
||||
const suffixes = [`.${platform}`, ...(platform === "web" ? [] : [".native"]), ""].flatMap(suffix => ["tsx", "ts", "jsx", "js"].map(ext => `${suffix}.${ext}`));
|
||||
const layout = suffixes.map(suffix => `${directory}/_layout${suffix}`).find(path => files.has(path));
|
||||
if (layout) pending.push(layout);
|
||||
directory = posix.dirname(directory);
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { posix } from "node:path";
|
||||
import ts from "typescript";
|
||||
import type { SourceSnapshot } from "./dependency-graph.js";
|
||||
import { readTsconfigAlias } from "../shared/tsconfig-alias.js";
|
||||
import { readTsconfigAlias, resolveTsconfigAlias, resolveTsconfigBaseUrl } from "../shared/tsconfig-alias.js";
|
||||
import { detectAppDir, routeGroupOf } from "./route-providers/expo-router.js";
|
||||
import { validateSourceRoutes, type SourceRoute } from "../contracts/source-route.js";
|
||||
import { validateNavigationGraph, type NavigationEdge, type NavigationGraph } from "../contracts/navigation-graph.js";
|
||||
@@ -54,7 +54,7 @@ export function extractSourceNavigation(routes: readonly SourceRoute[], files: S
|
||||
if (routes.length > 5_000 || files.size > 50_000) throw new Error("Source navigation inventory exceeds its analysis limit");
|
||||
const appDir = detectAppDir(files, analysis.entry);
|
||||
const platform = analysis.platform ?? "ios";
|
||||
const extensions = ["tsx", "ts", "jsx", "js"].flatMap(extension => [`.${platform}.${extension}`, ...(platform === "web" ? [] : [`.native.${extension}`]), `.${extension}`]).concat([".mjs", ".cjs"]);
|
||||
const extensions = [`.${platform}`, ...(platform === "web" ? [] : [".native"]), ""].flatMap(suffix => ["tsx", "ts", "jsx", "js"].map(ext => `${suffix}.${ext}`)).concat([".mjs", ".cjs"]);
|
||||
const unresolved = new Set<string>();
|
||||
const edges = new Map<string, NavigationEdge>();
|
||||
const modalSurfaceIds = new Set<string>();
|
||||
@@ -65,8 +65,8 @@ export function extractSourceNavigation(routes: readonly SourceRoute[], files: S
|
||||
const alias = readTsconfigAlias(files.get("tsconfig.json"));
|
||||
if (alias.unsupported) unresolved.add(`Unresolved navigation: tsconfig.json: ${alias.unsupported}`);
|
||||
const resolveModule = (specifier: string, importer: string): string | undefined => {
|
||||
const base = specifier.startsWith("@/") ? `${alias.target}${specifier.slice(2)}`
|
||||
: specifier.startsWith(".") ? posix.normalize(posix.join(posix.dirname(importer.replace(/^\//, "")), specifier)) : undefined;
|
||||
const base = resolveTsconfigAlias(alias, specifier)
|
||||
?? (specifier.startsWith(".") ? posix.normalize(posix.join(posix.dirname(importer.replace(/^\//, "")), specifier)) : resolveTsconfigBaseUrl(alias, specifier));
|
||||
if (!base || base.startsWith("../")) return undefined;
|
||||
const withoutJs = /\.[cm]?jsx?$/.test(base) ? base.replace(/\.[cm]?jsx?$/, "") : base;
|
||||
return [...extensions.map((ext) => base + ext), base,
|
||||
@@ -542,7 +542,7 @@ export function extractSourceNavigation(routes: readonly SourceRoute[], files: S
|
||||
let parent: ts.Node = declaration;
|
||||
while (!ts.isImportDeclaration(parent) && !ts.isSourceFile(parent)) parent = parent.parent;
|
||||
if (ts.isImportDeclaration(parent) && ts.isStringLiteral(parent.moduleSpecifier)
|
||||
&& /^(?:\.|@\/|~)/.test(parent.moduleSpecifier.text)
|
||||
&& (/^(?:\.|@\/|~)/.test(parent.moduleSpecifier.text) || resolveTsconfigAlias(alias, parent.moduleSpecifier.text) !== undefined)
|
||||
&& !assetFile.test(parent.moduleSpecifier.text)
|
||||
&& !resolveModule(parent.moduleSpecifier.text, parent.getSourceFile().fileName)) issue(parent, "local imported code could not be resolved");
|
||||
}
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { posix } from "node:path";
|
||||
import ts from "typescript";
|
||||
import { readTsconfigAlias } from "../../shared/tsconfig-alias.js";
|
||||
import { readTsconfigAlias, resolveTsconfigAlias, resolveTsconfigBaseUrl } from "../../shared/tsconfig-alias.js";
|
||||
|
||||
const UNKNOWN = "\u0000";
|
||||
const MAX_VALUES = 64;
|
||||
@@ -15,7 +15,7 @@ function unwrap(node: ts.Node): ts.Node {
|
||||
|
||||
/** Prove that every render path forwards elsewhere; unknown behavior remains capturable. */
|
||||
export function expoRedirectTargets(files: ReadonlyMap<string, string>, routeFiles: readonly string[], platform = "ios"): Map<string, string[]> {
|
||||
const extensions = ["tsx", "ts", "jsx", "js"].flatMap(ext => [`.${platform}.${ext}`, ...(platform === "web" ? [] : [`.native.${ext}`]), `.${ext}`]).concat([".mjs", ".cjs"]);
|
||||
const extensions = [`.${platform}`, ...(platform === "web" ? [] : [".native"]), ""].flatMap(suffix => ["tsx", "ts", "jsx", "js"].map(ext => `${suffix}.${ext}`)).concat([".mjs", ".cjs"]);
|
||||
const sources = new Map<string, ts.SourceFile | undefined>();
|
||||
let sourceBytes = 0;
|
||||
const sourceFile = (name: string): ts.SourceFile | undefined => {
|
||||
@@ -34,8 +34,8 @@ export function expoRedirectTargets(files: ReadonlyMap<string, string>, routeFil
|
||||
};
|
||||
const alias = readTsconfigAlias(files.get("tsconfig.json"));
|
||||
const resolveModule = (specifier: string, importer: string): string | undefined => {
|
||||
const base = specifier.startsWith("@/") && !alias.unsupported ? `${alias.target}${specifier.slice(2)}`
|
||||
: specifier.startsWith(".") ? posix.normalize(posix.join(posix.dirname(importer.replace(/^\//, "")), specifier)) : undefined;
|
||||
const base = (alias.unsupported ? undefined : resolveTsconfigAlias(alias, specifier))
|
||||
?? (specifier.startsWith(".") ? posix.normalize(posix.join(posix.dirname(importer.replace(/^\//, "")), specifier)) : alias.unsupported ? undefined : resolveTsconfigBaseUrl(alias, specifier));
|
||||
if (!base || base.startsWith("../")) return undefined;
|
||||
const withoutJs = base.replace(/\.[cm]?jsx?$/, "");
|
||||
return [...extensions.map(ext => base + ext), base, ...extensions.map(ext => `${base}/index${ext}`),
|
||||
|
||||
@@ -45,6 +45,8 @@ export function discoverReactNavigation(files: Record<string, string>, options:
|
||||
}
|
||||
}
|
||||
}
|
||||
// TypeScript uses the pattern with the longest prefix and no other, so `@/assets/x` never falls back to `@/*`.
|
||||
aliases.sort((a, b) => b.pattern.split("*")[0]!.length - a.pattern.split("*")[0]!.length);
|
||||
const resolveModule = (file: string, specifier: string): string | undefined => {
|
||||
const bases: string[] = [];
|
||||
if (specifier.startsWith(".")) bases.push(posix.normalize(posix.join(posix.dirname(file), specifier)));
|
||||
@@ -54,6 +56,7 @@ export function discoverReactNavigation(files: Record<string, string>, options:
|
||||
if (suffix === undefined ? specifier === prefix : specifier.startsWith(prefix!) && specifier.endsWith(suffix)) {
|
||||
const replacement = suffix === undefined ? "" : specifier.slice(prefix!.length, specifier.length - suffix.length);
|
||||
bases.push(...alias.targets.map((target) => posix.normalize(posix.join(alias.base, target.replace("*", replacement)))));
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -25,6 +25,7 @@ jobs:
|
||||
contents: read
|
||||
outputs:
|
||||
targets: ${{ steps.targets.outputs.targets }}
|
||||
max_parallel: ${{ steps.targets.outputs.max_parallel }}
|
||||
steps:
|
||||
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
||||
with: { ref: '${{ github.sha }}', path: app, persist-credentials: false }
|
||||
@@ -51,12 +52,15 @@ jobs:
|
||||
shell: bash
|
||||
run: |
|
||||
set -euo pipefail
|
||||
targets="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '[.targets[].id]')"
|
||||
echo "targets=$targets" >> "$GITHUB_OUTPUT"
|
||||
listed="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" --config .expo-explore/config.yaml)"
|
||||
echo "targets=$(jq -c '[.targets[].id]' <<< "$listed")" >> "$GITHUB_OUTPUT"
|
||||
# Each target job needs a simulator session: at most capture.maxSessions of them run at once.
|
||||
echo "max_parallel=$(jq '.maxParallel // (.targets | length)' <<< "$listed")" >> "$GITHUB_OUTPUT"
|
||||
baseline:
|
||||
needs: targets
|
||||
strategy:
|
||||
fail-fast: false
|
||||
max-parallel: ${{ fromJSON(needs.targets.outputs.max_parallel) }}
|
||||
matrix:
|
||||
target: ${{ fromJSON(needs.targets.outputs.targets) }}
|
||||
runs-on: ubuntu-22.04
|
||||
|
||||
@@ -48,6 +48,7 @@ jobs:
|
||||
contents: read
|
||||
outputs:
|
||||
targets: ${{ steps.targets.outputs.targets }}
|
||||
max_parallel: ${{ steps.targets.outputs.max_parallel }}
|
||||
base: ${{ steps.refs.outputs.base }}
|
||||
head: ${{ steps.refs.outputs.head }}
|
||||
compare: ${{ steps.refs.outputs.compare }}
|
||||
@@ -89,12 +90,15 @@ jobs:
|
||||
shell: bash
|
||||
run: |
|
||||
set -euo pipefail
|
||||
targets="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '[.targets[].id]')"
|
||||
echo "targets=$targets" >> "$GITHUB_OUTPUT"
|
||||
listed="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml)"
|
||||
echo "targets=$(jq -c '[.targets[].id]' <<< "$listed")" >> "$GITHUB_OUTPUT"
|
||||
# Each target job needs a simulator session: at most capture.maxSessions of them run at once.
|
||||
echo "max_parallel=$(jq '.maxParallel // (.targets | length)' <<< "$listed")" >> "$GITHUB_OUTPUT"
|
||||
capture:
|
||||
needs: targets
|
||||
strategy:
|
||||
fail-fast: false
|
||||
max-parallel: ${{ fromJSON(needs.targets.outputs.max_parallel) }}
|
||||
matrix:
|
||||
target: ${{ fromJSON(needs.targets.outputs.targets) }}
|
||||
runs-on: ubuntu-22.04
|
||||
@@ -215,8 +219,12 @@ jobs:
|
||||
${{ runner.temp }}/explore-review/agent-usage.jsonl
|
||||
retention-days: 7
|
||||
if-no-files-found: ignore
|
||||
# Each target's report runs once its own capture uploaded one, whatever the other targets' captures did, as in the
|
||||
# review workflow (brentvatne/euxy#172): needs.capture.result is the whole matrix's, so each leg looks for its own
|
||||
# artifact, and a target whose capture failed packages and links nothing. !cancelled() keeps a cancelled run stopped.
|
||||
report:
|
||||
needs: [targets, capture]
|
||||
if: needs.targets.result == 'success' && !cancelled()
|
||||
strategy:
|
||||
fail-fast: false
|
||||
matrix:
|
||||
@@ -225,19 +233,34 @@ jobs:
|
||||
timeout-minutes: 20
|
||||
permissions:
|
||||
contents: read
|
||||
outputs:
|
||||
# "true" from every leg that linked its report, so "true" once any did: the deploy job runs only then.
|
||||
published: ${{ steps.publish.outputs.published }}
|
||||
env:
|
||||
TARGET: ${{ matrix.target }}
|
||||
steps:
|
||||
# Downloading by name fails when the artifact is missing. A pattern that matches nothing downloads nothing and
|
||||
# succeeds, so only a download that went wrong fails this step; its one match is extracted into the path itself.
|
||||
- name: Download this target's captured review
|
||||
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
||||
with:
|
||||
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
|
||||
path: ${{ runner.temp }}/explore-review
|
||||
- name: Check that this target's capture succeeded
|
||||
id: captured
|
||||
shell: bash
|
||||
run: |
|
||||
set -euo pipefail
|
||||
if [[ -f "$RUNNER_TEMP/explore-review/report-input.json" ]]; then echo "found=true" >> "$GITHUB_OUTPUT"
|
||||
else echo "The $TARGET capture uploaded no review: its capture job failed."; fi
|
||||
- *setup-node
|
||||
- *install-explore
|
||||
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
||||
with:
|
||||
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
|
||||
path: ${{ runner.temp }}/explore-review
|
||||
- name: Package the report
|
||||
if: steps.captured.outputs.found == 'true'
|
||||
shell: bash
|
||||
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --target "$TARGET"
|
||||
- name: Upload the report
|
||||
if: steps.captured.outputs.found == 'true'
|
||||
id: report
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
||||
with:
|
||||
@@ -246,10 +269,15 @@ jobs:
|
||||
retention-days: 30
|
||||
if-no-files-found: error
|
||||
- name: Link the report from the run summary
|
||||
if: steps.captured.outputs.found == 'true'
|
||||
id: publish
|
||||
env:
|
||||
ARTIFACT_URL: ${{ steps.report.outputs.artifact-url }}
|
||||
shell: bash
|
||||
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
|
||||
run: |
|
||||
set -euo pipefail
|
||||
node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
|
||||
echo "published=true" >> "$GITHUB_OUTPUT"
|
||||
- name: Upload report failure diagnostics
|
||||
if: always()
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
||||
@@ -260,9 +288,10 @@ jobs:
|
||||
if-no-files-found: ignore
|
||||
# Hosted report (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment serving every target's report.
|
||||
# This is the only job after capture that holds EXPO_TOKEN; it writes the link to the run summary.
|
||||
# It runs once any target linked its report, and serves the targets that did; a failed target has no report to wait for.
|
||||
deploy:
|
||||
needs: [targets, capture, report]
|
||||
if: needs.capture.outputs.preview == 'eas'
|
||||
if: needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()
|
||||
runs-on: ubuntu-22.04
|
||||
timeout-minutes: 20
|
||||
permissions:
|
||||
@@ -271,7 +300,8 @@ jobs:
|
||||
steps:
|
||||
- *setup-node
|
||||
- *install-explore
|
||||
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>).
|
||||
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>),
|
||||
# or a lone artifact's files in the path itself; ci:deploy reads both.
|
||||
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
||||
with:
|
||||
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*
|
||||
|
||||
@@ -33,6 +33,7 @@ jobs:
|
||||
pull-requests: read
|
||||
outputs:
|
||||
targets: ${{ steps.targets.outputs.targets }}
|
||||
max_parallel: ${{ steps.targets.outputs.max_parallel }}
|
||||
# The failure job comments with these when a capture job fails before it resolves the PR itself.
|
||||
pr_number: ${{ steps.pr.outputs.pr_number }}
|
||||
base: ${{ steps.pr.outputs.base }}
|
||||
@@ -69,12 +70,15 @@ jobs:
|
||||
shell: bash
|
||||
run: |
|
||||
set -euo pipefail
|
||||
targets="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '[.targets[].id]')"
|
||||
echo "targets=$targets" >> "$GITHUB_OUTPUT"
|
||||
listed="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml)"
|
||||
echo "targets=$(jq -c '[.targets[].id]' <<< "$listed")" >> "$GITHUB_OUTPUT"
|
||||
# Each target job needs a simulator session: at most capture.maxSessions of them run at once.
|
||||
echo "max_parallel=$(jq '.maxParallel // (.targets | length)' <<< "$listed")" >> "$GITHUB_OUTPUT"
|
||||
capture:
|
||||
needs: targets
|
||||
strategy:
|
||||
fail-fast: false
|
||||
max-parallel: ${{ fromJSON(needs.targets.outputs.max_parallel) }}
|
||||
matrix:
|
||||
target: ${{ fromJSON(needs.targets.outputs.targets) }}
|
||||
runs-on: ubuntu-22.04
|
||||
@@ -203,8 +207,14 @@ jobs:
|
||||
${{ runner.temp }}/explore-review/agent-usage.jsonl
|
||||
retention-days: 7
|
||||
if-no-files-found: ignore
|
||||
# Each target's report runs once its own capture uploaded one, whatever the other targets' captures did: in
|
||||
# brentvatne/euxy#172 (run 39348956443) one flaky simulator session failed one of five captures, and with the report
|
||||
# waiting on every capture the PR got no report at all. needs.capture.result is the whole matrix's, so each leg looks
|
||||
# for its own artifact instead; a target whose capture failed uploaded none, packages and publishes nothing here, and
|
||||
# is named by the failure job. !cancelled() lets the legs run after a failed capture leg, but not in a cancelled run.
|
||||
report:
|
||||
needs: [targets, capture]
|
||||
if: needs.targets.result == 'success' && !cancelled()
|
||||
strategy:
|
||||
fail-fast: false
|
||||
matrix:
|
||||
@@ -215,19 +225,34 @@ jobs:
|
||||
contents: read
|
||||
actions: read
|
||||
pull-requests: write
|
||||
outputs:
|
||||
# "true" from every leg that published, so "true" once any did: the deploy job runs only then.
|
||||
published: ${{ steps.publish.outputs.published }}
|
||||
env:
|
||||
TARGET: ${{ matrix.target }}
|
||||
steps:
|
||||
# Downloading by name fails when the artifact is missing. A pattern that matches nothing downloads nothing and
|
||||
# succeeds, so only a download that went wrong fails this step; its one match is extracted into the path itself.
|
||||
- name: Download this target's captured review
|
||||
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
||||
with:
|
||||
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
|
||||
path: ${{ runner.temp }}/explore-review
|
||||
- name: Check that this target's capture succeeded
|
||||
id: captured
|
||||
shell: bash
|
||||
run: |
|
||||
set -euo pipefail
|
||||
if [[ -f "$RUNNER_TEMP/explore-review/report-input.json" ]]; then echo "found=true" >> "$GITHUB_OUTPUT"
|
||||
else echo "The $TARGET capture uploaded no review: its capture job failed, and the failure job reports it."; fi
|
||||
- *setup-node
|
||||
- *install-explore
|
||||
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
||||
with:
|
||||
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
|
||||
path: ${{ runner.temp }}/explore-review
|
||||
- name: Package hosted review bundle
|
||||
if: steps.captured.outputs.found == 'true'
|
||||
shell: bash
|
||||
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --target "$TARGET"
|
||||
- name: Upload hosted review bundle
|
||||
if: steps.captured.outputs.found == 'true'
|
||||
id: viewer
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
||||
with:
|
||||
@@ -236,11 +261,16 @@ jobs:
|
||||
retention-days: 30
|
||||
if-no-files-found: error
|
||||
- name: Publish current PR hosted links
|
||||
if: steps.captured.outputs.found == 'true'
|
||||
id: publish
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ github.token }}
|
||||
ARTIFACT_URL: ${{ steps.viewer.outputs.artifact-url }}
|
||||
shell: bash
|
||||
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
|
||||
run: |
|
||||
set -euo pipefail
|
||||
node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
|
||||
echo "published=true" >> "$GITHUB_OUTPUT"
|
||||
- name: Upload report failure diagnostics
|
||||
if: always()
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
||||
@@ -252,9 +282,10 @@ jobs:
|
||||
# Hosted preview (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment per review, serving every target's report.
|
||||
# This is the only job after capture that holds EXPO_TOKEN; the report job stays credential-free and has already
|
||||
# published the Download report link, so a failed deployment leaves the comment on the download-and-drop flow.
|
||||
# It runs once any target published its report, and serves the targets that did; a failed target has no report to wait for.
|
||||
deploy:
|
||||
needs: [targets, capture, report]
|
||||
if: needs.capture.outputs.preview == 'eas'
|
||||
if: needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()
|
||||
runs-on: ubuntu-22.04
|
||||
timeout-minutes: 20
|
||||
permissions:
|
||||
@@ -264,7 +295,8 @@ jobs:
|
||||
steps:
|
||||
- *setup-node
|
||||
- *install-explore
|
||||
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>).
|
||||
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>),
|
||||
# or a lone artifact's files in the path itself; ci:deploy reads both.
|
||||
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
||||
with:
|
||||
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*
|
||||
@@ -313,6 +345,6 @@ jobs:
|
||||
shell: bash
|
||||
run: |
|
||||
set -euo pipefail
|
||||
# The diagnostics artifacts are data files from this run and attempt, never executable report code;
|
||||
# the first error.json names the failed target, and the comment keeps every other target's result.
|
||||
# The diagnostics artifacts are data files from this run and attempt, never executable report code; each
|
||||
# error.json names its failed target, which gets a failed record, and the comment keeps every other target's result.
|
||||
node "$TOOLS/dist/cli.js" ci:failure --pr "${PR_NUMBER:-0}" --head "${HEAD_SHA:-}" --base "${BASE_SHA:-}" --diagnostics "$RUNNER_TEMP/explore-failure"
|
||||
@@ -196,7 +196,7 @@ test("the pill shows the app's own icon when the report has one, and the Expo ma
|
||||
report.review.runtime.appIcon = { url: `https://artifact.expo-explore.invalid/${iconSha}.png`, sha256: iconSha, width: 4, height: 4 };
|
||||
report.assets.push({ sha256: iconSha, path: iconPath });
|
||||
const withIcon = await harness(t, await archive(report, [{ name: iconPath, bytes: iconBytes }]), { app: true });
|
||||
const logo = withIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map", exact: true });
|
||||
const logo = withIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map of Fixture", exact: true });
|
||||
await expect(logo.locator("img.panel-app-icon")).toHaveJSProperty("naturalWidth", 4);
|
||||
await expect(logo.locator(".expo-mark")).toHaveCount(0);
|
||||
// The tab shows it too, from a Blob URL: the ZIP's own reference is not one the browser can load.
|
||||
@@ -206,7 +206,7 @@ test("the pill shows the app's own icon when the report has one, and the Expo ma
|
||||
assert.deepEqual(withIcon.errors, []);
|
||||
|
||||
const withoutIcon = await harness(t, await archive(), { app: true });
|
||||
const mark = withoutIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map", exact: true });
|
||||
const mark = withoutIcon.page.locator(".left-panel-collapsed-pill").getByRole("button", { name: "Map of Fixture", exact: true });
|
||||
await expect(mark.locator(".expo-mark")).toHaveCount(1);
|
||||
await expect(mark.locator("img")).toHaveCount(0);
|
||||
assert.deepEqual(withoutIcon.errors, []);
|
||||
@@ -647,6 +647,259 @@ test("a switch to a target whose screenshots have another shape lays the map out
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
/**
|
||||
* The phone header as drawn, once a resize's fit has run. Its shown controls, each of the row's clipped at the row's
|
||||
* edges: how many pairs overlap, how many run past the row's end (past the window on a desktop, whose row does not
|
||||
* clip), and the page's overflow; the target label's parts cut without a fade or faded though whole; the room around
|
||||
* the row's first and last controls for a focus ring; and the name's width against its text's and its minimum.
|
||||
*/
|
||||
function phoneHeader(page) {
|
||||
return page.locator(".left-panel-collapsed-pill").evaluate(async pill => {
|
||||
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
|
||||
const row = pill.querySelector(".collapsed-app-identity");
|
||||
const clip = row.getBoundingClientRect();
|
||||
const end = getComputedStyle(row).overflowX === "clip" ? clip.right - parseFloat(getComputedStyle(row).paddingRight) : innerWidth;
|
||||
const shown = [...pill.querySelectorAll(".panel-logo-button, .collapsed-app-identity > strong, .collapsed-platform, .collapsed-pr, .collapsed-search")]
|
||||
.filter(node => node.checkVisibility({ visibilityProperty: true }));
|
||||
const boxes = shown.map(node => {
|
||||
const box = node.getBoundingClientRect();
|
||||
return row.contains(node) ? { left: Math.max(box.left, clip.left), right: Math.min(box.right, clip.right) } : box;
|
||||
});
|
||||
let overlaps = 0;
|
||||
for (const [index, a] of boxes.entries()) for (const b of boxes.slice(index + 1)) if (a.left < b.right - 1 && b.left < a.right - 1) overlaps += 1;
|
||||
const items = shown.filter(node => row.contains(node));
|
||||
const past = items.filter(node => node.getBoundingClientRect().right > end + 1).length;
|
||||
const parts = [...row.querySelectorAll(".collapsed-target .collapsed-platform-label, .collapsed-target .collapsed-platform-label-text, .collapsed-target .collapsed-platform-label-suffix")];
|
||||
const cut = node => node.scrollWidth > node.offsetWidth;
|
||||
const faded = node => getComputedStyle(node).maskImage !== "none";
|
||||
const controls = items.filter(node => node.matches(".collapsed-platform, .collapsed-pr"));
|
||||
const ring = controls.length ? Math.floor(Math.min(controls[0].getBoundingClientRect().left - clip.left, clip.right - controls.at(-1).getBoundingClientRect().right)) : 4;
|
||||
const name = row.querySelector(":scope > strong");
|
||||
const minimum = parseFloat(getComputedStyle(row).getPropertyValue("--collapsed-name-min")) || 64;
|
||||
return {
|
||||
overlaps, past, overflow: document.documentElement.scrollWidth - innerWidth,
|
||||
unfaded: parts.filter(node => cut(node) && !faded(node)).length, fadedWhole: parts.filter(node => faded(node) && !cut(node)).length,
|
||||
ring, targetCut: parts.some(cut),
|
||||
name: name.checkVisibility({ visibilityProperty: true }) ? { width: name.getBoundingClientRect().width, text: name.scrollWidth, minimum: Math.min(minimum, name.scrollWidth) } : undefined,
|
||||
};
|
||||
});
|
||||
}
|
||||
|
||||
/** What a header that fits shows: nothing overlaps or runs past the row, and a label fades exactly where it is cut. */
|
||||
const FITS = { overlaps: 0, past: 0, overflow: 0, unfaded: 0, fadedWhole: 0 };
|
||||
const fitOf = ({ overlaps, past, overflow, unfaded, fadedWhole }) => ({ overlaps, past, overflow, unfaded, fadedWhole });
|
||||
|
||||
/**
|
||||
* A report of two targets, `label` the shown one's, for the phone header: `icon` adds the app's icon (`"broken"`, one
|
||||
* whose bytes are no image), `appearances` a second chip, and the pull request is #1234.
|
||||
*/
|
||||
async function phoneReport({ label, appName = "Acme Super Long Application Name", icon = false, appearances = false }) {
|
||||
const targets = [{ id: "shown", platform: "ios", label }, { id: "other", platform: "ios", label: "iPhone 17" }];
|
||||
const report = reportFixture();
|
||||
report.review.runtime = { ...report.review.runtime, appName, platform: "ios", platforms: ["ios"], target: targets[0], targets,
|
||||
...(appearances ? { colorSchemes: ["light", "dark"] } : {}) };
|
||||
report.review.pullRequest.number = 1234;
|
||||
const extra = [];
|
||||
if (icon) {
|
||||
const image = new PNG({ width: 4, height: 4 });
|
||||
image.data.fill(180);
|
||||
const bytes = icon === "broken" ? new TextEncoder().encode("not an image") : PNG.sync.write(image);
|
||||
const sha = createHash("sha256").update(bytes).digest("hex");
|
||||
report.review.runtime.appIcon = { url: `https://artifact.expo-explore.invalid/${sha}.png`, sha256: sha, width: 4, height: 4 };
|
||||
report.assets.push({ sha256: sha, path: `assets/${sha}.png` });
|
||||
extra.push({ name: `assets/${sha}.png`, bytes });
|
||||
}
|
||||
return archive(report, extra);
|
||||
}
|
||||
|
||||
test("at a phone's width the header leaves out the app's name, then the pull request link, then fades the target's device; nothing overlaps", { timeout: 60_000 }, async t => {
|
||||
const targets = [{ id: "iphone", platform: "ios", label: "iPhone 17" }, { id: "duo-half", platform: "ios", label: "iPhone 17 Pro Max Duo (half-open, outer)" }];
|
||||
const icon = new PNG({ width: 4, height: 4 });
|
||||
icon.data.fill(180);
|
||||
const iconBytes = PNG.sync.write(icon);
|
||||
const iconSha = createHash("sha256").update(iconBytes).digest("hex");
|
||||
const report = reportFixture();
|
||||
// An icon to name the app once its name is left out; two appearances for the second chip; the longest target.
|
||||
report.review.runtime = {
|
||||
...report.review.runtime, platform: "ios", platforms: ["ios"], target: targets[1], targets, colorSchemes: ["light", "dark"],
|
||||
appIcon: { url: `https://artifact.expo-explore.invalid/${iconSha}.png`, sha256: iconSha, width: 4, height: 4 },
|
||||
};
|
||||
report.assets.push({ sha256: iconSha, path: `assets/${iconSha}.png` });
|
||||
report.review.pullRequest.number = 1234;
|
||||
const { page, errors } = await harness(t, await archive(report, [{ name: `assets/${iconSha}.png`, bytes: iconBytes }]), { app: true });
|
||||
const pill = page.locator(".left-panel-collapsed-pill");
|
||||
const name = pill.locator(".collapsed-app-identity > strong");
|
||||
const target = pill.locator(".collapsed-target");
|
||||
const device = target.locator(".collapsed-platform-label-text");
|
||||
const pose = target.locator(".collapsed-platform-label-suffix");
|
||||
const pr = pill.locator(".collapsed-pr");
|
||||
const layout = async () => fitOf(await phoneHeader(page));
|
||||
const clipped = locator => locator.evaluate(node => node.scrollWidth - node.offsetWidth > 1);
|
||||
const whole = async () => ({ device: !await clipped(device), pose: !await clipped(pose) });
|
||||
const dropped = () => pill.locator(".collapsed-app-identity").evaluate(node => node.dataset.drop ?? "");
|
||||
// The fit measures text: the Viewer's font must be in before the row's widths mean anything.
|
||||
await page.evaluate(() => document.fonts.ready);
|
||||
|
||||
// A desktop window's pill is sized by its content and shows the whole row.
|
||||
await page.setViewportSize({ width: 1180, height: 820 });
|
||||
await expect(name).toBeVisible();
|
||||
await expect(target).toHaveText("iPhone 17 Pro Max Duo (half-open, outer)");
|
||||
await expect(pr).toHaveText("PR #1234");
|
||||
await expect(pr).toBeVisible();
|
||||
expect(await whole()).toEqual({ device: true, pose: true });
|
||||
expect(await dropped()).toBe("");
|
||||
await expect.poll(layout).toEqual(FITS);
|
||||
|
||||
// A small tablet has no room for the name beside Search: the row leaves it out (the icon still names the app) and
|
||||
// keeps the whole target and a shorter link.
|
||||
await page.setViewportSize({ width: 560, height: 932 });
|
||||
await expect(name).toBeHidden();
|
||||
await expect(pr).toHaveText("#1234");
|
||||
await expect(pr).toBeVisible();
|
||||
await expect(target).toHaveText("iPhone 17 Pro Max Duo (half-open, outer)");
|
||||
expect(await whole()).toEqual({ device: true, pose: true });
|
||||
await expect.poll(layout).toEqual(FITS);
|
||||
const search = pill.getByRole("button", { name: "Search", exact: true });
|
||||
const finger = await search.boundingBox();
|
||||
assert.ok(finger.width >= 44 && finger.height >= 44, `Search is ${finger.width}×${finger.height}`);
|
||||
|
||||
// A large phone's width leaves out the link too (Search keeps "Open pull request") before it touches the target.
|
||||
await page.setViewportSize({ width: 500, height: 844 });
|
||||
await expect(pr).toBeHidden();
|
||||
await expect(target).toHaveText("iPhone 17 Pro Max Duo (half-open, outer)");
|
||||
expect(await whole()).toEqual({ device: true, pose: true });
|
||||
await expect.poll(layout).toEqual(FITS);
|
||||
await page.keyboard.press("ControlOrMeta+KeyK");
|
||||
const palette = page.getByRole("dialog", { name: "Search Explore" });
|
||||
await palette.getByRole("combobox", { name: "Search screens and commands" }).fill("pull request");
|
||||
await expect(palette.getByRole("option", { name: /^Open pull request #1234 on GitHub/ })).toBeVisible();
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(palette).toBeHidden();
|
||||
|
||||
// An iPhone's width fades the device's name; the pose stays whole and nothing overlaps.
|
||||
await page.setViewportSize({ width: 390, height: 844 });
|
||||
await expect(pill.locator(".collapsed-app-identity")).toHaveAttribute("data-drop", /squeeze/);
|
||||
await expect(pill.locator(".collapsed-app-identity")).not.toHaveAttribute("data-drop", /pose/);
|
||||
expect(await whole()).toEqual({ device: false, pose: true });
|
||||
await expect.poll(layout).toEqual(FITS);
|
||||
|
||||
// Narrower than the pose beside two chips: the pose fades too, inside its chip, never over the appearance chip.
|
||||
await page.setViewportSize({ width: 320, height: 568 });
|
||||
await expect(pill.locator(".collapsed-app-identity")).toHaveAttribute("data-drop", /pose/);
|
||||
await expect(pill.locator(".collapsed-platform").nth(1)).toHaveText("Light");
|
||||
await expect.poll(layout).toEqual(FITS);
|
||||
|
||||
// Widened again, the row takes everything back: the desktop's pill is sized by its content and leaves nothing out
|
||||
// (its own width rule ellipsizes the name beside so long a target; the fit does not touch it).
|
||||
await page.setViewportSize({ width: 1180, height: 820 });
|
||||
await expect(name).toHaveCSS("visibility", "visible");
|
||||
await expect(name).toHaveCSS("position", "static");
|
||||
await expect(pr).toHaveText("PR #1234");
|
||||
await expect(pr).toBeVisible();
|
||||
expect(await whole()).toEqual({ device: true, pose: true });
|
||||
expect(await dropped()).toBe("");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a phone's row without the app's icon cuts the name down to its minimum before it squeezes the target, and fades a label only where it is cut", { timeout: 90_000 }, async t => {
|
||||
const { page, errors } = await harness(t, await phoneReport({ label: "iPhone 16 Pro (open)" }), { app: true });
|
||||
const row = page.locator(".left-panel-collapsed-pill .collapsed-app-identity");
|
||||
await expect(row.locator(".collapsed-target")).toHaveText("iPhone 16 Pro (open)");
|
||||
await page.evaluate(() => document.fonts.ready);
|
||||
|
||||
// An iPhone's width has room for the whole target beside a cut name: the name gives way, the target keeps its label.
|
||||
await page.setViewportSize({ width: 390, height: 844 });
|
||||
await expect(row).not.toHaveAttribute("data-drop", /squeeze/);
|
||||
const iphone = await phoneHeader(page);
|
||||
assert.equal(iphone.targetCut, false);
|
||||
assert.ok(iphone.name && iphone.name.width > iphone.name.minimum + 1 && iphone.name.width < iphone.name.text, `the name is ${JSON.stringify(iphone.name)}`);
|
||||
|
||||
// At every phone width, the target is cut only once the name is at its minimum, and only what is cut fades.
|
||||
for (const width of [320, 340, 360, 375, 390, 414, 430, 460, 480, 560, 700]) {
|
||||
await page.setViewportSize({ width, height: 844 });
|
||||
const header = await phoneHeader(page);
|
||||
assert.deepEqual(fitOf(header), FITS, `at ${width}px`);
|
||||
if (header.name) assert.ok(header.name.width >= header.name.minimum - 1, `at ${width}px the name is ${JSON.stringify(header.name)}`);
|
||||
if (header.targetCut && header.name) assert.ok(header.name.width <= header.name.minimum + 1, `at ${width}px the target is cut beside ${JSON.stringify(header.name)}`);
|
||||
}
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a phone's header with Hand off fits its row at an iPhone's widths, with or without the app's icon", { timeout: 120_000 }, async t => {
|
||||
// The hosted preview's header: Hand off sits before Search, so the row has less room than at /r.
|
||||
const reports = [
|
||||
{ label: "iPhone 16 Pro (open)", icon: false, appearances: true },
|
||||
{ label: "iPhone 16 Pro (open)", icon: true, appearances: true },
|
||||
{ label: "iOS", icon: false, appearances: true },
|
||||
];
|
||||
for (const [index, options] of reports.entries()) {
|
||||
const preview = { token: `${"qrstuvwxyz234567234567234567".slice(0, 28)}${"abcd".slice(index, index + 1)}bcd` };
|
||||
const { page, errors } = await harness(t, await phoneReport(options), { app: true, reportIdentity: null, preview, query: "" });
|
||||
const pill = page.locator(".left-panel-collapsed-pill");
|
||||
await expect(pill.locator(".collapsed-target")).toHaveText(options.label);
|
||||
await page.evaluate(() => document.fonts.ready);
|
||||
for (const width of [320, 360, 390, 430, 460]) {
|
||||
await page.setViewportSize({ width, height: 844 });
|
||||
await expect(pill.getByRole("button", { name: "Hand off to AI" })).toBeVisible();
|
||||
const header = await phoneHeader(page);
|
||||
const where = `${JSON.stringify(options)} at ${width}px`;
|
||||
assert.deepEqual(fitOf(header), FITS, where);
|
||||
// The row's end chip has room for its focus ring (2px, 2px out) and its key hint.
|
||||
assert.ok(header.ring >= 4, `${where}: ${header.ring}px around the row's controls`);
|
||||
// A name the row keeps is readable; one it leaves out is still the Map button's.
|
||||
if (header.name) assert.ok(header.name.width >= header.name.minimum - 1, `${where}: the name is ${JSON.stringify(header.name)}`);
|
||||
else await expect(pill.getByRole("button", { name: "Map of Acme Super Long Application Name", exact: true })).toBeVisible();
|
||||
// A short label is no squeeze's to give: it shows whole.
|
||||
if (options.label === "iOS") assert.equal(header.targetCut, false, where);
|
||||
}
|
||||
assert.deepEqual(errors, []);
|
||||
await page.close();
|
||||
}
|
||||
});
|
||||
|
||||
test("a phone's row keeps the app's name when its icon cannot be read and the Expo mark stands in", { timeout: 60_000 }, async t => {
|
||||
const { page, errors } = await harness(t, await phoneReport({ label: "iPhone 17 Pro Max Duo (half-open, outer)", icon: "broken", appearances: true }), { app: true });
|
||||
const pill = page.locator(".left-panel-collapsed-pill");
|
||||
await expect(pill.locator(".panel-logo-button .expo-mark")).toHaveCount(1);
|
||||
await expect(pill.locator(".panel-logo-button img")).toHaveCount(0);
|
||||
await page.evaluate(() => document.fonts.ready);
|
||||
// With the icon, this width leaves the name out; the Expo mark does not name the app, so the name stays, cut.
|
||||
await page.setViewportSize({ width: 560, height: 932 });
|
||||
await expect(pill.locator(".collapsed-app-identity > strong")).toBeVisible();
|
||||
const header = await phoneHeader(page);
|
||||
assert.deepEqual(fitOf(header), FITS);
|
||||
assert.ok(header.name && header.name.width >= header.name.minimum - 1, `the name is ${JSON.stringify(header.name)}`);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a phone's fit that waits on the fonts does nothing once the window is a desktop's", { timeout: 60_000 }, async t => {
|
||||
// The fonts arrive only when the test says, after the window has crossed to the desktop layout.
|
||||
const fault = () => {
|
||||
let release;
|
||||
const ready = new Promise(resolve => { release = () => resolve(document.fonts); });
|
||||
Object.defineProperty(document.fonts, "ready", { configurable: true, get: () => ready });
|
||||
window.releaseFonts = release;
|
||||
};
|
||||
const bytes = await phoneReport({ label: "iPhone 16 Pro (open)", icon: true, appearances: true });
|
||||
const { page, errors } = await harness(t, bytes, { app: true, open: false, fault });
|
||||
await page.setViewportSize({ width: 390, height: 844 });
|
||||
await chooseFile(page, bytes);
|
||||
const pill = page.locator(".left-panel-collapsed-pill");
|
||||
const row = pill.locator(".collapsed-app-identity");
|
||||
await expect(row).toHaveAttribute("data-drop", /name/);
|
||||
|
||||
await page.setViewportSize({ width: 1180, height: 820 });
|
||||
await expect(pill.locator(".collapsed-pr")).toHaveText("PR #1234");
|
||||
await page.evaluate(async () => {
|
||||
window.releaseFonts();
|
||||
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
|
||||
});
|
||||
await expect(row).not.toHaveAttribute("data-drop");
|
||||
await expect(pill.locator(".collapsed-pr")).toBeVisible();
|
||||
await expect(pill.locator(".collapsed-app-identity > strong")).toBeVisible();
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a hosted manifest larger than the Viewer reads is refused before it is parsed", { timeout: 60_000 }, async t => {
|
||||
const preview = { token: "klmnopqrstuvwxyz2345672345672345", padding: 11 * 1024 * 1024 };
|
||||
const { page, errors } = await harness(t, await archive(), { app: true, reportIdentity: null, preview, query: "" });
|
||||
@@ -1346,7 +1599,7 @@ test("transition thumbnails without a readable screenshot show the variant thumb
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a docs-only report with zero images and no EAS build opens Screens without a visual verdict", async t => {
|
||||
test("a docs-only report with zero images and no EAS build has no screens to show, and its link to a route says why", async t => {
|
||||
const report = reportFixture();
|
||||
report.review.mode = "changes";
|
||||
report.review.runtime.projectId = "";
|
||||
@@ -1359,12 +1612,11 @@ test("a docs-only report with zero images and no EAS build opens Screens without
|
||||
report.assets = [];
|
||||
const { page, errors } = await harness(t, await archive(report), { app: true });
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
await page.getByRole("button", { name: "Screens", exact: true }).click();
|
||||
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(1);
|
||||
await expect(page.locator(".screens-page .diff-frame.diff-not-compared")).toHaveCount(1);
|
||||
// The Inspector's missing screenshot matches the canvas node: the icon above a short label and
|
||||
// the report's reason for the gap, centred in a phone-shaped preview frame.
|
||||
await page.locator(".screens-page .screen-screenshot-target").click();
|
||||
// The change reaches no screen, so the one route was never captured: the Map and Screens say so instead of an empty page.
|
||||
const empty = page.locator(".map-empty");
|
||||
await expect(empty.getByRole("heading")).toHaveText("No screens were captured");
|
||||
// The link names /home, and the Inspector says why it has no screenshot: the icon above a short label and the report's
|
||||
// reason for the gap, centred in a phone-shaped preview frame.
|
||||
const placeholder = page.locator(".inspector .inspector-preview .screenshot-placeholder");
|
||||
await expect(placeholder.locator("span")).toHaveText("No screenshot");
|
||||
await expect(placeholder.locator(".screenshot-placeholder-detail")).toHaveText("Not compared; no capture was recorded");
|
||||
@@ -1390,10 +1642,98 @@ test("a docs-only report with zero images and no EAS build opens Screens without
|
||||
await expect(page.locator(".collapsed-change-count")).toHaveCount(0);
|
||||
await expect(page.locator(".changes-screen-row")).toHaveCount(0);
|
||||
await expect(page.locator(".diff-frame.diff-modified, .diff-frame.diff-unchanged")).toHaveCount(0);
|
||||
await page.getByRole("button", { name: "Screens", exact: true }).click();
|
||||
await expect(empty.getByRole("heading")).toHaveText("No screens were captured");
|
||||
await expect(page.locator(".screens-cell, .screens-tree-row")).toHaveCount(0);
|
||||
assert.equal(await page.evaluate(() => window.createdUrls.length), 0);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
/** A report with Home (modified) and Profile (not compared) captured, a new route named in exploration.exclude, and a redirect. */
|
||||
function omittedRoutesReport() {
|
||||
const report = reportFixture();
|
||||
const home = report.review.surfaces[0];
|
||||
const route = (id, path, extra = {}) => ({ ...home.head, id, route: path, path, routeFile: `app/${id}.tsx`, logicalPath: `app/${id}.tsx`, ...extra });
|
||||
const redirect = route("start", "/start", { kind: "redirect", redirectTo: "/home" });
|
||||
report.review.surfaces.push(
|
||||
{ id: "profile", status: "unchanged", base: route("profile", "/profile"), head: route("profile", "/profile"),
|
||||
baseImage: { ...home.baseImage }, headImage: { ...home.headImage }, baseOutcome: { ...home.baseOutcome }, headOutcome: { ...home.headOutcome } },
|
||||
{ id: "channel", status: "added", excluded: true, base: null, head: route("channel", "/c/[channel]") },
|
||||
{ id: "start", status: "unchanged", base: { ...redirect }, head: redirect });
|
||||
return report;
|
||||
}
|
||||
|
||||
test("a public report's excluded route and redirect are not among its screens: Screens, its counts, find, search and the changes leave them out", { timeout: 60_000 }, async t => {
|
||||
const { page, errors } = await harness(t, await archive(omittedRoutesReport()), { app: true, query: "&screen=home" });
|
||||
await expect(page.locator(".map-canvas .react-flow__node")).toHaveCount(2);
|
||||
// The excluded route is new in this change, but it was never captured: it is not a change to review.
|
||||
const menu = await openChangesMenu(page);
|
||||
await expect(menu.getByRole("group", { name: "Filter changes" }).getByRole("button")).toHaveText(["Modified 1"]);
|
||||
await expect(menu.getByText("/c/[channel]")).toHaveCount(0);
|
||||
await page.keyboard.press("Escape");
|
||||
|
||||
await page.getByRole("button", { name: "Screens", exact: true }).click();
|
||||
const cells = page.locator(".screens-page .screens-cell");
|
||||
await expect(cells).toHaveCount(2);
|
||||
await expect(page.locator(".screens-tree-row[data-screen-id]")).toHaveCount(2);
|
||||
for (const id of ["channel", "start"]) await expect(page.locator(`[data-screen-id="${id}"]`)).toHaveCount(0);
|
||||
await expect(page.locator(".screens-filter .screens-chip")).toHaveText(["Changed1", "All2"]);
|
||||
// ← and → step through the two screens and no others.
|
||||
await page.locator(".screens-page").click({ position: { x: 4, y: 4 } });
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(page.locator(".screens-cell .screen-screenshot-card.selected")).toHaveCount(1);
|
||||
const picked = async () => page.locator(".screens-cell:has(.screen-screenshot-card.selected)").getAttribute("data-screen-id");
|
||||
const first = await picked();
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect.poll(picked).not.toBe(first);
|
||||
const second = await picked();
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect.poll(picked).toBe(second);
|
||||
assert.deepEqual([first, second].sort(), ["home", "profile"]);
|
||||
|
||||
// `/` finds the report's screens only.
|
||||
await page.keyboard.press("/");
|
||||
const find = page.getByRole("searchbox", { name: "Find screens" });
|
||||
await expect(find).toBeFocused();
|
||||
for (const query of ["channel", "start"]) {
|
||||
await find.fill(query);
|
||||
await expect(page.locator(".screens-find-empty")).toHaveText(`No screens match “${query}”`);
|
||||
await expect(cells).toHaveCount(0);
|
||||
}
|
||||
await find.fill("profile");
|
||||
await expect(cells).toHaveCount(1);
|
||||
await page.keyboard.press("Escape");
|
||||
await page.keyboard.press("Escape");
|
||||
|
||||
// So does the command palette's screen search.
|
||||
await page.keyboard.press("ControlOrMeta+KeyK");
|
||||
const palette = page.getByRole("dialog", { name: "Search Explore" });
|
||||
const box = palette.getByRole("combobox", { name: "Search screens and commands" });
|
||||
await expect(box).toBeFocused();
|
||||
await box.fill("/c/");
|
||||
await expect(palette.getByRole("option")).toHaveCount(0);
|
||||
await box.fill("/st");
|
||||
await expect(palette.getByRole("option")).toHaveCount(0);
|
||||
await box.fill("/pro");
|
||||
await expect(palette.getByRole("option")).toHaveText([/\/profile/]);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a link to an excluded route opens it in the Inspector, which says why it has no screenshot, on the Map and on Screens", { timeout: 60_000 }, async t => {
|
||||
const { page, errors } = await harness(t, await archive(omittedRoutesReport()), { app: true, query: "&screen=channel" });
|
||||
const detail = page.locator(".inspector .inspector-preview .screenshot-placeholder-detail");
|
||||
await expect(detail).toHaveText("Excluded by exploration.exclude; never captured");
|
||||
await expect(page.locator(".map-canvas .react-flow__node")).toHaveCount(2);
|
||||
await expect(page.locator(".map-canvas .react-flow__node.selected")).toHaveCount(0);
|
||||
// The same link on Screens, opened afresh: no card is picked, and the Inspector explains the route.
|
||||
await page.goto(page.url().replace("#/map/", "#/screens/"));
|
||||
await page.reload();
|
||||
await expect(page.locator(".screens-page .screens-cell")).toHaveCount(2);
|
||||
await expect(page.locator(".screens-cell .screen-screenshot-card.selected")).toHaveCount(0);
|
||||
await expect(detail).toHaveText("Excluded by exploration.exclude; never captured");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("unverified capture diagnostics stay separate from verified Needs review, and source changes nobody compared are not changes", async t => {
|
||||
const report = reportFixture();
|
||||
const home = report.review.surfaces[0];
|
||||
@@ -1507,10 +1847,11 @@ test("a recorded pull-request artifact opens its verified verdicts and every scr
|
||||
await expect(menu.getByText(route, { exact: true })).toBeVisible();
|
||||
}
|
||||
|
||||
// Its two redirect declarations (/ and /scan/select-photo) were never captured: they are not among its screens.
|
||||
await page.getByRole("button", { name: "Screens", exact: true }).click();
|
||||
const frames = page.locator(".screens-page .diff-frame");
|
||||
await expect(frames).toHaveCount(35);
|
||||
for (const [status, count] of [["modified", 3], ["added", 1], ["removed", 1], ["unchanged", 28], ["not-compared", 2]]) {
|
||||
await expect(frames).toHaveCount(33);
|
||||
for (const [status, count] of [["modified", 3], ["added", 1], ["removed", 1], ["unchanged", 28], ["not-compared", 0]]) {
|
||||
await expect(page.locator(`.screens-page .diff-frame.diff-${status}`)).toHaveCount(count);
|
||||
}
|
||||
const screenshots = page.locator(".screens-page img[data-screenshot-src]");
|
||||
@@ -1686,3 +2027,502 @@ test("a near-square landscape pair in a short window keeps both halves on screen
|
||||
}
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
/** A capture in a colour of its own, so every side of every screen is a screenshot of its own. */
|
||||
function tintedCapture(seed) {
|
||||
const picture = new PNG({ width: 32, height: 64 });
|
||||
for (let offset = 0; offset < picture.data.length; offset += 4) picture.data.set([(seed * 53) % 256, (seed * 101 + 40) % 256, (seed * 151 + 90) % 256, 255], offset);
|
||||
const bytes = PNG.sync.write(picture);
|
||||
const digest = createHash("sha256").update(bytes).digest("hex");
|
||||
return { bytes, sha256: digest, path: `assets/${digest}.png`, reference: `expo-explore-asset:${digest}.png`,
|
||||
record: { url: `https://artifact.expo-explore.invalid/${digest}.png`, sha256: digest, width: 32, height: 64 } };
|
||||
}
|
||||
|
||||
/**
|
||||
* `count` modified screens, screen-1 to screen-<count>, each with a Before and an After of its own. `seed` gives
|
||||
* another target its own captures. `screens[i]` holds screen-(i + 1)'s `before` and `after`. `sameAfter: { i: j }`
|
||||
* gives the screen at index i the After of the one at index j.
|
||||
*/
|
||||
async function changedScreensArchive(count, { seed = 1, runtime, sameAfter = {} } = {}) {
|
||||
const report = reportFixture();
|
||||
const home = report.review.surfaces[0];
|
||||
const route = id => ({ ...home.head, id, route: `/${id}`, path: `/${id}`, routeFile: `app/${id}.tsx`, logicalPath: `app/${id}.tsx` });
|
||||
const extra = [];
|
||||
const screens = [];
|
||||
report.assets = [];
|
||||
report.review.surfaces = Array.from({ length: count }, (_, index) => {
|
||||
const id = `screen-${index + 1}`;
|
||||
const before = tintedCapture(seed * 100 + index * 2);
|
||||
const after = sameAfter[index] !== undefined ? screens[sameAfter[index]].after : tintedCapture(seed * 100 + index * 2 + 1);
|
||||
screens.push({ id, before, after });
|
||||
for (const capture of [before, after]) {
|
||||
if (report.assets.some(asset => asset.sha256 === capture.sha256)) continue;
|
||||
report.assets.push({ sha256: capture.sha256, path: capture.path });
|
||||
extra.push({ name: capture.path, bytes: capture.bytes });
|
||||
}
|
||||
return { ...structuredClone(home), id, base: route(id), head: route(id),
|
||||
baseImage: { ...home.baseImage, ...before.record }, headImage: { ...home.headImage, ...after.record } };
|
||||
});
|
||||
const empty = { contract: "explore.navigation", edges: [], modalSurfaceIds: [], unresolved: [] };
|
||||
report.review.navigation = { base: structuredClone(empty), head: empty };
|
||||
if (runtime) report.review.runtime = { ...report.review.runtime, ...runtime };
|
||||
return { bytes: await archive(report, extra), screens };
|
||||
}
|
||||
|
||||
/** Records each screenshot request (reference, priority, when) and release on the page's report archives. */
|
||||
async function recordScreenshotReads(page) {
|
||||
await page.evaluate(async () => {
|
||||
const { ArtifactReportArchive } = await import("/src/utils/artifact-report.ts");
|
||||
window.reads = [];
|
||||
window.releases = [];
|
||||
const { resolve, release } = ArtifactReportArchive.prototype;
|
||||
ArtifactReportArchive.prototype.resolve = function (reference, priority) {
|
||||
window.reads.push({ reference, priority: priority ?? "lazy", at: performance.now() });
|
||||
return resolve.call(this, reference, priority);
|
||||
};
|
||||
ArtifactReportArchive.prototype.release = function (reference) {
|
||||
window.releases.push({ reference, at: performance.now() });
|
||||
return release.call(this, reference);
|
||||
};
|
||||
});
|
||||
}
|
||||
|
||||
/** How many uses of each screenshot the shown report counts, by reference. */
|
||||
const screenshotUses = page => page.evaluate(async () => {
|
||||
const { activeArtifactReport } = await import("/src/utils/artifact-report.ts");
|
||||
return Object.fromEntries([...activeArtifactReport.loads.values()].map(load => [`expo-explore-asset:${load.sha256}.png`, load.users]));
|
||||
});
|
||||
|
||||
/** How many mounted images show each screenshot, by reference. */
|
||||
const mountedScreenshots = page => page.evaluate(() => {
|
||||
const counts = {};
|
||||
for (const image of document.querySelectorAll("img[data-screenshot-src]")) counts[image.dataset.screenshotSrc] = (counts[image.dataset.screenshotSrc] ?? 0) + 1;
|
||||
return counts;
|
||||
});
|
||||
|
||||
/** Every use the report counts belongs to an image on the page; nothing else holds a screenshot. */
|
||||
async function expectBalancedUses(page, message) {
|
||||
await expect.poll(async () => {
|
||||
const uses = await screenshotUses(page);
|
||||
const mounted = await mountedScreenshots(page);
|
||||
return Object.entries(uses).filter(([reference, users]) => users > (mounted[reference] ?? 0));
|
||||
}, { message }).toEqual([]);
|
||||
}
|
||||
|
||||
test("Compare reads the next screen's screenshots once it rests on a screen, never while an arrow is held, and they are released when it moves on", { timeout: 90_000 }, async t => {
|
||||
const { bytes, screens } = await changedScreensArchive(9);
|
||||
const { page, errors } = await harness(t, bytes, { app: true, open: false, query: "&view=compare&screen=screen-1" });
|
||||
await recordScreenshotReads(page);
|
||||
await chooseFile(page, bytes);
|
||||
const compare = page.locator(".compare-section");
|
||||
await expect(compare.locator(".compare-frame img")).toHaveCount(2);
|
||||
for (const image of await compare.locator(".compare-frame img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
const position = compare.locator(".compare-nav-position");
|
||||
await expect(position).toHaveText(/^1 of 9$/);
|
||||
const shownAt = await page.evaluate(() => Math.min(...window.reads.filter(read => read.priority === "eager").map(read => read.at)));
|
||||
|
||||
// Resting on screen-1, its neighbour in the direction of travel (screen-2) is read, after the settle delay, as a
|
||||
// prefetch that leaves the next step's slots free.
|
||||
const prefetchesOf = screen => page.evaluate(references => window.reads.filter(read => read.priority === "prefetch" && references.includes(read.reference)),
|
||||
[screen.before.reference, screen.after.reference]);
|
||||
await expect.poll(async () => (await prefetchesOf(screens[1])).length).toBe(2);
|
||||
assert.ok((await prefetchesOf(screens[1]))[0].at - shownAt >= 240, "Nothing is read before Compare rests on the screen");
|
||||
assert.equal((await page.evaluate(() => window.reads.filter(read => read.priority === "prefetch"))).length, 2, "Only the neighbour is read");
|
||||
await expect.poll(() => screenshotUses(page)).toMatchObject({ [screens[1].before.reference]: 1, [screens[1].after.reference]: 1 });
|
||||
|
||||
// The step finds its pictures decoded: nothing new is decoded for them.
|
||||
await expect.poll(() => page.evaluate(() => window.createdUrls.length)).toBe(4);
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(position).toHaveText(/^2 of 9$/);
|
||||
for (const image of await compare.locator(".compare-frame img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
assert.equal(await page.evaluate(() => window.createdUrls.length), 4, "The prefetched screenshots were shown without a new decode");
|
||||
|
||||
// A held arrow steps past several screens; nothing is read for a neighbour until it is released.
|
||||
await expect.poll(async () => (await prefetchesOf(screens[2])).length).toBe(2);
|
||||
const downAt = await page.evaluate(() => performance.now());
|
||||
await page.keyboard.down("ArrowRight");
|
||||
await expect.poll(async () => Number((await position.textContent()).split(" ")[0]), { timeout: 4000 }).toBeGreaterThanOrEqual(6);
|
||||
// The stage is marked while the key repeats, so the screenshots it passes appear without a fade.
|
||||
await expect(compare.locator(".compare-stage")).toHaveAttribute("data-screenshot-instant", "");
|
||||
await page.waitForTimeout(150);
|
||||
const upAt = await page.evaluate(() => performance.now());
|
||||
await page.keyboard.up("ArrowRight");
|
||||
await expect(compare.locator(".compare-stage")).not.toHaveAttribute("data-screenshot-instant", /.*/);
|
||||
const heldPrefetches = await page.evaluate(({ downAt, upAt }) => window.reads.filter(read => read.priority === "prefetch" && read.at > downAt && read.at <= upAt), { downAt, upAt });
|
||||
assert.deepEqual(heldPrefetches, [], "No neighbour was read while the arrow was held");
|
||||
const landed = Number((await position.textContent()).split(" ")[0]);
|
||||
const next = screens[landed];
|
||||
if (next) await expect.poll(async () => (await prefetchesOf(next)).length).toBe(2);
|
||||
|
||||
// Leaving Compare lets go of every screenshot it, and its prefetch, held.
|
||||
await page.getByRole("group", { name: "Canvas view" }).getByRole("button", { name: "Screens", exact: true }).click();
|
||||
await expect(page.locator(".screens-page")).toBeVisible();
|
||||
await expect(compare).toHaveCount(0);
|
||||
await expectBalancedUses(page, "Every use left after Compare belongs to an image on Screens");
|
||||
const uses = await screenshotUses(page);
|
||||
for (const screen of screens) assert.equal(uses[screen.before.reference] ?? 0, 0, `${screen.id}'s Before is no longer in use`);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a prefetch never holds a slot the screen the reviewer steps to needs, whichever way the step goes", { timeout: 20_000 }, async t => {
|
||||
const { page, errors } = await harness(t);
|
||||
const { bytes, shas } = await multiImageArchive(8);
|
||||
const result = await page.evaluate(async ({ bytes, identity, shas, probe }) => {
|
||||
const archive = await window.openReport(bytes, identity);
|
||||
const decodes = new Function(`return (${probe})()`)();
|
||||
const [shown, shownToo, ahead, aheadToo, behind, behindToo, later, laterToo] = shas.map(sha => archive.reference(sha));
|
||||
const settle = () => new Promise(resolve => setTimeout(resolve, 30));
|
||||
// The screen on show is still being read when Compare rests on it: its neighbour's prefetches wait.
|
||||
const visible = [archive.resolve(shown, "eager"), archive.resolve(shownToo, "eager")];
|
||||
await decodes.until(() => decodes.held() === 2);
|
||||
const waited = [archive.resolve(ahead, "prefetch"), archive.resolve(aheadToo, "prefetch")].map(read => read.then(() => "read", error => error.message));
|
||||
await settle();
|
||||
const heldWhileShownReads = decodes.held();
|
||||
// The reviewer steps the other way before they start: they are dropped, unread.
|
||||
archive.release(ahead);
|
||||
archive.release(aheadToo);
|
||||
const stepped = [archive.resolve(behind, "eager"), archive.resolve(behindToo, "eager")];
|
||||
await decodes.until(() => decodes.held() === 4);
|
||||
decodes.all();
|
||||
await Promise.all([...visible, ...stepped]);
|
||||
const dropped = await Promise.all(waited);
|
||||
|
||||
// Resting on that screen, its own neighbour's prefetches start, in the slots its reads have finished with.
|
||||
const running = [archive.resolve(later, "prefetch"), archive.resolve(laterToo, "prefetch")];
|
||||
await decodes.until(() => decodes.held() === 2);
|
||||
// The reviewer steps the other way while they run: they keep their slots, and the screen stepped to starts at once.
|
||||
archive.release(later);
|
||||
archive.release(laterToo);
|
||||
archive.release(shown);
|
||||
archive.release(shownToo);
|
||||
const back = [archive.resolve(shown, "eager"), archive.resolve(shownToo, "eager")];
|
||||
await settle();
|
||||
const heldAfterStep = decodes.held();
|
||||
decodes.all();
|
||||
await Promise.all([...running, ...back]);
|
||||
return { heldWhileShownReads, dropped, heldAfterStep, hashed: decodes.hashed() };
|
||||
}, { bytes, identity, shas, probe: decodeProbe.toString() });
|
||||
assert.equal(result.heldWhileShownReads, 2, "The prefetches waited while the shown screen was still being read");
|
||||
assert.deepEqual(result.dropped, ["This screenshot is no longer in use.", "This screenshot is no longer in use."]);
|
||||
assert.ok(!result.hashed.includes(shas[2]) && !result.hashed.includes(shas[3]), "A prefetch let go before it started was never read");
|
||||
assert.equal(result.heldAfterStep, 2, "The screen stepped to was read at once, beside the running prefetches");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("Flip reads a screen's Before only once its After has loaded, and flipping reads nothing new", { timeout: 90_000 }, async t => {
|
||||
const { bytes, screens } = await changedScreensArchive(4);
|
||||
const { page, errors } = await harness(t, bytes, { app: true, open: false, query: "&view=compare&screen=screen-1" });
|
||||
await page.addInitScript(() => localStorage.setItem("expo-explore:compare-mode", "flip"));
|
||||
await page.reload();
|
||||
await recordScreenshotReads(page);
|
||||
await chooseFile(page, bytes);
|
||||
const frame = page.locator(".compare-section .compare-flip-frame");
|
||||
await expect(frame.locator(".compare-flip-layer")).toHaveCount(2);
|
||||
for (const image of await frame.locator("img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
// The side off screen is hidden, its spinner with it.
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='before']")).toHaveAttribute("aria-hidden", "true");
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='before']")).toHaveCSS("visibility", "hidden");
|
||||
|
||||
// The next screen's After is held back: its Before is not read meanwhile, and only After's layer is mounted.
|
||||
await page.evaluate(after => {
|
||||
const digest = crypto.subtle.digest.bind(crypto.subtle);
|
||||
const hex = buffer => Array.from(new Uint8Array(buffer), byte => byte.toString(16).padStart(2, "0")).join("");
|
||||
window.heldAfter = [];
|
||||
crypto.subtle.digest = async (algorithm, data) => {
|
||||
const value = await digest(algorithm, data);
|
||||
if (hex(value) === after) await new Promise(resolve => window.heldAfter.push(resolve));
|
||||
return value;
|
||||
};
|
||||
}, screens[1].after.sha256);
|
||||
const readsOf = reference => page.evaluate(reference => window.reads.filter(read => read.reference === reference && read.priority !== "prefetch").length, reference);
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(page.locator(".compare-section .compare-nav-position")).toHaveText(/^2 of 4$/);
|
||||
await expect(frame.locator(".compare-flip-layer")).toHaveCount(1);
|
||||
await page.waitForTimeout(150);
|
||||
assert.equal(await readsOf(screens[1].before.reference), 0, "Before is not read while After loads");
|
||||
await page.evaluate(() => window.heldAfter.splice(0).forEach(release => release()));
|
||||
await expect(frame.locator(".compare-flip-layer")).toHaveCount(2);
|
||||
for (const image of await frame.locator("img").all()) await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
// StrictMode mounts each image's lease twice in development.
|
||||
assert.ok(await readsOf(screens[1].before.reference) > 0, "Before is read once After has loaded");
|
||||
|
||||
// Flipping swaps the two decoded sides at once.
|
||||
const reads = await page.evaluate(() => window.reads.length);
|
||||
await page.keyboard.press("KeyX");
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='before']")).not.toHaveAttribute("aria-hidden", /.*/);
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='after']")).toHaveCSS("visibility", "hidden");
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='before'] img")).toHaveCSS("opacity", "1");
|
||||
await page.keyboard.press("KeyX");
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='after']")).not.toHaveAttribute("aria-hidden", /.*/);
|
||||
assert.equal(await page.evaluate(() => window.reads.length), reads, "A flip reads nothing");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a Map card's backing draws the frame its screenshot waits and fades in over, and steps aside for No screenshot", { timeout: 60_000 }, async t => {
|
||||
const { page, errors } = await harness(t, await archive(), { app: true, fault: holdScreenshotHashes() });
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
const slot = page.locator(".map-canvas .screen-node-image").first();
|
||||
const image = slot.locator("img[data-screenshot-src]");
|
||||
const backing = slot.locator(".screenshot-backing");
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "loading");
|
||||
await expect(image).toHaveCSS("opacity", "0");
|
||||
await expect(backing).toHaveCSS("visibility", "visible");
|
||||
const frames = () => slot.evaluate(element => {
|
||||
const box = node => { const { left, top, width, height } = node.getBoundingClientRect(); return [left, top, width, height].map(value => Math.round(value * 10) / 10); };
|
||||
const style = node => { const { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow } = getComputedStyle(node); return { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow }; };
|
||||
const [img, backing] = [element.querySelector("img"), element.querySelector(".screenshot-backing")];
|
||||
return { image: box(img), backing: box(backing), imageStyle: style(img), backingStyle: style(backing) };
|
||||
});
|
||||
// The link selects Home, so the frame carries the selection ring past the Modified status.
|
||||
await expect(page.locator(".map-canvas .react-flow__node-screen.selected")).toHaveCount(1);
|
||||
// The ring follows the canvas zoom, and the backing's ring eases to it as the opening camera settles.
|
||||
await expect.poll(async () => { const { backingStyle, imageStyle } = await frames(); return backingStyle.boxShadow === imageStyle.boxShadow; }).toBe(true);
|
||||
const waiting = await frames();
|
||||
assert.deepEqual(waiting.backing, waiting.image, "The backing sits exactly where the image does");
|
||||
assert.deepEqual(waiting.backingStyle, waiting.imageStyle, "and draws the same frame: fill, border, radius, status and ring");
|
||||
assert.match(waiting.backingStyle.boxShadow, /rgb\(5, 136, 240\)/);
|
||||
|
||||
await page.evaluate(() => window.releaseScreenshotHashes());
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
|
||||
assert.deepEqual((await frames()).image, waiting.image, "Loading moved nothing");
|
||||
// Once the picture has faded in, the backing hides.
|
||||
await expect(backing).toHaveCSS("visibility", "hidden");
|
||||
await expect(image).toHaveCSS("opacity", "1");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a Map card whose screenshot cannot be read shows No screenshot in one frame, its backing hidden", async t => {
|
||||
const damaged = Buffer.from(png);
|
||||
damaged[damaged.length - 1] ^= 1;
|
||||
const { page, errors } = await harness(t, await archive(reportFixture(), [], damaged), { app: true });
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
const slot = page.locator(".map-canvas .screen-node-image").first();
|
||||
await expect(slot.locator(".image-placeholder")).toHaveText("No screenshot");
|
||||
await expect(slot.locator(".screenshot-backing")).toHaveCSS("visibility", "hidden");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("on a phone, a Screens card's screenshot keeps its height while it loads and once it has", { timeout: 60_000 }, async t => {
|
||||
const { bytes } = await changedScreensArchive(2);
|
||||
const { page, errors } = await harness(t, bytes, { app: true, open: false, fault: holdScreenshotHashes(tintedCapture(100).bytes.length) });
|
||||
await page.setViewportSize({ width: 390, height: 844 });
|
||||
await chooseFile(page, bytes);
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
await page.goto(`${page.url().split("#")[0]}#/screens`);
|
||||
const slot = page.locator(".screens-cell .screen-node-image.has-screenshot").first();
|
||||
await expect(slot).toBeVisible();
|
||||
const height = () => slot.evaluate(element => [element.getBoundingClientRect().height, element.querySelector("img").getBoundingClientRect().height]);
|
||||
const [waiting, waitingImage] = await height();
|
||||
assert.ok(waiting > 100 && Math.abs(waiting - waitingImage) < 1, `The waiting screenshot holds the slot open: ${waiting}, ${waitingImage}`);
|
||||
// The image is the frame here, and hidden while it loads: its backing draws the same frame in its place.
|
||||
await expect(slot.locator("img")).toHaveCSS("opacity", "0");
|
||||
const backing = slot.locator(".screenshot-backing");
|
||||
await expect(backing).toHaveCSS("visibility", "visible");
|
||||
const frames = await slot.evaluate(element => {
|
||||
const box = node => { const { left, top, width, height } = node.getBoundingClientRect(); return [left, top, width, height].map(value => Math.round(value)); };
|
||||
const style = node => { const { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow } = getComputedStyle(node); return { borderTopColor, borderTopWidth, borderTopLeftRadius, backgroundColor, boxShadow }; };
|
||||
const [img, backing] = [element.querySelector("img"), element.querySelector(".screenshot-backing")];
|
||||
return { image: box(img), backing: box(backing), imageStyle: style(img), backingStyle: style(backing) };
|
||||
});
|
||||
assert.deepEqual(frames.backing, frames.image);
|
||||
assert.deepEqual(frames.backingStyle, frames.imageStyle, "The backing draws the image's frame: border, fill, radius, status and ring");
|
||||
assert.notEqual(frames.backingStyle.backgroundColor, "rgba(0, 0, 0, 0)");
|
||||
// Selected, the backing carries the image's ring while the screenshot still loads (a changed screen's is its status).
|
||||
await page.goto(`${page.url().split("#")[0]}#/screens?screen=screen-1`);
|
||||
const selected = page.locator(".screens-cell .screen-screenshot-card.selected .screen-node-image");
|
||||
await expect(selected.locator("img")).toHaveAttribute("data-screenshot-state", "loading");
|
||||
const rings = await selected.evaluate(element => [element.querySelector("img"), element.querySelector(".screenshot-backing")]
|
||||
.map(node => getComputedStyle(node).boxShadow));
|
||||
assert.equal(rings[1], rings[0]);
|
||||
assert.notEqual(rings[1], "none");
|
||||
await page.evaluate(() => window.releaseScreenshotHashes());
|
||||
await expect(slot.locator("img")).toHaveAttribute("data-screenshot-state", "ready");
|
||||
assert.deepEqual(await height(), [waiting, waitingImage]);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a target switch blanks every card whose screenshot differs, never showing the other target's picture, and switching back reuses the kept pictures", { timeout: 90_000 }, async t => {
|
||||
const runtime = { platform: "android", platforms: ["ios", "android"] };
|
||||
const android = await changedScreensArchive(3, { seed: 1, runtime });
|
||||
const ios = await changedScreensArchive(3, { seed: 2, runtime: { ...runtime, platform: "ios" } });
|
||||
const preview = { token: "pqrstuvwxyz234567234567234567234", listing: [{ platform: "ios" }, { platform: "android" }],
|
||||
archives: { "?platform=ios": ios.bytes } };
|
||||
const { page, errors } = await harness(t, android.bytes, { app: true, reportIdentity: null, preview, query: "&platform=android" });
|
||||
await expect(page.locator(".app-shell")).toBeVisible();
|
||||
const cards = page.locator(".map-canvas img[data-screenshot-src]");
|
||||
await expect(cards).toHaveCount(3);
|
||||
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "ready");
|
||||
const shown = await cards.evaluateAll(images => Object.fromEntries(images.map(image => [image.getAttribute("src"), image.dataset.screenshotSrc])));
|
||||
// Hold iOS's screenshots back so the switch is caught while they load.
|
||||
await page.evaluate(sizes => {
|
||||
const digest = crypto.subtle.digest.bind(crypto.subtle);
|
||||
window.heldIos = [];
|
||||
window.releaseIos = () => window.heldIos.splice(0).forEach(release => release());
|
||||
window.holdIos = true;
|
||||
crypto.subtle.digest = (algorithm, data) => window.holdIos && sizes.includes(data.byteLength)
|
||||
? new Promise(resolve => window.heldIos.push(() => resolve(digest(algorithm, data)))) : digest(algorithm, data);
|
||||
}, ios.screens.flatMap(screen => [screen.before.bytes.length, screen.after.bytes.length]));
|
||||
// Every frame from the switch on: no card shows a picture under another screenshot's name, and a waiting one is hidden.
|
||||
await page.evaluate(shown => {
|
||||
window.staleFrames = [];
|
||||
window.sampling = true;
|
||||
const sample = () => {
|
||||
for (const image of document.querySelectorAll(".map-canvas img[data-screenshot-src]")) {
|
||||
const source = shown[image.getAttribute("src")];
|
||||
const opacity = Number(getComputedStyle(image).opacity);
|
||||
if (source && source !== image.dataset.screenshotSrc && opacity > 0) window.staleFrames.push({ source, named: image.dataset.screenshotSrc, opacity });
|
||||
if (image.dataset.screenshotState === "loading" && opacity > 0) window.staleFrames.push({ waiting: image.dataset.screenshotSrc, opacity });
|
||||
}
|
||||
if (window.sampling) requestAnimationFrame(sample);
|
||||
};
|
||||
requestAnimationFrame(sample);
|
||||
}, shown);
|
||||
await page.getByRole("button", { name: "Platform: Android. Open another platform's report" }).click();
|
||||
await page.getByRole("menu", { name: "Platform" }).getByRole("menuitemradio").nth(0).click();
|
||||
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "ios");
|
||||
await expect(cards.first()).toHaveAttribute("data-screenshot-src", ios.screens[0].after.reference);
|
||||
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "loading");
|
||||
await page.waitForTimeout(200);
|
||||
await page.evaluate(() => { window.holdIos = false; window.releaseIos(); });
|
||||
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await page.evaluate(() => { window.sampling = false; });
|
||||
assert.deepEqual(await page.evaluate(() => window.staleFrames), [], "No frame showed Android's picture on iOS's cards, or a waiting picture");
|
||||
await expectBalancedUses(page, "After the switch, the iOS report counts only the cards' uses");
|
||||
|
||||
// Back to Android: its kept pictures come back without a new decode.
|
||||
const created = await page.evaluate(() => window.createdUrls.length);
|
||||
await page.goBack();
|
||||
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "android");
|
||||
for (const card of await cards.all()) await expect(card).toHaveAttribute("data-screenshot-state", "ready");
|
||||
const back = await cards.evaluateAll(images => Object.fromEntries(images.map(image => [image.getAttribute("src"), image.dataset.screenshotSrc])));
|
||||
assert.deepEqual(back, shown, "Android's cards show the Blob URLs they showed before");
|
||||
assert.equal(await page.evaluate(() => window.createdUrls.length), created, "nothing was decoded again");
|
||||
await expectBalancedUses(page, "After switching back, the Android report counts only the cards' uses");
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a prefetch the reviewer steps onto starts at once when a slot is free, instead of waiting for a running read", { timeout: 20_000 }, async t => {
|
||||
const { page, errors } = await harness(t);
|
||||
const { bytes, shas } = await multiImageArchive(4);
|
||||
const result = await page.evaluate(async ({ bytes, identity, shas, probe }) => {
|
||||
const archive = await window.openReport(bytes, identity);
|
||||
const decodes = new Function(`return (${probe})()`)();
|
||||
const [shown, shownToo, next, nextToo] = shas.map(sha => archive.reference(sha));
|
||||
// The screen on show is still being read after the rest: the next screen's prefetches wait behind the reserve.
|
||||
const visible = [archive.resolve(shown, "eager"), archive.resolve(shownToo, "eager")];
|
||||
await decodes.until(() => decodes.held() === 2);
|
||||
const prefetched = [archive.resolve(next, "prefetch"), archive.resolve(nextToo, "prefetch")];
|
||||
await new Promise(resolve => setTimeout(resolve, 30));
|
||||
const heldBeforeStep = decodes.held();
|
||||
// The reviewer steps onto that screen: its reads start in the two free slots, beside the running ones.
|
||||
const stepped = [archive.resolve(next, "eager"), archive.resolve(nextToo, "eager")];
|
||||
await new Promise(resolve => setTimeout(resolve, 30));
|
||||
const heldAfterStep = decodes.held();
|
||||
decodes.all();
|
||||
await Promise.all([...visible, ...prefetched, ...stepped]);
|
||||
return { heldBeforeStep, heldAfterStep, shared: await prefetched[0] === await stepped[0] };
|
||||
}, { bytes, identity, shas, probe: decodeProbe.toString() });
|
||||
assert.equal(result.heldBeforeStep, 2, "The prefetches waited behind the reserve");
|
||||
assert.equal(result.heldAfterStep, 4, "Stepped onto, they started at once");
|
||||
assert.equal(result.shared, true);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("a prefetch read that never finishes does not stop Compare reading the next screens ahead", { timeout: 90_000 }, async t => {
|
||||
const { bytes, screens } = await changedScreensArchive(5);
|
||||
const { page, errors } = await harness(t, bytes, { app: true, open: false, query: "&view=compare&screen=screen-1" });
|
||||
await recordScreenshotReads(page);
|
||||
// Screen-2's Before never finishes verifying.
|
||||
await page.evaluate(stuck => {
|
||||
const digest = crypto.subtle.digest.bind(crypto.subtle);
|
||||
const hex = buffer => Array.from(new Uint8Array(buffer), byte => byte.toString(16).padStart(2, "0")).join("");
|
||||
crypto.subtle.digest = async (algorithm, data) => {
|
||||
const value = await digest(algorithm, data);
|
||||
if (hex(value) === stuck) await new Promise(() => {});
|
||||
return value;
|
||||
};
|
||||
}, screens[1].before.sha256);
|
||||
await chooseFile(page, bytes);
|
||||
const compare = page.locator(".compare-section");
|
||||
await expect(compare.locator(".compare-frame img[data-screenshot-state='ready']")).toHaveCount(2);
|
||||
const prefetchesOf = screen => page.evaluate(references => window.reads.filter(read => read.priority === "prefetch" && references.includes(read.reference)).length,
|
||||
[screen.before.reference, screen.after.reference]);
|
||||
await expect.poll(() => prefetchesOf(screens[1])).toBe(2);
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(compare.locator(".compare-nav-position")).toHaveText(/^2 of 5$/);
|
||||
await expect.poll(() => prefetchesOf(screens[2])).toBe(2);
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(compare.locator(".compare-nav-position")).toHaveText(/^3 of 5$/);
|
||||
await expect.poll(() => prefetchesOf(screens[3])).toBe(2);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
/** Opens Compare in Flip at `screen`, recording screenshot reads. */
|
||||
async function openFlip(t, bytes, screen) {
|
||||
const opened = await harness(t, bytes, { app: true, open: false, query: `&view=compare&screen=${screen}` });
|
||||
await opened.page.addInitScript(() => localStorage.setItem("expo-explore:compare-mode", "flip"));
|
||||
await opened.page.reload();
|
||||
await recordScreenshotReads(opened.page);
|
||||
return opened;
|
||||
}
|
||||
|
||||
/** Holds back verifying the screenshot with this hash until `window.releaseHeld()`. */
|
||||
const holdScreenshot = (page, sha256) => page.evaluate(held => {
|
||||
const digest = crypto.subtle.digest.bind(crypto.subtle);
|
||||
const hex = buffer => Array.from(new Uint8Array(buffer), byte => byte.toString(16).padStart(2, "0")).join("");
|
||||
const waiting = [];
|
||||
window.releaseHeld = () => waiting.splice(0).forEach(release => release());
|
||||
crypto.subtle.digest = async (algorithm, data) => {
|
||||
const value = await digest(algorithm, data);
|
||||
if (hex(value) === held) await new Promise(resolve => waiting.push(resolve));
|
||||
return value;
|
||||
};
|
||||
}, sha256);
|
||||
|
||||
test("Flip reads the next screen's Before when a step keeps the After it shows, which fires no load", { timeout: 90_000 }, async t => {
|
||||
// Screen-2 keeps screen-1's After beside a Before of its own.
|
||||
const { bytes, screens } = await changedScreensArchive(3, { sameAfter: { 1: 0 } });
|
||||
const { page, errors } = await openFlip(t, bytes, "screen-1");
|
||||
await chooseFile(page, bytes);
|
||||
const frame = page.locator(".compare-section .compare-flip-frame");
|
||||
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect(page.locator(".compare-section .compare-nav-position")).toHaveText(/^2 of 3$/);
|
||||
await expect(frame.locator(".compare-flip-layer[data-side='before'] img")).toHaveAttribute("data-screenshot-src", screens[1].before.reference);
|
||||
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("Flip stepped from Before shows the next screen's After from its first frame and reads its Before only once After is ready", { timeout: 90_000 }, async t => {
|
||||
const { bytes, screens } = await changedScreensArchive(3);
|
||||
const { page, errors } = await openFlip(t, bytes, "screen-1");
|
||||
await chooseFile(page, bytes);
|
||||
const frame = page.locator(".compare-section .compare-flip-frame");
|
||||
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
|
||||
await page.keyboard.press("KeyX");
|
||||
await expect(frame).toHaveAttribute("data-side", "before");
|
||||
await holdScreenshot(page, screens[1].after.sha256);
|
||||
// Every frame from the step: which side the frame shows, and which layers are mounted.
|
||||
await page.evaluate(() => {
|
||||
window.flipFrames = [];
|
||||
const sample = () => {
|
||||
const element = document.querySelector(".compare-flip-frame");
|
||||
window.flipFrames.push({ route: document.querySelector(".compare-nav-route")?.textContent, side: element?.dataset.side,
|
||||
layers: [...(element?.querySelectorAll(".compare-flip-layer") ?? [])].map(layer => layer.dataset.side).join(",") });
|
||||
if (window.flipFrames.length < 20) requestAnimationFrame(sample);
|
||||
};
|
||||
requestAnimationFrame(sample);
|
||||
});
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect.poll(() => page.evaluate(() => window.flipFrames.length)).toBe(20);
|
||||
const stepped = (await page.evaluate(() => window.flipFrames)).filter(sample => sample.route === "/screen-2");
|
||||
assert.ok(stepped.length > 0);
|
||||
assert.deepEqual([...new Set(stepped.map(sample => `${sample.side}:${sample.layers}`))], ["after:after"],
|
||||
"From its first frame screen-2 shows After alone");
|
||||
const readsOf = reference => page.evaluate(reference => window.reads.filter(read => read.reference === reference && read.priority !== "prefetch").length, reference);
|
||||
assert.equal(await readsOf(screens[1].before.reference), 0, "Before waits for After");
|
||||
await page.evaluate(() => window.releaseHeld());
|
||||
await expect(frame.locator(".compare-flip-layer img[data-screenshot-state='ready']")).toHaveCount(2);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
@@ -188,12 +188,11 @@ test("Map keeps selected elevated arrows behind screenshots without rendering na
|
||||
await expect(sourceHitArea.locator("title")).toHaveText("Source navigation\npush · app/home.tsx");
|
||||
await page.mouse.move(1320, 30);
|
||||
const dimmedComparisons = [];
|
||||
for (const presentation of ["muted", "selection"]) {
|
||||
// Only the Changes filter dims a screen; a selection fades nothing.
|
||||
for (const presentation of ["muted"]) {
|
||||
await page.evaluate(mode => {
|
||||
const profile = document.querySelector('.react-flow__node[data-id="profile"]');
|
||||
const canvas = document.querySelector(".map-canvas");
|
||||
profile.classList.toggle("graph-node-muted", mode === "muted");
|
||||
canvas.classList.toggle("screen-selection-active", mode === "selection");
|
||||
}, presentation);
|
||||
const dimmedWithArrows = await profileImage.screenshot({ animations: "disabled" });
|
||||
await page.locator(".map-surface .react-flow__edges").evaluate(node => { node.style.visibility = "hidden"; });
|
||||
@@ -216,7 +215,6 @@ test("Map keeps selected elevated arrows behind screenshots without rendering na
|
||||
}
|
||||
await page.evaluate(() => {
|
||||
document.querySelector('.react-flow__node[data-id="profile"]').classList.remove("graph-node-muted");
|
||||
document.querySelector(".map-canvas").classList.remove("screen-selection-active");
|
||||
});
|
||||
await page.getByRole("button", { name: "Open Profile", exact: true }).click();
|
||||
assert.equal(await page.evaluate(() => window.selectedScreen), "profile");
|
||||
|
||||
@@ -155,7 +155,7 @@ test("Compare steps through changed screens and their changed areas", { timeout:
|
||||
|
||||
// A changed screen opens the same review in the Inspector on every canvas: Compare at sidebar
|
||||
// size. CI compares the images pixel for pixel, so /games's four CI regions read as changed
|
||||
// areas, outlined at the same place on both sides.
|
||||
// areas, outlined on After; Before keeps the same outlines unseen until one is hovered on After.
|
||||
await openChangedScreen(page, /, Modified, \/games$/);
|
||||
const inspector = page.locator(".right-panel");
|
||||
const review = inspector.getByRole("region", { name: "Changes in /games" });
|
||||
@@ -166,6 +166,8 @@ test("Compare steps through changed screens and their changed areas", { timeout:
|
||||
await expect.poll(() => outlineCount("after")).toBeGreaterThan(0);
|
||||
const areas = await outlineCount("after");
|
||||
assert.equal(await outlineCount("before"), areas);
|
||||
await expect(review.locator('[data-side="after"] .visual-change-outlines')).toHaveClass(/linked/);
|
||||
await expect(review.locator('[data-side="before"] .visual-change-outlines')).toHaveClass(/ghost/);
|
||||
// Esc closes the Inspector; the selection stays, a second Esc clears it.
|
||||
const selected = page.locator(".map-canvas .react-flow__node-screen.selected");
|
||||
await page.keyboard.press("Escape");
|
||||
@@ -225,6 +227,12 @@ test("Compare steps through changed screens and their changed areas", { timeout:
|
||||
await expect.poll(() => compare.locator(`[data-side="${side}"] img`).first()
|
||||
.evaluate(image => image.naturalWidth)).toBe(402);
|
||||
}
|
||||
// Hovering an outline on After lights the same area on Before, and only that one.
|
||||
await compare.locator('[data-side="after"] .visual-change-outline').nth(1).hover();
|
||||
await expect(compare.locator('[data-side="before"] .visual-change-outline.hovered')).toHaveCount(1);
|
||||
await expect(compare.locator('[data-side="before"] .visual-change-outline').nth(1)).toHaveClass(/hovered/);
|
||||
await page.mouse.move(0, 0);
|
||||
await expect(compare.locator(".visual-change-outline.hovered")).toHaveCount(0);
|
||||
|
||||
// J and K step through the changed areas; Esc clears the highlight.
|
||||
const outlines = compare.locator('[data-side="after"] .visual-change-outline');
|
||||
@@ -234,6 +242,14 @@ test("Compare steps through changed screens and their changed areas", { timeout:
|
||||
await expect(outlines.nth(1)).toHaveClass(/active/);
|
||||
await page.keyboard.press("k");
|
||||
await expect(outlines.nth(0)).toHaveClass(/active/);
|
||||
// Esc in the bottom bar's More menu closes the menu and only the menu.
|
||||
const more = page.getByRole("button", { name: "More", exact: true });
|
||||
await more.click();
|
||||
await expect(page.getByRole("menu", { name: "More" })).toBeVisible();
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(page.getByRole("menu", { name: "More" })).toHaveCount(0);
|
||||
await expect(more).toBeFocused();
|
||||
await expect(outlines.nth(0)).toHaveClass(/active/);
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(compare.locator(".visual-change-outline.active")).toHaveCount(0);
|
||||
|
||||
@@ -302,7 +318,7 @@ test("Compare steps through changed screens and their changed areas", { timeout:
|
||||
/** The Inspector's one frame for a screen outside the review, and its Swipe frame for a changed one, in this viewport. */
|
||||
async function inspectorFrames(page, url) {
|
||||
const games = "expo-tabs-games-index-2c6605360b11";
|
||||
const index = "expo-index-02872ff9f2ca";
|
||||
const unchanged = "expo-tabs-scan-index-2bbf42237cc6";
|
||||
const open = async id => {
|
||||
await page.goto(`${url}#/screens`);
|
||||
const all = page.getByRole("button", { name: /^All/ }).first();
|
||||
@@ -317,14 +333,14 @@ async function inspectorFrames(page, url) {
|
||||
const swipeImage = page.locator(".sidebar-review-stage img").first();
|
||||
await expect(swipeImage).toBeVisible();
|
||||
const changed = await swipeImage.boundingBox();
|
||||
await open(index);
|
||||
await open(unchanged);
|
||||
const single = page.locator(".sidebar-review-off .variant-preview");
|
||||
await expect(single).toBeVisible();
|
||||
return { changed, single: await single.boundingBox() };
|
||||
}
|
||||
|
||||
test("the Inspector frames an unchanged screen at the size of a changed screen's Swipe frame", { timeout: 90_000 }, async t => {
|
||||
// / is unchanged (not compared); /games is modified. The single frame used to take at most half the panel, the
|
||||
// /scan is unchanged; /games is modified. The single frame used to take at most half the panel, the
|
||||
// width of one frame of a Before/After pair, while Swipe and Flip fill the panel up to 70 % (phone: 52 %) of the window.
|
||||
for (const viewport of [{ width: 1024, height: 820 }, { width: 390, height: 844 }]) {
|
||||
const { page, url, errors } = await openReport(t, viewport);
|
||||
|
||||
@@ -48,6 +48,8 @@ const entry = `
|
||||
import { useEffect, useState } from "react";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import { ScreenshotImage } from "/src/components/shared/screenshot-image.tsx";
|
||||
// The Viewer's own rules hide a waiting screenshot and fade a ready one in.
|
||||
if (window.fixture.styles) await import("/src/styles.css");
|
||||
|
||||
function Harness() {
|
||||
const [state, setState] = useState(window.fixture);
|
||||
@@ -66,10 +68,13 @@ function Harness() {
|
||||
return <main style={{ position: "relative", height: state.layout === "scroll" ? 3300 : 300,
|
||||
width: 600, overflow: state.layout === "pan" ? "hidden" : undefined }}>
|
||||
{state.normalSource && <ScreenshotImage src={state.normalSource} alt="Hosted screenshot"
|
||||
width={24} height={18} decoding="async" onLoad={loaded} />}
|
||||
width={24} height={18} decoding="async" onLoad={loaded} {...(state.holdPrevious ? { holdPrevious: true } : {})}
|
||||
{...(state.fallback ? { fallback: <span data-testid="hosted-fallback">No hosted screenshot</span> } : {})} />}
|
||||
<div data-testid="positioner" style={{ position: "absolute", left: 20,
|
||||
top: state.layout === "scroll" ? 3000 : 30,
|
||||
transform: state.layout === "pan" ? "translateX(2500px)" : undefined }}>
|
||||
transform: state.layout === "pan" ? "translateX(2500px)" : undefined }}
|
||||
{...(state.instant ? { "data-screenshot-instant": "" } : {})}
|
||||
{...(state.thumbnail ? { className: "variant-thumbnail", "aria-selected": "false" } : {})}>
|
||||
{state.mounted !== false && <ScreenshotImage src={state.source} alt="Captured checkout"
|
||||
width={120} height={80} loading={state.loading} decoding="async" className="captured-image"
|
||||
data-screen="checkout" onLoad={loaded} onError={failed}
|
||||
@@ -106,6 +111,18 @@ async function fixture(t, options = {}) {
|
||||
response.end(firstImage);
|
||||
return;
|
||||
}
|
||||
// A hosted screenshot that is not there.
|
||||
if (request.url === "/__missing.png") {
|
||||
response.statusCode = 404;
|
||||
response.end("Not found");
|
||||
return;
|
||||
}
|
||||
// A hosted screenshot that takes a while to arrive.
|
||||
if (request.url === "/__slow.png") {
|
||||
response.setHeader("Content-Type", "image/png");
|
||||
setTimeout(() => response.end(secondImage), 600);
|
||||
return;
|
||||
}
|
||||
if (request.url !== "/") return next();
|
||||
response.setHeader("Content-Type", "text/html");
|
||||
response.end('<!doctype html><html><head><style>body{margin:0}</style></head><body><div id="root"></div><script type="module" src="/__screenshot_image.tsx"></script></body></html>');
|
||||
@@ -163,7 +180,15 @@ async function fixture(t, options = {}) {
|
||||
window.pendingScreenshots.delete(source);
|
||||
for (const { reject } of pending) reject(new Error("Screenshot resolution failed"));
|
||||
};
|
||||
if (fixture.decode === "manual") {
|
||||
// The test settles each decode; one it never settles stands in for a decode that hangs.
|
||||
window.pendingDecodes = [];
|
||||
HTMLImageElement.prototype.decode = function () {
|
||||
return new Promise((resolve, reject) => window.pendingDecodes.push({ image: this, resolve, reject }));
|
||||
};
|
||||
}
|
||||
}, { source: firstSource, layout: "visible", ...options });
|
||||
if (options.reducedMotion) await page.emulateMedia({ reducedMotion: "reduce" });
|
||||
await page.goto(`http://127.0.0.1:${address.port}/`);
|
||||
await page.waitForFunction(() => window.harnessReady);
|
||||
return { page, image: page.getByRole("img", { name: "Captured checkout", exact: true }) };
|
||||
@@ -505,3 +530,187 @@ test("an image that leaves and re-enters the viewport within one render is ready
|
||||
await expect(image).not.toHaveAttribute("aria-busy", /.*/);
|
||||
assert.equal(await page.evaluate(() => window.imageLoads.length), 1, "No second load event fired");
|
||||
});
|
||||
|
||||
/** The image's opacity and state in each of the next `frames` frames, from the frame after `change` runs. */
|
||||
async function framesAfter(page, change, frames = 4, selector = "img[alt='Captured checkout']") {
|
||||
return page.evaluate(({ change, frames, selector }) => new Promise(resolve => {
|
||||
const samples = [];
|
||||
new Function(change)();
|
||||
const sample = () => {
|
||||
const image = document.querySelector(selector);
|
||||
samples.push(image ? { source: image.dataset.screenshotSrc ?? image.getAttribute("src"),
|
||||
state: image.dataset.screenshotState, opacity: getComputedStyle(image).opacity } : undefined);
|
||||
if (samples.length < frames) requestAnimationFrame(sample);
|
||||
else resolve(samples);
|
||||
};
|
||||
requestAnimationFrame(sample);
|
||||
}), { change, frames, selector });
|
||||
}
|
||||
|
||||
/** The reveal animation on the image, paused and sought to `at` milliseconds: its opacity there. */
|
||||
async function revealOpacityAt(image, at) {
|
||||
return image.evaluate((element, at) => {
|
||||
const [animation] = element.getAnimations().filter(animation => animation.animationName === "screenshot-reveal");
|
||||
if (!animation) return undefined;
|
||||
animation.pause();
|
||||
animation.currentTime = at;
|
||||
return Number(getComputedStyle(element).opacity);
|
||||
}, at);
|
||||
}
|
||||
|
||||
test("a waiting screenshot is hidden from its first frame, and one that fills its empty frame fades in", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true });
|
||||
await expect.poll(() => page.evaluate(() => window.resolverCalls)).toEqual([firstSource]);
|
||||
await expect(image).toHaveCSS("opacity", "0");
|
||||
await resolveImage(page, firstSource);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
|
||||
assert.equal(await revealOpacityAt(image, 0), 0, "The fade starts from nothing");
|
||||
const midway = await revealOpacityAt(image, 80);
|
||||
assert.ok(midway > 0 && midway < 1, `Halfway through the fade the picture is partly shown (${midway})`);
|
||||
await image.evaluate(element => element.getAnimations().forEach(animation => animation.finish()));
|
||||
await expect(image).toHaveCSS("opacity", "1");
|
||||
|
||||
// Another source: the picture before is hidden in the very frame the new source lands, never faded out.
|
||||
const samples = await framesAfter(page, `window.updateScreenshot({ source: ${JSON.stringify(secondSource)} })`);
|
||||
const landed = samples.filter(sample => sample?.source === secondSource);
|
||||
assert.ok(landed.length > 0, "The new source landed within a few frames");
|
||||
assert.deepEqual(landed.map(sample => sample.opacity), landed.map(() => "0"));
|
||||
assert.deepEqual(samples.filter(sample => sample?.source !== secondSource).map(sample => sample.opacity),
|
||||
samples.filter(sample => sample?.source !== secondSource).map(() => "1"), "Until then, the shown picture is the one it names");
|
||||
assert.deepEqual(await image.evaluate(element => element.getAnimations().map(animation => animation.constructor.name)), [],
|
||||
"Nothing animates the hiding");
|
||||
});
|
||||
|
||||
test("a loaded screenshot is shown only once it has decoded, or after a short wait for a decode that hangs", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true, decode: "manual" });
|
||||
await resolveImage(page, firstSource);
|
||||
// The caller hears the load at once (Compare takes its shape from it); the picture waits for its pixels.
|
||||
await expect.poll(() => page.evaluate(() => window.imageLoads.length)).toBe(1);
|
||||
await expect.poll(() => page.evaluate(() => window.pendingDecodes.length)).toBe(1);
|
||||
await page.waitForTimeout(100);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "loading");
|
||||
await expect(image).toHaveCSS("opacity", "0");
|
||||
await page.evaluate(() => window.pendingDecodes.shift().resolve());
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
|
||||
|
||||
// A decode that never settles: shown anyway, with its fade.
|
||||
await page.evaluate(source => window.updateScreenshot({ source }), secondSource);
|
||||
await resolveImage(page, secondSource, secondImage);
|
||||
await expect.poll(() => page.evaluate(() => window.pendingDecodes.length)).toBe(1);
|
||||
const loadedAt = await page.evaluate(() => performance.now());
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
const waited = await page.evaluate(() => performance.now()) - loadedAt;
|
||||
assert.ok(waited >= 200, `The hung decode was waited for before the picture was shown (${Math.round(waited)}ms)`);
|
||||
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
|
||||
assert.equal(await image.evaluate(element => element.naturalWidth), 4);
|
||||
});
|
||||
|
||||
test("a screenshot the report still holds decoded fades in when it is shown again", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true });
|
||||
const url = await blobUrl(page, firstImage);
|
||||
await expect.poll(() => page.evaluate(() => window.resolverCalls)).toEqual([firstSource]);
|
||||
await page.evaluate(({ source, url }) => window.resolveScreenshot(source, url), { source: firstSource, url });
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
|
||||
// Shown again (Compare stepping back to it, a view mounting again) while the report still holds its decoded URL.
|
||||
await page.evaluate(() => window.updateScreenshot({ mounted: false }));
|
||||
await expect(image).toHaveCount(0);
|
||||
await page.evaluate(({ source, url }) => {
|
||||
window.immediateScreenshots.set(source, url);
|
||||
window.updateScreenshot({ mounted: true });
|
||||
}, { source: firstSource, url });
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(image).toHaveAttribute("data-screenshot-reveal", "");
|
||||
assert.equal(await revealOpacityAt(image, 0), 0);
|
||||
});
|
||||
|
||||
test("an ordinary URL is a new image for each source and never shows the one before while it loads", { timeout: 30_000 }, async t => {
|
||||
const { page } = await fixture(t, { loading: "eager", styles: true, normalSource: "/__normal.png" });
|
||||
const hosted = page.getByRole("img", { name: "Hosted screenshot", exact: true });
|
||||
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(hosted).toHaveAttribute("data-screenshot-reveal", "");
|
||||
await hosted.evaluate(element => { element.dataset.first = "true"; });
|
||||
|
||||
const samples = await framesAfter(page, "window.updateScreenshot({ normalSource: '/__slow.png' })", 6, "img[alt='Hosted screenshot']");
|
||||
const landed = samples.filter(sample => sample?.source === "/__slow.png");
|
||||
assert.ok(landed.length > 0);
|
||||
assert.deepEqual(landed.map(sample => [sample.state, sample.opacity]), landed.map(() => ["loading", "0"]));
|
||||
await expect(hosted).not.toHaveAttribute("data-first", /.*/);
|
||||
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(hosted).toHaveAttribute("data-screenshot-reveal", "");
|
||||
await expectDecoded(hosted, 4, 5);
|
||||
});
|
||||
|
||||
test("a held picture stays shown while its replacement loads, and the replacement appears without a fade", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true, holdPrevious: true, fallback: true });
|
||||
await resolveImage(page, firstSource);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await page.evaluate(source => window.updateScreenshot({ source }), secondSource);
|
||||
await expect(image).toHaveAttribute("data-screenshot-held", "");
|
||||
await expect(image).toHaveCSS("opacity", "1");
|
||||
await resolveImage(page, secondSource, secondImage);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expectDecoded(image, 4, 5);
|
||||
await expect(image).not.toHaveAttribute("data-screenshot-reveal", /.*/);
|
||||
await expect(image).not.toHaveAttribute("data-screenshot-held", /.*/);
|
||||
assert.deepEqual(await image.evaluate(element => element.getAnimations().length), 0);
|
||||
});
|
||||
|
||||
test("inside an instant stage a picture appears at once", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true, instant: true });
|
||||
await resolveImage(page, firstSource);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(image).not.toHaveAttribute("data-screenshot-reveal", /.*/);
|
||||
await expect(image).toHaveCSS("opacity", "1");
|
||||
});
|
||||
|
||||
test("with reduced motion a screenshot appears without a fade", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true, reducedMotion: true });
|
||||
await resolveImage(page, firstSource);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
// The Viewer's reduced-motion rule leaves every transition a hundredth of a millisecond long; the fade is gone.
|
||||
assert.deepEqual(await image.evaluate(element => element.getAnimations().map(animation => animation.animationName).filter(Boolean)), []);
|
||||
await expect(image).toHaveCSS("opacity", "1");
|
||||
});
|
||||
|
||||
test("an unselected variant thumbnail that changes source hides at once, despite its own dimmed opacity and its transition", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true, thumbnail: true });
|
||||
await resolveImage(page, firstSource);
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await image.evaluate(element => element.getAnimations().forEach(animation => animation.finish()));
|
||||
await expect(image).toHaveCSS("opacity", "0.35");
|
||||
const samples = await framesAfter(page, `window.updateScreenshot({ source: ${JSON.stringify(secondSource)} })`);
|
||||
const landed = samples.filter(sample => sample?.source === secondSource);
|
||||
assert.ok(landed.length > 0);
|
||||
assert.deepEqual(landed.map(sample => sample.opacity), landed.map(() => "0"));
|
||||
});
|
||||
|
||||
test("an ordinary URL that cannot be loaded shows the fallback, and a held one gives way to it", { timeout: 30_000 }, async t => {
|
||||
const { page } = await fixture(t, { loading: "eager", styles: true, fallback: true, holdPrevious: true, normalSource: "/__normal.png" });
|
||||
const hosted = page.getByRole("img", { name: "Hosted screenshot", exact: true });
|
||||
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
|
||||
// The app icon's case: a held picture whose replacement is missing ends on the fallback, not on the picture before.
|
||||
await page.evaluate(() => window.updateScreenshot({ normalSource: "/__missing.png" }));
|
||||
await expect(page.getByTestId("hosted-fallback")).toHaveText("No hosted screenshot");
|
||||
await expect(hosted).toHaveCount(0);
|
||||
// A new source tries again.
|
||||
await page.evaluate(() => window.updateScreenshot({ normalSource: "/__normal.png" }));
|
||||
await expect(hosted).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(page.getByTestId("hosted-fallback")).toHaveCount(0);
|
||||
});
|
||||
|
||||
test("re-rendering an image that waits for its decode starts no second wait", { timeout: 30_000 }, async t => {
|
||||
const { page, image } = await fixture(t, { loading: "eager", styles: true, decode: "manual" });
|
||||
await resolveImage(page, firstSource);
|
||||
await expect.poll(() => page.evaluate(() => window.pendingDecodes.length)).toBe(1);
|
||||
// Renders while the decode is pending find the image loaded but not shown yet.
|
||||
for (let render = 0; render < 5; render++) {
|
||||
await page.evaluate(render => window.updateScreenshot({ render }), render);
|
||||
await page.evaluate(() => new Promise(resolve => requestAnimationFrame(resolve)));
|
||||
}
|
||||
assert.equal(await page.evaluate(() => window.pendingDecodes.length), 1, "One decode wait for the one picture");
|
||||
await page.evaluate(() => window.pendingDecodes.shift().resolve());
|
||||
await expect(image).toHaveAttribute("data-screenshot-state", "ready");
|
||||
});
|
||||
@@ -0,0 +1,186 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { chromium, expect } from "@playwright/test";
|
||||
import { PNG } from "pngjs";
|
||||
import { createBrowserVite } from "../helpers/browser-vite.mjs";
|
||||
|
||||
function pngBytes(width, height, color) {
|
||||
const image = new PNG({ width, height });
|
||||
for (let index = 0; index < image.data.length; index += 4) image.data.set([...color, 255], index);
|
||||
return PNG.sync.write(image);
|
||||
}
|
||||
const png = (width, height, color) => `data:image/png;base64,${pngBytes(width, height, color).toString("base64")}`;
|
||||
const GREEN = [40, 200, 40];
|
||||
|
||||
// Split over one screen with two changed areas and a card that moved 40% of the width right (at 60% in After, so
|
||||
// at 20% in Before), and a second screen with one changed area elsewhere. The status bar CI left out is a foldable's
|
||||
// rail pill, not a band across the top. Keys stand in for the controller's, so the pointer can stay where it is:
|
||||
// 1 and 2 pick Split and Swipe, o toggles the outlines, n steps to the other screen, j selects the first area.
|
||||
const entry = `
|
||||
import { useState, useEffect } from "react";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import { CompareStage } from "/src/components/compare/compare-section.tsx";
|
||||
import "/src/styles.css";
|
||||
const screens = [
|
||||
[
|
||||
{ x: 10, y: 20, width: 30, height: 20, share: 40, regionCount: 1 },
|
||||
{ x: 60, y: 60, width: 30, height: 20, share: 30, regionCount: 1, move: { x: 40, y: 0, amount: { x: 400, y: 0 }, unit: "px" } },
|
||||
{ x: 55, y: 20, width: 35, height: 20, share: 30, regionCount: 1 },
|
||||
],
|
||||
[{ x: 10, y: 85, width: 20, height: 10, share: 100, regionCount: 1 }],
|
||||
];
|
||||
const systemRegions = [{ kind: "status-bar", x: 40, y: 0, width: 20, height: 4 }];
|
||||
function Harness() {
|
||||
const [mode, setMode] = useState("split");
|
||||
const [outlines, setOutlines] = useState(true);
|
||||
const [screen, setScreen] = useState(0);
|
||||
const [active, setActive] = useState();
|
||||
useEffect(() => {
|
||||
const onKey = (event) => {
|
||||
if (event.key === "1") setMode("split");
|
||||
if (event.key === "2") setMode("swipe");
|
||||
if (event.key === "o") setOutlines((shown) => !shown);
|
||||
if (event.key === "n") setScreen((index) => 1 - index);
|
||||
if (event.key === "j") setActive(0);
|
||||
};
|
||||
window.addEventListener("keydown", onKey);
|
||||
return () => window.removeEventListener("keydown", onKey);
|
||||
}, []);
|
||||
// The second screen has screenshots of its own when the test gives it some.
|
||||
const diff = { id: "s" + screen, status: "modified", beforeScreenshot: screen && window.nextBefore || window.before,
|
||||
afterScreenshot: screen && window.nextAfter || window.after };
|
||||
return (
|
||||
<div className={"compare-stage mode-" + mode} style={{ width: 800, height: 500, display: "flex" }}>
|
||||
<CompareStage key="stage" mode={mode} diff={diff} title="Share" areas={screens[screen]} activeArea={active}
|
||||
showOutlines={outlines} systemRegions={systemRegions} overlay={null} flipSide="after" onFlip={() => {}}
|
||||
swipePosition={50} onSwipePosition={() => {}} aspect={1} onAspect={() => {}} />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
createRoot(document.getElementById("root")).render(<Harness />);
|
||||
`;
|
||||
|
||||
async function openSplit(t, contextOptions = {}, images = {}) {
|
||||
const vite = await createBrowserVite(t, {
|
||||
configFile: false, root: fileURLToPath(new URL("../../viewer", import.meta.url)),
|
||||
logLevel: "error", esbuild: { jsx: "automatic" },
|
||||
plugins: [{
|
||||
name: "split-outlines-fixture",
|
||||
resolveId: id => id === "/__split-outlines.tsx" ? id : undefined,
|
||||
load: id => id === "/__split-outlines.tsx" ? entry : undefined,
|
||||
configureServer(server) {
|
||||
server.middlewares.use((request, response, next) => {
|
||||
// The next screen's Before, which takes a while to arrive.
|
||||
if (request.url === "/__slow-before.png") {
|
||||
response.setHeader("Content-Type", "image/png");
|
||||
setTimeout(() => response.end(pngBytes(100, 100, GREEN)), 1000);
|
||||
return;
|
||||
}
|
||||
if (new URL(request.url, "http://localhost").pathname !== "/") return next();
|
||||
response.setHeader("Content-Type", "text/html");
|
||||
response.end('<!doctype html><html><body style="margin:0"><div id="root"></div><script type="module" src="/__split-outlines.tsx"></script></body></html>');
|
||||
});
|
||||
},
|
||||
}],
|
||||
server: { host: "127.0.0.1", port: 0 },
|
||||
});
|
||||
await vite.listen();
|
||||
const browser = await chromium.launch({ headless: true });
|
||||
t.after(() => browser.close());
|
||||
const page = await browser.newPage({ viewport: { width: 900, height: 600 }, ...contextOptions });
|
||||
const errors = [];
|
||||
page.on("pageerror", error => errors.push(error.message));
|
||||
t.after(() => assert.deepEqual(errors, []));
|
||||
await page.addInitScript(images => Object.assign(window, images), { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]), ...images });
|
||||
await page.goto(`http://127.0.0.1:${vite.httpServer.address().port}/`);
|
||||
const outline = (side, index) => page.locator(`[data-side="${side}"] .visual-change-outline`).nth(index);
|
||||
await expect(outline("after", 0)).toBeVisible();
|
||||
return { page, outline };
|
||||
}
|
||||
|
||||
const opacity = locator => locator.evaluate(element => Number(getComputedStyle(element).opacity));
|
||||
|
||||
test("Split keeps the ignored system regions the report names on both sides", { timeout: 30_000 }, async t => {
|
||||
const { page } = await openSplit(t);
|
||||
for (const side of ["before", "after"]) {
|
||||
const band = page.locator(`[data-side="${side}"] .visual-system-region-status-bar`);
|
||||
await expect(band).toHaveCount(1);
|
||||
const [frame, box] = await Promise.all([page.locator(`[data-side="${side}"] .compare-frame`).boundingBox(), band.boundingBox()]);
|
||||
assert.ok(Math.abs((box.x - frame.x) - 0.4 * frame.width) < 1, `${side}'s band sits where the report puts the rail pill`);
|
||||
assert.ok(Math.abs(box.width - 0.2 * frame.width) < 1);
|
||||
}
|
||||
});
|
||||
|
||||
test("Split hides Before's changed outlines but keeps a moved area where its content was", { timeout: 30_000 }, async t => {
|
||||
const { page, outline } = await openSplit(t);
|
||||
await expect.poll(() => opacity(outline("before", 0))).toBe(0);
|
||||
await expect.poll(() => opacity(outline("before", 1))).toBe(1);
|
||||
await expect(outline("before", 1).locator(".visual-change-measure")).toHaveCount(1);
|
||||
const frame = side => page.locator(`[data-side="${side}"] .compare-frame`).boundingBox();
|
||||
const [before, after, beforeFrame, afterFrame] = await Promise.all([outline("before", 1).boundingBox(), outline("after", 1).boundingBox(),
|
||||
frame("before"), frame("after")]);
|
||||
assert.ok(Math.abs(((after.x - afterFrame.x) - (before.x - beforeFrame.x)) - 0.4 * afterFrame.width) < 1, "Before's moved outline is back by the move");
|
||||
});
|
||||
|
||||
test("A hover is dropped when the screen, the mode or the outlines change under the pointer", { timeout: 30_000 }, async t => {
|
||||
const { page, outline } = await openSplit(t);
|
||||
const hovered = page.locator(".visual-change-outline.hovered");
|
||||
for (const [away, back] of [["2", "1"], ["o", "o"], ["n", "n"]]) {
|
||||
await outline("after", 0).hover();
|
||||
await expect(outline("before", 0)).toHaveClass(/hovered/);
|
||||
// The outline goes from under the pointer, which then moves off the frame before it comes back.
|
||||
await page.keyboard.press(away);
|
||||
await page.mouse.move(0, 0);
|
||||
await page.keyboard.press(back);
|
||||
await expect(outline("after", 0)).toBeVisible();
|
||||
await expect(hovered).toHaveCount(0);
|
||||
}
|
||||
});
|
||||
|
||||
test("The hovered outline on After stays lit while another area is selected", { timeout: 30_000 }, async t => {
|
||||
const { page, outline } = await openSplit(t);
|
||||
await page.keyboard.press("j");
|
||||
await outline("after", 2).hover();
|
||||
await expect.poll(() => opacity(outline("after", 2))).toBe(1);
|
||||
await expect.poll(() => opacity(outline("before", 2))).toBe(1);
|
||||
await expect.poll(() => opacity(outline("after", 1))).toBe(0.35);
|
||||
});
|
||||
|
||||
test("A screen without hover keeps Before's outlines, as it cannot reveal one", { timeout: 30_000 }, async t => {
|
||||
const { page, outline } = await openSplit(t, { hasTouch: true, isMobile: true });
|
||||
assert.equal(await page.evaluate(() => matchMedia("(hover: none)").matches), true);
|
||||
await expect.poll(() => opacity(outline("before", 0))).toBe(1);
|
||||
await expect.poll(() => opacity(outline("before", 2))).toBe(1);
|
||||
});
|
||||
|
||||
test("Stepping never shows the screen before's pictures under the next one's outlines: a side still loading is an empty frame", { timeout: 30_000 }, async t => {
|
||||
const images = { before: png(100, 100, [200, 40, 40]), after: png(100, 100, [40, 40, 200]),
|
||||
nextBefore: "/__slow-before.png", nextAfter: png(100, 100, [200, 200, 40]) };
|
||||
const { page } = await openSplit(t, {}, images);
|
||||
for (const side of ["before", "after"]) await expect(page.locator(`[data-side="${side}"] img`)).toHaveAttribute("data-screenshot-state", "ready");
|
||||
// Every frame from the step on: the screen the outlines belong to, and any picture of the screen before still showing.
|
||||
await page.evaluate(previous => {
|
||||
window.stepFrames = [];
|
||||
const sample = () => {
|
||||
const outlines = document.querySelectorAll('[data-side="after"] .visual-change-outline').length;
|
||||
const stale = [...document.querySelectorAll(".compare-frame img")].filter(image => previous.includes(image.getAttribute("src"))
|
||||
&& Number(getComputedStyle(image).opacity) > 0).length;
|
||||
window.stepFrames.push({ outlines, stale });
|
||||
if (window.stepFrames.length < 30) requestAnimationFrame(sample);
|
||||
};
|
||||
requestAnimationFrame(sample);
|
||||
}, [images.before, images.after]);
|
||||
await page.keyboard.press("n");
|
||||
await expect.poll(() => page.evaluate(() => window.stepFrames.length)).toBe(30);
|
||||
const frames = await page.evaluate(() => window.stepFrames);
|
||||
assert.ok(frames.some(frame => frame.outlines === 1), "The step landed while the frames were sampled");
|
||||
assert.deepEqual(frames.filter(frame => frame.outlines === 1 && frame.stale > 0), [], "No frame showed a picture of the screen before under the next one's outlines");
|
||||
|
||||
// Before is still loading: its frame is empty, After's shows the new screen.
|
||||
const before = page.locator('[data-side="before"] img');
|
||||
await expect(before).toHaveAttribute("data-screenshot-state", "loading");
|
||||
await expect(before).toHaveCSS("opacity", "0");
|
||||
await expect(page.locator('[data-side="after"] img')).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(before).toHaveAttribute("data-screenshot-state", "ready", { timeout: 5000 });
|
||||
});
|
||||
@@ -5,11 +5,15 @@ import { chromium, expect } from "@playwright/test";
|
||||
import { PNG } from "pngjs";
|
||||
import { createBrowserVite } from "../helpers/browser-vite.mjs";
|
||||
|
||||
function png(width, height, color) {
|
||||
function pngBytes(width, height, color) {
|
||||
const image = new PNG({ width, height });
|
||||
for (let index = 0; index < image.data.length; index += 4) image.data.set([...color, 255], index);
|
||||
return `data:image/png;base64,${PNG.sync.write(image).toString("base64")}`;
|
||||
return PNG.sync.write(image);
|
||||
}
|
||||
const png = (width, height, color) => `data:image/png;base64,${pngBytes(width, height, color).toString("base64")}`;
|
||||
|
||||
const RED = [200, 40, 40];
|
||||
const BLUE = [40, 40, 200];
|
||||
|
||||
// A card that moved 40% of the width right: it is at 60% in After, so it was at 20% in Before.
|
||||
const entry = `
|
||||
@@ -19,11 +23,11 @@ import "/src/styles.css";
|
||||
const changes = [{ x: 60, y: 30, width: 30, height: 30, share: 100, regionCount: 1,
|
||||
move: { x: 40, y: 0, amount: { x: 400, y: 0 }, unit: "px" } }];
|
||||
createRoot(document.getElementById("root")).render(<div style={{ width: 400, display: "flex" }}>
|
||||
<SwipeCompare title="Share" before={window.before} after={window.after} imageAspect={1} changes={changes} position={50} />
|
||||
<SwipeCompare title="Share" before={window.before} after={window.after} imageAspect={1} changes={changes} position={window.position ?? 50} />
|
||||
</div>);
|
||||
`;
|
||||
|
||||
test("Swipe draws a moved area where its content was on Before's half and where it is on After's", { timeout: 30_000 }, async t => {
|
||||
async function openSwipe(t, images) {
|
||||
const vite = await createBrowserVite(t, {
|
||||
configFile: false, root: fileURLToPath(new URL("../../viewer", import.meta.url)),
|
||||
logLevel: "error", esbuild: { jsx: "automatic" },
|
||||
@@ -33,6 +37,12 @@ test("Swipe draws a moved area where its content was on Before's half and where
|
||||
load: id => id === "/__swipe-outlines.tsx" ? entry : undefined,
|
||||
configureServer(server) {
|
||||
server.middlewares.use((request, response, next) => {
|
||||
// A Before that takes a while to arrive.
|
||||
if (request.url === "/__slow-before.png") {
|
||||
response.setHeader("Content-Type", "image/png");
|
||||
setTimeout(() => response.end(pngBytes(100, 100, RED)), 1000);
|
||||
return;
|
||||
}
|
||||
if (new URL(request.url, "http://localhost").pathname !== "/") return next();
|
||||
response.setHeader("Content-Type", "text/html");
|
||||
response.end('<!doctype html><html><body style="margin:0"><div id="root"></div><script type="module" src="/__swipe-outlines.tsx"></script></body></html>');
|
||||
@@ -47,9 +57,23 @@ test("Swipe draws a moved area where its content was on Before's half and where
|
||||
const page = await browser.newPage({ viewport: { width: 600, height: 600 } });
|
||||
const errors = [];
|
||||
page.on("pageerror", error => errors.push(error.message));
|
||||
await page.addInitScript(images => Object.assign(window, images), { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]) });
|
||||
t.after(() => assert.deepEqual(errors, []));
|
||||
await page.addInitScript(images => Object.assign(window, images), images);
|
||||
await page.goto(`http://127.0.0.1:${vite.httpServer.address().port}/`);
|
||||
return page;
|
||||
}
|
||||
|
||||
/** The colour on screen at `x` (a share of the frame's width), a fifth of the way down the Swipe frame, clear of the divider's handle. */
|
||||
async function colourAt(page, x) {
|
||||
const box = await page.locator(".visual-swipe").boundingBox();
|
||||
const shot = PNG.sync.read(await page.screenshot({ clip: { x: box.x + box.width * x, y: box.y + box.height / 5, width: 1, height: 1 } }));
|
||||
return [...shot.data.subarray(0, 3)];
|
||||
}
|
||||
|
||||
const near = (colour, expected) => colour.every((value, index) => Math.abs(value - expected[index]) <= 6);
|
||||
|
||||
test("Swipe draws a moved area where its content was on Before's half and where it is on After's", { timeout: 30_000 }, async t => {
|
||||
const page = await openSwipe(t, { before: png(100, 100, [240, 240, 240]), after: png(100, 100, [230, 230, 230]) });
|
||||
const frame = page.locator(".visual-swipe");
|
||||
const before = page.locator(".visual-swipe-outlines.before .visual-change-outline.moved");
|
||||
const after = page.locator(".visual-swipe-outlines.after .visual-change-outline.moved");
|
||||
@@ -60,5 +84,28 @@ test("Swipe draws a moved area where its content was on Before's half and where
|
||||
// Each side's outlines show only over its own half of the frame.
|
||||
const clips = await page.locator(".visual-swipe-outlines").evaluateAll(spans => spans.map(span => getComputedStyle(span).clipPath));
|
||||
assert.deepEqual(clips.map(clip => clip.startsWith("inset(")), [true, true]);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test("Swipe never shows After on Before's half: while Before loads, its half is the empty frame", { timeout: 30_000 }, async t => {
|
||||
const page = await openSwipe(t, { before: "/__slow-before.png", after: png(100, 100, BLUE) });
|
||||
const before = page.locator("img.visual-swipe-before");
|
||||
await expect(page.locator("img.visual-swipe-after")).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await expect(before).toHaveAttribute("data-screenshot-state", "loading");
|
||||
await page.evaluate(() => document.getAnimations().forEach(animation => animation.finish()));
|
||||
assert.ok(near(await colourAt(page, 0.75), BLUE), "After shows on its own half");
|
||||
const waiting = await colourAt(page, 0.25);
|
||||
assert.ok(!near(waiting, BLUE) && !near(waiting, RED), `Before's half is the empty frame while Before loads: ${waiting}`);
|
||||
await expect(before).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await page.evaluate(() => document.getAnimations().forEach(animation => animation.finish()));
|
||||
assert.ok(near(await colourAt(page, 0.25), RED));
|
||||
assert.ok(near(await colourAt(page, 0.75), BLUE));
|
||||
});
|
||||
|
||||
for (const [position, shown] of [[0, BLUE], [100, RED]]) {
|
||||
test(`Swipe at ${position}% shows only ${position ? "Before" : "After"}, across the whole frame`, { timeout: 30_000 }, async t => {
|
||||
const page = await openSwipe(t, { before: png(100, 100, RED), after: png(100, 100, BLUE), position });
|
||||
for (const side of ["before", "after"]) await expect(page.locator(`img.visual-swipe-${side}`)).toHaveAttribute("data-screenshot-state", "ready");
|
||||
await page.evaluate(() => document.getAnimations().forEach(animation => animation.finish()));
|
||||
for (const x of [0.03, 0.5, 0.97]) assert.ok(near(await colourAt(page, x), shown), `${position}%: ${x} of the way across`);
|
||||
});
|
||||
}
|
||||
@@ -0,0 +1,266 @@
|
||||
import { expect, test, type Page } from "@playwright/test";
|
||||
|
||||
const STORAGE_KEY = "expo-explore:inspector-width";
|
||||
const panel = (page: Page) => page.getByRole("complementary", { name: "Inspector panel" });
|
||||
const handle = (page: Page) => page.getByRole("separator", { name: "Resize inspector" });
|
||||
const panelWidth = async (page: Page) => (await panel(page).boundingBox())!.width;
|
||||
const storedWidth = (page: Page) => page.evaluate((key) => localStorage.getItem(key), STORAGE_KEY);
|
||||
|
||||
/** Drags the panel's edge `dx` pixels (negative is left, which widens the panel). */
|
||||
async function dragEdge(page: Page, dx: number) {
|
||||
const box = (await handle(page).boundingBox())!;
|
||||
const x = box.x + box.width / 2;
|
||||
const y = box.y + box.height / 2;
|
||||
await page.mouse.move(x, y);
|
||||
await page.mouse.down();
|
||||
await page.mouse.move(x + dx / 2, y);
|
||||
await page.mouse.move(x + dx, y);
|
||||
await page.mouse.up();
|
||||
}
|
||||
|
||||
test.describe("Inspector resize", () => {
|
||||
test("dragging the edge resizes the Inspector, and the width is kept for the next visit", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
// The 1280px test window takes the wide default.
|
||||
expect(await panelWidth(page)).toBe(400);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "400");
|
||||
|
||||
await dragEdge(page, -150);
|
||||
await expect.poll(() => panelWidth(page)).toBe(550);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "550");
|
||||
expect(await storedWidth(page)).toBe("550");
|
||||
|
||||
await page.reload();
|
||||
await expect(panel(page)).toBeVisible();
|
||||
await expect.poll(() => panelWidth(page)).toBe(550);
|
||||
|
||||
// Dragging back right narrows it, never below the minimum.
|
||||
await dragEdge(page, 400);
|
||||
await expect.poll(() => panelWidth(page)).toBe(320);
|
||||
expect(await storedWidth(page)).toBe("320");
|
||||
});
|
||||
|
||||
test("the width stops at half the window, and a double-click restores the default", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
await dragEdge(page, -600);
|
||||
await expect.poll(() => panelWidth(page)).toBe(640);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuemax", "640");
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "640");
|
||||
|
||||
// The canvas toolbar moves left, out from under the wide panel, instead of being covered.
|
||||
const toolbar = page.getByRole("toolbar", { name: "Canvas tools" });
|
||||
await expect(toolbar).toBeVisible();
|
||||
await expect.poll(async () => {
|
||||
const toolbarBox = (await toolbar.boundingBox())!;
|
||||
const panelBox = (await panel(page).boundingBox())!;
|
||||
return panelBox.x - (toolbarBox.x + toolbarBox.width);
|
||||
}).toBeGreaterThanOrEqual(8);
|
||||
|
||||
await handle(page).dblclick();
|
||||
await expect.poll(() => panelWidth(page)).toBe(400);
|
||||
expect(await storedWidth(page)).toBeNull();
|
||||
});
|
||||
|
||||
test("arrow keys move the edge a step; Home and End take it to its limits", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
await handle(page).focus();
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await expect.poll(() => panelWidth(page)).toBe(416);
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await expect.poll(() => panelWidth(page)).toBe(432);
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect.poll(() => panelWidth(page)).toBe(416);
|
||||
await page.keyboard.press("End");
|
||||
await expect.poll(() => panelWidth(page)).toBe(640);
|
||||
await page.keyboard.press("Home");
|
||||
await expect.poll(() => panelWidth(page)).toBe(320);
|
||||
// The arrows resized the panel; they did not step the selected screen.
|
||||
expect(new URL(page.url()).searchParams.get("screen")).toBe("area-0-screen-1");
|
||||
});
|
||||
|
||||
test("a saved width wider than half of a smaller window is held to half of it", async ({ page }) => {
|
||||
await page.addInitScript((key) => localStorage.setItem(key, "760"), STORAGE_KEY);
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
expect(await panelWidth(page)).toBe(640);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "640");
|
||||
});
|
||||
|
||||
test("a drag that ends where it started leaves the default width in place", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
const box = (await handle(page).boundingBox())!;
|
||||
const x = box.x + box.width / 2;
|
||||
const y = box.y + box.height / 2;
|
||||
await page.mouse.move(x, y);
|
||||
await page.mouse.down();
|
||||
await page.mouse.move(x - 100, y);
|
||||
await expect.poll(() => panelWidth(page)).toBe(500);
|
||||
await page.mouse.move(x, y);
|
||||
await page.mouse.up();
|
||||
await expect.poll(() => panelWidth(page)).toBe(400);
|
||||
expect(await storedWidth(page)).toBeNull();
|
||||
// Still the default: a narrower window takes the narrow default, not the 400 the drag passed through.
|
||||
await page.setViewportSize({ width: 1100, height: 820 });
|
||||
await expect.poll(() => panelWidth(page)).toBe(320);
|
||||
});
|
||||
|
||||
test("a saved width below the minimum is held to it", async ({ page }) => {
|
||||
await page.addInitScript((key) => localStorage.setItem(key, "40"), STORAGE_KEY);
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
expect(await panelWidth(page)).toBe(320);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "320");
|
||||
});
|
||||
|
||||
test.describe("in a window wider than two maximum panels", () => {
|
||||
test.use({ viewport: { width: 1700, height: 900 } });
|
||||
|
||||
test("a saved width above the maximum is held to it", async ({ page }) => {
|
||||
await page.addInitScript((key) => localStorage.setItem(key, "5000"), STORAGE_KEY);
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
// Half of this window is 850.
|
||||
expect(await panelWidth(page)).toBe(800);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "800");
|
||||
});
|
||||
});
|
||||
|
||||
test("a key that cannot move the edge keeps the saved width", async ({ page }) => {
|
||||
await page.addInitScript((key) => localStorage.setItem(key, "760"), STORAGE_KEY);
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
expect(await panelWidth(page)).toBe(640);
|
||||
await handle(page).focus();
|
||||
await page.keyboard.press("End");
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
expect(await storedWidth(page)).toBe("760");
|
||||
await page.keyboard.press("ArrowRight");
|
||||
await expect.poll(() => panelWidth(page)).toBe(624);
|
||||
expect(await storedWidth(page)).toBe("624");
|
||||
});
|
||||
|
||||
test("the separator's values follow the window", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
await handle(page).focus();
|
||||
await page.keyboard.press("End");
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "640");
|
||||
await page.setViewportSize({ width: 1000, height: 820 });
|
||||
await expect.poll(() => panelWidth(page)).toBe(500);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuemax", "500");
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "500");
|
||||
// Back in the wide window the saved width returns.
|
||||
await page.setViewportSize({ width: 1280, height: 820 });
|
||||
await expect.poll(() => panelWidth(page)).toBe(640);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "640");
|
||||
});
|
||||
|
||||
test("closing the Inspector mid-drag ends the drag", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
const box = (await handle(page).boundingBox())!;
|
||||
const x = box.x + box.width / 2;
|
||||
const y = box.y + box.height / 2;
|
||||
await page.mouse.move(x, y);
|
||||
await page.mouse.down();
|
||||
await page.mouse.move(x - 100, y);
|
||||
await expect(page.locator("html")).toHaveClass(/inspector-resizing/);
|
||||
await page.keyboard.press("i");
|
||||
await expect(panel(page)).toHaveCount(0);
|
||||
await page.mouse.up();
|
||||
await expect(page.locator("html")).not.toHaveClass(/inspector-resizing/);
|
||||
// The width the drag reached is kept.
|
||||
await page.keyboard.press("i");
|
||||
await expect.poll(() => panelWidth(page)).toBe(500);
|
||||
});
|
||||
|
||||
test.describe("in a window too narrow for the toolbar beside a half-window Inspector", () => {
|
||||
test.use({ viewport: { width: 820, height: 800 } });
|
||||
|
||||
/** The widest the panel may be here: the window less the bottom bar and a 12px gap either side. */
|
||||
async function widestBesideToolbar(page: Page) {
|
||||
const toolbarBox = (await page.getByRole("toolbar", { name: "Canvas tools" }).boundingBox())!;
|
||||
return Math.floor(820 - (toolbarBox.width + 2 * 12));
|
||||
}
|
||||
|
||||
async function expectToolbarBesidePanel(page: Page) {
|
||||
const toolbar = page.getByRole("toolbar", { name: "Canvas tools" });
|
||||
await expect(toolbar).toBeVisible();
|
||||
await expect(toolbar.getByRole("button", { name: "More", exact: true })).toBeVisible();
|
||||
const toolbarBox = (await toolbar.boundingBox())!;
|
||||
const panelBox = (await panel(page).boundingBox())!;
|
||||
expect(toolbarBox.x).toBeGreaterThanOrEqual(12 - 1);
|
||||
expect(toolbarBox.x + toolbarBox.width + 12).toBeLessThanOrEqual(panelBox.x + 1);
|
||||
}
|
||||
|
||||
test("End stops the Inspector where the toolbar still fits beside it, with More in reach", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
const widest = await widestBesideToolbar(page);
|
||||
// Half the window would be 410; the toolbar needs more of the canvas than that leaves.
|
||||
expect(widest).toBeLessThan(410);
|
||||
expect(widest).toBeGreaterThan(320);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuemax", String(widest));
|
||||
await handle(page).focus();
|
||||
await page.keyboard.press("End");
|
||||
await expect.poll(() => panelWidth(page)).toBe(widest);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", String(widest));
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await expect.poll(() => panelWidth(page)).toBe(widest);
|
||||
await expectToolbarBesidePanel(page);
|
||||
// Narrowed again, the toolbar keeps its gap to the panel.
|
||||
await page.keyboard.press("Home");
|
||||
await expect.poll(() => panelWidth(page)).toBe(320);
|
||||
await expectToolbarBesidePanel(page);
|
||||
});
|
||||
|
||||
test("a drag or a saved width stops there too", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
const widest = await widestBesideToolbar(page);
|
||||
await dragEdge(page, -300);
|
||||
await expect.poll(() => panelWidth(page)).toBe(widest);
|
||||
expect(await storedWidth(page)).toBe(String(widest));
|
||||
await expectToolbarBesidePanel(page);
|
||||
|
||||
await page.evaluate((key) => localStorage.setItem(key, "800"), STORAGE_KEY);
|
||||
await page.reload();
|
||||
await expect(panel(page)).toBeVisible();
|
||||
await expect.poll(() => panelWidth(page)).toBe(widest);
|
||||
await expectToolbarBesidePanel(page);
|
||||
// A wider window gives the saved width more room again.
|
||||
await page.setViewportSize({ width: 1280, height: 800 });
|
||||
await expect.poll(() => panelWidth(page)).toBe(640);
|
||||
});
|
||||
});
|
||||
|
||||
test.describe("in a narrow window", () => {
|
||||
test.use({ viewport: { width: 1180, height: 820 } });
|
||||
|
||||
test("the Inspector starts at its narrow default, and a saved width is held to half the window", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
expect(await panelWidth(page)).toBe(320);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "320");
|
||||
await page.evaluate((key) => localStorage.setItem(key, "760"), STORAGE_KEY);
|
||||
await page.reload();
|
||||
await expect(panel(page)).toBeVisible();
|
||||
expect(await panelWidth(page)).toBe(590);
|
||||
await expect(handle(page)).toHaveAttribute("aria-valuenow", "590");
|
||||
});
|
||||
});
|
||||
|
||||
test.describe("on a phone", () => {
|
||||
test.use({ viewport: { width: 390, height: 844 }, hasTouch: true, isMobile: true });
|
||||
|
||||
test("the Inspector sheet has no resize edge", async ({ page }) => {
|
||||
await page.goto("/map?screen=area-0-screen-1");
|
||||
await expect(panel(page)).toBeVisible();
|
||||
await expect(handle(page)).toHaveCount(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -54,7 +54,7 @@ export async function readUsage(output) {
|
||||
|
||||
export async function fixture(t, provider, { docsOnly = false, unresolvedParameters = false, observerFailurePath, agentMode = false,
|
||||
instructions = 'Explore selected routes in a stable, comparable state.', recoverableOpenFailure = false,
|
||||
userInterfaceStyle, headUserInterfaceStyle, platform: initialPlatform = 'ios', targets } = {}) {
|
||||
userInterfaceStyle, headUserInterfaceStyle, platform: initialPlatform = 'ios', targets, maxSessions } = {}) {
|
||||
let platform = initialPlatform;
|
||||
const root = await realpath(await mkdtemp(join(tmpdir(), 'explore-ci-integration-')));
|
||||
t.after(() => rm(root, { recursive: true, force: true }));
|
||||
@@ -67,7 +67,7 @@ export async function fixture(t, provider, { docsOnly = false, unresolvedParamet
|
||||
const commit = message => { git(headProject, 'add', '.'); git(headProject, 'commit', '-m', message); return git(headProject, 'rev-parse', 'HEAD'); };
|
||||
const config = { mode: 'deterministic', app: { name: 'Example', platform, bundleId: 'com.example.app', easProfile: 'capture', scheme: 'sample' },
|
||||
device: { name: 'iPhone 17 Pro' }, navigation: { provider, ...(provider === 'react-navigation' ? { entry: 'src/App.tsx' } : {}) },
|
||||
exploration: { scope: 'changes' }, capture: { maxMinutes: 30, maxActions: 500, repack: 'eas' },
|
||||
exploration: { scope: 'changes' }, capture: { maxMinutes: 30, maxActions: 500, repack: 'eas', ...(maxSessions ? { maxSessions } : {}) },
|
||||
parameters: provider === 'expo-router' && !unresolvedParameters ? { '/item/[id]': { id: 'example-item' } } : {} };
|
||||
if (targets) config.targets = targets;
|
||||
if (agentMode) { config.mode = 'agent'; config.agent = { provider: 'anthropic', model: 'fixture-model', instructions: '.expo-explore/instructions.md' }; }
|
||||
|
||||
@@ -138,9 +138,10 @@ test("baseline captures a complete single default-branch commit without a PR", (
|
||||
const job = baseline.jobs.baseline;
|
||||
assert.match(baseline.jobs.targets.if, /github\.event\.repository\.default_branch/);
|
||||
assert.deepEqual(job.needs, "targets");
|
||||
assert.deepEqual(job.strategy, { "fail-fast": false, matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
|
||||
assert.deepEqual(job.strategy, { "fail-fast": false, "max-parallel": "${{ fromJSON(needs.targets.outputs.max_parallel) }}",
|
||||
matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
|
||||
assert.equal(job.env.TARGET, "${{ matrix.target }}");
|
||||
assert.match(baseline.jobs.targets.steps.at(-1).run, /config:targets .* \| jq -c '\[\.targets\[\]\.id\]'/);
|
||||
assert.match(baseline.jobs.targets.steps.at(-1).run, /config:targets --project "\$GITHUB_WORKSPACE\/app\/\$APP_PROJECT_DIR"/);
|
||||
const verify = job.steps.find(step => step.name === "Verify deterministic source planning");
|
||||
assert.match(verify.run, /--base-sha "\$GITHUB_SHA" --head-sha "\$GITHUB_SHA" --scope all/);
|
||||
const capture = job.steps.find(step => step.name === "Capture complete single-commit baseline");
|
||||
@@ -292,7 +293,7 @@ test("action rejects unsupported Node versions before installing tools", async t
|
||||
test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it runs only for a requested hosted preview", () => {
|
||||
const deploy = review.jobs.deploy;
|
||||
assert.deepEqual(deploy.needs, ["targets", "capture", "report"]);
|
||||
assert.equal(deploy.if, "needs.capture.outputs.preview == 'eas'");
|
||||
assert.equal(deploy.if, "needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()");
|
||||
assert.deepEqual(deploy.permissions, { contents: "read", actions: "read", "pull-requests": "write" });
|
||||
const step = deploy.steps.find(step => step.name === "Deploy the hosted preview and publish its Explore report links");
|
||||
assert.equal(step.env.EXPO_TOKEN, "${{ secrets.EXPO_TOKEN }}");
|
||||
@@ -304,7 +305,8 @@ test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it
|
||||
assert.deepEqual(downloads.map(step => step.with.pattern), ["explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*", "explore-review-${{ github.run_id }}-${{ github.run_attempt }}-*"]);
|
||||
assert.ok(downloads.every(step => step.with.name === undefined && step.with["merge-multiple"] === undefined));
|
||||
assert.doesNotMatch(JSON.stringify(deploy), /OPENAI_API_KEY|ANTHROPIC_API_KEY/);
|
||||
assert.equal(review.jobs.report.outputs, undefined);
|
||||
// A report job hands forward only whether it published; its artifact URL is looked up again (matrix outputs keep one leg's value).
|
||||
assert.deepEqual(review.jobs.report.outputs, { published: "${{ steps.publish.outputs.published }}" });
|
||||
// capture:review writes preview=<hosting> to the step outputs from the reviewed config.
|
||||
assert.equal(review.jobs.capture.outputs.preview, "${{ steps.capture.outputs.preview }}");
|
||||
assert.match(review.jobs.capture.steps.find(step => step.id === "capture").run, /capture:review/);
|
||||
@@ -313,6 +315,48 @@ test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it
|
||||
assert.match(review.jobs.failure.if, /needs\.deploy\.result == 'failure'/);
|
||||
});
|
||||
|
||||
test("one target's failed capture keeps neither the other targets' reports nor the preview off the PR (brentvatne/euxy#172)", async t => {
|
||||
for (const workflow of [review, compare]) {
|
||||
const report = workflow.jobs.report;
|
||||
// A plain needs: [capture] skips every report once one capture leg fails; !cancelled() runs them, except in a cancelled run.
|
||||
assert.equal(report.if, "needs.targets.result == 'success' && !cancelled()");
|
||||
assert.deepEqual(report.needs, ["targets", "capture"]);
|
||||
const [download, check] = report.steps;
|
||||
assert.ok(download.uses.startsWith("actions/download-artifact@"));
|
||||
// A pattern without a wildcard names this leg's artifact alone, and matching nothing is not a failure, as a name is.
|
||||
assert.deepEqual(download.with, { pattern: "explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}", path: "${{ runner.temp }}/explore-review" });
|
||||
assert.equal(download["continue-on-error"], undefined, "a download that went wrong still fails the leg");
|
||||
assert.equal(check.id, "captured");
|
||||
const explore = report.steps.filter(step => /cli\.js" ci:(report|publish)/.test(step.run ?? "") || step.uses?.startsWith("actions/upload-artifact@") && step.if !== "always()");
|
||||
assert.equal(explore.length, 3);
|
||||
for (const step of explore) assert.equal(step.if, "steps.captured.outputs.found == 'true'", step.name);
|
||||
const publish = report.steps.find(step => step.id === "publish");
|
||||
assert.match(publish.run, /ci:publish[^\n]*\n\s*echo "published=true" >> "\$GITHUB_OUTPUT"/, "published only once ci:publish succeeded");
|
||||
assert.deepEqual(report.outputs, { published: "${{ steps.publish.outputs.published }}" });
|
||||
assert.equal(workflow.jobs.deploy.if, "needs.report.outputs.published == 'true' && needs.capture.outputs.preview == 'eas' && !cancelled()");
|
||||
assert.deepEqual(workflow.jobs.deploy.needs, ["targets", "capture", "report"]);
|
||||
// The check reads what the download left: this target's report input, or nothing.
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-report-check-"));
|
||||
t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const runCheck = async () => {
|
||||
const output = join(root, "output"); await writeFile(output, "");
|
||||
const result = spawnSync("bash", ["-c", check.run], { encoding: "utf8", env: { ...process.env, RUNNER_TEMP: root, GITHUB_OUTPUT: output, TARGET: "duo-open" } });
|
||||
assert.equal(result.status, 0, result.stderr);
|
||||
return { output: await readFile(output, "utf8"), stdout: result.stdout };
|
||||
};
|
||||
const failed = await runCheck();
|
||||
assert.equal(failed.output, "");
|
||||
assert.match(failed.stdout, /The duo-open capture uploaded no review: its capture job failed/);
|
||||
await mkdir(join(root, "explore-review"), { recursive: true });
|
||||
await writeFile(join(root, "explore-review", "report-input.json"), "{}");
|
||||
assert.equal((await runCheck()).output, "found=true\n");
|
||||
}
|
||||
// The failure job still runs when a capture leg failed, and names that target from its diagnostics.
|
||||
const failure = review.jobs.failure;
|
||||
assert.match(failure.if, /^always\(\) && \(.*needs\.capture\.result == 'failure'.*needs\.report\.result == 'failure'/);
|
||||
for (const step of failure.steps.filter(step => step.uses?.startsWith("actions/download-artifact@"))) assert.equal(step["continue-on-error"], true, step.name);
|
||||
});
|
||||
|
||||
test("closing a pull request runs nothing: hosted previews stay until a developer deletes them", () => {
|
||||
assert.ok(!review.on.pull_request_target.types.includes("closed"));
|
||||
assert.doesNotMatch(review.jobs.targets.if, /closed/);
|
||||
@@ -325,16 +369,21 @@ test("review captures and reports each configured target in its own matrix job,
|
||||
assert.deepEqual(targets.permissions, { contents: "read", "pull-requests": "read" });
|
||||
assert.equal(targets.outputs.targets, "${{ steps.targets.outputs.targets }}");
|
||||
// config:targets lists ids in config order; a config without targets: lists ["ios"] / ["ios","android"], as config:platforms did.
|
||||
assert.match(targets.steps.at(-1).run, /config:targets --project "\$GITHUB_WORKSPACE\/app-head\/\$APP_PROJECT_DIR" --config \.expo-explore\/config\.yaml \| jq -c '\[\.targets\[\]\.id\]'/);
|
||||
assert.match(targets.steps.at(-1).run, /config:targets --project "\$GITHUB_WORKSPACE\/app-head\/\$APP_PROJECT_DIR" --config \.expo-explore\/config\.yaml/);
|
||||
assert.equal(targets.outputs.max_parallel, "${{ steps.targets.outputs.max_parallel }}");
|
||||
assert.doesNotMatch(JSON.stringify(targets), /EXPO_TOKEN|OPENAI_API_KEY|ANTHROPIC_API_KEY|APP_REVIEW/);
|
||||
for (const workflow of [review, compare, baseline]) {
|
||||
assert.doesNotMatch(JSON.stringify(workflow), /matrix\.platform|config:platforms|\$PLATFORM|needs\.platforms/, "every job is keyed by target, never by platform");
|
||||
assert.match(JSON.stringify(workflow), /matrix\.target/, "doctor looks for matrix.target in an installed workflow");
|
||||
}
|
||||
for (const job of [review.jobs.capture, review.jobs.report]) {
|
||||
assert.deepEqual(job.strategy, { "fail-fast": false, matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
|
||||
// Each capture job needs a simulator session, so at most capture.maxSessions of them run at once; a report needs none.
|
||||
for (const job of [review.jobs.capture, compare.jobs.capture]) {
|
||||
assert.deepEqual(job.strategy, { "fail-fast": false, "max-parallel": "${{ fromJSON(needs.targets.outputs.max_parallel) }}",
|
||||
matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
|
||||
assert.equal(job.env.TARGET, "${{ matrix.target }}");
|
||||
}
|
||||
assert.deepEqual(review.jobs.report.strategy, { "fail-fast": false, matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
|
||||
assert.equal(review.jobs.report.env.TARGET, "${{ matrix.target }}");
|
||||
assert.equal(review.jobs.capture.needs, "targets");
|
||||
assert.deepEqual(review.jobs.report.needs, ["targets", "capture"]);
|
||||
const runs = [review.jobs.capture, review.jobs.report, baseline.jobs.baseline].flatMap(job => job.steps.filter(step => step.run).map(step => step.run));
|
||||
@@ -378,3 +427,27 @@ test("compare reviews any two refs from a manual run or another workflow, with n
|
||||
assert.match(compare.jobs.capture.steps.find(step => step.id === "capture").run, /printf '%s' "\$COMPARE" > "\$RUNNER_TEMP\/explore-compare\.json"/);
|
||||
assert.match(compare.jobs.deploy.steps.at(-1).run, /ci:deploy --inputs/);
|
||||
});
|
||||
|
||||
test("the targets job lists the target ids and how many capture jobs run at once: no more than capture.maxSessions", async t => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-targets-step-"));
|
||||
t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const tools = new URL("../..", import.meta.url).pathname;
|
||||
const run = async (workflow, checkout, config) => {
|
||||
const project = join(root, checkout); await mkdir(join(project, ".expo-explore"), { recursive: true });
|
||||
await writeFile(join(project, ".expo-explore", "config.yaml"), config);
|
||||
const output = join(root, "output"); await writeFile(output, "");
|
||||
const step = workflow.jobs.targets.steps.find(entry => entry.id === "targets");
|
||||
const result = spawnSync("bash", ["-c", step.run], { encoding: "utf8",
|
||||
env: { PATH: process.env.PATH, HOME: root, TOOLS: tools, GITHUB_WORKSPACE: root, APP_PROJECT_DIR: ".", GITHUB_OUTPUT: output } });
|
||||
assert.equal(result.status, 0, result.stderr);
|
||||
const outputs = Object.fromEntries((await readFile(output, "utf8")).trim().split("\n").map(line => line.split(/=(.*)/s).slice(0, 2)));
|
||||
return { targets: JSON.parse(outputs.targets), maxParallel: JSON.parse(outputs.max_parallel) };
|
||||
};
|
||||
const app = "app:\n bundleId: com.example.app\n easProfile: explore\ndevice:\n name: iPhone 17\n";
|
||||
const five = "targets:\n" + ["iphone", "ipad", "duo-closed", "duo-open"].map(id => ` ${id}: { platform: ios }\n`).join("") + " pixel: { platform: android, bundleId: com.example.app, easProfile: explore }\n";
|
||||
for (const [workflow, checkout] of [[review, "app-head"], [compare, "app-head"], [baseline, "app"]]) {
|
||||
assert.deepEqual(await run(workflow, checkout, app + five), { targets: ["iphone", "ipad", "duo-closed", "duo-open", "pixel"], maxParallel: 5 }, "unset: five");
|
||||
assert.deepEqual((await run(workflow, checkout, app + "capture:\n maxSessions: 2\n" + five)).maxParallel, 2, "a starter plan's two");
|
||||
assert.deepEqual(await run(workflow, checkout, app), { targets: ["ios"], maxParallel: 1 });
|
||||
}
|
||||
});
|
||||
@@ -0,0 +1,135 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import test from "node:test";
|
||||
|
||||
import { startArgentBridgeRunner } from "../../dist/capture/argent-bridge-host.js";
|
||||
import { ARGENT_VERSION } from "../../dist/shared/argent-version.js";
|
||||
|
||||
const PNG = Buffer.from("iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+A8AAQUBAScY42YAAAAASUVORK5CYII=", "base64");
|
||||
|
||||
async function fakeClient(root, body) {
|
||||
const module = join(root, "client.mjs");
|
||||
await writeFile(module, `const calls = [];\nexport function createArgentClient() { return { calls, async callTool(name, args, options) { calls.push({ name, args }); ${body} } }; }\n`);
|
||||
return module;
|
||||
}
|
||||
|
||||
test("the bridge thread answers the capture's commands through Argent's client and falls back for other executables", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-argent-bridge-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
await writeFile(join(root, "shot.png"), PNG);
|
||||
const clientModule = await fakeClient(root, `
|
||||
if (name === "list-devices") return { data: { devices: [{ udid: "UDID-1", name: "iPhone 17", state: "Booted", platform: "ios", runtime: "iOS 26.0" }] } };
|
||||
if (name === "screenshot") return { data: { path: ${JSON.stringify(join(root, "shot.png"))} } };
|
||||
if (name === "await-screen-idle") { if (options?.signal?.aborted) throw options.signal.reason; await new Promise((resolve, reject) => { const timer = setTimeout(resolve, 5_000); options?.signal?.addEventListener("abort", () => { clearTimeout(timer); reject(options.signal.reason); }); }); return { data: { idle: true } }; }
|
||||
throw new Error("unexpected tool " + name);`);
|
||||
const fallbackCalls = [];
|
||||
const environment = { EXPLORE_ARGENT_STATE: join(root, "state.json"), EXPLORE_ARGENT_PLATFORM: "ios", ARGENT_TOOLS_URL: "http://127.0.0.1:9/tools", HOME: root, PATH: process.env.PATH };
|
||||
const bridge = startArgentBridgeRunner({ command: "/opt/argent-controller", environment, clientModule, fallback: request => { fallbackCalls.push(request.args[0]); return { stdout: "{}", stderr: "" }; } });
|
||||
t.after(() => bridge.close());
|
||||
const request = args => ({ command: "/opt/argent-controller", args, cwd: root, environment, timeoutMs: 20_000 });
|
||||
|
||||
const version = bridge.runner(request(["--version"]));
|
||||
assert.equal(version.stdout.trim(), ARGENT_VERSION);
|
||||
const shot = JSON.parse(bridge.runner(request(["screenshot", join(root, "out", "screen.png"), "--session", "explore", "--platform", "ios", "--json"])).stdout);
|
||||
assert.equal(shot.success, true);
|
||||
assert.deepEqual(await readFile(join(root, "out", "screen.png")), PNG, "the materialized artifact is copied where the command asked");
|
||||
assert.ok(bridge.active);
|
||||
|
||||
bridge.runner({ command: "/usr/bin/other", args: ["noop"], cwd: root, environment });
|
||||
assert.deepEqual(fallbackCalls, ["noop"], "other executables go to the fallback runner");
|
||||
|
||||
const started = Date.now();
|
||||
assert.throws(() => bridge.runner({ ...request(["wait", "stable", "500", "8000", "--session", "explore", "--platform", "ios", "--json"]), timeoutMs: 300 }), /timed out after 300 ms/);
|
||||
assert.ok(Date.now() - started < 5_000, "a timed-out command is aborted, not waited out");
|
||||
assert.ok(bridge.active, "the thread answered the abort, so it keeps serving");
|
||||
assert.equal(bridge.runner(request(["--version"])).stdout.trim(), ARGENT_VERSION);
|
||||
});
|
||||
|
||||
test("a thread whose Argent client cannot load hands every command to the fallback runner", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-argent-bridge-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const fallbackCalls = [];
|
||||
const environment = { EXPLORE_ARGENT_STATE: join(root, "state.json"), EXPLORE_ARGENT_PLATFORM: "ios", ARGENT_TOOLS_URL: "http://127.0.0.1:9/tools", HOME: root, PATH: process.env.PATH };
|
||||
const bridge = startArgentBridgeRunner({ command: "/opt/argent-controller", environment, clientModule: join(root, "missing.mjs"), fallback: request => { fallbackCalls.push(request.args[0]); return { stdout: "{}", stderr: "" }; } });
|
||||
t.after(() => bridge.close());
|
||||
bridge.runner({ command: "/opt/argent-controller", args: ["snapshot", "--json"], cwd: root, environment, timeoutMs: 20_000 });
|
||||
bridge.runner({ command: "/opt/argent-controller", args: ["screenshot", "x.png", "--json"], cwd: root, environment, timeoutMs: 20_000 });
|
||||
assert.deepEqual(fallbackCalls, ["snapshot", "screenshot"]);
|
||||
assert.equal(bridge.active, false);
|
||||
});
|
||||
|
||||
test("a session whose tool-server was replaced is driven at the new one: the thread starts again with the changed environment", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-argent-bridge-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
await writeFile(join(root, "shot.png"), PNG);
|
||||
// The fake client notes which tool-server it was given, as Argent's reads ARGENT_TOOLS_URL from its environment.
|
||||
const clientModule = await fakeClient(root, `
|
||||
if (name === "list-devices") return { data: { devices: [{ udid: "UDID-1", name: "iPhone 17", state: "Booted", platform: "ios", runtime: "iOS 26.0" }] } };
|
||||
if (name === "screenshot") { (await import("node:fs")).appendFileSync(${JSON.stringify(join(root, "servers.txt"))}, process.env.ARGENT_TOOLS_URL + "\\n"); return { data: { path: ${JSON.stringify(join(root, "shot.png"))} } }; }
|
||||
throw new Error("unexpected tool " + name);`);
|
||||
const environment = { EXPLORE_ARGENT_STATE: join(root, "state.json"), EXPLORE_ARGENT_PLATFORM: "ios", ARGENT_TOOLS_URL: "http://127.0.0.1:9/old", HOME: root, PATH: process.env.PATH };
|
||||
const bridge = startArgentBridgeRunner({ command: "/opt/argent-controller", environment, clientModule, fallback: () => assert.fail("the thread serves every command") });
|
||||
t.after(() => bridge.close());
|
||||
const screenshot = () => JSON.parse(bridge.runner({ command: "/opt/argent-controller", args: ["screenshot", join(root, "out", "screen.png"), "--session", "explore", "--platform", "ios", "--json"],
|
||||
cwd: root, environment, timeoutMs: 20_000 }).stdout);
|
||||
assert.equal(screenshot().success, true);
|
||||
// As the capture's local recovery does: the same environment object, pointed at the restarted tool-server.
|
||||
Object.assign(environment, { ARGENT_TOOLS_URL: "http://127.0.0.1:9/new", ARGENT_AUTH_TOKEN: "new-token" });
|
||||
assert.equal(screenshot().success, true);
|
||||
assert.deepEqual((await readFile(join(root, "servers.txt"), "utf8")).trim().split("\n"), ["http://127.0.0.1:9/old", "http://127.0.0.1:9/new"]);
|
||||
assert.ok(bridge.active);
|
||||
});
|
||||
|
||||
test("a thread that crashes stops serving, and the commands after it run per command", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-argent-bridge-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
await writeFile(join(root, "shot.png"), PNG);
|
||||
// An exception nothing catches, thrown on the thread well after its answer.
|
||||
const clientModule = await fakeClient(root, `
|
||||
if (name === "list-devices") return { data: { devices: [{ udid: "UDID-1", name: "iPhone 17", state: "Booted", platform: "ios", runtime: "iOS 26.0" }] } };
|
||||
if (name === "screenshot") { setTimeout(() => { throw new Error("the client crashed"); }, 300); return { data: { path: ${JSON.stringify(join(root, "shot.png"))} } }; }
|
||||
throw new Error("unexpected tool " + name);`);
|
||||
const fallbackCalls = [], messages = [];
|
||||
const environment = { EXPLORE_ARGENT_STATE: join(root, "state.json"), EXPLORE_ARGENT_PLATFORM: "ios", ARGENT_TOOLS_URL: "http://127.0.0.1:9/tools", HOME: root, PATH: process.env.PATH };
|
||||
const bridge = startArgentBridgeRunner({ command: "/opt/argent-controller", environment, clientModule, progress: message => messages.push(message),
|
||||
fallback: request => { fallbackCalls.push(request.args[0]); return { stdout: "{}", stderr: "" }; } });
|
||||
t.after(() => bridge.close());
|
||||
const request = args => ({ command: "/opt/argent-controller", args, cwd: root, environment, timeoutMs: 20_000 });
|
||||
assert.equal(JSON.parse(bridge.runner(request(["screenshot", join(root, "out", "screen.png"), "--session", "explore", "--platform", "ios", "--json"])).stdout).success, true);
|
||||
await new Promise(resolve => setTimeout(resolve, 1_500));
|
||||
assert.equal(bridge.active, false);
|
||||
assert.match(messages.join("\n"), /the Argent bridge thread failed \(the client crashed\)/);
|
||||
bridge.runner(request(["snapshot", "--json"]));
|
||||
assert.deepEqual(fallbackCalls, ["snapshot"]);
|
||||
});
|
||||
|
||||
test("a recording runs per command, and a screenshot is taken only from a file that is an image", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-argent-bridge-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
await writeFile(join(root, "shot.png"), PNG);
|
||||
await writeFile(join(root, "notes.txt"), "not a screenshot\n");
|
||||
const answer = join(root, "answer.json");
|
||||
const clientModule = await fakeClient(root, `
|
||||
if (name === "list-devices") return { data: { devices: [{ udid: "UDID-1", name: "iPhone 17", state: "Booted", platform: "ios", runtime: "iOS 26.0" }] } };
|
||||
if (name === "screenshot") return { data: JSON.parse((await import("node:fs")).readFileSync(${JSON.stringify(answer)}, "utf8")) };
|
||||
throw new Error("unexpected tool " + name);`);
|
||||
const fallbackCalls = [];
|
||||
const environment = { EXPLORE_ARGENT_STATE: join(root, "state.json"), EXPLORE_ARGENT_PLATFORM: "ios", ARGENT_TOOLS_URL: "http://127.0.0.1:9/tools", HOME: root, PATH: process.env.PATH };
|
||||
const bridge = startArgentBridgeRunner({ command: "/opt/argent-controller", environment, clientModule,
|
||||
fallback: request => { fallbackCalls.push(request.args.slice(0, 2).join(" ")); return { stdout: "{}", stderr: "" }; } });
|
||||
t.after(() => bridge.close());
|
||||
const request = args => ({ command: "/opt/argent-controller", args, cwd: root, environment, timeoutMs: 20_000 });
|
||||
|
||||
bridge.runner(request(["record", "start", join(root, "launch.mp4"), "--scope", "app", "--json"]));
|
||||
bridge.runner(request(["record", "stop", "--json"]));
|
||||
assert.deepEqual(fallbackCalls, ["record start", "record stop"], "recordings go to the per-command bridge");
|
||||
assert.ok(bridge.active);
|
||||
|
||||
const screenshot = out => JSON.parse(bridge.runner({ ...request(["screenshot", out, "--session", "explore", "--platform", "ios", "--json"]), allowFailure: true }).stdout);
|
||||
// A path to a file that is not an image is not a screenshot, whatever its key; the image beside it is.
|
||||
await writeFile(answer, JSON.stringify({ path: join(root, "notes.txt"), image: join(root, "shot.png") }));
|
||||
assert.equal(screenshot(join(root, "out", "one.png")).success, true);
|
||||
assert.deepEqual(await readFile(join(root, "out", "one.png")), PNG);
|
||||
await writeFile(answer, JSON.stringify({ path: join(root, "notes.txt") }));
|
||||
const failed = screenshot(join(root, "out", "two.png"));
|
||||
assert.equal(failed.success, false);
|
||||
assert.match(failed.error.message, /did not write/);
|
||||
await assert.rejects(readFile(join(root, "out", "two.png")), { code: "ENOENT" });
|
||||
});
|
||||
@@ -201,6 +201,8 @@ test("Android fill uses Argent's fill and requires it to verify the text", async
|
||||
const snapshot = await run(["snapshot", ...flags("android")]);
|
||||
const node = snapshot.json.data.nodes.find(item => item.type === "TextField");
|
||||
assert.ok(node, "the rename fixture has an EditText");
|
||||
assert.equal(node.focused, true, "the focused field is marked, as agent-device marks it");
|
||||
assert.equal(snapshot.json.data.keyboardVisible, false, "whether a keyboard shows, which the Android tree cannot say, is passed on");
|
||||
assert.equal((await run(["fill", node.ref, ...flags("android"), "--", "Groove"])).exitCode, 0);
|
||||
assert.deepEqual(calls.find(call => call.tool === "fill").args, { udid: "emulator-5554", text: "Groove" });
|
||||
const unverified = await run(["fill", node.ref, ...flags("android"), "--", "Groove"]);
|
||||
@@ -439,6 +441,42 @@ test("a reader stuck on the dark panel after a fold is reset once more before th
|
||||
assert.equal(stuck.calls.filter(call => call.tool === "stop-all-simulator-servers").length, 2, "before the fold and once after, not in a loop");
|
||||
});
|
||||
|
||||
// brentvatne/euxy#172, review run 39348956443: the fold after capture restarted SpringBoard failed with this, before it ran.
|
||||
const DEPENDENCY_FAILED = "argent run fold failed: [Tool:fold] Service dependency failed: [SimulatorServer:74195B53-4DBC-4EAA-9991-F98E5BB86BA8] Timed out waiting for simulator-server to become ready";
|
||||
|
||||
test("a fold whose simulator-server did not start is sent again after a pause, and then folds", async () => {
|
||||
const lit = { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 };
|
||||
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": DUO_OPEN_EDIT_LANE, "stop-all-simulator-servers": { stopped: [] },
|
||||
fold: [new ArgentCallError(DEPENDENCY_FAILED, true), lit] });
|
||||
const pauses = [];
|
||||
context.sleep = async milliseconds => { pauses.push(milliseconds); };
|
||||
assert.deepEqual((await run(["fold", "open", ...flags("ios")])).json.data, { action: "fold", pose: "open" });
|
||||
assert.equal(calls.filter(call => call.tool === "fold").length, 2);
|
||||
assert.deepEqual(pauses, [3_000], "one pause before the fold is sent again");
|
||||
});
|
||||
|
||||
test("a fold whose simulator-server never starts fails as it did before, after two more tries", async () => {
|
||||
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": DUO_OPEN_EDIT_LANE, "stop-all-simulator-servers": { stopped: [] },
|
||||
fold: new ArgentCallError(DEPENDENCY_FAILED, true) });
|
||||
const pauses = [];
|
||||
context.sleep = async milliseconds => { pauses.push(milliseconds); };
|
||||
const failed = await run(["fold", "open", ...flags("ios")]);
|
||||
assert.deepEqual(failed.json.error, { code: "ARGENT_TOOL_FAILED", message: DEPENDENCY_FAILED });
|
||||
assert.equal(calls.filter(call => call.tool === "fold").length, 3);
|
||||
assert.deepEqual(pauses, [3_000, 6_000]);
|
||||
});
|
||||
|
||||
test("a UI action that failed for another reason is still sent once, even when its message mentions a dependency", async () => {
|
||||
// Only the tool's own wrap counts: a nested tool's dependency failure is not this tool failing to start.
|
||||
for (const message of ["argent run gesture-tap failed: [Tool:gesture-tap] simulator-server answered 500",
|
||||
"argent run gesture-tap failed: [Tool:gesture-tap] [Tool:keyboard] Service dependency failed: [SimulatorServer:x] Timed out"]) {
|
||||
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-tap": new ArgentCallError(message, true) });
|
||||
const pressed = await run(["press", "10", "10", ...flags("ios")]);
|
||||
assert.deepEqual(pressed.json.error, { code: "ARGENT_TOOL_FAILED", message });
|
||||
assert.equal(calls.filter(call => call.tool === "gesture-tap").length, 1, message);
|
||||
}
|
||||
});
|
||||
|
||||
test("an alert that is not the link prompt is left for capture to answer", async () => {
|
||||
const other = { ...IOS_HOME, alertVisible: true, foregroundApp: "com.apple.springboard",
|
||||
roots: [{ type: "Alert", label: "Delete all data?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [
|
||||
|
||||
@@ -135,6 +135,9 @@ test("capture recipes exclude display settings but bind agent instructions and c
|
||||
assert.equal(JSON.parse(key).observer, CAPTURE_OBSERVER_HASH);
|
||||
assert.match(JSON.parse(key).observer, /^[a-f0-9]{64}$/);
|
||||
assert.equal(key,captureRecipeConfig({...config,app:{...config.app,name:"Renamed display"}}));
|
||||
// How many sessions capture it does not change the evidence: a baseline captured under any ceiling serves the review.
|
||||
assert.equal(key,captureRecipeConfig({...config,capture:{...config.capture,maxSessions:16}}));
|
||||
assert.equal(captureRecipeConfig({...config,capture:{...config.capture,maxSessions:4}}),captureRecipeConfig({...config,capture:{...config.capture,maxSessions:16}}));
|
||||
// An unset repack is keyed as it resolves, so configs that never chose one keep the recipe of the old written-out default.
|
||||
assert.equal(key,captureRecipeConfig({...config,capture:{...config.capture,repack:"eas"}}));
|
||||
assert.equal(JSON.parse(key).capture.repack, "eas");
|
||||
|
||||
@@ -173,6 +173,22 @@ test("CI argument failures preserve JSON output, annotation, summary, and diagno
|
||||
assert.match(await readFile(summary, "utf8"), /Next action/);
|
||||
});
|
||||
|
||||
test("a failed command's diagnostics file names the matrix target it ran for, so the failure comment can", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-cli-target-"));
|
||||
t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const cli = new URL("../../src/cli.ts", import.meta.url);
|
||||
const run = target => {
|
||||
const result = spawnSync(process.execPath, ["--import", "tsx", cli.pathname, "ci:report", "--input", join(root, "missing.json"), "--output", join(root, "out"), "--target", target],
|
||||
{ encoding: "utf8", env: { ...process.env, GITHUB_ACTIONS: "true", RUNNER_TEMP: root } });
|
||||
assert.equal(result.status, 1, result.stderr);
|
||||
return readFile(join(root, "explore-diagnostics/error.json"), "utf8").then(JSON.parse);
|
||||
};
|
||||
const written = await run("duo-closed");
|
||||
assert.equal(written.target, "duo-closed");
|
||||
assert.equal(written.code, "REPORT_INPUT_INVALID");
|
||||
assert.equal((await run("../ios")).target, undefined, "only a valid target id is written");
|
||||
});
|
||||
|
||||
test("source worker failures emit a structured diagnostic without a raw stack", () => {
|
||||
const worker = new URL("../../src/source/plan-worker.ts", import.meta.url);
|
||||
const result = spawnSync(process.execPath, ["--import", "tsx", worker.pathname], { input: "{", encoding: "utf8" });
|
||||
|
||||
@@ -14,7 +14,10 @@ import { AGENT_DEVICE_VERSION, captureDeepLink, controllerCommandFailure, revisi
|
||||
import { CiError, serializeCiError } from '../../dist/shared/ci-errors.js';
|
||||
import { createSourceCapturePlan } from '../../dist/source/capture-plan.js';
|
||||
import { CAPTURE_OBSERVER_IDENTIFIER } from '../../dist/capture/observer.js';
|
||||
import { parseRuntimeExecutionContext } from '../../dist/review/runtime-adapter.js';
|
||||
import { parseRuntimeExecutionContext, runtimeEvidenceInputFromMap } from '../../dist/review/runtime-adapter.js';
|
||||
import { readExportedMap } from '../../dist/review/evidence-assessment.js';
|
||||
import { projectRuntimeEvidence } from '../../dist/review/runtime-evidence.js';
|
||||
import { mergeCaptureExports } from '../../dist/ci/export-merge.js';
|
||||
import { assertCompleteCaptures, hasVerifiedCapture } from '../../dist/capture/health.js';
|
||||
import { readCaptureBundle } from '../../dist/review/capture-review.js';
|
||||
import { writeCaptureObserverPackages } from '../helpers/capture-observer-fixture.mjs';
|
||||
@@ -66,6 +69,18 @@ const unreadableSurface = () => json({ success: false, error: { code: 'COMMAND_F
|
||||
details: { hint: 'com.apple.SafariViewService hosts the surface presented over the app, and this capture targeted that surface. No snapshot backend could read this screen (XCTest-backed snapshot tiers were deferred after recent slow accessibility work on this screen).' } } });
|
||||
|
||||
|
||||
/**
|
||||
* The iOS 26 keyboard as agent-device reports it: the Keyboard element with its keys beneath it, and the dock's Emoji and
|
||||
* Dictate buttons, which its host bridge names by their view class (brentvatne/euxy#172, review run 39362642343).
|
||||
*/
|
||||
const softKeyboard = [
|
||||
{ index: 900, type: 'Application', rect: { x: 0, y: 0, width: 402, height: 874 }, visible: true },
|
||||
{ index: 902, parentIndex: 900, type: 'Keyboard', rect: { x: 0, y: 583, width: 402, height: 233 }, visible: true },
|
||||
{ index: 903, parentIndex: 902, type: 'Key', label: 'Q', rect: { x: 5, y: 590, width: 39, height: 54 }, visible: true },
|
||||
{ index: 905, parentIndex: 900, type: 'Button', role: 'UIKeyboardDockItemButton', label: 'Emoji', rect: { x: 8, y: 806, width: 68, height: 68 }, visible: true },
|
||||
{ index: 906, parentIndex: 900, type: 'Button', role: 'UIKeyboardDockItemButton', label: 'Dictate', identifier: 'dictation', rect: { x: 325, y: 806, width: 68, height: 68 }, visible: true },
|
||||
];
|
||||
|
||||
function agentFixture(actions, observedRequests = []) {
|
||||
return { instructions: 'Capture each selected route in its normal loaded state.', contexts: {},
|
||||
provider: { provider: 'anthropic', model: 'test-model', preflight: async () => {}, run: async request => {
|
||||
@@ -114,6 +129,8 @@ async function fixture(t, settings = {}) {
|
||||
let enteredName = false; let scrolledToContinue = false; let finishHidden = false; let wedgeCleared = false; let deviceLost = false; let relaunchedAfterForeign = false; let serverStarts = 0; let unreadableLeft = settings.unreadableAfterFold ?? 0;
|
||||
// startsErrored / startsUnnamed: how many session starts EAS fails, after naming the session (it ERRORS) or before.
|
||||
let starts = 0; let currentSession = 'session-1'; const erroredSessions = new Set(); let foldUnverifiedLeft = settings.foldUnverified ?? 0;
|
||||
// focusedField: the screen at `path` focuses its text field, and the keyboard is up from the `keyboardFrom`th read of it.
|
||||
let focusedReads = 0;
|
||||
// blackAfterFold: the first so many folds of an EAS agent-device session light the panel but draw nothing.
|
||||
let folds = 0;
|
||||
const deviceName = settings.android ? 'Pixel 7' : 'iPhone 17 Pro';
|
||||
@@ -366,6 +383,8 @@ async function fixture(t, settings = {}) {
|
||||
] : []),
|
||||
...(settings.statefulSetup && current === '/transient' ? [{ type: 'Button', label: 'Finish', ref: 'e103', enabled: true, visible: !finishHidden }] : []),
|
||||
...(alert ? [{ type: 'Alert', label: alert.message }, ...alert.items.map((label, index) => ({ type: 'Button', label, ref: `e${index + 1}`, enabled: true, visible: true }))] : []),
|
||||
...(settings.focusedField?.path === current ? [{ type: 'TextField', label: 'Pattern name', focused: true, visible: true, rect: { x: 23, y: 386, width: 355, height: 50 } },
|
||||
...(++focusedReads >= (settings.focusedField.keyboardFrom ?? Infinity) ? softKeyboard : [])] : []),
|
||||
...(settings.missingObserver || settings.missingObserverAt === current ? [] : [observer]),
|
||||
// A second active destination is ambiguous; the host AX bridge's identical copy is not.
|
||||
...(settings.duplicateObserver ? [{ ...observer, label: JSON.stringify({ provider: 'expo-router', pathname: '/other', segments: ['other'], parameters: {} }) }] : []),
|
||||
@@ -1178,6 +1197,46 @@ test('every app link settles before the screen is read', async t => {
|
||||
assert.ok(opened >= 0 && settled > opened && settled < read, 'the settle runs between the link and the first read');
|
||||
});
|
||||
|
||||
const keyboardLog = async f => (await readFile(join(f.options.mapDirectory, 'capture-diagnostics', 'keyboard.jsonl'), 'utf8'))
|
||||
.trim().split('\n').map(line => JSON.parse(line));
|
||||
|
||||
test('a screen whose text field has the focus is captured once its keyboard is up and still, and the keyboard is not one of its elements', async t => {
|
||||
// euxy#172 (review run 39362642343): the rename sheet focuses its field, and the keyboard rises after the sheet settles.
|
||||
const f = await fixture(t, { routes: [route('rename')], focusedField: { path: '/rename', keyboardFrom: 2 } });
|
||||
const result = await runCiMap(f.options);
|
||||
assert.equal(result.outcomes[f.ids.rename].status, 'captured');
|
||||
assert.equal(result.outcomes[f.ids.rename].attempts, 1);
|
||||
assert.deepEqual((await keyboardLog(f)).map(line => [line.route, line.outcome, line.reads]), [[f.ids.rename, 'shown', 2]],
|
||||
'read until the keyboard was up in the same place twice');
|
||||
const calls = f.requests.filter(request => request.command === 'fake-controller').map(request => request.args[0]);
|
||||
const shot = calls.lastIndexOf('screenshot');
|
||||
assert.deepEqual(calls.slice(shot - 3, shot), ['snapshot', 'snapshot', 'snapshot'], 'the destination read, then the keyboard reads, then the screenshot');
|
||||
const map = await readExportedMap(f.options.outputDirectory);
|
||||
const labels = map.observations.flatMap(observation => observation.elements.map(element => element.label));
|
||||
assert.ok(labels.includes('Pattern name'));
|
||||
for (const label of ['Q', 'Emoji', 'Dictate']) assert.equal(labels.includes(label), false, `${label} is the keyboard's, not the app's`);
|
||||
});
|
||||
|
||||
test('a focused field whose keyboard never rises is captured after about a second and at least two reads, without it', async t => {
|
||||
const f = await fixture(t, { routes: [route('rename')], focusedField: { path: '/rename' } });
|
||||
const result = await runCiMap(f.options);
|
||||
assert.equal(result.outcomes[f.ids.rename].status, 'captured');
|
||||
const [line] = await keyboardLog(f);
|
||||
assert.equal(line.outcome, 'absent');
|
||||
assert.ok(line.reads >= 2 && line.reads <= 6 && line.elapsedMs >= 1000, `gave up after ${line.reads} reads in ${line.elapsedMs} ms`);
|
||||
assert.equal(f.operations().includes('keyboard'), false, 'the keyboard is never dismissed or summoned');
|
||||
// A screen without a focused field is not read again.
|
||||
const plain = await fixture(t, { routes: [route('home')] });
|
||||
await runCiMap(plain.options);
|
||||
assert.equal(existsSync(join(plain.options.mapDirectory, 'capture-diagnostics', 'keyboard.jsonl')), false);
|
||||
});
|
||||
|
||||
test('a keyboard already up when the screen is read is captured once a later read finds it in the same place', async t => {
|
||||
const f = await fixture(t, { routes: [route('rename')], focusedField: { path: '/rename', keyboardFrom: 1 } });
|
||||
assert.equal((await runCiMap(f.options)).outcomes[f.ids.rename].status, 'captured');
|
||||
assert.deepEqual((await keyboardLog(f)).map(line => [line.outcome, line.reads]), [['shown', 1]]);
|
||||
});
|
||||
|
||||
test('an application Open button is never an implicit confirmation action', async t => {
|
||||
const f = await fixture(t, { routes: [route('home')], appOpenButton: true });
|
||||
const result = await runCiMap(f.options);
|
||||
@@ -3557,3 +3616,57 @@ test('a verified label is located on the image\'s axes when the screenshot is th
|
||||
// A 669 x 951 portrait panel captured upright as a 951 x 669 image: the button near its bottom-left is near the image's top-left.
|
||||
assert.deepEqual(verifiedCaptureLabels(nodes, ['Done'], { height: 951 })[0].rect, { x: 11, y: 10, width: 40, height: 100 });
|
||||
});
|
||||
|
||||
test('a session given only the dark pass (appearancePass) captures @dark screens shaped as in a single run', async t => {
|
||||
const f = await fixture(t, { userInterfaceStyle: 'automatic' });
|
||||
const result = await runCiMap({ ...f.options, appearancePass: { all: ['light', 'dark'], capture: ['dark'] } });
|
||||
assert.equal(result.runStatus, 'complete');
|
||||
assert.deepEqual(f.requests.filter(request => request.args[0] === 'settings').map(request => request.args.slice(1, 3)), [['appearance', 'dark']]);
|
||||
assert.equal(f.requests.filter(request => request.args[0] === 'screenshot').length, 2);
|
||||
const map = JSON.parse(await readFile(join(f.options.outputDirectory, 'screen-map.json'), 'utf8'));
|
||||
assert.deepEqual(map.run.environment.colorSchemes, ['light', 'dark']);
|
||||
assert.deepEqual(map.screens.map(screen => [screen.id, screen.colorScheme]), [[`${f.ids.home}@dark`, 'dark'], [`${f.ids.settings}@dark`, 'dark']]);
|
||||
const bundle = JSON.parse(await readFile(join(f.options.outputDirectory, 'bundle.json'), 'utf8'));
|
||||
assert.deepEqual(Object.keys(bundle.images).sort(), [`${f.ids.home}@dark`, `${f.ids.settings}@dark`]);
|
||||
assert.deepEqual(Object.keys(bundle.outcomes).sort(), [`${f.ids.home}@dark`, `${f.ids.settings}@dark`]);
|
||||
assert.equal(bundle.runtimeProfile.colorSchemes, 'light,dark');
|
||||
});
|
||||
|
||||
test('a session given only the dark pass keeps a wrong landing as the unattributed frame its pass recorded, for the export merge', async t => {
|
||||
const f = await fixture(t, { userInterfaceStyle: 'automatic', markerMismatchAt: { path: '/settings', scheme: 'dark' } });
|
||||
const result = await runCiMap({ ...f.options, appearancePass: { all: ['light', 'dark'], capture: ['dark'] } });
|
||||
const dark = `${f.ids.settings}@dark`;
|
||||
// Without the light pass beside it, the frame is not demoted to a lost route: the merge decides, as one run's passes do.
|
||||
assert.equal(result.outcomes[dark].status, 'captured');
|
||||
assert.equal(result.outcomes[dark].landing, 'unverified');
|
||||
assert.equal(result.outcomes[f.ids.settings], undefined);
|
||||
assert.equal(result.runStatus, 'partial');
|
||||
const bundle = JSON.parse(await readFile(join(f.options.outputDirectory, 'bundle.json'), 'utf8'));
|
||||
assert.equal(bundle.images[dark].sha256, result.outcomes[dark].screenshotSha256);
|
||||
assert.deepEqual(Object.keys(bundle.outcomes).sort(), [`${f.ids.home}@dark`, dark].sort());
|
||||
});
|
||||
|
||||
test('a split side merges into the export one run makes: each appearance a verified sibling, its runtime evidence resolvable', async t => {
|
||||
const f = await fixture(t, { userInterfaceStyle: 'automatic' });
|
||||
const at = name => ({ mapDirectory: join(f.root, `map${name}`), outputDirectory: join(f.root, `export${name}`) });
|
||||
await runCiMap({ ...f.options, ...at('-single') });
|
||||
await runCiMap({ ...f.options, ...at(''), appearancePass: { all: ['light', 'dark'], capture: ['light'] } });
|
||||
await runCiMap({ ...f.options, ...at('-dark'), appearancePass: { all: ['light', 'dark'], capture: ['dark'] } });
|
||||
await mergeCaptureExports(join(f.root, 'export'), [{ directory: join(f.root, 'export-dark'), scheme: 'dark' }]);
|
||||
const [single, merged] = await Promise.all(['export-single', 'export'].map(name => readCaptureBundle(join(f.root, name))));
|
||||
assert.deepEqual(Object.keys(merged.images).sort(), Object.keys(single.images).sort());
|
||||
assert.deepEqual(merged.outcomes, single.outcomes);
|
||||
// What a review needs of a sibling appearance (#28): its own verified frame and a map that resolves it as one run's would.
|
||||
const map = await readExportedMap(join(f.root, 'export'));
|
||||
const execution = parseRuntimeExecutionContext(JSON.parse(await readFile(join(f.root, 'export', 'execution.json'), 'utf8')));
|
||||
for (const [route, id] of Object.values(f.ids).flatMap(id => [[id, id], [id, `${id}@dark`]])) {
|
||||
// A verified secondary frame has no outcome of its own: it is verified under its route's, as the review reads it.
|
||||
const outcome = merged.outcomes[id] ?? merged.outcomes[route];
|
||||
assert.equal(outcome.status, 'captured', id); assert.equal(outcome.landing, 'verified', id);
|
||||
assert.ok(existsSync(join(f.root, 'export', merged.images[id].path)), id);
|
||||
const screen = map.screens.find(entry => entry.id === id);
|
||||
assert.equal(screen.observationIds.length, 1, id);
|
||||
projectRuntimeEvidence(runtimeEvidenceInputFromMap({ side: 'head', map, screenId: id, representativeObservationId: screen.observationIds[0],
|
||||
sampleObservationIds: screen.observationIds, expectedSampleCount: 1, profile: 'capture:com.example.app', execution }));
|
||||
}
|
||||
});
|
||||
@@ -331,3 +331,15 @@ test("compare CLI emits a comparison, review, and catalog that reload as a works
|
||||
));
|
||||
assert.deepEqual(shared.baselineScreenIds, ["shared-home"]);
|
||||
});
|
||||
|
||||
test("fingerprints from different Explore versions are not comparable: the match needs review instead of reading as changed", async () => {
|
||||
// A map saved by Explore 0.20.x hashes the tree with the keyboard and the focus in it, unprefixed; a2 hashes leave them out.
|
||||
const baseline = makeMap("main-eeeeeee", [{ id: "home", route: "/", acc: "0".repeat(64) }]);
|
||||
const current = makeMap("pr-3-fffffff", [{ id: "home", route: "/", acc: `a2:${"1".repeat(64)}` }]);
|
||||
const { comparison, review } = generateComparison(baseline, current);
|
||||
await validateComparisonDocument(comparison, baseline, current);
|
||||
const home = review.entries.find((entry) => entry.entryId === "match-home");
|
||||
assert.equal(home.needsReview, true);
|
||||
assert.match(entryById(comparison, "match-home").rationale, /different Explore versions/);
|
||||
assert.ok(home.notes.some((note) => /compare the screenshots/.test(note)));
|
||||
});
|
||||
@@ -823,3 +823,48 @@ test("a capture's snapshot backend is read from its saved controller response",
|
||||
assert.equal(snapshotBackend(directory, map("artifacts/accessibility/missing.json"), "o"), undefined);
|
||||
assert.equal(snapshotBackend(directory, map("../outside.json"), "o"), undefined);
|
||||
});
|
||||
|
||||
/**
|
||||
* Tempo on the closed iPhone Duo in brentvatne/euxy#172 (review run 39362642343): a 1398 × 2034 screenshot of a
|
||||
* 466 × 678 pt screen, and a footnote whose text changed below the fold of its scrolling sheet, so the screenshots match.
|
||||
* The published review carries no accessibility tree, so the footnote's real bounds are unknown: these tests pin the
|
||||
* rule (more than half of the changed element past the screen's edge), not where euxy's footnote was.
|
||||
*/
|
||||
function tempoSide(sideName, footnote, footnoteBounds, image = { width: 1398, height: 2034 }) {
|
||||
const evidence = side(sideName, [
|
||||
element({ elementId: "app", role: "other", label: "euxy", actions: [], actionable: false, bounds: { x: 0, y: 0, width: 466, height: 678, unit: "points" } }),
|
||||
element({ elementId: "title", role: "text", label: "Base Resolution", actions: [], actionable: false, bounds: { x: 26, y: 560, width: 300, height: 24, unit: "points" } }),
|
||||
element({ elementId: `${sideName}-footnote`, role: "text", label: footnote, actions: [], actionable: false, bounds: footnoteBounds }),
|
||||
]);
|
||||
if (image) {
|
||||
evidence.map.artifacts.push({ id: `${sideName}-shot`, kind: "screenshot", path: `${sideName}.png`, sha256: "0".repeat(64), mimeType: "image/png", ...image, createdAt: "2026-09-01T01:00:00.000Z" });
|
||||
evidence.map.observations[0].screenshotArtifactId = `${sideName}-shot`;
|
||||
}
|
||||
return evidence;
|
||||
}
|
||||
const NEW_LANES = "Changes apply live while playing. Base resolution sets the step grid for new lanes.";
|
||||
const ADD_NEXT = "Changes apply live while playing. Base resolution sets the step grid for lanes you add next.";
|
||||
// Its top 12 pt on the screen, 28 pt below the bottom edge: 70% past it.
|
||||
const mostlyBelow = { x: 26, y: 666, width: 414, height: 40, unit: "points" };
|
||||
const offScreenOf = (bounds, assessment = visual("unchanged"), image) => compareSurfaceEvidence({ impact: impact(),
|
||||
base: tempoSide("base", NEW_LANES, bounds, image), head: tempoSide("head", ADD_NEXT, bounds, image), visualAssessment: assessment }).offScreen;
|
||||
|
||||
test("matching screenshots of a change whose elements lie mostly past the screen's edge are off-screen", () => {
|
||||
assert.equal(offScreenOf(mostlyBelow), true);
|
||||
// A turned frame (an opened iPhone Duo shown upright) keeps the tree on the portrait axes: the screen is still found.
|
||||
assert.equal(offScreenOf(mostlyBelow, visual("unchanged"), { width: 2034, height: 1398 }), true);
|
||||
});
|
||||
|
||||
test("a change on the screen, partly on it, with differing screenshots, or with no screen to measure against is never off-screen", () => {
|
||||
const cases = {
|
||||
"an on-screen text change": [{ x: 26, y: 600, width: 414, height: 40, unit: "points" }],
|
||||
// Its top 28 pt on the screen, 12 pt below: mostly visible, so matching pixels prove nothing about it.
|
||||
"a footnote mostly on the screen": [{ x: 26, y: 650, width: 414, height: 40, unit: "points" }],
|
||||
// A control nudged 2 pt past the left edge, otherwise wholly visible.
|
||||
"a control just crossing an edge": [{ x: -2, y: 600, width: 300, height: 40, unit: "points" }],
|
||||
"screenshots that differ": [mostlyBelow, visual("modified")],
|
||||
"no screenshot size": [mostlyBelow, visual("unchanged"), null],
|
||||
"a changed element without bounds": [undefined],
|
||||
};
|
||||
for (const [name, args] of Object.entries(cases)) assert.equal(offScreenOf(...args), undefined, name);
|
||||
});
|
||||
@@ -346,6 +346,15 @@ test("target ids and entries are validated", () => {
|
||||
assert.throws(() => validateExploreConfig({ ...base(), targets }), error => error.code === "CONFIG_INVALID", JSON.stringify(targets));
|
||||
}
|
||||
assert.throws(() => validateExploreConfig({ ...base(), platforms: { ios: {} }, targets: { iphone: { platform: "ios" } } }), /targets or platforms, not both/);
|
||||
const twoTargets = { iphone: { platform: "ios" }, ipad: { platform: "ios" } };
|
||||
assert.equal(validateExploreConfig({ ...base(), targets: twoTargets, capture: { maxSessions: 2 } }).capture.maxSessions, 2);
|
||||
assert.equal("maxSessions" in validateExploreConfig({ ...base(), targets: twoTargets }).capture, false);
|
||||
// A ceiling below the number of targets runs that many target jobs at once (a starter plan's one simulator per platform).
|
||||
assert.equal(validateExploreConfig({ ...base(), targets: twoTargets, capture: { maxSessions: 1 } }).capture.maxSessions, 1);
|
||||
assert.throws(() => validateExploreConfig({ ...base(), capture: { maxSessions: 0 } }), /capture.maxSessions must be a positive integer/);
|
||||
assert.throws(() => validateExploreConfig({ ...base(), capture: { maxSessions: 1.5 } }), /capture.maxSessions must be a positive integer/);
|
||||
const platforms = { ios: {}, android: { bundleId: "com.example.app", easProfile: "explore" } };
|
||||
assert.equal(validateExploreConfig({ ...base(), platforms, capture: { maxSessions: 1 } }).capture.maxSessions, 1);
|
||||
});
|
||||
|
||||
test("a target can choose its own controller and simulator over capture's", () => {
|
||||
|
||||
@@ -0,0 +1,96 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { mkdtemp, mkdir, readFile, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import test from "node:test";
|
||||
|
||||
import { mergeSchemeOutcomes } from "../../dist/capture/appearance.js";
|
||||
import { mergeCaptureExports } from "../../dist/ci/export-merge.js";
|
||||
|
||||
async function writeExport(root, { screens, images, outcomes, launch, diagnostics }) {
|
||||
await mkdir(join(root, "artifacts"), { recursive: true });
|
||||
await mkdir(join(root, "capture-diagnostics"), { recursive: true });
|
||||
const artifacts = [];
|
||||
for (const screen of screens) {
|
||||
const path = `artifacts/${screen}.png`;
|
||||
await writeFile(join(root, path), screen);
|
||||
artifacts.push({ id: `artifact-${screen}`, path, sha256: screen, bytes: screen.length, mimeType: "image/png" });
|
||||
}
|
||||
const map = { contract: "explore.map", revision: 1, run: { id: "run", environment: { colorSchemes: ["light", "dark"] } }, artifacts,
|
||||
screens: screens.map(id => ({ id, colorScheme: id.endsWith("@dark") ? "dark" : "light" })), variants: [], observations: screens.map(id => ({ screenId: id })),
|
||||
elements: [], actionAttempts: [], transitions: [], journeys: [], frontier: [], gaps: [] };
|
||||
await writeFile(join(root, "screen-map.json"), JSON.stringify(map));
|
||||
await writeFile(join(root, "bundle.json"), JSON.stringify({ contract: "explore.bundle", side: "head", runtimeProfile: { colorSchemes: "light,dark" }, images, outcomes, ...(launch ? { launch } : {}) }));
|
||||
await writeFile(join(root, "manifest.json"), JSON.stringify({ contract: "explore.map", runId: "run", revision: 1, files: artifacts.map(({ id: _id, ...file }) => file) }));
|
||||
await writeFile(join(root, "capture-diagnostics", "controller-timing.jsonl"), diagnostics);
|
||||
return root;
|
||||
}
|
||||
|
||||
test("a dark session's export folds into the light session's: @dark frames, outcomes, launch, map records, files and diagnostics", async () => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-merge-"));
|
||||
const primary = await writeExport(join(root, "head-export"), { screens: ["home", "settings"],
|
||||
images: { home: { path: "artifacts/home.png" }, settings: { path: "artifacts/settings.png" } },
|
||||
outcomes: { home: { status: "captured", landing: "verified", attempts: 1 }, settings: { status: "captured", landing: "verified", attempts: 1 } },
|
||||
launch: { light: { splash: "l" } }, diagnostics: "{\"pass\":\"light\"}\n" });
|
||||
const dark = await writeExport(join(root, "head-export-dark"), { screens: ["home@dark", "settings@dark"],
|
||||
images: { "home@dark": { path: "artifacts/[email protected]" }, "settings@dark": { path: "artifacts/[email protected]" } },
|
||||
// A secondary-only run reports a route it lost under the route id, as a run's dark pass does before the passes merge.
|
||||
outcomes: { "home@dark": { status: "captured", landing: "verified", attempts: 2 }, settings: { status: "failed", landing: "unverified", attempts: 3 } },
|
||||
launch: { dark: { splash: "d" } }, diagnostics: "{\"pass\":\"dark\"}\n" });
|
||||
await mergeCaptureExports(primary, [{ directory: dark, scheme: "dark" }]);
|
||||
const bundle = JSON.parse(await readFile(join(primary, "bundle.json"), "utf8"));
|
||||
assert.deepEqual(Object.keys(bundle.images).sort(), ["home", "home@dark", "settings", "settings@dark"]);
|
||||
// As in one run: a dark frame verified beside its light one needs no record of its own; a lost one is the scheme's own outcome.
|
||||
assert.deepEqual(bundle.outcomes, { home: { status: "captured", landing: "verified", attempts: 2 }, settings: { status: "captured", landing: "verified", attempts: 3 },
|
||||
"settings@dark": { status: "failed", landing: "unverified", attempts: 3 } });
|
||||
assert.deepEqual(bundle.launch, { light: { splash: "l" }, dark: { splash: "d" } });
|
||||
const map = JSON.parse(await readFile(join(primary, "screen-map.json"), "utf8"));
|
||||
assert.deepEqual(map.screens.map(screen => screen.id), ["home", "settings", "home@dark", "settings@dark"]);
|
||||
assert.equal(map.observations.length, 4);
|
||||
assert.equal(map.artifacts.length, 4);
|
||||
const manifest = JSON.parse(await readFile(join(primary, "manifest.json"), "utf8"));
|
||||
assert.deepEqual(manifest.files.map(file => file.path).sort(), ["artifacts/home.png", "artifacts/[email protected]", "artifacts/settings.png", "artifacts/[email protected]"]);
|
||||
assert.equal(await readFile(join(primary, "artifacts/[email protected]"), "utf8"), "home@dark");
|
||||
assert.equal(await readFile(join(primary, "capture-diagnostics/controller-timing.jsonl"), "utf8"), "{\"pass\":\"light\"}\n{\"pass\":\"dark\"}\n");
|
||||
// Merging is idempotent for records already present.
|
||||
await mergeCaptureExports(primary, [{ directory: dark, scheme: "dark" }]);
|
||||
assert.equal(JSON.parse(await readFile(join(primary, "screen-map.json"), "utf8")).screens.length, 4);
|
||||
});
|
||||
|
||||
test("merged passes recombine as one run's: an unattributed dark frame beside a verified light one is kept", async () => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-merge-"));
|
||||
const light = { status: "captured", landing: "verified", attempts: 1 };
|
||||
const wrong = { status: "captured", landing: "unverified", attempts: 2, screenshotSha256: "x", observed: { reason: "landing-mismatch", route: "/login", attempts: 2 } };
|
||||
const primary = await writeExport(join(root, "head-export"), { screens: ["settings"], images: { settings: { path: "artifacts/settings.png" } },
|
||||
outcomes: { settings: light }, diagnostics: "" });
|
||||
const dark = await writeExport(join(root, "head-export-dark"), { screens: ["settings@dark"], images: { "settings@dark": { path: "artifacts/[email protected]" } },
|
||||
outcomes: { "settings@dark": wrong }, diagnostics: "" });
|
||||
await mergeCaptureExports(primary, [{ directory: dark, scheme: "dark" }]);
|
||||
const bundle = JSON.parse(await readFile(join(primary, "bundle.json"), "utf8"));
|
||||
assert.deepEqual(bundle.outcomes, mergeSchemeOutcomes([{ settings: light }, { settings: wrong }], ["light", "dark"]));
|
||||
assert.deepEqual(bundle.outcomes["settings@dark"], wrong);
|
||||
});
|
||||
|
||||
test("a dark session that could not show dark (Argent without appearance.set) adds nothing, and an open gap leaves the run partial", async () => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-merge-"));
|
||||
const primary = await writeExport(join(root, "head-export"), { screens: ["home"], images: { home: { path: "artifacts/home.png" } },
|
||||
outcomes: { home: { status: "captured", landing: "verified", attempts: 1 } }, diagnostics: "" });
|
||||
const bundlePath = join(primary, "bundle.json"), mapPath = join(primary, "screen-map.json");
|
||||
// The primary session could not switch either: it captured light only.
|
||||
await writeFile(bundlePath, JSON.stringify({ ...JSON.parse(await readFile(bundlePath, "utf8")), runtimeProfile: { colorScheme: "light" } }));
|
||||
await writeFile(mapPath, JSON.stringify({ ...JSON.parse(await readFile(mapPath, "utf8")), run: { id: "run", status: "complete", environment: {} } }));
|
||||
const narrowed = await writeExport(join(root, "head-export-dark"), { screens: [], images: {}, outcomes: {}, diagnostics: "" });
|
||||
const narrowedBundle = join(narrowed, "bundle.json");
|
||||
await writeFile(narrowedBundle, JSON.stringify({ ...JSON.parse(await readFile(narrowedBundle, "utf8")), runtimeProfile: { colorScheme: "light" } }));
|
||||
await mergeCaptureExports(primary, [{ directory: narrowed, scheme: "dark" }]);
|
||||
assert.deepEqual(Object.keys(JSON.parse(await readFile(bundlePath, "utf8")).outcomes), ["home"]);
|
||||
assert.equal(JSON.parse(await readFile(mapPath, "utf8")).run.status, "complete");
|
||||
|
||||
const gapped = await writeExport(join(root, "other-export-dark"), { screens: ["home@dark"], images: { "home@dark": { path: "artifacts/[email protected]" } },
|
||||
outcomes: { "home@dark": { status: "captured", landing: "verified", attempts: 1 } }, diagnostics: "" });
|
||||
const gappedMap = join(gapped, "screen-map.json");
|
||||
await writeFile(gappedMap, JSON.stringify({ ...JSON.parse(await readFile(gappedMap, "utf8")), gaps: [{ id: "gap-1", status: "open" }] }));
|
||||
await writeFile(bundlePath, JSON.stringify({ ...JSON.parse(await readFile(bundlePath, "utf8")), runtimeProfile: { colorSchemes: "light,dark" } }));
|
||||
await mergeCaptureExports(primary, [{ directory: gapped, scheme: "dark" }]);
|
||||
assert.equal(JSON.parse(await readFile(mapPath, "utf8")).run.status, "partial", "a complete run has no open gaps");
|
||||
});
|
||||
@@ -0,0 +1,35 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
|
||||
const { tsImport } = await import("tsx/esm/api");
|
||||
const { clampInspectorWidth, inspectorWidthBounds, INSPECTOR_WIDTH_MAX, INSPECTOR_WIDTH_MIN } =
|
||||
await tsImport("../../viewer/src/utils/inspector-width.ts", import.meta.url);
|
||||
|
||||
test("the Inspector may take at most half the window, within its fixed range", () => {
|
||||
assert.deepEqual(inspectorWidthBounds(1440), { min: INSPECTOR_WIDTH_MIN, max: 720 });
|
||||
assert.deepEqual(inspectorWidthBounds(2560), { min: INSPECTOR_WIDTH_MIN, max: INSPECTOR_WIDTH_MAX });
|
||||
// A window narrower than two minimum panels still allows the minimum.
|
||||
assert.deepEqual(inspectorWidthBounds(500), { min: INSPECTOR_WIDTH_MIN, max: INSPECTOR_WIDTH_MIN });
|
||||
});
|
||||
|
||||
test("the bounds are in the panel's own pixels when the chrome is zoomed", () => {
|
||||
assert.deepEqual(inspectorWidthBounds(1600, 1.25), { min: INSPECTOR_WIDTH_MIN, max: 640 });
|
||||
assert.deepEqual(inspectorWidthBounds(1600, 0), inspectorWidthBounds(1600, 1));
|
||||
});
|
||||
|
||||
test("the Inspector stops where the canvas keeps the bottom bar's room, never below the minimum", () => {
|
||||
// 820 - 424 leaves 396, less than half of 820.
|
||||
assert.deepEqual(inspectorWidthBounds(820, 1, 424), { min: INSPECTOR_WIDTH_MIN, max: 396 });
|
||||
// In a wide window half of it is the tighter cap.
|
||||
assert.deepEqual(inspectorWidthBounds(1440, 1, 424), { min: INSPECTOR_WIDTH_MIN, max: 720 });
|
||||
// The room is in window pixels, the width in the panel's own: (1000 - 530) / 1.25 = 376.
|
||||
assert.deepEqual(inspectorWidthBounds(1000, 1.25, 530), { min: INSPECTOR_WIDTH_MIN, max: 376 });
|
||||
assert.deepEqual(inspectorWidthBounds(700, 1, 424), { min: INSPECTOR_WIDTH_MIN, max: INSPECTOR_WIDTH_MIN });
|
||||
});
|
||||
|
||||
test("a width is clamped to the bounds and rounded to whole pixels", () => {
|
||||
const bounds = { min: 320, max: 720 };
|
||||
assert.equal(clampInspectorWidth(100, bounds), 320);
|
||||
assert.equal(clampInspectorWidth(1000, bounds), 720);
|
||||
assert.equal(clampInspectorWidth(455.6, bounds), 456);
|
||||
});
|
||||
@@ -60,6 +60,29 @@ test("ending a hold, or beginning another key, stops the first", (t) => {
|
||||
assert.equal(left, 2);
|
||||
});
|
||||
|
||||
test("a hold says when it ends, however it ends, and whether any key is held", (t) => {
|
||||
t.mock.timers.enable({ apis: ["setTimeout"] });
|
||||
const hold = createKeyHold();
|
||||
const ended = [];
|
||||
assert.ok(!hold.holding());
|
||||
hold.begin("ArrowRight", () => true, () => ended.push("released"));
|
||||
assert.ok(hold.holding());
|
||||
hold.release("ArrowLeft");
|
||||
assert.deepEqual(ended, [], "another key going up leaves it held");
|
||||
hold.release("ArrowRight");
|
||||
hold.begin("ArrowLeft", () => true, () => ended.push("replaced"));
|
||||
hold.begin("ArrowRight", () => true, () => ended.push("ended"));
|
||||
hold.end();
|
||||
let steps = 0;
|
||||
hold.begin("ArrowDown", () => (steps += 1) < 2, () => ended.push("at the end"));
|
||||
t.mock.timers.tick(HOLD_INITIAL_DELAY_MS);
|
||||
t.mock.timers.tick(holdIntervalMs(1));
|
||||
assert.deepEqual(ended, ["released", "replaced", "ended", "at the end"]);
|
||||
assert.ok(!hold.holding());
|
||||
hold.end();
|
||||
assert.equal(ended.length, 4, "an ended hold does not end again");
|
||||
});
|
||||
|
||||
test("another key ends a hold, as the OS's own repeat stops; its own repeats and a modifier do not", () => {
|
||||
const key = (code, key = code, repeat = false) => ({ code, key, repeat });
|
||||
const hold = createKeyHold();
|
||||
|
||||
@@ -0,0 +1,201 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { readFileSync } from "node:fs";
|
||||
import test from "node:test";
|
||||
import { tsImport } from "tsx/esm/api";
|
||||
|
||||
const { snapshotFromTree } = await tsImport("../../src/capture/argent-driver.ts", import.meta.url);
|
||||
const { focusedTextInput, keyboardBounds, keyboardNodes, keyboardSettle } = await tsImport("../../src/capture/keyboard.ts", import.meta.url);
|
||||
const { parseControllerOutput } = await tsImport("../../src/capture/controller-output.ts", import.meta.url);
|
||||
const { normalizeSnapshot } = await tsImport("../../src/map/store.ts", import.meta.url);
|
||||
|
||||
const fixture = name => JSON.parse(readFileSync(new URL(`../fixtures/argent-0.29/${name}`, import.meta.url), "utf8"));
|
||||
// euxy's rename sheet on iOS 26 under Argent 0.29, its field focused and the keyboard up: the head of brentvatne/euxy#172
|
||||
// (review run 39362642343). Its root holds three windows: the app's, the input view placeholder's, and the keyboard's.
|
||||
const RENAME_KEYBOARD_UP = fixture("fixture-ios-ui-tree-rename.json");
|
||||
// The same sheet a moment earlier, as the base was captured: the field focused and its cursor showing, no keyboard yet.
|
||||
const RENAME_KEYBOARD_DOWN = { ...RENAME_KEYBOARD_UP, keyboardVisible: false,
|
||||
roots: [{ ...RENAME_KEYBOARD_UP.roots[0], children: RENAME_KEYBOARD_UP.roots[0].children.slice(0, 1) }] };
|
||||
const ANDROID_RENAME = fixture("fixture-android-ui-tree-rename.json");
|
||||
|
||||
const nodesOf = tree => snapshotFromTree(tree, "ios", 1).nodes;
|
||||
const labelsOf = nodes => parseControllerOutput("agent-device", JSON.stringify({ success: true, data: { nodes } })).elements.map(element => element.label);
|
||||
const nameOf = node => node.label ?? node.identifier;
|
||||
const rect = (x, y, width, height) => ({ x, y, width, height });
|
||||
|
||||
test("the iOS keyboard Argent reports is its own windows: the input view placeholder's and the keyboard's, Emoji and Dictate included", () => {
|
||||
const nodes = nodesOf(RENAME_KEYBOARD_UP);
|
||||
assert.deepEqual(keyboardBounds(nodes), rect(0, 539, 402, 335), "the input view and prediction bar down to the bottom edge");
|
||||
const owned = [...keyboardNodes(nodes)];
|
||||
const names = owned.map(nameOf).filter(Boolean);
|
||||
for (const name of ["inputView", "SystemInputAssistantView", "Typing Predictions", "Q", "shift", "Emoji", "Dictate"]) assert.ok(names.includes(name), name);
|
||||
assert.ok(owned.every(node => node.systemKeyboard === true), "only nodes of the keyboard's windows");
|
||||
// Every element of the app's window stays, those behind the keyboard's band among them.
|
||||
const app = nodesOf(RENAME_KEYBOARD_DOWN).map(nameOf).filter(Boolean);
|
||||
for (const name of app) assert.ok(nodes.some(node => nameOf(node) === name && !keyboardNodes(nodes).has(node)), name);
|
||||
assert.ok(app.includes("AdditionalDimmingOverlay") && app.includes("Tab Bar") && app.includes("Clear name"));
|
||||
});
|
||||
|
||||
test("a keyboard up on one side only leaves the elements and the accessibility fingerprint unchanged", () => {
|
||||
// In euxy#172 the review led with "Added button “Dictate”", “Emoji” and “inputView” over the label change.
|
||||
const up = nodesOf(RENAME_KEYBOARD_UP), down = nodesOf(RENAME_KEYBOARD_DOWN);
|
||||
assert.deepEqual(labelsOf(up), labelsOf(down));
|
||||
for (const name of ["Dictate", "Emoji", "inputView", "Q"]) assert.equal(labelsOf(up).includes(name), false, name);
|
||||
// The bridge numbers nodes in order, so the app's own nodes keep their indices when the keyboard's windows follow them.
|
||||
const snapshot = nodes => JSON.stringify({ success: true, data: { nodes: nodes.map(({ ref: _ref, ...node }) => node) } });
|
||||
assert.equal(normalizeSnapshot(snapshot(up)), normalizeSnapshot(snapshot(down)));
|
||||
});
|
||||
|
||||
test("the text field with the focus is passed on from Argent", () => {
|
||||
const up = nodesOf(RENAME_KEYBOARD_UP), down = nodesOf(RENAME_KEYBOARD_DOWN);
|
||||
assert.equal(up.filter(node => node.focused === true).map(node => node.type).join(), "TextField");
|
||||
assert.equal(focusedTextInput(up), true);
|
||||
assert.equal(focusedTextInput(down), true);
|
||||
assert.equal(keyboardBounds(down), undefined);
|
||||
assert.equal(focusedTextInput(nodesOf(fixture("fixture-ios-ui-tree-home.json"))), false);
|
||||
});
|
||||
|
||||
test("an element the app identifies as inputView in its own window is the app's", () => {
|
||||
// A chat composer with testID="inputView", no keyboard up.
|
||||
const app = RENAME_KEYBOARD_DOWN.roots[0].children[0];
|
||||
const composer = { role: "AXGroup", type: "Other", identifier: "inputView", frame: rect(0, 0.8, 1, 0.1),
|
||||
children: [{ role: "AXButton", type: "Button", label: "Send", frame: rect(0.8, 0.82, 0.15, 0.05), children: [] }] };
|
||||
const tree = { ...RENAME_KEYBOARD_DOWN, roots: [{ ...RENAME_KEYBOARD_DOWN.roots[0], children: [{ ...app, children: [...app.children, composer] }] }] };
|
||||
const nodes = nodesOf(tree);
|
||||
assert.equal(keyboardNodes(nodes).size, 0);
|
||||
assert.equal(keyboardBounds(nodes), undefined);
|
||||
assert.ok(labelsOf(nodes).includes("inputView") && labelsOf(nodes).includes("Send"));
|
||||
});
|
||||
|
||||
test("a second window of the app's own, its testID inputView included, is the app's; the keyboard's windows need a Keyboard", () => {
|
||||
// The app's second UIWindow (a toast or a floating composer) with a view identified as inputView and a Save button.
|
||||
const window = { role: "AXGroup", type: "Application", frame: rect(0, 0, 1, 1), children: [
|
||||
{ role: "AXGroup", type: "Other", identifier: "inputView", frame: rect(0, 0.8, 1, 0.1),
|
||||
children: [{ role: "AXButton", type: "Button", label: "Save", frame: rect(0.8, 0.82, 0.15, 0.05), children: [] }] }] };
|
||||
const [app, placeholder, keyboard] = RENAME_KEYBOARD_UP.roots[0].children;
|
||||
const withWindows = windows => nodesOf({ ...RENAME_KEYBOARD_UP, roots: [{ ...RENAME_KEYBOARD_UP.roots[0], children: [app, ...windows] }] });
|
||||
for (const windows of [[window], [window, keyboard], [window, placeholder, keyboard]]) {
|
||||
const labels = labelsOf(withWindows(windows));
|
||||
assert.ok(labels.includes("Save") && labels.includes("inputView"), `kept beside ${windows.length - 1} keyboard windows`);
|
||||
}
|
||||
// Without the keyboard's own window, an input view placeholder window proves nothing.
|
||||
assert.ok(labelsOf(withWindows([placeholder])).includes("inputView"));
|
||||
assert.equal(keyboardNodes(withWindows([placeholder])).size, 0);
|
||||
// With it, the placeholder is the keyboard's too, as in the real tree.
|
||||
assert.equal(labelsOf(withWindows([placeholder, keyboard])).includes("inputView"), false);
|
||||
});
|
||||
|
||||
test("agent-device's keyboard is its Keyboard element and what is under it, and its host bridge's keyboard view classes", () => {
|
||||
// XCTest: the Keyboard directly under the Application, beside the app's own controls in the same band.
|
||||
const xctest = [
|
||||
{ index: 0, type: "Application", label: "Example", rect: rect(0, 0, 402, 874) },
|
||||
{ index: 1, parentIndex: 0, type: "TextField", label: "Pattern name", focused: true, rect: rect(23, 386, 355, 50) },
|
||||
{ index: 2, parentIndex: 0, type: "Keyboard", rect: rect(0, 583, 402, 233) },
|
||||
{ index: 3, parentIndex: 2, type: "Key", label: "Q", rect: rect(5, 590, 39, 54) },
|
||||
{ index: 4, parentIndex: 0, type: "Button", label: "Home tab", rect: rect(0, 800, 134, 74) },
|
||||
{ index: 5, parentIndex: 0, type: "Other", label: "Formatting toolbar", rect: rect(0, 540, 402, 43) },
|
||||
{ index: 6, parentIndex: 0, type: "Button", label: "Emoji", rect: rect(8, 300, 68, 40) },
|
||||
];
|
||||
assert.deepEqual(keyboardBounds(xctest), rect(0, 583, 402, 233));
|
||||
assert.deepEqual(labelsOf(xctest), ["Example", "Pattern name", "Home tab", "Formatting toolbar", "Emoji"]);
|
||||
// The host bridge names the dock's buttons by class, wherever they sit.
|
||||
const hostBridge = [
|
||||
{ type: "TextField", role: "RCTUITextField", label: "Pattern name", focused: true, rect: rect(23, 386, 355, 50) },
|
||||
{ type: "Button", role: "UIKeyboardDockItemButton", label: "Dictate", rect: rect(325, 806, 68, 68) },
|
||||
{ type: "Other", role: "UIAccessibilityElementKBKey", label: "Q", rect: rect(5, 590, 39, 54) },
|
||||
{ type: "Button", role: "RCTViewComponentView", label: "Profile tab", rect: rect(268, 800, 134, 74) },
|
||||
];
|
||||
assert.ok(keyboardBounds(hostBridge));
|
||||
assert.deepEqual(labelsOf(hostBridge), ["Pattern name", "Profile tab"]);
|
||||
});
|
||||
|
||||
test("nothing without a parent link is taken for the keyboard's, and keys alone are no keyboard", () => {
|
||||
// agent-device's flat shape: no parentIndex. The Keyboard element goes; nothing can be proven to be under it.
|
||||
const flat = [
|
||||
{ type: "Keyboard", rect: rect(0, 583, 402, 233) },
|
||||
{ type: "Key", label: "Q", rect: rect(5, 590, 39, 54) },
|
||||
{ type: "Button", label: "Profile tab", rect: rect(268, 800, 134, 74) },
|
||||
];
|
||||
assert.deepEqual(labelsOf(flat), ["Q", "Profile tab"]);
|
||||
// An app's own PIN pad (accessibilityRole="keyboardkey") and its footer action, with no system keyboard up.
|
||||
const pinPad = [
|
||||
{ index: 0, type: "Application", label: "Example", rect: rect(0, 0, 402, 874) },
|
||||
{ index: 1, parentIndex: 0, type: "SecureTextField", label: "PIN", focused: true, rect: rect(23, 200, 355, 50) },
|
||||
...["1", "2", "3"].map((digit, offset) => ({ index: 2 + offset, parentIndex: 0, type: "Key", label: digit, rect: rect(offset * 134, 600, 134, 70) })),
|
||||
{ index: 5, parentIndex: 0, type: "Button", label: "App footer action", rect: rect(0, 800, 402, 74) },
|
||||
];
|
||||
assert.equal(keyboardNodes(pinPad).size, 0);
|
||||
assert.equal(keyboardBounds(pinPad), undefined);
|
||||
assert.deepEqual(labelsOf(pinPad), ["Example", "PIN", "1", "2", "3", "App footer action"]);
|
||||
});
|
||||
|
||||
test("in landscape the keyboard is told apart the same way, the app's bottom bar kept", () => {
|
||||
const landscape = [
|
||||
{ index: 0, type: "Application", label: "Example", rect: rect(0, 0, 874, 402) },
|
||||
{ index: 1, parentIndex: 0, type: "TextField", label: "Search", focused: true, rect: rect(100, 60, 674, 40) },
|
||||
{ index: 2, parentIndex: 0, type: "Keyboard", rect: rect(0, 230, 874, 172) },
|
||||
{ index: 3, parentIndex: 2, type: "Key", label: "Q", rect: rect(60, 236, 70, 38) },
|
||||
{ index: 4, parentIndex: 0, type: "TabBar", label: "Tab Bar", rect: rect(0, 352, 874, 50) },
|
||||
];
|
||||
assert.deepEqual(keyboardBounds(landscape), rect(0, 230, 874, 172));
|
||||
assert.deepEqual(labelsOf(landscape), ["Example", "Search", "Tab Bar"]);
|
||||
});
|
||||
|
||||
test("an Android input method's window is the keyboard under Argent, AOSP's included, and Argent says when one shows", () => {
|
||||
const ime = pkg => ({ role: "FrameLayout", type: "android.widget.FrameLayout", bundleId: pkg, frame: rect(0, 0.6, 1, 0.4),
|
||||
children: [{ role: "Button", type: "android.widget.Button", contentDescription: "q", frame: rect(0.01, 0.65, 0.09, 0.06), children: [] }] });
|
||||
const before = snapshotFromTree(ANDROID_RENAME, "android", 1, "dev.brent.euxy").nodes;
|
||||
assert.equal(focusedTextInput(before), true, "Argent marks the focused EditText");
|
||||
assert.equal(keyboardBounds(before), undefined);
|
||||
for (const pkg of ["com.google.android.inputmethod.latin", "com.android.inputmethod.latin"]) {
|
||||
const after = snapshotFromTree({ ...ANDROID_RENAME, keyboardVisible: true, roots: [...ANDROID_RENAME.roots, ime(pkg)] }, "android", 1, "dev.brent.euxy").nodes;
|
||||
assert.deepEqual(keyboardBounds(after), rect(0, 960, 720, 640), pkg);
|
||||
assert.deepEqual(labelsOf(after), labelsOf(before), pkg);
|
||||
}
|
||||
});
|
||||
|
||||
test("the wait reads until the keyboard is in one place twice, at least twice, at most six times", () => {
|
||||
const field = { type: "TextField", label: "Pattern name", focused: true, rect: rect(23, 386, 355, 50) };
|
||||
const keyboardAt = y => [field, { index: 9, type: "Keyboard", rect: rect(0, y, 402, 874 - y) }];
|
||||
// Already up when the screen was read: one more read must find it in the same place.
|
||||
const up = keyboardSettle({ nodes: keyboardAt(583) });
|
||||
assert.equal(up.more(0), true, "a keyboard already up may still be rising");
|
||||
up.read({ nodes: keyboardAt(583) });
|
||||
assert.deepEqual([up.outcome, up.reads, up.more(250)], ["shown", 1, false]);
|
||||
// Caught rising: it moves between reads, then holds.
|
||||
const rising = keyboardSettle({ nodes: [field] });
|
||||
for (const y of [700, 583, 583]) rising.read({ nodes: keyboardAt(y) });
|
||||
assert.deepEqual([rising.outcome, rising.reads], ["shown", 3]);
|
||||
// A slow controller: the second read is owed even after a second has passed.
|
||||
const slow = keyboardSettle({ nodes: [field] });
|
||||
slow.read({ nodes: [field] });
|
||||
assert.equal(slow.more(2_500), true);
|
||||
slow.read({ nodes: [field] });
|
||||
assert.deepEqual([slow.outcome, slow.more(5_000)], ["absent", false], "no keyboard came: captured without one");
|
||||
// A slow first read without a keyboard, then the keyboard first seen still moving: read on until it holds.
|
||||
const late = keyboardSettle({ nodes: [field] });
|
||||
late.read({ nodes: [field] });
|
||||
late.read({ nodes: keyboardAt(700) });
|
||||
assert.deepEqual([late.outcome, late.more(2_500)], ["moving", true], "a moving keyboard is not given up on after a second");
|
||||
late.read({ nodes: keyboardAt(583) });
|
||||
late.read({ nodes: keyboardAt(583) });
|
||||
assert.deepEqual([late.outcome, late.reads], ["shown", 4]);
|
||||
// But not past four seconds, however few reads that was.
|
||||
const stalled = keyboardSettle({ nodes: [field] });
|
||||
stalled.read({ nodes: [field] });
|
||||
stalled.read({ nodes: keyboardAt(700) });
|
||||
assert.equal(stalled.more(4_000), false);
|
||||
// Six reads at most, however fast they come.
|
||||
const busy = keyboardSettle({ nodes: [field] });
|
||||
for (let read = 0; busy.more(0); read++) busy.read({ nodes: keyboardAt(read % 2 ? 583 : 700) });
|
||||
assert.deepEqual([busy.outcome, busy.reads], ["moving", 6]);
|
||||
// The field let go and no keyboard shows: nothing more to wait for.
|
||||
const released = keyboardSettle({ nodes: [field] });
|
||||
released.read({ nodes: [{ ...field, focused: false }] });
|
||||
assert.deepEqual([released.outcome, released.more(0)], ["unfocused", false]);
|
||||
// Argent on Android says a keyboard shows without placing it: it shows twice running.
|
||||
const android = keyboardSettle({ nodes: [field] });
|
||||
android.read({ nodes: [field], keyboardVisible: true });
|
||||
android.read({ nodes: [field], keyboardVisible: true });
|
||||
assert.equal(android.outcome, "shown");
|
||||
assert.equal(keyboardSettle({ nodes: [{ ...field, focused: false }] }), undefined, "a screen without a focused field is not waited on");
|
||||
});
|
||||
@@ -437,6 +437,30 @@ test('a review runs at most --parallel targets at once, and every target settles
|
||||
assert.deepEqual(results.map(result => result.status === 'fulfilled' ? result.value : result.reason.message), [10, 20, 'three', 40, 50]);
|
||||
});
|
||||
|
||||
test('a local review runs no more targets at once than capture.maxSessions', async t => {
|
||||
const targets = { phone: { platform: 'ios' }, tablet: { platform: 'ios', device: 'iPad Air' } };
|
||||
// Whether one target's review began before the other's ended, from the order of their progress lines.
|
||||
const overlapped = async (maxSessions, parallel) => {
|
||||
const f = await fixture(t, 'expo-router', { targets, maxSessions });
|
||||
t.mock.method(globalThis, 'fetch', async input => assert.fail(`Unmocked network request: ${input}`));
|
||||
const environment = { ...f.environment, EXPLORE_CACHE_DIR: await scratch(t, 'explore-local-cache-'), GITHUB_RUN_ID: '', GITHUB_RUN_ATTEMPT: '', GITHUB_TOKEN: '' };
|
||||
const lines = [];
|
||||
const result = await runLocalReview({ project: f.headProject, base: f.baseSha, head: f.headSha, environment, cache: false, ...(parallel ? { parallel } : {}),
|
||||
install: async checkout => { await writeCaptureObserverPackages(checkout, { provider: 'expo-router' }); }, runner: f.runner, now: f.now, sleep: f.sleep,
|
||||
progress: message => lines.push(message) });
|
||||
t.after(() => rm(result.work, { recursive: true, force: true }));
|
||||
assert.deepEqual(result.reports.map(report => report.target.id).sort(), ['phone', 'tablet']);
|
||||
const span = id => [lines.findIndex(line => line.startsWith(`${id}: `)), lines.findLastIndex(line => line.startsWith(`${id}: `))];
|
||||
const [phone, tablet] = [span('phone'), span('tablet')];
|
||||
return phone[0] < tablet[1] && tablet[0] < phone[1];
|
||||
};
|
||||
// One simulator at a time: the targets take turns.
|
||||
assert.equal(await overlapped(1), false);
|
||||
// The default ceiling (five) runs both at once, and --parallel still chooses for itself.
|
||||
assert.equal(await overlapped(undefined), true);
|
||||
assert.equal(await overlapped(1, 2), true);
|
||||
});
|
||||
|
||||
test('a target that fails outright costs only its own report', async t => {
|
||||
const targets = { phone: { platform: 'ios' }, tablet: { platform: 'ios', device: 'iPad Air' } };
|
||||
const f = await fixture(t, 'expo-router', { targets });
|
||||
|
||||
@@ -7,7 +7,7 @@ import test from "node:test";
|
||||
import { prepareCaptureReview } from "../../dist/review/capture-review.js";
|
||||
import { createSourceCapturePlan } from "../../dist/source/capture-plan.js";
|
||||
import { writeCiReportInput, exportCiReport } from "../../dist/report/artifact.js";
|
||||
import { collectPlatformReports, deployExplorationReport, deployFixturePreview, deployLocalReports, fixtureReports, deployPreview, previewProjectSlug, readReportZip, whoamiAccounts, zipReportDirectory } from "../../dist/report/preview-deploy.js";
|
||||
import { collectPlatformReports, deployExplorationReport, deployFixturePreview, deployLocalReports, FIXTURE_ALIAS_WAIT_MS, fixtureReports, deployPreview, previewProjectSlug, readReportZip, whoamiAccounts, zipReportDirectory } from "../../dist/report/preview-deploy.js";
|
||||
import { spawnSync } from "node:child_process";
|
||||
import { ZipReader, Uint8ArrayReader, TextWriter, configure } from "@zip.js/zip.js";
|
||||
import { viewerLinks } from "../../dist/report/viewer-links.js";
|
||||
@@ -387,11 +387,76 @@ test("collectPlatformReports pairs downloaded artifact directories by platform a
|
||||
const lookups = eas.requests.filter(request => request.url.pathname.endsWith("/actions/runs/10/artifacts"));
|
||||
assert.deepEqual(lookups.map(request => request.url.searchParams.get("name")), ["explore-review-10-1-android", "explore-review-10-1-ios"]);
|
||||
assert.ok(lookups.every(request => request.options.headers.authorization === "Bearer test-token"));
|
||||
// A target whose report job failed (brentvatne/euxy#172) is left out; the others still deploy, without waiting for it.
|
||||
await rm(join(root, "reports", "explore-review-10-1-android"), { recursive: true });
|
||||
const before = eas.requests.length;
|
||||
const remaining = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: eas.transport });
|
||||
assert.deepEqual(remaining.map(entry => entry.target.id), ["ios"]);
|
||||
assert.deepEqual(eas.requests.slice(before).map(request => request.url.searchParams.get("name")), ["explore-review-10-1-ios"], "no lookup for the target without a report");
|
||||
await rm(join(root, "reports", "explore-review-10-1-ios"), { recursive: true });
|
||||
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: eas.transport }),
|
||||
error => error.code === "PREVIEW_REPORTS_INCOMPLETE");
|
||||
});
|
||||
|
||||
test("collectPlatformReports reads a lone target's artifacts, which download-artifact extracts into the path itself", async t => {
|
||||
const fixture = await asTarget(await exportFixture(t), TARGETS[2]);
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-fanin-lone-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
// Four of five captures failed, so each pattern matched one artifact: its files sit in --inputs and --reports themselves.
|
||||
await mkdir(join(root, "inputs"), { recursive: true }); await cp(fixture.inputPath, join(root, "inputs", "report-input.json"));
|
||||
await cp(fixture.reportPath, join(root, "reports"), { recursive: true });
|
||||
const eas = easFixture();
|
||||
const transport = async (input, options) => {
|
||||
const url = new URL(input);
|
||||
if (url.pathname.endsWith("/actions/runs/10/artifacts") && url.searchParams.get("name") === "explore-review-10-1-duo-open") {
|
||||
return new Response(JSON.stringify({ artifacts: [{ id: 33, name: "explore-review-10-1-duo-open" }] }), { status: 200 });
|
||||
}
|
||||
return eas.transport(input, options);
|
||||
};
|
||||
const [entry, ...rest] = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport });
|
||||
assert.deepEqual(rest, []);
|
||||
assert.deepEqual([entry.target.id, entry.inputPath, entry.reportPath, entry.artifactUrl.split("/").at(-1)],
|
||||
["duo-open", join(root, "inputs", "report-input.json"), join(root, "reports"), "33"]);
|
||||
// A pattern that matched nothing left no directory: there is nothing to deploy, and that is said plainly.
|
||||
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "missing"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport }),
|
||||
error => error.code === "PREVIEW_REPORTS_MISSING");
|
||||
});
|
||||
|
||||
test("collectPlatformReports looks up a report artifact the run does not list yet again, but not one its token cannot read", async t => {
|
||||
const ios = await exportFixture(t);
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-fanin-late-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const { cp } = await import("node:fs/promises");
|
||||
await mkdir(join(root, "inputs", "explore-capture-10-1-ios"), { recursive: true }); await cp(ios.inputPath, join(root, "inputs", "explore-capture-10-1-ios", "report-input.json"));
|
||||
await cp(ios.reportPath, join(root, "reports", "explore-review-10-1-ios"), { recursive: true });
|
||||
const eas = easFixture();
|
||||
const listing = answers => {
|
||||
const lookups = [];
|
||||
const transport = async (input, options) => {
|
||||
const url = new URL(input);
|
||||
if (!url.pathname.endsWith("/actions/runs/10/artifacts")) return eas.transport(input, options);
|
||||
lookups.push(url);
|
||||
const answer = answers[Math.min(lookups.length, answers.length) - 1];
|
||||
return answer ? new Response(JSON.stringify(answer.body ?? {}), { status: answer.status }) : eas.transport(input, options);
|
||||
};
|
||||
return { lookups, transport };
|
||||
};
|
||||
const pauses = [];
|
||||
const sleep = async milliseconds => { pauses.push(milliseconds); };
|
||||
// The list lags the report job's upload: empty, then a 404, then the artifact.
|
||||
const late = listing([{ status: 200, body: { artifacts: [] } }, { status: 404 }, undefined]);
|
||||
const [entry] = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: late.transport, sleep });
|
||||
assert.equal(entry.artifactUrl, artifactUrl.replace(/20$/, "21"));
|
||||
assert.equal(late.lookups.length, 3);
|
||||
assert.equal(pauses.length, 2);
|
||||
const denied = listing([{ status: 403 }]);
|
||||
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: denied.transport, sleep }),
|
||||
error => error.code === "REPORT_ARTIFACT_MISSING" && /HTTP 403/.test(error.message));
|
||||
assert.equal(denied.lookups.length, 1);
|
||||
const never = listing([{ status: 200, body: { artifacts: [] } }]);
|
||||
await assert.rejects(collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport: never.transport, sleep }),
|
||||
error => error.code === "REPORT_ARTIFACT_MISSING");
|
||||
assert.equal(never.lookups.length, 5);
|
||||
});
|
||||
|
||||
const now = Date.UTC(2026, 8, 11, 3, 7);
|
||||
const STALE_COMMENT = `<!-- expo-explore-ci -->
|
||||
Explore review for abc · Managed via config
|
||||
@@ -456,6 +521,20 @@ test("a standalone report deploys to a fixed alias with a fixed token, verifies
|
||||
assert.match(plain.previewUrl, /^https:\/\/acme-explore--1lcbdcpwn3\.expo\.app\/p\/[a-z2-7]{32}$/);
|
||||
assert.notEqual(plain.previewUrl, result.previewUrl, "without a fixed token the link is random");
|
||||
|
||||
// A standalone report's alias that is still behind after the whole budget: its link is the deployment, which
|
||||
// serves this run, and nothing says the alias is behind (only a fixture preview's comment explains a lagging link).
|
||||
const behind = easFixture({ aliasServes: false });
|
||||
let clock = now;
|
||||
const quiet = process.stderr.write.bind(process.stderr);
|
||||
process.stderr.write = () => true;
|
||||
let fallback;
|
||||
try {
|
||||
fallback = await deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "bluesky", token,
|
||||
environment: deployEnvironment, transport: behind.transport, run: behind.run, now: () => (clock += 31_000), verifyTimeoutMs: 60_000 });
|
||||
} finally { process.stderr.write = quiet; }
|
||||
assert.equal(fallback.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
|
||||
assert.equal(fallback.aliasBehind, undefined);
|
||||
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, alias: "Blue Sky",
|
||||
environment: deployEnvironment, transport: eas.transport, run: eas.run, verifyTimeoutMs: 1 }), error => error.code === "PREVIEW_ALIAS_INVALID");
|
||||
await assert.rejects(deployExplorationReport({ reportPath, project: "acme-explore", owner: "brent-org", exportPath, token: "short",
|
||||
@@ -487,21 +566,28 @@ test("a fixture preview seals each platform's ZIP as is behind one alias and lis
|
||||
const served = eas.requests.filter(request => request.url.pathname === `/p/${token}/manifest.json`).map(request => request.url.searchParams.get("platform"));
|
||||
assert.deepEqual([...new Set(served)].sort(), ["android", "ios"], "both platforms' manifests are verified");
|
||||
|
||||
// The alias lagging the deployment past the budget is not a failed deployment: the deployment is verified, so the
|
||||
// link is the deployment's own origin and the job log carries a warning (every 2026-10-14 "HTTP 404" failure was this).
|
||||
// The alias lagging the deployment is not a failed deployment (every 2026-10-14 "HTTP 404" failure was this): the
|
||||
// deployment is verified, so after FIXTURE_ALIAS_WAIT_MS, not the whole verification budget, the pull request links
|
||||
// the alias anyway, says it is behind, and the job log carries a warning.
|
||||
const behind = easFixture({ aliasOrigin: "https://explore-viewer-pr--pr-12.expo.app", aliasServes: false });
|
||||
let clock = now; const ticking = () => (clock += 31_000);
|
||||
// Each poll really waits 3 s, so the clock moves 7 s a reading: the 20 s wait is three polls, not twenty.
|
||||
let clock = now; const ticking = () => (clock += 7_000);
|
||||
const quiet = process.stderr.write.bind(process.stderr); const logged = [];
|
||||
process.stderr.write = chunk => { logged.push(String(chunk)); return true; };
|
||||
let linked;
|
||||
try {
|
||||
linked = await deployFixturePreview({ reports: [{ platform: "ios", zipPath: join(root, "ios.zip") }], project: "explore-viewer-pr", owner: "brent-org", alias: "pr-12", token,
|
||||
exportPath, environment: deployEnvironment, transport: behind.transport, run: behind.run, now: ticking, verifyTimeoutMs: 60_000 });
|
||||
exportPath, environment: deployEnvironment, transport: behind.transport, run: behind.run, now: ticking, verifyTimeoutMs: 180_000 });
|
||||
} finally { process.stderr.write = quiet; }
|
||||
assert.equal(linked.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
|
||||
assert.equal(linked.previewUrl, `https://explore-viewer-pr--pr-12.expo.app/p/${token}`);
|
||||
assert.equal(linked.aliasUrl, "https://explore-viewer-pr--pr-12.expo.app");
|
||||
assert.equal(linked.aliasBehind, true);
|
||||
assert.equal(linked.deploymentUrl, "https://acme-explore--1lcbdcpwn3.expo.app", "the comment links the verified deployment beside the alias");
|
||||
assert.equal(logged.filter(line => /^Deployment https:\/\/acme-explore--1lcbdcpwn3\.expo\.app serves this run's report \(\d+ s after eas deploy returned\)\./.test(line)).length, 1);
|
||||
assert.equal(logged.filter(line => /^::warning::The alias https:\/\/explore-viewer-pr--pr-12\.expo\.app still answers HTTP 404 \d+ s after eas deploy returned\. The pull request links the deployment https:\/\/acme-explore--1lcbdcpwn3\.expo\.app instead\./.test(line)).length, 1);
|
||||
const warning = logged.find(line => /^::warning::The alias https:\/\/explore-viewer-pr--pr-12\.expo\.app still answers HTTP 404 \d+ s after eas deploy returned\. The pull request links it anyway, until it catches up, beside the deployment https:\/\/acme-explore--1lcbdcpwn3\.expo\.app\./.test(line));
|
||||
assert.ok(warning, logged.join(""));
|
||||
const waited = Number(/HTTP 404 (\d+) s/.exec(warning)[1]);
|
||||
assert.ok(waited >= FIXTURE_ALIAS_WAIT_MS / 1000 && waited < FIXTURE_ALIAS_WAIT_MS / 1000 + 15, `gave up on the alias after ${waited} s, not the 180 s budget`);
|
||||
assert.ok(behind.requests.some(request => request.url.origin === "https://explore-viewer-pr--pr-12.expo.app"), "the alias was polled");
|
||||
|
||||
// The example report keeps one token and the same fixtures, so an alias still on the previous deployment serves the
|
||||
@@ -513,7 +599,8 @@ test("a fixture preview seals each platform's ZIP as is behind one alias and lis
|
||||
linked = await deployFixturePreview({ reports: [{ platform: "ios", zipPath: join(root, "ios.zip") }], project: "explore-viewer-pr", owner: "brent-org", alias: "pr-12", token,
|
||||
exportPath, environment: deployEnvironment, transport: stale.transport, run: stale.run, now: ticking, verifyTimeoutMs: 60_000 });
|
||||
} finally { process.stderr.write = quiet; }
|
||||
assert.equal(linked.previewUrl, `https://acme-explore--1lcbdcpwn3.expo.app/p/${token}`);
|
||||
assert.equal(linked.previewUrl, `https://explore-viewer-pr--pr-12.expo.app/p/${token}`);
|
||||
assert.equal(linked.aliasBehind, true);
|
||||
assert.equal(logged.filter(line => /^::warning::The alias https:\/\/explore-viewer-pr--pr-12\.expo\.app still serves an earlier deployment \d+ s after eas deploy returned\./.test(line)).length, 1);
|
||||
|
||||
await assert.rejects(deployFixturePreview({ reports: [{ platform: "ios", zipPath: join(root, "ios.zip") }, { platform: "ios", zipPath: join(root, "ios.zip") }],
|
||||
@@ -789,7 +876,9 @@ test("ci:deploy pairs target-named artifacts, deploys them in config order, and
|
||||
const entries = await collectPlatformReports({ inputsPath: join(root, "inputs"), reportsPath: join(root, "reports"), environment: deployEnvironment, transport });
|
||||
assert.deepEqual(entries.map(entry => [entry.target.id, entry.platform, entry.artifactUrl.split("/").at(-1)]),
|
||||
[["iphone", undefined, "31"], ["duo-closed", undefined, "32"], ["duo-open", undefined, "33"], ["android", "android", "34"]], "config order, not directory order");
|
||||
const sealed = await deployPreview({ reports: entries.map(({ platform: _platform, ...entry }) => entry), exportPath: fixtures[0].exportPath, environment: deployEnvironment, transport, run: eas.run, now: () => now, verifyTimeoutMs: 1 })
|
||||
// The fixture serves none of these artifacts by id, so each comment's artifact lookup answers 404 through all its retries.
|
||||
const sealed = await deployPreview({ reports: entries.map(({ platform: _platform, ...entry }) => entry), exportPath: fixtures[0].exportPath, environment: deployEnvironment, transport, run: eas.run, now: () => now, verifyTimeoutMs: 1,
|
||||
sleep: async () => {} })
|
||||
.catch(error => error);
|
||||
// Publishing each target's comment section after the deployment is the comment code's (publishCiReportComment, which needs
|
||||
// the target to name the artifact); the deployment itself must have been written per target either way.
|
||||
|
||||
@@ -679,6 +679,80 @@ test('a config without targets writes the same records and comment as before tar
|
||||
assert.deepEqual(Object.keys(readCommentRecords(after).current), ['ios', 'android']);
|
||||
});
|
||||
|
||||
/**
|
||||
* brentvatne/euxy#172, review run 39362642343: five targets, two strings changed. Tempo's footnote sits low in a
|
||||
* scrolling sheet. On the closed iPhone Duo the accessibility tree has the new text but the screenshots match: the
|
||||
* footnote runs past the bottom of the screen (`offScreen`, from the elements' bounds). On the half-open and opened Duo
|
||||
* neither the tree nor the pixels have it. Android captures no dark appearance.
|
||||
*/
|
||||
const euxyTargets = [{ id: 'iphone', platform: 'ios', label: 'iPhone 17' }, { id: 'duo-closed', platform: 'ios', label: 'iPhone Duo (closed)' },
|
||||
{ id: 'duo-half-open', platform: 'ios', label: 'iPhone Duo (half-open)' }, { id: 'duo-open', platform: 'ios', label: 'iPhone Duo (open)' },
|
||||
{ id: 'android', platform: 'android', label: 'Android' }];
|
||||
const footnote = 'Added text “Changes apply live while playing. Base resolution sets the step grid for lanes you add next.”.';
|
||||
const footnoteText = 'Added text “Changes apply live while playing\\. Base resolution sets the step grid for lanes you add next\\.”';
|
||||
function euxyReview(target, options = {}) {
|
||||
const own = { sourceImpact: ['own'], sourceScope: 'screen' };
|
||||
const matched = { verdict: 'unchanged', reason: 'matched', mismatchPercentage: 0, threshold: 0.1, tool: '[email protected]' };
|
||||
const changed = (description, mismatchPercentage) => ({ ...own,
|
||||
review: { status: 'modified', description, facts: [{ category: 'element', templateId: 'element.added', bullet: description }] },
|
||||
visual: { verdict: 'modified', reason: 'repeated-cross-build-delta', mismatchPercentage, threshold: 0.1, tool: '[email protected]' } });
|
||||
const inTreeOnly = { ...changed(footnote, 0), visual: matched };
|
||||
if (options.offScreen !== false) inTreeOnly.review.offScreen = true;
|
||||
if (options.diffFailed) inTreeOnly.visual = { ...matched, reason: 'diff-failed' };
|
||||
const unseen = { ...own, review: { status: 'unchanged', description: 'No visible change' }, visual: matched };
|
||||
const tempo = target === 'duo-closed' ? inTreeOnly : ['duo-half-open', 'duo-open'].includes(target) ? unseen : changed(footnote, 0.11);
|
||||
const rename = changed('Added text “Pattern name”.', 0.16);
|
||||
const schemes = target === 'android' ? [''] : ['', '@dark'];
|
||||
return review(schemes.flatMap(scheme => [
|
||||
surface(`tempo${scheme}`, 'modified', { route: '/tempo', extra: structuredClone(tempo) }),
|
||||
surface(`rename-pattern${scheme}`, 'modified', { route: '/rename-pattern', extra: structuredClone(rename) }),
|
||||
]));
|
||||
}
|
||||
async function euxyRows(reviewOf = euxyReview) {
|
||||
const { platformSectionMerge } = await import('../../dist/report/pr-comment-body.js');
|
||||
let body;
|
||||
for (const target of euxyTargets) body = platformSectionMerge(state({ artifactOnly: true, target, targets: euxyTargets, review: reviewOf(target.id),
|
||||
build: { ...state().build, platform: target.platform }, runtime: { ...state().runtime, platform: target.platform, deviceModel: target.label } }), target.id).merge(body);
|
||||
return { body, rows: listOf(body).map(line => line.replace(/\(<[^>]+>\)/, '')) };
|
||||
}
|
||||
|
||||
test('a change whose elements run past the screen on a device is named off-screen there, beside the devices that show it (euxy#172)', async () => {
|
||||
const { body, rows } = await euxyRows();
|
||||
assert.deepEqual(rows, [
|
||||
`- [\`/tempo\`] · ${footnoteText} · iPhone 17, Android only · off-screen on iPhone Duo \\(closed\\)`,
|
||||
`- [\`/rename-pattern\`] · Added text “Pattern name”`,
|
||||
`- [\`/tempo\`] (dark) · ${footnoteText} · iPhone 17 only · off-screen on iPhone Duo \\(closed\\)`,
|
||||
`- [\`/rename-pattern\`] (dark) · Added text “Pattern name” · not on Android`,
|
||||
], 'the half-open and opened Duo have no trace of it, so they stay among the devices it is not on');
|
||||
const { readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
|
||||
assert.deepEqual(readCommentRecords(body).current['duo-closed'].changes.filter(change => change.offScreen).map(change => change.id), ['tempo', 'tempo@dark'],
|
||||
'the mark survives the comment round trip');
|
||||
});
|
||||
|
||||
test('without geometry that puts it past the screen, or with a failed comparison, a device keeps today\'s wording', async () => {
|
||||
// The review euxy#172 published: the closed Duo's change is accessibility-only, with nothing saying where its elements are.
|
||||
const { rows } = await euxyRows(target => euxyReview(target, { offScreen: false }));
|
||||
assert.equal(rows[0], `- [\`/tempo\`] · ${footnoteText} · not on iPhone Duo \\(half\\-open\\), iPhone Duo \\(open\\)`);
|
||||
assert.equal(rows[2], `- [\`/tempo\`] (dark) · ${footnoteText} · iPhone 17, iPhone Duo \\(closed\\) only`);
|
||||
// A comparison that failed is no verdict at all: the closed Duo is not counted among the devices with the change.
|
||||
const failed = await euxyRows(target => euxyReview(target, { diffFailed: true }));
|
||||
assert.match(failed.rows[0], / · on iPhone 17, Android$/);
|
||||
assert.doesNotMatch(failed.rows.join('\n'), /off-screen/);
|
||||
});
|
||||
|
||||
test('a change one platform has and another lacks keeps "only" and "not on"', async () => {
|
||||
// An iOS-only branch in a shared screen file: Android's capture of the screen shows no change, and says nothing off-screen.
|
||||
const iosOnly = target => {
|
||||
const reviewed = euxyReview(target);
|
||||
if (target === 'android') for (const entry of reviewed.surfaces) Object.assign(entry, { review: { status: 'unchanged', description: 'No visible change' },
|
||||
visual: { verdict: 'unchanged', reason: 'matched', mismatchPercentage: 0, threshold: 0.1, tool: '[email protected]' } });
|
||||
return reviewed;
|
||||
};
|
||||
const { rows } = await euxyRows(iosOnly);
|
||||
assert.equal(rows[0], `- [\`/tempo\`] · ${footnoteText} · iPhone 17 only · off-screen on iPhone Duo \\(closed\\)`);
|
||||
assert.match(rows.find(row => row.startsWith('- [`/rename-pattern`] ·')), / · not on Android$/);
|
||||
});
|
||||
|
||||
test('several targets share a comment: named in config order in the subtitle, each linking its report, keyed by id in the records and history', async () => {
|
||||
const { platformSectionMerge, readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
|
||||
const [iphone, closed, open, android] = duoTargets;
|
||||
@@ -710,6 +784,53 @@ test('several targets share a comment: named in config order in the subtitle, ea
|
||||
assert.match(next, /\n- \[bbbbbbbb\]\(<[^>]+>\) · iPhone 17 🟩 3 changes \(.*?\) · iPhone Duo \\\(closed\\\) ⏳ did not finish \(.*?\) · iPhone Duo \\\(open\\\) 🟩 3 changes \(.*?\) · Pixel 7 🟩 3 changes /);
|
||||
});
|
||||
|
||||
test('one of five targets failed: the comment shows the four reports and that failure, and no new-run banner (brentvatne/euxy#172)', async t => {
|
||||
const { platformSectionMerge, readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
|
||||
const { publishFailureComment } = await import('../../dist/report/failure-comment.js');
|
||||
const { mkdir, mkdtemp, rm, writeFile } = await import('node:fs/promises');
|
||||
const { tmpdir } = await import('node:os');
|
||||
const { join } = await import('node:path');
|
||||
const targets = [...duoTargets, { id: 'pixel-dark', platform: 'android', label: 'Pixel 7 (dark)' }];
|
||||
const configPath = '.expo-explore/config.yaml';
|
||||
const firstAttempt = viewerLinks({ artifactUrl: 'https://github.com/expo/explore-playground/actions/runs/42/artifacts/7650', repository: pullRequest.repository, headSha, runId: '42', runAttempt: '1', configPath });
|
||||
const working = viewerLinks({ repository: pullRequest.repository, headSha, runId: '42', runAttempt: '2', configPath });
|
||||
// Attempt 1 published every target; attempt 2 captured them all at once, and the iPhone Duo (open) session failed.
|
||||
let body;
|
||||
for (const target of targets) body = platformSectionMerge(targetState(target, { targets, links: firstAttempt }), target.id).merge(body);
|
||||
for (const target of targets) body = platformSectionMerge(targetState(target, { targets, links: working, phase: 'capturing', review: undefined, evidence: undefined,
|
||||
capture: { planned: { base: 3, head: 3 }, done: { base: 3, head: 1 }, baseFromCache: false, current: 'head' } }), target.id).merge(body);
|
||||
assert.match(visible(body), /New run in progress/);
|
||||
for (const target of targets.filter(target => target.id !== 'duo-open')) body = platformSectionMerge(targetState(target, { targets }), target.id).merge(body);
|
||||
|
||||
const root = await mkdtemp(join(tmpdir(), 'explore-one-failed-')); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
for (const target of targets) await mkdir(join(root, 'capture', `explore-diagnostics-42-2-${target.id}`, 'explore-diagnostics'), { recursive: true });
|
||||
await writeFile(join(root, 'capture', 'explore-diagnostics-42-2-duo-open', 'explore-diagnostics', 'error.json'), JSON.stringify({ code: 'ARGENT_TOOL_FAILED', stage: 'session',
|
||||
message: 'fold: argent run fold failed: [Tool:fold] Service dependency failed', nextAction: 'Rerun the capture.', retryable: false, target: 'duo-open' }));
|
||||
let comments = [{ id: 5, user: { login: 'github-actions[bot]' }, body }];
|
||||
const transport = async (input, init = {}) => {
|
||||
const url = new URL(input);
|
||||
if (url.pathname === '/repos/expo/explore-playground/pulls/1') return Response.json({ state: 'open', draft: false, title: pullRequest.title, html_url: pullRequest.url,
|
||||
base: { ref: 'main', sha: baseSha, repo: { id: 1, full_name: pullRequest.repository } }, head: { ref: pullRequest.head.ref, sha: headSha, repo: { full_name: pullRequest.repository } } });
|
||||
if (url.pathname === '/repos/expo/explore-playground/issues/1/comments') return Response.json(comments);
|
||||
if (url.pathname === '/repos/expo/explore-playground/issues/comments/5' && init.method === 'PATCH') {
|
||||
comments = [{ ...comments[0], body: JSON.parse(init.body).body }]; return Response.json({ id: 5 });
|
||||
}
|
||||
throw new Error(`unexpected request ${init.method ?? 'GET'} ${url}`);
|
||||
};
|
||||
assert.deepEqual(await publishFailureComment({ repository: pullRequest.repository, pullNumber: 1, headSha, baseSha, runId: '42', runAttempt: '2', diagnosticsPath: root,
|
||||
environment: { GITHUB_TOKEN: 'test-token' }, transport }), { posted: true });
|
||||
const final = comments[0].body;
|
||||
assert.doesNotMatch(visible(final), /New run in progress|New run failed/);
|
||||
assert.equal(readCommentRecords(final).previous, undefined, "attempt 1's records go once every target of attempt 2 finished");
|
||||
const records = readCommentRecords(final).current;
|
||||
assert.deepEqual(targets.map(target => [records[target.id].runAttempt, records[target.id].phase]),
|
||||
[['2', 'ready'], ['2', 'ready'], ['2', 'failed'], ['2', 'ready'], ['2', 'ready']]);
|
||||
assert.match(statusOf(final, 'iPhone Duo \\(open\\)'), /^\*\*iPhone Duo \\\(open\\\) failed\*\* · session · ARGENT\\_TOOL\\_FAILED\\: fold\\: argent run fold failed/);
|
||||
// Each published target links its report; the failure's record is the newest, so it sets the updated time.
|
||||
assert.ok(subtitleOf(final).startsWith(`<sub>[iPhone 17](<${reportUrl}>) · [iPhone Duo \\(closed\\)](<${reportUrl}>) · iPhone Duo \\(open\\) · [Pixel 7](<${reportUrl}>) · [Pixel 7 \\(dark\\)](<${reportUrl}>) · ${commits} · updated `), subtitleOf(final));
|
||||
assert.equal(titleOf(final), `### 3 screens changed · [Review in Explore](<${reportUrl}>)`);
|
||||
});
|
||||
|
||||
test('a comment written by a per-platform version keeps parsing, and malformed target records are dropped', async () => {
|
||||
const { platformSectionMerge, readCommentRecords } = await import('../../dist/report/pr-comment-body.js');
|
||||
const { encodeRecordPayload } = await import('../../dist/report/pr-comment-record.js');
|
||||
@@ -796,3 +917,16 @@ test('an excluded route is neither listed nor counted as an app-wide screen', ()
|
||||
const body = renderPublicComment(state({ review: review([...evidenceReview().surfaces, excluded]) }));
|
||||
assert.doesNotMatch(body, /\/channel|App-wide source changes|not compared/);
|
||||
});
|
||||
|
||||
test('an excluded route that is new is not one of the changed screens, nor of the ones the list links to', () => {
|
||||
const screens = Array.from({ length: 11 }, (_, index) => surface(`screen-${index}`, 'modified', { extra: {
|
||||
review: { status: 'modified', description: `Changed ${index}` },
|
||||
visual: { verdict: 'modified', reason: 'repeated-cross-build-delta', mismatchPercentage: 1, threshold: 0.1, tool: '[email protected]' },
|
||||
} }));
|
||||
const excluded = surface('channel', 'added', { route: '/c/[channel]', extra: { excluded: true } });
|
||||
for (const key of ['baseImage', 'headImage', 'baseOutcome', 'headOutcome']) delete excluded[key];
|
||||
const body = renderPublicComment(state({ review: review([...screens, excluded]) }));
|
||||
assert.equal(titleOf(body), `### 11 screens changed · [Review in Explore](<${reportUrl}>)`);
|
||||
assert.equal(listOf(body).at(-1), `- [1 more screen in the report](<${reportUrl}>)`);
|
||||
assert.doesNotMatch(body, /\/c\/\[channel\]/);
|
||||
});
|
||||
@@ -340,8 +340,10 @@ test("expired comparison budgets produce diagnostics rather than review verdicts
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-public-evidence-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const base = await side(root, "base", manifests.base);
|
||||
const head = await side(root, "head", manifests.head);
|
||||
let clock = 0;
|
||||
const result = await assessPublicEvidence({ plan: plan(), base, head, profile: "explore:bundle", agentDeviceCommand: "/nonexistent/agent-device", timeBudgetMs: 0, now: () => clock++, measure: async () => { assert.fail('expired comparisons do not run'); } });
|
||||
let clock = 0, measured = 0;
|
||||
const result = await assessPublicEvidence({ plan: plan(), base, head, profile: "explore:bundle", agentDeviceCommand: "/nonexistent/agent-device", timeBudgetMs: 0, now: () => clock++,
|
||||
measure: async (...args) => { measured += 1; return measurer({})(...args); } });
|
||||
assert.equal(measured, 0, "expired comparisons do not run");
|
||||
assert.equal(result.summary.visual.compared, 0);
|
||||
assert.equal(result.summary.visual.failed, 3);
|
||||
assert.equal(result.summary.visual.needsReview, 0);
|
||||
@@ -526,6 +528,47 @@ test("a presence verdict for a long route (an encoded share link) stays within t
|
||||
assert.equal(presenceDescription("Added ", "/home", " screen."), "Added /home screen.");
|
||||
});
|
||||
|
||||
test("screenshot pairs compare a few at a time, in the loop's order, with the same verdicts as one at a time", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-public-evidence-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const base = await side(root, "base", manifests.base);
|
||||
const head = await side(root, "head", manifests.head);
|
||||
const run = async (concurrency) => {
|
||||
let active = 0, peak = 0;
|
||||
const started = [];
|
||||
const measure = async (baselinePath, currentPath) => {
|
||||
started.push(baselinePath);
|
||||
active += 1; peak = Math.max(peak, active);
|
||||
await new Promise(resolve => setTimeout(resolve, 20));
|
||||
active -= 1;
|
||||
return measurer({ changed: 3.2, stable: 0.4 })(baselinePath, currentPath);
|
||||
};
|
||||
const result = await assessPublicEvidence({ plan: plan(), base, head, profile: "explore:bundle", agentDeviceCommand: "/nonexistent/agent-device", measure, concurrency });
|
||||
return { peak, started, surfaces: result.surfaces, summary: result.summary };
|
||||
};
|
||||
const sequential = await run(1);
|
||||
const parallel = await run(4);
|
||||
assert.equal(sequential.peak, 1);
|
||||
assert.ok(parallel.peak > 1, `comparisons overlap (peak ${parallel.peak})`);
|
||||
assert.deepEqual(parallel.started, sequential.started, "pairs start in the loop's order");
|
||||
assert.deepEqual(parallel.surfaces, sequential.surfaces);
|
||||
assert.deepEqual(parallel.summary, sequential.summary);
|
||||
});
|
||||
|
||||
test("a pair whose turn comes after the budget expired is not started, and one started in time is used", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-public-evidence-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const base = await side(root, "base", manifests.base);
|
||||
const head = await side(root, "head", manifests.head);
|
||||
// The first comparison takes past the budget: it was started in time, the two queued behind it were not.
|
||||
let time = 0, measured = 0;
|
||||
const measure = async (...args) => { measured += 1; time += 1_000; return measurer({})(...args); };
|
||||
const result = await assessPublicEvidence({ plan: plan(), base, head, profile: "explore:bundle", agentDeviceCommand: "/nonexistent/agent-device",
|
||||
timeBudgetMs: 100, now: () => time, measure, concurrency: 1 });
|
||||
assert.equal(measured, 1);
|
||||
assert.equal(result.summary.visual.compared, 1);
|
||||
assert.equal(result.summary.visual.failed, 2);
|
||||
assert.ok(result.summary.diagnostics.every(item => item.code === 'VISUAL_COMPARISON_BUDGET_EXHAUSTED'));
|
||||
});
|
||||
|
||||
test("unstable text never makes a screen Modified, and names a variant's runtime state", () => {
|
||||
const unstable = { category: "visible-text", templateId: "visible-text.unstable-within-build", bullet: 'Text varies between captures of the same build: "2m" / "4m" / "3m".' };
|
||||
const summary = (facts) => ({ facts, needsReview: false, reviewIssues: [] });
|
||||
|
||||
@@ -320,3 +320,15 @@ test("an excluded surface carries no capture evidence", () => {
|
||||
excluded.surfaces[1].excluded = false;
|
||||
assert.throws(() => assertPublicReview(excluded), /excluded surface carries capture evidence/);
|
||||
});
|
||||
|
||||
test("a review says its change is off-screen only on a modified verdict whose screenshots match", () => {
|
||||
const offScreen = (status, verdict) => {
|
||||
const input = review();
|
||||
input.surfaces[0].review = { status, description: status === "modified" ? "Added text “lanes you add next”." : "No visible change", offScreen: true };
|
||||
input.surfaces[0].visual = { verdict, reason: verdict === "unchanged" ? "matched" : "repeated-cross-build-delta", mismatchPercentage: verdict === "unchanged" ? 0 : 3, threshold: 0.1, tool: "[email protected]" };
|
||||
return input;
|
||||
};
|
||||
assert.doesNotThrow(() => assertPublicReview(offScreen("modified", "unchanged")));
|
||||
assert.throws(() => assertPublicReview(offScreen("modified", "modified")), /inconsistent/);
|
||||
assert.throws(() => assertPublicReview(offScreen("unchanged", "unchanged")), /inconsistent/);
|
||||
});
|
||||
@@ -13,6 +13,13 @@ const { presentScreensByPath, presentBuildDiff } = await tsImport(
|
||||
const { artifactUrl, indexMap } = await tsImport("../../viewer/src/utils/model.ts", import.meta.url);
|
||||
const { primaryScreenshotForScreen } = await tsImport("../../viewer/src/utils/screen-images.ts", import.meta.url);
|
||||
const { buildObservedGraph, buildViewerGraph, projectFullGraph } = await tsImport("../../viewer/src/utils/graph-model.ts", import.meta.url);
|
||||
const { omittedScreenIds, omittedSourceScreenIds, reportScreens, withoutOmittedScreens } = await tsImport("../../viewer/src/utils/omitted-screens.ts", import.meta.url);
|
||||
const { reviewChanges } = await import("../../dist/report/pr-comment-body.js");
|
||||
const { neverCapturedSurfaceIds } = await tsImport("../../src/contracts/surface-capture.ts", import.meta.url);
|
||||
const { buildSearchItems } = await tsImport("../../viewer/src/utils/search.ts", import.meta.url);
|
||||
|
||||
/** The Map as the Viewer draws a map without a comparison: its own screens, less the ones it never captured. */
|
||||
const viewerGraph = (map, index = indexMap(map)) => buildViewerGraph(map, index, omittedScreenIds(map));
|
||||
|
||||
function entry(id, route, variant = "default", extra = {}) {
|
||||
return {
|
||||
@@ -124,10 +131,10 @@ test("source navigation projects directional context and route variants without
|
||||
assert.equal(payload.coverage.transitions, 0);
|
||||
for (const collection of ["transitions", "actionAttempts", "journeys"]) assert.deepEqual(payload.map[collection], []);
|
||||
assert.equal(buildObservedGraph(payload.map, indexMap(payload.map)).groups.length, 0);
|
||||
const viewerGraph = buildViewerGraph(payload.map, indexMap(payload.map));
|
||||
assert.deepEqual(viewerGraph.screens.map(screen => screen.id).sort(), ["camera-alias", "games-free", "games-pro", "scan-breed", "scan-mood"]);
|
||||
assert.equal(viewerGraph.groups.length, 2);
|
||||
assert.ok(viewerGraph.groups.every(group => group.transitionIds.length === 0 && group.sourceEdges.length > 0));
|
||||
const graph = viewerGraph(payload.map);
|
||||
assert.deepEqual(graph.screens.map(screen => screen.id).sort(), ["camera-alias", "games-free", "games-pro", "scan-breed", "scan-mood"]);
|
||||
assert.equal(graph.groups.length, 2);
|
||||
assert.ok(graph.groups.every(group => group.transitionIds.length === 0 && group.sourceEdges.length > 0));
|
||||
const presentation = presentScreensByPath(payload.map);
|
||||
const scan = presentation.map.screens.find(screen => screen.route === "/scan/instruction");
|
||||
assert.equal(scan.variantIds.length, 2);
|
||||
@@ -139,7 +146,7 @@ test("source navigation projects directional context and route variants without
|
||||
test("public map omits redirects and unselected changes routes while retaining selected failures", () => {
|
||||
const review = verifyImages(fixture("changes"));
|
||||
const current = workspaceSides(publicReviewToWorkspace(review)).current;
|
||||
const graph = buildViewerGraph(current.map, indexMap(current.map));
|
||||
const graph = viewerGraph(current.map);
|
||||
assert.deepEqual(graph.screens.map(screen => screen.id).sort(), ["care-guide", "games-free"]);
|
||||
assert.equal(current.map.screens.length, 7, "the published source inventory remains available");
|
||||
|
||||
@@ -149,7 +156,7 @@ test("public map omits redirects and unselected changes routes while retaining s
|
||||
status: "failed", attempts: 1, landing: "unverified", reason: "Capture failed",
|
||||
};
|
||||
const failedMap = workspaceSides(publicReviewToWorkspace(failed)).current.map;
|
||||
const failedGraph = buildViewerGraph(failedMap, indexMap(failedMap));
|
||||
const failedGraph = viewerGraph(failedMap);
|
||||
assert.equal(failedGraph.screens.some(screen => screen.id === "scan-mood"), true);
|
||||
assert.equal(failedGraph.screens.some(screen => screen.id === "home"), false);
|
||||
});
|
||||
@@ -833,7 +840,7 @@ test("an excluded route leaves the map with an accepted gap, like a redirect", (
|
||||
excluded.excluded = true;
|
||||
for (const side of ["base", "head"]) { delete excluded[`${side}Image`]; delete excluded[`${side}Outcome`]; }
|
||||
const { current } = workspaceSides(publicReviewToWorkspace(review));
|
||||
const graph = buildViewerGraph(current.map, indexMap(current.map));
|
||||
const graph = viewerGraph(current.map);
|
||||
assert.equal(graph.screens.some(screen => screen.id === "games-pro"), false, "never captured, so not a card on the map");
|
||||
assert.ok(current.map.screens.some(screen => screen.id === "games-pro"), "the inventory still knows the route");
|
||||
const gap = current.map.gaps.find(gap => gap.screenId === "games-pro");
|
||||
@@ -885,3 +892,151 @@ test("a screen's note is its first open gap of any kind, and an accepted gap onl
|
||||
assert.equal(indexMap({ ...current.map, gaps: [resolved, accepted] }).screenNotes.get("games-free"), accepted.message);
|
||||
assert.equal(indexMap({ ...current.map, gaps: [resolved] }).screenNotes.has("games-free"), false);
|
||||
});
|
||||
|
||||
/** What the Viewer leaves out of a review and the comparison it then shows, computed as app.tsx does. */
|
||||
function viewerOmission(review) {
|
||||
const workspace = publicReviewToWorkspace(review);
|
||||
const diff = diffFor(review);
|
||||
const presentation = presentScreensByPath(diff.map);
|
||||
const omitted = omittedScreenIds(diff.map, { diff, presentation });
|
||||
const presented = presentBuildDiff(diff, presentation);
|
||||
// The surfaces the Viewer leaves out, before path grouping: a removed screen goes back to its surface id.
|
||||
const removed = new Map(review.surfaces.map(surface => [removedScreenId(workspace.catalog.defaultBaselineBuildId, surface.id), surface.id]));
|
||||
const surfaces = new Set([...omittedSourceScreenIds(diff.map, diff)].map(id => removed.get(id) ?? id));
|
||||
return { diff, presentation, omitted, presented, shown: withoutOmittedScreens(presented, omitted), surfaces,
|
||||
graph: buildViewerGraph(presentation.map, presentation.index, omitted) };
|
||||
}
|
||||
|
||||
test("a public report's never-captured routes are not its screens anywhere; a captured screen and a local map keep theirs", () => {
|
||||
const review = verifyImages(fixture());
|
||||
// A new route named in exploration.exclude, and a route that was a redirect and is now a captured screen.
|
||||
review.surfaces.push({ id: "channel", status: "added", excluded: true, base: null, head: entry("channel", "/c/[channel]") });
|
||||
const nowCaptured = review.surfaces.find(surface => surface.id === "games-pro");
|
||||
nowCaptured.status = "modified";
|
||||
nowCaptured.base = entry("games-pro", "/games", "pro", { kind: "redirect", redirectTo: "/games" });
|
||||
delete nowCaptured.baseImage; delete nowCaptured.baseOutcome;
|
||||
const { presentation, presented, omitted, shown, graph } = viewerOmission(review);
|
||||
assert.equal(presented.screens.get("channel").status, "added", "the comparison alone would count it as a change");
|
||||
|
||||
assert.deepEqual([...omitted].sort(), ["channel", "home"], "the excluded route and the redirect; the route captured now stays");
|
||||
assert.deepEqual(reportScreens(presentation.map.screens, omitted).map(screen => screen.id).sort(),
|
||||
graph.screens.map(screen => screen.id).sort(), "Screens lists what the Map draws");
|
||||
assert.deepEqual(buildSearchItems({ screens: reportScreens(presentation.map.screens, omitted) }).filter(item => omitted.has(item.screenId)), []);
|
||||
|
||||
assert.deepEqual([...shown.screens.keys()].filter(id => omitted.has(id)), []);
|
||||
assert.equal(shown.counts.added, presented.counts.added - 1);
|
||||
assert.equal(shown.counts["not-compared"], presented.counts["not-compared"] - 1);
|
||||
assert.equal(Object.values(shown.counts).reduce((sum, count) => sum + count, 0), shown.screens.size);
|
||||
assert.ok(shown.index.screens.has("channel"), "a link to it still opens it");
|
||||
assert.equal(shown.index.screenNotes.get("channel"), "Excluded by exploration.exclude; never captured");
|
||||
|
||||
// A captured route whose excluded variant joins it on one card stays on the Map and in Screens.
|
||||
const variants = navigationReview();
|
||||
const pro = variants.surfaces.find(surface => surface.id === "games-pro");
|
||||
pro.excluded = true;
|
||||
for (const side of ["base", "head"]) { delete pro[`${side}Image`]; delete pro[`${side}Outcome`]; }
|
||||
const { current } = workspaceSides(publicReviewToWorkspace(variants));
|
||||
const family = presentScreensByPath(current.map);
|
||||
const familyOmitted = omittedScreenIds(current.map, { presentation: family });
|
||||
const games = family.map.screens.find(screen => screen.route === "/games");
|
||||
assert.equal(games.variantIds.length, 2);
|
||||
assert.ok(reportScreens(family.map.screens, familyOmitted).includes(games));
|
||||
assert.ok(buildViewerGraph(family.map, family.index, familyOmitted).screens.includes(games));
|
||||
|
||||
// A local map with the same gaps lists every screen.
|
||||
const diff = diffFor(review);
|
||||
const local = { ...diff.map, run: { ...diff.map.run, id: "local-run" } };
|
||||
assert.equal(omittedScreenIds(local, { diff, presentation: presentScreensByPath(local) }).size, 0);
|
||||
});
|
||||
|
||||
test("an open capture gap keeps a screen that also has an accepted one, from the baseline or from a sibling", () => {
|
||||
// `/scan/camera` was a redirect and is now a screen whose capture failed: the comparison retargets the baseline's
|
||||
// accepted redirect gap onto it, beside the head's open failure.
|
||||
const redirected = verifyImages(fixture());
|
||||
const camera = redirected.surfaces.find(surface => surface.id === "camera-alias");
|
||||
camera.status = "modified";
|
||||
camera.base = entry("camera-alias", "/scan/camera?action=mood", "mood", { kind: "redirect", redirectTo: "/games" });
|
||||
delete camera.baseImage; delete camera.baseOutcome; delete camera.headImage;
|
||||
camera.headOutcome = { status: "failed", attempts: 2, landing: "unverified", reason: "timeout" };
|
||||
const baseline = viewerOmission(redirected);
|
||||
assert.deepEqual(baseline.diff.map.gaps.filter(gap => gap.screenId === "camera-alias").map(gap => gap.status).sort(), ["accepted", "open"]);
|
||||
assert.equal(baseline.omitted.has("camera-alias"), false);
|
||||
assert.equal(baseline.shown.screens.get("camera-alias").status, "unavailable");
|
||||
assert.equal(baseline.shown.counts.unavailable, 1, "the failed capture is still counted");
|
||||
assert.ok(baseline.graph.screens.some(screen => screen.id === "camera-alias"));
|
||||
assert.equal(neverCapturedSurfaceIds(redirected).has("camera-alias"), false);
|
||||
|
||||
// `/games` free's capture failed and `/games` pro is excluded: both gaps land on the one `/games` card.
|
||||
const sibling = verifyImages(fixture());
|
||||
const pro = sibling.surfaces.find(surface => surface.id === "games-pro");
|
||||
pro.excluded = true;
|
||||
for (const side of ["base", "head"]) { delete pro[`${side}Image`]; delete pro[`${side}Outcome`]; }
|
||||
const free = sibling.surfaces.find(surface => surface.id === "games-free");
|
||||
delete free.headImage;
|
||||
free.headOutcome = { status: "failed", attempts: 2, landing: "unverified", reason: "timeout" };
|
||||
const merged = viewerOmission(sibling);
|
||||
assert.equal(merged.omitted.has("games-free"), false);
|
||||
assert.equal(merged.shown.screens.get("games-free").status, "unavailable");
|
||||
assert.equal(merged.shown.counts.unavailable, 1);
|
||||
assert.ok(merged.surfaces.has("games-pro"), "the excluded variant itself is still never captured");
|
||||
assert.equal(merged.surfaces.has("games-free"), false);
|
||||
});
|
||||
|
||||
test("a removed screen keeps its card when the route that replaces it on the same path is a redirect or excluded", () => {
|
||||
for (const replacement of [
|
||||
{ kind: "redirect", entry: entry("sweet-bee-new", "/games/sweet-bee", "default", { kind: "redirect", redirectTo: "/games" }) },
|
||||
{ kind: "excluded", entry: entry("sweet-bee-new", "/games/sweet-bee"), excluded: true },
|
||||
]) {
|
||||
const review = verifyImages(fixture());
|
||||
review.surfaces.push({ id: "sweet-bee-new", status: "added", base: null, head: replacement.entry,
|
||||
...(replacement.excluded ? { excluded: true } : {}) });
|
||||
const { omitted, shown, graph, surfaces, presentation } = viewerOmission(review);
|
||||
const card = presentation.representativeIdByScreenId.get("sweet-bee-new");
|
||||
assert.equal(omitted.has(card), false, `${replacement.kind}: the removed screen's capture keeps the card`);
|
||||
assert.ok(shown.screens.get(card)?.beforeScreenshot, `${replacement.kind}: Compare and Changes keep the removed screenshot`);
|
||||
assert.ok(graph.screens.some(screen => screen.id === card));
|
||||
assert.ok(surfaces.has("sweet-bee-new"), `${replacement.kind}: the replacement on its own is never captured`);
|
||||
assert.equal(surfaces.has("sweet-bee"), false);
|
||||
assert.equal(reviewChanges(review).get("sweet-bee"), "removed", "the comment lists the removal the Viewer shows");
|
||||
}
|
||||
});
|
||||
|
||||
test("a captured screen that becomes a redirect keeps its card and its screenshot from before", () => {
|
||||
const review = verifyImages(fixture());
|
||||
const camera = review.surfaces.find(surface => surface.id === "camera-alias");
|
||||
camera.status = "modified";
|
||||
camera.head = entry("camera-alias", "/scan/camera?action=mood", "mood", { kind: "redirect", redirectTo: "/games" });
|
||||
delete camera.headImage; delete camera.headOutcome;
|
||||
const { omitted, shown, graph, surfaces } = viewerOmission(review);
|
||||
assert.equal(omitted.has("camera-alias"), false);
|
||||
assert.ok(shown.screens.get("camera-alias").beforeScreenshot);
|
||||
assert.ok(graph.screens.some(screen => screen.id === "camera-alias"));
|
||||
assert.equal(surfaces.has("camera-alias"), false);
|
||||
assert.equal(neverCapturedSurfaceIds(review).has("camera-alias"), false);
|
||||
});
|
||||
|
||||
test("the Viewer leaves out exactly the surfaces the PR comment skips", () => {
|
||||
const review = verifyImages(fixture());
|
||||
review.surfaces.push(
|
||||
{ id: "channel", status: "added", excluded: true, base: null, head: entry("channel", "/c/[channel]") },
|
||||
{ id: "old-start", status: "removed", base: entry("old-start", "/start", "default", { kind: "redirect", redirectTo: "/games" }), head: null },
|
||||
{ id: "sweet-bee-new", status: "added", base: null, head: entry("sweet-bee-new", "/games/sweet-bee", "default", { kind: "redirect", redirectTo: "/games" }) },
|
||||
);
|
||||
const camera = review.surfaces.find(surface => surface.id === "camera-alias");
|
||||
camera.head = entry("camera-alias", "/scan/camera?action=mood", "mood", { kind: "redirect", redirectTo: "/games" });
|
||||
camera.status = "modified";
|
||||
delete camera.headImage; delete camera.headOutcome;
|
||||
const skipped = neverCapturedSurfaceIds(review);
|
||||
assert.deepEqual([...skipped].sort(), ["channel", "home", "old-start", "sweet-bee-new"]);
|
||||
assert.deepEqual([...viewerOmission(review).surfaces].sort(), [...skipped].sort());
|
||||
const listed = reviewChanges(review);
|
||||
for (const id of skipped) assert.equal(listed.has(id), false, `${id} is not a listed change`);
|
||||
assert.equal(listed.get("care-guide"), "added");
|
||||
assert.equal(listed.get("sweet-bee"), "removed");
|
||||
|
||||
const changes = verifyImages(fixture("changes"));
|
||||
assert.deepEqual([...viewerOmission(changes).surfaces].sort(), [...neverCapturedSurfaceIds(changes)].sort());
|
||||
const navigated = navigationReview();
|
||||
assert.deepEqual([...viewerOmission(navigated).surfaces].sort(), [...neverCapturedSurfaceIds(navigated)].sort());
|
||||
assert.ok(neverCapturedSurfaceIds(navigated).size > 0);
|
||||
});
|
||||
@@ -1,7 +1,12 @@
|
||||
import assert from "node:assert/strict";
|
||||
import test from "node:test";
|
||||
import { Buffer } from "node:buffer";
|
||||
import { regionMoves, regionShifts } from "../../dist/review/region-shift.js";
|
||||
import { mkdtemp, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import { PNG } from "pngjs";
|
||||
import { measureRegionMoves, regionMoves, regionShifts } from "../../dist/review/region-shift.js";
|
||||
import { measureRegionMovesInWorker } from "../../dist/review/region-shift-worker.js";
|
||||
|
||||
/** A 120×160 frame of a light background with dark text-like bars, drawn `offsetY` pixels lower (fractions blend rows). */
|
||||
function frame(offsetY, { barColor = 40, extraBar = false } = {}) {
|
||||
@@ -102,6 +107,18 @@ test("a half-pixel move up and down is judged alike", () => {
|
||||
assert.deepEqual([up?.y, down?.y], [-0.5, 0.5]);
|
||||
});
|
||||
|
||||
test("a move whose best fit ties with a smaller one is still a move: the search stops no fit that could make it ambiguous", () => {
|
||||
// Two and a half pixels lower, with a sparse speckle of noise. The tie goes to a fit a little worse than the least error,
|
||||
// and an ambiguity is judged against that one, so a fit stopped short against the least error must not pass for one.
|
||||
const moved = frame(2.5), speckled = { ...moved, data: Buffer.from(moved.data) };
|
||||
for (let y = 0; y < moved.height; y += 1) for (let x = 0; x < moved.width; x += 1) {
|
||||
if ((x * 3 + y * 5) % 11 !== 0) continue;
|
||||
const offset = (y * moved.width + x) * 4, value = Math.max(0, Math.min(255, moved.data[offset] + ((x + y) % 2 ? 10 : -10)));
|
||||
speckled.data.fill(value, offset, offset + 3);
|
||||
}
|
||||
assert.deepEqual(regionShifts(frame(0), speckled, [region]), [{ x: 0, y: 2.5 }]);
|
||||
});
|
||||
|
||||
/**
|
||||
* A light frame with a dark card of irregular blocks at (x, y): the blocks make every offset look different, as a
|
||||
* real card's text and icons do. `tile` repeats one such block pattern every `tile` pixels across the whole row
|
||||
@@ -138,6 +155,22 @@ test("a card that moved far along a row is one move, from the regions where it l
|
||||
[{ rect: { x: 330, y: 80, width: 150, height: 120 }, shift: { x: 270, y: 0 }, members: [1, 0] }], "the region it arrived in first");
|
||||
});
|
||||
|
||||
test("a large move is measured on a worker thread the same as on the calling thread", async (t) => {
|
||||
const root = await mkdtemp(join(tmpdir(), "explore-region-shift-")); t.after(() => rm(root, { recursive: true, force: true }));
|
||||
const write = async (name, frame) => {
|
||||
const png = new PNG({ width: frame.width, height: frame.height }); frame.data.copy(png.data);
|
||||
await writeFile(join(root, name), PNG.sync.write(png)); return join(root, name);
|
||||
};
|
||||
const basePath = await write("base.png", cardFrame()), headPath = await write("head.png", cardFrame({ x: 330 }));
|
||||
const regions = [
|
||||
{ x: 60, y: 80, width: 150, height: 120, dominantChange: "brighter" },
|
||||
{ x: 330, y: 80, width: 150, height: 120, dominantChange: "darker" },
|
||||
];
|
||||
const measured = await measureRegionMovesInWorker(basePath, headPath, regions);
|
||||
assert.deepEqual(measured, await measureRegionMoves(basePath, headPath, regions));
|
||||
assert.deepEqual(measured.moves, [{ rect: { x: 330, y: 80, width: 150, height: 120 }, shift: { x: 270, y: 0 }, members: [1, 0] }]);
|
||||
});
|
||||
|
||||
test("a move whose old and new places overlap takes in the fragments of it the comparison found in between", () => {
|
||||
// A 300-wide card moved 120 right: the comparison sees where it only was, where it only is, and a fragment of the
|
||||
// overlap whose pixels differ because the card's own content moved over itself.
|
||||
|
||||