Compare commits

..
Author SHA1 Message Date
Brent Vatne 0352b3e5fc Address the PR review, and clean up after interrupted local captures
From a three-model review of this PR:
- EAS Simulator sessions now start during the repack, so they ask for 20
  minutes on top of the capture's own, and retry with the plan's maximum
  when that is refused.
- doctor checks each target where it runs (local or EAS Simulator,
  Argent or agent-device), not only the config's top level.
- A local review's reports list only the targets it ran, so the Viewer
  offers no link to a report that does not exist.
- A setup step that wedges the controller runs setup again from the
  start; if it wedges again, routes go on but say setup did not complete,
  in every appearance.
- Agent-mode taps and readiness bounds map between an upright landscape
  screenshot and the portrait axes of an opened iPhone Duo.
- Emulator port locks live in the user's Explore cache, and a lock taken
  over from a process that died is broken by one capture at a time.
- Argent's tool-server installs with npm ci from a lockfile Explore ships,
  so every dependency is pinned, and neither npm nor stopping the server
  sees a capture's tokens.
- A target whose capture worker died fails the shared builds it owned,
  so the targets waiting on them stop.

Every local capture records what it starts (simulator, emulator,
agent-device daemon, Argent tool-server); a local review first stops
what a capture stopped hard left running.
2026-10-17 14:37:46 -07:00
Brent Vatne 7bf12bcf42 Open a route again when the emulator's adb connection drops
Each local emulator's adb connection drops once, about half a minute
after it boots (adb's log: "connection terminated: read failed"), and
the same is seen on EAS. A route whose open hit that failed outright:
agent-device's "device not found" is not retryable. Once the device
answers again, the route now opens again from the app's root, recorded
in controller-retries.jsonl.
2026-10-17 14:37:35 -07:00
Brent Vatne f904120f78 Wait for the root link to settle before each route's link
The one-call reset sent a route's link straight after the root link. On
iOS a link that lands while the previous route's sheet is still being
dismissed can leave the app unable to present a sheet until it is
relaunched: euxy's share link, opened right after its share sheet, never
showed its own, on either attempt. The base waited for the screen to
settle after the root link; captures do again (expo/expo#51740).
2026-10-17 14:37:11 -07:00
Brent Vatne 9a548cf2e8 Use agent-device 0.21.28
The latest release, with fixes for iPhone Duo's viewport and fold and for
iOS 27. The pinned version, its tarball integrity, the dev dependency and
the CI guide move together.
2026-10-17 14:36:58 -07:00
Brent Vatne 40b581d385 Repack on this machine with a local simulator
A local simulator already needs Xcode or the Android SDK, which is all a
repack needs, so it now repacks on this machine unless capture.repack
says eas. --repack eas|local chooses for one run. The default resolves
where it is used, and the capture recipe keys it as resolved, so configs
on EAS Simulator keep their baselines. doctor checks that a local Android
repack has the SDK build-tools and Java.

Fixes found running it:
- A local repack is not uploaded, so it has no EAS build ID, and every
  frame was dropped from the bundle. Frames and the bundle now name the
  native EAS build it repacked, which the review checks them against.
- Head and base reserve emulator ports from worker threads of one
  process, and both could take over the same stale lock. Reservations now
  run one at a time under a mutex directory.

The docs no longer say a local repack is uploaded with eas upload.
2026-10-17 08:44:45 -07:00
Brent Vatne c7f7dc800d Keep a Screens card's notes and status dot with its route
"Changed in dark" and "via" notes were drawn after the card, outside it.
They are now in the card's footer under the route. The status dot was
placed from the card's bottom, so a card stretched to a taller row showed
it a line below the route; it is now placed from the top of the footer.

Also corrects the docs and help that said a local simulator works with
agent-device only and that Argent captures one appearance: that holds on
EAS Simulator only.
2026-10-17 08:44:39 -07:00
Brent Vatne 8e576c5f57 Stop a local emulator adb has lost
An emulator whose console port closed is not listed by adb and ignores
emu kill, so cleanup took it for stopped while it kept running. After emu
kill, any Explore emulator process still on the capture's console port is
signalled, SIGTERM then SIGKILL.
2026-10-17 07:52:16 -07:00
Brent Vatne deed8e9cc1 Capture an opened foldable's screenshots upright through Argent
Argent reads the opened iPhone Duo's inner panel on its portrait axes, so
the screen it reports has the screenshot's shape and the transpose check
never fired. The capture now tells the Argent bridge the target's pose;
an opened iOS foldable asks Argent for a LandscapeRight screenshot, and
its recordings, which Argent cannot turn, are turned clockwise with ffmpeg
when they come back portrait.
2026-10-17 07:52:16 -07:00
Brent VatneandClaude Opus 5.5 a3f1ad2ffa Recover when Argent cannot read the app after a fold
After a fold, Argent's accessibility reader can stay on a foldable's dark outer panel and never
read the app. Locally the capture runs that reader, so it starts a fresh tool-server (whose reader
starts on the lit panel) and opens the app again; if that fails too, it restarts SpringBoard as
well, the recovery XcodeBuildMCP#537 reports for this panel. A third failure is reported.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-16 23:58:16 -07:00
Brent VatneandClaude Opus 5.5 91b2b49d61 Recover from a setup step that leaves another app in front
On the closed iPhone Duo, a tap on the sheet's Done button, which main still draws under the status
pill, brought up the system instead of the app and failed setup, and with it every route. Like a
stuck controller, it now costs that step: the app starts again and the routes go on by app link.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-16 23:52:09 -07:00
Brent VatneandClaude Opus 5.5 490123d380 Turn the opened iPhone Duo's launch recording upright too
Argent records the opened panel in the same portrait orientation as its screenshots. When a
recording's shape is the transpose of the screen, the bridge turns it a quarter clockwise with
ffmpeg, which observing a launch already needs; without ffmpeg it is left as it is.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-16 23:39:14 -07:00
Brent VatneandClaude Opus 5.5 87106f6672 Capture on a local simulator or emulator, several targets per config, and faster, sturdier runs
Local devices (`capture.simulator: local`, `--simulator local`): each commit gets an iOS
simulator (simctl) or Android emulator (Android SDK) of its own on this machine, removed
afterwards. The app's URL scheme is pre-approved, a foldable's pose is checked by its lit
display, and Argent runs locally through a tool-server of the capture's own (installed on first
use, pinned and integrity-checked); the host switches the appearance Argent cannot.

Targets (`targets:` in config.yaml): named captures, several per platform (a phone, a foldable
closed and open), each its own report with its own label, device, pose, controller and
simulator. `--target`, `config:targets`, matrix workflows, artifacts, baselines, PR comment
records, saved runs, hosted listings and the Viewer's switcher are keyed by target; configs
without targets keep their platform-named ids and byte-identical names.

Speed: devices and EAS sessions start while the app is repacked (the app is installed through
the controller, never uploaded), a review's targets run at once (`--parallel N`) and share each
commit's build, and a route needs one root open and no appstate.

Sturdiness: a controller that stops answering costs one route or setup step (the app restarts,
recorded in controller-recoveries.jsonl), a target that fails costs only its own report, local
daemons and tool-servers are stopped, and emulators skip ports agent-device still claims.
Argent's opened iPhone Duo screenshots are turned upright.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-16 23:34:42 -07:00
Brent VatneandClaude Opus 5.5 88a73dd2a9 Drive EAS Simulator with Argent as an alternative to agent-device (#6)
Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-16 19:24:56 -07:00
Brent Vatne 6a8dbfb5a3 Pin eas-cli 25.0.0, and start Explore's sessions with a public preview link (#5) 2026-10-16 14:26:45 -07:00
Brent Vatne e3afc2a00c README: one place for local reviews, a framed hero, and a table of what you get
- Merge "Review a change before you push it" into the Quick start: the reports
  picker and the details of a local review now live there.
- Replace "What you get" with a row of three pictures under the hero (Compare,
  Screens, the PR comment), with the agent prompt collapsed beneath; Terms and
  How agents read a report move to Additional information.
- The hero is the Map zoomed in on the selected screen and framed as a window on
  a soft stage (readme-screenshots.mjs: stagedWindow, --zoom).
- Regenerate every screenshot from the euxy #157 fixtures, with the new Screens
  grid, and update the readme-refresh skill to this layout.
2026-10-16 13:08:35 -07:00
Brent Vatne a60ae5c6d8 Release 0.19.5 2026-10-16 12:39:06 -07:00
Brent Vatne d26e65db47 Add a README quick start, and run local reviews with no setup
- README: a Quick start of two steps (make the app buildable on EAS, then
  `npx @expo/explore capture`), with a prompt to paste into Claude Code or Codex.
- `capture` is a one-word name for `capture:review`.
- A local review reviews the working tree by default, untracked files included,
  as `eas build` uploads it. `--committed` reviews HEAD alone, and an eas.json
  with `cli.requireCommit: true` leaves uncommitted changes out, as eas build does.
- Without `.expo-explore/config.yaml`, a local review uses the config `setup`
  would write (or an uncommitted one in the checkout), so it works before setup.
- setup prefers a simulator profile named `explore` when there are several.
2026-10-16 12:36:38 -07:00
Brent Vatne 47f37988a5 Release 0.19.4 2026-10-15 23:06:16 -07:00
Brent Vatne 1a5a95af63 Show Screens as one grid of screen cards, with arrow-key stepping and ⌃1/2/3 (#4) 2026-10-15 23:06:09 -07:00
Brent Vatne fc5b465513 Release 0.19.3 2026-10-15 20:42:49 -07:00
Brent Vatne 09b9f34e33 Label outlines with how far moved areas moved (#3) 2026-10-15 20:42:38 -07:00
Brent Vatne d61d9b9fc5 Release 0.19.2 2026-10-15 18:25:01 -07:00
Brent Vatne e8a03a362e Label accessibility-only changes and stop reporting uncompared source changes (#2) 2026-10-15 18:24:49 -07:00
171 changed files with 35331 additions and 1383 deletions

No files matched your search

+44 -13
View File
@@ -34,31 +34,31 @@ Older setups vendored the tools into `.github/vendor/expo-explore` and pinned th
| Workflow | Trigger | Condition | Result |
| --- | --- | --- | --- |
| `explore-review.yml` | `pull_request_target` (opened, synchronize, reopened, ready_for_review), `workflow_dispatch` with `pr=N` | Open, non-draft, same-repository PR whose author has write access or is listed in `ci.trustedAuthors` | Captures base and head, compares, packages a report, comments on the PR |
| `explore-baseline.yml` | `push` to the default branch, `workflow_dispatch` | Default branch only | Captures every route of one commit per configured platform and uploads `explore-baseline-<sha>-<platform>` for later PRs to reuse |
| `explore-baseline.yml` | `push` to the default branch, `workflow_dispatch` | Default branch only | Captures every route of one commit per configured target and uploads `explore-baseline-<sha>-<target>` for later PRs to reuse |
| `explore-compare.yml` | `workflow_dispatch` or `workflow_call` with `base` and `head` (branch, tag or SHA) | Whoever can run or call workflows (write access) | Captures base and head, compares, packages a report like a PR review (`capture:review --compare`), and links it from the run summary; no PR comment |
Each workflow starts with a `platforms` job: it installs the pinned CLI and runs `expo-explore config:platforms`, whose JSON list (`["ios"]`, `["ios","android"]`) becomes the matrix of the capture, report, and baseline jobs (`fail-fast: false`). Every matrix job passes `--platform ${{ matrix.platform }}`, so one platform's failure neither cancels nor hides the other's report.
Each workflow starts with a `targets` job: it installs the pinned CLI and runs `expo-explore config:targets`, whose target ids (`jq -c '[.targets[].id]'`) become the matrix of the capture, report, and baseline jobs (`fail-fast: false`). A config without `targets:` has one target per platform named after it (`["ios"]`, `["ios","android"]`), so its artifact names, baselines and comment records are the ones per-platform versions wrote; a config with `targets:` lists its own (`["iphone","duo-closed","duo-open","android"]`), and several may share a platform. Every matrix job passes `--target "$TARGET"` (`TARGET: ${{ matrix.target }}`), and GitHub names each job after its target (`capture (duo-open)`), so one target's failure neither cancels nor hides another's report.
### 2.2 `explore-review.yml`
| Job | Step | What it does |
| --- | --- | --- |
| platforms | Install Explore, resolve and authorize the live pull request | As in the capture job below; it exports the PR's number and commits so the failure job can comment even when a capture job fails before resolving the PR itself. Then checks out head and lists the platforms. |
| capture (matrix: platform) | Install Explore | Validates `EXPLORE_VERSION`, `npm pack`s that release into `$TOOLS_PREFIX`, then `npm ci --omit=dev --include=optional --ignore-scripts` against the release's shrinkwrap. The agent runtimes and `eas-cli` are optional dependencies, so `--include=optional` is what makes capture possible. The step is defined once per workflow file (a YAML anchor) and reused in every job. |
| targets | Install Explore, resolve and authorize the live pull request | As in the capture job below; it exports the PR's number and commits so the failure job can comment even when a capture job fails before resolving the PR itself. Then checks out head and lists the targets. |
| capture (matrix: target) | Install Explore | Validates `EXPLORE_VERSION`, `npm pack`s that release into `$TOOLS_PREFIX`, then `npm ci --omit=dev --include=optional --ignore-scripts` against the release's shrinkwrap. The agent runtimes and `eas-cli` are optional dependencies, so `--include=optional` is what makes capture possible. The step is defined once per workflow file (a YAML anchor) and reused in every job. |
| | Resolve and authorize the live pull request | `ci:pr` reads the PR through the API. Forks, drafts and authors without write access (unless listed in `ci.trustedAuthors` of the default branch's `config.yaml`, read through the API) fail with `SOURCE_NOT_TRUSTED`. Writes `explore-pr.json` (repository, number, base/head ref and SHA) and the step outputs. Runs before any PR code is checked out. |
| | checkout `app-base`, `app-head` | Checks out the exact base and head SHAs with full history and without persisted credentials. |
| | Verify deterministic source planning | `source:verify` builds the capture plan from source alone in two fresh processes and compares the bytes. Runs before any build or simulator work and needs no credentials. |
| | Install app dependencies | `npm ci --ignore-scripts` in both checkouts (`APP_INSTALL_DIR` for monorepos). |
| | Find / Download optional exact-base evidence | `ci:find-baseline` looks for a successful `explore-baseline-<base sha>-<platform>` artifact (iOS also accepts the older unsuffixed `explore-baseline-<base sha>`) from the baseline workflow on the default branch and downloads it as `EXPLORE_CAPTURE_CACHE`. Missing evidence is not an error. |
| | Find / Download optional exact-base evidence | `ci:find-baseline` looks for a successful `explore-baseline-<base sha>-<target>` artifact (target `ios` also accepts the older unsuffixed `explore-baseline-<base sha>`) from the baseline workflow on the default branch and downloads it as `EXPLORE_CAPTURE_CACHE`. Missing evidence is not an error. |
| | Capture review | `capture:review` (§3). `EXPO_TOKEN`, the provider key and the app's `{{secret:NAME}}` values reach only this step. The sticky PR comment is updated while it runs. It writes `preview=<hosting>` to the step outputs, which decides whether the deploy job runs. |
| | Stop capture sessions and check the checkouts | `ci:after-capture`, whenever the PR was resolved, success or not: stops the EAS Simulator sessions named in `head-session` / `base-session`, nothing else, then fails with `CHECKOUT_MODIFIED` if capture modified an app checkout. |
| | Upload captured review / diagnostics | `explore-capture-<run>-<attempt>-<platform>` feeds the report job. On failure `explore-diagnostics-<run>-<attempt>-<platform>` keeps plans, exports and agent diagnostics for 7 days. |
| report (matrix: platform) | Install Explore, download the capture | Runs without Expo or model credentials. |
| | Upload captured review / diagnostics | `explore-capture-<run>-<attempt>-<target>` feeds the report job. On failure `explore-diagnostics-<run>-<attempt>-<target>` keeps plans, exports and agent diagnostics for 7 days. |
| report (matrix: target) | Install Explore, download the capture | Runs without Expo or model credentials. |
| | Package hosted review bundle | `ci:report` writes the report directory. |
| | Upload hosted review bundle | `explore-review-<run>-<attempt>-<platform>`, kept 30 days. |
| | Publish current PR hosted links | `ci:publish` re-checks that the artifact belongs to this PR, then updates the sticky comment with **Open** (the hosted Viewer) and **zip**. The comment has one section per platform between `<!-- expo-explore-platform:<platform> -->` markers; each job replaces only its own section, so parallel platforms do not overwrite each other. |
| `deploy` (only when `report.preview` is set; after every report job) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every platform's capture and report artifacts, zips and encrypts each report, deploys it with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report** and the link's expiry. |
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only the failed platform's section when the run has several. |
| | Upload hosted review bundle | `explore-review-<run>-<attempt>-<target>`, kept 30 days. |
| | Publish current PR hosted links | `ci:publish` re-checks that the artifact belongs to this PR, then updates the sticky comment with **Open** (the hosted Viewer) and **zip**. The comment is rendered from one hidden record per target (`<!-- expo-explore-record:<target>:… -->`, plus one history line for earlier runs); each job folds its own record into the ones the comment already carries and re-renders the whole comment, so parallel targets do not overwrite each other. Rows, report links and validation columns are labelled with the target's label (`iOS` and `Android` without `targets:`) and follow config order. |
| `deploy` (only when `report.preview` is set; after every report job) | Deploy the hosted preview | `ci:deploy --inputs --reports` downloads every target's capture and report artifacts, zips and encrypts each report, deploys it with the prebuilt preview Viewer to a dedicated EAS Hosting project (the only post-capture job holding `EXPO_TOKEN`), verifies that only `/p/<token>` answers, then updates the comment with **Explore report** and the link's expiry. |
| failure | Report failure only on the current PR | Downloads whichever diagnostics exist and posts the failure comment to this PR alone, replacing only the failed target's record when the run has several; the target is the id the failed job's diagnostics artifact name ends with, and its label comes from the record the capture job already posted. |
A reviewer downloads the report ZIP and drops it on the hosted Viewer; downloading needs read access to the repository.
@@ -68,7 +68,7 @@ Validate baseline source → Install Explore → Verify deterministic source pla
### 2.4 `explore-compare.yml`
The same jobs as a PR review, for any `base` and `head` without a pull request. The `platforms` job resolves both refs once with `ci:compare-refs` (a tag wins over a branch of the same name; the same commit twice fails with `COMPARE_SAME_COMMIT`) and passes the comparison to the capture jobs, which run `capture:review --compare` with no GitHub requests. The optional `scope` and `expires-in` inputs override `exploration.scope` and `report.preview.expiresAfter` for that run. The report job's `ci:publish` writes each platform's **Open** and **zip** links to the run summary, and the deploy job adds the hosted link there; nothing comments on a pull request.
The same jobs as a PR review, for any `base` and `head` without a pull request. The `targets` job resolves both refs once with `ci:compare-refs` (a tag wins over a branch of the same name; the same commit twice fails with `COMPARE_SAME_COMMIT`) and passes the comparison to the capture jobs, which run `capture:review --compare` with no GitHub requests. The optional `scope` and `expires-in` inputs override `exploration.scope` and `report.preview.expiresAfter` for that run. The report job's `ci:publish` writes each target's **Open** and **zip** links to the run summary, and the deploy job adds the hosted link there; nothing comments on a pull request.
## 3. Inside `capture:review` (`runCiReview`)
@@ -93,7 +93,7 @@ A failure at any stage is recorded in `state.failure`, a partial report is writt
| 1 | cache | If a reuse directory exists, its bundle and map are validated and copied. With no routes left, skip straight to export. |
| 2 | `configuration` | `eas config --profile` confirms the app identity and scheme, `ios.simulator: true` and the bundle ID; `eas simulator:availability`. |
| 3 | `build` | `eas fingerprint:generate`; a finished simulator build with the same fingerprint is reused, otherwise `eas build --wait` (up to 45 minutes). |
| 4 | `instrumentation` | A hosted EAS `repack` workflow job (`eas workflow:run --wait --json` from a staged copy of the checkout) rebundles the current JavaScript with a read-only navigation observer (the same observer on both sides) and returns the repacked build ID; `capture.repack: local` runs `@expo/repack-app` on the runner and `eas upload`s the result. Generated files stay outside the checkout. |
| 4 | `instrumentation` | A hosted EAS `repack` workflow job (`eas workflow:run --wait --json` from a staged copy of the checkout) rebundles the current JavaScript with a read-only navigation observer (the same observer on both sides), and the repacked app is downloaded and installed into the session; `capture.repack: local` (the default with `capture.simulator: local`) runs `@expo/repack-app` on the runner, and its app is installed without an upload. Generated files stay outside the checkout. |
| 5 | `session` | `eas simulator:start`; the session ID is written to `<side>-session`; the app is installed. |
| 6 | route capture | Mode-specific (§5). `agent-device` drives the simulator and records a screenshot plus the accessibility tree. A capture is accepted only when the observer's reported destination matches the requested route. |
| 7 | `export` / `cleanup` | Validate the map, write `<side>-export/` (`bundle.json`, `execution.json`, PNGs, `capture-diagnostics/`), stop the session. |
@@ -143,8 +143,39 @@ A failure at any stage is recorded in `state.failure`, a partial report is writt
| Only app-wide inputs changed (`app-wide`) | Modified | Unchanged (one line in the PR comment) | Needs review |
| No source change (`none`) | Screen variant (listed apart from Changes) | Unchanged | Unchanged |
A screen whose source changed but whose screenshots were not compared (it is outside the capture scope) has no
verdict: the PR comment does not list it, the agent API reports `not-compared`, and the Viewer marks it Not compared.
Earlier versions listed it as Source-affected. A planned capture that failed is counted as unavailable and named under
Validation.
"Differs" means the screenshots differ or the accessibility tree does. A Modified screen whose screenshots match is
**Accessibility only**: what screen readers and voice control read changed (a label, a role, an element added to the tree)
but nothing shows in the capture. It is still a change: the PR comment counts it apart ("3 visual changes · 12
accessibility only") under 🟦 Accessibility only, the Viewer marks it blue and Compare steps through it, and the agent API
reports `status: "accessibility-only"` with `sourceStatus: "modified"`. The report contract is unchanged (its review
status stays `modified`), so earlier reports read the same way. The accessibility tree can include content outside the
screenshot, such as rows scrolled below the fold or elements under a sheet, so an accessibility-only change is not always
invisible on a device.
A pixel mismatch that rounds to 0.00% is noise and counts as "same". Diff regions inside the status-bar band are excluded from the verdict and reported as `ignoredStatusBarRegions`; the Viewer marks that band in Compare.
Each changed region also records whether its content only moved. CI searches for the shift (up to 20 screenshot
pixels vertically and 4 horizontally, whole pixels and then sixths of one) that best lines Before up with After inside
the region; near-ties go to the smallest move, and a second fit nearly as good two or more pixels away (repeating
content) or a best fit at the edge of the search leaves the region unmeasured. When the shift explains most of the
region's difference (a quarter for a move of half a pixel or less, where text re-rasterizes rather than moves; 60%
above that) and, aligned by it, no more than two pixels still differ by over 140 in any channel, the region gets
`shift: { x, y }` in screenshot pixels (right and down positive). New text, another colour or a caret is not a move.
Every region the comparison found is measured, not only the eight it publishes, and `allRegionsMoved: true` says all
of them moved. Moves are measured while the comparison's time budget lasts.
The Viewer draws moved areas dashed, at each side's own position, labelled with how far they moved to a tenth
("↑4.1pt"); areas whose moves are within a third of each other merge into one outline, never around a changed area.
When every region moved, What changed says how far per direction in place of the generic visual finding, and adds
"Nothing on this screen changed content" when no other finding remains. A switch there turns the labels off. iOS
screenshots are one pixel per point, so labels read in points; Android's are labelled in screenshot pixels, since the
report does not know the screen's density.
## 7. Local CI test
`test/ci/run.mjs` runs the production pipeline against an app folder in this repository (`test/ci/apps/wallet`) and a scenario (`test/ci/scenarios/<app>/<name>/`: `scenario.json`, `overlay/`, `expected.json`, optional `setup.yaml`). The [local CI test harness README](test/ci/README.md) covers prerequisites, scenarios, expectations, the matrix runner and how to revisit a result. In outline:
+189 -88
View File
@@ -4,11 +4,52 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-hero-dark.png">
<img alt="Explore's Map of the euxy app with the new About screen selected: every screen as a card laid out by distance from the launch screen, and the Inspector on the right showing the About capture as an added screen with its transitions" src="docs/screenshots/readme-hero-light.png">
<img alt="Explore's Map of a euxy pull request, zoomed in on the new About screen, marked Added among the modified Patterns screens, with its transitions highlighted and the Inspector open on it, shown as a window on a soft stage" src="docs/screenshots/readme-hero-light.png">
</picture>
**See a real report:** [euxy](https://explore-example--euxy.expo.app/p/rfcoic27ccgnrmzgijubxkmuzmptcrva?platform=ios), a MIDI sequencer, reviewed by Explore. It is redeployed with the current Viewer on every merge to main.
<table>
<tr>
<td width="33%" valign="top">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-compare-dark.png">
<img width="100%" alt="The Compare view with the euxy Patterns screen's before and after captures side by side: each pattern row's tempo moved out of the subtitle into its own column on the right, the changed subtitles outlined in both" src="docs/screenshots/readme-compare-light.png">
</picture>
<strong>Compare</strong>: each changed screen before and after, with the changed regions outlined.
</td>
<td width="33%" valign="top">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-screens-dark.png">
<img width="100%" alt="The Screens view of a euxy review: the app/ route tree on the left under Changed 9 and All 19, and a grid of screen cards beside it in the same order, each with its route below the screenshot and a dot before it: green for the new /about, orange for modified screens such as /activity-log, /settings and /patterns, red for the removed /channel-surf" src="docs/screenshots/readme-screens-light.png">
</picture>
<strong>Screens</strong>: every capture in one grid, beside the route tree, with a dot for what changed.
</td>
<td width="33%" valign="top">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-pr-comment-dark.png">
<img width="100%" alt="Explore's GitHub PR comment on a euxy PR: the heading links to the iOS and Android reports, a table with one row per platform giving device, result and an Open link, the Added, Removed, Modified, Needs review and Source-affected screens as collapsed lists, fading out below them" src="docs/screenshots/readme-pr-comment-light.png">
</picture>
<strong>A comment on every PR</strong>: with <a href="#set-up-ci">CI</a>, the report links and the added, removed and modified screens.
</td>
</tr>
</table>
<details>
<summary><strong>Ask an agent about a report</strong></summary>
Paste this into Claude Code, Codex, Cursor, or any tool that can fetch a URL. In the Viewer, **Hand off to AI** fills it in for you:
```text
Review the visual changes in this PR. Expo Explore report: <report link>
Fetch the link first. It explains the report's JSON API. Go through the changed screens,
compare the before and after screenshots, and tell me which changes look intended and
which look like regressions. For each regression, name the source file to fix.
```
</details>
<details>
<summary><strong>Requirements</strong></summary>
@@ -20,9 +61,75 @@ Explore maps your app: a screenshot of every screen, connected by the taps betwe
</details>
## Try it on your app
## Quick start
Paste this into Claude Code or Codex from your app's directory. It explores a build you point to, or an Expo project straight from its source:
Review a change to your own app, on your machine. You need an Expo SDK 57+ app with Expo Router or React Navigation, Node.js 24.12+, and EAS Simulator access ([join the waitlist](https://expo.dev/services/simulators)). No API keys, no CI.
From your app's directory:
1. **Make the app buildable on EAS, if it is not yet.**
```sh
npx eas-cli@latest login
npx eas-cli@latest init
```
Then set `ios.bundleIdentifier` in your app config, add a simulator profile to `eas.json`, and commit. The review builds your last commit as the "before".
```json
{ "build": { "explore": { "ios": { "simulator": true } } } }
```
2. **Change a screen, then review the change.** Edit some text near the top of a screen (Explore captures the first screenful) and run:
```sh
npx @expo/explore capture
```
Explore builds your last commit and your uncommitted changes on EAS, captures the screens the changes can affect, before and after, on EAS Simulator, and opens the report in your browser. The first run waits for an EAS build; later runs reuse it while your native code is unchanged.
Or paste this into Claude Code or Codex from your app's directory:
```text
Show me an Expo Explore review of a change to this app. Follow the "Review a change on
this machine" section of https://unpkg.com/@expo/explore/skills/explore-setup/SKILL.md.
If the app cannot build for the iOS Simulator on EAS yet, set that up (an EAS project,
ios.bundleIdentifier, an "explore" profile with ios.simulator: true) and ask me before
you commit it. If I have no uncommitted changes, change some text near the top of a
screen. Then run npx @expo/explore capture and open the report.
```
Every run is kept on your machine for 30 days. `npx @expo/explore reports` lists your local reviews, explorations and uploaded reports with their commits, and reopens or hosts one without capturing again:
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-reports-dark.png">
<img alt="npx @expo/explore reports in a terminal: the Expo Explore wordmark, then one line per saved run (a local review of HEAD vs main selected, an exploration of an app, and PR #1), and below them the selected run's head and base commits with their messages and its 13 modified, 2 added, 2 removed and 17 need-review screens" src="docs/screenshots/readme-reports-light.png">
</picture>
<details>
<summary><strong>Other commits, and what a review does</strong></summary>
```sh
npx @expo/explore capture # HEAD and your uncommitted changes, against where HEAD left the default branch
npx @expo/explore capture --committed # HEAD alone
npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all --upload
```
- It checks out both commits as temporary worktrees, installs their dependencies, captures every configured platform on EAS Simulator (`--platform` picks one), and opens the report in a local Viewer. `--upload` hosts it and prints the link; `report:upload <report.zip>` hosts one you already have.
- Your checkout, index and branches are never touched. Your uncommitted changes, untracked files included, are reviewed as `eas build` would upload them; `--committed`, or `cli.requireCommit: true` in `eas.json`, leaves them out.
- It runs both commits' code on your machine, as you: installing their dependencies, evaluating the app config, and bundling the JavaScript. That is what checking them out and running them would do, so review only commits you would run, and someone else's branch only if you trust it.
- Installs run without credential environment variables, which keeps tokens out of reach of a registry a commit's `.npmrc` names; that is not a sandbox. A registry that needs `${NPM_TOKEN}` in the project's `.npmrc` must be authenticated in your own `~/.npmrc`.
- Captures are cached in `~/.cache/expo-explore`, so the same base is not captured twice (`--no-cache` skips it); a capture unused for 30 days goes, and the cache stays under 2 GB. Ctrl+C stops the run's simulator sessions.
- Like a CI review, it builds on EAS (reusing a matching build) and runs simulator sessions: expect several minutes and EAS usage.
- Saved runs take up to 2 GB in all, the oldest going first. `reports add <report.zip>` keeps a report you downloaded, such as a PR's `explore-review` artifact.
</details>
Explore uses its defaults until you run `npx @expo/explore setup`, which writes `.expo-explore/config.yaml` for you to change. Next: [review every pull request](#set-up-ci).
## Map every screen of any app
To map every screen of an app instead, with no config, paste this into Claude Code or Codex from your app's directory. It explores a build you point to, or an Expo project straight from its source:
```text
Show me Expo Explore working on this app. Follow
@@ -66,7 +173,7 @@ Explore starts an EAS Simulator, installs the build, taps through the app with y
<details>
<summary><strong>Explore a simulator session you already started</strong></summary>
If the app is already running on an `agent-device` EAS Simulator session, Explore can start from there. It leaves your session running.
If the app is already running on an EAS Simulator session (`--type agent-device` or `--type argent`), Explore can start from there, with the session's controller. It leaves your session running.
```sh
eas simulator:start --type agent-device --out-config-type dotenv # then agent-device install / open
@@ -87,42 +194,6 @@ One card per screen the run reached, laid out by how many taps it took, with the
</details>
### Review a change before you push it
Once Explore is [set up](#set-up-ci) (`.expo-explore/config.yaml` committed), the review a PR gets also runs on your machine, between any two commits. No tokens or keys to set: it uses your `eas login` and your Claude Code or Codex login.
```text
Review my current changes with Expo Explore. Follow the "Review a change on this machine"
section of https://unpkg.com/@expo/explore/skills/explore-setup/SKILL.md, compare my
branch (with my uncommitted changes) against main, and open the report.
```
Every run is kept on your machine for 30 days. `npx @expo/explore reports` lists your local reviews, explorations and uploaded reports with their commits, and reopens or hosts one without capturing again:
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-reports-dark.png">
<img alt="npx @expo/explore reports in a terminal: the Expo Explore wordmark, then one line per saved run (a local review of HEAD vs main selected, an exploration of an app, and PR #1), and below them the selected run's head and base commits with their messages and its 13 modified, 2 added, 2 removed and 17 need-review screens" src="docs/screenshots/readme-reports-light.png">
</picture>
<details>
<summary><strong>Run it yourself</strong></summary>
```sh
npx @expo/explore capture:review # HEAD against where it left the default branch
npx @expo/explore capture:review --uncommitted # your uncommitted changes too
npx @expo/explore capture:review --base v1.3.0 --head v1.4.0 --scope all --upload
```
- It checks out both commits as temporary worktrees, installs their dependencies, captures every configured platform on EAS Simulator (`--platform` picks one), and opens the report in a local Viewer. `--upload` hosts it and prints the link; `report:upload <report.zip>` hosts one you already have.
- Your checkout, index and branches are never touched. `--uncommitted` takes tracked changes only; `--include-untracked` adds untracked files, which are uploaded with the EAS build.
- It runs both commits' code on your machine, as you: installing their dependencies, evaluating the app config, and bundling the JavaScript. That is what checking them out and running them would do, so review only commits you would run, and someone else's branch only if you trust it.
- Installs run without credential environment variables, which keeps tokens out of reach of a registry a commit's `.npmrc` names; that is not a sandbox. A registry that needs `${NPM_TOKEN}` in the project's `.npmrc` must be authenticated in your own `~/.npmrc`.
- Captures are cached in `~/.cache/expo-explore`, so the same base is not captured twice (`--no-cache` skips it); a capture unused for 30 days goes, and the cache stays under 2 GB. Ctrl+C stops the run's simulator sessions.
- Like a CI review, it builds on EAS (reusing a matching build) and runs simulator sessions: expect several minutes and EAS usage.
- Saved runs take up to 2 GB in all, the oldest going first. `reports add <report.zip>` keeps a report you downloaded, such as a PR's `explore-review` artifact.
</details>
## Set up CI
Explore runs in your repository's GitHub Actions in two ways, both from the same setup: a review on every pull request, and a comparison of any two commits, such as a release against the last one.
@@ -154,8 +225,8 @@ report:
```
- Run `expo-explore setup --workflows` after enabling it to add the `deploy` job.
- A [comparison of two commits](#compare-any-two-commits) links its hosted report from the run's summary instead of a PR comment. `capture:review --upload` on your machine deploys to the same project with your `eas login`.
- `expo-explore report:upload <report.zip>...` hosts reports already on your machine the same way: a review's reports (one per platform, from `capture:review --output` or a downloaded `explore-review` artifact) or an `explore:binary` report.
- A [comparison of two commits](#compare-any-two-commits) links its hosted report from the run's summary instead of a PR comment. `capture --upload` on your machine deploys to the same project with your `eas login`.
- `expo-explore report:upload <report.zip>...` hosts reports already on your machine the same way: a review's reports (one per platform, from `capture --output` or a downloaded `explore-review` artifact) or an `explore:binary` report.
- `EXPO_TOKEN` must be able to create the EAS project, so use a [robot user's](https://docs.expo.dev/accounts/programmatic-access/) token.
- The report is encrypted, and only a request carrying the link's token can open it. Treat the link like a shared file link; see [report access](docs/private-review.md#hosted-previews).
@@ -172,7 +243,7 @@ The prompt above walks through these steps with you. To do them yourself:
- `EXPO_TOKEN`: create it in [Expo access tokens](https://expo.dev/settings/access-tokens). For [hosted previews](#hosted-previews), use a [robot user](https://docs.expo.dev/accounts/programmatic-access/) that can create projects.
- A secret for each `{{secret:NAME}}` in your setup steps. Run `npx @expo/explore setup --workflows` after you add one.
4. Commit, merge to the default branch, and run **Expo Explore baseline** from GitHub Actions.
5. Open a PR. **Expo Explore review** runs and posts a comment with the report. To see a whole review of your branch first, run `npx @expo/explore capture:review` on your machine.
5. Open a PR. **Expo Explore review** runs and posts a comment with the report. To see a whole review of your branch first, run `npx @expo/explore capture` on your machine.
A failed run shows an error code and a next action in the PR comment; see [CI troubleshooting](docs/quickstart-ci.md#diagnose-a-failed-run).
@@ -227,6 +298,76 @@ platforms:
</details>
<details>
<summary id="targets"><strong>Several devices: targets</strong></summary>
To capture more than one device of a platform, such as a phone and a foldable, or a foldable both closed and open, name each one under `targets` instead of `platforms`. Each target is captured and reported on its own, in this order:
```yaml
targets:
iphone: { platform: ios, device: iPhone 17 }
duo-closed: { platform: ios, device: iPhone Duo, pose: closed }
duo-open: { platform: ios, device: iPhone Duo, pose: open }
android: { platform: android, device: pixel_7, bundleId: com.example.myapp, easProfile: explore-android }
```
- A target takes the flat `app` and `device` fields it does not set; a target of another platform than `app.platform` sets its own `bundleId` and `easProfile`. `label` names it in reports (by default its device and pose).
- Ids are lowercase letters, digits and dashes. A config with `platforms` has one target per platform, named `ios` and `android`.
- The workflows run one capture job per target, the PR comment has a section per target, and each report links its sibling targets' reports.
- `capture --target duo-open` reviews one target on this machine; `--platform ios` the iOS ones.
</details>
<details>
<summary id="controller"><strong>Device controller: agent-device or Argent</strong></summary>
Explore drives EAS Simulator with [agent-device](https://github.com/callstackincubator/agent-device) by default. To use [Argent](https://github.com/software-mansion/argent) instead, set it in the config or pass it for one run:
```yaml
capture:
controller: argent # agent-device (default) | argent
```
```sh
npx @expo/explore capture --controller argent
npx @expo/explore explore:binary ./app.apk --controller argent
```
Explore pins each controller's version and starts the EAS session with it. Reports and baselines record the controller, and a review compares captures made with the same one.
Neither controller is installed with Explore. The first run that needs one downloads its pinned npm release (agent-device 1.4 MB, Argent 27 MB), checks it against the integrity hash Explore pins, and keeps it in `~/.cache/expo-explore/controllers` (`EXPLORE_CONTROLLER_CACHE` moves it). Behind a private registry, set `EXPLORE_NPM_REGISTRY` to a mirror of it.
Argent cannot switch the simulator's appearance yet ([software-mansion/argent#1509](https://github.com/software-mansion/argent/pull/1509)), so an Argent capture on EAS Simulator records one appearance: the one the app forces, else light. Explore warns when it skips one. On a [local simulator](#simulator) the host switches it, so both are captured.
</details>
<details>
<summary id="simulator"><strong>Local simulator instead of EAS Simulator</strong></summary>
To capture on your Mac instead of EAS Simulator, set it in the config or pass it for one run:
```yaml
capture:
simulator: local # eas (default) | local
```
```sh
npx @expo/explore capture --simulator local
```
For each commit, Explore starts a device of its own and removes it afterwards; head and base each get one:
- **iOS:** a simulator of the configured device with Xcode's newest runtime that runs it. `DEVELOPER_DIR` picks another Xcode, such as one that adds iPhone Duo. Explore approves the app's URL scheme on it, so links open without iOS asking "Open in …?", and checks a foldable's pose by the shape of its lit display.
- **Android:** an emulator of the configured device profile (such as `pixel_7`), from the newest Google APIs system image installed for this machine (`arm64-v8a` on Apple silicon), in a private AVD folder. The APK must ship native libraries for that ABI; a universal build does.
Builds still run on EAS. The app is repacked with the route observer on your machine as well, so it is never uploaded; on Android that needs the SDK's build-tools and a JDK. `capture.repack: eas` (or `--repack eas`) keeps the repack in a hosted EAS job. `doctor --simulator local` checks that Xcode and the Android SDK can start each device, and that Android can be repacked locally.
With `--controller argent`, Explore installs Argent's tool-server on first use (with its dependencies, about 165 MB, in the controller cache) and starts one per device. The host switches the appearance, so a local Argent capture records light and dark. Reports record where they were captured, and a baseline is reused only by a review captured the same way.
A review's targets run at once, the targets of a platform sharing each commit's build; `--parallel N` runs at most N at a time. A device controller that stops answering on one screen costs that route: Explore restarts the app, goes on with the next route, and records what happened in `capture-diagnostics/controller-recoveries.jsonl`. A target that fails outright costs its own report; the others still open.
</details>
<details>
<summary><strong>Keep your setup current</strong></summary>
@@ -252,7 +393,7 @@ There are a few ways to snapshot a release:
- **On demand:** in your repository's Actions tab, open **Expo Explore compare**, choose **Run workflow**, and set `base` to the last release's tag (`v1.3.0`), `head` to the new tag or release candidate (`v1.4.0-rc.1`), `scope` to `all` and `expires-in` to `never`. The run's summary links the report.
- **Automatically, on every tag:** add the `release-review.yml` in [The comparison workflow](#compare) below. It compares each tag, release candidates included, with the last stable tag, so a release candidate is reviewed against what people have now.
- **On your machine, without CI:** `npx @expo/explore capture:review --base v1.3.0 --head v1.4.0 --scope all --upload`, with your `eas login`. `npx @expo/explore reports` lists the runs you have kept.
- **On your machine, without CI:** `npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all --upload`, with your `eas login`. `npx @expo/explore reports` lists the runs you have kept.
`scope: all` captures every screen, not only those whose source changed, so the report shows the whole release with what changed since the last one marked; `expires-in: never` keeps its link.
@@ -329,46 +470,7 @@ If the sign-in can't be typed (one-time codes, email links, Sign in with Apple o
When a run stops early, `gap:list --dir <output>` says what blocked it.
## What you get
### A comment on every PR
The report links, a row per platform, and the added, removed and modified screens.
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-pr-comment-dark.png">
<img alt="Explore's GitHub PR comment on a euxy PR: the heading links to the iOS and Android reports, a table with one row per platform giving device, result and an Open link, the Added, Removed, Modified, Needs review and Source-affected screens as collapsed lists, fading out below them" src="docs/screenshots/readme-pr-comment-light.png">
</picture>
### Compare
Each changed screen before and after, with the changed regions outlined.
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-compare-dark.png">
<img alt="The Compare view with the euxy Patterns screen's before and after captures side by side: each pattern row's tempo moved out of the subtitle into its own column on the right, the changed subtitles outlined in both" src="docs/screenshots/readme-compare-light.png">
</picture>
### Screens
Every capture, in a section per route folder, with a route tree whose folders fold away and a **Changed** / **All** filter.
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshots/readme-screens-dark.png">
<img alt="The Screens view of a euxy review: a foldable route tree on the left with Changed and All above it, and the screens in sections named after their app/ folder (Launch, Sequencer, Settings, Patterns) with each folder path beneath, the new About screen marked Added, Activity Log and Settings marked Modified, and the Sequencer marked No visible change" src="docs/screenshots/readme-screens-light.png">
</picture>
### Ask an agent about it
Paste this into Claude Code, Codex, Cursor, or any tool that can fetch a URL. In the Viewer, **Hand off to AI** fills it in for you:
```text
Review the visual changes in this PR. Expo Explore report: <report link>
Fetch the link first. It explains the report's JSON API. Go through the changed screens,
compare the before and after screenshots, and tell me which changes look intended and
which look like regressions. For each regression, name the source file to fix.
```
## Additional information
<details>
<summary><strong>Terms in the report</strong></summary>
@@ -387,7 +489,7 @@ The same link answers differently depending on who asks. It already carries the
- A browser gets the Viewer.
- Anything that does not ask for HTML (`curl`, `fetch`, agents' URL tools) gets a Markdown index of the report, also at `/llms.txt`.
- The index links to a read-only JSON API under `/api/v1`: `/screens?status=modified,added,removed`, `/screens/<id>`, `/transitions`, and `/raw` for the report file.
- The index links to a read-only JSON API under `/api/v1`: `/screens?status=modified,accessibility-only,added,removed`, `/screens/<id>`, `/transitions`, and `/raw` for the report file.
- Reports without source also expose `/journeys`, `/gaps`, and `/frontier`.
- Multi-platform reports take `?platform=ios|android`. Expired links answer `410`.
@@ -397,8 +499,6 @@ curl -s "$LINK/api/v1/screens?status=modified" | jq '.items[] | {route, status,
</details>
## Additional information
<details>
<summary><strong>How it works</strong></summary>
@@ -408,7 +508,7 @@ curl -s "$LINK/api/v1/screens?status=modified" | jq '.items[] | {route, status,
4. It compares the captures. A screen with a source change is **Modified** if its captures differ.
5. It uploads the report to GitHub Actions and posts a PR comment.
The same review runs for any two commits without a PR ([`explore-compare.yml`](#compare-any-two-commits), linking the report from the run summary) and on your machine (`capture:review`, [above](#review-a-change-before-you-push-it)). The workflows' logic lives in `expo-explore ci:*` commands, so a fix reaches CI with the `@expo/explore` version the workflows pin.
The same review runs for any two commits without a PR ([`explore-compare.yml`](#compare-any-two-commits), linking the report from the run summary) and on your machine (`capture`, [above](#quick-start)). The workflows' logic lives in `expo-explore ci:*` commands, so a fix reaches CI with the `@expo/explore` version the workflows pin.
Reports and baselines are kept for 30 days and diagnostics for 7. Hosted deployments are never deleted automatically; see [report access](docs/private-review.md).
@@ -423,6 +523,7 @@ Reports and baselines are kept for 30 days and diagnostics for 7. Hosted deploym
- The launch is captured once per appearance and compared like any screen. The comment says how long the splash stayed as it first appeared, when it first changed (a native launch screen handing over to an app-drawn one, an animation starting on it), and when the first screen settled. `capture.launch: video` adds a recording; a launch too fast to observe is reported as "no splash observed".
- On Android the splash usually shows only in the recording, which needs `ffmpeg`. The generated workflows install it.
- Hosted acceptance of agent mode with an API key is incomplete.
- With `capture.controller: argent` on EAS Simulator, each capture records one appearance (see [device controller](#controller)).
</details>
File diff suppressed because it is too large. Load diff
@@ -0,0 +1,8 @@
{
"name": "expo-explore-argent-tool-server",
"private": true,
"description": "Argent's tool-server at the release Explore pins, with every dependency locked: installed with npm ci for local simulators.",
"dependencies": {
"@swmansion/argent": "0.29.0"
}
}
+11 -4
View File
@@ -73,7 +73,7 @@ Every selected target on both revisions must have a screenshot of its verified d
### Automatic destination verification
CI repacks both Base and Head with the same read-only navigation observer, including when EAS creates a fresh native build. By default the repack is a hosted EAS `repack` workflow job: the tracked files of the clean checkout are staged in a temporary copy together with the generated observer, Metro override and a one-job workflow, uploaded with `eas workflow:run --wait`, and the job's build ID starts the simulator session. `capture.repack: local` runs `@expo/repack-app` on the runner and uploads the result with `eas upload` instead. Generated files never land in the source checkout. The application does not need to import a marker or maintain a screen manifest.
CI repacks both Base and Head with the same read-only navigation observer, including when EAS creates a fresh native build. By default the repack is a hosted EAS `repack` workflow job: the tracked files of the clean checkout are staged in a temporary copy together with the generated observer, Metro override and a one-job workflow, and run with `eas workflow:run --wait`; the repacked app is downloaded and installed into the simulator session, which started while the job ran. `capture.repack: local` runs `@expo/repack-app` on the runner instead, and its app is installed without being uploaded. With `capture.simulator: local` the repack runs on that machine unless `capture.repack: eas` says otherwise. Generated files never land in the source checkout. The application does not need to import a marker or maintain a screen manifest.
The observer adapter requires **Expo SDK 57 or newer** and an installed Expo CLI with Metro configuration override support. It accepts **Expo Router 57 or newer**, or **React Navigation core 6 or newer**. Older packages fail instrumentation explicitly.
@@ -103,7 +103,7 @@ exploration:
capture:
maxMinutes: 30
maxActions: 500
repack: eas # eas (hosted workflow job) | local (repack-app on the runner)
repack: eas # eas (hosted workflow job; the default on EAS Simulator) | local (repack-app on the runner; the default with simulator: local)
appearance: auto # auto (follow the app's userInterfaceStyle: automatic captures light and dark) | dark | light | [dark, light]
launch: screenshot # screenshot (relaunch the app per appearance and keep its splash and first settled frame, default) | video (also keep a launch recording in the report) | off
reset: root-link # root-link (open the app's root link and let it settle before every route link, default) | none (each link opens from whatever the previous route left on screen)
@@ -172,13 +172,20 @@ imported source changed), `app-wide` (only app-wide inputs such as dependencies,
| --- | --- |
| Added / Removed | Route presence differs between source inventories |
| Modified | The screen's source changed and comparable evidence differs |
| Accessibility only | Modified, but the screenshots match: only the accessibility tree (what screen readers and voice control read) differs. Counted as a change and listed apart from the visual ones |
| Needs review | The screen's source changed and the comparison could not tell whether it looks different; a review target |
| Screen variant | No source change reaches the screen, but its captures differ in runtime UI state (balances, timestamps, loaded content). Listed apart from changes |
| Source-affected | Source impact without a comparison |
| Unchanged | No visible difference, whether or not the screen's source changed. Explore reports visual changes; reports before 0.19.1 called a source change with no visible difference Needs review |
| Not compared | No comparison was performed |
| Not compared | No comparison was performed, including for a screen whose source changed. Not counted as a change: Explore reports what the captures show, not what the code might do. Earlier versions listed these as Source-affected |
A difference that rounds to 0.00% of pixels is rendering noise and counts as no difference.
A changed region whose content only moved (a layout that grew by a device pixel, a sheet that is taller) carries
`shift`, how far it moved in screenshot pixels, and `allRegionsMoved: true` says every region CI found moved (it
publishes the largest eight); the Viewer labels each outline with its move. A shift does not change the verdict: a
moved screen is still Modified.
Accessibility only is how readers present a `modified` verdict whose visual verdict is `unchanged`; the contract has no
separate status for it, so reports from earlier versions show it too. The accessibility tree can include content outside
the screenshot (rows below the fold, elements under a sheet), so such a change may still be visible on a device.
A runtime difference is not proof that the code change caused it. Deterministic mode uses template notes and evidence facts. Agent mode adds AI explanations from the captured evidence and source changes through a separate CLI session; those explanations cannot override fixed verdicts. Structural flows describe possible source navigation; semantic business grouping remains deferred.
## Artifacts and cache
+19 -2
View File
@@ -101,12 +101,15 @@ navigation:
# entry: src/navigation/RootNavigator.tsx
device:
name: iPhone 17 # Android: an AVD profile id such as pixel_7
# pose: open # a foldable (iPhone Duo): closed (the outer display, how a session starts) | half-open | open (the inner display)
exploration:
scope: changes # changes | all
capture:
# controller: agent-device # agent-device (default) | argent (one appearance per capture on EAS Simulator until Argent can switch it; --controller overrides it for one run)
# simulator: eas # eas (EAS Simulator, default) | local (a simulator or emulator Explore starts on this machine with Xcode or the Android SDK; --simulator overrides it for one run)
maxMinutes: 30
maxActions: 500
repack: eas # eas (hosted EAS workflow job, default) | local (repack-app + eas upload on the runner)
repack: eas # eas (hosted EAS workflow job, the default on EAS Simulator) | local (repack-app on the runner, the default with simulator: local; --repack overrides it for one run)
appearance: auto # auto (follow the app's userInterfaceStyle: automatic captures light and dark) | dark | light | [dark, light]
launch: screenshot # screenshot (relaunch the app per appearance and keep its splash and first settled frame, default) | video (also keep a launch recording in the report) | off
reset: root-link # root-link (open the app's root link and let it settle before every route link, default) | none (each link opens from whatever the previous route left on screen)
@@ -129,6 +132,20 @@ platforms:
Commands that capture or publish (`source:verify`, `capture:review`, `capture:baseline`, `ci:report`, `ci:publish`) take `--platform ios|android`; with one configured platform it is optional, with two it is required (`PLATFORM_REQUIRED`). `expo-explore config:platforms` prints the configured list as JSON, which the workflows use as their matrix. Artifacts carry the platform (`explore-capture-<run>-<attempt>-android`, `explore-baseline-<sha>-ios`); an iOS job still reuses an older unsuffixed baseline. The PR comment has one section per platform, and a hosted preview serves both reports from one link.
### Several devices (targets)
`targets` names each capture instead of `platforms`, so one platform can have several devices or poses. Each target is captured, published and commented on as its own report, in config order:
```yaml
targets:
iphone: { platform: ios, device: iPhone 17 }
duo-closed: { platform: ios, device: iPhone Duo, pose: closed }
duo-open: { platform: ios, device: iPhone Duo, pose: open, label: "iPhone Duo (open)" }
android: { platform: android, device: pixel_7, bundleId: com.example.myapp, easProfile: explore-android }
```
A target's id (lowercase letters, digits and dashes; not `base`, `head` or `report`) takes the place of the platform everywhere a capture is named: `--target duo-open`, `explore-capture-<run>-<attempt>-duo-open`, `explore-baseline-<sha>-duo-open`. `expo-explore config:targets` prints the list the workflows use as their matrix. Fields a target leaves out come from `app` and `device`; a target of another platform than `app.platform` sets its own `bundleId` and `easProfile`. A config with `platforms` has one target per platform, named `ios` and `android`, so its names do not change. `--platform` still selects a target when only one has that platform.
Use the actual bundle identifier, scheme, profile, and available simulator device name. `scheme` is optional when static app configuration supplies it. `navigation.entry` resolves ambiguous entry modules; it does not list screens.
Do not add a surface inventory, required fixture routes, runtime probe, configuration version, or Viewer URL. The analyzer discovers screens from source. Application data, time, and network remain live.
@@ -269,7 +286,7 @@ The provider selects the runtime that owns the navigation loop:
| `anthropic` | Claude Code through `@anthropic-ai/claude-agent-sdk` 0.3.285 and its platform-native package | `ANTHROPIC_API_KEY` |
| `openai` | Codex app-server from `@openai/codex` 0.159.2 and its platform-native package | `OPENAI_API_KEY` |
Both runtimes use Explore's device tools to operate the existing EAS Simulator through official `agent-device` 0.21.15. The runtime and native binaries come from the pinned tools installation. CI does not use the development-only `node_modules/.bin/claude` executable or an interactive subscription login.
Both runtimes use Explore's device tools to operate the existing EAS Simulator through official `agent-device` 0.21.28. The runtime and native binaries come from the pinned tools installation. CI does not use the development-only `node_modules/.bin/claude` executable or an interactive subscription login.
Create and commit the nonempty English prose file named by `agent.instructions`. The shared setup skill authors it from source and asks for missing test data or environment inputs. Describe how to reach the app's screens, necessary prerequisites, the representative state to use on both revisions, readiness signals, and actions to avoid. This file guides the runtime agent; it is not a list of mandatory YAML steps or a second screen inventory.
Binary file not shown.

Before

Width:  |  Height:  |  Size: 452 KiB

After

Width:  |  Height:  |  Size: 451 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 452 KiB

After

Width:  |  Height:  |  Size: 452 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 870 KiB

After

Width:  |  Height:  |  Size: 847 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 832 KiB

After

Width:  |  Height:  |  Size: 830 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 151 KiB

After

Width:  |  Height:  |  Size: 151 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 147 KiB

After

Width:  |  Height:  |  Size: 147 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 610 KiB

After

Width:  |  Height:  |  Size: 642 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 606 KiB

After

Width:  |  Height:  |  Size: 643 KiB

+65 -67
View File
@@ -1,18 +1,17 @@
{
"name": "@expo/explore",
"version": "0.19.1",
"version": "0.19.5",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@expo/explore",
"version": "0.19.1",
"version": "0.19.5",
"license": "MIT",
"dependencies": {
"@expo/repack-app": "0.10.1",
"@types/node": "^22.19.19",
"@zip.js/zip.js": "2.16.0",
"agent-device": "0.21.15",
"ajv": "^8.17.1",
"pngjs": "7.0.0",
"typescript": "^5.9.3",
@@ -30,6 +29,7 @@
"@types/react-dom": "^19.2.4",
"@vitejs/plugin-react": "^4.7.0",
"@xyflow/react": "^12.11.3",
"agent-device": "0.21.28",
"babel-plugin-react-compiler": "^1.0.0",
"eslint": "^10.12.0",
"eslint-plugin-react-hooks": "^7.1.1",
@@ -48,7 +48,7 @@
"optionalDependencies": {
"@anthropic-ai/claude-agent-sdk": "0.3.285",
"@openai/codex": "0.159.2",
"eas-cli": "24.4.2"
"eas-cli": "25.0.0"
}
},
"node_modules/@0no-co/graphql.web": {
@@ -1600,15 +1600,15 @@
}
},
"node_modules/@expo/eas-build-job": {
"version": "24.3.0",
"resolved": "https://registry.npmjs.org/@expo/eas-build-job/-/eas-build-job-24.3.0.tgz",
"integrity": "sha512-CyDUm8B8pSH38XZg8QzdPaxukThspSWfJ4ccUBCzBLs/qL6SknaLVswD3OTxNQmirrZUyo72DfzupSxHDZOeyw==",
"version": "25.0.0",
"resolved": "https://registry.npmjs.org/@expo/eas-build-job/-/eas-build-job-25.0.0.tgz",
"integrity": "sha512-Vuai42tVopKuK2KFyTWUsW9cL1YMY1dWhFAKz+evUV5AKaMCk4dYxOYZ6tBWNhIJ15bGK3p4N0YUomlAqubFWg==",
"license": "MIT",
"optional": true,
"dependencies": {
"@expo/logger": "24.0.0",
"@expo/logger": "25.0.0",
"@expo/results": "1.0.0",
"@expo/turtle-spawn": "24.0.0",
"@expo/turtle-spawn": "25.0.0",
"joi": "^17.13.1",
"semver": "^7.6.2",
"zod": "^4.3.5"
@@ -1642,14 +1642,14 @@
}
},
"node_modules/@expo/eas-json": {
"version": "24.3.0",
"resolved": "https://registry.npmjs.org/@expo/eas-json/-/eas-json-24.3.0.tgz",
"integrity": "sha512-FIdvHmGeRFB0BoA4+aicn/tnpUUTSre4cCrN/hk6xkHOlpbjDVyl2tFaEe0RpiI1itrQ2ze/KTUYqdyecfHv0Q==",
"version": "25.0.0",
"resolved": "https://registry.npmjs.org/@expo/eas-json/-/eas-json-25.0.0.tgz",
"integrity": "sha512-ilPw4O0Lnce/6lbu1GPwega8KF2GqTio9vuNFjNaGL78pfxz7GdktBsJ9JRaGtiM0LYdPa09W2FYb7DcMY8xWA==",
"license": "MIT",
"optional": true,
"dependencies": {
"@babel/code-frame": "7.23.5",
"@expo/eas-build-job": "24.3.0",
"@expo/eas-build-job": "25.0.0",
"chalk": "4.1.2",
"env-string": "1.0.1",
"fs-extra": "11.2.0",
@@ -1900,9 +1900,9 @@
}
},
"node_modules/@expo/logger": {
"version": "24.0.0",
"resolved": "https://registry.npmjs.org/@expo/logger/-/logger-24.0.0.tgz",
"integrity": "sha512-LezHQbZbqa7papq2ciCmwEjz4gUxe3b4oIdl3IU/wp3WGy+zQ4s+xKdDuUCbDLVkbqABBgVNqFav4ucXo1Gh/w==",
"version": "25.0.0",
"resolved": "https://registry.npmjs.org/@expo/logger/-/logger-25.0.0.tgz",
"integrity": "sha512-KcNOYmeJH8GESYEjbiewg+LU98XH/yBs368XlPqmEHVZekkbOONpIzPd5AFcFRWO1BW0c2nl/58BUI876UFT8A==",
"license": "BUSL-1.1",
"optional": true,
"dependencies": {
@@ -2592,14 +2592,14 @@
}
},
"node_modules/@expo/steps": {
"version": "24.3.0",
"resolved": "https://registry.npmjs.org/@expo/steps/-/steps-24.3.0.tgz",
"integrity": "sha512-y0zuyUaivXiq1l7D0x9xosUbhtknDwQ4v669smGslshEYXZAuxYQJo0L6H0MRuRsaZn6N8zvfICBM+4n/n4Xeg==",
"version": "25.0.0",
"resolved": "https://registry.npmjs.org/@expo/steps/-/steps-25.0.0.tgz",
"integrity": "sha512-+o04mm5akQJRX0j9TwwkdZiuNM9swLxw9DsDPtFhbWceg95gky/vc/0qF200kjZL4DEMfd/WhzngBW9aqJ0JQg==",
"license": "BUSL-1.1",
"optional": true,
"dependencies": {
"@expo/eas-build-job": "24.3.0",
"@expo/logger": "24.0.0",
"@expo/eas-build-job": "25.0.0",
"@expo/logger": "25.0.0",
"@expo/spawn-async": "^1.7.2",
"arg": "^5.0.2",
"fast-glob": "^3.3.2",
@@ -2637,13 +2637,13 @@
"optional": true
},
"node_modules/@expo/turtle-spawn": {
"version": "24.0.0",
"resolved": "https://registry.npmjs.org/@expo/turtle-spawn/-/turtle-spawn-24.0.0.tgz",
"integrity": "sha512-HtumnPY7iVCc6vDmSmjsUEvhIPnmwVzpQ2aNPxAX+G0M2Zst88DAlItOd7mZUPSNNO8qp3izDPtqmI0fdLYPng==",
"version": "25.0.0",
"resolved": "https://registry.npmjs.org/@expo/turtle-spawn/-/turtle-spawn-25.0.0.tgz",
"integrity": "sha512-XBQZ2azxh0IWozO5hCxIJt150LjIGbk6VZakeyA6UXPHp1ESenm97o0JIHOvzQNOgBV481muV88KmIWHGt0yIA==",
"license": "BUSL-1.1",
"optional": true,
"dependencies": {
"@expo/logger": "24.0.0",
"@expo/logger": "25.0.0",
"@expo/spawn-async": "^1.7.2"
}
},
@@ -4556,6 +4556,16 @@
"node": ">=0.4.0"
}
},
"node_modules/agent-base": {
"version": "7.1.4",
"resolved": "https://registry.npmjs.org/agent-base/-/agent-base-7.1.4.tgz",
"integrity": "sha512-MnA+YT8fwfJPgBx3m60MNqakm30XOkyIoH1y6huTQvC0PwZG7ki8NacLBcrPbNoo8vEZy7Jpuk7+jMO+CUovTQ==",
"license": "MIT",
"optional": true,
"engines": {
"node": ">= 14"
}
},
"node_modules/agent-cli-detector": {
"version": "0.1.7",
"resolved": "https://registry.npmjs.org/agent-cli-detector/-/agent-cli-detector-0.1.7.tgz",
@@ -4570,9 +4580,10 @@
}
},
"node_modules/agent-device": {
"version": "0.21.15",
"resolved": "https://registry.npmjs.org/agent-device/-/agent-device-0.21.15.tgz",
"integrity": "sha512-Om1j6oNJkeKlkk8lBM+0V9bKwpxUXLMf/PDDSvAt3RFquBRqAiM58J81E0rvPQNxs6GCjhABYpwVvIAXptxjjA==",
"version": "0.21.28",
"resolved": "https://registry.npmjs.org/agent-device/-/agent-device-0.21.28.tgz",
"integrity": "sha512-uGEENVhPzSpIACrVlt16O1mloODWJyAemTCT0boDb4L006JXN2rG747u1TRoQJudOpdP/Pm2urxNRHeECLMLfg==",
"dev": true,
"license": "MIT",
"bin": {
"agent-device": "bin/agent-device.mjs"
@@ -5711,9 +5722,9 @@
}
},
"node_modules/eas-cli": {
"version": "24.4.2",
"resolved": "https://registry.npmjs.org/eas-cli/-/eas-cli-24.4.2.tgz",
"integrity": "sha512-7tXqvzZ+4hRBS9p8Voo0PB2Ruapvqc9LLn99ZSw5m2VOQITAxdNhj8PcF+RAV3by7lMGT0oFotP7+/v3FDjpyg==",
"version": "25.0.0",
"resolved": "https://registry.npmjs.org/eas-cli/-/eas-cli-25.0.0.tgz",
"integrity": "sha512-FBY3pIo/3L0s+8KK5ZpMKzlLrA5jOmr5kOpoOwkAXsxMrI4vo+LNoEsciRcOxjce9efc08GqEEPc/CxLRAWIvA==",
"license": "MIT",
"optional": true,
"dependencies": {
@@ -5721,11 +5732,11 @@
"@expo/code-signing-certificates": "0.0.5",
"@expo/config": "55.0.10",
"@expo/config-plugins": "55.0.7",
"@expo/eas-build-job": "24.3.0",
"@expo/eas-json": "24.3.0",
"@expo/eas-build-job": "25.0.0",
"@expo/eas-json": "25.0.0",
"@expo/env": "^1.0.0",
"@expo/json-file": "8.3.3",
"@expo/logger": "24.0.0",
"@expo/logger": "25.0.0",
"@expo/multipart-body-parser": "2.0.0",
"@expo/osascript": "2.1.4",
"@expo/package-manager": "1.9.10",
@@ -5737,7 +5748,7 @@
"@expo/results": "1.0.0",
"@expo/rudder-sdk-node": "1.1.1",
"@expo/spawn-async": "1.7.2",
"@expo/steps": "24.3.0",
"@expo/steps": "25.0.0",
"@expo/timeago.js": "1.0.0",
"@oclif/core": "^4.8.3",
"@oclif/plugin-autocomplete": "^3.2.40",
@@ -5768,7 +5779,7 @@
"gradle-to-js": "2.0.1",
"graphql": "16.8.1",
"graphql-tag": "2.12.6",
"https-proxy-agent": "5.0.1",
"https-proxy-agent": "7.0.6",
"ignore": "5.3.0",
"indent-string": "4.0.0",
"invariant": "^2.2.2",
@@ -5817,19 +5828,6 @@
"node": "^20.18.3 || >=22.0.0"
}
},
"node_modules/eas-cli/node_modules/agent-base": {
"version": "6.0.2",
"resolved": "https://registry.npmjs.org/agent-base/-/agent-base-6.0.2.tgz",
"integrity": "sha512-RZNwNclF7+MS/8bDg70amg32dyeZGZxiDuQmZxKLAlQjr3jGyLx+4Kkk58UO7D2QdgFIQCovuSuZESne6RG6XQ==",
"license": "MIT",
"optional": true,
"dependencies": {
"debug": "4"
},
"engines": {
"node": ">= 6.0.0"
}
},
"node_modules/eas-cli/node_modules/ajv": {
"version": "8.11.0",
"resolved": "https://registry.npmjs.org/ajv/-/ajv-8.11.0.tgz",
@@ -5847,20 +5845,6 @@
"url": "https://github.com/sponsors/epoberezkin"
}
},
"node_modules/eas-cli/node_modules/https-proxy-agent": {
"version": "5.0.1",
"resolved": "https://registry.npmjs.org/https-proxy-agent/-/https-proxy-agent-5.0.1.tgz",
"integrity": "sha512-dFcAjpTQFgoLMzC2VwU+C/CbS7uRL0lWmxDITmqm7C+7F0Odmj6s9l6alZc6AELXhrnggM2CeWSXHGOdX2YtwA==",
"license": "MIT",
"optional": true,
"dependencies": {
"agent-base": "6",
"debug": "4"
},
"engines": {
"node": ">= 6"
}
},
"node_modules/eas-cli/node_modules/ignore": {
"version": "5.3.0",
"resolved": "https://registry.npmjs.org/ignore/-/ignore-5.3.0.tgz",
@@ -7399,6 +7383,20 @@
"url": "https://opencollective.com/express"
}
},
"node_modules/https-proxy-agent": {
"version": "7.0.6",
"resolved": "https://registry.npmjs.org/https-proxy-agent/-/https-proxy-agent-7.0.6.tgz",
"integrity": "sha512-vK9P5/iUfdl95AI+JVyUuIcVtd4ofvtrOr3HNtM2yxC9bnMbEdp3x01OhQNnjb8IJYi38VlTE3mBXwcfvywuSw==",
"license": "MIT",
"optional": true,
"dependencies": {
"agent-base": "^7.1.2",
"debug": "4"
},
"engines": {
"node": ">= 14"
}
},
"node_modules/hyperlinker": {
"version": "1.0.0",
"resolved": "https://registry.npmjs.org/hyperlinker/-/hyperlinker-1.0.0.tgz",
@@ -7808,13 +7806,13 @@
}
},
"node_modules/jsep": {
"version": "1.4.0",
"resolved": "https://registry.npmjs.org/jsep/-/jsep-1.4.0.tgz",
"integrity": "sha512-B7qPcEVE3NVkmSJbaYxvv4cHkVW7DQsZz13pUMrfS8z8Q/BuShN+gcTXrUlPiGqM2/t/EEaI030bpxMqY8gMlw==",
"version": "1.6.0",
"resolved": "https://registry.npmjs.org/jsep/-/jsep-1.6.0.tgz",
"integrity": "sha512-Y8Tr54CX7B5YGAwo7/n8eumidEX3Opx98RyyQVnlHqUaZcPA8uUzL2v1rshr9ypW9Q6hNjfJtg3sL+8kaNE7TA==",
"license": "MIT",
"optional": true,
"engines": {
"node": ">= 10.16.0"
"node": ">= 20.16.0"
}
},
"node_modules/jsesc": {
+4 -3
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/explore",
"version": "0.19.1",
"version": "0.19.5",
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
"license": "MIT",
"type": "module",
@@ -9,6 +9,7 @@
},
"files": [
"action.yml",
"controllers/argent-tool-server",
"npm-shrinkwrap.json",
"dist",
"docs",
@@ -63,7 +64,6 @@
"@expo/repack-app": "0.10.1",
"@types/node": "^22.19.19",
"@zip.js/zip.js": "2.16.0",
"agent-device": "0.21.15",
"ajv": "^8.17.1",
"pngjs": "7.0.0",
"typescript": "^5.9.3",
@@ -73,7 +73,7 @@
"optionalDependencies": {
"@anthropic-ai/claude-agent-sdk": "0.3.285",
"@openai/codex": "0.159.2",
"eas-cli": "24.4.2"
"eas-cli": "25.0.0"
},
"devDependencies": {
"@anthropic-ai/claude-code": "2.1.285",
@@ -83,6 +83,7 @@
"@types/react-dom": "^19.2.4",
"@vitejs/plugin-react": "^4.7.0",
"@xyflow/react": "^12.11.3",
"agent-device": "0.21.28",
"babel-plugin-react-compiler": "^1.0.0",
"eslint": "^10.12.0",
"eslint-plugin-react-hooks": "^7.1.1",
+12
View File
@@ -68,6 +68,16 @@
"pattern": "^\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}(?:\\.\\d{3})?Z$"
},
"platform": { "enum": ["ios", "android"] },
"runTarget": {
"type": "object",
"additionalProperties": false,
"required": ["id", "platform", "label"],
"properties": {
"id": { "type": "string", "pattern": "^[a-z][a-z0-9-]{0,31}$" },
"platform": { "$ref": "#/$defs/platform" },
"label": { "type": "string", "minLength": 1 }
}
},
"controller": { "enum": ["agent-device", "argent"] },
"actionKind": {
"enum": ["press", "fill", "swipe", "back", "dismiss", "deep-link", "key", "other"]
@@ -162,6 +172,8 @@
"name": { "type": "string", "minLength": 1 },
"platform": { "$ref": "#/$defs/platform" },
"platforms": { "type": "array", "items": { "$ref": "#/$defs/platform" }, "minItems": 2, "uniqueItems": true },
"target": { "$ref": "#/$defs/runTarget" },
"targets": { "type": "array", "items": { "$ref": "#/$defs/runTarget" }, "minItems": 2, "maxItems": 8 },
"controller": { "$ref": "#/$defs/controller" },
"bundleId": { "type": "string" },
"deviceId": { "type": "string" },
+42 -3
View File
@@ -6,7 +6,8 @@
// [--pr https://github.com/brentvatne/euxy/pull/148]
//
// --report a sealed review report (the hosted link's report.zip?platform=ios, or the PR's zip artifact)
// --select the route selected on the hero Map (opens the Inspector); default /settings
// --select the route selected on the hero Map (opens the Inspector); default /settings. The hero zooms in around it
// (--zoom, default 73%) and is framed as a window on a soft stage, like the PR comment
// --compare the Compare key of a modified screen: the slug in the Viewer's #/compare/<key> URL; default patterns
// --pr a GitHub PR URL whose Explore comment becomes readme-pr-comment-light.png (public repository): the comment
// at its own size on a soft stage, cut off with a fade after the list of changed screens
@@ -22,6 +23,7 @@ const { values: args } = parseArgs({
select: { type: "string", default: "/settings" },
compare: { type: "string", default: "patterns" },
pr: { type: "string" },
zoom: { type: "string", default: "73" },
},
});
if (!args.report) {
@@ -31,7 +33,7 @@ if (!args.report) {
const out = fileURLToPath(new URL("../docs/screenshots/", import.meta.url));
const SHOTS = [
{ file: "readme-hero", hash: "#/map", viewport: { width: 2200, height: 1240 }, click: "Fit canvas", select: args.select },
{ file: "readme-hero", hash: "#/map", viewport: { width: 1376, height: 774 }, click: "Fit canvas", select: args.select, zoom: Number(args.zoom), framed: true },
{ file: "readme-compare", hash: `#/compare/${args.compare}`, viewport: { width: 1760, height: 1000 } },
{ file: "readme-screens", hash: "#/screens", viewport: { width: 1760, height: 1000 } },
];
@@ -58,11 +60,28 @@ try {
await page.mouse.move(400, shot.viewport.height - 30);
await page.waitForTimeout(1500);
}
if (shot.zoom) {
// Zoom around the selected screen with the wheel, which keeps it under the pointer, then pan it left and up, clear
// of the minimap and the bottom bar. The camera stops at the first wheel step past the zoom asked for.
const box = await page.locator(`.screen-screenshot-target[title="${shot.select}"]`).boundingBox();
await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2);
for (let step = 0; step < 60; step++) {
if (Number((await page.locator(".zoom-button span").first().textContent()).replace("%", "")) >= shot.zoom) break;
await page.keyboard.down("Control");
await page.mouse.wheel(0, -12);
await page.keyboard.up("Control");
await page.waitForTimeout(150);
}
await page.mouse.wheel(160, 90);
await page.mouse.move(shot.viewport.width - 60, shot.viewport.height / 2);
await page.waitForTimeout(1200);
}
if (shot.hash.startsWith("#/compare/") && !page.url().includes(shot.hash)) {
throw new Error(`Compare key ${args.compare} is not a screen of this report (the Viewer went to ${page.url()}); pass --compare <key> from a #/compare/<key> URL.`);
}
const path = `${out}${shot.file}-${theme}.png`;
await page.screenshot({ path });
if (shot.framed) await writeFile(path, await stagedWindow(browser, await page.screenshot(), shot.viewport, theme));
else await page.screenshot({ path });
console.log(path);
await context.close();
}
@@ -95,6 +114,26 @@ try {
await server.close?.();
}
/**
* A Viewer screenshot as a window on a rounded 1600×900 stage (drawn at 2x), with a hairline border and a soft shadow,
* as the post about Explore frames it. The corners outside the stage stay transparent, so it sits on either GitHub theme.
*/
async function stagedWindow(browser, shot, viewport, theme) {
const dark = theme === "dark";
const stage = dark ? "#151B23" : "#F6F8FA";
const border = dark ? "#3D444D" : "#D1D9E0";
const shadow = dark ? "0 2px 4px rgba(1,4,9,0.4), 0 30px 70px rgba(1,4,9,0.6)" : "0 2px 4px rgba(17,17,17,0.04), 0 30px 70px rgba(17,17,17,0.14)";
const context = await browser.newContext({ viewport: { width: 1600, height: 900 }, deviceScaleFactor: 2 });
const page = await context.newPage();
await page.setContent(`<!doctype html><html><body style="margin:0;background:transparent">
<div id="stage" style="position:relative;width:1600px;height:900px;background:${stage};border-radius:22px;overflow:hidden">
<img src="data:image/png;base64,${shot.toString("base64")}" style="position:absolute;left:${(1600 - viewport.width) / 2}px;top:${(900 - viewport.height) / 2}px;width:${viewport.width}px;height:${viewport.height}px;box-sizing:border-box;border:1px solid ${border};border-radius:14px;box-shadow:${shadow}">
</div></body></html>`);
const png = await page.locator("#stage").screenshot({ omitBackground: true });
await context.close();
return png;
}
/**
* The comment on a rounded stage as wide as the README column (880 px, drawn at 2x), with a soft shadow and a fade at
* the cut. The corners outside the stage stay transparent, so the image sits on either GitHub theme.
+4 -4
View File
@@ -24,8 +24,8 @@ Platform, bundle id, app name and version are read from the archive; do not pass
## What happens
1. Archive inspection and compatibility checks (size, simulator build, emulator ABI, sha256).
2. `eas simulator:start` of an empty agent-device session, verified by exact session id before use.
3. `agent-device install` of the archive straight into the session, then `open <bundle id>`.
2. `eas simulator:start` of an empty agent-device session (an `argent` one with `--controller argent`), verified by exact session id before use.
3. `agent-device install` of the archive straight into the session (Argent: `reinstall-app`), then `open <bundle id>`.
4. The model explores through a small tool set (observe, act, capture, finish); app text is treated as untrusted and destructive controls (delete, reset, sign out, purchase, send, share) are blocked outside the model.
5. The map and screenshots are written under `--output` (default `./explore-<archive>-<timestamp>`), plus `report/` for the Viewer.
6. The report is sealed and deployed to EAS Hosting (`--no-upload` skips this; `--expires-in 7d|30d|never`).
@@ -65,14 +65,14 @@ The model only ever sees the reference; Explore types the value into the field.
## Already have a session? `explore:session`
When the app is already installed on an agent-device EAS Simulator session you started (for example after `eas simulator:start --type agent-device --out-config-type dotenv`, `agent-device install ...`, `agent-device open ...`), skip intake and install:
When the app is already installed on an EAS Simulator session you started (for example after `eas simulator:start --type agent-device --out-config-type dotenv`, `agent-device install ...`, `agent-device open ...`; an `--type argent` session works the same way, with Argent's tools), skip intake and install:
```sh
npx @expo/explore explore:session # session from ./.env.eas-simulator or EAS_SIMULATOR_SESSION_ID; explores the app in the foreground
npx @expo/explore explore:session <session-id> --env-file path/.env.eas-simulator --bundle-id dev.brent.euxy --json
```
The app is whatever is in the foreground, else the only user-installed app; pass `--bundle-id` when neither is clear (`BUNDLE_ID_REQUIRED` lists what is installed); `--app-name`/`--app-version` label the report. The session is checked with `eas simulator:get` (must be agent-device, in progress, and the same daemon as the connection you passed), your existing `agent-device` session on the device is reused, and the same model, budgets, hints and destructive-action flags apply. The map and `report/` are written under `--output` and opened in the local Viewer (`--port N`); `--no-open` skips that and `--upload` hosts the report instead. The session is never stopped: the output ends with the `eas simulator:stop --id ...` command for when you are done.
The app is whatever is in the foreground, else the only user-installed app; pass `--bundle-id` when neither is clear (`BUNDLE_ID_REQUIRED` lists what is installed); `--app-name`/`--app-version` label the report. The session is checked with `eas simulator:get` (must be the controller type its connection names, agent-device or argent, in progress, and the same endpoint as the connection you passed; `--controller` must agree with it), your existing `agent-device` session on the device is reused, and the same model, budgets, hints and destructive-action flags apply. The map and `report/` are written under `--output` and opened in the local Viewer (`--port N`); `--no-open` skips that and `--upload` hosts the report instead. The session is never stopped: the output ends with the `eas simulator:stop --id ...` command for when you are done.
## An Expo project and no build: run it from source
+6 -6
View File
@@ -152,18 +152,18 @@ Repeat `expo-explore doctor --json` and fix each `fail` until none remain, colle
## Review a change on this machine
Once `.expo-explore/config.yaml` is committed, the same review CI runs works locally, between any two commits:
The same review CI runs works locally, between any two commits. It reads `.expo-explore/config.yaml` from the head commit, else from the checkout when setup wrote it but it is not committed, else uses the defaults `setup --non-interactive` would write (with several simulator profiles, the one named `explore`), so it works before setup:
```sh
npx @expo/explore capture:review # HEAD against where it left the default branch
npx @expo/explore capture:review --uncommitted # your uncommitted changes to tracked files against HEAD's base
npx @expo/explore capture:review --base v1.3.0 --head v1.4.0 --scope all
npx @expo/explore capture # HEAD and the uncommitted changes, against where HEAD left the default branch
npx @expo/explore capture --committed # HEAD alone
npx @expo/explore capture --base v1.3.0 --head v1.4.0 --scope all
```
- It prints which commits it compares. Each is checked out as a detached worktree in a temporary directory, its dependencies installed (frozen lockfile, no scripts, no Explore credentials in the environment), and removed afterwards; the user's checkout, index and branches are never touched.
- It runs both commits' code as the user (dependency installs, the app config, bundling). Before reviewing a branch the user did not write, say so and ask; credential-free installs are not a sandbox.
- Logins: `EXPO_TOKEN` and the provider's API key when they are set; otherwise the user's `eas login` and their local `claude` or `codex` login for the configured provider. If `eas whoami` fails, tell them to run `eas login`.
- `--uncommitted` includes tracked files only. `--include-untracked` adds untracked, non-ignored files, which are uploaded with the EAS build, so check the listed files first and never include secrets.
- Without `--head`, the head is HEAD plus the working tree's changes, untracked non-ignored files included, which is what `eas build` uploads. It lists them; check that list for secrets the user would not want built. `--committed` reviews HEAD alone, and an `eas.json` with `cli.requireCommit: true` leaves the changes out unless `--uncommitted` is passed.
- Every configured platform is reviewed unless `--platform` picks one. It opens the report in a local Viewer; `--upload` hosts it instead and prints the link, `--no-open` or `--json` only prints the report paths.
- Every run is kept on this machine for 30 days: `npx @expo/explore reports list` (or `--json`) shows them, `reports open <id|latest>` reopens one in the local Viewer, and `reports upload <id>` hosts it without capturing again. Run bare in a terminal, `reports` is an arrow-key picker for the user.
- To host a report after the fact, run `npx @expo/explore report:upload <report.zip>...` with the paths it printed (or the `--output` directory's `<platform>/report.zip`), one per platform. It uses the same project as `--upload` and does not capture again.
@@ -176,7 +176,7 @@ npx @expo/explore capture:review --base v1.3.0 --head v1.4.0 --scope all
- **Releases.** Unless the user asks otherwise, compare each release with the last stable release, with `scope: all` (every screen, so the report shows the whole release with what changed marked) and, when hosted previews are on, `expires-in: never` (the link outlives the 30-day artifact). For every tag as it is pushed, add the `release-review.yml` from the README's "Compare any two commits" section: it finds the newest earlier tag without a `-` (so a release candidate is compared with the last stable release) and calls `explore-compare.yml` with `secrets: inherit` and `permissions: { contents: read, actions: read }`. A nightly compares with yesterday's tag; a release branch with `main`.
- **Once, on demand.** The workflow must be on the default branch to be dispatched: `gh workflow run explore-compare.yml -f base=<ref> -f head=<ref> -f scope=all -f expires-in=never`, or **Run workflow** under Actions → Expo Explore compare.
- **Without CI.** `npx @expo/explore capture:review --base <ref> --head <ref> --scope all --upload` runs the same comparison on this machine (see the previous section).
- **Without CI.** `npx @expo/explore capture --base <ref> --head <ref> --scope all --upload` runs the same comparison on this machine (see the previous section).
- Call the workflow once per workflow run (a second call in the same run reuses the first one's artifact names). A `base` the baseline workflow captured in the last 30 days is reused, so only `head` is captured.
- To verify, run it once on the latest tag and open the run's summary: it lists each platform's result and links the report.
+7 -7
View File
@@ -1,6 +1,6 @@
---
name: readme-refresh
description: Refresh Expo Explore's README.md with euxy (github.com/brentvatne/euxy) as the reference app. Regenerate every screenshot in docs/screenshots from a current euxy review report and PR comment, then re-read the README as a first-time user: the top level only says what Explore does, links the live euxy example, and gives a prompt to copy for trying it on your app and one for setting up CI; everything else lives in collapsibles. Use after a Viewer or PR-comment change that the README shows, a new command or setting, or a release that made a README claim stale. Not for the docs/ guides or the shipped skills.
description: Refresh Expo Explore's README.md with euxy (github.com/brentvatne/euxy) as the reference app. Regenerate every screenshot in docs/screenshots from a current euxy review report and PR comment, then re-read the README as a first-time user: the top level only says what Explore does, links the live euxy example, gives numbered quick-start steps for reviewing a change to your own app, a prompt to copy for exploring any build, and one for setting up CI; everything else lives in collapsibles. Use after a Viewer or PR-comment change that the README shows, a new command or setting, or a release that made a README claim stale. Not for the docs/ guides or the shipped skills.
---
# Refresh the README
@@ -53,18 +53,18 @@ cd - && npm run build:cli && node scripts/readme-reports-rows.mjs > /tmp/reports
- The script renders the picker as the CLI draws it (96 columns, the newest run selected) and writes the terminal body as HTML: each coloured piece is exactly its characters wide, so columns line up, and the wordmark is drawn as cell rectangles, since a design tool's font does not draw `█▀▄` cell for cell.
- In Paper, replace the frame named "Terminal" inside each artboard's window with that HTML, check both artboards in a screenshot (crisp wordmark, aligned columns, the selected row highlighted to the end, coloured counts), and export both at 2x as `readme-reports-light.png` and `readme-reports-dark.png`. The window's title bar reads `npx @expo/explore reports`, as people run it.
Look at every PNG you produced before committing, light and dark: the selected screen should be the one you asked for, the Compare view must show Before and After with outlines, the Screens grid must show the Added/Removed/Modified badges, the PR comment must show the heading links and result glyphs. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
Look at every PNG you produced before committing, light and dark: the selected screen should be the one you asked for, the Compare view must show Before and After with outlines, the Screens grid must show the added, removed and modified status dots, the PR comment must show the heading links and result glyphs. Describe each in its Markdown alt text as what the picture shows, not what the feature is.
## 3. Pass over the content as a first-time user
Read the README top to bottom once without opening a collapsible. At that level it may only answer, in this order:
1. What Explore is (one short paragraph), the hero image, and the link to the live euxy example (`explore-example--euxy.expo.app`, redeployed on every merge to main by `.github/workflows/example-report.yml`).
2. **Try it on your app**: one sentence and a prompt to paste into Claude Code or Codex that gets a simulator build of any app (Expo or not, or just a build) and runs `explore:binary` on it. After its collapsibles, **Review a change before you push it**: one sentence, a prompt that runs `capture:review` locally (the explore-setup skill's "Review a change on this machine" section) on a set-up app, and the `reports` picker image (`readme-reports-*.png`) with one sentence on saved runs, at the top level, not inside a collapsible. Each section keeps its own "Run it yourself"; never put one section between another's prompt and its collapsibles.
3. **Set up CI**: one sentence, then two subsections, each a sentence on what it gives and a prompt to paste: **Review on every PR** (the setup prompt, then a few grouped collapsibles: Hosted previews first, then Manual setup (the setup prompt's steps done by hand, in order: setup, doctor, secrets, baseline, first PR), Capture modes: deterministic or agent, iOS, Android, or both, Keep your setup current) and **Compare any two commits** (a prompt that follows the explore-setup skill's "Compare any two commits" section, the ways to snapshot a release as bullets, then the comparison workflow collapsed).
4. **What you get**: the PR comment, Compare, and Screens, each a heading, one line, and its picture, then a prompt for asking an agent about a report.
1. What Explore is (one short paragraph), the hero image, and the link to the live euxy example (`explore-example--euxy.expo.app`, redeployed on every merge to main by `.github/workflows/example-report.yml`). Under it, one table row of three pictures with a one-line caption each: Compare, Screens, and the PR comment (which says it needs CI), then the agent prompt collapsed as **Ask an agent about a report**. The hero is a zoomed Map framed as a window on a stage (`stagedWindow` in the script); the three below are plain.
2. **Quick start**: the smallest set of steps to see a review of the reader's own Expo app on their machine, numbered and with nothing optional in them: make the app buildable on EAS (login, init, bundle identifier, a simulator profile named `explore`) and commit (the before build is the last commit), then edit a screen near its top and run `capture`, which reviews uncommitted changes as `eas build` would upload them and uses setup's defaults when there is no config. After the steps, a prompt that has Claude Code or Codex do the same through the explore-setup skill's "Review a change on this machine" section. Then the `reports` picker image (`readme-reports-*.png`) with one sentence on saved runs, at the top level, and one collapsible for other commits (`--committed`, `--base`/`--head`) and what a review does on the machine. Run the steps on a fresh `create-expo-app` before changing them.
3. **Map every screen of any app**: one sentence and a prompt to paste into Claude Code or Codex that gets a simulator build of any app (Expo or not, or just a build) and runs `explore:binary` on it. Each section keeps its own "Run it yourself"; never put one section between another's prompt and its collapsibles.
4. **Set up CI**: one sentence, then two subsections, each a sentence on what it gives and a prompt to paste: **Review on every PR** (the setup prompt, then a few grouped collapsibles: Hosted previews first, then Manual setup (the setup prompt's steps done by hand, in order: setup, doctor, secrets, baseline, first PR), Capture modes: deterministic or agent, iOS, Android, or both, Keep your setup current) and **Compare any two commits** (a prompt that follows the explore-setup skill's "Compare any two commits" section, the ways to snapshot a release as bullets, then the comparison workflow collapsed).
Lead with prompts, not explanations: a reader should be able to copy something and see Explore work. Everything else, the manual commands, requirements, options, the manual setup, capture modes, hosted previews, iOS and Android, agent mode, repository settings, how agents read a report, how it works, limitations, contributing, goes into a `<details>` block under the section it belongs to, with a `<summary>` that says what the reader will find. Keep bullets to one or two sentences. Group related collapsibles rather than adding one per topic, so a section shows a handful, not nine. Requirements sit collapsed right under the example report link. Keep the collapsibles' `id` attributes that other docs link to (`#hosted-previews`, `#platforms`, `#compare`, `#agents`), and keep the Inspiration section (screenmap and Revyl's Atlas).
Lead with prompts, not explanations: a reader should be able to copy something and see Explore work. Everything else, the manual commands, requirements, options, the manual setup, capture modes, hosted previews, iOS and Android, agent mode, repository settings, how agents read a report, how it works, limitations, contributing, goes into a `<details>` block under the section it belongs to, with a `<summary>` that says what the reader will find. Keep bullets to one or two sentences. Group related collapsibles rather than adding one per topic, so a section shows a handful, not nine. Requirements sit collapsed right under the example report link. Keep the collapsibles' `id` attributes that other docs link to (`#hosted-previews`, `#platforms`, `#compare`, `#agents`); the Terms and How agents read a report collapsibles live under Additional information, and keep the Inspiration section (screenmap and Revyl's Atlas).
Check that each prompt still works as written:
- the skill links it names (`https://unpkg.com/@expo/explore/skills/...`) are files the package ships (`files` in `package.json`), and they open from the published release;
+7 -2
View File
@@ -233,7 +233,7 @@ async function hashDirectory(root: string, maxBytes: number): Promise<{ sha256:
type TarVisitor = (entry: { name: string; type: string; size: number; mode: number }, contents: () => Promise<Buffer>, skip: () => Promise<void>) => Promise<boolean | void>;
/** Walk a gzip tarball once; `visit` returns true to stop. Long GNU names are honoured; nothing is written. */
async function walkTar(path: string, visit: TarVisitor): Promise<void> {
export async function walkTar(path: string, visit: TarVisitor): Promise<void> {
const stream = createReadStream(path).pipe(createGunzip());
const iterator = stream[Symbol.asyncIterator]();
let buffer = Buffer.alloc(0);
@@ -296,7 +296,7 @@ async function tarEntry(path: string, match: (name: string) => boolean): Promise
return found;
}
function safeRelativePath(name: string): string | undefined {
export function safeRelativePath(name: string): string | undefined {
const parts = name.replace(/^\.\//, "").split("/").filter(part => part.length);
if (!parts.length || parts.some(part => part === "." || part === ".." || part.includes("\\") || part.includes("\0"))) return undefined;
return parts.join("/");
@@ -372,6 +372,11 @@ class FileRangeReader extends Reader<unknown> {
const readers = new WeakMap<object, FileRangeReader>();
/** The ABIs an APK ships native libraries for (`lib/<abi>/`), without reading its manifest. */
export async function apkAbis(path: string): Promise<string[]> {
return [...new Set((await zipEntries(path)).map(entry => /^lib\/([^/]+)\//.exec(entry.filename)?.[1]).filter((abi): abi is string => !!abi))].sort();
}
async function zipEntries(path: string): Promise<ZipEntry[]> {
configure({ useWebWorkers: false });
const reader = new FileRangeReader(path);
+5 -5
View File
@@ -7,7 +7,7 @@ import type { CaptureSetupAction } from "../config/explore-config.js";
import { createExplorationInputs, explorationSecretNames } from "../config/exploration-inputs.js";
import type { ExploreStore, PreparedArtifact } from "../map/store.js";
import { CiError } from "../shared/ci-errors.js";
import type { ActionKind, ActionRisk, Artifact, ElementRole, ExploreMap, ObservedElement, Observation, Screen } from "../types.js";
import type { ActionKind, ActionRisk, Artifact, Controller, ElementRole, ExploreMap, ObservedElement, Observation, Screen } from "../types.js";
/** One look at the device: accessibility always, a PNG when the host could take a safe one. */
export type BlackBoxFrame = {
@@ -278,7 +278,7 @@ function markPressableGroups(nodes: readonly Record<string, unknown>[]): void {
}
}
export function elementsOf(nodes: readonly Record<string, unknown>[], allow: readonly string[]): Array<Omit<ObservedElement, "elementId">> {
export function elementsOf(nodes: readonly Record<string, unknown>[], allow: readonly string[], controller: Controller = "agent-device"): Array<Omit<ObservedElement, "elementId">> {
markPressableGroups(nodes);
const occurrences = new Map<string, number>();
const out: Array<Omit<ObservedElement, "elementId">> = [];
@@ -306,7 +306,7 @@ export function elementsOf(nodes: readonly Record<string, unknown>[], allow: rea
const occurrence = (occurrences.get(key) ?? 0) + 1;
occurrences.set(key, occurrence);
const rect = node.rect && typeof node.rect === "object" ? node.rect as Record<string, unknown> : undefined;
out.push({ role, label, ...(identifier ? { identifier } : {}), occurrence, controller: "agent-device",
out.push({ role, label, ...(identifier ? { identifier } : {}), occurrence, controller,
actions: role === "field" ? ["fill"] : role === "toggle" ? ["press"] : ["press"],
risk: riskOf(label, allow), actionable: true, enabled: node.enabled !== false, visible: true,
...(rect && typeof rect.x === "number" && typeof rect.y === "number" && typeof rect.width === "number" && typeof rect.height === "number"
@@ -497,7 +497,7 @@ export async function runBlackBoxExploration(options: BlackBoxExplorerOptions):
for (const part of loose) seen.parts.add(part);
seen.loadingOnly &&= loading;
evidence.set(screen.id, seen);
for (const element of elementsOf(frame.nodes, allow)) {
for (const element of elementsOf(frame.nodes, allow, map.run.controller)) {
const id = elementId(screen.id, element);
if (!screen.elementIds.includes(id)) {
screen.elementIds.push(id);
@@ -538,7 +538,7 @@ export async function runBlackBoxExploration(options: BlackBoxExplorerOptions):
}
screenshotArtifactId = artifact.id;
}
const elements = elementsOf(frame.nodes, allow).map(element => ({ elementId: elementId(screen.id, element), ...element }));
const elements = elementsOf(frame.nodes, allow, map.run.controller).map(element => ({ elementId: elementId(screen.id, element), ...element }));
const observation: Observation = { id: observationId, screenId: screen.id, variantId: variant.id, capturedAt: frame.capturedAt, surfaceScope: "app",
fingerprints: { combined: screenEvidenceKey(frame.nodes), accessibility: accessibilitySha, ...(screenshotArtifactId ? { visual: map.artifacts.find(item => item.id === screenshotArtifactId)!.sha256 } : {}) },
elementIds: elements.map(element => element.elementId), elements, accessibilityArtifactId: accessibilityArtifact.id, ...(screenshotArtifactId ? { screenshotArtifactId } : {}) };
+54 -21
View File
@@ -6,12 +6,14 @@ import { join } from "node:path";
import { createCiAgentSession, type CiAgentSession, type CiAgentSessionConfig } from "../capture/agent/session.js";
import { createLocalCiAgentSession } from "../capture/agent/session-local.js";
import type { CiAgentProviderName } from "../capture/agent/provider.js";
import { AGENT_DEVICE_VERSION, CONTROLLER_SESSION, baseEnvironment, isRecord } from "../capture/common.js";
import { CONTROLLER_SESSION, baseEnvironment, isRecord } from "../capture/common.js";
import { controllerData, defaultRunner, openedSimulatorDevice } from "../capture/controller.js";
import type { CommandRequest, CommandResult } from "../capture/run.js";
import { executeCaptureSetup } from "../capture/setup-actions.js";
import { SIMULATOR_DOTENV_FILE_NAME, SIMULATOR_DOTENV_HEADER, assertSimulatorSessionIdentity, assertSimulatorStopped, readSimulatorDotenvHandoff,
assertAttachedSimulatorSession, resolveAttachedSimulatorSession, simulatorOsVersion, simulatorStartFailure, type ActiveSimulatorRuntime, type SimulatorConnection } from "../capture/simulator.js";
assertAttachedSimulatorSession, connectionController, controllerVersion, resolveAttachedSimulatorSession, simulatorOsVersion, simulatorStartFailure, type ActiveSimulatorRuntime, type SimulatorConnection } from "../capture/simulator.js";
import { argentControllerInvocation } from "../capture/controller-invocation.js";
import { agentDeviceLauncher, ensureController } from "../shared/controller-cache.js";
import { DEFAULT_ANDROID_DEVICE } from "../config/explore-config.js";
import { createExplorationInputs } from "../config/exploration-inputs.js";
import { ExploreStore, getCoverage } from "../map/store.js";
@@ -46,6 +48,8 @@ export type BinaryExploreOptions = {
owner?: string;
/** EAS project slug the sessions run under; created on first use. */
project?: string;
/** The session's device controller; agent-device unless Argent is chosen. explore:session takes it from the session. */
controller?: "agent-device" | "argent";
environment?: NodeJS.ProcessEnv;
runner?: typeof defaultRunner;
createSession?: (config: CiAgentSessionConfig, options: { env: NodeJS.ProcessEnv; auth: ModelAuth }) => CiAgentSession;
@@ -64,10 +68,19 @@ export type BinaryExploreResult = {
durationMs: number;
};
/** The command and environment that reach a session's controller: agent-device's CLI with its daemon, or the Argent bridge. */
type ControllerInvocation = { command: string; environment: NodeJS.ProcessEnv };
async function argentInvocation(connection: SimulatorConnection, work: string, platform: Platform, environment: NodeJS.ProcessEnv, bundleId?: string): Promise<ControllerInvocation> {
return argentControllerInvocation({ directory: work, connection, platform, environment: baseEnvironment(environment), sourceEnvironment: environment, ...(bundleId ? { bundleId } : {}) });
}
/** The daemon refuses a second session on a busy device; the caller's own `agent-device` session (from install/open) is reused instead. */
function daemonSessions(runner: typeof defaultRunner, connection: SimulatorConnection, work: string, platform: Platform, environment: NodeJS.ProcessEnv): { name: string; device: string }[] {
// Argent has no named sessions to share; its tool-server serves every caller.
if (connectionController(connection) === "argent") return [];
try {
const result = runner({ command: packageBin("agent-device", "agent-device"), args: ["session", "list", "--json"], cwd: work, timeoutMs: 60_000,
const result = runner({ command: agentDeviceLauncher(environment), args: ["session", "list", "--json"], cwd: work, timeoutMs: 60_000,
environment: { ...baseEnvironment(environment), AGENT_DEVICE_DAEMON_BASE_URL: connection.daemonBaseUrl, AGENT_DEVICE_DAEMON_AUTH_TOKEN: connection.daemonAuthToken } });
const data = controllerData(result.stdout, "session list");
const sessions = Array.isArray(data.sessions) ? data.sessions : [];
@@ -119,11 +132,11 @@ const named = (apps: { bundleId: string | undefined; name: string | undefined }[
};
/** Finds the app to explore when the caller named none: the one the session has in the foreground, else the only user-installed app. */
export function resolveSessionApp(runner: typeof defaultRunner, connection: SimulatorConnection, work: string, platform: Platform, device: string, controllerSession: string | undefined, environment: NodeJS.ProcessEnv): { bundleId: string; name?: string } {
export function resolveSessionApp(runner: typeof defaultRunner, connection: SimulatorConnection, work: string, platform: Platform, device: string, controllerSession: string | undefined, environment: NodeJS.ProcessEnv, invocation?: ControllerInvocation): { bundleId: string; name?: string } {
const run = (args: string[]): Record<string, unknown> | undefined => {
try {
const result = runner({ command: packageBin("agent-device", "agent-device"), args: [...args, ...(platform === "ios" ? ["--device", device] : []), "--platform", platform, "--json"], cwd: work, timeoutMs: 60_000,
environment: { ...baseEnvironment(environment), AGENT_DEVICE_DAEMON_BASE_URL: connection.daemonBaseUrl, AGENT_DEVICE_DAEMON_AUTH_TOKEN: connection.daemonAuthToken } });
const result = runner({ command: invocation?.command ?? agentDeviceLauncher(environment), args: [...args, ...(platform === "ios" ? ["--device", device] : []), "--platform", platform, "--json"], cwd: work, timeoutMs: 60_000,
environment: invocation?.environment ?? { ...baseEnvironment(environment), AGENT_DEVICE_DAEMON_BASE_URL: connection.daemonBaseUrl, AGENT_DEVICE_DAEMON_AUTH_TOKEN: connection.daemonAuthToken } });
return controllerData(result.stdout, args[0]!);
} catch { return undefined; }
};
@@ -260,11 +273,20 @@ export type ConnectedSessionExploration = {
export async function exploreConnectedSession(ctx: ConnectedSessionExploration): Promise<{ runtime: ActiveSimulatorRuntime; exploration: BlackBoxExplorerResult }> {
const { connection, platform, device, bundleId, app, install, work, runner, environment, secrets, inputs, say, now, limits, store, map, model, sessionJson, launchUrl, hints, allowDestructive } = ctx;
const controllerSession = ctx.controllerSession ?? CONTROLLER_SESSION;
const controllerConfig = join(work, "agent-device.json");
await writeFile(controllerConfig, "{}\n", { flag: "wx", mode: 0o400 });
const controllerEnvironment = { ...baseEnvironment(environment), AGENT_DEVICE_CONFIG: controllerConfig, AGENT_DEVICE_DAEMON_BASE_URL: connection.daemonBaseUrl,
AGENT_DEVICE_DAEMON_AUTH_TOKEN: connection.daemonAuthToken, AGENT_DEVICE_SESSION: controllerSession, AGENT_DEVICE_SESSION_LOCK: "reject", AGENT_DEVICE_PLATFORM: platform };
const agentDevice = packageBin("agent-device", "agent-device");
const controllerKind = connectionController(connection);
const controllerName = controllerKind === "argent" ? "Argent" : "agent-device";
if (controllerKind === "argent") await ensureController("argent", { environment, progress: say });
let agentDevice: string;
let controllerEnvironment: NodeJS.ProcessEnv;
if (controllerKind === "argent") {
({ command: agentDevice, environment: controllerEnvironment } = await argentInvocation(connection, work, platform, environment, bundleId));
} else {
const controllerConfig = join(work, "agent-device.json");
await writeFile(controllerConfig, "{}\n", { flag: "wx", mode: 0o400 });
controllerEnvironment = { ...baseEnvironment(environment), AGENT_DEVICE_CONFIG: controllerConfig, AGENT_DEVICE_DAEMON_BASE_URL: connection.daemonBaseUrl,
AGENT_DEVICE_DAEMON_AUTH_TOKEN: connection.daemonAuthToken, AGENT_DEVICE_SESSION: controllerSession, AGENT_DEVICE_SESSION_LOCK: "reject", AGENT_DEVICE_PLATFORM: platform };
agentDevice = agentDeviceLauncher(environment);
}
const deviceArgs = platform === "ios" ? ["--device", device] : [];
const controller = (args: string[], timeoutMs = 90_000): CommandResult => {
// Session flags go before a `--` separator so model-chosen text (`type -h`, a URL, a label) is never read as a flag.
@@ -275,22 +297,23 @@ export async function exploreConnectedSession(ctx: ConnectedSessionExploration):
};
const failureText = (error: unknown): string => lastLine(redactSecrets(error instanceof Error ? error.message : String(error), secrets)).slice(0, 400);
const version = runner({ command: agentDevice, args: ["--version"], cwd: work, environment: controllerEnvironment, timeoutMs: 30_000 }).stdout.trim();
if (version !== AGENT_DEVICE_VERSION) throw binaryError("EXPLORE_TOOLS_MISSING", `agent-device ${AGENT_DEVICE_VERSION} is required (found ${version || "none"}).`, "Reinstall @expo/explore.");
if (version !== controllerVersion(controllerKind)) throw binaryError("EXPLORE_TOOLS_MISSING", `${controllerName} ${controllerVersion(controllerKind)} is required (found ${version || "none"}).`, "Reinstall @expo/explore.");
if (install) {
say(`installing ${install.kind === "android-apk" ? "the APK" : "the app"} on session ${connection.sessionId}`);
try { controller(["install", install.path, "--json"], 15 * 60_000); }
catch (error) { throw binaryError("APP_INSTALL_FAILED", `agent-device could not install the app: ${failureText(error)}`, "Check that the archive is a simulator build for this platform and under the size limit, then rerun.", { sessionId: connection.sessionId }); }
catch (error) { throw binaryError("APP_INSTALL_FAILED", `${controllerName} could not install the app: ${failureText(error)}`, "Check that the archive is a simulator build for this platform and under the size limit, then rerun.", { sessionId: connection.sessionId }); }
}
const opened = controller(["open", bundleId, "--level", "full", "--json"], 2 * 60_000);
const openedDevice = openedSimulatorDevice(opened.stdout, bundleId, "initial app open", platform, controllerSession);
const data = controllerData(opened.stdout, "initial app open");
const deviceData = data.device && typeof data.device === "object" ? data.device as Record<string, unknown> : {};
const observed = (key: string): string => { const value = deviceData[key] ?? data[key]; return typeof value === "string" && value.trim() ? value : "unknown"; };
const runtime = { provider: "eas-simulator", controller: "agent-device", controllerPackageVersion: AGENT_DEVICE_VERSION, easCliVersion: "unknown", platform, controllerDeviceId: openedDevice.deviceId,
const runtime = { provider: "eas-simulator", controller: controllerKind, controllerPackageVersion: controllerVersion(controllerKind), easCliVersion: "unknown", platform, controllerDeviceId: openedDevice.deviceId,
deviceModel: openedDevice.deviceModel, osVersion: observed("osVersion"), locale: observed("locale"), orientation: observed("orientation") === "landscape" ? "landscape" : "portrait",
colorScheme: observed("colorScheme") === "dark" ? "dark" : "light" } as ActiveSimulatorRuntime;
try { runtime.osVersion = await simulatorOsVersion(sessionJson(), runtime.controllerDeviceId, fetch, platform); } catch { /* descriptive only */ }
// Argent's `open` reports the OS version itself (list-devices); agent-device's comes from the session's preview.
if (runtime.osVersion === "unknown" || controllerKind !== "argent") try { runtime.osVersion = await simulatorOsVersion(sessionJson(), runtime.controllerDeviceId, fetch, platform); } catch { /* descriptive only */ }
map.run.deviceId = runtime.controllerDeviceId;
map.run.environment = { deviceModel: runtime.deviceModel, osVersion: runtime.osVersion, locale: runtime.locale, orientation: runtime.orientation, colorScheme: runtime.colorScheme };
map.run.status = "exploring";
@@ -474,7 +497,13 @@ export async function runSessionExploration(options: SessionExploreOptions): Pro
try { connection = await resolveAttachedSimulatorSession(environment, options.envFile, options.session); }
catch (error) {
throw binaryError("SESSION_NOT_PROVIDED", `No EAS Simulator session connection was found: ${error instanceof Error ? error.message : String(error)}`,
"Start one with `eas simulator:start --type agent-device --out-config-type dotenv` and run explore:session in that directory (or pass --env-file / set EAS_SIMULATOR_SESSION_ID, AGENT_DEVICE_DAEMON_BASE_URL and AGENT_DEVICE_DAEMON_AUTH_TOKEN).");
"Start one with `eas simulator:start --type agent-device --out-config-type dotenv` (or `--type argent`) and run explore:session in that directory (or pass --env-file / set EAS_SIMULATOR_SESSION_ID with AGENT_DEVICE_DAEMON_BASE_URL and AGENT_DEVICE_DAEMON_AUTH_TOKEN, or ARGENT_TOOLS_URL).");
}
const sessionController = connectionController(connection);
if (!options.runner) await ensureController(sessionController, { environment, progress: say });
if (options.controller && options.controller !== sessionController) {
throw binaryError("CONTROLLER_MISMATCH", `--controller ${options.controller} was passed, but the session is driven by ${sessionController}.`,
`Drop --controller, or start a session with \`eas simulator:start --type ${options.controller}\`.`, { sessionId: connection.sessionId });
}
if (!environment.EXPO_TOKEN?.trim() && !environment.EXPO_SESSION_SECRET?.trim() && !(await easLoggedIn(runner, environment))) {
throw binaryError("EXPO_LOGIN_REQUIRED", "No EAS login was found.", "Run `eas login` or set EXPO_TOKEN, then rerun explore:session.");
@@ -495,7 +524,7 @@ export async function runSessionExploration(options: SessionExploreOptions): Pro
let device = options.device ?? "";
const app = { name: options.appName ?? options.bundleId ?? "app", bundleId: options.bundleId ?? "app", ...(options.version ? { version: options.version } : {}) };
const secrets = [environment.EXPO_TOKEN ?? "", connection.daemonAuthToken, ...inputs.values].filter(Boolean);
const map: ExploreMap = { contract: CONTRACT, revision: 0, run: { id: randomUUID(), name: app.name, platform, controller: "agent-device", exploration: "black-box", bundleId: app.bundleId, status: "draft",
const map: ExploreMap = { contract: CONTRACT, revision: 0, run: { id: randomUUID(), name: app.name, platform, controller: sessionController, exploration: "black-box", bundleId: app.bundleId, status: "draft",
createdAt: new Date(now()).toISOString(), updatedAt: new Date(now()).toISOString(), build: { ...(app.version ? { version: app.version } : {}), source: "unknown" }, environment: {}, limits },
artifacts: [], screens: [], variants: [], observations: [], elements: [], actionAttempts: [], transitions: [], journeys: [], frontier: [], gaps: [] };
try {
@@ -504,7 +533,7 @@ export async function runSessionExploration(options: SessionExploreOptions): Pro
try { info = assertAttachedSimulatorSession(sessionJson(), connection, options.platform); }
catch (error) {
throw binaryError("SESSION_UNAVAILABLE", `EAS Simulator session ${connection.sessionId} cannot be explored: ${lastLine(redactSecrets(error instanceof Error ? error.message : String(error), secrets))}`,
"Check `eas simulator:list`; the session must be in progress, of type agent-device, and match the connection you passed.", { sessionId: connection.sessionId });
`Check \`eas simulator:list\`; the session must be in progress, of type ${sessionController}, and match the connection you passed.`, { sessionId: connection.sessionId });
}
platform = info.platform;
const candidates = daemonSessions(runner, connection, work, platform, environment).filter(item => !device || item.device === device);
@@ -514,7 +543,8 @@ export async function runSessionExploration(options: SessionExploreOptions): Pro
if (existing) say(`reusing agent-device session "${existing.name}" on ${existing.device}`);
device = device || existing?.device || (platform === "ios" ? DEFAULT_IOS_DEVICE : DEFAULT_ANDROID_DEVICE);
if (!options.bundleId) {
const resolved = resolveSessionApp(runner, connection, work, platform, device, existing?.name, environment);
const resolved = resolveSessionApp(runner, connection, work, platform, device, existing?.name, environment,
sessionController === "argent" ? await argentInvocation(connection, work, platform, environment) : undefined);
app.bundleId = resolved.bundleId;
if (!options.appName) app.name = resolved.name ?? app.bundleId;
map.run.bundleId = app.bundleId;
@@ -582,7 +612,10 @@ export async function runBinaryExploration(options: BinaryExploreOptions): Promi
let exploration: BlackBoxExplorerResult | undefined;
let owner = options.owner ?? "";
const project = options.project ?? DEFAULT_BINARY_PROJECT;
const map: ExploreMap = { contract: CONTRACT, revision: 0, run: { id: randomUUID(), name: archive.appName, platform, controller: "agent-device", exploration: "black-box", bundleId, status: "draft",
const controller = options.controller ?? "agent-device";
// Fetched before the paid session starts, so a blocked download costs nothing.
if (!options.runner) await ensureController(controller, { environment, progress: say });
const map: ExploreMap = { contract: CONTRACT, revision: 0, run: { id: randomUUID(), name: archive.appName, platform, controller, exploration: "black-box", bundleId, status: "draft",
createdAt: new Date(now()).toISOString(), updatedAt: new Date(now()).toISOString(),
build: { ...(archive.version ? { version: archive.version } : {}), ...(archive.buildNumber ? { number: archive.buildNumber } : {}), hash: archive.sha256, source: "local" },
environment: { deviceModel: device }, limits }, artifacts: [], screens: [], variants: [], observations: [], elements: [], actionAttempts: [], transitions: [], journeys: [], frontier: [], gaps: [] };
@@ -610,7 +643,7 @@ export async function runBinaryExploration(options: BinaryExploreOptions): Promi
await writeFile(dotenvPath, SIMULATOR_DOTENV_HEADER, { flag: "wx", mode: 0o600 });
let startError: unknown;
try {
const started = eas(["simulator:start", "--name", sessionName, "--platform", platform, "--device", device, "--type", "agent-device", "--package-version", AGENT_DEVICE_VERSION,
const started = eas(["simulator:start", "--name", sessionName, "--platform", platform, "--device", device, "--type", controller, "--package-version", controllerVersion(controller), "--public-link",
"--max-duration-minutes", String(limits.maxDurationMinutes + 5), "--out-config-type", "dotenv", "--non-interactive"], 20 * 60_000);
if (started.status !== 0) throw new Error(started.stderr || started.stdout || "eas simulator:start failed");
} catch (error) { startError = error; }
+15
View File
@@ -18,6 +18,19 @@ export function resolveColorSchemes(appearance: AppearanceSetting, appConfig: Re
return ["light"];
}
/**
* What an Argent capture renders: one pass, since Argent cannot switch the device's appearance yet
* (software-mansion/argent#1509). An app that forces a style renders it on any device; any other app renders as the
* fresh simulator starts, light. Requested schemes that pass cannot show are reported as skipped.
*/
export function argentColorSchemes(requested: readonly ColorScheme[], appConfig: Record<string, unknown> | undefined, platform: string): { schemes: ColorScheme[]; skipped: ColorScheme[] } {
const platformConfig = appConfig?.[platform];
const declared = (platformConfig && typeof platformConfig === "object" ? (platformConfig as Record<string, unknown>).userInterfaceStyle : undefined)
?? appConfig?.userInterfaceStyle;
const scheme: ColorScheme = declared === "dark" ? "dark" : "light";
return { schemes: [scheme], skipped: requested.filter(item => item !== scheme) };
}
export function parseAppearance(value: unknown, path: string): AppearanceSetting {
if (value === undefined || value === "auto") return "auto";
const list = Array.isArray(value) ? value : [value];
@@ -69,6 +82,8 @@ export function mergeSchemeOutcomes(passes: readonly Record<string, CaptureOutco
// frame too: the review then shows that appearance and marks the primary one unavailable, instead of nothing.
if (verified(outcome)) {
if (scheme && !(primary && primary.status === "captured")) merged[schemeScreenId(id, scheme)] = outcome;
// Its note (setup that did not complete in that appearance) stays with the route the frame is published under.
else if (outcome.reason && merged[id]) merged[id] = { ...merged[id], reason: [merged[id].reason, scheme ? `In ${scheme}: ${outcome.reason}` : outcome.reason].filter(Boolean).join(" ") };
continue;
}
if (scheme && primary && primary.status === "captured") merged[schemeScreenId(id, scheme)] = outcome;
+157
View File
@@ -0,0 +1,157 @@
/**
* The Argent controller's command line: Explore runs it where it would run agent-device, with the same
* arguments. Each command becomes `argent run <tool> --args <json>` calls, as EAS Simulator recommends
* driving an `argent` session, with the session's ARGENT_TOOLS_URL and ARGENT_AUTH_TOKEN in the environment.
*/
import { spawnSync } from "node:child_process";
import { appendFile, copyFile, mkdir, readFile, realpath, rename, rm, stat, writeFile } from "node:fs/promises";
import { dirname, join } from "node:path";
import { createRequire } from "node:module";
import type { DecodedFrame } from "../shared/png-evidence.js";
import { ArgentCallError, runBridgeCommand, type ArgentBridgeState, type ArgentPlatform, type ArgentTree } from "./argent-driver.js";
import { ARGENT_VERSION } from "../shared/argent-version.js";
import { ensureController } from "../shared/controller-cache.js";
const ARGENT_CALL_TIMEOUT_MS = 180_000;
async function readState(path: string): Promise<ArgentBridgeState> {
try { return JSON.parse(await readFile(path, "utf8")) as ArgentBridgeState; }
catch { return { generation: 0 }; }
}
/** Written whole and renamed into place, so a command stopped mid-write never leaves a torn state. */
async function writeState(path: string, state: ArgentBridgeState): Promise<void> {
const temporary = `${path}.${process.pid}.tmp`;
await writeFile(temporary, JSON.stringify(state), { mode: 0o600 });
await rename(temporary, path);
}
/** A call's arguments for the debug log: text that could be typed into a field is logged by length only. */
function loggedArgs(args: Record<string, unknown>): Record<string, unknown> {
return Object.fromEntries(Object.entries(args).map(([key, value]) => key === "text" && typeof value === "string" ? [key, `<${value.length} characters>`]
: key === "steps" && Array.isArray(value) ? [key, `<${value.length} steps>`] : [key, value]));
}
/** What a call answered, for the debug log: a tree's shape, not its contents. */
function summarize(tool: string, value: unknown): unknown {
if (!value || typeof value !== "object") return value;
if (tool !== "ui-tree") return Object.keys(value);
const tree = value as ArgentTree;
let nodes = 0;
const walk = (node: { children?: unknown[] }) => { nodes++; (node.children ?? []).forEach(child => walk(child as { children?: unknown[] })); };
(tree.roots ?? []).forEach(walk);
return { foregroundApp: tree.foregroundApp, alertVisible: tree.alertVisible, keyboardVisible: tree.keyboardVisible, truncated: tree.truncated,
screen: tree.screen, nodes, roots: (tree.roots ?? []).map(root => [root.type ?? null, root.bundleId ?? null, (root.children ?? []).length]) };
}
async function main(): Promise<number> {
const environment = process.env;
const statePath = environment.EXPLORE_ARGENT_STATE;
const platform = environment.EXPLORE_ARGENT_PLATFORM as ArgentPlatform | undefined;
const toolsUrl = environment.ARGENT_TOOLS_URL;
if (!statePath || (platform !== "ios" && platform !== "android")) {
process.stdout.write(JSON.stringify({ success: false, error: { code: "INVALID_ARGS", message: "The Argent controller needs EXPLORE_ARGENT_STATE and EXPLORE_ARGENT_PLATFORM." } }));
return 1;
}
const argv = process.argv.slice(2);
if (argv[0] !== "--version" && !toolsUrl) {
// Without a URL the Argent client would start a local tool-server; Explore only drives the session's own.
process.stdout.write(JSON.stringify({ success: false, error: { code: "INVALID_ARGS", message: "ARGENT_TOOLS_URL is not set for the Argent controller." } }));
return 1;
}
// EXPLORE_ARGENT_LOG_DIR (opt-in): every Argent call this bridge makes, how long it took, and the shape of what it read.
const logPath = environment.EXPLORE_ARGENT_LOG_DIR
? join(environment.EXPLORE_ARGENT_LOG_DIR, `argent-${platform}-${environment.EXPLORE_ARGENT_LOG_NAME ?? "bridge"}.jsonl`) : undefined;
const log = async (entry: Record<string, unknown>) => {
if (!logPath) return;
await appendFile(logPath, `${JSON.stringify({ at: new Date().toISOString(), command: argv[0], ...entry })}\n`, { mode: 0o600 }).catch(() => undefined);
};
const state = await readState(statePath);
let cli: string;
try { cli = argv[0] === "--version" ? "" : await ensureController("argent", { environment, progress: message => process.stderr.write(`[explore] ${message}\n`) }); }
catch (error) {
const failure = error as { code?: string; message?: string };
process.stdout.write(JSON.stringify({ success: false, error: { code: failure.code ?? "CONTROLLER_DOWNLOAD_FAILED", message: failure.message ?? String(error) } }));
return 1;
}
const callArgent = async (tool: string, args: Record<string, unknown>, options?: { out?: string }): Promise<unknown> => {
const run = spawnSync(process.execPath, [cli, "run", tool, "--args", JSON.stringify(args), ...(options?.out ? ["--out", options.out] : [])],
{ env: environment, encoding: "utf8", maxBuffer: 64 * 1024 * 1024, timeout: ARGENT_CALL_TIMEOUT_MS });
if (run.error) throw new ArgentCallError(`argent run ${tool}: ${run.error.message}`, true);
if (run.status !== 0) {
const detail = `${run.stderr ?? ""}\n${run.stdout ?? ""}`.trim().split("\n").filter(Boolean).slice(-4).join(" | ").slice(0, 800);
throw new ArgentCallError(`argent run ${tool} failed: ${detail}`, true);
}
// With --out the client saves the tool's file and prints where ("Wrote: <path>"), not the tool's JSON.
if (options?.out) {
const written = await stat(options.out).catch(() => undefined);
if (!written?.isFile() || written.size === 0) throw new ArgentCallError(`argent run ${tool} did not write ${options.out}`, true);
return { path: options.out };
}
try { return JSON.parse(run.stdout); }
catch { throw new ArgentCallError(`argent run ${tool} did not answer with JSON`, true); }
};
const result = await runBridgeCommand(argv, {
state, platform, version: ARGENT_VERSION,
...(environment.EXPLORE_ARGENT_BUNDLE_ID ? { bundleId: environment.EXPLORE_ARGENT_BUNDLE_ID } : {}),
...(environment.EXPLORE_ARGENT_DEVICE ? { device: environment.EXPLORE_ARGENT_DEVICE } : {}),
// An opened foldable's inner panel shows its UI in landscape (Argent's fold: "Unfolded, the UI is landscape").
...(platform === "ios" && ["open", "half-open"].includes(environment.EXPLORE_ARGENT_POSE ?? "") ? { landscape: true } : {}),
call: async (tool, args, options) => {
const started = Date.now();
try {
const value = await callArgent(tool, args, options);
await log({ tool, args: loggedArgs(args), ms: Date.now() - started, summary: summarize(tool, value) });
return value;
} catch (error) {
await log({ tool, args: loggedArgs(args), ms: Date.now() - started, error: (error instanceof Error ? error.message : String(error)).slice(0, 400) });
throw error;
}
},
reachable: async () => {
let ok = false;
try {
const token = environment.ARGENT_AUTH_TOKEN;
// The same URL Argent's own client checks: ARGENT_TOOLS_URL may carry a path, which /tools is appended to.
const response = await fetch(`${(toolsUrl ?? "").replace(/\/+$/, "")}/tools`, { headers: token ? { authorization: `Bearer ${token}` } : {}, signal: AbortSignal.timeout(5_000) });
await response.body?.cancel();
ok = response.status < 500;
} catch { ok = false; }
if (!ok) await log({ tool: "reachable", ok });
return ok;
},
sleep: milliseconds => new Promise(resolve => setTimeout(resolve, milliseconds)),
orientVideo: async path => {
// Turned with ffmpeg, which observing a launch needs anyway; without it the recording is left as it is.
const probed = spawnSync("ffprobe", ["-v", "error", "-select_streams", "v:0", "-show_entries", "stream=width,height", "-of", "csv=p=0:s=x", path], { encoding: "utf8", timeout: 30_000 });
const [width, height] = (probed.stdout ?? "").trim().split("x").map(Number);
if (probed.status !== 0 || !width || !height || width >= height) return;
const turned = `${path}.upright.mp4`;
const ffmpeg = spawnSync("ffmpeg", ["-nostdin", "-y", "-loglevel", "error", "-i", path, "-vf", "transpose=clock", "-an", turned], { encoding: "utf8", timeout: 120_000 });
if (ffmpeg.status === 0) await rename(turned, path);
else await rm(turned, { force: true });
},
scratchImage: { path: join(dirname(statePath), "argent-scratch.png"), read: async path => {
const { PNG } = createRequire(import.meta.url)("pngjs") as { PNG: { sync: { read(bytes: Buffer, options: { checkCRC: boolean }): DecodedFrame } } };
return PNG.sync.read(await readFile(path), { checkCRC: false });
} },
moveFile: async (from, to) => {
// Argent's client downloads a recording under its HOME or the working directory; nothing else is moved.
const source = await realpath(from);
const roots = await Promise.all([environment.HOME, process.cwd()].filter((root): root is string => !!root).map(root => realpath(root).catch(() => root)));
if (!roots.some(root => source.startsWith(`${root}/`))) throw new Error(`Argent returned a recording outside its own directories: ${from}`);
await mkdir(dirname(to), { recursive: true });
try { await rename(from, to); }
catch { await copyFile(from, to); await rm(from, { force: true }); }
},
});
await writeState(statePath, state);
await log({ result: result.exitCode === 0 ? "ok" : result.stdout.slice(0, 300) });
process.stdout.write(result.stdout);
return result.exitCode;
}
process.exitCode = await main();
+736
View File
@@ -0,0 +1,736 @@
/**
* Translates the agent-device commands Explore sends into Argent tool calls, and Argent's answers into
* agent-device's JSON envelopes, so capture, setup, the agent tool host and black-box exploration drive
* either controller without knowing which one runs. Pure: the Argent call, the clock and file moves are
* injected, so the translation is tested against recorded Argent output.
*/
import { CONTROLLER_SESSION } from "./common.js";
import type { DecodedFrame } from "../shared/png-evidence.js";
export type ArgentPlatform = "ios" | "android";
/** One `argent run <tool>` call. `sent: false` means the request provably never reached the tool-server. */
export class ArgentCallError extends Error {
constructor(message: string, readonly sent: boolean) { super(message); }
}
export type ArgentCall = (tool: string, args: Record<string, unknown>, options?: { out?: string }) => Promise<unknown>;
type Rect = { x: number; y: number; width: number; height: number };
/** What the bridge keeps between commands, in the per-run state file. */
export type ArgentBridgeState = {
udid?: string;
model?: string;
osVersion?: string;
/** The coordinate space of the last tree: points on iOS, pixels on Android, as agent-device reports them. */
screen?: { width: number; height: number };
generation: number;
refs?: Record<string, { rect: Rect; type?: string; value?: string; secure?: boolean }>;
/** iOS asks "Open in “<app>”?" for the first custom-scheme link of a session; later links open directly. */
deepLinkPromptAccepted?: boolean;
recording?: string;
};
export type ArgentBridgeContext = {
call: ArgentCall;
state: ArgentBridgeState;
platform: ArgentPlatform;
/** The app under test when the caller names it outside the command (explore:binary's `install`). */
bundleId?: string;
/** The device to drive (UDID or adb serial) when the tool-server sees several: a local one serves this machine's. */
device?: string;
version: string;
sleep: (milliseconds: number) => Promise<void>;
/** Moves a file the Argent client downloaded (a screen recording) to where Explore asked for it. */
moveFile: (from: string, to: string) => Promise<void>;
/** Whether the tool-server answers, checked before a UI action is sent (see `remoteUnavailable`). */
reachable: () => Promise<boolean>;
/** A file the bridge may overwrite with a screenshot, and a reader for it (the link-prompt fallback). */
scratchImage?: { path: string; read: (path: string) => Promise<DecodedFrame> };
/**
* The UI is landscape on a panel whose native axes are portrait, as on an opened iPhone Duo. Argent reads such a panel
* on its portrait axes (screen, tree and taps all agree), so only what a person sees is turned: screenshots are
* captured upright, and recordings, which Argent cannot turn, go to orientVideo.
*/
landscape?: boolean;
/** Turns a portrait screen recording a quarter clockwise, to the landscape UI it shows. */
orientVideo?: (path: string) => Promise<void>;
};
export type BridgeResult = { exitCode: number; stdout: string };
const success = (data: Record<string, unknown>): BridgeResult => ({ exitCode: 0, stdout: JSON.stringify({ success: true, data }) });
const failure = (code: string, message: string, details?: Record<string, unknown>): BridgeResult =>
({ exitCode: 1, stdout: JSON.stringify({ success: false, error: { code, message, ...(details ? { details } : {}) } }) });
/**
* agent-device's answer when its pre-flight health check fails, which Explore resends because the command was
* provably never sent (controller.ts remoteDaemonUnavailable). The bridge gives it only on the same proof.
*/
const remoteUnavailable = () => failure("COMMAND_FAILED", "Remote daemon is unavailable");
/** Flags agent-device takes after a command; the bridge needs the platform only from its own context. */
const VALUE_FLAGS = new Set(["--session", "--device", "--platform", "--level", "--udid", "--scope", "--bundle-id", "--serial", "--timeout"]);
const BOOLEAN_FLAGS = new Set(["--json", "--relaunch", "--normalize-status-bar", "--force-full", "--in-app", "--system"]);
export function parseCommand(argv: readonly string[]): { positional: string[]; flags: Record<string, string | true> } {
const positional: string[] = [];
const flags: Record<string, string | true> = {};
for (let index = 0; index < argv.length; index++) {
const value = argv[index]!;
if (value === "--") { positional.push(...argv.slice(index + 1)); break; }
if (VALUE_FLAGS.has(value)) { flags[value.slice(2)] = argv[index + 1] ?? ""; index++; continue; }
if (BOOLEAN_FLAGS.has(value)) { flags[value.slice(2)] = true; continue; }
positional.push(value);
}
return { positional, flags };
}
type ArgentNode = { role?: string; type?: string; label?: string; identifier?: string; value?: string; contentDescription?: string; disabled?: boolean;
frame?: Rect; traits?: string[]; hidden?: boolean; selected?: boolean; password?: boolean; bundleId?: string; children?: ArgentNode[] };
export type ArgentTree = { schemaVersion?: number; source?: string; screen?: { width: number; height: number }; roots?: ArgentNode[];
truncated?: boolean; alertVisible?: boolean; keyboardVisible?: boolean; foregroundApp?: string };
const record = (value: unknown): Record<string, unknown> => (value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : {});
const finite = (value: unknown): value is number => typeof value === "number" && Number.isFinite(value);
/** Android widget classes as agent-device names their element types. */
function agentDeviceType(node: ArgentNode, platform: ArgentPlatform): string {
const type = node.type ?? node.role ?? "Other";
if (node.password) return "SecureTextField";
if (platform === "ios") return type;
const simple = type.split(".").pop() ?? type;
if (/EditText|TextInput/.test(simple)) return "TextField";
if (/Button$|ImageButton|CheckBox|Switch|RadioButton/.test(simple)) return simple.endsWith("Button") ? "Button" : simple;
if (/TextView/.test(simple)) return "StaticText";
if (/ImageView/.test(simple)) return "Image";
if (/ScrollView|RecyclerView|ListView/.test(simple)) return "ScrollView";
return simple || "Other";
}
/**
* The tree as agent-device's snapshot: the app's root (an `Application` node sized to the screen) and every
* element on or near the screen, in the units agent-device uses (points on iOS, pixels on Android), with
* refs pinned to this snapshot's generation. Elements Argent lists twice (iOS AX does) appear once.
*/
export function snapshotFromTree(tree: ArgentTree, platform: ArgentPlatform, generation: number, bundleId?: string) {
const screen = tree.screen;
if (!screen || !finite(screen.width) || !finite(screen.height) || screen.width <= 0 || screen.height <= 0) {
throw new Error("ui-tree did not report the screen size");
}
const app = bundleId ?? tree.foregroundApp;
// Android's status bar and navigation (com.android.systemui) are not part of the app; a dialog another package draws
// over it (a runtime permission prompt) is, because it covers the app and setup has to answer it.
const roots = (tree.roots ?? []).filter(root => platform === "ios" || root.bundleId !== ANDROID_SYSTEM_UI);
const nodes: Record<string, unknown>[] = [];
const refs: NonNullable<ArgentBridgeState["refs"]> = {};
const seen = new Set<string>();
const toPoints = (frame: Rect): Rect => ({ x: frame.x * screen.width, y: frame.y * screen.height, width: frame.width * screen.width, height: frame.height * screen.height });
/**
* iOS visibility, as Argent computes it (a node is hidden when its frame misses every ancestor's frame), except that a
* root clips to the whole screen. On iPhone Duo's inner display Argent 0.29 reports the app root as the top-left third
* of the screen ([0, 0, 0.333, 0.333], its 3x scale applied twice), which hid everything outside that third: a sheet's
* title and its Cancel button among them. Android's `hidden` is the system's own visible-to-user flag and is kept.
*/
const clipOf = (node: ArgentNode, clip: Rect | undefined, root: boolean): Rect | undefined => {
if (root || !node.frame || ![node.frame.x, node.frame.y, node.frame.width, node.frame.height].every(finite)) return clip;
return clip && intersect(node.frame, clip);
};
const visit = (node: ArgentNode, depth: number, parentIndex: number | undefined, appRoot: boolean, clip: Rect | undefined, root: boolean) => {
const frame = node.frame;
const inner = clipOf(node, clip, root);
const rect = frame && [frame.x, frame.y, frame.width, frame.height].every(finite) ? toPoints(frame) : undefined;
const onScreen = !!rect && rect.x < screen.width && rect.y < screen.height && rect.x + rect.width > 0 && rect.y + rect.height > 0;
const type = appRoot ? "Application" : agentDeviceType(node, platform);
const label = node.label ?? node.contentDescription;
const key = JSON.stringify([type, label, node.identifier, node.value, rect && [Math.round(rect.x), Math.round(rect.y), Math.round(rect.width), Math.round(rect.height)]]);
let index = parentIndex;
// Off-screen content stays out, as agent-device leaves it out; its parents still come through for depth.
if (rect && (onScreen || appRoot) && !seen.has(key)) {
seen.add(key);
index = nodes.length;
const ref = `e${index + 1}`;
const traits = node.traits ?? [];
// iOS marks a disabled element with the notEnabled trait, Android with disabled.
const enabled = !traits.includes("notEnabled") && node.disabled !== true;
const visible = platform === "ios" ? !!inner : node.hidden !== true;
nodes.push({ depth, index, ...(parentIndex === undefined ? {} : { parentIndex }), type, ref,
rect: appRoot ? { x: 0, y: 0, width: screen.width, height: screen.height } : rect,
...(label ? { label } : {}), ...(node.identifier ? { identifier: node.identifier } : {}),
...(node.value !== undefined ? { value: node.value } : {}), enabled, hittable: enabled && visible && !appRoot,
...(visible ? {} : { visible: false }), ...(node.selected || traits.includes("selected") ? { selected: true } : {}) });
refs[ref] = { rect: appRoot ? { x: 0, y: 0, width: screen.width, height: screen.height } : rect, type,
...(node.value !== undefined ? { value: node.value } : {}), ...(type === "SecureTextField" ? { secure: true } : {}) };
}
for (const child of node.children ?? []) visit(child, depth + 1, index, false, inner, false);
};
for (const root of roots) {
const isAppRoot = platform === "ios" ? root.type === "Application" || nodes.length === 0 : root.bundleId === app;
visit(root, 0, undefined, isAppRoot, { x: 0, y: 0, width: 1, height: 1 }, true);
}
return { nodes, refs, screen: { width: screen.width, height: screen.height } };
}
function intersect(a: Rect, b: Rect): Rect | undefined {
const x = Math.max(a.x, b.x), y = Math.max(a.y, b.y);
const right = Math.min(a.x + a.width, b.x + b.width), bottom = Math.min(a.y + a.height, b.y + b.height);
return right > x && bottom > y ? { x, y, width: right - x, height: bottom - y } : undefined;
}
const centre = (rect: Rect, screen: { width: number; height: number }) =>
({ x: (rect.x + rect.width / 2) / screen.width, y: (rect.y + rect.height / 2) / screen.height });
/**
* Argent read nothing: exactly one bare root and no foreground app, which is what iOS 27.1 gives while the link prompt
* is up. A read that returned no roots at all is a failed read, not this state.
*/
function blindTree(tree: ArgentTree): boolean {
const roots = tree.roots ?? [];
return !tree.foregroundApp && roots.length === 1 && (roots[0]!.children ?? []).length === 0 && !roots[0]!.label && !roots[0]!.type;
}
/** A tree with the app's root and something in it: what a relaunch must reach before the app is usable. */
function appReady(tree: ArgentTree, bundleId: string): boolean {
if (tree.foregroundApp !== bundleId) return false;
const count = (node: ArgentNode): number => 1 + (node.children ?? []).reduce((sum, child) => sum + count(child), 0);
return (tree.roots ?? []).some(root => count(root) > 1);
}
function flatten(tree: ArgentTree): ArgentNode[] {
const nodes: ArgentNode[] = [];
const walk = (node: ArgentNode) => { nodes.push(node); (node.children ?? []).forEach(walk); };
(tree.roots ?? []).forEach(walk);
return nodes;
}
/** iOS: `com.apple.CoreSimulator.SimRuntime.iOS-26-5` → `26.5`. */
export function iosRuntimeVersion(runtime: unknown): string | undefined {
const match = typeof runtime === "string" ? /iOS-(\d+)-(\d+)(?:-(\d+))?$/.exec(runtime) : null;
return match ? [match[1], match[2], match[3]].filter(Boolean).join(".") : undefined;
}
const DEEP_LINK_PROMPT_CONFIRM = { dxPoints: 74, dyPoints: 37 };
const KEYBOARD_DISMISS_LABELS = ["Hide keyboard", "Dismiss keyboard", "Done"];
// A keyboard covers the lower part of the screen; its keys start below this share of the height.
const KEYBOARD_TOP = 0.4;
const ALERT_PREFERRED_BUTTONS = ["Open", "OK", "Allow", "Allow While Using App", "Continue"];
const READ_TOOLS = new Set(["ui-tree", "list-devices", "screenshot", "foreground-app", "await-screen-idle", "describe"]);
const SPRINGBOARD = "com.apple.springboard";
const ANDROID_SYSTEM_UI = "com.android.systemui";
const OPEN_IN_APP_PROMPT = /^Open in “.+”\?$/;
/**
* iOS's "Open in “<app>”?" link prompt, recognized by its own text. Argent 0.29 does not always flag it as an alert
* (on iOS 27.1, iPhone Duo, `alertVisible` stays false while SpringBoard shows it), and another alert must never be
* taken for it: the bridge presses this prompt's Open on its own.
*/
export function openInAppPromptShowing(tree: ArgentTree): boolean {
return flatten(tree).some(node => OPEN_IN_APP_PROMPT.test(node.label ?? ""));
}
/** Any system alert in front of the app: one Argent flags, or the link prompt it does not. */
function alertShowing(tree: ArgentTree): boolean {
return tree.alertVisible === true || (tree.foregroundApp === SPRINGBOARD && openInAppPromptShowing(tree));
}
/**
* The link prompt's Open button found in a screenshot: the largest wide, filled system-blue shape in the middle of the
* screen, as iOS 26 and 27 draw it. Used only when Argent cannot read the screen at all while the prompt is up.
*/
export function findOpenButton(frame: DecodedFrame): { x: number; y: number } | undefined {
const step = Math.max(1, Math.round(frame.width / 200));
const columns = Math.floor(frame.width / step), rows = Math.floor(frame.height / step);
const top = Math.floor(rows * 0.2), bottom = Math.ceil(rows * 0.8);
const blue = new Uint8Array(columns * rows);
for (let row = top; row < bottom; row++) for (let column = 0; column < columns; column++) {
const offset = (row * step * frame.width + column * step) * 4;
const [red, green, blueValue] = [frame.data[offset]!, frame.data[offset + 1]!, frame.data[offset + 2]!];
if (red < 70 && green > 90 && green < 170 && blueValue > 200) blue[row * columns + column] = 1;
}
let best: { cells: number; left: number; right: number; top: number; bottom: number } | undefined;
const seen = new Uint8Array(columns * rows);
for (let start = 0; start < blue.length; start++) {
if (!blue[start] || seen[start]) continue;
const shape = { cells: 0, left: columns, right: 0, top: rows, bottom: 0 };
const queue = [start];
seen[start] = 1;
while (queue.length) {
const cell = queue.pop()!;
const row = Math.floor(cell / columns), column = cell % columns;
shape.cells++;
shape.left = Math.min(shape.left, column); shape.right = Math.max(shape.right, column);
shape.top = Math.min(shape.top, row); shape.bottom = Math.max(shape.bottom, row);
for (const next of [cell - 1, cell + 1, cell - columns, cell + columns]) {
if (next < 0 || next >= blue.length || seen[next] || !blue[next]) continue;
if (Math.abs((next % columns) - column) > 1) continue;
seen[next] = 1;
queue.push(next);
}
}
const width = shape.right - shape.left + 1, height = shape.bottom - shape.top + 1;
// A dialog button: wide, a few percent of the screen tall, and well under its full width.
if (width < columns * 0.15 || width > columns * 0.6 || width < height * 1.5 || height < rows * 0.03 || height > rows * 0.12) continue;
if (!best || shape.cells > best.cells) best = shape;
}
if (!best) return undefined;
return { x: ((best.left + best.right + 1) / 2) / columns, y: ((best.top + best.bottom + 1) / 2) / rows };
}
/**
* The prompt's Open button from `describe`. On iOS 27.1 (iPhone Duo) `ui-tree` reports SpringBoard's frames with
* x and y swapped, while `describe` reads them correctly, so the button is located there.
*/
export function describedButton(description: unknown, label: string): Rect | undefined {
if (typeof description !== "string") return undefined;
const escaped = label.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
// Only a whole line Argent printed counts, so an app label that spells out a button line cannot be picked.
const match = new RegExp(`^\\s*AXButton "${escaped}"\\s+\\(([\\d.]+), ([\\d.]+), ([\\d.]+), ([\\d.]+)\\)\\s*$`, "m").exec(description);
if (!match) return undefined;
const [x, y, width, height] = match.slice(1).map(Number) as [number, number, number, number];
return [x, y, width, height].every(finite) && width > 0 && height > 0 ? { x, y, width, height } : undefined;
}
/** Runs one agent-device command against Argent and answers as agent-device would. */
export async function runBridgeCommand(argv: readonly string[], context: ArgentBridgeContext): Promise<BridgeResult> {
const { state, platform } = context;
if (argv[0] === "--version") return { exitCode: 0, stdout: `${context.version}\n` };
const [command, ...rest] = argv;
const { positional, flags } = parseCommand(rest);
const bundleFlag = typeof flags["bundle-id"] === "string" ? flags["bundle-id"] : context.bundleId;
/** Reads are resent after a transport failure (they change nothing); a UI action is sent once, after a health check. */
const call = async (tool: string, args: Record<string, unknown> = {}, options?: { out?: string }): Promise<Record<string, unknown>> => {
const withDevice = tool === "list-devices" ? args : { udid: state.udid, ...args };
for (let attempt = 0; ; attempt++) {
try { return record(await context.call(tool, withDevice, options)); }
catch (error) {
if (READ_TOOLS.has(tool) && attempt < 2) { await context.sleep(1_000 * (attempt + 1)); continue; }
throw error;
}
}
};
const tree = async (): Promise<ArgentTree> => (await call("ui-tree")) as ArgentTree;
const ensureDevice = async () => {
if (state.udid) return;
let devices: Record<string, unknown>[] = [];
// A tool-server that has just started can list no devices at all for its first call; that is not an answer.
for (let attempt = 0; attempt < 3; attempt++) {
const listed = await call("list-devices");
const all = Array.isArray(listed.devices) ? listed.devices : [];
devices = all.map(record).filter(device => device.platform === platform
&& (platform === "ios" ? device.state === "Booted" && device.runtimeKind !== "tv" : device.state === "device" && device.runtimeKind !== "tv")
&& (!context.device || (platform === "ios" ? device.udid : device.serial) === context.device));
if (all.length) break;
await context.sleep(2_000);
}
if (devices.length !== 1) throw new BridgeFailure("DEVICE_UNAVAILABLE", context.device
? `Argent does not list ${context.device} among the booted ${platform} devices.`
: `Argent lists ${devices.length} booted ${platform} devices on this session; Explore drives exactly one.`);
const device = devices[0]!;
const udid = platform === "ios" ? device.udid : device.serial;
if (typeof udid !== "string" || !udid) throw new BridgeFailure("DEVICE_UNAVAILABLE", "Argent did not name the booted device.");
state.udid = udid;
state.model = String(platform === "ios" ? device.name : device.model ?? device.avdName ?? udid);
const version = platform === "ios" ? iosRuntimeVersion(device.runtime) : undefined;
if (version) state.osVersion = version;
};
/** Relaunches until the app's tree is readable: an EAS simulator Argent did not boot needs a relaunch first. */
const relaunch = async (bundleId: string) => {
for (let restart = 0; restart < 2; restart++) {
await call("restart-app", { bundleId });
for (let poll = 0; poll < 12; poll++) {
await context.sleep(1_000);
if (appReady(await tree(), bundleId)) return;
}
}
throw new BridgeFailure("APP_NOT_READY", `${bundleId} did not come up with a readable accessibility tree after relaunching.`);
};
const deviceEnvelope = (bundleId: string) => ({ session: CONTROLLER_SESSION, appBundleId: bundleId, platform, target: "mobile",
device: { platform, target: "mobile", name: state.model, id: state.udid, ...(state.osVersion ? { osVersion: state.osVersion } : {}) },
identifiers: { session: CONTROLLER_SESSION, appBundleId: bundleId, deviceName: state.model, deviceId: state.udid } });
const screen = async () => {
if (!state.screen) { const current = await tree(); if (current.screen) state.screen = { ...current.screen }; }
if (!state.screen) throw new BridgeFailure("COMMAND_FAILED", "The screen size is not known yet.");
return state.screen;
};
const tap = async (x: number, y: number) => { await call("gesture-tap", { x, y }); };
const resolveRef = (value: string) => {
const match = /^@?(e\d+)(?:~s(\d+))?$/.exec(value);
if (!match) throw new BridgeFailure("INVALID_ARGS", `Not an element reference: ${value}`);
if (match[2] && Number(match[2]) !== state.generation) throw new BridgeFailure("COMMAND_FAILED", `Element reference ${value} is stale; take a new snapshot.`);
const target = state.refs?.[match[1]!];
if (!target) throw new BridgeFailure("COMMAND_FAILED", `Element reference ${value} is not in the last snapshot.`);
return target;
};
/**
* A UI action is only sent when the tool-server answers first, so a failure after this point is never resent. A
* session's tool-server can still be starting when EAS reports the session ready, so it is given about 25 s to answer.
*/
const beforeAction = async () => {
for (const delay of [1_000, 2_000, 3_000, 4_000, 5_000, 5_000, 5_000]) {
if (await context.reachable()) return;
await context.sleep(delay);
}
if (!await context.reachable()) throw new UnsentFailure();
};
try {
switch (command) {
case "open": {
await ensureDevice();
const target = positional.length === 2 ? { bundleId: positional[0]!, url: positional[1]! }
: positional.length === 1 && /^[A-Za-z][A-Za-z0-9+.-]*:/.test(positional[0]!) ? { url: positional[0]! } : { bundleId: positional[0] };
if (target.url) {
await beforeAction();
await call("open-url", { url: target.url });
if (platform === "ios" && !state.deepLinkPromptAccepted) await acceptDeepLinkPrompt(target.bundleId ?? bundleFlag);
return success({ ...(target.bundleId ? deviceEnvelope(target.bundleId) : { session: CONTROLLER_SESSION }), url: target.url });
}
const bundleId = target.bundleId ?? bundleFlag;
if (!bundleId) throw new BridgeFailure("INVALID_ARGS", "open needs a bundle identifier or a URL.");
// agent-device's plain open brings a running app forward and keeps its state; only --relaunch restarts it.
if (flags.relaunch !== true && appReady(await tree(), bundleId)) return success({ ...deviceEnvelope(bundleId), appName: bundleId });
await beforeAction();
await relaunch(bundleId);
return success({ ...deviceEnvelope(bundleId), appName: bundleId });
}
case "snapshot": {
await ensureDevice();
const current = await tree();
state.generation += 1;
const converted = snapshotFromTree(current, platform, state.generation, bundleFlag);
state.refs = converted.refs;
state.screen = converted.screen;
const dialog = platform === "android" ? readAlert(current) : undefined;
if (dialog && !converted.nodes.some(node => node.type === "Alert")) {
// An Android dialog from another package covers the app: report it as agent-device does, as an Alert.
converted.nodes.push({ depth: 1, index: converted.nodes.length, parentIndex: 0, type: "Alert", ref: `e${converted.nodes.length + 1}`,
rect: { x: 0, y: 0, width: converted.screen.width, height: converted.screen.height }, label: dialog.message || "System dialog", enabled: true, hittable: false });
} else if (platform === "ios" && alertShowing(current) && !converted.nodes.some(node => node.type === "Alert")
&& !(bundleFlag && appReady(current, bundleFlag))) {
// A system alert (SpringBoard's) hides the app's tree; report it the way agent-device does, as an Alert node.
converted.nodes.push({ depth: 1, index: converted.nodes.length, parentIndex: 0, type: "Alert", ref: `e${converted.nodes.length + 1}`,
rect: { x: 0, y: 0, width: converted.screen.width, height: converted.screen.height }, label: "System alert", enabled: true, hittable: false });
}
return success({ nodes: converted.nodes, truncated: current.truncated === true, refsGeneration: state.generation,
...(current.foregroundApp ? { appBundleId: current.foregroundApp, appName: current.foregroundApp } : {}),
snapshotQuality: { state: "healthy", backend: "argent" } });
}
case "appstate": {
await ensureDevice();
const current = await tree();
const foreground = current.foregroundApp;
return success({ ...(foreground ? { appBundleId: foreground, ...(platform === "android" ? { package: foreground } : {}) } : {}),
session: CONTROLLER_SESSION, state: foreground ? "runningForeground" : "unknown", surface: foreground ? "app" : "home",
device: { id: state.udid, name: state.model } });
}
case "alert": {
await ensureDevice();
const current = await tree();
const alert = readAlert(current);
if (positional[0] === "get") {
if (!alert) return platform === "android" ? success({ platform: "android", alert: null }) : failure("COMMAND_FAILED", "alert not found");
return platform === "android" ? success({ platform: "android", alert: { title: alert.message, buttons: alert.items } })
: success({ message: alert.message, items: alert.items });
}
if (positional[0] === "accept" || positional[0] === "dismiss") {
if (!alert) return failure("COMMAND_FAILED", "alert not found");
const preferred = positional[0] === "dismiss"
? alert.buttons.find(button => /^(Cancel|Not Now|Don.t Allow|Dismiss)$/.test(button.label)) ?? alert.buttons[0]
: ALERT_PREFERRED_BUTTONS.map(label => alert.buttons.find(button => button.label === label)).find(Boolean) ?? alert.buttons.at(-1);
if (!preferred) return failure("COMMAND_FAILED", "The alert has no button to press.");
await beforeAction();
const size = current.screen ?? await screen();
// describe places SpringBoard's buttons correctly where ui-tree may not (iOS 27.1); the tree is the fallback.
const described = describedButton(await call("describe").then(value => value.description, () => undefined), preferred.label);
await tap(...Object.values(described ? centre(described, { width: 1, height: 1 }) : centre(preferred.rect, size)) as [number, number]);
await context.sleep(800);
if (readAlert(await tree())) return failure("COMMAND_FAILED", "The alert is still showing after its button was pressed.");
return success({ action: positional[0], button: preferred.label });
}
return failure("INVALID_ARGS", `Unsupported alert command: ${positional[0] ?? ""}`);
}
case "press": {
await ensureDevice();
const size = await screen();
let point: { x: number; y: number };
if (positional[0]?.startsWith("@") || /^e\d+/.test(positional[0] ?? "")) point = centre(resolveRef(positional[0]!).rect, size);
else {
const x = Number(positional[0]), y = Number(positional[1]);
if (!finite(x) || !finite(y)) throw new BridgeFailure("INVALID_ARGS", "press needs an element reference or x and y.");
point = { x: x / size.width, y: y / size.height };
}
await beforeAction();
await tap(point.x, point.y);
return success({ action: "press", x: point.x, y: point.y });
}
case "fill": {
await ensureDevice();
const target = resolveRef(positional[0] ?? "");
const text = positional.slice(1).join(" ");
rejectSecretPlaceholder(text);
const size = await screen();
await beforeAction();
await tap(...Object.values(centre(target.rect, size)) as [number, number]);
await context.sleep(400);
if (platform === "android") {
const filled = await call("fill", { text });
if (filled.verified !== true) return failure("COMMAND_FAILED", "Argent could not verify the field's new text.");
return success({ action: "fill" });
}
// Argent's iOS `fill` cannot see React Native's focused field, so the old text is erased and the new one typed.
const erase = target.secure ? 64 : (target.value ?? "").length;
if (erase > 0) {
const erased = await call("run-sequence", { steps: Array.from({ length: erase }, () => ({ tool: "keyboard", args: { udid: state.udid, key: "backspace" } })) });
// run-sequence answers normally when it stops partway; typing over half-erased text would leave a wrong value.
if (erased.completed !== erased.total) return failure("COMMAND_FAILED", `Erasing the field stopped after ${String(erased.completed)} of ${String(erased.total)} keys; nothing was typed.`);
}
if (text) await call("keyboard", { text });
if (!target.secure) {
const after = flatten(await tree()).find(node => node.frame && Math.abs(node.frame.x * size.width - target.rect.x) < 2
&& Math.abs(node.frame.y * size.height - target.rect.y) < 2 && /TextField|EditText/.test(node.type ?? ""));
if (after && (after.value ?? "") !== text) return failure("COMMAND_FAILED", "The field does not hold the requested text after typing it.");
}
return success({ action: "fill" });
}
case "type": {
await ensureDevice();
const text = positional.join(" ");
rejectSecretPlaceholder(text);
await beforeAction();
await call("keyboard", { text });
return success({ action: "type" });
}
case "keyboard": {
if (positional[0] !== "dismiss") return failure("INVALID_ARGS", `Unsupported keyboard command: ${positional[0] ?? ""}`);
await ensureDevice();
const current = await tree();
if (!current.keyboardVisible) return success({ platform, action: "dismiss", wasVisible: false, dismissed: false, visible: false });
await beforeAction();
if (platform === "android") await call("button", { button: "back" });
else {
// agent-device taps the keyboard's own dismiss control, and fails with this message when there is none, which
// callers answer with the return key. Only a key in the keyboard's area counts: an app's "Done" above it is not one.
const key = flatten(current).find(node => KEYBOARD_DISMISS_LABELS.includes(node.label ?? "") && node.frame && node.frame.y >= KEYBOARD_TOP);
if (!key) return failure("COMMAND_FAILED", "Unable to dismiss the iOS keyboard: the keyboard exposes no dismiss control.");
const size = current.screen ?? await screen();
await tap(...Object.values(centre({ x: key.frame!.x * size.width, y: key.frame!.y * size.height,
width: key.frame!.width * size.width, height: key.frame!.height * size.height }, size)) as [number, number]);
}
await context.sleep(500);
const visible = (await tree()).keyboardVisible === true;
if (visible && platform === "ios") return failure("COMMAND_FAILED", "Unable to dismiss the iOS keyboard: it is still showing after its dismiss key was pressed.");
return success({ platform, action: "dismiss", wasVisible: true, dismissed: !visible, visible });
}
case "scroll": {
await ensureDevice();
const direction = positional[0] ?? "down";
const vertical = direction === "down" || direction === "up";
const [from, to] = direction === "down" || direction === "right" ? [0.7, 0.3] : [0.3, 0.7];
await beforeAction();
await call("gesture-swipe", vertical ? { fromX: 0.5, fromY: from, toX: 0.5, toY: to, momentum: false } : { fromX: from, fromY: 0.5, toX: to, toY: 0.5, momentum: false });
return success({ action: "scroll", direction });
}
case "swipe": {
await ensureDevice();
const [x1, y1, x2, y2] = positional.slice(0, 4).map(Number);
if (![x1, y1, x2, y2].every(finite)) throw new BridgeFailure("INVALID_ARGS", "swipe needs x1 y1 x2 y2.");
const size = await screen();
await beforeAction();
await call("gesture-swipe", { fromX: x1! / size.width, fromY: y1! / size.height, toX: x2! / size.width, toY: y2! / size.height, momentum: false });
return success({ action: "swipe" });
}
case "back": {
await ensureDevice();
await beforeAction();
if (flags.system === true) {
// agent-device's system back: the hardware button on Android, the edge swipe on iOS.
if (platform === "android") await call("button", { button: "back" });
else await call("gesture-swipe", { fromX: 0.05, fromY: 0.5, toX: 0.8, toY: 0.5, momentum: false });
return success({ action: "back", mode: "system" });
}
const current = await tree();
const nodes = flatten(current);
const button = platform === "android"
? nodes.find(node => /^(Navigate up|Back)$/i.test(node.contentDescription ?? node.label ?? "") && node.frame)
: (() => {
const bar = nodes.find(node => node.type === "NavigationBar" && node.frame);
return bar && (bar.children ?? []).flatMap(function all(node: ArgentNode): ArgentNode[] { return [node, ...(node.children ?? []).flatMap(all)]; })
.find(node => node.type === "Button" && node.frame && node.frame.x < 1 / 3);
})();
if (button?.frame) {
await tap(button.frame.x + button.frame.width / 2, button.frame.y + button.frame.height / 2);
return success({ action: "back", mode: "in-app" });
}
if (flags["in-app"] === true || platform === "ios") return failure("COMMAND_FAILED", "in-app back control is not available");
await call("button", { button: "back" });
return success({ action: "back", mode: "system" });
}
case "wait": {
if (positional[0] === "stable") {
await ensureDevice();
const minStableMs = Number(positional[1] ?? 500), timeoutMs = Number(positional[2] ?? 8000);
const idle = await call("await-screen-idle", { minStableMs: finite(minStableMs) ? minStableMs : 500, timeoutMs: finite(timeoutMs) ? timeoutMs : 8000 });
return success({ stable: idle.settled === true });
}
const milliseconds = Number(positional[0]);
if (!finite(milliseconds) || milliseconds < 0) throw new BridgeFailure("INVALID_ARGS", "wait needs a number of milliseconds or `stable`.");
await context.sleep(milliseconds);
return success({ waitedMs: milliseconds });
}
case "screenshot": {
await ensureDevice();
const path = positional[0];
if (!path) throw new BridgeFailure("INVALID_ARGS", "screenshot needs a path.");
// Upright on a portrait panel showing a landscape UI; on the opened iPhone Duo that is LandscapeRight (seen on iOS 27.1).
await call("screenshot", { scale: 1, ...(context.landscape ? { rotation: "LandscapeRight" } : {}) }, { out: path });
return success({ path });
}
case "record": {
await ensureDevice();
if (positional[0] === "start") {
if (!positional[1]) throw new BridgeFailure("INVALID_ARGS", "record start needs a path.");
await call("screen-recording-start", { timeLimitSeconds: 300, trimStatic: false, showTouches: false });
state.recording = positional[1];
return success({ recording: true, outPath: positional[1] });
}
if (positional[0] === "stop") {
const stopped = await call("screen-recording-stop");
const target = state.recording;
delete state.recording;
if (typeof stopped.video !== "string") return failure("COMMAND_FAILED", "Argent did not return the recording.");
if (target) await context.moveFile(stopped.video, target);
if (target && context.landscape && context.orientVideo) await context.orientVideo(target);
return success({ outPath: target ?? stopped.video, ...(finite(stopped.durationMs) ? { durationMs: stopped.durationMs } : {}) });
}
return failure("INVALID_ARGS", `Unsupported record command: ${positional[0] ?? ""}`);
}
case "install": {
await ensureDevice();
const path = positional[0];
if (!path || !bundleFlag) throw new BridgeFailure("INVALID_ARGS", "install needs an archive path and the app's bundle identifier.");
await beforeAction();
await call("reinstall-app", { bundleId: bundleFlag, appPath: path });
return success({ installed: true, appBundleId: bundleFlag });
}
case "fold": {
await ensureDevice();
const posture = positional[0];
if (posture !== "closed" && posture !== "half-open" && posture !== "open") throw new BridgeFailure("INVALID_ARGS", "fold needs closed, half-open or open.");
await beforeAction();
const folded = await call("fold", { posture });
// The other panel lights at another size: every stored coordinate and element reference is stale.
delete state.screen;
delete state.refs;
state.generation += 1;
// Argent's accessibility reader can keep reading the panel that went dark (seen on iPhone Duo when it had read
// the outer panel before the fold): its tree keeps the old panel's shape and comes back bare. Nothing is read
// before the fold, and the tree must take the shape of the panel the fold lit before the bridge answers.
const lit = record(folded.screen);
if (finite(lit.width) && finite(lit.height) && lit.height > 0) {
const litRatio = lit.width / lit.height;
let followed = false;
for (let poll = 0; poll < 10 && !followed; poll++) {
const shape = (await tree()).screen;
followed = !!shape && shape.height > 0 && Math.abs(shape.width / shape.height - litRatio) < 0.004;
if (!followed) await context.sleep(1_000);
}
if (!followed) throw new BridgeFailure("CONTROLLER_FOLD_UNVERIFIED", `Argent kept reading the other panel after folding the device ${posture}.`);
}
return success({ action: "fold", pose: posture, ...(folded.panel !== undefined ? { panel: folded.panel } : {}) });
}
case "apps": return success({ apps: [] });
case "session": return success({ sessions: [] });
// TODO(argent#1509): map `settings appearance <scheme>` to Argent's `set-appearance` once a release with it is pinned.
case "settings": return failure("CONTROLLER_UNSUPPORTED", "Argent cannot change the device's appearance yet.");
case "logs": return failure("CONTROLLER_UNSUPPORTED", "Argent does not provide device logs to Explore.");
default: return failure("INVALID_ARGS", `Unsupported command for the Argent controller: ${command ?? ""}`);
}
} catch (error) {
if (error instanceof UnsentFailure) return remoteUnavailable();
if (error instanceof BridgeFailure) return failure(error.code, error.message);
if (error instanceof ArgentCallError) {
// Never "Remote daemon is unavailable" here: the request may have run, so Explore must not resend it.
return failure(error.sent ? "ARGENT_TOOL_FAILED" : "COMMAND_FAILED", error.sent ? error.message : "Remote daemon is unavailable");
}
return failure("ARGENT_BRIDGE_FAILED", error instanceof Error ? error.message : String(error));
}
/** Accepts iOS's "Open in “<app>”?" once per session; later links in the same session open without it. */
async function acceptDeepLinkPrompt(bundleId: string | undefined) {
for (let poll = 0; poll < 6; poll++) {
await context.sleep(700);
const current = await tree();
// Argent can read nothing while iOS 27.1 shows the prompt; find Open in a screenshot instead.
if (blindTree(current) && poll >= 1 && context.scratchImage) {
if (await pressOpenFromScreenshot(context.scratchImage)) { state.deepLinkPromptAccepted = true; return; }
continue;
}
if (!openInAppPromptShowing(current)) {
if (bundleId && appReady(current, bundleId)) { state.deepLinkPromptAccepted = true; return; }
// Another alert is the app's or the system's own business; capture answers it, the bridge does not.
if (current.alertVisible) return;
continue;
}
const size = current.screen;
if (!size) break;
const open = describedButton(await call("describe").then(described => described.description, () => undefined), "Open");
// Without a described button, the prompt's Open button sits at a fixed offset from the centre on iPhone 17.
await tap(...(open ? Object.values(centre(open, { width: 1, height: 1 })) as [number, number]
: [0.5 + DEEP_LINK_PROMPT_CONFIRM.dxPoints / size.width, 0.5 + DEEP_LINK_PROMPT_CONFIRM.dyPoints / size.height] as [number, number]));
if (await promptCleared()) { state.deepLinkPromptAccepted = true; return; }
throw new BridgeFailure("CONTROLLER_DEEP_LINK_PROMPT", "iOS kept asking to open the link in the app after Open was pressed.");
}
}
/**
* After Open is pressed, the prompt can stay in the tree for a second or two while the app comes forward (observed on
* iPhone Duo's inner display), so the bridge reads again for a few seconds before it calls the press a failure.
*/
async function promptCleared(): Promise<boolean> {
for (let poll = 0; poll < 6; poll++) {
await context.sleep(1_000);
if (!openInAppPromptShowing(await tree())) return true;
}
return false;
}
/** Taps the Open button found in a screenshot, then confirms it is gone. */
async function pressOpenFromScreenshot(scratch: NonNullable<ArgentBridgeContext["scratchImage"]>): Promise<boolean> {
await call("screenshot", { scale: 1 }, { out: scratch.path });
const open = findOpenButton(await scratch.read(scratch.path));
if (!open) return false;
await tap(open.x, open.y);
await context.sleep(1_000);
const after = await tree();
if (!blindTree(after)) return !openInAppPromptShowing(after);
await call("screenshot", { scale: 1 }, { out: scratch.path });
return !findOpenButton(await scratch.read(scratch.path));
}
function readAlert(current: ArgentTree) {
const androidDialog = platform === "android"
? (current.roots ?? []).find(root => root.bundleId && root.bundleId !== ANDROID_SYSTEM_UI && root.bundleId !== (bundleFlag ?? current.foregroundApp))
: undefined;
if (!androidDialog && !alertShowing(current)) return undefined;
const size = current.screen ?? state.screen ?? { width: 1, height: 1 };
const nodes = flatten(current);
const container = nodes.find(node => node.type === "Alert")
?? nodes.find(node => (node.children ?? []).length > 0 && OPEN_IN_APP_PROMPT.test(node.label ?? "")) ?? androidDialog;
if (!container) return undefined;
const inside = flatten({ roots: [container] });
const buttons = inside.filter(node => /Button/.test(node.type ?? node.role ?? "") && node.label && node.frame)
.map(node => ({ label: node.label!, rect: { x: node.frame!.x * size.width, y: node.frame!.y * size.height, width: node.frame!.width * size.width, height: node.frame!.height * size.height } }));
const text = inside.filter(node => /StaticText|TextView/.test(node.type ?? node.role ?? "") && node.label).map(node => node.label!);
return buttons.length ? { message: text.join(" ") || container.label || "", items: buttons.map(button => button.label), buttons } : undefined;
}
}
class BridgeFailure extends Error { constructor(readonly code: string, message: string) { super(message); } }
class UnsentFailure extends Error {}
/** Argent's `fill` and `keyboard` would expand `{{secret:NAME}}` from Argent's own secret store; Explore resolves its own. */
function rejectSecretPlaceholder(text: string) {
if (/\{\{\s*secret\s*:/i.test(text)) throw new BridgeFailure("INVALID_ARGS", "Text for the device must not contain a {{secret:…}} placeholder.");
}
+3 -1
View File
@@ -1,6 +1,6 @@
import { CiError } from "../shared/ci-errors.js";
export const EAS_CLI_VERSION = "24.4.2";
export const EAS_CLI_VERSION = "25.0.0";
export { AGENT_DEVICE_VERSION } from "../shared/agent-device-version.js";
export const CONTROLLER_SESSION = "expo-explore-runtime";
@@ -42,6 +42,8 @@ export function baseEnvironment(environment: NodeJS.ProcessEnv): NodeJS.ProcessE
"ANDROID_SDK_ROOT",
"ANDROID_HOME",
"JAVA_HOME",
// A local simulator runs with this Xcode instead of xcode-select's, e.g. one that adds iPhone Duo.
"DEVELOPER_DIR",
]) {
if (environment[name] !== undefined) result[name] = environment[name];
}
+49
View File
@@ -0,0 +1,49 @@
import { mkdir, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { fileURLToPath } from "node:url";
import type { SimulatorConnection } from "./simulator.js";
import { controllerCacheRoot } from "../shared/controller-cache.js";
/** The Argent bridge's entry, run where agent-device's CLI would be. */
export const ARGENT_CONTROLLER_WORKER = fileURLToPath(new URL("./argent-controller-worker.js", import.meta.url));
const shellQuote = (value: string) => `'${value.replace(/'/g, `'\\''`)}'`;
/**
* The command and environment that drive an Argent session the way agent-device's are run: a small executable in
* the run's private directory runs the bridge with this Node, so every caller keeps passing one command and its
* arguments. The bridge gets only the session's tool-server variables, telemetry off, and a HOME of its own, so
* Argent's state (links, downloaded recordings) is never shared between runs or sides of a review.
*/
export async function argentControllerInvocation(options: {
directory: string; connection: SimulatorConnection; platform: "ios" | "android"; environment: NodeJS.ProcessEnv; bundleId?: string;
/** The device to drive (UDID or adb serial) when the tool-server sees several, as a local one does. */
device?: string;
/** A foldable's pose (device.pose): opened, its UI is landscape on a portrait panel, which the bridge turns upright. */
pose?: string;
/** The caller's full environment, which names the controller cache and npm registry the narrowed one drops. */
sourceEnvironment?: NodeJS.ProcessEnv;
}): Promise<{ command: string; environment: NodeJS.ProcessEnv }> {
const source = options.sourceEnvironment ?? options.environment;
const home = join(options.directory, "argent-home");
await mkdir(home, { recursive: true, mode: 0o700 });
const command = join(options.directory, "argent-controller");
await writeFile(command, `#!/bin/sh\nexec ${shellQuote(process.execPath)} ${shellQuote(ARGENT_CONTROLLER_WORKER)} "$@"\n`, { mode: 0o700 });
// agent-device's variables never reach Argent's bridge, and Argent's never reach agent-device.
const environment = Object.fromEntries(Object.entries(options.environment).filter(([name]) => !/^(AGENT_DEVICE_|ARGENT_)/.test(name)));
return {
command,
environment: { ...environment, HOME: home, DO_NOT_TRACK: "1",
ARGENT_TOOLS_URL: options.connection.daemonBaseUrl,
...(options.connection.daemonAuthToken ? { ARGENT_AUTH_TOKEN: options.connection.daemonAuthToken } : {}),
EXPLORE_ARGENT_STATE: join(options.directory, "argent-state.json"), EXPLORE_ARGENT_PLATFORM: options.platform,
// The bridge runs with a HOME of its own, so it is told where the fetched Argent release is cached.
EXPLORE_CONTROLLER_CACHE: controllerCacheRoot(source),
...(source.EXPLORE_NPM_REGISTRY ? { EXPLORE_NPM_REGISTRY: source.EXPLORE_NPM_REGISTRY } : {}),
// Opt-in: each Argent call to a JSON-lines log, one file per session, for debugging a controller run.
...(source.EXPLORE_ARGENT_LOG_DIR ? { EXPLORE_ARGENT_LOG_DIR: source.EXPLORE_ARGENT_LOG_DIR, EXPLORE_ARGENT_LOG_NAME: options.connection.sessionId } : {}),
...(options.bundleId ? { EXPLORE_ARGENT_BUNDLE_ID: options.bundleId } : {}),
...(options.device ? { EXPLORE_ARGENT_DEVICE: options.device } : {}),
...(options.pose ? { EXPLORE_ARGENT_POSE: options.pose } : {}) },
};
}
+32
View File
@@ -0,0 +1,32 @@
/**
* Runs a device controller Explore fetches on first use: `controller-launcher.js <controller> <args...>` makes sure
* the pinned release is in the cache, then runs it with the arguments, passing its output and exit code through.
* A failed fetch answers in agent-device's JSON envelope, so callers report it like any controller failure.
*/
import { spawn } from "node:child_process";
import { ensureController, type ControllerName } from "../shared/controller-cache.js";
async function main(): Promise<number> {
const [controller, ...args] = process.argv.slice(2);
if (controller !== "agent-device") {
process.stdout.write(JSON.stringify({ success: false, error: { code: "INVALID_ARGS", message: `Unknown controller: ${controller ?? ""}` } }));
return 1;
}
let bin: string;
try { bin = await ensureController(controller as ControllerName, { progress: message => process.stderr.write(`[explore] ${message}\n`) }); }
catch (error) {
const failure = error as { code?: string; message?: string; nextAction?: string };
process.stdout.write(JSON.stringify({ success: false, error: { code: failure.code ?? "CONTROLLER_DOWNLOAD_FAILED",
message: failure.message ?? String(error), ...(failure.nextAction ? { hint: failure.nextAction } : {}) } }));
return 1;
}
return new Promise(resolve => {
const child = spawn(process.execPath, [bin, ...args], { stdio: "inherit" });
// A capture that stops the launcher stops the controller with it.
for (const signal of ["SIGINT", "SIGTERM"] as const) process.on(signal, () => child.kill(signal));
child.on("exit", (code, signal) => resolve(code ?? (signal ? 1 : 0)));
child.on("error", () => resolve(1));
});
}
process.exitCode = await main();
+25 -54
View File
@@ -1,4 +1,4 @@
import { cp, lstat, realpath, mkdtemp, mkdir, writeFile, readFile, rm } from "node:fs/promises";
import { cp, lstat, realpath, mkdtemp, mkdir, writeFile, readFile, rename, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import { isAbsolute, basename, dirname, resolve, join } from "node:path";
import type { SourceRoute } from "../contracts/source-route.js";
@@ -146,35 +146,6 @@ async function downloadedAppPath(stdout: string, privateRoot: string, platform:
return canonical;
}
function uploadedBuildId(stdout: string): string {
const value = parseJson(stdout, "eas upload");
if (!isRecord(value) || typeof value.url !== "string") {
throw new Error("eas upload did not return a build URL");
}
let url: URL;
try {
url = new URL(value.url);
} catch {
throw new Error("eas upload returned an invalid build URL");
}
if (
url.protocol !== "https:"
|| url.hostname !== "expo.dev"
|| url.port
|| url.username
|| url.password
|| url.search
|| url.hash
) {
throw new Error("eas upload returned an untrusted build URL");
}
const segments = url.pathname.split("/").filter(Boolean);
if (segments.at(-2) !== "builds") {
throw new Error("eas upload returned an unexpected build URL");
}
return buildIdFrom({ id: segments.at(-1) }, "eas upload");
}
export type RepackProfile = {
easEnvironment: string;
profileEnvironment: Record<string, string>;
@@ -525,6 +496,12 @@ async function prepareHostedRepack(options: {
return hostedRepackBuildId(run.stdout, run.stderr, options.platform);
}
/**
* The instrumented app a capture runs, on this machine, and the EAS build it came from when a hosted job repacked it.
* A local repack is never uploaded, so it has no build id.
*/
export type PreparedBuild = { buildId: string | null; app: string };
export async function prepareExactSourceBuild(options: {
platform?: "ios" | "android";
runner: CommandRunner;
@@ -537,14 +514,16 @@ export async function prepareExactSourceBuild(options: {
easEnvironment: NodeJS.ProcessEnv;
repackEnvironment: NodeJS.ProcessEnv;
routes: readonly SourceRoute[];
/** `eas` (default) repacks in a hosted EAS workflow job; `local` runs repack-app on this machine and `eas upload`s the result. */
/** `eas` (default) repacks in a hosted EAS workflow job; `local` runs repack-app on this machine. */
repack?: RepackMode | undefined;
/** The capture build profile name; the hosted repack job builds against it. */
easProfile?: string | undefined;
}): Promise<string | undefined> {
/** Where to leave the instrumented app on this machine, for the capture to install; it must not exist yet. */
keepApp: string;
}): Promise<PreparedBuild | undefined> {
const platform = options.platform ?? "ios";
const root = await mkdtemp(join(tmpdir(), "expo-explore-repack-"));
let outcome: string | null | undefined;
let outcome: PreparedBuild | null | undefined;
let primaryError: unknown;
try {
const providers = [...new Set(options.routes.map(route => route.provider))];
@@ -553,10 +532,18 @@ export async function prepareExactSourceBuild(options: {
nextAction: "Select the application's navigation provider in config.yaml and rerun source planning." });
if ((options.repack ?? "eas") === "eas") {
if (!options.easProfile) throw new Error("The hosted repack needs the capture build profile name.");
outcome = await prepareHostedRepack({ platform, runner: options.runner, easCommand: options.easCommand, project: options.project,
const hosted = await prepareHostedRepack({ platform, runner: options.runner, easCommand: options.easCommand, project: options.project,
nativeBuildId: options.nativeBuildId, easProfile: options.easProfile, repackProfile: options.repackProfile,
easEnvironment: options.easEnvironment, restrictedEnvironment: options.repackEnvironment, provider: providers[0]!,
parameterKeys: captureObserverParameterKeys(options.routes), root });
{
// The hosted job leaves its app on EAS; the capture installs a copy downloaded here.
const downloaded = await downloadedAppPath(options.runner({ command: options.easCommand,
args: ["build:download", "--build-id", hosted, "--json", "--non-interactive"], cwd: options.project,
environment: { ...options.easEnvironment, TMPDIR: root, TMP: root, TEMP: root }, timeoutMs: 10 * 60_000 }).stdout, root, platform);
await rename(downloaded, options.keepApp);
outcome = { buildId: hosted, app: options.keepApp };
}
} else {
const shadowProject = join(root, "eas-project");
const pulledEnvironmentPath = join(root, "server.env");
@@ -671,26 +658,10 @@ export async function prepareExactSourceBuild(options: {
if (repackedInfo.isSymbolicLink() || (platform === "android" ? !repackedInfo.isFile() : !repackedInfo.isDirectory())) {
throw new Error(platform === "android" ? "repack-app did not produce a non-symlink Android .apk file" : "repack-app did not produce a non-symlink iOS .app directory");
}
let uploaded;
try {
uploaded = options.runner({
command: options.easCommand,
args: [
"upload",
"--platform", platform,
"--build-path", repackedApp,
"--fingerprint", options.fingerprint,
"--json",
"--non-interactive",
],
cwd: options.project,
environment: privateEasEnvironment,
timeoutMs: 10 * 60_000,
});
} catch (error) {
throw easPlanLimitError(error, platform) ?? error;
}
outcome = uploadedBuildId(uploaded.stdout);
// The capture installs the repacked app from here (a local device directly, an EAS session through its
// controller), so it is never uploaded.
await rename(repackedApp, options.keepApp);
outcome = { buildId: null, app: options.keepApp };
}
}
} catch (error) {
+74
View File
@@ -0,0 +1,74 @@
import { randomUUID } from "node:crypto";
import { mkdir, readdir, readFile, rename, rm, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { exploreCacheRoot } from "../shared/cache-root.js";
import { deleteLocalEmulator, deleteLocalSimulator, emulatorPortsDirectory, stopLocalAgentDevice, stopLocalArgentServer } from "./local-simulator.js";
import type { CommandRunner } from "./run.js";
/**
* What one capture side started on this machine: its simulator or emulator, its agent-device daemon (under `directory`)
* and its Argent tool-server, with the process that owns them. A capture that stops cleanly removes its record; one
* stopped hard (a second Ctrl+C, a killed terminal) leaves it, and the next local review cleans up after it.
*/
export type LocalCaptureRecord = { owner: number; startedAt: string; directory: string; udid?: string; serial?: string; avd?: string;
argent?: { pid: number; cli: string; home: string } };
function registryDirectory(environment: NodeJS.ProcessEnv): string {
return join(exploreCacheRoot(environment), "local-captures");
}
/** Records what a capture side starts, as it starts it; `close` forgets it once everything is stopped. */
export async function openLocalCaptureRecord(environment: NodeJS.ProcessEnv, directory: string): Promise<{
update: (patch: Partial<Omit<LocalCaptureRecord, "owner" | "startedAt" | "directory">>) => Promise<void>; close: () => Promise<void> }> {
const registry = registryDirectory(environment);
await mkdir(registry, { recursive: true, mode: 0o700 });
const path = join(registry, `${randomUUID()}.json`);
let record: LocalCaptureRecord = { owner: process.pid, startedAt: new Date().toISOString(), directory };
const write = async () => {
// Written whole and renamed, so a sweep never reads half a record.
await writeFile(`${path}.tmp`, JSON.stringify(record), { mode: 0o600 });
await rename(`${path}.tmp`, path);
};
await write();
return { update: async patch => { record = { ...record, ...patch }; await write(); }, close: () => rm(path, { force: true }) };
}
function alive(pid: number): boolean {
if (!Number.isInteger(pid) || pid <= 0) return false;
try { process.kill(pid, 0); return true; } catch (error) { return (error as NodeJS.ErrnoException).code === "EPERM"; }
}
/**
* Stops what captures whose process has exited left running, and says what it stopped. Only what Explore recorded is
* touched, never other simulators or emulators on this machine. An emulator's console port may have been taken by a
* live capture since; then that emulator is left alone rather than risk stopping the live one.
*/
export async function sweepLocalCaptures(options: { environment: NodeJS.ProcessEnv; runner: CommandRunner; cwd: string }): Promise<string[]> {
const registry = registryDirectory(options.environment);
const swept: string[] = [];
for (const name of await readdir(registry).catch(() => [] as string[])) {
if (!name.endsWith(".json")) continue;
const path = join(registry, name);
const record = await readFile(path, "utf8").then(text => JSON.parse(text) as LocalCaptureRecord, () => undefined);
if (!record || typeof record.owner !== "number" || alive(record.owner)) continue;
const { runner, cwd, environment } = options;
let complete = true;
const attempt = async (what: string, stop: () => unknown) => {
try { await stop(); swept.push(what); } catch { complete = false; }
};
if (record.argent && Number.isInteger(record.argent.pid)) {
const argent = record.argent;
await attempt(`Argent tool-server (pid ${argent.pid})`, () => stopLocalArgentServer({ ...argent, environment: { PATH: environment.PATH, HOME: argent.home } }));
}
if (typeof record.directory === "string") await attempt("agent-device daemon", () => stopLocalAgentDevice(join(record.directory, "agent-device-state")));
if (typeof record.udid === "string") await attempt(`simulator ${record.udid}`, () => deleteLocalSimulator({ runner, udid: record.udid!, cwd, environment }));
if (typeof record.serial === "string") {
const holder = Number(await readFile(join(emulatorPortsDirectory(environment), `${record.serial.slice("emulator-".length)}.lock`), "utf8").catch(() => ""));
if (!alive(holder) || holder === record.owner) await attempt(`emulator ${record.serial}`, () => deleteLocalEmulator({ runner, serial: record.serial!, cwd, environment }));
}
if (!complete) continue;
if (typeof record.directory === "string") await rm(record.directory, { recursive: true, force: true });
await rm(path, { force: true });
}
return swept;
}
+417
View File
@@ -0,0 +1,417 @@
import { spawnSync } from "node:child_process";
import { existsSync } from "node:fs";
import { mkdir, readdir, readFile, rm, stat, symlink, writeFile } from "node:fs/promises";
import { homedir } from "node:os";
import { join } from "node:path";
import { apkAbis } from "../binary/archive.js";
import { exploreCacheRoot } from "../shared/cache-root.js";
import { CiError } from "../shared/ci-errors.js";
import { isRecord, parseJson } from "./common.js";
import type { CommandRunner } from "./run.js";
/**
* A simulator Explore creates on this Mac for one capture (`capture.simulator: local`), in place of an EAS Simulator
* session. Each capture gets its own device, so head and base run side by side without sharing app state, and the
* device is deleted when the capture ends.
*/
export type LocalSimulator = { udid: string; name: string; deviceType: string; runtime: string; osVersion: string };
/** A session state file names a local simulator with this prefix, so an interrupted review deletes it rather than calling EAS. */
export const LOCAL_SIMULATOR_STATE_PREFIX = "simctl-";
const UDID = /^[0-9A-F]{8}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{12}$/;
function simctl(runner: CommandRunner, args: string[], cwd: string, environment: NodeJS.ProcessEnv, timeoutMs = 60_000, allowFailure = false) {
return runner({ command: "xcrun", args: ["simctl", ...args], cwd, environment, timeoutMs, ...(allowFailure ? { allowFailure } : {}) });
}
function versionKey(version: string): number[] {
return version.split(".").map(part => Number.parseInt(part, 10) || 0);
}
function newer(left: string, right: string): boolean {
const a = versionKey(left), b = versionKey(right);
for (let index = 0; index < Math.max(a.length, b.length); index += 1) {
if ((a[index] ?? 0) !== (b[index] ?? 0)) return (a[index] ?? 0) > (b[index] ?? 0);
}
return false;
}
/** The device type named like the configured device, and the newest installed iOS runtime that runs it. */
export function localSimulatorTarget(devicetypes: string, runtimes: string, device: string): { deviceType: string; runtime: string; osVersion: string } {
const types = parseJson(devicetypes, "simctl list devicetypes");
const type = (isRecord(types) && Array.isArray(types.devicetypes) ? types.devicetypes : [])
.find(entry => isRecord(entry) && entry.name === device);
if (!isRecord(type) || typeof type.identifier !== "string") throw new CiError({ code: "LOCAL_SIMULATOR_DEVICE_UNAVAILABLE", stage: "session",
message: `This Mac's Xcode has no ${device} simulator.`,
nextAction: `Set device.name in config.yaml to a simulator listed by xcrun simctl list devicetypes, or install the Xcode that adds ${device} and select it with xcode-select.` });
const listed = parseJson(runtimes, "simctl list runtimes");
let best: { runtime: string; osVersion: string } | undefined;
for (const entry of isRecord(listed) && Array.isArray(listed.runtimes) ? listed.runtimes : []) {
if (!isRecord(entry) || entry.isAvailable !== true || entry.platform !== "iOS" || typeof entry.identifier !== "string" || typeof entry.version !== "string") continue;
const supported = Array.isArray(entry.supportedDeviceTypes) && entry.supportedDeviceTypes.some(supportedType => isRecord(supportedType) && supportedType.identifier === type.identifier);
if (supported && (!best || newer(entry.version, best.osVersion))) best = { runtime: entry.identifier, osVersion: entry.version };
}
if (!best) throw new CiError({ code: "LOCAL_SIMULATOR_RUNTIME_UNAVAILABLE", stage: "session",
message: `No installed iOS simulator runtime runs ${device}.`,
nextAction: "Install an iOS simulator runtime in Xcode (Settings > Components) that supports this device, then rerun." });
return { deviceType: type.identifier, ...best };
}
/**
* Creates a fresh simulator of the configured device and starts it booting. `simctl boot` returns while the device is
* still starting, so a capture boots it before repacking the app and waits for it (waitForLocalSimulator) afterwards.
*/
export async function createLocalSimulator(options: { runner: CommandRunner; device: string; name: string; cwd: string; environment: NodeJS.ProcessEnv;
/** Called with the new device's UDID before it boots, so a caller can record it for cleanup. */
created?: (udid: string) => void | Promise<void> }): Promise<LocalSimulator> {
const { runner, cwd, environment } = options;
const target = localSimulatorTarget(simctl(runner, ["list", "devicetypes", "-j"], cwd, environment).stdout,
simctl(runner, ["list", "runtimes", "-j"], cwd, environment).stdout, options.device);
const udid = simctl(runner, ["create", options.name, target.deviceType, target.runtime], cwd, environment).stdout.trim();
if (!UDID.test(udid)) throw new Error("simctl create did not return a simulator UDID");
await options.created?.(udid);
simctl(runner, ["boot", udid], cwd, environment, 5 * 60_000);
return { udid, name: options.name, ...target };
}
/** Waits until a simulator createLocalSimulator started has finished booting. */
export function waitForLocalSimulator(options: { runner: CommandRunner; udid: string; cwd: string; environment: NodeJS.ProcessEnv }): void {
simctl(options.runner, ["bootstatus", options.udid, "-b"], options.cwd, options.environment, 5 * 60_000);
}
/**
* Lets the app open its own links without iOS asking "Open in “App”?" first, as a person would have approved it once.
* EAS Simulator gives no access to the device, so its captures still answer the prompt (route-capture.ts); a local
* simulator never shows it.
*/
export function approveLinkScheme(options: { runner: CommandRunner; udid: string; scheme: string; bundleId: string; cwd: string; environment: NodeJS.ProcessEnv }): void {
if (!/^[A-Za-z][A-Za-z0-9+.-]*$/.test(options.scheme)) throw new Error("Not a URL scheme");
simctl(options.runner, ["spawn", options.udid, "defaults", "write", "com.apple.launchservices.schemeapproval",
`com.apple.CoreSimulator.CoreSimulatorBridge-->${options.scheme}`, "-string", options.bundleId], options.cwd, options.environment);
}
/** The pixel size of a PNG, from its header. */
function pngSize(bytes: Buffer): { width: number; height: number } | undefined {
if (bytes.length < 24 || bytes.toString("latin1", 12, 16) !== "IHDR") return undefined;
return { width: bytes.readUInt32BE(16), height: bytes.readUInt32BE(20) };
}
/**
* Whether a local foldable shows the pose it was folded to, by the shape of its lit display: the inner one is landscape
* when open, the outer one portrait when closed. A half-open hinge shows either, so it is not checked.
*/
export async function localPoseShown(options: { runner: CommandRunner; udid: string; pose: string; directory: string; cwd: string; environment: NodeJS.ProcessEnv;
sleep?: (milliseconds: number) => void }): Promise<boolean> {
if (options.pose !== "open" && options.pose !== "closed") return true;
const file = join(options.directory, "pose.png");
const sleep = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
// The display relights and resizes over a moment after the hinge moves.
for (let attempt = 0; attempt < 10; attempt += 1) {
if (attempt) sleep(1_000);
simctl(options.runner, ["io", options.udid, "screenshot", file], options.cwd, options.environment, 60_000, true);
const size = pngSize(await readFile(file).catch(() => Buffer.alloc(0)));
await rm(file, { force: true });
if (size && (options.pose === "open" ? size.width > size.height : size.height > size.width)) return true;
}
return false;
}
export function installOnLocalSimulator(options: { runner: CommandRunner; udid: string; app: string; cwd: string; environment: NodeJS.ProcessEnv }): void {
simctl(options.runner, ["install", options.udid, options.app], options.cwd, options.environment, 5 * 60_000);
}
/** Shuts the simulator down and deletes it. Shutting down a device that is not booted fails harmlessly; only the delete counts. */
export function deleteLocalSimulator(options: { runner: CommandRunner; udid: string; cwd: string; environment: NodeJS.ProcessEnv }): void {
if (!UDID.test(options.udid)) throw new Error("Not a simulator UDID");
simctl(options.runner, ["shutdown", options.udid], options.cwd, options.environment, 2 * 60_000, true);
simctl(options.runner, ["delete", options.udid], options.cwd, options.environment, 2 * 60_000);
}
/** The UDID a session state file records for a local simulator, or undefined when it names an EAS session. */
export function localSimulatorFromState(state: string): string | undefined {
if (!state.startsWith(LOCAL_SIMULATOR_STATE_PREFIX)) return undefined;
const udid = state.slice(LOCAL_SIMULATOR_STATE_PREFIX.length);
return UDID.test(udid) ? udid : undefined;
}
/**
* An Android emulator Explore creates on this machine for one capture. Its AVD lives in the capture's own
* `ANDROID_AVD_HOME`, so it never appears among the user's emulators and goes with the capture's directory.
*/
export type LocalEmulator = { serial: string; avd: string; avdHome: string; image: string; osVersion: string };
/** A session state file names a local emulator by its adb serial with this prefix. */
export const LOCAL_EMULATOR_STATE_PREFIX = "adb-";
const SERIAL = /^emulator-[0-9]{4}$/;
/** The SDK's own tools, so a different adb or avdmanager earlier on PATH does not answer for this SDK. */
export function androidTools(environment: NodeJS.ProcessEnv): { sdk: string; adb: string; emulator: string; avdmanager: string } {
const sdk = environment.ANDROID_HOME || environment.ANDROID_SDK_ROOT;
if (!sdk) throw new CiError({ code: "ANDROID_SDK_MISSING", stage: "session",
message: "A local Android emulator needs the Android SDK, and neither ANDROID_HOME nor ANDROID_SDK_ROOT is set.",
nextAction: "Install the SDK's platform-tools, emulator, cmdline-tools and a system image with sdkmanager, export ANDROID_HOME, and rerun." });
return { sdk, adb: join(sdk, "platform-tools", "adb"), emulator: join(sdk, "emulator", "emulator"), avdmanager: join(sdk, "cmdline-tools", "latest", "bin", "avdmanager") };
}
/** The ABI an emulator runs natively on this machine: Apple silicon runs arm64 images; x86_64 images need an Intel host. */
export function hostEmulatorAbi(arch: string = process.arch): string {
return arch === "arm64" ? "arm64-v8a" : "x86_64";
}
/** The newest installed Google APIs system image for this machine's ABI, as `system-images;android-35;google_apis;arm64-v8a`. */
export async function localSystemImage(sdk: string, abi: string): Promise<{ image: string; apiLevel: number }> {
let best: { image: string; apiLevel: number } | undefined;
const platforms = await readdir(join(sdk, "system-images")).catch(() => [] as string[]);
for (const platform of platforms) {
const apiLevel = Number(/^android-(\d+)$/.exec(platform)?.[1]);
if (!Number.isInteger(apiLevel)) continue;
for (const tag of ["google_apis_playstore", "google_apis"]) {
if (!existsSync(join(sdk, "system-images", platform, tag, abi, "system.img"))) continue;
if (!best || apiLevel > best.apiLevel) best = { image: `system-images;${platform};${tag};${abi}`, apiLevel };
}
}
if (!best) throw new CiError({ code: "LOCAL_EMULATOR_IMAGE_UNAVAILABLE", stage: "session",
message: `The Android SDK at ${sdk} has no Google APIs system image for ${abi}.`,
nextAction: `Install one, for example: sdkmanager "system-images;android-35;google_apis;${abi}", then rerun.` });
return best;
}
/** Refuses an APK whose native libraries cannot load on this machine's emulator, before an emulator is started for it. */
export async function assertLocalEmulatorCompatible(apk: string, abi: string): Promise<void> {
const abis = await apkAbis(apk);
if (abis.length && !abis.includes(abi)) throw new CiError({ code: "LOCAL_EMULATOR_ABI_UNSUPPORTED", stage: "session",
message: `The APK ships native libraries only for ${abis.join(", ")}; this machine's emulator runs ${abi}.`,
nextAction: `Build an APK that includes ${abi} (a universal build does), or capture Android on EAS Simulator with --simulator eas.` });
}
/**
* Creates an AVD of the configured device profile (such as pixel_7) and starts it without a window. It boots in the
* background while a capture repacks the app; waitForLocalEmulator waits for it afterwards.
*/
export async function startLocalEmulator(options: { runner: CommandRunner; device: string; name: string; directory: string; cwd: string; environment: NodeJS.ProcessEnv;
/** Called with the emulator's adb serial once it is starting, so a caller can record it for cleanup. */
started?: (serial: string) => void | Promise<void>;
/** Whether the controller still holds a serial (a claim an interrupted run left behind); such a port is skipped. */
claimed?: (serial: string) => boolean }): Promise<Omit<LocalEmulator, "osVersion"> & { apiLevel: number }> {
const { runner, cwd } = options;
const tools = androidTools(options.environment);
const avdHome = join(options.directory, "avd");
await mkdir(avdHome, { recursive: true });
const environment = { ...options.environment, ANDROID_AVD_HOME: avdHome };
const { image, apiLevel } = await localSystemImage(tools.sdk, hostEmulatorAbi());
const created = runner({ command: tools.avdmanager, args: ["create", "avd", "--name", options.name, "--package", image, "--device", options.device, "--force"],
cwd, environment: { ...environment, ANDROID_SDK_ROOT: tools.sdk }, timeoutMs: 2 * 60_000, allowFailure: true });
if (!existsSync(join(avdHome, `${options.name}.avd`))) throw new CiError({ code: "LOCAL_EMULATOR_DEVICE_UNAVAILABLE", stage: "session",
message: `avdmanager could not create an ${options.device} emulator: ${(created.stderr || created.stdout).trim().split("\n").at(-1) ?? "no output"}`,
nextAction: "Set device.name to a device profile listed by avdmanager list device -c (such as pixel_7), then rerun." });
// Emulators listen on even console ports from 5554; this one takes the first that adb does not list and no other capture
// has reserved, since several start at once.
const listed = runner({ command: tools.adb, args: ["devices"], cwd, environment, timeoutMs: 30_000 }).stdout;
let port = 5554;
while (listed.includes(`emulator-${port}`) || listed.includes(`emulator-${port + 1}`) || options.claimed?.(`emulator-${port}`) || !await reservePort(port, options.environment)) {
port += 2;
if (port > 5682) throw new CiError({ code: "LOCAL_EMULATOR_PORT_UNAVAILABLE", stage: "session", message: "Every emulator console port (5554-5682) is in use.",
nextAction: "Stop some running emulators (adb devices lists them), then rerun." });
}
const serial = `emulator-${port}`;
// The emulator runs until the capture kills it; the shell returns as soon as it is started.
// gRPC (with a token) makes the emulator publish itself in avd/running, where Argent's device server finds it.
runner({ command: "/bin/sh", args: ["-c", 'nohup "$0" "$@" > "$EXPLORE_EMULATOR_LOG" 2>&1 &', tools.emulator, "-avd", options.name, "-port", String(port),
"-grpc", String(port + 3000), "-grpc-use-token", "-no-window", "-no-audio", "-no-boot-anim", "-no-snapshot", "-gpu", "swiftshader_indirect"],
cwd, environment: { ...environment, EXPLORE_EMULATOR_LOG: join(options.directory, "emulator.log") }, timeoutMs: 30_000 });
await options.started?.(serial);
return { serial, avd: options.name, avdHome, image, apiLevel };
}
/** Waits until an emulator startLocalEmulator started has booted, and reads its Android version. */
export function waitForLocalEmulator(options: { runner: CommandRunner; serial: string; device: string; apiLevel: number; directory: string; cwd: string;
environment: NodeJS.ProcessEnv; now?: () => number; sleep?: (milliseconds: number) => void }): string {
const { runner, serial, cwd } = options;
const tools = androidTools(options.environment);
const environment = { ...options.environment, ANDROID_AVD_HOME: join(options.directory, "avd") };
const now = options.now ?? Date.now;
const sleep = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
runner({ command: tools.adb, args: ["-s", serial, "wait-for-device"], cwd, environment, timeoutMs: 5 * 60_000 });
const deadline = now() + 5 * 60_000;
while (runner({ command: tools.adb, args: ["-s", serial, "shell", "getprop", "sys.boot_completed"], cwd, environment, timeoutMs: 30_000, allowFailure: true }).stdout.trim() !== "1") {
if (now() > deadline) throw new CiError({ code: "LOCAL_EMULATOR_BOOT_TIMEOUT", stage: "session",
message: `The ${options.device} emulator did not finish booting in 5 minutes.`, nextAction: `Inspect ${join(options.directory, "emulator.log")} and rerun.` });
sleep(2_000);
}
return runner({ command: tools.adb, args: ["-s", serial, "shell", "getprop", "ro.build.version.release"], cwd, environment, timeoutMs: 30_000 }).stdout.trim() || String(options.apiLevel);
}
export function installOnLocalEmulator(options: { runner: CommandRunner; serial: string; apk: string; cwd: string; environment: NodeJS.ProcessEnv }): void {
const { adb } = androidTools(options.environment);
options.runner({ command: adb, args: ["-s", options.serial, "install", "-r", options.apk], cwd: options.cwd, environment: options.environment, timeoutMs: 5 * 60_000 });
}
/**
* Where captures reserve emulator console ports: a directory of this user's Explore cache, not the machine's temporary
* directory, which on Linux is shared with other users who could plant a lock (or a symlink in its place).
*/
export function emulatorPortsDirectory(environment: NodeJS.ProcessEnv): string {
return join(exploreCacheRoot(environment), "emulator-ports");
}
/** The reservation of one console port; it names the process holding it. */
function portLock(port: number, environment: NodeJS.ProcessEnv): string {
return join(emulatorPortsDirectory(environment), `${port}.lock`);
}
/** Whether a process this user can see is running; a pid that is not a positive integer names none. */
function processAlive(pid: number): boolean {
if (!Number.isInteger(pid) || pid <= 0) return false;
try { process.kill(pid, 0); return true; } catch (error) { return (error as NodeJS.ErrnoException).code === "EPERM"; }
}
/**
* Reserves a console port for this process; a reservation whose process has exited is taken over. Head and base start
* their emulators at once on worker threads of one process, and other reviews may too: each reservation runs alone,
* under a mutex directory, since taking over a stale lock is a read, a removal and a write that two captures would
* otherwise both complete. The mutex names its holder; one left by a process that died holding it is broken by a
* single capture at a time (a breaker directory), which checks again that it is still the dead holder's.
*/
export async function reservePort(port: number, environment: NodeJS.ProcessEnv): Promise<boolean> {
const directory = emulatorPortsDirectory(environment);
await mkdir(directory, { recursive: true, mode: 0o700 });
const mutex = join(directory, "mutex"), breaker = join(directory, "mutex-breaker");
// A holder writes its pid right after creating the mutex; a mutex without one is a holder between the two, unless old.
const abandoned = async (path: string) => {
const info = await stat(path).catch(() => undefined);
if (!info) return false;
const owner = await readFile(join(path, "owner"), "utf8").catch(() => undefined);
return owner === undefined ? Date.now() - info.mtimeMs > 10_000 : !processAlive(Number(owner));
};
for (;;) {
try { await mkdir(mutex); await writeFile(join(mutex, "owner"), String(process.pid)); break; }
catch (error) {
if ((error as NodeJS.ErrnoException).code !== "EEXIST") throw error;
if (await abandoned(mutex)) {
let breaking = false;
try { await mkdir(breaker); breaking = true; }
catch (failure) { if ((failure as NodeJS.ErrnoException).code !== "EEXIST") throw failure; if (await abandoned(breaker)) await rm(breaker, { recursive: true, force: true }); }
if (breaking) {
try { await writeFile(join(breaker, "owner"), String(process.pid)); if (await abandoned(mutex)) await rm(mutex, { recursive: true, force: true }); }
finally { await rm(breaker, { recursive: true, force: true }); }
continue;
}
}
await new Promise(resolve => setTimeout(resolve, 20));
}
}
try {
const lock = portLock(port, environment);
if (processAlive(Number(await readFile(lock, "utf8").catch(() => "")))) return false;
await writeFile(lock, String(process.pid));
return true;
} finally {
await rm(mutex, { recursive: true, force: true });
}
}
/** Stops the emulator and frees its console port; its AVD goes with the capture's directory. */
export async function deleteLocalEmulator(options: { runner: CommandRunner; serial: string; cwd: string; environment: NodeJS.ProcessEnv }): Promise<void> {
if (!SERIAL.test(options.serial)) throw new Error("Not an emulator serial");
const { adb } = androidTools(options.environment);
// An emulator that already exited (or crashed) is stopped too; only one adb still lists is not.
options.runner({ command: adb, args: ["-s", options.serial, "emu", "kill"], cwd: options.cwd, environment: options.environment, timeoutMs: 60_000, allowFailure: true });
const listed = (serial: string) => options.runner({ command: adb, args: ["devices"], cwd: options.cwd, environment: options.environment, timeoutMs: 30_000, allowFailure: true })
.stdout.split("\n").some(line => line.split("\t")[0] === serial && line.includes("device"));
for (let attempt = 0; listed(options.serial); attempt += 1) {
if (attempt === 10) throw new Error(`${options.serial} is still running after emu kill`);
await new Promise(resolve => setTimeout(resolve, 1_000));
}
// An emulator adb has lost (its console port closed, a child defunct) is not listed and ignores emu kill, yet runs on
// with its AVD open; its process, by the AVD name and port this capture started it with, is stopped instead.
const port = Number(options.serial.slice("emulator-".length));
const running = () => options.runner({ command: "pgrep", args: ["-f", `qemu-system.* -avd explore-[a-z]+-[0-9a-f]{8} -port ${port} `], cwd: options.cwd,
environment: options.environment, timeoutMs: 30_000, allowFailure: true }).stdout.split("\n").map(Number).filter(pid => Number.isInteger(pid) && pid > 0);
for (let attempt = 0, pids = running(); pids.length > 0; attempt += 1, pids = running()) {
if (attempt === 10) throw new Error(`${options.serial} is still running after it was signalled`);
for (const pid of pids) try { process.kill(pid, attempt < 5 ? "SIGTERM" : "SIGKILL"); } catch { /* it has already exited */ }
await new Promise(resolve => setTimeout(resolve, 1_000));
}
await rm(portLock(port, options.environment), { force: true });
}
/** The adb serial a session state file records for a local emulator, or undefined when it names something else. */
export function localEmulatorFromState(state: string): string | undefined {
if (!state.startsWith(LOCAL_EMULATOR_STATE_PREFIX)) return undefined;
const serial = state.slice(LOCAL_EMULATOR_STATE_PREFIX.length);
return SERIAL.test(serial) ? serial : undefined;
}
/** Argent's tool-server for one capture on this machine: where it listens, its token, and its process. */
/** A capture's own tool-server; `environment` is the narrowed one it was started with, which stopping it uses too. */
export type LocalArgentServer = { url: string; token: string; pid: number; cli: string; home: string; environment: NodeJS.ProcessEnv };
/**
* Starts Argent's tool-server for one capture, on a free port, with a HOME of its own so captures running side by
* side do not share its state, and waits for it to say where it listens. Its simulator server looks for devices
* under $HOME, so that HOME links to this machine's simulators and Android settings.
*/
export async function startLocalArgentServer(options: { runner: CommandRunner; cli: string; directory: string; cwd: string; environment: NodeJS.ProcessEnv;
now?: () => number; sleep?: (milliseconds: number) => void }): Promise<LocalArgentServer> {
const home = join(options.directory, "argent-server-home"), log = join(options.directory, "argent-server.log");
await mkdir(join(home, "Library", "Developer"), { recursive: true, mode: 0o700 });
const realHome = options.environment.HOME || homedir();
// Running emulators publish themselves (gRPC port and token) in TemporaryItems/avd/running.
const running = join("Library", "Caches", "TemporaryItems", "avd");
await mkdir(join(realHome, running), { recursive: true });
await mkdir(join(home, "Library", "Caches", "TemporaryItems"), { recursive: true, mode: 0o700 });
for (const path of [join("Library", "Developer", "CoreSimulator"), ".android", running]) {
if (existsSync(join(realHome, path))) await symlink(join(realHome, path), join(home, path)).catch(error => { if (error.code !== "EEXIST") throw error; });
}
const environment = { ...options.environment, HOME: home, DO_NOT_TRACK: "1" };
const started = options.runner({ command: "/bin/sh", args: ["-c", 'nohup "$0" "$1" server start --port 0 > "$EXPLORE_ARGENT_SERVER_LOG" 2>&1 & echo $!', process.execPath, options.cli],
cwd: options.cwd, environment: { ...environment, EXPLORE_ARGENT_SERVER_LOG: log }, timeoutMs: 30_000 });
const pid = Number(started.stdout.trim());
const now = options.now ?? Date.now;
const sleep = options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); });
const deadline = now() + 60_000;
for (;;) {
const text = await readFile(log, "utf8").catch(() => "");
const url = /Tools server listening on (http:\/\/127\.0\.0\.1:\d+)/.exec(text)?.[1];
const token = /--token ([0-9a-f]+)/.exec(text)?.[1];
if (url && token && Number.isInteger(pid) && pid > 0) return { url, token, pid, cli: options.cli, home, environment };
if (now() > deadline) {
if (Number.isInteger(pid) && pid > 0) stopLocalArgentServer({ pid, cli: options.cli, home, environment });
throw new CiError({ code: "LOCAL_ARGENT_UNAVAILABLE", stage: "session", message: `Argent's tool-server did not start: ${text.trim().split("\n").at(-1) ?? "no output"}`,
nextAction: `Inspect ${log}, then rerun.` });
}
sleep(500);
}
}
/** Stops the tool-server the way Argent does (its own `server stop`, which ends the server it spawned), then its process. */
export function stopLocalArgentServer(server: Pick<LocalArgentServer, "pid" | "cli" | "home" | "environment">): void {
// The capture's narrowed environment, as at start: never the tokens and keys in this process's own.
spawnSync(process.execPath, [server.cli, "server", "stop"], { env: { ...server.environment, HOME: server.home }, timeout: 30_000, stdio: "ignore" });
try { process.kill(server.pid, "SIGTERM"); } catch { /* it has already exited */ }
}
/** Switches a local simulator's appearance from the host, for a controller that cannot (Argent). */
export function setLocalSimulatorAppearance(options: { runner: CommandRunner; udid: string; scheme: "light" | "dark"; cwd: string; environment: NodeJS.ProcessEnv }): void {
simctl(options.runner, ["ui", options.udid, "appearance", options.scheme], options.cwd, options.environment);
}
/** Switches a local emulator's night mode from the host, for a controller that cannot (Argent). */
export function setLocalEmulatorAppearance(options: { runner: CommandRunner; serial: string; scheme: "light" | "dark"; cwd: string; environment: NodeJS.ProcessEnv }): void {
const { adb } = androidTools(options.environment);
options.runner({ command: adb, args: ["-s", options.serial, "shell", "cmd", "uimode", "night", options.scheme === "dark" ? "yes" : "no"],
cwd: options.cwd, environment: options.environment, timeoutMs: 60_000 });
}
/**
* Stops the agent-device daemon a local capture ran in its own state directory. `close` ends the session, but the
* daemon outlives a directory removed under it; the pid it records (daemon.json) is the one to stop.
*/
export async function stopLocalAgentDevice(stateDirectory: string): Promise<void> {
const info = await readFile(join(stateDirectory, "daemon.json"), "utf8").then(text => JSON.parse(text) as { pid?: unknown }, () => undefined);
if (typeof info?.pid === "number" && Number.isInteger(info.pid) && info.pid > 0 && info.pid !== process.pid) {
try { process.kill(info.pid, "SIGTERM"); } catch { /* it has already exited */ }
}
}
+150 -21
View File
@@ -23,10 +23,13 @@ import { createExplorationInputs } from "../config/exploration-inputs.js";
import { isRecord, captureError, CONTROLLER_SESSION, parseJson } from "./common.js";
import { MAX_ACCESSIBILITY_EVIDENCE_BYTES, adbDeviceOffline, remoteDaemonUnavailable, controllerData, defaultRunner, type ControllerReadRecovery, type RemoteDaemonRetry, runControllerRead, controllerCommandFailure, runControllerReadAsync, runAgentControllerCommand, wedgedControllerReadFailure, openedSimulatorDevice, alertWatchdogFailure } from "./controller.js";
import type { ActiveSimulatorRuntime, SimulatorConnection } from "./simulator.js";
import { androidTools } from "./local-simulator.js";
import type { CiMapOptions, CommandResult } from "./run.js";
/** iOS commands name the simulator; an EAS Android session has exactly one emulator, selected by the session. */
export function deviceArgs(runtime: Pick<ActiveSimulatorRuntime, "platform" | "deviceModel">): string[] {
export function deviceArgs(runtime: Pick<ActiveSimulatorRuntime, "platform" | "deviceModel"> & Partial<Pick<ActiveSimulatorRuntime, "provider" | "controllerDeviceId">>): string[] {
// A local simulator is picked by its UDID, a local emulator by its adb serial: this machine may run others of the same model.
if (runtime.provider === "local-simulator" && runtime.controllerDeviceId) return [runtime.platform === "android" ? "--serial" : "--udid", runtime.controllerDeviceId];
return runtime.platform === "android" ? [] : ["--device", runtime.deviceModel];
}
@@ -90,12 +93,16 @@ function snapshotNodes(raw: string): Record<string, unknown>[] {
}
/** The visible element each required label matched, so an image assessor can find icon-only controls. */
export function verifiedCaptureLabels(nodes: readonly Record<string, unknown>[], requiredLabels: readonly string[]) {
export function verifiedCaptureLabels(nodes: readonly Record<string, unknown>[], requiredLabels: readonly string[],
/** The screen's portrait height, when the screenshot is that screen turned a quarter clockwise (an opened iPhone Duo). */
turned?: { height: number }) {
return requiredLabels.flatMap(value => nodes.filter(node => node.visible !== false && (node.label === value || node.identifier === value)).slice(0, 3).map(node => {
const rect = isRecord(node.rect) && ["x", "y", "width", "height"].every(key => Number.isFinite((node.rect as Record<string, unknown>)[key]))
? node.rect as { x: number; y: number; width: number; height: number } : undefined;
// The bounds are given on the image's axes: turned a quarter clockwise, the portrait point (x, y) is at (H - y, x).
const shown = rect && turned ? { x: turned.height - rect.y - rect.height, y: rect.x, width: rect.height, height: rect.width } : rect;
return { value, matchedField: node.label === value ? "label" as const : "identifier" as const,
...(typeof node.type === "string" ? { type: node.type } : {}), ...(rect ? { rect: { x: rect.x, y: rect.y, width: rect.width, height: rect.height } } : {}) };
...(typeof node.type === "string" ? { type: node.type } : {}), ...(shown ? { rect: { x: shown.x, y: shown.y, width: shown.width, height: shown.height } } : {}) };
}));
}
@@ -136,7 +143,9 @@ function landing(nodes: readonly Record<string, unknown>[], route: SourceRoute,
/** Execute source-owned targets in order. Live content never changes the source inventory. */
export async function capturePlannedRoutes(options: {
capture: CiMapOptions; routes: readonly SourceRoute[]; scheme: string | undefined; appName: string;
runtime: ActiveSimulatorRuntime; connection: SimulatorConnection; environment: NodeJS.ProcessEnv;
runtime: ActiveSimulatorRuntime;
/** The EAS session's controller connection; a local simulator has none. */
connection?: SimulatorConnection | undefined; environment: NodeJS.ProcessEnv;
store: ExploreStore; map: ExploreMap;
inventory?: readonly SourceRoute[];
acceptedFrames?: Record<string, AgentAcceptedFrame>;
@@ -328,7 +337,7 @@ export async function capturePlannedRoutes(options: {
message: "The Open confirmation did not complete within its capture budget.",
nextAction: "Inspect the controller diagnostic and verify that the pinned controller can dismiss the configured app's Open confirmation.",
details: { controller: serializeCiError(toCiError(error, { code: "CONTROLLER_ALERT_FAILED", stage: "capture" }),
{ secrets: [capture.expoToken, options.connection.daemonAuthToken] }) } });
{ secrets: [capture.expoToken, ...(options.connection ? [options.connection.daemonAuthToken] : [])] }) } });
}
const remainingAlert = alertInspection("deep-link-confirmed");
if (remainingAlert && (!allowExplicitSetupAlert || expectedTitles.includes(remainingAlert.message.normalize("NFC").trim()))) {
@@ -337,7 +346,7 @@ export async function capturePlannedRoutes(options: {
controllerApp();
controller(["wait", "500", "--level", "full", "--json"]);
};
const secrets = [capture.expoToken, options.connection.daemonAuthToken, ...inputs.values, ...(capture.agent?.secretValues ?? [])];
const secrets = [capture.expoToken, ...(options.connection ? [options.connection.daemonAuthToken] : []), ...inputs.values, ...(capture.agent?.secretValues ?? [])];
const redact = (text: string): string => secrets.filter(Boolean).flatMap(value => [value, JSON.stringify(value).slice(1, -1), encodeURIComponent(value)])
.sort((a, b) => b.length - a.length).reduce((result, value) => result.split(value).join("[REDACTED]"), inputs.redact(text));
const redactValue = <T>(value: T): T => {
@@ -521,9 +530,13 @@ export async function capturePlannedRoutes(options: {
const height = png.readUInt32BE(20);
runtime.orientation = width > height ? "landscape" : "portrait";
map.run.environment.orientation = runtime.orientation;
controllerApp();
const raw = controller(["snapshot", "--force-full", "--level", "full", "--json"]).stdout;
const confirmed = snapshotNodes(raw);
// The snapshot after the screenshot names the app in front, which saves an `appstate` call per route; a
// controller whose snapshot does not name it is asked.
const read = controllerData(raw, "snapshot");
if (read.appBundleId !== undefined || isRecord(read.identifiers)) assertIdentity(read, capture.bundleId, runtime.controllerDeviceId);
else controllerApp();
assertNoAlert({ route, nodes: confirmed });
const verifiedLanding: "verified" | "unverified" = unattributed ? "unverified" : landing(confirmed, route, inventory);
assertSafeScreenshot(confirmed);
@@ -673,17 +686,39 @@ export async function capturePlannedRoutes(options: {
rect: isRecord(node.rect) ? Object.fromEntries(Object.entries(node.rect).sort(([left], [right]) => left.localeCompare(right))) : node.rect,
parentIndex: node.parentIndex,
})));
/**
* The logical coordinate space a frame's normalized taps map into. On a panel whose native axes are portrait but
* whose UI is landscape (an opened iPhone Duo under Argent), the screenshot is taken upright: the portrait screen
* turned a quarter clockwise, while the accessibility tree and taps stay on the panel's portrait axes. Its root is
* then the transpose of the frame, and a tap is turned back (see `toLogical`).
*/
const bounds = (frame: Candidate) => {
const roots = frame.snapshot.nodes.filter(node => node.type === "Application" && isRecord(node.rect)
const roots = (transposed: boolean) => frame.snapshot.nodes.filter(node => node.type === "Application" && isRecord(node.rect)
&& node.rect.x === 0 && node.rect.y === 0 && typeof node.rect.width === "number" && typeof node.rect.height === "number"
&& Number.isFinite(node.rect.width) && Number.isFinite(node.rect.height) && node.rect.width > 0 && node.rect.height > 0
&& node.rect.width * frame.height === node.rect.height * frame.width);
if (roots.length !== 1) throw captureError("AGENT_COORDINATE_BOUNDS_UNVERIFIED", "The screenshot does not identify one matching full-screen logical coordinate space.");
&& (transposed ? node.rect.width * frame.width === node.rect.height * frame.height : node.rect.width * frame.height === node.rect.height * frame.width));
// A square screen matches both ways; it is read upright, as before rotated frames existed.
const upright = roots(false), turned = upright.length ? [] : roots(true);
const matched = upright.length ? upright : turned;
if (matched.length !== 1) throw captureError("AGENT_COORDINATE_BOUNDS_UNVERIFIED", "The screenshot does not identify one matching full-screen logical coordinate space.");
// The official iOS screenshot is full-screen. Its default is 1x, but a proven
// uniform pixel density must still map to XCTest points rather than raw pixels.
const rect = roots[0]!.rect as { width: number; height: number };
return { width: rect.width, height: rect.height };
const rect = matched[0]!.rect as { width: number; height: number };
return { width: rect.width, height: rect.height, transposed: turned.length === 1 };
};
/**
* A normalized point (x, y) in the screenshot, in the tree's logical points. Upright, it scales by the root. Turned:
* a portrait screen W wide and H tall, turned a quarter clockwise, is an image H wide and W tall in which the portrait
* point (px, py) lands at (u, v) = (H - py, px); so the image point (u, v) is the portrait point (v, H - u). With
* u = x * H and v = y * W, that is (y * W, (1 - x) * H). (A 2x3 portrait pixel at (0, 0), centre (0.5, 0.5), sits at
* column 2 of the turned 3x2 image, centre (2.5, 0.5), which maps back to (0.5, 3 - 2.5).)
*/
/** The portrait screen a turned (upright landscape) frame shows, or undefined for a frame on the screen's own axes. */
const turnedSpace = (frame: Candidate): { height: number } | undefined => {
try { const space = bounds(frame); return space.transposed ? { height: space.height } : undefined; } catch { return undefined; }
};
const toLogical = (space: { width: number; height: number; transposed: boolean }, x: number, y: number): [number, number] =>
space.transposed ? [y * space.width, (1 - x) * space.height] : [x * space.width, y * space.height];
/**
* agent-device's in-app back taps a navigation control and cannot leave a sheet without one.
* Swipe such a sheet down, then require the observed destination to change.
@@ -826,7 +861,7 @@ export async function capturePlannedRoutes(options: {
retryable: true, details: changes });
}
await discard();
await command(["press", String(action.x * oldBounds.width), String(action.y * oldBounds.height), "--level", "full", "--json"], signal);
await command(["press", ...toLogical(oldBounds, action.x, action.y).map(String), "--level", "full", "--json"], signal);
} finally { await discard(); await rm(previous.directory, { recursive: true, force: true }); }
return;
}
@@ -862,7 +897,7 @@ export async function capturePlannedRoutes(options: {
let assessment;
try {
assessment = rejectedReadiness.get(key) ?? await agent.assessCapture({ image: frame.png, route: route.route, context,
instructions: agent.instructions, verifiedLabels: verifiedCaptureLabels(frame.snapshot.nodes, context.requiredLabels),
instructions: agent.instructions, verifiedLabels: verifiedCaptureLabels(frame.snapshot.nodes, context.requiredLabels, turnedSpace(frame)),
deadlineMs: deadline, signal: liveSignal(signal) });
if (assessment.imageSha256 !== frame.imageSha256) throw new Error("Readiness assessment belongs to another frame");
await writeFile(join(diagnostics, `${stem}.json`), JSON.stringify(redactValue({ route: route.route, context, ...assessment })), { mode: 0o600 });
@@ -949,6 +984,52 @@ export async function capturePlannedRoutes(options: {
* reported as the failure it is. Only steps up to the fault have run, so no later state exists.
*/
const transientControllerFault = (error: unknown) => adbDeviceOffline(error) || remoteDaemonUnavailable(error);
/**
* A controller that stopped answering on one screen (its runner wedged on an accessibility capture or a covered
* control, or its reads stayed busy past their recovery window) fails every later read the same way. That costs the
* step or route it happened on, not the capture: the app is stopped (from the host on a local device, which a wedged
* runner cannot block) and started again, the read recovery starts over, and the controller must answer before the
* next route. Each recovery is recorded in capture-diagnostics/controller-recoveries.jsonl.
*/
const controllerWedged = (error: unknown): boolean => {
if (wedgedControllerReadFailure(error)) return true;
const failure = toCiError(error);
// An accessibility read that never completes (or never returns a whole tree) is the controller's failure, not the app's.
return ["CONTROLLER_READ_BUSY", "RUNNER_WEDGED", "CONTROLLER_RUNNER_WEDGED", "INVALID_ACCESSIBILITY_EVIDENCE", "SETUP_SYSTEM_SURFACE_BLOCKING"].includes(failure.code)
|| /execution watchdog|accessibility responsiveness|requires a valid viewport/.test(failure.message);
};
/**
* A setup step that left another app in front (a tap that landed on a system control drawn over the app, as iPhone
* Duo's status pill over a sheet's Done button) is recovered the same way: the app is started again.
*/
const appLeft = (error: unknown): boolean => toCiError(error).code === "CONTROLLER_IDENTITY_MISMATCH";
let recoveries = 0;
/** `next` records what the capture did once the app restarted: `setup-rerun` or `setup-incomplete` after a setup step. */
const recoverController = (where: string, error: unknown, next?: "setup-rerun" | "setup-incomplete"): boolean => {
const reported = serializeCiError(toCiError(error), { secrets });
const record = (recovered: boolean) => {
const diagnostics = join(store.root, "capture-diagnostics");
mkdirSync(diagnostics, { recursive: true, mode: 0o700 });
appendFileSync(join(diagnostics, "controller-recoveries.jsonl"), `${JSON.stringify({ where, code: reported.code, message: reported.message, recovered,
...(recovered && next ? { next } : {}), at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
};
if (recoveries >= 3 || deadline - clock() < 60_000) { record(false); return false; }
recoveries += 1;
say(`${appLeft(error) ? "the app was no longer in front" : "the device controller stopped answering"} on ${where} (${reported.code}); restarting the app before going on`);
try {
if (runtime.provider === "local-simulator") runner(runtime.platform === "ios"
? { command: "xcrun", args: ["simctl", "terminate", runtime.controllerDeviceId, capture.bundleId], cwd: store.root, environment: options.environment, timeoutMs: 60_000, allowFailure: true }
: { command: androidTools(options.environment).adb, args: ["-s", runtime.controllerDeviceId, "shell", "am", "force-stop", capture.bundleId],
cwd: store.root, environment: options.environment, timeoutMs: 60_000, allowFailure: true });
for (const key of Object.keys(readRecovery)) delete (readRecovery as Record<string, unknown>)[key];
readRecovery.busyAttempts = 0;
controller(["open", capture.bundleId, "--relaunch", "--level", "full", "--json"]);
settle();
snapshot();
} catch { record(false); return false; }
record(true);
return true;
};
const recoverFromControllerFault = (error: unknown): boolean => {
if (!transientControllerFault(error) || deadline - clock() < 30_000) return false;
const reported = serializeCiError(toCiError(error), { secrets });
@@ -965,6 +1046,14 @@ export async function capturePlannedRoutes(options: {
fault: reported.message, at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
return true;
};
/**
* A setup step that wedged the controller or left the app has not run, nor have the steps after it (a login, seeded
* data, a permission), so routes opened by app link may show the wrong state. Once the app is restarted, setup runs
* again from the start, once. When it stops the same way again, the routes go on by app link (so one covered control
* does not fail the whole capture), and each route captured afterwards says in its outcome that setup did not complete.
*/
let setupRerunAfterRecovery = false;
let setupIncomplete: string | undefined;
for (let setupAttempt = 0; ; setupAttempt += 1) try {
await executeCaptureSetup((capture.setup ?? []).map(action => action.action === "fill" || action.action === "type" ? { ...action, text: inputs.resolve(action.text) } : action), {
command: args => { controllerApp(); return controller(args); },
@@ -996,6 +1085,19 @@ export async function capturePlannedRoutes(options: {
break;
} catch (error) {
if (setupAttempt === 0 && recoverFromControllerFault(error)) continue;
// A wedged controller says nothing about the app's state: the routes the steps before it prepared are captured or
// failed on their own. Once the controller answers again, setup runs again from the start, once.
if ((controllerWedged(error) || appLeft(error)) && recoverController("a setup step", error, setupRerunAfterRecovery ? "setup-incomplete" : "setup-rerun")) {
const reported = serializeCiError(toCiError(error), { secrets });
if (!setupRerunAfterRecovery) {
setupRerunAfterRecovery = true;
say(`setup stopped (${reported.code}); running setup again from the start`);
continue;
}
setupIncomplete = `Setup did not complete: a setup step stopped twice (${reported.code}), so this route was opened by app link without the state the remaining setup steps prepare.`;
say(`setup stopped again (${reported.code}); setup did not complete, and the routes it had not reached go on by app link marked as such`);
break;
}
const failure = toCiError(error, { code: "SETUP_FAILED", stage: "setup" });
const diagnostics: Record<string, string> = {};
const directory = join(store.root, "capture-diagnostics");
@@ -1051,14 +1153,18 @@ export async function capturePlannedRoutes(options: {
const linked = options.routes.filter(route => !(outcomes[route.id]?.status === "captured" && !setupFailure) && !(prepared.has(route.id) && outcomes[route.id]?.status !== "captured"));
let opened = 0;
/**
* Opens the app's root link and lets it settle, so the route link that follows starts from the
* app's home rather than from the sheet, modal or list the previous link left on screen. The
* OS may ask to confirm the root link too; that confirmation is answered here so the route's
* own poll never mistakes it for its own.
* Opens the app's root link, so the route link that follows starts from the app's home rather than from the sheet,
* modal or list the previous link left on screen. The first attempt only opens it: the route's own readiness poll
* checks where its link landed and answers a confirmation the OS asks for. A route that landed wrong is retried
* after a full reset, which lets the root settle and answers the root link's own confirmation first.
*/
const resetToRoot = () => {
const resetToRoot = (full: boolean) => {
controller(["open", capture.bundleId, rootLink!, "--level", "full", "--json"]);
// The root link closes what the last route presented; the next link waits until that has finished. A link that lands
// while a sheet is still being dismissed can leave the app unable to present another sheet until it is relaunched
// (seen on iOS: euxy's share link, opened right after its share sheet, never showed its own).
settle();
if (!full) return;
if (snapshot().nodes.some(node => node.type === "Alert")) {
resolveDeepLinkConfirmation();
settle();
@@ -1093,10 +1199,12 @@ export async function capturePlannedRoutes(options: {
try {
// Every route link starts from the app's home, not from what the previous link left on
// screen; the app keeps running, since relaunching invalidates photo and translation prerequisites.
if (rootLink && deepLink !== rootLink) resetToRoot();
if (rootLink && deepLink !== rootLink) resetToRoot(attempt > 1);
const opened = controller(["open", capture.bundleId, deepLink, "--level", "full", "--json"]);
const device = openedSimulatorDevice(opened.stdout, capture.bundleId, "capture open", runtime.platform);
if (device.deviceId !== runtime.controllerDeviceId || device.deviceModel !== runtime.deviceModel) throw captureError("CONTROLLER_IDENTITY_MISMATCH", "The controller changed the selected device.");
// A local simulator is named for Explore and recorded as the model it was created as; its UDID identifies it.
if (device.deviceId !== runtime.controllerDeviceId
|| (runtime.provider !== "local-simulator" && device.deviceModel !== runtime.deviceModel)) throw captureError("CONTROLLER_IDENTITY_MISMATCH", "The controller changed the selected device.");
// The open response already proved the controller's device and app; the capture asserts the
// session again after its screenshot, and resolves a link confirmation only if the snapshot calls for it.
readiness = { startedAt: clock(), budgetMs: readinessBudgetMs(attempt), attempt };
@@ -1104,7 +1212,26 @@ export async function capturePlannedRoutes(options: {
await captureCurrent(route, attempt);
break;
} catch (error) {
// The emulator's adb connection dropped (a local one does once, early, under load) or the daemon was unreachable:
// that says nothing about this route. Once the device answers again, the route opens again from the app's root.
if (attempt === 1 && transientControllerFault(error) && deadline - clock() > 30_000) {
let answered = true;
try { controllerApp(); } catch { answered = false; }
if (answered) {
const diagnostics = join(store.root, "capture-diagnostics");
mkdirSync(diagnostics, { recursive: true, mode: 0o700 });
appendFileSync(join(diagnostics, "controller-retries.jsonl"), `${JSON.stringify({ command: "open", route: route.route, reason: "route-reopened-after-device-lost",
fault: serializeCiError(toCiError(error), { secrets }).message, at: new Date(clock()).toISOString() })}\n`, { mode: 0o600 });
continue;
}
}
const failure = failedOutcome(error, attempt);
// A wedged controller costs this route only: once its retries are spent, the next route starts on a restarted app.
if (controllerWedged(error) && (attempt === 2 || !failure.error?.retryable)) {
outcomes[route.id] = { ...failure, reason: "The device controller stopped answering on this screen; Explore restarted the app and went on with the next route." };
recoverController(route.route, error);
break;
}
if (failure.status === "budget-exhausted" || !failure.error?.retryable || attempt === 2) {
outcomes[route.id] = failure;
if (attempt === 2) await captureUnattributed(route, attempt, error);
@@ -1112,6 +1239,8 @@ export async function capturePlannedRoutes(options: {
}
}
}
const outcome = outcomes[route.id];
if (setupIncomplete && outcome?.status === "captured") outcomes[route.id] = { ...outcome, reason: outcome.reason ? `${outcome.reason} ${setupIncomplete}` : setupIncomplete };
reportOutcome(route, "by app link");
}
return outcomes;
+372 -99
View File
@@ -1,4 +1,4 @@
import { appearanceArgs, bundleColorSchemes, mergeSchemeOutcomes, resolveColorSchemes, routeIdOfScreen, type AppearanceSetting, type ColorScheme } from "./appearance.js";
import { appearanceArgs, argentColorSchemes, bundleColorSchemes, mergeSchemeOutcomes, resolveColorSchemes, routeIdOfScreen, type AppearanceSetting, type ColorScheme } from "./appearance.js";
import { assertNoCaptureHealthIssues, captureHealthIssues, partitionCaptureHealthIssues } from "./health.js";
import { type RouteResetSetting } from "./route-reset.js";
import { defaultReadinessSeconds } from "./readiness.js";
@@ -14,15 +14,22 @@ import type { SourceCapturePlan } from "../source/capture-plan.js";
import { CONTRACT, type ExploreMap, type Platform, type RunStatus } from "../types.js";
import { ExploreStore, validateMap } from "../map/store.js";
import { CiError, serializeCiError, toCiError } from "../shared/ci-errors.js";
import type { CaptureSetupAction } from "../config/explore-config.js";
import type { CaptureSetupAction, DevicePose } from "../config/explore-config.js";
import { type CiAgentRuntimeOptions } from "./agent/runtime.js";
import { EAS_CLI_VERSION, AGENT_DEVICE_VERSION, CONTROLLER_SESSION, isRecord, parseJson, baseEnvironment, nonEmpty } from "./common.js";
import { EAS_CLI_VERSION, CONTROLLER_SESSION, isRecord, parseJson, baseEnvironment, nonEmpty } from "./common.js";
import { lstatIfExists, isWithin, temporaryCaptureDirectory, absoluteContractFile, readContractJson, assertNoSymlinkAncestors } from "./fs-safety.js";
import { loadAppIcon, loadCachedAppIcon, storeAppIcon } from "./app-icon.js";
import { defaultRunner } from "./controller.js";
import { defaultRunner, runAgentControllerCommand } from "./controller.js";
import { silentProgress, type Progress } from "../shared/progress.js";
import { assertCaptureEasProfile, assertSimulatorAvailable, fingerprintFrom, hasEasEnvironmentFetchFailure, nativeBuildFrom, existingBuild, repackProfileFrom, prepareExactSourceBuild, type RepackMode } from "./eas-build.js";
import { SIMULATOR_DOTENV_FILE_NAME, SIMULATOR_DOTENV_HEADER, simulatorSessionName, simulatorStartFailure, readSimulatorDotenvHandoff, assertSimulatorSessionIdentity, assertSimulatorStopped, collectRuntime, simulatorOsVersion, type ActiveSimulatorRuntime } from "./simulator.js";
import { SIMULATOR_DOTENV_FILE_NAME, SIMULATOR_DOTENV_HEADER, simulatorSessionName, simulatorStartFailure, readSimulatorDotenvHandoff, assertSimulatorSessionIdentity, assertSimulatorStopped, collectRuntime, controllerVersion, simulatorOsVersion, type ActiveSimulatorRuntime, type SimulatorConnection } from "./simulator.js";
import { argentControllerInvocation } from "./controller-invocation.js";
import { sharedBuild } from "./shared-build.js";
import { LOCAL_EMULATOR_STATE_PREFIX, LOCAL_SIMULATOR_STATE_PREFIX, assertLocalEmulatorCompatible, createLocalSimulator, startLocalEmulator, waitForLocalEmulator, waitForLocalSimulator, deleteLocalEmulator,
deleteLocalSimulator, hostEmulatorAbi, installOnLocalEmulator, installOnLocalSimulator, approveLinkScheme, localPoseShown,
setLocalEmulatorAppearance, setLocalSimulatorAppearance, startLocalArgentServer, stopLocalAgentDevice, stopLocalArgentServer, type LocalArgentServer } from "./local-simulator.js";
import { ensureArgentToolServer } from "../shared/controller-cache.js";
import { openLocalCaptureRecord } from "./local-registry.js";
import { type UnattributedSetting } from "./unattributed.js";
import { appScheme, hasConcreteRoutePath, unavailableRoute, capturePlannedRoutes, deviceArgs } from "./route-capture.js";
@@ -51,8 +58,16 @@ export type CiMapOptions = {
/** Host-side pause used while a controller read is resent; tests pair it with `now` so recovery waits are not real time. */
sleep?: (milliseconds: number) => void;
easCommand: string; repackCommand: string; agentDeviceCommand: string;
/** The device controller EAS starts on the session; agent-device unless the config chose Argent. */
controller?: "agent-device" | "argent";
/** A foldable's pose (device.pose), set with the controller's `fold` before anything is captured. */
devicePose?: DevicePose;
/** Where the app runs: an EAS Simulator session (default), or a simulator created on this Mac for the capture. */
simulator?: "eas" | "local";
/** Where the route observer is bundled into the app: a hosted EAS repack job (default) or repack-app on this machine. */
repack?: RepackMode;
/** A folder the review's captures share builds through: targets of one platform, profile and commit build and repack once. */
buildShare?: string;
/** Which appearances to capture; `auto` (default) follows the app's `userInterfaceStyle`. */
appearance?: AppearanceSetting;
/** Whether to observe the app launch (splash screen) per appearance; `video` also keeps the recording. Defaults to `off`. */
@@ -69,7 +84,7 @@ export type CiMapOptions = {
signal?: AbortSignal;
};
export type SimulatorRuntimeMetadata = {
provider: "eas-simulator"; controller: "agent-device"; controllerPackageVersion: string;
provider: "eas-simulator" | "local-simulator"; controller: "agent-device" | "argent"; controllerPackageVersion: string;
easCliVersion: string; platform: Platform; deviceModel: string; osVersion: string; locale: string;
orientation: "portrait" | "landscape"; colorScheme: "light" | "dark" | "system"; colorSchemes?: ColorScheme[];
sessionLifecycle: "stopped";
@@ -83,6 +98,25 @@ export type CiMapResult = {
};
function parseJsonOrUndefined(text: string): unknown {
try { return JSON.parse(text); } catch { return undefined; }
}
/**
* Minutes an EAS session is asked for beyond the capture's own budget. The session starts beside the repack, and the
* capture deadline only starts once the app is installed, so the session also has to outlast a slow or queued hosted
* repack, the app's upload and its install; 20 minutes covers a typical repack with room for a queue.
*/
const SESSION_PREPARATION_MINUTES = 20;
/**
* EAS refuses (before allocating anything) a session longer than the plan allows, naming that maximum. Only that exact
* rejection is recognized; any other start failure is kept as it is.
*/
function sessionDurationLimit(error: unknown): number | undefined {
const match = /max duration must not exceed (\d+(?:\.\d+)?) minutes/i.exec(error instanceof Error ? error.message : String(error));
return match ? Math.floor(Number(match[1])) : undefined;
}
function positiveInteger(value: number, name: string): number {
if (!Number.isInteger(value) || value <= 0) {
throw new Error(`${name} must be a positive integer`);
@@ -94,7 +128,7 @@ function newCaptureMap(options: CiMapOptions, runtime?: ActiveSimulatorRuntime,
const timestamp = new Date((options.now ?? Date.now)()).toISOString();
return {
contract: CONTRACT, revision: 0,
run: { id: options.buildId, name: options.name, platform: options.platform, controller: "agent-device", status: "draft",
run: { id: options.buildId, name: options.name, platform: options.platform, controller: options.controller ?? "agent-device", status: "draft",
bundleId: options.bundleId, ...(runtime ? { deviceId: runtime.controllerDeviceId } : {}),
createdAt: timestamp, updatedAt: timestamp,
build: { id: options.buildId, version: options.buildVersion, gitCommit: options.gitCommit, source: "eas", ...(fingerprint ? { hash: fingerprint } : {}) },
@@ -163,6 +197,8 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
const setup = revisionSetup(options.setup ?? [], plan, side);
const runner = options.runner ?? defaultRunner;
const sourceEnvironment = options.environment ?? process.env;
const controller = options.controller ?? "agent-device";
const local = options.simulator === "local";
const restrictedEnvironment = baseEnvironment(sourceEnvironment);
const easEnvironment = { ...restrictedEnvironment, ...(options.expoToken ? { EXPO_TOKEN: options.expoToken } : {}) };
const assertCheckout = () => {
@@ -279,7 +315,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
app = { name: cachedBundle.appName ?? options.name };
appIcon = await loadCachedAppIcon(cacheRoot, cachedBundle.appIcon);
const cachedProfile = cachedBundle.runtimeProfile!;
runtime = { provider: "eas-simulator", controller: "agent-device", controllerPackageVersion: AGENT_DEVICE_VERSION,
runtime = { provider: local ? "local-simulator" : "eas-simulator", controller, controllerPackageVersion: controllerVersion(controller),
easCliVersion: EAS_CLI_VERSION, platform: options.platform, controllerDeviceId: cachedDeviceId ?? "cached",
deviceModel: cachedProfile.deviceModel, osVersion: cachedProfile.osVersion, locale: cachedProfile.locale,
orientation: cachedProfile.orientation === "landscape" ? "landscape" : "portrait",
@@ -305,7 +341,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
const errors = await validateMap(map, store);
if (errors.length) throw new Error(`Captured map failed validation: ${errors.join("; ")}`);
await store.exportTo(outputDirectory, map);
for (const name of ["setup-accessibility.json", "setup-screen.png", "agent-navigation.jsonl", "alert-inspection.jsonl", "accessibility-deferral.jsonl", "system-prompts.jsonl", "controller-retries.jsonl"]) {
for (const name of ["setup-accessibility.json", "setup-screen.png", "agent-navigation.jsonl", "alert-inspection.jsonl", "accessibility-deferral.jsonl", "system-prompts.jsonl", "controller-retries.jsonl", "controller-recoveries.jsonl"]) {
const source = join(mapDirectory, "capture-diagnostics", name);
if (!(await lstatIfExists(source))) continue;
await assertNoSymlinkAncestors(mapDirectory, source, "setup diagnostic");
@@ -313,6 +349,9 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
await copyFile(source, join(outputDirectory, "capture-diagnostics", name));
}
const images: CaptureBundle["images"] = {};
// The build a frame came from: the repacked app's EAS build, or for a repack on this machine, which is never
// uploaded, the native EAS build it repacked. The bundle names it too, as the review's build.
const frameBuildId = easBuildId ?? nativeEasBuildId;
for (const observation of map.observations) {
// A secondary-appearance screen (`<route>@<scheme>`) exports under its route's outcome, with its own frame, or
// under its own outcome when the primary pass lost the route and this pass captured it.
@@ -320,13 +359,13 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
const owner = (scheme && outcomes[observation.screenId]) || outcomes[routeId];
if (!selected.has(routeId) || owner?.status !== "captured") continue;
const artifact = map.artifacts.find(value => value.id === observation.screenshotArtifactId);
if (!artifact || (!easBuildId && !cachedImages[observation.screenId])) continue;
if (!artifact || (!frameBuildId && !cachedImages[observation.screenId])) continue;
const png = await readFile(join(outputDirectory, artifact.path));
assertDecodedPng(png, "Exported capture image");
const expectedSha256 = scheme ? artifact.sha256 : outcomes[routeId]?.screenshotSha256;
if (createHash("sha256").update(png).digest("hex") !== expectedSha256) throw new Error("Exported screenshot does not match the captured frame");
images[observation.screenId] = cachedImages[observation.screenId] ?? { path: artifact.path, sha256: artifact.sha256, width: png.readUInt32BE(16), height: png.readUInt32BE(20),
capturedAt: observation.capturedAt, sourceCommit: options.gitCommit, buildId: easBuildId! };
capturedAt: observation.capturedAt, sourceCommit: options.gitCommit, buildId: frameBuildId! };
}
const metadata: SimulatorRuntimeMetadata | null = runtime ? { provider: runtime.provider, controller: runtime.controller,
controllerPackageVersion: runtime.controllerPackageVersion, easCliVersion: runtime.easCliVersion, platform: runtime.platform,
@@ -348,8 +387,8 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
}
await rm(launchWorkDirectory, { recursive: true, force: true });
const storedIcon = appIcon ? await storeAppIcon(outputDirectory, appIcon) : undefined;
const bundle: CaptureBundle = { contract: "explore.bundle", side, gitCommit: options.gitCommit, easBuildId, completedAt: map.run.completedAt,
easProjectId: projectId, platform: options.platform, profile: options.easProfile, appName: app.name, ...(storedIcon ? { appIcon: storedIcon } : {}),
const bundle: CaptureBundle = { contract: "explore.bundle", side, gitCommit: options.gitCommit, easBuildId: frameBuildId, completedAt: map.run.completedAt,
easProjectId: projectId, platform: options.platform, profile: options.easProfile, appName: app.name, ...(controller === "argent" ? { controller } : {}), ...(storedIcon ? { appIcon: storedIcon } : {}),
selectedSurfaceIds: selectedIds,
runtimeProfile: metadata ? { deviceModel: metadata.deviceModel, osVersion: metadata.osVersion, locale: metadata.locale,
orientation: metadata.orientation, colorScheme: metadata.colorScheme, ...(metadata.colorSchemes ? { colorSchemes: metadata.colorSchemes.join(",") } : {}) } : null, images, outcomes, procedure: { reset: options.reset ?? "root-link", readinessSeconds: options.readinessSeconds ?? defaultReadinessSeconds(options.platform) },
@@ -381,6 +420,12 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
const configValue = parseJson(configResult.stdout, "eas config") as { appConfig: Record<string, unknown>; buildProfile: Record<string, unknown> };
scheme ??= appScheme(configValue.appConfig.scheme);
colorSchemes = resolveColorSchemes(options.appearance ?? "auto", configValue.appConfig, options.platform);
// Argent cannot switch the appearance itself; on a local device the host switches it (simctl, adb), so it is kept.
if (controller === "argent" && !local) {
const single = argentColorSchemes(colorSchemes, configValue.appConfig, options.platform);
if (single.skipped.length) say(`Argent cannot switch appearance yet (software-mansion/argent#1509); capturing ${single.schemes[0]} only, skipped ${single.skipped.join(", ")}`);
colorSchemes = single.schemes;
}
app = { name: profile.projectIdentity.name, ...(profile.projectIdentity.version ? { version: profile.projectIdentity.version } : {}),
...(profile.projectIdentity.buildNumber ? { buildNumber: profile.projectIdentity.buildNumber } : {}) };
projectId = profile.projectIdentity.projectId;
@@ -390,45 +435,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
return finish();
}
assertCaptureEasProfile(configValue, options.bundleId, options.platform, { side, commit: options.gitCommit });
assertSimulatorAvailable(eas(["simulator:availability", "--json", "--non-interactive"]).stdout);
setStage("build");
// Historical frames do not replace the fresh build needed for missing targets.
easBuildId = null;
options.signal?.throwIfAborted();
say("computing the native fingerprint");
const fingerprintResult = eas(["fingerprint:generate", "--platform", options.platform, "--build-profile", options.easProfile, "--json", "--non-interactive"]);
fingerprint = fingerprintFrom(fingerprintResult.stdout);
const reusable = options.forceFreshBuild || hasEasEnvironmentFetchFailure(configResult.stderr) || hasEasEnvironmentFetchFailure(fingerprintResult.stderr)
? undefined : existingBuild(eas(["build:list", "--platform", options.platform, "--status", "finished", "--build-profile", options.easProfile,
"--fingerprint-hash", fingerprint, ...(options.platform === "ios" ? ["--simulator"] : []), "--limit", "1", "--json", "--non-interactive"]).stdout);
if (reusable) {
say(`reusing EAS build ${reusable.id} (fingerprint ${fingerprint.slice(0, 12)}); repacking it with this commit's JavaScript and the route observer`);
const repacked = await prepareExactSourceBuild({ platform: options.platform, runner, easCommand: options.easCommand, repackCommand: options.repackCommand,
project, nativeBuildId: reusable.id, fingerprint, repackProfile: profile, easEnvironment, repackEnvironment: restrictedEnvironment, routes: inventory, repack: options.repack, easProfile: options.easProfile });
if (!repacked) throw new CiError({ code: "CAPTURE_OBSERVER_BUILD_UNSUPPORTED", stage: "instrumentation",
message: "The build environment cannot be reproduced for automatic capture instrumentation.",
nextAction: "Use a simulator build profile whose required bundle environment can be pulled for local repacking; an uninstrumented build cannot verify captures." });
if (repacked) { nativeEasBuildId = reusable.id; easBuildId = repacked; reusedEasBuild = true; }
if (!app.version && reusable.appVersion) app.version = reusable.appVersion;
if (!app.buildNumber && reusable.appBuildVersion) app.buildNumber = reusable.appBuildVersion;
}
options.signal?.throwIfAborted();
if (!easBuildId) {
say(options.forceFreshBuild ? "building on EAS (a fresh build was requested); waiting for it to finish"
: `no finished simulator build has fingerprint ${fingerprint.slice(0, 12)}; building on EAS and waiting for it to finish`);
const built = nativeBuildFrom(eas(["build", "--platform", options.platform, "--profile", options.easProfile, "--wait", "--json", "--non-interactive"], 45 * 60_000).stdout);
nativeEasBuildId = built.id; fingerprint = built.fingerprint;
say(`EAS build ${built.id} finished; repacking it with the route observer`);
const repacked = await prepareExactSourceBuild({ platform: options.platform, runner, easCommand: options.easCommand, repackCommand: options.repackCommand,
project, nativeBuildId: built.id, fingerprint, repackProfile: profile, easEnvironment, repackEnvironment: restrictedEnvironment, routes: inventory, repack: options.repack, easProfile: options.easProfile });
if (!repacked) throw new CiError({ code: "CAPTURE_OBSERVER_BUILD_UNSUPPORTED", stage: "instrumentation",
message: "The fresh native build cannot be instrumented with the required route observer.",
nextAction: "Use a simulator profile with a reproducible bundle environment so both revisions can be repacked with the same observer." });
easBuildId = repacked;
if (!app.version && built.appVersion) app.version = built.appVersion;
if (!app.buildNumber && built.appBuildVersion) app.buildNumber = built.appBuildVersion;
}
options.signal?.throwIfAborted();
if (!local) assertSimulatorAvailable(eas(["simulator:availability", "--json", "--non-interactive"]).stdout);
const simulatorProject = await realpath(await mkdtemp(join(tmpdir(), "expo-explore-session-")));
const dotenvPath = join(simulatorProject, SIMULATOR_DOTENV_FILE_NAME);
const statePath = options.sessionStatePath ? absoluteContractFile(options.sessionStatePath, "sessionStatePath") : undefined;
@@ -436,59 +443,287 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
await writeFile(join(simulatorProject, "app.json"), JSON.stringify({ expo: { name: profile.projectIdentity.name, slug: profile.projectIdentity.slug,
owner: profile.projectIdentity.owner, extra: { eas: { projectId } } } }), { mode: 0o600 });
await writeFile(join(simulatorProject, "package.json"), "{}\n", { mode: 0o600 });
const sessionName = simulatorSessionName({ mapName: options.name, mapId: options.buildId, gitCommit: options.gitCommit, easBuildId,
// The local simulator's UDID (iOS) or emulator's adb serial (Android): what agent-device is pointed at.
let localSimulator: string | undefined;
let localEmulator: string | undefined;
let localOsVersion: string | undefined;
// Argent's tool-server on this machine, when Argent drives a local device.
let localArgent: LocalArgentServer | undefined;
const localDevice = () => localSimulator ?? localEmulator;
// A local device starts booting now and finishes while the app is built and repacked; the session waits for it.
let localEmulatorStart: Awaited<ReturnType<typeof startLocalEmulator>> | undefined;
const localName = `Explore ${options.device} (${side} ${options.gitCommit.slice(0, 8)})`;
// An EAS session's start, once begun (startSession): it resolves with the start command's failure, if any.
let sessionStart: Promise<unknown> | undefined;
const stopEarlyDevice = async () => {
// An EAS session started beside a repack that then failed: stop the exact session its handoff names.
if (sessionStart) {
await sessionStart;
const handoff = await readSimulatorDotenvHandoff(dotenvPath).catch(() => undefined);
if (handoff?.sessionId) assertSimulatorStopped(eas(["simulator:stop", "--id", handoff.sessionId, "--json", "--non-interactive"], 2 * 60_000, simulatorProject).stdout, handoff.sessionId);
}
if (localSimulator) deleteLocalSimulator({ runner, udid: localSimulator, cwd: simulatorProject, environment: restrictedEnvironment });
if (localEmulator) await deleteLocalEmulator({ runner, serial: localEmulator, cwd: simulatorProject, environment: restrictedEnvironment });
if (statePath) await rm(statePath, { force: true });
await rm(simulatorProject, { recursive: true, force: true });
await localRecord?.close();
};
// What this side starts on this machine, so a later review cleans up after it if this process is stopped hard.
const localRecord = local ? await openLocalCaptureRecord(sourceEnvironment, simulatorProject) : undefined;
if (local) try {
if (options.platform === "android") {
say(`starting a local ${options.device} emulator`);
localEmulatorStart = await startLocalEmulator({ runner, device: options.device, name: `explore-${side}-${options.gitCommit.slice(0, 8)}`, directory: simulatorProject,
cwd: simulatorProject, environment: restrictedEnvironment,
// agent-device refuses a serial an interrupted run still claims, even one it reports as stale, so that port is skipped.
...(controller === "agent-device" ? { claimed: (serial: string) => {
const status = runner({ command: options.agentDeviceCommand, args: ["device", "status", "--platform", "android", "--serial", serial, "--json"],
cwd: simulatorProject, environment: restrictedEnvironment, timeoutMs: 30_000, allowFailure: true });
const data = (parseJsonOrUndefined(status.stdout) as { data?: { claims?: unknown[]; hiddenStaleClaims?: number } } | undefined)?.data;
return (data?.claims?.length ?? 0) + (data?.hiddenStaleClaims ?? 0) > 0;
} } : {}),
// Recorded as soon as it starts, so an interrupted review stops it too.
started: async serial => {
localEmulator = serial;
await localRecord?.update({ serial, avd: `explore-${side}-${options.gitCommit.slice(0, 8)}` });
if (statePath) await writeFile(statePath, `${LOCAL_EMULATOR_STATE_PREFIX}${serial}\n`, { flag: "wx", mode: 0o600 });
} });
} else {
say(`starting a local ${options.device} simulator`);
const created = await createLocalSimulator({ runner, device: options.device, name: localName, cwd: simulatorProject, environment: restrictedEnvironment,
// Recorded before it boots, so an interrupted review deletes it too.
created: async udid => {
localSimulator = udid;
await localRecord?.update({ udid });
if (statePath) await writeFile(statePath, `${LOCAL_SIMULATOR_STATE_PREFIX}${udid}\n`, { flag: "wx", mode: 0o600 });
} });
localOsVersion = created.osVersion;
}
} catch (error) { await stopEarlyDevice().catch(() => undefined); throw error; }
// The session is named before its app exists: an EAS session starts while the app is repacked (startSession).
const sessionName = simulatorSessionName({ mapName: options.name, mapId: options.buildId, gitCommit: options.gitCommit, easBuildId: local ? "local" : "installed",
runIdentity: JSON.stringify({ mapDirectory, outputDirectory, run: sourceEnvironment.GITHUB_RUN_ID, attempt: sourceEnvironment.GITHUB_RUN_ATTEMPT }) });
/**
* Starts the EAS Simulator session in the background, empty, once the build to repack is known (not while a native
* build runs, which can take most of an hour of session time). The app is installed through the controller when both
* are ready. Resolves with the start command's failure, if any; the session block verifies what EAS handed over.
*/
const startSession = () => {
if (local || sessionStart) return;
say(`starting an EAS Simulator session (${options.device}) while the app is repacked`);
const request = (minutes: number) => ({ command: options.easCommand, args: ["simulator:start", "--name", sessionName, "--platform", options.platform, "--device", options.device,
"--type", controller, "--package-version", controllerVersion(controller), "--public-link",
"--max-duration-minutes", String(minutes), "--out-config-type", "dotenv", "--non-interactive"], cwd: simulatorProject, environment: easEnvironment, timeoutMs: 20 * 60_000 });
// An injected runner (tests) answers synchronously; a real start runs beside the repack.
const start = async (minutes: number) => options.runner ? options.runner(request(minutes)) : runAgentControllerCommand(request(minutes), options.signal ?? new AbortController().signal);
sessionStart = writeFile(dotenvPath, SIMULATOR_DOTENV_HEADER, { flag: "wx", mode: 0o600 })
.then(() => start(options.maxDurationMinutes + SESSION_PREPARATION_MINUTES).catch(async (error: unknown) => {
// A plan that cannot give the allowance gets as much of it as the plan allows, and never less than the capture's own minutes.
const limit = sessionDurationLimit(error);
if (limit === undefined) throw error;
say(`EAS allows ${limit}-minute sessions on this plan; starting the session again without the full repack allowance`);
return start(Math.max(options.maxDurationMinutes, limit));
}))
.then(() => undefined, (error: unknown) => error);
};
setStage("build");
// The instrumented app stays on this machine: a local device installs it, and an EAS session gets it through the
// controller. It goes in this capture's own directory, or in the review's shared build folder when other targets use it.
const appName = options.platform === "android" ? "app.apk" : "app.app";
const appDirectory = !options.buildShare ? await realpath(await mkdtemp(join(tmpdir(), "expo-explore-app-"))) : undefined;
let localApp: string | undefined;
type BuiltApp = { fingerprint: string; nativeEasBuildId: string | null; easBuildId: string | null; app?: string; reused: boolean; version?: string; buildNumber?: string };
const buildApp = async (keepApp: string): Promise<BuiltApp> => {
options.signal?.throwIfAborted();
say("computing the native fingerprint");
const fingerprintResult = eas(["fingerprint:generate", "--platform", options.platform, "--build-profile", options.easProfile, "--json", "--non-interactive"]);
const sourceFingerprint = fingerprintFrom(fingerprintResult.stdout);
const reusable = options.forceFreshBuild || hasEasEnvironmentFetchFailure(configResult.stderr) || hasEasEnvironmentFetchFailure(fingerprintResult.stderr)
? undefined : existingBuild(eas(["build:list", "--platform", options.platform, "--status", "finished", "--build-profile", options.easProfile,
"--fingerprint-hash", sourceFingerprint, ...(options.platform === "ios" ? ["--simulator"] : []), "--limit", "1", "--json", "--non-interactive"]).stdout);
if (reusable) {
say(`reusing EAS build ${reusable.id} (fingerprint ${sourceFingerprint.slice(0, 12)}); repacking it with this commit's JavaScript and the route observer`);
startSession();
const repacked = await prepareExactSourceBuild({ platform: options.platform, runner, easCommand: options.easCommand, repackCommand: options.repackCommand,
project, nativeBuildId: reusable.id, fingerprint: sourceFingerprint, repackProfile: profile, easEnvironment, repackEnvironment: restrictedEnvironment, routes: inventory, repack: options.repack, easProfile: options.easProfile, keepApp });
if (!repacked) throw new CiError({ code: "CAPTURE_OBSERVER_BUILD_UNSUPPORTED", stage: "instrumentation",
message: "The build environment cannot be reproduced for automatic capture instrumentation.",
nextAction: "Use a simulator build profile whose required bundle environment can be pulled for local repacking; an uninstrumented build cannot verify captures." });
return { fingerprint: sourceFingerprint, nativeEasBuildId: reusable.id, easBuildId: repacked.buildId, ...(repacked.app ? { app: repacked.app } : {}), reused: true,
...(reusable.appVersion ? { version: reusable.appVersion } : {}), ...(reusable.appBuildVersion ? { buildNumber: reusable.appBuildVersion } : {}) };
}
options.signal?.throwIfAborted();
say(options.forceFreshBuild ? "building on EAS (a fresh build was requested); waiting for it to finish"
: `no finished simulator build has fingerprint ${sourceFingerprint.slice(0, 12)}; building on EAS and waiting for it to finish`);
const built = nativeBuildFrom(eas(["build", "--platform", options.platform, "--profile", options.easProfile, "--wait", "--json", "--non-interactive"], 45 * 60_000).stdout);
say(`EAS build ${built.id} finished; repacking it with the route observer`);
startSession();
const repacked = await prepareExactSourceBuild({ platform: options.platform, runner, easCommand: options.easCommand, repackCommand: options.repackCommand,
project, nativeBuildId: built.id, fingerprint: built.fingerprint, repackProfile: profile, easEnvironment, repackEnvironment: restrictedEnvironment, routes: inventory, repack: options.repack, easProfile: options.easProfile, keepApp });
if (!repacked) throw new CiError({ code: "CAPTURE_OBSERVER_BUILD_UNSUPPORTED", stage: "instrumentation",
message: "The fresh native build cannot be instrumented with the required route observer.",
nextAction: "Use a simulator profile with a reproducible bundle environment so both revisions can be repacked with the same observer." });
return { fingerprint: built.fingerprint, nativeEasBuildId: built.id, easBuildId: repacked.buildId, ...(repacked.app ? { app: repacked.app } : {}), reused: false,
...(built.appVersion ? { version: built.appVersion } : {}), ...(built.appBuildVersion ? { buildNumber: built.appBuildVersion } : {}) };
};
try {
// Historical frames do not replace the fresh build needed for missing targets.
easBuildId = null;
const built = options.buildShare
? await sharedBuild({ directory: options.buildShare, appName, ...(options.signal ? { signal: options.signal } : {}), build: buildApp, owner: options.outputDirectory,
key: { platform: options.platform, easProfile: options.easProfile, bundleId: options.bundleId, gitCommit: options.gitCommit, repack: options.repack ?? "eas", local,
routes: inventory.map(route => route.id) },
waiting: () => say("using the build another target of this review is preparing for this commit") })
: await buildApp(join(appDirectory!, appName));
// A capture that used another target's build starts its session now.
startSession();
fingerprint = built.fingerprint; nativeEasBuildId = built.nativeEasBuildId; easBuildId = built.easBuildId; localApp = built.app; reusedEasBuild = built.reused;
if (!app.version && built.version) app.version = built.version;
if (!app.buildNumber && built.buildNumber) app.buildNumber = built.buildNumber;
options.signal?.throwIfAborted();
} catch (error) {
// A build or repack that fails leaves nothing running: a device started for it goes, with the session's files and the app.
await stopEarlyDevice().catch(() => undefined);
if (appDirectory) await rm(appDirectory, { recursive: true, force: true });
throw error;
}
let primaryError: unknown;
let runtimeStage = "session";
try {
setStage(runtimeStage);
say(`starting an EAS Simulator session (${options.device}) with build ${easBuildId}`);
await writeFile(dotenvPath, SIMULATOR_DOTENV_HEADER, { flag: "wx", mode: 0o600 });
let startError: unknown;
try { eas(["simulator:start", "--name", sessionName, "--platform", options.platform, "--device", options.device,
"--type", "agent-device", "--package-version", AGENT_DEVICE_VERSION, "--build-id", easBuildId,
"--max-duration-minutes", String(options.maxDurationMinutes), "--out-config-type", "dotenv", "--non-interactive"], 20 * 60_000, simulatorProject); }
catch (error) { startError = error; }
const handoff = await readSimulatorDotenvHandoff(dotenvPath);
const startSecrets = [options.expoToken, ...(handoff.connection ? [handoff.connection.daemonAuthToken] : [])];
const startFailure = startError ? simulatorStartFailure(startError, startSecrets) : undefined;
if (handoff.sessionId) {
try { assertSimulatorSessionIdentity(eas(["simulator:get", "--id", handoff.sessionId, "--json", "--non-interactive"], 2 * 60_000).stdout,
handoff.sessionId, sessionName, profile.projectIdentity, handoff.connection, options.platform); }
catch (error) { throw new CiError({ code: "SESSION_HANDOFF_UNVERIFIED", stage: "session",
message: "The EAS handoff could not prove ownership of the exact simulator session. The private handoff was preserved.",
nextAction: "Inspect the EAS session logs and preserved handoff; confirm ownership before cleaning up the reported session.",
details: { handoffDirectory: simulatorProject, reportedSessionId: handoff.sessionId,
...(startFailure ? { startFailure } : {}), verificationFailure: simulatorStartFailure(error, startSecrets) }, cause: error }); }
sessionId = handoff.sessionId;
if (statePath) await writeFile(statePath, `${sessionId}\n`, { flag: "wx", mode: 0o600 });
let connection: SimulatorConnection | undefined;
if (localApp && localEmulator && localEmulatorStart) {
await assertLocalEmulatorCompatible(localApp, hostEmulatorAbi());
localOsVersion = waitForLocalEmulator({ runner, serial: localEmulator, device: options.device, apiLevel: localEmulatorStart.apiLevel, directory: simulatorProject,
cwd: simulatorProject, environment: restrictedEnvironment, ...(options.now ? { now: options.now } : {}), ...(options.sleep ? { sleep: options.sleep } : {}) });
say(`installing the app on ${localEmulator}`);
installOnLocalEmulator({ runner, serial: localEmulator, apk: localApp, cwd: simulatorProject, environment: restrictedEnvironment });
} else if (localApp && localSimulator) {
waitForLocalSimulator({ runner, udid: localSimulator, cwd: simulatorProject, environment: restrictedEnvironment });
if (scheme) approveLinkScheme({ runner, udid: localSimulator, scheme, bundleId: options.bundleId, cwd: simulatorProject, environment: restrictedEnvironment });
say(`installing the app on ${localName}`);
installOnLocalSimulator({ runner, udid: localSimulator, app: localApp, cwd: simulatorProject, environment: restrictedEnvironment });
} else if (local) {
throw new Error("The local device did not start before capture");
} else {
if (!localApp || !sessionStart) throw new Error("An EAS Simulator session needs the instrumented app on this machine");
const startError = await sessionStart;
const handoff = await readSimulatorDotenvHandoff(dotenvPath);
const startSecrets = [options.expoToken, ...(handoff.connection ? [handoff.connection.daemonAuthToken] : [])];
const startFailure = startError ? simulatorStartFailure(startError, startSecrets) : undefined;
if (handoff.sessionId) {
try { assertSimulatorSessionIdentity(eas(["simulator:get", "--id", handoff.sessionId, "--json", "--non-interactive"], 2 * 60_000).stdout,
handoff.sessionId, sessionName, profile.projectIdentity, handoff.connection, options.platform); }
catch (error) { throw new CiError({ code: "SESSION_HANDOFF_UNVERIFIED", stage: "session",
message: "The EAS handoff could not prove ownership of the exact simulator session. The private handoff was preserved.",
nextAction: "Inspect the EAS session logs and preserved handoff; confirm ownership before cleaning up the reported session.",
details: { handoffDirectory: simulatorProject, reportedSessionId: handoff.sessionId,
...(startFailure ? { startFailure } : {}), verificationFailure: simulatorStartFailure(error, startSecrets) }, cause: error }); }
sessionId = handoff.sessionId;
if (statePath) await writeFile(statePath, `${sessionId}\n`, { flag: "wx", mode: 0o600 });
}
if (!sessionId) throw new CiError({ code: startFailure ? "SIMULATOR_START_FAILED" : "SESSION_HANDOFF_UNVERIFIED", stage: "session",
message: startFailure ? `EAS simulator:start failed before a session identity could be verified: ${startFailure.message}`
: "EAS did not provide an exact verifiable simulator session. The private handoff was preserved.",
nextAction: "Inspect the recorded start failure and EAS session list. Allocation status is unknown; verify a session's exact ID and ownership before cleanup.",
details: { handoffDirectory: simulatorProject, command: "eas simulator:start", startCommandStatus: startFailure ? "failed" : "completed", allocation: "unknown",
...(startFailure ? { startFailure } : {}),
...(handoff.validationError ? { handoffFailure: simulatorStartFailure(handoff.validationError, startSecrets) } : {}) },
cause: startError ?? handoff.validationError });
if (startFailure) throw new CiError({ code: "SIMULATOR_START_FAILED", stage: "session",
message: `EAS simulator:start failed after the session identity was verified: ${startFailure.message}`,
nextAction: "Inspect the recorded start failure; Explore will stop the exact verified session before returning this error.",
details: { reportedSessionId: sessionId, command: "eas simulator:start", startCommandStatus: "failed", allocation: "verified", startFailure }, cause: startError });
if (handoff.validationError) throw handoff.validationError;
if (!handoff.connection) throw new Error("Simulator handoff is missing its controller connection");
connection = handoff.connection;
await rm(dotenvPath, { force: true });
}
if (!sessionId) throw new CiError({ code: startFailure ? "SIMULATOR_START_FAILED" : "SESSION_HANDOFF_UNVERIFIED", stage: "session",
message: startFailure ? `EAS simulator:start failed before a session identity could be verified: ${startFailure.message}`
: "EAS did not provide an exact verifiable simulator session. The private handoff was preserved.",
nextAction: "Inspect the recorded start failure and EAS session list. Allocation status is unknown; verify a session's exact ID and ownership before cleanup.",
details: { handoffDirectory: simulatorProject, command: "eas simulator:start", startCommandStatus: startFailure ? "failed" : "completed", allocation: "unknown",
...(startFailure ? { startFailure } : {}),
...(handoff.validationError ? { handoffFailure: simulatorStartFailure(handoff.validationError, startSecrets) } : {}) },
cause: startError ?? handoff.validationError });
if (startFailure) throw new CiError({ code: "SIMULATOR_START_FAILED", stage: "session",
message: `EAS simulator:start failed after the session identity was verified: ${startFailure.message}`,
nextAction: "Inspect the recorded start failure; Explore will stop the exact verified session before returning this error.",
details: { reportedSessionId: sessionId, command: "eas simulator:start", startCommandStatus: "failed", allocation: "verified", startFailure }, cause: startError });
if (handoff.validationError) throw handoff.validationError;
if (!handoff.connection) throw new Error("Simulator handoff is missing its controller connection");
await rm(dotenvPath, { force: true });
const controllerConfig = join(simulatorProject, "agent-device.json");
await writeFile(controllerConfig, "{}\n", { flag: "wx", mode: 0o400 });
const controllerEnvironment = { ...restrictedEnvironment, AGENT_DEVICE_CONFIG: controllerConfig,
AGENT_DEVICE_DAEMON_BASE_URL: handoff.connection.daemonBaseUrl, AGENT_DEVICE_DAEMON_AUTH_TOKEN: handoff.connection.daemonAuthToken,
if (local && controller === "argent") {
// Argent drives a local device through a tool-server of this capture's own, pointed at that device.
const cli = await ensureArgentToolServer({ environment: sourceEnvironment, progress: say });
localArgent = await startLocalArgentServer({ runner, cli, directory: simulatorProject, cwd: simulatorProject, environment: restrictedEnvironment,
...(options.now ? { now: options.now } : {}), ...(options.sleep ? { sleep: options.sleep } : {}) });
await localRecord?.update({ argent: { pid: localArgent.pid, cli: localArgent.cli, home: localArgent.home } });
connection = { sessionId: `local-${localDevice()}`, daemonBaseUrl: localArgent.url, daemonAuthToken: localArgent.token, controller: "argent" };
}
const argent = controller === "argent" && connection
? await argentControllerInvocation({ directory: simulatorProject, connection, platform: options.platform, environment: restrictedEnvironment, sourceEnvironment, bundleId: options.bundleId,
...(localDevice() ? { device: localDevice()! } : {}), ...(options.devicePose ? { pose: options.devicePose } : {}) })
: undefined;
const controllerEnvironment = argent?.environment ?? { ...restrictedEnvironment, AGENT_DEVICE_CONFIG: controllerConfig,
// Locally, agent-device runs its own daemon, one per capture, so head and base do not share sessions.
...(connection ? { AGENT_DEVICE_DAEMON_BASE_URL: connection.daemonBaseUrl, AGENT_DEVICE_DAEMON_AUTH_TOKEN: connection.daemonAuthToken }
: { AGENT_DEVICE_STATE_DIR: join(simulatorProject, "agent-device-state") }),
AGENT_DEVICE_SESSION: CONTROLLER_SESSION, AGENT_DEVICE_SESSION_LOCK: "reject", AGENT_DEVICE_PLATFORM: options.platform };
// Every controller call below goes to the session's controller; for Argent that is the bridge.
const controllerCommand = argent?.command ?? options.agentDeviceCommand;
if (!local && localApp) {
// The session started empty while the app was repacked; the controller installs it now.
say(`installing the app on session ${sessionId}`);
runner({ command: controllerCommand, args: ["install", localApp, "--session", CONTROLLER_SESSION, ...deviceArgs({ platform: options.platform, deviceModel: options.device }),
"--platform", options.platform, "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 15 * 60_000 });
}
if (options.devicePose) {
// A fold relights the other panel and resizes the window. It comes before the app is first opened or read, so the
// controller's accessibility reader starts on the lit panel: Argent's, started on the outer panel, can stay there.
say(`folding ${options.device} ${options.devicePose}`);
const target = deviceArgs({ platform: options.platform, deviceModel: options.device, ...(localDevice() ? { provider: "local-simulator" as const, controllerDeviceId: localDevice()! } : {}) });
const fold = () => runner({ command: controllerCommand, args: ["fold", options.devicePose!, "--session", CONTROLLER_SESSION, ...target, "--platform", options.platform, "--json"],
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 2 * 60_000, ...(localSimulator ? { allowFailure: true } : {}) });
if (localSimulator && controller === "argent") {
// Argent folds without a session and checks the fold against its own reader; this machine also checks the display.
fold();
if (!await localPoseShown({ runner, udid: localSimulator, pose: options.devicePose, directory: simulatorProject, cwd: simulatorProject, environment: restrictedEnvironment,
...(options.sleep ? { sleep: options.sleep } : {}) })) throw new CiError({ code: "CONTROLLER_FOLD_UNVERIFIED", stage: "session",
message: `${options.device} did not show the ${options.devicePose} display after folding.`, nextAction: "Rerun; if it persists, check that this Xcode's simulator supports folding the device." });
} else if (localSimulator) {
// A local agent-device folds only inside a session, so the app opens first (its first open also builds the
// runner). agent-device then reads the hinge back with a devicectl option Xcode 27.1 no longer has, so on this
// machine the pose is checked by the lit display's shape instead of its answer.
runner({ command: controllerCommand, args: ["open", options.bundleId, "--session", CONTROLLER_SESSION, ...target, "--platform", options.platform, "--json"],
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 15 * 60_000 });
const folded = fold();
if (!await localPoseShown({ runner, udid: localSimulator, pose: options.devicePose, directory: simulatorProject, cwd: simulatorProject, environment: restrictedEnvironment,
...(options.sleep ? { sleep: options.sleep } : {}) })) throw new CiError({ code: "CONTROLLER_FOLD_UNVERIFIED", stage: "session",
message: `${options.device} did not show the ${options.devicePose} display after folding: ${(folded.stderr || folded.stdout).trim().split("\n").at(-1) ?? ""}`.trim(),
nextAction: "Rerun; if it persists, check that this Xcode's simulator supports folding the device." });
} else fold();
}
runtimeStage = "runtime";
setStage(runtimeStage);
runtime = collectRuntime(options, controllerEnvironment);
const localId = localDevice();
const collect = () => collectRuntime({ ...options, agentDeviceCommand: controllerCommand }, controllerEnvironment, localId ? { id: localId } : undefined);
// Argent's accessibility reader can stay on a foldable's dark outer panel after a fold and never read the app
// (APP_NOT_READY). On this machine the capture runs that reader, so it recovers in two steps, each followed by one more
// open: a fresh tool-server, whose reader starts on the lit panel; then, as XcodeBuildMCP#537 found for this panel,
// SpringBoard restarted as well. The bridge's cached view of the device goes with the old server.
for (let recovery = 0; ; recovery += 1) try { runtime = collect(); break; }
catch (error) {
if (!localArgent || recovery === 2 || toCiError(error).code !== "APP_NOT_READY") throw error;
say(recovery === 0 ? "Argent did not read the app after starting it; restarting Argent's tool-server and opening the app again"
: "Argent still did not read the app; restarting SpringBoard and Argent's tool-server and opening the app again");
stopLocalArgentServer(localArgent);
if (recovery === 1 && localSimulator) {
runner({ command: "xcrun", args: ["simctl", "spawn", localSimulator, "launchctl", "kickstart", "-k", "system/com.apple.SpringBoard"],
cwd: simulatorProject, environment: restrictedEnvironment, timeoutMs: 60_000, allowFailure: true });
// SpringBoard takes a moment to come back before an app can be opened over it.
(options.sleep ?? (milliseconds => { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, milliseconds); }))(5_000);
}
localArgent = await startLocalArgentServer({ runner, cli: localArgent.cli, directory: simulatorProject, cwd: simulatorProject, environment: restrictedEnvironment,
...(options.now ? { now: options.now } : {}), ...(options.sleep ? { sleep: options.sleep } : {}) });
await localRecord?.update({ argent: { pid: localArgent.pid, cli: localArgent.cli, home: localArgent.home } });
Object.assign(controllerEnvironment, { ARGENT_TOOLS_URL: localArgent.url, ARGENT_AUTH_TOKEN: localArgent.token });
if (connection) Object.assign(connection, { daemonBaseUrl: localArgent.url, daemonAuthToken: localArgent.token });
await rm(join(simulatorProject, "argent-state.json"), { force: true });
}
runtime.colorScheme = colorSchemes[0]!;
// The version is descriptive; a capture proceeds without it and records "unknown".
try {
// The version is descriptive; a capture proceeds without it and records "unknown". Argent names it with the device;
// agent-device's is always taken from the session, as before.
if (localOsVersion) runtime.osVersion = localOsVersion;
else if (sessionId && (runtime.osVersion === "unknown" || controller !== "argent")) try {
runtime.osVersion = await simulatorOsVersion(eas(["simulator:get", "--id", sessionId, "--json", "--non-interactive"], 2 * 60_000).stdout,
runtime.controllerDeviceId, options.fetch ?? fetch, options.platform);
} catch (error) {
@@ -499,13 +734,17 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
if (colorSchemes.length > 1) { map.run.environment.colorSchemes = [...colorSchemes]; await store.write(map); }
runtimeStage = "capture";
setStage(runtimeStage);
say(`simulator session ${sessionId} is ready (${runtime.deviceModel}, ${options.platform === "ios" ? "iOS" : "Android"} ${runtime.osVersion})`);
say(`${localSimulator ? "local simulator" : localEmulator ? "local emulator" : "simulator session"} ${localDevice() ?? sessionId} is ready (${runtime.deviceModel}, ${options.platform === "ios" ? "iOS" : "Android"} ${runtime.osVersion})`);
// Every pass sets the appearance explicitly, so a capture does not inherit whatever the simulator last used.
const passes: CaptureBundle["outcomes"][] = [];
const recordingTools = launchSetting === "off" ? undefined : options.recordingTools === undefined ? ffmpegRecordingTools() : options.recordingTools ?? undefined;
for (const [index, colorScheme] of colorSchemes.entries()) {
runner({ command: options.agentDeviceCommand, args: [...appearanceArgs(colorScheme), "--session", CONTROLLER_SESSION, ...deviceArgs(runtime), "--platform", options.platform],
// Argent cannot switch the appearance yet (software-mansion/argent#1509): on EAS its single pass runs as the device
// starts, and on this machine the host switches it.
if (controller !== "argent") runner({ command: controllerCommand, args: [...appearanceArgs(colorScheme), "--session", CONTROLLER_SESSION, ...deviceArgs(runtime), "--platform", options.platform],
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 60_000 });
else if (localSimulator) setLocalSimulatorAppearance({ runner, udid: localSimulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
else if (localEmulator) setLocalEmulatorAppearance({ runner, serial: localEmulator, scheme: colorScheme, cwd: simulatorProject, environment: restrictedEnvironment });
// A scheme change recreates the Android activity in place, and the sheets it re-presents lose their inset; a
// relaunch starts the app in the new scheme, the same way the first pass did.
if (launchSetting !== "off") {
@@ -516,7 +755,7 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
const record = await captureLaunch({ bundleId: options.bundleId, keepVideo: launchSetting === "video", platform: options.platform,
directory: join(launchWorkDirectory, launchDirectory(colorScheme)), relativeDirectory: launchDirectory(colorScheme), ...(options.now ? { now: options.now } : {}),
...(recordingTools ? { recordingTools } : {}),
controller: (args, controllerOptions) => runner({ command: options.agentDeviceCommand, args: [...args, "--session", CONTROLLER_SESSION, ...deviceArgs(runtime!), "--platform", options.platform],
controller: (args, controllerOptions) => runner({ command: controllerCommand, args: [...args, "--session", CONTROLLER_SESSION, ...deviceArgs(runtime!), "--platform", options.platform],
cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: controllerOptions?.timeoutMs ?? 60_000, ...(controllerOptions?.allowFailure ? { allowFailure: true } : {}) }) });
launch[colorScheme] = { root: launchWorkDirectory, record };
} catch (error) {
@@ -524,12 +763,12 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
say(`the app launch could not be observed (${(error as Error).message}); the report has no launch evidence for ${colorScheme}`);
await rm(join(launchWorkDirectory, launchDirectory(colorScheme)), { recursive: true, force: true });
}
} else if (index > 0) runner({ command: options.agentDeviceCommand, args: ["open", options.bundleId, "--relaunch", "--session", CONTROLLER_SESSION,
} else if (index > 0) runner({ command: controllerCommand, args: ["open", options.bundleId, "--relaunch", "--session", CONTROLLER_SESSION,
...deviceArgs(runtime), "--platform", options.platform, "--level", "full", "--json"], cwd: simulatorProject, environment: controllerEnvironment, timeoutMs: 60_000 });
runtime.colorScheme = colorScheme;
if (colorSchemes.length > 1) say(`appearance ${colorScheme} (${index + 1}/${colorSchemes.length})`);
passes.push(await capturePlannedRoutes({ capture: { ...options, setup, progress: say }, routes: missingRoutes, inventory, scheme, appName: app.name, runtime,
connection: handoff.connection, environment: controllerEnvironment, store, map, acceptedFrames, outcomes: index === 0 ? outcomes : {},
passes.push(await capturePlannedRoutes({ capture: { ...options, agentDeviceCommand: controllerCommand, setup, progress: say }, routes: missingRoutes, inventory, scheme, appName: app.name, runtime,
connection, environment: controllerEnvironment, store, map, acceptedFrames, outcomes: index === 0 ? outcomes : {},
...(colorSchemes.length > 1 ? { appearance: { scheme: colorScheme, primary: index === 0 } } : {}) }));
}
runtime.colorScheme = colorSchemes[0]!;
@@ -537,6 +776,40 @@ async function executeCiMap(options: CiMapOptions, setStage: (stage: string) =>
} catch (error) { primaryError = toCiError(error, { code: `CAPTURE_${runtimeStage.toUpperCase()}_FAILED`, stage: runtimeStage,
nextAction: "Inspect the capture diagnostic, correct the failing prerequisite, and rerun Explore." }); }
finally {
if (appDirectory) await rm(appDirectory, { recursive: true, force: true });
if (localArgent) stopLocalArgentServer(localArgent);
if (localEmulator) {
try {
setStage("cleanup");
say(`stopping the local emulator ${localEmulator}`);
runner({ command: options.agentDeviceCommand, args: ["close", "--session", CONTROLLER_SESSION, "--json"], cwd: simulatorProject,
environment: { ...restrictedEnvironment, AGENT_DEVICE_STATE_DIR: join(simulatorProject, "agent-device-state") }, timeoutMs: 60_000, allowFailure: true });
await stopLocalAgentDevice(join(simulatorProject, "agent-device-state"));
await deleteLocalEmulator({ runner, serial: localEmulator, cwd: simulatorProject, environment: restrictedEnvironment });
if (statePath) await rm(statePath, { force: true });
// The AVD lives in the capture's directory, so it goes with it.
await rm(simulatorProject, { recursive: true, force: true });
} catch (error) { throw new CiError({ code: "SESSION_CLEANUP_FAILED", stage: "cleanup",
message: "The local emulator Explore started could not be stopped.", nextAction: `Stop it with: adb -s ${localEmulator} emu kill`,
details: { serial: localEmulator, ...(primaryError ? { originalFailure: serializeCiError(primaryError, { secrets: [options.expoToken] }) } : {}) }, cause: error }); }
}
if (localSimulator) {
try {
setStage("cleanup");
say(`deleting the local simulator ${localSimulator}`);
// Its own agent-device daemon lets go of the device before it goes.
runner({ command: options.agentDeviceCommand, args: ["close", "--session", CONTROLLER_SESSION, "--json"], cwd: simulatorProject,
environment: { ...restrictedEnvironment, AGENT_DEVICE_STATE_DIR: join(simulatorProject, "agent-device-state") }, timeoutMs: 60_000, allowFailure: true });
await stopLocalAgentDevice(join(simulatorProject, "agent-device-state"));
deleteLocalSimulator({ runner, udid: localSimulator, cwd: simulatorProject, environment: restrictedEnvironment });
if (statePath) await rm(statePath, { force: true });
await rm(simulatorProject, { recursive: true, force: true });
} catch (error) { throw new CiError({ code: "SESSION_CLEANUP_FAILED", stage: "cleanup",
message: "The local simulator Explore created could not be deleted.", nextAction: `Delete it with: xcrun simctl delete ${localSimulator}`,
details: { udid: localSimulator, ...(primaryError ? { originalFailure: serializeCiError(primaryError, { secrets: [options.expoToken] }) } : {}) }, cause: error }); }
}
// Everything this side started on this machine is stopped; a cleanup that threw above leaves the record for a sweep.
await localRecord?.close();
if (sessionId) {
try {
setStage("cleanup");
+72
View File
@@ -0,0 +1,72 @@
import { createHash } from "node:crypto";
import { existsSync } from "node:fs";
import { mkdir, readdir, readFile, rename, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { CiError, serializeCiError, toCiError } from "../shared/ci-errors.js";
/**
* Several targets of one review run the same commit of one platform and EAS profile: they need one build and one
* repack, not one each. The captures run in parallel, in worker threads, so they meet in a directory: the first to
* claim a build's folder builds it and writes the result there, and the others wait for that result (or its failure).
*/
export type SharedBuildKey = { platform: string; easProfile: string; bundleId: string; gitCommit: string; repack: string; local: boolean; routes: readonly string[] };
export function sharedBuildId(key: SharedBuildKey): string {
return createHash("sha256").update(JSON.stringify({ ...key, routes: [...key.routes].sort() })).digest("hex").slice(0, 24);
}
const POLL_MS = 2_000;
/**
* Runs `build` once per key across every capture sharing `directory`; the app it leaves goes in the build's folder
* (`keepApp`), which outlives each capture. A waiter is told so it can say whose build it uses.
*/
export async function sharedBuild<T extends object>(options: { directory: string; key: SharedBuildKey; appName: string; signal?: AbortSignal;
build: (keepApp: string) => Promise<T>; waiting?: () => void;
/** Who builds it (the capture's output directory), so a review can fail its waiters if that capture dies (abandonSharedBuilds). */
owner?: string }): Promise<T> {
const folder = join(options.directory, sharedBuildId(options.key));
const result = join(folder, "result.json"), failure = join(folder, "failure.json");
await mkdir(options.directory, { recursive: true });
let owner = true;
try { await mkdir(folder); } catch (error) { if ((error as NodeJS.ErrnoException).code !== "EEXIST") throw error; owner = false; }
if (owner) {
if (options.owner) await writeFile(join(folder, "owner"), options.owner);
try {
const built = await options.build(join(folder, options.appName));
await writeFile(`${result}.tmp`, JSON.stringify(built));
await rename(`${result}.tmp`, result);
return built;
} catch (error) {
await writeFile(failure, JSON.stringify(serializeCiError(toCiError(error, { code: "CAPTURE_BUILD_FAILED", stage: "build",
nextAction: "Inspect the capture diagnostic, correct the failing prerequisite, and rerun Explore." })))).catch(() => undefined);
throw error;
}
}
options.waiting?.();
for (;;) {
options.signal?.throwIfAborted();
const done = await readFile(result, "utf8").catch(() => undefined);
if (done !== undefined) return JSON.parse(done) as T;
const failed = await readFile(failure, "utf8").catch(() => undefined);
if (failed !== undefined) {
const error = JSON.parse(failed) as { code: string; stage: string; message: string; nextAction: string };
throw new CiError({ code: error.code, stage: error.stage, message: `The shared build failed: ${error.message}`, nextAction: error.nextAction });
}
await new Promise(resolve => setTimeout(resolve, POLL_MS));
}
}
/**
* Fails the unfinished builds a capture owned, for one that ended without saying (a worker thread that exited before
* its build wrote failure.json): the captures waiting on them stop instead of polling until the review is stopped.
*/
export async function abandonSharedBuilds(directory: string, ownedBy: (owner: string) => boolean, reason: string): Promise<void> {
for (const folder of await readdir(directory).catch(() => [] as string[])) {
const path = join(directory, folder);
const owner = await readFile(join(path, "owner"), "utf8").catch(() => undefined);
if (owner === undefined || !ownedBy(owner) || existsSync(join(path, "result.json")) || existsSync(join(path, "failure.json"))) continue;
await writeFile(join(path, "failure.json"), JSON.stringify(serializeCiError(new CiError({ code: "CAPTURE_BUILD_FAILED", stage: "build",
message: `the capture building it stopped (${reason})`, nextAction: "Inspect that target's failure above, correct it, and rerun Explore." }))));
}
}
+82 -43
View File
@@ -2,6 +2,7 @@ import { createHash } from "node:crypto";
import { readFile } from "node:fs/promises";
import { toCiError, serializeCiError, CiError } from "../shared/ci-errors.js";
import { isRecord, parseJson, baseEnvironment, AGENT_DEVICE_VERSION, CONTROLLER_SESSION, EAS_CLI_VERSION } from "./common.js";
import { ARGENT_VERSION } from "../shared/argent-version.js";
import { SIMULATOR_PREVIEW_HOST, framedSimulatorPreviewServer } from "../shared/simulator-preview.js";
import { lstatIfExists } from "./fs-safety.js";
import { defaultRunner, openedSimulatorDevice, controllerData } from "./controller.js";
@@ -9,7 +10,21 @@ import type { RepackProfile } from "./eas-build.js";
import type { SimulatorRuntimeMetadata, CiMapOptions } from "./run.js";
import type { Platform } from "../types.js";
export type SimulatorConnection = { sessionId: string; daemonBaseUrl: string; daemonAuthToken: string };
/**
* How Explore reaches a session's device controller. For agent-device (no `controller`) these are the daemon's URL and
* token; for Argent they are the tool-server's `ARGENT_TOOLS_URL` and `ARGENT_AUTH_TOKEN`, whose token may be empty.
*/
export type SimulatorConnection = { sessionId: string; daemonBaseUrl: string; daemonAuthToken: string; controller?: "argent" };
/** The controller a connection reaches: the session `--type` EAS started. */
export function connectionController(connection: Pick<SimulatorConnection, "controller">): "agent-device" | "argent" {
return connection.controller ?? "agent-device";
}
/** The controller's pinned version: what EAS installs on the session (`--package-version`) and what runs here. */
export function controllerVersion(controller: "agent-device" | "argent"): string {
return controller === "argent" ? ARGENT_VERSION : AGENT_DEVICE_VERSION;
}
export type ActiveSimulatorRuntime = Omit<SimulatorRuntimeMetadata, "sessionLifecycle"> & { controllerDeviceId: string };
const SIMULATOR_SESSION_NAME_MAX_CHARACTERS = 50;
const SIMULATOR_SESSION_DIGEST_CHARACTERS = 20;
@@ -64,24 +79,28 @@ function simulatorConnection(
sessionId: string,
daemonBaseUrl: unknown,
daemonAuthToken: unknown,
controller: "agent-device" | "argent" = "agent-device",
): SimulatorConnection {
// An Argent tool-server may run without a token (ARGENT_AUTH_TOKEN is only set when it needs one).
if (controller === "argent" && daemonAuthToken === undefined) daemonAuthToken = "";
if (
typeof daemonBaseUrl !== "string"
|| typeof daemonAuthToken !== "string"
|| !daemonBaseUrl
|| !daemonAuthToken
|| (!daemonAuthToken && controller !== "argent")
|| daemonBaseUrl.length > 2_048
|| daemonAuthToken.length > 8_192
|| /[\u0000-\u001f\u007f]/.test(daemonBaseUrl)
|| /[\u0000-\u001f\u007f]/.test(daemonAuthToken)
) {
throw new Error("eas simulator:start returned an unsafe agent-device connection");
throw new Error(`eas simulator:start returned an unsafe ${controller} connection`);
}
remoteDaemonDomain(daemonBaseUrl);
remoteDaemonDomain(daemonBaseUrl, controller);
return {
sessionId,
daemonBaseUrl,
daemonAuthToken,
...(controller === "argent" ? { controller } : {}),
};
}
@@ -100,7 +119,7 @@ export function simulatorStartFailure(error: unknown, secrets: readonly string[]
message: source.message.replace(/\\+(["'/])/g, "$1"),
nextAction: "Inspect the EAS simulator start failure." }), { secrets });
const message = failure.message
.replace(/\b(?:AGENT_DEVICE_[A-Z_]+|EAS_SIMULATOR_[A-Z_]+|EXPO_TOKEN|agentDeviceRemoteSession(?:Token|Url)|webPreviewUrl)["']?\s*[:=][^\r\n]*/g, "[REDACTED_HANDOFF]")
.replace(/\b(?:AGENT_DEVICE_[A-Z_]+|ARGENT_[A-Z_]+|EAS_SIMULATOR_[A-Z_]+|EXPO_TOKEN|agentDeviceRemoteSession(?:Token|Url)|toolsUrl|toolsAuthToken|webPreviewUrl|previewApiUrl)["']?\s*[:=][^\r\n]*/g, "[REDACTED_HANDOFF]")
.replace(/\b[A-Za-z][A-Za-z0-9+.-]*:\/\/[^\s<>"']+/g, "[REDACTED_URL]")
.slice(0, 1600);
return { code: failure.code, stage: "session", message,
@@ -149,6 +168,8 @@ export async function readSimulatorDotenvHandoff(path: string): Promise<Simulato
"EAS_SIMULATOR_SESSION_ID",
"AGENT_DEVICE_DAEMON_BASE_URL",
"AGENT_DEVICE_DAEMON_AUTH_TOKEN",
"ARGENT_TOOLS_URL",
"ARGENT_AUTH_TOKEN",
].includes(name)) {
validationError ??= new Error("EAS Simulator dotenv handoff contains an unexpected assignment");
continue;
@@ -177,11 +198,14 @@ export async function readSimulatorDotenvHandoff(path: string): Promise<Simulato
let connection: SimulatorConnection | undefined;
if (sessionId) {
try {
connection = simulatorConnection(
sessionId,
assignments.AGENT_DEVICE_DAEMON_BASE_URL,
assignments.AGENT_DEVICE_DAEMON_AUTH_TOKEN,
);
// An `argent` session writes the Argent tool-server's variables instead of agent-device's.
connection = assignments.ARGENT_TOOLS_URL !== undefined
? simulatorConnection(sessionId, assignments.ARGENT_TOOLS_URL, assignments.ARGENT_AUTH_TOKEN, "argent")
: simulatorConnection(
sessionId,
assignments.AGENT_DEVICE_DAEMON_BASE_URL,
assignments.AGENT_DEVICE_DAEMON_AUTH_TOKEN,
);
} catch (error) {
validationError ??= error instanceof Error ? error : new Error(String(error));
}
@@ -207,7 +231,7 @@ export function assertSimulatorSessionIdentity(
sessionId !== expectedSessionId
|| !isRecord(value)
|| value.name !== expectedSessionName
|| value.type !== "agent-device"
|| value.type !== (expectedConnection ? connectionController(expectedConnection) : "agent-device")
|| value.platform !== expectedPlatform.toUpperCase()
|| value.status !== "IN_PROGRESS"
) {
@@ -226,17 +250,19 @@ export function assertSimulatorSessionIdentity(
if (!projectProven) {
throw new Error("eas simulator:get did not prove the exact expected simulator session");
}
if (expectedConnection) {
if (
!isRecord(value.remoteConfig)
|| value.remoteConfig.agentDeviceRemoteSessionUrl !== expectedConnection.daemonBaseUrl
|| value.remoteConfig.agentDeviceRemoteSessionToken !== expectedConnection.daemonAuthToken
) {
throw new Error("eas simulator:get returned a different agent-device connection");
}
if (expectedConnection && !remoteConfigMatches(value.remoteConfig, expectedConnection)) {
throw new Error(`eas simulator:get returned a different ${connectionController(expectedConnection)} connection`);
}
}
/** The session's published controller endpoint is the one Explore holds: agent-device's daemon, or Argent's tool-server. */
function remoteConfigMatches(remoteConfig: unknown, connection: SimulatorConnection): boolean {
if (!isRecord(remoteConfig)) return false;
return connectionController(connection) === "argent"
? remoteConfig.toolsUrl === connection.daemonBaseUrl && (remoteConfig.toolsAuthToken ?? "") === connection.daemonAuthToken
: remoteConfig.agentDeviceRemoteSessionUrl === connection.daemonBaseUrl && remoteConfig.agentDeviceRemoteSessionToken === connection.daemonAuthToken;
}
/**
* A session Explore did not start: the connection comes from `eas simulator:start --out-config-type dotenv`
* (`.env.eas-simulator`) or from the `EAS_SIMULATOR_SESSION_ID` / `AGENT_DEVICE_DAEMON_*` variables that
@@ -263,7 +289,9 @@ export async function resolveAttachedSimulatorSession(
if (requestedSessionId && environment.EAS_SIMULATOR_SESSION_ID && environment.EAS_SIMULATOR_SESSION_ID !== requestedSessionId) {
throw new Error(`EAS_SIMULATOR_SESSION_ID is ${environment.EAS_SIMULATOR_SESSION_ID}, not ${requestedSessionId}`);
}
return simulatorConnection(sessionId, environment.AGENT_DEVICE_DAEMON_BASE_URL, environment.AGENT_DEVICE_DAEMON_AUTH_TOKEN);
return environment.ARGENT_TOOLS_URL !== undefined && environment.AGENT_DEVICE_DAEMON_BASE_URL === undefined
? simulatorConnection(sessionId, environment.ARGENT_TOOLS_URL, environment.ARGENT_AUTH_TOKEN, "argent")
: simulatorConnection(sessionId, environment.AGENT_DEVICE_DAEMON_BASE_URL, environment.AGENT_DEVICE_DAEMON_AUTH_TOKEN);
}
/** Proves an attached session is live, agent-device typed, and served by the connection we hold; returns its platform. */
@@ -274,8 +302,8 @@ export function assertAttachedSimulatorSession(
): { platform: Platform; name: string; deviceRunSessionUrl?: string } {
const value = parseJson(stdout, "eas simulator:get");
const sessionId = simulatorSessionId(value, "eas simulator:get");
if (sessionId !== connection.sessionId || !isRecord(value) || value.type !== "agent-device") {
throw new Error("eas simulator:get did not describe the attached agent-device session");
if (sessionId !== connection.sessionId || !isRecord(value) || value.type !== connectionController(connection)) {
throw new Error(`eas simulator:get did not describe the attached ${connectionController(connection)} session`);
}
if (value.status !== "IN_PROGRESS") {
throw new Error(`EAS Simulator session ${sessionId} is ${String(value.status).toLowerCase()}, not in progress`);
@@ -284,12 +312,8 @@ export function assertAttachedSimulatorSession(
if (!platform || (expectedPlatform && platform !== expectedPlatform)) {
throw new Error(`EAS Simulator session ${sessionId} is ${String(value.platform).toLowerCase()}${expectedPlatform ? `, not ${expectedPlatform}` : ""}`);
}
if (
!isRecord(value.remoteConfig)
|| value.remoteConfig.agentDeviceRemoteSessionUrl !== connection.daemonBaseUrl
|| value.remoteConfig.agentDeviceRemoteSessionToken !== connection.daemonAuthToken
) {
throw new Error("eas simulator:get returned a different agent-device connection than the one provided");
if (!remoteConfigMatches(value.remoteConfig, connection)) {
throw new Error(`eas simulator:get returned a different ${connectionController(connection)} connection than the one provided`);
}
return {
platform,
@@ -309,12 +333,12 @@ export function assertSimulatorStopped(stdout: string, expectedSessionId: string
}
}
function remoteDaemonDomain(value: string): string {
function remoteDaemonDomain(value: string, controller: "agent-device" | "argent" = "agent-device"): string {
let url: URL;
try {
url = new URL(value);
} catch {
throw new Error("eas simulator returned an invalid agent-device URL");
throw new Error(`eas simulator returned an invalid ${controller} URL`);
}
if (
url.protocol !== "https:"
@@ -322,21 +346,32 @@ function remoteDaemonDomain(value: string): string {
|| url.password
|| !url.hostname
) {
throw new Error("eas simulator returned an unsafe agent-device URL");
throw new Error(`eas simulator returned an unsafe ${controller} URL`);
}
return url.hostname;
}
export function collectRuntime(options: CiMapOptions & { platform: NonNullable<CiMapOptions["platform"]> }, environment: NodeJS.ProcessEnv): ActiveSimulatorRuntime {
export function collectRuntime(options: CiMapOptions & { platform: NonNullable<CiMapOptions["platform"]> }, environment: NodeJS.ProcessEnv,
/** The local simulator (UDID) or emulator (adb serial) Explore started; absent for an EAS session. */
local?: { id: string }): ActiveSimulatorRuntime {
const runner = options.runner ?? defaultRunner;
const controller = options.controller ?? "agent-device";
const version = runner({ command: options.agentDeviceCommand, args: ["--version"], cwd: options.project,
environment: baseEnvironment(options.environment ?? process.env), timeoutMs: 30_000 }).stdout.trim();
if (version !== AGENT_DEVICE_VERSION) throw new Error(`agent-device version must be ${AGENT_DEVICE_VERSION}`);
environment: controller === "argent" ? environment : baseEnvironment(options.environment ?? process.env), timeoutMs: 30_000 }).stdout.trim();
if (version !== controllerVersion(controller)) throw new Error(`${controller} version must be ${controllerVersion(controller)}`);
const opened = runner({ command: options.agentDeviceCommand,
args: ["open", options.bundleId, "--session", CONTROLLER_SESSION, ...(options.platform === "ios" ? ["--device", options.device] : []),
"--platform", options.platform, "--level", "full", "--json"], cwd: options.project, environment, timeoutMs: 60_000 });
args: ["open", options.bundleId, "--session", CONTROLLER_SESSION,
...(local ? [options.platform === "ios" ? "--udid" : "--serial", local.id] : options.platform === "ios" ? ["--device", options.device] : []),
"--platform", options.platform, "--level", "full", "--json"], cwd: options.project, environment,
// Argent's first call can wait for a tool-server that is still starting, then relaunch the app until it is readable.
// A local simulator's first open also builds agent-device's XCTest runner, once per agent-device release.
timeoutMs: controller === "argent" ? 180_000 : local ? 15 * 60_000 : 60_000 });
const device = openedSimulatorDevice(opened.stdout, options.bundleId, "initial app open", options.platform);
if (options.platform === "ios" && device.deviceModel !== options.device) throw new CiError({ code: "DEVICE_MISMATCH", stage: "runtime",
if (local && device.deviceId !== local.id) throw new CiError({ code: "DEVICE_MISMATCH", stage: "runtime",
message: `agent-device opened ${device.deviceId} instead of the device Explore started (${local.id}).`,
nextAction: "Rerun capture; if it happens again, check xcrun simctl list devices for leftover Explore simulators." });
// A local simulator is named for Explore; its model is the configured device it was created as.
if (!local && options.platform === "ios" && device.deviceModel !== options.device) throw new CiError({ code: "DEVICE_MISMATCH", stage: "runtime",
message: `EAS opened ${device.deviceModel} instead of the configured ${options.device}.`,
nextAction: "Select an available exact device name in config.yaml and rerun capture." });
const data = controllerData(opened.stdout, "initial app open");
@@ -345,8 +380,8 @@ export function collectRuntime(options: CiMapOptions & { platform: NonNullable<C
const value = deviceData[key] ?? data[key];
return typeof value === "string" && value.trim() ? value : "unknown";
};
return { provider: "eas-simulator", controller: "agent-device", controllerPackageVersion: AGENT_DEVICE_VERSION,
easCliVersion: EAS_CLI_VERSION, platform: options.platform, controllerDeviceId: device.deviceId, deviceModel: device.deviceModel,
return { provider: local ? "local-simulator" : "eas-simulator", controller, controllerPackageVersion: controllerVersion(controller),
easCliVersion: EAS_CLI_VERSION, platform: options.platform, controllerDeviceId: device.deviceId, deviceModel: local ? options.device : device.deviceModel,
osVersion: observed("osVersion"), locale: observed("locale"),
orientation: observed("orientation") === "landscape" ? "landscape" : "portrait",
colorScheme: observed("colorScheme") === "light" ? "light" : observed("colorScheme") === "dark" ? "dark" : "system" };
@@ -361,11 +396,15 @@ export function collectRuntime(options: CiMapOptions & { platform: NonNullable<C
export async function simulatorOsVersion(session: string, deviceId: string, transport: typeof fetch, platform: "ios" | "android" = "ios"): Promise<string> {
const value = parseJson(session, "eas simulator:get");
const remote = isRecord(value) && isRecord(value.remoteConfig) ? value.remoteConfig : {};
if (typeof remote.webPreviewUrl !== "string") throw new Error("EAS did not publish the simulator preview URL");
const preview = new URL(remote.webPreviewUrl);
// eas-cli 25 publishes the preview server itself as previewApiUrl, with the token in its query, but only for a
// session started with --public-link; its webPreviewUrl is then an expo.dev page with the token in the fragment.
// Earlier versions folded the token into webPreviewUrl's query. A private session's output has no token at all.
const published = typeof remote.previewApiUrl === "string" ? remote.previewApiUrl : remote.webPreviewUrl;
if (typeof published !== "string") throw new Error("EAS did not publish the simulator preview URL");
const preview = new URL(published);
if (preview.protocol !== "https:" || preview.username || preview.password) throw new Error("The simulator preview URL is not HTTPS");
// eas-cli --json folds the preview token into the URL; the catalog takes it as a bearer credential.
const token = preview.searchParams.get("token");
// The catalog takes the preview token as a bearer credential.
const token = preview.searchParams.get("token") ?? new URLSearchParams(preview.hash.slice(1)).get("token");
const catalog = new URL(framedSimulatorPreviewServer(preview) ?? preview.origin);
if (!SIMULATOR_PREVIEW_HOST.test(catalog.hostname)) throw new Error(`The simulator preview URL names no preview server: ${preview.origin}${preview.pathname}`);
// The iOS preview server lists simulators at /grid/api; the Android one has no grid and lists
+7 -2
View File
@@ -8,9 +8,10 @@ import { parseRuntimeExecutionContext } from "../review/runtime-adapter.js";
import { AGENT_ACCEPTANCE_POLICY, assertAgentAcceptance, type CaptureBundle } from "../contracts/capture.js";
import { assertDecodedPng } from "../shared/png-evidence.js";
import { canonicalJson } from "../shared/canonical-json.js";
import type { ExploreConfig } from "../config/explore-config.js";
import { captureRepack, type ExploreConfig } from "../config/explore-config.js";
import { hasVerifiedCapture } from "../capture/health.js";
import { CAPTURE_OBSERVER_HASH } from "../capture/observer.js";
import { ARGENT_VERSION } from "../shared/argent-version.js";
const METADATA = "cache-metadata.json";
const CONTRACT = "explore.capture-cache";
@@ -33,7 +34,11 @@ export function captureRecipeConfig(config: ExploreConfig, instructionsSha256?:
...(config.mode === "agent" ? { agent: { ...config.agent, instructionsSha256, acceptancePolicy: AGENT_ACCEPTANCE_POLICY } } : {}),
app: { platform: config.app.platform, bundleId: config.app.bundleId, easProfile: config.app.easProfile,
...(config.app.scheme === undefined ? {} : { scheme: config.app.scheme }) },
device: config.device, parameters: config.parameters, setup: config.setup ?? [], capture: config.capture,
device: config.device, parameters: config.parameters, setup: config.setup ?? [],
// The repack as it resolves, so a config that leaves it to the default keeps the recipe it had when the default was written out.
capture: { ...config.capture, repack: captureRepack(config) },
// agent-device recipes stay as they were; an Argent capture is keyed to the Argent release that drove it.
...(config.capture.controller === "argent" ? { controllerVersion: ARGENT_VERSION } : {}),
});
}
+113 -21
View File
@@ -1,6 +1,6 @@
import { spawnSync } from "node:child_process";
import { readFileSync } from "node:fs";
import { lstat, mkdir, readFile, realpath } from "node:fs/promises";
import { lstat, mkdir, readdir, readFile, realpath } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join, sep } from "node:path";
import { CiError, toCiError } from "../shared/ci-errors.js";
@@ -8,8 +8,11 @@ import type { CaptureBundle } from "../contracts/capture.js";
import type { SourceCapturePlan } from "../source/capture-plan.js";
import type { CommandRunner } from "../capture/run.js";
import { runBaselineCi } from "./pipeline.js";
import { DEFAULT_EXPLORE_CONFIG_PATH, configPlatforms, readExploreConfig, readExploreInstructions, resolvePlatformConfig, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { DEFAULT_EXPLORE_CONFIG_PATH, captureRepack, configTargets, readExploreConfig, readExploreInstructions, resolveTargetConfig, withRunOverrides, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { explorationSecretNames } from "../config/exploration-inputs.js";
import { controllerCached } from "../shared/controller-cache.js";
import { androidTools, hostEmulatorAbi, localSimulatorTarget, localSystemImage } from "../capture/local-simulator.js";
import { ARGENT_VERSION } from "../shared/argent-version.js";
import { AGENT_PROVIDERS as PROVIDERS, DRAFT_INSTRUCTIONS_MARKER, EXPO_TOKENS_URL as TOKENS, appConfig, simulatorProfiles } from "../config/setup.js";
import { captureCompatibility } from "../capture/observer.js";
import { assertCaptureEasProfile, assertSimulatorAvailable, repackProfileFrom, unreproducibleEasVariables } from "../capture/eas-build.js";
@@ -46,6 +49,12 @@ export type DoctorOptions = {
github?: boolean;
/** One small model request with the local provider key. */
checkModel?: boolean;
/** `--controller`: the device controller to check, over the config's `capture.controller`. */
controller?: string | undefined;
/** `--simulator`: where the app runs, over the config's `capture.simulator`. */
simulator?: string | undefined;
/** `--repack`: where the app is repacked, over the config's `capture.repack`. */
repack?: string | undefined;
run?: DoctorRun;
environment?: NodeJS.ProcessEnv;
nodeVersion?: string;
@@ -149,7 +158,71 @@ function routeChecks(config: ExploreConfig, report: RouteEntryReport): DoctorChe
return checks;
}
async function easChecks(project: string, config: ExploreConfig, run: DoctorRun): Promise<DoctorCheck[]> {
/** Every target, resolved, once per platform, EAS profile and app: targets that differ only by device or pose share these checks. */
function resolvedTargets(config: ExploreConfig, by: (target: ExploreConfig) => string = target => `${target.app.platform}:${target.app.easProfile}:${target.app.bundleId}`): ExploreConfig[] {
const seen = new Set<string>();
return configTargets(config).map(target => resolveTargetConfig(config, { target: target.id })).filter(target => !seen.has(by(target)) && !!seen.add(by(target)));
}
/**
* Every target as a capture of it runs: its own controller and simulator (else the config's), with the run's
* --controller and --simulator over both.
*/
function runTargets(config: ExploreConfig, overrides: { controller?: string | undefined; simulator?: string | undefined }): ExploreConfig[] {
return configTargets(config).map(target => withRunOverrides(resolveTargetConfig(config, { target: target.id }), overrides));
}
/**
* The targets that run on a local simulator, in place of EAS Simulator access: this Mac's Xcode can create each iOS
* target's device, and the Android SDK can start each Android target's device profile with a system image this machine runs.
*/
async function localSimulatorChecks(project: string, targets: readonly ExploreConfig[], run: DoctorRun, environment: NodeJS.ProcessEnv): Promise<DoctorCheck[]> {
const checks: DoctorCheck[] = [];
const seen = new Set<string>();
for (const target of targets.filter(each => !seen.has(`${each.app.platform}:${each.device.name}`) && !!seen.add(`${each.app.platform}:${each.device.name}`))) {
const device = target.device.name;
if (target.app.platform === "ios") {
const types = run("xcrun", ["simctl", "list", "devicetypes", "-j"], project);
const runtimes = run("xcrun", ["simctl", "list", "runtimes", "-j"], project);
try {
if (types.status !== 0 || runtimes.status !== 0) throw new Error(lastLine(types.stderr || runtimes.stderr || "xcrun simctl failed"));
const local = localSimulatorTarget(types.stdout, runtimes.stdout, device);
checks.push({ step: 1, id: "local-simulator", status: "pass", message: `This Mac can create an ${device} simulator (iOS ${local.osVersion}).` });
} catch (error) {
checks.push(fromError(1, "local-simulator", error, { code: "LOCAL_SIMULATOR_UNAVAILABLE",
nextAction: "Install Xcode and an iOS simulator runtime for the configured device, select it with xcode-select (or DEVELOPER_DIR), then rerun doctor." }));
}
continue;
}
try {
const tools = androidTools(environment);
const image = await localSystemImage(tools.sdk, hostEmulatorAbi());
const devices = run(tools.avdmanager, ["list", "device", "-c"], project);
if (devices.status !== 0) throw new Error(lastLine(devices.stderr || devices.stdout || "avdmanager failed"));
if (!devices.stdout.split("\n").map(line => line.trim()).includes(device)) throw new CiError({ code: "LOCAL_EMULATOR_DEVICE_UNAVAILABLE", stage: "preflight",
message: `The Android SDK has no ${device} device profile.`, nextAction: "Set the target's device to a profile listed by avdmanager list device -c, such as pixel_7." });
checks.push({ step: 1, id: "local-emulator", status: "pass", message: `This machine can start a ${device} emulator (${image.image.split(";").slice(1).join(" ")}).` });
} catch (error) {
checks.push(fromError(1, "local-emulator", error, { code: "LOCAL_EMULATOR_UNAVAILABLE",
nextAction: "Install the Android SDK's emulator, platform-tools, cmdline-tools and a system image with sdkmanager, export ANDROID_HOME, then rerun doctor." }));
}
// A local simulator repacks on this machine too, unless capture.repack says eas: repack-app signs the APK with the
// SDK's build-tools and runs apktool and apksigner with Java.
if (captureRepack(target) === "local") {
const java = run("java", ["-version"], project);
let buildTools: string[] = [];
try { buildTools = await readdir(join(androidTools(environment).sdk, "build-tools")); } catch { /* no SDK or no build-tools */ }
checks.push(buildTools.length && java.status === 0
? { step: 1, id: "local-repack", status: "pass", message: `This machine can repack the APK (build-tools ${buildTools.sort().at(-1)}, ${(java.stderr || java.stdout).trim().split("\n")[0] || "Java"}).` }
: { step: 1, id: "local-repack", status: "fail", code: "LOCAL_REPACK_UNAVAILABLE",
message: buildTools.length ? "Repacking the APK on this machine needs Java, and java -version did not run." : "Repacking the APK on this machine needs the Android SDK build-tools, and none are installed.",
nextAction: "Install the build-tools (sdkmanager \"build-tools;35.0.0\") and a JDK 17, or set capture.repack: eas to repack in a hosted EAS job, then rerun doctor." });
}
}
return checks;
}
async function easChecks(project: string, config: ExploreConfig, run: DoctorRun, environment: NodeJS.ProcessEnv, simulator?: string): Promise<DoctorCheck[]> {
let eas: string;
try { eas = packageBin("eas-cli", "eas"); if (!await exists(eas)) throw new Error(); }
catch { return [{ step: 1, id: "eas-cli", status: "fail", code: "EXPLORE_TOOLS_MISSING",
@@ -168,17 +241,23 @@ async function easChecks(project: string, config: ExploreConfig, run: DoctorRun)
? { step: 1, id: "eas-project", status: "pass", message: "The app is linked to an EAS project this account can access." }
: { step: 1, id: "eas-project", status: "fail", code: "EAS_PROJECT_UNAVAILABLE", message: `EAS project check failed: ${lastLine(info.stderr || info.stdout)}`,
nextAction: "Run eas init in the app directory to link it, or ask the project's owner for access. The CI EXPO_TOKEN must belong to an account with the same access." });
const availability = run(eas, ["simulator:availability", "--json", "--non-interactive"], project);
try {
if (availability.status !== 0) throw new Error(lastLine(availability.stderr || availability.stdout));
assertSimulatorAvailable(availability.stdout);
checks.push({ step: 1, id: "eas-simulator", status: "pass", message: "EAS Simulator is available for this account." });
} catch (error) {
checks.push({ ...fromError(1, "eas-simulator", error, { code: "SIMULATOR_UNAVAILABLE", nextAction: "" }),
code: "SIMULATOR_UNAVAILABLE", nextAction: `Join the EAS Simulator waitlist at ${WAITLIST} with ${account}, the account the CI EXPO_TOKEN must use. Capture cannot run until access is granted.` });
// The targets on a local simulator need this machine's tools, and EAS Simulator access is checked when any target uses it.
const targets = runTargets(config, { simulator });
const local = targets.filter(target => target.capture.simulator === "local");
if (local.length) checks.push(...await localSimulatorChecks(project, local, run, environment));
if (local.length < targets.length) {
const availability = run(eas, ["simulator:availability", "--json", "--non-interactive"], project);
try {
if (availability.status !== 0) throw new Error(lastLine(availability.stderr || availability.stdout));
assertSimulatorAvailable(availability.stdout);
checks.push({ step: 1, id: "eas-simulator", status: "pass", message: "EAS Simulator is available for this account." });
} catch (error) {
checks.push({ ...fromError(1, "eas-simulator", error, { code: "SIMULATOR_UNAVAILABLE", nextAction: "" }),
code: "SIMULATOR_UNAVAILABLE", nextAction: `Join the EAS Simulator waitlist at ${WAITLIST} with ${account}, the account the CI EXPO_TOKEN must use. Capture cannot run until access is granted.` });
}
}
const checkedEnvironments = new Set<string>();
for (const target of configPlatforms(config).map(platform => resolvePlatformConfig(config, platform))) {
for (const target of resolvedTargets(config)) {
const { platform, easProfile, bundleId } = target.app;
const resolved = run(eas, ["config", "--platform", platform, "--profile", easProfile, "--json", "--non-interactive"], project);
if (resolved.status !== 0) {
@@ -227,7 +306,8 @@ async function easChecks(project: string, config: ExploreConfig, run: DoctorRun)
return checks;
}
async function ciFileChecks(project: string, secretNames: readonly string[], run: DoctorRun, online: boolean, platformCount = 1): Promise<{ checks: DoctorCheck[]; root?: string }> {
/** `named`: the config names its own targets, so only a workflow with a target matrix captures each one. */
async function ciFileChecks(project: string, secretNames: readonly string[], run: DoctorRun, online: boolean, platformCount = 1, named = false): Promise<{ checks: DoctorCheck[]; root?: string }> {
let layout: Awaited<ReturnType<typeof ciLayout>>;
try { layout = await ciLayout(project); }
catch (error) { return { checks: [fromError(6, "repository", error, { code: "NOT_A_GIT_REPOSITORY", nextAction: "Put the app in a Git repository, commit it, and rerun doctor." })] }; }
@@ -262,8 +342,10 @@ async function ciFileChecks(project: string, secretNames: readonly string[], run
if (drift) checks.push({ step: 6, id: `workflow-template-${name}`, status: "warn", code: "WORKFLOW_TEMPLATE_DRIFT",
message: `${file} ${drift === "stale" ? "was generated by an older @expo/explore template" : "differs from the @expo/explore template (edited after setup, or generated by an older version)"}; steps the ${EXPLORE_VERSION} template adds (such as installing ffmpeg for launch recordings) are missing from CI.`,
nextAction: drift === "stale" ? "Run expo-explore setup --workflows, then commit the workflows." : "Run expo-explore setup --workflows --force to regenerate it (reapply your edits), then commit the workflows." });
if (platformCount > 1 && !text.includes("matrix.platform")) checks.push({ step: 6, id: `workflow-platforms-${name}`, status: "warn", code: "WORKFLOW_PLATFORM_MATRIX_MISSING",
message: `${DEFAULT_EXPLORE_CONFIG_PATH} configures ${platformCount} platforms, but ${file} captures one platform (no matrix.platform).`,
// Workflows installed before targets run one job per platform, which covers a config whose targets are its platforms.
const matrix = text.includes("matrix.target") || (text.includes("matrix.platform") && !named);
if (platformCount > 1 && !matrix) checks.push({ step: 6, id: `workflow-platforms-${name}`, status: "warn", code: "WORKFLOW_PLATFORM_MATRIX_MISSING",
message: `${DEFAULT_EXPLORE_CONFIG_PATH} configures ${platformCount} targets, but ${file} does not capture each one (no matrix.target).`,
nextAction: "Run expo-explore setup --workflows to install the matrix workflows, then commit them." });
}
if (online) for (const version of versions) {
@@ -383,7 +465,7 @@ export async function runDoctor(options: DoctorOptions): Promise<DoctorReport> {
return { ok: false, mode: null, checks, ...(routes ? { routes } : {}) };
}
let config: ExploreConfig;
try { config = await readExploreConfig(project); }
try { config = withRunOverrides(await readExploreConfig(project), { controller: options.controller, simulator: options.simulator, repack: options.repack }); }
catch (error) {
checks.push(fromError(4, "config", error, { code: "CONFIG_INVALID", nextAction: `Correct ${DEFAULT_EXPLORE_CONFIG_PATH} and rerun doctor.` }));
return { ok: false, mode: null, checks };
@@ -392,6 +474,7 @@ export async function runDoctor(options: DoctorOptions): Promise<DoctorReport> {
checks.push(config.mode === "agent"
? { step: 3, id: "mode", status: "pass", message: `Agent mode with ${config.agent!.provider} ${config.agent!.model}. Capture navigation uses the model and is billed to your ${config.agent!.provider} account.` }
: { step: 3, id: "mode", status: "pass", message: "Deterministic mode: capture replays config.yaml without a model, so it needs no API key and has no AI charges." });
if (runTargets(config, { controller: options.controller }).some(target => target.capture.controller === "argent")) checks.push(argentCheck(environment));
if (config.capture.launch !== "off") {
const ffmpeg = run("ffmpeg", ["-version"], project);
checks.push(ffmpeg.status === 0
@@ -402,7 +485,7 @@ export async function runDoctor(options: DoctorOptions): Promise<DoctorReport> {
}
try {
const eas = JSON.parse(await readFile(join(project, "eas.json"), "utf8")) as Record<string, unknown>;
for (const target of configPlatforms(config).map(platform => resolvePlatformConfig(config, platform))) {
for (const target of resolvedTargets(config)) {
const { platform, easProfile } = target.app;
const requirement = platform === "ios" ? "ios.simulator: true" : "android.buildType: apk";
if (!simulatorProfiles(eas, platform).includes(easProfile)) throw new CiError({ code: platform === "ios" ? "EAS_PROFILE_NOT_SIMULATOR" : "EAS_PROFILE_NOT_APK", stage: "preflight",
@@ -465,7 +548,7 @@ export async function runDoctor(options: DoctorOptions): Promise<DoctorReport> {
}
}
const secretNames = referencedSecretNames(config, instructions);
const files = await ciFileChecks(project, secretNames, run, options.online !== false, configPlatforms(config).length);
const files = await ciFileChecks(project, secretNames, run, options.online !== false, configTargets(config).length, !!config.targets);
checks.push(...files.checks);
if (files.root) {
const pending = run("git", ["status", "--porcelain", "--untracked-files=all", "--", DEFAULT_EXPLORE_CONFIG_PATH, ...(config.agent?.instructions ? [config.agent.instructions] : [])], project).stdout
@@ -475,7 +558,7 @@ export async function runDoctor(options: DoctorOptions): Promise<DoctorReport> {
message: `Setup files are not committed: ${list(paths)}. CI reads them from the pushed repository.`,
nextAction: "Commit them, push, and merge them into the default branch." });
}
if (options.online !== false) checks.push(...await easChecks(project, config, run));
if (options.online !== false) checks.push(...await easChecks(project, config, run, environment, options.simulator));
else checks.push({ step: 1, id: "eas", status: "skip", message: "EAS login, project, simulator access and build profile were not checked (--offline)." });
if (options.github !== false && files.root) checks.push(...githubChecks(files.root, config, secretNames, run));
else if (files.root) checks.push({ step: 7, id: "github", status: "skip", message: `Repository settings were not checked (${options.online === false ? "--offline" : "--no-github"}).` });
@@ -547,7 +630,16 @@ export function summarizeCaptureCheck(plan: SourceCapturePlan, bundle: CaptureBu
* Capture the committed HEAD the way the baseline workflow does, with the local EAS login. This is
* the only doctor step that starts an EAS build and a simulator session.
*/
export async function runCaptureCheck(options: { project: string; output: string; platform?: ExplorePlatform; environment?: NodeJS.ProcessEnv; runner?: CommandRunner; progress?: Progress }): Promise<CaptureCheckResult> {
/** An Argent capture records one appearance, and fetches the pinned Argent release on first use. agent-device, the default, is not reported. */
function argentCheck(environment: NodeJS.ProcessEnv): DoctorCheck {
const cached = controllerCached("argent", environment);
return { step: 3, id: "controller", status: "warn", code: "CONTROLLER_APPEARANCE_FIXED",
message: `Device controller: Argent ${ARGENT_VERSION} (${cached ? "cached on this machine" : "fetched from npm on the first capture, about 27 MB"}). `
+ "Argent cannot switch the simulator's appearance yet (software-mansion/argent#1509), so each capture records one appearance: the app's forced one, else light.",
nextAction: "Nothing to do unless you need dark-mode screenshots; use agent-device (the default) for those." };
}
export async function runCaptureCheck(options: { project: string; output: string; platform?: ExplorePlatform; controller?: string | undefined; simulator?: string | undefined; repack?: string | undefined; target?: string | undefined; environment?: NodeJS.ProcessEnv; runner?: CommandRunner; progress?: Progress }): Promise<CaptureCheckResult> {
const project = await realpath(options.project);
const git = (...args: string[]) => spawnSync("git", ["-C", project, ...args], { encoding: "utf8", timeout: 10_000 });
const head = git("rev-parse", "HEAD");
@@ -559,7 +651,7 @@ export async function runCaptureCheck(options: { project: string; output: string
nextAction: "Commit your changes, including .expo-explore (a local commit is enough; nothing is pushed), then rerun. "
+ "To keep unrelated files, run it from a clean checkout instead: git worktree add --detach ../app-capture HEAD, install the app's dependencies there, and run doctor --capture in it." });
const commit = head.stdout.trim();
const config = resolvePlatformConfig(await readExploreConfig(project), options.platform);
const config = withRunOverrides(resolveTargetConfig(await readExploreConfig(project), { platform: options.platform, target: options.target }), { controller: options.controller, simulator: options.simulator, repack: options.repack });
// Capture keeps its working directories in the system temporary directory, outside the app.
await mkdir(options.output, { recursive: true });
const output = await realpath(options.output);
+178 -46
View File
@@ -1,3 +1,4 @@
import type { RunTarget } from "../types.js";
import { spawnSync } from "node:child_process";
import { randomBytes } from "node:crypto";
import { readFileSync } from "node:fs";
@@ -7,17 +8,21 @@ import { join, relative, resolve } from "node:path";
import { runCiReview } from "./pipeline.js";
import { resolveCommit } from "./workflow-steps.js";
import { ciLayout, installCommand, type PackageManager } from "./workflow-install.js";
import { configPlatforms, readExploreConfig, resolvePlatformConfig, withRunOverrides, DEFAULT_EXPLORE_CONFIG_PATH, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { AGENT_PROVIDERS } from "../config/setup.js";
import { configPlatforms, readExploreConfig, resolveTargetConfig, configTargets, withRunOverrides, DEFAULT_EXPLORE_CONFIG_PATH, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { AGENT_PROVIDERS, defaultExploreConfig } from "../config/setup.js";
import type { PrepareCiExplorationOptions } from "../capture/agent/exploration.js";
import { createCiAgentSession } from "../capture/agent/session.js";
import { createLocalCiAgentSession } from "../capture/agent/session-local.js";
import { androidTools, localEmulatorFromState, localSimulatorFromState } from "../capture/local-simulator.js";
import type { CommandRunner } from "../capture/run.js";
import { isSafeBranchRef, type LocalReviewPresentation, type PullRequestSidePresentation } from "../contracts/review.js";
import { exportCiReport, readCiReportInput } from "../report/artifact.js";
import { reviewChangeCount, reviewDevice, type PublicCommentState } from "../report/pr-comment-body.js";
import { zipReportDirectory } from "../report/preview-deploy.js";
import { CiError } from "../shared/ci-errors.js";
import { CiError, serializeCiError, toCiError, type CiErrorData } from "../shared/ci-errors.js";
import { defaultRunner } from "../capture/controller.js";
import { sweepLocalCaptures } from "../capture/local-registry.js";
import { abandonSharedBuilds } from "../capture/shared-build.js";
import { exploreCacheRoot } from "../shared/cache-root.js";
import { packageBin } from "../shared/package-paths.js";
import { silentProgress, type Progress } from "../shared/progress.js";
@@ -32,13 +37,23 @@ export type LocalReviewOptions = {
project: string;
base?: string | undefined;
head?: string | undefined;
/** Review uncommitted changes to tracked files as the head (the working tree, not a commit). */
/** Review HEAD alone, leaving out the working tree's changes. */
committed?: boolean | undefined;
/** Review the working tree even when eas.json sets cli.requireCommit. Without --head this is the default. */
uncommitted?: boolean | undefined;
/** With `uncommitted`: also include untracked files that are not ignored. */
untracked?: boolean | undefined;
platform?: ExplorePlatform | undefined;
/** `--target`: capture this config.yaml target alone; with `platform`, the targets of that platform. */
target?: string | undefined;
/** `--parallel`: how many targets capture at once (each runs a simulator or emulator per side); all of them by default. */
parallel?: number | undefined;
scope?: string | undefined;
expiresIn?: string | undefined;
/** `--controller`: the device controller for both sides, over the config's `capture.controller`. */
controller?: string | undefined;
/** `--simulator`: `local` runs both sides on simulators this Mac creates, over the config's `capture.simulator`. */
simulator?: string | undefined;
/** `--repack`: where the app is repacked with the route observer, over the config's `capture.repack`. */
repack?: string | undefined;
/** Reuse and keep captures in the local capture cache (default true). */
cache?: boolean | undefined;
configPath?: string | undefined;
@@ -52,10 +67,12 @@ export type LocalReviewOptions = {
agentSessionFactory?: PrepareCiExplorationOptions["createSession"];
};
export type LocalReviewReport = { platform: ExplorePlatform; directory: string; zip: string; changes?: number; device?: string };
export type LocalReviewReport = { platform: ExplorePlatform; target: RunTarget; directory: string; zip: string; changes?: number; device?: string };
export type LocalReviewResult = {
runId: string; base: PullRequestSidePresentation; head: PullRequestSidePresentation & { uncommitted?: string[] };
work: string; reports: LocalReviewReport[]; config: ExploreConfig; repository: string;
/** Targets whose review failed outright; the others' reports are kept and opened all the same. */
failures: { target: RunTarget; error: CiErrorData }[];
};
/** Git, without the user's hooks or fsmonitor, and never with a terminal prompt. */
@@ -89,7 +106,7 @@ export async function snapshotWorkingTree(root: string, options: { untracked?: b
for (const file of untracked) bytes += (await stat(join(root, file)).catch(() => ({ size: 0 }))).size;
if (bytes > UNTRACKED_LIMIT_BYTES) throw new CiError({ code: "LOCAL_REVIEW_UNTRACKED_TOO_LARGE", stage: "preflight",
message: `The untracked files add up to ${Math.round(bytes / 1024 / 1024)} MB; they would be uploaded with the EAS build.`,
nextAction: "Ignore or commit the large files, or leave out --include-untracked." });
nextAction: "Ignore or commit the large files, or pass --committed to review HEAD alone." });
must(git(root, ["add", options.untracked ? "-A" : "-u", "--", "."], environment), "Cannot stage the working tree", "Check the repository's state.");
const tree = must(git(root, ["write-tree"], environment), "Cannot write the working tree", "Check the repository's state.");
await rm(index, { force: true });
@@ -173,9 +190,27 @@ export async function installDependencies(project: string, logFile: string, envi
+ "Installs run without credential environment variables: a registry that needs ${NPM_TOKEN} in the project's .npmrc must be authenticated in your own ~/.npmrc instead." });
}
/** `~/.cache/expo-explore/captures/<platform>/<sha>`: one capture per commit and platform, reused while its recipe matches. */
export function captureCacheDirectory(environment: NodeJS.ProcessEnv, platform: ExplorePlatform, sha: string): string {
return join(exploreCacheRoot(environment), "captures", platform, sha);
/** Runs `task` on every item, at most `limit` at once, in order; every task settles, as Promise.allSettled does. */
export async function settleLimited<T, R>(items: readonly T[], limit: number, task: (item: T) => Promise<R>): Promise<PromiseSettledResult<R>[]> {
const results: PromiseSettledResult<R>[] = new Array(items.length);
let next = 0;
const worker = async () => {
while (next < items.length) {
const index = next++;
try { results[index] = { status: "fulfilled", value: await task(items[index]!) }; }
catch (reason) { results[index] = { status: "rejected", reason }; }
}
};
await Promise.all(Array.from({ length: Math.max(1, Math.min(limit, items.length)) }, worker));
return results;
}
/**
* `~/.cache/expo-explore/captures/<target>/<sha>`: one capture per commit and target, reused while its recipe matches.
* A config without targets names them for their platforms, so its captures stay where they were.
*/
export function captureCacheDirectory(environment: NodeJS.ProcessEnv, target: string, sha: string): string {
return join(exploreCacheRoot(environment), "captures", target, sha);
}
async function exists(path: string): Promise<boolean> { try { await lstat(path); return true; } catch { return false; } }
@@ -256,21 +291,80 @@ function recordedSessionIds(outputs: string[]): string[] {
}));
}
/** Stop the EAS Simulator sessions a capture recorded and did not stop itself (an interrupted run), with the local login. */
/** How to stop a recorded session by hand: an EAS Simulator session, or a local simulator or emulator the capture started. */
function stopHint(id: string): string {
const udid = localSimulatorFromState(id);
const serial = localEmulatorFromState(id);
return udid ? `xcrun simctl delete ${udid}` : serial ? `adb -s ${serial} emu kill` : `eas simulator:stop --id ${id}`;
}
/**
* Stop the simulators a capture recorded and did not stop itself (an interrupted run): EAS Simulator sessions with the
* local login, local simulators by deleting them, and local emulators by killing them.
*/
export async function stopRecordedSessions(outputs: string[], environment: NodeJS.ProcessEnv, runner: (args: string[]) => { status: number | null } =
args => spawnSync(packageBin("eas-cli", "eas"), args, { env: environment, encoding: "utf8", timeout: 120_000 }), quiet = false): Promise<string[]> {
args => spawnSync(packageBin("eas-cli", "eas"), args, { env: environment, encoding: "utf8", timeout: 120_000 }), quiet = false,
simctl: (args: string[]) => { status: number | null } = args => spawnSync("xcrun", ["simctl", ...args], { env: environment, encoding: "utf8", timeout: 120_000 }),
adb: (args: string[]) => { status: number | null } = args => spawnSync(androidTools(environment).adb, args, { env: environment, encoding: "utf8", timeout: 60_000 })): Promise<string[]> {
const stopped: string[] = [];
for (const output of outputs) for (const name of ["head-session", "base-session"]) {
const file = join(output, name);
const id = (await readFile(file, "utf8").catch(() => "")).trim();
if (!/^[A-Za-z0-9][A-Za-z0-9._-]{0,199}$/.test(id)) continue;
if (runner(["simulator:stop", "--id", id, "--json", "--non-interactive"]).status === 0) { stopped.push(id); await rm(file, { force: true }); }
const udid = localSimulatorFromState(id);
const serial = localEmulatorFromState(id);
if (udid) simctl(["shutdown", udid]);
const stop = udid ? simctl(["delete", udid]) : serial ? adb(["-s", serial, "emu", "kill"]) : runner(["simulator:stop", "--id", id, "--json", "--non-interactive"]);
if (stop.status === 0) { stopped.push(id); await rm(file, { force: true }); }
// During an interrupt the capture may stop the same session first; only the final pass reports a failure.
else if (!quiet) process.stderr.write(`Could not stop EAS Simulator session ${id}; stop it with: eas simulator:stop --id ${id}\n`);
else if (!quiet) process.stderr.write(`Could not stop simulator ${id}; stop it with: ${stopHint(id)}\n`);
}
return stopped;
}
/**
* What the head of a review without --head is: the working tree, as `eas build` uploads it (tracked and untracked
* files, not ignored ones), unless the app's eas.json sets cli.requireCommit, which makes eas build refuse uncommitted
* changes, or --committed asks for HEAD alone. --head names a commit, so the working tree is never part of it.
*/
export async function reviewHeadSource(options: Pick<LocalReviewOptions, "head" | "committed" | "uncommitted">, project: string):
Promise<"working-tree" | "commit" | "require-commit"> {
const namedHead = options.head !== undefined && options.head !== "HEAD";
if (options.uncommitted && (namedHead || options.committed)) throw new CiError({ code: "LOCAL_REVIEW_UNCOMMITTED_HEAD", stage: "preflight",
message: "--uncommitted reviews the working tree, which is on top of HEAD.", nextAction: `Leave out ${namedHead ? "--head" : "--committed"}, or leave out --uncommitted.` });
if (namedHead || options.committed) return "commit";
if (options.uncommitted) return "working-tree";
let eas: unknown;
try { eas = JSON.parse(await readFile(join(project, "eas.json"), "utf8")); } catch { return "working-tree"; }
const cli = eas !== null && typeof eas === "object" ? (eas as { cli?: unknown }).cli : undefined;
return cli !== null && typeof cli === "object" && (cli as { requireCommit?: unknown }).requireCommit === true ? "require-commit" : "working-tree";
}
/**
* The config a local review runs with: the head commit's; else the one in your checkout, when setup has written it but
* it is not committed yet; else the defaults setup would write, so an app can be reviewed before it is set up. A
* config path passed with --config must be in the head commit.
*/
export async function localReviewConfig(options: { project: string; head: string; configPath: string; explicit: boolean;
platform?: ExplorePlatform | undefined; progress?: Progress }): Promise<ExploreConfig> {
const progress = options.progress ?? silentProgress;
if (options.explicit || await exists(join(options.head, options.configPath))) return readExploreConfig(options.head, options.configPath);
if (await exists(join(options.project, options.configPath))) {
progress(`config: ${options.configPath} from your checkout (it is not in the head commit)`);
return readExploreConfig(options.project, options.configPath);
}
let config: ExploreConfig;
try { config = await defaultExploreConfig(options.project, options.platform); }
catch (error) {
throw new CiError({ code: "LOCAL_REVIEW_CONFIG_DEFAULTS", stage: "preflight",
message: `There is no ${options.configPath}, so this review uses setup's defaults, which need this: ${(error as Error).message}`,
nextAction: "Fix that and rerun (with several simulator profiles, the one named explore is used), or run expo-explore setup to write a config." });
}
progress(`config: none yet, so setup's defaults (${config.app.bundleId}, EAS profile ${config.app.easProfile}, ${config.device.name}); `
+ "expo-explore setup writes one you can change");
return config;
}
export async function runLocalReview(options: LocalReviewOptions): Promise<LocalReviewResult> {
const environment = { ...(options.environment ?? process.env) };
const progress = options.progress ?? silentProgress;
@@ -288,13 +382,13 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
const interrupt = () => {
interrupts += 1;
if (interrupts === 1) {
process.stderr.write("\nStopping the review and its EAS Simulator sessions… (Ctrl+C again to quit now)\n");
process.stderr.write("\nStopping the review and its simulators… (Ctrl+C again to quit now)\n");
abort.abort(new CiError({ code: "LOCAL_REVIEW_INTERRUPTED", stage: "capture", message: "The review was interrupted.", nextAction: "Rerun it when you are ready." }));
if (!options.runner) void stopRecordedSessions(outputs, environment, undefined, true);
return;
}
for (const tree of worktrees) git(root, ["worktree", "remove", "--force", tree]);
for (const id of recordedSessionIds(outputs)) process.stderr.write(`Still running: stop it with eas simulator:stop --id ${id}\n`);
for (const id of recordedSessionIds(outputs)) process.stderr.write(`Still running: stop it with ${stopHint(id)}\n`);
process.exit(130);
};
process.on("SIGINT", interrupt);
@@ -306,14 +400,14 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
// The commits.
const headRef = options.head ?? "HEAD";
let head: LocalReviewResult["head"];
if (options.uncommitted) {
if (options.head && options.head !== "HEAD") throw new CiError({ code: "LOCAL_REVIEW_UNCOMMITTED_HEAD", stage: "preflight",
message: "--uncommitted reviews the working tree, which is on top of HEAD.", nextAction: "Leave out --head, or leave out --uncommitted." });
const snapshot = await snapshotWorkingTree(root, { untracked: options.untracked, work });
const source = await reviewHeadSource(options, project);
if (source === "require-commit") progress("head: HEAD; eas.json sets cli.requireCommit, so uncommitted changes are left out as eas build leaves them out (--uncommitted includes them)");
if (source === "working-tree") {
const snapshot = await snapshotWorkingTree(root, { untracked: true, work });
head = snapshot ? { ref: "uncommitted changes", sha: snapshot.sha, uncommitted: snapshot.changed } : { ref: "HEAD", sha: resolveCommit(root, "HEAD", "head") };
if (snapshot) progress(`head: your uncommitted changes to ${snapshot.changed.length} file${snapshot.changed.length === 1 ? "" : "s"}`
+ (snapshot.untracked.length ? ` (untracked, uploaded with the build and kept in .git/objects until git gc: ${snapshot.untracked.join(", ")})` : ""));
else progress("head: no uncommitted changes, reviewing HEAD");
if (snapshot) progress(`head: HEAD with your uncommitted changes to ${snapshot.changed.length} file${snapshot.changed.length === 1 ? "" : "s"}, as eas build would upload them`
+ (snapshot.untracked.length ? ` (untracked, kept in .git/objects until git gc: ${snapshot.untracked.join(", ")})` : "") + "; --committed leaves them out");
else progress("head: HEAD (no uncommitted changes)");
} else {
const sha = resolveCommit(root, headRef, "head");
head = { ref: reportRef(root, headRef, sha), sha };
@@ -321,7 +415,7 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
const baseSha = options.base ? resolveCommit(root, options.base, "base") : undefined;
const base = options.base && baseSha ? { ref: reportRef(root, options.base, baseSha), sha: baseSha } : defaultBase(root, head.sha);
if (base.sha === head.sha) throw new CiError({ code: "COMPARE_SAME_COMMIT", stage: "preflight", message: `${base.ref} and ${head.ref} are the same commit (${head.sha.slice(0, 8)}).`,
nextAction: "Pass --base with an earlier commit, or --uncommitted to review your uncommitted changes." });
nextAction: "Change something to review it, or pass --base with an earlier commit." });
progress(`comparing ${head.ref} (${head.sha.slice(0, 8)}) with ${base.ref} (${base.sha.slice(0, 8)})`);
// The checkouts, and the config at head.
@@ -333,8 +427,17 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
}
const projects = { base: join(checkouts.base, appDirectory), head: join(checkouts.head, appDirectory) };
const configPath = options.configPath ?? DEFAULT_EXPLORE_CONFIG_PATH;
const rawConfig = await readExploreConfig(projects.head, configPath);
const platforms = options.platform ? [options.platform] : configPlatforms(rawConfig);
const rawConfig = await localReviewConfig({ project, head: projects.head, configPath, explicit: options.configPath !== undefined,
platform: options.platform, progress });
const allTargets = configTargets(rawConfig);
if (options.target !== undefined && !allTargets.some(target => target.id === options.target)) throw new CiError({ code: "TARGET_NOT_CONFIGURED", stage: "preflight",
message: `The config has no target ${options.target}.`, nextAction: `Pass one of: ${allTargets.map(target => target.id).join(", ")}.` });
const targets = allTargets.filter(target => (options.target === undefined || target.id === options.target) && (options.platform === undefined || target.platform === options.platform));
if (!targets.length) throw new CiError({ code: "PLATFORM_NOT_CONFIGURED", stage: "preflight", message: `The config has no ${options.platform} target.`,
nextAction: `Pass one of: ${allTargets.map(target => target.id).join(", ")}.` });
// The reports link to each other's targets (the Viewer's target switch), so they name only the targets this review
// captures: `--target phone` or `--platform ios` makes no report for the others, and a link to one would find nothing.
const platforms = configPlatforms(rawConfig).filter(platform => targets.some(target => target.platform === platform));
const repository = repositoryName(root, rawConfig);
// Credentials: tokens and keys when set, otherwise your own logins.
@@ -347,19 +450,21 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
const subscription = rawConfig.mode === "agent" && rawConfig.agent !== undefined && !environment[AGENT_PROVIDERS[rawConfig.agent.provider].secret]?.trim();
if (subscription) progress(`model: your local ${rawConfig.agent!.provider === "anthropic" ? "claude" : "codex"} login (no ${AGENT_PROVIDERS[rawConfig.agent!.provider].secret} set)`);
let installed = false;
// Every target's capture waits on one install of both commits' dependencies.
let installed: Promise<void> | undefined;
const install = options.install ?? (async (project: string, side: "base" | "head") => {
progress(`installing the ${side} commit's dependencies`);
await installDependencies(project, join(work, `install-${side}.log`), environment);
});
const reports: LocalReviewReport[] = [];
for (const platform of platforms) {
const config = withRunOverrides(resolvePlatformConfig(rawConfig, platform), { scope: options.scope, expiresIn: options.expiresIn });
const output = join(work, platform); await mkdir(output);
// The targets run at once, as CI runs them in parallel jobs: each on its own simulators, with its own output.
const captureTarget = async (target: RunTarget): Promise<LocalReviewReport> => {
const config = withRunOverrides(resolveTargetConfig(rawConfig, { target: target.id }), { scope: options.scope, expiresIn: options.expiresIn, controller: options.controller, simulator: options.simulator, repack: options.repack });
const platform = target.platform;
const output = join(work, target.id); await mkdir(output);
outputs.push(output);
const platformEnvironment = { ...environment };
delete platformEnvironment.EXPLORE_CAPTURE_CACHE;
const cachedBase = captureCacheDirectory(environment, platform, base.sha);
const cachedBase = captureCacheDirectory(environment, target.id, base.sha);
if (options.cache !== false && await exists(join(cachedBase, CACHE_METADATA))) {
platformEnvironment.EXPLORE_CAPTURE_CACHE = cachedBase;
// Reusing a capture counts as using it, so pruning keeps the bases reviews come back to.
@@ -370,10 +475,14 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
const state: PublicCommentState = { phase: "pending", pullRequest: presentation, mode: config.exploration.scope, executionMode: config.mode,
configPath: appDirectory === "." ? configPath : `${appDirectory}/${configPath}`,
links: { viewer: null, download: null, run: "", config: "", artifacts: "" }, startedAt: Date.now(), updatedAt: Date.now(),
build: { platform: config.app.platform, easProfile: config.app.easProfile }, artifactOnly: true };
progress(`${platform}: reviewing`);
build: { platform: config.app.platform, easProfile: config.app.easProfile }, artifactOnly: true,
target, ...(targets.length > 1 ? { targets } : {}) };
progress(`${target.id}: reviewing${target.id === platform ? "" : ` (${target.label})`}`);
const result = await runCiReview({ projects, output, config, presentation, runId, runAttempt: "1", state, environment: platformEnvironment,
...(platforms.length > 1 ? { platforms } : {}), subscription, useLocalEasSession, progress: message => progress(`${platform}: ${message}`),
...(platforms.length > 1 ? { platforms } : {}), ...(targets.length > 1 ? { targets } : {}),
// Targets of one platform capture the same commits from the same build; it is built and repacked once.
...(targets.length > 1 ? { buildShare: join(work, ".builds") } : {}),
subscription, useLocalEasSession, progress: message => progress(`${target.id}: ${message}`),
...(options.runner ? { runner: options.runner } : {}), ...(options.now ? { now: options.now } : {}), ...(options.sleep ? { sleep: options.sleep } : {}),
signal: abort.signal,
// Model requests end on Ctrl+C: the session kills its own process group and restores any login it changed.
@@ -383,11 +492,9 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
preflight: preflightOptions => session.preflight({ ...preflightOptions, signal: preflightOptions?.signal ? AbortSignal.any([preflightOptions.signal, abort.signal]) : abort.signal }),
run: request => session.run({ ...request, signal: request.signal ? AbortSignal.any([request.signal, abort.signal]) : abort.signal }) };
},
prepareCapture: async () => {
if (installed) return;
prepareCapture: () => installed ??= (async () => {
for (const side of ["head", "base"] as const) await install(projects[side], side);
installed = true;
},
})(),
assertCurrentHead: async () => {
abort.signal.throwIfAborted();
for (const side of ["base", "head"] as const) {
@@ -405,20 +512,45 @@ export async function runLocalReview(options: LocalReviewOptions): Promise<Local
await writeFile(zip, await zipReportDirectory(directory));
const input = await readCiReportInput(result.inputPath);
const changes = reviewChangeCount(input.commentState); const device = reviewDevice(input.commentState);
reports.push({ platform, directory, zip, ...(changes === undefined ? {} : { changes }), ...(device ? { device } : {}) });
const report: LocalReviewReport = { platform, target, directory, zip, ...(changes === undefined ? {} : { changes }), ...(device ? { device } : {}) };
// Keep both sides' captures for later reviews of these commits; a working-tree snapshot is never reviewed again.
if (options.cache !== false) for (const side of ["base", "head"] as const) {
if (side === "head" && head.uncommitted) continue;
await keepCapture(join(output, `${side}-export`), captureCacheDirectory(environment, platform, side === "base" ? base.sha : head.sha));
await keepCapture(join(output, `${side}-export`), captureCacheDirectory(environment, target.id, side === "base" ? base.sha : head.sha));
}
if (options.cache !== false) await pruneCaptureCache(environment).catch(() => []);
// The report is all that is kept; the captures, maps and checkouts are the bulk of the run.
for (const entry of await readdir(output)) if (entry !== "report" && entry !== "report.zip") await rm(join(output, entry), { recursive: true, force: true });
abort.signal.throwIfAborted();
}
return report;
};
// Every target finishes or fails on its own, so each stops the simulators it started; then the first failure is the review's.
// Whatever an earlier review stopped hard left running on this machine (simulators, emulators, daemons,
// tool-servers) is stopped first; only what Explore recorded is touched.
const swept = await sweepLocalCaptures({ environment, runner: options.runner ?? defaultRunner, cwd: work }).catch(() => [] as string[]);
if (swept.length) progress(`stopped what an interrupted review left running: ${swept.join(", ")}`);
// A capture worker that exited before its shared build said how it ended would leave the targets waiting on that build
// polling until the review is stopped: its builds are failed instead.
const releaseBuilds = async (target: RunTarget, error: unknown) => {
const failure = toCiError(error);
const side = /^capture-(head|base)$/.exec(failure.stage)?.[1];
if (targets.length > 1 && failure.code === "CAPTURE_WORKER_EXITED" && side) {
await abandonSharedBuilds(join(work, ".builds"), owner => owner === join(work, target.id, `${side}-export`), failure.code);
}
};
const settled = await settleLimited(targets, options.parallel ?? targets.length,
target => captureTarget(target).catch(async (error: unknown) => { await releaseBuilds(target, error).catch(() => undefined); throw error; }));
// One target that fails costs that target's report, not the others': they are kept, and the failure is named.
// Only an interrupted review, or one where every target failed, fails as a whole.
const reports = settled.flatMap(outcome => outcome.status === "fulfilled" ? [outcome.value] : []);
const failed = settled.flatMap((outcome, index) => outcome.status === "rejected" ? [{ target: targets[index]!, reason: outcome.reason as unknown }] : []);
abort.signal.throwIfAborted();
if (!reports.length && failed.length) throw failed[0]!.reason;
const failures = failed.map(({ target, reason }) => ({ target, error: serializeCiError(reason) }));
for (const { target, error } of failures) progress(`${target.id}: no report (${error.code}: ${error.message})`);
if (options.cache !== false) await pruneCaptureCache(environment).catch(() => []);
// The install logs and snapshot index go too; the checkouts are removed with git below.
for (const entry of await readdir(work)) if (![...platforms, "base", "head"].includes(entry)) await rm(join(work, entry), { recursive: true, force: true });
return { runId, base, head, work, reports, config: rawConfig, repository };
for (const entry of await readdir(work)) if (![...targets.map(target => target.id), "base", "head"].includes(entry)) await rm(join(work, entry), { recursive: true, force: true });
return { runId, base, head, work, reports, config: rawConfig, repository, failures };
} catch (error) {
failed = true;
// A capture interrupted mid-session reports its cleanup; the interruption is what happened.
+34 -9
View File
@@ -1,3 +1,4 @@
import type { RunTarget } from "../types.js";
import { spawnSync } from "node:child_process";
import { mkdir, open, readFile, realpath, writeFile } from "node:fs/promises";
import { join, relative, resolve, isAbsolute } from "node:path";
@@ -18,7 +19,7 @@ import { projectComparePresentation, projectPullRequestPresentation, type Review
import { renderPublicComment, platformSectionMerge, type PublicCommentState } from "../report/pr-comment-body.js";
import { upsertStickyComment } from "../report/pr-comment.js";
import { viewerLinks } from "../report/viewer-links.js";
import { DEFAULT_EXPLORE_CONFIG_PATH, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { DEFAULT_EXPLORE_CONFIG_PATH, captureRepack, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { prepareCiExploration, type PrepareCiExplorationOptions } from "../capture/agent/exploration.js";
import { generateAgentChangeNotes } from "../capture/agent/change-notes.js";
import { CiError, serializeCiError, toCiError } from "../shared/ci-errors.js";
@@ -26,6 +27,7 @@ import type { SourceCapturePlan } from "../source/capture-plan.js";
import { createSourceChangeSummaries } from "../source/change-summary.js";
import { assertNoCaptureHealthIssues, partitionCaptureHealthIssues, renderCaptureIssueAnnotation, renderComparisonDiagnosticAnnotation, renderNotesUnavailableAnnotation, renderReviewGapAnnotation, sortedCaptureHealthIssues } from "../capture/health.js";
import { EXPLORE_PACKAGE, packageBin } from "../shared/package-paths.js";
import { agentDeviceLauncher, ensureArgentToolServer, ensureController } from "../shared/controller-cache.js";
import { silentProgress, type Progress } from "../shared/progress.js";
@@ -63,16 +65,25 @@ type CaptureClock = { now?: (() => number) | undefined; sleep?: ((milliseconds:
function captureOptions(config: ExploreConfig, environment: NodeJS.ProcessEnv, runner?: CommandRunner, clock: CaptureClock = {}) {
return { ...(runner && clock.now ? { now: clock.now } : {}), ...(runner && clock.sleep ? { sleep: clock.sleep } : {}), platform: config.app.platform, bundleId: config.app.bundleId,
...(config.app.scheme ? { scheme: config.app.scheme } : {}), device: config.device.name,
...(config.app.scheme ? { scheme: config.app.scheme } : {}), device: config.device.name, ...(config.device.pose ? { devicePose: config.device.pose } : {}),
easProfile: config.app.easProfile, expoToken: environment.EXPO_TOKEN ?? "",
maxScreens: 5000, maxActions: config.capture.maxActions, maxDurationMinutes: config.capture.maxMinutes,
setup: config.setup ?? [], forceFreshBuild: false, confirmExternalRun: true, confirmTrustedSource: true, repack: config.capture.repack, appearance: config.capture.appearance, launch: config.capture.launch, reset: config.capture.reset, unattributed: config.capture.unattributed, ...(config.capture.readinessSeconds !== undefined ? { readinessSeconds: config.capture.readinessSeconds } : {}),
environment, ...(runner ? { runner } : {}), easCommand: packageBin("eas-cli", "eas"), agentDeviceCommand: packageBin("agent-device", "agent-device"), repackCommand: packageBin("@expo/repack-app", "repack-app") };
setup: config.setup ?? [], forceFreshBuild: false, confirmExternalRun: true, confirmTrustedSource: true, repack: captureRepack(config), appearance: config.capture.appearance, launch: config.capture.launch, reset: config.capture.reset, unattributed: config.capture.unattributed, ...(config.capture.readinessSeconds !== undefined ? { readinessSeconds: config.capture.readinessSeconds } : {}), ...(config.capture.controller ? { controller: config.capture.controller } : {}),
...(config.capture.simulator ? { simulator: config.capture.simulator } : {}),
environment, ...(runner ? { runner } : {}), easCommand: packageBin("eas-cli", "eas"), agentDeviceCommand: agentDeviceLauncher(environment), repackCommand: packageBin("@expo/repack-app", "repack-app") };
}
/**
* Head and base run in parallel worker threads when nothing ties them together: an agent session is
* shared, an injected runner belongs to this thread, and a plausible baseline needs head's runtime profile.
*/
/** The controllers a capture of this config runs: agent-device always (it also compares screenshots), Argent when chosen. */
async function prefetchControllers(config: ExploreConfig, environment: NodeJS.ProcessEnv, progress: Progress): Promise<void> {
await ensureController("agent-device", { environment, progress });
if (config.capture.controller === "argent") await ensureController("argent", { environment, progress });
// Argent on a local device also needs its tool-server, installed once before the targets capture side by side.
if (config.capture.controller === "argent" && config.capture.simulator === "local") await ensureArgentToolServer({ environment, progress });
}
export function captureSidesConcurrently(input: { plan: SourceCapturePlan; agent: boolean; injectedRunner: boolean; baselineMayExist: boolean }): boolean {
return !input.agent && !input.injectedRunner && !input.baselineMayExist
&& input.plan.headCaptureSurfaceIds.length > 0 && input.plan.baseCaptureSurfaceIds.length > 0;
@@ -94,8 +105,12 @@ export type PublicCiOptions = {
measure?: Parameters<typeof assessPublicEvidence>[0]["measure"];
/** Set when the workflow passes --platform; artifact and report names then carry the platform suffix. */
platform?: ExplorePlatform;
/** The target id a matrix job captures (--target, or --platform from older workflows): its comment section and names. */
target?: string;
/** Every platform config.yaml captures; recorded in the report so the Viewer links the sibling platform's report. */
platforms?: ExplorePlatform[];
/** Every target config.yaml captures, in config order; recorded in the report so the Viewer links the sibling targets' reports. */
targets?: RunTarget[];
baseProject: string; headProject: string; pullRequestPath: string; output: string;
config: ExploreConfig; configPath?: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch;
now?: () => number; sleep?: (milliseconds: number) => void; onComment?: (state: PublicCommentState, body: string) => void;
@@ -113,7 +128,7 @@ function assertRunIdentity(environment: NodeJS.ProcessEnv): void {
}
/** What both CI adapters check before capture: exact checkouts of both sides and an output outside them. */
async function prepareCiRun(options: Pick<PublicCiOptions, "baseProject" | "headProject" | "output" | "config" | "configPath" | "now">,
async function prepareCiRun(options: Pick<PublicCiOptions, "baseProject" | "headProject" | "output" | "config" | "configPath" | "now" | "targets">,
environment: NodeJS.ProcessEnv, presentation: ReviewPresentation) {
const now = options.now ?? Date.now;
const config = options.config;
@@ -134,7 +149,8 @@ async function prepareCiRun(options: Pick<PublicCiOptions, "baseProject" | "head
executionMode: config.mode, configPath: repositoryConfigPath,
links: viewerLinks({ repository: presentation.repository, headSha: presentation.head.sha, runId: environment.GITHUB_RUN_ID!,
runAttempt: environment.GITHUB_RUN_ATTEMPT!, configPath: repositoryConfigPath }),
startedAt: now(), updatedAt: now(), build: { platform: config.app.platform, easProfile: config.app.easProfile }, artifactOnly: true };
startedAt: now(), updatedAt: now(), build: { platform: config.app.platform, easProfile: config.app.easProfile }, artifactOnly: true,
...(config.target ? { target: config.target } : {}), ...(options.targets && options.targets.length > 1 ? { targets: options.targets } : {}) };
return { projects, output, state };
}
@@ -161,7 +177,7 @@ export async function runPublicCi(options: PublicCiOptions) {
const postComment = async () => {
await assertCurrentPr();
state.updatedAt = now(); const body = renderPublicComment(state); options.onComment?.(state, body);
try { await upsertStickyComment({ repository: pr.repository, issueNumber: pr.number, body, ...platformSectionMerge(state, options.platform), token: githubToken, fetchImpl: transport }); }
try { await upsertStickyComment({ repository: pr.repository, issueNumber: pr.number, body, ...platformSectionMerge(state, options.target ?? options.platform), token: githubToken, fetchImpl: transport }); }
catch (error) { process.stderr.write(`Progress comment unavailable: ${serializeCiError(error).message}\n`); }
};
let prVerificationFailed = false;
@@ -234,6 +250,10 @@ export async function runCiReview(options: {
projects: { base: string; head: string }; output: string; config: ExploreConfig;
presentation: ReviewPresentation; runId: string; runAttempt: string;
platforms?: ExplorePlatform[];
/** Every target config.yaml captures; `config.target` is the one this review captures. */
targets?: RunTarget[];
/** A folder shared with the other targets' reviews, so the targets of one platform build each commit once. */
buildShare?: string;
measure?: Parameters<typeof assessPublicEvidence>[0]["measure"];
state: PublicCommentState; environment: NodeJS.ProcessEnv;
assertCurrentHead: () => Promise<void>; postComment: () => Promise<void>; canPublish?: () => boolean;
@@ -246,6 +266,9 @@ export async function runCiReview(options: {
}) {
const { projects, output, config, environment, state, assertCurrentHead, postComment } = options;
const progress = options.progress ?? silentProgress;
// The controllers are fetched before any EAS work, so a blocked download fails before a session is paid for. agent-device
// also compares the screenshots. An injected runner (tests) runs no real controller.
if (!options.runner) await prefetchControllers(config, environment, progress);
const pr = options.presentation;
const now = options.now ?? Date.now;
const secretValues = Object.entries(environment).filter(([key]) => /(?:TOKEN|SECRET|PASSWORD|API_KEY)/i.test(key)).flatMap(([, value]) => value ? [value] : []);
@@ -301,7 +324,7 @@ export async function runCiReview(options: {
...(exploration.agent ? { agent: exploration.agent } : {}), project: projects[side],
mapDirectory: join(output, `${side}-map`), outputDirectory: directory,
name: config.app.name ?? pr.repository, buildId: pr.origin === "local" ? `local-${pr.runId}-${side}` : pr.origin === "compare" ? `compare-${options.runId}-${side}` : `pr-${pr.number}-${side}`, buildVersion: pr[side].sha.slice(0, 8), gitCommit: pr[side].sha,
planPath: join(output, "execution-plan.json"), side, sessionStatePath: join(output, `${side}-session`),
planPath: join(output, "execution-plan.json"), side, sessionStatePath: join(output, `${side}-session`), ...(options.buildShare ? { buildShare: options.buildShare } : {}),
...(reuseDirectory ? { reuseDirectory } : {}), ...(options.signal ? { signal: options.signal } : {}) };
const captured = concurrent
? await runCiMapOnWorker((({ progress: _progress, runner: _runner, agent: _agent, signal: _signal, ...rest }) => rest)(mapOptions), progress, options.signal)
@@ -344,10 +367,11 @@ export async function runCiReview(options: {
stage = "compare";
progress("comparing base and head captures");
const sides = { base: await evidenceSide(join(output, "base-export")), head: await evidenceSide(join(output, "head-export")) };
const evidence = await assessPublicEvidence({ platform: config.app.platform, plan, ...sides, ...(options.measure ? { measure: options.measure } : {}), profile: `${config.app.easProfile}:${config.app.bundleId}`, agentDeviceCommand: packageBin("agent-device", "agent-device") });
const evidence = await assessPublicEvidence({ platform: config.app.platform, plan, ...sides, ...(options.measure ? { measure: options.measure } : {}), profile: `${config.app.easProfile}:${config.app.bundleId}`, agentDeviceCommand: agentDeviceLauncher(options.environment) });
const result = await prepareCaptureReview({ plan, pullRequest: pr, baseDirectory: sides.base.directory, headDirectory: sides.head.directory,
runId: options.runId, runAttempt: options.runAttempt, assertCurrentHead, assessments: evidence.surfaces,
...(options.platforms ? { platforms: options.platforms } : {}),
...(config.target ? { target: config.target } : {}), ...(options.targets ? { targets: options.targets } : {}),
app: { ...(state.build?.appVersion ? { version: state.build.appVersion } : {}),
...(state.build?.appBuildNumber ? { buildNumber: state.build.appBuildNumber } : {}) } });
const contract = quarantineReviewContract(result.review);
@@ -444,6 +468,7 @@ export async function runBaselineCi(options: { platform?: ExplorePlatform; proje
subscription?: boolean }) {
const environment = options.environment ?? process.env;
assertCheckout(options.project, options.sha);
if (!options.runner) await prefetchControllers(options.config, environment, options.progress ?? silentProgress);
const output = resolve(options.output);
const relativeOutput = relative(await realpath(options.project), output);
if (!relativeOutput.startsWith("..") || isAbsolute(relativeOutput)) throw new Error("Baseline output must be outside the source checkout");
+9 -5
View File
@@ -3,7 +3,7 @@ import { appendFile, lstat, mkdir, writeFile } from "node:fs/promises";
import { join, resolve } from "node:path";
import { tmpdir } from "node:os";
import { pathToFileURL } from "node:url";
import { parseTrustedAuthors, DEFAULT_EXPLORE_CONFIG_PATH } from "../config/explore-config.js";
import { isTargetId, parseTrustedAuthors, DEFAULT_EXPLORE_CONFIG_PATH } from "../config/explore-config.js";
import { compareTitle, compareUrl, projectComparePresentation, projectPullRequestPresentation,
type CompareReviewPresentation, type PullRequestPresentation } from "../contracts/review.js";
import { CiError } from "../shared/ci-errors.js";
@@ -109,15 +109,19 @@ type GithubRun = { conclusion: string | null; workflow_id: number; head_sha: str
* `ci:find-baseline`: the newest successful baseline-workflow artifact of exactly this commit, uploaded from the
* default branch of this repository. Its id and run go to the step outputs for actions/download-artifact.
*/
export async function findBaselineArtifact(options: { sha: string; platform?: string; environment?: Environment; transport?: typeof fetch }): Promise<{ id: number; run: number } | undefined> {
export async function findBaselineArtifact(options: { sha: string; target?: string;
/** What callers from before targets pass: a platform is the id of its default target. */ platform?: string; environment?: Environment; transport?: typeof fetch }): Promise<{ id: number; run: number } | undefined> {
const environment = options.environment ?? process.env; const transport = options.transport ?? fetch;
const context = githubContext(environment);
if (!SHA.test(options.sha)) throw new CiError({ code: "SHA_INVALID", stage: "preflight", message: "The base commit must be a full SHA.", nextAction: "Pass --sha with a 40-character commit SHA." });
const target = options.target ?? options.platform ?? "ios";
if (!isTargetId(target)) throw new CiError({ code: "TARGET_INVALID", stage: "preflight", message: `${target} is not a target id.`,
nextAction: "Pass --target with an id from targets: in .expo-explore/config.yaml (ios or android without targets:)." });
const repository = await githubGet<{ default_branch: string }>(`repos/${context.repository}`, context, transport);
const workflow = await githubGet<{ id: number }>(`repos/${context.repository}/actions/workflows/explore-baseline.yml`, context, transport);
if (!repository || !workflow) return undefined;
// Baselines carry the platform suffix; iOS also accepts the unsuffixed name older baseline workflows uploaded.
const names = [`explore-baseline-${options.sha}-${options.platform ?? "ios"}`, ...(options.platform === "android" ? [] : [`explore-baseline-${options.sha}`])];
// Baselines carry the target suffix; target ios also accepts the unsuffixed name older single-platform baseline workflows uploaded.
const names = [`explore-baseline-${options.sha}-${target}`, ...(target === "ios" ? [`explore-baseline-${options.sha}`] : [])];
const artifacts: GithubArtifact[] = [];
for (const name of names) for (let page = 1; page <= 10; page++) {
const listed = await githubGet<{ artifacts: GithubArtifact[] }>(`repos/${context.repository}/actions/artifacts?name=${encodeURIComponent(name)}&per_page=100&page=${page}`, context, transport);
@@ -138,7 +142,7 @@ export async function findBaselineArtifact(options: { sha: string; platform?: st
/**
* `ci:find-baseline` as the workflow runs it: a baseline is optional, so a lookup that fails (a GitHub 5xx, a rate
* limit) is a warning and no baseline, never an error. A `ci:*` error would write explore-diagnostics/error.json,
* which the failure comment would then report as the cause of an unrelated failure, possibly on another platform.
* which the failure comment would then report as the cause of an unrelated failure, possibly on another target.
*/
export async function findOptionalBaseline(options: Parameters<typeof findBaselineArtifact>[0]):
Promise<{ baseline?: { id: number; run: number }; warning?: { code: string; message: string } }> {
+2 -1
View File
@@ -9,7 +9,7 @@ import { command, resultContract, argumentError, validateCommandArguments, flag,
import { help } from "./cli/help.js";
import { listScreens, getScreen, listElements, listObservations, getObservation, nextFrontier, listAttempts, getAttempt, listTransitions, getTransition, neighbors, pathQuery, listJourneys, getJourney, listFrontier, listGaps, summary, search, status, validate, exportArtifacts } from "./cli/map-commands.js";
import { compareCommand, exportWeb, view } from "./cli/catalog-commands.js";
import { ciReport, ciPublish, ciFailure, ciDeploy, ciPullRequest, ciFindBaseline, ciCompareRefs, ciAfterCapture, setup, doctor, sourceVerify, captureReview, captureBaseline, configPlatforms } from "./cli/ci-commands.js";
import { ciReport, ciPublish, ciFailure, ciDeploy, ciPullRequest, ciFindBaseline, ciCompareRefs, ciAfterCapture, setup, doctor, sourceVerify, captureReview, captureBaseline, configPlatforms, configTargetList } from "./cli/ci-commands.js";
import { exploreBinary, exploreSession } from "./cli/binary-commands.js";
import { reports, reportUpload } from "./cli/report-commands.js";
@@ -53,6 +53,7 @@ const handlers: Record<string, () => Promise<void> | void> = {
"capture:baseline": captureBaseline,
"source:verify": sourceVerify,
"config:platforms": configPlatforms,
"config:targets": configTargetList,
doctor,
compare: compareCommand,
view,
+19 -14
View File
@@ -24,12 +24,16 @@ const aliases: Record<string, string> = {
"ci failure": "ci:failure",
"ci deploy": "ci:deploy",
"config platforms": "config:platforms",
"config targets": "config:targets",
};
/** One-word names for commands people type: `capture` is the local review, `capture:review` without its CI flags. */
const shortNames: Record<string, string> = { capture: "capture:review" };
const first = argv[0] ?? "help";
const pair = `${first} ${argv[1] ?? ""}`.trim();
export const command = aliases[pair] ?? first;
export const resultContract = ["source:verify", "capture:review", "capture:baseline", "ci:report", "ci:publish", "ci:failure", "ci:deploy", "ci:pr", "ci:find-baseline", "ci:compare-refs", "ci:after-capture", "config:platforms", "explore:binary", "explore:session", "report:upload", "reports"].includes(command)
export const command = aliases[pair] ?? shortNames[first] ?? first;
export const resultContract = ["source:verify", "capture:review", "capture:baseline", "ci:report", "ci:publish", "ci:failure", "ci:deploy", "ci:pr", "ci:find-baseline", "ci:compare-refs", "ci:after-capture", "config:platforms", "config:targets", "explore:binary", "explore:session", "report:upload", "reports"].includes(command)
? "explore.result" : QUERY_CONTRACT;
const commandArgCount = aliases[pair] ? 2 : 1;
const args = argv.slice(commandArgCount);
@@ -47,10 +51,11 @@ const flagKinds: Record<string, Record<string, "value" | "boolean">> = {
setup: { project: "value", platform: "value", device: "value", scope: "value", profile: "value", "bundle-id": "value", scheme: "value", navigation: "value",
mode: "value", provider: "value", model: "value", param: "value", "app-state": "value", workflows: "boolean", "no-workflows": "boolean",
"non-interactive": "boolean", check: "boolean", force: "boolean", help: "boolean" },
doctor: { project: "value", offline: "boolean", "no-github": "boolean", "check-model": "boolean", capture: "boolean", output: "value", platform: "value", yes: "boolean", help: "boolean" },
"capture:baseline": { project:"value", sha:"value", output:"value", config:"value", platform:"value" },
"source:verify": { "base-project":"value", "head-project":"value", "base-sha":"value", "head-sha":"value", output:"value", config:"value", scope:"value", platform:"value" },
doctor: { project: "value", offline: "boolean", "no-github": "boolean", "check-model": "boolean", capture: "boolean", output: "value", target: "value", platform: "value", controller: "value", simulator: "value", repack: "value", yes: "boolean", help: "boolean" },
"capture:baseline": { project:"value", sha:"value", output:"value", config:"value", target:"value", platform:"value", controller:"value", simulator:"value", repack:"value" },
"source:verify": { "base-project":"value", "head-project":"value", "base-sha":"value", "head-sha":"value", output:"value", config:"value", scope:"value", target:"value", platform:"value" },
"config:platforms": { project:"value", config:"value" },
"config:targets": { project:"value", config:"value" },
"screen:list": { limit: "value", cursor: "value", unexplored: "boolean" },
"screen:get": { id: "value" },
"element:list": {
@@ -80,23 +85,23 @@ const flagKinds: Record<string, Record<string, "value" | "boolean">> = {
validate: {},
export: { output: "value" },
"export:web": {catalog:"value",output:"value"},
"capture:review": { "base-project":"value", "head-project":"value", "pull-request":"value", compare:"value", output:"value", config:"value", platform:"value", scope:"value", "expires-in":"value",
base:"value", head:"value", project:"value", uncommitted:"boolean", "include-untracked":"boolean", upload:"boolean", "no-open":"boolean", "no-cache":"boolean", port:"value" },
"capture:review": { "base-project":"value", "head-project":"value", "pull-request":"value", compare:"value", output:"value", config:"value", parallel:"value", target:"value", platform:"value", controller:"value", simulator:"value", repack:"value", scope:"value", "expires-in":"value",
base:"value", head:"value", project:"value", committed:"boolean", uncommitted:"boolean", "include-untracked":"boolean", upload:"boolean", "no-open":"boolean", "no-cache":"boolean", port:"value" },
"explore:binary": { archive:"value", output:"value", platform:"value", device:"value", "bundle-id":"value", "launch-url":"value", hints:"value", "allow-destructive":"value",
"explore:binary": { archive:"value", output:"value", platform:"value", controller:"value", device:"value", "bundle-id":"value", "launch-url":"value", hints:"value", "allow-destructive":"value",
"max-duration-minutes":"value", "max-screens":"value", "max-actions":"value", provider:"value", model:"value", owner:"value", project:"value",
upload:"boolean", "no-upload":"boolean", "expires-in":"value", alias:"value" },
"explore:session": { session:"value", "env-file":"value", "bundle-id":"value", "app-name":"value", "app-version":"value", output:"value", platform:"value", device:"value", "launch-url":"value", hints:"value",
"explore:session": { session:"value", "env-file":"value", "bundle-id":"value", "app-name":"value", "app-version":"value", output:"value", platform:"value", controller:"value", device:"value", "launch-url":"value", hints:"value",
"allow-destructive":"value", "max-duration-minutes":"value", "max-screens":"value", "max-actions":"value", provider:"value", model:"value", owner:"value", project:"value",
upload:"boolean", "expires-in":"value", alias:"value", "no-open":"boolean", port:"value" },
"ci:report": { input:"value", output:"value", platform:"value" },
"ci:publish": { input:"value", "artifact-url":"value", platform:"value", inputs:"value" },
"ci:failure": { pr:"value", head:"value", base:"value", diagnostics:"value", platform:"value" },
"ci:deploy": { input:"value", report:"value", "artifact-url":"value", platform:"value", inputs:"value", reports:"value" },
"ci:report": { input:"value", output:"value", target:"value", platform:"value" },
"ci:publish": { input:"value", "artifact-url":"value", target:"value", platform:"value", inputs:"value" },
"ci:failure": { pr:"value", head:"value", base:"value", diagnostics:"value", target:"value", platform:"value" },
"ci:deploy": { input:"value", report:"value", "artifact-url":"value", target:"value", platform:"value", inputs:"value", reports:"value" },
"ci:pr": { pr:"value", output:"value", "app-dir":"value", config:"value" },
"ci:find-baseline": { sha:"value", platform:"value" },
"ci:find-baseline": { sha:"value", target:"value", platform:"value" },
"ci:compare-refs": { project:"value", base:"value", head:"value", title:"value", output:"value" },
"ci:after-capture": { output:"value", checkout:"value" },
compare: {
+4 -2
View File
@@ -38,13 +38,14 @@ export async function exploreBinary(): Promise<void> {
const expiresAfterDays = expiresInDays(flag("expires-in") ?? "7d");
const platform = flag("platform") === undefined ? undefined : oneOf("platform", ["ios", "android"] as const);
const provider = flag("provider") === undefined ? undefined : oneOf("provider", ["anthropic", "openai"] as const);
const controller = flag("controller") === undefined ? undefined : oneOf("controller", ["agent-device", "argent"] as const);
const started = Date.now();
const say = (message: string) => { process.stderr.write(`[explore ${Math.round((Date.now() - started) / 1000)}s] ${message}\n`); };
const allowDestructive = flags("allow-destructive").flatMap(value => value.split(",")).map(value => value.trim()).filter(Boolean);
if (!has("no-upload")) await assertHostingExport();
const result = await runBinaryExploration({
archive: resolve(process.cwd(), archive), output: outputDirectory, progress: say,
...(platform ? { platform } : {}), ...(provider ? { provider } : {}),
...(platform ? { platform } : {}), ...(provider ? { provider } : {}), ...(controller ? { controller } : {}),
...(flag("device") ? { device: flag("device")! } : {}), ...(flag("bundle-id") ? { bundleId: flag("bundle-id")! } : {}),
...(flag("launch-url") ? { launchUrl: flag("launch-url")! } : {}), ...(flag("hints") ? { hints: flag("hints")! } : {}),
...(allowDestructive.length ? { allowDestructive } : {}), ...(flag("model") ? { model: flag("model")! } : {}),
@@ -93,6 +94,7 @@ export async function exploreSession(): Promise<void> {
const expiresAfterDays = expiresInDays(flag("expires-in") ?? "7d");
const platform = flag("platform") === undefined ? undefined : oneOf("platform", ["ios", "android"] as const);
const provider = flag("provider") === undefined ? undefined : oneOf("provider", ["anthropic", "openai"] as const);
const controller = flag("controller") === undefined ? undefined : oneOf("controller", ["agent-device", "argent"] as const);
const port = flag("port") === undefined ? undefined : nonNegativeInteger("port");
const started = Date.now();
const say = (message: string) => { process.stderr.write(`[explore ${Math.round((Date.now() - started) / 1000)}s] ${message}\n`); };
@@ -103,7 +105,7 @@ export async function exploreSession(): Promise<void> {
output: outputDirectory, progress: say,
...(bundleId ? { bundleId } : {}), ...(session ? { session } : {}), ...(envFile ? { envFile } : {}),
...(flag("app-name") ? { appName: flag("app-name")! } : {}), ...(flag("app-version") ? { version: flag("app-version")! } : {}),
...(platform ? { platform } : {}), ...(provider ? { provider } : {}),
...(platform ? { platform } : {}), ...(provider ? { provider } : {}), ...(controller ? { controller } : {}),
...(flag("device") ? { device: flag("device")! } : {}),
...(flag("launch-url") ? { launchUrl: flag("launch-url")! } : {}), ...(flag("hints") ? { hints: flag("hints")! } : {}),
...(allowDestructive.length ? { allowDestructive } : {}), ...(flag("model") ? { model: flag("model")! } : {}),
+61 -33
View File
@@ -15,8 +15,8 @@ import { installCiFiles } from "../ci/workflow-install.js";
import { readRouteEntry } from "../ci/route-entry.js";
import { buildVerifiedPlan } from "../ci/verified-plan.js";
import { formatCaptureCheck, formatDoctorReport, referencedSecretNames, runCaptureCheck, runDoctor } from "../ci/doctor.js";
import { readExploreConfig, readExploreInstructions, resolvePlatformConfig, withRunOverrides, previewDays, configPlatforms as listPlatforms, EXPLORE_PLATFORMS, DEFAULT_EXPLORE_CONFIG_PATH, PREVIEW_DEFAULT_DAYS, type ExplorePlatform } from "../config/explore-config.js";
import { argumentError, output, required, has, flag, flags, nonNegativeInteger, oneOf } from "./args.js";
import { readExploreConfig, readExploreInstructions, resolveTargetConfig, configTargets, isTargetId, withRunOverrides, previewDays, configPlatforms as listPlatforms, EXPLORE_PLATFORMS, DEFAULT_EXPLORE_CONFIG_PATH, PREVIEW_DEFAULT_DAYS, type ExplorePlatform } from "../config/explore-config.js";
import { argumentError, output, required, has, flag, flags, nonNegativeInteger, oneOf, positiveInteger } from "./args.js";
import { help } from "./help.js";
import { CiError } from "../shared/ci-errors.js";
import { cleanupAfterCapture, findOptionalBaseline, resolveCompareRefs, resolvePullRequest, writeCaptureOutputs, writeStepOutputs } from "../ci/workflow-steps.js";
@@ -26,7 +26,7 @@ export async function doctor(): Promise<void> {
if (has("help")) return help();
const project = flag("project") ?? process.cwd();
const report = await runDoctor({ project, online: !has("offline"), github: !has("no-github") && !has("offline"),
checkModel: has("check-model") });
checkModel: has("check-model"), controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack") });
if (!has("capture")) {
if (has("json")) output({ ...report });
else console.log(formatDoctorReport(report));
@@ -53,7 +53,7 @@ Fix the problems in steps 1–5 before a capture check.`);
let result: Awaited<ReturnType<typeof runCaptureCheck>>;
try {
const platform = platformFlag();
result = await runCaptureCheck({ project, ...(platform ? { platform } : {}), output: resolve(flag("output") ?? await mkdtemp(join(tmpdir(), "expo-explore-capture-"))), progress: stderrProgress() });
result = await runCaptureCheck({ project, ...(platform ? { platform } : {}), target: targetFlag(), controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack"), output: resolve(flag("output") ?? await mkdtemp(join(tmpdir(), "expo-explore-capture-"))), progress: stderrProgress() });
} catch (error) {
// A refusal before any EAS work: show it with its next action next to the static report.
if (!(error instanceof CiError)) throw error;
@@ -84,20 +84,20 @@ export async function ciDeploy(): Promise<void> {
}
export async function ciPublish(): Promise<void> {
const platform = platformFlag();
output({ ok: true, ...await publishCiReportComment({ inputPath: required("input"), artifactUrl: required("artifact-url"), ...(platform ? { platform } : {}) }) });
const platform = platformFlag(), target = targetFlag();
output({ ok: true, ...await publishCiReportComment({ inputPath: required("input"), artifactUrl: required("artifact-url"), ...(platform ? { platform } : {}), ...(target ? { target } : {}) }) });
}
/** The failure job's comment for a job that died before Explore could post its own: `ci:failure --pr N --head SHA --base SHA [--diagnostics DIR] [--platform P]`. */
export async function ciFailure(): Promise<void> {
const platform = platformFlag();
const platform = platformFlag(), target = targetFlag();
const repository = process.env.GITHUB_REPOSITORY, runId = process.env.GITHUB_RUN_ID, runAttempt = process.env.GITHUB_RUN_ATTEMPT;
if (!repository || !runId || !runAttempt) throw new CiError({ code: "CONFIG_MISSING", stage: "preflight", message: "GITHUB_REPOSITORY, GITHUB_RUN_ID and GITHUB_RUN_ATTEMPT are required",
nextAction: "Run ci:failure inside the GitHub Actions failure job." });
const pullNumber = Number(required("pr"));
if (!Number.isSafeInteger(pullNumber) || pullNumber <= 0) { output({ ok: true, posted: false, reason: "No PR number: the capture job never started." }); return; }
output({ ok: true, ...await publishFailureComment({ repository, pullNumber, headSha: required("head"), baseSha: required("base"), runId, runAttempt,
...(has("diagnostics") ? { diagnosticsPath: required("diagnostics") } : {}), ...(platform ? { platform } : {}) }) });
...(has("diagnostics") ? { diagnosticsPath: required("diagnostics") } : {}), ...(platform ? { platform } : {}), ...(target ? { target } : {}) }) });
}
/** `ci:pr --pr N [--output FILE]`: the live, authorized pull request; its commits go to the step outputs. */
@@ -111,8 +111,8 @@ export async function ciPullRequest(): Promise<void> {
/** `ci:find-baseline --sha SHA [--platform P]`: a reusable baseline artifact of the base commit, if one exists. */
export async function ciFindBaseline(): Promise<void> {
const platform = platformFlag();
const { baseline, warning } = await findOptionalBaseline({ sha: required("sha"), ...(platform ? { platform } : {}) });
const platform = platformFlag(), target = targetFlag();
const { baseline, warning } = await findOptionalBaseline({ sha: required("sha"), ...(platform ? { platform } : {}), ...(target ? { target } : {}) });
if (baseline) await writeStepOutputs(process.env, { id: String(baseline.id), run: String(baseline.run) });
if (warning && process.env.GITHUB_ACTIONS) console.log(`::warning title=${warning.code}::${warning.message.replace(/[\r\n]+/g, " ")}`);
output({ ok: true, baseline: baseline ?? null, ...(warning ? { warning } : {}) });
@@ -140,10 +140,29 @@ export function platformFlag(): ExplorePlatform | undefined {
return has("platform") ? oneOf("platform", EXPLORE_PLATFORMS) : undefined;
}
/** The platforms config.yaml captures, for the review workflow's matrix. */
/** The `--target` flag, when given: the config.yaml target to capture. */
export function targetFlag(): string | undefined {
const value = flag("target");
if (value !== undefined && !isTargetId(value)) argumentError("--target must be a target id from config.yaml: lowercase letters, digits and dashes.", "target");
return value;
}
/** The target `--target` (or `--platform`, from workflows installed before targets) selects. */
function targetSelection(): { target?: string; platform?: ExplorePlatform } {
const target = targetFlag(), platform = platformFlag();
return { ...(target ? { target } : {}), ...(platform ? { platform } : {}) };
}
/** The targets config.yaml captures, as ids (the review workflow's matrix); workflows installed before targets read them as platforms. */
export async function configPlatforms(): Promise<void> {
const config = await readExploreConfig(flag("project") ?? process.cwd(), flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH);
output({ ok: true, platforms: listPlatforms(config) });
output({ ok: true, platforms: configTargets(config).map(target => target.id) });
}
/** The targets config.yaml captures, in order, with their platforms and labels: the review workflow's matrix. */
export async function configTargetList(): Promise<void> {
const config = await readExploreConfig(flag("project") ?? process.cwd(), flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH);
output({ ok: true, targets: configTargets(config) });
}
async function exists(path: string): Promise<boolean> {
@@ -189,7 +208,7 @@ export async function setup(): Promise<void> {
export async function sourceVerify(): Promise<void> {
const headProject = required("head-project");
const config = resolvePlatformConfig(await readExploreConfig(headProject, flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH), platformFlag());
const config = resolveTargetConfig(await readExploreConfig(headProject, flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH), targetSelection());
const scope = oneOf("scope", ["all", "changes"] as const, config.exploration.scope);
const plan = await buildVerifiedPlan({ baseProject: required("base-project"), headProject,
baseSha: required("base-sha"), headSha: required("head-sha"), config, scope, output: required("output") });
@@ -201,11 +220,14 @@ export async function captureReview(): Promise<void> {
if (!has("base-project") && !has("head-project") && !has("pull-request") && !has("compare")) return localReview();
const headProject = required("head-project");
const configPath = flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH;
const platform = platformFlag();
const selection = targetSelection();
const rawConfig = await readExploreConfig(headProject, configPath);
const config = withRunOverrides(resolvePlatformConfig(rawConfig, platform), { scope: flag("scope"), expiresIn: flag("expires-in") });
const config = withRunOverrides(resolveTargetConfig(rawConfig, selection), { scope: flag("scope"), expiresIn: flag("expires-in"), controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack") });
if (has("pull-request") === has("compare")) argumentError("Pass --pull-request FILE for a pull request, or --compare FILE for any two commits.", has("compare") ? "compare" : "pull-request");
const common = { ...(platform ? { platform } : {}), platforms: listPlatforms(rawConfig), baseProject: required("base-project"), headProject,
// A matrix job names its target; its artifacts, report and comment section carry the target's id.
const named = selection.target !== undefined || selection.platform !== undefined;
const common = { ...(named ? { target: config.target!.id } : {}), ...(selection.platform ? { platform: selection.platform } : {}),
platforms: listPlatforms(rawConfig), targets: configTargets(rawConfig), baseProject: required("base-project"), headProject,
output: required("output"), config, configPath, progress: stderrProgress() };
const result = has("compare") ? await runCompareCi({ ...common, comparePath: required("compare") })
: await runPublicCi({ ...common, pullRequestPath: required("pull-request") });
@@ -216,35 +238,41 @@ export async function captureReview(): Promise<void> {
export async function captureBaseline(): Promise<void> {
const project = required("project");
const platform = platformFlag();
const config = resolvePlatformConfig(await readExploreConfig(project, flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH), platform);
output({ ok: true, ...await runBaselineCi({ ...(platform ? { platform } : {}), project, sha: required("sha"), output: required("output"), config, progress: stderrProgress() }) });
const config = withRunOverrides(resolveTargetConfig(await readExploreConfig(project, flag("config") ?? DEFAULT_EXPLORE_CONFIG_PATH), targetSelection()), { controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack") });
output({ ok: true, ...await runBaselineCi({ platform: config.app.platform, project, sha: required("sha"), output: required("output"), config, progress: stderrProgress() }) });
}
/** `capture:review [--base REF] [--head REF | --uncommitted]`: a local review, opened in the Viewer or hosted with --upload. */
/** `capture` (or `capture:review`) `[--base REF] [--head REF | --committed]`: a local review, opened in the Viewer or hosted with --upload. */
async function localReview(): Promise<void> {
const platform = platformFlag();
const result = await runLocalReview({ project: flag("project") ?? process.cwd(), base: flag("base"), head: flag("head"),
uncommitted: has("uncommitted"), untracked: has("include-untracked"), ...(platform ? { platform } : {}),
scope: flag("scope"), expiresIn: flag("expires-in"), cache: !has("no-cache"), configPath: flag("config"), progress: stderrProgress() });
const platform = platformFlag(), target = targetFlag();
const parallel = has("parallel") ? positiveInteger("parallel") : undefined;
const result = await runLocalReview({ project: flag("project") ?? process.cwd(), base: flag("base"), head: flag("head"), ...(target ? { target } : {}),
...(parallel ? { parallel } : {}),
// --include-untracked is accepted from before untracked files were included by default.
committed: has("committed"), uncommitted: has("uncommitted"), ...(platform ? { platform } : {}),
scope: flag("scope"), expiresIn: flag("expires-in"), controller: flag("controller"), simulator: flag("simulator"), repack: flag("repack"), cache: !has("no-cache"), configPath: flag("config"), progress: stderrProgress() });
if (has("output")) {
for (const report of result.reports) {
const target = resolve(required("output"), report.platform);
await cp(report.directory, join(target, "report"), { recursive: true });
await cp(report.zip, join(target, "report.zip"));
report.directory = join(target, "report"); report.zip = join(target, "report.zip");
const destination = resolve(required("output"), report.target.id);
await cp(report.directory, join(destination, "report"), { recursive: true });
await cp(report.zip, join(destination, "report.zip"));
report.directory = join(destination, "report"); report.zip = join(destination, "report.zip");
}
// The reports now live under --output; the temporary copies are not needed.
await rm(result.work, { recursive: true, force: true });
}
const summary = { ok: true, runId: result.runId, base: result.base, head: result.head,
reports: result.reports.map(({ platform, directory, zip, changes, device }) => ({ platform, directory, zip, ...(changes === undefined ? {} : { changes }), ...(device ? { device } : {}) })) };
const zips = await Promise.all(result.reports.map(async report => ({ platform: report.platform, zip: new Uint8Array(await readFile(report.zip)),
// A target that failed outright has no report; the others still open, save and upload, and the command exits 1.
if (result.failures.length) process.exitCode = 1;
const summary = { ok: result.failures.length === 0, runId: result.runId, base: result.base, head: result.head,
...(result.failures.length ? { failures: result.failures.map(({ target, error }) => ({ target: target.id, code: error.code, message: error.message })) } : {}),
reports: result.reports.map(({ platform, target, directory, zip, changes, device }) => ({ platform, target: target.id, label: target.label, directory, zip,
...(changes === undefined ? {} : { changes }), ...(device ? { device } : {}) })) };
const zips = await Promise.all(result.reports.map(async report => ({ platform: report.platform, target: report.target, zip: new Uint8Array(await readFile(report.zip)),
...(report.changes === undefined ? {} : { changes: report.changes }), ...(report.device ? { device: report.device } : {}) })));
// Kept among the saved runs, with the commits' subjects (an uncommitted head is named by the commit under it).
const project = resolve(flag("project") ?? process.cwd());
const headSubject = commitSubject(project, result.head.uncommitted ? `${result.head.sha}^` : result.head.sha), baseSubject = commitSubject(project, result.base.sha);
const saved = await keepReports(zips.map(({ platform, zip }) => ({ platform, zip })), { subjects: { ...(headSubject ? { head: headSubject } : {}), ...(baseSubject ? { base: baseSubject } : {}) },
const saved = await keepReports(zips.map(({ platform, target, zip }) => ({ platform, target, zip })), { subjects: { ...(headSubject ? { head: headSubject } : {}), ...(baseSubject ? { base: baseSubject } : {}) },
...(result.head.uncommitted?.length ? { uncommittedFiles: result.head.uncommitted.length } : {}) });
if (has("upload")) {
const preview = result.config.report?.preview;
@@ -261,7 +289,7 @@ async function localReview(): Promise<void> {
}
if (has("json") || has("no-open")) {
if (has("json")) output(summary);
else for (const report of result.reports) console.log(`${report.platform}: ${report.zip}`);
else for (const report of result.reports) console.log(`${report.target.id}: ${report.zip}`);
return;
}
const server = await startLocalReportServer({ reports: zips, ...(has("port") ? { port: nonNegativeInteger("port") } : {}) });
+31 -16
View File
@@ -15,13 +15,24 @@ const GET_STARTED = `Get started (run these in the Expo app's directory):
doctor [--project DIRECTORY] [--offline] [--no-github] [--check-model] [--json]
(checks every setup step and prints the next action for each problem; exits 1 until ready)
(--offline skips EAS and GitHub; --check-model sends one small request with the local provider key)
doctor --capture [--project DIRECTORY] [--output DIRECTORY] [--platform ios|android] [--yes]
doctor --capture [--project DIRECTORY] [--output DIRECTORY] [--target ID | --platform ios|android] [--controller agent-device|argent] [--simulator eas|local] [--repack eas|local] [--yes]
(captures the committed HEAD like the baseline workflow, with your eas login, and reports each route)
capture:review [--base REF] [--head REF | --uncommitted [--include-untracked]] [--platform ios|android] [--scope all|changes]
[--upload [--expires-in 7d|30d|never]] [--no-open] [--no-cache] [--output DIRECTORY] [--project DIRECTORY]
capture [--base REF] [--head REF | --committed] [--target ID | --platform ios|android] [--parallel N] [--scope all|changes]
[--controller agent-device|argent] [--simulator eas|local] [--repack eas|local] [--upload [--expires-in 7d|30d|never]] [--no-open] [--no-cache] [--output DIRECTORY] [--project DIRECTORY]
(on this machine: checks out both commits in temporary worktrees, captures them with your eas login and your
local claude or codex login, and opens the report; the base defaults to where HEAD left the default branch;
it runs both commits' code as you, so review only commits you would run)
local claude or codex login, and opens the report; the head is HEAD with your uncommitted changes, as eas build
uploads them (--committed, or cli.requireCommit in eas.json, leaves them out); the base defaults to where HEAD
left the default branch;
without .expo-explore/config.yaml it uses the defaults setup would write;
it runs both commits' code as you, so review only commits you would run; capture:review is the same command;
--controller argent drives the simulator with Argent instead of agent-device, the default (or set
capture.controller in config.yaml); on EAS Simulator Argent captures one appearance, since it cannot switch it yet;
--simulator local runs each commit on a simulator (Xcode) or emulator (Android SDK) Explore starts on this
machine, instead of EAS Simulator, and removes it afterwards (or set capture.simulator in config.yaml); builds
still run on EAS, and the host switches appearance for either controller; the app is repacked with the route
observer on this machine too (--repack eas, or capture.repack, keeps the hosted EAS job);
with targets in config.yaml it reviews them at once (--parallel N at most N at a time; the targets of a platform
share each commit's build), --target ID one of them, --platform those of a platform)
view [--catalog FILE] [--port N] [--no-open]
(opens a report in the Viewer)
reports [list | open ID | add REPORT... | upload ID | rm ID | prune] [--all] [--json]
@@ -37,6 +48,7 @@ const BINARY = `Prebuilt apps (no source needed; runs on EAS Simulator with your
(installs the archive in a fresh EAS Simulator session, lets the model explore it, writes a map
and report under --output, hosts the report on EAS Hosting, and prints the link)
Flags, all optional: --device NAME --bundle-id ID --launch-url URL --hints "what to focus on"
--controller agent-device|argent (the session's device controller; agent-device by default)
(a sign-in in --hints is written as {{secret:NAME}}: Explore types the value of the environment variable NAME,
and the model and the report only see the reference)
--max-duration-minutes N --max-screens N --max-actions N --provider anthropic|openai --model ID
@@ -46,36 +58,39 @@ const BINARY = `Prebuilt apps (no source needed; runs on EAS Simulator with your
(iOS needs a simulator build; a device .ipa and Android .aab are rejected before any session starts)
explore:session [SESSION_ID] [--bundle-id ID] [--output DIRECTORY] [--upload] [--json]
(explores an app that is already installed on an EAS Simulator session you started — run it where
"eas simulator:start --type agent-device --out-config-type dotenv" wrote .env.eas-simulator, or pass
--env-file FILE, or export EAS_SIMULATOR_SESSION_ID, AGENT_DEVICE_DAEMON_BASE_URL and
AGENT_DEVICE_DAEMON_AUTH_TOKEN; writes the map and report, then opens them in the local Viewer;
"eas simulator:start --type agent-device --out-config-type dotenv" (or --type argent) wrote .env.eas-simulator,
or pass --env-file FILE, or export EAS_SIMULATOR_SESSION_ID with AGENT_DEVICE_DAEMON_BASE_URL and
AGENT_DEVICE_DAEMON_AUTH_TOKEN, or with ARGENT_TOOLS_URL and ARGENT_AUTH_TOKEN; writes the map and report, then opens them in the local Viewer;
--upload hosts the report instead, --no-open skips the Viewer; the session is left running;
the app is the one in the foreground, else the only installed one; --bundle-id picks it otherwise)
the app is the one in the foreground, else the only installed one; --bundle-id picks it otherwise;
the controller follows the session's type, and --controller must match it)
Extra flags: --app-name NAME --app-version X.Y --port N, plus the explore:binary budget/model flags
Afterwards: view --dir DIRECTORY, screen:list --dir DIRECTORY, gap:list --dir DIRECTORY`;
const CI = `CI (the installed workflows run these; they manage remote EAS Simulator sessions):
config:targets [--project DIRECTORY] [--config FILE]
(lists the targets config.yaml captures, with their platforms and labels; the review workflow's matrix)
config:platforms [--project DIRECTORY] [--config FILE]
(lists the platforms config.yaml captures; the review workflow's matrix)
capture:review --base-project DIRECTORY --head-project DIRECTORY (--pull-request FILE | --compare FILE)
--output TEMP_DIRECTORY [--config .expo-explore/config.yaml] [--platform ios|android]
--output TEMP_DIRECTORY [--config .expo-explore/config.yaml] [--target ID | --platform ios|android] [--controller agent-device|argent] [--simulator eas|local] [--repack eas|local]
(--compare reviews any two commits without a PR: {"origin":"compare","repositoryId","repository","base":{ref,sha},"head":{ref,sha}})
capture:baseline --project DIRECTORY --sha COMMIT --output TEMP_DIRECTORY [--config FILE] [--platform ios|android]
capture:baseline --project DIRECTORY --sha COMMIT --output TEMP_DIRECTORY [--config FILE] [--target ID | --platform ios|android] [--controller agent-device|argent] [--simulator eas|local] [--repack eas|local]
source:verify --base-project DIRECTORY --head-project DIRECTORY
--base-sha COMMIT --head-sha COMMIT --output DIRECTORY [--config FILE] [--scope all|changes] [--platform ios|android]
--base-sha COMMIT --head-sha COMMIT --output DIRECTORY [--config FILE] [--scope all|changes] [--target ID | --platform ios|android]
compare --baseline DIRECTORY --current DIRECTORY --output FILE
[--review-output FILE] [--catalog-output FILE] [--catalog-name NAME]
[--base-surface-coverage FILE] [--head-surface-coverage FILE]
export:web --catalog FILE --output DIRECTORY
ci:report --input REPORT_INPUT --output DIRECTORY [--platform ios|android]
ci:publish --input REPORT_INPUT --artifact-url GITHUB_ARTIFACT_URL [--platform ios|android]
ci:report --input REPORT_INPUT --output DIRECTORY [--target ID | --platform ios|android]
ci:publish --input REPORT_INPUT --artifact-url GITHUB_ARTIFACT_URL [--target ID | --platform ios|android]
ci:publish --inputs DIRECTORY (one <platform>/ subdirectory per captured platform)
ci:deploy --input REPORT_INPUT --report REPORT_DIR --artifact-url GITHUB_ARTIFACT_URL [--platform ios|android]
ci:deploy --input REPORT_INPUT --report REPORT_DIR --artifact-url GITHUB_ARTIFACT_URL [--target ID | --platform ios|android]
ci:deploy --inputs DIRECTORY --reports DIRECTORY
ci:pr --pr N [--output FILE] [--app-dir DIRECTORY]
(resolves the live PR and refuses it unless it is open, from this repository, and by a trusted author)
ci:compare-refs --project DIRECTORY --base REF --head REF [--output FILE]
ci:find-baseline --sha COMMIT [--platform ios|android]
ci:find-baseline --sha COMMIT [--target ID | --platform ios|android]
ci:after-capture --output TEMP_DIRECTORY --checkout DIRECTORY...
(stops the capture's EAS Simulator sessions and checks capture left each checkout unchanged)
(the ci:* commands write their results to $GITHUB_OUTPUT for the next steps)`;
+16 -16
View File
@@ -3,10 +3,10 @@ import { readFile, stat } from "node:fs/promises";
import { basename, dirname, join, relative, resolve, sep } from "node:path";
import { DEFAULT_BINARY_PROJECT } from "../binary/run.js";
import { pruneCaptureCache, repositoryName } from "../ci/local-review.js";
import { readExploreConfig, previewDays, DEFAULT_EXPLORE_CONFIG_PATH, PREVIEW_DEFAULT_DAYS, type ExploreConfig, type ExplorePlatform } from "../config/explore-config.js";
import { readExploreConfig, previewDays, DEFAULT_EXPLORE_CONFIG_PATH, PREVIEW_DEFAULT_DAYS, type ExploreConfig } from "../config/explore-config.js";
import { assertHostingExport, deployLocalReports, previewProjectSlug, readReportZip, zipReportDirectory, MAX_REPORT_BYTES, type ReportZipSummary } from "../report/preview-deploy.js";
import { startLocalReportServer } from "../report/local-report-server.js";
import { findSavedRun, listSavedRuns, pruneSavedRuns, readSavedReports, removeSavedRun, saveRun, savedRunsDirectory, SAVED_RUN_LIMITS, type SavedReport, type SavedRun } from "../report/saved-runs.js";
import { findSavedRun, listSavedRuns, pruneSavedRuns, readSavedReports, removeSavedRun, reportTarget, saveRun, savedRunsDirectory, SAVED_RUN_LIMITS, type SavedReport, type SavedRun } from "../report/saved-runs.js";
import { openViewerInBrowser } from "../map/viewer-server.js";
import { formatBytes, friendlyTime, kindLabel, runPicker, runTitle } from "./reports-picker.js";
import { pickIntro } from "./title-intros.js";
@@ -70,18 +70,18 @@ async function repositoryPreview(repository: string): Promise<{ preview: Preview
type ReadReport = Awaited<ReturnType<typeof readReport>>;
/** Several reports share one link only as one review's platforms; an exploration goes up on its own. */
/** Several reports share one link only as one review's targets; an exploration goes up on its own. */
function assertOneReview(reports: ReadReport[]): void {
const [first, ...others] = reports as [ReadReport, ...ReadReport[]];
const platforms = new Set<ExplorePlatform>([first.summary.platform]);
const targets = new Set<string>([first.summary.target.id]);
for (const report of others) {
if (platforms.has(report.summary.platform)) throw new CiError({ code: "PREVIEW_REPORTS_INVALID", stage: "preflight",
message: `More than one ${report.summary.platform} report: one link holds one report per platform.`, nextAction: "Upload each platform's report once." });
platforms.add(report.summary.platform);
if (targets.has(report.summary.target.id)) throw new CiError({ code: "PREVIEW_REPORTS_INVALID", stage: "preflight",
message: `More than one ${report.summary.target.id} report: one link holds one report per target.`, nextAction: "Upload each target's report once." });
targets.add(report.summary.target.id);
const a = first.summary, b = report.summary;
if (a.kind !== "review" || b.kind !== "review" || a.repository !== b.repository || a.runId !== b.runId || a.base !== b.base || a.head !== b.head) {
throw new CiError({ code: "PREVIEW_REPORTS_MISMATCH", stage: "preflight", message: `${first.path} and ${report.path} are not the same review's platforms.`,
nextAction: "Upload the reports of one review together (one per platform), and anything else on its own." });
throw new CiError({ code: "PREVIEW_REPORTS_MISMATCH", stage: "preflight", message: `${first.path} and ${report.path} are not the same review's targets.`,
nextAction: "Upload the reports of one review together (one per target), and anything else on its own." });
}
}
}
@@ -100,13 +100,13 @@ async function hostReports(reports: ReadReport[]): Promise<void> {
const expiresAfterDays = has("expires-in") ? previewDays(required("expires-in"), "--expires-in")
: preview ? preview.expiresAfterDays : review ? PREVIEW_DEFAULT_DAYS : EXPLORATION_DEFAULT_DAYS;
const hosted = await deployLocalReports({ project, ...(owner ? { owner } : {}), expiresAfterDays,
reports: reports.map(report => ({ platform: report.summary.platform, zip: report.zip,
reports: reports.map(report => ({ platform: report.summary.platform, target: report.summary.target, zip: report.zip,
...(report.summary.changes === undefined ? {} : { changes: report.summary.changes }), ...(report.summary.device ? { device: report.summary.device } : {}) })),
ownerHint: "Pass --owner with the Expo account that should host the report.",
projectHint: "Give this EAS login permission to create projects under the owner, or pass --project with an existing project slug." });
if (has("json")) {
output({ ok: true, url: hosted.previewUrl, expiresAt: hosted.expiresAt, project: hosted.project, owner: hosted.owner,
reports: reports.map(report => ({ path: report.path, platform: report.summary.platform, kind: report.summary.kind })) });
reports: reports.map(report => ({ path: report.path, platform: report.summary.platform, target: report.summary.target.id, kind: report.summary.kind })) });
return;
}
console.log(`Report: ${hosted.previewUrl}${hosted.expiresAt ? ` (until ${hosted.expiresAt.slice(0, 10)})` : ""}`);
@@ -141,7 +141,7 @@ export async function reportUpload(): Promise<void> {
assertOneReview(reports);
const review = reports[0]!.summary.kind === "review" ? reports[0]!.summary : undefined;
const head = review && commitSubject(process.cwd(), review.head), base = review && commitSubject(process.cwd(), review.base);
await keepReports(reports.map(report => ({ platform: report.summary.platform, zip: report.zip })), { subjects: { ...(head ? { head } : {}), ...(base ? { base } : {}) } });
await keepReports(reports.map(report => ({ platform: report.summary.platform, target: report.summary.target, zip: report.zip })), { subjects: { ...(head ? { head } : {}), ...(base ? { base } : {}) } });
await hostReports(reports);
}
@@ -171,14 +171,14 @@ async function savedRun(id: string | undefined): Promise<SavedRun> {
async function uploadSavedRun(run: SavedRun): Promise<void> {
const reports: ReadReport[] = [];
for (const report of await readSavedReports(run)) reports.push({ path: `${run.id}/${report.platform}.zip`, zip: report.zip, summary: await readReportZip(report.zip) });
for (const report of await readSavedReports(run)) reports.push({ path: `${run.id}/${reportTarget(report).id}.zip`, zip: report.zip, summary: await readReportZip(report.zip) });
await hostReports(reports);
}
function listLines(runs: SavedRun[], now = Date.now()): string[] {
if (!runs.length) return ["No saved runs yet. expo-explore capture:review reviews your branch on this machine, and its report is kept here."];
if (!runs.length) return ["No saved runs yet. expo-explore capture reviews your branch on this machine, and its report is kept here."];
const idWidth = Math.max(...runs.map(run => run.id.length));
return [...runs.map(run => `${run.id.padEnd(idWidth)} ${kindLabel(run).padEnd(9)}${runTitle(run)} (${run.platforms.join(", ")}, ${friendlyTime(run.createdAt, now)})`),
return [...runs.map(run => `${run.id.padEnd(idWidth)} ${kindLabel(run).padEnd(9)}${runTitle(run)} (${(run.targets?.map(target => target.id) ?? run.platforms).join(", ")}, ${friendlyTime(run.createdAt, now)})`),
"", "Open one with: expo-explore reports open <id>"];
}
@@ -204,7 +204,7 @@ export async function reports(): Promise<void> {
assertOneReview(read);
const review = read[0]!.summary.kind === "review" ? read[0]!.summary : undefined;
const head = review && commitSubject(process.cwd(), review.head), base = review && commitSubject(process.cwd(), review.base);
const run = await saveRun(read.map(report => ({ platform: report.summary.platform, zip: report.zip })), { subjects: { ...(head ? { head } : {}), ...(base ? { base } : {}) } });
const run = await saveRun(read.map(report => ({ platform: report.summary.platform, target: report.summary.target, zip: report.zip })), { subjects: { ...(head ? { head } : {}), ...(base ? { base } : {}) } });
if (has("json")) output({ ok: true, run }); else console.log(`Kept ${runTitle(run)} as ${run.id}.`);
return;
}
+5 -4
View File
@@ -76,7 +76,8 @@ export function runTitle(run: SavedRun): string {
}
const PLATFORM_NAMES: Record<string, string> = { ios: "iOS", android: "Android" };
const platforms = (run: SavedRun) => run.platforms.map(platform => PLATFORM_NAMES[platform] ?? platform).join(" ");
// A run's targets by label, else its platforms by name, as runs saved before targets list them.
const platforms = (run: SavedRun) => run.targets?.map(target => target.label).join(", ") ?? run.platforms.map(platform => PLATFORM_NAMES[platform] ?? platform).join(" ");
/** The runs the list shows: this repository's (or all) that match the filter, across title, refs, subjects, SHAs and PR number. */
export function visibleRuns(state: PickerState): SavedRun[] {
@@ -88,8 +89,8 @@ export function visibleRuns(state: PickerState): SavedRun[] {
function counts(run: SavedRun, paint: Paint): string {
if (run.explored) return `${paint.text(String(run.explored.screens))} ${paint.dim("screens")} ${paint.dim(`${run.explored.unexplored} unexplored`)}`;
const parts = ([["modified", paint.amber, "modified"], ["added", paint.green, "added"], ["removed", paint.red, "removed"], ["needs-review", paint.yellow, "need review"],
["source-affected", paint.yellow, "source-affected"]] as const)
const parts = ([["modified", paint.amber, "modified"], ["accessibility-only", paint.blue, "accessibility only"], ["added", paint.green, "added"], ["removed", paint.red, "removed"],
["needs-review", paint.yellow, "need review"]] as const)
.filter(([group]) => run.changes?.[group]).map(([group, colour, label]) => `${colour(String(run.changes![group]))} ${paint.dim(label)}`);
return parts.length ? parts.join(" ") : paint.dim("no visible changes");
}
@@ -129,7 +130,7 @@ export function renderPicker(state: PickerState, options: { width: number; heigh
if (!runs.length) {
const empty = state.runs.length
? [` ${paint.dim(state.filter ? `Nothing matches "${state.filter}".` : `No saved runs of ${state.repository}. Press tab for every repository.`)}`]
: [` ${paint.text("No saved runs yet.")}`, ` ${paint.dim("expo-explore capture:review reviews your branch on this machine, and its report is kept here.")}`];
: [` ${paint.text("No saved runs yet.")}`, ` ${paint.dim("expo-explore capture reviews your branch on this machine, and its report is kept here.")}`];
return [...header, ...empty, "", ...footer].map(line => fit(line, width));
}
const selected = runs[Math.min(state.selected, runs.length - 1)]!;
+1 -1
View File
@@ -2,7 +2,7 @@ import { CiError } from "../shared/ci-errors.js";
import type { CaptureSetupAction } from "./explore-config.js";
const TOKEN = /\{\{secret:([A-Z][A-Z0-9_]{0,127})\}\}/g;
const RESERVED = /^(?:GITHUB_|RUNNER_|ACTIONS_|AGENT_DEVICE_|OPENAI_|ANTHROPIC_|EXPO_TOKEN$)/;
const RESERVED = /^(?:GITHUB_|RUNNER_|ACTIONS_|AGENT_DEVICE_|ARGENT_|OPENAI_|ANTHROPIC_|EXPO_TOKEN$)/;
/** References are data, never shell expressions or arbitrary environment access. */
export function explorationSecretNames(text: string): string[] {
+169 -9
View File
@@ -1,3 +1,4 @@
import type { RunTarget } from "../types.js";
import { parseUnattributedSetting, type UnattributedSetting } from "../capture/unattributed.js";
import { parseAppearance, type AppearanceSetting } from "../capture/appearance.js";
import { parseLaunchSetting, type LaunchSetting } from "../capture/launch-capture.js";
@@ -43,22 +44,62 @@ export const DEFAULT_ANDROID_DEVICE = "pixel_7";
* One platform's capture target. `platforms.ios` fields default to the flat `app`/`device` fields;
* `platforms.android` needs its own package and EAS profile (an `android.buildType: apk` profile).
*/
/** The poses a foldable device can be captured in (`fold` in agent-device and Argent). */
export const DEVICE_POSES = ["closed", "half-open", "open"] as const;
export type DevicePose = typeof DEVICE_POSES[number];
export type PlatformConfig = { device?: string; bundleId?: string; easProfile?: string };
/**
* One named capture target (`targets.<id>`): a platform's device, optionally in a pose, captured as its own report.
* Several may share a platform, such as a phone and a foldable, or one foldable closed and open.
*/
export type TargetConfig = { platform: ExplorePlatform; device?: string; pose?: DevicePose; bundleId?: string; easProfile?: string; label?: string;
/** This target's device controller and simulator, over `capture.controller` and `capture.simulator`. */
controller?: "agent-device" | "argent"; simulator?: "eas" | "local" };
/**
* A target id names directories, report files, CI artifacts and URL parameters, so it is short and plain. `base` and
* `head` name a review's own directories.
*/
export const TARGET_ID_PATTERN = /^[a-z][a-z0-9-]{0,31}$/;
const RESERVED_TARGET_IDS = new Set(["base", "head", "report"]);
export function isTargetId(value: unknown): value is string {
return typeof value === "string" && TARGET_ID_PATTERN.test(value) && !RESERVED_TARGET_IDS.has(value) && !value.startsWith("install-");
}
/** Source discovery never consumes a user-authored screen inventory. */
export type ExploreConfig = {
mode: "deterministic" | "agent";
app: { name?: string; platform: ExplorePlatform; bundleId: string; easProfile: string; scheme?: string };
navigation: { provider: "auto" | "expo-router" | "react-navigation"; entry?: string };
device: { name: string };
/**
* `pose` folds a foldable (iPhone Duo) before capture: closed lights the outer display, open the inner one.
* Absent leaves the device as it starts (closed). It applies to the primary platform's device.
*/
device: { name: string; pose?: DevicePose };
/**
* Each platform Explore captures, in CI as one matrix job each. Absent: the single platform the
* flat fields describe. Capture code never reads this map; resolvePlatformConfig flattens it.
*/
platforms?: Partial<Record<ExplorePlatform, PlatformConfig>>;
/**
* Named capture targets, each captured and reported on its own, in this order. Instead of `platforms`, which is the
* same as one target per platform, named after it. Capture code never reads this map; resolveTargetConfig flattens it.
*/
targets?: Record<string, TargetConfig>;
/** Set on a config resolved for one target: the target it captures. */
target?: RunTarget;
/** `exclude` names routes, as `requiresRoute` does, that stay in the map but are never captured. */
exploration: { scope: "changes" | "all"; exclude?: string[] };
capture: { maxMinutes: number; maxActions: number; repack: "eas" | "local"; appearance: AppearanceSetting; launch: LaunchSetting; reset: RouteResetSetting; unattributed: UnattributedSetting; readinessSeconds?: number };
capture: { maxMinutes: number; maxActions: number;
/** Where the route observer is bundled into the app, when the config chooses; captureRepack gives the default. */
repack?: "eas" | "local"; appearance: AppearanceSetting; launch: LaunchSetting; reset: RouteResetSetting; unattributed: UnattributedSetting; readinessSeconds?: number;
/** The device controller; absent means agent-device, so configs that never chose one keep their cache recipes. */
controller?: "argent";
/** Where the app runs: EAS Simulator when absent, or `local`, a simulator Explore creates on this Mac for the run. */
simulator?: "local" };
parameters?: Record<string, Record<string, string>>;
setup?: ExploreSetupAction[];
agent?: { provider: "openai" | "anthropic"; model: string; instructions?: string };
@@ -233,17 +274,20 @@ function parameters(value: unknown): Record<string, Record<string, string>> {
/** Validate and normalize plain data; credential validation is a separate execution gate. */
export function validateExploreConfig(value: unknown): ExploreConfig {
const root = record(value, "config");
exactKeys(root, ["mode", "app", "navigation", "device", "platforms", "exploration", "capture", "parameters", "setup", "agent", "report", "ci"], "config");
exactKeys(root, ["mode", "app", "navigation", "device", "platforms", "targets", "exploration", "capture", "parameters", "setup", "agent", "report", "ci"], "config");
const app = record(root.app, "app");
exactKeys(app, ["name", "platform", "bundleId", "easProfile", "scheme"], "app");
const device = record(root.device, "device");
exactKeys(device, ["name"], "device");
exactKeys(device, ["name", "pose"], "device");
const pose = device.pose === undefined ? undefined : literal(device.pose, DEVICE_POSES, "device.pose", "closed");
const navigation = optionalRecord(root.navigation, "navigation");
exactKeys(navigation, ["provider", "entry"], "navigation");
const exploration = optionalRecord(root.exploration, "exploration");
exactKeys(exploration, ["scope", "exclude"], "exploration");
const capture = optionalRecord(root.capture, "capture");
exactKeys(capture, ["maxMinutes", "maxActions", "repack", "appearance", "launch", "reset", "unattributed", "readinessSeconds"], "capture");
exactKeys(capture, ["maxMinutes", "maxActions", "repack", "appearance", "launch", "reset", "unattributed", "readinessSeconds", "controller", "simulator"], "capture");
const controller = literal(capture.controller, ["agent-device", "argent"] as const, "capture.controller", "agent-device");
const simulator = literal(capture.simulator, ["eas", "local"] as const, "capture.simulator", "eas");
const mode = literal(root.mode, ["deterministic", "agent"] as const, "mode", "deterministic");
const name = optionalText(app.name, "app.name", 128);
const scheme = app.scheme === undefined ? undefined : customScheme(app.scheme, "app.scheme");
@@ -251,6 +295,8 @@ export function validateExploreConfig(value: unknown): ExploreConfig {
const bundleId = applicationId(app.bundleId, "app.bundleId");
const easProfile = profileName(app.easProfile, "app.easProfile");
const platforms = platformsConfig(root.platforms, platform);
const targets = targetsConfig(root.targets, platform);
if (platforms && targets) fail("Use targets or platforms, not both", "targets", "Move each platforms entry into targets, with its platform.");
let agent: ExploreConfig["agent"];
if (root.agent !== undefined || mode === "agent") {
const input = record(root.agent, "agent");
@@ -276,8 +322,9 @@ export function validateExploreConfig(value: unknown): ExploreConfig {
provider: literal(navigation.provider, ["auto", "expo-router", "react-navigation"] as const, "navigation.provider", "auto"),
...(navigation.entry === undefined ? {} : { entry: repoPath(navigation.entry, "navigation.entry") }),
},
device: { name: text(device.name, "device.name", 128) },
device: { name: text(device.name, "device.name", 128), ...(pose === undefined ? {} : { pose }) },
...(platforms === undefined ? {} : { platforms }),
...(targets === undefined ? {} : { targets }),
exploration: {
scope: literal(exploration.scope, ["changes", "all"] as const, "exploration.scope", "changes"),
...(exploration.exclude === undefined ? {} : { exclude: excludedRoutes(exploration.exclude) }),
@@ -285,12 +332,14 @@ export function validateExploreConfig(value: unknown): ExploreConfig {
capture: {
maxMinutes: positiveInteger(capture.maxMinutes, "capture.maxMinutes", 30),
maxActions: positiveInteger(capture.maxActions, "capture.maxActions", 500),
repack: literal(capture.repack, ["eas", "local"] as const, "capture.repack", "eas"),
...(capture.repack === undefined ? {} : { repack: literal(capture.repack, ["eas", "local"] as const, "capture.repack") }),
appearance: parseAppearance(capture.appearance, "capture.appearance"),
launch: parseLaunchSetting(capture.launch, "capture.launch"),
reset: parseRouteResetSetting(capture.reset, "capture.reset"),
unattributed: parseUnattributedSetting(capture.unattributed, "capture.unattributed"),
...(capture.readinessSeconds !== undefined ? { readinessSeconds: positiveInteger(capture.readinessSeconds, "capture.readinessSeconds") } : {}),
...(controller === "argent" ? { controller } : {}),
...(simulator === "local" ? { simulator } : {}),
},
...(root.parameters === undefined ? {} : { parameters: parameters(root.parameters) }),
...(root.setup === undefined ? {} : { setup: setupActions(root.setup, scheme) }),
@@ -335,16 +384,103 @@ function platformsConfig(value: unknown, primary: ExplorePlatform): ExploreConfi
return result;
}
function targetsConfig(value: unknown, primary: ExplorePlatform): ExploreConfig["targets"] {
if (value === undefined) return undefined;
const mapping = record(value, "targets");
const ids = Object.keys(mapping);
if (!ids.length) fail("targets must name at least one target", "targets");
if (ids.length > 8) fail("targets can name at most 8 targets", "targets");
const result: NonNullable<ExploreConfig["targets"]> = {};
for (const id of ids) {
const label = `targets.${id}`;
if (!isTargetId(id)) fail(`${label}: a target id is lowercase letters, digits and dashes, starts with a letter, and is not base, head or report`, label);
const entry = record(mapping[id], label);
exactKeys(entry, ["platform", "device", "pose", "bundleId", "easProfile", "label", "controller", "simulator"], label);
const platform = literal(entry.platform, EXPLORE_PLATFORMS, `${label}.platform`);
const device = optionalText(entry.device, `${label}.device`, 128);
const pose = entry.pose === undefined ? undefined : literal(entry.pose, DEVICE_POSES, `${label}.pose`);
const bundleId = entry.bundleId === undefined ? undefined : applicationId(entry.bundleId, `${label}.bundleId`);
const easProfile = entry.easProfile === undefined ? undefined : profileName(entry.easProfile, `${label}.easProfile`);
const name = optionalText(entry.label, `${label}.label`, 64);
const controller = entry.controller === undefined ? undefined : literal(entry.controller, ["agent-device", "argent"] as const, `${label}.controller`);
const simulator = entry.simulator === undefined ? undefined : literal(entry.simulator, ["eas", "local"] as const, `${label}.simulator`);
if (platform !== primary && (bundleId === undefined || easProfile === undefined)) {
fail(`${label} needs bundleId and easProfile`, label,
`Set ${label}.bundleId to the app's ${platform === "android" ? "android.package" : "ios.bundleIdentifier"} and ${label}.easProfile to an eas.json profile that builds a ${platform === "android" ? "signed APK (android.buildType: apk)" : "simulator app (ios.simulator: true)"}.`);
}
result[id] = { platform, ...(device === undefined ? {} : { device }), ...(pose === undefined ? {} : { pose }), ...(bundleId === undefined ? {} : { bundleId }),
...(easProfile === undefined ? {} : { easProfile }), ...(name === undefined ? {} : { label: name }),
...(controller === undefined ? {} : { controller }), ...(simulator === undefined ? {} : { simulator }) };
}
return result;
}
/** The platforms a configuration captures, iOS first; the flat fields alone describe one. */
export function configPlatforms(config: ExploreConfig): ExplorePlatform[] {
if (config.targets) return EXPLORE_PLATFORMS.filter(platform => Object.values(config.targets!).some(target => target.platform === platform));
return config.platforms ? EXPLORE_PLATFORMS.filter(platform => config.platforms![platform] !== undefined) : [config.app.platform];
}
const PLATFORM_LABELS: Record<ExplorePlatform, string> = { ios: "iOS", android: "Android" };
/** The targets a configuration captures, in order: its `targets`, else one per platform, named after it. */
export function configTargets(config: ExploreConfig): RunTarget[] {
if (!config.targets) return configPlatforms(config).map(platform => ({ id: platform, platform, label: PLATFORM_LABELS[platform] }));
return Object.entries(config.targets).map(([id, target]) => ({ id, platform: target.platform,
label: target.label ?? `${target.device ?? (target.platform === config.app.platform ? config.device.name : DEFAULT_ANDROID_DEVICE)}${target.pose ? ` (${target.pose})` : ""}` }));
}
/**
* The flat configuration capture consumes for one target, with `target` naming it. `--target` names one; `--platform`
* names the target of that platform, when only one has it; with neither, the config must have a single target.
*/
export function resolveTargetConfig(config: ExploreConfig, selection: { target?: string | undefined; platform?: ExplorePlatform | undefined } = {}): ExploreConfig {
const targets = configTargets(config);
if (!config.targets) {
if (selection.target !== undefined && !targets.some(target => target.id === selection.target)) throw targetNotConfigured(selection.target, targets);
const resolved = resolvePlatformConfig(config, (selection.target as ExplorePlatform | undefined) ?? selection.platform);
return { ...resolved, target: targets.find(target => target.platform === resolved.app.platform)! };
}
let chosen: RunTarget | undefined;
if (selection.target !== undefined) {
chosen = targets.find(target => target.id === selection.target);
if (!chosen) throw targetNotConfigured(selection.target, targets);
} else {
const candidates = selection.platform ? targets.filter(target => target.platform === selection.platform) : targets;
if (candidates.length !== 1) throw new CiError({ code: candidates.length ? "TARGET_REQUIRED" : "PLATFORM_NOT_CONFIGURED", stage: "preflight",
message: candidates.length ? `${DEFAULT_EXPLORE_CONFIG_PATH} lists ${candidates.map(target => target.id).join(", ")}; pass --target to select one.`
: `${DEFAULT_EXPLORE_CONFIG_PATH} has no ${selection.platform} target.`,
nextAction: "Run expo-explore setup --workflows to install the matrix workflows, which pass --target per job." });
chosen = candidates[0]!;
}
const entry = config.targets[chosen.id]!;
const primary = entry.platform === config.app.platform;
const { targets: _targets, platforms: _platforms, ...rest } = config;
void _targets; void _platforms;
// A target's own controller and simulator; agent-device and EAS Simulator are the defaults, which leave the config as it was.
const { controller: _controller, simulator: _simulator, ...capture } = config.capture;
void _controller; void _simulator;
const controller = entry.controller ?? config.capture.controller ?? "agent-device";
const simulator = entry.simulator ?? config.capture.simulator ?? "eas";
return { ...rest, target: chosen,
capture: { ...capture, ...(controller === "argent" ? { controller } : {}), ...(simulator === "local" ? { simulator } : {}) },
app: { ...config.app, platform: entry.platform, bundleId: entry.bundleId ?? config.app.bundleId, easProfile: entry.easProfile ?? config.app.easProfile },
device: { name: entry.device ?? (primary ? config.device.name : DEFAULT_ANDROID_DEVICE),
// A target's own pose; else the top-level one, which belongs to the primary platform's device.
...(entry.pose ? { pose: entry.pose } : primary && !entry.device && config.device.pose ? { pose: config.device.pose } : {}) } };
}
function targetNotConfigured(id: string, targets: RunTarget[]): CiError {
return new CiError({ code: "TARGET_NOT_CONFIGURED", stage: "preflight", message: `${DEFAULT_EXPLORE_CONFIG_PATH} has no target ${id}.`,
nextAction: `Capture one of: ${targets.map(target => target.id).join(", ")}.` });
}
/**
* The flat configuration capture consumes for one platform: `app.platform`, `app.bundleId`,
* `app.easProfile`, and `device.name` describe that platform; everything else is shared.
*/
export function resolvePlatformConfig(config: ExploreConfig, platform: ExplorePlatform | undefined): ExploreConfig {
if (config.targets) return resolveTargetConfig(config, { platform });
const platforms = configPlatforms(config);
if (platform === undefined) {
if (platforms.length > 1) throw new CiError({ code: "PLATFORM_REQUIRED", stage: "preflight",
@@ -362,7 +498,9 @@ export function resolvePlatformConfig(config: ExploreConfig, platform: ExplorePl
return { ...rest,
app: { ...config.app, platform, bundleId: entry.bundleId ?? (primary ? config.app.bundleId : fail(`platforms.${platform}.bundleId is required`)),
easProfile: entry.easProfile ?? (primary ? config.app.easProfile : fail(`platforms.${platform}.easProfile is required`)) },
device: { name: entry.device ?? (primary ? config.device.name : platform === "android" ? DEFAULT_ANDROID_DEVICE : config.device.name) } };
device: { name: entry.device ?? (primary ? config.device.name : platform === "android" ? DEFAULT_ANDROID_DEVICE : config.device.name),
// A pose belongs to the primary platform's device; the other platform's device starts as it is.
...(primary && config.device.pose ? { pose: config.device.pose } : {}) } };
}
/**
@@ -370,8 +508,22 @@ export function resolvePlatformConfig(config: ExploreConfig, platform: ExplorePl
* every screen (`scope: all`) and keep its hosted link (`expiresIn: never`). `expiresIn` changes nothing when the
* config hosts no report.
*/
export function withRunOverrides(config: ExploreConfig, overrides: { scope?: string | undefined; expiresIn?: string | undefined }): ExploreConfig {
export function withRunOverrides(config: ExploreConfig, overrides: { scope?: string | undefined; expiresIn?: string | undefined; controller?: string | undefined; simulator?: string | undefined; repack?: string | undefined }): ExploreConfig {
let result = config;
if (overrides.repack !== undefined) {
if (overrides.repack !== "eas" && overrides.repack !== "local") fail("--repack must be eas or local", "--repack");
result = { ...result, capture: { ...result.capture, repack: overrides.repack } };
}
if (overrides.controller !== undefined) {
if (overrides.controller !== "agent-device" && overrides.controller !== "argent") fail("--controller must be agent-device or argent", "--controller");
const { controller: _previous, ...capture } = result.capture;
result = { ...result, capture: { ...capture, ...(overrides.controller === "argent" ? { controller: "argent" as const } : {}) } };
}
if (overrides.simulator !== undefined) {
if (overrides.simulator !== "eas" && overrides.simulator !== "local") fail("--simulator must be eas or local", "--simulator");
const { simulator: _previous, ...capture } = result.capture;
result = { ...result, capture: { ...capture, ...(overrides.simulator === "local" ? { simulator: "local" as const } : {}) } };
}
if (overrides.scope !== undefined) {
if (overrides.scope !== "changes" && overrides.scope !== "all") fail("--scope must be changes or all", "--scope");
result = { ...result, exploration: { ...result.exploration, scope: overrides.scope } };
@@ -384,6 +536,14 @@ export function withRunOverrides(config: ExploreConfig, overrides: { scope?: str
return result;
}
/**
* Where a capture repacks the app with the route observer: the config's choice, else on this machine when the app runs on
* a local simulator (which already needs Xcode or the Android SDK), and in a hosted EAS job otherwise.
*/
export function captureRepack(config: ExploreConfig): "eas" | "local" {
return config.capture.repack ?? (config.capture.simulator === "local" ? "local" : "eas");
}
/** `expiresAfter` is a whole number of days (`30d`, `30 days`, or `30`), at most PREVIEW_MAX_DAYS, or `never` (null). */
export function previewDays(value: unknown, field: string): number | null {
if (value === undefined) return PREVIEW_DEFAULT_DAYS;
+15 -2
View File
@@ -4,7 +4,7 @@ import { dirname, join, resolve } from "node:path";
import { createInterface } from "node:readline/promises";
import { fileURLToPath } from "node:url";
import { stringify } from "yaml";
import { DEFAULT_EXPLORE_CONFIG_PATH, readExploreConfig, validateExploreConfig, type ExploreConfig } from "./explore-config.js";
import { DEFAULT_EXPLORE_CONFIG_PATH, readExploreConfig, validateExploreConfig, type ExploreConfig, type ExplorePlatform } from "./explore-config.js";
import { explorationSecretNames } from "./exploration-inputs.js";
import type { RouteEntryReport } from "../ci/route-entry.js";
import type { CiInstallResult } from "../ci/workflow-install.js";
@@ -60,6 +60,8 @@ type SetupOptions = {
appState?: string | undefined;
workflows?: boolean | undefined;
nonInteractive?: boolean;
/** Return the config without writing anything. */
dryRun?: boolean;
check?: boolean;
};
type Interaction = {
@@ -234,6 +236,14 @@ export type SetupResult = {
nextSteps?: string[];
};
/**
* The config `setup --non-interactive` would write, without writing it: what a local review runs with in an app that
* has no config yet. Throws setup's errors when the app cannot be built for capture.
*/
export async function defaultExploreConfig(project: string, platform?: ExplorePlatform): Promise<ExploreConfig> {
return (await runExploreSetup({ project, platform, nonInteractive: true, dryRun: true })).config;
}
/**
* The guided setup. It writes what it can derive (app identity, mode, route parameters it was given,
* an agent-instructions draft, CI files) and hands the app-specific flows to the user's coding agent.
@@ -290,7 +300,9 @@ export async function runExploreSetup(options: SetupOptions = {}, interaction?:
}
const schemes = Array.isArray(app.scheme) ? app.scheme.filter((value): value is string => typeof value === "string") : undefined;
const scheme = await choose("URL scheme (optional)", options.scheme, schemes?.[0] ?? string(app.scheme), schemes);
const profile = await choose(platform === "android" ? "EAS emulator (APK) build profile" : "EAS simulator build profile", options.profile, profiles.length === 1 ? profiles[0]! : "", profiles);
const profile = await choose(platform === "android" ? "EAS emulator (APK) build profile" : "EAS simulator build profile", options.profile,
// With several, the one named explore, the name the README and the explore-setup skill give it.
profiles.length === 1 ? profiles[0]! : profiles.includes("explore") ? "explore" : "", profiles);
if (!profiles.includes(profile)) throw new Error(`Choose ${platform === "android" ? "an Android APK" : "a simulator"} profile from eas.json with --profile: ${profiles.join(", ")}.`);
const inferredProvider = dependencies["expo-router"] ? "expo-router" : dependencies["@react-navigation/native"] ? "react-navigation" : "auto";
const provider = await choose("Navigation provider", options.navigation, inferredProvider, ["auto", "expo-router", "react-navigation"]);
@@ -390,6 +402,7 @@ export async function runExploreSetup(options: SetupOptions = {}, interaction?:
const answer = await ui!.ask("Write this config? (yes/no)", "yes");
if (!/^(y|yes)$/i.test(answer.trim())) throw new Error("Setup canceled; no config was written.");
}
if (options.dryRun) return { path, config, created: false };
await mkdir(parent, { recursive: true });
await writeFile(path, yaml, { flag: "wx" });
if (instructions) await writeFile(instructionsPath, instructions, { flag: "wx" });
+19
View File
@@ -1,3 +1,4 @@
import type { RunTarget } from "../types.js";
import { validateSourceRoutes, type SourceRoute } from "./source-route.js";
import type { SourceCapturePlan, SurfaceSourceScope } from "../source/capture-plan.js";
import type { ReviewPresentation } from "./review.js";
@@ -73,6 +74,8 @@ export type CaptureBundle = {
/** Execution completion time, recorded even when no routes require screenshots. */
completedAt?: string;
appName?: string;
/** The device controller that drove the capture; absent for agent-device, the default. */
controller?: "argent";
/** The icon the app config declares, shrunk to at most 128 pixels; absent when unavailable. */
appIcon?: Omit<AppIconImage, "url"> & { path: string };
profile: string; selectedSurfaceIds: string[];
@@ -172,8 +175,18 @@ export type PublicVisualVerdict = {
rect: { x: number; y: number; width: number; height: number };
normalizedRect: { x: number; y: number; width: number; height: number };
differentPixels: number; shareOfDiffPercentage: number; dominantChange: string; location: string;
/**
* Set when the region's content is the same in both screenshots, only moved: how far, in screenshot pixels
* (right and down are positive). Absent when the content itself changed.
*/
shift?: { x: number; y: number };
}>;
tool: string;
/**
* Every region the comparison found (not only the published ones) only moved: nothing on the screen changed
* content. Absent when any region changed, or moves were not measured.
*/
allRegionsMoved?: true;
/** Diff regions inside the iOS status-bar band that were excluded from the verdict. */
ignoredStatusBarRegions?: number;
/** Diff regions that lay entirely inside the home-indicator band and were left out of the verdict. */
@@ -228,6 +241,8 @@ export type PublicReview = {
appIcon?: AppIconImage;
/** Absent in reports published before Android support: iOS. */
platform?: "ios" | "android";
/** The device controller that drove the head capture; absent for agent-device, the default. */
controller?: "argent";
device?: { model: string; osVersion: string };
/** The share of each screenshot's height the verdict ignored as the status bar. */
statusBarBandPercent?: number;
@@ -235,6 +250,10 @@ export type PublicReview = {
homeIndicatorBandPercent?: number;
/** Every platform the config captures, so the Viewer can offer the sibling platform's report of the same run. */
platforms?: Array<"ios" | "android">;
/** The target this report captured; absent in reports from before targets, whose target is their platform. */
target?: RunTarget;
/** Every target the config captures, in config order, when more than one: the sibling reports of the same run. */
targets?: RunTarget[];
/** Every appearance the capture rendered, primary first, when it rendered several; surfaces then carry their `colorScheme`. */
colorSchemes?: Array<"light" | "dark">;
};
+19 -1
View File
@@ -32,6 +32,14 @@ function hasVerifiedPair(surface: Surface): boolean {
&& surface[`${side}Outcome`]?.landing === "verified");
}
/**
* A modified screen whose verified screenshots match: only what assistive technology reads (its accessibility tree)
* changed. Screen readers and voice control see it, so it is a change to review, listed apart from the visual ones.
*/
export function isAccessibilityOnlyChange(surface: Surface): boolean {
return surface.review?.status === "modified" && surface.visual?.verdict === "unchanged" && hasVerifiedPair(surface);
}
function assertReviewFields(surface: Surface, enforceComparisonEvidence: boolean): void {
const assertVerifiedPair = () => {
if (enforceComparisonEvidence && !hasVerifiedPair(surface)) {
@@ -67,13 +75,23 @@ function assertReviewFields(surface: Surface, enforceComparisonEvidence: boolean
}
}
/** A region's move between the screenshots: finite, and small enough to be layout drift rather than another screen. */
function validShift(shift: unknown): boolean {
if (!shift || typeof shift !== "object") return false;
const { x, y } = shift as { x?: unknown; y?: unknown };
return typeof x === "number" && typeof y === "number" && Number.isFinite(x) && Number.isFinite(y) && Math.abs(x) <= 64 && Math.abs(y) <= 64;
}
function assertVisualVerdict(visual: PublicVisualVerdict, enforceComparisonEvidence: boolean, paired: boolean): void {
if (!visual || typeof visual !== "object" || !VISUAL_VERDICTS.has(visual.verdict)
|| typeof visual.reason !== "string" || (enforceComparisonEvidence && visual.reason === "diff-failed") || typeof visual.tool !== "string"
|| typeof visual.threshold !== "number" || !Number.isFinite(visual.threshold)
|| (visual.mismatchPercentage !== undefined
&& (typeof visual.mismatchPercentage !== "number" || !Number.isFinite(visual.mismatchPercentage) || visual.mismatchPercentage < 0))
|| (visual.regions !== undefined && (!Array.isArray(visual.regions) || visual.regions.length > 64))
|| (visual.regions !== undefined && (!Array.isArray(visual.regions) || visual.regions.length > 64
|| visual.regions.some(region => region?.shift !== undefined && !validShift(region.shift))))
|| (visual.allRegionsMoved !== undefined && (visual.allRegionsMoved !== true || !visual.regions?.length
|| visual.regions.some(region => region.shift === undefined)))
|| !paired) {
throw new Error("Public visual verdict is inconsistent");
}
+85 -10
View File
@@ -60,18 +60,51 @@ export type AgentContext = {
pageUrl: string;
/** This report's platform when the deployment serves several, so links keep `?platform=`. */
platform?: string | undefined;
/** The distinct platforms the deployment serves. */
platforms: string[];
/** This report's target id when the deployment serves several targets, so links keep selecting it. */
target?: string | undefined;
/** Every target the deployment serves, in config order; absent from contexts that predate targets. */
targets?: AgentTarget[] | undefined;
expiresAt: string | null;
};
export type AgentTarget = { id: string; platform: string; label?: string | undefined };
/**
* The query parameter that keeps a link on this report: `target=<id>`, or `platform=<id>` for a target named after its
* platform (as links were before targets), or the platform alone in contexts that predate targets.
*/
function selection(context: AgentContext): [string, string] | undefined {
if (context.target && (context.targets?.length ?? 0) > 1) return [context.target === "ios" || context.target === "android" ? "platform" : "target", context.target];
return context.platform && context.platforms.length > 1 ? ["platform", context.platform] : undefined;
}
/** The same page for another target of the deployment. */
function targetPageUrl(context: AgentContext, id: string): string {
return viewerUrl({ ...context, target: id }, {});
}
const apiUrl = (context: AgentContext, path = "") => `${context.pageUrl}/api/${AGENT_API_VERSION}${path}`;
function viewerUrl(context: AgentContext, params: Record<string, string> = {}): string {
const url = new URL(context.pageUrl);
if (context.platform && context.platforms.length > 1) url.searchParams.set("platform", context.platform);
const selected = selection(context);
if (selected) url.searchParams.set(...selected);
for (const [key, value] of Object.entries(params)) url.searchParams.set(key, value);
return url.href;
}
const withPlatform = (context: AgentContext, url: string) => (context.platform && context.platforms.length > 1 ? `${url}${url.includes("?") ? "&" : "?"}platform=${context.platform}` : url);
const withPlatform = (context: AgentContext, url: string) => {
const selected = selection(context);
return selected ? `${url}${url.includes("?") ? "&" : "?"}${selected[0]}=${selected[1]}` : url;
};
/** The targets as the summary lists them: each with its label and Viewer link, this one marked. */
function targetList(context: AgentContext): Json[] | undefined {
if (!context.targets || context.targets.length < 2) return undefined;
return context.targets.map(target => defined({ id: target.id, platform: target.platform, label: target.label, current: target.id === context.target ? true : undefined,
viewer: targetPageUrl(context, target.id), summary: `${apiUrl(context)}?${new URLSearchParams([selection({ ...context, target: target.id })!]).toString()}` }));
}
/** What the index title names this report by: the target's label when the deployment serves several. */
function targetLabel(context: AgentContext): string | undefined {
return (context.targets?.length ?? 0) > 1 ? context.targets!.find(target => target.id === context.target)?.label ?? context.target : undefined;
}
type Page<T> = { items: T[]; total: number; count: number; hasMore: boolean; nextCursor?: string };
function page<T>(items: T[], params: URLSearchParams): Page<T> | undefined {
@@ -124,15 +157,50 @@ const edgeItem = (edge: Json): Json => defined({ from: str(edge.from), to: str(e
/**
* A screen's status as the Viewer and the PR comment show it: the review's verdict where there is one, so `modified`
* means a visible change. A screen whose source changed but whose captures match is unchanged, including in reports
* from before 0.19.1, which called it "needs review".
* from before 0.19.1, which called it "needs review". A modified screen whose screenshots match changed only in what
* assistive technology reads: `accessibility-only`. A screen whose capture failed is `unavailable`, and one whose
* source changed but that has no verdict was not compared: `not-compared`.
*/
/** Both sides captured at their verified destination route, as a verdict requires (isAccessibilityOnlyChange in the contract). */
function verifiedPair(surface: Json): boolean {
return (["base", "head"] as const).every(side => str(rec(surface[side]).kind) === "screen" && Boolean(surface[`${side}Image`])
&& str(rec(surface[`${side}Outcome`]).status) === "captured" && str(rec(surface[`${side}Outcome`]).landing) === "verified");
}
/** The side's planned capture ended without a screenshot, or captured another screen than the route (the Viewer's Unavailable). */
function captureUnavailable(surface: Json, side: "base" | "head"): boolean {
const outcome = surface[`${side}Outcome`];
if (str(rec(surface[side]).kind) !== "screen" || outcome === undefined) return false;
const image = Boolean(surface[`${side}Image`]);
if (!image) return str(rec(outcome).status) !== "captured";
return str(rec(outcome).status) === "captured" && str(rec(outcome).landing) !== "verified" && rec(outcome).observed !== undefined;
}
function verdictOf(surface: Json): string | undefined {
// A capture that failed is unavailable, as the Viewer says, whatever the source or an older verdict claims.
if (str(surface.status) !== "removed" && captureUnavailable(surface, "head")) return "unavailable";
if (["modified", "unchanged"].includes(str(surface.status) ?? "") && captureUnavailable(surface, "base")) return "unavailable";
const review = rec(surface.review);
const status = str(review.status);
if (status === "needs-review" && str(review.description) === "Source changed; no visible difference was captured.") return "unchanged";
if (status === "modified" && str(rec(surface.visual).verdict) === "unchanged" && verifiedPair(surface)) return "accessibility-only";
// A source change nobody compared is not a change Explore saw.
if (status === undefined && str(surface.status) === "modified") return "not-compared";
return status ?? str(surface.status);
}
const STATUS_ORDER = ["modified", "accessibility-only", "added", "removed", "needs-review", "unavailable", "not-compared", "unchanged", "variant"];
const STATUS_WORDS: Record<string, string> = { "accessibility-only": "accessibility only (screenshots match, the accessibility tree does not)",
"needs-review": "need review", "not-compared": "not compared", variant: "screen variants" };
/** "3 modified, 1 added, 1 removed, 30 unchanged": every status counted, so the parts add up to the total. */
function screenCounts(screens: Json): string {
const statuses = Object.keys(screens).filter(status => status !== "total")
.sort((left, right) => (STATUS_ORDER.indexOf(left) + 1 || 99) - (STATUS_ORDER.indexOf(right) + 1 || 99));
const parts = statuses.flatMap(status => (num(screens[status]) ? [`${num(screens[status])} ${STATUS_WORDS[status] ?? status}`] : []));
return parts.length ? parts.join(", ") : "none";
}
function reviewSummary(context: AgentContext, review: Json): Json {
const surfaces = arr(review.surfaces).map(rec);
const counts: Record<string, number> = {};
@@ -142,10 +210,10 @@ function reviewSummary(context: AgentContext, review: Json): Json {
kind: "pr-review", api: AGENT_API_VERSION, contract: str(review.contract),
pullRequest: defined({ origin: str(pr.origin), repository: str(pr.repository), number: num(pr.number), title: str(pr.title), url: str(pr.url), head: str(rec(pr.head).sha), base: str(rec(pr.base).sha) }),
app: defined({ name: str(runtime.appName), version: str(runtime.appVersion), build: str(runtime.appBuildNumber), platform: str(runtime.platform) ?? context.platform, device: rec(runtime.device).model === undefined ? undefined : `${str(rec(runtime.device).model)} ${str(rec(runtime.device).osVersion) ?? ""}`.trim() }),
createdAt: str(review.createdAt), mode: str(review.mode), platforms: context.platforms, expiresAt: context.expiresAt,
createdAt: str(review.createdAt), mode: str(review.mode), platforms: context.platforms, target: context.target, targets: targetList(context), expiresAt: context.expiresAt,
screens: { total: surfaces.length, ...counts },
links: {
screens: withPlatform(context, apiUrl(context, "/screens")), changed: withPlatform(context, apiUrl(context, "/screens?status=modified,added,removed")),
screens: withPlatform(context, apiUrl(context, "/screens")), changed: withPlatform(context, apiUrl(context, "/screens?status=modified,accessibility-only,added,removed")),
transitions: withPlatform(context, apiUrl(context, "/transitions")), raw: withPlatform(context, apiUrl(context, "/raw")),
viewer: viewerUrl(context), viewerChanges: viewerUrl(context, { focus: "modified", inspect: "diff" }), markdown: `${context.pageUrl}/llms.txt`,
},
@@ -202,7 +270,7 @@ function explorationSummary(context: AgentContext, report: Json): Json {
kind: "exploration", api: AGENT_API_VERSION, contract: str(map.contract),
app: defined({ name: str(app.name), bundleId: str(app.bundleId), platform: str(app.platform) ?? context.platform, version: str(app.version), build: str(app.buildNumber), device: device.model === undefined ? undefined : `${str(device.model)} ${str(device.osVersion) ?? ""}`.trim() }),
startedAt: str(exploration.startedAt), completedAt: str(exploration.completedAt), stopReason: str(exploration.stopReason), summary: str(exploration.summary),
model: str(rec(exploration.model).model), platforms: context.platforms, expiresAt: context.expiresAt,
model: str(rec(exploration.model).model), platforms: context.platforms, target: context.target, targets: targetList(context), expiresAt: context.expiresAt,
screens: { total: screens.length, coverage: Object.keys(coverage).length ? coverage : undefined },
counts: { transitions: arr(map.transitions).length, elements: arr(map.elements).length, journeys: arr(map.journeys).length, gaps: arr(map.gaps).length, frontier: arr(map.frontier).length },
links: {
@@ -223,16 +291,18 @@ export function agentIndexMarkdown(context: AgentContext, loaded: LoadedReport):
const links = rec(summary.links) as Record<string, string>;
const app = rec(summary.app), screens = rec(summary.screens);
const lines: string[] = [];
const label = targetLabel(context);
const titled = (platform: unknown) => (label ? ` (${escapeMd(label)})` : platform ? ` (${escapeMd(platform)})` : "");
if (loaded.kind === "pr-review") {
const pr = rec(summary.pullRequest);
// A comparison of two commits has a title ("v1.4.0 vs v1.3.0") where a pull request has a number.
// A comparison of two commits, or a local review on someone's machine, has no pull request: its title names both refs.
const compared = pr.origin === "compare" || pr.origin === "local";
lines.push(`# Expo Explore report: ${escapeMd(app.name ?? pr.repository)} ${compared ? escapeMd(pr.title) : `PR #${escapeMd(pr.number)}`}${app.platform ? ` (${escapeMd(app.platform)})` : ""}`, "",
`> Visual review of ${compared ? `${escapeMd(pr.repository)} ${escapeMd(pr.title)}` : `pull request ${escapeMd(pr.repository)}#${escapeMd(pr.number)}`} by Expo Explore. ${screens.total} screens captured: ${screens.modified ?? 0} modified, ${screens.added ?? 0} added, ${screens.removed ?? 0} removed, ${screens.unchanged ?? 0} unchanged.${context.expiresAt ? ` This link stops serving the report after ${context.expiresAt}.` : ""}`, "",
lines.push(`# Expo Explore report: ${escapeMd(app.name ?? pr.repository)} ${compared ? escapeMd(pr.title) : `PR #${escapeMd(pr.number)}`}${titled(app.platform)}`, "",
`> Visual review of ${compared ? `${escapeMd(pr.repository)} ${escapeMd(pr.title)}` : `pull request ${escapeMd(pr.repository)}#${escapeMd(pr.number)}`} by Expo Explore. ${screens.total} screens: ${screenCounts(screens)}.${context.expiresAt ? ` This link stops serving the report after ${context.expiresAt}.` : ""}`, "",
"This URL is the human Viewer. The same report is available as read-only JSON (no credentials beyond this URL):", "",
`- [Summary](${links.summary ?? withPlatform(context, apiUrl(context))}): kind, counts by status, app and PR identity, links`,
`- [Changed screens](${links.changed}): the modified, added and removed screens with the review description, visual verdict and mismatch percentage; \`status=\` filters, \`limit=\`/\`cursor=\` page`,
`- [Changed screens](${links.changed}): the modified, accessibility-only (screenshots match, the accessibility tree does not), added and removed screens with the review description, visual verdict and mismatch percentage; \`status=\` filters, \`limit=\`/\`cursor=\` page`,
`- [All screens](${links.screens}): every captured screen; \`${links.screens}/{id}\` (the \`id\` field of a screen) adds source files and navigation in and out`,
`- [Transitions](${links.transitions}): navigation edges between screens (\`?from=\`/\`?to=\` take a screen id or route)`,
`- Screenshots: each screen's \`headImage\`/\`baseImage\` URL returns the PNG`,
@@ -240,7 +310,7 @@ export function agentIndexMarkdown(context: AgentContext, loaded: LoadedReport):
`Start with the changed screens. Every item carries a \`viewerUrl\` that opens that screen in the Viewer for a human; [${escapeMd(links.viewerChanges)}](${links.viewerChanges}) opens the list of changes.`);
} else {
const counts = rec(summary.counts);
lines.push(`# Expo Explore exploration: ${escapeMd(app.name)}${app.platform ? ` (${escapeMd(app.platform)})` : ""}`, "",
lines.push(`# Expo Explore exploration: ${escapeMd(app.name)}${titled(app.platform)}`, "",
`> An agent explored ${escapeMd(app.name)} ${escapeMd(app.version ?? "")} on ${escapeMd(app.device ?? app.platform)} and mapped ${screens.total} screens, ${counts.transitions} transitions, ${counts.elements} elements; ${counts.gaps} coverage gaps. Stopped: ${escapeMd(summary.stopReason)}.${summary.summary ? ` ${escapeMd(summary.summary)}` : ""}${context.expiresAt ? ` This link stops serving the report after ${context.expiresAt}.` : ""}`, "",
"This URL is the human Viewer. The same map is available as read-only JSON (no credentials beyond this URL):", "",
`- [Summary](${withPlatform(context, apiUrl(context))}): app, device, model, stop reason, counts, links`,
@@ -252,6 +322,11 @@ export function agentIndexMarkdown(context: AgentContext, loaded: LoadedReport):
`- [Raw exploration.json](${links.raw}): the full map contract`, "",
"Start with the screens list, then open the screens you care about. Every item carries a `viewerUrl` that opens it in the Viewer for a human.");
}
const others = (context.targets ?? []).filter(target => target.id !== context.target);
if (label && others.length) {
lines.push("", `This link also serves the same run's other targets; each has its own index and JSON API:`, "",
...others.map(target => `- [${escapeMd(target.label ?? target.id).replace(/[[\]]/g, "")}](${targetPageUrl(context, target.id)}) (${escapeMd(target.platform)})`));
}
return lines.join("\n") + "\n";
}
+35 -14
View File
@@ -5,8 +5,8 @@ import { assertPublicReview, projectPublicReviewForReport } from "../contracts/r
import { createHash } from "node:crypto";
import type { ArtifactReport } from "../contracts/artifact-report.js";
import { compareTitleMarkdown, projectReviewPresentation, type CompareReviewPresentation } from "../contracts/review.js";
import { renderPublicComment, platformSectionMerge, type PublicCommentState } from "./pr-comment-body.js";
import type { ExplorePlatform } from "../config/explore-config.js";
import { renderPublicComment, platformSectionMerge, reviewChangeCount, type PublicCommentState } from "./pr-comment-body.js";
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
import { upsertStickyComment } from "./pr-comment.js";
import { previewLinks, viewerLinks } from "./viewer-links.js";
import type { PublicReview } from "../contracts/capture.js";
@@ -112,10 +112,23 @@ async function exportCiReportUnchecked(options: { inputPath: string; outputPath:
}
/**
* The suffix of this matrix job's artifacts: `--target`, else for a `--platform` caller the captured target when it
* has that platform (its id is the platform for a config without targets), else nothing (a workflow without a matrix).
*/
function reportTarget(options: { target?: string; platform?: ExplorePlatform }, state: PublicCommentState): string | undefined {
const target = options.target ?? (options.platform && state.target?.platform === options.platform ? state.target.id : options.platform);
if (target !== undefined && !isTargetId(target)) throw new CiError({ code: "TARGET_INVALID", stage: "preflight", message: `${target} is not a target id.`,
nextAction: "Pass --target with an id from targets: in .expo-explore/config.yaml (ios or android without targets:)." });
return target;
}
/** Finalize only an uploaded artifact from this run while the captured PR is still current. */
export async function publishCiReportComment(options: {
inputPath: string; artifactUrl: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch;
/** Set by the matrix workflows: the artifact carries the platform suffix and the comment gets one section per platform. */
/** Set by the matrix workflows: the artifact carries the target suffix and the comment gets one section per target. */
target?: string;
/** What callers from before targets pass: the platform of the captured target, whose id then names the artifact. */
platform?: ExplorePlatform;
/** A verified hosted preview from `ci:deploy`; the comment then links to it as Explore report. */
preview?: { url: string; expiresAt: number | null };
@@ -135,10 +148,11 @@ export async function publishCiReportComment(options: {
nextAction: "Publish the report-input.json produced by this repository's current workflow run and attempt." });
}
if (pr.origin === "local") throw new Error("Local reports cannot be published as GitHub PR comments");
const target = reportTarget(options, input.commentState);
const links = viewerLinks({ repository: pr.repository, headSha: pr.head.sha, runId: review.runId,
runAttempt: review.runAttempt, configPath: input.commentState.configPath, artifactUrl: options.artifactUrl,
...(options.platform ? { platform: options.platform } : {}) });
if (options.preview) links.preview = previewLinks(options.preview.url, options.preview.expiresAt, options.platform);
...(target ? { target } : {}) });
if (options.preview) links.preview = previewLinks(options.preview.url, options.preview.expiresAt, target);
else if (input.preview && !options.previewFailed) links.deploying = true;
const api = async (path: string) => {
let response: Response;
@@ -171,7 +185,7 @@ export async function publishCiReportComment(options: {
message: "GitHub returned invalid report metadata.", nextAction: "Rerun publication; if the response remains invalid, inspect the GitHub metadata request.", cause: error }); }
};
const artifact = await api(`actions/artifacts/${new URL(options.artifactUrl).pathname.split("/").at(-1)}`);
if (artifact.expired || artifact.name !== `explore-review-${review.runId}-${review.runAttempt}${options.platform ? `-${options.platform}` : ""}` || String(artifact.workflow_run?.id) !== review.runId) {
if (artifact.expired || artifact.name !== `explore-review-${review.runId}-${review.runAttempt}${target ? `-${target}` : ""}` || String(artifact.workflow_run?.id) !== review.runId) {
throw new CiError({ code: artifact.expired ? "REPORT_ARTIFACT_EXPIRED" : "REPORT_ARTIFACT_MISMATCH", stage: "publication",
message: "The uploaded report artifact is unavailable or belongs to another run",
nextAction: artifact.expired ? "Rerun Explore to upload a fresh report artifact." : "Pass the final report artifact from this workflow run and attempt." });
@@ -188,9 +202,9 @@ export async function publishCiReportComment(options: {
const superseded = current.head?.sha !== pr.head.sha || current.base?.sha !== pr.base.sha;
const state: PublicCommentState = { ...input.commentState, phase: "ready", updatedAt: Date.now(),
review, links, artifactOnly: true, ...(superseded ? { superseded: true } : {}) };
const body = renderPublicComment(state);
const body = renderPublicComment(state, undefined, target);
let previousBody: string | undefined;
try { previousBody = (await upsertStickyComment({ repository: pr.repository, issueNumber: pr.number, body, ...platformSectionMerge(state, options.platform),
try { previousBody = (await upsertStickyComment({ repository: pr.repository, issueNumber: pr.number, body, ...platformSectionMerge(state, target),
token: environment.GITHUB_TOKEN, fetchImpl: transport })).previousBody; }
catch (error) { throw toCiError(error, { code: "COMMENT_PUBLICATION_FAILED", stage: "publication",
nextAction: "Grant the GitHub token PR comment write permission and retry publication for the current PR head." }); }
@@ -200,9 +214,9 @@ export async function publishCiReportComment(options: {
/**
* A comparison has no pull request to comment on: `ci:publish` links its report from the run summary instead,
* with the same Open (central Viewer) and zip links a PR comment carries for this platform.
* with the same Open (central Viewer) and zip links a PR comment carries for this target, labelled as the comment labels it.
*/
async function publishCompareSummary(input: CiReportInput, options: { artifactUrl: string; platform?: ExplorePlatform }, environment: NodeJS.ProcessEnv) {
async function publishCompareSummary(input: CiReportInput, options: { artifactUrl: string; target?: string; platform?: ExplorePlatform }, environment: NodeJS.ProcessEnv) {
const review = input.publicReview; const comparison = review.pullRequest as CompareReviewPresentation;
if (review.runId !== environment.GITHUB_RUN_ID || review.runAttempt !== environment.GITHUB_RUN_ATTEMPT
|| (environment.GITHUB_REPOSITORY && environment.GITHUB_REPOSITORY !== comparison.repository)) {
@@ -210,14 +224,21 @@ async function publishCompareSummary(input: CiReportInput, options: { artifactUr
message: "Report input is not from the current repository run and attempt",
nextAction: "Publish the report-input.json produced by this repository's current workflow run and attempt." });
}
const target = reportTarget(options, input.commentState);
const links = viewerLinks({ repository: comparison.repository, headSha: comparison.head.sha, runId: review.runId,
runAttempt: review.runAttempt, configPath: input.commentState.configPath, artifactUrl: options.artifactUrl,
...(options.platform ? { platform: options.platform } : {}) });
...(target ? { target } : {}) });
const changes = input.commentState.review ?? review;
const count = changes.surfaces.filter(surface => surface.review ? surface.review.status !== "unchanged" && surface.review.status !== "variant" : surface.status !== "unchanged").length;
const platform = (options.platform ?? review.runtime.platform) === "android" ? "Android" : "iOS";
const count = reviewChangeCount({ review: changes }) ?? 0;
const label = summaryText(input.commentState.target?.label ?? review.runtime.target?.label
?? ((options.platform ?? review.runtime.platform) === "android" ? "Android" : "iOS"));
if (environment.GITHUB_STEP_SUMMARY) {
await appendFile(environment.GITHUB_STEP_SUMMARY, `- ${platform} report of ${compareTitleMarkdown(comparison)}: [Open](${links.viewer!.open}) · [zip](${links.download!}) · ${count} ${count === 1 ? "change" : "changes"}\n`);
await appendFile(environment.GITHUB_STEP_SUMMARY, `- ${label} report of ${compareTitleMarkdown(comparison)}: [Open](${links.viewer!.open}) · [zip](${links.download!}) · ${count} ${count === 1 ? "change" : "changes"}\n`);
}
return { artifactUrl: links.viewer!.open, headSha: comparison.head.sha };
}
/** A config-authored label as plain Markdown text on one line. */
function summaryText(value: string): string {
return value.replace(/[\u0000-\u001f\u007f]+/g, " ").replace(/[\\`*_{}[\]()#+!|<>~]/g, "\\$&").trim().slice(0, 80);
}
+28 -15
View File
@@ -4,7 +4,7 @@ import { CiError } from "../shared/ci-errors.js";
import { renderPublicComment, platformSectionMerge, type PublicCommentState } from "./pr-comment-body.js";
import { upsertStickyComment } from "./pr-comment.js";
import { viewerLinks } from "./viewer-links.js";
import type { ExplorePlatform } from "../config/explore-config.js";
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
export type FailureCommentOptions = {
repository: string;
@@ -15,6 +15,9 @@ export type FailureCommentOptions = {
runAttempt: string;
/** The directory the failure job downloaded diagnostics artifacts into (`<stage>/<artifact>/…/error.json`). */
diagnosticsPath?: string;
/** The failed target's id; otherwise the one the first diagnostics artifact's name carries. */
target?: string;
/** What callers from before targets pass: a platform is the id of its default target. */
platform?: ExplorePlatform;
configPath?: string;
environment?: NodeJS.ProcessEnv;
@@ -23,7 +26,9 @@ export type FailureCommentOptions = {
type Diagnostic = { code: string; stage: string; message: string; nextAction: string };
const SHA = /^[0-9a-f]{40}$/;
const ARTIFACT_DIR = /^explore-[a-z-]+-\d+-\d+-(ios|android)$/;
// `explore-<kind>-<run>-<attempt>-<target>`: the kind has no digits, so the first number is the run and the rest is the target id.
const ARTIFACT_DIR = /^explore-[a-z-]+-\d+-\d+-([a-z][a-z0-9-]{0,31})$/;
const artifactTarget = (name: string): string | undefined => { const id = ARTIFACT_DIR.exec(name)?.[1]; return isTargetId(id) ? id : undefined; };
const MAX_DIAGNOSTIC_BYTES = 32_768;
const CODE = /^[A-Z][A-Z0-9_]{1,63}$/;
@@ -42,21 +47,23 @@ function parseDiagnostic(text: string, stage: string): Diagnostic | undefined {
}
/**
* The error.json a failed job left behind and the platform its artifact name carries. A report failure's
* diagnostic takes precedence over capture's; a present but unreadable file yields the generic failure
* rather than an earlier stage's error, and only regular files count (never symlinks out of the artifact).
* The error.json a failed job left behind and the target its artifact name carries (`ios` or `android` for a config
* without targets, and for artifacts of versions before targets). A report failure's diagnostic takes precedence over
* capture's; a present but unreadable file yields the generic failure rather than an earlier stage's error, and only
* regular files count (never symlinks out of the artifact). `platform` is set when the target id is a platform's.
*/
export async function locateFailureDiagnostic(root: string): Promise<{ diagnostic?: Diagnostic; platform: ExplorePlatform } | undefined> {
export async function locateFailureDiagnostic(root: string): Promise<{ diagnostic?: Diagnostic; target: string; platform?: ExplorePlatform } | undefined> {
for (const [stage, file] of [["report", "error.json"], ["capture", join("explore-diagnostics", "error.json")]] as const) {
const entries = await readdir(join(root, stage), { withFileTypes: true }).catch(() => []);
for (const entry of entries.filter(entry => entry.isDirectory() && ARTIFACT_DIR.test(entry.name)).sort((a, b) => a.name.localeCompare(b.name))) {
for (const entry of entries.filter(entry => entry.isDirectory() && artifactTarget(entry.name)).sort((a, b) => a.name.localeCompare(b.name))) {
const path = join(root, stage, entry.name, file);
const info = await lstat(path).catch(() => undefined);
if (!info) continue;
const platform = ARTIFACT_DIR.exec(entry.name)![1] as ExplorePlatform;
if (!info.isFile() || info.size > MAX_DIAGNOSTIC_BYTES) return { platform };
const target = artifactTarget(entry.name)!;
const located: { target: string; platform?: ExplorePlatform } = { target, ...(target === "ios" || target === "android" ? { platform: target as ExplorePlatform } : {}) };
if (!info.isFile() || info.size > MAX_DIAGNOSTIC_BYTES) return located;
const diagnostic = parseDiagnostic(await readFile(path, "utf8"), stage);
return diagnostic ? { diagnostic, platform } : { platform };
return diagnostic ? { diagnostic, ...located } : located;
}
}
return undefined;
@@ -64,7 +71,7 @@ export async function locateFailureDiagnostic(root: string): Promise<{ diagnosti
/**
* The failure job's comment: a job died outside Explore's own progress comments (install, checkout, a crash
* before the pipeline posted), so the sticky comment gets a failed record for that platform from the same
* before the pipeline posted), so the sticky comment gets a failed record for that target from the same
* renderer every other writer uses. Nothing is posted when the PR is closed; a PR that moved on is marked
* superseded so the failure lands under previous runs.
*/
@@ -75,6 +82,9 @@ export async function publishFailureComment(options: FailureCommentOptions): Pro
if (!token) throw new CiError({ code: "GITHUB_TOKEN_MISSING", stage: "publication", message: "GITHUB_TOKEN is required to post the failure comment",
nextAction: "Pass GITHUB_TOKEN to the failure job with PR comment write permission." });
if (!SHA.test(options.headSha) || !SHA.test(options.baseSha)) return { posted: false, reason: "The capture job did not record the PR head and base." };
const requested = options.target ?? options.platform;
if (requested !== undefined && !isTargetId(requested)) throw new CiError({ code: "TARGET_INVALID", stage: "publication", message: `${requested} is not a target id.`,
nextAction: "Pass --target with an id from targets: in .expo-explore/config.yaml (ios or android without targets:)." });
const response = await transport(`https://api.github.com/repos/${options.repository}/pulls/${options.pullNumber}`, {
headers: { authorization: `Bearer ${token}`, accept: "application/vnd.github+json" }, redirect: "error", signal: AbortSignal.timeout(15_000) });
if (!response.ok) throw new CiError({ code: "GITHUB_REQUEST_FAILED", stage: "publication", message: `GitHub PR lookup failed (${response.status})`,
@@ -85,7 +95,9 @@ export async function publishFailureComment(options: FailureCommentOptions): Pro
}
const superseded = pr.head?.sha !== options.headSha || pr.base?.sha !== options.baseSha;
const located = options.diagnosticsPath ? await locateFailureDiagnostic(options.diagnosticsPath) : undefined;
const platform = options.platform ?? located?.platform;
const target = requested ?? located?.target;
// The failure job knows a target by its id alone; the comment's own record for that id supplies its label and platform.
const platform: ExplorePlatform | undefined = target === "ios" || target === "android" ? target : undefined;
const configPath = options.configPath ?? ".expo-explore/config.yaml";
const now = Date.now();
const diagnostic = located?.diagnostic;
@@ -93,7 +105,8 @@ export async function publishFailureComment(options: FailureCommentOptions): Pro
phase: "failed", mode: "changes", executionMode: "deterministic", configPath,
pullRequest: { repositoryId: String(pr.base?.repo?.id ?? ""), repository: options.repository, number: options.pullNumber, title: String(pr.title ?? ""), url: String(pr.html_url ?? ""),
base: { ref: String(pr.base?.ref ?? ""), sha: options.baseSha }, head: { ref: String(pr.head?.ref ?? ""), sha: options.headSha } },
links: viewerLinks({ repository: options.repository, headSha: options.headSha, runId: options.runId, runAttempt: options.runAttempt, configPath, ...(platform ? { platform } : {}) }),
// No artifact URL, so no Viewer link: the target would only pick a report that this failure never uploaded.
links: viewerLinks({ repository: options.repository, headSha: options.headSha, runId: options.runId, runAttempt: options.runAttempt, configPath }),
startedAt: now, updatedAt: now, artifactOnly: true,
...(platform ? { build: { platform, easProfile: "" } } : {}),
failure: { step: diagnostic?.stage ?? "workflow", message: diagnostic
@@ -101,7 +114,7 @@ export async function publishFailureComment(options: FailureCommentOptions): Pro
: "Explore could not finish this review. See the run for the error code, cause, and next action. Fix the reported issue and rerun Explore." },
...(superseded ? { superseded: true } : {}),
};
await upsertStickyComment({ repository: options.repository, issueNumber: options.pullNumber, body: renderPublicComment(state),
...platformSectionMerge(state, platform), token, fetchImpl: transport });
await upsertStickyComment({ repository: options.repository, issueNumber: options.pullNumber, body: renderPublicComment(state, undefined, target),
...platformSectionMerge(state, target), token, fetchImpl: transport });
return { posted: true, ...(superseded ? { superseded: true } : {}) };
}
+16 -7
View File
@@ -4,16 +4,19 @@ import { createServer, type Server } from "node:http";
import { extname, resolve, sep } from "node:path";
import { fileURLToPath } from "node:url";
import type { ExplorePlatform } from "../config/explore-config.js";
import type { RunTarget } from "../types.js";
import { reportTarget } from "./saved-runs.js";
import { AGENT_API_VERSION, agentApiReply, agentIndexMarkdown, loadReport, prefersHtml, type AgentContext, type LoadedReport } from "./agent-api.js";
/**
* Serve review reports on this machine the way a hosted report serves them: the built Viewer at `/p/<token>`, each
* platform's report at `/p/<token>/report.zip?platform=…`, and the platform list at `/p/<token>/reports.json`. The
* target's report at `/p/<token>/report.zip?target=…` (or `?platform=…`), and the list at `/p/<token>/reports.json`. The
* Viewer already knows this layout, so nothing in it changes. An agent on this machine gets what it gets from a hosted
* link: the Markdown index when it fetches `/p/<token>` without asking for HTML, `/p/<token>/llms.txt`, and the JSON
* API at `/p/<token>/api/v1/...` (agent-api.ts, shared with the hosted Worker). Loopback only; anything else answers 404.
*/
export type LocalReport = { platform: ExplorePlatform; zip: Uint8Array; changes?: number; device?: string };
/** A report to serve; without a target, it is the one named for its platform. */
export type LocalReport = { platform: ExplorePlatform; target?: RunTarget; zip: Uint8Array; changes?: number; device?: string };
export type LocalReportServer = { server: Server; url: string; close: () => Promise<void> };
const TYPES: Record<string, string> = { ".html": "text/html; charset=utf-8", ".js": "text/javascript; charset=utf-8", ".css": "text/css; charset=utf-8",
@@ -27,7 +30,8 @@ export async function startLocalReportServer(options: { reports: LocalReport[];
await stat(resolve(viewerRoot, "index.html"));
const token = options.token ?? [...randomBytes(32)].map(byte => BASE32[byte % 32]).join("");
const page = `/p/${token}`;
const listing = JSON.stringify(options.reports.map(report => ({ platform: report.platform,
// The hosted listing's shape and key order (preview-deploy.ts), without the hosted file paths.
const listing = JSON.stringify(options.reports.map(report => ({ target: reportTarget(report).id, platform: report.platform, label: reportTarget(report).label,
...(report.changes === undefined ? {} : { changes: report.changes }), ...(report.device ? { device: report.device } : {}) })));
const loaded = new Map<LocalReport, Promise<LoadedReport | undefined>>();
let pageUrl = "";
@@ -39,9 +43,13 @@ export async function startLocalReportServer(options: { reports: LocalReport[];
response.end(body);
};
if (request.method !== "GET" && request.method !== "HEAD") return send(405, "Method not allowed");
// `?platform=` picks one of several reports, the first otherwise; an unknown platform matches nothing.
const platforms = url.searchParams.getAll("platform");
const report = platforms.length > 1 ? undefined : platforms.length ? options.reports.find(candidate => candidate.platform === platforms[0]) : options.reports[0];
// `?target=` picks one of several reports; `?platform=`, from links made before targets, the target named for it, else
// the first of that platform; neither, the first. An unknown one matches nothing.
const targets = url.searchParams.getAll("target"), platforms = url.searchParams.getAll("platform");
const report = targets.length + platforms.length > 1 ? undefined
: targets.length ? options.reports.find(candidate => reportTarget(candidate).id === targets[0])
: platforms.length ? options.reports.find(candidate => reportTarget(candidate).id === platforms[0]) ?? options.reports.find(candidate => candidate.platform === platforms[0])
: options.reports[0];
const accept = request.headers.accept ?? null;
const isPage = url.pathname === page || url.pathname === `${page}/`;
const agentPath = url.pathname.startsWith(`${page}/`) ? url.pathname.slice(page.length) : "";
@@ -50,7 +58,8 @@ export async function startLocalReportServer(options: { reports: LocalReport[];
if (!loaded.has(report)) loaded.set(report, loadReport(report.zip));
const content = await loaded.get(report);
if (!content) return send(404, "Not found");
const context: AgentContext = { pageUrl, platform: report.platform, platforms: options.reports.map(entry => entry.platform), expiresAt: null };
const context: AgentContext = { pageUrl, platform: report.platform, platforms: [...new Set(options.reports.map(entry => entry.platform))], expiresAt: null,
target: reportTarget(report).id, targets: options.reports.map(entry => { const { id, platform, label } = reportTarget(entry); return { id, platform, label }; }) };
const link = { link: `<${pageUrl}/api/${AGENT_API_VERSION}>; rel="alternate"; type="application/json", <${pageUrl}/llms.txt>; rel="alternate"; type="text/markdown"`, vary: "Accept" };
if (isPage || agentPath === "/llms.txt") return send(200, agentIndexMarkdown(context, content), "text/markdown; charset=utf-8", link);
const reply = await agentApiReply(context, content, agentPath.slice("/api/v1".length).replace(/\/$/, ""), url.searchParams, accept);
+130 -70
View File
@@ -1,8 +1,10 @@
import type { PublicReview } from "../contracts/capture.js";
import type { RunTarget } from "../types.js";
import type { SimulatorRuntimeMetadata } from "../capture/run.js";
import { CI_COMMENT_MARKER } from "./pr-comment.js";
import { CHANGE_GROUPS, foldRecord, historyLine, readCommentRecords, recordLine, recordSummary, type ChangeGroup, type CommentPlatform, type CommentRecords, type HistoryEntry, type PlatformRecord } from "./pr-comment-record.js";
import { sourceImpactSentences } from "../contracts/source-change.js";
import { CHANGE_GROUPS, MAX_COMMENT_TARGETS, changeCountText, compareTargets, defaultTargetLabel, foldRecord, strongerGroup, historyLine, orderedRecords, readCommentRecords, recordLabel, recordLine, recordSummary, recordTarget,
type ChangeGroup, type CommentTarget, type CommentRecords, type HistoryEntry, type PlatformRecord } from "./pr-comment-record.js";
import { isAccessibilityOnlyChange } from "../contracts/review-validation.js";
import type { PublicCaptureHealth, PublicEvidenceSummary } from "../review/evidence-assessment.js";
import type { ReviewPresentation } from "../contracts/review.js";
import type { ViewerLinks } from "./viewer-links.js";
@@ -34,6 +36,10 @@ export type PublicCommentState = {
easBuildId?: string;
reusedEasBuild?: boolean;
};
/** The target this run captures; absent in states from before targets (then the target is build.platform). */
target?: RunTarget;
/** Every target the config captures, in config order, when more than one. */
targets?: RunTarget[];
runtime?: SimulatorRuntimeMetadata;
capture?: {
planned: { base: number; head: number };
@@ -60,8 +66,8 @@ const GROUP_LABEL: Record<ReviewGroup, string> = {
added: "🟩 Added",
modified: "🟧 Modified",
removed: "🟥 Removed",
"accessibility-only": "🟦 Accessibility only",
"needs-review": "🟨 Needs review",
"source-affected": "🟨 Source-affected",
};
/** The body is HTML, so no blank lines are needed and the block keeps its natural spacing. */
@@ -121,16 +127,32 @@ function plural(count: number, noun: string): string {
type Surface = PublicReview["surfaces"][number];
/** Evidence-based group when the run produced verdicts; otherwise the source-based status. */
function groupOf(surface: Surface, evidenceBased: boolean): ReviewGroup | "unchanged" | "variant" {
/**
* The group a surface is listed under, from the run's verdicts. A screen without one (its source changed but no
* screenshots were compared) is not listed: Explore reports what the captures show. A capture that failed is counted as
* unavailable in the result and named under Validation instead.
*/
function groupOf(surface: Surface, evidenceBased: boolean): ReviewGroup | "unlisted" {
if (surface.status === "added" || surface.status === "removed") return surface.status;
const verified = (["base", "head"] as const).every(side => surface[`${side}Image`]
&& surface[`${side}Outcome`]?.status === "captured" && surface[`${side}Outcome`]?.landing === "verified");
if (evidenceBased && verified && surface.review && surface.visual?.reason !== "diff-failed") return surface.review.status;
switch (surface.status) {
case "modified": return "source-affected";
case "unchanged": return "unchanged";
if (evidenceBased && verified && surface.review && surface.visual?.reason !== "diff-failed") {
const status = surface.review.status;
if (status === "unchanged" || status === "variant") return "unlisted";
return isAccessibilityOnlyChange(surface) ? "accessibility-only" : status;
}
return "unlisted";
}
/**
* A screen whose source changed and whose captures were both verified, but that has no verdict: the comparison did
* not run or failed. Not a change, but not a screen that looks the same either, so the result says how many.
*/
function notComparedChange(surface: Surface): boolean {
if (surface.status !== "modified" || (surface.head ?? surface.base)?.kind === "redirect") return false;
const verified = (["base", "head"] as const).every(side => surface[`${side}Image`]
&& surface[`${side}Outcome`]?.status === "captured" && surface[`${side}Outcome`]?.landing === "verified");
return verified && (!surface.review || surface.visual?.reason === "diff-failed");
}
function routeOf(surface: Surface): string {
@@ -143,9 +165,6 @@ function descriptionOf(surface: Surface, group: ReviewGroup): string {
if (group === "added") return `Added ${route} screen`;
if (group === "removed") return `Removed ${route} screen`;
// A group's own label already says added or removed; the route makes the line readable alone.
if (group === "source-affected") {
return sourceImpactSentences(surface.sourceImpact) ?? "Source-affected; not compared";
}
if (surface.review) return plainText(surface.review.description, MAX_DESCRIPTION_LENGTH);
return "No visible change";
}
@@ -214,8 +233,6 @@ function contextLines(review: PublicReview): string[] {
return lines.length ? [...lines, ""] : [];
}
const PLATFORM_LABELS: Record<CommentPlatform, string> = { ios: "iOS", android: "Android" };
const PLATFORM_ORDER: CommentPlatform[] = ["ios", "android"];
const SURFACE_ID = /^[A-Za-z0-9._-]{1,200}(@(light|dark))?$/;
const MAX_ROWS_PER_GROUP = 200;
@@ -229,9 +246,28 @@ function schemeOf(id: string): string | undefined {
return /@(light|dark)$/.exec(id)?.[1];
}
/** This writer's state as the compact record the comment is rendered from. */
export function platformRecordOf(state: PublicCommentState, platform?: CommentPlatform): PlatformRecord {
/**
* The position of a target in config.yaml, recorded only when the run's targets are not the per-platform ios and
* android (in that order, with their default labels): those render in the order and with the labels they always had.
*/
function targetOrder(targets: PublicCommentState["targets"], id: CommentTarget): number | undefined {
if (!targets?.length) return undefined;
const ids = targets.map(target => target.id).join(",");
const perPlatform = ["ios", "android", "ios,android"].includes(ids) && targets.every(target => target.id === target.platform && target.label === defaultTargetLabel(target.id));
const index = targets.findIndex(target => target.id === id);
return perPlatform || index < 0 || index >= MAX_COMMENT_TARGETS ? undefined : index;
}
/**
* This writer's state as the compact record the comment is rendered from, keyed by its target: the state's own, else
* `target` (a writer that knows only the id, such as the failure job), else the build's platform (states from before targets).
*/
export function platformRecordOf(state: PublicCommentState, target?: CommentTarget): PlatformRecord {
const pr = state.pullRequest;
const id = state.target?.id ?? target ?? state.build?.platform ?? "ios";
const platform = state.target?.platform ?? state.build?.platform ?? (id === "android" ? "android" : "ios");
const label = state.target?.label && state.target.label !== defaultTargetLabel(id) ? state.target.label : undefined;
const order = targetOrder(state.targets, id);
const { runId, runAttempt } = runIdentity(state.links.run);
// While the hosted preview is deploying the central Viewer's download-and-drop page would read as the report, so no link.
const deploying = state.phase === "ready" && !state.links.preview && state.links.deploying === true;
@@ -239,7 +275,7 @@ export function platformRecordOf(state: PublicCommentState, platform?: CommentPl
// A republished review keeps the duration of the run that produced it.
const reviewedAt = state.phase === "ready" && state.review ? Date.parse(state.review.createdAt) : NaN;
const record: PlatformRecord = {
v: 1, platform: platform ?? state.build?.platform ?? "ios", runId, runAttempt, headSha: pr.head.sha, baseSha: pr.base.sha,
v: 1, platform, ...(id !== platform ? { target: id } : {}), ...(label ? { label } : {}), ...(order !== undefined ? { order } : {}), runId, runAttempt, headSha: pr.head.sha, baseSha: pr.base.sha,
startedAt: state.startedAt, updatedAt: Number.isFinite(reviewedAt) ? reviewedAt : state.updatedAt, phase: state.phase,
links: { run: state.links.run, artifacts: state.links.artifacts, config: state.links.config, ...(report ? { report } : {}),
...(state.phase === "ready" && state.links.download ? { download: state.links.download } : {}),
@@ -270,10 +306,12 @@ export function platformRecordOf(state: PublicCommentState, platform?: CommentPl
for (const surface of state.review.surfaces) {
if ((surface.head ?? surface.base)?.kind === "redirect") continue;
const group = groupOf(surface, evidenceBased);
if (group === "unchanged" || group === "variant") continue;
if (group === "unlisted") continue;
const scheme = schemeOf(surface.id);
record.changes.push({ id: surface.id, route: routeOf(surface), group, description: descriptionOf(surface, group), ...(scheme ? { scheme } : {}) });
}
const notCompared = state.review.surfaces.filter(notComparedChange).length;
if (notCompared) record.notCompared = notCompared;
record.context = contextLines(state.review).filter(line => line.length);
const diagnostics = [...(state.evidence?.diagnostics ?? [])];
for (const surface of state.review.surfaces) {
@@ -318,12 +356,12 @@ function resultCell(record: PlatformRecord): string {
}
case "failed": return `🟥 failed · ${inlineText(record.failure?.step ?? "capture", 48)}`;
case "ready": {
const changes = record.changes?.length ?? 0;
const unavailable = record.health ? record.health.base.unavailable + record.health.head.unavailable : 0;
const unverified = record.health ? record.health.base.unverified + record.health.head.unverified : 0;
const failed = (record.validation?.visual?.failed ?? 0) + (record.validation?.accessibility?.failed ?? 0);
const icon = unavailable || unverified || failed ? "🟨" : "🟩";
return [`${icon} ${plural(changes, "change")}`, unavailable ? `${unavailable} unavailable` : undefined, unverified ? `${unverified} unattributed` : undefined,
const notCompared = record.notCompared ?? 0;
const icon = unavailable || unverified || failed || notCompared ? "🟨" : "🟩";
return [`${icon} ${changeCountText(record.changes?.map(change => change.group) ?? [])}`, notCompared ? `${notCompared} not compared` : undefined, unavailable ? `${unavailable} unavailable` : undefined, unverified ? `${unverified} unattributed` : undefined,
failed ? `${failed} comparison${failed === 1 ? "" : "s"} failed` : undefined, duration(record.startedAt, record.updatedAt)].filter(Boolean).join(" · ");
}
}
@@ -337,13 +375,21 @@ function reportCell(record: PlatformRecord): string {
return record.links.report ? link(record.links.report.includes(".expo.app/") ? "Open" : "Viewer", record.links.report) : record.links.deploying ? "deploying…" : run;
}
/** "Workflow iOS run · zip; Android run · zip" for the ready platforms, with the platform named only when there are several. */
/** A target's label as Markdown text. */
const labelOf = (record: PlatformRecord) => inlineText(recordLabel(record), 80);
/** "platform" for the per-platform targets of a config without targets, "device" once a config names its own. */
function targetNoun(records: PlatformRecord[]): "platform" | "device" {
return records.every(record => !record.target && record.label === undefined) ? "platform" : "device";
}
/** "Workflow iOS run · zip; Android run · zip" for the ready targets, with the target named only when there are several. */
function artifactLinks(records: PlatformRecord[]): string | undefined {
const ready = records.filter(record => record.phase === "ready");
if (!ready.length) return undefined;
const parts = ready.map(record => {
const links = [link("run", record.links.run), record.links.download ? link("zip", record.links.download) : undefined].filter(Boolean).join(" · ");
return ready.length > 1 ? `${PLATFORM_LABELS[record.platform]} ${links}` : links;
return ready.length > 1 ? `${labelOf(record)} ${links}` : links;
});
return `Workflow ${parts.join("; ")}`;
}
@@ -354,7 +400,7 @@ function deviceCell(record: PlatformRecord): string {
return parts.length ? parts.join(" · ") : "—";
}
type ChangeRow = { id: string; route: string; scheme?: string; group: ReviewGroup; description: string; perPlatform: Partial<Record<CommentPlatform, { group: ReviewGroup; href?: string }>> };
type ChangeRow = { id: string; route: string; scheme?: string; group: ReviewGroup; description: string; perTarget: Partial<Record<CommentTarget, { group: ReviewGroup; href?: string }>> };
function changeRows(records: PlatformRecord[]): Map<ReviewGroup, ChangeRow[]> {
const rows = new Map<string, ChangeRow>();
@@ -362,8 +408,10 @@ function changeRows(records: PlatformRecord[]): Map<ReviewGroup, ChangeRow[]> {
if (record.phase !== "ready") continue;
for (const change of record.changes ?? []) {
const href = record.links.report ? surfaceLink(record.links.report, change.id) : undefined;
const row = rows.get(change.id) ?? { id: change.id, route: change.route, group: change.group, description: change.description, perPlatform: {}, ...(change.scheme ? { scheme: change.scheme } : {}) };
row.perPlatform[record.platform] = { group: change.group, ...(href ? { href } : {}) };
const row = rows.get(change.id) ?? { id: change.id, route: change.route, group: change.group, description: change.description, perTarget: {}, ...(change.scheme ? { scheme: change.scheme } : {}) };
// A screen accessibility-only on one target and visibly changed on another is listed as the visible change.
if (strongerGroup(row.group, change.group) !== row.group) Object.assign(row, { group: change.group, description: change.description });
row.perTarget[recordTarget(record)] = { group: change.group, ...(href ? { href } : {}) };
rows.set(change.id, row);
}
}
@@ -372,30 +420,33 @@ function changeRows(records: PlatformRecord[]): Map<ReviewGroup, ChangeRow[]> {
return groups;
}
function renderChangeRow(row: ChangeRow, platforms: CommentPlatform[]): string {
const where = platforms.flatMap(platform => {
const entry = row.perPlatform[platform];
function renderChangeRow(row: ChangeRow, records: PlatformRecord[]): string {
const where = records.flatMap(record => {
const entry = row.perTarget[recordTarget(record)];
if (!entry) return [];
const label = PLATFORM_LABELS[platform] + (entry.group !== row.group ? ` (${GROUP_LABEL[entry.group].replace(/^\S+ /, "").toLowerCase()})` : "");
const label = labelOf(record) + (entry.group !== row.group ? ` (${GROUP_LABEL[entry.group].replace(/^\S+ /, "").toLowerCase()})` : "");
return [entry.href ? link(label, entry.href) : label];
});
const route = `\`${plainText(row.route, MAX_ROUTE_LENGTH).replace(/`/g, "")}\`${row.scheme ? ` (${inlineText(row.scheme, 20)})` : ""}`;
return `- ${route} — ${inlineText(row.description, MAX_DESCRIPTION_LENGTH)}${where.length ? ` · ${where.join(" · ")}` : ""}`;
}
function changesSection(records: PlatformRecord[], platforms: CommentPlatform[], rowCap: number): string[] {
function changesSection(records: PlatformRecord[], rowCap: number): string[] {
const ready = records.filter(record => record.phase === "ready");
if (!ready.length) return [];
const groups = changeRows(ready);
const lines: string[] = [];
const noun = targetNoun(records);
const total = [...groups.values()].reduce((sum, rows) => sum + rows.length, 0);
lines.push(`**Changes** · ${plural(total, "screen")}${platforms.length > 1 && ready.length > 1 ? " · a screen is listed once, with a link per platform" : ""}`, "");
if (total === 0) lines.push("No screen changed on the reviewed platforms.", "");
lines.push(`**Changes** · ${plural(total, "screen")}${records.length > 1 && ready.length > 1 ? ` · a screen is listed once, with a link per ${noun}` : ""}`, "");
// With screens left uncompared, nothing changed only among the ones compared.
if (total === 0) lines.push(ready.some(record => record.notCompared) ? `No compared screen changed on the reviewed ${noun}s.` : `No screen changed on the reviewed ${noun}s.`, "");
for (const group of GROUP_ORDER) {
const rows = groups.get(group) ?? [];
if (!rows.length) continue;
const shown = rows.slice(0, rowCap);
const content = ["", ...shown.map(row => renderChangeRow(row, platforms))];
const content = ["", ...(group === "accessibility-only" ? ["Before and After look the same. What screen readers and voice control read changed.", ""] : []),
...shown.map(row => renderChangeRow(row, records))];
if (rows.length > shown.length) {
const report = ready.find(record => record.links.report)?.links.report;
content.push(`- ${rows.length - shown.length} more${report ? ` — ${link("Explore report", report)}` : ""}`);
@@ -408,14 +459,14 @@ function changesSection(records: PlatformRecord[], platforms: CommentPlatform[],
if (seen.has(line)) continue;
seen.add(line);
const everywhere = ready.every(other => other.context?.includes(line));
lines.push(everywhere ? line : `${PLATFORM_LABELS[record.platform]} · ${line}`, "");
lines.push(everywhere ? line : `${labelOf(record)} · ${line}`, "");
}
return lines;
}
/**
* The heading carries the report links: on a phone the table's last column is clipped, and the
* commits it reviews are a subtitle under it. A platform still capturing adds its link when it is ready.
* commits it reviews are a subtitle under it. A target still capturing adds its link when it is ready.
*/
function heading(records: PlatformRecord[]): string {
const ready = records.filter(record => record.phase === "ready" && record.links.report);
@@ -423,7 +474,7 @@ function heading(records: PlatformRecord[]): string {
return records.some(record => record.phase === "ready" && record.links.deploying) ? "### Explore review · report deploying, not ready yet" : "### Explore review";
}
const links = ready.length === 1 ? [link("Open report", ready[0]!.links.report!)]
: ready.map(record => link(`${PLATFORM_LABELS[record.platform]} report`, record.links.report!));
: ready.map(record => link(`${labelOf(record)} report`, record.links.report!));
return `### Explore review · ${links.join(" · ")}`;
}
@@ -476,24 +527,23 @@ function validationSummary(record: PlatformRecord): string {
}
}
function validationSection(records: PlatformRecord[], platforms: CommentPlatform[]): string[] {
if (!records.some(record => record.phase === "ready" || record.phase === "failed")) return [];
const byPlatform = platforms.map(platform => records.find(record => record.platform === platform)!);
const summary = `Validation · ${byPlatform.map(record => `${PLATFORM_LABELS[record.platform]} ${validationSummary(record)}`).join(" · ")}`;
const header = platforms.length > 1 ? `| Check | ${byPlatform.map(record => PLATFORM_LABELS[record.platform]).join(" | ")} |` : `| Check | ${PLATFORM_LABELS[byPlatform[0]!.platform]} |`;
function validationSection(byTarget: PlatformRecord[]): string[] {
if (!byTarget.some(record => record.phase === "ready" || record.phase === "failed")) return [];
const summary = `Validation · ${byTarget.map(record => `${labelOf(record)} ${validationSummary(record)}`).join(" · ")}`;
const header = `| Check | ${byTarget.map(labelOf).join(" | ")} |`;
const checks: [string, Parameters<typeof validationCell>[1]][] = [["Capture", "capture"], ["Route verification", "routes"], ["Visual comparison", "visual"], ["Accessibility comparison", "accessibility"], ["Source inventory", "inventory"]];
const content = ["", header, `|---|${byPlatform.map(() => "---").join("|")}|`,
...checks.map(([label, check]) => `| ${label} | ${byPlatform.map(record => validationCell(record, check)).join(" | ")} |`), ""];
for (const record of byPlatform) {
const content = ["", header, `|---|${byTarget.map(() => "---").join("|")}|`,
...checks.map(([label, check]) => `| ${label} | ${byTarget.map(record => validationCell(record, check)).join(" | ")} |`), ""];
for (const record of byTarget) {
if (record.phase === "failed" && record.failure) {
content.push(`**${PLATFORM_LABELS[record.platform]} failed** — ${inlineText(record.failure.message, 1200)} ${link("Open the failed run", record.links.run)} · ${link("Evidence artifact", record.links.artifacts)}`, "");
content.push(`**${labelOf(record)} failed** — ${inlineText(record.failure.message, 1200)} ${link("Open the failed run", record.links.run)} · ${link("Evidence artifact", record.links.artifacts)}`, "");
}
if (record.phase !== "ready") continue;
const health = record.health;
const gaps = health ? health.base.unavailable + health.base.unverified + health.head.unavailable + health.head.unverified : 0;
if (!gaps && !record.diagnostics?.length) continue;
const sideLine = (side: "base" | "head") => { const h = health![side]; return `${side} ${h.verified}/${h.planned} verified${h.unverified ? ` · ${h.unverified} unattributed` : ""}${h.unavailable ? ` · ${h.unavailable} unavailable` : ""}`; };
content.push(health ? `**${PLATFORM_LABELS[record.platform]}** · ${sideLine("base")} · ${sideLine("head")}` : `**${PLATFORM_LABELS[record.platform]}**`, "");
content.push(health ? `**${labelOf(record)}** · ${sideLine("base")} · ${sideLine("head")}` : `**${labelOf(record)}**`, "");
for (const diagnostic of record.diagnostics ?? []) {
content.push(`- ${diagnostic.side ? `${diagnostic.side === "base" ? "Base" : "Head"} · ` : ""}${inlineText(diagnostic.route, MAX_ROUTE_LENGTH)} · ${inlineText(diagnostic.code, 80)}: ${inlineText(diagnostic.message, 160)} Next action: ${inlineText(diagnostic.nextAction, 240)}`);
}
@@ -507,13 +557,12 @@ function validationSection(records: PlatformRecord[], platforms: CommentPlatform
function historySection(repository: string, history: HistoryEntry[]): string[] {
if (!history.length) return [];
const content = ["", ...history.map(entry => {
const platforms = PLATFORM_ORDER.flatMap(platform => {
const item = entry.platforms[platform];
if (!item) return [];
const links = [item.report ? link("report", item.report) : undefined, link("run", item.run)].filter(Boolean).join(" · ");
return [`${PLATFORM_LABELS[platform]} ${inlineText(item.summary, 120)} (${links})`];
});
return `- ${commitLink(repository, entry.headSha)} · ${platforms.join(" · ")}`;
const targets = Object.keys(entry.platforms).map(id => ({ id, item: entry.platforms[id]! })).filter(({ item }) => Boolean(item))
.sort((a, b) => compareTargets({ id: a.id, order: a.item.order }, { id: b.id, order: b.item.order })).map(({ id, item }) => {
const links = [item.report ? link("report", item.report) : undefined, link("run", item.run)].filter(Boolean).join(" · ");
return `${inlineText(item.label ?? defaultTargetLabel(id), 80)} ${inlineText(item.summary, 120)} (${links})`;
});
return `- ${commitLink(repository, entry.headSha)} · ${targets.join(" · ")}`;
}), ""];
return details(`Previous runs (${history.length})`, content);
}
@@ -536,10 +585,9 @@ function deploymentMarkerOf(records: CommentRecords): string | undefined {
return names.size ? `<!-- expo-explore-deployments:${[...names].sort().join(",")} -->` : undefined;
}
/** The whole comment from its records: hidden lines first, then one review for every platform of the current run. */
/** The whole comment from its records: hidden lines first, then one review for every target of the current run, in config order. */
export function renderCommentRecords(records: CommentRecords, existing?: string, budget = PUBLIC_COMMENT_BODY_BUDGET): string {
const current = PLATFORM_ORDER.flatMap(platform => records.current[platform] ? [records.current[platform]!] : []);
const platforms = current.map(record => record.platform);
const current = orderedRecords(records);
const hidden = [CI_COMMENT_MARKER, ...[deploymentMarkerOf(records)].filter((line): line is string => Boolean(line)),
...current.map(recordLine), ...[historyLine(records.history)].filter((line): line is string => Boolean(line))];
if (!current.length) return [...hidden, "### Explore review", "", ...(records.history.some(entry => Object.values(entry.platforms).some(item => item?.superseded)) ? [SUPERSEDED_NOTE, ""] : []),
@@ -551,9 +599,9 @@ export function renderCommentRecords(records: CommentRecords, existing?: string,
`<sub>base ${commitLink(repository, first.baseSha)} → ${commitLink(repository, first.headSha)}</sub>`, ""];
if (first.superseded) lines.push(SUPERSEDED_NOTE, "");
lines.push(`| | Device | Result | Report |`, `|---|---|---|---|`,
...current.map(record => `| ${PLATFORM_LABELS[record.platform]} | ${deviceCell(record)} | ${resultCell(record)} | ${reportCell(record)} |`), "");
lines.push(...changesSection(current, platforms, rowCap));
lines.push(...validationSection(current, platforms));
...current.map(record => `| ${labelOf(record)} | ${deviceCell(record)} | ${resultCell(record)} | ${reportCell(record)} |`), "");
lines.push(...changesSection(current, rowCap));
lines.push(...validationSection(current));
lines.push(...historySection(repository, records.history));
const expiries = current.filter(record => record.phase === "ready" && record.links.expiresAt !== undefined).map(record => record.links.expiresAt);
const footer: string[] = [];
@@ -580,16 +628,19 @@ function configPathOf(config: string): string {
return match ? decodeURIComponent(match[1]!) : "config";
}
/** Render the sticky pull-request comment for any phase of a public review run, folding this writer into the existing comment's records. */
export function renderPublicComment(state: PublicCommentState, existing?: string, platform?: CommentPlatform): string {
/**
* Render the sticky pull-request comment for any phase of a public review run, folding this writer into the existing
* comment's records. `target` keys the record when the state names no target of its own (see platformRecordOf).
*/
export function renderPublicComment(state: PublicCommentState, existing?: string, target?: CommentTarget): string {
const pr = state.pullRequest;
if (pr.origin === "local") return renderLocalText(state);
return renderCommentRecords(foldRecord(readCommentRecords(existing), platformRecordOf(state, platform)), existing);
return renderCommentRecords(foldRecord(readCommentRecords(existing), platformRecordOf(state, target)), existing);
}
/** The sticky-comment merge for a writer: every writer re-renders the whole comment from the records it carries plus its own. */
export function platformSectionMerge(state: PublicCommentState, platform: CommentPlatform | undefined): { merge: (existing: string | undefined) => string } {
return { merge: existing => renderPublicComment(state, existing, platform) };
export function platformSectionMerge(state: PublicCommentState, target: CommentTarget | undefined): { merge: (existing: string | undefined) => string } {
return { merge: existing => renderPublicComment(state, existing, target) };
}
/** "iPhone 17 Pro 26.0 · light + dark": the device model and OS version the report's head capture ran on, and its appearances when it captured several. */
@@ -606,19 +657,28 @@ export function reviewChanges(review: PublicReview): Map<string, ChangeGroup> {
for (const surface of review.surfaces) {
if ((surface.head ?? surface.base)?.kind === "redirect") continue;
const group = groupOf(surface, evidenceBased);
if (group !== "unchanged" && group !== "variant") changes.set(surface.id, group);
if (group !== "unlisted") changes.set(surface.id, group);
}
return changes;
}
/** Surfaces the review calls changed (reviewer verdicts first, raw status otherwise); undefined before the review exists. */
/** How many screens the comment lists as changed; undefined before the review exists. */
export function reviewChangeCount(state: Pick<PublicCommentState, "review">): number | undefined {
return state.review?.surfaces.filter(surface => surface.review ? surface.review.status !== "unchanged" && surface.review.status !== "variant"
: surface.status !== "unchanged").length;
return state.review ? reviewChanges(state.review).size : undefined;
}
export { recordSummary, readCommentRecords };
/** A surface's status in the local text summary, named as the comment groups it. */
function localStatus(surface: Surface): string {
if (isAccessibilityOnlyChange(surface)) return "accessibility only";
if (surface.review) return surface.review.status;
if (surface.status === "added" || surface.status === "removed") return surface.status;
const failed = (["base", "head"] as const).some(side => surface[side]?.kind === "screen" && !surface[`${side}Image`]
&& surface[`${side}Outcome`] && surface[`${side}Outcome`]?.status !== "captured");
return failed ? "unavailable" : "not compared";
}
function renderLocalText(state: PublicCommentState): string {
const pr = state.pullRequest as Extract<ReviewPresentation, { origin: "local" }>;
const counts = state.capture;
@@ -630,6 +690,6 @@ function renderLocalText(state: PublicCommentState): string {
...(counts && counts.planned.base + counts.planned.head === 0 ? ["No captures selected; visual comparison was not required.", ""] : []),
...(state.review?.surfaces.filter(s => (s.status === "added" || s.status === "removed"
|| s.baseOutcome || s.headOutcome || s.review) && s.review?.status !== "unchanged" && s.review?.status !== "variant").map(s =>
`- ${inlineText((s.head ?? s.base)?.route ?? s.id, 160)}: ${s.review?.status ?? (s.status === "added" || s.status === "removed" ? s.status : "not compared")}${s.note ? ` — ${inlineText(s.note.text, 500)}` : ""}`) ?? []),
`- ${inlineText((s.head ?? s.base)?.route ?? s.id, 160)}: ${localStatus(s)}${s.note ? ` — ${inlineText(s.note.text, 500)}` : ""}`) ?? []),
"", ...(state.review ? contextLines(state.review) : []), "Report: artifacts/report.zip", "Details: README.md, agent-mode-cost.md, issues.md", ""].join("\n");
}
+122 -28
View File
@@ -1,26 +1,73 @@
import { deflateRawSync, inflateRawSync } from "node:zlib";
import { isTargetId } from "../config/explore-config.js";
/**
* The sticky PR comment is rendered from compact per-platform records that every writer embeds as hidden
* The sticky PR comment is rendered from compact per-target records that every writer embeds as hidden
* HTML comment lines, so the capture, report, deploy and failure jobs of one run (and the runs that follow
* it) each rewrite the whole comment from the same data without needing the other jobs' files:
*
* <!-- expo-explore-record:<platform>:<base64url(deflate(json))> --> one per platform of the current run
* <!-- expo-explore-history:<base64url(deflate(json))> --> earlier runs on this PR
* <!-- expo-explore-record:<target>:<base64url(deflate(json))> --> one per target of the current run
* <!-- expo-explore-history:<base64url(deflate(json))> --> earlier runs on this PR
*
* A config without targets has one target per platform whose id is the platform (`ios`, `android`); its records
* carry neither `target` nor `label` nor `order`, so they are byte-identical to the per-platform records of
* versions before targets, and those still parse.
*
* Records read back from GitHub are untrusted: anything that does not match the schema is dropped and the
* comment renders without it.
*/
export type CommentPlatform = "ios" | "android";
/** A target id (`ios`, `android`, or an id from config.yaml's targets); it keys records and history entries. */
export type CommentTarget = string;
/** A config has at most 8 targets; a comment never holds more records than that. */
export const MAX_COMMENT_TARGETS = 8;
const PLATFORM_LABELS: Record<CommentPlatform, string> = { ios: "iOS", android: "Android" };
const LEGACY_ORDER: CommentPlatform[] = ["ios", "android"];
/** The label a target shows without a `label` of its own: iOS and Android for the per-platform ids, else the id. */
export function defaultTargetLabel(id: CommentTarget): string {
return id === "ios" || id === "android" ? PLATFORM_LABELS[id] : id;
}
export type RecordPhase = "pending" | "capturing" | "ready" | "failed";
export type ChangeGroup = "added" | "modified" | "removed" | "needs-review" | "source-affected";
export const CHANGE_GROUPS: ChangeGroup[] = ["added", "removed", "modified", "needs-review", "source-affected"];
/**
* `accessibility-only`: modified, but the screenshots match; only what assistive technology reads changed. A screen
* whose source changed but that was not compared is no group: Explore reports what the captures show, not what the code
* might do.
*/
export type ChangeGroup = "added" | "modified" | "removed" | "accessibility-only" | "needs-review";
export const CHANGE_GROUPS: ChangeGroup[] = ["added", "removed", "modified", "accessibility-only", "needs-review"];
/**
* "12 changes", or "3 visual changes · 12 accessibility only" when some changed only for assistive technology: those
* are changes too (screen readers and voice control see them), but not ones a screenshot shows.
*/
/**
* The group of a screen that changed on several targets. Accessibility only says the screenshots match, so it
* yields to any other group; otherwise the first target's group stands, as it always has.
*/
export function strongerGroup(first: ChangeGroup, other: ChangeGroup): ChangeGroup {
return first === "accessibility-only" ? other : first;
}
export function changeCountText(groups: readonly ChangeGroup[]): string {
const accessibility = groups.filter(group => group === "accessibility-only").length;
const visual = groups.length - accessibility;
if (!accessibility) return `${visual} change${visual === 1 ? "" : "s"}`;
return [visual ? `${visual} visual change${visual === 1 ? "" : "s"}` : undefined, `${accessibility} accessibility only`].filter(Boolean).join(" · ");
}
export type SideHealth = { planned: number; captured: number; verified: number; unverified: number; unavailable: number };
export type PlatformRecord = {
v: 1;
/** The target's platform. A failure record of a target it never saw before guesses ios; nothing renders it. */
platform: CommentPlatform;
/** The target id, when it is not the platform. */
target?: CommentTarget;
/** What the comment calls the target, when that is not defaultTargetLabel(id). */
label?: string;
/** The target's position in config.yaml, when the run's targets are not the per-platform ios, android. */
order?: number;
runId: string;
runAttempt: string;
headSha: string;
@@ -41,6 +88,8 @@ export type PlatformRecord = {
};
/** The review's changed surfaces, one per surface; `scheme` for a secondary appearance (`<route>@<scheme>`). */
changes?: { id: string; route: string; group: ChangeGroup; description: string; scheme?: string }[];
/** Screens whose source changed and whose captures were verified, but that got no verdict: the comparison did not run or failed. */
notCompared?: number;
/** Differences stated once rather than per screen (variants, app-wide source changes). */
context?: string[];
diagnostics?: { side?: "base" | "head"; route: string; code: string; message: string; nextAction: string }[];
@@ -55,13 +104,36 @@ export type HistoryEntry = {
baseSha: string;
runId: string;
startedAt: number;
platforms: Partial<Record<CommentPlatform, { phase: RecordPhase; summary: string; run: string; report?: string; download?: string; superseded?: boolean }>>;
/** Keyed by target id (the platform for configs without targets; the key keeps its old name so old entries parse). */
platforms: Partial<Record<CommentTarget, HistoryItem>>;
};
export type HistoryItem = { phase: RecordPhase; summary: string; run: string; report?: string; download?: string; superseded?: boolean; label?: string; order?: number };
export type CommentRecords = { current: Partial<Record<CommentPlatform, PlatformRecord>>; history: HistoryEntry[] };
export type CommentRecords = { current: Partial<Record<CommentTarget, PlatformRecord>>; history: HistoryEntry[] };
/** The id a record is keyed by. */
export function recordTarget(record: Pick<PlatformRecord, "platform" | "target">): CommentTarget {
return record.target ?? record.platform;
}
export function recordLabel(record: Pick<PlatformRecord, "platform" | "target" | "label">): string {
return record.label ?? defaultTargetLabel(recordTarget(record));
}
/** Config order where the run recorded one, else iOS before Android, then by id. */
export function compareTargets(a: { id: CommentTarget; order?: number | undefined }, b: { id: CommentTarget; order?: number | undefined }): number {
const rank = (item: { id: CommentTarget; order?: number | undefined }) => item.order ?? (LEGACY_ORDER.includes(item.id as CommentPlatform) ? LEGACY_ORDER.indexOf(item.id as CommentPlatform) : MAX_COMMENT_TARGETS);
return rank(a) - rank(b) || (a.id < b.id ? -1 : a.id > b.id ? 1 : 0);
}
/** The current records in display order. */
export function orderedRecords(records: CommentRecords): PlatformRecord[] {
return Object.values(records.current).filter((record): record is PlatformRecord => Boolean(record))
.sort((a, b) => compareTargets({ id: recordTarget(a), order: a.order }, { id: recordTarget(b), order: b.order }));
}
export const HISTORY_LIMIT = 5;
const RECORD_LINE = /^<!-- expo-explore-record:(ios|android):([A-Za-z0-9_-]+) -->$/gm;
const RECORD_LINE = /^<!-- expo-explore-record:([a-z][a-z0-9-]{0,31}):([A-Za-z0-9_-]+) -->$/gm;
const HISTORY_LINE = /^<!-- expo-explore-history:([A-Za-z0-9_-]+) -->$/m;
const MAX_ENCODED = 24_000;
const MAX_DECODED = 256_000;
@@ -83,7 +155,7 @@ function decodePayload(encoded: string): unknown {
}
export function recordLine(record: PlatformRecord): string {
return `<!-- expo-explore-record:${record.platform}:${encodeRecordPayload(record)} -->`;
return `<!-- expo-explore-record:${recordTarget(record)}:${encodeRecordPayload(record)} -->`;
}
export function historyLine(history: HistoryEntry[]): string | undefined {
@@ -96,6 +168,8 @@ const isCount = (value: unknown): value is number => typeof value === "number" &
const isTime = (value: unknown): value is number => typeof value === "number" && Number.isFinite(value) && value > 0;
const isPhase = (value: unknown): value is RecordPhase => value === "pending" || value === "capturing" || value === "ready" || value === "failed";
const isPlatform = (value: unknown): value is CommentPlatform => value === "ios" || value === "android";
const isLabel = (value: unknown): value is string => isString(value, 80) && value.trim().length > 0;
const isOrder = (value: unknown): value is number => isCount(value) && value < MAX_COMMENT_TARGETS;
const isSide = (value: unknown): value is "base" | "head" => value === "base" || value === "head";
const isUrl = (value: unknown): value is string => {
if (!isString(value, 4000)) return false;
@@ -117,9 +191,11 @@ export function parsePlatformRecord(value: unknown): PlatformRecord | undefined
|| !isRecord(value.links) || !isUrl(value.links.run) || !isUrl(value.links.artifacts) || !isUrl(value.links.config)
|| !optional(value.links.report, isUrl) || !optional(value.links.download, isUrl)
|| !(value.links.expiresAt === undefined || value.links.expiresAt === null || isTime(value.links.expiresAt))
|| !(value.links.deploying === undefined || value.links.deploying === true)) return undefined;
|| !(value.links.deploying === undefined || value.links.deploying === true)
|| !optional(value.target, isTargetId) || !optional(value.label, isLabel) || !optional(value.order, isOrder)) return undefined;
const record: PlatformRecord = {
v: 1, platform: value.platform, runId: value.runId, runAttempt: value.runAttempt, headSha: value.headSha, baseSha: value.baseSha,
v: 1, platform: value.platform, ...(value.target !== undefined && value.target !== value.platform ? { target: value.target } : {}),
...(value.label !== undefined ? { label: value.label } : {}), ...(value.order !== undefined ? { order: value.order } : {}), runId: value.runId, runAttempt: value.runAttempt, headSha: value.headSha, baseSha: value.baseSha,
startedAt: value.startedAt, updatedAt: value.updatedAt, phase: value.phase,
links: { run: value.links.run, artifacts: value.links.artifacts, config: value.links.config,
...(value.links.report ? { report: value.links.report } : {}), ...(value.links.download ? { download: value.links.download } : {}),
@@ -166,6 +242,7 @@ export function parsePlatformRecord(value: unknown): PlatformRecord | undefined
&& isString(entry.message) && isString(entry.nextAction)
? [{ ...(isSide(entry.side) ? { side: entry.side } : {}), route: entry.route, code: entry.code, message: entry.message, nextAction: entry.nextAction }] : []).slice(0, 20);
}
if (isCount(value.notCompared) && value.notCompared > 0) record.notCompared = value.notCompared;
if (isCount(value.diagnosticCount)) record.diagnosticCount = value.diagnosticCount;
if (isRecord(value.failure) && isString(value.failure.step, 200) && isString(value.failure.message)) record.failure = { step: value.failure.step, message: value.failure.message };
if (value.superseded === true) record.superseded = true;
@@ -179,12 +256,12 @@ export function parseHistory(value: unknown): HistoryEntry[] {
if (!isRecord(entry) || !isString(entry.headSha) || !SHA.test(entry.headSha) || !isString(entry.baseSha) || !SHA.test(entry.baseSha)
|| !isString(entry.runId, 200) || !SAFE_ID.test(entry.runId) || !isTime(entry.startedAt) || !isRecord(entry.platforms)) continue;
const platforms: HistoryEntry["platforms"] = {};
for (const platform of ["ios", "android"] as const) {
const item = entry.platforms[platform];
for (const target of Object.keys(entry.platforms).filter(isTargetId).slice(0, MAX_COMMENT_TARGETS)) {
const item = entry.platforms[target];
if (!isRecord(item) || !isPhase(item.phase) || !isString(item.summary, 400) || !isUrl(item.run)
|| !optional(item.report, isUrl) || !optional(item.download, isUrl)) continue;
platforms[platform] = { phase: item.phase, summary: item.summary, run: item.run, ...(item.report ? { report: item.report } : {}), ...(item.download ? { download: item.download } : {}),
...(item.superseded === true ? { superseded: true } : {}) };
|| !optional(item.report, isUrl) || !optional(item.download, isUrl) || !optional(item.label, isLabel) || !optional(item.order, isOrder)) continue;
platforms[target] = { phase: item.phase, summary: item.summary, run: item.run, ...(item.report ? { report: item.report } : {}), ...(item.download ? { download: item.download } : {}),
...(item.superseded === true ? { superseded: true } : {}), ...(item.label !== undefined ? { label: item.label } : {}), ...(item.order !== undefined ? { order: item.order } : {}) };
}
if (Object.keys(platforms).length) entries.push({ headSha: entry.headSha, baseSha: entry.baseSha, runId: entry.runId, startedAt: entry.startedAt, platforms });
if (entries.length === HISTORY_LIMIT) break;
@@ -198,7 +275,9 @@ export function readCommentRecords(body: string | undefined): CommentRecords {
if (!body) return records;
for (const match of body.matchAll(RECORD_LINE)) {
const record = parsePlatformRecord(decodePayload(match[2]!));
if (record && record.platform === match[1]) records.current[record.platform] = record;
const target = record && recordTarget(record);
if (!record || target !== match[1] || !isTargetId(target)) continue;
if (records.current[target] || Object.keys(records.current).length < MAX_COMMENT_TARGETS) records.current[target] = record;
}
const history = body.match(HISTORY_LINE);
if (history) records.history = parseHistory(decodePayload(history[1]!));
@@ -207,13 +286,12 @@ export function readCommentRecords(body: string | undefined): CommentRecords {
/** A short result for a run that is no longer current: "🟩 34 changes", "🟨 12 changes · 4 unavailable", "🟥 failed · capture". */
export function recordSummary(record: PlatformRecord): string {
const changes = record.changes?.length;
switch (record.phase) {
case "failed": return `🟥 failed · ${record.failure?.step ?? "capture"}`;
case "ready": {
const unavailable = record.health ? record.health.base.unavailable + record.health.head.unavailable : 0;
const icon = unavailable > 0 || (record.validation?.visual?.failed ?? 0) > 0 ? "🟨" : "🟩";
return `${icon} ${changes ?? 0} change${changes === 1 ? "" : "s"}${unavailable > 0 ? ` · ${unavailable} unavailable` : ""}`;
const icon = unavailable > 0 || (record.validation?.visual?.failed ?? 0) > 0 || record.notCompared ? "🟨" : "🟩";
return `${icon} ${changeCountText(record.changes?.map(change => change.group) ?? [])}${unavailable > 0 ? ` · ${unavailable} unavailable` : ""}${record.notCompared ? ` · ${record.notCompared} not compared` : ""}`;
}
default: return "⏳ did not finish";
}
@@ -224,9 +302,10 @@ function historyEntryOf(records: PlatformRecord[]): HistoryEntry | undefined {
if (!first) return undefined;
const entry: HistoryEntry = { headSha: first.headSha, baseSha: first.baseSha, runId: first.runId, startedAt: Math.min(...records.map(record => record.startedAt)), platforms: {} };
for (const record of records) {
entry.platforms[record.platform] = { phase: record.phase, summary: recordSummary(record), run: record.links.run,
entry.platforms[recordTarget(record)] = { phase: record.phase, summary: recordSummary(record), run: record.links.run,
...(record.links.report ? { report: record.links.report } : {}), ...(record.links.download ? { download: record.links.download } : {}),
...(record.superseded ? { superseded: true } : {}) };
...(record.superseded ? { superseded: true } : {}), ...(record.label !== undefined ? { label: record.label } : {}),
...(record.order !== undefined ? { order: record.order } : {}) };
}
return entry;
}
@@ -236,27 +315,42 @@ const runOrder = (runId: string): number => Number.parseInt(runId, 10) || 0;
function pushHistory(history: HistoryEntry[], entry: HistoryEntry | undefined): HistoryEntry[] {
if (!entry) return history;
const merged = [entry, ...history.filter(item => item.runId !== entry.runId)];
// One entry per run: a platform that reaches history later joins the entry its sibling made.
// One entry per run: a target that reaches history later joins the entry its sibling made.
const existing = history.find(item => item.runId === entry.runId);
if (existing) merged[0] = { ...existing, platforms: { ...existing.platforms, ...entry.platforms } };
return merged.sort((a, b) => runOrder(b.runId) - runOrder(a.runId) || b.startedAt - a.startedAt).slice(0, HISTORY_LIMIT);
}
/**
* Fold one writer's record into the comment's records. The same run replaces its own platform; a newer run
* Fold one writer's record into the comment's records. The same run replaces its own target; a newer run
* moves the previous run into history; a run that finds a newer run already current (the PR moved while it
* worked) is superseded and only adds itself to history, so its report stays linked without displacing the
* current review.
*/
export function foldRecord(existing: CommentRecords, record: PlatformRecord): CommentRecords {
const current = Object.values(existing.current).filter((item): item is PlatformRecord => Boolean(item));
export function foldRecord(existing: CommentRecords, incoming: PlatformRecord): CommentRecords {
const current = orderedRecords(existing);
const record = withKnownTarget(incoming, existing);
const target = recordTarget(record);
const currentRun = current[0];
if (!currentRun && record.superseded) return { current: {}, history: pushHistory(existing.history, historyEntryOf([record])) };
if (!currentRun || currentRun.runId === record.runId) {
return { current: { ...existing.current, [record.platform]: record }, history: existing.history };
return { current: { ...existing.current, [target]: record }, history: existing.history };
}
if (runOrder(currentRun.runId) > runOrder(record.runId) || record.superseded) {
return { current: existing.current, history: pushHistory(existing.history, historyEntryOf([{ ...record, superseded: true }])) };
}
return { current: { [record.platform]: record }, history: pushHistory(existing.history, historyEntryOf(current)) };
return { current: { [target]: record }, history: pushHistory(existing.history, historyEntryOf(current)) };
}
/**
* The failure job knows a target only by the id in an artifact name: its record takes the label, order and platform
* the comment already holds for that id (from the capture job's progress record, or the newest run that had it).
*/
function withKnownTarget(record: PlatformRecord, existing: CommentRecords): PlatformRecord {
const target = recordTarget(record);
if (!record.target || record.label !== undefined || record.order !== undefined) return record;
const known = existing.current[target];
if (known) return { ...record, platform: known.platform, ...(known.label !== undefined ? { label: known.label } : {}), ...(known.order !== undefined ? { order: known.order } : {}) };
const item = existing.history.find(entry => entry.platforms[target])?.platforms[target];
return item ? { ...record, ...(item.label !== undefined ? { label: item.label } : {}), ...(item.order !== undefined ? { order: item.order } : {}) } : record;
}
+143 -70
View File
@@ -8,7 +8,9 @@ import { MAX_METADATA_BYTES } from "./agent-api.js";
import { publishCiReportComment, readCiReportInput, type CiReportInput } from "./artifact.js";
import { readZipDirectory, readZipEntry } from "./zip-reader.js";
import { reviewChangeCount, reviewDevice } from "./pr-comment-body.js";
import type { ExplorePlatform } from "../config/explore-config.js";
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
import type { RunTarget } from "../types.js";
import { targetParameter } from "./viewer-links.js";
import type { ArtifactReport } from "../contracts/artifact-report.js";
import { normalizePublicReviewForReading } from "../contracts/review-validation.js";
import { EXPLORATION_REPORT_KIND, type ExplorationReport } from "../contracts/standalone-report.js";
@@ -31,6 +33,11 @@ export type CommandRunner = (command: string, args: readonly string[], options:
export type PreviewReportInput = {
/** Set by the matrix workflows; the preview then serves this report at report.zip?platform=<platform>. */
platform?: ExplorePlatform;
/**
* The capture target, set by the matrix workflows (wins over `platform`): the preview serves the report as
* `<target id>.zip.enc` at report.zip?target=<id> (?platform=<id> for a target named after its platform).
*/
target?: RunTarget;
inputPath: string;
/** The `ci:report` output directory: review.json and assets/. */
reportPath: string;
@@ -67,7 +74,7 @@ export type PreviewDeployResult = {
/** The first (or only) report's archive, as before; `reports` lists every platform's. */
reportSha256: string;
reportBytes: number;
reports: Array<{ platform?: ExplorePlatform; artifactUrl: string; reportSha256: string; reportBytes: number }>;
reports: Array<{ platform?: ExplorePlatform; target?: RunTarget; artifactUrl: string; reportSha256: string; reportBytes: number }>;
headSha: string;
/** A comparison's link is in the run summary only: callers must not print previewUrl, which is unmasked for it. */
linkedFromRunSummary?: true;
@@ -79,6 +86,33 @@ const BASE32 = "abcdefghijklmnopqrstuvwxyz234567";
/** The largest report ZIP a hosted preview serves. */
export const MAX_REPORT_BYTES = 256 * 1024 * 1024;
const ZIP_DATE = new Date("2000-01-01T00:00:00Z");
const PLATFORM_LABELS: Record<ExplorePlatform, string> = { ios: "iOS", android: "Android" };
/** The target of a report from before targets, or of a config without them: its platform, under the platform's name. */
export function platformTarget(platform: ExplorePlatform): RunTarget {
return { id: platform, platform, label: PLATFORM_LABELS[platform] };
}
/** The report.zip query that selects a target (see targetParameter): `?platform=ios` for configs without targets, as before. */
function targetQuery(target: RunTarget): string {
const [key, value] = targetParameter(target.id);
return `?${key}=${value}`;
}
/** A target as untrusted JSON names it (a report's review.runtime.target): its id, platform and a plain label, or undefined. */
function readTarget(value: unknown): RunTarget | undefined {
if (typeof value !== "object" || value === null) return undefined;
const { id, platform, label } = value as Record<string, unknown>;
if (!isTargetId(id) || (platform !== "ios" && platform !== "android")) return undefined;
const shown = typeof label === "string" ? listingLabel(label) : "";
return { id, platform, label: shown || PLATFORM_LABELS[platform] };
}
function assertTargets(targets: RunTarget[], message: string, nextAction: string): void {
// At most 8, as a config names: the Worker refuses a longer listing.
if (!targets.length || targets.length > 8 || targets.some(target => !isTargetId(target.id) || (target.platform !== "ios" && target.platform !== "android"))
|| new Set(targets.map(target => target.id)).size !== targets.length) throw previewError("PREVIEW_REPORTS_INVALID", message, nextAction);
}
function base32(bytes: Uint8Array): string {
let bits = 0; let value = 0; let out = "";
@@ -163,8 +197,11 @@ export async function zipReportDirectory(reportPath: string): Promise<Uint8Array
return writer.close();
}
/** What a report ZIP holds, from its review.json or exploration.json: where to host it and how the platform switch labels it. */
export type ReportZipSummary = { platform: ExplorePlatform; changes?: number; device?: string }
/**
* What a report ZIP holds, from its review.json or exploration.json: where to host it and how the target switch labels it.
* `target` is review.runtime.target, or for reports from before targets (and explorations) the platform's own target.
*/
export type ReportZipSummary = { platform: ExplorePlatform; target: RunTarget; changes?: number; device?: string }
& ({ kind: "review"; repository: string; runId: string; base: string; head: string } | { kind: "exploration" });
/**
@@ -189,7 +226,7 @@ export async function readReportZip(zip: Uint8Array): Promise<ReportZipSummary>
if (report?.kind !== EXPLORATION_REPORT_KIND || !exploration || (exploration.app?.platform !== "ios" && exploration.app?.platform !== "android")) {
throw new Error("exploration.json is not an Explore exploration report");
}
return { kind: "exploration", platform: exploration.app.platform, device: `${exploration.device.model} ${exploration.device.osVersion}`.trim() };
return { kind: "exploration", platform: exploration.app.platform, target: platformTarget(exploration.app.platform), device: `${exploration.device.model} ${exploration.device.osVersion}`.trim() };
}
const review = (report as Partial<ArtifactReport>).review;
const pr = review?.pullRequest;
@@ -207,7 +244,10 @@ export async function readReportZip(zip: Uint8Array): Promise<ReportZipSummary>
const changes = reviewChangeCount({ review: normalizePublicReviewForReading(review) });
const device = reviewDevice({ runtime: { deviceModel: review.runtime?.device?.model ?? "", osVersion: review.runtime?.device?.osVersion ?? "",
...(review.runtime?.colorSchemes ? { colorSchemes: review.runtime.colorSchemes } : {}) } });
return { kind: "review", platform, repository: pr.repository, runId: review.runId, base: pr.base.sha, head: pr.head.sha,
// A target whose platform is not the report's own is not this report's target.
const named = readTarget(review.runtime?.target);
const target = named?.platform === platform ? named : platformTarget(platform);
return { kind: "review", platform, target, repository: pr.repository, runId: review.runId, base: pr.base.sha, head: pr.head.sha,
...(changes === undefined ? {} : { changes }), ...(device ? { device } : {}) };
}
@@ -232,11 +272,10 @@ async function assertExport(exportPath: string): Promise<void> {
}
}
type SealedReport = { entry: PreviewReportInput; input: CiReportInput; zip: Uint8Array; sha256: string; file: string };
type SealedReport = { entry: PreviewReportInput; input: CiReportInput; target?: RunTarget; zip: Uint8Array; sha256: string; file: string };
function previewError(code: string, message: string, nextAction: string): CiError { return new CiError({ code, stage: "preflight", message, nextAction }); }
/** A device label for the platform switch, safe in the sealed .env: no `#` (a dotenv comment), markup or control characters, and short. */
/**
* A device label for the platform switch, safe in the sealed .env: letters, digits and a few separators only. `eas
* deploy` reads that file with variable expansion, so a `$` (even single-quoted) would pull the deploying process's
@@ -245,15 +284,21 @@ function previewError(code: string, message: string, nextAction: string): CiErro
function listingDevice(device: string): string {
return device.replace(/[^\p{L}\p{N} .,()+·_:/-]/gu, "").replace(/\s+/g, " ").trim().slice(0, 120);
}
/** A target's label for the switch, as safe as a device label and shorter. */
function listingLabel(label: string): string {
return listingDevice(label).slice(0, 80).trim();
}
/** The worker's EXPLORE_PREVIEW_REPORTS entries, in the order the workflow lists platforms; also what reports.json must echo. */
export function previewReportListing(reports: ReadonlyArray<Pick<SealedReport, "entry" | "input" | "file">>, reportDirectory: string) {
return reports.map(report => {
const changes = reviewChangeCount(report.input.commentState);
const device = listingDevice(reviewDevice(report.input.commentState));
return { platform: report.entry.platform!, path: `/_report/${reportDirectory}/${report.file}`,
...(changes === undefined ? {} : { changes }), ...(device ? { device } : {}) };
});
/** One EXPLORE_PREVIEW_REPORTS entry, keys in the order the Worker echoes them in reports.json. */
export type PreviewListingEntry = { target: string; platform: ExplorePlatform; label?: string; path: string; changes?: number; device?: string };
function listingEntry(target: RunTarget, path: string, changes?: number, device?: string): PreviewListingEntry {
const label = listingLabel(target.label), shown = device ? listingDevice(device) : "";
return { target: target.id, platform: target.platform, ...(label ? { label } : {}), path, ...(changes === undefined ? {} : { changes }), ...(shown ? { device: shown } : {}) };
}
/** The worker's EXPLORE_PREVIEW_REPORTS entries, in the order the workflow lists targets; also what reports.json must echo. */
export function previewReportListing(reports: ReadonlyArray<Pick<SealedReport, "input" | "file"> & { target: RunTarget }>, reportDirectory: string): PreviewListingEntry[] {
return reports.map(report => listingEntry(report.target, `/_report/${reportDirectory}/${report.file}`, reviewChangeCount(report.input.commentState), reviewDevice(report.input.commentState)));
}
export async function deployPreview(options: PreviewDeployOptions): Promise<PreviewDeployResult> {
@@ -263,12 +308,19 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
: [{ inputPath: options.inputPath, reportPath: options.reportPath, artifactUrl: options.artifactUrl }];
if (!entries.length) throw previewError("PREVIEW_REPORTS_MISSING", "There is no platform report to deploy",
"Pass --inputs and --reports directories holding one explore-capture and one explore-review artifact per platform.");
const multi = entries.some(entry => entry.platform !== undefined);
if (multi && (entries.some(entry => !entry.platform) || new Set(entries.map(entry => entry.platform)).size !== entries.length)) {
throw previewError("PREVIEW_REPORTS_INVALID", "Each report of a multi-platform preview must name a distinct platform", "Deploy one report per platform of the same run.");
const multi = entries.some(entry => entry.platform !== undefined || entry.target !== undefined);
if (multi) {
if (entries.some(entry => !entry.platform && !entry.target)) throw previewError("PREVIEW_REPORTS_INVALID", "Each report of a multi-target preview must name its target", "Deploy one report per target of the same run.");
assertTargets(entries.map(entry => entry.target ?? platformTarget(entry.platform!)), "Each report of a multi-target preview must name a distinct target", "Deploy one report per target of the same run.");
}
const inputs: Array<{ entry: PreviewReportInput; input: CiReportInput; target?: RunTarget }> = [];
for (const entry of entries) {
const input = await readCiReportInput(entry.inputPath);
// A platform-named entry takes the report's own label when the report names that target.
const named = readTarget(input.publicReview.runtime.target);
const target = entry.target ?? (entry.platform ? (named?.id === entry.platform ? named : platformTarget(entry.platform)) : undefined);
inputs.push({ entry, input, ...(target ? { target } : {}) });
}
const inputs: Array<{ entry: PreviewReportInput; input: CiReportInput }> = [];
for (const entry of entries) inputs.push({ entry, input: await readCiReportInput(entry.inputPath) });
const first = inputs[0]!.input; const review = first.publicReview; const pr = review.pullRequest;
if (!first.preview) throw new CiError({ code: "PREVIEW_NOT_CONFIGURED", stage: "preflight",
message: "This review did not request a hosted preview", nextAction: "Set report.preview.hosting: eas in .expo-explore/config.yaml, or remove the deploy job." });
@@ -281,29 +333,29 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
const other = input.publicReview;
if (!input.preview || other.pullRequest.origin !== pr.origin || other.pullRequest.repository !== pr.repository || other.pullRequest.number !== pr.number
|| other.pullRequest.head.sha !== pr.head.sha || other.pullRequest.base.sha !== pr.base.sha || other.runId !== review.runId || other.runAttempt !== review.runAttempt) {
throw previewError("PREVIEW_REPORTS_MISMATCH", "The platform reports do not come from the same review run", "Deploy only the reports this workflow run produced for the same PR head.");
throw previewError("PREVIEW_REPORTS_MISMATCH", "The target reports do not come from the same review run", "Deploy only the reports this workflow run produced for the same PR head.");
}
}
const exportPath = resolve(options.exportPath ?? PREVIEW_EXPORT_PATH);
await assertExport(exportPath);
const reports: SealedReport[] = [];
for (const { entry, input } of inputs) {
for (const { entry, input, target } of inputs) {
let zip: Uint8Array;
try { zip = await zipReportDirectory(entry.reportPath); }
catch (error) { throw toCiError(error, { code: "REPORT_ZIP_FAILED", stage: "export",
nextAction: "Pass the ci:report output directory downloaded from this run's explore-review artifact." }); }
reports.push({ entry, input, zip, sha256: createHash("sha256").update(zip).digest("hex"), file: multi ? `${entry.platform}.zip.enc` : "report.zip.enc" });
reports.push({ entry, input, ...(target ? { target } : {}), zip, sha256: createHash("sha256").update(zip).digest("hex"), file: multi && target ? `${target.id}.zip.enc` : "report.zip.enc" });
}
const reportDirectory = base32(random(10));
const expiresAt = first.preview.expiresAfterDays === null ? null : now() + first.preview.expiresAfterDays * 86_400_000;
const project = previewProjectSlug(pr.repository, first.preview.project);
const listing = multi ? previewReportListing(reports, reportDirectory) : undefined;
const listing = multi ? previewReportListing(reports.map(report => ({ ...report, target: report.target! })), reportDirectory) : undefined;
let hosted: Awaited<ReturnType<typeof deploySealedReports>>;
try {
hosted = await deploySealedReports({
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: multi ? `?platform=${report.entry.platform}` : "" })),
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: multi && report.target ? targetQuery(report.target) : "" })),
reportDirectory, ...(listing ? { listing } : {}), project, ...(first.preview.owner ? { owner: first.preview.owner } : {}),
ownerHint: "Set report.preview.owner in .expo-explore/config.yaml to the account that should hold the preview project.",
projectHint: "Give EXPO_TOKEN's account permission to create projects, or set report.preview.project to an existing project it can deploy to.",
@@ -317,7 +369,7 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
if (pr.origin !== "compare") for (const report of reports) {
try {
await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
...(report.entry.platform ? { platform: report.entry.platform } : {}), previewFailed: true });
...commentTarget(report), previewFailed: true });
} catch { /* the deployment failure is the one to report */ }
}
throw error;
@@ -329,23 +381,30 @@ export async function deployPreview(options: PreviewDeployOptions): Promise<Prev
let headSha = pr.head.sha;
if (pr.origin !== "compare") for (const report of reports) {
const published = await publishCiReportComment({ inputPath: report.entry.inputPath, artifactUrl: report.entry.artifactUrl, environment, transport,
...(report.entry.platform ? { platform: report.entry.platform } : {}), preview: { url: previewUrl, expiresAt } });
...commentTarget(report), preview: { url: previewUrl, expiresAt } });
headSha = published.headSha;
}
return { previewUrl, expiresAt: expiresAt === null ? null : new Date(expiresAt).toISOString(), deploymentId: hosted.deploymentId, deploymentUrl: hosted.deploymentUrl,
project, owner: hosted.owner, reportSha256: reports[0]!.sha256, reportBytes: reports[0]!.zip.byteLength,
reports: reports.map(report => ({ ...(report.entry.platform ? { platform: report.entry.platform } : {}), artifactUrl: report.entry.artifactUrl,
reports: reports.map(report => ({ ...(report.entry.platform ? { platform: report.entry.platform } : {}), ...(report.target ? { target: report.target } : {}), artifactUrl: report.entry.artifactUrl,
reportSha256: report.sha256, reportBytes: report.zip.byteLength })), headSha,
...(pr.origin === "compare" ? { linkedFromRunSummary: true as const } : {}) };
}
}
/** The comparison's job summary: what was compared, the hosted link, and each platform's change count. */
/** Which comment section and artifact a report is: its target, or (single-report runs) none. */
function commentTarget(report: SealedReport): { target?: string; platform?: ExplorePlatform } {
if (report.target) return { target: report.target.id, platform: report.target.platform };
return report.entry.platform ? { platform: report.entry.platform } : {};
}
/** The comparison's job summary: what was compared, the hosted link, and each target's change count. */
export function renderCompareSummary(comparison: CompareReviewPresentation, previewUrl: string, expiresAt: number | null, inputs: CiReportInput[]): string {
const platforms = inputs.map(input => {
const changes = reviewChangeCount(input.commentState);
const device = reviewDevice(input.commentState);
return `- ${input.publicReview.runtime.platform === "android" ? "Android" : "iOS"}${device ? ` (${device})` : ""}: ${changes === undefined ? "no review" : `${changes} ${changes === 1 ? "change" : "changes"}`}`;
const label = readTarget(input.publicReview.runtime.target)?.label ?? (input.publicReview.runtime.platform === "android" ? "Android" : "iOS");
return `- ${label}${device ? ` (${device})` : ""}: ${changes === undefined ? "no review" : `${changes} ${changes === 1 ? "change" : "changes"}`}`;
});
return [`### Explore: ${compareTitleMarkdown(comparison)}`, "",
`[Open the report](${previewUrl}) · [${comparison.base.sha.slice(0, 8)}..${comparison.head.sha.slice(0, 8)}](${comparison.url})`
@@ -528,9 +587,10 @@ export async function deployExplorationReport(options: ExplorationDeployOptions)
const now = options.now ?? Date.now;
const sha256 = createHash("sha256").update(zip).digest("hex");
const reportDirectory = base32(random(10));
const file = options.platform ? `${options.platform}.zip.enc` : "report.zip.enc";
const hosted = await deploySealedReports({ reports: [{ zip, sha256, file, query: options.platform ? `?platform=${options.platform}` : "" }], reportDirectory,
...(options.platform ? { listing: [{ platform: options.platform, path: `/_report/${reportDirectory}/${file}` }] } : {}), project: options.project,
const target = options.platform ? platformTarget(options.platform) : undefined;
const file = target ? `${target.id}.zip.enc` : "report.zip.enc";
const hosted = await deploySealedReports({ reports: [{ zip, sha256, file, query: target ? targetQuery(target) : "" }], reportDirectory,
...(target ? { listing: [listingEntry(target, `/_report/${reportDirectory}/${file}`)] } : {}), project: options.project,
...(options.owner ? { owner: options.owner } : {}), ownerHint: "Pass --owner with the Expo account that should host the report.",
projectHint: "Give this EAS login permission to create projects under the owner, or pass --project with an existing slug.",
expiresAt: options.expiresAfterDays === null ? null : now() + options.expiresAfterDays * 86_400_000, exportPath, environment, run: options.run ?? defaultRun, ...(options.sleep ? { sleep: options.sleep } : {}),
@@ -540,8 +600,8 @@ export async function deployExplorationReport(options: ExplorationDeployOptions)
}
export type FixturePreviewOptions = {
/** Report ZIPs as a hosted preview serves them from report.zip, one per platform, with what the platform switch says of each. */
reports: Array<{ platform: ExplorePlatform; zipPath: string; changes?: number; device?: string }>;
/** Report ZIPs as a hosted preview serves them from report.zip, one per target (`platform` alone: the platform's target), with what the switch says of each. */
reports: Array<{ platform: ExplorePlatform; target?: RunTarget; zipPath: string; changes?: number; device?: string }>;
project: string;
owner?: string;
alias: string;
@@ -568,21 +628,19 @@ export async function deployFixturePreview(options: FixturePreviewOptions): Prom
message: "An EAS login is required to deploy the Viewer preview", nextAction: "Run `eas login` or set EXPO_TOKEN." });
if (!HOSTING_ALIAS.test(options.alias)) throw previewError("PREVIEW_ALIAS_INVALID", `Invalid EAS Hosting alias: ${options.alias}`, "Pass --alias as a lowercase slug such as pr-123.");
if (options.token !== undefined && !HOSTED_TOKEN.test(options.token)) throw previewError("PREVIEW_TOKEN_INVALID", "The preview token must be 32 characters of a-z and 2-7.", "Pass the /p/<token> segment of the previous preview link, or none for a new one.");
if (!options.reports.length || new Set(options.reports.map(report => report.platform)).size !== options.reports.length) {
throw previewError("PREVIEW_REPORTS_INVALID", "A fixture preview needs one report per platform", "Pass each platform's report ZIP once.");
}
assertTargets(options.reports.map(report => report.target ?? platformTarget(report.platform)), "A fixture preview needs one report per target", "Pass each target's report ZIP once.");
const exportPath = resolve(options.exportPath ?? PREVIEW_EXPORT_PATH);
await assertExport(exportPath);
const random = options.random ?? (bytes => new Uint8Array(randomBytes(bytes)));
const reportDirectory = base32(random(10));
const reports = await Promise.all(options.reports.map(async report => {
const zip = new Uint8Array(await readFile(report.zipPath));
return { ...report, zip, sha256: createHash("sha256").update(zip).digest("hex"), file: `${report.platform}.zip.enc` };
const target = report.target ?? platformTarget(report.platform);
return { ...report, target, zip, sha256: createHash("sha256").update(zip).digest("hex"), file: `${target.id}.zip.enc` };
}));
const listing = reports.map(report => ({ platform: report.platform, path: `/_report/${reportDirectory}/${report.file}`,
...(report.changes === undefined ? {} : { changes: report.changes }), ...(report.device ? { device: report.device } : {}) }));
const listing = reports.map(report => listingEntry(report.target, `/_report/${reportDirectory}/${report.file}`, report.changes, report.device));
return deploySealedReports({
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: `?platform=${report.platform}` })),
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: targetQuery(report.target) })),
reportDirectory, listing, project: options.project, ...(options.owner ? { owner: options.owner } : {}),
ownerHint: "Pass --owner with the Expo account that holds the preview project.",
projectHint: "Give EXPO_TOKEN's account permission to create projects, or pass --project with an existing slug.",
@@ -592,11 +650,12 @@ export async function deployFixturePreview(options: FixturePreviewOptions): Prom
}
/**
* Report ZIPs on this machine behind one token (`capture:review --upload`, `report:upload`), one per platform: the same
* Report ZIPs on this machine behind one token (`capture:review --upload`, `report:upload`), one per target: the same
* sealed deployment as a PR preview, from ZIPs instead of GitHub artifacts, with the local EAS login or EXPO_TOKEN.
*/
export async function deployLocalReports(options: {
reports: Array<{ platform: ExplorePlatform; zip: Uint8Array; changes?: number; device?: string }>;
/** One per target; an entry without `target` is its platform's target, as before targets. */
reports: Array<{ platform: ExplorePlatform; target?: RunTarget; zip: Uint8Array; changes?: number; device?: string }>;
project: string; owner?: string; expiresAfterDays: number | null;
/** What to change when the owner or project is not usable; defaults name report.preview in config.yaml. */
ownerHint?: string; projectHint?: string;
@@ -604,22 +663,20 @@ export async function deployLocalReports(options: {
transport?: typeof fetch; now?: () => number; random?: (bytes: number) => Uint8Array; verifyTimeoutMs?: number;
}): Promise<HostedDeployment> {
const environment = options.environment ?? process.env;
if (!options.reports.length || new Set(options.reports.map(report => report.platform)).size !== options.reports.length) {
throw previewError("PREVIEW_REPORTS_INVALID", "A local upload needs one report per platform", "Capture each platform once, then upload.");
}
assertTargets(options.reports.map(report => report.target ?? platformTarget(report.platform)), "A local upload needs one report per target", "Capture each target once, then upload.");
const exportPath = resolve(options.exportPath ?? PREVIEW_EXPORT_PATH);
await assertExport(exportPath);
const now = options.now ?? Date.now;
const random = options.random ?? (bytes => new Uint8Array(randomBytes(bytes)));
const reportDirectory = base32(random(10));
// Always listed, even alone: the Worker takes an unlisted report for iOS, so an Android one would be mislabelled.
const reports = options.reports.map(report => ({ ...report, sha256: createHash("sha256").update(report.zip).digest("hex"), file: `${report.platform}.zip.enc` }));
const listing = reports.map(report => {
const device = report.device ? listingDevice(report.device) : "";
return { platform: report.platform, path: `/_report/${reportDirectory}/${report.file}`, ...(report.changes === undefined ? {} : { changes: report.changes }), ...(device ? { device } : {}) };
const reports = options.reports.map(report => {
const target = report.target ?? platformTarget(report.platform);
return { ...report, target, sha256: createHash("sha256").update(report.zip).digest("hex"), file: `${target.id}.zip.enc` };
});
const listing = reports.map(report => listingEntry(report.target, `/_report/${reportDirectory}/${report.file}`, report.changes, report.device));
return deploySealedReports({
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: `?platform=${report.platform}` })),
reports: reports.map(report => ({ zip: report.zip, sha256: report.sha256, file: report.file, query: targetQuery(report.target) })),
reportDirectory, listing, project: options.project, ...(options.owner ? { owner: options.owner } : {}),
ownerHint: options.ownerHint ?? "Set report.preview.owner in .expo-explore/config.yaml to the account that should hold the hosted reports.",
projectHint: options.projectHint ?? "Make sure your Expo account can create projects, or set report.preview.project to an existing project you can deploy to.",
@@ -628,36 +685,52 @@ export async function deployLocalReports(options: {
verifyTimeoutMs: options.verifyTimeoutMs ?? 180_000 });
}
const ARTIFACT_DIRECTORY = /^explore-(capture|review)-\d+-\d+-(ios|android)$/;
/** explore-(capture|review)-<run>-<attempt>-<target id>; the id starts with a letter, so the run and attempt end unambiguously. */
const ARTIFACT_DIRECTORY = /^explore-(capture|review)-\d+-\d+-([a-z][a-z0-9-]{0,31})$/;
/**
* The fan-in deploy job's inputs: actions/download-artifact puts each explore-capture-<run>-<attempt>-<platform>
* directory under --inputs and each explore-review-… directory under --reports. Pairs them by platform and
* looks up each report artifact's URL on the run, since matrix jobs cannot hand their artifact URLs forward.
* The fan-in deploy job's inputs: actions/download-artifact puts each explore-capture-<run>-<attempt>-<target>
* directory under --inputs and each explore-review-… directory under --reports (the target is the platform for
* configs without targets). Pairs them by target, in the order the run's review lists its targets, and looks up each
* report artifact's URL on the run, since matrix jobs cannot hand their artifact URLs forward.
*/
export async function collectPlatformReports(options: { inputsPath: string; reportsPath: string; environment?: NodeJS.ProcessEnv; transport?: typeof fetch }): Promise<PreviewReportInput[]> {
const environment = options.environment ?? process.env; const transport = options.transport ?? fetch;
const directories = async (root: string, kind: "capture" | "review") => {
const found = new Map<ExplorePlatform, string>();
const found = new Map<string, string>();
for (const name of (await readdir(root)).sort()) {
const match = ARTIFACT_DIRECTORY.exec(name);
if (!match || match[1] !== kind) continue;
if (found.has(match[2] as ExplorePlatform)) throw previewError("PREVIEW_REPORTS_INVALID", `Several ${kind} artifacts for ${match[2]} were downloaded`,
if (!match || match[1] !== kind || !isTargetId(match[2])) continue;
if (found.has(match[2]!)) throw previewError("PREVIEW_REPORTS_INVALID", `Several ${kind} artifacts for ${match[2]} were downloaded`,
"Download only this run attempt's artifacts into the --inputs and --reports directories.");
found.set(match[2] as ExplorePlatform, join(root, name));
found.set(match[2]!, join(root, name));
}
return found;
};
const inputs = await directories(options.inputsPath, "capture"); const reports = await directories(options.reportsPath, "review");
if (!inputs.size) throw previewError("PREVIEW_REPORTS_MISSING", "No explore-capture-<run>-<attempt>-<platform> artifact was downloaded",
if (!inputs.size) throw previewError("PREVIEW_REPORTS_MISSING", "No explore-capture-<run>-<attempt>-<target> artifact was downloaded",
"Download this run's explore-capture artifacts into the --inputs directory before ci:deploy.");
if (inputs.size > 8) throw previewError("PREVIEW_REPORTS_INVALID", `${inputs.size} capture artifacts were downloaded; a run has at most 8 targets`,
"Download only this run attempt's artifacts into the --inputs and --reports directories.");
const entries: PreviewReportInput[] = [];
for (const [platform, inputDirectory] of inputs) {
const reportPath = reports.get(platform);
if (!reportPath) throw previewError("PREVIEW_REPORTS_INCOMPLETE", `The ${platform} capture has no report artifact to deploy`,
"Rerun the workflow; the report job for that platform did not upload its explore-review artifact.");
entries.push({ platform, inputPath: join(inputDirectory, "report-input.json"), reportPath, artifactUrl: "" });
for (const [id, inputDirectory] of inputs) {
const reportPath = reports.get(id);
if (!reportPath) throw previewError("PREVIEW_REPORTS_INCOMPLETE", `The ${id} capture has no report artifact to deploy`,
"Rerun the workflow; the report job for that target did not upload its explore-review artifact.");
const inputPath = join(inputDirectory, "report-input.json");
const runtime = (await readCiReportInput(inputPath)).publicReview.runtime;
// A report from before targets names only its platform, and its artifact is named after it.
const named = readTarget(runtime.target);
if (named && named.id !== id) throw previewError("PREVIEW_REPORTS_INVALID", `The ${id} capture artifact holds the report of ${named.id}`,
"Download only this run attempt's artifacts, as the capture jobs named them.");
const target = named ?? (id === "ios" || id === "android" ? platformTarget(id) : { id, platform: runtime.platform ?? "ios", label: id });
entries.push({ ...(id === target.platform ? { platform: target.platform } : {}), target, inputPath, reportPath, artifactUrl: "" });
}
// Config order, as the review lists its targets (or, before targets, its platforms); directory order otherwise.
const listed = (await readCiReportInput(entries[0]!.inputPath)).publicReview.runtime;
const order: string[] = listed.targets?.map(target => target.id) ?? listed.platforms ?? [];
const rank = (entry: PreviewReportInput) => { const index = order.indexOf(entry.target!.id); return index === -1 ? order.length : index; };
entries.sort((a, b) => rank(a) - rank(b));
const review = (await readCiReportInput(entries[0]!.inputPath)).publicReview;
if (review.pullRequest.origin === "local") throw new Error("Local reports cannot be deployed as hosted previews");
const repository = review.pullRequest.repository;
@@ -665,7 +738,7 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
throw previewError("REPORT_INPUT_INVALID", "The report input does not name a GitHub run", "Use the report-input.json produced by this run's capture job.");
}
for (const entry of entries) {
const name = `explore-review-${review.runId}-${review.runAttempt}-${entry.platform}`;
const name = `explore-review-${review.runId}-${review.runAttempt}-${entry.target!.id}`;
const url = `https://api.github.com/repos/${repository}/actions/runs/${review.runId}/artifacts?per_page=100&name=${encodeURIComponent(name)}`;
const response = await transport(url, { headers: { accept: "application/vnd.github+json", authorization: `Bearer ${environment.GITHUB_TOKEN ?? ""}`,
"x-github-api-version": "2022-11-28" }, signal: AbortSignal.timeout(60_000) });
@@ -673,7 +746,7 @@ export async function collectPlatformReports(options: { inputsPath: string; repo
const artifact = body?.artifacts?.find(candidate => candidate.name === name && candidate.expired !== true);
if (!artifact || typeof artifact.id !== "number" || !Number.isSafeInteger(artifact.id) || artifact.id <= 0) {
throw deployError("REPORT_ARTIFACT_MISSING", `The run has no artifact named ${name} (HTTP ${response.status}).`,
"Rerun the workflow so every platform's report job uploads its artifact before the deploy job runs.", { retryable: true });
"Rerun the workflow so every target's report job uploads its artifact before the deploy job runs.", { retryable: true });
}
entry.artifactUrl = `https://github.com/${repository}/actions/runs/${review.runId}/artifacts/${artifact.id}`;
}
@@ -723,7 +796,7 @@ async function verifyDeployment(check: { origin: string; token: string; reports:
if (check.listing !== undefined) {
const list = await get(`/p/${check.token}/reports.json`);
const body = list.status === 200 ? await list.text() : "";
if (list.status !== 200 || body !== check.listing) throw deployError("PREVIEW_VERIFY_FAILED", "The hosted preview did not list the platforms that were deployed.",
if (list.status !== 200 || body !== check.listing) throw deployError("PREVIEW_VERIFY_FAILED", "The hosted preview did not list the targets that were deployed.",
"Rerun the deploy job; the deployment's report listing did not match.", { details: { status: list.status } });
}
const other = check.token.endsWith("a") ? `${check.token.slice(0, -1)}b` : `${check.token.slice(0, -1)}a`;
+40 -16
View File
@@ -1,18 +1,19 @@
import { createHash, randomBytes } from "node:crypto";
import { lstat, mkdir, readdir, readFile, rename, rm, writeFile } from "node:fs/promises";
import { join } from "node:path";
import type { ExplorePlatform } from "../config/explore-config.js";
import { isTargetId, type ExplorePlatform } from "../config/explore-config.js";
import type { RunTarget } from "../types.js";
import type { ArtifactReport } from "../contracts/artifact-report.js";
import { EXPLORATION_REPORT_KIND, type ExplorationReport } from "../contracts/standalone-report.js";
import { exploreCacheRoot } from "../shared/cache-root.js";
import { MAX_METADATA_BYTES } from "./agent-api.js";
import { normalizePublicReviewForReading } from "../contracts/review-validation.js";
import { reviewChanges, reviewDevice } from "./pr-comment-body.js";
import type { ChangeGroup } from "./pr-comment-record.js";
import { strongerGroup, type ChangeGroup } from "./pr-comment-record.js";
import { readZipDirectory, readZipEntry } from "./zip-reader.js";
/**
* Every report a run produces on this machine is kept under `<cache>/reports/<id>/`: one `<platform>.zip` per platform
* Every report a run produces on this machine is kept under `<cache>/reports/<id>/`: one `<target>.zip` per target
* (the same ZIP a hosted or local Viewer serves) and `run.json`, what `expo-explore reports` lists. Local reviews,
* explorations and uploaded reports land here, so a past run can be reopened or hosted without capturing it again.
* Runs older than 30 days, and the oldest beyond 2 GB, are pruned whenever a run is saved.
@@ -30,6 +31,8 @@ export type SavedRun = {
/** A local review of uncommitted changes: how many files differed from HEAD. */
uncommittedFiles?: number;
platforms: ExplorePlatform[];
/** The run's targets, in order; their ids name its ZIPs. Absent in runs saved before targets, whose ZIPs are named for `platforms`. */
targets?: RunTarget[];
device?: string;
/** Changed surfaces by group across the platforms, as the PR comment counts them. */
changes?: Partial<Record<ChangeGroup, number>>;
@@ -40,7 +43,15 @@ export type SavedRun = {
savedAt: string;
bytes: number;
};
export type SavedReport = { platform: ExplorePlatform; zip: Uint8Array; changes?: number; device?: string };
/** One report of a run. Without a target, it is the target named for its platform, as runs saved before targets were. */
export type SavedReport = { platform: ExplorePlatform; target?: RunTarget; zip: Uint8Array; changes?: number; device?: string };
const PLATFORM_LABELS: Record<ExplorePlatform, string> = { ios: "iOS", android: "Android" };
/** A report's target: its own, else the one named for its platform. */
export function reportTarget(report: Pick<SavedReport, "platform" | "target">): RunTarget {
return report.target ?? { id: report.platform, platform: report.platform, label: PLATFORM_LABELS[report.platform] };
}
export const SAVED_RUN_LIMITS = { maxAgeDays: 30, maxBytes: 2 * 1024 * 1024 * 1024 } as const;
const ID = /^[a-z0-9][a-z0-9._-]{0,119}$/;
@@ -84,14 +95,17 @@ export async function describeReports(reports: SavedReport[], extra: { subjects?
const first = parsed[0]?.content;
if (!first) throw new Error("Not an Explore report ZIP");
const createdAt = extra.createdAt ?? new Date().toISOString();
const platforms = parsed.map(entry => entry.report.platform);
const platforms = [...new Set(parsed.map(entry => entry.report.platform))];
// Targets named for their platforms describe a run saved the old way, which older versions can still read.
const targets = reports.map(reportTarget);
const named = targets.some(target => target.id !== target.platform) ? { targets } : {};
if (first.file === "exploration.json") {
const report = first.json as Partial<ExplorationReport>;
if (report.kind !== EXPLORATION_REPORT_KIND || !report.exploration || !report.map) throw new Error("Not an Explore exploration report");
const { app, device } = report.exploration;
const zipHash = createHash("sha256").update(reports[0]!.zip).digest("hex").slice(0, 10);
return { id: `explore-${slug(app.name, 40)}-${zipHash}`, kind: "exploration", title: `${app.name}${app.version ? ` ${app.version}` : ""}${app.buildNumber ? ` (${app.buildNumber})` : ""} on ${device.model}`,
platforms, device: `${device.model} ${device.osVersion}`.trim(),
platforms, ...named, device: `${device.model} ${device.osVersion}`.trim(),
explored: { app: app.name, ...(app.version ? { version: app.version } : {}), ...(app.buildNumber ? { buildNumber: app.buildNumber } : {}),
screens: report.map.screens.length, unexplored: report.coverage?.frontier.pending ?? 0 },
createdAt: report.exploration.completedAt ?? createdAt };
@@ -100,9 +114,12 @@ export async function describeReports(reports: SavedReport[], extra: { subjects?
const review = reviews[0];
const pr = review?.pullRequest;
if (!review || !pr) throw new Error("Not an Explore review report");
// One surface changed on two platforms is one change, under the first platform's group, as the PR comment lists it.
// One surface changed on two platforms is one change, under the group the PR comment lists it in (strongerGroup).
const merged = new Map<string, ChangeGroup>();
for (const each of reviews) if (each) for (const [id, group] of reviewChanges(normalizePublicReviewForReading(each))) if (!merged.has(id)) merged.set(id, group);
for (const each of reviews) if (each) for (const [id, group] of reviewChanges(normalizePublicReviewForReading(each))) {
const first = merged.get(id);
merged.set(id, first ? strongerGroup(first, group) : group);
}
const changes: Partial<Record<ChangeGroup, number>> = {};
for (const group of merged.values()) changes[group] = (changes[group] ?? 0) + 1;
const devices = [...new Set(reviews.map(each => each ? reviewDevice({ runtime: { deviceModel: each.runtime?.device?.model ?? "", osVersion: each.runtime?.device?.osVersion ?? "",
@@ -114,7 +131,7 @@ export async function describeReports(reports: SavedReport[], extra: { subjects?
: `${kind === "compare" ? "compare" : `pr-${number}`}-${slug(pr.repository.split("/").at(-1) ?? "", 40)}-${slug(review.runId, 40)}-${slug(String(review.runAttempt), 8)}`;
const commit = (side: "head" | "base"): SavedCommit => ({ ref: pr[side].ref, sha: pr[side].sha, ...(extra.subjects?.[side] ? { subject: extra.subjects[side] } : {}) });
return { id, kind, title: pr.title, repository: pr.repository, ...(number === undefined ? {} : { number }), head: commit("head"), base: commit("base"),
...(extra.uncommittedFiles ? { uncommittedFiles: extra.uncommittedFiles } : {}), platforms, ...(devices.length ? { device: devices.join(", ") } : {}),
...(extra.uncommittedFiles ? { uncommittedFiles: extra.uncommittedFiles } : {}), platforms, ...named, ...(devices.length ? { device: devices.join(", ") } : {}),
changes, createdAt: review.createdAt ?? createdAt };
}
@@ -132,10 +149,13 @@ export async function saveRun(reports: SavedReport[], extra: Parameters<typeof d
const kept = await findSavedRun(described.id, environment);
if (kept && described.kind !== "exploration" && kept.kind === described.kind && kept.repository === described.repository
&& kept.head?.sha === described.head?.sha && kept.base?.sha === described.base?.sha) {
const others = (await readSavedReports(kept, environment).catch(() => [] as SavedReport[])).filter(report => !reports.some(each => each.platform === report.platform));
const others = (await readSavedReports(kept, environment).catch(() => [] as SavedReport[])).filter(report => !reports.some(each => reportTarget(each).id === reportTarget(report).id));
if (others.length) {
const order: ExplorePlatform[] = ["ios", "android"];
reports = [...reports, ...others].sort((a, b) => order.indexOf(a.platform) - order.indexOf(b.platform));
// The targets' own order when the reports name it; iOS before Android for reports from before targets.
const order = (await Promise.all([...reports, ...others].map(async report => ((await reportJson(report.zip))?.json as Partial<ArtifactReport> | undefined)?.review?.runtime?.targets)))
.find(list => Array.isArray(list))?.map(target => target.id) ?? ["ios", "android"];
const rank = (report: SavedReport) => { const index = order.indexOf(reportTarget(report).id); return index < 0 ? order.length : index; };
reports = [...reports, ...others].sort((a, b) => rank(a) - rank(b));
const subjects = { ...(kept.head?.subject ? { head: kept.head.subject } : {}), ...(kept.base?.subject ? { base: kept.base.subject } : {}), ...extra.subjects };
described = await describeReports(reports, { ...extra, subjects, ...(kept.uncommittedFiles && !extra.uncommittedFiles ? { uncommittedFiles: kept.uncommittedFiles } : {}) });
}
@@ -144,7 +164,7 @@ export async function saveRun(reports: SavedReport[], extra: Parameters<typeof d
const run = cleanRun({ version: 1, ...described, savedAt: new Date(now).toISOString(), bytes: reports.reduce((total, report) => total + report.zip.byteLength, 0) });
try {
await mkdir(staged);
for (const report of reports) await writeFile(join(staged, `${report.platform}.zip`), report.zip);
for (const report of reports) await writeFile(join(staged, `${reportTarget(report).id}.zip`), report.zip);
await writeFile(join(staged, "run.json"), `${JSON.stringify(run, null, 2)}\n`);
await rm(target, { recursive: true, force: true });
await rename(staged, target);
@@ -158,8 +178,11 @@ export async function saveRun(reports: SavedReport[], extra: Parameters<typeof d
function validRun(value: unknown, id: string): SavedRun | undefined {
const run = value as Partial<SavedRun> | undefined;
if (!run || run.version !== 1 || run.id !== id || typeof run.title !== "string" || typeof run.bytes !== "number") return undefined;
// Platforms name the ZIP files read back, so only the two there are.
// Targets (else platforms) name the ZIP files read back, so only valid ids.
if (!Array.isArray(run.platforms) || !run.platforms.length || run.platforms.some(platform => platform !== "ios" && platform !== "android")) return undefined;
if (run.targets !== undefined && (!Array.isArray(run.targets) || !run.targets.length || run.targets.some(target => !target || !isTargetId(target.id)
|| (target.platform !== "ios" && target.platform !== "android") || typeof target.label !== "string")
|| new Set(run.targets.map(target => target.id)).size !== run.targets.length)) return undefined;
if (!["local", "pull-request", "compare", "exploration"].includes(run.kind ?? "") || Number.isNaN(Date.parse(run.createdAt ?? "")) || Number.isNaN(Date.parse(run.savedAt ?? ""))) return undefined;
return run as SavedRun;
}
@@ -185,10 +208,11 @@ export async function findSavedRun(idOrLatest: string, environment: NodeJS.Proce
return idOrLatest === "latest" ? runs[0] : runs.find(run => run.id === idOrLatest);
}
/** A saved run's reports, in the order the run lists its platforms, labelled for a Viewer's platform switch. */
/** A saved run's reports, in the order the run lists its targets, labelled for a Viewer's target switch. */
export async function readSavedReports(run: SavedRun, environment: NodeJS.ProcessEnv = process.env): Promise<SavedReport[]> {
const root = join(savedRunsDirectory(environment), run.id);
return Promise.all(run.platforms.map(async platform => ({ platform, zip: new Uint8Array(await readFile(join(root, `${platform}.zip`))) })));
const targets = run.targets ?? run.platforms.map(platform => reportTarget({ platform }));
return Promise.all(targets.map(async target => ({ platform: target.platform, target, zip: new Uint8Array(await readFile(join(root, `${target.id}.zip`))) })));
}
export async function removeSavedRun(id: string, environment: NodeJS.ProcessEnv = process.env): Promise<boolean> {
+21 -4
View File
@@ -50,9 +50,23 @@ export type ViewerLinkInput = {
runAttempt: string;
/** Set by the matrix workflows; the Viewer then downloads the platform-suffixed report artifact. */
platform?: "ios" | "android";
/** The capture target's id when the run captures several (wins over `platform`); the artifact is suffixed with it. */
target?: string;
configPath: string;
};
/** The target id grammar (TARGET_ID_PATTERN, minus the names isTargetId reserves). */
const TARGET_ID = /^[a-z][a-z0-9-]{0,31}$/;
/**
* The query parameter that selects a target's report: `platform=<id>` for a target named after its platform, so links for
* configs without targets stay byte-identical and old Workers and Viewers still read them; `target=<id>` for any other.
*/
export function targetParameter(id: string): ["platform" | "target", string] {
if (!TARGET_ID.test(id) || ["base", "head", "report"].includes(id) || id.startsWith("install-")) throw new Error("target id is invalid");
return [id === "ios" || id === "android" ? "platform" : "target", id];
}
const SAFE_ID = /^[A-Za-z0-9._-]{1,200}$/;
// A secondary appearance surface is `<route>@<scheme>` (see schemeScreenId).
const SURFACE_ID = /^[A-Za-z0-9._-]{1,200}(@(light|dark))?$/;
@@ -77,16 +91,17 @@ function repositoryPath(repository: string): string {
const PREVIEW_PATH = /^\/p\/[a-z2-7]{32}$/;
/** Deep links on a verified preview URL (`https://<project>--<id>.expo.app/p/<token>`), same grammar as the central Viewer. */
export function previewLinks(previewUrl: string, expiresAt: number | null, platform?: "ios" | "android"): PreviewLinks {
export function previewLinks(previewUrl: string, expiresAt: number | null, target?: string): PreviewLinks {
const url = safeHttpUrl(previewUrl, "preview URL");
if (url.protocol !== "https:" || url.search || url.hash || !PREVIEW_PATH.test(url.pathname)) {
throw new Error("preview URL must be an https token page without a query or fragment");
}
if (expiresAt !== null && (!Number.isFinite(expiresAt) || expiresAt <= 0)) throw new Error("preview expiry must be a timestamp or null");
const selection = target ? targetParameter(target) : undefined;
const make = (params: Record<string, string> = {}) => {
const link = new URL(url.href);
// Several platforms share one token page; `platform` picks this report's archive.
if (platform) link.searchParams.set("platform", platform);
// Several targets share one token page; `platform` or `target` picks this report's archive.
if (selection) link.searchParams.set(...selection);
for (const [key, value] of Object.entries(params)) link.searchParams.set(key, value);
return link.href;
};
@@ -107,6 +122,8 @@ export function viewerLinks(input: ViewerLinkInput): ViewerLinks {
throw new Error("configPath must be a relative repository path");
}
const repository = `https://github.com/${repositoryPath(input.repository)}`;
const targetId = input.target ?? input.platform;
const selection = targetId ? targetParameter(targetId) : undefined;
const artifact = input.artifactUrl ? safeHttpUrl(input.artifactUrl, "artifact URL") : undefined;
if (artifact && (artifact.origin !== "https://github.com" || artifact.search || artifact.hash
|| !new RegExp(`^/${repositoryPath(input.repository).replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}/actions/runs/${input.runId}/artifacts/[1-9][0-9]*$`).test(artifact.pathname))) {
@@ -119,7 +136,7 @@ export function viewerLinks(input: ViewerLinkInput): ViewerLinks {
url.searchParams.set("repo", input.repository);
url.searchParams.set("run", input.runId);
url.searchParams.set("attempt", input.runAttempt);
if (input.platform) url.searchParams.set("platform", input.platform);
if (selection) url.searchParams.set(...selection);
url.searchParams.set("artifact", artifact.pathname.split("/").at(-1)!);
for (const [key, value] of Object.entries(params)) url.searchParams.set(key, value);
return url.href;
+11 -1
View File
@@ -1,3 +1,4 @@
import type { RunTarget } from "../types.js";
import { appearancePairs, bundleColorSchemes, routeIdOfScreen } from "../capture/appearance.js";
import { createHash } from "node:crypto";
import { lstat, readFile, realpath } from "node:fs/promises";
@@ -259,6 +260,9 @@ export type CaptureReviewOptions = {
app?: { version?: string; buildNumber?: string };
/** The platforms config.yaml captures (this report's platform among them), when more than one. */
platforms?: Array<"ios" | "android">;
/** The target this report captures, and every target config.yaml captures (this one among them), when more than one. */
target?: RunTarget;
targets?: RunTarget[];
};
/** Build the validated review independently of where its metadata and images will be stored. */
@@ -284,6 +288,10 @@ async function constructCaptureReview(options: CaptureReviewOptions, store: Scre
? sourceImpactKinds(surface.sourceChange.files.map((file) => file.relation))
: []
);
// Each controller reads and drives the device its own way; a review compares captures made the same way.
if ((head.bundle.controller ?? "agent-device") !== (base.bundle.controller ?? "agent-device")) {
throw new Error(`The base was captured with ${base.bundle.controller ?? "agent-device"} and the head with ${head.bundle.controller ?? "agent-device"}; capture both sides with the same controller.`);
}
const colorSchemes = bundleColorSchemes(head.bundle);
const baseColorSchemes = bundleColorSchemes(base.bundle);
const review: PublicReview = {
@@ -291,9 +299,11 @@ async function constructCaptureReview(options: CaptureReviewOptions, store: Scre
runId: options.runId, runAttempt: options.runAttempt,
...(plan.navigation ? { navigation: plan.navigation } : {}),
runtime: { projectId: head.bundle.easProjectId ?? "", buildId: head.bundle.easBuildId ?? "", gitCommit: plan.headSha,
platform: head.bundle.platform ?? "ios", statusBarBandPercent: statusBarBandPercent(head.bundle.platform),
platform: head.bundle.platform ?? "ios", ...(head.bundle.controller === "argent" ? { controller: "argent" as const } : {}), statusBarBandPercent: statusBarBandPercent(head.bundle.platform),
...(homeIndicatorBandPercent(head.bundle.platform) > 0 ? { homeIndicatorBandPercent: homeIndicatorBandPercent(head.bundle.platform) } : {}),
...(options.platforms && options.platforms.length > 1 ? { platforms: [...options.platforms] } : {}),
...(options.target ? { target: { ...options.target } } : {}),
...(options.targets && options.targets.length > 1 ? { targets: options.targets.map(target => ({ ...target })) } : {}),
...(colorSchemes.length > 1 ? { colorSchemes: [...colorSchemes] } : {}),
...(head.bundle.runtimeProfile ? { device: { model: head.bundle.runtimeProfile.deviceModel, osVersion: head.bundle.runtimeProfile.osVersion } } : {}),
...(head.bundle.appName?.trim() ? { appName: head.bundle.appName.trim() } : {}),
+28
View File
@@ -27,6 +27,7 @@ import {
} from "./visual-evidence.js";
import { AGENT_DEVICE_VERSION } from "../shared/agent-device-version.js";
import { STATUS_BAR_BAND_PERCENT } from "../shared/png-evidence.js";
import { measureRegionShifts } from "./region-shift.js";
export const DEFAULT_VISUAL_THRESHOLD = 0.1;
export const DEFAULT_EVIDENCE_TIME_BUDGET_MS = 10 * 60_000;
@@ -141,6 +142,29 @@ function visualVerdict(assessment: VisualEvidenceAssessment, threshold: number):
};
}
/**
* The published regions with how far their content moved, where a move explains it: a layout that shifted by a
* device pixel reads as moved, not as changed. Every region the comparison found is measured, not only the ones
* published, so `allRegionsMoved` can say nothing else on the screen changed. A measurement that fails leaves the
* regions as they were.
*/
async function withRegionShifts(basePath: string, headPath: string, all: readonly VisualDiffRegion[], published: NonNullable<PublicVisualVerdict["regions"]>):
Promise<Pick<PublicVisualVerdict, "regions" | "allRegionsMoved">> {
try {
const shifts = await measureRegionShifts(basePath, headPath, all.map(region => region.rect));
const shiftOf = new Map(all.map((region, index) => [region.rect, shifts[index]] as const));
return {
regions: published.map(region => {
const shift = shiftOf.get(region.rect);
return shift ? { ...region, shift } : region;
}),
...(all.length > 0 && shifts.every(Boolean) ? { allRegionsMoved: true as const } : {}),
};
} catch {
return { regions: published };
}
}
/** Remove status-bar-only diff regions from a measurement and recompute its verdict inputs. */
export function ignoreStatusBar(measurement: ScreenshotDiffMeasurement, bandPercent: number = STATUS_BAR_BAND_PERCENT): { measurement: ScreenshotDiffMeasurement; ignored: number } {
const bands = ignoreSystemBands(measurement, { top: bandPercent, bottom: 0 });
@@ -463,6 +487,10 @@ export async function assessPublicEvidence(options: {
representative: measurement,
});
visual = visualVerdict(assessment, threshold);
// Measuring moves is extra: once the comparison budget is spent, regions go out unmeasured.
if (visual.verdict === "modified" && visual.regions?.length && now() <= deadline) {
Object.assign(visual, await withRegionShifts(basePath, headPath, measurement.regions, visual.regions));
}
if (ignoredTop > 0) visual.ignoredStatusBarRegions = ignoredTop;
if (ignoredBottom > 0) visual.ignoredHomeIndicatorRegions = ignoredBottom;
visualCounts.compared += 1;
+150
View File
@@ -0,0 +1,150 @@
import { createRequire } from "node:module";
import { readFile } from "node:fs/promises";
import type { DecodedFrame } from "../shared/png-evidence.js";
/** How far a region's content moved from Before to After, in screenshot pixels (right and down are positive). */
export type RegionShift = { x: number; y: number };
type Rect = { x: number; y: number; width: number; height: number };
/**
* The farthest a region is searched for, in screenshot pixels: layout drift, not a different screen. Drift adds up
* down a long screen (a device pixel per text element above), so the vertical reach is the larger.
*/
const MAX_SHIFT_X = 4;
const MAX_SHIFT_Y = 20;
/** How close to the edge of the search a best fit may land and still count: the real one may lie beyond it. */
const EDGE = 1.5;
/**
* The share of a region's difference one shift must explain for the region to have moved rather than changed.
* A move of half a pixel or less re-rasterizes text rather than shifting it, so a pure shift explains only a
* quarter to a half of it; content that changed (new text, a caret) explains under a quarter at that size, and
* anything larger has to be explained mostly by the shift. Measured on euxy's SDK 58 upgrade (brentvatne/euxy#161).
*/
const MIN_EXPLAINED = 0.6;
const MIN_EXPLAINED_SUBPIXEL = 0.25;
const SUBPIXEL = 0.5;
/** A smaller shift is rendering noise, not a move. */
const MIN_SHIFT = 0.25;
/** Sixths of a pixel in the refining search: a third of a 1x pixel is one device pixel on a 3x screen. */
const STEPS_PER_PIXEL = 6;
/** Fits this close to the best are ties, which go to the smallest move (content that is the same all along one axis). */
const TIE = 1.005;
/** Another fit this close at a vertical offset two or more pixels away makes the move ambiguous (repeating content). */
const AMBIGUOUS = 1.05;
/**
* After aligning by the move, content is the same only where every channel is within this: re-rasterized text
* differs by at most about 125 (brentvatne/euxy#161), new content by about 200. A few pixels over it are noise; more are a change.
*/
const CHANGED_CHANNEL = 140;
const CHANGED_PIXELS = 3;
type Image = { width: number; height: number; frame: DecodedFrame; luminance: Float32Array };
type Fit = { sx: number; sy: number; error: number };
function image(frame: DecodedFrame): Image {
const luminance = new Float32Array(frame.width * frame.height);
for (let index = 0; index < luminance.length; index += 1) {
const offset = index * 4;
luminance[index] = 0.299 * frame.data[offset]! + 0.587 * frame.data[offset + 1]! + 0.114 * frame.data[offset + 2]!;
}
return { width: frame.width, height: frame.height, frame, luminance };
}
/** Bilinear sample of one plane: `channel` 0–2 of the frame, or luminance when undefined. */
function at(source: Image, x: number, y: number, channel?: number): number {
const cx = Math.min(source.width - 1, Math.max(0, x));
const cy = Math.min(source.height - 1, Math.max(0, y));
const x0 = Math.floor(cx), y0 = Math.floor(cy);
const x1 = Math.min(source.width - 1, x0 + 1), y1 = Math.min(source.height - 1, y0 + 1);
const fx = cx - x0, fy = cy - y0;
const value = channel === undefined
? (px: number, py: number) => source.luminance[py * source.width + px]!
: (px: number, py: number) => source.frame.data[(py * source.width + px) * 4 + channel]!;
return value(x0, y0) * (1 - fx) * (1 - fy) + value(x1, y0) * fx * (1 - fy) + value(x0, y1) * (1 - fx) * fy + value(x1, y1) * fx * fy;
}
/** How badly After's region matches Before shifted by (sx, sy). */
function mismatch(base: Image, head: Image, rect: Rect, sx: number, sy: number): number {
let error = 0;
for (let y = rect.y; y < rect.y + rect.height; y += 1) {
for (let x = rect.x; x < rect.x + rect.width; x += 1) {
error += Math.abs(at(base, x - sx, y - sy) - head.luminance[y * head.width + x]!);
}
}
return error;
}
/** The best of some fits, with near-ties going to the smallest move. */
function bestOf(fits: readonly Fit[]): Fit {
const least = Math.min(...fits.map(fit => fit.error));
return fits.filter(fit => fit.error <= least * TIE + 1e-6)
.sort((a, b) => Math.hypot(a.sx, a.sy) - Math.hypot(b.sx, b.sy))[0]!;
}
/** Whether, aligned by the move, some of the region still differs strongly in any channel: content that changed. */
function changedAfterMove(base: Image, head: Image, rect: Rect, sx: number, sy: number): boolean {
let strong = 0;
for (let y = rect.y; y < rect.y + rect.height; y += 1) {
for (let x = rect.x; x < rect.x + rect.width; x += 1) {
for (let channel = 0; channel < 3; channel += 1) {
if (Math.abs(at(base, x - sx, y - sy, channel) - head.frame.data[(y * head.width + x) * 4 + channel]!) > CHANGED_CHANNEL) {
strong += 1;
if (strong >= CHANGED_PIXELS) return true;
break;
}
}
}
}
return false;
}
/**
* The shift that explains one region's difference, if one does: the region's content is the same in both
* screenshots, only moved. A region whose content changed (new text, another colour) has no shift, and neither has
* one whose content repeats so that several shifts fit.
*/
function regionShift(base: Image, head: Image, region: Rect): RegionShift | undefined {
const x = Math.max(0, Math.floor(region.x)), y = Math.max(0, Math.floor(region.y));
const rect = { x, y, width: Math.min(head.width - x, Math.ceil(region.width)), height: Math.min(head.height - y, Math.ceil(region.height)) };
if (rect.width <= 0 || rect.height <= 0) return undefined;
const unshifted = mismatch(base, head, rect, 0, 0);
if (unshifted === 0) return undefined;
// Whole pixels first, every pixel counting: sampling every other row aliases on thin shapes (text, hairlines).
const whole: Fit[] = [];
for (let sy = -MAX_SHIFT_Y; sy <= MAX_SHIFT_Y; sy += 1) {
for (let sx = -MAX_SHIFT_X; sx <= MAX_SHIFT_X; sx += 1) whole.push({ sx, sy, error: mismatch(base, head, rect, sx, sy) });
}
const coarse = bestOf(whole);
if (whole.some(fit => Math.abs(fit.sy - coarse.sy) >= 2 && fit.error <= coarse.error * AMBIGUOUS + 1e-6)) return undefined;
// Then sixths of a pixel around it, from whole-number steps so a move up and a move down round alike.
const fine: Fit[] = [];
for (let iy = -STEPS_PER_PIXEL; iy <= STEPS_PER_PIXEL; iy += 1) {
for (let ix = -STEPS_PER_PIXEL; ix <= STEPS_PER_PIXEL; ix += 1) {
const sx = coarse.sx + ix / STEPS_PER_PIXEL, sy = coarse.sy + iy / STEPS_PER_PIXEL;
fine.push({ sx, sy, error: ix === 0 && iy === 0 ? coarse.error : mismatch(base, head, rect, sx, sy) });
}
}
const best = bestOf(fine);
if (Math.abs(best.sx) > MAX_SHIFT_X - EDGE || Math.abs(best.sy) > MAX_SHIFT_Y - EDGE) return undefined;
const distance = Math.hypot(best.sx, best.sy);
const needed = distance <= SUBPIXEL + 1e-6 ? MIN_EXPLAINED_SUBPIXEL : MIN_EXPLAINED;
if (distance < MIN_SHIFT - 1e-6 || 1 - best.error / unshifted < needed) return undefined;
if (changedAfterMove(base, head, rect, best.sx, best.sy)) return undefined;
const round = (value: number) => Math.round(value * 100) / 100 || 0;
return { x: round(best.sx), y: round(best.sy) };
}
/** Each region's shift between two screenshots of the same size; undefined where a region's content changed. */
export function regionShifts(baseFrame: DecodedFrame, headFrame: DecodedFrame, regions: readonly Rect[]): Array<RegionShift | undefined> {
if (baseFrame.width !== headFrame.width || baseFrame.height !== headFrame.height) return regions.map(() => undefined);
const base = image(baseFrame), head = image(headFrame);
return regions.map(region => regionShift(base, head, region));
}
/** Reads both PNG screenshots and measures each region's shift. */
export async function measureRegionShifts(basePath: string, headPath: string, regions: readonly Rect[]): Promise<Array<RegionShift | undefined>> {
const { PNG } = createRequire(import.meta.url.replace(/\?.*$/, ""))("pngjs") as
{ PNG: { sync: { read(bytes: Buffer, options: { checkCRC: boolean }): DecodedFrame } } };
const [base, head] = await Promise.all([readFile(basePath), readFile(headPath)]);
return regionShifts(PNG.sync.read(base, { checkCRC: false }), PNG.sync.read(head, { checkCRC: false }), regions);
}
+11 -7
View File
@@ -11,12 +11,15 @@ import type {
} from "./runtime-evidence.js";
import type { ExploreMap, Observation, Screen } from "../types.js";
import { CAPTURE_OBSERVER_IDENTIFIER } from "../capture/observer.js";
import { ARGENT_VERSION } from "../shared/argent-version.js";
/** Strict, non-secret subset written after a successful EAS Simulator cleanup. */
/** Strict, non-secret subset written after a successful simulator cleanup. */
export type RuntimeExecutionContext = {
provider: "eas-simulator";
controller: "agent-device";
controllerPackageVersion: typeof AGENT_DEVICE_VERSION;
/** EAS Simulator, or a simulator Explore created on the capturing Mac (`capture.simulator: local`). */
provider: "eas-simulator" | "local-simulator";
controller: "agent-device" | "argent";
/** The pinned package of the controller that drove the session. */
controllerPackageVersion: typeof AGENT_DEVICE_VERSION | typeof ARGENT_VERSION;
easCliVersion: typeof EAS_CLI_VERSION;
platform: "ios" | "android";
deviceModel: string;
@@ -107,12 +110,13 @@ export function parseRuntimeExecutionContext(value: unknown): RuntimeExecutionCo
}
return context.colorSchemes.map((entry) => literal(entry, ["light", "dark"], "Runtime color schemes"));
})();
const controller = literal(context.controller, ["agent-device", "argent"], "Runtime controller");
return {
provider: literal(context.provider, ["eas-simulator"], "Runtime provider"),
controller: literal(context.controller, ["agent-device"], "Runtime controller"),
provider: literal(context.provider, ["eas-simulator", "local-simulator"], "Runtime provider"),
controller,
controllerPackageVersion: literal(
context.controllerPackageVersion,
[AGENT_DEVICE_VERSION],
[controller === "argent" ? ARGENT_VERSION : AGENT_DEVICE_VERSION],
"Controller package version",
),
easCliVersion: literal(context.easCliVersion, [EAS_CLI_VERSION], "EAS CLI version"),
+6 -6
View File
@@ -92,8 +92,8 @@ export type RawCaptureSample = {
};
export type RawSimulatorEnvironment = {
provider: "eas-simulator";
controller: "agent-device";
provider: "eas-simulator" | "local-simulator";
controller: "agent-device" | "argent";
platform: Platform;
deviceModel: string;
osVersion: string;
@@ -246,8 +246,8 @@ export type RuntimeEnvironmentEvidence = {
id: "environment";
profile: EvidenceField<"capture-context", string>;
fixturePersona?: EvidenceField<"capture-context", string>;
provider: EvidenceField<"eas-agent-device", "eas-simulator">;
controller: EvidenceField<"eas-agent-device", "agent-device">;
provider: EvidenceField<"eas-agent-device", "eas-simulator" | "local-simulator">;
controller: EvidenceField<"eas-agent-device", "agent-device" | "argent">;
controllerPackageVersion?: EvidenceField<"capture-context", string>;
easCliVersion?: EvidenceField<"capture-context", string>;
platform: EvidenceField<"eas-agent-device", Platform>;
@@ -784,8 +784,8 @@ function parseEnvironment(value: unknown): RawSimulatorEnvironment {
"Runtime environment",
);
return {
provider: literal(environment.provider, ["eas-simulator"], "Runtime provider"),
controller: literal(environment.controller, ["agent-device"], "Runtime controller"),
provider: literal(environment.provider, ["eas-simulator", "local-simulator"], "Runtime provider"),
controller: literal(environment.controller, ["agent-device", "argent"], "Runtime controller"),
platform: literal(environment.platform, PLATFORMS, "Runtime platform"),
deviceModel: safeString(environment.deviceModel, "Device model", 256),
osVersion: safeString(environment.osVersion, "OS version", 256),
+1 -1
View File
@@ -3,4 +3,4 @@
* controller (`--package-version`), the daemon health check, and the screenshot diff tool must
* all be this version; each caller checks it by exact equality.
*/
export const AGENT_DEVICE_VERSION = "0.21.15";
export const AGENT_DEVICE_VERSION = "0.21.28";
+5
View File
@@ -0,0 +1,5 @@
/**
* The one Argent version Explore runs. The local CLI (`package.json`) and the EAS Simulator controller
* (`--package-version` for an `argent` session) must both be this version.
*/
export const ARGENT_VERSION = "0.29.0";
+235
View File
@@ -0,0 +1,235 @@
/**
* The device controllers Explore drives, fetched on first use instead of installed with Explore. Each is pinned to
* an exact npm release and its sha512 integrity; the tarball is checked before anything in it is written, nothing in
* it runs at install time, and neither controller needs other packages at run time. Argent's tool-server, which a
* local simulator needs, is the exception: ensureArgentToolServer installs it with its dependencies.
*/
import { spawnSync } from "node:child_process";
import { createHash, randomUUID } from "node:crypto";
import { existsSync, mkdirSync, readFileSync, renameSync, writeFileSync } from "node:fs";
import { chmod, mkdir, open, readdir, rename, rm, stat, writeFile } from "node:fs/promises";
import { homedir } from "node:os";
import { dirname, join, resolve, sep } from "node:path";
import { fileURLToPath } from "node:url";
import { safeRelativePath, walkTar } from "../binary/archive.js";
import { CiError } from "./ci-errors.js";
import { AGENT_DEVICE_VERSION } from "./agent-device-version.js";
import { ARGENT_VERSION } from "./argent-version.js";
export type ControllerName = "agent-device" | "argent";
/** Each controller's npm release, the file Explore runs from it, and the integrity npm publishes for it. */
export const CONTROLLER_PACKAGES: Record<ControllerName, { name: string; version: string; bin: string; integrity: string }> = {
"agent-device": { name: "agent-device", version: AGENT_DEVICE_VERSION, bin: "bin/agent-device.mjs",
integrity: "sha512-uGEENVhPzSpIACrVlt16O1mloODWJyAemTCT0boDb4L006JXN2rG747u1TRoQJudOpdP/Pm2urxNRHeECLMLfg==" },
argent: { name: "@swmansion/argent", version: ARGENT_VERSION, bin: "dist/cli.js",
integrity: "sha512-XXWlWZJlHKqnAvNx3RDhuiVFQOPqh5EDB76+mFAyqC2mutC6irzw03+M/6S/WQ+Dzz2IYOkEfOzQnOOdhrGgJg==" },
};
const COMPLETE = ".explore-controller.json";
const MAX_CONTROLLER_BYTES = 256 * 1024 * 1024;
const LAUNCHER = fileURLToPath(new URL("../capture/controller-launcher.js", import.meta.url));
/** Where fetched controllers live: EXPLORE_CONTROLLER_CACHE, else the user's cache directory. */
export function controllerCacheRoot(environment: NodeJS.ProcessEnv = process.env): string {
if (environment.EXPLORE_CONTROLLER_CACHE) return resolve(environment.EXPLORE_CONTROLLER_CACHE);
const base = environment.XDG_CACHE_HOME || join(environment.HOME || homedir(), ".cache");
return join(base, "expo-explore", "controllers");
}
export function controllerDirectory(controller: ControllerName, environment: NodeJS.ProcessEnv = process.env): string {
const { name, version } = CONTROLLER_PACKAGES[controller];
return join(controllerCacheRoot(environment), `${name.replace("/", "+")}@${version}`);
}
/** The controller's entry file in the cache; it exists once `ensureController` has run. */
export function controllerBin(controller: ControllerName, environment: NodeJS.ProcessEnv = process.env): string {
return join(controllerDirectory(controller, environment), CONTROLLER_PACKAGES[controller].bin);
}
export function controllerCached(controller: ControllerName, environment: NodeJS.ProcessEnv = process.env): boolean {
return existsSync(join(controllerDirectory(controller, environment), COMPLETE));
}
/** The registry tarball for a release, from EXPLORE_NPM_REGISTRY (a mirror) or the public npm registry. */
export function controllerTarballUrl(controller: ControllerName, environment: NodeJS.ProcessEnv = process.env): string {
const { name, version } = CONTROLLER_PACKAGES[controller];
const registry = (environment.EXPLORE_NPM_REGISTRY || "https://registry.npmjs.org").replace(/\/+$/, "");
return `${registry}/${name}/-/${name.split("/").pop()}-${version}.tgz`;
}
/**
* The command that runs agent-device: a small script in the cache that fetches the pinned release on first use and
* then runs it with the same arguments. It names the cache, so a caller that narrows the environment (no HOME) still
* finds it. Written synchronously, so capture options can name it before any controller call.
*/
export function agentDeviceLauncher(environment: NodeJS.ProcessEnv = process.env): string {
const root = controllerCacheRoot(environment);
const quote = (value: string) => `'${value.replace(/'/g, `'\\''`)}'`;
// The registry is part of the command too: controller calls run with a narrowed environment that drops it.
const registry = environment.EXPLORE_NPM_REGISTRY ? ` EXPLORE_NPM_REGISTRY=${quote(environment.EXPLORE_NPM_REGISTRY)}` : "";
const script = `#!/bin/sh\nEXPLORE_CONTROLLER_CACHE=${quote(root)}${registry} exec ${quote(process.execPath)} ${quote(LAUNCHER)} agent-device "$@"\n`;
// One command per pinned release and installation, so two Explore installs on a machine never swap each other's
// controller in the middle of a capture.
const digest = createHash("sha256").update(script).digest("hex").slice(0, 12);
const command = join(root, "bin", `agent-device-${CONTROLLER_PACKAGES["agent-device"].version}-${digest}`);
if (existsSync(command) && readFileSync(command, "utf8") === script) return command;
mkdirSync(dirname(command), { recursive: true, mode: 0o700 });
const temporary = `${command}.${process.pid}.${randomUUID()}`;
writeFileSync(temporary, script, { mode: 0o755 });
renameSync(temporary, command);
return command;
}
/** A fetch killed mid-download (a timed-out controller call) leaves its staging files; clear any over an hour old. */
async function removeAbandonedStaging(root: string): Promise<void> {
const cutoff = Date.now() - 60 * 60_000;
for (const name of await readdir(root).catch(() => [] as string[])) {
if (!name.startsWith(".staging-")) continue;
const path = join(root, name);
const info = await stat(path).catch(() => undefined);
if (info && info.mtimeMs < cutoff) await rm(path, { recursive: true, force: true });
}
}
function downloadFailed(controller: ControllerName, message: string): CiError {
const { name, version } = CONTROLLER_PACKAGES[controller];
return new CiError({ code: "CONTROLLER_DOWNLOAD_FAILED", stage: "preflight", message: `${name}@${version} could not be fetched: ${message}`,
nextAction: "Check that this machine can reach the npm registry (or set EXPLORE_NPM_REGISTRY to a mirror that serves it), then rerun." });
}
/**
* Fetches the pinned controller into the cache once and returns its entry file. The download is hashed while it
* streams and must match the pinned integrity before it is unpacked; only regular files and directories inside the
* package are written, and the finished directory is renamed into place, so concurrent runs never see half of it.
*/
export async function ensureController(controller: ControllerName, options: {
environment?: NodeJS.ProcessEnv; fetch?: typeof fetch; progress?: (message: string) => void;
/** Tests: releases built on the spot instead of the pinned npm ones. */
packages?: typeof CONTROLLER_PACKAGES;
} = {}): Promise<string> {
const environment = options.environment ?? process.env;
const pinned = (options.packages ?? CONTROLLER_PACKAGES)[controller];
const directory = controllerDirectory(controller, environment);
const bin = join(directory, pinned.bin);
if (controllerCached(controller, environment)) return bin;
const root = controllerCacheRoot(environment);
await mkdir(root, { recursive: true, mode: 0o700 });
await removeAbandonedStaging(root);
const staging = join(root, `.staging-${process.pid}-${randomUUID()}`);
const tarball = `${staging}.tgz`;
try {
options.progress?.(`fetching ${pinned.name}@${pinned.version}`);
let response: Response;
try { response = await (options.fetch ?? fetch)(controllerTarballUrl(controller, environment)); }
catch (error) { throw downloadFailed(controller, error instanceof Error ? error.message : String(error)); }
if (!response.ok || !response.body) throw downloadFailed(controller, `the registry answered ${response.status}`);
const hash = createHash("sha512");
const file = await open(tarball, "wx", 0o600);
let bytes = 0;
try {
for await (const chunk of response.body as unknown as AsyncIterable<Uint8Array>) {
bytes += chunk.length;
if (bytes > MAX_CONTROLLER_BYTES) throw downloadFailed(controller, "the tarball is larger than expected");
hash.update(chunk);
await file.write(chunk);
}
} finally { await file.close(); }
const integrity = `sha512-${hash.digest("base64")}`;
if (integrity !== pinned.integrity) {
throw new CiError({ code: "CONTROLLER_INTEGRITY_MISMATCH", stage: "preflight",
message: `${pinned.name}@${pinned.version} from the registry does not match the release Explore pins (${integrity}).`,
nextAction: "Do not use this registry for Explore's controllers; unset EXPLORE_NPM_REGISTRY or point it at a faithful mirror." });
}
await mkdir(staging, { mode: 0o700 });
let written = 0;
await walkTar(tarball, async (entry, contents) => {
const relative = safeRelativePath(entry.name);
if (relative === "package" && entry.type === "5") return;
if (!relative || !relative.startsWith("package/")) throw downloadFailed(controller, `the tarball has an entry outside the package (${entry.name})`);
const target = join(staging, relative.slice("package/".length));
if (!target.startsWith(`${staging}${sep}`)) throw downloadFailed(controller, `the tarball has an unsafe entry (${entry.name})`);
if (entry.type === "5") { await mkdir(target, { recursive: true }); return; }
if (entry.type !== "0") throw downloadFailed(controller, `the tarball has a link or special file (${entry.name})`);
written += entry.size;
if (written > MAX_CONTROLLER_BYTES) throw downloadFailed(controller, "the package is larger than expected");
await mkdir(dirname(target), { recursive: true });
await writeFile(target, await contents(), { mode: entry.mode & 0o111 ? 0o755 : 0o644 });
});
if (!existsSync(join(staging, pinned.bin))) throw downloadFailed(controller, `the package has no ${pinned.bin}`);
await chmod(join(staging, pinned.bin), 0o755);
await writeFile(join(staging, COMPLETE), `${JSON.stringify({ name: pinned.name, version: pinned.version, integrity })}\n`);
try { await rename(staging, directory); }
catch (error) {
// Another run finished first; its copy is the same verified release.
if (!controllerCached(controller, environment)) throw error;
}
return bin;
} finally {
await rm(tarball, { force: true });
await rm(staging, { recursive: true, force: true });
}
}
/** The tool-server's package and its lockfile, shipped with Explore: every dependency is the version and tarball locked there. */
const ARGENT_TOOL_SERVER_LOCK = fileURLToPath(new URL("../../controllers/argent-tool-server/", import.meta.url));
/**
* Where the tool-server is installed in the controller cache: by Argent's version and the lockfile's hash, so a changed
* lock (or an install from before there was one) is installed afresh.
*/
export function argentToolServerDirectory(root: string): string {
const lock = createHash("sha256").update(readFileSync(join(ARGENT_TOOL_SERVER_LOCK, "package-lock.json"))).digest("hex").slice(0, 12);
return join(root, `argent-tool-server@${CONTROLLER_PACKAGES.argent.version}-${lock}`);
}
/** npm gets what it needs to reach the registry, never the tokens and keys a capture's environment carries. */
export function npmEnvironment(environment: NodeJS.ProcessEnv): NodeJS.ProcessEnv {
return Object.fromEntries(Object.entries(environment).filter(([name]) => /^(PATH|HOME|USER|LOGNAME|SHELL|TMPDIR|TEMP|TMP|LANG|LC_ALL|LC_CTYPE|SystemRoot|WINDIR|APPDATA|LOCALAPPDATA|NODE_EXTRA_CA_CERTS|(HTTPS?|NO|ALL)_PROXY|(https?|no|all)_proxy|npm_config_\w+|NPM_CONFIG_\w+)$/.test(name)));
}
/**
* Argent's tool-server, for driving simulators on this machine (`capture.simulator: local`): unlike the client, it
* needs Argent's dependencies, some with native prebuilds (tree-sitter). They are installed once, on first use, with
* `npm ci` from the lockfile Explore ships, so each package is the exact tarball locked there, and without running any
* package's install scripts. Returns its CLI.
*/
export async function ensureArgentToolServer(options: { environment?: NodeJS.ProcessEnv; progress?: (message: string) => void;
/** Tests: stands in for `npm ci`, given the folder to install into (its package.json and lockfile are there). */
install?: (directory: string) => Promise<void> } = {}): Promise<string> {
const environment = options.environment ?? process.env;
const pinned = CONTROLLER_PACKAGES.argent;
const root = controllerCacheRoot(environment);
const directory = argentToolServerDirectory(root);
const cli = join(directory, "node_modules", "@swmansion", "argent", pinned.bin);
if (existsSync(join(directory, COMPLETE))) return cli;
await mkdir(root, { recursive: true, mode: 0o700 });
await removeAbandonedStaging(root);
const staging = join(root, `.staging-${process.pid}-${randomUUID()}`);
try {
options.progress?.(`installing Argent's tool-server (${pinned.name}@${pinned.version} and its locked dependencies)`);
await mkdir(staging, { mode: 0o700 });
for (const file of ["package.json", "package-lock.json"]) await writeFile(join(staging, file), readFileSync(join(ARGENT_TOOL_SERVER_LOCK, file)));
await (options.install ?? (async target => {
const registry = environment.EXPLORE_NPM_REGISTRY ? ["--registry", environment.EXPLORE_NPM_REGISTRY] : [];
const npm = spawnSync("npm", ["ci", "--omit=optional", "--ignore-scripts", "--no-audit", "--no-fund", ...registry],
{ cwd: target, env: npmEnvironment(environment), encoding: "utf8", timeout: 10 * 60_000 });
if (npm.error || npm.status !== 0) throw new CiError({ code: "CONTROLLER_DOWNLOAD_FAILED", stage: "preflight",
message: `Argent's tool-server could not be installed: ${(npm.error?.message ?? npm.stderr ?? "").trim().split("\n").at(-1) ?? "npm failed"}`,
nextAction: "Check that npm is on PATH and can reach the registry (or set EXPLORE_NPM_REGISTRY), then rerun." });
}))(staging);
// npm ci checked every package against the lockfile; Argent itself must also be the exact release Explore pins.
const lock = JSON.parse(readFileSync(join(staging, "package-lock.json"), "utf8")) as { packages?: Record<string, { version?: string; integrity?: string }> };
const installed = lock.packages?.[`node_modules/${pinned.name}`];
if (installed?.version !== pinned.version || installed.integrity !== pinned.integrity) throw new CiError({ code: "CONTROLLER_INTEGRITY_MISMATCH", stage: "preflight",
message: `The ${pinned.name} npm installed (${installed?.version ?? "none"}, ${installed?.integrity ?? "no integrity"}) is not the release Explore pins.`,
nextAction: "Do not use this registry for Explore's controllers; unset EXPLORE_NPM_REGISTRY or point it at a faithful mirror." });
await writeFile(join(staging, COMPLETE), `${JSON.stringify({ name: pinned.name, version: pinned.version, integrity: pinned.integrity })}\n`);
// Several captures may install at once; the first to finish keeps its copy.
try { await rename(staging, directory); }
catch (error) { if (!existsSync(join(directory, COMPLETE))) throw error; }
return cli;
} finally {
await rm(staging, { recursive: true, force: true });
}
}
+10
View File
@@ -77,12 +77,22 @@ export type RunEnvironment = {
instructions?: string;
};
/**
* A named capture target: one platform's device, in one pose, captured as its own report. A config without `targets`
* has one target per platform, named after it (`ios`, `android`).
*/
export type RunTarget = { id: string; platform: Platform; label: string };
export type ExploreRun = {
id: string;
name: string;
platform: Platform;
/** Every platform the review captured, when more than one; the Viewer links the sibling report. */
platforms?: Platform[];
/** The target this report captured; absent in reports from before targets, which are named for their platform. */
target?: RunTarget;
/** Every target the review captured, in config order, when more than one; the Viewer links the sibling reports. */
targets?: RunTarget[];
controller: Controller;
bundleId?: string;
deviceId?: string;
+14 -14
View File
@@ -16,15 +16,15 @@ concurrency:
group: explore-baseline-${{ github.sha }}
cancel-in-progress: false
jobs:
# The platforms .expo-explore/config.yaml captures (ios, android, or both): one baseline job each.
platforms:
# The targets .expo-explore/config.yaml captures (ios, android, or the devices under targets:): one baseline job each.
targets:
if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch)
runs-on: ubuntu-22.04
timeout-minutes: 10
permissions:
contents: read
outputs:
platforms: ${{ steps.platforms.outputs.platforms }}
targets: ${{ steps.targets.outputs.targets }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with: { ref: '${{ github.sha }}', path: app, persist-credentials: false }
@@ -46,25 +46,25 @@ jobs:
tar -xzf "$TOOLS_PREFIX"/expo-explore-*.tgz -C "$TOOLS_PREFIX"
cd "$TOOLS"
npm ci --omit=dev --include=optional --ignore-scripts --no-audit --no-fund
- name: List the configured platforms
id: platforms
- name: List the configured targets
id: targets
shell: bash
run: |
set -euo pipefail
platforms="$(node "$TOOLS/dist/cli.js" config:platforms --project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '.platforms')"
echo "platforms=$platforms" >> "$GITHUB_OUTPUT"
targets="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '[.targets[].id]')"
echo "targets=$targets" >> "$GITHUB_OUTPUT"
baseline:
needs: platforms
needs: targets
strategy:
fail-fast: false
matrix:
platform: ${{ fromJSON(needs.platforms.outputs.platforms) }}
target: ${{ fromJSON(needs.targets.outputs.targets) }}
runs-on: ubuntu-22.04
timeout-minutes: 90
permissions:
contents: read
env:
PLATFORM: ${{ matrix.platform }}
TARGET: ${{ matrix.target }}
steps:
- name: Validate baseline source
shell: bash
@@ -93,7 +93,7 @@ jobs:
node "$TOOLS/dist/cli.js" source:verify \
--base-project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" --head-project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" \
--base-sha "$GITHUB_SHA" --head-sha "$GITHUB_SHA" --scope all \
--config .expo-explore/config.yaml --output "$RUNNER_TEMP/explore-consistency" --platform "$PLATFORM"
--config .expo-explore/config.yaml --output "$RUNNER_TEMP/explore-consistency" --target "$TARGET"
- name: Install app dependencies
shell: bash
run: npm ci --ignore-scripts --prefix "app/$APP_INSTALL_DIR"
@@ -108,7 +108,7 @@ jobs:
run: |
set -euo pipefail
node "$TOOLS/dist/cli.js" capture:baseline --project "$GITHUB_WORKSPACE/app/$APP_PROJECT_DIR" \
--sha "$GITHUB_SHA" --config .expo-explore/config.yaml --output "$RUNNER_TEMP/explore-baseline" --platform "$PLATFORM"
--sha "$GITHUB_SHA" --config .expo-explore/config.yaml --output "$RUNNER_TEMP/explore-baseline" --target "$TARGET"
- name: Stop the capture session and check the checkout
if: always() && steps.explore.outcome == 'success'
timeout-minutes: 5
@@ -119,7 +119,7 @@ jobs:
- name: Upload exact-commit baseline evidence
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-baseline-${{ github.sha }}-${{ matrix.platform }}
name: explore-baseline-${{ github.sha }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-baseline/baseline-export
retention-days: 30
if-no-files-found: error
@@ -127,7 +127,7 @@ jobs:
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-baseline-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-baseline-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: |
${{ runner.temp }}/explore-consistency
${{ runner.temp }}/explore-diagnostics
+31 -31
View File
@@ -40,14 +40,14 @@ concurrency:
group: explore-compare-${{ inputs.base }}..${{ inputs.head }}
cancel-in-progress: false
jobs:
# Resolves both refs to commits once, and lists the platforms .expo-explore/config.yaml captures at head.
platforms:
# Resolves both refs to commits once, and lists the targets .expo-explore/config.yaml captures at head.
targets:
runs-on: ubuntu-22.04
timeout-minutes: 10
permissions:
contents: read
outputs:
platforms: ${{ steps.platforms.outputs.platforms }}
targets: ${{ steps.targets.outputs.targets }}
base: ${{ steps.refs.outputs.base }}
head: ${{ steps.refs.outputs.head }}
compare: ${{ steps.refs.outputs.compare }}
@@ -84,19 +84,19 @@ jobs:
HEAD_SHA: ${{ steps.refs.outputs.head }}
shell: bash
run: git -C app-head checkout --quiet --detach "$HEAD_SHA"
- name: List the configured platforms
id: platforms
- name: List the configured targets
id: targets
shell: bash
run: |
set -euo pipefail
platforms="$(node "$TOOLS/dist/cli.js" config:platforms --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '.platforms')"
echo "platforms=$platforms" >> "$GITHUB_OUTPUT"
targets="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '[.targets[].id]')"
echo "targets=$targets" >> "$GITHUB_OUTPUT"
capture:
needs: platforms
needs: targets
strategy:
fail-fast: false
matrix:
platform: ${{ fromJSON(needs.platforms.outputs.platforms) }}
target: ${{ fromJSON(needs.targets.outputs.targets) }}
runs-on: ubuntu-22.04
timeout-minutes: 120
permissions:
@@ -106,14 +106,14 @@ jobs:
# "eas" when .expo-explore/config.yaml sets report.preview.hosting; the deploy job runs only then.
preview: ${{ steps.capture.outputs.preview }}
env:
PLATFORM: ${{ matrix.platform }}
BASE_SHA: ${{ needs.platforms.outputs.base }}
HEAD_SHA: ${{ needs.platforms.outputs.head }}
TARGET: ${{ matrix.target }}
BASE_SHA: ${{ needs.targets.outputs.base }}
HEAD_SHA: ${{ needs.targets.outputs.head }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with: { ref: '${{ needs.platforms.outputs.base }}', path: app-base, fetch-depth: 0, persist-credentials: false }
with: { ref: '${{ needs.targets.outputs.base }}', path: app-base, fetch-depth: 0, persist-credentials: false }
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with: { ref: '${{ needs.platforms.outputs.head }}', path: app-head, fetch-depth: 0, persist-credentials: false }
with: { ref: '${{ needs.targets.outputs.head }}', path: app-head, fetch-depth: 0, persist-credentials: false }
- *setup-node
- *install-explore
- name: Install the launch recording decoder
@@ -132,7 +132,7 @@ jobs:
node "$TOOLS/dist/cli.js" source:verify \
--base-project "$GITHUB_WORKSPACE/app-base/$APP_PROJECT_DIR" --head-project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" \
--base-sha "$BASE_SHA" --head-sha "$HEAD_SHA" --config .expo-explore/config.yaml --output "$RUNNER_TEMP/explore-consistency" \
--platform "$PLATFORM" ${SCOPE:+--scope "$SCOPE"}
--target "$TARGET" ${SCOPE:+--scope "$SCOPE"}
- name: Install app dependencies
shell: bash
run: |
@@ -145,7 +145,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}
shell: bash
run: node "$TOOLS/dist/cli.js" ci:find-baseline --sha "$BASE_SHA" --platform "$PLATFORM"
run: node "$TOOLS/dist/cli.js" ci:find-baseline --sha "$BASE_SHA" --target "$TARGET"
- name: Download optional exact-base evidence
if: steps.cache.outputs.id != ''
continue-on-error: true
@@ -159,7 +159,7 @@ jobs:
- name: Capture review
id: capture
env:
COMPARE: ${{ needs.platforms.outputs.compare }}
COMPARE: ${{ needs.targets.outputs.compare }}
SCOPE: ${{ inputs.scope }}
EXPIRES_IN: ${{ inputs.expires-in }}
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
@@ -175,7 +175,7 @@ jobs:
node "$TOOLS/dist/cli.js" capture:review \
--base-project "$GITHUB_WORKSPACE/app-base/$APP_PROJECT_DIR" --head-project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" \
--compare "$RUNNER_TEMP/explore-compare.json" --output "$RUNNER_TEMP/explore-review" --config .expo-explore/config.yaml \
--platform "$PLATFORM" ${SCOPE:+--scope "$SCOPE"} ${EXPIRES_IN:+--expires-in "$EXPIRES_IN"}
--target "$TARGET" ${SCOPE:+--scope "$SCOPE"} ${EXPIRES_IN:+--expires-in "$EXPIRES_IN"}
- name: Stop capture sessions and check the checkouts
if: always() && steps.explore.outcome == 'success'
timeout-minutes: 5
@@ -186,7 +186,7 @@ jobs:
- name: Upload captured review for packaging
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: |
${{ runner.temp }}/explore-review/report-input.json
${{ runner.temp }}/explore-review/plan.json
@@ -201,7 +201,7 @@ jobs:
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: |
${{ runner.temp }}/explore-consistency
${{ runner.temp }}/explore-diagnostics
@@ -216,32 +216,32 @@ jobs:
retention-days: 7
if-no-files-found: ignore
report:
needs: [platforms, capture]
needs: [targets, capture]
strategy:
fail-fast: false
matrix:
platform: ${{ fromJSON(needs.platforms.outputs.platforms) }}
target: ${{ fromJSON(needs.targets.outputs.targets) }}
runs-on: ubuntu-22.04
timeout-minutes: 20
permissions:
contents: read
env:
PLATFORM: ${{ matrix.platform }}
TARGET: ${{ matrix.target }}
steps:
- *setup-node
- *install-explore
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-review
- name: Package the report
shell: bash
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --platform "$PLATFORM"
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --target "$TARGET"
- name: Upload the report
id: report
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-review-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-review-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-report
retention-days: 30
if-no-files-found: error
@@ -249,19 +249,19 @@ jobs:
env:
ARTIFACT_URL: ${{ steps.report.outputs.artifact-url }}
shell: bash
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --platform "$PLATFORM"
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
- name: Upload report failure diagnostics
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-report-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-report-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-diagnostics
retention-days: 7
if-no-files-found: ignore
# Hosted report (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment serving every platform's report.
# Hosted report (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment serving every target's report.
# This is the only job after capture that holds EXPO_TOKEN; it writes the link to the run summary.
deploy:
needs: [platforms, capture, report]
needs: [targets, capture, report]
if: needs.capture.outputs.preview == 'eas'
runs-on: ubuntu-22.04
timeout-minutes: 20
@@ -271,7 +271,7 @@ jobs:
steps:
- *setup-node
- *install-explore
# One directory per platform artifact (explore-capture-<run>-<attempt>-<platform>, explore-review-<run>-<attempt>-<platform>).
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>).
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*
+32 -32
View File
@@ -21,8 +21,8 @@ concurrency:
group: explore-review-${{ github.event.pull_request.number || inputs.pr }}
cancel-in-progress: false
jobs:
# The platforms .expo-explore/config.yaml captures (ios, android, or both): one capture and report job each.
platforms:
# The targets .expo-explore/config.yaml captures (ios, android, or the devices under targets:): one capture and report job each.
targets:
if: >-
github.event_name != 'pull_request_target' ||
(github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository)
@@ -32,7 +32,7 @@ jobs:
contents: read
pull-requests: read
outputs:
platforms: ${{ steps.platforms.outputs.platforms }}
targets: ${{ steps.targets.outputs.targets }}
# The failure job comments with these when a capture job fails before it resolves the PR itself.
pr_number: ${{ steps.pr.outputs.pr_number }}
base: ${{ steps.pr.outputs.base }}
@@ -64,19 +64,19 @@ jobs:
run: node "$TOOLS/dist/cli.js" ci:pr --pr "$PR_NUMBER" --app-dir "$APP_PROJECT_DIR"
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with: { ref: '${{ steps.pr.outputs.head }}', path: app-head, persist-credentials: false }
- name: List the configured platforms
id: platforms
- name: List the configured targets
id: targets
shell: bash
run: |
set -euo pipefail
platforms="$(node "$TOOLS/dist/cli.js" config:platforms --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '.platforms')"
echo "platforms=$platforms" >> "$GITHUB_OUTPUT"
targets="$(node "$TOOLS/dist/cli.js" config:targets --project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" --config .expo-explore/config.yaml | jq -c '[.targets[].id]')"
echo "targets=$targets" >> "$GITHUB_OUTPUT"
capture:
needs: platforms
needs: targets
strategy:
fail-fast: false
matrix:
platform: ${{ fromJSON(needs.platforms.outputs.platforms) }}
target: ${{ fromJSON(needs.targets.outputs.targets) }}
runs-on: ubuntu-22.04
timeout-minutes: 120
permissions:
@@ -91,7 +91,7 @@ jobs:
# "eas" when .expo-explore/config.yaml sets report.preview.hosting; the deploy job runs only then.
preview: ${{ steps.capture.outputs.preview }}
env:
PLATFORM: ${{ matrix.platform }}
TARGET: ${{ matrix.target }}
steps:
- *setup-node
- *install-explore
@@ -122,7 +122,7 @@ jobs:
node "$TOOLS/dist/cli.js" source:verify \
--base-project "$GITHUB_WORKSPACE/app-base/$APP_PROJECT_DIR" --head-project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" \
--base-sha "$BASE_SHA" --head-sha "$HEAD_SHA" --config .expo-explore/config.yaml --output "$RUNNER_TEMP/explore-consistency" \
--platform "$PLATFORM"
--target "$TARGET"
- name: Install app dependencies
shell: bash
run: |
@@ -136,7 +136,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
BASE_SHA: ${{ steps.pr.outputs.base }}
shell: bash
run: node "$TOOLS/dist/cli.js" ci:find-baseline --sha "$BASE_SHA" --platform "$PLATFORM"
run: node "$TOOLS/dist/cli.js" ci:find-baseline --sha "$BASE_SHA" --target "$TARGET"
- name: Download optional exact-base evidence
if: steps.cache.outputs.id != ''
continue-on-error: true
@@ -163,7 +163,7 @@ jobs:
node "$TOOLS/dist/cli.js" capture:review \
--base-project "$GITHUB_WORKSPACE/app-base/$APP_PROJECT_DIR" --head-project "$GITHUB_WORKSPACE/app-head/$APP_PROJECT_DIR" \
--pull-request "$RUNNER_TEMP/explore-pr.json" --output "$RUNNER_TEMP/explore-review" --config .expo-explore/config.yaml \
--platform "$PLATFORM"
--target "$TARGET"
- name: Stop capture sessions and check the checkouts
if: always() && steps.pr.outcome == 'success'
timeout-minutes: 5
@@ -174,7 +174,7 @@ jobs:
- name: Upload captured review for packaging
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: |
${{ runner.temp }}/explore-review/report-input.json
${{ runner.temp }}/explore-review/plan.json
@@ -189,7 +189,7 @@ jobs:
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: |
${{ runner.temp }}/explore-consistency
${{ runner.temp }}/explore-diagnostics
@@ -204,11 +204,11 @@ jobs:
retention-days: 7
if-no-files-found: ignore
report:
needs: [platforms, capture]
needs: [targets, capture]
strategy:
fail-fast: false
matrix:
platform: ${{ fromJSON(needs.platforms.outputs.platforms) }}
target: ${{ fromJSON(needs.targets.outputs.targets) }}
runs-on: ubuntu-22.04
timeout-minutes: 20
permissions:
@@ -216,22 +216,22 @@ jobs:
actions: read
pull-requests: write
env:
PLATFORM: ${{ matrix.platform }}
TARGET: ${{ matrix.target }}
steps:
- *setup-node
- *install-explore
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-review
- name: Package hosted review bundle
shell: bash
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --platform "$PLATFORM"
run: node "$TOOLS/dist/cli.js" ci:report --input "$RUNNER_TEMP/explore-review/report-input.json" --output "$RUNNER_TEMP/explore-report" --target "$TARGET"
- name: Upload hosted review bundle
id: viewer
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-review-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-review-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-report
retention-days: 30
if-no-files-found: error
@@ -240,20 +240,20 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
ARTIFACT_URL: ${{ steps.viewer.outputs.artifact-url }}
shell: bash
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --platform "$PLATFORM"
run: node "$TOOLS/dist/cli.js" ci:publish --input "$RUNNER_TEMP/explore-review/report-input.json" --artifact-url "$ARTIFACT_URL" --target "$TARGET"
- name: Upload report failure diagnostics
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: explore-report-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}
name: explore-report-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}
path: ${{ runner.temp }}/explore-diagnostics
retention-days: 7
if-no-files-found: ignore
# Hosted preview (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment per review, serving every platform's report.
# Hosted preview (opt-in, report.preview in config.yaml): one token-gated EAS Hosting deployment per review, serving every target's report.
# This is the only job after capture that holds EXPO_TOKEN; the report job stays credential-free and has already
# published the Download report link, so a failed deployment leaves the comment on the download-and-drop flow.
deploy:
needs: [platforms, capture, report]
needs: [targets, capture, report]
if: needs.capture.outputs.preview == 'eas'
runs-on: ubuntu-22.04
timeout-minutes: 20
@@ -264,7 +264,7 @@ jobs:
steps:
- *setup-node
- *install-explore
# One directory per platform artifact (explore-capture-<run>-<attempt>-<platform>, explore-review-<run>-<attempt>-<platform>).
# One directory per target artifact (explore-capture-<run>-<attempt>-<target>, explore-review-<run>-<attempt>-<target>).
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
pattern: explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*
@@ -280,8 +280,8 @@ jobs:
shell: bash
run: node "$TOOLS/dist/cli.js" ci:deploy --inputs "$RUNNER_TEMP/explore-review" --reports "$RUNNER_TEMP/explore-report"
failure:
needs: [platforms, capture, report, deploy]
if: always() && (needs.platforms.result == 'failure' || needs.capture.result == 'failure' || needs.report.result == 'failure' || needs.deploy.result == 'failure')
needs: [targets, capture, report, deploy]
if: always() && (needs.targets.result == 'failure' || needs.capture.result == 'failure' || needs.report.result == 'failure' || needs.deploy.result == 'failure')
runs-on: ubuntu-22.04
timeout-minutes: 10
permissions:
@@ -307,12 +307,12 @@ jobs:
- name: Report failure only on the current PR
env:
GITHUB_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ needs.capture.outputs.pr_number || needs.platforms.outputs.pr_number }}
HEAD_SHA: ${{ needs.capture.outputs.head || needs.platforms.outputs.head }}
BASE_SHA: ${{ needs.capture.outputs.base || needs.platforms.outputs.base }}
PR_NUMBER: ${{ needs.capture.outputs.pr_number || needs.targets.outputs.pr_number }}
HEAD_SHA: ${{ needs.capture.outputs.head || needs.targets.outputs.head }}
BASE_SHA: ${{ needs.capture.outputs.base || needs.targets.outputs.base }}
shell: bash
run: |
set -euo pipefail
# The diagnostics artifacts are data files from this run and attempt, never executable report code;
# the first error.json names the failed platform, and the comment keeps every other platform's result.
# the first error.json names the failed target, and the comment keeps every other target's result.
node "$TOOLS/dist/cli.js" ci:failure --pr "${PR_NUMBER:-0}" --head "${HEAD_SHA:-}" --base "${BASE_SHA:-}" --diagnostics "$RUNNER_TEMP/explore-failure"
+17 -10
View File
@@ -106,24 +106,31 @@ test("artifact cache isolates repository, run and attempt, ignores the artifact
assert.deepEqual(result, { misses: [true, true, true], artifactIgnored: true, deleted: true, retained: true });
});
test("artifact cache keeps one report per platform of a run and both survive the prune of a later write", async t => {
test("artifact cache keeps one report per target of a run, under the platform keys reports were saved with before targets", async t => {
const { open } = await harness(t);
const page = await open();
const result = await page.evaluate(async identity => {
const ios = { ...identity, platform: "ios" };
const android = { ...identity, platform: "android" };
const result = await page.evaluate(async ({ identity, namespace }) => {
const ios = { ...identity, target: "ios" };
const android = { ...identity, target: "android" };
const duo = { ...identity, target: "duo-open" };
const { digest: iosDigest } = await window.writeArtifact(ios, [80, 75, 3, 4, 1]);
const { digest: androidDigest } = await window.writeArtifact(android, [80, 75, 3, 4, 2]);
// Storing another report prunes every key it does not recognise; platform keys must be recognised.
const { digest: duoDigest } = await window.writeArtifact(duo, [80, 75, 3, 4, 3]);
// Storing another report prunes every key it does not recognise; target keys must be recognised.
await window.writeArtifact({ ...identity, run: "999" });
const [iosHit, androidHit, unsuffixed] = await Promise.all([ios, android, identity].map(value => window.cacheApi.getCachedArtifact(value)));
const [iosHit, androidHit, duoHit, unsuffixed] = await Promise.all([ios, android, duo, identity].map(value => window.cacheApi.getCachedArtifact(value)));
const keys = (await (await caches.open(namespace)).keys()).map(request => new URL(request.url).search).sort();
return {
ios: iosHit?.digest === iosDigest, android: androidHit?.digest === androidDigest, distinct: iosHit?.digest !== androidHit?.digest,
ios: iosHit?.digest === iosDigest, android: androidHit?.digest === androidDigest, duo: duoHit?.digest === duoDigest,
distinct: new Set([iosHit?.digest, androidHit?.digest, duoHit?.digest]).size === 3,
unsuffixedMisses: !unsuffixed,
invalid: !await window.cacheApi.getCachedArtifact({ ...identity, platform: "web" }),
invalid: !await window.cacheApi.getCachedArtifact({ ...identity, target: "Duo Open" }),
keys,
};
}, identity);
assert.deepEqual(result, { ios: true, android: true, distinct: true, unsuffixedMisses: true, invalid: true });
}, { identity, namespace });
assert.deepEqual(result, { ios: true, android: true, duo: true, distinct: true, unsuffixedMisses: true, invalid: true, keys: [
"?repo=expo%2Fexample&run=123&attempt=2&platform=android", "?repo=expo%2Fexample&run=123&attempt=2&platform=ios",
"?repo=expo%2Fexample&run=123&attempt=2&target=duo-open", "?repo=expo%2Fexample&run=999&attempt=2"] });
});
test("artifact cache removes the retired public download cache the first time it is used", async t => {
+97 -6
View File
@@ -69,11 +69,16 @@ async function harness(t, bytes, { app = false, open = true, name = fileName, re
// A preview deployment's Worker: the decrypted report behind the token, or the same 404 as any other path.
if (preview && url.pathname === `${pagePath}/report.zip`) {
preview.requests = (preview.requests ?? 0) + 1;
preview.queries = [...(preview.queries ?? []), url.search];
if (preview.status && preview.status !== 200) { response.statusCode = preview.status; return response.end(preview.body ?? "Not found"); }
response.setHeader("content-type", "application/zip");
response.setHeader("content-length", String(bytes.length));
return response.end(bytes);
}
if (preview?.listing && url.pathname === `${pagePath}/reports.json`) {
response.setHeader("content-type", "application/json");
return response.end(JSON.stringify(preview.listing));
}
if (url.pathname !== pagePath) return next();
response.setHeader("content-type", "text/html");
response.end(`<!doctype html><html><head><meta charset="utf-8"><link rel="icon" href="/favicon.svg" type="image/svg+xml"></head><body><div id="root"></div>
@@ -408,6 +413,91 @@ test("a hosted preview link downloads the report from its own token route, opens
assert.deepEqual(gone.errors, []);
});
test("a hosted run of several targets opens the linked target and switches between all of them in config order", { timeout: 60_000 }, async t => {
const targets = [
{ id: "iphone", platform: "ios", label: "iPhone 17" },
{ id: "duo-closed", platform: "ios", label: "iPhone Duo (closed)" },
{ id: "duo-open", platform: "ios", label: "iPhone Duo (open)" },
{ id: "android", platform: "android", label: "Android" },
];
const report = reportFixture();
report.review.runtime = { ...report.review.runtime, platform: "ios", platforms: ["ios", "android"], target: targets[2], targets };
const preview = { token: "defghijklmnopqrstuvwxyz234567234", listing: [
{ target: "iphone", platform: "ios", label: "iPhone 17", changes: 1 },
{ target: "duo-closed", platform: "ios", label: "iPhone Duo (closed)" },
{ target: "duo-open", platform: "ios", label: "iPhone Duo (open)", changes: 1 },
{ target: "android", platform: "android", label: "Android", changes: 2, device: "Pixel 9 16" },
] };
const { page, errors } = await harness(t, await archive(report), { app: true, reportIdentity: null, preview, query: "&target=duo-open" });
const button = page.getByRole("button", { name: "Device: iPhone Duo (open). Open another device's report" });
await expect(button).toBeVisible();
assert.deepEqual(preview.queries, ["?target=duo-open"], "the Viewer asks the Worker for the linked target's report");
await button.click();
const items = page.getByRole("menu", { name: "Device" }).getByRole("menuitemradio");
await expect(items).toHaveCount(4);
assert.deepEqual(await items.evaluateAll(rows => rows.map(row => [row.querySelector(".menu-row-label")?.firstChild?.textContent, row.getAttribute("aria-checked")])),
[["iPhone 17", "false"], ["iPhone Duo (closed)", "false"], ["iPhone Duo (open)", "true"], ["Android", "false"]]);
await expect(items.nth(3)).toContainText("2 changes · Pixel 9 16");
await expect(items.nth(1)).toContainText("Same review, other device");
await items.nth(3).click();
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "android");
const next = new URL(page.url());
assert.equal(next.searchParams.get("target"), null, "a target named after its platform is linked as before targets");
await expect.poll(() => preview.queries.at(-1)).toBe("?platform=android");
assert.deepEqual(errors, []);
});
test("a hosted report from before targets still switches platforms by ?platform=", { timeout: 60_000 }, async t => {
const report = reportFixture();
report.review.runtime = { ...report.review.runtime, platform: "android", platforms: ["ios", "android"] };
const preview = { token: "efghijklmnopqrstuvwxyz2345672345", listing: [{ platform: "ios", changes: 3 }, { platform: "android" }] };
const { page, errors } = await harness(t, await archive(report), { app: true, reportIdentity: null, preview, query: "&platform=android" });
const button = page.getByRole("button", { name: "Platform: Android. Open another platform's report" });
await expect(button).toBeVisible();
assert.deepEqual(preview.queries, ["?platform=android"]);
await button.click();
const items = page.getByRole("menu", { name: "Platform" }).getByRole("menuitemradio");
assert.deepEqual(await items.evaluateAll(rows => rows.map(row => [row.querySelector(".menu-row-label")?.firstChild?.textContent, row.getAttribute("aria-checked")])),
[["iOS", "false"], ["Android", "true"]]);
await expect(items.nth(0)).toContainText("3 changes");
await items.nth(0).click();
await page.waitForURL(url => new URL(url).searchParams.get("platform") === "ios");
assert.deepEqual(errors, []);
});
test("report links name their target: ?target=, ?platform= from before targets, and the artifact file name", async t => {
const { page } = await harness(t, undefined, { reportIdentity: null, query: "" });
const result = await page.evaluate(() => {
const api = window.archiveApi;
const attempt = fn => { try { return fn(); } catch (error) { return `error: ${error.message}`; } };
const preview = "http://x/p/abcdefghijklmnopqrstuvwxyz234567";
return {
target: api.previewReportUrl(new URL(`${preview}?target=duo-open`)),
platform: api.previewReportUrl(new URL(`${preview}?platform=android`)),
none: api.previewReportUrl(new URL(preview)),
both: attempt(() => api.reportTarget(new URL(`${preview}?target=duo-open&platform=ios`))),
invalid: attempt(() => api.reportTarget(new URL(`${preview}?target=Duo`))),
reserved: attempt(() => api.reportTarget(new URL(`${preview}?target=report`))),
identity: api.artifactIdentity(new URL("http://x/r?repo=expo/example&run=1&attempt=2&target=duo-open")),
legacy: api.artifactIdentity(new URL("http://x/r?repo=expo/example&run=1&attempt=2&platform=android")),
fileName: api.reportFileName({ run: "1", attempt: "2", target: "duo-open" }),
legacyFileName: api.reportFileName({ run: "1", attempt: "2", target: "ios" }),
};
});
assert.deepEqual(result, {
target: "/p/abcdefghijklmnopqrstuvwxyz234567/report.zip?target=duo-open",
platform: "/p/abcdefghijklmnopqrstuvwxyz234567/report.zip?platform=android",
none: "/p/abcdefghijklmnopqrstuvwxyz234567/report.zip",
both: "error: This report link needs one target, such as ios or android.",
invalid: "error: This report link needs one target, such as ios or android.",
reserved: "error: This report link needs one target, such as ios or android.",
identity: { repo: "expo/example", run: "1", attempt: "2", target: "duo-open" },
legacy: { repo: "expo/example", run: "1", attempt: "2", target: "android" },
fileName: "explore-review-1-2-duo-open.zip",
legacyFileName: "explore-review-1-2-ios.zip",
});
});
test("a bare /r opens any report and takes its identity from review.json", async t => {
const { page, errors, origin } = await harness(t, undefined, { app: true, reportIdentity: null, query: "" });
const drop = page.locator(".report-drop");
@@ -1005,7 +1095,7 @@ test("a docs-only report with zero images and no EAS build opens Screens without
assert.deepEqual(errors, []);
});
test("unverified capture diagnostics stay separate from verified Needs review and source impact filters", async t => {
test("unverified capture diagnostics stay separate from verified Needs review, and source changes nobody compared are not changes", async t => {
const report = reportFixture();
const home = report.review.surfaces[0];
const uncertain = structuredClone(home);
@@ -1029,12 +1119,13 @@ test("unverified capture diagnostics stay separate from verified Needs review an
await expect(page.locator(".app-shell")).toBeVisible();
await page.getByRole("button", { name: "Screens", exact: true }).click();
await expect(page.locator(".screens-page .diff-frame.diff-needs-review")).toHaveCount(1);
await expect(page.locator(".screens-page .diff-frame.diff-source-affected")).toHaveCount(2);
await expect(page.locator(".screens-page .diff-frame.diff-not-compared")).toHaveCount(1);
// The unverified /home and the never-captured /candidate changed in source only: not compared, like /untouched.
await expect(page.locator(".screens-page .diff-frame.diff-source-affected")).toHaveCount(0);
await expect(page.locator(".screens-page .diff-frame.diff-not-compared")).toHaveCount(3);
await expect(page.locator(".screens-page .diff-frame.diff-modified")).toHaveCount(0);
const menu = await openChangesMenu(page);
const chips = menu.getByRole("group", { name: "Filter changes" }).getByRole("button");
await expect(chips).toHaveText(["Modified 0", "No visible change 1", "Source-affected 2"]);
await expect(chips).toHaveText(["Modified 0", "No visible change 1"]);
assert.deepEqual(errors, []);
});
@@ -1068,8 +1159,8 @@ test("an existing report with operational verdicts opens as diagnostics without
const { page, errors } = await harness(t, await archive(report), { app: true });
await expect(page.locator(".app-shell")).toBeVisible();
await page.getByRole("button", { name: "Screens", exact: true }).click();
await expect(page.locator(".screens-page .diff-frame.diff-source-affected")).toHaveCount(1);
await expect(page.locator(".screens-page .diff-frame.diff-not-compared")).toHaveCount(1);
await expect(page.locator(".screens-page .diff-frame.diff-source-affected")).toHaveCount(0);
await expect(page.locator(".screens-page .diff-frame.diff-not-compared")).toHaveCount(2);
await expect(page.locator(".screens-page .diff-frame.diff-unavailable")).toHaveCount(1, "an added route whose capture failed has nothing to show");
await expect(page.locator(".screens-page .diff-frame.diff-removed")).toHaveCount(1);
await expect(page.locator(".diff-frame.diff-needs-review, .diff-frame.diff-modified, .diff-frame.diff-unchanged, .diff-frame.diff-added")).toHaveCount(0);
+31 -4
View File
@@ -406,10 +406,13 @@ test("the Screens tree folds by row, by keyboard, and all at once, and remembers
await tree.getByRole("button", { name: "Expand all" }).click();
await expect.poll(() => rows.count()).toBe(expandedRows);
// Section headings name the folder, with the path beneath.
const onboarding = page.getByRole("region", { name: "Onboarding" });
await expect(onboarding.getByRole("heading", { level: 2 })).toHaveText("Onboarding");
await expect(onboarding.locator(".screens-section-head .path")).toHaveText("app/onboarding");
// The tree names the folders, so the page beside it is one grid without section headings, in the tree's order.
await expect(page.locator(".screens-page .screens-section-head")).toHaveCount(0);
await expect(page.locator(".screens-page .screens-grid")).toHaveCount(1);
const treeOrder = await tree.locator(".screens-tree-row[data-screen-id]").evaluateAll(rows => rows.map(row => row.dataset.screenId));
const gridOrder = await page.locator(".screens-page .screens-cell").evaluateAll(cells => cells.map(cell => cell.dataset.screenId));
assert.ok(gridOrder.length > 1);
assert.deepEqual(gridOrder, treeOrder);
assert.deepEqual(errors, []);
});
@@ -433,3 +436,27 @@ test("dev opens the report ZIP named by EXPLORE_REPORT and preserves the explici
assert.equal(payload.map.screens.length, 32);
await expectStopped(mapDev, "SIGINT");
});
test("a Screens card keeps its status dot on the route's line, however tall its row", { timeout: 60_000 }, async t => {
const { page, url, errors } = await openReport(t, { width: 1440, height: 900 });
await page.goto(`${url}#/screens`);
const all = page.getByRole("button", { name: /^All/ }).first();
await expect(all).toBeVisible();
if ((await all.getAttribute("aria-pressed")) !== "true") await all.click();
await expect(page.locator(".screens-cell .diff-label").first()).toBeVisible();
const layout = await page.locator(".screens-page").evaluate(async () => {
const cards = [...document.querySelectorAll(".screens-cell .screen-screenshot-card")];
// A row grows with a neighbour's notes ("Changed in dark") and stretches every card in it: stretch each one well past its content.
for (const card of cards) card.style.height = `${card.getBoundingClientRect().height + 48}px`;
await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
const offsets = cards.filter(card => card.querySelector(".diff-label")).map(card => {
const dot = card.querySelector(".diff-label").getBoundingClientRect(), title = card.querySelector(".screen-node-title").getBoundingClientRect();
const line = parseFloat(getComputedStyle(card.querySelector(".screen-node-title")).lineHeight);
return Math.abs(dot.top + dot.height / 2 - (title.top + line / 2));
});
return { offsets };
});
assert.ok(layout.offsets.length > 0, "the report has changed screens");
assert.ok(layout.offsets.every(offset => offset <= 1), `each dot is centred on its route's first line: ${layout.offsets}`);
assert.deepEqual(errors, []);
});
+96 -2
View File
@@ -1309,7 +1309,100 @@ for (const canvas of ["map", "screens"] as const) {
});
}
test("reuses the Map screenshot card visual in Screens, with the route at the card's left edge", async ({ page }) => {
test("← and → step through the Screens cards in page order, with focus, and leave the tree's arrows alone", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/screens");
const grid = page.getByRole("main", { name: "Screens" });
await grid.getByRole("button", { name: /^All/ }).click();
const cells = grid.locator(".screens-grid .screens-cell");
const ids = await cells.evaluateAll(elements => elements.map(element => element.getAttribute("data-screen-id")!));
expect(ids.length).toBeGreaterThan(2);
const card = (id: string) => grid.locator(`.screens-cell[data-screen-id="${id}"] .screen-screenshot-card`);
const target = (id: string) => grid.locator(`.screens-cell[data-screen-id="${id}"] .screen-screenshot-target`);
// With nothing selected, → starts at the first card.
await expect(grid.locator(".screen-screenshot-card.selected")).toHaveCount(0);
await page.keyboard.press("ArrowRight");
await expect(card(ids[0]!)).toHaveClass(/selected/);
await expect(target(ids[0]!)).toBeFocused();
await page.keyboard.press("ArrowRight");
await expect(card(ids[1]!)).toHaveClass(/selected/);
await expect(target(ids[1]!)).toBeFocused();
await page.keyboard.press("ArrowRight");
await expect(card(ids[2]!)).toHaveClass(/selected/);
await page.keyboard.press("ArrowLeft");
await expect(card(ids[1]!)).toHaveClass(/selected/);
await expect(card(ids[2]!)).not.toHaveClass(/selected/);
// ↓ and ↑ move a row, to the card in the same column.
const tops = await cells.evaluateAll(elements => elements.map(element => Math.round(element.getBoundingClientRect().top)));
const columns = tops.filter(top => top === tops[0]).length;
if (ids.length > 1 + columns) {
await page.keyboard.press("ArrowDown");
await expect(card(ids[1 + columns]!)).toHaveClass(/selected/);
await expect(target(ids[1 + columns]!)).toBeFocused();
await page.keyboard.press("ArrowUp");
await expect(card(ids[1]!)).toHaveClass(/selected/);
}
// Held, → keeps stepping, as in Compare, and stops on release.
const selectedAt = async () => ids.indexOf((await grid.locator(".screens-cell:has(.screen-screenshot-card.selected)").getAttribute("data-screen-id"))!);
const from = await selectedAt();
await page.keyboard.down("ArrowRight");
await expect.poll(selectedAt, { timeout: 4000 }).toBeGreaterThanOrEqual(Math.min(ids.length - 1, from + 3));
await page.keyboard.up("ArrowRight");
const released = await selectedAt();
await page.waitForTimeout(500);
expect(await selectedAt()).toBe(released);
// Return opens the pick in the Inspector, from the card or from anywhere on the page.
const inspector = page.getByRole("complementary", { name: "Inspector panel" });
await expect(inspector).toBeHidden();
await page.keyboard.press("Enter");
await expect(inspector).toBeVisible();
await page.keyboard.press("Escape");
await expect(inspector).toBeHidden();
await page.evaluate(() => (document.activeElement as HTMLElement | null)?.blur());
await page.keyboard.press("Enter");
await expect(inspector).toBeVisible();
await page.keyboard.press("Escape");
await expect(inspector).toBeHidden();
// In the tree, ← and → fold and unfold rows; they do not step the cards.
const picked = await selectedAt();
const row = grid.locator(".screens-tree-row").first();
await row.focus();
await page.keyboard.press("ArrowLeft");
await expect(card(ids[picked]!)).toHaveClass(/selected/);
});
test("→ steps the Screens cards right after Screens is opened from the toolbar, and from a pick that Changed hides", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/map");
await page.getByRole("group", { name: "Canvas view" }).getByRole("button", { name: "Screens", exact: true }).click();
const grid = page.getByRole("main", { name: "Screens" });
const cells = grid.locator(".screens-grid .screens-cell");
await expect(cells.first()).toBeVisible();
// Focus is still on the toolbar's Screens button.
await page.keyboard.press("ArrowRight");
await expect(cells.first().locator(".screen-screenshot-card")).toHaveClass(/selected/);
// Pick a screen that Changed hides, then show Changed: → goes to the next changed card after it in the tree.
await grid.getByRole("button", { name: /^All/ }).click();
const all = await cells.evaluateAll(elements => elements.map(element => element.getAttribute("data-screen-id")!));
await grid.getByRole("button", { name: /^Changed/ }).click();
const changed = await cells.evaluateAll(elements => elements.map(element => element.getAttribute("data-screen-id")!));
const hidden = all.find((id, position) => !changed.includes(id) && all.slice(position + 1).some(next => changed.includes(next)));
test.skip(!hidden, "the fixture has no unchanged screen before a changed one");
await grid.getByRole("button", { name: /^All/ }).click();
await grid.locator(`.screens-cell[data-screen-id="${hidden}"] .screen-screenshot-target`).click();
await grid.getByRole("button", { name: /^Changed/ }).click();
const expected = all.slice(all.indexOf(hidden!) + 1).find(id => changed.includes(id))!;
await page.keyboard.press("ArrowRight");
await expect(grid.locator(`.screens-cell[data-screen-id="${expected}"] .screen-screenshot-card`)).toHaveClass(/selected/);
});
test("reuses the Map screenshot card in Screens, with the route under the screenshot at the card's left edge", async ({ page }) => {
await serveWorkspace(page);
await page.goto("/screens");
@@ -1337,8 +1430,9 @@ test("reuses the Map screenshot card visual in Screens, with the route at the ca
};
});
expect(layout.flexDirection).toBe("column");
// The card is the Map's, so the heading still comes first in the markup; Screens shows it as the card's footer.
expect(layout.headingBeforeImage).toBe(true);
expect(layout.headingTop).toBeLessThan(layout.imageTop);
expect(layout.headingTop).toBeGreaterThan(layout.imageTop);
expect(layout.titleLeftDelta).toBeLessThan(1);
}
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
@@ -0,0 +1,5 @@
{
"description": "Source: ax-service\nMode: flat\nCoordinates are normalized [0,1] fractions of the screen (x, y, width, height), not pixels.\nPass them straight to gesture-tap / gesture-swipe / gesture-pinch, which expect this same space.\nTo tap an element, use its centre: tap_x = frame.x + frame.width / 2, tap_y = frame.y + frame.height / 2.\n\nROOT AXGroup (0.000, 0.000, 1.000, 1.000)\n\n AXGroup \"Open in “euxy”?\" (0.067, 0.382, 0.687, 0.186)\n AXAdjustable \"Vertical scroll bar, 2 pages\" value=\"0%\" (0.682, 0.382, 0.064, 0.068)\n AXAdjustable \"Horizontal scroll bar, 1 page\" value=\"0%\" (0.067, 0.412, 0.687, 0.034)\n AXStaticText \"Open in “euxy”?\" (0.131, 0.414, 0.558, 0.030)\n AXAdjustable \"Vertical scroll bar, 1 page\" value=\"0%\" (0.682, 0.450, 0.064, 0.118)\n AXButton \"Cancel\" (0.101, 0.473, 0.300, 0.071)\n AXButton \"Open\" (0.418, 0.473, 0.300, 0.071)\n AXAdjustable \"Horizontal scroll bar, 1 page\" value=\"0%\" (0.067, 0.519, 0.687, 0.044)",
"source": "ax-service",
"hint": "This simulator was not booted through argent, so system dialogs and native modals may not appear in this tree; everything else reads normally. If something you expect is missing, boot-device with force=true reboots the simulator with the full accessibility settings"
}
File diff suppressed because it is too large. Load diff
+117
View File
@@ -0,0 +1,117 @@
{
"devices": [
{
"platform": "ios",
"udid": "404F2659-7202-4450-8465-912BD2AB744B",
"name": "iPhone 17",
"state": "Booted",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "13145DF8-2591-4879-8B4E-0EE52E38B9DC",
"name": "Apple TV 4K (3rd generation)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.tvOS-26-5",
"runtimeKind": "tv"
},
{
"platform": "ios",
"udid": "9F874416-F37E-49D4-BE9F-D03A61447F37",
"name": "Apple TV 4K (3rd generation) (at 1080p)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.tvOS-26-5",
"runtimeKind": "tv"
},
{
"platform": "ios",
"udid": "AA581E94-E134-4DEC-8D68-A80C02932E86",
"name": "Apple TV",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.tvOS-26-5",
"runtimeKind": "tv"
},
{
"platform": "ios",
"udid": "7166D6B3-15EA-485E-B233-D4CF5AA1A9E6",
"name": "iPhone 17 Pro",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "65AF775B-D9DC-4293-88B6-7862868B66BC",
"name": "iPhone 17 Pro Max",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "65D86638-6B23-47AB-A60B-B152A3E5FBEC",
"name": "iPhone 17e",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "A690C59A-DE62-467C-9A93-6B9C81BE7859",
"name": "iPhone Air",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "9D7FC73C-7A12-4BCF-83C2-9B52ACF9859D",
"name": "iPad Pro 13-inch (M5)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "E71C61D3-8D9F-4591-8511-8FE65229C790",
"name": "iPad Pro 11-inch (M5)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "ED9D983B-1AA4-4648-8EED-CDCD5327B8D6",
"name": "iPad mini (A17 Pro)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "9C0DF431-D699-4862-8CF3-264CA044F515",
"name": "iPad Air 13-inch (M4)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "B92DDF42-5EB6-47F1-A1E7-2B3F2CE2CA84",
"name": "iPad Air 11-inch (M4)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
},
{
"platform": "ios",
"udid": "44804797-154C-40DB-8559-342C3F95477A",
"name": "iPad (A16)",
"state": "Shutdown",
"runtime": "com.apple.CoreSimulator.SimRuntime.iOS-26-5",
"runtimeKind": "mobile"
}
],
"avds": []
}
Binary file not shown.

After

Width:  |  Height:  |  Size: 215 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 167 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 131 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 619 KiB

+39 -20
View File
@@ -41,7 +41,7 @@ export async function readUsage(output) {
export async function fixture(t, provider, { docsOnly = false, unresolvedParameters = false, observerFailurePath, agentMode = false,
instructions = 'Explore selected routes in a stable, comparable state.', recoverableOpenFailure = false,
userInterfaceStyle, headUserInterfaceStyle, platform: initialPlatform = 'ios' } = {}) {
userInterfaceStyle, headUserInterfaceStyle, platform: initialPlatform = 'ios', targets } = {}) {
let platform = initialPlatform;
const root = await realpath(await mkdtemp(join(tmpdir(), 'explore-ci-integration-')));
t.after(() => rm(root, { recursive: true, force: true }));
@@ -56,6 +56,7 @@ export async function fixture(t, provider, { docsOnly = false, unresolvedParamet
device: { name: 'iPhone 17 Pro' }, navigation: { provider, ...(provider === 'react-navigation' ? { entry: 'src/App.tsx' } : {}) },
exploration: { scope: 'changes' }, capture: { maxMinutes: 30, maxActions: 500, repack: 'eas' },
parameters: provider === 'expo-router' && !unresolvedParameters ? { '/item/[id]': { id: 'example-item' } } : {} };
if (targets) config.targets = targets;
if (agentMode) { config.mode = 'agent'; config.agent = { provider: 'anthropic', model: 'fixture-model', instructions: '.expo-explore/instructions.md' }; }
await put('.expo-explore/instructions.md', instructions);
await put('.gitignore', 'node_modules/\n');
@@ -67,6 +68,7 @@ export async function fixture(t, provider, { docsOnly = false, unresolvedParamet
await put('eas.json', JSON.stringify({ build: { capture: { ios: { simulator: true }, android: { buildType: 'apk', distribution: 'internal' } } } }));
const registration = names => `import {createNativeStackNavigator} from '@react-navigation/native-stack';
import {createStaticNavigation} from '@react-navigation/native';
${names.map(name => `import ${name} from './${name}';`).join('\n')}
const Root=createNativeStackNavigator({screens:{${names.map(name => `${name}:{screen:${name},linking:'${name.toLowerCase()}'}`).join(',')}}});
const Navigation=createStaticNavigation(Root); export default function App(){return <Navigation/>;}`;
@@ -103,10 +105,11 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
const pullRequestPath = join(root, 'pull-request.json'); await writeFile(pullRequestPath, JSON.stringify(pr));
const environment = { PATH: process.env.PATH, HOME: root, RUNNER_TEMP: root, EXPO_TOKEN: 'test-expo-secret', GITHUB_TOKEN: 'test-github-secret',
GITHUB_RUN_ID: '1234', GITHUB_RUN_ATTEMPT: '1', GITHUB_REPOSITORY: pr.repository, TOOLS_COMMIT: 'c'.repeat(40), EXPLORE_VIEWER_ORIGIN: 'https://viewer.example' };
const requests = []; const comments = []; const sessions = new Map(); let currentSession; let currentPath = '/'; let sessionCounter = 0; let repackedSha; let openFailed = false; let currentScheme = 'light';
const identity = () => ({ session: 'expo-explore-runtime', appBundleId: config.app.bundleId,
device: { id: 'device-1', name: config.device.name, platform, target: 'mobile', osVersion: '26.0', locale: 'en-US', orientation: 'portrait', colorScheme: 'light' },
identifiers: { session: 'expo-explore-runtime', appBundleId: config.app.bundleId, deviceId: 'device-1', deviceName: config.device.name } });
const requests = []; const comments = []; const sessions = new Map(); let currentSession; const idleDevice = { path: '/', scheme: 'light' }; let sessionCounter = 0; let repackedSha; let openFailed = false;
const identity = (session) => ({ session: 'expo-explore-runtime', appBundleId: config.app.bundleId,
// The device the session was started with, as EAS starts the one a target names.
device: { id: 'device-1', name: session?.device ?? config.device.name, platform, target: 'mobile', osVersion: '26.0', locale: 'en-US', orientation: 'portrait', colorScheme: 'light' },
identifiers: { session: 'expo-explore-runtime', appBundleId: config.app.bundleId, deviceId: 'device-1', deviceName: session?.device ?? config.device.name } });
// The fixture's clock: every controller round trip advances it by one poll interval, as a device snapshot would, so a
// readiness budget expires in simulated time and a route that never becomes ready costs no real seconds.
let clockMs = Date.now();
@@ -114,7 +117,7 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
const sleep = milliseconds => { clockMs += milliseconds; };
const runner = request => {
requests.push(request);
if (basename(request.command) === 'agent-device') clockMs += 600;
if (/^agent-device(-|$)/.test(basename(request.command))) clockMs += 600;
if (request.command === 'git') { const result = spawnSync('git', request.args, { cwd: request.cwd, encoding: 'utf8', env: request.environment }); assert.equal(result.status, 0); return { stdout: result.stdout, stderr: result.stderr }; }
const command = request.args[0];
if (basename(request.command) === 'eas') {
@@ -128,7 +131,13 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
if (command === 'build:list') return json([]);
if (command === 'build') return json([{ id: `build-${git(request.cwd, 'rev-parse', 'HEAD')}`, fingerprint: { hash: 'mock-native-fingerprint' }, appVersion: '3.0.0', appBuildVersion: '7' }]);
if (command === 'env:pull') { writeFileSync(value(request, '--path'), '# Environment: preview\n'); return { stdout: '', stderr: '' }; }
if (command === 'build:download') { const path = join(request.environment.TMPDIR, 'native.app'); mkdirSync(path); return json({ path }); }
// The app carries its build's id, so the session it is installed on knows which commit it runs.
if (command === 'build:download') {
const build = value(request, '--build-id');
const path = join(request.environment.TMPDIR, platform === 'android' ? 'native.apk' : 'native.app');
if (platform === 'android') writeFileSync(path, build); else { mkdirSync(path); writeFileSync(join(path, 'build-id'), build); }
return json({ path });
}
if (command === 'upload') return json({ url: `https://expo.dev/accounts/acme/projects/example/builds/repacked-${repackedSha}` });
if (command === 'workflow:run') {
assert.equal(request.environment.EAS_NO_VCS, '1');
@@ -140,8 +149,8 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
return json({ jobs: [{ key: 'repack', status: 'SUCCESS', outputs: { build_id: `repacked-${repackedSha}`, platform } }] });
}
if (command === 'simulator:start') {
const id = `session-${++sessionCounter}`; currentSession = id; currentPath = '/'; openFailed = false;
const session = { id, name: value(request, '--name'), build: value(request, '--build-id') }; sessions.set(id, session);
const id = `session-${++sessionCounter}`; currentSession = id; openFailed = false;
const session = { id, name: value(request, '--name'), build: value(request, '--build-id'), device: value(request, '--device'), path: '/', scheme: 'light' }; sessions.set(id, session);
writeFileSync(join(request.cwd, '.env.eas-simulator'), `${HEADER}EAS_SIMULATOR_SESSION_ID='${id}'\nAGENT_DEVICE_DAEMON_BASE_URL='https://controller.example/${id}'\nAGENT_DEVICE_DAEMON_AUTH_TOKEN='controller-private-token'\n`);
return { stdout: 'ready', stderr: '' };
}
@@ -151,10 +160,14 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
if (basename(request.command) === 'repack-app') {
repackedSha = git(request.cwd, 'rev-parse', 'HEAD');
assert.ok(request.environment.EXPO_OVERRIDE_METRO_CONFIG, 'fresh and reused native builds must include the automatic observer');
mkdirSync(value(request, '--output'));
const output = value(request, '--output');
if (platform === 'android') writeFileSync(output, `repacked-${repackedSha}`); else { mkdirSync(output); writeFileSync(join(output, 'build-id'), `repacked-${repackedSha}`); }
return { stdout: '', stderr: '' };
}
if (basename(request.command) === 'agent-device') {
if (/^agent-device(-|$)/.test(basename(request.command))) {
// Base and head capture in parallel, each on its own simulator: a request names its session in the daemon URL,
// so the route, appearance and build it sees are that session's, not whichever session started last.
const device = sessions.get(/\/([^/]+)$/.exec(request.environment?.AGENT_DEVICE_DAEMON_BASE_URL ?? '')?.[1]) ?? sessions.get(currentSession) ?? idleDevice;
if (command === '--version') return { stdout: AGENT_DEVICE_VERSION, stderr: '' };
if (command === 'open') {
if (request.args[2]?.startsWith('sample://')) {
@@ -162,25 +175,31 @@ const Navigation=createStaticNavigation(Root); export default function App(){ret
openFailed = true;
return json({ success: false, error: { code: 'COMMAND_FAILED', message: 'The app is not ready for this link yet.' } });
}
currentPath = '/' + request.args[2].slice('sample://'.length);
device.path = '/' + request.args[2].slice('sample://'.length);
}
return ok(identity());
return ok(identity(device));
}
if (command === 'fold') return ok({ action: 'fold', pose: request.args[1] });
if (command === 'install') {
const app = request.args[1];
device.build = platform === 'android' ? readFileSync(app, 'utf8') : readFileSync(join(app, 'build-id'), 'utf8');
return ok({ installed: true, appBundleId: config.app.bundleId });
}
if (command === 'appstate') return ok({ platform, appBundleId: config.app.bundleId, source: 'session', device_udid: 'device-1' });
if (command === 'wait') return ok({});
if (command === 'alert' && request.args[1] === 'get') return json({ success: false, error: { code: 'COMMAND_FAILED', message: 'alert not found' } });
if (command === 'snapshot') {
const dynamic = currentPath.startsWith('/item/');
const dynamic = device.path.startsWith('/item/');
const destination = provider === 'expo-router'
? { provider, pathname: currentPath, segments: dynamic ? ['item', '[id]'] : currentPath.split('/').filter(Boolean), parameters: dynamic ? { id: currentPath.slice('/item/'.length) } : {} }
: { provider, segments: [currentPath.slice(1).replace(/^./, first => first.toUpperCase())], parameters: {} };
? { provider, pathname: device.path, segments: dynamic ? ['item', '[id]'] : device.path.split('/').filter(Boolean), parameters: dynamic ? { id: device.path.slice('/item/'.length) } : {} }
: { provider, segments: [device.path.slice(1).replace(/^./, first => first.toUpperCase())], parameters: {} };
return ok({ truncated: false, nodes: [
{ index: 0, type: 'StaticText', label: currentPath, identifier: 'screen-title', enabled: true, visible: true, rect: { x: 0, y: 0, width: 16, height: 24 } },
...(currentPath === observerFailurePath ? [] : [{ index: 1, type: 'StaticText', label: JSON.stringify(destination), identifier: CAPTURE_OBSERVER_IDENTIFIER, enabled: true, visible: true }]),
{ index: 0, type: 'StaticText', label: device.path, identifier: 'screen-title', enabled: true, visible: true, rect: { x: 0, y: 0, width: 16, height: 24 } },
...(device.path === observerFailurePath ? [] : [{ index: 1, type: 'StaticText', label: JSON.stringify(destination), identifier: CAPTURE_OBSERVER_IDENTIFIER, enabled: true, visible: true }]),
] });
}
if (command === 'settings') { if (request.args[1] === 'appearance') currentScheme = request.args[2]; return ok({ setting: request.args[1], value: request.args[2] }); }
if (command === 'screenshot') { const color = createHash('sha256').update(`${currentPath}:${currentScheme}:${currentPath === '/home' ? sessions.get(currentSession).build : 'unchanged-source'}`).digest(); const data = Buffer.alloc(16 * 24 * 4); for (let i = 0; i < data.length; i += 4) { data[i] = color[0]; data[i + 1] = color[1]; data[i + 2] = color[2]; data[i + 3] = 255; } writeFileSync(request.args[1], PNG.sync.write({ width: 16, height: 24, data })); return ok({ path: request.args[1] }); }
if (command === 'settings') { if (request.args[1] === 'appearance') device.scheme = request.args[2]; return ok({ setting: request.args[1], value: request.args[2] }); }
if (command === 'screenshot') { const color = createHash('sha256').update(`${device.path}:${device.scheme}:${device.path === '/home' ? device.build : 'unchanged-source'}`).digest(); const data = Buffer.alloc(16 * 24 * 4); for (let i = 0; i < data.length; i += 4) { data[i] = color[0]; data[i + 1] = color[1]; data[i + 2] = color[2]; data[i + 3] = 255; } writeFileSync(request.args[1], PNG.sync.write({ width: 16, height: 24, data })); return ok({ path: request.args[1] }); }
}
throw new Error(`Unexpected mocked command: ${request.command} ${request.args.join(' ')}`);
};
+35 -30
View File
@@ -119,7 +119,7 @@ test("trusted tools retain native agent runtimes while omitting development depe
const builds = [action.runs.steps.find(step => step.name === "Build the pinned Explore CLI"),
...workflows.flatMap(workflow => Object.values(workflow.jobs)
.flatMap(job => job.steps.filter(step => step.name === "Install Explore")))];
assert.equal(builds.length, 12, "composite action, review platforms/capture/report/deploy/failure, baseline platforms/baseline, and compare platforms/capture/report/deploy install the trusted tools");
assert.equal(builds.length, 12, "composite action, review targets/capture/report/deploy/failure, baseline targets/baseline, and compare targets/capture/report/deploy install the trusted tools");
for (const step of builds) {
const install = step.run.split("\n").find(line => /^\s*npm ci\b/.test(line));
assert.ok(install, step.name);
@@ -136,18 +136,18 @@ test("baseline captures a complete single default-branch commit without a PR", (
assert.ok(Object.hasOwn(baseline.on, "push"));
assert.ok(Object.hasOwn(baseline.on, "workflow_dispatch"));
const job = baseline.jobs.baseline;
assert.match(baseline.jobs.platforms.if, /github\.event\.repository\.default_branch/);
assert.deepEqual(job.needs, "platforms");
assert.deepEqual(job.strategy, { "fail-fast": false, matrix: { platform: "${{ fromJSON(needs.platforms.outputs.platforms) }}" } });
assert.equal(job.env.PLATFORM, "${{ matrix.platform }}");
assert.match(baseline.jobs.platforms.steps.at(-1).run, /config:platforms .* \| jq -c '\.platforms'/);
assert.match(baseline.jobs.targets.if, /github\.event\.repository\.default_branch/);
assert.deepEqual(job.needs, "targets");
assert.deepEqual(job.strategy, { "fail-fast": false, matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
assert.equal(job.env.TARGET, "${{ matrix.target }}");
assert.match(baseline.jobs.targets.steps.at(-1).run, /config:targets .* \| jq -c '\[\.targets\[\]\.id\]'/);
const verify = job.steps.find(step => step.name === "Verify deterministic source planning");
assert.match(verify.run, /--base-sha "\$GITHUB_SHA" --head-sha "\$GITHUB_SHA" --scope all/);
const capture = job.steps.find(step => step.name === "Capture complete single-commit baseline");
assert.match(capture.run, /capture:baseline/);
assert.doesNotMatch(baselineSource, /--pull-request|capture:review|inputs\.pr/);
const upload = job.steps.find(step => step.name === "Upload exact-commit baseline evidence");
assert.equal(upload.with.name, "explore-baseline-${{ github.sha }}-${{ matrix.platform }}");
assert.equal(upload.with.name, "explore-baseline-${{ github.sha }}-${{ matrix.target }}");
assert.equal(upload.with["retention-days"], 30);
const diagnostics = job.steps.find(step => step.name === "Upload planning and baseline diagnostics");
assert.equal(diagnostics.if, "always()");
@@ -291,7 +291,7 @@ test("action rejects unsupported Node versions before installing tools", async t
test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it runs only for a requested hosted preview", () => {
const deploy = review.jobs.deploy;
assert.deepEqual(deploy.needs, ["platforms", "capture", "report"]);
assert.deepEqual(deploy.needs, ["targets", "capture", "report"]);
assert.equal(deploy.if, "needs.capture.outputs.preview == 'eas'");
assert.deepEqual(deploy.permissions, { contents: "read", actions: "read", "pull-requests": "write" });
const step = deploy.steps.find(step => step.name === "Deploy the hosted preview and publish its Explore report links");
@@ -299,7 +299,7 @@ test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it
assert.equal(step.env.GITHUB_TOKEN, "${{ github.token }}");
assert.equal(step.env.ARTIFACT_URL, undefined);
assert.match(step.run, /ci:deploy --inputs "\$RUNNER_TEMP\/explore-review" --reports "\$RUNNER_TEMP\/explore-report"/);
// Every platform's capture and report artifact, one directory each, so the deployment serves all of them.
// Every target's capture and report artifact, one directory each, so the deployment serves all of them.
const downloads = deploy.steps.filter(step => step.uses?.startsWith("actions/download-artifact@"));
assert.deepEqual(downloads.map(step => step.with.pattern), ["explore-capture-${{ github.run_id }}-${{ github.run_attempt }}-*", "explore-review-${{ github.run_id }}-${{ github.run_attempt }}-*"]);
assert.ok(downloads.every(step => step.with.name === undefined && step.with["merge-multiple"] === undefined));
@@ -308,44 +308,49 @@ test("the deploy job is the only post-capture job that holds EXPO_TOKEN, and it
// capture:review writes preview=<hosting> to the step outputs from the reviewed config.
assert.equal(review.jobs.capture.outputs.preview, "${{ steps.capture.outputs.preview }}");
assert.match(review.jobs.capture.steps.find(step => step.id === "capture").run, /capture:review/);
assert.deepEqual(review.jobs.failure.needs, ["platforms", "capture", "report", "deploy"]);
assert.match(review.jobs.failure.if, /needs\.platforms\.result == 'failure'/);
assert.deepEqual(review.jobs.failure.needs, ["targets", "capture", "report", "deploy"]);
assert.match(review.jobs.failure.if, /needs\.targets\.result == 'failure'/);
assert.match(review.jobs.failure.if, /needs\.deploy\.result == 'failure'/);
});
test("closing a pull request runs nothing: hosted previews stay until a developer deletes them", () => {
assert.ok(!review.on.pull_request_target.types.includes("closed"));
assert.doesNotMatch(review.jobs.platforms.if, /closed/);
assert.doesNotMatch(review.jobs.targets.if, /closed/);
assert.equal(review.jobs.cleanup, undefined);
for (const workflow of workflows) assert.doesNotMatch(JSON.stringify(workflow), /ci:cleanup|deploy:delete/);
});
test("review captures and reports each configured platform in its own matrix job, with platform-suffixed artifacts", () => {
const platforms = review.jobs.platforms;
assert.deepEqual(platforms.permissions, { contents: "read", "pull-requests": "read" });
assert.equal(platforms.outputs.platforms, "${{ steps.platforms.outputs.platforms }}");
assert.match(platforms.steps.at(-1).run, /config:platforms --project "\$GITHUB_WORKSPACE\/app-head\/\$APP_PROJECT_DIR" --config \.expo-explore\/config\.yaml \| jq -c '\.platforms'/);
assert.doesNotMatch(JSON.stringify(platforms), /EXPO_TOKEN|OPENAI_API_KEY|ANTHROPIC_API_KEY|APP_REVIEW/);
for (const job of [review.jobs.capture, review.jobs.report]) {
assert.deepEqual(job.strategy, { "fail-fast": false, matrix: { platform: "${{ fromJSON(needs.platforms.outputs.platforms) }}" } });
assert.equal(job.env.PLATFORM, "${{ matrix.platform }}");
test("review captures and reports each configured target in its own matrix job, with target-suffixed artifacts", () => {
const targets = review.jobs.targets;
assert.deepEqual(targets.permissions, { contents: "read", "pull-requests": "read" });
assert.equal(targets.outputs.targets, "${{ steps.targets.outputs.targets }}");
// config:targets lists ids in config order; a config without targets: lists ["ios"] / ["ios","android"], as config:platforms did.
assert.match(targets.steps.at(-1).run, /config:targets --project "\$GITHUB_WORKSPACE\/app-head\/\$APP_PROJECT_DIR" --config \.expo-explore\/config\.yaml \| jq -c '\[\.targets\[\]\.id\]'/);
assert.doesNotMatch(JSON.stringify(targets), /EXPO_TOKEN|OPENAI_API_KEY|ANTHROPIC_API_KEY|APP_REVIEW/);
for (const workflow of [review, compare, baseline]) {
assert.doesNotMatch(JSON.stringify(workflow), /matrix\.platform|config:platforms|\$PLATFORM|needs\.platforms/, "every job is keyed by target, never by platform");
assert.match(JSON.stringify(workflow), /matrix\.target/, "doctor looks for matrix.target in an installed workflow");
}
assert.equal(review.jobs.capture.needs, "platforms");
assert.deepEqual(review.jobs.report.needs, ["platforms", "capture"]);
for (const job of [review.jobs.capture, review.jobs.report]) {
assert.deepEqual(job.strategy, { "fail-fast": false, matrix: { target: "${{ fromJSON(needs.targets.outputs.targets) }}" } });
assert.equal(job.env.TARGET, "${{ matrix.target }}");
}
assert.equal(review.jobs.capture.needs, "targets");
assert.deepEqual(review.jobs.report.needs, ["targets", "capture"]);
const runs = [review.jobs.capture, review.jobs.report, baseline.jobs.baseline].flatMap(job => job.steps.filter(step => step.run).map(step => step.run));
for (const command of ["source:verify", "capture:review", "capture:baseline", "ci:report", "ci:publish"]) {
const uses = runs.filter(run => run.includes(`cli.js" ${command}`));
assert.ok(uses.length > 0, command);
for (const run of uses) assert.match(run, /--platform "\$PLATFORM"/, command);
for (const run of uses) assert.match(run, /--target "\$TARGET"/, command);
}
for (const workflow of [review, compare]) {
assert.equal(workflow.jobs.capture.steps.find(step => step.name === "Find optional exact-base evidence").run,
'node "$TOOLS/dist/cli.js" ci:find-baseline --sha "$BASE_SHA" --platform "$PLATFORM"');
'node "$TOOLS/dist/cli.js" ci:find-baseline --sha "$BASE_SHA" --target "$TARGET"');
}
for (const [job, name] of [[review.jobs.capture, "Upload captured review for packaging"], [review.jobs.capture, "Upload planning and failure diagnostics"],
[review.jobs.report, "Upload hosted review bundle"], [review.jobs.report, "Upload report failure diagnostics"],
[baseline.jobs.baseline, "Upload exact-commit baseline evidence"], [baseline.jobs.baseline, "Upload planning and baseline diagnostics"]]) {
assert.ok(job.steps.find(step => step.name === name).with.name.endsWith("-${{ matrix.platform }}"), name);
assert.ok(job.steps.find(step => step.name === name).with.name.endsWith("-${{ matrix.target }}"), name);
}
});
@@ -363,13 +368,13 @@ test("compare reviews any two refs from a manual run or another workflow, with n
// Each override reaches the CLI only when the caller set it; the CLI validates the value.
assert.match(capture.run, /\$\{SCOPE:\+--scope "\$SCOPE"\} \$\{EXPIRES_IN:\+--expires-in "\$EXPIRES_IN"\}/);
assert.match(compare.jobs.capture.steps.find(step => step.name === "Verify deterministic source planning").run, /\$\{SCOPE:\+--scope "\$SCOPE"\}/);
assert.match(compare.jobs.report.steps.find(step => step.name === "Link the report from the run summary").run, /ci:publish --input .* --artifact-url "\$ARTIFACT_URL" --platform "\$PLATFORM"/);
assert.equal(compare.jobs.capture.env.BASE_SHA, "${{ needs.platforms.outputs.base }}", "capture checks out the commits the refs resolved to once");
assert.equal(compare.jobs.capture.env.HEAD_SHA, "${{ needs.platforms.outputs.head }}");
assert.match(compare.jobs.report.steps.find(step => step.name === "Link the report from the run summary").run, /ci:publish --input .* --artifact-url "\$ARTIFACT_URL" --target "\$TARGET"/);
assert.equal(compare.jobs.capture.env.BASE_SHA, "${{ needs.targets.outputs.base }}", "capture checks out the commits the refs resolved to once");
assert.equal(compare.jobs.capture.env.HEAD_SHA, "${{ needs.targets.outputs.head }}");
assert.equal(compare.concurrency.group, "explore-compare-${{ inputs.base }}..${{ inputs.head }}", "\"..\" cannot appear in a ref, so groups never collide");
const diagnostics = compare.jobs.report.steps.find(step => step.name === "Upload report failure diagnostics");
assert.deepEqual([diagnostics.if, diagnostics.with.path], ["always()", "${{ runner.temp }}/explore-diagnostics"]);
assert.match(compare.jobs.platforms.steps.find(step => step.id === "refs").run, /ci:compare-refs --project app-head --base "\$BASE_REF" --head "\$HEAD_REF"/);
assert.match(compare.jobs.targets.steps.find(step => step.id === "refs").run, /ci:compare-refs --project app-head --base "\$BASE_REF" --head "\$HEAD_REF"/);
assert.match(compare.jobs.capture.steps.find(step => step.id === "capture").run, /printf '%s' "\$COMPARE" > "\$RUNNER_TEMP\/explore-compare\.json"/);
assert.match(compare.jobs.deploy.steps.at(-1).run, /ci:deploy --inputs/);
});
+559
View File
@@ -0,0 +1,559 @@
import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import test from "node:test";
import { tsImport } from "tsx/esm/api";
const { PNG } = await import("pngjs");
const { ArgentCallError, describedButton, findOpenButton, iosRuntimeVersion, openInAppPromptShowing, parseCommand, runBridgeCommand, snapshotFromTree } = await tsImport("../../src/capture/argent-driver.ts", import.meta.url);
const fixture = name => JSON.parse(readFileSync(new URL(`../fixtures/argent-0.29/${name}`, import.meta.url), "utf8"));
const IOS_HOME = fixture("fixture-ios-ui-tree-home.json");
const IOS_RENAME = fixture("fixture-ios-ui-tree-rename.json");
const ANDROID_HOME = fixture("fixture-android-ui-tree-home.json");
const ANDROID_RENAME = fixture("fixture-android-ui-tree-rename.json");
const IOS_DEVICES = fixture("list-devices.out");
// iOS 27.1 on iPhone Duo: the link prompt is up, SpringBoard is in front, and alertVisible is false.
const DUO_PROMPT = fixture("fixture-ios27-duo-open-prompt-ui-tree.json");
const DUO_PROMPT_DESCRIBE = fixture("fixture-ios27-duo-open-prompt-describe.json");
const DUO_HOME = fixture("fixture-ios27-duo-home-ui-tree.json");
// iPhone Duo opened (the inner display), Edit Lane sheet up: Argent reports the app root as the screen's top-left third.
const DUO_OPEN_EDIT_LANE = fixture("fixture-ios27-duo-open-edit-lane-ui-tree.json");
const DUO_DEVICES = { devices: [{ platform: "ios", udid: "74195B53-4DBC-4EAA-9991-F98E5BB86BA8", name: "iPhone Duo", state: "Booted", runtime: "com.apple.CoreSimulator.SimRuntime.iOS-27-1", runtimeKind: "mobile" }] };
const ANDROID_DEVICES = { devices: [{ platform: "android", serial: "emulator-5554", state: "device", isEmulator: true, model: "sdk_gphone64_x86_64", avdName: "pixel_7", sdkLevel: 36, runtimeKind: "mobile" }], avds: [] };
const BUNDLE = "dev.brent.euxy";
const UDID = "404F2659-7202-4450-8465-912BD2AB744B";
/** A scripted tool-server: each tool answers from `answers` (a value, a function of the args, or a queue of either). */
function harness(platform, answers, options = {}) {
const calls = [];
const moves = [];
const queues = Object.fromEntries(Object.entries(answers).map(([tool, answer]) => [tool, Array.isArray(answer) ? [...answer] : answer]));
const context = {
platform, version: "0.29.0", state: options.state ?? { generation: 0 }, ...(options.bundleId ? { bundleId: options.bundleId } : {}),
sleep: async () => {},
reachable: async () => options.reachable ?? true,
moveFile: async (from, to) => { moves.push([from, to]); },
call: async (tool, args, callOptions) => {
calls.push({ tool, args, ...(callOptions ? { options: callOptions } : {}) });
let answer = queues[tool];
if (Array.isArray(answer)) answer = answer.length > 1 ? answer.shift() : answer[0];
if (answer === undefined) throw new Error(`unexpected tool ${tool}`);
const value = typeof answer === "function" ? answer(args) : answer;
if (value instanceof Error) throw value;
return structuredClone(value);
},
};
return { calls, moves, context, run: argv => runBridgeCommand(argv, context).then(result => ({ ...result, json: result.stdout.trim().startsWith("{") ? JSON.parse(result.stdout) : result.stdout })) };
}
const flags = (platform, extra = []) => [...extra, "--session", "expo-explore-runtime", ...(platform === "ios" ? ["--device", "iPhone 17"] : []), "--platform", platform, "--json"];
const flatten = tree => { const out = []; const walk = node => { out.push(node); (node.children ?? []).forEach(walk); }; (tree.roots ?? []).forEach(walk); return out; };
test("parseCommand separates agent-device's trailing flags from positionals and keeps text after --", () => {
assert.deepEqual(parseCommand(["e3", "--session", "s", "--device", "iPhone 17", "--platform", "ios", "--json", "--", "-h", "--json"]),
{ positional: ["e3", "-h", "--json"], flags: { session: "s", device: "iPhone 17", platform: "ios", json: true } });
});
test("iosRuntimeVersion reads the OS version from a CoreSimulator runtime id", () => {
assert.equal(iosRuntimeVersion("com.apple.CoreSimulator.SimRuntime.iOS-26-5"), "26.5");
assert.equal(iosRuntimeVersion("com.apple.CoreSimulator.SimRuntime.iOS-18-0-1"), "18.0.1");
assert.equal(iosRuntimeVersion("com.apple.CoreSimulator.SimRuntime.tvOS-26-5"), undefined);
});
test("--version answers with the pinned Argent version without calling Argent", async () => {
const { run, calls } = harness("ios", {});
assert.equal((await run(["--version"])).stdout, "0.29.0\n");
assert.equal(calls.length, 0);
});
test("an iOS snapshot is agent-device's shape: points, the app root, the observer, and no duplicate nodes", () => {
const { nodes, refs, screen } = snapshotFromTree(IOS_HOME, "ios", 1, BUNDLE);
assert.deepEqual(screen, { width: 402, height: 874 });
assert.equal(nodes[0].type, "Application");
assert.deepEqual(nodes[0].rect, { x: 0, y: 0, width: 402, height: 874 });
assert.equal(nodes[0].hittable, false);
for (const [index, node] of nodes.entries()) {
assert.equal(node.index, index);
assert.equal(node.ref, `e${index + 1}`);
assert.ok(refs[node.ref]);
if (index > 0) assert.ok(node.parentIndex < index, "a parent comes before its children");
assert.ok(node.rect.x < 402 && node.rect.y < 874 && node.rect.x + node.rect.width > 0 && node.rect.y + node.rect.height > 0, "only on-screen nodes");
}
const observer = nodes.find(node => node.identifier === "expo-explore-observer");
assert.ok(observer, "the capture observer is in the tree");
assert.equal(JSON.parse(observer.label).pathname, "/");
const keys = nodes.map(node => JSON.stringify([node.type, node.label, node.identifier, node.value, Object.values(node.rect).map(Math.round)]));
assert.equal(new Set(keys).size, keys.length, "iOS AX duplicates appear once");
assert.ok(nodes.length < flatten(IOS_HOME).length);
assert.ok(nodes.some(node => node.type === "Button" && node.identifier === "lane-row-title-0"));
});
test("an Android snapshot keeps pixels, drops the system UI root, and names widgets as agent-device does", () => {
const { nodes, screen } = snapshotFromTree(ANDROID_HOME, "android", 1, BUNDLE);
assert.deepEqual(screen, { width: 720, height: 1600 });
assert.equal(nodes[0].type, "Application");
assert.deepEqual(nodes[0].rect, { x: 0, y: 0, width: 720, height: 1600 });
assert.ok(!nodes.some(node => /^android\.widget\./.test(node.type)), "widget classes are simplified");
assert.ok(nodes.some(node => node.identifier === "expo-explore-observer"));
const systemUi = flatten({ roots: ANDROID_HOME.roots.filter(root => root.bundleId === "com.android.systemui") })
.map(node => node.label ?? node.contentDescription).filter(Boolean);
for (const label of systemUi) assert.ok(!nodes.some(node => node.label === label && node.depth === 0), `system UI root is left out (${label})`);
assert.ok(nodes.filter(node => node.depth === 0).length === 1);
});
test("snapshot pins refs to its generation and reports the foreground app; press resolves a ref to the element's centre", async () => {
const { run, calls, context } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-tap": {} });
const snapshot = await run(["snapshot", ...flags("ios", ["--force-full", "--level", "full"])]);
assert.equal(snapshot.exitCode, 0);
assert.equal(snapshot.json.data.refsGeneration, 1);
assert.equal(snapshot.json.data.appBundleId, BUNDLE);
assert.equal(snapshot.json.data.truncated, false);
assert.equal(context.state.udid, UDID);
assert.equal(context.state.model, "iPhone 17");
assert.equal(context.state.osVersion, "26.5");
const target = snapshot.json.data.nodes.find(node => node.identifier === "lane-row-title-0");
const pressed = await run(["press", `@${target.ref}`, ...flags("ios")]);
assert.equal(pressed.exitCode, 0);
const tap = calls.at(-1);
assert.equal(tap.tool, "gesture-tap");
assert.equal(tap.args.udid, UDID);
assert.ok(Math.abs(tap.args.x - (target.rect.x + target.rect.width / 2) / 402) < 1e-9);
assert.ok(Math.abs(tap.args.y - (target.rect.y + target.rect.height / 2) / 874) < 1e-9);
const stale = await run(["press", `${target.ref}~s0`, ...flags("ios")]);
assert.equal(stale.exitCode, 1);
assert.match(stale.json.error.message, /stale/);
});
test("press with coordinates normalizes Android pixels", async () => {
const { run, calls } = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": ANDROID_HOME, "gesture-tap": {} });
assert.equal((await run(["press", "360", "400", ...flags("android")])).exitCode, 0);
assert.deepEqual(calls.at(-1), { tool: "gesture-tap", args: { udid: "emulator-5554", x: 0.5, y: 0.25 } });
});
test("open relaunches the app until its tree is readable and answers with agent-device's open envelope", async () => {
const empty = { ...IOS_HOME, roots: [{ type: "Other", frame: { x: 0, y: 0, width: 1, height: 1 } }] };
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "restart-app": {}, "ui-tree": [empty, empty, IOS_HOME] });
const opened = await run(["open", BUNDLE, ...flags("ios", ["--level", "full"])]);
assert.equal(opened.exitCode, 0);
assert.deepEqual(opened.json.data.device, { platform: "ios", target: "mobile", name: "iPhone 17", id: UDID, osVersion: "26.5" });
assert.equal(opened.json.data.appBundleId, BUNDLE);
assert.equal(opened.json.data.session, "expo-explore-runtime");
assert.deepEqual(opened.json.data.identifiers, { session: "expo-explore-runtime", appBundleId: BUNDLE, deviceName: "iPhone 17", deviceId: UDID });
assert.deepEqual(calls.filter(call => call.tool === "restart-app").map(call => call.args), [{ udid: UDID, bundleId: BUNDLE }]);
});
test("open fails clearly when the app never shows a tree", async () => {
const empty = { ...IOS_HOME, roots: [] };
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "restart-app": {}, "ui-tree": empty });
const opened = await run(["open", BUNDLE, ...flags("ios")]);
assert.equal(opened.exitCode, 1);
assert.equal(opened.json.error.code, "APP_NOT_READY");
assert.equal(calls.filter(call => call.tool === "restart-app").length, 2);
});
test("a session with no single booted device is refused", async () => {
const none = { devices: IOS_DEVICES.devices.map(device => ({ ...device, state: "Shutdown" })) };
const { run } = harness("ios", { "list-devices": none });
const result = await run(["snapshot", ...flags("ios")]);
assert.equal(result.json.error.code, "DEVICE_UNAVAILABLE");
});
test("the first iOS deep link accepts the Open prompt once; later links open directly", async () => {
// iOS 26.5 flags the prompt as an alert; its text is what identifies it as the link prompt.
const prompt = { ...IOS_HOME, alertVisible: true, foregroundApp: "com.apple.springboard",
roots: [...IOS_HOME.roots, { type: "Alert", label: "Open in “euxy”?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [] }] };
const { run, calls, context } = harness("ios", { "list-devices": IOS_DEVICES, "open-url": {}, "gesture-tap": {}, "ui-tree": [prompt, IOS_HOME] });
const first = await run(["open", BUNDLE, "euxy://settings", ...flags("ios")]);
assert.equal(first.exitCode, 0);
const tap = calls.find(call => call.tool === "gesture-tap");
assert.ok(Math.abs(tap.args.x - (0.5 + 74 / 402)) < 1e-9 && Math.abs(tap.args.y - (0.5 + 37 / 874)) < 1e-9);
assert.equal(context.state.deepLinkPromptAccepted, true);
const before = calls.length;
assert.equal((await run(["open", "euxy://patterns", ...flags("ios")])).exitCode, 0);
assert.deepEqual(calls.slice(before).map(call => call.tool), ["open-url"]);
});
test("iOS fill taps the field, erases its text with backspaces, types, and checks the result", async () => {
const field = flatten(IOS_RENAME).find(node => node.type === "TextField" && node.frame);
assert.ok(field, "the rename fixture has a text field");
const typed = structuredClone(IOS_RENAME);
flatten(typed).find(node => node.type === "TextField" && node.frame).value = "Groove";
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": [IOS_RENAME, typed], "gesture-tap": {}, "run-sequence": {}, keyboard: {} });
const snapshot = await run(["snapshot", ...flags("ios")]);
const node = snapshot.json.data.nodes.find(item => item.type === "TextField");
const filled = await run(["fill", node.ref, ...flags("ios"), "--", "Groove"]);
assert.equal(filled.exitCode, 0, filled.stdout);
const tools = calls.slice(2).map(call => call.tool);
assert.equal(tools[0], "gesture-tap");
const erase = (field.value ?? "").length;
if (erase) {
const sequence = calls.find(call => call.tool === "run-sequence");
assert.equal(sequence.args.steps.length, erase);
assert.deepEqual(sequence.args.steps[0], { tool: "keyboard", args: { udid: UDID, key: "backspace" } });
}
assert.deepEqual(calls.find(call => call.tool === "keyboard").args, { udid: UDID, text: "Groove" });
assert.ok(!calls.some(call => call.tool === "fill"), "Argent's iOS fill is not used");
});
test("Android fill uses Argent's fill and requires it to verify the text", async () => {
const { run, calls } = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": ANDROID_RENAME, "gesture-tap": {}, fill: [{ verified: true }, { verified: false }] });
const snapshot = await run(["snapshot", ...flags("android")]);
const node = snapshot.json.data.nodes.find(item => item.type === "TextField");
assert.ok(node, "the rename fixture has an EditText");
assert.equal((await run(["fill", node.ref, ...flags("android"), "--", "Groove"])).exitCode, 0);
assert.deepEqual(calls.find(call => call.tool === "fill").args, { udid: "emulator-5554", text: "Groove" });
const unverified = await run(["fill", node.ref, ...flags("android"), "--", "Groove"]);
assert.equal(unverified.exitCode, 1);
});
test("text with a {{secret:…}} placeholder never reaches Argent", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, keyboard: {} });
const typed = await run(["type", ...flags("ios"), "--", "{{secret:PASSWORD}}"]);
assert.equal(typed.json.error.code, "INVALID_ARGS");
assert.ok(!calls.some(call => call.tool === "keyboard"));
});
test("keyboard dismiss matches agent-device: Android presses back; iOS taps a dismiss key or reports it could not", async () => {
const android = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": [{ ...ANDROID_RENAME, keyboardVisible: true }, { ...ANDROID_RENAME, keyboardVisible: false }], button: {} });
const dismissed = await android.run(["keyboard", "dismiss", ...flags("android")]);
assert.deepEqual(dismissed.json.data, { platform: "android", action: "dismiss", wasVisible: true, dismissed: true, visible: false });
assert.deepEqual(android.calls.find(call => call.tool === "button").args, { udid: "emulator-5554", button: "back" });
// agent-device fails with this message when the keyboard has no dismiss key, and callers fall back to the return key.
const noKey = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": { ...IOS_HOME, keyboardVisible: true } });
const failed = await noKey.run(["keyboard", "dismiss", ...flags("ios")]);
assert.equal(failed.exitCode, 1);
assert.match(failed.json.error.message, /^Unable to dismiss the iOS keyboard/);
const hidden = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME });
assert.equal((await hidden.run(["keyboard", "dismiss", ...flags("ios")])).json.data.wasVisible, false);
});
test("iOS back with no navigation bar back control fails with agent-device's message", async () => {
const { run } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME });
const back = await run(["back", ...flags("ios")]);
assert.equal(back.exitCode, 1);
assert.equal(back.json.error.message, "in-app back control is not available");
});
test("alerts read and answer in each platform's agent-device shape", async () => {
const noAlert = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME });
assert.equal((await noAlert.run(["alert", "get", ...flags("ios")])).json.error.message, "alert not found");
const androidNone = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": ANDROID_HOME });
assert.deepEqual((await androidNone.run(["alert", "get", ...flags("android")])).json.data, { platform: "android", alert: null });
const alertTree = { ...IOS_HOME, alertVisible: true, roots: [{ type: "Alert", label: "Allow?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [
{ type: "StaticText", label: "Allow notifications?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.05 } },
{ type: "Button", label: "Don’t Allow", frame: { x: 0.1, y: 0.55, width: 0.4, height: 0.05 } },
{ type: "Button", label: "Allow", frame: { x: 0.5, y: 0.55, width: 0.4, height: 0.05 } }] }] };
const ios = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": [alertTree, alertTree, IOS_HOME], "gesture-tap": {} });
assert.deepEqual((await ios.run(["alert", "get", ...flags("ios")])).json.data, { message: "Allow notifications?", items: ["Don’t Allow", "Allow"] });
const accepted = await ios.run(["alert", "accept", ...flags("ios")]);
assert.deepEqual(accepted.json.data, { action: "accept", button: "Allow" });
const tap = ios.calls.find(call => call.tool === "gesture-tap");
assert.ok(Math.abs(tap.args.x - 0.7) < 1e-9 && Math.abs(tap.args.y - 0.575) < 1e-9);
});
test("screenshots download at full resolution to the requested path", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, screenshot: {} });
assert.deepEqual((await run(["screenshot", "/tmp/out.png", ...flags("ios")])).json.data, { path: "/tmp/out.png" });
assert.deepEqual(calls.at(-1), { tool: "screenshot", args: { udid: UDID, scale: 1 }, options: { out: "/tmp/out.png" } });
});
test("a recording is moved from where the Argent client downloaded it to the path Explore asked for", async () => {
const { run, moves, context } = harness("android", { "list-devices": ANDROID_DEVICES, "screen-recording-start": {}, "screen-recording-stop": { video: "/home/.argent/recordings/r.mp4", durationMs: 4200 } });
assert.equal((await run(["record", "start", "/work/launch.mp4", ...flags("android")])).exitCode, 0);
assert.equal(context.state.recording, "/work/launch.mp4");
const stopped = await run(["record", "stop", ...flags("android")]);
assert.deepEqual(stopped.json.data, { outPath: "/work/launch.mp4", durationMs: 4200 });
assert.deepEqual(moves, [["/home/.argent/recordings/r.mp4", "/work/launch.mp4"]]);
assert.equal(context.state.recording, undefined);
});
test("install reinstalls the archive under the bundle id the caller names", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "reinstall-app": {} }, { bundleId: BUNDLE });
assert.deepEqual((await run(["install", "/work/bundle/euxy.app", ...flags("ios")])).json.data, { installed: true, appBundleId: BUNDLE });
assert.deepEqual(calls.at(-1).args, { udid: UDID, bundleId: BUNDLE, appPath: "/work/bundle/euxy.app" });
const missing = harness("ios", { "list-devices": IOS_DEVICES, "reinstall-app": {} });
assert.equal((await missing.run(["install", "/work/a.app", ...flags("ios")])).json.error.code, "INVALID_ARGS");
});
test("appearance and logs are reported as unsupported, not silently ignored", async () => {
const { run } = harness("ios", {});
assert.equal((await run(["settings", "appearance", "dark", ...flags("ios")])).json.error.code, "CONTROLLER_UNSUPPORTED");
assert.equal((await run(["logs", "path", ...flags("ios")])).json.error.code, "CONTROLLER_UNSUPPORTED");
});
test("a tool-server that is still starting is waited for before the action is sent", async () => {
const { run, calls, context } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-tap": {} });
const answers = [false, false, false, true];
context.reachable = async () => answers.shift() ?? true;
assert.equal((await run(["press", "10", "10", ...flags("ios")])).exitCode, 0);
assert.equal(calls.filter(call => call.tool === "gesture-tap").length, 1);
});
test("an unreachable tool-server before a UI action is the retryable 'Remote daemon is unavailable'", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-tap": {} }, { reachable: false });
const pressed = await run(["press", "10", "10", ...flags("ios")]);
assert.deepEqual(pressed.json.error, { code: "COMMAND_FAILED", message: "Remote daemon is unavailable" });
assert.ok(!calls.some(call => call.tool === "gesture-tap"));
});
test("a UI action whose answer is lost is reported once and never retried", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-tap": new ArgentCallError("argent run gesture-tap failed: socket hang up", true) });
const pressed = await run(["press", "10", "10", ...flags("ios")]);
assert.equal(pressed.json.error.code, "ARGENT_TOOL_FAILED");
assert.notEqual(pressed.json.error.message, "Remote daemon is unavailable");
assert.equal(calls.filter(call => call.tool === "gesture-tap").length, 1);
});
test("reads are retried after a transport failure", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": [new ArgentCallError("timeout", true), IOS_HOME] });
assert.equal((await run(["snapshot", ...flags("ios")])).exitCode, 0);
assert.equal(calls.filter(call => call.tool === "ui-tree").length, 2);
});
test("wait stable maps to await-screen-idle", async () => {
const { run, calls } = harness("android", { "list-devices": ANDROID_DEVICES, "await-screen-idle": { settled: true } });
assert.deepEqual((await run(["wait", "stable", "700", "5000", ...flags("android")])).json.data, { stable: true });
assert.deepEqual(calls.at(-1).args, { udid: "emulator-5554", minStableMs: 700, timeoutMs: 5000 });
});
test("iOS 27.1's link prompt is recognized by its text when Argent does not flag it as an alert", () => {
assert.equal(DUO_PROMPT.alertVisible, false);
assert.equal(openInAppPromptShowing(DUO_PROMPT), true);
assert.equal(openInAppPromptShowing(DUO_HOME), false);
assert.equal(openInAppPromptShowing(IOS_HOME), false);
});
test("describe locates the prompt's Open button where it is on screen", () => {
assert.deepEqual(describedButton(DUO_PROMPT_DESCRIBE.description, "Open"), { x: 0.418, y: 0.473, width: 0.3, height: 0.071 });
assert.equal(describedButton(DUO_PROMPT_DESCRIBE.description, "Allow"), undefined);
assert.equal(describedButton(undefined, "Open"), undefined);
});
test("on iPhone Duo the first link taps Open where describe puts it, not at iPhone 17's offset", async () => {
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "open-url": {}, "gesture-tap": {}, describe: DUO_PROMPT_DESCRIBE, "ui-tree": [DUO_PROMPT, DUO_HOME] });
const opened = await run(["open", "dev.brent.euxy", "euxy://", ...flags("ios")]);
assert.equal(opened.exitCode, 0, opened.stdout);
const tap = calls.find(call => call.tool === "gesture-tap");
assert.ok(Math.abs(tap.args.x - (0.418 + 0.15)) < 1e-9 && Math.abs(tap.args.y - (0.473 + 0.0355)) < 1e-9, JSON.stringify(tap.args));
assert.equal(context.state.deepLinkPromptAccepted, true);
});
test("a snapshot taken while iOS 27.1's link prompt is up reports it as an alert", async () => {
const { run } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": DUO_PROMPT });
const snapshot = await run(["snapshot", ...flags("ios")]);
assert.ok(snapshot.json.data.nodes.some(node => node.type === "Alert"));
});
test("a tool-server that lists no devices on its first call is asked again", async () => {
const { run, calls, context } = harness("ios", { "list-devices": [{ devices: [], avds: [] }, DUO_DEVICES], "ui-tree": DUO_HOME });
assert.equal((await run(["snapshot", ...flags("ios")])).exitCode, 0);
assert.equal(calls.filter(call => call.tool === "list-devices").length, 2);
assert.equal(context.state.model, "iPhone Duo");
assert.equal(context.state.osVersion, "27.1");
});
test("alert get and accept read iOS 27.1's link prompt and press Open where describe puts it", async () => {
const { run, calls } = harness("ios", { "list-devices": DUO_DEVICES, "gesture-tap": {}, describe: DUO_PROMPT_DESCRIBE, "ui-tree": [DUO_PROMPT, DUO_PROMPT, DUO_HOME] });
const read = await run(["alert", "get", ...flags("ios")]);
assert.deepEqual(read.json.data, { message: "Open in “euxy”?", items: ["Cancel", "Open"] });
const accepted = await run(["alert", "accept", ...flags("ios")]);
assert.deepEqual(accepted.json.data, { action: "accept", button: "Open" });
const tap = calls.find(call => call.tool === "gesture-tap");
assert.ok(Math.abs(tap.args.x - 0.568) < 1e-9 && Math.abs(tap.args.y - 0.5085) < 1e-9, JSON.stringify(tap.args));
});
const image = name => PNG.sync.read(readFileSync(new URL(`../fixtures/argent-0.29/${name}`, import.meta.url)));
const near = (actual, expected, tolerance = 0.02) => Math.abs(actual - expected) <= tolerance;
test("the link prompt's Open button is found in iOS 26 and iOS 27.1 screenshots", () => {
// iPhone Duo: describe puts Open at (0.418, 0.473, 0.3 × 0.071).
const duo = findOpenButton(image("screenshot-ios27-duo-open-prompt.png"));
assert.ok(duo && near(duo.x, 0.568) && near(duo.y, 0.5085), JSON.stringify(duo));
const iphone17 = findOpenButton(image("screenshot-ios26-iphone17-open-prompt.png"));
assert.ok(iphone17 && iphone17.x > 0.5 && iphone17.x < 0.85 && iphone17.y > 0.48 && iphone17.y < 0.6, JSON.stringify(iphone17));
});
test("no Open button is found without the prompt, even with a blue key on screen", () => {
assert.equal(findOpenButton(image("screenshot-ios27-duo-no-prompt-small.png")), undefined);
assert.equal(findOpenButton(image("screenshot-ios26-keyboard.png")), undefined);
});
test("when Argent reads nothing while the prompt is up, Open is tapped from a screenshot", async () => {
const blind = { schemaVersion: 1, source: "ax-service", screen: { width: 466, height: 678 }, roots: [{ role: "AXGroup", children: [] }], truncated: false, alertVisible: false };
const frames = [image("screenshot-ios27-duo-open-prompt.png"), image("screenshot-ios27-duo-no-prompt-small.png")];
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "open-url": {}, "gesture-tap": {}, screenshot: {}, "ui-tree": blind });
context.scratchImage = { path: "/work/argent-scratch.png", read: async () => frames.shift() };
const opened = await run(["open", "dev.brent.euxy", "euxy://", ...flags("ios")]);
assert.equal(opened.exitCode, 0, opened.stdout);
const tap = calls.find(call => call.tool === "gesture-tap");
assert.ok(near(tap.args.x, 0.568) && near(tap.args.y, 0.5085), JSON.stringify(tap.args));
assert.deepEqual(calls.filter(call => call.tool === "screenshot").map(call => call.options), [{ out: "/work/argent-scratch.png" }, { out: "/work/argent-scratch.png" }]);
assert.equal(context.state.deepLinkPromptAccepted, true);
});
test("fold moves a foldable to a pose and forgets the old panel's geometry", async () => {
// Argent's fold answers with the panel it lit, in pixels; the inner panel is 2007 × 2853 (669 × 951 points).
const { run, calls, context } = harness("ios", { "list-devices": DUO_DEVICES, "ui-tree": [DUO_HOME, DUO_OPEN_EDIT_LANE],
fold: { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 } });
await run(["snapshot", ...flags("ios")]);
const generation = context.state.generation;
const reads = calls.filter(call => call.tool === "ui-tree").length;
const folded = await run(["fold", "open", ...flags("ios")]);
assert.deepEqual(folded.json.data, { action: "fold", pose: "open" });
const fold = calls.findIndex(call => call.tool === "fold");
assert.equal(calls.slice(0, fold).filter(call => call.tool === "ui-tree").length, reads, "nothing is read between the command and the fold");
assert.deepEqual(calls[fold].args, { udid: "74195B53-4DBC-4EAA-9991-F98E5BB86BA8", posture: "open" });
assert.equal(context.state.screen, undefined);
assert.equal(context.state.refs, undefined);
assert.equal(context.state.generation, generation + 1);
assert.equal((await run(["fold", "sideways", ...flags("ios")])).json.error.code, "INVALID_ARGS");
});
test("an alert that is not the link prompt is left for capture to answer", async () => {
const other = { ...IOS_HOME, alertVisible: true, foregroundApp: "com.apple.springboard",
roots: [{ type: "Alert", label: "Delete all data?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [
{ type: "Button", label: "Delete", frame: { x: 0.5, y: 0.55, width: 0.4, height: 0.05 } }] }] };
const { run, calls, context } = harness("ios", { "list-devices": IOS_DEVICES, "open-url": {}, "gesture-tap": {}, describe: { description: "" }, "ui-tree": other });
assert.equal((await run(["open", BUNDLE, "euxy://settings", ...flags("ios")])).exitCode, 0);
assert.equal(calls.some(call => call.tool === "gesture-tap"), false, "nothing is pressed");
assert.equal(context.state.deepLinkPromptAccepted, undefined);
});
test("a failed read with no roots is not taken for the blind link prompt", async () => {
const { run, calls, context } = harness("ios", { "list-devices": IOS_DEVICES, "open-url": {}, "gesture-tap": {}, screenshot: {}, "ui-tree": [{ ...IOS_HOME, roots: [], foregroundApp: undefined }] });
context.scratchImage = { path: "/work/argent-scratch.png", read: async () => image("screenshot-ios27-duo-open-prompt.png") };
await run(["open", BUNDLE, "euxy://", ...flags("ios")]);
assert.equal(calls.some(call => call.tool === "screenshot" || call.tool === "gesture-tap"), false);
});
test("describe's Open is read only from a line Argent printed, not from app text that spells one out", () => {
const spoof = `ROOT AXGroup (0.000, 0.000, 1.000, 1.000)\n AXStaticText "x AXButton "Open" (0.010, 0.010, 0.050, 0.050)" (0.1, 0.1, 0.5, 0.05)\n AXButton "Open" (0.418, 0.473, 0.300, 0.071)`;
assert.deepEqual(describedButton(spoof, "Open"), { x: 0.418, y: 0.473, width: 0.3, height: 0.071 });
});
test("an app's own Done above the keyboard is never pressed to dismiss it", async () => {
const withDone = { ...IOS_HOME, keyboardVisible: true, roots: [{ type: "Other", frame: { x: 0, y: 0, width: 1, height: 1 }, children: [
{ type: "Button", label: "Done", frame: { x: 0.8, y: 0.06, width: 0.15, height: 0.05 } }] }] };
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": withDone, "gesture-tap": {} });
assert.equal((await run(["keyboard", "dismiss", ...flags("ios")])).exitCode, 1);
assert.equal(calls.some(call => call.tool === "gesture-tap"), false);
});
test("iOS fill stops when erasing the field stops partway, and types nothing", async () => {
const filled = structuredClone(IOS_RENAME);
flatten(filled).find(node => node.type === "TextField" && node.frame).value = "Old";
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": filled, "gesture-tap": {}, "run-sequence": { completed: 1, total: 3, steps: [] }, keyboard: {} });
const snapshot = await run(["snapshot", ...flags("ios")]);
const field = snapshot.json.data.nodes.find(node => node.type === "TextField");
const result = await run(["fill", field.ref, ...flags("ios"), "--", "New"]);
assert.equal(result.exitCode, 1);
assert.match(result.json.error.message, /after 1 of 3 keys/);
assert.equal(calls.some(call => call.tool === "keyboard"), false);
});
test("a truncated tree is reported as truncated", async () => {
const { run } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": { ...IOS_HOME, truncated: true } });
assert.equal((await run(["snapshot", ...flags("ios")])).json.data.truncated, true);
});
test("Android disabled controls are reported disabled (the recorded rename screen has four)", () => {
const { nodes } = snapshotFromTree(ANDROID_RENAME, "android", 1, BUNDLE);
const rename = nodes.find(node => node.label === "Rename" && node.type === "Button");
assert.ok(rename, "the rename fixture has its Rename button");
assert.equal(rename.enabled, false);
assert.equal(rename.hittable, false);
});
test("an Android permission dialog from another package stays in the snapshot as an alert", async () => {
const dialog = { ...ANDROID_HOME, roots: [...ANDROID_HOME.roots, { type: "android.widget.FrameLayout", bundleId: "com.google.android.permissioncontroller",
frame: { x: 0.1, y: 0.35, width: 0.8, height: 0.3 }, children: [
{ type: "android.widget.TextView", label: "Allow euxy to send you notifications?", frame: { x: 0.15, y: 0.4, width: 0.7, height: 0.05 } },
{ type: "android.widget.Button", label: "Allow", frame: { x: 0.15, y: 0.55, width: 0.7, height: 0.05 } }] }] };
const { run } = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": dialog });
const snapshot = (await run(["snapshot", ...flags("android")])).json.data;
assert.ok(snapshot.nodes.some(node => node.type === "Button" && node.label === "Allow"), "the dialog's buttons can be found");
assert.ok(snapshot.nodes.some(node => node.type === "Alert"), "capture sees an alert covering the app");
assert.ok(!snapshot.nodes.some(node => /systemui/.test(JSON.stringify(node))), "the system UI is still left out");
assert.deepEqual((await run(["alert", "get", ...flags("android")])).json.data.alert.buttons, ["Allow"]);
});
test("system back swipes from the iOS edge; Android prefers an in-app back control", async () => {
const ios = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "gesture-swipe": {} });
assert.equal((await ios.run(["back", "--system", ...flags("ios")])).exitCode, 0);
assert.deepEqual(ios.calls.at(-1).args, { udid: UDID, fromX: 0.05, fromY: 0.5, toX: 0.8, toY: 0.5, momentum: false });
const up = { ...ANDROID_HOME, roots: [...ANDROID_HOME.roots.filter(root => root.bundleId !== BUNDLE), { type: "android.widget.FrameLayout", bundleId: BUNDLE,
frame: { x: 0, y: 0, width: 1, height: 1 }, children: [{ type: "android.widget.ImageButton", contentDescription: "Navigate up", frame: { x: 0, y: 0.05, width: 0.1, height: 0.05 } }] }] };
const android = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": up, "gesture-tap": {}, button: {} });
assert.deepEqual((await android.run(["back", "--in-app", ...flags("android")])).json.data, { action: "back", mode: "in-app" });
assert.equal(android.calls.some(call => call.tool === "button"), false);
const none = harness("android", { "list-devices": ANDROID_DEVICES, "ui-tree": ANDROID_HOME, button: {} });
assert.equal((await none.run(["back", "--in-app", ...flags("android")])).json.error.message, "in-app back control is not available");
assert.deepEqual((await none.run(["back", ...flags("android")])).json.data, { action: "back", mode: "system" });
});
test("open without --relaunch keeps a running app as it is", async () => {
const { run, calls } = harness("ios", { "list-devices": IOS_DEVICES, "ui-tree": IOS_HOME, "restart-app": {} });
assert.equal((await run(["open", BUNDLE, ...flags("ios")])).exitCode, 0);
assert.equal(calls.some(call => call.tool === "restart-app"), false);
});
test("a link prompt that lingers a moment after Open is pressed is not a failure", async () => {
const prompt = { ...IOS_HOME, alertVisible: true, foregroundApp: "com.apple.springboard",
roots: [...IOS_HOME.roots, { type: "Alert", label: "Open in “euxy”?", frame: { x: 0.1, y: 0.4, width: 0.8, height: 0.2 }, children: [] }] };
// Read once before the press, twice more while the app comes forward, then the app.
const { run, context } = harness("ios", { "list-devices": IOS_DEVICES, "open-url": {}, "gesture-tap": {}, describe: { description: "" }, "ui-tree": [prompt, prompt, prompt, IOS_HOME] });
assert.equal((await run(["open", BUNDLE, "euxy://", ...flags("ios")])).exitCode, 0);
assert.equal(context.state.deepLinkPromptAccepted, true);
});
test("on iPhone Duo's inner display, a sheet's title outside Argent's shrunken root frame is visible", () => {
assert.deepEqual(DUO_OPEN_EDIT_LANE.roots[0].frame, { x: 0, y: 0, width: 0.3333333333333333, height: 0.3333333333333333 }, "the recorded Argent quirk");
const { nodes } = snapshotFromTree(DUO_OPEN_EDIT_LANE, "ios", 1, BUNDLE);
for (const label of ["Edit Lane", "Cancel", "Done"]) {
const node = nodes.find(item => item.label === label);
assert.ok(node, label);
assert.notEqual(node.visible, false, `${label} is visible`);
}
});
test("a node its ancestor clips away is still reported hidden on iOS", () => {
const clipped = { screen: { width: 400, height: 800 }, foregroundApp: BUNDLE, roots: [{ type: "Application", frame: { x: 0, y: 0, width: 1, height: 1 }, children: [
{ type: "ScrollView", frame: { x: 0, y: 0, width: 1, height: 0.5 }, children: [
{ type: "Button", label: "In view", frame: { x: 0.1, y: 0.1, width: 0.3, height: 0.05 } },
{ type: "Button", label: "Scrolled away", frame: { x: 0.1, y: 0.7, width: 0.3, height: 0.05 } }] }] }] };
const { nodes } = snapshotFromTree(clipped, "ios", 1, BUNDLE);
assert.notEqual(nodes.find(node => node.label === "In view").visible, false);
assert.equal(nodes.find(node => node.label === "Scrolled away").visible, false);
});
test("a fold whose panel Argent never reads fails clearly instead of capturing the dark panel", async () => {
const lit = { activeScreen: 3, screen: { id: 3, panel: "inner panel", width: 2007, height: 2853 }, posture: "open", hingeAngle: 180 };
const blindClosed = { ...DUO_HOME, foregroundApp: undefined, roots: [{ role: "AXGroup", children: [] }] };
const late = harness("ios", { "list-devices": DUO_DEVICES, fold: lit, "ui-tree": [blindClosed, blindClosed, DUO_OPEN_EDIT_LANE] });
assert.equal((await late.run(["fold", "open", ...flags("ios")])).exitCode, 0, "a reader that catches up within the wait is fine");
const stuck = harness("ios", { "list-devices": DUO_DEVICES, fold: lit, "ui-tree": blindClosed });
const failed = await stuck.run(["fold", "open", ...flags("ios")]);
assert.equal(failed.json.error.code, "CONTROLLER_FOLD_UNVERIFIED");
assert.equal(stuck.calls.filter(call => call.tool === "fold").length, 1, "the session is not folded back and forth");
});
test("an opened foldable's screenshots are captured upright and its recordings handed to be turned; others are left as Argent saves them", async () => {
const replies = { "list-devices": IOS_DEVICES, screenshot: {}, "screen-recording-start": {}, "screen-recording-stop": { video: "/home/.argent/recordings/r.mp4" } };
for (const landscape of [true, false]) {
const { run, context, calls } = harness("ios", replies, { state: { generation: 0, screen: { width: 669, height: 951 } } });
// Argent reads the opened panel on its portrait axes, like the closed one: only the pose tells them apart.
if (landscape) context.landscape = true;
const oriented = [];
context.orientVideo = async path => { oriented.push(path); };
assert.equal((await run(["screenshot", "/work/screen.png", ...flags("ios")])).exitCode, 0);
await run(["record", "start", "/work/launch.mp4", ...flags("ios")]);
await run(["record", "stop", ...flags("ios")]);
assert.deepEqual(calls.find(call => call.tool === "screenshot").args, { udid: UDID, scale: 1, ...(landscape ? { rotation: "LandscapeRight" } : {}) });
assert.deepEqual(oriented, landscape ? ["/work/launch.mp4"] : []);
}
});
+5 -5
View File
@@ -14,7 +14,7 @@ test("report publishes one normal ZIP artifact to the hosted Viewer", () => {
assert.ok(packageIndex > 0 && uploadIndex > packageIndex && publishIndex > uploadIndex);
assert.match(report.steps[packageIndex].run, /ci:report --input/);
const upload = report.steps[uploadIndex];
assert.equal(upload.with.name, "explore-review-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}");
assert.equal(upload.with.name, "explore-review-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}");
assert.equal(upload.with.path, "${{ runner.temp }}/explore-report");
assert.equal(upload.with.archive, undefined);
assert.equal(upload.with["retention-days"], 30);
@@ -46,7 +46,7 @@ test("report job persists its own diagnostics even when packaging or publication
assert.equal(step.if, "always()");
assert.equal(step.with.path, "${{ runner.temp }}/explore-diagnostics");
assert.equal(step.with["retention-days"], 7);
assert.equal(step.with.name, "explore-report-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.platform }}");
assert.equal(step.with.name, "explore-report-diagnostics-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.target }}");
});
test("failure reporting downloads only this run attempt's failed-job diagnostics", () => {
@@ -65,10 +65,10 @@ test("failure reporting downloads only this run attempt's failed-job diagnostics
assert.equal(step.with.repository, undefined);
}
// A capture job that fails before it resolves the PR (its tool install, say) still gets its failure comment:
// the platforms job already resolved and authorized the same PR.
// the targets job already resolved and authorized the same PR.
const report = job.steps.find(step => step.name === "Report failure only on the current PR");
for (const [env, output] of [["PR_NUMBER", "pr_number"], ["HEAD_SHA", "head"], ["BASE_SHA", "base"]]) {
assert.equal(report.env[env], `\${{ needs.capture.outputs.${output} || needs.platforms.outputs.${output} }}`);
assert.equal(workflow.jobs.platforms.outputs[output], `\${{ steps.pr.outputs.${output} }}`);
assert.equal(report.env[env], `\${{ needs.capture.outputs.${output} || needs.targets.outputs.${output} }}`);
assert.equal(workflow.jobs.targets.outputs[output], `\${{ steps.pr.outputs.${output} }}`);
}
});
+24
View File
@@ -101,3 +101,27 @@ test("attached sessions are proven live, agent-device typed, and served by the g
await assert.rejects(resolveAttachedSimulatorSession({}, undefined), /EAS_SIMULATOR_SESSION_ID did not return a session id/);
await assert.rejects(resolveAttachedSimulatorSession({ ...env, AGENT_DEVICE_DAEMON_AUTH_TOKEN: "" }, undefined), /unsafe agent-device connection/);
});
test("an attached argent session is found from ARGENT_* and proven against the session's tool-server", async () => {
const { assertAttachedSimulatorSession, readSimulatorDotenvHandoff, resolveAttachedSimulatorSession } = await import(join(root, "dist", "capture", "simulator.js"));
const connection = { sessionId: "01a1-mine", daemonBaseUrl: "https://tools.example.eas.dev", daemonAuthToken: "secret", controller: "argent" };
const env = { EAS_SIMULATOR_SESSION_ID: "01a1-mine", ARGENT_TOOLS_URL: connection.daemonBaseUrl, ARGENT_AUTH_TOKEN: "secret" };
assert.deepEqual(await resolveAttachedSimulatorSession(env, undefined), connection);
// A tool-server that needs no token is still an argent session.
assert.deepEqual(await resolveAttachedSimulatorSession({ ...env, ARGENT_AUTH_TOKEN: undefined }, undefined), { ...connection, daemonAuthToken: "" });
await assert.rejects(resolveAttachedSimulatorSession({ ...env, ARGENT_TOOLS_URL: "http://tools.example.eas.dev" }, undefined), /unsafe argent/);
const session = (overrides = {}) => JSON.stringify({ id: "01a1-mine", name: "mine", type: "argent", status: "IN_PROGRESS", platform: "ANDROID",
remoteConfig: { toolsUrl: connection.daemonBaseUrl, toolsAuthToken: "secret" }, ...overrides });
assert.equal(assertAttachedSimulatorSession(session(), connection).platform, "android");
assert.throws(() => assertAttachedSimulatorSession(session({ type: "agent-device" }), connection), /attached argent session/);
assert.throws(() => assertAttachedSimulatorSession(session({ remoteConfig: { toolsUrl: connection.daemonBaseUrl, toolsAuthToken: "other" } }), connection), /different argent connection/);
const dir = await mkdtemp(join(tmpdir(), "explore-argent-dotenv-"));
try {
const path = join(dir, ".env.eas-simulator");
await writeFile(path, "# Do not commit this file.\n# Do not modify these values manually. They are managed by eas-cli.\n# It holds configuration only for the current simulator session.\n\nEAS_SIMULATOR_SESSION_ID='01a1-mine'\nARGENT_TOOLS_URL='https://tools.example.eas.dev'\nARGENT_AUTH_TOKEN='secret'\n");
const handoff = await readSimulatorDotenvHandoff(path);
assert.equal(handoff.validationError, undefined);
assert.deepEqual(handoff.connection, connection);
assert.deepEqual(await resolveAttachedSimulatorSession({}, path), connection);
} finally { await rm(dir, { recursive: true, force: true }); }
});
+10
View File
@@ -88,3 +88,13 @@ test("a route the primary pass lost keeps its verified secondary frame under <id
assert.equal(merged["q@dark"], undefined, "two failures stay one failure");
assert.equal(Object.keys(mergeSchemeOutcomes([{ p: failed }, { p: captured }]))["p@dark"], undefined, "no scheme list, no secondary slot");
});
test("a note on a verified frame of another appearance stays with the route its primary frame is published under", () => {
const captured = { status: "captured", attempts: 1, landing: "verified", screenshotSha256: "a".repeat(64) };
const incomplete = "Setup did not complete: a setup step stopped twice (RUNNER_WEDGED), so this route was opened by app link without the state the remaining setup steps prepare.";
const merged = mergeSchemeOutcomes([{ p: captured, q: { ...captured, reason: "Already noted." } }, { p: { ...captured, reason: incomplete }, q: captured }], ["light", "dark"]);
assert.equal(merged.p.reason, `In dark: ${incomplete}`);
assert.equal(merged.p.status, "captured");
assert.equal(merged.q.reason, "Already noted.", "a pass without a note adds none");
assert.equal(merged["p@dark"], undefined, "the dark frame is still published under the route, as before");
});
@@ -135,6 +135,15 @@ test("capture recipes exclude display settings but bind agent instructions and c
assert.equal(JSON.parse(key).observer, CAPTURE_OBSERVER_HASH);
assert.match(JSON.parse(key).observer, /^[a-f0-9]{64}$/);
assert.equal(key,captureRecipeConfig({...config,app:{...config.app,name:"Renamed display"}}));
// An unset repack is keyed as it resolves, so configs that never chose one keep the recipe of the old written-out default.
assert.equal(key,captureRecipeConfig({...config,capture:{...config.capture,repack:"eas"}}));
assert.equal(JSON.parse(key).capture.repack, "eas");
assert.equal(JSON.parse(captureRecipeConfig({...config,capture:{...config.capture,simulator:"local"}})).capture.repack, "local");
// agent-device recipes are unchanged by Argent support; an Argent capture is keyed to Argent and its version.
assert.equal(JSON.parse(key).controllerVersion, undefined);
const argent = JSON.parse(captureRecipeConfig({...config,capture:{...config.capture,controller:"argent"}}));
assert.equal(argent.capture.controller, "argent");
assert.match(argent.controllerVersion, /^\d+\.\d+\.\d+$/);
const agent = {...config,mode:"agent",agent:{provider:"openai",model:"another-model",instructions:".expo-explore/instructions.md"}};
assert.notEqual(key,captureRecipeConfig(agent,"a".repeat(64)));
assert.equal(JSON.parse(captureRecipeConfig(agent,"a".repeat(64))).agent.acceptancePolicy, AGENT_ACCEPTANCE_POLICY);
+38 -10
View File
@@ -2,16 +2,44 @@ import assert from "node:assert/strict";
import test from "node:test";
const { tsImport } = await import("tsx/esm/api");
const { isVisibleChange } = await tsImport("../../viewer/src/utils/changed-screens.ts", import.meta.url);
const { isCapturedChange } = await tsImport("../../viewer/src/utils/changed-screens.ts", import.meta.url);
test("only a change the captures show counts for Compare and Screens' Changed filter", () => {
assert.equal(isVisibleChange({ status: "added" }), true);
assert.equal(isVisibleChange({ status: "removed" }), true);
assert.equal(isVisibleChange({ status: "modified" }), true);
// The source changed but the captures look the same.
assert.equal(isVisibleChange({ status: "modified", notVisible: true }), false);
assert.equal(isVisibleChange({ status: "needs-review" }), false);
assert.equal(isVisibleChange({ status: "source-affected" }), false);
assert.equal(isVisibleChange({ status: "unchanged" }), false);
assert.equal(isVisibleChange(undefined), false);
assert.equal(isCapturedChange({ status: "added" }), true);
assert.equal(isCapturedChange({ status: "removed" }), true);
assert.equal(isCapturedChange({ status: "modified" }), true);
// The screenshots match but the accessibility tree changed: screen readers see it, so it is reviewed.
assert.equal(isCapturedChange({ status: "modified", accessibilityOnly: true }), true);
// The source changed but the captures show nothing different.
assert.equal(isCapturedChange({ status: "needs-review" }), false);
assert.equal(isCapturedChange({ status: "source-affected" }), false);
assert.equal(isCapturedChange({ status: "unchanged" }), false);
assert.equal(isCapturedChange(undefined), false);
});
const { splitForAssistiveTechnology } = await tsImport("../../viewer/src/utils/presented-changes.ts", import.meta.url);
test("What changed lists what assistive technology reads under its own heading", () => {
const change = (id, category) => ({ id, copy: id, fact: { id, category, templateId: `${category}.x`, priority: 0, evidenceRefs: [] } });
const changes = [change("Added button “Play”.", "element"), change("Changed accessibility label.", "accessibility")];
const ids = ({ visible, assistive }) => [visible.map(entry => entry.id), assistive.map(entry => entry.id)];
// Pixels differ: an added element may be visible, a label is not.
assert.deepEqual(ids(splitForAssistiveTechnology(changes, { status: "modified" })), [["Added button “Play”."], ["Changed accessibility label."]]);
// The screenshots match: nothing on the screen looks different, so every finding is for assistive technology.
assert.deepEqual(ids(splitForAssistiveTechnology(changes, { status: "modified", accessibilityOnly: true })), [[], ["Added button “Play”.", "Changed accessibility label."]]);
// A reviewer note is not a finding about the accessibility tree.
assert.deepEqual(ids(splitForAssistiveTechnology([{ id: "review-note", copy: "Note" }], { status: "modified", accessibilityOnly: true })), [["review-note"], []]);
});
const { focusCounts, focusStatusOf } = await tsImport("../../viewer/src/utils/changed-screens.ts", import.meta.url);
test("the Changes filter counts Accessibility only apart from Modified", () => {
const screens = new Map([
["a", { status: "modified" }], ["b", { status: "modified", accessibilityOnly: true }], ["c", { status: "modified", accessibilityOnly: true }],
["d", { status: "added" }], ["e", { status: "not-compared" }], ["f", { status: "unchanged" }],
]);
assert.deepEqual(focusCounts({ screens }), { added: 1, modified: 1, "accessibility-only": 2, removed: 0, "needs-review": 0, "source-affected": 0 });
assert.equal(focusStatusOf({ status: "modified", accessibilityOnly: true }), "accessibility-only");
assert.equal(focusStatusOf({ status: "modified" }), "modified");
assert.equal(focusStatusOf(undefined), undefined);
});
Loaded 100 of 171 files, more files were not shown because too many files have changed in this diff. Show more