Compare commits

..
Author SHA1 Message Date
Brent Vatne 005ca2d0cf Name euxy's PR by its repository in comments 2026-10-15 20:40:11 -07:00
Brent Vatne 05f85ca9d9 Make measured moves exact and never hide a change
Review fixes for measured outlines:

- A region that moved and also changed is not a move: after aligning it by
  the move, three or more pixels still differing by over 140 in any channel
  mean its content changed (re-rasterized text stays under about 125; new
  content is about 200). Colour-only changes are caught per channel.
- Near-tie fits go to the smallest move, so content that is the same all along
  one axis (full-width bars, hairlines) is measured; a second fit nearly as
  good two or more pixels away (repeating content) leaves the region
  unmeasured rather than reporting a wrong direction.
- The vertical search reaches 20 pixels, since drift adds up down long
  screens; sub-pixel offsets come from whole-number steps, so moves up and
  down are judged alike; moves are measured only while the comparison's time
  budget lasts.
- Every region the comparison found is measured, not only the eight it
  publishes, and allRegionsMoved records that all of them moved. The Viewer
  says "Nothing on this screen changed content" only then, and only when no
  other finding remains; it hides only the generic visual finding.
- Each outline carries one number, to a tenth: areas merge only when their
  moves are within a third of each other and span at most half a point
  together, and a moved outline never grows around a changed area.
- The outline and measurement switches keep the choice in memory where
  browser storage is denied, and the Inspector's side-by-side places Before
  outlines too.
2026-10-15 20:35:17 -07:00
Brent Vatne 0240437a4f Label outlines with how far moved areas moved
A layout that grew by a device pixel marks every edge below it as changed, so
an SDK upgrade reads as dozens of modified screens with nothing visible to say
why. CI now measures, for each changed region, the shift that best lines
Before up with After; when one shift explains the region, the report records
it as the region's shift (screenshot pixels, right and down positive). New
text, another colour or a caret is not a move. A move of half a pixel or less
needs a quarter of the difference explained (text re-rasterizes rather than
moves at that size), a larger one 60%, and a best fit at the edge of the search
is rejected, since repeating rows line up with themselves a pitch away.

With Highlight on, the Viewer draws a moved area dashed, where its content is
on each side, labelled with how far it moved ("↑4pt", "↓1–2pt"); areas that
moved together merge into one outline. When every area only moved, What
changed says the layout shifted and how far, in place of the generic visual
finding, and a Show measurements switch there turns the labels off in every
mode. iOS screenshots are one pixel per point; Android's are labelled in
screenshot pixels, since the report does not know the screen's density.
2026-10-15 19:48:19 -07:00
2 changed files with 3 additions and 3 deletions

No files matched your search

+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "@expo/explore",
"version": "0.19.3",
"version": "0.19.2",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@expo/explore",
"version": "0.19.3",
"version": "0.19.2",
"license": "MIT",
"dependencies": {
"@expo/repack-app": "0.10.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@expo/explore",
"version": "0.19.3",
"version": "0.19.2",
"description": "Source-driven mobile app maps, deterministic CI capture, and visual reviews",
"license": "MIT",
"type": "module",