mirror of
https://github.com/expo/expo-github-action.git
synced 2026-11-15 17:32:45 -10:00
Compare commits
4
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c7b66a9c32 | ||
|
|
b8a9be8336 | ||
|
|
b547b4d94a | ||
|
|
54efbfdf1d |
No files matched your search
@@ -1,3 +1,22 @@
|
||||
## [8.2.1](https://github.com/expo/expo-github-action/compare/8.2.0...8.2.1) (2024-01-15)
|
||||
|
||||
|
||||
### Bug fixes
|
||||
|
||||
* **preview:** filter slugs with special characters to match dev clients `exp+<slug>` scheme ([#252](https://github.com/expo/expo-github-action/issues/252)) ([b8a9be8](https://github.com/expo/expo-github-action/commit/b8a9be8336bf5609f8e299a8486f9a2bf7073f8a))
|
||||
|
||||
## [8.2.0](https://github.com/expo/expo-github-action/compare/8.1.0...8.2.0) (2023-12-02)
|
||||
|
||||
|
||||
### New features
|
||||
|
||||
* **preview:** add `qr-target` and use proper QR codes for `expo-go` and `dev-build` ([#247](https://github.com/expo/expo-github-action/issues/247)) ([54efbfd](https://github.com/expo/expo-github-action/commit/54efbfdf1d130888a5f13b73fb7adc85edeb8855))
|
||||
|
||||
|
||||
### Documentation changes
|
||||
|
||||
* **preview:** clarify the branch and workflow trigger relations ([#246](https://github.com/expo/expo-github-action/issues/246)) ([ccfad6f](https://github.com/expo/expo-github-action/commit/ccfad6f148eaa709959a64b1be216481f4ca54ff))
|
||||
|
||||
## [8.1.0](https://github.com/expo/expo-github-action/compare/8.0.0...8.1.0) (2023-11-24)
|
||||
|
||||
|
||||
|
||||
@@ -42133,7 +42133,8 @@ function getUpdateGroupQr({ projectId, updateGroupId, appSlug, qrTarget, }) {
|
||||
if (qrTarget === 'dev-build') {
|
||||
// While the parameter is called `appScheme`, it's actually the app's slug
|
||||
// This should only be added when using dev clients as target
|
||||
url.searchParams.append('appScheme', appSlug);
|
||||
// See: https://github.com/expo/expo/blob/8ae75dde393e5d2393d446227a1fe2482c75eec3/packages/expo-dev-client/plugin/src/getDefaultScheme.ts#L17
|
||||
url.searchParams.append('appScheme', appSlug.replace(/[^A-Za-z0-9+\-.]/g, ''));
|
||||
}
|
||||
url.searchParams.append('projectId', projectId);
|
||||
url.searchParams.append('groupId', updateGroupId);
|
||||
|
||||
+1
-1
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"private": true,
|
||||
"name": "expo-github-action",
|
||||
"version": "8.1.0",
|
||||
"version": "8.2.1",
|
||||
"description": "Expo CLI in your GitHub Actions workflow",
|
||||
"main": "build/index.js",
|
||||
"repository": {
|
||||
|
||||
+2
-1
@@ -84,7 +84,8 @@ export function getUpdateGroupQr({
|
||||
if (qrTarget === 'dev-build') {
|
||||
// While the parameter is called `appScheme`, it's actually the app's slug
|
||||
// This should only be added when using dev clients as target
|
||||
url.searchParams.append('appScheme', appSlug);
|
||||
// See: https://github.com/expo/expo/blob/8ae75dde393e5d2393d446227a1fe2482c75eec3/packages/expo-dev-client/plugin/src/getDefaultScheme.ts#L17
|
||||
url.searchParams.append('appScheme', appSlug.replace(/[^A-Za-z0-9+\-.]/g, ''));
|
||||
}
|
||||
|
||||
url.searchParams.append('projectId', projectId);
|
||||
|
||||
Reference in new issue
Block a user