[logger] Fix s3 logger stream close crash

Bumps [set-getter](https://github.com/doowb/set-getter) from 0.1.0 to 0.1.1.
- [Release notes](https://github.com/doowb/set-getter/releases)
- [Commits](https://github.com/doowb/set-getter/commits/0.1.1)

---
updated-dependencies:
- dependency-name: set-getter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/ISSUE_TEMPLATE/BUG_REPORT.md

@@ -1,10 +1,9 @@
 ---
 name: "\U0001F41B Bug Report"
 about: You want to report a reproducible bug or regression in turtle-cli.
-title: ''
-labels: 'bug'
-assignees: ''
-
+title: ""
+labels: "bug"
+assignees: ""
 ---
 
 <!-- Thanks for helping expo! Before you submit your issue, please make sure you followed our checklist and check the appropriate boxes by putting an x in the [ ]: [x] -->
@@ -13,14 +12,16 @@ assignees: ''
 
 - [ ] Updated turtle-cli to the latest version (`yarn global add turtle-cli` or `npm install --global turtle-cli`).
 - [ ] I read the [Contribution Guidelines](https://github.com/expo/turtle/blob/master/CONTRIBUTING.md).
-- [ ] I read [docs.expo.io](https://docs.expo.io) (Managed Workflow > Distributing Your App).
+- [ ] I read [docs.expo.dev](https://docs.expo.dev) (Managed Workflow > Distributing Your App).
 - [ ] I searched for [existing GitHub issues](https://github.com/expo/turtle/issues).
 - [ ] **I enclosed the complete output when running turtle, including the stack trace and command used.**
 
 ### Issue Description
+
 <!-- Please include what's happening, expected behavior, and any relevant code samples -->
 
 ##### Command executed
+
 <!-- The command you executed on the command line that resulted in an error -->
 
 ##### Complete output when running turtle, including the stack trace and command used

.github/ISSUE_TEMPLATE/QUESTION.md

@@ -1,21 +1,22 @@
 ---
 name: "\U00002753 Questions and discussions"
 about: You have a question about turtle-cli or want to discuss some aspects of turtle-cli.
-title: ''
-labels: 'question'
-assignees: ''
-
+title: ""
+labels: "question"
+assignees: ""
 ---
 
 ### Question Checklist
 
 - [ ] I read the [Contribution Guidelines](https://github.com/expo/turtle/blob/master/CONTRIBUTING.md).
-- [ ] I read [docs.expo.io](https://docs.expo.io) (Managed Workflow > Distributing Your App).
+- [ ] I read [docs.expo.dev](https://docs.expo.dev) (Managed Workflow > Distributing Your App).
 - [ ] I searched for [existing GitHub issues](https://github.com/expo/turtle/issues).
 
 ### Question Subject
+
 <!-- What command do you have a question about? -->
 <!-- Is this a question about documentation? -->
 
 #### Question Description
+
 <!-- Please include expected behavior and any relevant code samples with your question if possible -->

CHANGELOG.md

@@ -7,6 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+- Fix s3 logger stream close crash.
+
+# [0.22.4] - 2021-07-27
+
+- Update iOS and Android tarballs for SDK 42.
+
+# [0.22.3] - 2021-07-02
+
+- Update Android tarball for SDK 42.
+
+# [0.22.1] - 2021-06-29
+
+- Update iOS and Android beta tarballs for SDK 42.
+
+# [0.22.0] - 2021-06-22
+
+- Add iOS and Android beta tarballs for SDK 42.
+
+# [0.21.9] - 2021-06-15
+
 - Update `sharp` package, fixes support for M1 macs.
 
 # [0.21.8] - 2021-05-25

CODE_OF_CONDUCT.md

@@ -4,4 +4,4 @@ The Expo team is committed to fostering an open and welcoming environment.
 
 **Our Community Guidelines can be found here:**
 
-https://expo.io/guidelines
+https://expo.dev/guidelines

CONTRIBUTING.md

@@ -1,30 +1,37 @@
 # Contributing to Turtle CLI
 
 ## How to contribute
+
 You can contribute to Turtle CLI in various ways, including:
+
 - [Reporting bugs or issues](https://github.com/expo/turtle/issues/new) on GitHub. Please make sure to fill in all the details suggested by the template to make sure the issue can be addressed as quickly as possible.
 - [Submitting improvements to the documentation](https://github.com/expo/expo/tree/master/docs). Updates, enhancements, new guides, spelling fixes…
-- Helping other people on [Expo Forums](https://forums.expo.io/) and on [Expo Developers Slack](http://slack.expo.io).
+- Helping other people on [Expo Forums](https://forums.expo.dev/) and on [Expo Developers Discord](http://chat.expo.dev).
 - Looking at existing [issues](https://github.com/expo/turtle/issues) and adding more information, particularly helping to reproduce the issues.
 - [Submitting a pull request](#submitting-a-pull-request) with a bug fix or an improvement.
 
 ## Turtle CLI repository
 
 ### Codebase
+
 This repository contains the codebase for the `turtle-cli` NPM package. The same codebase is used to run standalone app builders on the Expo servers.
 
 ### Branches
+
 The `master` branch of the repository should be kept releasable at any time. This way we can continuously release fixes and improvements without costly managing of different branches and issues will be noticed and fixed quickly. This also ensures other contributors can check out the latest version from GitHub and work on it with minimal disruption from other features in progress.
 
 ## Submitting a pull request
+
 To submit a pull request:
+
 1. Fork the [repository](https://github.com/expo/turtle) and create a feature branch. (Existing contributors can create feature branches without forking. Prefix the branch name with `@your-github-username/`.)
 2. Write the description of your pull request. Make sure to include a test plan and test your changes.
 3. Make sure all tests pass on CircleCI.
 4. Wait for a review and adjust the code if necessary.
 
 ## Publishing a release
+
 - Make sure you have set `GITHUB_TOKEN` and `CIRCLE_API_USER_TOKEN` environment variables in `.envrc.local` file. If you don't have the file, run `cp .envrc.local.example .envrc.local` and edit the file.
 - To release a new version of `turtle-cli`, run `yarn release` command.
-- If you wish to release a new *beta* version of `turtle-cli`, run `yarn release:beta` instead.
+- If you wish to release a new _beta_ version of `turtle-cli`, run `yarn release:beta` instead.
 - Update the [changelog](CHANGELOG.md).

README.md

@@ -6,8 +6,8 @@
 [![NPM](https://img.shields.io/npm/v/turtle-cli/latest.svg)](https://npmjs.com/package/turtle-cli)
 [![License](https://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/expo/turtle/blob/master/LICENSE)
 
-[![Expo Developers Slack](https://img.shields.io/badge/Expo%20Developers-e01563.svg?logo=slack)](http://slack.expo.io)
-[![Expo Forums](https://img.shields.io/badge/Expo%20Forums-blue.svg)](https://forums.expo.io/)
+[![Expo Developers Discord](https://img.shields.io/discord/695411232856997968)](http://chat.expo.dev)
+[![Expo Forums](https://img.shields.io/badge/Expo%20Forums-blue.svg)](https://forums.expo.dev/)
 
 <hr />
 
@@ -21,7 +21,7 @@ You can use it both on your CI and your private computer.
 
 ## Installation
 
-[Installation instructions and documentation here.](https://docs.expo.io/distribution/turtle-cli/)
+[Installation instructions and documentation here.](https://docs.expo.dev/distribution/turtle-cli/)
 
 ## Usage example
 
@@ -29,13 +29,13 @@ See the [expo/turtle-cli-example](https://github.com/expo/turtle-cli-example) re
 
 ## Do you need help?
 
-- Make sure you've read [the Expo Docs](https://docs.expo.io/), especially [Building Standalone Apps on Your CI
-](https://docs.expo.io/versions/latest/distribution/turtle-cli) and [Building Standalone Apps](https://docs.expo.io/versions/latest/distribution/building-standalone-apps) guides.
+- Make sure you've read [the Expo Docs](https://docs.expo.dev/), especially [Building Standalone Apps on Your CI
+  ](https://docs.expo.dev/versions/latest/distribution/turtle-cli) and [Building Standalone Apps](https://docs.expo.dev/versions/latest/distribution/building-standalone-apps) guides.
 - Search for existing GitHub issues [in this repository](https://github.com/expo/turtle/issues) and in [expo/expo](https://github.com/expo/expo/issues) repository.
 - Ask for help in **one** of the following ways:
-  * create [a GitHub issue](https://github.com/expo/turtle/issues/new).
-  * create a new topic on [Expo Forums](https://forums.expo.io/).
-  * ask a question on [Expo Developers Slack](http://slack.expo.io).
+  - create [a GitHub issue](https://github.com/expo/turtle/issues/new).
+  - create a new topic on the [Expo Forums](https://forums.expo.dev/).
+  - connect with the community on the [Expo Developers Discord](http://chat.expo.dev).
 
 ## License
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "turtle-cli",
-  "version": "0.21.8",
+  "version": "0.22.4",
   "description": "The command-line tool for building standalone Expo apps",
   "preferGlobal": true,
   "scripts": {
@@ -57,7 +57,7 @@
   "engines": {
     "node": ">=10"
   },
-  "author": "Expo <support@expo.io>",
+  "author": "Expo <support@expo.dev>",
   "license": "MIT",
   "bugs": {
     "url": "https://github.com/expo/turtle/issues"

scripts/tests/runAndroidSmokeTestsCI.sh

@@ -18,7 +18,7 @@ export AWS_S3_BUCKET="exp-shell-app-assets"
 export AWS_S3_REGION="us-west-1"
 export AWS_CLOUDWATCH_REGION="us-west-1"
 export API_PROTOCOL="http"
-export API_HOSTNAME="staging.expo.io"
+export API_HOSTNAME="staging.exp.host"
 export API_PORT="443"
 export REDIS_URL="noop"
 export REDIS_CONFIG_URL="noop"

scripts/tests/runIOSSmokeTestsCI.sh

@@ -14,7 +14,7 @@ export AWS_S3_BUCKET="exp-shell-app-assets"
 export AWS_S3_REGION="us-west-1"
 export AWS_CLOUDWATCH_REGION="us-west-1"
 export API_PROTOCOL="https"
-export API_HOSTNAME="staging.expo.io"
+export API_HOSTNAME="staging.exp.host"
 export API_PORT="443"
 export REDIS_URL="noop"
 export REDIS_CONFIG_URL="noop"

shellTarballs/android/sdk42

@@ -0,0 +1 @@
+s3://exp-artifacts/android-shell-builder-1bdbf48b083ef475c294128074a4149b276062ff.tar.gz

shellTarballs/ios/sdk42

@@ -0,0 +1 @@
+s3://exp-artifacts/ios-shell-builder-sdk-latest-1bdbf48b083ef475c294128074a4149b276062ff.tar.gz

src/logger/index.ts

@@ -29,13 +29,13 @@ class Logger {
       jobID: job.id,
       experienceName: job.experienceName,
     });
-    const s3Url = await streams.s3.stream.init(job);
+    const s3Url = await streams.s3?.stream.init(job);
     return s3Url;
   }
 
   public async cleanup() {
     this.currentLogger = this.parentLogger;
-    await streams.s3.stream.cleanup();
+    await streams.s3?.stream.cleanup();
   }
 
   public trace(...all: any[]) {

src/logger/streams/index.ts

@@ -1,20 +1,22 @@
-import pickBy from 'lodash/pickBy';
-
+import { pickBy } from 'lodash';
 import createGCloudStream from 'turtle/logger/streams/gcloud';
 import createOfflineStream from 'turtle/logger/streams/offline';
-import createS3Stream from 'turtle/logger/streams/s3';
+import createS3Stream, { S3Stream } from 'turtle/logger/streams/s3';
 import createSentryStream from 'turtle/logger/streams/sentry';
 import { isOffline } from 'turtle/turtleContext';
 
-interface IStream {
-  stream: any;
+interface IStream<T> {
+  stream: T;
   type?: string;
   level?: string;
   reemitErrorEvents?: boolean;
 }
 
 interface IStreamMap {
-  [key: string]: IStream;
+  stdout: IStream<any>;
+  gcloud?: IStream<any>;
+  s3?: IStream<S3Stream>;
+  sentry?: IStream<any>;
 }
 
 function prepareStreams(): IStreamMap {
@@ -29,7 +31,7 @@ function prepareStreams(): IStreamMap {
       s3: createS3Stream(),
       sentry: createSentryStream(),
     };
-    return pickBy(allStreams) as IStreamMap;
+    return pickBy(allStreams) as any as IStreamMap;
   }
 }
 

src/logger/streams/s3.ts

@@ -18,7 +18,7 @@ export default function create() {
   };
 }
 
-class S3Stream extends EventEmitter {
+export class S3Stream extends EventEmitter {
   private s3Url: string | null = null;
   private lastFlush: number | null = null;
   private filePath: string | null = null;
@@ -44,7 +44,11 @@ class S3Stream extends EventEmitter {
 
   public async cleanup() {
     await this.flush(true);
-    await fs.close(this.fileHandle as number);
+
+    if (this.fileHandle) {
+      await fs.close(this.fileHandle);
+    }
+
     this.fileHandle = null;
     this.waitingOnPromise = false;
   }
@@ -64,7 +68,7 @@ class S3Stream extends EventEmitter {
       return;
     }
     fs
-      .write(this.fileHandle as number, `${JSON.stringify(rec)}\n`)
+      .write(this.fileHandle, `${JSON.stringify(rec)}\n`)
       .then(() => {
         this.flush();
       });

yarn.lock

@@ -15230,9 +15230,9 @@ set-blocking@^2.0.0, set-blocking@~2.0.0:
   integrity sha1-BF+XgtARrppoA93TgrJDkrPYkPc=
 
 set-getter@^0.1.0:
-  version "0.1.0"
-  resolved "https://registry.yarnpkg.com/set-getter/-/set-getter-0.1.0.tgz#d769c182c9d5a51f409145f2fba82e5e86e80376"
-  integrity sha1-12nBgsnVpR9AkUXy+6guXoboA3Y=
+  version "0.1.1"
+  resolved "https://registry.yarnpkg.com/set-getter/-/set-getter-0.1.1.tgz#a3110e1b461d31a9cfc8c5c9ee2e9737ad447102"
+  integrity sha512-9sVWOy+gthr+0G9DzqqLaYNA7+5OKkSmcqjL9cBpDEaZrr3ShQlyX2cZ/O/ozE41oxn/Tt0LGEM/w4Rub3A3gw==
   dependencies:
     to-object-path "^0.3.0"