facebookresearch/faiss
1
0
Fork 0
mirror of https://github.com/facebookresearch/faiss.git synced 2026-10-11 22:50:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

faiss/conda: extend LSQ NEON-flaky test skip to all arm64 (#5713)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/5713

Two Local Search Quantizer tests are numerically flaky under ARM NEON FMA ordering:
- `TestComponents_ARM_NEON.test_update_codebooks_with_double`: `err_double` can exceed `err_float` on ARM even though it is better on x86.
- `TestProductLocalSearchQuantizer.test_lut`: `compute_LUT` rounds differently on NEON; max relative diff reaches ~1.7e-3, above the x86-tuned `rtol=5e-4`.

D121930308 already skips both via `pytest -k` on `osx and arm64`. This widens the conda selectors to `arm64` so linux-aarch64 nightly builds skip them too:
- `pytest` test requirement and the `pytest -k` command: `[osx and arm64]` -> `[arm64]`
- `unittest` `test_*` command: `[not (osx and arm64)]` -> `[not arm64]`

The root fix (platform guards / looser `rtol` in the test files) is still pending.

Reviewed By: mnorris11

Differential Revision: D122238335

fbshipit-source-id: c18fa2ecec29602e758bc20e2bc0dfc3e5d207d0
This commit is contained in:
Junjie Qi
2026-10-08 11:56:58 -07:00
committed by meta-codesync[bot]
parent 2839c39f20
commit 3a98062426
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conda/faiss/meta.yaml
+3 -3
View File
@@ -158,7 +158,7 @@ outputs:
requires:
- numpy >=2.0,<3.0
- scipy
- pytest # [osx and arm64]
- pytest # [arm64]
- pytorch-cpu >=2.7 # [not win]
- pytorch >=2.7 # [win]
{% if PY_VER == '3.10' or PY_VER == '3.11' %}
@@ -170,8 +170,8 @@ outputs:
- python_abi =3.12
{% endif %}
commands:
- python -X faulthandler -m pytest tests/ --ignore=tests/external_module_test.py -q -k 'not test_update_codebooks_with_double and not (TestProductLocalSearchQuantizer and test_lut)' # [osx and arm64]
- python -X faulthandler -m unittest discover -v -s tests/ -p "test_*" # [not (osx and arm64)]
- python -X faulthandler -m pytest tests/ --ignore=tests/external_module_test.py -q -k 'not test_update_codebooks_with_double and not (TestProductLocalSearchQuantizer and test_lut)' # [arm64]
- python -X faulthandler -m unittest discover -v -s tests/ -p "test_*" # [not arm64]
- python -X faulthandler -m unittest discover -v -s tests/ -p "torch_*"
- sh test_cpu_dispatch.sh # [linux64]
files: