facebookresearch/faiss
1
0
Fork 0
mirror of https://github.com/facebookresearch/faiss.git synced 2026-10-12 02:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Development.Module component in CMake FindPython (#4549)

Browse Source 
Summary:
This PR updates the CMake configuration for the Python extension.

The current configuration specifies `Development` python component that includes the unnecessary `Development.Embed` sub-component. For a Python extension, only `Development.Module` component is required. The current configuration leads to a cmake build failure in the `manylinux` environment.

https://cmake.org/cmake/help/latest/module/FindPython.html

**Additional context**
I found this issue while I was testing the `scikit-build-core` backend to build wheel packages in this repository:
https://github.com/kyamagu/faiss-build

Pull Request resolved: https://github.com/facebookresearch/faiss/pull/4549

Reviewed By: junjieqi

Differential Revision: D80952883

Pulled By: limqiying

fbshipit-source-id: 793bc369fae8e9f1745f91d7f573f77494a1b886
This commit is contained in:
Kota Yamaguchi
2025-08-26 00:37:26 -07:00
committed by Facebook GitHub Bot
parent 3c7235c6c7
commit e5de66e2c2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
faiss/python/CMakeLists.txt
+1 -1
View File
@@ -265,7 +265,7 @@ target_include_directories(swigfaiss_sve PRIVATE ${PROJECT_SOURCE_DIR}/../..)
target_include_directories(faiss_example_external_module PRIVATE ${PROJECT_SOURCE_DIR}/../..)
find_package(Python REQUIRED
COMPONENTS Development NumPy
COMPONENTS Development.Module NumPy
)
add_library(faiss_python_callbacks EXCLUDE_FROM_ALL