freebsd/freebsd-src
1
0 Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2026-11-07 04:36:52 -10:00
Code Issues Packages Projects Releases Wiki Activity

vtnet: don't provide VIRTIO_NET_HDR_F_DATA_VALID

Browse Source 
According to section 5.1.6.2.1 of version 1.3 of the virtio
specification, the driver MUST NOT set VIRTIO_NET_HDR_F_DATA_VALID in
the flags. So don't do that.

Reviewed by: 		Timo Völker
MFC after:		3 days
Differential Revision:	https://reviews.freebsd.org/D53650
This commit is contained in:
Michael Tuexen committed 2025-11-10 16:28:04 +01:00
1 parent 978aaa72f3
commit 836b3cd9d7
1 file changed
+1 -6
Download Patch File Download Diff File Expand all files Collapse all files
sys/dev/virtio/network/if_vtnet.c
+1 -6
View File
@@ -2505,10 +2505,6 @@ vtnet_txq_offload(struct vtnet_txq *txq, struct mbuf *m,
hdr->csum_start = vtnet_gtoh16(sc, csum_start);
hdr->csum_offset = vtnet_gtoh16(sc, m->m_pkthdr.csum_data);
txq->vtntx_stats.vtxs_csum++;
} else if ((flags & (CSUM_DATA_VALID | CSUM_PSEUDO_HDR)) &&
(proto == IPPROTO_TCP || proto == IPPROTO_UDP) &&
(m->m_pkthdr.csum_data == 0xFFFF)) {
hdr->flags |= VIRTIO_NET_HDR_F_DATA_VALID;
}
if (flags & (CSUM_IP_TSO | CSUM_IP6_TSO)) {
@@ -2622,8 +2618,7 @@ vtnet_txq_encap(struct vtnet_txq *txq, struct mbuf **m_head, int flags)
m->m_flags &= ~M_VLANTAG;
}
if (m->m_pkthdr.csum_flags &
(VTNET_CSUM_ALL_OFFLOAD | CSUM_DATA_VALID)) {
if (m->m_pkthdr.csum_flags & VTNET_CSUM_ALL_OFFLOAD) {
m = vtnet_txq_offload(txq, m, hdr);
if ((*m_head = m) == NULL) {
error = ENOBUFS;