* Support HMS for Windows Desktop and database AD access
* go mod tidy
* review comment
* make go-mod-tidy-all
* Rework tests
* Cleanup
* go mod tidy
* Cleanup
* Fix tests
* lint
* Use cluster name in CRL url
* Make db cert generation backward compatible
* Review comments
* go mod tidy
* test change
* Support out parameter for tctl crl command
* Use base32 for consistency
* Review comments
* Review comments
* Get authority for current cluster
* CHange out file patterns to simplify DB CRL import
* Print certutil commands at the end
* Print certutil commands at the end
* Update tests
* Update DB AD docs to mention HSM changes
* Update tool/tctl/common/auth_command.go
Co-authored-by: Zac Bergquist <[email protected]>
* Update tool/tctl/common/auth_command.go
Co-authored-by: Zac Bergquist <[email protected]>
* review comment
* Update tool/tctl/common/auth_command.go
Co-authored-by: Zac Bergquist <[email protected]>
* Update tool/tctl/common/auth_command.go
Co-authored-by: Zac Bergquist <[email protected]>
* Update docs/pages/enroll-resources/database-access/enroll-self-hosted-databases/sql-server-ad-pkinit.mdx
Co-authored-by: Zac Bergquist <[email protected]>
* review comment
* review comment
---------
Co-authored-by: Zac Bergquist <[email protected]>
* Support HMS for Windows Desktop and database AD access
* go mod tidy
* review comment
* make go-mod-tidy-all
* Rework tests
* Cleanup
* go mod tidy
* Cleanup
* Fix tests
* lint
* Use cluster name in CRL url
* Make db cert generation backward compatible
* Review comments
* go mod tidy
* test change
* Proto changes for HSM support in AD
* Database CRLDomain
* Update api/proto/teleport/legacy/types/events/events.proto
Co-authored-by: Zac Bergquist <[email protected]>
* Split ID to domain and type
---------
Co-authored-by: Zac Bergquist <[email protected]>
* Simplify code around latency detection for desktop
* cleanup
* Use tdp.Conn for client and server
* Add check for context cancellation
* Cleanup
* remove context check
* remove context check
* remove unused field
* use sync.OnceFunc, error on unexpected ping
* err message
* wip
* add ping message and latency from desktop side
* version
* Fix backward compatibility
* godocs
* formatting
* fix imports
* formatting
* formatting
* log and gci
* lint
* Apply tooltip on the icon directly, instead of on the Menu component
This fixes a problem where onMouseLeave in HoverTooltip wasn't called and the tooltip didn't disappear.
* Use consistent spacing between top bar elements
* updates from origin
* e
* e
* lint
* rework UI after merge
* Rename fields in backend
* prettier
* Update web/packages/shared/components/DesktopSession/TopBar.tsx
Co-authored-by: Grzegorz Zdunek <[email protected]>
* review comments
* fix ui
* add env var to disable windows desktop "ping"
* review comment
* review comment
* Update lib/web/desktop.go
Co-authored-by: Zac Bergquist <[email protected]>
* Refactor latency monitoring
* fix spelling
* remove monitorSessionLatency
* gci
* review comment
* review comment
* Update RFD and version
* fix gaps
---------
Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
* ad/non-ad
* use separate OID for AD status
* Update lib/auth/windows/windows.go
Co-authored-by: Zac Bergquist <[email protected]>
* Update lib/srv/desktop/windows_server.go
Co-authored-by: Edward Dowling <[email protected]>
---------
Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Edward Dowling <[email protected]>
* proto
* Fix update for DynamicWindowsDesktops
* fix test server
* fix test
* fix test
* fix test
* Update api/proto/teleport/dynamicwindows/v1/dynamicwindows_service.proto
Co-authored-by: Zac Bergquist <[email protected]>
* update proto
* fix tests
---------
Co-authored-by: Zac Bergquist <[email protected]>
* Add DynamicWindowsDesktop to proto
* Add resource matchers to Windows desktop service config
* move rpc to separate server
* e
* remove dynamic windows from paginated resource
* Update api/proto/teleport/legacy/types/types.proto
Co-authored-by: rosstimothy <[email protected]>
* gci
---------
Co-authored-by: rosstimothy <[email protected]>
* Add DynamicWindowsDesktop to proto
* move rpc to separate server
* e
* remove dynamic windows from paginated resource
* Update api/proto/teleport/legacy/types/types.proto
Co-authored-by: rosstimothy <[email protected]>
---------
Co-authored-by: rosstimothy <[email protected]>
* initial
* full flow
* e
* cleanup
* cleanup, deps
* fix non-ad
* update IronRDP/sspi, remove domain
* rework url parsing
* lint
* cleanup
* Update lib/srv/desktop/rdp/rdpclient/client_common.go
Co-authored-by: Zac Bergquist <[email protected]>
* cleanup
* cleanup
* cleanup
* cleanup
* update sspi to 0.13
* disable credssp in FIPS builds
* update IronRDP
* propagate KDCAddr from config file
* Allow tokio-rustls license
* clippy
* Fix public key data in FIPS mode, enable CredSSP in FIPS
* Update lib/srv/desktop/rdp/rdpclient/src/ssl.rs
Co-authored-by: Zac Bergquist <[email protected]>
* simplify network client
* Minor improvements
- Better error display for IronRDP errors with poor Display impls
- Check key length before truncating to avoid a panic
- Improve godocs
* Make NLA opt in via TELEPORT_ENABLE_RDP_NLA=yes
* Suppress sspi-rs logs
sspi-rs currently logs everything at info level, which clutters
the Teleport logs. Set its log level to warn until upstream's
logging is less chatty.
* try disabling credssp first
* use missing computer name in case of IP address
* always enable credssp when opted-in
* fmt
* Update lib/srv/desktop/rdp/rdpclient/src/client.rs
Co-authored-by: Zac Bergquist <[email protected]>
* review comments
* review comments
* use teleport.dev/computer_name
* e
---------
Co-authored-by: Zac Bergquist <[email protected]>
* adds ironrdp client and has it connect, alongside rdp-rs
* Integrates IronRDP client into the TDP png-response system. Instead of sending back chunks of the screen, its sends the full screen every time, and this is my running hypothesis for the current sticking point: a "Maximum call stack size exceeded" from the tdp client in the react app
* Changes arrayBufferToBase64 to use reduce, which fixes the "Maximum call stack size exceeded" bug
* removes convert_bgra_to_rgba which isn't needed with the bitmaps being produced by IronRDP
* Adds support for updating only a specific image region
* removes mistaken read_rdp_output_inner call from connect_rdp_inner
* Adds support for mouse input. I believe this code has race conditions for client.write_frame though this requires more research.
* Patches things up with the new IronRDP structure
Requires some modifications to IronRDP, see the corresponding commit hash
for IronRDP in lib/srv/desktop/rdp/rdpclient/Cargo.toml.
Started getting call stack overflows when manual testing again, but I'm
going to ignore those for now and focus on the version of this architecture
that passes the remoteFX encoded messages over TDP.
* Adds RemoteFX Frame to the backend
* Proof of concept for integrating a wasm module into the frontend
Building the wasm module still needs to be done manually, this was
just to get to a point where tools are configured and it can be successfully
called in both dev and prod modes.
Required that I comment out "default-src 'self'" in the CSP, this will
need to be figured out later.
We're also using a package called vite-plugin-wasm-pack whereas ironrdp
uses vite-plugin-wasm. I'm not sure why, I'm going to look into this and
swap out to vite-plugin-wasm if possible.
* Swaps out vite-plugin-wasm-pack for vite-plugin-wasm and adds build-wasm script to the teleport package.json.
vite-plugin-wasm-pack looks relatively unmaintained in comparison
to vite-plugin-wasm-pack.
build-wasm script is needed to build the wasm binary before calling vite [build]
* Adds backend structure for RPC PoC
Untested as of yet and it isn't pretty, but this more or less imitates the
RPC approach we have for directory sharing.
* hack solution which calls everything 'static. THIS IS VERY UNSAFE, WE SHOULD DO SOMETHING ELSE
* Gets the full display working end to end
with a particular commit of IronRDP. Unfortunately this commit is now
well out of date, and IronRDP had some bugs that were preventing RemoteFX
frames from being sent back.
* Full display working end to end with the updated IronRDP
* updates init_wasm_log to enable logging in the console
* updates hardcoded io_channel_id and user_channel_id
* Uses specific IronRDP sub-crates (i.e. ironrdp-session, ironrdp-tokio, etc.) rather than relying on whatever is re-exported from the ironrdp sub-crate itself
* Gets FastPathFrameResponse up to speed and the PoC is now working
* deletes all the rpc stuff which it turns out we don't need
* more cleanup including consolidating the FastPathFrame message between wasm and js, adding some comments
* Updates the documentation string for top level Client in lib.rs
* Removes hardcoded rdp server address, screen size, and username
* Swaps to online IronRDP repo
* Updates the TDP RFD with new messages
renaming them to be precise.
* remove hardcoded ip
* creates asRustBackedSlice
* removing some old todos
* Add cleanup for wasm-pack build artifacts to make clean
* Fix wasm in production builds (#27428)
* Converts the default Content-Security-Policy representation to a map
which makes it easier to programmatically add-to/overwrite the defaults
for special cases.
Also adds tests for the various custom CSPs.
* Alphabetize CSP directives for ease of testing/debugging in the future
* makes maps more easily composable
* removes commented code, and topLevelAwait() which was causing production builds to break
* Adds 'wasm-unsafe-eval' to the script-src section of the Content-Security-Policy
when a desktop session's url is detected.
The app already enforces no caching via the Cache-Control, Pragma, and
Expires headers (SetNoCacheHeaders), which means that any time the app
is requested in a new tab, the browser will always request a new index.html
which can be sent back with a new Content-Security-Policy header.
Since the only way to get to a desktop session is to either
click a link in the app which opens a new tab, or to open a new tab and
navigate to the url manually (this differs from most components, which can
be navigated to without a page reload using React Router), we can reliably
check each index.html request for a characteristic desktop session url path,
and only include the 'wasm-unsafe-eval' directive when strictly necessary
(in the spirit of the principle of least privilege).
* Removes vite-plugin-top-level-await from package.json
* moves regex to global so that it only need be compiled once
* CR fixes
updates Cargo.lock
removes commented feature flag
removes -framework SystemConfiguration
fixes makefile comment
* unsafe.SliceData
* fixes phrasing
* changes to docstring
* changes handle_tdp_fast_path_response to handle_tdp_rdp_response_pdu
so that its name is in line with its definition in RFD 0037 and
adds a more descriptive docstring.
* small fixes to comments
* preallocate RDPFastPathPDU Encode buffer
* updating comments
* Adds a detailed discussion of the Go/Rust Interface to the README (#29762)
* Aligns the codebase with the Go/Rust interface principles in the README (#29764)
* Move client functionality into Client (#29765)
* Adds the RDP Channel IDs TDP message (#27514)
* Refactoring `rdpclient` (#29766)
* Ironrdp recording playback (#28228)
* httplib.SetIndexContentSecurityPolicyWithWasm for recordings as well as desktop sessions so that the ironrdp wasm client can be used for recording playback
* Adds desktopplayback path to websocket proxy definitions so that it can be used with the dev server
* adds tdp.TypeRDPFastPathPDU as a tdp message to be recorded
* With this commit, recordings can be played back with the FastPathProcessor
Refactors tdp Client and subclass PlayerClient
such that now the classes are always constructed the same way,
and the internal representation of the screen size (the FastPathProcessor)
is either:
1. Created upon the call to Client.connect(spec) when spec is !undefined.
This is the case when the Client is being used for a desktop session.
2. Created when a client screen spec is received from the server. This is
the case when PlayerClient is being used for playback.
* Switches from sending the width/height via ur parameter string
to sending it via the client screen spec tdp message.
* changes tdpCli* to client* and adds a canvas* to the canvas related functions
* Static tokio (#30066)
* Beginnings of RdpdrBackend integration (#32814)
* Adds handling for the EstablishContextCall (#32971)
* Adds support for `ListReadersCall` and `ListReadersReturn` (#33004)
* Adds support for `GetStatusChangeCall`/`GetStatusChangeReturn` (#33056)
* Adds support for ConnectCall and ConnectReturn (#33136)
* Better error handling (#32925)
This change removes couple of unwrap that could cause panics on the Rust side and prevents panics from invalid cgo handle on the Go side.
It also sends error message from IronRDP to UI and cleans up a little final sequence of closing various goroutines in case of error or sessions end.
* Adds support for `HCardAndDispositionCall` with `ScardIoCtlCode::BeginTransaction` (#33192)
* `TransmitCall` and `TransmitReturn` (#33282)
* `StatusCall` and `StatusReturn` (#33284)
* `ReleaseContext` and refactor `handle_scard_call` (#33434)
* IronRDP clipboard sharing (#33335)
This change adds clipboard sharing to our IronRDP migration using ironrdp_cliprdr crate with out TDP-based backend (reused from rdp-rs times)
* Adds EndTransaction, Disconnect, Cancel, and IsValidContext (#33612)
* Adds support for `GetDeviceTypeId` (#33613)
* Adds support for `ReadCacheW` (#33618)
* `WriteCacheW` (#33620)
* Smartcard Login (#33712)
* `GetReaderIcon` (#33779)
* Update to IronRDP latest commit
* Removes a bunch of old deprecated code (including `rdp-rs`) (#33786)
* Pipes in `SharedDirectoryAnnounce` (#33911)
* Use tokio-boring for TLS upgrade (#33900)
This change switches TLS upgrade in our new RDP approach to tokio-boring in FIPS-compliant builds.
It also adds runtime check for FIPS mode.
Tested locally in custom Docker image.
* Update sspi (#34558)
* Break up rdpdr.rs, add support for the first directory sharing pdus (#34009)
* Adds support for `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse`. (#34011)
* `SharedDirectoryDeleteRequest` and `SharedDirectoryDeleteResponse` (#34051)
* remove leftover code
* Server drive query information request (#34082)
* Rdp client refactor (#34122)
* Add handling for `DeviceCloseRequest` (#34139)
* Updates to `IronRDP` latest (#34744)
* Updates to IronRDP latest with a slightly different API
* remove defunct comment
* `ServerDriveQueryDirectoryRequest` and `SharedDirectoryListRequest/Response` (#34746)
* `ServerDriveQueryVolumeInformationRequest` and `ClientDriveQueryVolumeInformationResponse` (#34871)
* `DeviceControlRequest` (#34898)
* `Read` (#34914)
* `Write` (#34919)
* `SetInformation` (#35092)
* `LockControl` (#35146)
* Stack pr feedback and other cleanup (#35306)
* Adds desktop access websocket pattern to vite config
* Updates IronRDP to latest, removes manual context strings in favor of automatically generated (by this latest IronRDP commit) (#35392)
* Small line fixes, comment removal, changing license to AGPL
* Update Go/Rust interface section of README (#35590)
* Ironrdp manual docs (#35455)
* Remove unnecessary whitespace
* Refactor navigation paths in Active Directory documentation for clarity
Replaced textual descriptions with formatted paths using `>` symbols for better readability.
Having been subject to going through many such tutorials myself, I find this to be a more
user-friendly way of presenting the information. It's very common to need to go back and
forth between the documentation and the group policy manager, and having these paths in a
format that can catch the eye quickly is a big help. This also appears to be common practice
e.g.
- https://softwarekeep.com/help-center/how-to-enable-remote-desktop-on-windows
- https://www.helpwire.app/blog/remote-desktop-group-policy/
* Add instructions for enabling RemoteFX
* Add an optional step to the end of each GPO update subsection
This lets us point users to subsections individually without worrying
about reminding them that they need to run a `gpupdate /force` each
time (because its already right there in the subsection).
* lowercase "open"
* Updates configuration script to enable RemoteFX (#35461)
* Restructure Cargo workspace (#35591)
* Update `IronRDP` to latest, fix key log leak (#35707)
Updates IronRDP to latest with the changes necessary to keep up with the changes in https://github.com/Devolutions/IronRDP/pull/328. We select the `"rustls"` feature explicitly now, this is in line with our implicit choice of it as [the default](https://github.com/Devolutions/IronRDP/pull/325/files#diff-1f64036f3e460819b2b1e954803b7f266feca0e2787ca0614ae1253323944f59L19) before these latest changes.
Also creates a custom debug for `ScardBackend` so as to not leak `key_der` in the logs.
* Don't leak pin in the logs
* Show clear error when export can't be done
* Show url of recording in webui
* patching up merge mistake
* use EndTime and StartTime to calculate duration
---------
Co-authored-by: Isaiah Becker-Mayer <[email protected]>
* Windows auto user creation
* changes in role
* fix roles
* make grpc
* fix imports
* fix test
* fix test
* fix test
* fix test
* fix test
* windows labels
* rename OID, add json tags
* params to struct
* grpc
* Update lib/services/role.go
Co-authored-by: Isaiah Becker-Mayer <[email protected]>
* Update lib/services/access_checker.go
Co-authored-by: Isaiah Becker-Mayer <[email protected]>
* grpc
* bump e
* only add extension when we create user
---------
Co-authored-by: Isaiah Becker-Mayer <[email protected]>
* Add building Windows Authentication Package to Drone
* Add building Windows Authentication Package to Drone
* Set test build version
* Test trigger
* Trigger + version update
* fix path
* path + version
* trigger?
* fix windres
* fix windres
* fix windres
* fix windres
* fix windres
* handle windows windres
* handle windows windres
* update e
* gocache
* gocache
* gocache
* update e
* go version
* go version
* go version
* tes
* tes
* test
* bump e
* bump e
* dronegen
* concurrent
* tag trigger
* bump version
* trigger
* trigger
* trigger
* bump e
* bump e, cleanup build
* fix signing
* fix signing
* rename
* fix signing
* restore trigger
* restore trigger
* bump version
* relcli update
* bump version
* bump version
* restore version
* restore e
* dronegen
* dronegen
* bump e
* dronegen
* dronegen
* dronegen
This change brings back setting alpha to 100% (fully opaque) before sending bitmap data to TDP in Desktop Access.
This fixes problem with using Desktop Access with Windows 10.
This change adds IP-based validation for SSH certificates.
There's new option in role definition:
kind: role
metadata:
name: dev
spec:
options:
pin_source_ip: true
When that is set to true client IP must be the same when generating certificates and using them. It uses source_address critical option that should be supported by both teleport and sshd and only applies to certificates we send to user (like in tsh login), we don't pin IP in certificates issued for web UI as they can't leak.
This change also omits machine ID (it uses different code path) - it will be added in separate PR.
Most of the lines changed are from regenerating types.proto, change itself is not that big
Relates #11719
#11684 added support for proxy protocol v2 for SSH and Postgres but MySQL uses different code path and it was missing. This change fixes that.
It also adds tests for v2 protocol support for MySQL, Postgres, Mongo and Redis
This change updates gosaml2 to our fork with added support for AES256GCM and AES192GCM for encrypted assertions.
I also run go mod tidy to cleanup go.mod file
Closes#10909
Currently we use random auth server from the list but if it's unavailable (for example it was restarted but there's still entry in cache, dynamodb backend etc) we return error.
This change tries all servers (in random order) and uses first that is available.
Closes#10019
