mirror of
https://github.com/gravitational/teleport.git
synced 2026-10-11 22:49:54 +00:00
22 lines
1.2 KiB
Markdown
22 lines
1.2 KiB
Markdown
# AGENTS.md
|
|
|
|
## Review Guidelines
|
|
- Focus only on critical security, reliability, performance, and scalability issues.
|
|
- Ignore style, performance micro-optimizations, and readability nits unless they are tied to a significant failure
|
|
|
|
### What to Look For
|
|
- Authentication/authorization bypasses
|
|
- Secret leakage, unsafe logging, or credential exposure
|
|
- Unsafe defaults in security-sensitive areas
|
|
- Injection risks (SQL, command, template, path traversal, SSRF)
|
|
- Insecure crypto usage or key handling
|
|
- Privilege escalation or sandbox escapes
|
|
- Data corruption, durability failures, or irreversible loss scenarios
|
|
- Concurrency hazards that can cause outages or data races
|
|
- Reliability regressions: crash loops, panics, deadlocks, unbounded retries, nil pointer dereferences
|
|
- Adherence to the guidelines defined in [RFD 153](https://github.com/gravitational/teleport/blob/8ff3d34581424302182c217e4d8d3be45bf2b0b7/rfd/0153-resource-guidelines.md) of Teleport resource definitions, gRPC, backend storage, and cache APIs.
|
|
|
|
### Documentation
|
|
|
|
When you are looking at a given product area find the relevant documentation in the docs/ directory to ensure you understand the context in which the code is used.
|