DEBUG #4294: log each chunk sent with its neighbours (never merge)

.gitattributes

@@ -4,8 +4,3 @@ docs/launcher-commands.md text eol=lf
 docs/horizon-ctl-commands.md text eol=lf
 crates/horizon-theme/tokens.css text eol=lf
 docs/api/*-reference.md text eol=lf
-# Generated by `cargo run -p xtask -- mod-api`; `--check` compares them byte for byte.
-crates/horizon-client/src/mod_api/generated.rs linguist-generated=true text eol=lf
-crates/horizon-client/src/mod_api/generated_host.rs linguist-generated=true text eol=lf
-crates/horizon-client/src/game/mod_api_host_generated.rs linguist-generated=true text eol=lf
-crates/horizon-client-render/src/gfx/native_render/generated.rs linguist-generated=true text eol=lf

.github/pull_request_template.md

@@ -21,12 +21,6 @@
 <!-- The vanilla classes and methods this follows (tools/rea_vanilla.py), and the harness that checks it.
      "Horizon-only" for a feature vanilla doesn't have; "none" for tooling or docs. -->
 
-## Other projects' code
-
-<!-- "none", or for each project you read or copied from: its link at the commit, its license (only MIT,
-     BSD-2-Clause, BSD-3-Clause, Apache-2.0, ISC, zlib, 0BSD, MIT-0, Unlicense or CC0-1.0), and what you took.
-     CONTRIBUTING.md "Only original code". -->
-
 ## Self-check
 
 <!-- Paste the block `python3 tools/pr_ready.py` prints (`--base upstream/main` from a fork). -->

.github/trusted-reviewers.txt

@@ -7,4 +7,3 @@ kacpherek    # added by Ludovic, 2026-10-27
 rdbtCVS      # added by Ludovic, 2026-10-27
 Online5277   # added by Ludovic, 2026-10-27 (his top three by merged pull requests)
 levzzz5154   # added by Ludovic, 2026-10-28 (Horizon Team; author of horizon-mixins)
-Qwerner88880 # added by Ludovic, 2026-10-31 (Discord vladislav_hagen; native-mod hooks)

.github/workflows/cancel-on-close.yml

@@ -9,9 +9,7 @@ permissions:
   actions: write
 jobs:
   cancel:
-    # One of playhorizon's small runners, out of GitHub's shared pool: no checkout, no code of the pull request
-    # (docs/ci-runners.md). SELF_HOSTED_CI=off: GitHub's runners.
-    runs-on: ${{ vars.SELF_HOSTED_CI != 'off' && fromJSON('["self-hosted", "linux", "playhorizon-light"]') || 'ubuntu-latest' }}
+    runs-on: ubuntu-latest
     steps:
       - name: Cancel the pull request's unfinished runs
         env:

.github/workflows/ci.yml

@@ -24,23 +24,14 @@ env:
   HORIZON_TELEMETRY_URL: "off"
 
 jobs:
-  # One job, not one per check: each job takes a runner from the organisation's shared pool, and with every pull request
-  # and every merge to main starting this workflow, three jobs a run left the pool's queue tens of minutes deep.
-  #
-  # Where: GitHub's runners. With the repository variable SELF_HOSTED_CI=all (for when that pool is full: their 4 CPUs
-  # are about one GitHub runner, docs/ci-runners.md), main's pushes and this repository's own pull requests run on
-  # playhorizon's checks runners (label playhorizon-ci); a fork's pull request never does (and the runners refuse it
-  # themselves). There the build folder persists (CARGO_TARGET_DIR, outside the checkout), so the apt packages,
-  # Python and the Rust cache steps are GitHub's only.
   verify:
-    runs-on: ${{ vars.SELF_HOSTED_CI == 'all' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && fromJSON('["self-hosted", "linux", "playhorizon-ci"]') || 'ubuntu-latest' }}
-    timeout-minutes: 45
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: actions/setup-python@v5
-        if: runner.environment == 'github-hosted'
         with:
           python-version: '3.12'
       - name: Does this pull request need Rust checks?
@@ -50,33 +41,20 @@ jobs:
           BASE_SHA: ${{ github.event.pull_request.base.sha }}
           HEAD_SHA: ${{ github.event.pull_request.head.sha }}
         run: python3 tools/ci/rust_changes.py "$BASE_SHA" "$HEAD_SHA" >> "$GITHUB_OUTPUT"
-      # A pull request adds only its own commits to main, so it reads those; main's pushes read every ref's history.
       - name: Keep game artifacts out of Git
-        env:
-          EVENT: ${{ github.event_name }}
-          BASE_SHA: ${{ github.event.pull_request.base.sha }}
-          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
         run: |
           python tools/check_public_tree.py
-          if [ "$EVENT" = pull_request ]; then
-            python tools/check_public_tree.py --range "$BASE_SHA..$HEAD_SHA"
-          else
-            python tools/check_public_tree.py --history
-          fi
+          python tools/check_public_tree.py --history
       - name: Test offline research tooling
         run: python -m unittest discover -s tests -v
       - name: Install Rust toolchain and the ALSA and udev headers the client links against
         if: steps.rust.outputs.required != 'false'
-        env:
-          HOSTED: ${{ runner.environment == 'github-hosted' }}
         run: |
-          if [ "$HOSTED" = true ]; then
-            sudo apt-get update && sudo apt-get install -y --no-install-recommends libasound2-dev libudev-dev
-          fi
+          sudo apt-get update && sudo apt-get install -y --no-install-recommends libasound2-dev libudev-dev
           rustup toolchain install stable --profile minimal --component rustfmt --component clippy
       # Dependencies and the workspace's own build, saved from main's runs (pull requests read main's cache).
       - uses: Swatinem/rust-cache@v2
-        if: steps.rust.outputs.required != 'false' && runner.environment == 'github-hosted'
+        if: steps.rust.outputs.required != 'false'
         with:
           shared-key: verify
           save-if: ${{ github.ref == 'refs/heads/main' }}
@@ -89,8 +67,6 @@ jobs:
           cargo +stable clippy -p horizon-client --all-targets --no-default-features -- -D warnings
       # Libraries, binaries and integration tests, then doc tests: not the ~275 examples, which clippy above already
       # type-checks and the parity job builds and runs (they were most of this step's build and link time).
-      # cargo test, not nextest: nextest's process per test reloads each binary's shared tables for every test, and on
-      # these 4-core runners it was no faster (#4978).
       - name: Test Rust core and voxel kernel correctness
         if: steps.rust.outputs.required != 'false'
         run: |
@@ -103,8 +79,8 @@ jobs:
   # changes it or a crate it builds is checked here, and so is every push to main: two pull requests can each pass
   # alone and break it together (#2059 and the registry ratings did, 2026-10-26).
   launcher:
-    runs-on: ${{ vars.SELF_HOSTED_CI == 'all' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && fromJSON('["self-hosted", "linux", "playhorizon-ci"]') || 'ubuntu-latest' }}
-    timeout-minutes: 45
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - uses: actions/checkout@v4
         with:
@@ -118,16 +94,12 @@ jobs:
         run: python3 tools/ci/rust_changes.py --launcher "$BASE_SHA" "$HEAD_SHA" >> "$GITHUB_OUTPUT"
       - name: Install Rust and the headers GPUI links against
         if: steps.launcher.outputs.required != 'false'
-        env:
-          HOSTED: ${{ runner.environment == 'github-hosted' }}
         run: |
-          if [ "$HOSTED" = true ]; then
-            sudo apt-get update && sudo apt-get install -y --no-install-recommends libxkbcommon-x11-dev libwayland-dev \
-              libx11-xcb-dev libfontconfig-dev libvulkan-dev libasound2-dev libudev-dev
-          fi
+          sudo apt-get update && sudo apt-get install -y --no-install-recommends libxkbcommon-x11-dev libwayland-dev \
+            libx11-xcb-dev libfontconfig-dev libvulkan-dev libasound2-dev libudev-dev
           rustup toolchain install stable --profile minimal --component rustfmt --component clippy
       - uses: Swatinem/rust-cache@v2
-        if: steps.launcher.outputs.required != 'false' && runner.environment == 'github-hosted'
+        if: steps.launcher.outputs.required != 'false'
         with:
           workspaces: launcher
           shared-key: launcher
@@ -144,8 +116,7 @@ jobs:
   # a harness, an oracle, a probe or the runner, or carries the run-parity label (run-parity.yml, when it is added).
   parity-scope:
     if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository
-    # A git diff of this repository's own branch: one of playhorizon's small runners (docs/ci-runners.md).
-    runs-on: ${{ vars.SELF_HOSTED_CI != 'off' && fromJSON('["self-hosted", "linux", "playhorizon-light"]') || 'ubuntu-latest' }}
+    runs-on: ubuntu-latest
     outputs:
       run: ${{ steps.scope.outputs.run }}
     steps:

.github/workflows/claim-command.yml

@@ -29,8 +29,7 @@ jobs:
     # the skipped runs of ordinary comments must not cancel a waiting one.
     concurrency:
       group: claim-${{ github.event.issue.number }}
-    # One of playhorizon's small runners, out of GitHub's shared pool: main's script only (docs/ci-runners.md).
-    runs-on: ${{ vars.SELF_HOSTED_CI != 'off' && fromJSON('["self-hosted", "linux", "playhorizon-light"]') || 'ubuntu-latest' }}
+    runs-on: ubuntu-latest
     timeout-minutes: 5
     permissions:
       contents: read
@@ -56,8 +55,7 @@ jobs:
         run: python3 tools/ci/claim_command.py command
   release:
     if: github.event_name != 'issue_comment' && github.repository == 'horizon-rust/horizon'
-    # One of playhorizon's small runners, out of GitHub's shared pool: main's script only (docs/ci-runners.md).
-    runs-on: ${{ vars.SELF_HOSTED_CI != 'off' && fromJSON('["self-hosted", "linux", "playhorizon-light"]') || 'ubuntu-latest' }}
+    runs-on: ubuntu-latest
     timeout-minutes: 10
     permissions:
       contents: read

.github/workflows/game-build.yml

@@ -1,7 +1,6 @@
 name: game build
 # Builds the game for every platform from `ref`: the Java exporters, then Linux and the Linux server and Windows on
-# GitHub, macOS on the Mac mini's runner with a 1500-frame offscreen run of a new world (smoke-test.json): Apple
-# Silicon, and Intel cross-built there for x86_64-apple-darwin and checked under Rosetta 2 (#1161). Called by
+# GitHub, macOS on the Mac mini's runner with a 1500-frame offscreen run of a new world (smoke-test.json). Called by
 # release.yml (the releases) and nightly-build.yml (the opt-in Nightly), always from main's copy of this file: the
 # caller's commit, never the one being built. It holds no secrets: signing the checksums is the callers' own job,
 # which never runs what this one built. See docs/release-flow.md.
@@ -105,13 +104,6 @@ jobs:
             mac: true
             dir: horizon-macos-arm64
             asset: horizon-macos-arm64.zip
-          # Intel Macs: built on the same runner for another target; its checks and smoke test run the x86_64
-          # programs under Rosetta 2.
-          - name: macos-x64
-            mac: true
-            target: x86_64-apple-darwin
-            dir: horizon-macos-x64
-            asset: horizon-macos-x64.zip
     runs-on: ${{ matrix.mac && (inputs.trusted && vars.MAC_RUNNER || fromJSON('["self-hosted", "macOS", "horizon-nightly"]')) || matrix.os }}
     # Notarizing the zip can take a few minutes.
     timeout-minutes: ${{ matrix.mac && 60 || 40 }}
@@ -122,8 +114,6 @@ jobs:
       HORIZON_VERSION: ${{ inputs.version }}
       # A nightly's date and commit ("2026-10-28 0c02067"), which the game shows; empty for a release.
       HORIZON_NIGHTLY: ${{ inputs.nightly }}
-      # Where cargo puts the programs: target/release, or target/<target>/release for another target.
-      BIN: ${{ matrix.target && format('target/{0}/release', matrix.target) || 'target/release' }}
     defaults:
       run:
         shell: bash
@@ -138,8 +128,6 @@ jobs:
           # keeps its preparations outside the checkout.
           clean: true
       - uses: dtolnay/rust-toolchain@stable
-        with:
-          targets: ${{ matrix.target }}
       - uses: Swatinem/rust-cache@v2
         if: runner.environment == 'github-hosted'
         with:
@@ -150,11 +138,11 @@ jobs:
         if: runner.os == 'Linux'
         run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libasound2-dev libudev-dev
       - name: Build the client, horizon-ctl, horizon-prepare and horizon-server
-        run: cargo build --release --locked ${{ matrix.target && format('--target {0}', matrix.target) || '' }} -p horizon-client -p horizon-client-lib --bin horizon-client --bin horizon-ctl -p horizon-prepare --bin horizon-prepare -p horizon-server --bin horizon-server
+        run: cargo build --release --locked -p horizon-client --bin horizon-client --bin horizon-ctl -p horizon-prepare --bin horizon-prepare -p horizon-server --bin horizon-server
       - name: Every program the release folder takes was built
         run: |
           for binary in horizon-client horizon-ctl horizon-prepare horizon-server; do
-            test -f "$BIN/$binary${{ matrix.exe }}" || { echo "::error::$BIN/$binary${{ matrix.exe }} is missing"; exit 1; }
+            test -f "target/release/$binary${{ matrix.exe }}" || { echo "::error::target/release/$binary${{ matrix.exe }} is missing"; exit 1; }
           done
       - name: The signing keychain, unlocked
         if: runner.os == 'macOS' && vars.MACOS_SIGN_IDENTITY != '' && inputs.developer_id
@@ -169,15 +157,15 @@ jobs:
         run: |
           for binary in horizon-client horizon-ctl horizon-prepare horizon-server; do
             codesign --force --options runtime --timestamp --keychain "$MACOS_SIGN_KEYCHAIN" \
-              --identifier "dev.horizon.${binary#horizon-}" --sign "$MACOS_SIGN_IDENTITY" "$BIN/$binary"
-            codesign --verify --strict --verbose=2 "$BIN/$binary"
+              --identifier "dev.horizon.${binary#horizon-}" --sign "$MACOS_SIGN_IDENTITY" "target/release/$binary"
+            codesign --verify --strict --verbose=2 "target/release/$binary"
           done
       - name: Only system libraries
         # Windows: no non-system DLL (a "DLL not found" dialog on some players' machines). Linux: the standard
         # loader and libraries every desktop distribution has. macOS: only the system's own libraries.
         run: |
           for binary in horizon-client horizon-ctl horizon-prepare horizon-server; do
-            file="$BIN/$binary${{ matrix.exe }}"
+            file="target/release/$binary${{ matrix.exe }}"
             if [[ "$RUNNER_OS" == macOS ]]; then
               others=$(otool -L "$file" | tail -n +2 | awk '{print $1}' | grep -v -E '^(/usr/lib/|/System/Library/)' || true)
               [[ -z "$others" ]] || { echo "::error::$binary links $others"; exit 1; }
@@ -188,7 +176,7 @@ jobs:
       - name: Every program starts
         run: |
           set -euo pipefail
-          bin=$BIN
+          bin=target/release
           "$bin/horizon-client${{ matrix.exe }}" --help | grep -q -- '--resources'
           "$bin/horizon-ctl${{ matrix.exe }}" --help > /dev/null
           "$bin/horizon-prepare${{ matrix.exe }}" --help | grep -q -- '--minecraft-dir'
@@ -214,7 +202,7 @@ jobs:
           home="$RUNNER_TEMP/horizon-smoke"
           rm -rf "$home" && mkdir -p "$home"
           version=$(sed -n 's/.*"version": *"\([^"]*\)".*/\1/p' research-lock.json | head -1)
-          client="$PWD/$BIN/horizon-client"
+          client="$PWD/target/release/horizon-client"
           resources="$PWD/.local/horizon-client/$version"
           (cd "$home" && HORIZON_HOME="$home" HORIZON_NO_AUDIO=1 "$client" --resources "$resources" --offscreen \
             --world smoke --seed 1 --render-distance 4 --world-frames 1500 --timeout-seconds 180 \
@@ -229,9 +217,8 @@ jobs:
           EOF
           # Published with the release; the publish job checks it again before it publishes anything.
           cp "$home/smoke.json" "$RUNNER_TEMP/smoke-test.json"
-      # One smoke-test.json per build, the Apple Silicon one's; the Intel build must pass its own run too.
       - uses: actions/upload-artifact@v4
-        if: runner.environment == 'self-hosted' && !matrix.target
+        if: runner.environment == 'self-hosted'
         with:
           name: smoke-test.json
           path: ${{ runner.temp }}/smoke-test.json
@@ -244,7 +231,7 @@ jobs:
       - name: Package
         run: |
           set -euo pipefail
-          cargo run --locked -p xtask -- package "$BIN/horizon-client${{ matrix.exe }}" "dist/${{ matrix.dir }}"
+          cargo run --locked -p xtask -- package "target/release/horizon-client${{ matrix.exe }}" "dist/${{ matrix.dir }}"
           cd dist
           rm -f "${{ matrix.asset }}"
           case "${{ matrix.asset }}" in

.github/workflows/launcher.yml

@@ -8,11 +8,7 @@ name: launcher
 # feature. The version and the tag are given to the build (HORIZON_LAUNCHER_VERSION, HORIZON_LAUNCHER_TAG): no bump
 # commits.
 # Never marked latest. Pushes to launcher branches only build. RELEASES_PAUSED=1 stops releases.
-# Linux ships two archives of one binary: the .tar.gz the launcher updates itself from, and an
-# AppImage (packaging/linux/appimage.sh) for players without a distribution package, which replaces
-# itself instead (launcher/src/backend.rs).
-# macOS: Apple Silicon, and Intel cross-built for x86_64-apple-darwin on the same runner, its tests and smoke test
-# under Rosetta 2 (#1161). With the repository variable MACOS_SIGN_IDENTITY set, Horizon.app and the .dmg are signed with
+# macOS: with the repository variable MACOS_SIGN_IDENTITY set, Horizon.app and the .dmg are signed with
 # Developer ID, notarized and stapled, from the runner's signing keychain (packaging/macos/README.md);
 # unset (forks), they are signed ad hoc.
 #   gh workflow run launcher --ref <branch>                    # dry run: builds everything, publishes nothing
@@ -22,7 +18,7 @@ on:
   push:
     branches: [main, launcher, 'launcher-*']
     paths:
-      # Everything the launcher is built and packaged from, as tools/release_train.py's LAUNCHER_PATHS.
+      # Every crate the launcher builds in, as tools/release_train.py's LAUNCHER_PATHS.
       - 'launcher/**'
       - 'crates/horizon-bench/**'
       - 'crates/horizon-friends/**'
@@ -32,8 +28,6 @@ on:
       - 'crates/horizon-release-sign/**'
       - 'crates/horizon-telemetry/**'
       - 'crates/horizon-theme/**'
-      - 'packaging/linux/**'
-      - 'packaging/icons/**'
       - '.github/workflows/launcher.yml'
   schedule:
     - cron: '7-59/10 * * * *'
@@ -111,13 +105,6 @@ jobs:
             mac: true
             asset: horizon-launcher-macos-arm64.zip
             binary: horizon-launcher
-            mac_arch: arm64
-          - name: macos-x64
-            mac: true
-            target: x86_64-apple-darwin
-            asset: horizon-launcher-macos-x64.zip
-            binary: horizon-launcher
-            mac_arch: x64
           - name: windows
             os: windows-latest
             asset: horizon-launcher-windows-x64.zip
@@ -130,8 +117,6 @@ jobs:
     timeout-minutes: ${{ matrix.mac && 60 || 40 }}
     env:
       RUSTFLAGS: ${{ matrix.rustflags }}
-      # Where cargo puts the launcher: target/release, or target/<target>/release for another target.
-      BIN: ${{ matrix.target && format('target/{0}/release', matrix.target) || 'target/release' }}
       # Horizon's Azure app for Microsoft sign-in (docs/microsoft-account.md): a repository
       # variable, not a secret. Unset, the launcher says sign-in is not configured.
       HORIZON_MSA_CLIENT_ID: ${{ vars.HORIZON_MSA_CLIENT_ID }}
@@ -155,8 +140,6 @@ jobs:
           # parity jobs, and nothing they leave may end up in a launcher release (target/ is rebuilt from scratch).
           clean: true
       - uses: dtolnay/rust-toolchain@stable
-        with:
-          targets: ${{ matrix.target }}
       - uses: Swatinem/rust-cache@v2
         if: runner.environment == 'github-hosted'
         with:
@@ -166,7 +149,7 @@ jobs:
         if: runner.os == 'Linux'
         run: |
           sudo apt-get update
-          sudo apt-get install -y libxkbcommon-x11-dev libwayland-dev libx11-xcb-dev libfontconfig-dev libvulkan-dev libasound2-dev patchelf
+          sudo apt-get install -y libxkbcommon-x11-dev libwayland-dev libx11-xcb-dev libfontconfig-dev libvulkan-dev libasound2-dev
       - name: Metal shaders compiled now, or at run time without the Metal toolchain
         # GPUI compiles its Metal shaders when it builds; the Mac mini has Xcode without the Metal toolchain
         # (xcodebuild -downloadComponent MetalToolchain), so there they are compiled when the launcher starts.
@@ -177,17 +160,17 @@ jobs:
             echo "LAUNCHER_FEATURES=gpui/runtime_shaders" >> "$GITHUB_ENV"
           fi
       # Every test target (the library, the binary, tests/), on each system the launcher ships for.
-      - run: cargo test --release --locked ${{ matrix.target && format('--target {0}', matrix.target) || '' }} ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
-      - run: cargo build --release --locked ${{ matrix.target && format('--target {0}', matrix.target) || '' }} ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
+      - run: cargo test --release --locked ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
+      - run: cargo build --release --locked ${LAUNCHER_FEATURES:+--features "$LAUNCHER_FEATURES"}
       - name: The version is the release's
         run: |
-          out=$("$BIN/${{ matrix.binary }}" --version)
+          out=$(target/release/${{ matrix.binary }} --version)
           echo "$out"
           expected="${HORIZON_LAUNCHER_VERSION:-$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | head -1)}"
           [[ "$out" == "horizon-launcher $expected" ]] || { echo "::error::expected horizon-launcher $expected"; exit 1; }
       - name: Only system libraries
         run: |
-          file="$BIN/${{ matrix.binary }}"
+          file=target/release/${{ matrix.binary }}
           case "$RUNNER_OS" in
             Windows) python ../tools/check_imports.py "$file" ;;
             macOS) others=$(otool -L "$file" | tail -n +2 | awk '{print $1}' | grep -v -E '^(/usr/lib/|/System/Library/)' || true)
@@ -202,28 +185,13 @@ jobs:
           export HORIZON_LAUNCHER_HOME="${RUNNER_TEMP//\\//}/horizon-launcher-smoke"
           export HORIZON_HOME="$HORIZON_LAUNCHER_HOME/game"
           rm -rf "$HORIZON_LAUNCHER_HOME"
-          launcher="$PWD/$BIN/${{ matrix.binary }}"
+          launcher="$PWD/target/release/${{ matrix.binary }}"
           # GitHub's API rate-limits shared runner addresses now and then: try a few times.
           retry() { for i in 1 2 3 4; do "$@" && return 0; sleep $((i * 15)); done; return 1; }
           retry "$launcher" versions
-          "$launcher" links --json
-          # The Intel Mac launcher can come out before any game build has its asset (#1161): then there is nothing
-          # to install yet. Only that entry skips, and only on a version list that parsed and had no build here
-          # (exit 3); a launcher or a script that fails still fails the step.
-          if [[ "${{ matrix.name }}" == macos-x64 ]]; then
-            versions=$(retry "$launcher" --json versions)
-            no_build='import json, sys; sys.exit(3 if not any(r["available_here"] for r in json.load(sys.stdin)) else 0)'
-            status=0
-            python3 -c "$no_build" <<<"$versions" || status=$?
-            if [[ $status == 3 ]]; then
-              echo "::warning::No game build has an asset for ${{ matrix.name }} yet: install not tested"
-              rm -rf "$HORIZON_LAUNCHER_HOME"
-              exit 0
-            fi
-            [[ $status == 0 ]] || exit $status
-          fi
           retry "$launcher" install latest
           "$launcher" versions --installed
+          "$launcher" links --json
           # `install latest` is the Nightly since #3342 (versions/nightly-<date>-<commit>), a vX.Y.Z before.
           clients=("$HORIZON_LAUNCHER_HOME"/versions/*/horizon-client*)
           client="${clients[0]}"
@@ -256,18 +224,11 @@ jobs:
             # Developer ID): packaging/macos.
             python3 -m venv "$RUNNER_TEMP/dmg" && "$RUNNER_TEMP/dmg/bin/pip" install --quiet dmgbuild==1.6.5
             version=${HORIZON_LAUNCHER_VERSION:-$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | head -1)}
-            DMGBUILD="$RUNNER_TEMP/dmg/bin/dmgbuild" ../packaging/macos/package.sh "$BIN/${{ matrix.binary }}" "$version" out ${{ matrix.mac_arch }}
+            DMGBUILD="$RUNNER_TEMP/dmg/bin/dmgbuild" ../packaging/macos/package.sh target/release/${{ matrix.binary }} "$version" out
             rm -rf out/Horizon.app
           else
-            version=${HORIZON_LAUNCHER_VERSION:-$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | head -1)}
-            if [[ "$RUNNER_OS" == "Linux" ]]; then
-              # The .tar.gz below is what the launcher updates itself from; the AppImage is what a
-              # player downloads and double-clicks, and it replaces itself instead
-              # (packaging/linux/appimage.sh, launcher/src/backend.rs).
-              ../packaging/linux/appimage.sh "$BIN/${{ matrix.binary }}" "$version" out
-            fi
             mkdir -p dist
-            cp "$BIN/${{ matrix.binary }}" dist/
+            cp target/release/${{ matrix.binary }} dist/
             if [[ "${{ matrix.asset }}" == *.tar.gz ]]; then
               (cd dist && tar czf ../out/${{ matrix.asset }} ${{ matrix.binary }})
             else

.github/workflows/mojang-republish.yml

@@ -1,31 +0,0 @@
-name: mojang republish
-# Hourly: does Mojang's version manifest list a pinned-version JSON that research-lock.json does not know?
-# If so, one issue "Mojang republished <version>: <sha8>" with the hashes and a lock snippet
-# (tools/ci/mojang_republish.py). Reads only Mojang's public manifest.
-#   gh workflow run "mojang republish" -f dry_run=true
-on:
-  schedule:
-    - cron: '23 * * * *'  # hourly: a republished JSON breaks horizon-prepare for every new player until accepted
-  workflow_dispatch:
-    inputs:
-      dry_run:
-        description: Only print what it would do with issues
-        type: boolean
-        default: false
-permissions:
-  contents: read
-  issues: write
-concurrency:
-  group: mojang-republish
-  cancel-in-progress: false
-
-jobs:
-  check:
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-    steps:
-      - uses: actions/checkout@v4
-      - name: Check the manifest
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: python3 tools/ci/mojang_republish.py ${{ inputs.dry_run && '--dry-run' || '' }}

.github/workflows/native-hook-stamp.yml

@@ -1,55 +0,0 @@
-name: native hook stamp
-# Opens a PR that numbers pending fragments after they merge. Only pushes to
-# main run main's own tool; fragments are read as data, not PR code.
-
-on:
-  push:
-    branches: [main]
-    paths:
-      - 'tools/native-hook-fragments/*.json'
-
-permissions:
-  contents: read
-
-concurrency:
-  group: native-hook-stamp
-  cancel-in-progress: false
-
-jobs:
-  stamp:
-    if: github.repository == 'horizon-rust/horizon'
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-      pull-requests: write
-    timeout-minutes: 10
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: main
-          fetch-depth: 0
-      - name: Open a stamp pull request
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          set -eu
-          branch=automation/native-hook-stamp
-          if [ -n "$(gh pr list --state open --head "$branch" --json number --jq '.[0].number // empty')" ]; then
-            echo "A stamp pull request is already open."
-            exit 0
-          fi
-          python3 tools/stamp_native_hooks.py
-          if git diff --quiet; then
-            echo "No fragments to stamp."
-            exit 0
-          fi
-          git config user.name 'github-actions[bot]'
-          git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
-          git checkout -b "$branch"
-          git add -u
-          git commit -m 'Stamp native hook API fragments'
-          if git ls-remote --exit-code --heads origin "$branch" >/dev/null; then
-            git fetch origin "+refs/heads/$branch:refs/remotes/origin/$branch"
-          fi
-          git push --force-with-lease origin "$branch"
-          gh pr create --base main --head "$branch" --title 'Stamp native hook API fragments' --body 'Assign API numbers to the pending native hook fragments. Close and reopen this PR to run CI.'

.github/workflows/nightly-build.yml

@@ -172,8 +172,7 @@ jobs:
           EPHEMERAL: ${{ needs.pick.outputs.dry_run == 'true' && 'yes' || '' }}
         run: |
           bash tools/ci/sign_release.sh nightly dist/horizon-linux-x86_64.tar.gz dist/horizon-windows-x64.zip \
-            dist/horizon-macos-arm64.zip dist/horizon-macos-x64.zip dist/horizon-server-linux-x86_64.tar.gz \
-            dist/horizon-source.tar.gz
+            dist/horizon-macos-arm64.zip dist/horizon-server-linux-x86_64.tar.gz dist/horizon-source.tar.gz
       - uses: actions/upload-artifact@v4
         with:
           name: signature
@@ -234,10 +233,9 @@ jobs:
           # before the Nightly-only switch keep (they don't read Nightlies).
           gh release create nightly --prerelease --latest=false --target "$SHA" \
             --title "Nightly $DATE · ${SHA:0:7}" --notes-file dist/nightly-notes.md \
-            "dist/horizon-linux-x86_64.tar.gz#Game files the launcher installs (Nightly): Linux (horizon-linux-x86_64.tar.gz)" \
-            "dist/horizon-windows-x64.zip#Game files the launcher installs (Nightly): Windows (horizon-windows-x64.zip)" \
-            "dist/horizon-macos-arm64.zip#Game files the launcher installs (Nightly): macOS on Apple Silicon (horizon-macos-arm64.zip)" \
-            "dist/horizon-macos-x64.zip#Game files the launcher installs (Nightly): macOS on Intel (horizon-macos-x64.zip)" \
+            "dist/horizon-linux-x86_64.tar.gz#Nightly game files: Linux (horizon-linux-x86_64.tar.gz)" \
+            "dist/horizon-windows-x64.zip#Nightly game files: Windows (horizon-windows-x64.zip)" \
+            "dist/horizon-macos-arm64.zip#Nightly game files: macOS (horizon-macos-arm64.zip)" \
             "dist/horizon-server-linux-x86_64.tar.gz#Nightly dedicated server for Linux (horizon-server-linux-x86_64.tar.gz)" \
             "dist/horizon-source.tar.gz#Source of this Nightly, commit ${SHA:0:7} (horizon-source.tar.gz; kept for good as the tag $SOURCE_TAG)" \
             dist/SHA256SUMS "${signature[@]}" dist/smoke-test.json

.github/workflows/overlap-note.yml

@@ -19,9 +19,7 @@ jobs:
     concurrency:
       group: overlap-note-${{ github.event.pull_request.number }}
       cancel-in-progress: true
-    # One of playhorizon's small runners, out of GitHub's shared pool: it runs main's script only (above), so a fork's
-    # pull request runs none of its code there (docs/ci-runners.md). SELF_HOSTED_CI=off: GitHub's runners.
-    runs-on: ${{ vars.SELF_HOSTED_CI != 'off' && fromJSON('["self-hosted", "linux", "playhorizon-light"]') || 'ubuntu-latest' }}
+    runs-on: ubuntu-latest
     timeout-minutes: 10
     permissions:
       contents: read

.github/workflows/pack-bench.yml

@@ -1,61 +0,0 @@
-name: pack load bench
-# How long resource packs take to load: crates/horizon-client-render/examples/pack_load_bench.rs on generated packs
-# (no game files), on the branch and then on `base` with the branch's copy of the bench, on the same runner, so a pull
-# request can show its numbers next to main's. Started by hand, or by a push to a `pack-bench/*` branch (a fork can't
-# start a workflow its main lacks), against horizon-rust/horizon's main.
-on:
-  push:
-    branches: ['pack-bench/**']
-  workflow_dispatch:
-    inputs:
-      base:
-        description: Ref to compare against
-        default: main
-      scale:
-        description: How many times the default pack sizes
-        default: '1'
-permissions:
-  contents: read
-env:
-  HORIZON_TELEMETRY_URL: "off"
-  CARGO_TERM_COLOR: never
-
-jobs:
-  bench:
-    runs-on: ubuntu-latest
-    timeout-minutes: 90
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-      - name: Install Rust and the ALSA and udev headers
-        run: |
-          sudo apt-get update && sudo apt-get install -y --no-install-recommends libasound2-dev libudev-dev
-          rustup toolchain install stable --profile minimal
-      - uses: Swatinem/rust-cache@v2
-        with:
-          shared-key: pack-bench
-      - name: Bench the branch
-        env:
-          SCALE: ${{ inputs.scale || '1' }}
-        run: |
-          cargo run --profile fast -p horizon-client-render --example pack_load_bench -- --scale "$SCALE" > head.md
-      - name: Bench the base, with the branch's bench
-        env:
-          BASE: ${{ inputs.base || 'main' }}
-          SCALE: ${{ inputs.scale || '1' }}
-        run: |
-          git fetch https://github.com/horizon-rust/horizon.git "$BASE"
-          git worktree add ../base FETCH_HEAD
-          cp crates/horizon-client-render/examples/pack_load_bench.rs ../base/crates/horizon-client-render/examples/
-          # A bench row that times a function the base lacks keeps it from building there: then
-          # the branch's own rows compare the two ways.
-          (cd ../base && CARGO_TARGET_DIR="$GITHUB_WORKSPACE/target" cargo run --profile fast -p horizon-client-render \
-            --example pack_load_bench -- --scale "$SCALE") > base.md \
-            || echo "The bench does not build on the base." > base.md
-      - name: Summary
-        run: |
-          {
-            echo "### Branch ($(git rev-parse --short HEAD))"; cat head.md
-            echo; echo "### Base (${{ inputs.base || 'main' }})"; cat base.md
-          } | tee -a "$GITHUB_STEP_SUMMARY"

.github/workflows/pr-labels.yml

@@ -16,9 +16,7 @@ jobs:
   label:
     # Title-only edits change nothing: skip them before a runner starts.
     if: github.event.action != 'edited' || github.event.changes.body != null
-    # One of playhorizon's small runners, out of GitHub's shared pool: it runs main's script only (above), so a fork's
-    # pull request runs none of its code there (docs/ci-runners.md). SELF_HOSTED_CI=off: GitHub's runners.
-    runs-on: ${{ vars.SELF_HOSTED_CI != 'off' && fromJSON('["self-hosted", "linux", "playhorizon-light"]') || 'ubuntu-latest' }}
+    runs-on: ubuntu-latest
     timeout-minutes: 5
     permissions:
       contents: read

.gitignore

@@ -21,7 +21,6 @@
 .DS_Store
 # What the client writes to its working directory when run from the repo root.
 /options.txt
-/debug-profile.json
 /horizon.txt
 /horizon-graphics.txt
 /horizon-controller.txt

AGENTS.md

@@ -30,7 +30,6 @@ Feature → files → harness for the most-changed areas: [docs/architecture.md]
   change), none for a fix. Agents never add `release-now`: the maintainer decides it. Merges ship in batches of 5, or after
   6 hours ([docs/release-flow.md](docs/release-flow.md)).
 - Contributors first: `gh pr list --state open --search <area>` before you start; never duplicate theirs.
-- **No hardcoded user-facing strings.** Keep UI translation-ready from the start. In the launcher (`launcher/`), wrap visible text with `tr("...")` or `trf("... {arg} ...", &[("arg", &val)])` from `crate::i18n` instead of raw string literals or `format!`. In the game, use translation keys (`Text::tr`, `lang::get`), never hardcoded English strings.
 - **Claim before you start**: comment `/claim` on the issue (no issue yet: open one, then claim it). An assigned
   issue is taken: pick another. `/unclaim` when you stop; a claim with no open PR linking it is released after 5 days.
 
@@ -40,8 +39,7 @@ Game workspace (root `Cargo.toml`); `launcher/` and `crates/horizon-telemetry-se
 
 | Crate | Owns |
 |---|---|
-| `horizon-client` | Gameplay library (`src/lib.rs`: `game.rs` + `game/`, `entry.rs`) and thin executable (`src/main.rs`). Also the dedicated server (`--dedicated`). Re-exports `horizon-client-lib` for existing mod paths. |
-| `horizon-client-lib` | Reusable client systems, `horizon-ctl`, probes and their tests. Its manifest points to the existing sources under `crates/horizon-client/`; the library root is `src/client_lib.rs`. It never depends on gameplay. |
+| `horizon-client` | The game: a lib (`src/lib.rs`, ~100 flat modules: gameplay, networking, title screens) and the bin (`src/main.rs` → `game.rs` + `game/`), plus `horizon-ctl` (`src/bin/horizon-ctl/`). Also the dedicated server (`--dedicated`) |
 | `horizon-items` | Blocks and items below gameplay: `blocks.rs` (block facts), `items.rs`, `item_data.rs` (components), `enchant.rs`, `cooldowns.rs`, `bundle.rs`, `item_nbt.rs`. Re-exported as `horizon_client::items`... |
 | `horizon-command` | Command parsing (Brigadier): the vanilla tree, argument types, selectors, suggestions, the tree's network form. Re-exported as `horizon_client::command` |
 | `horizon-client-core` | The client lib's bottom layer: `text.rs`, `lang.rs`, `snbt.rs`, `nbt_path.rs`, `component.rs`, `scoreboard.rs`, `bossbar.rs`, `gamerules.rs`, `block_entity_nbt.rs`, registry/particle/sound tables. Re-exported under the old paths (`horizon_client::text`...) |
@@ -54,11 +52,9 @@ Game workspace (root `Cargo.toml`); `launcher/` and `crates/horizon-telemetry-se
 | `horizon-prepare` | Builds `.local/horizon-client/26.3` from the player's own Minecraft install (runs the Java exporters) |
 | `horizon-server` | `horizon-server`: `server.toml`, CLI, supervisor of the headless game ([docs/hosting.md](docs/hosting.md)) |
 | `horizon-server-files` | `server.properties`, eula, ops/whitelist/bans, usercache |
-| `horizon-anticheat` | The dedicated server's anticheat, off by default: `[anticheat]` settings, violation levels, the checks' rules; the hub runs them (`lan/anticheat.rs`) ([docs/anticheat.md](docs/anticheat.md)) |
 | `horizon-friends`, `horizon-relay` | Play with Friends: invite codes, encrypted tunnel, the relay ([docs/play-with-friends.md](docs/play-with-friends.md)) |
 | `horizon-mods`, `cargo-horizon-mod` | Content mods (`.hmod`: manifest, content fence, no code), the registry index and `.hpack`, and `cargo horizon-mod` (`new`, `build`, `run`, `check`, `registry`) ([docs/mods.md](docs/mods.md)). Code mods are native, built by the launcher ([docs/native-mods.md](docs/native-mods.md)) |
 | `horizon-port-pack` | Porting Java modpacks ([docs/modpacks.md](docs/modpacks.md)) |
-| `horizon-optifine` | OptiFine-format pack files below every feature that reads them: `.properties`, the name/range/block matchers, paths and `optifine/` folders, and custom entity models (`cem/`: `.jem`/`.jpm` parsing and baking) |
 | `horizon-shader-api` | Horizon's own WGSL shader packs ([docs/api/shaders.md](docs/api/shaders.md)): `horizon-shaders.toml`, the `.hshader` package; shared by the game, the launcher and the registry |
 | `horizon-shaders` | Shader packs (the `shaders/` folder format), rebuilt clean-room from a written spec of the format; no wgpu |
 | `horizon-theme` | Design tokens and fonts for the launcher, the game's own menus and the website |
@@ -71,23 +67,13 @@ unittest discover -s tests`), `mods/horizon/src/test/java/dev/horizonlab/parity/
 `docs/`, `.github/workflows/`. The website (playhorizon.dev) is the private horizon-rust/horizon-site: its build
 reads `README.md`, `launcher/links.json`, `docs/api/`, `roadmap/roadmap.json` and `crates/horizon-theme/tokens.css` from main.
 
-## Write tests with signal
-
-- Test observable behavior, not words in docs, comments or source. Keep checks for machine-consumed contracts.
-- Use independent expected values or a vanilla oracle; do not derive the answer from the code under test.
-- Test outcomes, not only calls to stubs. Use mocks to isolate behavior, not as the behavior itself.
-- Skip tests of trivial constants, derives and getters, or behavior already covered by another test.
-- Avoid pinning implementation details; a harmless refactor should not break a behavior test.
-- Make slow tests faster without removing cases or weakening their coverage.
-- Never delete parity harnesses or tests that pin vanilla behaviour: they are the spec.
-
 ## Build and test fast
 
 ```sh
 python3 tools/pr_ready.py                  # the self-check: fmt, clippy -D warnings, touched crates' tests, harnesses; paste its block in the PR
 python3 tools/pr_ready.py --quick          # same without harnesses
-cargo test -p horizon-client -p horizon-client-lib --lib --bins --tests   # skips the 104 examples (pr_ready does this); `--doc` separately
-cargo test -p horizon-client-lib --lib mod_content::tests:: -- --ignored   # the 5 slow content-root tests, #[ignore]d; pr_ready runs them when mod content, assets, blocks or items change
+cargo test -p horizon-client --lib --bins --tests   # skips the 104 examples (pr_ready does this); `--doc` separately
+cargo test -p horizon-client --lib mod_content::tests:: -- --ignored   # the 5 slow content-root tests, #[ignore]d; pr_ready runs them when mod content, assets, blocks or items change
 cargo build --profile fast -p horizon-client        # optimized, quick to link: use it to play or run lan_e2e
 python3 tools/parity.py --changed origin/main       # the harnesses your branch can affect (CI's parity job)
 python3 tools/parity.py --changed-files paths.txt --list   # which harnesses cover these files, without running them
@@ -104,11 +90,8 @@ python3 tools/agent_control_e2e.py         # horizon-ctl / MCP end to end
   or the game binary with a fixture env var (`game/dispense_fixture.rs`, `game/sculk_fixture.rs`,
   `game/command_harness.rs`, `game/net_harness.rs`). Copy a nearby harness for a new one.
 - Probes build into `.local/parity-target/`; harnesses find binaries via `lab.cargo_target()`, never `target/`.
-- Harness selection uses Cargo dep-info and reachable-code narrowing (`tools/parity_reach.py`).
-  `horizon-client-lib` builds the control tool and client probes without gameplay; their dep-info
-  excludes `game.rs` and `game/`, so gameplay edits do not rebuild or select those probes.
-  Source paths remain in `crates/horizon-client/`. Measure actual harness selection on refreshed
-  records with `tools/parity.py --changed-files paths.txt --list`; historical counts are not a guarantee.
+- What a change reruns (of 329 harnesses, measured 2026-10-23): a file of the game binary (`game.rs`, `game/`)
+  ~25, a file of the client lib ~103, of `horizon-world` ~103–109, of `horizon-core` ~119. Plan for it.
 - Rust integration tests: `crates/horizon-client/tests/` (`lan_bot.rs`, `generation_saves.rs`, `streaming_meshes.rs`).
 - Linux needs `libasound2-dev libudev-dev`; `--no-default-features` drops audio and controllers (the server build).
 - Run and drive the game (starts the `horizon-client` beside `horizon-ctl`; other arguments go to the game):
@@ -133,11 +116,8 @@ python3 tools/agent_control_e2e.py         # horizon-ctl / MCP end to end
 ## horizon-client: where things live
 
 `L:` = lib (`crates/horizon-client/src/`, or `crates/horizon-client-render/src/` for the modules that crate holds, under
-the same `horizon_client::<module>` paths), `G:` = gameplay (`crates/horizon-client/src/game/`), also in the lib in normal builds.
-Gameplay keeps its `horizon_client::<module>` imports through a self-crate alias. The executable
-contains only the allocator, mod API marker and a call to `entry::main`. For unit tests, the lib
-excludes `entry` and `game`, and the executable test target owns `game` so its process-wide test
-state stays separate from the library tests. This compiles gameplay twice for executable tests.
+the same `horizon_client::<module>` paths), `G:` = bin (`crates/horizon-client/src/game/`). The lib can't see
+`Game`; bin code reaches the lib as `horizon_client::<module>`.
 
 | Subsystem | Files |
 |---|---|
@@ -155,11 +135,11 @@ state stays separate from the library tests. This compiles gameplay twice for ex
 | Multiplayer client | L: `net.rs` (network thread); G: `remote.rs` (`fn handle_packet`, `fn tick_remote`), `remote_*.rs` (mob data, objects, projectiles, vehicles, stations) |
 | LAN host / server side | L: `lan/` (`conn.rs` handshake + login threads, `hub.rs` + `hub/` play state, `chunks.rs`, `entity.rs`, `tracking.rs`, `guest.rs`, `playerdata.rs`); G: `lan.rs` (`LanHost`), `lan_actions.rs` (`fn as_guest`, `fn tick_guests`), `lan_*.rs` per feature, `lan_entities.rs` (tracked entities) |
 | Integrated server | G: `integrated.rs` (the server thread), `levels.rs` (one level per dimension, `fn tick_server`), `server_travel.rs` |
-| Dedicated server | G: `dedicated.rs`, `dedicated/status.rs`; crates `horizon-server-files`, `horizon-server`, `horizon-anticheat` (L: `lan/anticheat.rs`) |
+| Dedicated server | G: `dedicated.rs`, `dedicated/status.rs`; crates `horizon-server-files`, `horizon-server` |
 | Save and load | L: `save.rs` (level.dat, regions, playerdata), `entity_nbt.rs`, `options_file.rs`; `horizon-client-core/src/block_entity_nbt.rs`; G: `saving.rs`, `persist.rs` (entities); `crates/horizon-world/src/{region.rs,nbt.rs,datafix/}` |
 | Input | game.rs `fn window_event`, `fn key_pressed`, `fn play_mouse`; crate `horizon-client-input` (`keybinds.rs`, `keymapping.rs`, `key_names.rs`, `mouse.rs`, `input.rs`, `interaction_input.rs`, `gamepad.rs`, `clipboard.rs`); L: `osk.rs`; G: `pad.rs`, `pad_menu.rs` |
 | Audio | L: `audio.rs` (mixer), `sound_engine.rs`, `sound_events.rs`, `music.rs`, `ambience.rs`; G: `music.rs`, `subtitle_hud.rs` |
-| Resource packs | L: `packs.rs` + `packs/`, `pack_screen.rs`, `atlas_sources.rs`, `sprites.rs`, `mipmap.rs`, `model_library.rs`, `font.rs`, `mobs/cem.rs` + `mobs/cem_anim.rs` (OptiFine/EMF entity models and their animations); `horizon-client-core/src/lang.rs`; crates `horizon-assets`, `horizon-optifine`; G: `packs.rs` |
+| Resource packs | L: `packs.rs` + `packs/`, `pack_screen.rs`, `atlas_sources.rs`, `sprites.rs`, `mipmap.rs`, `model_library.rs`, `font.rs`; `horizon-client-core/src/lang.rs`; crate `horizon-assets`; G: `packs.rs` |
 | Agent control | L: `control.rs` (socket), `bin/horizon-ctl/`; G: `control.rs`, `agent.rs`, `events.rs`, `ui_control.rs` ([docs/agent-control.md](docs/agent-control.md)) |
 | Mods | crate `horizon-mods`; G: `mods.rs`; L: `mod_content.rs`, `mod_list.rs` |
 | Horizon extras, settings | L: `extras.rs`, `graphics.rs`, `settings.rs`, `minimap.rs`; G: `extras.rs`, `tweaks.rs`, `options.rs` |
@@ -168,7 +148,7 @@ state stays separate from the library tests. This compiles gameplay twice for ex
 
 - `struct Game` (game.rs, ~290 fields) holds everything. Its methods are spread over ~180 files: game.rs keeps
   the core (tick, render, input, inventory, world open/close) and each `game/<feature>.rs` adds an
-  `impl Game<'_>` block for one feature, with its own state types. Fields stay private to the gameplay module and its descendants. Gameplay tests run in the gameplay library, separate from reusable-library tests.
+  `impl Game<'_>` block for one feature, with its own state types. Fields are private to the bin.
 - Find a feature's code: `grep -rn "fn tick_<thing>\|fn <verb>_<thing>" crates/horizon-client/src/game*`;
   the file is usually `game/<thing>s.rs`. Who calls it: grep the name in game.rs's `fn tick` / `fn tick_world`.
 - Fields that say which mode runs: `remote` (this window is a client of a server: multiplayer, LAN guest, or

CONTRIBUTING.md

@@ -2,7 +2,7 @@
 
 Thanks for helping. Horizon is Minecraft: Java Edition 26.3 rewritten in Rust, and the one rule that shapes
 everything is that **it plays exactly like vanilla**. This page is the short version of how we work; questions are
-welcome on [Discord](https://discord.gg/playhorizon).
+welcome on [Discord](https://discord.gg/HcTeMZxe5E).
 
 This repository holds the game and the launcher, plus the tools, tests and docs that build, check and release them.
 The website (playhorizon.dev) is built in a separate repository from this one's README, `docs/api/` and roadmap. Anything else (videos, Discord and other community material) lives elsewhere.
@@ -47,31 +47,14 @@ them (`git config core.hooksPath .githooks` runs it before every commit).
 The pre-push hook checks the full history reachable from the branches and tags being pushed. Run
 `python3 tools/check_public_tree.py --history` to audit the history of all local refs.
 
-## Only original code, or code whose license allows it
+## Only original code
 
-Horizon is MIT. Its code is written from Minecraft 26.3 itself and from public documentation. Since 30 October 2026
-another project's source may also be read and used, **only when that project's license allows it**:
-
-- **Allowed:** MIT, MIT-0, BSD-2-Clause, BSD-3-Clause, 0BSD, ISC, zlib, Apache-2.0, Unlicense, and the CC0-1.0
-  public-domain dedication. That code may be read, copied or adapted.
-- **Everything else is off limits, even to read:** GPL, LGPL (Iris), AGPL, MPL, EPL, Polyform (Sodium), the Creative
-  Commons licenses (CC BY, CC BY-SA, CC BY-NC and the others; CC0 is a public-domain dedication, not one of them),
-  custom or "source available" licenses, all rights reserved (OptiFine), and any project with no license or an
-  unclear one. Don't read, copy, translate or paraphrase their source, and don't send code an AI tool
-  wrote from it. Being able to download a mod or a pack does not give you the right to read its files.
-- **Check the license yourself.** Read the LICENSE file at the commit you use and the header of each file you take:
-  some repositories mix licenses, and a file under another license is off limits. A license that changed: the one
-  at your commit counts. In doubt, don't: ask in #contributors first.
-- **Say it in the pull request:** the project, a link to the commit, its license, and what you read or copied. A
-  pull request that used another project's source without saying so is closed.
-- **Copied or adapted code** keeps its copyright line and license notice at the top of the file, and gets an entry
-  in [THIRD_PARTY_NOTICES.md](THIRD_PARTY_NOTICES.md). Apache-2.0 code also keeps its NOTICE text and says what
-  was changed.
-
-User documentation and file formats are fine to read, and packs and mods are fine to run and observe, whatever
-their license. Shader packs were removed on 24 October 2026 (#1561) because their code had been written from
-another project's source; they come back only as a clean-room rewrite from a written description of the pack
-format.
+Horizon's code is written from Minecraft 26.3 itself and from public documentation, never from another mod, loader
+or renderer. Don't read, copy, translate or paraphrase the source of Iris, OptiFine, Sodium or any other project,
+and don't send code an AI tool wrote from it. Their user documentation and file formats are fine to read, and their
+packs and mods are fine to run and observe. Shader packs were removed on 24 October 2026 (#1561) because their code
+had been written from another project's source; they come back only as a clean-room rewrite from a written
+description of the pack format.
 
 ## Before asking for review
 
@@ -99,8 +82,7 @@ claimed on Discord with Kira's `/claim`): pick another, or ask its holder in the
 enough), then claim it. `/unclaim` gives it back.
 
 A claim with no open pull request linking the issue (`Fixes #123` in the description, or a draft) is released after
-5 days, with a comment: open a draft early. You can hold 8 open issues at a time, not counting the ones your
-pull requests already fix. Agents claim the same way.
+5 days, with a comment: open a draft early. You can hold 5 open issues at a time. Agents claim the same way.
 
 When your pull request changes the same functions as another open one, or closes the same issue, a bot comment names
 it (edited on every push, never repeated): talk to its author in the thread before you both finish the same work.
@@ -113,10 +95,6 @@ it (edited on every push, never repeated): talk to its author in the thread befo
   can see.
 - **Tick "Allow edits by maintainers".** When something small is left (a lint, a rebase, a nit) we push the fixup
   ourselves instead of sending it back to you; only design questions come back.
-- **Once we've pushed to your branch, merge main into it; don't rebase or force-push.** A rebase or force-push
-  replaces our commits with yours and erases the fixes we added (it happened on #5188 and #5203). Tell your agent
-  too: `git merge origin/main`, never `git rebase` or `git push --force` on a branch a maintainer has touched. If
-  our fixes get erased anyway, we finish the work in our own pull request that keeps your commits and credits you.
 - **Tick its kind** in the template: `parity` (Horizon now does what vanilla does), `bug` (a crash or breakage),
   `perf`, `feature` (new for players), `extra` (Horizon-only, off by default), `tooling` or `docs`. A workflow sets
   that label, and area labels (`launcher`, `mobs`, `worldgen`, `rendering`...) from the paths you change.
@@ -140,5 +118,5 @@ new pushes, we add it again.
 
 ## Talk to us
 
-[Discord](https://discord.gg/playhorizon) for questions and ideas, [issues](https://github.com/horizon-rust/horizon/issues)
+[Discord](https://discord.gg/HcTeMZxe5E) for questions and ideas, [issues](https://github.com/horizon-rust/horizon/issues)
 for bugs. To take something on, `/claim` its issue ([above](#claim-before-you-start)).

Cargo.toml

@@ -1,22 +1,18 @@
 [workspace]
-exclude = ["launcher", "crates/horizon-telemetry-server", "crates/horizon-mod-registry", "third_party/wgpu-hal", "third_party/naga"]
+exclude = ["launcher", "crates/horizon-telemetry-server", "crates/horizon-mod-registry", "third_party/wgpu-hal"]
 members = [
     "crates/horizon-core",
     "crates/horizon-dualsense",
-    "crates/horizon-narrator",
     "crates/horizon-threads",
     "crates/horizon-hdr",
     "crates/horizon-world",
     "crates/horizon-client",
-    "crates/horizon-client-lib",
     "crates/horizon-client-core",
     "crates/horizon-client-input",
     "crates/horizon-client-render",
     "crates/horizon-command",
     "crates/horizon-items",
     "crates/horizon-server-files",
-    "crates/horizon-anticheat",
-    "crates/horizon-chat-filter",
     "crates/horizon-server",
     "crates/horizon-bots",
     "crates/horizon-assets",
@@ -31,7 +27,6 @@ members = [
     "crates/cargo-horizon-mod",
     "crates/horizon-port-pack",
     "crates/horizon-shaders",
-    "crates/horizon-optifine",
     "crates/horizon-shader-api",
     "crates/horizon-release-sign",
     "xtask",
@@ -57,14 +52,9 @@ large_enum_variant = "allow"
 # UHD 620/630) crashes on it with an access violation (#746). It also fixes the
 # Metal backend's lookup of the CoreGraphics HDR colour space names, which handed
 # CoreGraphics a symbol's address as the string and crashed HDR output on macOS.
-# And gfx-rs/wgpu#10714: on Windows, Vulkan waits for the acquire fence only in
-# FIFO (VSync), where it was meant to pace frames; with VSync off it made every
-# frame wait for the GPU to finish the one before (#4604).
-# Drop this and the folder once a wgpu release has these fixes.
+# Drop this and the folder once a wgpu release has both fixes.
 [patch.crates-io]
 wgpu-hal = { path = "third_party/wgpu-hal" }
-# naga 30.0.1, with the fixes to its GLSL frontend that shader packs need (THIRD_PARTY_NOTICES.md).
-naga = { path = "third_party/naga" }
 
 # Line tables keep file:line in backtraces; full debug info made every
 # example and test binary hundreds of megabytes and slow to link.

README.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="docs/media/banner.webp" alt="The Horizon website: the game you know, rebuilt in Rust" width="100%">
+  <img src="docs/media/banner.webp" alt="Horizon: Minecraft: Java Edition 26.3, rewritten in Rust and checked against vanilla by more than 300 differential harnesses" width="100%">
 </p>
 
 <p align="center">
@@ -24,32 +24,34 @@
 
 # Horizon
 
-Minecraft: Java Edition 26.3, rewritten in Rust. Same worlds, same rules, same terrain, checked against the Java game by more than 300 differential harnesses. Free, open source and unofficial.
+Horizon is Minecraft: Java Edition 26.3 rewritten in Rust: a native game that reads the same worlds, follows the same rules and generates the same terrain as the Java game, and is checked against it by more than 300 differential harnesses. You play it through a small launcher, on the files from your own copy of Minecraft. It is free, open source and unofficial.
 
-> Not an official Minecraft product, nor approved by or associated with Mojang or Microsoft. Horizon contains no Minecraft code, assets or data: you need your own copy of Java Edition 26.3.
+> Not an official Minecraft product. Not approved by or associated with Mojang or Microsoft. Horizon contains no Minecraft code, assets or data: you need your own legally obtained copy of Minecraft: Java Edition 26.3.
 
 ## Download
 
-Get **the Horizon launcher** from [playhorizon.dev](https://playhorizon.dev) or [the launcher releases](https://github.com/horizon-rust/horizon/releases?q=launcher-v&expanded=true) (Linux x86-64, macOS on Apple Silicon, macOS on Intel from the next Nightly, Windows x64). It installs and updates the game, prepares its files from your copy of Minecraft, and updates itself.
+Horizon is installed through **the Horizon launcher**. Get it from [playhorizon.dev](https://playhorizon.dev) (the Download button picks your system) or from [the launcher releases](https://github.com/horizon-rust/horizon/releases?q=launcher-v&expanded=true), for Linux x86-64, macOS on Apple Silicon or Windows x64. The launcher installs the game and keeps it up to date with each new build (Horizon ships on one channel, the Nightly), prepares its files from your copy of Minecraft (your own install, or downloaded from Mojang for your account), and updates itself.
 
-**You need** a Microsoft account that owns Java Edition ([why](docs/microsoft-account.md)) and a GPU with Vulkan or OpenGL 3.3 (Linux), Vulkan or DirectX 12 (Windows), or a Mac (Apple Silicon, or Intel from the next Nightly). An existing Minecraft install (official launcher, Prism, MultiMC...) is reused; without one, Play downloads 26.3 from Mojang for your account. Step by step: [Install and first launch](https://playhorizon.dev/docs/install).
+**You need** a Microsoft account that owns Minecraft: Java Edition (the launcher signs in with it, as other launchers do; see [Microsoft account](docs/microsoft-account.md)) and a GPU with Vulkan or OpenGL 3.3 on Linux, Vulkan or DirectX 12 on Windows, or any Apple Silicon Mac. Nothing else: with no Minecraft on your computer, Play downloads 26.3 and the Java it needs from Mojang for your account, as the official launcher does, then prepares it once. An install you already have (the official launcher, Prism, MultiMC and other launchers all work) is used instead. Step by step, with macOS's first-open prompt and the first launch: [Install and first launch](https://playhorizon.dev/docs/install).
 
 <table>
   <tr>
-    <td width="50%"><img src="docs/media/launcher-play.webp" alt="The launcher's Home page: the selected instance ready to play, the version picker, Join a friend and the instance's tabs"></td>
-    <td width="50%"><img src="docs/media/launcher-settings.webp" alt="The launcher's Settings page: Microsoft account, offline name, updates, appearance and accent colour"></td>
+    <td width="50%"><img src="docs/media/launcher-play.webp" alt="The launcher's Play page: a version ready to play, its summary, Client and Server, the version picker and Play"></td>
+    <td width="50%"><img src="docs/media/launcher-patch-notes.webp" alt="The launcher's Patch notes page"></td>
   </tr>
 </table>
 
 ## What works today
 
-- **The game:** vanilla world generation, mobs, villagers, raids, redstone, every command, the HUD and the recipe book, on vanilla saves. Worlds from 1.8 to 26.2 are upgraded. [Status](#project-status).
-- **Extras:** new menus, graphics presets, distant terrain up to 1024 chunks, controllers, zoom, minimap and more, off by default where they change the vanilla look. [Settings](https://playhorizon.dev/docs/settings).
-- **Packs:** resource packs, and data packs with functions, predicates, item modifiers and world generation.
-- **Multiplayer:** invite friends with a code, Open to LAN, join servers (online mode included). [Multiplayer](https://playhorizon.dev/docs/multiplayer).
-- **Mods:** content mods (blocks, items, data) and native Rust mods, built by the launcher with nothing to install. Java mod jars do not run. [Mods](https://playhorizon.dev/docs/mods).
+The [documentation](https://playhorizon.dev/docs/) covers each of these.
 
-In the Rust client, with vanilla assets and no mods or shaders:
+- **The game:** singleplayer with vanilla's world generation, mobs, villagers, raids, redstone, every command, the HUD and the recipe book, on saves in vanilla's format. Worlds from 1.8 to 26.2 are upgraded as vanilla does. [Status table](#project-status).
+- **Horizon's own extras:** new menus (vanilla's are one setting away), graphics presets, distant terrain up to 1024 chunks, controller support, optional zoom, minimap and more, all off by default where they would change the vanilla look. See [Settings](https://playhorizon.dev/docs/settings).
+- **Resource packs and data packs:** resource packs work, and data packs load functions, predicates, item modifiers and world generation (vanilla's heights and biomes for now).
+- **Playing with others:** invite friends from the pause menu's Friends button with a code, Open to LAN, and joining servers, online-mode ones with the Microsoft account the launcher signs in with. See [Multiplayer](https://playhorizon.dev/docs/multiplayer).
+- **Mods:** content mods add blocks, items and data, and native mods change the game's own Rust code, built by the launcher on your copy, with no Rust to install. Horizon's own (Zoom, FPS Counter, Keystrokes, Minimap, Recipes and Coordinates HUD) are native mods. Java mod jars do not run in Horizon. See [Mods and data packs](https://playhorizon.dev/docs/mods).
+
+Screenshots, captured in the Rust client itself with vanilla assets and no mods or shaders:
 
 <table>
   <tr>
@@ -67,15 +69,15 @@ In the Rust client, with vanilla assets and no mods or shaders:
 
 ## Host a server
 
-The launcher's **Servers** page creates, starts, backs up and updates a server, and invites friends over Tailscale. On a VPS, `horizon-server` installs with one command and needs no Java. [Host a server](https://playhorizon.dev/docs/hosting) ([reference](docs/hosting.md)).
+The launcher's **Servers** page creates, starts, backs up and updates a Horizon server with buttons, and invites friends over Tailscale. On a VPS, `horizon-server` installs with one command and runs without Java. Guide: [Host a server](https://playhorizon.dev/docs/hosting) ([reference](docs/hosting.md)).
 
 ## Modpacks
 
-The launcher imports Modrinth and CurseForge packs and plays the mods Horizon can carry over: today, content mods made of data and assets, not Java code. [Modpacks](https://playhorizon.dev/docs/modpacks).
+The launcher's **Modpacks** page imports a Modrinth or CurseForge pack, shows which of its mods Horizon can carry over, and plays the ones it can as their own profile. Today that means content mods made of data and assets; mods with Java code are not ported yet. See [Modpacks](https://playhorizon.dev/docs/modpacks).
 
 ## Agent control
 
-AI agents and scripts can play Horizon. `horizon-ctl`, shipped with the game, reads its state as JSON and acts like a player; `horizon-ctl mcp` serves the same commands over MCP.
+AI agents and scripts can play Horizon. `horizon-ctl`, shipped beside the game in every release folder, is a command line that reads the game as JSON and acts like a player; `horizon-ctl mcp` serves the same commands as an MCP server (one tool per command, screenshots returned as images).
 
 ```sh
 horizon-ctl launch --world Survival --seed 5 --wait   # finds the version the launcher installed
@@ -86,14 +88,16 @@ horizon-ctl break -1 65 -3                              # mines it; replies with
 horizon-ctl open-inventory && horizon-ctl click-slot 0  # menus: slots, buttons by label, text fields
 ```
 
-Commands block until done and reply with the result; `horizon-ctl help` lists them all. [Agent control](docs/native-client.md#agent-control-horizon-ctl-and-mcp).
+Commands block until the action is done and reply with what happened; errors are JSON with distinct exit codes, `horizon-ctl help` lists every command and `horizon-ctl COMMAND --help` explains one with examples. It talks to the game over a Unix socket on Linux and macOS and over a token-protected localhost port on Windows. See [Agent control in the native client guide](docs/native-client.md#agent-control-horizon-ctl-and-mcp).
 
 ## Build from source
 
-Needs Rust 1.90+, Python 3.10+, JDK 25, and on Linux `libasound2-dev libudev-dev`. `horizon-prepare` builds the game's resources from **your own copy** of Java Edition 26.3 (checked against `research-lock.json`) and never downloads it:
+For developers. Requirements: Rust 1.90 or newer, Python 3.10 or newer, JDK 25, and on Linux the ALSA and udev development headers (`libasound2-dev libudev-dev` on Debian and Ubuntu). Development and the vanilla harnesses run on Linux.
 
-1. **Client:** play 26.3 once in the official launcher. Horizon reads `~/.minecraft` (or `--minecraft-dir` / `HORIZON_MINECRAFT_DIR`).
-2. **Server jar:** the 26.3 server jar (`downloads.server.url` in `versions/26.3/26.3.json`), passed once with `--server-jar` or `HORIZON_SERVER_JAR`.
+Horizon contains no game files, and `horizon-prepare` never downloads them (the launcher downloads them from Mojang only for a signed-in account that owns the game). It builds its resources from **your own copy** of Minecraft: Java Edition 26.3, verified against the checksums in `research-lock.json`:
+
+1. **Client:** install Java Edition with the official launcher and play 26.3 once. Horizon reads `versions/26.3/`, `libraries/` and `assets/` from the launcher's game directory (`~/.minecraft` on Linux). If yours lives elsewhere, pass `--minecraft-dir` or set `HORIZON_MINECRAFT_DIR`.
+2. **Server jar:** the 26.3 server jar, from the `downloads.server.url` in your launcher's `versions/26.3/26.3.json` (or [minecraft.net/download/server](https://www.minecraft.net/en-us/download/server) while 26.3 is the current release). Pass it with `--server-jar` or set `HORIZON_SERVER_JAR`. It is only needed the first time.
 
 ```sh
 git clone https://github.com/horizon-rust/horizon.git
@@ -103,57 +107,72 @@ cargo run --release -p horizon-prepare -- sounds   # optional: sounds from your
 cargo run --release -p horizon-client
 ```
 
-Prepared files land in the gitignored `.local/`: never commit or share them. Options, controls and architecture: [the native client guide](docs/native-client.md); all developer docs: [docs/README.md](docs/README.md).
+Everything prepared lands in the gitignored `.local/`. It is derived from the game: never commit it or share it.
+
+The client starts on the title screen. Command-line options (`--world`, `--seed`, `--creative`, `--render-distance`, `--dedicated`), controls, scripting through `horizon-ctl` and the architecture are described in [the native client guide](docs/native-client.md). The rest of the developer documentation is indexed in [docs/README.md](docs/README.md), including [the parity workflow](docs/parity-workflow.md).
 
 ## Roadmap
 
-What is in progress, what comes next and where to help: [ROADMAP.md](ROADMAP.md), or [playhorizon.dev/hub](https://playhorizon.dev/hub) with the work board and what shipped.
+What is being done now, what comes next and where you can help, in plain words and in technical detail: [ROADMAP.md](ROADMAP.md). [playhorizon.dev/hub](https://playhorizon.dev/hub) shows it with the work board, the journal of what shipped and how to help.
 
 ## Contributing
 
-Issues and pull requests are welcome: read [CONTRIBUTING.md](CONTRIBUTING.md) (vanilla first, small pull requests). Questions: [Discord](https://discord.gg/playhorizon). Before a pull request, run the self-check and paste its output:
+Issues and pull requests are welcome: see [CONTRIBUTING.md](CONTRIBUTING.md) for how we work (vanilla first, small pull requests, labels), or [the contributing guide](https://playhorizon.dev/docs/contributing) on the site. Questions and ideas: [Discord](https://discord.gg/HcTeMZxe5E). Before opening a pull request, run the self-check and paste the block it prints:
 
 ```sh
 git config core.hooksPath .githooks
 python3 tools/pr_ready.py
 ```
 
-It runs rustfmt, clippy, the touched crates' tests, the Python tests, the public-tree check and the vanilla harnesses your change affects. Never commit game files, decompiled source or prepared resources.
+It runs rustfmt, clippy with warnings denied, the tests of the crates you touched, the Python tests, the public-tree check, and the vanilla harnesses your change can affect. CI runs the same checks on GitHub's Linux runners; the vanilla harnesses need the game, which Horizon never downloads, so they run on a maintainer's computer holding their own copy. Never commit game files, decompiled source or prepared resources: `tools/check_public_tree.py` rejects them, and tracked Java is allowed only under the project's own `dev/horizonlab` namespace.
 
 ## Project status
 
 **Player-visible gaps: 833 open** of the 833 the [port ledger](tools/port_ledger.py) found, reading every vanilla 26.3 method against Horizon's code: vanilla behaviour a player would notice that Horizon doesn't have yet. By area: Screens, HUD and client packets [197](https://github.com/horizon-rust/horizon/issues/3518); Entity and block rendering, models [129](https://github.com/horizon-rust/horizon/issues/3519); Animals [110](https://github.com/horizon-rust/horizon/issues/3512); Server and players on the server [106](https://github.com/horizon-rust/horizon/issues/3520); Blocks, redstone and fluids [86](https://github.com/horizon-rust/horizon/issues/3516); Entities, projectiles, vehicles and decorations [64](https://github.com/horizon-rust/horizon/issues/3514); Monsters and bosses [53](https://github.com/horizon-rust/horizon/issues/3513); Mob AI, villagers and raids [35](https://github.com/horizon-rust/horizon/issues/3521); World, world generation and saves [32](https://github.com/horizon-rust/horizon/issues/3517); Items, enchantments and inventories [21](https://github.com/horizon-rust/horizon/issues/3515). This number goes down as gaps close (`tools/parity_gaps.py`); the harness results below say that what is tested matches.
 
-The table is the project's own audit: every subsystem matches vanilla in every harness that compares it. 100% means 100% of what the harnesses compare, not that nothing else differs.
+The table below is the project's own audit of each subsystem. Every subsystem now matches vanilla in every harness that compares it. 100% means 100% of what the harnesses compare, not proof that nothing else differs. The remaining known differences are listed below.
 
 ### Java parity: 100%
 
-Scores: 0 (absent), 0.25 (started), 0.5 (playable, major features missing), 0.75 (mostly complete) or 1 (complete and verified by differential tests); the percentage is their average. Last audited 2026-10-13: all 281 harnesses pass on Linux and macOS. The [port ledger](tools/port_ledger.py) adds a method-by-method view of what is ported.
+Each subsystem scores 0 (absent), 0.25 (started, not playable), 0.5 (playable,
+major vanilla features missing), 0.75 (playable, mostly complete) or 1 (complete
+and verified against vanilla by differential tests). The percentage is the
+average; `tests/test_parity.py` keeps it in sync with this table. Last audited
+2026-10-13 against the harness results: all 281 harnesses pass on Linux, each
+rerun whenever one of its inputs changed, and the Mac mini now runs every one of
+them too (Rust uses Java's own float maths on each platform).
+
+The harnesses measure behaviour. A second measure is method by method: the [port ledger](tools/port_ledger.py)
+lists every method of vanilla 26.3 next to the Rust functions that port it, with a verdict for each one
+(ported, folded into another function, missing, or needing no port), and the untested ports. Run
+`python3 tools/port_ledger.py build`, then `coverage`, with the vanilla data in `.local/`.
 
 | Subsystem | Score | Main gaps |
 | --- | ---: | --- |
-| Window, input and game loop | 1 | None: game loop, options, camera, auto-jump, toggle sprint/sneak and frame limiter match |
-| Assets and resources | 1 | None: item models match over 196,290 stacks; the resource pack screen over 3,000 sessions |
-| Network protocol and multiplayer | 1 | None: joins vanilla servers; the dedicated server matches vanilla's files, login, configuration, play and command tree; LAN discovery over 462 cases (offline mode only) |
+| Window, input and game loop | 1 | None: the game loop, options, camera, auto-jump, toggle sprint/sneak, local input and the frame limiter match vanilla |
+| Assets and resources | 1 | None: item models match vanilla over 196,290 stacks and the client draws every item through them; the resource pack screen matches vanilla's drawing over 3,000 sessions of clicks, scrolling and searching, its incompatibility confirmation included |
+| Network protocol and multiplayer | 1 | None: joins vanilla servers; the dedicated server (`--dedicated`) matches vanilla's files, status ping, login, configuration, play, chunks, chat, recipes, advancements and command tree, a client built from vanilla's packet code joins it, Horizon joins a vanilla server, and LAN discovery matches over 462 cases (offline mode only) |
 | Chunk storage and palettes | 1 | None: client and saves share paletted containers, identical to vanilla over 266 scenarios |
 | Section meshing | 1 | None: 112 scenes and over a million quads identical to vanilla |
-| Rendering | 1 | None: entity models, block entity renderers (407 cases) and animations (296), HUD overlays (2,200 states), the recipe book (600), player list, subtitles and world border match |
+| Rendering | 1 | None: entity models, block entity renderers (407 cases, End portals, gateways and the loom's banner preview included) and their animations (296 cases, End gateway beams included), the HUD overlays (2,200 states), the recipe book (600 states), the player list, subtitles and the world border match vanilla |
 | Lighting | 1 | None: saved and relit light matches vanilla, slabs and stairs included |
 | World generation | 1 | None: 2,352 whole chunks over 225 structure sites, in all three dimensions, identical to vanilla |
-| Region files and saves | 1 | None: saves round-trip with vanilla; worlds from 1.8 to 26.2 upgrade as vanilla's DataFixers do |
-| Entities and physics | 1 | None: attributes, spawn rules, natural spawning (15,500 cases), raids and patrols (1,900), `finalizeSpawn` (24,000) and mob AI (92 scenarios) match |
-| Interaction and inventory | 1 | None: menu clicks over 8,000 sequences; recipe book placement (6,000), buttons (1,200), saved book (1,500), loom and crafter screens (1,600) |
-| Menus, HUD and chat | 1 | None: every command (758 over 39,685 inputs), scoreboards (81,000 operations), the player list (872,000 draw calls), chat and its suggestions (3,000 sessions) match |
+| Region files and saves | 1 | None: saves round-trip with vanilla, and worlds from 1.8 to 26.2 upgrade as vanilla's DataFixers do, superflat worlds included; old options.txt and hotbar.nbt files are upgraded too |
+| Entities and physics | 1 | None: attributes, dimensions, death loot, spawn rules, natural spawning (15,500 cases), raids and patrols (1,900 cases), spawned mobs' gear, enchantments and state (`finalizeSpawn`, 24,000 cases) and mob AI (92 scenarios: villager breeding and gossip, the warden, ghastlings and copper golems included) match vanilla |
+| Interaction and inventory | 1 | None: menu clicks match over 8,000 click sequences, the loom and the crafter included; recipe book placement (6,000 cases), its buttons (1,200), the saved book (1,500) and the loom and crafter screens (1,600) match vanilla |
+| Menus, HUD and chat | 1 | None: every command runs as vanilla (758 commands over 39,685 parsed inputs), scoreboards and teams match (81,000 operations), the player list matches over 872,000 draw calls with heads drawn from players' skins (authlib's textures, SkinManager's lookup, legacy skin conversion), and the chat matches focused and scrolled; the resource pack screen (selection over 4,000 cases, drawing and its incompatibility confirmation over 3,000 sessions) and the chat input with its command suggestions, usage lines, Tab completion and history (3,000 sessions on vanilla's client command tree) match vanilla |
 | Audio | 1 | None: the sound engine, sound events, music, situational music, ambience and subtitles match vanilla |
-| Block behaviours and ticking | 1 | None: block updates, random ticks, redstone, dispensers (6,000 cases), crafters (4,000), container spills (4,000), copper golems and the sculk family (435 scenarios) match |
+| Block behaviours and ticking | 1 | None: block updates, random ticks, redstone, dispensers (6,000 cases), crafters (4,000 crafts), block entity removal (containers spill, 4,000 cases), copper golem chest sorting and the sculk family (435 scenarios: shrieker warnings and warden summoning included) match vanilla |
 
 ### Known issues
 
-Skins served over https show the default skin unless already cached; pack icons show the unknown-pack texture in game; item tooltips lack attribute lines.
+Skins served over https show the default skin unless already cached; pack icons show the unknown-pack texture in game; the creative hotbar keys (C/X) aren't wired to the hotbar loader; item tooltips lack attribute lines.
 
 ## Licence
 
-[MIT](LICENSE), for the project's original work; dependencies keep their own licences ([notices](THIRD_PARTY_NOTICES.md)). Minecraft is a trademark of Mojang Synergies AB; its code and assets belong to Mojang and Microsoft under the [Minecraft EULA](https://www.minecraft.net/en-us/eula).
+[MIT](LICENSE), for the project's original work only. Dependencies keep their own licences. Minecraft is a trademark of Mojang Synergies AB; Minecraft code and assets belong to Mojang and Microsoft and are covered by the [Minecraft EULA](https://www.minecraft.net/en-us/eula). Decompiled game source and prepared resources stay on your machine and are never published.
+
+Third-party credits and licenses: [Third-party notices](THIRD_PARTY_NOTICES.md).
 
 ## Author
 

ROADMAP.md

@@ -76,9 +76,9 @@ Owner: [levzzz5154](https://github.com/levzzz5154) · Tracking: [#3911](https://
 
 <details><summary>Technical</summary>
 
-One item for all modding work ([#3911](https://github.com/horizon-rust/horizon/issues/3911)), led by levzzz5154 with vladislav_hagen; the order between the parts is theirs. Native mods on stable hook points (game/native_hooks.rs, [#3345](https://github.com/horizon-rust/horizon/issues/3345), [#3346](https://github.com/horizon-rust/horizon/issues/3346), [#3434](https://github.com/horizon-rust/horizon/issues/3434), [#3435](https://github.com/horizon-rust/horizon/issues/3435)) built by the launcher ([#3388](https://github.com/horizon-rust/horizon/issues/3388), [#3855](https://github.com/horizon-rust/horizon/issues/3855)); server-side hooks ([#3878](https://github.com/horizon-rust/horizon/issues/3878), [#3706](https://github.com/horizon-rust/horizon/issues/3706)); mod-owned screens, input and drawing; tools for mod makers (templates, `native.py check`); the registry ([#1634](https://github.com/horizon-rust/horizon/issues/1634), [#1642](https://github.com/horizon-rust/horizon/issues/1642), [#1659](https://github.com/horizon-rust/horizon/issues/1659)); machines with inventories and menus ([#1189](https://github.com/horizon-rust/horizon/issues/1189)); mods that read and change the world through the server. [docs/native-mods.md](docs/native-mods.md).
+One item for all modding work ([#3911](https://github.com/horizon-rust/horizon/issues/3911)), led by levzzz5154 with vladislav_hagen; the order between the parts is theirs. Native mods on stable hook points (game/native_hooks.rs, [#3345](https://github.com/horizon-rust/horizon/issues/3345), [#3346](https://github.com/horizon-rust/horizon/issues/3346), [#3434](https://github.com/horizon-rust/horizon/issues/3434), [#3435](https://github.com/horizon-rust/horizon/issues/3435)) built by the launcher ([#3388](https://github.com/horizon-rust/horizon/issues/3388), [#3855](https://github.com/horizon-rust/horizon/issues/3855)); server-side hooks ([#3878](https://github.com/horizon-rust/horizon/issues/3878), [#3706](https://github.com/horizon-rust/horizon/issues/3706)); mod-owned screens, input and drawing; tools for mod makers (templates, `native.py check`); the registry ([#1634](https://github.com/horizon-rust/horizon/issues/1634), [#1642](https://github.com/horizon-rust/horizon/issues/1642), [#1659](https://github.com/horizon-rust/horizon/issues/1659)); machines with inventories and menus ([#1189](https://github.com/horizon-rust/horizon/issues/1189)); mods that read and change the world through the server. The WebAssembly runtime is removed ([#3350](https://github.com/horizon-rust/horizon/issues/3350), [#3351](https://github.com/horizon-rust/horizon/issues/3351), [#3353](https://github.com/horizon-rust/horizon/issues/3353)). [docs/native-mods.md](docs/native-mods.md).
 
-More: [#3351](https://github.com/horizon-rust/horizon/issues/3351) · [#3353](https://github.com/horizon-rust/horizon/issues/3353) · [#3360](https://github.com/horizon-rust/horizon/issues/3360) · [#1596](https://github.com/horizon-rust/horizon/issues/1596) · [#1635](https://github.com/horizon-rust/horizon/issues/1635)
+More: [#3360](https://github.com/horizon-rust/horizon/issues/3360) · [#1596](https://github.com/horizon-rust/horizon/issues/1596) · [#1635](https://github.com/horizon-rust/horizon/issues/1635)
 
 </details>
 
@@ -326,11 +326,11 @@ A mapping table from intermediary and SRG names so pre-26.1 jars can be classifi
 
 #### A modpack's own resource and shader packs
 
-Imported modpacks carry their resource packs into a profile of their own. Shader-pack conversion is still pending.
+Importing a modpack also brings the resource packs and shader packs it ships with, where Horizon can use them.
 
 <details><summary>Technical</summary>
 
-Resource-pack carry-over is implemented locally: Modrinth common/client overrides, CurseForge's override folder, installed instances (ZIP and directory packs), and hash-checked indexed ZIP downloads. The launcher keeps profile edits and lets resource-only profiles play; packs are enabled in Resource Packs. Synthetic import and profile tests cover the file pipeline; in-game rendering has not been verified. Shader-pack conversion is still pending, so this combined item remains partial ([docs/modpacks.md](docs/modpacks.md)).
+Porting a pack carries data, assets and worldgen today; the resource packs and shader packs bundled with it are left out. Resource packs can be carried as they are; shader packs go through the converter ([docs/modpacks.md](docs/modpacks.md)).
 
 </details>
 
@@ -490,7 +490,7 @@ Small mods written as scripts, in the style of KubeJS, with no compiler.
 
 <details><summary>Technical</summary>
 
-Waits for native mods to settle: a script layer over the native hook points is to be designed.
+Waits for native mods to settle: the earlier plan ran Lua inside the WebAssembly sandbox, which is removed. A script layer over the native hook points is to be designed.
 
 More: [docs/native-mods.md](docs/native-mods.md)
 
@@ -718,7 +718,7 @@ Versions of Horizon for Android, iOS and web browsers. Nothing official yet; con
 
 <details><summary>Technical</summary>
 
-No official build. Android was first closed as not planned, with touch controls, a mobile interface, packaging and loading the player's own assets all missing; the roadmap now includes it, iOS and a build for the browser as long-term goals. First pieces from contributors: `horizon-dualsense` compiling on iOS ([#1813](https://github.com/horizon-rust/horizon/issues/1813)) and helper-thread limits on Android ([#1751](https://github.com/horizon-rust/horizon/issues/1751)). Preparing without Java ([#1750](https://github.com/horizon-rust/horizon/issues/1750)) matters here too. Horizon ships none of Mojang's files on any platform.
+No official build. Android was first closed as not planned, with touch controls, a mobile interface, packaging and loading the player's own assets all missing; the roadmap now includes it, iOS and a WebAssembly build for the browser as long-term goals. First pieces from contributors: `horizon-dualsense` compiling on iOS ([#1813](https://github.com/horizon-rust/horizon/issues/1813)) and helper-thread limits on Android ([#1751](https://github.com/horizon-rust/horizon/issues/1751)). Preparing without Java ([#1750](https://github.com/horizon-rust/horizon/issues/1750)) matters here too. Horizon ships none of Mojang's files on any platform.
 
 </details>
 
@@ -742,13 +742,13 @@ Open: the GUI Scale is clamped to 2 after a restart under Hyprland, while XWayla
 
 </details>
 
-#### A Nix flake
+#### AppImage and a Nix flake
 
-Install Horizon on NixOS through a Nix flake.
+Install Horizon on any Linux distribution as an AppImage, and on NixOS through a Nix flake.
 
 <details><summary>Technical</summary>
 
-A player's idea (#horizon-ideas). The launcher's AppImage ships with each launcher release ([packaging/linux/appimage.sh](packaging/linux/appimage.sh)): one file with the libraries GPUI needs, which replaces itself when it updates. A flake.nix packaging the release binaries with their runtime libraries (Vulkan loader, X11/Wayland, ALSA) is still missing, the way horizon-parity's NixOS setup runs them today.
+A player's idea (#horizon-ideas). An AppImage of the launcher and game from the release workflow, and a flake.nix packaging the release binaries with their runtime libraries (Vulkan loader, X11/Wayland, ALSA), the way horizon-parity's NixOS setup runs them today.
 
 </details>
 

THIRD_PARTY_NOTICES.md

@@ -3,17 +3,10 @@
 ## wgpu-hal
 
 `third_party/wgpu-hal` is [wgpu-hal](https://github.com/gfx-rs/wgpu) 30.0.1 by the gfx-rs
-developers, with upstream fixes applied
-([gfx-rs/wgpu#10124](https://github.com/gfx-rs/wgpu/pull/10124),
-[gfx-rs/wgpu#10714](https://github.com/gfx-rs/wgpu/pull/10714)). It is licensed under MIT or
+developers, with one upstream fix applied
+([gfx-rs/wgpu#10124](https://github.com/gfx-rs/wgpu/pull/10124)). It is licensed under MIT or
 Apache-2.0; both licenses are in that folder (`LICENSE.MIT`, `LICENSE.APACHE`).
 
-## naga
-
-`third_party/naga` is [naga](https://github.com/gfx-rs/wgpu) 30.0.1 by the gfx-rs developers, with
-fixes to its GLSL frontend that shader packs need, each applied in the commit that needed it. It is licensed under MIT or Apache-2.0; both licenses
-are in that folder (`LICENSE.MIT`, `LICENSE.APACHE`).
-
 ## Pixelify Sans
 
 `crates/horizon-theme/fonts/PixelifySans-*.ttf` is [Pixelify Sans](https://github.com/eifetx/Pixelify-Sans)
@@ -26,92 +19,3 @@ by The Pixelify Sans Project Authors, licensed under the SIL Open Font License 1
 [Pixelarticons](https://github.com/halfmage/pixelarticons) by Gerrit Halfmann, under the MIT
 license (`crates/horizon-theme/icons/pixel/LICENSE-pixelarticons.txt`). `star.svg` is Horizon's own, drawn on
 the same grid.
-
-## AMD FidelityFX SDK (FSR 3.1 frame generation)
-
-`crates/horizon-client-render/src/gfx/frame_gen/optical_flow.wgsl` and `interpolation.wgsl` are
-ports to WGSL of the optical flow and frame interpolation shaders of the
-[AMD FidelityFX SDK](https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK) 1.1.4
-(`sdk/include/FidelityFX/gpu/{opticalflow,frameinterpolation}`, at commit
-[c6efa6bf7f20](https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/tree/c6efa6bf7f2027b3ec94f28578bb5965eabb9e55)),
-and `optical_flow.rs` follows the SDK's `sdk/src/components/opticalflow/ffx_opticalflow.cpp`
-(its passes, their order and their dispatch sizes). Copyright (C) 2024 Advanced Micro Devices,
-Inc., under the MIT license, whose text heads each file. AMD and FidelityFX are AMD's
-trademarks; Horizon is not affiliated with AMD.
-
-## Mod loader logos
-
-The launcher shows the logo of the mod loader an instance plays with.
-
-- `launcher/assets/logos/quilt.png` is the Quilt mini icon (`brand/128png/quilt_mini_icon_transparent.png`)
-  from [QuiltMC/art](https://github.com/QuiltMC/art), by the Quilt Project, dedicated to the public
-  domain under [CC0 1.0](https://creativecommons.org/publicdomain/zero/1.0/).
-- `launcher/assets/logos/neoforge.png` is NeoForged's icon (`art/neoforged_icon_16x16.png`) from
-  [neoforged/.github](https://github.com/neoforged/.github/tree/main/art), © the NeoForged team,
-  created by Ridanisaurus, under [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/). It is
-  unmodified (the launcher scales it up by whole pixels).
-- Fabric's and Forge's icons are not shipped: neither publishes a license for its logo. The launcher
-  fetches them from their own sites when an instance needs them
-  ([fabric-loader's icon](https://github.com/FabricMC/fabric-loader/blob/master/src/main/resources/assets/fabricloader/icon.png),
-  [files.minecraftforge.net's](https://files.minecraftforge.net/)).
-
-Each logo belongs to its project. Showing it says which loader an instance runs; it does not mean
-the project endorses Horizon.
-
-## Sign in with Microsoft
-
-The launcher's sign-in buttons follow Microsoft's published branding guidelines for apps that sign in
-with Microsoft accounts
-([Sign in with Microsoft branding](https://learn.microsoft.com/en-us/entra/identity-platform/howto-add-branding-in-apps)).
-The four-square Microsoft symbol in `launcher/src/microsoft.rs` reproduces the squares, positions and
-colours of Microsoft's official `ms-symbollockup_mssymbol_19.svg` from that page, unmodified. Microsoft
-and its logo are trademarks of the Microsoft group of companies; Horizon is not endorsed by Microsoft.
-
-## CIT Resewn
-
-`crates/horizon-optifine/src/cit.rs` and `crates/horizon-client-render/src/cit.rs` follow the
-condition semantics of [CIT Resewn Continuation](https://github.com/EthanVisagie/CIT-Resewn-Continuation-1.21.11)
-(at `b792f9a`), a continuation of [CIT Resewn](https://github.com/SHsuperCM/CITResewn) by SHsuperCM: the
-1.21 component paths, enchantment levels, percent damage, text matching and rule ordering. It is
-licensed under the MIT license:
-
-> Copyright (c) 2021 SHsuperCM
->
-> Permission is hereby granted, free of charge, to any person obtaining a copy of this software
-> and associated documentation files (the "Software"), to deal in the Software without
-> restriction, including without limitation the rights to use, copy, modify, merge, publish,
-> distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the
-> Software is furnished to do so, subject to the following conditions:
->
-> The above copyright notice and this permission notice shall be included in all copies or
-> substantial portions of the Software.
->
-> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING
-> BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-> NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-> DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-> OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-## FusionExamples
-
-The tile tables in `crates/horizon-optifine/src/fusion/layout.rs` were read off the connecting
-texture templates (`templates/template <layout>.png`) of
-[FusionExamples](https://github.com/SuperMartijn642/FusionExamples) (at `8c9c56e`), which is
-licensed under the MIT license:
-
-> Copyright (c) 2024 Martijn van den Brand
->
-> Permission is hereby granted, free of charge, to any person obtaining a copy of this software
-> and associated documentation files (the "Software"), to deal in the Software without
-> restriction, including without limitation the rights to use, copy, modify, merge, publish,
-> distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the
-> Software is furnished to do so, subject to the following conditions:
->
-> The above copyright notice and this permission notice shall be included in all copies or
-> substantial portions of the Software.
->
-> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING
-> BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-> NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-> DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-> OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

bench/bench.py

@@ -1,457 +0,0 @@
-#!/usr/bin/env python3
-"""Server load bench: the same horizon-bots load on Horizon, vanilla 26.3 or Pumpkin.
-
-    python3 bench/bench.py --server horizon --exe target/release/horizon-server --bots 50
-    python3 bench/bench.py --server vanilla --jar ~/mc/server.jar --bots 50 --pre-generated ~/worlds/seed12345
-    python3 bench/bench.py --server pumpkin --exe ./pumpkin --bots 50
-
-Every run uses a fresh scratch folder (bound to 127.0.0.1, offline, creative so the bots can fly), starts the
-server, lets `horizon-bots` join one every --join-every seconds, warms up, then measures for --seconds:
-
-- TPS: `time query gametime` at the start and the end of the window, as game ticks per wall-clock second;
-- MSPT: `tick query` every 5 s (average, P50, P95, P99 over the last 100 ticks), averaged over the window;
-- RSS and CPU of the server's whole process tree, once a second (needs `ps`: Linux and macOS);
-- bandwidth: `bytes_in`/`bytes_out` from the bots' report, per player and second online (each bot's whole time
-  on the server, its join included), when the bots report them (they do not yet: the field is null until S-6); join time: the bots' `joined_after_ms`.
-
-It writes one JSON report (--out) and prints the Markdown table of the design (docs/design.md, section 1).
-
-Vanilla is the owner's own server.jar (--jar): nothing of Mojang's is fetched or committed. Pumpkin is a released
-binary run as a black box (--exe); its Bedrock listeners, LAN broadcast and telemetry are turned off in the
-config this script writes (--pumpkin-config adds a TOML file of your own on top if a release names a key
-differently). `--pre-generated DIR` copies a finished world into every run's scratch folder as `world`, so runs
-repeat on the same terrain. Build the bots first: cargo build --release -p horizon-bots
-"""
-
-import argparse
-import datetime
-import json
-import os
-from pathlib import Path
-import platform
-import re
-import shutil
-import socket
-import statistics
-import subprocess
-import sys
-import tempfile
-import threading
-import time
-
-ROOT = Path(__file__).resolve().parent.parent
-EXE = '.exe' if os.name == 'nt' else ''
-SERVERS = ('horizon', 'vanilla', 'pumpkin')
-
-PROPERTIES = {
-    'level-seed': '12345',
-    'view-distance': '10',
-    'simulation-distance': '10',
-    'online-mode': 'false',
-    'white-list': 'false',
-    'gamemode': 'creative',
-    'force-gamemode': 'true',
-    'spawn-protection': '0',
-    'max-players': '200',
-    'difficulty': 'easy',
-    'server-ip': '127.0.0.1',
-    'enable-query': 'false',
-    'enable-rcon': 'false',
-}
-
-# Pumpkin's two config files. Bedrock, LAN broadcast and telemetry (plugins' included) are off.
-PUMPKIN_CONFIGURATION = '''\
-server_address = "127.0.0.1:{port}"
-seed = "{seed}"
-max_players = 200
-view_distance = {view}
-simulation_distance = {view}
-online_mode = false
-default_difficulty = "Easy"
-allow_chat_reports = false
-encryption = false
-lan_broadcast = false
-
-[networking.bedrock]
-enabled = false
-
-[networking.lan_broadcast]
-enabled = false
-
-[networking.query]
-enabled = false
-
-[networking.rcon]
-enabled = false
-'''
-PUMPKIN_FEATURES = '''\
-[telemetry]
-enabled = false
-
-[plugins]
-enabled = false
-'''
-
-DONE = re.compile(r'Done|listening|Server started', re.IGNORECASE)
-TICK_AVERAGE = re.compile(r'Average time per tick: ([0-9.]+) ?ms')
-TICK_PERCENTILES = re.compile(r'P50: ([0-9.]+) ?ms P95: ([0-9.]+) ?ms P99: ([0-9.]+) ?ms')
-GAMETIME = re.compile(r'The time is (-?\d+)')
-
-
-def free_port():
-    with socket.socket() as s:
-        s.bind(('127.0.0.1', 0))
-        return s.getsockname()[1]
-
-
-def parse_tick_query(lines):
-    """MSPT numbers from the lines `tick query` printed, or None until both lines are there."""
-    average = percentiles = None
-    for line in lines:
-        if (m := TICK_AVERAGE.search(line)) and average is None:
-            average = float(m.group(1))
-        if (m := TICK_PERCENTILES.search(line)) and percentiles is None:
-            percentiles = tuple(float(g) for g in m.groups())
-    if average is None or percentiles is None:
-        return None
-    return {'average': average, 'p50': percentiles[0], 'p95': percentiles[1], 'p99': percentiles[2]}
-
-
-def parse_gametime(lines):
-    """The game time `time query gametime` printed, or None."""
-    for line in lines:
-        if m := GAMETIME.search(line):
-            return int(m.group(1))
-    return None
-
-
-def tps(start_ticks, end_ticks, seconds):
-    """Game ticks per wall-clock second over the window, or None when a query went unanswered."""
-    if start_ticks is None or end_ticks is None or seconds <= 0:
-        return None
-    return round((end_ticks - start_ticks) / seconds, 2)
-
-
-def percentile(values, p):
-    if not values:
-        return None
-    ordered = sorted(values)
-    return ordered[min(len(ordered) - 1, int(p / 100 * len(ordered)))]
-
-
-def cpu_seconds(text):
-    """ps's cumulative CPU time: [[DD-]HH:]MM:SS[.ss]."""
-    days, _, rest = text.rpartition('-')
-    seconds = 0.0
-    for part in rest.split(':'):
-        seconds = seconds * 60 + float(part)
-    return seconds + (float(days) * 86400 if days else 0)
-
-
-def tree_usage(root):
-    """RSS (bytes) and CPU seconds of a process and all its descendants; None without `ps`."""
-    try:
-        out = subprocess.run(['ps', '-A', '-o', 'pid=,ppid=,rss=,time='], capture_output=True, text=True).stdout
-    except OSError:
-        return None
-    rows = {}
-    for line in out.splitlines():
-        parts = line.split()
-        if len(parts) == 4:
-            rows[int(parts[0])] = (int(parts[1]), int(parts[2]) * 1024, cpu_seconds(parts[3]))
-    tree, frontier = {root}, [root]
-    while frontier:
-        parent = frontier.pop()
-        for pid, (ppid, _, _) in rows.items():
-            if ppid == parent and pid not in tree:
-                tree.add(pid)
-                frontier.append(pid)
-    return sum(rows[p][1] for p in tree if p in rows), sum(rows[p][2] for p in tree if p in rows)
-
-
-def prepare(kind, directory, port, args):
-    """Writes the server's settings into its scratch folder and returns the command that starts it."""
-    directory = Path(directory)
-    if args.pre_generated:
-        shutil.copytree(args.pre_generated, directory / 'world')
-    props = dict(PROPERTIES, **{'server-port': str(port), 'level-seed': str(args.seed),
-                                'view-distance': str(args.view_distance),
-                                'simulation-distance': str(args.view_distance)})
-    if kind == 'pumpkin':
-        config = directory / 'config'
-        config.mkdir()
-        (config / 'configuration.toml').write_text(PUMPKIN_CONFIGURATION.format(
-            port=port, seed=args.seed, view=args.view_distance))
-        (config / 'features.toml').write_text(PUMPKIN_FEATURES)
-        if args.pumpkin_config:
-            with (config / 'configuration.toml').open('a') as f:
-                f.write('\n' + Path(args.pumpkin_config).read_text())
-        return [Path(args.exe).resolve()]
-    (directory / 'server.properties').write_text(''.join(f'{k}={v}\n' for k, v in props.items()))
-    (directory / 'eula.txt').write_text('eula=true\n')
-    if kind == 'vanilla':
-        return ['java', f'-Xms{args.heap}', f'-Xmx{args.heap}', '-jar', Path(args.jar).resolve(), 'nogui']
-    server = Path(args.exe).resolve()
-    subprocess.run([server, '--dir', directory, 'import', directory / 'server.properties'], check=True,
-                   capture_output=True)
-    toml = directory / 'server.toml'
-    # No web panel in a bench.
-    toml.write_text(re.sub(r'(?m)^bind = "127\.0\.0\.1:8130"', 'bind = ""', toml.read_text()))
-    return [server, '--dir', directory, 'run']
-
-
-class Server:
-    """A server with its console on stdin and its output collected."""
-
-    def __init__(self, command, directory, log_path):
-        self.lines = []
-        self.lock = threading.Lock()
-        self.log = log_path.open('w', encoding='utf-8')
-        env = dict(os.environ, HORIZON_NO_AUDIO='1', HORIZON_HOME=str(directory / 'horizon-home'),
-                   HORIZON_LAUNCHER_NO_SELF_UPDATE='1')
-        self.process = subprocess.Popen([str(c) for c in command], cwd=directory, stdin=subprocess.PIPE,
-                                        stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True,
-                                        encoding='utf-8', errors='replace', env=env)
-        threading.Thread(target=self._read, daemon=True).start()
-
-    def _read(self):
-        for line in self.process.stdout:
-            with self.lock:
-                self.lines.append(line.rstrip('\n'))
-            self.log.write(line)
-            self.log.flush()
-
-    def count(self):
-        with self.lock:
-            return len(self.lines)
-
-    def since(self, n):
-        with self.lock:
-            return self.lines[n:]
-
-    def wait_for(self, regex, timeout):
-        deadline = time.time() + timeout
-        while time.time() < deadline:
-            if any(regex.search(line) for line in self.since(0)):
-                return
-            if self.process.poll() is not None:
-                raise RuntimeError('the server exited:\n' + '\n'.join(self.since(0)[-20:]))
-            time.sleep(0.1)
-        raise RuntimeError(f'the server was not up within {timeout} s')
-
-    def ask(self, command, parse, timeout=5):
-        """Sends a console command and returns parse(its output lines), or None if nothing parsed in time."""
-        start = self.count()
-        try:
-            self.process.stdin.write(command + '\n')
-            self.process.stdin.flush()
-        except (BrokenPipeError, OSError):
-            return None
-        deadline = time.time() + timeout
-        while time.time() < deadline:
-            if (value := parse(self.since(start))) is not None:
-                return value
-            time.sleep(0.05)
-        return None
-
-    def stop(self):
-        if self.process.poll() is None:
-            try:
-                self.process.stdin.write('stop\n')
-                self.process.stdin.flush()
-                self.process.wait(timeout=60)
-            except (BrokenPipeError, OSError, subprocess.TimeoutExpired):
-                self.process.kill()
-                self.process.wait()
-        self.log.close()
-
-
-def bots_command(args, port, total):
-    return [str(args.bots_bin), '--server', f'127.0.0.1:{port}', '--bots', str(args.bots),
-            '--behaviour', args.behaviour, '--join-every', str(args.join_every), '--seconds', str(int(total)),
-            '--seed', str(args.seed), '--view-distance', str(args.view_distance), '--report', '-']
-
-
-def split_bot_output(lines):
-    """The per-second samples (JSON lines with a `t`) and the final summary the bots printed."""
-    samples, rest = [], []
-    for line in lines:
-        try:
-            sample = json.loads(line)
-        except ValueError:
-            sample = None
-        if isinstance(sample, dict) and 't' in sample:
-            samples.append(sample)
-        else:
-            rest.append(line)
-    text = ''.join(rest)
-    return samples, (json.loads(text) if text.strip() else {})
-
-
-def bytes_per_player_second(per_bot, run_seconds, join_every):
-    """The bots' bytes over the seconds they were connected: bot i connects i * join_every after the first and
-    stays to the end of the run. So it is each bot's average from its login on, its join included, not the
-    measuring window's alone (the bots report one total at the end). None until the bots count bytes (S-6)."""
-    counted = [(i, b) for i, b in enumerate(per_bot) if 'bytes_in' in b and not b.get('error')]
-    online = sum(max(run_seconds - i * join_every, 0) for i, _ in counted)
-    if not counted or online <= 0:
-        return None
-    return {k: round(sum(b.get(k, 0) for _, b in counted) / online) for k in ('bytes_in', 'bytes_out')}
-
-
-def summarize(kind, args, ticks, rss, cpu, gametime, window_seconds, summary, start_seconds, run_seconds):
-    mean = lambda xs: round(statistics.fmean(xs), 2) if xs else None
-    joins = [b['joined_after_ms'] for b in summary.get('per_bot', []) if b.get('joined_after_ms', 0) > 0]
-    bandwidth = bytes_per_player_second(summary.get('per_bot', []), run_seconds, args.join_every)
-    return {
-        'server': kind,
-        'bots': args.bots,
-        'behaviour': args.behaviour,
-        'start_seconds': start_seconds,
-        'tps': tps(*gametime, window_seconds),
-        'mspt': {k: mean([t[k] for t in ticks]) for k in ('average', 'p50', 'p95', 'p99')},
-        'mspt_worst_p99': max((t['p99'] for t in ticks), default=None),
-        'rss_mb': {'mean': mean([r / 1e6 for r in rss]), 'max': round(max(rss) / 1e6, 1) if rss else None},
-        'cpu_percent': mean(cpu),
-        'bytes_per_player_second': bandwidth,
-        'join_ms': {'p50': percentile(joins, 50), 'worst': max(joins, default=None)},
-        'bots_joined': summary.get('joined'),
-        'bots_failed': [b for b in summary.get('per_bot', []) if b.get('error')],
-        'chunks_total': summary.get('chunks'),
-        'tick_queries': len(ticks),
-    }
-
-
-def run_once(kind, args, out):
-    scratch = Path(tempfile.mkdtemp(prefix=f'horizon-bench-{kind}-'))
-    result = {'server': kind, 'bots': args.bots, 'behaviour': args.behaviour}
-    server = None
-    try:
-        port = free_port()
-        command = prepare(kind, scratch, port, args)
-        started = time.time()
-        server = Server(command, scratch, out / f'{kind}-{args.bots}.log')
-        server.wait_for(DONE, args.start_timeout)
-        start_seconds = round(time.time() - started, 2)
-        total = args.bots * args.join_every + args.warmup + args.seconds
-        bot_process = subprocess.Popen(bots_command(args, port, total), stdout=subprocess.PIPE,
-                                       stderr=subprocess.PIPE, text=True)
-        bot_lines = []
-        threading.Thread(target=lambda: bot_lines.extend(bot_process.stdout), daemon=True).start()
-        time.sleep(args.bots * args.join_every + args.warmup)
-        first_time = server.ask('time query gametime', parse_gametime)
-        began = time.time()
-        rss, cpu, ticks = [], [], []
-        usage = tree_usage(server.process.pid)
-        last_cpu, last_time = (usage[1] if usage else 0), time.time()
-        next_query = time.time()
-        while time.time() - began < args.seconds:
-            time.sleep(1)
-            now = time.time()
-            if usage and (u := tree_usage(server.process.pid)):
-                rss.append(u[0])
-                cpu.append((u[1] - last_cpu) / (now - last_time) * 100)
-                last_cpu, last_time = u[1], now
-            if now >= next_query:
-                if (t := server.ask('tick query', parse_tick_query)) is not None:
-                    ticks.append(t)
-                next_query = now + 5
-        window = time.time() - began
-        last = server.ask('time query gametime', parse_gametime)
-        bot_process.wait(timeout=total + 120)
-        time.sleep(0.5)
-        _, summary = split_bot_output(list(bot_lines))
-        result.update(summarize(kind, args, ticks, rss, cpu, (first_time, last), window, summary, start_seconds,
-                                total))
-    except Exception as e:  # a failed run is reported, and the next one still runs
-        result['error'] = str(e)
-    finally:
-        if server:
-            server.stop()
-        shutil.rmtree(scratch, ignore_errors=True)
-    return result
-
-
-def table(runs):
-    """The Markdown table of the design: one column per server, one row per measure."""
-    ok = [r for r in runs if 'error' not in r]
-    head = '| | ' + ' | '.join(r['server'] for r in ok) + ' |\n|---|' + '---|' * len(ok) + '\n'
-    def cell(r, path):
-        value = r
-        for key in path:
-            value = value.get(key) if isinstance(value, dict) else None
-        return '-' if value is None else str(value)
-    rows = [
-        ('Players', ('bots',)),
-        ('TPS', ('tps',)),
-        ('MSPT average', ('mspt', 'average')),
-        ('MSPT p99 (mean of 5 s queries)', ('mspt', 'p99')),
-        ('MSPT p99 (worst query)', ('mspt_worst_p99',)),
-        ('RSS mean MB', ('rss_mb', 'mean')),
-        ('CPU %', ('cpu_percent',)),
-        ('Bytes in per player and s online', ('bytes_per_player_second', 'bytes_in')),
-        ('Join p50 ms', ('join_ms', 'p50')),
-        ('Join worst ms', ('join_ms', 'worst')),
-        ('Start s', ('start_seconds',)),
-    ]
-    body = ''.join(f'| {name} | ' + ' | '.join(cell(r, path) for r in ok) + ' |\n' for name, path in rows)
-    failed = ''.join(f'\n{r["server"]} failed: {r["error"].splitlines()[0]}\n' for r in runs if 'error' in r)
-    return head + body + failed
-
-
-def check(args):
-    for kind in args.server:
-        if kind not in SERVERS:
-            sys.exit(f'--server: {kind!r} is not one of {", ".join(SERVERS)}')
-    if 'vanilla' in args.server and not args.jar:
-        sys.exit('vanilla needs --jar, your own server.jar')
-    if any(k != 'vanilla' for k in args.server) and not args.exe:
-        sys.exit('horizon and pumpkin need --exe, the server binary')
-    if not Path(args.bots_bin).exists():
-        sys.exit(f'{args.bots_bin} is missing: cargo build --release -p horizon-bots')
-    if args.pre_generated and not Path(args.pre_generated).is_dir():
-        sys.exit(f'--pre-generated {args.pre_generated} is not a folder')
-
-
-def main(argv=None):
-    parser = argparse.ArgumentParser(description=__doc__.split('\n\n')[0])
-    parser.add_argument('--server', type=lambda s: s.split(','), default=['horizon'],
-                        help='horizon, vanilla or pumpkin (comma-separated, one run each)')
-    parser.add_argument('--exe', help='the horizon-server or Pumpkin binary')
-    parser.add_argument('--jar', help="vanilla's server.jar (your own copy)")
-    parser.add_argument('--bots-bin', default=str(ROOT / 'target/release' / f'horizon-bots{EXE}'))
-    parser.add_argument('--bots', type=int, default=50)
-    parser.add_argument('--behaviour', default='mixed')
-    parser.add_argument('--join-every', type=float, default=0.5)
-    parser.add_argument('--warmup', type=int, default=30)
-    parser.add_argument('--seconds', type=int, default=60)
-    parser.add_argument('--seed', type=int, default=12345)
-    parser.add_argument('--view-distance', type=int, default=10)
-    parser.add_argument('--heap', default='4g', help='the Java heap for vanilla')
-    parser.add_argument('--pre-generated', help='a finished world folder, copied into every run as `world`')
-    parser.add_argument('--pumpkin-config', help='extra TOML appended to Pumpkin\'s configuration.toml')
-    parser.add_argument('--start-timeout', type=int, default=600)
-    parser.add_argument('--out', type=Path, default=ROOT / '.local/bench', help='the folder for report.json and logs')
-    args = parser.parse_args(argv)
-    check(args)
-    args.out.mkdir(parents=True, exist_ok=True)
-    runs = []
-    for kind in args.server:
-        print(f'{kind}, {args.bots} {args.behaviour} bots...', flush=True)
-        runs.append(run_once(kind, args, args.out))
-        print(json.dumps(runs[-1]), flush=True)
-    report = {
-        'kind': 'horizon-bench',
-        'date': datetime.datetime.now(datetime.timezone.utc).isoformat(timespec='seconds'),
-        'machine': {'system': platform.system(), 'machine': platform.machine(), 'cpus': os.cpu_count()},
-        'settings': {k: str(v) if isinstance(v, Path) else v for k, v in vars(args).items()},
-        'runs': runs,
-    }
-    path = args.out / 'report.json'
-    path.write_text(json.dumps(report, indent=2) + '\n')
-    print('\n' + table(runs) + f'\nWrote {path}')
-    return 1 if any('error' in r for r in runs) else 0
-
-
-if __name__ == '__main__':
-    sys.exit(main())

benchmarks/perf/horizon-m4pro-1080p-rd16.json

@@ -1,758 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T22:55:52Z",
- "app": {
-  "name": "horizon-client",
-  "version": "0.1.0",
-  "commit": "1bd24e4042"
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "",
-   "driver": "",
-   "backend": "metal",
-   "kind": "integrated"
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 16,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 113.978,
-  "window": [
-   1920,
-   1080
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 1524.333,
-   "stdev": 364.142,
-   "min": 1112.127,
-   "max": 1802.295,
-   "ci95": 904.651
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 14001.774,
-   "stdev": 8119.623,
-   "min": 7466.904,
-   "max": 23091.569,
-   "ci95": 20171.889
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 8159.696,
-   "stdev": 3897.327,
-   "min": 5313.528,
-   "max": 12601.663,
-   "ci95": 9682.279
-  },
-  "chunks.village.meshed_count": {
-   "n": 3,
-   "mean": 25431.333,
-   "stdev": 1389.728,
-   "min": 24149.0,
-   "max": 26908.0,
-   "ci95": 3452.555
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 568.391,
-   "stdev": 11.948,
-   "min": 558.517,
-   "max": 581.673,
-   "ci95": 29.684
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 270.644,
-   "stdev": 9.955,
-   "min": 259.156,
-   "max": 276.728,
-   "ci95": 24.732
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 209.951,
-   "stdev": 30.24,
-   "min": 191.819,
-   "max": 244.86,
-   "ci95": 75.126
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 8879.707,
-   "stdev": 1758.259,
-   "min": 7205.686,
-   "max": 10711.562,
-   "ci95": 4368.11
-  },
-  "chunks.forest.meshed_count": {
-   "n": 3,
-   "mean": 29366.667,
-   "stdev": 273.35,
-   "min": 29053.0,
-   "max": 29554.0,
-   "ci95": 679.094
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 333.026,
-   "stdev": 1.469,
-   "min": 331.478,
-   "max": 334.4,
-   "ci95": 3.649
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 193.014,
-   "stdev": 11.504,
-   "min": 185.57,
-   "max": 206.264,
-   "ci95": 28.58
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 137.067,
-   "stdev": 28.701,
-   "min": 108.337,
-   "max": 165.738,
-   "ci95": 71.302
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 6399.435,
-   "stdev": 2268.592,
-   "min": 4346.111,
-   "max": 8834.786,
-   "ci95": 5635.949
-  },
-  "chunks.ocean.meshed_count": {
-   "n": 3,
-   "mean": 25436.0,
-   "stdev": 813.154,
-   "min": 24718.0,
-   "max": 26319.0,
-   "ci95": 2020.149
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 411.986,
-   "stdev": 1.42,
-   "min": 410.981,
-   "max": 413.61,
-   "ci95": 3.527
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 209.307,
-   "stdev": 10.427,
-   "min": 197.391,
-   "max": 216.759,
-   "ci95": 25.905
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 126.88,
-   "stdev": 17.642,
-   "min": 106.534,
-   "max": 137.93,
-   "ci95": 43.829
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 14672.976,
-   "stdev": 9832.9,
-   "min": 8230.723,
-   "max": 25990.951,
-   "ci95": 24428.25
-  },
-  "chunks.mountain.meshed_count": {
-   "n": 3,
-   "mean": 27715.0,
-   "stdev": 1706.033,
-   "min": 26572.0,
-   "max": 29676.0,
-   "ci95": 4238.362
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 357.149,
-   "stdev": 2.391,
-   "min": 355.009,
-   "max": 359.73,
-   "ci95": 5.941
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 199.658,
-   "stdev": 12.172,
-   "min": 187.504,
-   "max": 211.847,
-   "ci95": 30.238
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 154.465,
-   "stdev": 13.484,
-   "min": 144.923,
-   "max": 169.891,
-   "ci95": 33.498
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 1892.0,
-   "stdev": 49.025,
-   "min": 1835.406,
-   "max": 1921.438,
-   "ci95": 121.794
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 1616.755,
-   "stdev": 47.256,
-   "min": 1564.734,
-   "max": 1657.031,
-   "ci95": 117.4
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 3083.815,
-   "stdev": 25.002,
-   "min": 3062.456,
-   "max": 3111.315,
-   "ci95": 62.113
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 2495.271,
-   "stdev": 36.569,
-   "min": 2453.284,
-   "max": 2520.151,
-   "ci95": 90.85
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 6981,
-   "seconds": 12.002,
-   "avg_fps": 581.673,
-   "low_1pct_fps": 276.049,
-   "low_01pct_fps": 191.819,
-   "p50_ms": 1.655,
-   "p95_ms": 2.267,
-   "p99_ms": 3.277,
-   "p999_ms": 4.174,
-   "max_ms": 7.418,
-   "cpu_p50_ms": 0.955,
-   "gpu_p50_ms": 1.646,
-   "histogram": [
-    0,
-    6445,
-    353,
-    176,
-    3,
-    3,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 6703,
-   "seconds": 12.001,
-   "avg_fps": 558.517,
-   "low_1pct_fps": 276.728,
-   "low_01pct_fps": 244.86,
-   "p50_ms": 1.725,
-   "p95_ms": 2.341,
-   "p99_ms": 3.396,
-   "p999_ms": 3.939,
-   "max_ms": 4.185,
-   "cpu_p50_ms": 0.767,
-   "gpu_p50_ms": 1.708,
-   "histogram": [
-    17,
-    6041,
-    442,
-    202,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 6780,
-   "seconds": 12.0,
-   "avg_fps": 564.982,
-   "low_1pct_fps": 259.156,
-   "low_01pct_fps": 193.174,
-   "p50_ms": 1.707,
-   "p95_ms": 2.311,
-   "p99_ms": 3.407,
-   "p999_ms": 4.984,
-   "max_ms": 5.322,
-   "cpu_p50_ms": 0.923,
-   "gpu_p50_ms": 1.698,
-   "histogram": [
-    5,
-    6118,
-    480,
-    163,
-    8,
-    6,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 3978,
-   "seconds": 12.001,
-   "avg_fps": 331.478,
-   "low_1pct_fps": 187.208,
-   "low_01pct_fps": 137.127,
-   "p50_ms": 2.93,
-   "p95_ms": 3.969,
-   "p99_ms": 4.719,
-   "p999_ms": 6.451,
-   "max_ms": 8.835,
-   "cpu_p50_ms": 0.857,
-   "gpu_p50_ms": 2.92,
-   "histogram": [
-    0,
-    29,
-    2279,
-    1541,
-    109,
-    14,
-    4,
-    1,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 3999,
-   "seconds": 12.002,
-   "avg_fps": 333.199,
-   "low_1pct_fps": 185.57,
-   "low_01pct_fps": 108.337,
-   "p50_ms": 2.921,
-   "p95_ms": 3.862,
-   "p99_ms": 4.679,
-   "p999_ms": 6.817,
-   "max_ms": 11.683,
-   "cpu_p50_ms": 0.828,
-   "gpu_p50_ms": 2.903,
-   "histogram": [
-    3,
-    16,
-    2356,
-    1511,
-    97,
-    12,
-    1,
-    0,
-    2,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 4013,
-   "seconds": 12.001,
-   "avg_fps": 334.4,
-   "low_1pct_fps": 206.264,
-   "low_01pct_fps": 165.738,
-   "p50_ms": 2.915,
-   "p95_ms": 3.809,
-   "p99_ms": 4.525,
-   "p999_ms": 5.078,
-   "max_ms": 8.228,
-   "cpu_p50_ms": 0.861,
-   "gpu_p50_ms": 2.899,
-   "histogram": [
-    1,
-    18,
-    2357,
-    1553,
-    77,
-    5,
-    1,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 4932,
-   "seconds": 12.001,
-   "avg_fps": 410.981,
-   "low_1pct_fps": 216.759,
-   "low_01pct_fps": 137.93,
-   "p50_ms": 2.353,
-   "p95_ms": 3.181,
-   "p99_ms": 4.01,
-   "p999_ms": 5.767,
-   "max_ms": 9.713,
-   "cpu_p50_ms": 0.888,
-   "gpu_p50_ms": 2.343,
-   "histogram": [
-    0,
-    163,
-    4474,
-    264,
-    23,
-    4,
-    1,
-    2,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 4937,
-   "seconds": 12.001,
-   "avg_fps": 411.366,
-   "low_1pct_fps": 213.772,
-   "low_01pct_fps": 136.177,
-   "p50_ms": 2.349,
-   "p95_ms": 3.258,
-   "p99_ms": 4.015,
-   "p999_ms": 5.985,
-   "max_ms": 8.539,
-   "cpu_p50_ms": 0.871,
-   "gpu_p50_ms": 2.339,
-   "histogram": [
-    0,
-    202,
-    4406,
-    295,
-    25,
-    5,
-    1,
-    2,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 4963,
-   "seconds": 11.999,
-   "avg_fps": 413.61,
-   "low_1pct_fps": 197.391,
-   "low_01pct_fps": 106.534,
-   "p50_ms": 2.335,
-   "p95_ms": 3.214,
-   "p99_ms": 4.111,
-   "p999_ms": 7.65,
-   "max_ms": 11.399,
-   "cpu_p50_ms": 0.878,
-   "gpu_p50_ms": 2.323,
-   "histogram": [
-    2,
-    228,
-    4417,
-    274,
-    28,
-    7,
-    2,
-    2,
-    1,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 4317,
-   "seconds": 12.001,
-   "avg_fps": 359.73,
-   "low_1pct_fps": 211.847,
-   "low_01pct_fps": 169.891,
-   "p50_ms": 2.7,
-   "p95_ms": 3.753,
-   "p99_ms": 4.366,
-   "p999_ms": 5.041,
-   "max_ms": 8.726,
-   "cpu_p50_ms": 1.113,
-   "gpu_p50_ms": 2.687,
-   "histogram": [
-    0,
-    68,
-    3445,
-    718,
-    80,
-    5,
-    0,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 4281,
-   "seconds": 12.001,
-   "avg_fps": 356.707,
-   "low_1pct_fps": 199.624,
-   "low_01pct_fps": 144.923,
-   "p50_ms": 2.712,
-   "p95_ms": 3.806,
-   "p99_ms": 4.535,
-   "p999_ms": 5.453,
-   "max_ms": 8.354,
-   "cpu_p50_ms": 1.111,
-   "gpu_p50_ms": 2.694,
-   "histogram": [
-    0,
-    64,
-    3353,
-    717,
-    138,
-    5,
-    2,
-    1,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 4261,
-   "seconds": 12.003,
-   "avg_fps": 355.009,
-   "low_1pct_fps": 187.504,
-   "low_01pct_fps": 148.582,
-   "p50_ms": 2.727,
-   "p95_ms": 4.083,
-   "p99_ms": 4.744,
-   "p999_ms": 6.091,
-   "max_ms": 7.442,
-   "cpu_p50_ms": 1.126,
-   "gpu_p50_ms": 2.711,
-   "histogram": [
-    0,
-    155,
-    3198,
-    719,
-    165,
-    17,
-    6,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  }
- ],
- "label": "horizon-m4pro-1080p"
-}

benchmarks/perf/horizon-m4pro-1080p-rd32.json

@@ -1,758 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T23:17:23Z",
- "app": {
-  "name": "horizon-client",
-  "version": "0.1.0",
-  "commit": "1bd24e4042"
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "",
-   "driver": "",
-   "backend": "metal",
-   "kind": "integrated"
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 32,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 28.236,
-  "window": [
-   1920,
-   1080
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 2190.186,
-   "stdev": 1780.667,
-   "min": 906.481,
-   "max": 4223.028,
-   "ci95": 4423.779
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 14254.027,
-   "stdev": 4604.903,
-   "min": 10130.899,
-   "max": 19223.339,
-   "ci95": 11440.138
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 6509.117,
-   "stdev": 1616.283,
-   "min": 5457.214,
-   "max": 8370.17,
-   "ci95": 4015.394
-  },
-  "chunks.village.meshed_count": {
-   "n": 3,
-   "mean": 48522.333,
-   "stdev": 1713.943,
-   "min": 46732.0,
-   "max": 50148.0,
-   "ci95": 4258.014
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 326.473,
-   "stdev": 6.811,
-   "min": 319.588,
-   "max": 333.208,
-   "ci95": 16.921
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 152.497,
-   "stdev": 34.142,
-   "min": 116.575,
-   "max": 184.525,
-   "ci95": 84.82
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 122.567,
-   "stdev": 33.914,
-   "min": 87.235,
-   "max": 154.858,
-   "ci95": 84.254
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 10363.339,
-   "stdev": 3122.178,
-   "min": 6760.012,
-   "max": 12265.121,
-   "ci95": 7756.547
-  },
-  "chunks.forest.meshed_count": {
-   "n": 3,
-   "mean": 82591.667,
-   "stdev": 1489.69,
-   "min": 81053.0,
-   "max": 84027.0,
-   "ci95": 3700.895
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 165.414,
-   "stdev": 4.368,
-   "min": 162.757,
-   "max": 170.455,
-   "ci95": 10.851
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 103.992,
-   "stdev": 20.41,
-   "min": 83.527,
-   "max": 124.346,
-   "ci95": 50.705
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 94.785,
-   "stdev": 24.344,
-   "min": 69.796,
-   "max": 118.428,
-   "ci95": 60.478
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 10450.642,
-   "stdev": 2599.832,
-   "min": 7510.454,
-   "max": 12445.71,
-   "ci95": 6458.863
-  },
-  "chunks.ocean.meshed_count": {
-   "n": 3,
-   "mean": 76405.667,
-   "stdev": 649.936,
-   "min": 75681.0,
-   "max": 76937.0,
-   "ci95": 1614.662
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 210.179,
-   "stdev": 5.279,
-   "min": 205.559,
-   "max": 215.932,
-   "ci95": 13.114
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 128.777,
-   "stdev": 30.982,
-   "min": 93.017,
-   "max": 147.571,
-   "ci95": 76.97
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 115.916,
-   "stdev": 39.398,
-   "min": 70.443,
-   "max": 139.838,
-   "ci95": 97.879
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 17168.619,
-   "stdev": 3613.606,
-   "min": 13749.902,
-   "max": 20949.796,
-   "ci95": 8977.42
-  },
-  "chunks.mountain.meshed_count": {
-   "n": 3,
-   "mean": 91622.667,
-   "stdev": 482.189,
-   "min": 91089.0,
-   "max": 92027.0,
-   "ci95": 1197.921
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 190.088,
-   "stdev": 2.175,
-   "min": 187.78,
-   "max": 192.099,
-   "ci95": 5.403
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 108.92,
-   "stdev": 14.244,
-   "min": 92.641,
-   "max": 119.094,
-   "ci95": 35.388
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 91.132,
-   "stdev": 12.82,
-   "min": 76.343,
-   "max": 99.09,
-   "ci95": 31.849
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 2536.536,
-   "stdev": 40.31,
-   "min": 2506.281,
-   "max": 2582.297,
-   "ci95": 100.144
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 2195.922,
-   "stdev": 37.757,
-   "min": 2167.078,
-   "max": 2238.656,
-   "ci95": 93.8
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 5559.837,
-   "stdev": 47.18,
-   "min": 5505.457,
-   "max": 5589.863,
-   "ci95": 117.211
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 4373.034,
-   "stdev": 82.743,
-   "min": 4311.909,
-   "max": 4467.191,
-   "ci95": 205.561
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 3920,
-   "seconds": 12.002,
-   "avg_fps": 326.623,
-   "low_1pct_fps": 116.575,
-   "low_01pct_fps": 87.235,
-   "p50_ms": 2.938,
-   "p95_ms": 4.356,
-   "p99_ms": 7.397,
-   "p999_ms": 9.497,
-   "max_ms": 13.274,
-   "cpu_p50_ms": 1.611,
-   "gpu_p50_ms": 2.871,
-   "histogram": [
-    0,
-    115,
-    2297,
-    1271,
-    149,
-    33,
-    10,
-    24,
-    18,
-    1,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 3835,
-   "seconds": 12.0,
-   "avg_fps": 319.588,
-   "low_1pct_fps": 156.39,
-   "low_01pct_fps": 125.608,
-   "p50_ms": 3.04,
-   "p95_ms": 4.322,
-   "p99_ms": 5.265,
-   "p999_ms": 7.732,
-   "max_ms": 8.183,
-   "cpu_p50_ms": 1.733,
-   "gpu_p50_ms": 2.936,
-   "histogram": [
-    0,
-    1,
-    1610,
-    2006,
-    142,
-    51,
-    15,
-    10,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 3999,
-   "seconds": 12.002,
-   "avg_fps": 333.208,
-   "low_1pct_fps": 184.525,
-   "low_01pct_fps": 154.858,
-   "p50_ms": 2.9,
-   "p95_ms": 4.01,
-   "p99_ms": 4.955,
-   "p999_ms": 6.193,
-   "max_ms": 6.805,
-   "cpu_p50_ms": 1.51,
-   "gpu_p50_ms": 2.788,
-   "histogram": [
-    0,
-    8,
-    2499,
-    1328,
-    132,
-    25,
-    7,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 1957,
-   "seconds": 12.004,
-   "avg_fps": 163.03,
-   "low_1pct_fps": 83.527,
-   "low_01pct_fps": 69.796,
-   "p50_ms": 6.011,
-   "p95_ms": 8.032,
-   "p99_ms": 10.903,
-   "p999_ms": 14.322,
-   "max_ms": 14.333,
-   "cpu_p50_ms": 1.555,
-   "gpu_p50_ms": 5.857,
-   "histogram": [
-    0,
-    5,
-    26,
-    16,
-    36,
-    883,
-    739,
-    194,
-    29,
-    22,
-    5,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 1954,
-   "seconds": 12.006,
-   "avg_fps": 162.757,
-   "low_1pct_fps": 104.102,
-   "low_01pct_fps": 96.13,
-   "p50_ms": 5.98,
-   "p95_ms": 7.665,
-   "p99_ms": 9.049,
-   "p999_ms": 10.323,
-   "max_ms": 10.482,
-   "cpu_p50_ms": 1.584,
-   "gpu_p50_ms": 5.715,
-   "histogram": [
-    0,
-    0,
-    0,
-    1,
-    9,
-    1028,
-    737,
-    130,
-    46,
-    3,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 2046,
-   "seconds": 12.003,
-   "avg_fps": 170.455,
-   "low_1pct_fps": 124.346,
-   "low_01pct_fps": 118.428,
-   "p50_ms": 5.719,
-   "p95_ms": 7.342,
-   "p99_ms": 7.815,
-   "p999_ms": 8.38,
-   "max_ms": 8.506,
-   "cpu_p50_ms": 1.384,
-   "gpu_p50_ms": 5.572,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    26,
-    1452,
-    396,
-    169,
-    3,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 2467,
-   "seconds": 12.001,
-   "avg_fps": 205.559,
-   "low_1pct_fps": 93.017,
-   "low_01pct_fps": 70.443,
-   "p50_ms": 4.708,
-   "p95_ms": 6.6,
-   "p99_ms": 9.432,
-   "p999_ms": 13.566,
-   "max_ms": 15.228,
-   "cpu_p50_ms": 1.664,
-   "gpu_p50_ms": 4.483,
-   "histogram": [
-    0,
-    18,
-    55,
-    87,
-    1811,
-    290,
-    143,
-    27,
-    20,
-    13,
-    2,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 2509,
-   "seconds": 12.002,
-   "avg_fps": 209.045,
-   "low_1pct_fps": 145.742,
-   "low_01pct_fps": 139.838,
-   "p50_ms": 4.642,
-   "p95_ms": 6.15,
-   "p99_ms": 6.72,
-   "p999_ms": 7.081,
-   "max_ms": 7.254,
-   "cpu_p50_ms": 1.74,
-   "gpu_p50_ms": 4.376,
-   "histogram": [
-    0,
-    0,
-    0,
-    78,
-    2008,
-    277,
-    142,
-    4,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 2591,
-   "seconds": 11.999,
-   "avg_fps": 215.932,
-   "low_1pct_fps": 147.571,
-   "low_01pct_fps": 137.466,
-   "p50_ms": 4.466,
-   "p95_ms": 5.947,
-   "p99_ms": 6.512,
-   "p999_ms": 7.262,
-   "max_ms": 7.283,
-   "cpu_p50_ms": 1.422,
-   "gpu_p50_ms": 4.286,
-   "histogram": [
-    0,
-    2,
-    0,
-    111,
-    2114,
-    248,
-    111,
-    5,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 2285,
-   "seconds": 12.002,
-   "avg_fps": 190.386,
-   "low_1pct_fps": 92.641,
-   "low_01pct_fps": 76.343,
-   "p50_ms": 5.038,
-   "p95_ms": 7.005,
-   "p99_ms": 9.383,
-   "p999_ms": 11.731,
-   "max_ms": 15.266,
-   "cpu_p50_ms": 2.239,
-   "gpu_p50_ms": 4.915,
-   "histogram": [
-    0,
-    0,
-    54,
-    45,
-    916,
-    985,
-    168,
-    78,
-    22,
-    15,
-    1,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 2306,
-   "seconds": 12.004,
-   "avg_fps": 192.099,
-   "low_1pct_fps": 119.094,
-   "low_01pct_fps": 99.09,
-   "p50_ms": 5.017,
-   "p95_ms": 6.58,
-   "p99_ms": 7.586,
-   "p999_ms": 9.195,
-   "max_ms": 11.428,
-   "cpu_p50_ms": 2.261,
-   "gpu_p50_ms": 4.823,
-   "histogram": [
-    0,
-    0,
-    3,
-    12,
-    1070,
-    1003,
-    165,
-    43,
-    9,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 2254,
-   "seconds": 12.003,
-   "avg_fps": 187.78,
-   "low_1pct_fps": 115.026,
-   "low_01pct_fps": 97.962,
-   "p50_ms": 5.175,
-   "p95_ms": 6.791,
-   "p99_ms": 7.916,
-   "p999_ms": 9.284,
-   "max_ms": 11.986,
-   "cpu_p50_ms": 2.158,
-   "gpu_p50_ms": 4.942,
-   "histogram": [
-    0,
-    0,
-    0,
-    17,
-    774,
-    1199,
-    182,
-    69,
-    12,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  }
- ],
- "label": "horizon-m4pro-1080p"
-}

benchmarks/perf/horizon-m4pro-1080p-rd8.json

@@ -1,758 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T22:55:52Z",
- "app": {
-  "name": "horizon-client",
-  "version": "0.1.0",
-  "commit": "1bd24e4042"
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "",
-   "driver": "",
-   "backend": "metal",
-   "kind": "integrated"
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 8,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 73.292,
-  "window": [
-   1920,
-   1080
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 7204.239,
-   "stdev": 1586.64,
-   "min": 5409.683,
-   "max": 8421.051,
-   "ci95": 3941.749
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 11407.51,
-   "stdev": 2085.692,
-   "min": 9027.004,
-   "max": 12913.993,
-   "ci95": 5181.563
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 5116.146,
-   "stdev": 744.611,
-   "min": 4548.096,
-   "max": 5959.13,
-   "ci95": 1849.865
-  },
-  "chunks.village.meshed_count": {
-   "n": 3,
-   "mean": 7220.0,
-   "stdev": 137.292,
-   "min": 7092.0,
-   "max": 7365.0,
-   "ci95": 341.079
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 540.213,
-   "stdev": 182.263,
-   "min": 432.911,
-   "max": 750.659,
-   "ci95": 452.803
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 195.561,
-   "stdev": 75.888,
-   "min": 141.859,
-   "max": 282.38,
-   "ci95": 188.533
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 134.559,
-   "stdev": 74.125,
-   "min": 87.663,
-   "max": 220.016,
-   "ci95": 184.153
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 7185.67,
-   "stdev": 4093.192,
-   "min": 4323.79,
-   "max": 11874.133,
-   "ci95": 10168.874
-  },
-  "chunks.forest.meshed_count": {
-   "n": 3,
-   "mean": 8302.667,
-   "stdev": 538.894,
-   "min": 7853.0,
-   "max": 8900.0,
-   "ci95": 1338.794
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 364.068,
-   "stdev": 8.947,
-   "min": 355.173,
-   "max": 373.067,
-   "ci95": 22.229
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 145.064,
-   "stdev": 21.824,
-   "min": 121.995,
-   "max": 165.382,
-   "ci95": 54.218
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 97.299,
-   "stdev": 15.364,
-   "min": 81.075,
-   "max": 111.627,
-   "ci95": 38.17
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 4944.497,
-   "stdev": 1598.757,
-   "min": 3816.976,
-   "max": 6774.175,
-   "ci95": 3971.854
-  },
-  "chunks.ocean.meshed_count": {
-   "n": 3,
-   "mean": 7041.0,
-   "stdev": 276.949,
-   "min": 6821.0,
-   "max": 7352.0,
-   "ci95": 688.036
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 410.281,
-   "stdev": 35.314,
-   "min": 370.881,
-   "max": 439.08,
-   "ci95": 87.731
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 161.057,
-   "stdev": 15.769,
-   "min": 144.003,
-   "max": 175.109,
-   "ci95": 39.175
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 111.852,
-   "stdev": 16.415,
-   "min": 93.045,
-   "max": 123.299,
-   "ci95": 40.78
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 8844.497,
-   "stdev": 4291.678,
-   "min": 5269.587,
-   "max": 13604.075,
-   "ci95": 10661.98
-  },
-  "chunks.mountain.meshed_count": {
-   "n": 3,
-   "mean": 7381.0,
-   "stdev": 88.606,
-   "min": 7290.0,
-   "max": 7467.0,
-   "ci95": 220.127
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 466.294,
-   "stdev": 2.738,
-   "min": 464.707,
-   "max": 469.455,
-   "ci95": 6.801
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 164.71,
-   "stdev": 21.73,
-   "min": 141.437,
-   "max": 184.468,
-   "ci95": 53.984
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 90.643,
-   "stdev": 14.864,
-   "min": 76.851,
-   "max": 106.387,
-   "ci95": 36.928
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 1536.969,
-   "stdev": 19.205,
-   "min": 1516.188,
-   "max": 1554.063,
-   "ci95": 47.711
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 1379.422,
-   "stdev": 9.712,
-   "min": 1371.438,
-   "max": 1390.234,
-   "ci95": 24.129
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 2093.701,
-   "stdev": 13.714,
-   "min": 2078.862,
-   "max": 2105.909,
-   "ci95": 34.07
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 1883.495,
-   "stdev": 10.346,
-   "min": 1871.987,
-   "max": 1892.026,
-   "ci95": 25.702
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 9008,
-   "seconds": 12.0,
-   "avg_fps": 750.659,
-   "low_1pct_fps": 282.38,
-   "low_01pct_fps": 220.016,
-   "p50_ms": 1.047,
-   "p95_ms": 2.169,
-   "p99_ms": 3.163,
-   "p999_ms": 4.077,
-   "max_ms": 5.462,
-   "cpu_p50_ms": 0.447,
-   "gpu_p50_ms": 1.021,
-   "histogram": [
-    3979,
-    3877,
-    1033,
-    112,
-    6,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 5245,
-   "seconds": 12.0,
-   "avg_fps": 437.07,
-   "low_1pct_fps": 141.859,
-   "low_01pct_fps": 87.663,
-   "p50_ms": 1.822,
-   "p95_ms": 4.165,
-   "p99_ms": 5.399,
-   "p999_ms": 10.052,
-   "max_ms": 12.712,
-   "cpu_p50_ms": 0.652,
-   "gpu_p50_ms": 1.943,
-   "histogram": [
-    831,
-    1968,
-    606,
-    1582,
-    154,
-    82,
-    3,
-    3,
-    10,
-    4,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 5195,
-   "seconds": 12.0,
-   "avg_fps": 432.911,
-   "low_1pct_fps": 162.445,
-   "low_01pct_fps": 95.997,
-   "p50_ms": 1.806,
-   "p95_ms": 4.202,
-   "p99_ms": 5.259,
-   "p999_ms": 7.591,
-   "max_ms": 17.328,
-   "cpu_p50_ms": 0.636,
-   "gpu_p50_ms": 1.876,
-   "histogram": [
-    297,
-    2502,
-    650,
-    1469,
-    192,
-    73,
-    6,
-    1,
-    3,
-    1,
-    0,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 4262,
-   "seconds": 12.0,
-   "avg_fps": 355.173,
-   "low_1pct_fps": 165.382,
-   "low_01pct_fps": 111.627,
-   "p50_ms": 2.917,
-   "p95_ms": 3.854,
-   "p99_ms": 5.022,
-   "p999_ms": 7.808,
-   "max_ms": 9.769,
-   "cpu_p50_ms": 0.59,
-   "gpu_p50_ms": 2.91,
-   "histogram": [
-    98,
-    416,
-    2506,
-    1080,
-    118,
-    29,
-    10,
-    1,
-    4,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 4477,
-   "seconds": 12.001,
-   "avg_fps": 373.067,
-   "low_1pct_fps": 121.995,
-   "low_01pct_fps": 81.075,
-   "p50_ms": 2.243,
-   "p95_ms": 4.687,
-   "p99_ms": 5.835,
-   "p999_ms": 11.831,
-   "max_ms": 13.367,
-   "cpu_p50_ms": 0.541,
-   "gpu_p50_ms": 2.346,
-   "histogram": [
-    183,
-    1975,
-    392,
-    887,
-    903,
-    99,
-    12,
-    6,
-    11,
-    6,
-    3,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 4368,
-   "seconds": 12.001,
-   "avg_fps": 363.964,
-   "low_1pct_fps": 147.816,
-   "low_01pct_fps": 99.196,
-   "p50_ms": 2.264,
-   "p95_ms": 4.763,
-   "p99_ms": 5.86,
-   "p999_ms": 7.641,
-   "max_ms": 11.427,
-   "cpu_p50_ms": 0.562,
-   "gpu_p50_ms": 2.203,
-   "histogram": [
-    73,
-    1978,
-    472,
-    695,
-    1004,
-    104,
-    35,
-    3,
-    1,
-    3,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 4451,
-   "seconds": 12.001,
-   "avg_fps": 370.881,
-   "low_1pct_fps": 175.109,
-   "low_01pct_fps": 119.212,
-   "p50_ms": 2.858,
-   "p95_ms": 4.279,
-   "p99_ms": 5.045,
-   "p999_ms": 6.057,
-   "max_ms": 10.866,
-   "cpu_p50_ms": 0.609,
-   "gpu_p50_ms": 2.922,
-   "histogram": [
-    193,
-    1245,
-    964,
-    1732,
-    270,
-    42,
-    2,
-    0,
-    1,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 5269,
-   "seconds": 12.0,
-   "avg_fps": 439.08,
-   "low_1pct_fps": 144.003,
-   "low_01pct_fps": 93.045,
-   "p50_ms": 1.767,
-   "p95_ms": 4.188,
-   "p99_ms": 5.191,
-   "p999_ms": 10.375,
-   "max_ms": 11.271,
-   "cpu_p50_ms": 0.545,
-   "gpu_p50_ms": 1.815,
-   "histogram": [
-    1239,
-    1550,
-    644,
-    1555,
-    201,
-    59,
-    1,
-    4,
-    10,
-    6,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 5051,
-   "seconds": 12.001,
-   "avg_fps": 420.881,
-   "low_1pct_fps": 164.058,
-   "low_01pct_fps": 123.299,
-   "p50_ms": 1.872,
-   "p95_ms": 4.455,
-   "p99_ms": 5.38,
-   "p999_ms": 6.923,
-   "max_ms": 11.189,
-   "cpu_p50_ms": 0.548,
-   "gpu_p50_ms": 1.874,
-   "histogram": [
-    519,
-    2114,
-    673,
-    1086,
-    577,
-    65,
-    13,
-    3,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 5635,
-   "seconds": 12.003,
-   "avg_fps": 469.455,
-   "low_1pct_fps": 184.468,
-   "low_01pct_fps": 106.387,
-   "p50_ms": 1.626,
-   "p95_ms": 3.874,
-   "p99_ms": 4.614,
-   "p999_ms": 5.913,
-   "max_ms": 18.185,
-   "cpu_p50_ms": 0.564,
-   "gpu_p50_ms": 1.604,
-   "histogram": [
-    1491,
-    1599,
-    704,
-    1688,
-    128,
-    20,
-    1,
-    2,
-    0,
-    1,
-    0,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 5578,
-   "seconds": 12.003,
-   "avg_fps": 464.72,
-   "low_1pct_fps": 141.437,
-   "low_01pct_fps": 76.851,
-   "p50_ms": 1.587,
-   "p95_ms": 4.127,
-   "p99_ms": 5.085,
-   "p999_ms": 10.138,
-   "max_ms": 21.644,
-   "cpu_p50_ms": 0.588,
-   "gpu_p50_ms": 1.625,
-   "histogram": [
-    1321,
-    1798,
-    770,
-    1453,
-    173,
-    41,
-    2,
-    5,
-    7,
-    6,
-    1,
-    0,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 5576,
-   "seconds": 11.999,
-   "avg_fps": 464.707,
-   "low_1pct_fps": 168.226,
-   "low_01pct_fps": 88.692,
-   "p50_ms": 1.627,
-   "p95_ms": 4.154,
-   "p99_ms": 4.908,
-   "p999_ms": 9.555,
-   "max_ms": 14.784,
-   "cpu_p50_ms": 0.595,
-   "gpu_p50_ms": 1.64,
-   "histogram": [
-    1054,
-    2049,
-    837,
-    1377,
-    217,
-    32,
-    3,
-    0,
-    2,
-    4,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  }
- ],
- "label": "horizon-m4pro-1080p"
-}

benchmarks/perf/macmini-m4pro-loaded-2026-11-01.md

@@ -1,68 +0,0 @@
-# Horizon main vs vanilla 26.3 on a loaded Mac mini M4 Pro (2026-11-01)
-
-`tools/perf_bench.py` reports for Horizon main 1bd24e4042, vanilla 26.3 and vanilla with performance mods, render distances
-8, 16 and 32, three games each, every game from a fresh world. **These are not player numbers:** the Mac mini was running other
-work the whole time (1-minute load average 15-114 on 14 cores), and every game rendered without presenting. They are kept because
-they're the first Mac reports and show how each game behaves under heavy CPU contention. The reports are the
-`*-m4pro-1080p-rd*.json` files next to this page.
-
-## Setup
-
-- **Machine:** Mac mini, Apple M4 Pro (10 performance + 4 efficiency cores, 20-core GPU), 64 GB, macOS 27.0.1. Screen
-  1920x1080; the session was locked, so every game ran `offscreen` (Horizon renders into a texture; vanilla draws into a
-  window nobody sees).
-- **Horizon:** main 1bd24e4042, `cargo build --release -p horizon-client`, Metal.
-- **Vanilla:** the 26.3 client jar with Fabric Loader and the driver mod, Java 25 (Temurin), `-Xmx2G` with the launcher's G1
-  flags, OpenGL 4.1 (Apple's Metal-backed driver).
-- **Vanilla + mods:** the same with Sodium mc26.3-0.9.2, Lithium mc26.3-0.26.2, FerriteCore 9.0.0, ImmediatelyFast 1.17.1 and
-  Fabric API (`tools/benchmark-deps/mods.lock.json`).
-- **Order:** the games took turns inside each repeat (vanilla, mods, Horizon; then mods, Horizon, vanilla; then Horizon, vanilla,
-  mods), one game at a time.
-
-## Why these numbers aren't a fair comparison
-
-- **Load.** Load before each game: RD 8 46-82, RD 16 43-114, RD 32 15-59 (the later RD 32 games ran at 15-30). Horizon raises its
-  render and server threads to the user-interactive QoS class, and the JVM's threads stay at the default, so under this
-  contention macOS runs Horizon's frame first. Vanilla's 1% lows of 2-15 FPS show that, more than how fast either game is.
-- **Resolution.** Vanilla's 1920x1080 window was shrunk to **1920x930** by the 1080p screen (menu and title bars); Horizon,
-  offscreen, rendered 1920x1080. Vanilla drew 14% fewer pixels, which favours it in GPU-bound scenes. Because the recorded
-  windows differ, `perf_bench.py --table` refuses to compare these reports. The tables below were made with the window check
-  skipped. A rerun at a size that fits the screen (1600x900) would avoid it.
-
-## Results
-
-Mean of 3 games ± 95% confidence interval. FPS over the 12-second flight (average / 1% low / 0.1% low):
-
-| RD | scene | Horizon main | Vanilla 26.3 | Vanilla + mods |
-| --- | --- | --- | --- | --- |
-| 8 | forest | 364 ±22 / 145 ±54 / 97 ±38 | 66 ±22 / 8 ±10 / 6 ±8 | 47 ±42 / 4 ±2 / 3 ±1 |
-| 8 | mountain | 466 ±7 / 165 ±54 / 91 ±37 | 46 ±37 / 5 ±7 / 4 ±6 | 67 ±35 / 8 ±5 / 4 ±4 |
-| 8 | ocean | 410 ±88 / 161 ±39 / 112 ±41 | 50 ±44 / 6 ±13 / 5 ±11 | 35 ±16 / 5 ±4 / 4 ±4 |
-| 8 | village | 540 ±453 / 196 ±189 / 135 ±184 | 42 ±16 / 4 ±3 / 3 ±0 | 33 ±46 / 4 ±6 / 3 ±4 |
-| 16 | forest | 333 ±4 / 193 ±29 / 137 ±71 | 23 ±9 / 2 ±1 / 2 ±1 | 62 ±94 / 10 ±21 / 7 ±14 |
-| 16 | mountain | 357 ±6 / 200 ±30 / 154 ±33 | 44 ±12 / 7 ±2 / 4 ±1 | 36 ±44 / 4 ±5 / 3 ±5 |
-| 16 | ocean | 412 ±4 / 209 ±26 / 127 ±44 | 51 ±16 / 6 ±8 / 4 ±7 | 75 ±159 / 13 ±33 / 7 ±16 |
-| 16 | village | 568 ±30 / 271 ±25 / 210 ±75 | 46 ±110 / 9 ±27 / 7 ±17 | 46 ±45 / 7 ±9 / 5 ±4 |
-| 32 | forest | 165 ±11 / 104 ±51 / 95 ±60 | 68 ±122 / 18 ±49 / 14 ±42 | 114 ±132 / 29 ±44 / 21 ±34 |
-| 32 | mountain | 190 ±5 / 109 ±35 / 91 ±32 | 29 ±19 / 3 ±2 / 2 ±3 | 57 ±49 / 7 ±2 / 3 ±3 |
-| 32 | ocean | 210 ±13 / 129 ±77 / 116 ±98 | 44 ±80 / 5 ±4 / 2 ±1 | 119 ±176 / 32 ±66 / 17 ±37 |
-| 32 | village | 326 ±17 / 152 ±85 / 123 ±84 | 81 ±99 / 15 ±20 / 11 ±11 | 92 ±28 / 13 ±6 / 9 ±3 |
-
-Start to title / in-world, mean scene load, RSS steady / peak, physical footprint steady / peak (macOS `footprint`, which on Apple
-Silicon includes the game's GPU allocations), load average before the first game:
-
-| RD | Horizon main | Vanilla 26.3 | Vanilla + mods |
-| --- | --- | --- | --- |
-| 8 | 7.2 / 11.4, 6.5, 1379 / 1537, 1883 / 2094, 73 | 49.9 / 89.1, 18.2, 1811 / 1877, 2635 / 2709, 66 | 56.3 / 97.7, 17.9, 1927 / 2019, 2396 / 2441, 74 |
-| 16 | 1.5 / 14.0, 9.5, 1617 / 1892, 2495 / 3084, 114 | 19.4 / 78.9, 33.3, 2431 / 2555, 3450 / 3713, 76 | 23.8 / 76.9, 27.1, 2355 / 2566, 3212 / 3431, 70 |
-| 32 | 2.2 / 14.3, 11.1, 2196 / 2537, 4373 / 5560, 28 | 20.6 / 124.2, 44.2, 2838 / 2958, 4265 / 4618, 59 | 13.5 / 63.2, 29.9, 3705 / 4078, 4647 / 5250, 37 |
-
-## What it shows
-
-- Horizon is GPU-bound on the M4 Pro in every scene at every distance: its median GPU time per frame is 1.6-2.5 ms at RD 8 and
-  2.9-5.7 ms at RD 32, its render thread's CPU time 0.6-2.2 ms.
-- In the least-loaded RD 32 games (load 15-22), vanilla + mods matched Horizon's average FPS over the forest (162 vs 163-170) and
-  the ocean (187 vs 209-216); Horizon's 1% lows were 2.4 times the modded client's there, and 15-17 times over the village and the
-  mountain.
-- Horizon's resident memory is 1.2-1.7 times smaller than both clients'. Its physical footprint, GPU memory included, is level
-  with vanilla's at RD 32 (4373 vs 4265 MB steady) and above it at peak (5560 vs 4618 MB).

benchmarks/perf/vanilla-m4pro-1080p-rd16.json

@@ -1,707 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T22:55:52Z",
- "app": {
-  "name": "minecraft",
-  "version": "26.3",
-  "mods": [
-   {
-    "name": "fabric-loader",
-    "version": "0.19.5"
-   }
-  ]
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "Apple",
-   "driver": "4.1 Metal - 91.7",
-   "backend": "opengl",
-   "kind": ""
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 16,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 75.854,
-  "window": [
-   1920,
-   930
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 19419.646,
-   "stdev": 10653.755,
-   "min": 8240.178,
-   "max": 29455.403,
-   "ci95": 26467.531
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 78944.646,
-   "stdev": 36737.011,
-   "min": 51495.357,
-   "max": 120678.403,
-   "ci95": 91267.16
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 21947.683,
-   "stdev": 10432.774,
-   "min": 10427.451,
-   "max": 30758.368,
-   "ci95": 25918.54
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 45.524,
-   "stdev": 44.352,
-   "min": 15.749,
-   "max": 96.497,
-   "ci95": 110.185
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 9.141,
-   "stdev": 10.812,
-   "min": 1.86,
-   "max": 21.565,
-   "ci95": 26.862
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 6.727,
-   "stdev": 6.902,
-   "min": 1.785,
-   "max": 14.612,
-   "ci95": 17.146
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 39062.839,
-   "stdev": 21806.234,
-   "min": 15037.908,
-   "max": 57603.235,
-   "ci95": 54174.061
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 23.347,
-   "stdev": 3.693,
-   "min": 20.154,
-   "max": 27.392,
-   "ci95": 9.175
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 2.419,
-   "stdev": 0.269,
-   "min": 2.196,
-   "max": 2.718,
-   "ci95": 0.669
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 1.972,
-   "stdev": 0.438,
-   "min": 1.551,
-   "max": 2.425,
-   "ci95": 1.088
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 22097.713,
-   "stdev": 4463.742,
-   "min": 18053.319,
-   "max": 26887.066,
-   "ci95": 11089.445
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 51.279,
-   "stdev": 6.309,
-   "min": 44.786,
-   "max": 57.386,
-   "ci95": 15.673
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 6.15,
-   "stdev": 3.128,
-   "min": 3.444,
-   "max": 9.574,
-   "ci95": 7.77
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 4.161,
-   "stdev": 2.739,
-   "min": 2.487,
-   "max": 7.321,
-   "ci95": 6.803
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 50257.39,
-   "stdev": 34798.619,
-   "min": 25919.598,
-   "max": 90115.595,
-   "ci95": 86451.54
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 44.346,
-   "stdev": 4.882,
-   "min": 39.246,
-   "max": 48.975,
-   "ci95": 12.128
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 6.637,
-   "stdev": 0.69,
-   "min": 5.888,
-   "max": 7.246,
-   "ci95": 1.714
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 4.444,
-   "stdev": 0.6,
-   "min": 3.937,
-   "max": 5.107,
-   "ci95": 1.491
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 2554.552,
-   "stdev": 218.163,
-   "min": 2328.859,
-   "max": 2764.313,
-   "ci95": 541.991
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 2430.854,
-   "stdev": 230.654,
-   "min": 2186.328,
-   "max": 2644.531,
-   "ci95": 573.023
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 3713.311,
-   "stdev": 191.61,
-   "min": 3512.331,
-   "max": 3893.925,
-   "ci95": 476.025
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 3450.061,
-   "stdev": 76.233,
-   "min": 3370.253,
-   "max": 3522.128,
-   "ci95": 189.388
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 189,
-   "seconds": 12.001,
-   "avg_fps": 15.749,
-   "low_1pct_fps": 1.86,
-   "low_01pct_fps": 1.785,
-   "p50_ms": 22.219,
-   "p95_ms": 254.854,
-   "p99_ms": 515.134,
-   "p999_ms": 560.079,
-   "max_ms": 560.079,
-   "histogram": [
-    0,
-    0,
-    0,
-    1,
-    2,
-    2,
-    7,
-    9,
-    10,
-    16,
-    12,
-    11,
-    14,
-    16,
-    22,
-    9,
-    6,
-    5,
-    11,
-    10,
-    15,
-    9,
-    2,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 292,
-   "seconds": 12.004,
-   "avg_fps": 24.325,
-   "low_1pct_fps": 3.998,
-   "low_01pct_fps": 3.783,
-   "p50_ms": 15.477,
-   "p95_ms": 165.164,
-   "p99_ms": 242.898,
-   "p999_ms": 264.363,
-   "max_ms": 264.363,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    4,
-    26,
-    20,
-    32,
-    20,
-    20,
-    17,
-    12,
-    12,
-    10,
-    17,
-    14,
-    20,
-    14,
-    16,
-    16,
-    21,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 1158,
-   "seconds": 12.0,
-   "avg_fps": 96.497,
-   "low_1pct_fps": 21.565,
-   "low_01pct_fps": 14.612,
-   "p50_ms": 7.567,
-   "p95_ms": 22.849,
-   "p99_ms": 34.806,
-   "p999_ms": 62.86,
-   "max_ms": 74.011,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    1,
-    38,
-    452,
-    158,
-    102,
-    94,
-    125,
-    68,
-    34,
-    42,
-    30,
-    7,
-    4,
-    2,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 271,
-   "seconds": 12.047,
-   "avg_fps": 22.496,
-   "low_1pct_fps": 2.196,
-   "low_01pct_fps": 1.551,
-   "p50_ms": 18.263,
-   "p95_ms": 189.284,
-   "p99_ms": 317.823,
-   "p999_ms": 644.675,
-   "max_ms": 644.675,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    3,
-    22,
-    23,
-    13,
-    22,
-    22,
-    19,
-    24,
-    22,
-    14,
-    17,
-    12,
-    13,
-    9,
-    16,
-    15,
-    4,
-    1,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 242,
-   "seconds": 12.007,
-   "avg_fps": 20.154,
-   "low_1pct_fps": 2.343,
-   "low_01pct_fps": 1.939,
-   "p50_ms": 19.762,
-   "p95_ms": 157.949,
-   "p99_ms": 376.292,
-   "p999_ms": 515.678,
-   "max_ms": 515.678,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    13,
-    17,
-    16,
-    26,
-    19,
-    11,
-    9,
-    10,
-    11,
-    9,
-    16,
-    17,
-    12,
-    21,
-    19,
-    9,
-    6,
-    1,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 331,
-   "seconds": 12.084,
-   "avg_fps": 27.392,
-   "low_1pct_fps": 2.718,
-   "low_01pct_fps": 2.425,
-   "p50_ms": 13.0,
-   "p95_ms": 162.797,
-   "p99_ms": 325.827,
-   "p999_ms": 412.349,
-   "max_ms": 412.349,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    3,
-    5,
-    26,
-    34,
-    42,
-    41,
-    24,
-    27,
-    15,
-    21,
-    22,
-    8,
-    10,
-    11,
-    10,
-    14,
-    10,
-    8,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 620,
-   "seconds": 12.001,
-   "avg_fps": 51.664,
-   "low_1pct_fps": 3.444,
-   "low_01pct_fps": 2.487,
-   "p50_ms": 10.358,
-   "p95_ms": 54.808,
-   "p99_ms": 181.112,
-   "p999_ms": 402.152,
-   "max_ms": 402.152,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    30,
-    79,
-    95,
-    86,
-    90,
-    60,
-    54,
-    28,
-    28,
-    19,
-    9,
-    8,
-    8,
-    6,
-    8,
-    7,
-    5,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 689,
-   "seconds": 12.006,
-   "avg_fps": 57.386,
-   "low_1pct_fps": 9.574,
-   "low_01pct_fps": 7.321,
-   "p50_ms": 12.76,
-   "p95_ms": 43.737,
-   "p99_ms": 69.357,
-   "p999_ms": 136.592,
-   "max_ms": 136.592,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    23,
-    46,
-    80,
-    80,
-    92,
-    68,
-    74,
-    54,
-    49,
-    51,
-    24,
-    22,
-    16,
-    6,
-    4,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 538,
-   "seconds": 12.013,
-   "avg_fps": 44.786,
-   "low_1pct_fps": 5.431,
-   "low_01pct_fps": 2.674,
-   "p50_ms": 14.011,
-   "p95_ms": 71.23,
-   "p99_ms": 141.423,
-   "p999_ms": 373.913,
-   "max_ms": 373.913,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    1,
-    8,
-    38,
-    84,
-    83,
-    53,
-    62,
-    52,
-    54,
-    29,
-    12,
-    15,
-    13,
-    22,
-    10,
-    1,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 588,
-   "seconds": 12.006,
-   "avg_fps": 48.975,
-   "low_1pct_fps": 6.777,
-   "low_01pct_fps": 3.937,
-   "p50_ms": 12.678,
-   "p95_ms": 64.221,
-   "p99_ms": 108.513,
-   "p999_ms": 254.008,
-   "max_ms": 254.008,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    4,
-    34,
-    21,
-    41,
-    108,
-    62,
-    55,
-    55,
-    40,
-    45,
-    41,
-    21,
-    16,
-    17,
-    18,
-    9,
-    0,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 471,
-   "seconds": 12.001,
-   "avg_fps": 39.246,
-   "low_1pct_fps": 5.888,
-   "low_01pct_fps": 4.289,
-   "p50_ms": 17.65,
-   "p95_ms": 73.314,
-   "p99_ms": 135.3,
-   "p999_ms": 233.136,
-   "max_ms": 233.136,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    3,
-    12,
-    22,
-    29,
-    36,
-    40,
-    43,
-    38,
-    41,
-    46,
-    62,
-    29,
-    20,
-    19,
-    22,
-    5,
-    4,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 538,
-   "seconds": 12.004,
-   "avg_fps": 44.818,
-   "low_1pct_fps": 7.246,
-   "low_01pct_fps": 5.107,
-   "p50_ms": 15.959,
-   "p95_ms": 63.485,
-   "p99_ms": 109.639,
-   "p999_ms": 195.815,
-   "max_ms": 195.815,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    4,
-    6,
-    21,
-    75,
-    56,
-    54,
-    78,
-    54,
-    69,
-    36,
-    23,
-    22,
-    18,
-    14,
-    7,
-    1,
-    0,
-    0,
-    0
-   ]
-  }
- ],
- "label": "vanilla-m4pro-1080p"
-}

benchmarks/perf/vanilla-m4pro-1080p-rd32.json

@@ -1,707 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T23:17:23Z",
- "app": {
-  "name": "minecraft",
-  "version": "26.3",
-  "mods": [
-   {
-    "name": "fabric-loader",
-    "version": "0.19.5"
-   }
-  ]
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "Apple",
-   "driver": "4.1 Metal - 91.7",
-   "backend": "opengl",
-   "kind": ""
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 32,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 58.672,
-  "window": [
-   1920,
-   930
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 20579.57,
-   "stdev": 13060.035,
-   "min": 10660.541,
-   "max": 35376.471,
-   "ci95": 32445.545
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 124180.237,
-   "stdev": 102723.197,
-   "min": 51510.541,
-   "max": 241702.471,
-   "ci95": 255199.163
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 23389.087,
-   "stdev": 5416.249,
-   "min": 18538.934,
-   "max": 29233.632,
-   "ci95": 13455.795
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 81.421,
-   "stdev": 39.944,
-   "min": 35.32,
-   "max": 105.706,
-   "ci95": 99.234
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 15.288,
-   "stdev": 8.185,
-   "min": 5.907,
-   "max": 20.97,
-   "ci95": 20.334
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 10.544,
-   "stdev": 4.403,
-   "min": 5.804,
-   "max": 14.505,
-   "ci95": 10.938
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 48382.741,
-   "stdev": 32005.955,
-   "min": 26161.003,
-   "max": 85067.56,
-   "ci95": 79513.616
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 67.82,
-   "stdev": 49.16,
-   "min": 12.722,
-   "max": 107.193,
-   "ci95": 122.129
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 17.769,
-   "stdev": 19.765,
-   "min": 2.609,
-   "max": 40.124,
-   "ci95": 49.103
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 13.876,
-   "stdev": 16.851,
-   "min": 2.308,
-   "max": 33.21,
-   "ci95": 41.864
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 37630.797,
-   "stdev": 33094.177,
-   "min": 14901.304,
-   "max": 75599.155,
-   "ci95": 82217.128
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 44.125,
-   "stdev": 32.286,
-   "min": 13.532,
-   "max": 77.872,
-   "ci95": 80.209
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 4.619,
-   "stdev": 1.694,
-   "min": 3.247,
-   "max": 6.512,
-   "ci95": 4.208
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 2.354,
-   "stdev": 0.44,
-   "min": 1.967,
-   "max": 2.833,
-   "ci95": 1.094
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 67242.203,
-   "stdev": 17886.115,
-   "min": 56354.348,
-   "max": 87884.948,
-   "ci95": 44435.159
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 28.745,
-   "stdev": 7.77,
-   "min": 20.237,
-   "max": 35.466,
-   "ci95": 19.304
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 3.013,
-   "stdev": 0.849,
-   "min": 2.273,
-   "max": 3.94,
-   "ci95": 2.109
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 2.377,
-   "stdev": 1.031,
-   "min": 1.246,
-   "max": 3.263,
-   "ci95": 2.561
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 2958.083,
-   "stdev": 22.425,
-   "min": 2937.734,
-   "max": 2982.125,
-   "ci95": 55.71
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 2837.568,
-   "stdev": 165.159,
-   "min": 2648.188,
-   "max": 2951.719,
-   "ci95": 410.31
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 4618.337,
-   "stdev": 95.349,
-   "min": 4543.347,
-   "max": 4725.644,
-   "ci95": 236.878
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 4264.652,
-   "stdev": 87.422,
-   "min": 4173.589,
-   "max": 4347.91,
-   "ci95": 217.185
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 424,
-   "seconds": 12.004,
-   "avg_fps": 35.32,
-   "low_1pct_fps": 5.907,
-   "low_01pct_fps": 5.804,
-   "p50_ms": 17.195,
-   "p95_ms": 95.694,
-   "p99_ms": 164.6,
-   "p999_ms": 172.292,
-   "max_ms": 172.292,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    5,
-    19,
-    39,
-    45,
-    44,
-    52,
-    42,
-    41,
-    38,
-    21,
-    20,
-    21,
-    19,
-    12,
-    6,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 1239,
-   "seconds": 12.001,
-   "avg_fps": 103.238,
-   "low_1pct_fps": 20.97,
-   "low_01pct_fps": 14.505,
-   "p50_ms": 8.073,
-   "p95_ms": 18.618,
-   "p99_ms": 34.704,
-   "p999_ms": 53.789,
-   "max_ms": 84.091,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    2,
-    275,
-    412,
-    260,
-    117,
-    60,
-    35,
-    25,
-    23,
-    14,
-    7,
-    5,
-    3,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 1271,
-   "seconds": 12.024,
-   "avg_fps": 105.706,
-   "low_1pct_fps": 18.988,
-   "low_01pct_fps": 11.324,
-   "p50_ms": 7.988,
-   "p95_ms": 16.852,
-   "p99_ms": 35.156,
-   "p999_ms": 65.46,
-   "max_ms": 111.155,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    3,
-    220,
-    500,
-    318,
-    101,
-    43,
-    21,
-    15,
-    19,
-    17,
-    4,
-    4,
-    5,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 154,
-   "seconds": 12.105,
-   "avg_fps": 12.722,
-   "low_1pct_fps": 2.609,
-   "low_01pct_fps": 2.308,
-   "p50_ms": 54.156,
-   "p95_ms": 216.738,
-   "p99_ms": 333.238,
-   "p999_ms": 433.205,
-   "max_ms": 433.205,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    1,
-    4,
-    5,
-    7,
-    9,
-    13,
-    25,
-    5,
-    7,
-    12,
-    17,
-    26,
-    18,
-    5,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 1287,
-   "seconds": 12.006,
-   "avg_fps": 107.193,
-   "low_1pct_fps": 40.124,
-   "low_01pct_fps": 33.21,
-   "p50_ms": 8.355,
-   "p95_ms": 14.243,
-   "p99_ms": 22.791,
-   "p999_ms": 29.023,
-   "max_ms": 31.2,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    627,
-    416,
-    130,
-    43,
-    33,
-    16,
-    18,
-    4,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 1003,
-   "seconds": 12.005,
-   "avg_fps": 83.546,
-   "low_1pct_fps": 10.575,
-   "low_01pct_fps": 6.111,
-   "p50_ms": 9.556,
-   "p95_ms": 22.218,
-   "p99_ms": 53.64,
-   "p999_ms": 143.879,
-   "max_ms": 183.38,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    57,
-    515,
-    239,
-    64,
-    45,
-    21,
-    30,
-    12,
-    4,
-    4,
-    5,
-    3,
-    3,
-    1,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 163,
-   "seconds": 12.045,
-   "avg_fps": 13.532,
-   "low_1pct_fps": 3.247,
-   "low_01pct_fps": 2.833,
-   "p50_ms": 52.758,
-   "p95_ms": 208.496,
-   "p99_ms": 263.074,
-   "p999_ms": 352.963,
-   "max_ms": 352.963,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    1,
-    2,
-    4,
-    5,
-    5,
-    14,
-    23,
-    10,
-    12,
-    17,
-    30,
-    18,
-    20,
-    2,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 951,
-   "seconds": 12.212,
-   "avg_fps": 77.872,
-   "low_1pct_fps": 6.512,
-   "low_01pct_fps": 1.967,
-   "p50_ms": 8.895,
-   "p95_ms": 31.377,
-   "p99_ms": 72.053,
-   "p999_ms": 508.284,
-   "max_ms": 508.284,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    359,
-    306,
-    104,
-    47,
-    29,
-    31,
-    16,
-    18,
-    10,
-    9,
-    10,
-    6,
-    2,
-    3,
-    0,
-    1,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 495,
-   "seconds": 12.082,
-   "avg_fps": 40.97,
-   "low_1pct_fps": 4.097,
-   "low_01pct_fps": 2.261,
-   "p50_ms": 11.995,
-   "p95_ms": 80.625,
-   "p99_ms": 146.758,
-   "p999_ms": 442.316,
-   "max_ms": 442.316,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    3,
-    80,
-    109,
-    56,
-    31,
-    37,
-    24,
-    30,
-    28,
-    17,
-    17,
-    27,
-    24,
-    8,
-    2,
-    2,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 243,
-   "seconds": 12.008,
-   "avg_fps": 20.237,
-   "low_1pct_fps": 2.827,
-   "low_01pct_fps": 2.623,
-   "p50_ms": 21.487,
-   "p95_ms": 177.814,
-   "p99_ms": 315.716,
-   "p999_ms": 381.289,
-   "max_ms": 381.289,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    5,
-    20,
-    26,
-    24,
-    32,
-    25,
-    21,
-    8,
-    19,
-    13,
-    18,
-    15,
-    10,
-    7,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 431,
-   "seconds": 12.153,
-   "avg_fps": 35.466,
-   "low_1pct_fps": 2.273,
-   "low_01pct_fps": 1.246,
-   "p50_ms": 12.232,
-   "p95_ms": 106.955,
-   "p99_ms": 249.209,
-   "p999_ms": 802.438,
-   "max_ms": 802.438,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    66,
-    137,
-    62,
-    41,
-    21,
-    23,
-    20,
-    3,
-    14,
-    11,
-    11,
-    10,
-    8,
-    2,
-    2,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 367,
-   "seconds": 12.02,
-   "avg_fps": 30.533,
-   "low_1pct_fps": 3.94,
-   "low_01pct_fps": 3.263,
-   "p50_ms": 21.354,
-   "p95_ms": 104.182,
-   "p99_ms": 218.448,
-   "p999_ms": 306.483,
-   "max_ms": 306.483,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    4,
-    52,
-    38,
-    32,
-    44,
-    53,
-    47,
-    20,
-    21,
-    19,
-    16,
-    15,
-    4,
-    2,
-    0,
-    0
-   ]
-  }
- ],
- "label": "vanilla-m4pro-1080p"
-}

benchmarks/perf/vanilla-m4pro-1080p-rd8.json

@@ -1,707 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T22:55:52Z",
- "app": {
-  "name": "minecraft",
-  "version": "26.3",
-  "mods": [
-   {
-    "name": "fabric-loader",
-    "version": "0.19.5"
-   }
-  ]
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "Apple",
-   "driver": "4.1 Metal - 91.7",
-   "backend": "opengl",
-   "kind": ""
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 8,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 66.477,
-  "window": [
-   1920,
-   930
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 49895.61,
-   "stdev": 37830.08,
-   "min": 27410.441,
-   "max": 93571.631,
-   "ci95": 93982.713
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 89080.61,
-   "stdev": 49418.222,
-   "min": 59243.441,
-   "max": 146123.631,
-   "ci95": 122771.577
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 29280.957,
-   "stdev": 15620.91,
-   "min": 18681.538,
-   "max": 47219.974,
-   "ci95": 38807.625
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 42.245,
-   "stdev": 6.241,
-   "min": 36.416,
-   "max": 48.83,
-   "ci95": 15.506
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 4.137,
-   "stdev": 1.2,
-   "min": 3.03,
-   "max": 5.412,
-   "ci95": 2.981
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 2.891,
-   "stdev": 0.196,
-   "min": 2.777,
-   "max": 3.118,
-   "ci95": 0.488
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 16212.425,
-   "stdev": 1584.155,
-   "min": 14800.702,
-   "max": 17925.672,
-   "ci95": 3935.576
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 66.392,
-   "stdev": 8.735,
-   "min": 57.65,
-   "max": 75.119,
-   "ci95": 21.699
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 8.327,
-   "stdev": 3.862,
-   "min": 6.012,
-   "max": 12.786,
-   "ci95": 9.595
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 6.154,
-   "stdev": 3.399,
-   "min": 3.873,
-   "max": 10.06,
-   "ci95": 8.444
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 9054.345,
-   "stdev": 1795.805,
-   "min": 7429.882,
-   "max": 10982.71,
-   "ci95": 4461.386
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 49.891,
-   "stdev": 17.901,
-   "min": 29.637,
-   "max": 63.591,
-   "ci95": 44.472
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 6.144,
-   "stdev": 5.262,
-   "min": 2.948,
-   "max": 12.218,
-   "ci95": 13.074
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 5.254,
-   "stdev": 4.377,
-   "min": 2.603,
-   "max": 10.306,
-   "ci95": 10.874
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 18171.415,
-   "stdev": 5234.921,
-   "min": 12170.39,
-   "max": 21800.551,
-   "ci95": 13005.314
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 45.9,
-   "stdev": 14.757,
-   "min": 29.055,
-   "max": 56.549,
-   "ci95": 36.661
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 4.83,
-   "stdev": 2.815,
-   "min": 2.104,
-   "max": 7.727,
-   "ci95": 6.994
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 3.986,
-   "stdev": 2.385,
-   "min": 1.597,
-   "max": 6.366,
-   "ci95": 5.924
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 1877.276,
-   "stdev": 149.19,
-   "min": 1724.094,
-   "max": 2022.125,
-   "ci95": 370.639
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 1810.693,
-   "stdev": 157.376,
-   "min": 1671.984,
-   "max": 1981.719,
-   "ci95": 390.975
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 2708.649,
-   "stdev": 200.476,
-   "min": 2538.472,
-   "max": 2929.644,
-   "ci95": 498.051
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 2635.498,
-   "stdev": 241.221,
-   "min": 2402.909,
-   "max": 2884.511,
-   "ci95": 599.274
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 586,
-   "seconds": 12.001,
-   "avg_fps": 48.83,
-   "low_1pct_fps": 3.03,
-   "low_01pct_fps": 2.779,
-   "p50_ms": 6.298,
-   "p95_ms": 102.59,
-   "p99_ms": 300.171,
-   "p999_ms": 359.883,
-   "max_ms": 359.883,
-   "histogram": [
-    0,
-    0,
-    30,
-    105,
-    67,
-    75,
-    58,
-    68,
-    43,
-    24,
-    14,
-    15,
-    8,
-    4,
-    8,
-    4,
-    7,
-    8,
-    18,
-    11,
-    11,
-    8,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 498,
-   "seconds": 12.003,
-   "avg_fps": 41.489,
-   "low_1pct_fps": 5.412,
-   "low_01pct_fps": 3.118,
-   "p50_ms": 14.331,
-   "p95_ms": 81.666,
-   "p99_ms": 133.706,
-   "p999_ms": 320.73,
-   "max_ms": 320.73,
-   "histogram": [
-    0,
-    0,
-    0,
-    5,
-    15,
-    23,
-    21,
-    37,
-    43,
-    41,
-    55,
-    45,
-    50,
-    45,
-    30,
-    15,
-    18,
-    18,
-    21,
-    13,
-    2,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 437,
-   "seconds": 12.0,
-   "avg_fps": 36.416,
-   "low_1pct_fps": 3.97,
-   "low_01pct_fps": 2.777,
-   "p50_ms": 12.279,
-   "p95_ms": 133.385,
-   "p99_ms": 203.287,
-   "p999_ms": 360.113,
-   "max_ms": 360.113,
-   "histogram": [
-    0,
-    0,
-    0,
-    9,
-    28,
-    21,
-    19,
-    41,
-    52,
-    41,
-    31,
-    33,
-    27,
-    25,
-    27,
-    13,
-    13,
-    17,
-    12,
-    14,
-    12,
-    2,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 797,
-   "seconds": 12.002,
-   "avg_fps": 66.407,
-   "low_1pct_fps": 6.184,
-   "low_01pct_fps": 4.528,
-   "p50_ms": 7.208,
-   "p95_ms": 64.408,
-   "p99_ms": 126.005,
-   "p999_ms": 220.846,
-   "max_ms": 220.846,
-   "histogram": [
-    0,
-    0,
-    2,
-    22,
-    78,
-    137,
-    123,
-    136,
-    77,
-    58,
-    31,
-    14,
-    13,
-    14,
-    13,
-    10,
-    11,
-    21,
-    20,
-    13,
-    4,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 692,
-   "seconds": 12.003,
-   "avg_fps": 57.65,
-   "low_1pct_fps": 6.012,
-   "low_01pct_fps": 3.873,
-   "p50_ms": 10.783,
-   "p95_ms": 48.101,
-   "p99_ms": 121.963,
-   "p999_ms": 258.167,
-   "max_ms": 258.167,
-   "histogram": [
-    0,
-    0,
-    0,
-    13,
-    52,
-    52,
-    41,
-    62,
-    83,
-    88,
-    50,
-    46,
-    40,
-    50,
-    43,
-    20,
-    23,
-    9,
-    11,
-    6,
-    2,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 902,
-   "seconds": 12.008,
-   "avg_fps": 75.119,
-   "low_1pct_fps": 12.786,
-   "low_01pct_fps": 10.06,
-   "p50_ms": 9.096,
-   "p95_ms": 38.051,
-   "p99_ms": 67.18,
-   "p999_ms": 99.405,
-   "max_ms": 99.405,
-   "histogram": [
-    0,
-    0,
-    0,
-    26,
-    115,
-    72,
-    65,
-    100,
-    118,
-    90,
-    66,
-    51,
-    54,
-    50,
-    39,
-    16,
-    17,
-    13,
-    10,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 687,
-   "seconds": 12.171,
-   "avg_fps": 56.446,
-   "low_1pct_fps": 3.267,
-   "low_01pct_fps": 2.853,
-   "p50_ms": 4.938,
-   "p95_ms": 103.639,
-   "p99_ms": 257.27,
-   "p999_ms": 350.504,
-   "max_ms": 350.504,
-   "histogram": [
-    0,
-    0,
-    28,
-    199,
-    125,
-    99,
-    51,
-    35,
-    32,
-    18,
-    5,
-    7,
-    11,
-    10,
-    11,
-    6,
-    2,
-    4,
-    7,
-    14,
-    15,
-    8,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 764,
-   "seconds": 12.014,
-   "avg_fps": 63.591,
-   "low_1pct_fps": 12.218,
-   "low_01pct_fps": 10.306,
-   "p50_ms": 11.549,
-   "p95_ms": 45.214,
-   "p99_ms": 67.493,
-   "p999_ms": 97.034,
-   "max_ms": 97.034,
-   "histogram": [
-    0,
-    0,
-    0,
-    9,
-    45,
-    41,
-    59,
-    58,
-    87,
-    101,
-    71,
-    85,
-    42,
-    56,
-    49,
-    15,
-    16,
-    22,
-    8,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 357,
-   "seconds": 12.046,
-   "avg_fps": 29.637,
-   "low_1pct_fps": 2.948,
-   "low_01pct_fps": 2.603,
-   "p50_ms": 10.947,
-   "p95_ms": 173.526,
-   "p99_ms": 311.134,
-   "p999_ms": 384.135,
-   "max_ms": 384.135,
-   "histogram": [
-    0,
-    0,
-    0,
-    11,
-    47,
-    31,
-    12,
-    34,
-    32,
-    23,
-    15,
-    26,
-    21,
-    14,
-    15,
-    7,
-    6,
-    16,
-    18,
-    6,
-    15,
-    8,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 355,
-   "seconds": 12.218,
-   "avg_fps": 29.055,
-   "low_1pct_fps": 2.104,
-   "low_01pct_fps": 1.597,
-   "p50_ms": 7.766,
-   "p95_ms": 145.251,
-   "p99_ms": 368.51,
-   "p999_ms": 626.205,
-   "max_ms": 626.205,
-   "histogram": [
-    0,
-    0,
-    41,
-    53,
-    25,
-    28,
-    15,
-    22,
-    7,
-    16,
-    10,
-    15,
-    17,
-    12,
-    15,
-    11,
-    11,
-    8,
-    14,
-    19,
-    7,
-    7,
-    2,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 680,
-   "seconds": 12.025,
-   "avg_fps": 56.549,
-   "low_1pct_fps": 7.727,
-   "low_01pct_fps": 6.366,
-   "p50_ms": 11.633,
-   "p95_ms": 52.508,
-   "p99_ms": 111.848,
-   "p999_ms": 157.09,
-   "max_ms": 157.09,
-   "histogram": [
-    0,
-    0,
-    1,
-    32,
-    38,
-    43,
-    49,
-    71,
-    55,
-    55,
-    54,
-    57,
-    53,
-    41,
-    54,
-    21,
-    19,
-    17,
-    12,
-    7,
-    1,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 632,
-   "seconds": 12.132,
-   "avg_fps": 52.095,
-   "low_1pct_fps": 4.66,
-   "low_01pct_fps": 3.995,
-   "p50_ms": 8.601,
-   "p95_ms": 78.611,
-   "p99_ms": 172.405,
-   "p999_ms": 250.342,
-   "max_ms": 250.342,
-   "histogram": [
-    0,
-    0,
-    9,
-    75,
-    86,
-    53,
-    32,
-    57,
-    40,
-    41,
-    30,
-    38,
-    25,
-    24,
-    39,
-    16,
-    23,
-    7,
-    12,
-    15,
-    9,
-    1,
-    0,
-    0
-   ]
-  }
- ],
- "label": "vanilla-m4pro-1080p"
-}

benchmarks/perf/vanilla-mods-m4pro-1080p-rd16.json

@@ -1,723 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T22:55:52Z",
- "app": {
-  "name": "minecraft",
-  "version": "26.3",
-  "mods": [
-   {
-    "name": "fabric-loader",
-    "version": "0.19.5"
-   },
-   {
-    "name": "sodium",
-    "version": "mc26.3-0.9.2-fabric"
-   },
-   {
-    "name": "lithium",
-    "version": "mc26.3-0.26.2-fabric"
-   },
-   {
-    "name": "ferrite-core",
-    "version": "9.0.0-fabric"
-   },
-   {
-    "name": "immediatelyfast",
-    "version": "1.17.1+26.3-fabric"
-   }
-  ]
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "Apple",
-   "driver": "4.1 Metal - 91.7",
-   "backend": "opengl",
-   "kind": ""
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 16,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 69.878,
-  "window": [
-   1920,
-   930
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 23843.039,
-   "stdev": 7524.513,
-   "min": 16643.766,
-   "max": 31655.294,
-   "ci95": 18693.436
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 76908.706,
-   "stdev": 36719.804,
-   "min": 45051.766,
-   "max": 117069.294,
-   "ci95": 91224.412
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 19608.485,
-   "stdev": 9449.035,
-   "min": 13510.149,
-   "max": 30492.958,
-   "ci95": 23474.6
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 46.159,
-   "stdev": 17.954,
-   "min": 31.413,
-   "max": 66.152,
-   "ci95": 44.604
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 6.544,
-   "stdev": 3.452,
-   "min": 3.225,
-   "max": 10.116,
-   "ci95": 8.577
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 4.689,
-   "stdev": 1.808,
-   "min": 2.647,
-   "max": 6.085,
-   "ci95": 4.491
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 23344.685,
-   "stdev": 5493.145,
-   "min": 17038.709,
-   "max": 27089.821,
-   "ci95": 13646.83
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 61.892,
-   "stdev": 37.939,
-   "min": 22.354,
-   "max": 98.0,
-   "ci95": 94.254
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 9.736,
-   "stdev": 8.597,
-   "min": 2.296,
-   "max": 19.148,
-   "ci95": 21.359
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 6.651,
-   "stdev": 5.574,
-   "min": 2.202,
-   "max": 12.903,
-   "ci95": 13.847
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 27267.052,
-   "stdev": 21587.34,
-   "min": 10640.097,
-   "max": 51663.797,
-   "ci95": 53630.253
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 75.493,
-   "stdev": 63.885,
-   "min": 25.975,
-   "max": 147.604,
-   "ci95": 158.711
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 13.396,
-   "stdev": 13.366,
-   "min": 4.634,
-   "max": 28.78,
-   "ci95": 33.205
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 7.356,
-   "stdev": 6.609,
-   "min": 3.26,
-   "max": 14.98,
-   "ci95": 16.418
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 38284.867,
-   "stdev": 4237.4,
-   "min": 33922.931,
-   "max": 42385.65,
-   "ci95": 10527.134
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 35.918,
-   "stdev": 17.742,
-   "min": 18.135,
-   "max": 53.619,
-   "ci95": 44.077
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 3.999,
-   "stdev": 2.132,
-   "min": 2.453,
-   "max": 6.431,
-   "ci95": 5.297
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 3.017,
-   "stdev": 1.831,
-   "min": 1.775,
-   "max": 5.12,
-   "ci95": 4.549
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 2566.339,
-   "stdev": 218.228,
-   "min": 2339.094,
-   "max": 2774.266,
-   "ci95": 542.153
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 2354.852,
-   "stdev": 240.105,
-   "min": 2082.984,
-   "max": 2537.867,
-   "ci95": 596.503
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 3430.598,
-   "stdev": 77.063,
-   "min": 3345.395,
-   "max": 3495.426,
-   "ci95": 191.451
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 3211.931,
-   "stdev": 99.984,
-   "min": 3124.098,
-   "max": 3320.738,
-   "ci95": 248.394
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 377,
-   "seconds": 12.002,
-   "avg_fps": 31.413,
-   "low_1pct_fps": 3.225,
-   "low_01pct_fps": 2.647,
-   "p50_ms": 15.145,
-   "p95_ms": 128.716,
-   "p99_ms": 276.685,
-   "p999_ms": 377.749,
-   "max_ms": 377.749,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    17,
-    26,
-    21,
-    30,
-    23,
-    43,
-    16,
-    25,
-    28,
-    28,
-    35,
-    16,
-    14,
-    12,
-    15,
-    13,
-    11,
-    4,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 794,
-   "seconds": 12.003,
-   "avg_fps": 66.152,
-   "low_1pct_fps": 10.116,
-   "low_01pct_fps": 6.085,
-   "p50_ms": 11.137,
-   "p95_ms": 41.078,
-   "p99_ms": 73.531,
-   "p999_ms": 164.347,
-   "max_ms": 164.347,
-   "histogram": [
-    0,
-    0,
-    0,
-    20,
-    57,
-    65,
-    52,
-    70,
-    82,
-    88,
-    80,
-    67,
-    53,
-    48,
-    52,
-    18,
-    20,
-    10,
-    10,
-    1,
-    1,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 491,
-   "seconds": 12.001,
-   "avg_fps": 40.912,
-   "low_1pct_fps": 6.291,
-   "low_01pct_fps": 5.336,
-   "p50_ms": 15.962,
-   "p95_ms": 71.604,
-   "p99_ms": 137.056,
-   "p999_ms": 187.401,
-   "max_ms": 187.401,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    1,
-    5,
-    10,
-    32,
-    54,
-    60,
-    45,
-    49,
-    44,
-    49,
-    50,
-    22,
-    21,
-    20,
-    18,
-    8,
-    3,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 784,
-   "seconds": 12.002,
-   "avg_fps": 65.322,
-   "low_1pct_fps": 7.763,
-   "low_01pct_fps": 4.848,
-   "p50_ms": 10.024,
-   "p95_ms": 43.46,
-   "p99_ms": 94.19,
-   "p999_ms": 206.286,
-   "max_ms": 206.286,
-   "histogram": [
-    0,
-    0,
-    0,
-    17,
-    40,
-    69,
-    80,
-    95,
-    88,
-    82,
-    53,
-    58,
-    39,
-    49,
-    52,
-    21,
-    15,
-    14,
-    7,
-    3,
-    2,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 1176,
-   "seconds": 12.0,
-   "avg_fps": 98.0,
-   "low_1pct_fps": 19.148,
-   "low_01pct_fps": 12.903,
-   "p50_ms": 6.214,
-   "p95_ms": 30.125,
-   "p99_ms": 41.199,
-   "p999_ms": 73.675,
-   "max_ms": 81.328,
-   "histogram": [
-    0,
-    0,
-    3,
-    179,
-    205,
-    175,
-    115,
-    111,
-    79,
-    39,
-    21,
-    25,
-    34,
-    79,
-    77,
-    20,
-    10,
-    2,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 271,
-   "seconds": 12.123,
-   "avg_fps": 22.354,
-   "low_1pct_fps": 2.296,
-   "low_01pct_fps": 2.202,
-   "p50_ms": 14.989,
-   "p95_ms": 214.282,
-   "p99_ms": 404.5,
-   "p999_ms": 454.134,
-   "max_ms": 454.134,
-   "histogram": [
-    0,
-    0,
-    0,
-    1,
-    5,
-    18,
-    19,
-    19,
-    28,
-    28,
-    13,
-    19,
-    20,
-    12,
-    21,
-    14,
-    5,
-    8,
-    4,
-    9,
-    18,
-    10,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 1772,
-   "seconds": 12.005,
-   "avg_fps": 147.604,
-   "low_1pct_fps": 28.78,
-   "low_01pct_fps": 14.98,
-   "p50_ms": 5.328,
-   "p95_ms": 15.261,
-   "p99_ms": 25.961,
-   "p999_ms": 58.586,
-   "max_ms": 74.925,
-   "histogram": [
-    0,
-    0,
-    34,
-    421,
-    331,
-    290,
-    175,
-    163,
-    122,
-    83,
-    44,
-    33,
-    26,
-    28,
-    16,
-    2,
-    2,
-    1,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 635,
-   "seconds": 12.004,
-   "avg_fps": 52.9,
-   "low_1pct_fps": 6.774,
-   "low_01pct_fps": 3.828,
-   "p50_ms": 9.578,
-   "p95_ms": 61.195,
-   "p99_ms": 112.118,
-   "p999_ms": 261.228,
-   "max_ms": 261.228,
-   "histogram": [
-    0,
-    0,
-    0,
-    38,
-    49,
-    64,
-    63,
-    63,
-    51,
-    60,
-    27,
-    29,
-    27,
-    17,
-    37,
-    28,
-    30,
-    27,
-    15,
-    8,
-    1,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 312,
-   "seconds": 12.011,
-   "avg_fps": 25.975,
-   "low_1pct_fps": 4.634,
-   "low_01pct_fps": 3.26,
-   "p50_ms": 24.629,
-   "p95_ms": 115.493,
-   "p99_ms": 169.827,
-   "p999_ms": 306.737,
-   "max_ms": 306.737,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    2,
-    5,
-    10,
-    10,
-    24,
-    39,
-    33,
-    38,
-    47,
-    16,
-    16,
-    21,
-    23,
-    22,
-    5,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 218,
-   "seconds": 12.021,
-   "avg_fps": 18.135,
-   "low_1pct_fps": 2.453,
-   "low_01pct_fps": 2.156,
-   "p50_ms": 17.447,
-   "p95_ms": 257.129,
-   "p99_ms": 377.63,
-   "p999_ms": 463.802,
-   "max_ms": 463.802,
-   "histogram": [
-    0,
-    0,
-    7,
-    13,
-    15,
-    18,
-    11,
-    9,
-    7,
-    16,
-    8,
-    3,
-    11,
-    10,
-    14,
-    7,
-    5,
-    16,
-    8,
-    15,
-    12,
-    13,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 653,
-   "seconds": 12.179,
-   "avg_fps": 53.619,
-   "low_1pct_fps": 6.431,
-   "low_01pct_fps": 5.12,
-   "p50_ms": 8.427,
-   "p95_ms": 58.968,
-   "p99_ms": 141.423,
-   "p999_ms": 195.302,
-   "max_ms": 195.302,
-   "histogram": [
-    0,
-    0,
-    0,
-    38,
-    66,
-    76,
-    79,
-    64,
-    45,
-    38,
-    20,
-    29,
-    22,
-    24,
-    46,
-    25,
-    36,
-    17,
-    14,
-    10,
-    4,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 432,
-   "seconds": 12.0,
-   "avg_fps": 35.999,
-   "low_1pct_fps": 3.112,
-   "low_01pct_fps": 1.775,
-   "p50_ms": 16.724,
-   "p95_ms": 83.13,
-   "p99_ms": 220.496,
-   "p999_ms": 563.493,
-   "max_ms": 563.493,
-   "histogram": [
-    0,
-    0,
-    0,
-    7,
-    14,
-    17,
-    23,
-    35,
-    35,
-    26,
-    24,
-    33,
-    34,
-    43,
-    43,
-    23,
-    27,
-    20,
-    15,
-    5,
-    4,
-    3,
-    1,
-    0
-   ]
-  }
- ],
- "label": "vanilla-mods-m4pro-1080p"
-}

benchmarks/perf/vanilla-mods-m4pro-1080p-rd32.json

@@ -1,723 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T23:17:23Z",
- "app": {
-  "name": "minecraft",
-  "version": "26.3",
-  "mods": [
-   {
-    "name": "fabric-loader",
-    "version": "0.19.5"
-   },
-   {
-    "name": "sodium",
-    "version": "mc26.3-0.9.2-fabric"
-   },
-   {
-    "name": "lithium",
-    "version": "mc26.3-0.26.2-fabric"
-   },
-   {
-    "name": "ferrite-core",
-    "version": "9.0.0-fabric"
-   },
-   {
-    "name": "immediatelyfast",
-    "version": "1.17.1+26.3-fabric"
-   }
-  ]
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "Apple",
-   "driver": "4.1 Metal - 91.7",
-   "backend": "opengl",
-   "kind": ""
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 32,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 37.185,
-  "window": [
-   1920,
-   930
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 13521.661,
-   "stdev": 573.908,
-   "min": 13085.942,
-   "max": 14171.935,
-   "ci95": 1425.783
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 63229.994,
-   "stdev": 6185.388,
-   "min": 56237.942,
-   "max": 67987.935,
-   "ci95": 15366.595
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 14807.746,
-   "stdev": 2020.358,
-   "min": 13414.414,
-   "max": 17124.849,
-   "ci95": 5019.253
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 91.753,
-   "stdev": 11.452,
-   "min": 78.555,
-   "max": 99.067,
-   "ci95": 28.451
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 13.105,
-   "stdev": 2.514,
-   "min": 10.354,
-   "max": 15.282,
-   "ci95": 6.244
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 9.203,
-   "stdev": 1.382,
-   "min": 7.689,
-   "max": 10.396,
-   "ci95": 3.432
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 24180.167,
-   "stdev": 777.711,
-   "min": 23290.973,
-   "max": 24733.555,
-   "ci95": 1932.098
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 113.871,
-   "stdev": 53.305,
-   "min": 56.542,
-   "max": 161.938,
-   "ci95": 132.428
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 28.748,
-   "stdev": 17.633,
-   "min": 12.823,
-   "max": 47.698,
-   "ci95": 43.807
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 20.551,
-   "stdev": 13.547,
-   "min": 8.937,
-   "max": 35.433,
-   "ci95": 33.655
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 19314.547,
-   "stdev": 5853.258,
-   "min": 15068.272,
-   "max": 25991.528,
-   "ci95": 14541.473
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 119.116,
-   "stdev": 71.027,
-   "min": 45.498,
-   "max": 187.231,
-   "ci95": 176.454
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 31.721,
-   "stdev": 26.624,
-   "min": 8.585,
-   "max": 60.822,
-   "ci95": 66.144
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 16.8,
-   "stdev": 14.937,
-   "min": 5.876,
-   "max": 33.821,
-   "ci95": 37.109
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 61290.415,
-   "stdev": 15063.343,
-   "min": 49453.256,
-   "max": 78246.003,
-   "ci95": 37422.439
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 56.905,
-   "stdev": 19.674,
-   "min": 37.807,
-   "max": 77.109,
-   "ci95": 48.878
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 7.384,
-   "stdev": 0.62,
-   "min": 6.67,
-   "max": 7.784,
-   "ci95": 1.539
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 3.48,
-   "stdev": 1.306,
-   "min": 2.526,
-   "max": 4.968,
-   "ci95": 3.244
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 4078.01,
-   "stdev": 79.593,
-   "min": 4020.391,
-   "max": 4168.828,
-   "ci95": 197.735
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 3705.104,
-   "stdev": 149.415,
-   "min": 3541.375,
-   "max": 3834.078,
-   "ci95": 371.196
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 5250.386,
-   "stdev": 54.229,
-   "min": 5200.662,
-   "max": 5308.208,
-   "ci95": 134.723
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 4647.172,
-   "stdev": 29.179,
-   "min": 4613.552,
-   "max": 4665.911,
-   "ci95": 72.492
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 1172,
-   "seconds": 12.004,
-   "avg_fps": 97.637,
-   "low_1pct_fps": 15.282,
-   "low_01pct_fps": 10.396,
-   "p50_ms": 7.394,
-   "p95_ms": 26.126,
-   "p99_ms": 50.505,
-   "p999_ms": 79.614,
-   "max_ms": 112.764,
-   "histogram": [
-    0,
-    0,
-    0,
-    24,
-    111,
-    198,
-    193,
-    170,
-    129,
-    109,
-    59,
-    42,
-    43,
-    23,
-    38,
-    10,
-    10,
-    7,
-    5,
-    1,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 1189,
-   "seconds": 12.002,
-   "avg_fps": 99.067,
-   "low_1pct_fps": 13.678,
-   "low_01pct_fps": 9.523,
-   "p50_ms": 7.061,
-   "p95_ms": 28.029,
-   "p99_ms": 58.166,
-   "p999_ms": 103.326,
-   "max_ms": 106.682,
-   "histogram": [
-    0,
-    0,
-    0,
-    59,
-    132,
-    223,
-    172,
-    171,
-    107,
-    90,
-    59,
-    39,
-    36,
-    28,
-    35,
-    14,
-    9,
-    9,
-    4,
-    2,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 943,
-   "seconds": 12.004,
-   "avg_fps": 78.555,
-   "low_1pct_fps": 10.354,
-   "low_01pct_fps": 7.689,
-   "p50_ms": 8.817,
-   "p95_ms": 31.62,
-   "p99_ms": 70.58,
-   "p999_ms": 130.049,
-   "max_ms": 130.049,
-   "histogram": [
-    0,
-    0,
-    0,
-    8,
-    34,
-    97,
-    118,
-    168,
-    126,
-    106,
-    69,
-    58,
-    49,
-    36,
-    32,
-    8,
-    9,
-    13,
-    8,
-    4,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 679,
-   "seconds": 12.009,
-   "avg_fps": 56.542,
-   "low_1pct_fps": 12.823,
-   "low_01pct_fps": 8.937,
-   "p50_ms": 14.344,
-   "p95_ms": 42.09,
-   "p99_ms": 65.756,
-   "p999_ms": 111.897,
-   "max_ms": 111.897,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    2,
-    33,
-    50,
-    62,
-    68,
-    60,
-    48,
-    67,
-    84,
-    76,
-    64,
-    27,
-    18,
-    14,
-    5,
-    1,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 1478,
-   "seconds": 12.003,
-   "avg_fps": 123.133,
-   "low_1pct_fps": 25.723,
-   "low_01pct_fps": 17.282,
-   "p50_ms": 6.388,
-   "p95_ms": 17.972,
-   "p99_ms": 29.029,
-   "p999_ms": 57.659,
-   "max_ms": 58.069,
-   "histogram": [
-    0,
-    0,
-    0,
-    3,
-    336,
-    298,
-    222,
-    186,
-    144,
-    77,
-    70,
-    57,
-    39,
-    23,
-    13,
-    5,
-    3,
-    2,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 1944,
-   "seconds": 12.005,
-   "avg_fps": 161.938,
-   "low_1pct_fps": 47.698,
-   "low_01pct_fps": 35.433,
-   "p50_ms": 5.168,
-   "p95_ms": 12.12,
-   "p99_ms": 17.337,
-   "p999_ms": 26.48,
-   "max_ms": 29.965,
-   "histogram": [
-    0,
-    0,
-    0,
-    18,
-    793,
-    527,
-    243,
-    125,
-    91,
-    47,
-    41,
-    34,
-    15,
-    7,
-    3,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 548,
-   "seconds": 12.044,
-   "avg_fps": 45.498,
-   "low_1pct_fps": 8.585,
-   "low_01pct_fps": 5.876,
-   "p50_ms": 15.416,
-   "p95_ms": 62.523,
-   "p99_ms": 98.757,
-   "p999_ms": 170.17,
-   "max_ms": 170.17,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    2,
-    15,
-    26,
-    52,
-    53,
-    58,
-    37,
-    56,
-    39,
-    58,
-    60,
-    27,
-    24,
-    18,
-    21,
-    1,
-    1,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 1496,
-   "seconds": 12.005,
-   "avg_fps": 124.619,
-   "low_1pct_fps": 25.756,
-   "low_01pct_fps": 10.702,
-   "p50_ms": 6.649,
-   "p95_ms": 15.751,
-   "p99_ms": 26.208,
-   "p999_ms": 76.546,
-   "max_ms": 110.33,
-   "histogram": [
-    0,
-    0,
-    0,
-    15,
-    250,
-    299,
-    266,
-    216,
-    163,
-    115,
-    68,
-    40,
-    32,
-    13,
-    14,
-    3,
-    0,
-    0,
-    1,
-    1,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 2247,
-   "seconds": 12.001,
-   "avg_fps": 187.231,
-   "low_1pct_fps": 60.822,
-   "low_01pct_fps": 33.821,
-   "p50_ms": 4.73,
-   "p95_ms": 8.497,
-   "p99_ms": 12.315,
-   "p999_ms": 21.724,
-   "max_ms": 42.26,
-   "histogram": [
-    0,
-    0,
-    0,
-    347,
-    987,
-    453,
-    211,
-    122,
-    67,
-    32,
-    15,
-    6,
-    4,
-    2,
-    0,
-    0,
-    1,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 670,
-   "seconds": 12.007,
-   "avg_fps": 55.799,
-   "low_1pct_fps": 7.784,
-   "low_01pct_fps": 2.526,
-   "p50_ms": 12.887,
-   "p95_ms": 45.129,
-   "p99_ms": 76.315,
-   "p999_ms": 395.821,
-   "max_ms": 395.821,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    16,
-    54,
-    79,
-    75,
-    81,
-    68,
-    60,
-    53,
-    70,
-    54,
-    17,
-    16,
-    9,
-    17,
-    0,
-    0,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 455,
-   "seconds": 12.035,
-   "avg_fps": 37.807,
-   "low_1pct_fps": 6.67,
-   "low_01pct_fps": 4.968,
-   "p50_ms": 15.986,
-   "p95_ms": 82.012,
-   "p99_ms": 117.987,
-   "p999_ms": 201.279,
-   "max_ms": 201.279,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    3,
-    27,
-    37,
-    47,
-    49,
-    37,
-    39,
-    31,
-    39,
-    34,
-    20,
-    24,
-    30,
-    26,
-    10,
-    2,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 933,
-   "seconds": 12.1,
-   "avg_fps": 77.109,
-   "low_1pct_fps": 7.697,
-   "low_01pct_fps": 2.946,
-   "p50_ms": 8.593,
-   "p95_ms": 34.696,
-   "p99_ms": 79.266,
-   "p999_ms": 339.486,
-   "max_ms": 339.486,
-   "histogram": [
-    0,
-    0,
-    0,
-    0,
-    0,
-    45,
-    176,
-    209,
-    196,
-    95,
-    45,
-    43,
-    26,
-    19,
-    30,
-    9,
-    9,
-    14,
-    13,
-    2,
-    1,
-    1,
-    0,
-    0
-   ]
-  }
- ],
- "label": "vanilla-mods-m4pro-1080p"
-}

benchmarks/perf/vanilla-mods-m4pro-1080p-rd8.json

@@ -1,723 +0,0 @@
-{
- "format": "horizon-benchmark-report",
- "version": 1,
- "kind": "game",
- "created": "2026-11-01T22:55:52Z",
- "app": {
-  "name": "minecraft",
-  "version": "26.3",
-  "mods": [
-   {
-    "name": "fabric-loader",
-    "version": "0.19.5"
-   },
-   {
-    "name": "sodium",
-    "version": "mc26.3-0.9.2-fabric"
-   },
-   {
-    "name": "lithium",
-    "version": "mc26.3-0.26.2-fabric"
-   },
-   {
-    "name": "ferrite-core",
-    "version": "9.0.0-fabric"
-   },
-   {
-    "name": "immediatelyfast",
-    "version": "1.17.1+26.3-fabric"
-   }
-  ]
- },
- "hardware": {
-  "os": "macos",
-  "arch": "aarch64",
-  "cpu_threads": 14,
-  "os_version": "27.0.1",
-  "cpu": "Apple M4 Pro",
-  "ram_mb": 65536,
-  "gpu": {
-   "name": "Apple M4 Pro",
-   "vendor": "Apple",
-   "driver": "4.1 Metal - 91.7",
-   "backend": "opengl",
-   "kind": ""
-  }
- },
- "conditions": {
-  "scenario": "perf_bench:village,forest,ocean,mountain",
-  "seed": "1234",
-  "render_distance": 8,
-  "simulation_distance": 12,
-  "vsync": false,
-  "offscreen": true,
-  "repeats": 3,
-  "warmup_s": 2.0,
-  "load_avg_1m": 74.321,
-  "window": [
-   1920,
-   930
-  ]
- },
- "metrics": {
-  "startup.title_ms": {
-   "n": 3,
-   "mean": 56311.461,
-   "stdev": 26982.658,
-   "min": 36031.835,
-   "max": 86935.815,
-   "ci95": 67034.048
-  },
-  "startup.world_ms": {
-   "n": 3,
-   "mean": 97731.794,
-   "stdev": 21691.925,
-   "min": 72951.835,
-   "max": 113284.815,
-   "ci95": 53890.078
-  },
-  "chunks.village.load_ms": {
-   "n": 3,
-   "mean": 13954.335,
-   "stdev": 10146.301,
-   "min": 7679.006,
-   "max": 25660.115,
-   "ci95": 25206.843
-  },
-  "fps.village.avg_fps": {
-   "n": 3,
-   "mean": 33.239,
-   "stdev": 18.526,
-   "min": 12.03,
-   "max": 46.264,
-   "ci95": 46.026
-  },
-  "fps.village.low_1pct_fps": {
-   "n": 3,
-   "mean": 3.772,
-   "stdev": 2.399,
-   "min": 1.734,
-   "max": 6.416,
-   "ci95": 5.96
-  },
-  "fps.village.low_01pct_fps": {
-   "n": 3,
-   "mean": 2.866,
-   "stdev": 1.762,
-   "min": 1.433,
-   "max": 4.834,
-   "ci95": 4.379
-  },
-  "chunks.forest.load_ms": {
-   "n": 3,
-   "mean": 19803.961,
-   "stdev": 14910.114,
-   "min": 8220.752,
-   "max": 36626.588,
-   "ci95": 37041.766
-  },
-  "fps.forest.avg_fps": {
-   "n": 3,
-   "mean": 47.303,
-   "stdev": 17.044,
-   "min": 32.698,
-   "max": 66.03,
-   "ci95": 42.343
-  },
-  "fps.forest.low_1pct_fps": {
-   "n": 3,
-   "mean": 4.365,
-   "stdev": 0.709,
-   "min": 3.658,
-   "max": 5.076,
-   "ci95": 1.761
-  },
-  "fps.forest.low_01pct_fps": {
-   "n": 3,
-   "mean": 3.128,
-   "stdev": 0.564,
-   "min": 2.651,
-   "max": 3.751,
-   "ci95": 1.402
-  },
-  "chunks.ocean.load_ms": {
-   "n": 3,
-   "mean": 18639.188,
-   "stdev": 8912.103,
-   "min": 11960.198,
-   "max": 28758.72,
-   "ci95": 22140.678
-  },
-  "fps.ocean.avg_fps": {
-   "n": 3,
-   "mean": 34.908,
-   "stdev": 6.372,
-   "min": 29.271,
-   "max": 41.822,
-   "ci95": 15.831
-  },
-  "fps.ocean.low_1pct_fps": {
-   "n": 3,
-   "mean": 4.614,
-   "stdev": 1.558,
-   "min": 2.986,
-   "max": 6.09,
-   "ci95": 3.869
-  },
-  "fps.ocean.low_01pct_fps": {
-   "n": 3,
-   "mean": 4.06,
-   "stdev": 1.662,
-   "min": 2.224,
-   "max": 5.463,
-   "ci95": 4.13
-  },
-  "chunks.mountain.load_ms": {
-   "n": 3,
-   "mean": 19191.558,
-   "stdev": 2902.338,
-   "min": 15845.729,
-   "max": 21030.7,
-   "ci95": 7210.388
-  },
-  "fps.mountain.avg_fps": {
-   "n": 3,
-   "mean": 67.004,
-   "stdev": 13.923,
-   "min": 51.98,
-   "max": 79.471,
-   "ci95": 34.589
-  },
-  "fps.mountain.low_1pct_fps": {
-   "n": 3,
-   "mean": 7.862,
-   "stdev": 1.987,
-   "min": 6.339,
-   "max": 10.109,
-   "ci95": 4.936
-  },
-  "fps.mountain.low_01pct_fps": {
-   "n": 3,
-   "mean": 3.993,
-   "stdev": 1.679,
-   "min": 2.06,
-   "max": 5.088,
-   "ci95": 4.172
-  },
-  "memory.rss_peak_mb": {
-   "n": 3,
-   "mean": 2019.089,
-   "stdev": 53.398,
-   "min": 1960.188,
-   "max": 2064.328,
-   "ci95": 132.657
-  },
-  "memory.rss_steady_mb": {
-   "n": 3,
-   "mean": 1927.195,
-   "stdev": 108.077,
-   "min": 1813.609,
-   "max": 2028.758,
-   "ci95": 268.5
-  },
-  "memory.footprint_peak_mb": {
-   "n": 3,
-   "mean": 2440.727,
-   "stdev": 72.508,
-   "min": 2375.394,
-   "max": 2518.738,
-   "ci95": 180.134
-  },
-  "memory.footprint_steady_mb": {
-   "n": 3,
-   "mean": 2395.53,
-   "stdev": 71.597,
-   "min": 2318.504,
-   "max": 2460.05,
-   "ci95": 177.872
-  }
- },
- "frames": [
-  {
-   "phase": "village",
-   "repeat": 0,
-   "frames": 146,
-   "seconds": 12.136,
-   "avg_fps": 12.03,
-   "low_1pct_fps": 1.734,
-   "low_01pct_fps": 1.433,
-   "p50_ms": 28.465,
-   "p95_ms": 339.625,
-   "p99_ms": 455.663,
-   "p999_ms": 697.859,
-   "max_ms": 697.859,
-   "histogram": [
-    0,
-    0,
-    1,
-    4,
-    9,
-    9,
-    5,
-    5,
-    8,
-    6,
-    5,
-    5,
-    1,
-    10,
-    9,
-    6,
-    11,
-    10,
-    5,
-    8,
-    15,
-    13,
-    1,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 1,
-   "frames": 556,
-   "seconds": 12.018,
-   "avg_fps": 46.264,
-   "low_1pct_fps": 6.416,
-   "low_01pct_fps": 4.834,
-   "p50_ms": 13.72,
-   "p95_ms": 71.774,
-   "p99_ms": 120.078,
-   "p999_ms": 206.87,
-   "max_ms": 206.87,
-   "histogram": [
-    0,
-    0,
-    0,
-    6,
-    5,
-    16,
-    22,
-    57,
-    55,
-    64,
-    62,
-    62,
-    50,
-    38,
-    29,
-    19,
-    23,
-    16,
-    21,
-    9,
-    2,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "village",
-   "repeat": 2,
-   "frames": 498,
-   "seconds": 12.022,
-   "avg_fps": 41.423,
-   "low_1pct_fps": 3.166,
-   "low_01pct_fps": 2.331,
-   "p50_ms": 7.7,
-   "p95_ms": 114.025,
-   "p99_ms": 246.232,
-   "p999_ms": 428.98,
-   "max_ms": 428.98,
-   "histogram": [
-    0,
-    0,
-    15,
-    63,
-    55,
-    58,
-    33,
-    38,
-    31,
-    22,
-    23,
-    17,
-    24,
-    24,
-    20,
-    11,
-    9,
-    10,
-    14,
-    15,
-    12,
-    4,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 0,
-   "frames": 521,
-   "seconds": 12.065,
-   "avg_fps": 43.182,
-   "low_1pct_fps": 4.362,
-   "low_01pct_fps": 3.751,
-   "p50_ms": 8.121,
-   "p95_ms": 110.621,
-   "p99_ms": 191.925,
-   "p999_ms": 266.575,
-   "max_ms": 266.575,
-   "histogram": [
-    0,
-    0,
-    1,
-    63,
-    27,
-    49,
-    61,
-    67,
-    39,
-    45,
-    27,
-    17,
-    13,
-    17,
-    7,
-    11,
-    13,
-    11,
-    18,
-    22,
-    11,
-    2,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 1,
-   "frames": 793,
-   "seconds": 12.01,
-   "avg_fps": 66.03,
-   "low_1pct_fps": 5.076,
-   "low_01pct_fps": 2.651,
-   "p50_ms": 8.218,
-   "p95_ms": 44.767,
-   "p99_ms": 143.139,
-   "p999_ms": 377.207,
-   "max_ms": 377.207,
-   "histogram": [
-    0,
-    0,
-    0,
-    60,
-    106,
-    55,
-    58,
-    127,
-    97,
-    64,
-    41,
-    28,
-    32,
-    31,
-    39,
-    12,
-    7,
-    8,
-    14,
-    9,
-    4,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "forest",
-   "repeat": 2,
-   "frames": 395,
-   "seconds": 12.08,
-   "avg_fps": 32.698,
-   "low_1pct_fps": 3.658,
-   "low_01pct_fps": 2.983,
-   "p50_ms": 10.283,
-   "p95_ms": 171.818,
-   "p99_ms": 231.998,
-   "p999_ms": 335.242,
-   "max_ms": 335.242,
-   "histogram": [
-    0,
-    0,
-    6,
-    19,
-    13,
-    27,
-    42,
-    31,
-    53,
-    36,
-    22,
-    25,
-    20,
-    19,
-    10,
-    8,
-    7,
-    6,
-    11,
-    15,
-    23,
-    2,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 0,
-   "frames": 405,
-   "seconds": 12.043,
-   "avg_fps": 33.63,
-   "low_1pct_fps": 4.765,
-   "low_01pct_fps": 4.492,
-   "p50_ms": 14.686,
-   "p95_ms": 115.893,
-   "p99_ms": 196.822,
-   "p999_ms": 222.615,
-   "max_ms": 222.615,
-   "histogram": [
-    0,
-    0,
-    0,
-    5,
-    6,
-    16,
-    18,
-    49,
-    42,
-    36,
-    22,
-    30,
-    35,
-    32,
-    23,
-    10,
-    10,
-    22,
-    22,
-    16,
-    11,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 1,
-   "frames": 502,
-   "seconds": 12.003,
-   "avg_fps": 41.822,
-   "low_1pct_fps": 6.09,
-   "low_01pct_fps": 5.463,
-   "p50_ms": 15.264,
-   "p95_ms": 76.822,
-   "p99_ms": 144.7,
-   "p999_ms": 183.045,
-   "max_ms": 183.045,
-   "histogram": [
-    0,
-    0,
-    0,
-    9,
-    14,
-    12,
-    13,
-    47,
-    43,
-    52,
-    41,
-    40,
-    52,
-    40,
-    50,
-    15,
-    26,
-    17,
-    17,
-    9,
-    5,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "ocean",
-   "repeat": 2,
-   "frames": 353,
-   "seconds": 12.06,
-   "avg_fps": 29.271,
-   "low_1pct_fps": 2.986,
-   "low_01pct_fps": 2.224,
-   "p50_ms": 10.806,
-   "p95_ms": 150.281,
-   "p99_ms": 268.607,
-   "p999_ms": 449.56,
-   "max_ms": 449.56,
-   "histogram": [
-    0,
-    0,
-    0,
-    29,
-    16,
-    24,
-    36,
-    35,
-    23,
-    31,
-    13,
-    16,
-    12,
-    18,
-    14,
-    9,
-    8,
-    16,
-    18,
-    17,
-    12,
-    6,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 0,
-   "frames": 624,
-   "seconds": 12.005,
-   "avg_fps": 51.98,
-   "low_1pct_fps": 7.137,
-   "low_01pct_fps": 5.088,
-   "p50_ms": 12.033,
-   "p95_ms": 75.22,
-   "p99_ms": 115.345,
-   "p999_ms": 196.553,
-   "max_ms": 196.553,
-   "histogram": [
-    0,
-    0,
-    4,
-    29,
-    48,
-    34,
-    38,
-    40,
-    61,
-    56,
-    50,
-    57,
-    54,
-    41,
-    33,
-    13,
-    15,
-    15,
-    28,
-    6,
-    2,
-    0,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 1,
-   "frames": 835,
-   "seconds": 12.004,
-   "avg_fps": 69.562,
-   "low_1pct_fps": 6.339,
-   "low_01pct_fps": 2.06,
-   "p50_ms": 9.818,
-   "p95_ms": 37.917,
-   "p99_ms": 81.491,
-   "p999_ms": 485.481,
-   "max_ms": 485.481,
-   "histogram": [
-    0,
-    0,
-    6,
-    62,
-    63,
-    59,
-    75,
-    84,
-    75,
-    94,
-    59,
-    77,
-    55,
-    31,
-    36,
-    27,
-    10,
-    10,
-    5,
-    5,
-    1,
-    1,
-    0,
-    0
-   ]
-  },
-  {
-   "phase": "mountain",
-   "repeat": 2,
-   "frames": 954,
-   "seconds": 12.004,
-   "avg_fps": 79.471,
-   "low_1pct_fps": 10.109,
-   "low_01pct_fps": 4.832,
-   "p50_ms": 7.91,
-   "p95_ms": 38.672,
-   "p99_ms": 79.104,
-   "p999_ms": 206.935,
-   "max_ms": 206.935,
-   "histogram": [
-    0,
-    0,
-    13,
-    55,
-    70,
-    136,
-    119,
-    109,
-    93,
-    98,
-    52,
-    49,
-    48,
-    21,
-    30,
-    17,
-    14,
-    11,
-    17,
-    1,
-    1,
-    0,
-    0,
-    0
-   ]
-  }
- ],
- "label": "vanilla-mods-m4pro-1080p"
-}

crates/cargo-horizon-mod/src/registry.rs

@@ -13,9 +13,7 @@ const SITE: &str = "https://horizon-rust.github.io/horizon-mods/";
 const USAGE: &str = "usage: cargo horizon-mod registry build <checkout> --files <dir> --out <index.json> [--release <url>] [--site <url>] [--generated <time>]
        cargo horizon-mod registry review <base checkout> <head checkout> --author <login> [--json]
        cargo horizon-mod registry check <base checkout> <head checkout> --files <dir>
-       cargo horizon-mod registry list <checkout>
-       cargo horizon-mod registry release <checkout> <id> <file> --tag <tag> --published <YYYY-MM-DD> [--notes <file>] [--signature <file>] [--game <version>]
-       cargo horizon-mod registry page <checkout> <id> <horizon-registry.toml>";
+       cargo horizon-mod registry list <checkout>";
 
 fn flag<'a>(args: &'a [String], name: &str) -> Option<&'a str> {
     super::flag(args, name)
@@ -156,74 +154,6 @@ pub fn main(args: &[String]) -> Result<(), String> {
             }
             Ok(())
         }
-        // A release of a project's repository, downloaded: the checks of a submission, then the
-        // version as the index lists it (JSON on stdout), for the registry's release sync.
-        Some("release") => {
-            let [checkout, id, file] = pos[..] else {
-                return Err(USAGE.into());
-            };
-            let (tag, published) = (
-                flag(rest, "--tag").ok_or(USAGE)?,
-                flag(rest, "--published").ok_or(USAGE)?,
-            );
-            let read = |name: &str| {
-                flag(rest, name)
-                    .map(|p| std::fs::read_to_string(p).map_err(|e| format!("{p}: {e}")))
-                    .transpose()
-            };
-            let (notes, signature) = (read("--notes")?, read("--signature")?);
-            let entry = entry_of(checkout, id)?;
-            let path = Path::new(file);
-            let cache = registry::Cache::read(Path::new(checkout), id)?;
-            let entry = entry.resolved(&cache.page);
-            let name = path.file_name().and_then(|n| n.to_str()).unwrap_or("");
-            crate::check::check(
-                path,
-                entry.kind.clone(),
-                entry.key.as_deref(),
-                signature.as_deref(),
-            )?;
-            let version = registry::release_version(
-                &entry,
-                &registry::Release {
-                    tag,
-                    published,
-                    notes: notes.as_deref().unwrap_or(""),
-                    asset: flag(rest, "--name").unwrap_or(name),
-                    game: flag(rest, "--game").unwrap_or("26.3"),
-                    signature: signature.as_deref(),
-                },
-                path,
-            )?;
-            println!(
-                "{}",
-                serde_json::to_string(&version).map_err(|e| e.to_string())?
-            );
-            Ok(())
-        }
-        // The page file of a project's repository, checked against its entry: the page as JSON.
-        Some("page") => {
-            let [checkout, id, file] = pos[..] else {
-                return Err(USAGE.into());
-            };
-            let entry = entry_of(checkout, id)?;
-            let text = std::fs::read_to_string(file).map_err(|e| format!("{file}: {e}"))?;
-            let page = registry::page(&entry, &text)?;
-            println!(
-                "{}",
-                serde_json::to_string(&page).map_err(|e| e.to_string())?
-            );
-            Ok(())
-        }
         _ => Err(USAGE.into()),
     }
 }
-
-/// `mods/<id>.toml` of the checkout, which must name a repository.
-fn entry_of(checkout: &str, id: &str) -> Result<registry::Entry, String> {
-    let (entries, _) = registry::load(Path::new(checkout)).map_err(lines)?;
-    entries
-        .into_iter()
-        .find(|e| e.id == id && e.repo.is_some())
-        .ok_or_else(|| format!("{id}: no entry with a repo"))
-}

crates/cargo-horizon-mod/template/content/horizon-mod.toml

@@ -3,8 +3,8 @@ name = "{name}"
 version = "0.1.0"
 description = ""
 authors = []
-# A content mod: blocks, items and mob effects from data/ and assets/, no code (API 0.2).
+# A content mod: blocks and items from data/ and assets/, no code (API 0.2).
 api = "0.2"
 side = "both"
-# registries: "May add blocks, items, mob effects and entity types to your worlds".
+# registries: "May add blocks and items to your worlds".
 capabilities = ["registries"]

crates/horizon-anticheat/Cargo.toml

@@ -1,14 +0,0 @@
-[package]
-name = "horizon-anticheat"
-version = "0.1.0"
-edition.workspace = true
-license.workspace = true
-rust-version = "1.85"
-description = "The dedicated server's anticheat: its [anticheat] settings, violation levels and the checks' rules, with no game state (docs/anticheat.md)"
-
-[dependencies]
-serde = { version = "1", features = ["derive"] }
-toml = "1.1"
-
-[lints]
-workspace = true

crates/horizon-anticheat/src/combat.rs

@@ -1,99 +0,0 @@
-//! Combat: attacks vanilla's client can't send (docs/anticheat.md).
-//!
-//! Vanilla's client sends ServerboundAttackPacket from one place only, `Minecraft.startAttack`, run from
-//! `handleKeybinds` once per client tick. It attacks the entity of the tick's `hitResult`, which
-//! `Minecraft.tick` picks once before the keys are handled, so every attack of one client tick is on the
-//! same entity. And each attack swings the arm (ServerboundPunchPacket) in the same call, so a client
-//! tick never has more attacks than swings: a tick that does comes from a kill aura hiding its swing.
-//! The swing is counted before or after the attack, as older clients behind a version proxy swing
-//! first; a swing without an attack (a miss, a block) is fine.
-
-/// What breaks vanilla's way of attacking.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub enum Foul {
-    /// A client tick with more attacks than swings: how many more.
-    NoSwing(u32),
-    /// A second entity attacked in the same client tick: the first one and this one.
-    TwoTargets(i32, i32),
-}
-
-/// The attacks of the client tick being heard.
-#[derive(Clone, Copy, Debug, Default, PartialEq)]
-pub struct Attacks {
-    /// The entity this tick attacked first.
-    target: Option<i32>,
-    attacks: u32,
-    swings: u32,
-}
-
-impl Attacks {
-    /// ServerboundAttackPacket on entity `target`.
-    pub fn attack(&mut self, target: i32) -> Option<Foul> {
-        self.attacks = self.attacks.saturating_add(1);
-        let first = *self.target.get_or_insert(target);
-        (first != target).then_some(Foul::TwoTargets(first, target))
-    }
-
-    /// ServerboundPunchPacket: the arm swung.
-    pub fn swing(&mut self) {
-        self.swings = self.swings.saturating_add(1);
-    }
-
-    /// ServerboundClientTickEndPacket: the tick's attacks are counted, and the next tick picks its
-    /// target again.
-    pub fn tick_end(&mut self) -> Option<Foul> {
-        let unswung = self.attacks.saturating_sub(self.swings);
-        *self = Self::default();
-        (unswung > 0).then_some(Foul::NoSwing(unswung))
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn a_vanilla_tick_is_clean() {
-        let mut a = Attacks::default();
-        // Two clicks in one tick on the same entity, each swung for.
-        for _ in 0..2 {
-            assert_eq!(a.attack(7), None);
-            a.swing();
-        }
-        assert_eq!(a.tick_end(), None);
-        // The next tick may attack another entity, swinging first (an older client).
-        a.swing();
-        assert_eq!(a.attack(8), None);
-        assert_eq!(a.tick_end(), None);
-        // A swing on its own (a miss, a block) is fine.
-        a.swing();
-        assert_eq!(a.tick_end(), None);
-    }
-
-    #[test]
-    fn an_attack_not_swung_for_is_caught() {
-        let mut a = Attacks::default();
-        a.attack(7);
-        assert_eq!(a.tick_end(), Some(Foul::NoSwing(1)));
-        // A swing in the tick before doesn't count for this one.
-        a.swing();
-        a.tick_end();
-        a.attack(7);
-        a.attack(7);
-        a.swing();
-        assert_eq!(a.tick_end(), Some(Foul::NoSwing(1)));
-    }
-
-    #[test]
-    fn two_entities_in_one_tick_are_caught() {
-        let mut a = Attacks::default();
-        a.attack(7);
-        a.swing();
-        assert_eq!(a.attack(8), Some(Foul::TwoTargets(7, 8)));
-        a.swing();
-        // Still against the tick's first target.
-        assert_eq!(a.attack(9), Some(Foul::TwoTargets(7, 9)));
-        a.swing();
-        assert_eq!(a.tick_end(), None);
-    }
-}

crates/horizon-anticheat/src/lib.rs

@@ -1,426 +0,0 @@
-//! The dedicated server's anticheat (docs/anticheat.md), without the game: the `[anticheat]` section of
-//! `server.toml`, each player's violation levels, and the rules of the checks. The server's hub
-//! (`horizon_client::lan`) feeds it what players send and carries out what it decides.
-//!
-//! It is on by default, and so is every check, but only the checks a vanilla client can't trip act on
-//! their own (`combat`); the others log only until they have shown no false positive with real
-//! players (their `setback`, `alert` and `kick` are 0). `enabled = false` turns the anticheat, or one
-//! check, off. A check that fails *flags* the player: its violation level (VL) rises by the flag's
-//! weight and falls back by `decay` a second. From `setback` on, the move or action is cancelled (the
-//! player is sent back where the server last had them); from `alert` on, online operators and the
-//! console are told; from `kick` on, the player is disconnected. A check's kicks are counted per player
-//! across sessions ([`Strikes`]), and the kick that reaches its `ban_after` bans the player instead
-//! (`banned-players.json`, reason "Horizon anticheat: <check>"). Any threshold at 0 turns that action
-//! off.
-//!
-//! The checks are written from vanilla 26.3's own rules and from what cheats are publicly described to
-//! do, never from another anticheat's code.
-
-use std::collections::BTreeMap;
-
-use serde::{Deserialize, Serialize};
-
-pub mod combat;
-pub mod prediction;
-pub mod timer;
-
-/// What one check's violation level leads to.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub struct Actions {
-    pub setback: f32,
-    pub alert: f32,
-    pub kick: f32,
-    /// Violation level lost each second.
-    pub decay: f32,
-    /// The kick, counting this check's earlier ones for the player, that bans instead; 0: never.
-    pub ban_after: u32,
-}
-
-macro_rules! checks {
-    ($(
-        $(#[$doc:meta])*
-        $field:ident: $Check:ident => $Config:ident [$setback:expr, $alert:expr, $kick:expr, $decay:expr, $ban_after:expr] {
-            $( $(#[$xdoc:meta])* $extra:ident: $ty:ty = $default:expr, )*
-        }
-    )*) => {
-        /// Every check, in the order of the players' violation levels.
-        #[derive(Clone, Copy, Debug, PartialEq, Eq)]
-        pub enum Check { $($Check,)* }
-
-        impl Check {
-            pub const ALL: &[Check] = &[$(Check::$Check,)*];
-            /// Its name in `server.toml` and in alerts.
-            pub fn name(self) -> &'static str {
-                match self { $(Check::$Check => stringify!($field),)* }
-            }
-        }
-
-        $(
-            $(#[$doc])*
-            #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
-            #[serde(default, deny_unknown_fields)]
-            pub struct $Config {
-                pub enabled: bool,
-                pub setback: f32,
-                pub alert: f32,
-                pub kick: f32,
-                pub decay: f32,
-                pub ban_after: u32,
-                $( $(#[$xdoc])* pub $extra: $ty, )*
-            }
-
-            impl Default for $Config {
-                fn default() -> Self {
-                    Self {
-                        enabled: true,
-                        setback: $setback,
-                        alert: $alert,
-                        kick: $kick,
-                        decay: $decay,
-                        ban_after: $ban_after,
-                        $($extra: $default,)*
-                    }
-                }
-            }
-        )*
-
-        /// `server.toml`'s `[anticheat]`: on by default.
-        #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
-        #[serde(default, deny_unknown_fields)]
-        pub struct Config {
-            pub enabled: bool,
-            /// Tell online operators of an alert in their chat (the console and the log always are).
-            pub alerts: bool,
-            /// The permission level a player needs to see alerts.
-            pub alert_level: u8,
-            /// Every flag, one line each, relative to the server's folder; empty: no file.
-            pub log: String,
-            /// The players' kicks by check ([`Strikes`]), relative to the server's folder; empty: kept
-            /// only while the server runs.
-            pub strikes: String,
-            $(pub $field: $Config,)*
-        }
-
-        impl Default for Config {
-            fn default() -> Self {
-                Self {
-                    enabled: true,
-                    alerts: true,
-                    alert_level: 2,
-                    log: "logs/anticheat.log".into(),
-                    strikes: "anticheat-strikes.json".into(),
-                    $($field: $Config::default(),)*
-                }
-            }
-        }
-
-        impl Config {
-            /// Whether `check` runs: the anticheat and the check both on.
-            pub fn runs(&self, check: Check) -> bool {
-                self.enabled && match check { $(Check::$Check => self.$field.enabled,)* }
-            }
-
-            pub fn actions(&self, check: Check) -> Actions {
-                match check {
-                    $(Check::$Check => {
-                        let c = &self.$field;
-                        Actions {
-                            setback: c.setback,
-                            alert: c.alert,
-                            kick: c.kick,
-                            decay: c.decay,
-                            ban_after: c.ban_after,
-                        }
-                    })*
-                }
-            }
-        }
-    };
-}
-
-checks! {
-    /// Timer: more client ticks than the server's clock allows (a sped-up game). Vanilla's client ends
-    /// every tick with ServerboundClientTickEndPacket, at the server's tick rate; each one spends a tick's
-    /// time from a balance that wall-clock time fills, capped so a pause can't be saved up for a burst.
-    /// It logs only by default; once trusted: `setback = 2`, `alert = 5`, `kick = 20`.
-    timer: Timer => TimerConfig [0.0, 0.0, 0.0, 0.02, 0] {
-        /// How far ahead of the clock, in milliseconds, a client may get before it is flagged.
-        tolerance_ms: f64 = 300.0,
-        /// The most time, in milliseconds, a quiet connection banks for the ticks that follow (a lag
-        /// spike's backlog arrives at once).
-        max_lag_ms: f64 = 1000.0,
-    }
-
-    /// Ground: a move that says it ends on the ground with nothing there to stand on: no-fall (claiming
-    /// the ground to skip fall damage) and walking on water. The claim is dropped, so vanilla's
-    /// fall damage follows (the player is never sent back: `setback = 0` makes the check log only), and
-    /// a player that keeps claiming is kicked, then banned at the second kick (`ban_after = 2`). A claim standing still isn't
-    /// judged (no fall to skip). On the official server's first two hours (67 players), every player who
-    /// wasn't flying or walking on water peaked at level 7 (4 claims standing still in one second); the
-    /// ones who were, at 113 to 3749.
-    ground: Ground => GroundConfig [10.0, 15.0, 30.0, 2.0, 2] {}
-
-    /// Prediction: each move played again from the client's own inputs with vanilla's movement code,
-    /// and compared (speed, step, fly, jesus...). Each player's client ticks are recorded
-    /// (`prediction::Record`), with a ping a tick to place what the server changes, and played again
-    /// (horizon-client's `lan::prediction`). A move that lands farther than `tolerance` from the
-    /// replay flags, by how far it lands (one `tolerance` off weighs 1, at most 5 a tick), and the
-    /// setback puts the player back where its moves last agreed. A tick near what the replay can't
-    /// play yet (another entity, a block change or abilities the client hadn't seen, a moving piston,
-    /// a chunk the client doesn't have, a riptide launch) is excused, and so are the ticks after it
-    /// until the moves agree again. It logs only by default; once trusted: `setback = 5`, `alert = 15`,
-    /// `kick = 60`.
-    prediction: Prediction => PredictionConfig [0.0, 0.0, 0.0, 2.0, 0] {
-        /// How far, in blocks, a move may land from where the replay puts it.
-        tolerance: f64 = 0.03,
-    }
-
-    /// Combat: attacks vanilla's client can't send (`combat`): one with no swing after it (a kill aura
-    /// that hides its swing), or a second entity attacked in the same client tick (vanilla attacks the
-    /// one entity under the crosshair, picked once a tick). Each flags once; from `setback` on the
-    /// player's attacks are dropped. A vanilla client never trips it, so it acts by default: the first
-    /// kick warns, the second bans (`ban_after = 2`).
-    combat: Combat => CombatConfig [2.0, 5.0, 20.0, 0.5, 2] {}
-}
-
-/// How many checks there are.
-pub const CHECKS: usize = Check::ALL.len();
-
-impl Config {
-    /// The `[anticheat]` section of a whole `server.toml`; the default (off) when it has none.
-    pub fn from_server_toml(text: &str) -> Result<Self, String> {
-        #[derive(Deserialize)]
-        struct File {
-            #[serde(default)]
-            anticheat: Config,
-        }
-        // Other sections are the supervisor's to check: only this one is read here.
-        let mut table: toml::Table = toml::from_str(text).map_err(|e| e.to_string())?;
-        let mut only = toml::Table::new();
-        if let Some(section) = table.remove("anticheat") {
-            only.insert("anticheat".into(), section);
-        }
-        let file: File = only
-            .try_into()
-            .map_err(|e: toml::de::Error| format!("[anticheat]: {e}"))?;
-        file.anticheat.check()?;
-        Ok(file.anticheat)
-    }
-
-    /// Thresholds can't be negative.
-    pub fn check(&self) -> Result<(), String> {
-        for &c in Check::ALL {
-            let a = self.actions(c);
-            if [a.setback, a.alert, a.kick, a.decay]
-                .iter()
-                .any(|v| !v.is_finite() || *v < 0.0)
-            {
-                return Err(format!(
-                    "anticheat.{}: setback, alert, kick and decay are numbers from 0 up",
-                    c.name()
-                ));
-            }
-        }
-        let tolerance = self.prediction.tolerance;
-        if !tolerance.is_finite() || tolerance <= 0.0 {
-            return Err("anticheat.prediction: tolerance is a number of blocks above 0".into());
-        }
-        Ok(())
-    }
-}
-
-/// How many times each check kicked each player, kept across sessions (`strikes`, a JSON object of
-/// players' UUIDs to check names to counts): the kick that reaches a check's `ban_after` is a ban.
-#[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
-#[serde(transparent)]
-pub struct Strikes(pub BTreeMap<String, BTreeMap<String, u32>>);
-
-impl Strikes {
-    /// Player `uuid` was kicked by `check`: its kicks by it so far, this one included, and whether this
-    /// one bans. A ban starts the count again, so a player an operator pardons is kicked before the
-    /// next ban.
-    pub fn kick(&mut self, uuid: &str, check: Check, ban_after: u32) -> (u32, bool) {
-        let count = self
-            .0
-            .entry(uuid.to_owned())
-            .or_default()
-            .entry(check.name().to_owned())
-            .or_default();
-        *count = count.saturating_add(1);
-        let kicks = *count;
-        let ban = ban_after > 0 && kicks >= ban_after;
-        if ban {
-            *count = 0;
-        }
-        (kicks, ban)
-    }
-}
-
-/// What a flag leads to.
-#[derive(Clone, Copy, Debug, Default, PartialEq)]
-pub struct Verdict {
-    /// The check's violation level after the flag.
-    pub vl: f32,
-    /// Cancel the move or action.
-    pub setback: bool,
-    /// Tell operators and the console (at most once a second per check).
-    pub alert: bool,
-    pub kick: bool,
-}
-
-/// One player's anticheat state. Clean players cost nothing: levels only change when a check flags.
-#[derive(Clone, Debug, Default)]
-pub struct Player {
-    vl: [f32; CHECKS],
-    /// The server tick of each check's last flag (its decay runs from there).
-    flagged: [u64; CHECKS],
-    /// The server tick of each check's last alert.
-    alerted: [Option<u64>; CHECKS],
-    pub timer: timer::Balance,
-    /// The server tick and height where the ground last held the player.
-    pub ground: Option<(u64, f64)>,
-    /// The client ticks the prediction plays again (only while it runs).
-    pub record: Option<Box<prediction::Record>>,
-    /// Sprinting as the client's own commands left it (ServerboundPlayerCommandPacket's
-    /// START_SPRINTING and STOP_SPRINTING: LocalPlayer.wasSprinting), which the record's ticks take.
-    /// Not the server's player: a hit with extra knockback stops its sprint
-    /// (Player.causeExtraKnockback), the client's own `Player.attack` doesn't (a mob's `hurtClient`
-    /// is false), and once the server's flag reaches it LocalPlayer.aiStep starts the sprint again
-    /// while the sprint key is held, with nothing to say: wasSprinting never changed.
-    pub sprinting: bool,
-    /// The attacks of the client tick being heard.
-    pub attacks: combat::Attacks,
-}
-
-impl Player {
-    /// The check's violation level at `tick`, with its decay since the last flag.
-    pub fn vl(&self, config: &Config, check: Check, tick: u64) -> f32 {
-        let i = check as usize;
-        let seconds = tick.saturating_sub(self.flagged[i]) as f32 / 20.0;
-        (self.vl[i] - config.actions(check).decay * seconds).max(0.0)
-    }
-
-    /// `check` failed with this weight at server tick `tick`.
-    pub fn flag(&mut self, config: &Config, check: Check, weight: f32, tick: u64) -> Verdict {
-        let i = check as usize;
-        let a = config.actions(check);
-        let vl = self.vl(config, check, tick) + weight;
-        self.vl[i] = vl;
-        self.flagged[i] = tick;
-        let reached = |threshold: f32| threshold > 0.0 && vl >= threshold;
-        let alert = reached(a.alert) && self.alerted[i].is_none_or(|t| tick >= t + 20);
-        if alert {
-            self.alerted[i] = Some(tick);
-        }
-        Verdict {
-            vl,
-            setback: reached(a.setback),
-            alert,
-            kick: reached(a.kick),
-        }
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    fn on() -> Config {
-        Config {
-            enabled: true,
-            ..Config::default()
-        }
-    }
-
-    #[test]
-    fn on_by_default_but_only_combat_and_ground_act() {
-        let c = Config::from_server_toml("[server]\nport = 25565\n").unwrap();
-        assert_eq!(c, Config::default());
-        for &check in Check::ALL {
-            assert!(c.runs(check), "{}", check.name());
-            let a = c.actions(check);
-            let acts = [a.setback, a.alert, a.kick] != [0.0; 3];
-            assert_eq!(
-                acts,
-                matches!(check, Check::Combat | Check::Ground),
-                "{}",
-                check.name()
-            );
-        }
-        let off = Config::from_server_toml("[anticheat]\nenabled = false\n").unwrap();
-        assert!(Check::ALL.iter().all(|&check| !off.runs(check)));
-    }
-
-    #[test]
-    fn reads_its_section() {
-        let text = "[server]\nport = 1\n[anticheat]\nenabled = true\n[anticheat.timer]\nkick = 0\ntolerance_ms = 500\n";
-        let c = Config::from_server_toml(text).unwrap();
-        assert!(c.runs(Check::Timer));
-        assert_eq!(c.timer.kick, 0.0);
-        assert_eq!(c.timer.tolerance_ms, 500.0);
-        assert_eq!(c.timer.alert, TimerConfig::default().alert);
-        let zero = "[anticheat]\n[anticheat.prediction]\ntolerance = 0\n";
-        assert!(Config::from_server_toml(zero).is_err());
-        let off = "[anticheat]\nenabled = true\n[anticheat.timer]\nenabled = false\n";
-        assert!(!Config::from_server_toml(off).unwrap().runs(Check::Timer));
-    }
-
-    #[test]
-    fn refuses_unknown_keys_and_negative_levels() {
-        assert!(Config::from_server_toml("[anticheat]\nenable = true\n").is_err());
-        assert!(Config::from_server_toml("[anticheat.timer]\nkick = -1\n").is_err());
-    }
-
-    #[test]
-    fn levels_rise_decay_and_act_in_order() {
-        let mut c = on();
-        c.timer = TimerConfig {
-            setback: 2.0,
-            alert: 3.0,
-            kick: 5.0,
-            decay: 1.0,
-            ..TimerConfig::default()
-        };
-        let mut p = Player::default();
-        let v = p.flag(&c, Check::Timer, 1.0, 100);
-        assert_eq!((v.setback, v.alert, v.kick), (false, false, false));
-        let v = p.flag(&c, Check::Timer, 1.0, 100);
-        assert_eq!((v.vl, v.setback, v.alert), (2.0, true, false));
-        let v = p.flag(&c, Check::Timer, 1.0, 100);
-        assert!(v.alert && !v.kick);
-        // At most one alert a second.
-        assert!(!p.flag(&c, Check::Timer, 0.5, 110).alert);
-        // 3 at tick 110 (half a level gone, half added); two seconds later two more are gone.
-        assert_eq!(p.vl(&c, Check::Timer, 150), 1.0);
-        assert_eq!(p.vl(&c, Check::Timer, 10_000), 0.0);
-        let v = p.flag(&c, Check::Timer, 5.0, 10_000);
-        assert!(v.kick && v.alert);
-    }
-
-    #[test]
-    fn the_kick_that_reaches_ban_after_bans() {
-        let c = Config::default();
-        assert_eq!(c.actions(Check::Combat).ban_after, 2);
-        assert_eq!(c.actions(Check::Prediction).ban_after, 0);
-        let mut s = Strikes::default();
-        assert_eq!(s.kick("a", Check::Combat, 2), (1, false));
-        // Another player, another check: their own counts.
-        assert_eq!(s.kick("b", Check::Combat, 2), (1, false));
-        assert_eq!(s.kick("a", Check::Timer, 2), (1, false));
-        assert_eq!(s.kick("a", Check::Combat, 2), (2, true));
-        // Pardoned, the player is kicked once more before the next ban.
-        assert_eq!(s.kick("a", Check::Combat, 2), (1, false));
-        // 0 never bans; 1 bans at the first kick.
-        assert_eq!(s.kick("c", Check::Timer, 0), (1, false));
-        assert_eq!(s.kick("c", Check::Timer, 0), (2, false));
-        assert_eq!(s.kick("d", Check::Ground, 1), (1, true));
-    }
-
-    #[test]
-    fn zero_turns_an_action_off() {
-        let mut c = on();
-        c.timer.kick = 0.0;
-        let mut p = Player::default();
-        assert!(!p.flag(&c, Check::Timer, 1000.0, 1).kick);
-    }
-}

crates/horizon-anticheat/src/prediction.rs

@@ -1,416 +0,0 @@
-//! The movement prediction's record: each of a player's client ticks as the server heard them, so
-//! the server can play the tick again with vanilla's movement code and compare (docs/anticheat.md).
-//!
-//! A vanilla client ends every tick with ServerboundClientTickEndPacket, after the tick's input
-//! (ServerboundPlayerInputPacket, sent when the keys change) and its move (ServerboundMovePlayerPacket,
-//! when it moved or turned). Those packets arrive in order, so the packets between two tick ends are one
-//! client tick.
-//!
-//! What the server changes about the player (a push, a teleport, an effect) takes effect on the client
-//! when it handles the packet, which is some client ticks after the server sent it. At the end of each of
-//! its ticks the server sends a ClientboundPingPacket whose id is that server tick; the client answers
-//! with ServerboundPongPacket as soon as it handles it, before its next tick runs. A client tick knows
-//! the last server tick it had handled: every change of that server tick or an earlier one was in effect
-//! during the client tick, none of a later one.
-
-use std::collections::VecDeque;
-
-/// Client ticks kept: two seconds at 20 a second.
-pub const KEPT: usize = 40;
-
-/// Server changes kept, the oldest dropped first.
-const CHANGES_KEPT: usize = 64;
-
-/// Changes near the player kept until every kept tick has seen them.
-const NEAR_KEPT: usize = 1024;
-
-/// Something the server sent the player that changes how its client moves. The client applies it when
-/// it handles the packet, before its next tick.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub enum Change {
-    /// ClientboundSetEntityMotionPacket for the player itself: its new velocity, as the client
-    /// decodes it.
-    Velocity([f64; 3]),
-    /// ClientboundExplodePacket's player knockback, added to the velocity.
-    Knockback([f64; 3]),
-    /// ClientboundUpdateAttributesPacket for the player itself: the server's attributes as they
-    /// are when the replay reaches it, but for the movement speed's sprint modifier, which the
-    /// client's sprinting decides: `sprint` is whether the packet had it when it carried the
-    /// movement speed (the client takes the modifiers as sent, so a sprint modifier the packet
-    /// lacks is gone while the client sprints), None when it didn't (the client keeps its own).
-    Attributes { sprint: Option<bool> },
-    /// ClientboundSetEntityDataPacket for the player itself with its shared flags: their sprinting
-    /// bit, which the client takes as sent (SynchedEntityData.assignValues sets the flag alone, its
-    /// speed modifier and wasSprinting stay). A client whose sprint the server cleared this way
-    /// starts it again in its next aiStep, which adds the modifier back, and says nothing.
-    Sprinting(bool),
-    /// ClientboundUpdateMobEffectPacket or ClientboundRemoveMobEffectPacket for the player itself:
-    /// the server's effects, as they are when the replay reaches it. (Their attribute modifiers
-    /// are the server's: they reach the client as attributes.)
-    Effects,
-    /// ClientboundPlayerAbilitiesPacket (a game mode, flight given or taken), or the player's chest
-    /// slot (a glider put on or taken off): the replay takes these from the server every tick, so a
-    /// tick played before the client had them may be off.
-    Abilities,
-}
-
-/// A teleport the client accepted: the replay starts again from it.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub struct Restart {
-    /// Where it put the player.
-    pub at: [f64; 3],
-    /// It kept the player's motion (an End gateway's).
-    pub kept_motion: bool,
-    /// Client ticks ended and changes heard before it: the ones after are the replay's.
-    pub ended: u64,
-    pub changed: u64,
-}
-
-/// One client tick.
-#[derive(Clone, Copy, Debug, Default, PartialEq)]
-pub struct ClientTick {
-    /// The keys held (ServerboundPlayerInputPacket's flags: forward, backward, left, right, jump,
-    /// shift, sprint), as last sent.
-    pub input: u8,
-    /// Sprinting, as the player's commands left it (ServerboundPlayerCommandPacket).
-    pub sprinting: bool,
-    /// The rotation the client last sent.
-    pub yaw: f32,
-    pub pitch: f32,
-    /// Where the tick's move said the player is, if it said: a move with a position.
-    pub position: Option<[f64; 3]>,
-    /// The tick's move packet's flags (1: on the ground, 2: against a wall), if it sent one.
-    pub flags: Option<u8>,
-    /// The last server tick whose packets the client had handled (its pong) before this tick ended.
-    pub seen: Option<u64>,
-}
-
-/// A player's last client ticks.
-#[derive(Clone, Debug, Default)]
-pub struct Record {
-    /// The tick being heard.
-    current: ClientTick,
-    /// The ended ones, oldest first, at most [`KEPT`].
-    ticks: VecDeque<ClientTick>,
-    /// The last server tick the client answered for.
-    seen: Option<u64>,
-    /// Client ticks ended since the record began.
-    ended: u64,
-    /// Where an accepted teleport put the player, until the replay starts again from there.
-    restart: Option<Restart>,
-    /// What the server changed, with the server tick that sent it, oldest first.
-    changes: VecDeque<(u64, Change)>,
-    /// Changes heard since the record began.
-    changed: u64,
-    /// The blocks the server changed near the player (None: an entity it stopped showing the player
-    /// from near it, which counts wherever the player has gone since), with the server tick that sent
-    /// each, until every kept tick has seen them.
-    near: VecDeque<(u64, Option<[i32; 3]>)>,
-    /// The server tick of the last of them dropped early ([`NEAR_KEPT`] came after it).
-    near_dropped: Option<u64>,
-}
-
-impl Record {
-    /// The tick's move: its position if it has one, the rotation if it has one, and its flags.
-    pub fn moved(&mut self, position: Option<[f64; 3]>, rotation: Option<(f32, f32)>, flags: u8) {
-        if position.is_some() {
-            self.current.position = position;
-        }
-        if let Some((yaw, pitch)) = rotation {
-            (self.current.yaw, self.current.pitch) = (yaw, pitch);
-        }
-        self.current.flags = Some(flags);
-    }
-
-    /// ServerboundPongPacket for the ping sent at the end of `server_tick`. False for an answer to a
-    /// ping that was never sent, or one older than an answer already heard: a vanilla client answers
-    /// every ping, once, in order.
-    pub fn pong(&mut self, server_tick: u64, sent_up_to: u64) -> bool {
-        if server_tick > sent_up_to || self.seen.is_some_and(|seen| server_tick <= seen) {
-            return false;
-        }
-        self.seen = Some(server_tick);
-        true
-    }
-
-    /// ServerboundClientTickEndPacket: the tick ends with these keys held and this sprinting. The
-    /// next tick starts with the same keys and rotation, until the client says otherwise.
-    pub fn tick_end(&mut self, input: u8, sprinting: bool) -> &ClientTick {
-        self.current.input = input;
-        self.current.sprinting = sprinting;
-        self.current.seen = self.seen;
-        let next = ClientTick {
-            yaw: self.current.yaw,
-            pitch: self.current.pitch,
-            ..ClientTick::default()
-        };
-        let ended = std::mem::replace(&mut self.current, next);
-        if self.ticks.len() == KEPT {
-            self.ticks.pop_front();
-        }
-        self.ticks.push_back(ended);
-        self.ended += 1;
-        // What the oldest tick kept had seen, every later one had too.
-        if let Some(seen) = self.ticks.front().and_then(|t| t.seen) {
-            while self.near.front().is_some_and(|&(sent, _)| sent <= seen) {
-                self.near.pop_front();
-            }
-            self.near_dropped = self.near_dropped.filter(|&sent| sent > seen);
-        }
-        self.ticks.back().expect("just pushed")
-    }
-
-    /// The ended ticks, oldest first.
-    pub fn ticks(&self) -> impl DoubleEndedIterator<Item = &ClientTick> + ExactSizeIterator {
-        self.ticks.iter()
-    }
-
-    /// The last server tick the client answered for.
-    pub fn seen(&self) -> Option<u64> {
-        self.seen
-    }
-
-    /// Client ticks ended since the record began.
-    pub fn ended(&self) -> u64 {
-        self.ended
-    }
-
-    /// The ticks ended after the first `played`, oldest first; None when some of them are no longer
-    /// kept.
-    pub fn since(&self, played: u64) -> Option<impl Iterator<Item = &ClientTick>> {
-        let new = self.ended.checked_sub(played)?;
-        let new = usize::try_from(new)
-            .ok()
-            .filter(|&n| n <= self.ticks.len())?;
-        Some(self.ticks.iter().skip(self.ticks.len() - new))
-    }
-
-    /// `change`, sent during server tick `server_tick` (before that tick's ping).
-    pub fn changed(&mut self, server_tick: u64, change: Change) {
-        if self.changes.len() == CHANGES_KEPT {
-            self.changes.pop_front();
-        }
-        self.changes.push_back((server_tick, change));
-        self.changed += 1;
-    }
-
-    /// Changes heard since the record began.
-    pub fn changes(&self) -> u64 {
-        self.changed
-    }
-
-    /// The changes after the first `applied`, oldest first; None when some of them are no longer kept.
-    pub fn changes_since(
-        &self,
-        applied: u64,
-    ) -> Option<impl Iterator<Item = &(u64, Change)> + Clone> {
-        let new = self.changed.checked_sub(applied)?;
-        let new = usize::try_from(new)
-            .ok()
-            .filter(|&n| n <= self.changes.len())?;
-        Some(self.changes.iter().skip(self.changes.len() - new))
-    }
-
-    /// During server tick `server_tick` (before that tick's ping) the server sent the client the block
-    /// at `pos`.
-    pub fn changed_near(&mut self, server_tick: u64, pos: [i32; 3]) {
-        self.note_near(server_tick, Some(pos));
-    }
-
-    /// During server tick `server_tick` the server stopped showing the client an entity near it (a
-    /// firework it flew with, a mob that pushed it): the client may still have it, wherever it goes.
-    pub fn entity_gone(&mut self, server_tick: u64) {
-        if self.near.back() != Some(&(server_tick, None)) {
-            self.note_near(server_tick, None);
-        }
-    }
-
-    fn note_near(&mut self, server_tick: u64, pos: Option<[i32; 3]>) {
-        if self.near.len() == NEAR_KEPT {
-            self.near_dropped = self.near.pop_front().map(|(sent, _)| sent);
-        }
-        self.near.push_back((server_tick, pos));
-    }
-
-    /// Whether a client tick that had `seen` up to that server tick (its [`ClientTick::seen`]) may
-    /// not have had a change at a position for which `near` holds: it still had the old block, or the
-    /// entity, where the server no longer has it.
-    pub fn unseen_near(&self, seen: Option<u64>, near: impl Fn([i32; 3]) -> bool) -> bool {
-        let unseen = |sent: u64| seen.is_none_or(|seen| sent > seen);
-        self.near_dropped.is_some_and(unseen)
-            || self
-                .near
-                .iter()
-                .any(|&(sent, pos)| unseen(sent) && pos.is_none_or(&near))
-    }
-
-    /// The client accepted a teleport to `at` (ServerboundAcceptTeleportationPacket): it goes on from
-    /// there, standing still unless the teleport `kept_motion` (an End gateway's). The ticks it ended
-    /// before stay, for a replay that hasn't played them yet; the one under way starts again.
-    pub fn teleported(&mut self, at: [f64; 3], kept_motion: bool) {
-        self.restart_tick();
-        self.restart = Some(Restart {
-            at,
-            kept_motion,
-            ended: self.ended,
-            changed: self.changed,
-        });
-    }
-
-    /// The last teleport the client accepted, once.
-    pub fn take_restart(&mut self) -> Option<Restart> {
-        self.restart.take()
-    }
-
-    /// The ticks before now say nothing about the ones after.
-    pub fn clear(&mut self) {
-        self.ticks.clear();
-        self.restart_tick();
-    }
-
-    fn restart_tick(&mut self) {
-        self.current = ClientTick {
-            yaw: self.current.yaw,
-            pitch: self.current.pitch,
-            ..ClientTick::default()
-        };
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn a_change_near_is_unseen_by_the_ticks_before_its_pong() {
-        let mut r = Record::default();
-        r.changed_near(4, [1, 2, 3]);
-        r.changed_near(5, [7, 2, 3]);
-        let near = |p: [i32; 3]| p[0] < 5;
-        assert!(r.unseen_near(None, near));
-        assert!(r.unseen_near(Some(3), near));
-        assert!(!r.unseen_near(Some(4), near));
-        assert!(r.unseen_near(Some(4), |_| true));
-        // Kept until the oldest tick kept had seen it: one that ended before the pong hadn't.
-        r.tick_end(0, false);
-        assert!(r.pong(5, 5));
-        r.tick_end(0, false);
-        assert!(r.unseen_near(Some(3), near));
-        for _ in 0..KEPT {
-            r.tick_end(0, false);
-        }
-        assert!(!r.unseen_near(None, |_| true));
-        // An entity gone counts anywhere.
-        r.entity_gone(5);
-        r.entity_gone(5);
-        assert!(r.unseen_near(Some(4), |_| false));
-        assert!(!r.unseen_near(Some(5), |_| false));
-        // One dropped early counts for the ticks that hadn't seen it.
-        for i in 0..=NEAR_KEPT as u64 {
-            r.changed_near(6 + i, [100, 0, 0]);
-        }
-        assert!(
-            r.unseen_near(Some(5), near),
-            "a change dropped unseen counts"
-        );
-        assert!(!r.unseen_near(Some(6), near));
-    }
-
-    #[test]
-    fn a_tick_is_the_packets_between_two_tick_ends() {
-        let mut r = Record::default();
-        r.moved(Some([1.0, 2.0, 3.0]), Some((90.0, 10.0)), 1);
-        let t = *r.tick_end(0b1001, true);
-        assert_eq!(t.position, Some([1.0, 2.0, 3.0]));
-        assert_eq!((t.yaw, t.pitch, t.flags), (90.0, 10.0, Some(1)));
-        assert_eq!((t.input, t.sprinting, t.seen), (0b1001, true, None));
-        // A tick without a move keeps the rotation and has no position.
-        let t = *r.tick_end(0, false);
-        assert_eq!((t.position, t.flags, t.yaw), (None, None, 90.0));
-        assert_eq!(r.ticks().len(), 2);
-    }
-
-    #[test]
-    fn pongs_say_which_server_ticks_a_client_tick_had_seen() {
-        let mut r = Record::default();
-        assert!(r.pong(5, 6));
-        r.tick_end(0, false);
-        assert!(r.pong(6, 6));
-        r.tick_end(0, false);
-        r.tick_end(0, false);
-        let seen: Vec<_> = r.ticks().map(|t| t.seen).collect();
-        assert_eq!(seen, [Some(5), Some(6), Some(6)]);
-        // Never sent, answered twice, or out of order.
-        assert!(!r.pong(9, 6));
-        assert!(!r.pong(6, 6));
-        assert!(!r.pong(4, 6));
-        assert_eq!(r.seen(), Some(6));
-    }
-
-    #[test]
-    fn only_the_last_two_seconds_are_kept() {
-        let mut r = Record::default();
-        for i in 0..KEPT + 5 {
-            r.moved(Some([i as f64, 0.0, 0.0]), None, 0);
-            r.tick_end(0, false);
-        }
-        assert_eq!(r.ticks().len(), KEPT);
-        assert_eq!(r.ticks().next().unwrap().position, Some([5.0, 0.0, 0.0]));
-        r.clear();
-        assert_eq!(r.ticks().len(), 0);
-    }
-
-    #[test]
-    fn the_replay_takes_the_ticks_it_has_not_played() {
-        let mut r = Record::default();
-        for i in 0..3 {
-            r.moved(Some([i as f64, 0.0, 0.0]), None, 0);
-            r.tick_end(0, false);
-        }
-        fn x(r: &Record, played: u64) -> Option<Vec<f64>> {
-            r.since(played)
-                .map(|t| t.map(|t| t.position.unwrap()[0]).collect())
-        }
-        assert_eq!(x(&r, 1), Some(vec![1.0, 2.0]));
-        assert_eq!(x(&r, 3), Some(vec![]));
-        // Played ahead of the record, or so far behind the ticks are gone.
-        assert_eq!(x(&r, 4), None);
-        r.clear();
-        assert_eq!(x(&r, 2), None);
-        assert_eq!(x(&r, 3), Some(vec![]));
-        r.moved(Some([8.0, 0.0, 0.0]), None, 0);
-        r.tick_end(0, false);
-        r.moved(Some([9.0, 0.0, 0.0]), None, 0);
-        r.teleported([5.0, 6.0, 7.0], false);
-        // A tick that ends before the replay starts again is still one after the teleport.
-        r.tick_end(0, false);
-        let restart = r.take_restart().unwrap();
-        assert_eq!((restart.at, restart.kept_motion), ([5.0, 6.0, 7.0], false));
-        assert_eq!(r.since(restart.ended).unwrap().count(), 1);
-        // The tick ended before it stays for a replay that hasn't played it; the move of the one
-        // under way is gone.
-        let positions: Vec<_> = r.since(3).unwrap().map(|t| t.position).collect();
-        assert_eq!(positions, [Some([8.0, 0.0, 0.0]), None]);
-        assert_eq!(r.take_restart(), None);
-    }
-
-    #[test]
-    fn changes_keep_the_server_tick_that_sent_them() {
-        let mut r = Record::default();
-        r.changed(3, Change::Velocity([0.0, 0.4, 0.0]));
-        r.changed(5, Change::Effects);
-        let all: Vec<_> = r.changes_since(0).unwrap().copied().collect();
-        assert_eq!(
-            all,
-            [(3, Change::Velocity([0.0, 0.4, 0.0])), (5, Change::Effects)]
-        );
-        assert_eq!(r.changes_since(1).unwrap().count(), 1);
-        assert!(r.changes_since(3).is_none());
-        for i in 0..CHANGES_KEPT as u64 {
-            r.changed(6 + i, Change::Effects);
-        }
-        // The first two are gone.
-        assert!(r.changes_since(1).is_none());
-        assert_eq!(r.changes_since(2).unwrap().count(), CHANGES_KEPT);
-    }
-}

crates/horizon-anticheat/src/timer.rs

@@ -1,111 +0,0 @@
-//! The timer check's balance: how far a client's ticks are behind (positive) or ahead (negative) of the
-//! server's clock, in milliseconds.
-//!
-//! The server adds the wall-clock time of each of its ticks, and every ServerboundClientTickEndPacket
-//! takes away the length of one tick at the server's tick rate (vanilla's client ticks at that rate,
-//! `TickRateManager.millisecondsPerTick`). The balance is capped at `max_lag_ms` *after* the tick's
-//! packets are counted: a slow server tick that handles a second of packets at once also added that
-//! second, and a quiet connection banks at most `max_lag_ms` for the burst that ends a lag spike.
-
-use crate::TimerConfig;
-
-#[derive(Clone, Debug, Default)]
-pub struct Balance {
-    pub ms: f64,
-}
-
-impl Balance {
-    /// The start of a server tick that came `elapsed_ms` after the previous one.
-    pub fn elapse(&mut self, elapsed_ms: f64, config: &TimerConfig) {
-        self.ms = self.ms.min(config.max_lag_ms) + elapsed_ms;
-    }
-
-    /// One client tick ended, at a tick rate of `tick_rate` a second. Some(how far ahead, in ms) when the
-    /// client is further ahead than the tolerance; the balance starts again from zero then, so a
-    /// sustained speed-up is flagged again each time it gets that far ahead.
-    pub fn tick_end(&mut self, tick_rate: f32, config: &TimerConfig) -> Option<f64> {
-        self.ms -= 1000.0 / f64::from(tick_rate.max(1.0));
-        if self.ms < -config.tolerance_ms {
-            let ahead = -self.ms;
-            self.ms = 0.0;
-            return Some(ahead);
-        }
-        None
-    }
-
-    /// The tick rate changed or the player arrived: start again.
-    pub fn reset(&mut self) {
-        self.ms = 0.0;
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    /// `seconds` of server ticks of `server_ms` each, with `per_tick` client ticks handled in each.
-    fn run(b: &mut Balance, server_ms: f64, per_tick: f64, seconds: f64) -> usize {
-        let c = TimerConfig::default();
-        let mut owed = 0.0;
-        let mut flags = 0;
-        for _ in 0..(seconds * 1000.0 / server_ms) as usize {
-            b.elapse(server_ms, &c);
-            owed += per_tick;
-            while owed >= 1.0 {
-                owed -= 1.0;
-                flags += usize::from(b.tick_end(20.0, &c).is_some());
-            }
-        }
-        flags
-    }
-
-    #[test]
-    fn a_vanilla_client_is_never_flagged() {
-        let mut b = Balance::default();
-        assert_eq!(run(&mut b, 50.0, 1.0, 600.0), 0);
-        // A server that runs at 10 ticks a second handles two client ticks in each.
-        assert_eq!(run(&mut b, 100.0, 2.0, 600.0), 0);
-    }
-
-    #[test]
-    fn a_slow_server_tick_with_its_backlog_is_not_flagged() {
-        let (mut b, c) = (Balance::default(), TimerConfig::default());
-        b.elapse(3000.0, &c);
-        for _ in 0..60 {
-            assert_eq!(b.tick_end(20.0, &c), None);
-        }
-    }
-
-    #[test]
-    fn a_short_network_stall_is_not_flagged() {
-        let (mut b, c) = (Balance::default(), TimerConfig::default());
-        // 800 ms with nothing arriving, then the 16 ticks sent meanwhile.
-        for _ in 0..16 {
-            b.elapse(50.0, &c);
-        }
-        b.elapse(50.0, &c);
-        for _ in 0..17 {
-            assert_eq!(b.tick_end(20.0, &c), None);
-        }
-    }
-
-    #[test]
-    fn a_sped_up_client_is_flagged_again_and_again() {
-        let mut b = Balance::default();
-        // 10 % faster: 5 ms ahead each tick, 300 ms after 3 s, so close to 20 flags a minute.
-        let flags = run(&mut b, 50.0, 1.1, 60.0);
-        assert!((15..=20).contains(&flags), "{flags}");
-        // Twice as fast: a flag every 7 ticks.
-        assert!(run(&mut Balance::default(), 50.0, 2.0, 10.0) >= 25);
-    }
-
-    #[test]
-    fn a_pause_cant_be_saved_for_a_burst() {
-        let (mut b, c) = (Balance::default(), TimerConfig::default());
-        for _ in 0..200 {
-            b.elapse(50.0, &c);
-        }
-        let flagged = (0..60).any(|_| b.tick_end(20.0, &c).is_some());
-        assert!(flagged);
-    }
-}

crates/horizon-assets/src/item_bake.rs

@@ -7,7 +7,7 @@ use crate::{
     json::Result,
     math::{Mat4, quaternion_xyz},
     model::{Direction, DisplayTransform, GuiLight, ItemTransform, Material},
-    resolve::{ModelLibrary, ResolvedCuboidModel},
+    resolve::ModelLibrary,
 };
 use std::{collections::BTreeSet, f32::consts::PI};
 
@@ -110,15 +110,6 @@ pub fn bake_item_model(
     let model = library
         .resolve(name)
         .or_else(|_| library.resolve(crate::resolve::MISSING_MODEL))?;
-    bake_resolved(&model, sprites)
-}
-
-/// Bake an already resolved model, e.g. one from
-/// [`ModelLibrary::resolve_with_textures`].
-pub fn bake_resolved(
-    model: &ResolvedCuboidModel,
-    sprites: &dyn SpriteLookup,
-) -> Result<BakedItemModel> {
     let known = |sprite: &str| sprite == MISSING_SPRITE || sprites.mask(sprite).is_some();
     let material = |m: &Material| {
         if known(&m.sprite) {
@@ -152,7 +143,7 @@ pub fn bake_resolved(
         quads
     } else {
         let mut quads =
-            bake_block_model(model, crate::bake::BlockModelTransform::new([0; 3], false))?;
+            bake_block_model(&model, crate::bake::BlockModelTransform::new([0; 3], false))?;
         for q in &mut quads {
             q.material = material(&q.material);
         }
@@ -307,87 +298,3 @@ fn extrude_layer(mask: &SpriteMask, material: &Material, layer: i32) -> Result<V
     }
     Ok(quads)
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::model::{CuboidModel, TextureSlot};
-    use std::collections::BTreeMap;
-
-    /// The stick: 2x2 with one transparent pixel. `item/cit`: one opaque pixel, so a bake
-    /// shows whose mask it extruded.
-    struct Sprites;
-    impl SpriteLookup for Sprites {
-        fn mask(&self, sprite: &str) -> Option<SpriteMask> {
-            match sprite {
-                "minecraft:item/stick" => Some(SpriteMask {
-                    width: 2,
-                    height: 2,
-                    frames: vec![vec![true, false, false, false]],
-                }),
-                "horizon_cit:item/cit" => Some(SpriteMask {
-                    width: 1,
-                    height: 1,
-                    frames: vec![vec![false]],
-                }),
-                _ => None,
-            }
-        }
-    }
-    fn library() -> ModelLibrary {
-        ModelLibrary::with_item_generator(BTreeMap::from(
-            [
-                ("item/generated", r#"{"parent":"builtin/generated","display":{"gui":{"scale":[2,2,2]}}}"#),
-                ("item/stick", r#"{"parent":"item/generated","textures":{"layer0":"item/stick"}}"#),
-                ("horizon:loop", r#"{"parent":"horizon:loop2"}"#),
-                ("horizon:loop2", r#"{"parent":"horizon:loop"}"#),
-                ("block/slab", r##"{"textures":{"particle":"#side","side":"block/absent"},"elements":[{"from":[0,0,0],"to":[16,8,16],"faces":{"up":{"texture":"#side"},"down":{"texture":"#side","cullface":"down"}}}]}"##),
-            ]
-            .map(|(name, json)| (name.to_owned(), CuboidModel::from_json(json).unwrap())),
-        ))
-        .unwrap()
-    }
-    #[test]
-    fn baking_by_name_falls_back_to_the_missing_model() {
-        let library = library();
-        // Front, back, and the 8 unit edges around the L of 3 opaque pixels.
-        let stick = bake_item_model(&library, &Sprites, "item/stick").unwrap();
-        assert_eq!(stick.quads.len(), 10);
-        // An unknown sprite bakes as the missing sprite.
-        let slab = bake_item_model(&library, &Sprites, "block/slab").unwrap();
-        assert_eq!(slab.quads.len(), 2);
-        assert_eq!(slab.particle.sprite, MISSING_SPRITE);
-        // A cyclic chain, an error to `resolve`, bakes as the missing cube.
-        let cyclic = bake_item_model(&library, &Sprites, "horizon:loop").unwrap();
-        assert_eq!(cyclic.quads.len(), 6);
-        assert!(
-            cyclic
-                .quads
-                .iter()
-                .all(|q| q.material.sprite == MISSING_SPRITE)
-        );
-    }
-    #[test]
-    fn replaced_layer_bakes_with_its_own_sprite() {
-        let library = library();
-        let child = BTreeMap::from([(
-            "layer0".to_owned(),
-            TextureSlot::Material(Material {
-                sprite: "horizon_cit:item/cit".to_owned(),
-                force_translucent: false,
-            }),
-        )]);
-        let model = library.resolve_with_textures("item/stick", &child).unwrap();
-        let baked = bake_resolved(&model, &Sprites).unwrap();
-        // The CIT sprite's own mask, one opaque pixel: front, back and 4 edges.
-        assert_eq!(baked.quads.len(), 6);
-        assert!(
-            baked
-                .quads
-                .iter()
-                .all(|q| q.material.sprite == "horizon_cit:item/cit")
-        );
-        assert_eq!(baked.particle.sprite, "horizon_cit:item/cit");
-        assert_eq!(baked.transforms[5].as_ref().unwrap().scale, [2.0; 3]);
-    }
-}

crates/horizon-assets/src/item_model.rs

@@ -16,7 +16,6 @@ use std::{
     sync::{Arc, Mutex},
 };
 
-mod component_predicate;
 mod special;
 pub use special::{SpecialKind, SpecialModel};
 
@@ -629,7 +628,7 @@ pub enum ConditionProperty {
     ExtendedView,
     KeybindDown(String),
     ViewEntity,
-    /// A single `component` predicate; external predicate types use the host.
+    /// A `component` predicate, evaluated by the host.
     Component(Value),
 }
 impl ConditionProperty {
@@ -652,7 +651,13 @@ impl ConditionProperty {
             "minecraft:extended_view" => Self::ExtendedView,
             "minecraft:keybind_down" => Self::KeybindDown(string(required(m, "keybind")?)?),
             "minecraft:view_entity" => Self::ViewEntity,
-            "minecraft:component" => Self::Component(component_predicate::decode(m)?),
+            "minecraft:component" => {
+                let predicate = required(m, "predicate")?;
+                if object(predicate)?.len() != 1 {
+                    return Err(err("a single component predicate is expected"));
+                }
+                Self::Component(predicate.clone())
+            }
             _ => return Err(err("unknown condition property")),
         })
     }
@@ -959,14 +964,10 @@ pub trait ItemEnv {
     fn bundle_fullness(&self, _stack: &StackView, _components: &Components) -> f32 {
         0.0
     }
-    /// Additional component predicate types supplied by the host.
+    /// `ItemStack.getMaxStackSize` when the prototype has no component.
     fn component_matches(&self, _stack: &StackView, _predicate: &Value) -> bool {
         false
     }
-    /// Membership in the level's enchantment registry tags.
-    fn enchantment_in_tag(&self, _enchantment: &str, _tag: &str) -> bool {
-        false
-    }
     fn is_keybind_down(&self, _keybind: &str) -> bool {
         false
     }
@@ -1334,8 +1335,7 @@ impl Resolve<'_> {
             ConditionProperty::KeybindDown(key) => self.env.is_keybind_down(key),
             ConditionProperty::ViewEntity => owner.is_some_and(|o| o.is_view_entity),
             ConditionProperty::Component(predicate) => {
-                component_predicate::matches(predicate, self.components, self.env)
-                    .unwrap_or_else(|| self.env.component_matches(self.stack, predicate))
+                self.env.component_matches(self.stack, predicate)
             }
         }
     }

crates/horizon-assets/src/item_model/component_predicate.rs

@@ -1,177 +0,0 @@
-//! Component conditions used by enchantment-dependent item models.
-use super::*;
-
-/// `DataComponentPredicate.singleCodec`: a single predicate's type discriminator
-/// (`predicate`) and its wrapped codec's separate `value` field.
-pub(super) fn decode(m: &Map<String, Value>) -> Result<Value> {
-    let id = component_type(required(m, "predicate")?)?;
-    let mut value = required(m, "value")?.clone();
-    if matches!(
-        id.as_str(),
-        "minecraft:enchantments" | "minecraft:stored_enchantments"
-    ) {
-        let mut entries = Vec::new();
-        for entry in list(&value)? {
-            let mut entry = object(entry)?.clone();
-            if let Some(selector) = get(&entry, "enchantments") {
-                let selector = match selector {
-                    Value::Array(ids) => Value::Array(
-                        ids.iter()
-                            .map(ident)
-                            .map(|r| r.map(Value::String))
-                            .collect::<Result<_>>()?,
-                    ),
-                    Value::String(name) if name.starts_with('#') => {
-                        Value::String(format!("#{}", identifier(&name[1..])?))
-                    }
-                    _ => Value::String(ident(selector)?),
-                };
-                entry.insert("enchantments".into(), selector);
-            }
-            if let Some(levels) = get(&entry, "levels") {
-                let levels = if levels.is_object() {
-                    let mut bounds = Map::new();
-                    for key in ["min", "max"] {
-                        if let Some(n) = get(object(levels)?, key) {
-                            bounds.insert(key.into(), Value::from(int(n)?));
-                        }
-                    }
-                    // MinMaxBounds.Bounds.validateSwappedBoundsInCodec.
-                    if bounds
-                        .get("min")
-                        .and_then(Value::as_i64)
-                        .zip(bounds.get("max").and_then(Value::as_i64))
-                        .is_some_and(|(min, max)| min > max)
-                    {
-                        return Err(err("minimum exceeds maximum"));
-                    }
-                    Value::Object(bounds)
-                } else {
-                    Value::from(int(levels)?)
-                };
-                entry.insert("levels".into(), levels);
-            }
-            entries.push(Value::Object(entry));
-        }
-        value = Value::Array(entries);
-    }
-    Ok(Value::Object(Map::from_iter([(id, value)])))
-}
-
-/// `EnchantmentsPredicate.matches` and `EnchantmentPredicate.containedIn`:
-/// all entries must match; each entry needs one selected, present enchantment
-/// with a matching level. An empty predicate list still needs the component.
-pub(super) fn matches(
-    predicate: &Value,
-    components: &Components,
-    env: &dyn ItemEnv,
-) -> Option<bool> {
-    let (id, expected) = predicate.as_object()?.iter().next()?;
-    if !matches!(
-        id.as_str(),
-        "minecraft:enchantments" | "minecraft:stored_enchantments"
-    ) {
-        return None;
-    }
-    let Some(have) = components.get(id).and_then(Value::as_object) else {
-        return Some(false);
-    };
-    Some(expected.as_array()?.iter().all(|entry| {
-        let Some(entry) = entry.as_object() else {
-            return false;
-        };
-        have.iter().any(|(id, level)| {
-            let level = level.as_i64().unwrap_or(0);
-            let selector = get(entry, "enchantments");
-            let selected = match selector {
-                None => true,
-                Some(Value::String(s)) => s
-                    .strip_prefix('#')
-                    .map_or(s == id, |tag| env.enchantment_in_tag(id, tag)),
-                Some(Value::Array(ids)) => ids.iter().any(|s| s.as_str() == Some(id)),
-                _ => false,
-            };
-            selected
-                && if selector.is_some() {
-                    matches_enchantment(level, get(entry, "levels"))
-                } else {
-                    level_matches(level, get(entry, "levels"))
-                }
-        })
-    }))
-}
-
-/// `EnchantmentPredicate.matchesEnchantment`: a named enchantment needs a
-/// nonzero level even when its bounds accept zero.
-fn matches_enchantment(level: i64, bounds: Option<&Value>) -> bool {
-    level != 0 && level_matches(level, bounds)
-}
-
-/// `MinMaxBounds.Ints.matches`: inclusive bounds, or an exact integer.
-fn level_matches(level: i64, bounds: Option<&Value>) -> bool {
-    match bounds {
-        None => true,
-        Some(Value::Number(n)) => n.as_i64() == Some(level),
-        Some(Value::Object(bounds)) => {
-            get(bounds, "min")
-                .and_then(Value::as_i64)
-                .is_none_or(|min| level >= min)
-                && get(bounds, "max")
-                    .and_then(Value::as_i64)
-                    .is_none_or(|max| level <= max)
-        }
-        _ => false,
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use serde_json::json;
-
-    struct Tags;
-    impl ItemEnv for Tags {
-        fn enchantment_in_tag(&self, enchantment: &str, tag: &str) -> bool {
-            enchantment == "minecraft:density" && tag == "horizon:mace"
-        }
-    }
-
-    #[test]
-    fn unnamed_predicates_inspect_entries_but_named_ones_require_a_nonzero_level() {
-        let components = Components::from_iter([(
-            "minecraft:enchantments".into(),
-            json!({"minecraft:density":0}),
-        )]);
-        assert_eq!(
-            matches(&json!({"minecraft:enchantments":[{}]}), &components, &NoEnv),
-            Some(true)
-        );
-        assert_eq!(
-            matches(
-                &json!({"minecraft:enchantments":[{"enchantments":"minecraft:density"}]}),
-                &components,
-                &NoEnv
-            ),
-            Some(false)
-        );
-    }
-
-    #[test]
-    fn enchantment_selectors_use_the_hosts_registry_tags() {
-        let condition = json!({"predicate":"enchantments", "value":[
-            {"enchantments":"#horizon:mace", "levels":{"min":3}}
-        ]});
-        let predicate = decode(condition.as_object().unwrap()).unwrap();
-        let mut components = Components::from_iter([(
-            "minecraft:enchantments".into(),
-            json!({"minecraft:density":3}),
-        )]);
-        assert_eq!(matches(&predicate, &components, &Tags), Some(true));
-        assert_eq!(matches(&predicate, &components, &NoEnv), Some(false));
-        components.insert(
-            "minecraft:enchantments".into(),
-            json!({"minecraft:density":2}),
-        );
-        assert_eq!(matches(&predicate, &components, &Tags), Some(false));
-    }
-}

crates/horizon-assets/src/math.rs

@@ -335,177 +335,6 @@ pub fn quaternion_from_axis_angle(angle: f32, axis: [f32; 3]) -> [f32; 4] {
     [axis[0] * sin, axis[1] * sin, axis[2] * sin, cos]
 }
 
-/// A JOML `Matrix3f`: `m[column][row]`.
-type Mat3 = [[f32; 3]; 3];
-
-/// `Matrix3f.mul`: `a * b`.
-fn mul3(a: &Mat3, b: &Mat3) -> Mat3 {
-    std::array::from_fn(|c| {
-        std::array::from_fn(|r| fma(a[0][r], b[c][0], fma(a[1][r], b[c][1], a[2][r] * b[c][2])))
-    })
-}
-/// `Matrix3f.transpose`.
-fn transpose3(m: &Mat3) -> Mat3 {
-    std::array::from_fn(|c| std::array::from_fn(|r| m[r][c]))
-}
-/// `Matrix3f.rotate(Quaternionfc)`: `m * R(q)`, without fma.
-fn rotate3(m: &Mat3, q: [f32; 4]) -> Mat3 {
-    let [x, y, z, w] = q;
-    let (w2, x2, y2, z2) = (w * w, x * x, y * y, z * z);
-    let (zw, xy, xz, yw, yz, xw) = (z * w, x * y, x * z, y * w, y * z, x * w);
-    let (zw, xy, xz, yw, yz, xw) = (zw + zw, xy + xy, xz + xz, yw + yw, yz + yz, xw + xw);
-    let rotation = [
-        [w2 + x2 - z2 - y2, xy + zw, xz - yw],
-        [xy - zw, y2 - z2 + w2 - x2, yz + xw],
-        [yw + xz, yz - xw, z2 - y2 - x2 + w2],
-    ];
-    std::array::from_fn(|c| {
-        let rc = rotation[c];
-        std::array::from_fn(|r| m[0][r] * rc[0] + m[1][r] * rc[1] + m[2][r] * rc[2])
-    })
-}
-/// `Quaternionf.mul`: `a * b`.
-fn quaternion_mul(a: [f32; 4], b: [f32; 4]) -> [f32; 4] {
-    let ([x, y, z, w], [qx, qy, qz, qw]) = (a, b);
-    [
-        fma(w, qx, fma(x, qw, fma(y, qz, -z * qy))),
-        fma(w, qy, fma(-x, qz, fma(y, qw, z * qx))),
-        fma(w, qz, fma(x, qy, fma(-y, qx, z * qw))),
-        fma(w, qw, fma(-x, qx, fma(-y, qy, -z * qz))),
-    ]
-}
-
-/// `GivensParameters`: the half angle's sine and cosine.
-#[derive(Clone, Copy)]
-struct Givens(f32, f32);
-
-impl Givens {
-    /// `GivensParameters.fromUnnormalized`.
-    fn unnormalized(sin_half: f32, cos_half: f32) -> Self {
-        let inv = 1.0 / (sin_half * sin_half + cos_half * cos_half).sqrt();
-        Self(inv * sin_half, inv * cos_half)
-    }
-    /// `MatrixUtil.PI_4`: `fromPositiveAngle(π / 4)`.
-    fn quarter_pi() -> Self {
-        let half = std::f32::consts::FRAC_PI_4 / 2.0;
-        let sin = joml_sin(half);
-        Self(sin, cos_from_sin(sin, half))
-    }
-    fn inverse(self) -> Self {
-        Self(-self.0, self.1)
-    }
-    fn cos(self) -> f32 {
-        self.1 * self.1 - self.0 * self.0
-    }
-    fn sin(self) -> f32 {
-        2.0 * self.0 * self.1
-    }
-    /// `aroundX/Y/Z(Quaternionf)` (axis 0, 1, 2).
-    fn quaternion(self, axis: usize) -> [f32; 4] {
-        let mut q = [0.0, 0.0, 0.0, self.1];
-        q[axis] = self.0;
-        q
-    }
-    /// `aroundX/Y/Z(Matrix3f)` (axis 0, 1, 2).
-    fn matrix(self, axis: usize) -> Mat3 {
-        let (cos, sin) = (self.cos(), self.sin());
-        let (a, b) = ((axis + 1) % 3, (axis + 2) % 3);
-        let mut m = [[0.0; 3]; 3];
-        m[axis][axis] = 1.0;
-        m[a][a] = cos;
-        m[b][b] = cos;
-        m[a][b] = sin;
-        m[b][a] = -sin;
-        m
-    }
-}
-
-/// `MatrixUtil.approxGivensQuat`.
-fn approx_givens(a11: f32, a12: f32, a22: f32) -> Givens {
-    let g = 3.0 + 2.0 * 2.0f32.sqrt();
-    let (cos_half, sin_half) = (2.0 * (a11 - a22), a12);
-    if g * sin_half * sin_half < cos_half * cos_half {
-        Givens::unnormalized(sin_half, cos_half)
-    } else {
-        Givens::quarter_pi()
-    }
-}
-/// `MatrixUtil.qrGivensQuat`.
-fn qr_givens(a1: f32, a2: f32) -> Givens {
-    let p = f64::from(a1).hypot(f64::from(a2)) as f32;
-    let mut sin_half = if p > 1.0e-6 { a2 } else { 0.0 };
-    let mut cos_half = a1.abs() + if p > 1.0e-6 { p } else { 1.0e-6 };
-    if a1 < 0.0 {
-        std::mem::swap(&mut sin_half, &mut cos_half);
-    }
-    Givens::unnormalized(sin_half, cos_half)
-}
-/// `MatrixUtil.stepJacobi`: the xy, xz then yz pairs, each by
-/// `similarityTransform` (`R^T * m * R`).
-fn step_jacobi(m: &mut Mat3, q: &mut [f32; 4]) {
-    let mut rotate = |m: &mut Mat3, g: Givens, axis: usize| {
-        *q = quaternion_mul(*q, g.quaternion(axis));
-        let r = g.matrix(axis);
-        *m = mul3(&transpose3(&r), &mul3(m, &r));
-    };
-    if m[0][1] * m[0][1] + m[1][0] * m[1][0] > 1.0e-6 {
-        let g = approx_givens(m[0][0], 0.5 * (m[0][1] + m[1][0]), m[1][1]);
-        rotate(m, g, 2);
-    }
-    if m[0][2] * m[0][2] + m[2][0] * m[2][0] > 1.0e-6 {
-        let g = approx_givens(m[0][0], 0.5 * (m[0][2] + m[2][0]), m[2][2]).inverse();
-        rotate(m, g, 1);
-    }
-    if m[1][2] * m[1][2] + m[2][1] * m[2][1] > 1.0e-6 {
-        let g = approx_givens(m[1][1], 0.5 * (m[1][2] + m[2][1]), m[2][2]);
-        rotate(m, g, 0);
-    }
-}
-
-/// `MatrixUtil.svdDecompose(Matrix4fc, ...)`, how `new Transformation(matrix)`
-/// splits a matrix: translation, left rotation, scale, right rotation. The
-/// right rotation diagonalizes `a^T * a` (`eigenvalueJacobi`, 5 steps), then
-/// QR Givens rotations about z, y and x bring `a * R(right)` to the scale.
-pub fn svd_decompose(m: &Mat4) -> ([f32; 3], [f32; 4], [f32; 3], [f32; 4]) {
-    let inv = 1.0 / m.0[3][3];
-    let a: Mat3 = std::array::from_fn(|c| std::array::from_fn(|r| m.0[c][r] * inv));
-    let mut b = mul3(&transpose3(&a), &a);
-    let mut right = [0.0, 0.0, 0.0, 1.0];
-    for _ in 0..5 {
-        step_jacobi(&mut b, &mut right);
-    }
-    right = normalize_quaternion(right);
-    let (x_small, y_small) = (f64::from(b[0][0]) < 1.0e-6, f64::from(b[1][1]) < 1.0e-6);
-    let mut left = [0.0, 0.0, 0.0, 1.0];
-    let mut r = rotate3(&a, right);
-    let mut qr = |r: &mut Mat3, g: Givens, axis: usize| {
-        left = quaternion_mul(left, g.quaternion(axis));
-        *r = mul3(&transpose3(&g.matrix(axis)), r);
-    };
-    let g = if x_small {
-        qr_givens(r[1][1], -r[1][0])
-    } else {
-        qr_givens(r[0][0], r[0][1])
-    };
-    qr(&mut r, g, 2);
-    let g = if x_small {
-        qr_givens(r[2][2], -r[2][0])
-    } else {
-        qr_givens(r[0][0], r[0][2])
-    };
-    qr(&mut r, g.inverse(), 1);
-    let g = if y_small {
-        qr_givens(r[2][2], -r[2][1])
-    } else {
-        qr_givens(r[1][1], r[1][2])
-    };
-    qr(&mut r, g, 0);
-    let scale = [r[0][0], r[1][1], r[2][2]];
-    let translation = std::array::from_fn(|i| m.0[3][i] * inv);
-    let [x, y, z, w] = right;
-    (translation, left, scale, [-x, -y, -z, w])
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -526,51 +355,6 @@ mod tests {
         assert!((m.0[0][1] - 1.0).abs() < 1e-6 && m.0[0][0].abs() < 1e-6);
     }
     #[test]
-    fn svd_decomposes_like_matrix_util() {
-        let bits = |v: &[f32]| v.iter().map(|f| f.to_bits()).collect::<Vec<_>>();
-        let parts = |m: [f32; 16]| {
-            let (t, l, s, r) = svd_decompose(&Mat4::from_row_major(m));
-            [bits(&t), bits(&l), bits(&s), bits(&r)]
-        };
-        // Values from MatrixUtil.svdDecompose on the 26.3 jar.
-        let scaled = [
-            2.0, 0.0, 0.0, 1.0, 0.0, 3.0, 0.0, -2.0, 0.0, 0.0, 0.5, 0.25, 0.0, 0.0, 0.0, 1.0,
-        ];
-        assert_eq!(
-            parts(scaled),
-            [
-                vec![0x3f80_0000u32, 0xc000_0000, 0x3e80_0000],
-                vec![0u32, 0, 0, 0x3f80_0000],
-                vec![0x4000_0000u32, 0x4040_0000, 0x3f00_0000],
-                vec![0x8000_0000u32, 0x8000_0000, 0x8000_0000, 0x3f80_0000],
-            ]
-        );
-        let quarter_turn = [
-            0.0, -1.0, 0.0, 0.5, 1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0,
-        ];
-        assert_eq!(
-            parts(quarter_turn),
-            [
-                vec![0x3f00_0000u32, 0, 0],
-                vec![0u32, 0, 0x3f35_04f3, 0x3f35_04f3],
-                vec![0x3f7f_ffffu32, 0x3f7f_ffff, 0x3f80_0000],
-                vec![0x8000_0000u32, 0x8000_0000, 0x8000_0000, 0x3f80_0000],
-            ]
-        );
-        let sheared = [
-            1.0, 0.5, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.25, 0.0, 2.0, 3.0, 0.0, 0.0, 0.0, 2.0,
-        ];
-        assert_eq!(
-            parts(sheared),
-            [
-                vec![0u32, 0, 0x3fc0_0000],
-                vec![0x3c03_7010u32, 0x3d38_d722, 0x3ea8_ef95, 0x3f71_60d9],
-                vec![0x3f23_2630u32, 0x3ec6_bdde, 0x3f81_5b1f],
-                vec![0xbcc5_7e11u32, 0xbda8_1e36, 0xbee2_916d, 0x3f64_860a],
-            ]
-        );
-    }
-    #[test]
     fn half_turn_has_exact_zeros_like_joml() {
         let half_turn = 180.0 * (std::f64::consts::PI / 180.0) as f32;
         assert_eq!(quaternion_xyz(0.0, half_turn, 0.0), [0.0, 1.0, 0.0, 0.0]);

crates/horizon-assets/src/resolve.rs

@@ -102,74 +102,10 @@ impl ModelLibrary {
             missing,
         })
     }
-    /// This library plus `extra` models; an `extra` model replaces a
-    /// same-named one, but not the built-in missing and generated models.
-    /// Every existing model is shared, not copied.
-    pub fn overlaid(&self, extra: BTreeMap<String, CuboidModel>) -> Result<Self> {
-        let mut models = self.models.clone();
-        let mut added = BTreeSet::new();
-        for (name, model) in extra {
-            let name = identifier(&name)?;
-            if !added.insert(name.clone()) {
-                return Err(error("duplicate normalized model identifier"));
-            }
-            // The built-ins win, as `from_models` keeps `missing` and
-            // `with_item_generator` keeps `generated`.
-            if name != MISSING_MODEL && name != GENERATED_MODEL {
-                models.insert(name, Arc::new(model));
-            }
-        }
-        Ok(Self {
-            models,
-            missing: Arc::clone(&self.missing),
-        })
-    }
     /// Follow the complete parent chain. A missing resource uses the built-in
     /// model; a cyclic chain is rejected, as native discovery excludes it.
     /// The returned model can outlive this library without copying its elements.
     pub fn resolve(&self, name: &str) -> Result<ResolvedCuboidModel> {
-        self.resolve_chain(name, None)
-    }
-    /// Whether `name` and every parent it reaches are models of this library,
-    /// with no cycle: `resolve` puts the missing model in for any other.
-    pub fn resolves(&self, name: &str) -> bool {
-        let Ok(mut name) = identifier(name) else {
-            return false;
-        };
-        let mut visited = BTreeSet::new();
-        loop {
-            let Some(model) = self.models.get(&name) else {
-                return false;
-            };
-            if !visited.insert(name.clone()) {
-                return false;
-            }
-            match &model.parent {
-                Some(parent) => name = parent.clone(),
-                None => return true,
-            }
-        }
-    }
-    /// `name`'s resolved model with a virtual child in front of it that has
-    /// only `textures`: the child's slots win, and `#references` anywhere in
-    /// the chain re-bind through them (so `builtin/generated`'s
-    /// `particle: #layer0` follows a replaced `layer0`). The child's slots are
-    /// taken as given: sprites namespaced, references without their `#`, as
-    /// the JSON decoder leaves them. A cyclic chain is an
-    /// error, as for `resolve`: a caller wanting the missing model falls
-    /// back to it.
-    pub fn resolve_with_textures(
-        &self,
-        name: &str,
-        child: &BTreeMap<String, TextureSlot>,
-    ) -> Result<ResolvedCuboidModel> {
-        self.resolve_chain(name, Some(child))
-    }
-    fn resolve_chain(
-        &self,
-        name: &str,
-        child: Option<&BTreeMap<String, TextureSlot>>,
-    ) -> Result<ResolvedCuboidModel> {
         let mut name = identifier(name)?;
         let mut visited = BTreeSet::new();
         let mut chain = Vec::new();
@@ -220,9 +156,6 @@ impl ModelLibrary {
         for model in chain.into_iter().rev() {
             slots.extend(model.textures.iter().map(|(k, v)| (k.clone(), v)));
         }
-        if let Some(child) = child {
-            slots.extend(child.iter().map(|(k, v)| (k.clone(), v)));
-        }
         let mut textures = BTreeMap::<String, Material>::new();
         let mut unresolved_textures = BTreeSet::<String>::new();
         for start in slots.keys() {
@@ -341,195 +274,6 @@ mod tests {
             }
         );
     }
-    fn library(models: &[(&str, &str)]) -> ModelLibrary {
-        ModelLibrary::with_item_generator(
-            models
-                .iter()
-                .map(|(name, json)| (name.to_string(), CuboidModel::from_json(json).unwrap()))
-                .collect(),
-        )
-        .unwrap()
-    }
-    const GENERATED: &str = r#"{"parent":"builtin/generated","display":{"ground":{"translation":[0,2,0],"scale":[0.5,0.5,0.5]}}}"#;
-    const CIT: &str = "horizon_cit:minecraft/optifine/cit/x";
-    #[test]
-    fn child_textures_replace_slots_and_rebind_the_generated_particle() {
-        let library = library(&[
-            ("item/generated", GENERATED),
-            (
-                "item/stick",
-                r#"{"parent":"item/generated","textures":{"layer0":"item/stick"}}"#,
-            ),
-        ]);
-        let child = BTreeMap::from([(
-            "layer0".to_owned(),
-            TextureSlot::Material(Material {
-                sprite: CIT.to_owned(),
-                force_translucent: false,
-            }),
-        )]);
-        let model = library.resolve_with_textures("item/stick", &child).unwrap();
-        assert!(model.uses_item_generator());
-        assert_eq!(model.material("layer0").unwrap().unwrap().sprite, CIT);
-        assert_eq!(model.material("particle").unwrap().unwrap().sprite, CIT);
-        assert_eq!(
-            model.display.contexts[6],
-            DisplayTransform::Explicit(Some(ItemTransform {
-                rotation: [0.0; 3],
-                translation: [0.0, 0.125, 0.0],
-                scale: [0.5; 3],
-            }))
-        );
-        // The library itself is untouched.
-        let plain = library.resolve("item/stick").unwrap();
-        assert_eq!(
-            plain.material("particle").unwrap().unwrap().sprite,
-            "minecraft:item/stick"
-        );
-    }
-    #[test]
-    fn overlaid_models_inherit_from_the_library_and_share_the_rest() {
-        let base = library(&[
-            ("item/generated", GENERATED),
-            (
-                "item/handheld",
-                r#"{"parent":"item/generated","display":{"thirdperson_righthand":{"rotation":[0,-90,55]}}}"#,
-            ),
-            (
-                "item/stick",
-                r#"{"parent":"item/generated","textures":{"layer0":"item/stick"}}"#,
-            ),
-            (
-                "item/apple",
-                r#"{"parent":"item/generated","textures":{"layer0":"item/apple"}}"#,
-            ),
-        ]);
-        let cit = format!(r#"{{"parent":"item/handheld","textures":{{"layer0":"{CIT}"}}}}"#);
-        let over = base
-            .overlaid(BTreeMap::from([
-                (CIT.to_owned(), CuboidModel::from_json(&cit).unwrap()),
-                (
-                    "item/stick".to_owned(),
-                    CuboidModel::from_json(
-                        r#"{"parent":"item/generated","textures":{"layer0":"item/bone"}}"#,
-                    )
-                    .unwrap(),
-                ),
-            ]))
-            .unwrap();
-        let model = over.resolve(CIT).unwrap();
-        assert!(model.uses_item_generator());
-        assert_eq!(model.material("particle").unwrap().unwrap().sprite, CIT);
-        let DisplayTransform::Explicit(Some(right)) = &model.display.contexts[1] else {
-            panic!("handheld's right-hand transform is inherited");
-        };
-        assert_eq!(right.rotation, [0.0, -90.0, 55.0]);
-        let sprite = |l: &ModelLibrary| {
-            l.resolve("item/stick").unwrap().textures["layer0"]
-                .sprite
-                .clone()
-        };
-        assert_eq!(sprite(&over), "minecraft:item/bone");
-        assert_eq!(sprite(&base), "minecraft:item/stick");
-        assert!(!base.resolve(CIT).unwrap().uses_item_generator());
-        assert!(Arc::ptr_eq(
-            &base.models["minecraft:item/apple"],
-            &over.models["minecraft:item/apple"]
-        ));
-    }
-    fn material(sprite: &str) -> TextureSlot {
-        TextureSlot::Material(Material {
-            sprite: sprite.to_owned(),
-            force_translucent: false,
-        })
-    }
-    #[test]
-    fn child_slots_take_part_in_reference_chains() {
-        let library = library(&[
-            (
-                "item/two",
-                r##"{"textures":{"layer0":"#tex","layer1":"item/b","tex":"item/a"}}"##,
-            ),
-            ("horizon:loop", r#"{"parent":"horizon:loop2"}"#),
-            ("horizon:loop2", r#"{"parent":"horizon:loop"}"#),
-        ]);
-        let child = BTreeMap::from([
-            // A base alias binds through a slot only the child sets...
-            ("tex".to_owned(), material(CIT)),
-            // ...and a child alias through the base's slots.
-            (
-                "particle".to_owned(),
-                TextureSlot::Reference("layer1".to_owned()),
-            ),
-            // A child alias to itself resolves to nothing, without looping.
-            ("self".to_owned(), TextureSlot::Reference("self".to_owned())),
-        ]);
-        let model = library.resolve_with_textures("item/two", &child).unwrap();
-        assert_eq!(model.material("layer0").unwrap().unwrap().sprite, CIT);
-        assert_eq!(
-            model.material("particle").unwrap().unwrap().sprite,
-            "minecraft:item/b"
-        );
-        assert_eq!(model.material("self").unwrap(), None);
-        assert!(model.unresolved_textures.contains("self"));
-        // An absent base is the missing cube under the child; a cyclic one an error.
-        let absent = library
-            .resolve_with_textures("item/absent", &child)
-            .unwrap();
-        assert_eq!(absent.elements().len(), 1);
-        assert!(
-            library
-                .resolve_with_textures("horizon:loop", &child)
-                .is_err()
-        );
-    }
-    #[test]
-    fn an_overlay_replaces_parents_but_not_the_built_ins_and_refuses_twins() {
-        let base = library(&[
-            ("item/generated", GENERATED),
-            ("item/handheld", r#"{"parent":"item/generated"}"#),
-            (
-                "item/sword",
-                r#"{"parent":"item/handheld","textures":{"layer0":"item/sword"}}"#,
-            ),
-        ]);
-        let model = |json: &str| CuboidModel::from_json(json).unwrap();
-        let over = base
-            .overlaid(BTreeMap::from([
-                (
-                    "item/handheld".to_owned(),
-                    model(
-                        r#"{"parent":"item/generated","display":{"head":{"rotation":[0,45,0]}}}"#,
-                    ),
-                ),
-                // Neither built-in can be replaced.
-                ("builtin/missing".to_owned(), model(r#"{"elements":[]}"#)),
-                ("builtin/generated".to_owned(), model("{}")),
-            ]))
-            .unwrap();
-        // The base's sword sees the overlay's parent; the base library does not.
-        let head = |l: &ModelLibrary| l.resolve("item/sword").unwrap().display.contexts[4].clone();
-        let DisplayTransform::Explicit(Some(rotated)) = head(&over) else {
-            panic!("the replaced parent's head transform");
-        };
-        assert_eq!(rotated.rotation, [0.0, 45.0, 0.0]);
-        assert_ne!(head(&base), head(&over));
-        // The generator kept: its `particle: #layer0`, which `{}` would drop.
-        let sword = over.resolve("item/sword").unwrap();
-        assert_eq!(
-            sword.material("particle").unwrap().unwrap().sprite,
-            "minecraft:item/sword"
-        );
-        // The missing cube kept, looked up by its own name, not as a fallback.
-        let missing = over.resolve("builtin/missing").unwrap();
-        assert_eq!(missing.elements().len(), 1);
-        // Two spellings of one id.
-        let twins = BTreeMap::from([
-            ("item/x".to_owned(), model("{}")),
-            ("minecraft:item/x".to_owned(), model("{}")),
-        ]);
-        assert!(base.overlaid(twins).is_err());
-    }
     #[test]
     fn absent_parents_fall_back_but_cycles_invalidate_descendants() {
         let a = CuboidModel::from_json(r#"{"parent":"horizon:b"}"#).unwrap();
@@ -549,23 +293,4 @@ mod tests {
             "minecraft:missingno"
         );
     }
-    #[test]
-    fn a_model_resolves_only_with_its_whole_parent_chain() {
-        let library = library(&[
-            ("item/generated", GENERATED),
-            (
-                "item/stick",
-                r#"{"parent":"item/generated","textures":{"layer0":"item/stick"}}"#,
-            ),
-            ("item/orphan", r#"{"parent":"item/gone"}"#),
-            ("item/a", r#"{"parent":"item/b"}"#),
-            ("item/b", r#"{"parent":"item/a"}"#),
-        ]);
-        assert!(library.resolves("item/stick"));
-        assert!(library.resolves("minecraft:item/stick"));
-        assert!(!library.resolves("item/absent"));
-        assert!(!library.resolves("item/orphan"));
-        assert!(!library.resolves("item/a"));
-        assert!(!library.resolves("Item/Stick"));
-    }
 }

crates/horizon-bench/src/hardware.rs

@@ -202,8 +202,10 @@ fn os_version() -> Option<String> {
 #[cfg(target_os = "linux")]
 fn cpu() -> Option<String> {
     let info = std::fs::read_to_string("/proc/cpuinfo").ok()?;
-    // x86 names the CPU per core; arm64 only gives the core's implementer and part.
-    horizon_telemetry::system::linux_cpu_name(&info)
+    // x86 names the CPU per core; ARM boards name the machine once.
+    key_value(&info, "model name", ':')
+        .or_else(|| key_value(&info, "Model", ':'))
+        .map(str::to_owned)
 }
 
 #[cfg(target_os = "linux")]
@@ -225,12 +227,12 @@ fn key_value<'a>(text: &'a str, key: &str, sep: char) -> Option<&'a str> {
 
 #[cfg(target_os = "windows")]
 fn os_version() -> Option<String> {
-    horizon_telemetry::system::windows_version()
+    output("cmd", &["/C", "ver"])
 }
 
 #[cfg(target_os = "windows")]
 fn cpu() -> Option<String> {
-    horizon_telemetry::system::windows_cpu()
+    std::env::var("PROCESSOR_IDENTIFIER").ok()
 }
 
 #[cfg(target_os = "windows")]
@@ -279,16 +281,4 @@ mod tests {
             assert!(cpu_seconds(std::process::id()).unwrap() >= 0.0);
         }
     }
-
-    /// `hardware.cpu` is the brand name, not the family and model `PROCESSOR_IDENTIFIER` holds.
-    #[cfg(windows)]
-    #[test]
-    fn windows_reports_the_cpu_brand() {
-        let cpu = Hardware::detect().cpu.expect("a CPU name");
-        assert!(
-            !cpu.is_empty() && !cpu.contains(" Family ") && !cpu.contains("Stepping"),
-            "family and model, not a name: {cpu:?}"
-        );
-        assert_eq!(cpu, cpu.trim());
-    }
 }

crates/horizon-chat-filter/Cargo.toml

@@ -1,15 +0,0 @@
-[package]
-name = "horizon-chat-filter"
-version = "0.1.0"
-edition.workspace = true
-license.workspace = true
-rust-version = "1.88"
-description = "The dedicated server's chat filter: its [chat_filter] settings, the slur list's matcher and the mutes, with no game state (docs/chat-filter.md)"
-
-[dependencies]
-serde = { version = "1", features = ["derive"] }
-serde_json = "1"
-toml = "1.1"
-
-[lints]
-workspace = true

crates/horizon-chat-filter/data/slurs.txt

@@ -1,63 +0,0 @@
-# Horizon's chat filter: the hate slurs a server refuses in chat, private messages, /say, /me, team
-# messages, signs, anvil names and book titles (docs/chat-filter.md). This is a moderation list: the
-# words are written here only so the filter can recognise them, because players spammed them on the
-# official server (2026-10-31). Add a word when players find a way around the list; keep insults that
-# aren't slurs out of it (moderators handle those).
-#
-# One entry a line, matched after normalising the text: lower case, accents and look-alike letters
-# (Cyrillic, Greek, full-width, small capitals...), leetspeak (1 i, 3 e, 4 a, 0 o, @ a, $ s, 9 g),
-# separators between letters (n.i.g, n_i_g) and repeated letters. A doubled letter in an entry must be
-# doubled in the text: "niger", the river and the country, isn't "nigger".
-#   word    matches inside a longer word too
-#   =word   only as a whole word ("spic", not "suspicious")
-#   ~word   also when it's spread over several words ("nig ger", "n i g g e r")
-#   !word   never a match: a word that contains an entry ("snigger"); !word* any word starting so
-
-~nigger
-~nigga
-nigguh
-niggah
-niqqa
-niqqer
-nlgger
-nlgga
-kneegrow
-=nig
-=nigs
-=niglet
-=niglets
-=nibba
-=nibbas
-=nibber
-=nibbers
-jigaboo
-porchmonkey
-=coon
-=coons
-~faggot
-=fag
-=fags
-=faggy
-=fagot
-=fagots
-=tranny
-=trannies
-=kike
-=kikes
-=chink
-=chinks
-=gook
-=gooks
-=spic
-=spics
-wetback
-=beaner
-=beaners
-raghead
-towelhead
-zipperhead
-=paki
-=pakis
-
-!snigger*
-!niggard*

crates/horizon-chat-filter/src/lib.rs

@@ -1,472 +0,0 @@
-//! The dedicated server's chat filter (docs/chat-filter.md), without the game: `server.toml`'s
-//! `[chat_filter]`, the matcher for the slur list (`data/slurs.txt`, or the owner's `words_file`), and
-//! the escalation (a refused message, then a mute, then a temporary ban), with the mutes kept in a file
-//! so that they outlive a restart. The server's hub (`horizon_client::lan`) asks it before it relays a
-//! player's text and carries out what it decides.
-
-use serde::{Deserialize, Serialize};
-use std::collections::HashMap;
-use std::path::{Path, PathBuf};
-
-mod normalise;
-
-pub use normalise::{Run, Text};
-
-/// The list built into the game, used when `words_file` is empty.
-pub const DEFAULT_WORDS: &str = include_str!("../data/slurs.txt");
-
-/// The mutes, beside server.properties.
-pub const MUTES_FILE: &str = "chat-filter-mutes.json";
-
-/// `server.toml`'s `[chat_filter]`: on by default.
-#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
-#[serde(default, deny_unknown_fields)]
-pub struct Config {
-    pub enabled: bool,
-    /// The hit, counted within `window_minutes`, that mutes the player; 0: never.
-    pub mute_after: u32,
-    /// The hit that bans the player for `tempban_hours`; 0: never.
-    pub tempban_after: u32,
-    /// How long a hit counts towards the next ones (the time spent muted doesn't count).
-    pub window_minutes: u32,
-    pub mute_minutes: u32,
-    pub tempban_hours: u32,
-    /// The slur list, relative to the server's folder; empty: the list built into the game.
-    pub words_file: String,
-    /// Every refused text with the player and what followed, relative to the server's folder.
-    pub log: String,
-}
-
-impl Default for Config {
-    fn default() -> Self {
-        Self {
-            enabled: true,
-            mute_after: 2,
-            tempban_after: 3,
-            window_minutes: 10,
-            mute_minutes: 10,
-            tempban_hours: 24,
-            words_file: String::new(),
-            log: "logs/chat-filter.log".into(),
-        }
-    }
-}
-
-impl Config {
-    /// The `[chat_filter]` section of a whole `server.toml`; the default without it.
-    pub fn from_server_toml(text: &str) -> Result<Self, String> {
-        #[derive(Deserialize)]
-        struct File {
-            #[serde(default)]
-            chat_filter: Config,
-        }
-        // Other sections are the supervisor's to check: only this one is read here.
-        let mut table: toml::Table = toml::from_str(text).map_err(|e| e.to_string())?;
-        let mut only = toml::Table::new();
-        if let Some(section) = table.remove("chat_filter") {
-            only.insert("chat_filter".into(), section);
-        }
-        let file: File = only
-            .try_into()
-            .map_err(|e: toml::de::Error| format!("[chat_filter]: {e}"))?;
-        file.chat_filter.check()?;
-        Ok(file.chat_filter)
-    }
-
-    pub fn check(&self) -> Result<(), String> {
-        if self.window_minutes == 0 {
-            return Err("chat_filter.window_minutes must be 1 or more".into());
-        }
-        Ok(())
-    }
-}
-
-/// How an entry of the list matches.
-#[derive(Clone, Copy, Debug, PartialEq)]
-enum Kind {
-    /// Inside a longer word too.
-    Embedded,
-    /// Only as a whole word.
-    Whole,
-    /// Inside a word, or spread over several words from the start of one.
-    Spread,
-}
-
-#[derive(Debug)]
-struct Entry {
-    runs: Vec<Run>,
-    kind: Kind,
-}
-
-/// The slur list, compiled: each entry's letters as runs, indexed by first letter.
-#[derive(Debug)]
-pub struct Filter {
-    entries: Vec<Entry>,
-    by_first: [Vec<u16>; 27],
-    /// Words never matched: exact (`false`) or as a prefix (`true`).
-    allowed: Vec<(Vec<Run>, bool)>,
-}
-
-impl Filter {
-    /// Compiles a list in `data/slurs.txt`'s format.
-    pub fn new(list: &str) -> Self {
-        let mut f = Filter {
-            entries: Vec::new(),
-            by_first: Default::default(),
-            allowed: Vec::new(),
-        };
-        for line in list.lines() {
-            let line = line.trim();
-            if line.is_empty() || line.starts_with('#') {
-                continue;
-            }
-            if let Some(word) = line.strip_prefix('!') {
-                let (word, prefix) = match word.strip_suffix('*') {
-                    Some(w) => (w, true),
-                    None => (word, false),
-                };
-                f.allowed.push((normalise::word(word), prefix));
-                continue;
-            }
-            let (kind, word) = match line.as_bytes()[0] {
-                b'=' => (Kind::Whole, &line[1..]),
-                b'~' => (Kind::Spread, &line[1..]),
-                _ => (Kind::Embedded, line),
-            };
-            let runs = normalise::word(word);
-            let Some(first) = runs.first() else {
-                continue;
-            };
-            f.by_first[usize::from(first.letter)].push(f.entries.len() as u16);
-            f.entries.push(Entry { runs, kind });
-        }
-        f
-    }
-
-    /// The built-in list.
-    pub fn default_list() -> Self {
-        Self::new(DEFAULT_WORDS)
-    }
-
-    pub fn len(&self) -> usize {
-        self.entries.len()
-    }
-
-    pub fn is_empty(&self) -> bool {
-        self.entries.is_empty()
-    }
-
-    /// Whether `text` holds a slur of the list.
-    pub fn matches(&self, text: &str) -> bool {
-        let t = Text::new(text);
-        let runs = &t.runs;
-        for &(start, end) in t.words.iter().chain(&t.spaced) {
-            let word = &runs[start..end];
-            if self.is_allowed(word) {
-                continue;
-            }
-            for at in 0..word.len() {
-                for &e in &self.by_first[usize::from(word[at].letter)] {
-                    let e = &self.entries[usize::from(e)];
-                    let whole = e.kind == Kind::Whole;
-                    if (!whole || at == 0) && fits(&e.runs, &word[at..], whole) {
-                        return true;
-                    }
-                }
-            }
-        }
-        // Spread entries over the whole text, from the start of a word, across at least two.
-        for (w, &at) in t.joined_at.iter().enumerate() {
-            for &e in &self.by_first[usize::from(t.joined[at].letter)] {
-                let e = &self.entries[usize::from(e)];
-                if e.kind == Kind::Spread
-                    && fits(&e.runs, &t.joined[at..], false)
-                    && t.spans_words(w, e.runs.len())
-                {
-                    return true;
-                }
-            }
-        }
-        false
-    }
-
-    fn is_allowed(&self, word: &[Run]) -> bool {
-        self.allowed.iter().any(|(a, prefix)| {
-            if *prefix {
-                // A prefix: its last run may be part of a longer one.
-                word.len() >= a.len() && fits(a, word, false)
-            } else {
-                fits(a, word, true)
-            }
-        })
-    }
-}
-
-/// Whether `entry`'s runs start `runs` (are all of it with `whole`): the same letters, each at least
-/// as many times as the entry has it.
-fn fits(entry: &[Run], runs: &[Run], whole: bool) -> bool {
-    if runs.len() < entry.len() || (whole && runs.len() != entry.len()) {
-        return false;
-    }
-    entry
-        .iter()
-        .zip(runs)
-        .all(|(e, r)| e.letter == r.letter && r.count >= e.count)
-}
-
-/// What a hit leads to.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub enum Action {
-    /// The text is refused, nothing more.
-    Refused,
-    /// Refused, and the player can't chat until then (epoch milliseconds).
-    Muted { until: i64 },
-    /// Refused, and the player is banned until then.
-    Banned { until: i64 },
-}
-
-impl Action {
-    pub fn name(self) -> &'static str {
-        match self {
-            Action::Refused => "refused",
-            Action::Muted { .. } => "muted",
-            Action::Banned { .. } => "banned",
-        }
-    }
-}
-
-#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
-pub struct Mute {
-    pub uuid: String,
-    pub name: String,
-    /// Epoch milliseconds.
-    pub until: i64,
-}
-
-#[derive(Default, Serialize, Deserialize)]
-struct MutesFile {
-    mutes: Vec<Mute>,
-}
-
-/// One player's hits: how many, and when the last one stops counting.
-#[derive(Clone, Copy, Debug)]
-struct Strikes {
-    count: u32,
-    counts_until: i64,
-}
-
-/// The filter, the players' hits and the mutes.
-pub struct Guard {
-    pub config: Config,
-    pub filter: Filter,
-    strikes: HashMap<u128, Strikes>,
-    mutes: HashMap<u128, Mute>,
-    /// Where the mutes are kept; `None` keeps them in memory only (tests).
-    file: Option<PathBuf>,
-}
-
-const MINUTE: i64 = 60_000;
-
-impl Guard {
-    pub fn new(config: Config, filter: Filter, file: Option<PathBuf>) -> Self {
-        let mut mutes = HashMap::new();
-        if let Some(text) = file.as_ref().and_then(|f| std::fs::read_to_string(f).ok())
-            && let Ok(saved) = serde_json::from_str::<MutesFile>(&text)
-        {
-            for m in saved.mutes {
-                if let Some(uuid) = parse_uuid(&m.uuid) {
-                    mutes.insert(uuid, m);
-                }
-            }
-        }
-        Self {
-            config,
-            filter,
-            strikes: HashMap::new(),
-            mutes,
-            file,
-        }
-    }
-
-    /// The server's guard: `words_file` or the built-in list, the mutes in `dir`. An unreadable
-    /// `words_file` falls back to the built-in list, with why.
-    pub fn load(config: Config, dir: &Path) -> (Self, Option<String>) {
-        let mut problem = None;
-        let filter = if config.words_file.is_empty() {
-            Filter::default_list()
-        } else {
-            match std::fs::read_to_string(dir.join(&config.words_file)) {
-                Ok(text) => Filter::new(&text),
-                Err(e) => {
-                    problem = Some(format!(
-                        "chat_filter.words_file {}: {e}; using the built-in list",
-                        config.words_file
-                    ));
-                    Filter::default_list()
-                }
-            }
-        };
-        (
-            Self::new(config, filter, Some(dir.join(MUTES_FILE))),
-            problem,
-        )
-    }
-
-    /// When the player's mute ends, if they are muted at `now`.
-    pub fn muted_until(&self, uuid: u128, now: i64) -> Option<i64> {
-        self.mutes
-            .get(&uuid)
-            .map(|m| m.until)
-            .filter(|&until| until > now)
-    }
-
-    /// A hit by the player at `now`: the hit's number in the window, and what it leads to.
-    pub fn strike(&mut self, uuid: u128, name: &str, now: i64) -> (u32, Action) {
-        let c = &self.config;
-        let window = i64::from(c.window_minutes) * MINUTE;
-        let s = self.strikes.entry(uuid).or_insert(Strikes {
-            count: 0,
-            counts_until: 0,
-        });
-        if now > s.counts_until {
-            s.count = 0;
-        }
-        s.count += 1;
-        s.counts_until = now + window;
-        let count = s.count;
-        let action = if c.tempban_after > 0 && count >= c.tempban_after {
-            self.strikes.remove(&uuid);
-            Action::Banned {
-                until: now + i64::from(c.tempban_hours) * 60 * MINUTE,
-            }
-        } else if c.mute_after > 0 && count >= c.mute_after {
-            let until = now + i64::from(c.mute_minutes) * MINUTE;
-            // The window starts again when the mute ends.
-            s.counts_until = until + window;
-            self.mutes.insert(
-                uuid,
-                Mute {
-                    uuid: uuid_string(uuid),
-                    name: name.to_owned(),
-                    until,
-                },
-            );
-            self.save();
-            Action::Muted { until }
-        } else {
-            Action::Refused
-        };
-        (count, action)
-    }
-
-    /// Lifts a player's mute (and forgets their hits), by name; the name as muted, if they were.
-    pub fn unmute(&mut self, name: &str) -> Option<String> {
-        let uuid = *self
-            .mutes
-            .iter()
-            .find(|(_, m)| m.name.eq_ignore_ascii_case(name))?
-            .0;
-        let mute = self.mutes.remove(&uuid)?;
-        self.strikes.remove(&uuid);
-        self.save();
-        Some(mute.name)
-    }
-
-    fn save(&mut self) {
-        let Some(file) = &self.file else {
-            return;
-        };
-        let now = now_millis();
-        self.mutes.retain(|_, m| m.until > now);
-        let mut mutes: Vec<Mute> = self.mutes.values().cloned().collect();
-        mutes.sort_by(|a, b| a.name.cmp(&b.name));
-        if let Ok(text) = serde_json::to_string_pretty(&MutesFile { mutes }) {
-            let tmp = file.with_extension("json.tmp");
-            if std::fs::write(&tmp, text).is_ok() {
-                let _ = std::fs::rename(&tmp, file);
-            }
-        }
-    }
-}
-
-/// One line of `logs/chat-filter.log`, without its newline.
-pub fn log_line(
-    now: i64,
-    name: &str,
-    uuid: u128,
-    place: &str,
-    count: u32,
-    action: Action,
-    text: &str,
-) -> String {
-    let text: String = text
-        .chars()
-        .map(|c| if c == '\n' { ' ' } else { c })
-        .collect();
-    format!(
-        "{} {name} {} {place} hit {count} {}: {text}",
-        utc(now),
-        uuid_string(uuid),
-        action.name()
-    )
-}
-
-/// Appends a line to the log at `path` (its folder made if needed).
-pub fn append_log(path: &Path, line: &str) -> std::io::Result<()> {
-    use std::io::Write;
-    if let Some(dir) = path.parent() {
-        std::fs::create_dir_all(dir)?;
-    }
-    let mut f = std::fs::OpenOptions::new()
-        .create(true)
-        .append(true)
-        .open(path)?;
-    writeln!(f, "{line}")
-}
-
-pub fn now_millis() -> i64 {
-    std::time::SystemTime::now()
-        .duration_since(std::time::UNIX_EPOCH)
-        .map_or(0, |d| d.as_millis() as i64)
-}
-
-/// `YYYY-MM-DDTHH:MM:SSZ` for epoch milliseconds.
-pub fn utc(millis: i64) -> String {
-    let secs = millis.div_euclid(1000);
-    let (days, rest) = (secs.div_euclid(86_400), secs.rem_euclid(86_400));
-    // Howard Hinnant's civil_from_days.
-    let z = days + 719_468;
-    let era = z.div_euclid(146_097);
-    let doe = z.rem_euclid(146_097);
-    let yoe = (doe - doe / 1460 + doe / 36_524 - doe / 146_096) / 365;
-    let doy = doe - (365 * yoe + yoe / 4 - yoe / 100);
-    let mp = (5 * doy + 2) / 153;
-    let day = doy - (153 * mp + 2) / 5 + 1;
-    let month = if mp < 10 { mp + 3 } else { mp - 9 };
-    let year = yoe + era * 400 + i64::from(month <= 2);
-    format!(
-        "{year:04}-{month:02}-{day:02}T{:02}:{:02}:{:02}Z",
-        rest / 3600,
-        rest / 60 % 60,
-        rest % 60
-    )
-}
-
-fn uuid_string(u: u128) -> String {
-    let h = format!("{u:032x}");
-    format!(
-        "{}-{}-{}-{}-{}",
-        &h[..8],
-        &h[8..12],
-        &h[12..16],
-        &h[16..20],
-        &h[20..]
-    )
-}
-
-fn parse_uuid(s: &str) -> Option<u128> {
-    u128::from_str_radix(&s.replace('-', ""), 16).ok()
-}
-
-#[cfg(test)]
-mod tests;

crates/horizon-chat-filter/src/normalise.rs

@@ -1,255 +0,0 @@
-//! A text as the filter sees it: words of letters `a`..`z`, each letter with how many times it repeats.
-//! Case, accents, look-alike letters (Cyrillic, Greek, full-width, small capitals, styled mathematical
-//! letters, circled and squared letters), leetspeak and invisible characters are folded away;
-//! separators inside a word are dropped (`n.i.g` is `nig`), and whitespace ends a word.
-
-/// The letter code of anything that is a letter but none of `a`..`z`: it never matches.
-const OTHER: u8 = 26;
-
-/// One letter and how many times it repeats (`gg` is `g` twice).
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub struct Run {
-    /// 0..=25 for `a`..`z`, 26 for any other letter.
-    pub letter: u8,
-    pub count: u8,
-    /// Every one of its characters was punctuation read as a letter (`!` as `i`, `@` as `a`).
-    pub weak: bool,
-}
-
-/// A whole message, normalised.
-#[derive(Debug, Default)]
-pub struct Text {
-    pub runs: Vec<Run>,
-    /// Each word's runs, `runs[start..end]`.
-    pub words: Vec<(usize, usize)>,
-    /// More ranges of `runs` to match as words: letters spaced out (`n i g g a`), joined, and words
-    /// without the punctuation they end with (`fag!`).
-    pub spaced: Vec<(usize, usize)>,
-    /// Every word one after the other, a letter that ends one and starts the next merged.
-    pub joined: Vec<Run>,
-    /// Where each word starts in `joined`.
-    pub joined_at: Vec<usize>,
-    /// The last word each run of `joined` belongs to.
-    joined_last: Vec<usize>,
-}
-
-enum Fold {
-    Letter(u8, bool),
-    Separator,
-    Space,
-    Skip,
-}
-
-impl Text {
-    pub fn new(text: &str) -> Self {
-        let mut t = Text::default();
-        let mut start = 0;
-        for c in text.chars() {
-            match fold(c) {
-                Fold::Letter(letter, weak) => {
-                    let in_word = t.runs.len() > start;
-                    match t.runs.last_mut() {
-                        Some(last) if in_word && last.letter == letter => {
-                            last.count = last.count.saturating_add(1);
-                            last.weak &= weak;
-                        }
-                        _ => t.runs.push(Run {
-                            letter,
-                            count: 1,
-                            weak,
-                        }),
-                    }
-                }
-                Fold::Space => {
-                    t.end_word(start);
-                    start = t.runs.len();
-                }
-                Fold::Separator | Fold::Skip => {}
-            }
-        }
-        t.end_word(start);
-        t.add_spaced();
-        t.join();
-        t
-    }
-
-    fn end_word(&mut self, start: usize) {
-        if self.runs.len() > start {
-            self.words.push((start, self.runs.len()));
-        }
-    }
-
-    /// Spaced-out letters and words without their trailing punctuation, as extra words (their runs
-    /// copied after the real words').
-    fn add_spaced(&mut self) {
-        let words = self.words.len();
-        let mut w = 0;
-        while w < words {
-            let mut end = w;
-            while end < words && self.words[end].1 - self.words[end].0 == 1 {
-                end += 1;
-            }
-            if end - w >= 2 {
-                let first = self.runs.len();
-                for k in w..end {
-                    let run = self.runs[self.words[k].0];
-                    let in_word = self.runs.len() > first;
-                    match self.runs.last_mut() {
-                        Some(last) if in_word && last.letter == run.letter => {
-                            last.count = last.count.saturating_add(run.count);
-                        }
-                        _ => self.runs.push(run),
-                    }
-                }
-                self.spaced.push((first, self.runs.len()));
-                w = end;
-            } else {
-                w += 1;
-            }
-        }
-        for k in 0..words {
-            let (start, mut end) = self.words[k];
-            while end > start + 1 && self.runs[end - 1].weak {
-                end -= 1;
-            }
-            if end < self.words[k].1 {
-                self.spaced.push((start, end));
-            }
-        }
-    }
-
-    fn join(&mut self) {
-        for (w, &(start, end)) in self.words.iter().enumerate() {
-            let mut first = true;
-            for run in &self.runs[start..end] {
-                match self.joined.last_mut() {
-                    Some(last) if first && last.letter == run.letter => {
-                        last.count = last.count.saturating_add(run.count);
-                        self.joined_at.push(self.joined.len() - 1);
-                        *self.joined_last.last_mut().expect("beside joined") = w;
-                    }
-                    _ => {
-                        if first {
-                            self.joined_at.push(self.joined.len());
-                        }
-                        self.joined.push(*run);
-                        self.joined_last.push(w);
-                    }
-                }
-                first = false;
-            }
-        }
-    }
-
-    /// Whether `len` runs of `joined` from word `w`'s start reach into a later word.
-    pub fn spans_words(&self, w: usize, len: usize) -> bool {
-        self.joined_last
-            .get(self.joined_at[w] + len - 1)
-            .is_some_and(|&last| last > w)
-    }
-}
-
-/// An entry of the list, normalised the same way (one word, whitespace ignored).
-pub fn word(text: &str) -> Vec<Run> {
-    let t = Text::new(&text.replace(char::is_whitespace, ""));
-    t.words
-        .first()
-        .map_or_else(Vec::new, |&(s, e)| t.runs[s..e].to_vec())
-}
-
-fn letter(c: char) -> Fold {
-    Fold::Letter(c as u8 - b'a', false)
-}
-
-fn fold(c: char) -> Fold {
-    if c.is_ascii_alphabetic() {
-        return letter(c.to_ascii_lowercase());
-    }
-    if c.is_ascii() {
-        return match c {
-            '0' => letter('o'),
-            '1' => letter('i'),
-            '3' => letter('e'),
-            '4' => letter('a'),
-            '5' => letter('s'),
-            '6' | '9' => letter('g'),
-            '7' => letter('t'),
-            '8' => letter('b'),
-            '!' | '|' => Fold::Letter(b'i' - b'a', true),
-            '@' => Fold::Letter(0, true),
-            '$' => Fold::Letter(b's' - b'a', true),
-            c if c.is_ascii_whitespace() => Fold::Space,
-            _ => Fold::Separator,
-        };
-    }
-    let u = c as u32;
-    let from = |base: u32, span: u32| char::from(b'a' + ((u - base) % span) as u8);
-    let mapped = match u {
-        // Zero-width characters, soft hyphen, combining marks, variation selectors.
-        0xAD | 0x34F | 0x200B..=0x200F | 0x2060..=0x2064 | 0xFEFF | 0x180E => return Fold::Skip,
-        0x300..=0x36F
-        | 0x1AB0..=0x1AFF
-        | 0x1DC0..=0x1DFF
-        | 0x20D0..=0x20FF
-        | 0xFE00..=0xFE0F
-        | 0xFE20..=0xFE2F
-        | 0xE0100..=0xE01EF => return Fold::Skip,
-        // Full-width Latin and digits.
-        0xFF21..=0xFF3A => from(0xFF21, 26),
-        0xFF41..=0xFF5A => from(0xFF41, 26),
-        0xFF10..=0xFF19 => return fold(char::from(b'0' + (u - 0xFF10) as u8)),
-        // Mathematical alphanumerics: 52 letters a style, then digits.
-        0x1D400..=0x1D6A3 => from(0x1D400, 26),
-        0x1D7CE..=0x1D7FF => return fold(char::from(b'0' + ((u - 0x1D7CE) % 10) as u8)),
-        // Circled, parenthesised, squared and negative letters, regional indicators.
-        0x24B6..=0x24CF => from(0x24B6, 26),
-        0x24D0..=0x24E9 => from(0x24D0, 26),
-        0x249C..=0x24B5 => from(0x249C, 26),
-        0x1F130..=0x1F149 => from(0x1F130, 26),
-        0x1F150..=0x1F169 => from(0x1F150, 26),
-        0x1F170..=0x1F189 => from(0x1F170, 26),
-        0x1F1E6..=0x1F1FF => from(0x1F1E6, 26),
-        _ => {
-            if c.is_whitespace() {
-                return Fold::Space;
-            }
-            let lower = c.to_lowercase().next().unwrap_or(c);
-            match LOOK_ALIKES.iter().find(|(_, chars)| chars.contains(lower)) {
-                Some((base, _)) => *base,
-                None if c.is_alphabetic() => return Fold::Letter(OTHER, false),
-                None => return Fold::Separator,
-            }
-        }
-    };
-    letter(mapped)
-}
-
-/// Letters with accents and letters that look like a Latin one, by the letter they read as (lower case).
-const LOOK_ALIKES: &[(char, &str)] = &[
-    ('a', "àáâãäåāăąǎǟǡǻȁȃȧạảấầẩẫậắằẳẵặⱥɐаαᴀᵃª"),
-    ('b', "ƀɓḃḅḇвьъβʙᵇ"),
-    ('c', "çćĉċčƈḉȼсϲᴄᶜ"),
-    ('d', "ďđɗḋḍḏḑḓԁδᴅᵈ"),
-    ('e', "èéêëēĕėęěȅȇȩẹẻẽếềểễệḕḗḙḛḝɇеёєεᴇᵉ€"),
-    ('f', "ƒḟꜰᶠ"),
-    ('g', "ĝğġģǥǧǵɠḡɡɢᵍ"),
-    ('h', "ĥħȟḣḥḧḩḫẖнһʜʰ"),
-    ('i', "ìíîïĩīĭįıǐȉȋḭḯỉịіїιɪⁱ¡ӏ"),
-    ('j', "ĵǰјᴊʲ"),
-    ('k', "ķĸǩḱḳḵкκᴋᵏ"),
-    ('l', "ĺļľŀłḷḹḻḽʟˡ"),
-    ('m', "мᴍᵐ"),
-    ('n', "ñńņňʼnŋǹṅṇṉṋиипηπɴⁿ"),
-    ('o', "òóôõöøōŏőơǒǫǭǿȍȏȫȭȯȱọỏốồổỗộớờởỡợоοσᴏᵒº"),
-    ('p', "ṕṗрρᴘᵖ"),
-    ('q', "ԛ"),
-    ('r', "ŕŗřȑȓṙṛṝṟгʀʳ"),
-    ('s', "śŝşšșṡṣṥṧṩѕꜱˢß"),
-    ('t', "ţťŧțṫṭṯṱẗтτᴛᵗ"),
-    ('u', "ùúûüũūŭůűųưǔǖǘǚǜȕȗụủứừửữựυᴜᵘ"),
-    ('v', "νᴠᵛ"),
-    ('w', "ŵẁẃẅẇẉẘԝωᴡʷ"),
-    ('x', "хχˣ"),
-    ('y', "ýÿŷȳẏẙỳỵỷỹуүγʏʸ"),
-    ('z', "źżžƶẑẓẕᴢᶻ"),
-];

crates/horizon-chat-filter/src/tests.rs

@@ -1,253 +0,0 @@
-// The test texts spell the slurs the filter must refuse: that is what they test.
-use super::*;
-
-fn filter() -> Filter {
-    Filter::default_list()
-}
-
-#[test]
-fn the_list_compiles() {
-    let f = filter();
-    assert!(f.len() > 30, "{} entries", f.len());
-    assert_eq!(f.allowed.len(), 2);
-}
-
-#[test]
-fn normalising_catches_the_usual_disguises() {
-    let f = filter();
-    for text in [
-        "nigger",
-        "NIGGER",
-        "shut up nigga",
-        "Niggers",
-        "n1gg3r",
-        "ni99a",
-        "N!GGA",
-        "nigg@",
-        "n.i.g.g.e.r",
-        "n_i_g_g_a",
-        "n i g g e r",
-        "n i gg a",
-        "nig ger",
-        "nig  gaaa",
-        "niiiiggggggerrrrr",
-        "ñíggér",
-        "ｎｉｇｇｅｒ",
-        "Niggeг",         // Cyrillic ghe for r
-        "nіgger",         // Cyrillic i
-        "nigg\u{0435}r",  // Cyrillic e
-        "n\u{200B}igger", // a zero-width space
-        "n\u{0301}igger", // a combining accent
-        "𝐧𝐢𝐠𝐠𝐞𝐫",
-        "ⓝⓘⓖⓖⓐ",
-        "ɴɪɢɢᴀ",
-        "hi nig",
-        "f a g",
-        "fag!",
-        "you $pic",
-        "FAGGOTINO-CHAN",
-        "sandnigger",
-        "lol kike",
-    ] {
-        assert!(f.matches(text), "{text:?} should be refused");
-    }
-}
-
-#[test]
-fn ordinary_words_pass() {
-    let f = filter();
-    for text in [
-        "hello",
-        "Niger",
-        "I live in Niger",
-        "Nigeria and the Niger river",
-        "nigerian food",
-        "proud2benigerian",
-        "don't snigger",
-        "sniggering at that",
-        "a niggardly offer",
-        "knight",
-        "qKnights",
-        "its still night",
-        "anyone able to boot the latest nightly version?",
-        "i hate nighbours",
-        "can someune give mi night vision",
-        "suspicious stew",
-        "spicy food",
-        "a raccoon in a cocoon",
-        "Scunthorpe",
-        "bigger trigger digger",
-        "gg",
-        "gg ez",
-        "mini gg all",
-        "kniga",
-        "shenanigans",
-        "dignity and signing",
-        "Pakistan",
-        "chinking glasses",
-        "the trannys? no: transmission",
-        "1nicerOli",
-        "ask me evernig",
-        "冰淇淋",
-        "привет",
-        "",
-        "!!!",
-    ] {
-        assert!(!f.matches(text), "{text:?} should pass");
-    }
-}
-
-#[test]
-fn a_custom_list_has_the_same_syntax() {
-    let f = Filter::new("# comment\n=bad\n~worse\nmeh\n!mehish*\n");
-    assert!(f.matches("so bad"));
-    assert!(!f.matches("badly"));
-    assert!(f.matches("wor se"));
-    assert!(f.matches("xxmehxx"));
-    assert!(!f.matches("mehishness"));
-    assert!(!f.matches("me h"));
-}
-
-fn guard(config: Config) -> Guard {
-    Guard::new(config, filter(), None)
-}
-
-const NOW: i64 = 1_793_469_939_000;
-const MIN: i64 = 60_000;
-
-#[test]
-fn the_second_hit_mutes_and_the_third_bans() {
-    let mut g = guard(Config::default());
-    let id = 7;
-    assert_eq!(g.strike(id, "Ann", NOW), (1, Action::Refused));
-    assert_eq!(g.muted_until(id, NOW), None);
-    let until = NOW + 3 * MIN + 10 * MIN;
-    assert_eq!(
-        g.strike(id, "Ann", NOW + 3 * MIN),
-        (2, Action::Muted { until })
-    );
-    assert_eq!(g.muted_until(id, NOW + 4 * MIN), Some(until));
-    assert_eq!(g.muted_until(id, until), None);
-    // The time spent muted doesn't count: 8 minutes after the mute ended is still within the window.
-    assert_eq!(
-        g.strike(id, "Ann", until + 8 * MIN),
-        (
-            3,
-            Action::Banned {
-                until: until + 8 * MIN + 24 * 60 * MIN
-            }
-        )
-    );
-    // Then it starts again.
-    assert_eq!(g.strike(id, "Ann", until + 9 * MIN), (1, Action::Refused));
-}
-
-#[test]
-fn hits_far_apart_dont_add_up() {
-    let mut g = guard(Config::default());
-    assert_eq!(g.strike(1, "Bo", NOW), (1, Action::Refused));
-    assert_eq!(g.strike(1, "Bo", NOW + 11 * MIN), (1, Action::Refused));
-    // Players are counted apart.
-    assert_eq!(g.strike(2, "Cy", NOW + 12 * MIN), (1, Action::Refused));
-}
-
-#[test]
-fn thresholds_are_configurable() {
-    let mut g = guard(Config {
-        mute_after: 0,
-        tempban_after: 2,
-        tempban_hours: 1,
-        ..Config::default()
-    });
-    assert_eq!(g.strike(1, "Bo", NOW), (1, Action::Refused));
-    assert_eq!(
-        g.strike(1, "Bo", NOW + MIN),
-        (
-            2,
-            Action::Banned {
-                until: NOW + MIN + 60 * MIN
-            }
-        )
-    );
-    let mut off = guard(Config {
-        mute_after: 0,
-        tempban_after: 0,
-        ..Config::default()
-    });
-    for k in 1..5 {
-        assert_eq!(off.strike(1, "Bo", NOW + k), (k as u32, Action::Refused));
-    }
-}
-
-#[test]
-fn mutes_survive_a_restart_and_unmute_lifts_them() {
-    let dir = std::env::temp_dir().join(format!("chat-filter-test-{}", std::process::id()));
-    std::fs::create_dir_all(&dir).unwrap();
-    let now = now_millis();
-    let (mut g, problem) = Guard::load(Config::default(), &dir);
-    assert_eq!(problem, None);
-    g.strike(5, "Dee", now);
-    let (_, action) = g.strike(5, "Dee", now);
-    assert!(matches!(action, Action::Muted { .. }));
-    let (mut again, _) = Guard::load(Config::default(), &dir);
-    assert!(again.muted_until(5, now).is_some());
-    assert_eq!(again.unmute("dee").as_deref(), Some("Dee"));
-    assert_eq!(again.unmute("dee"), None);
-    assert_eq!(again.muted_until(5, now), None);
-    let (reloaded, _) = Guard::load(Config::default(), &dir);
-    assert_eq!(reloaded.muted_until(5, now), None);
-    std::fs::remove_dir_all(&dir).unwrap();
-}
-
-#[test]
-fn a_missing_words_file_falls_back_to_the_built_in_list() {
-    let config = Config {
-        words_file: "nope.txt".into(),
-        ..Config::default()
-    };
-    let (g, problem) = Guard::load(config, Path::new("/nonexistent-horizon"));
-    assert!(problem.unwrap().contains("nope.txt"));
-    assert!(g.filter.matches("nigger"));
-}
-
-#[test]
-fn the_section_reads_from_server_toml() {
-    let c = Config::from_server_toml("[server]\nport = 25565\n").unwrap();
-    assert_eq!(c, Config::default());
-    assert!(c.enabled);
-    let c = Config::from_server_toml(
-        "[chat_filter]\nenabled = true\nmute_after = 3\ntempban_after = 5\nwords_file = \"slurs.txt\"\n",
-    )
-    .unwrap();
-    assert_eq!((c.mute_after, c.tempban_after), (3, 5));
-    assert_eq!(c.words_file, "slurs.txt");
-    assert!(
-        !Config::from_server_toml("[chat_filter]\nenabled = false\n")
-            .unwrap()
-            .enabled
-    );
-    assert!(Config::from_server_toml("[chat_filter]\nmute = 2\n").is_err());
-    assert!(Config::from_server_toml("[chat_filter]\nwindow_minutes = 0\n").is_err());
-}
-
-#[test]
-fn log_lines_have_the_time_the_player_and_the_text() {
-    assert_eq!(utc(0), "1970-01-01T00:00:00Z");
-    assert_eq!(utc(951_782_400_000), "2000-02-29T00:00:00Z");
-    assert_eq!(
-        log_line(NOW, "Ann", 1, "chat", 2, Action::Muted { until: 0 }, "a\nb"),
-        "2026-10-31T18:05:39Z Ann 00000000-0000-0000-0000-000000000001 chat hit 2 muted: a b"
-    );
-}
-
-#[test]
-fn a_message_costs_little() {
-    // A long message through the whole list stays far below a tick (debug builds included).
-    let f = filter();
-    let text = "the quick brown fox jumps over the lazy dog ".repeat(6);
-    let start = std::time::Instant::now();
-    for _ in 0..1000 {
-        assert!(!f.matches(&text));
-    }
-    assert!(start.elapsed().as_millis() < 2000, "{:?}", start.elapsed());
-}

crates/horizon-client-core/src/component.rs

@@ -186,73 +186,6 @@ impl Parser<'_> {
         Err("unterminated string".into())
     }
 }
-/// `click_event` / `hover_event`, or the pre-datafixer `clickEvent` /
-/// `hoverEvent` names SNBT and older chat JSON still use.
-fn style_event_object<'a>(
-    o: &'a serde_json::Map<String, Value>,
-    modern: &str,
-    legacy: &str,
-) -> Option<&'a serde_json::Map<String, Value>> {
-    o.get(modern)
-        .or_else(|| o.get(legacy))
-        .and_then(Value::as_object)
-}
-
-/// Style flags from JSON bools, or SNBT `1b`/`0b` which parse as numbers.
-fn style_flag(v: Option<&Value>) -> Option<bool> {
-    match v {
-        Some(Value::Bool(b)) => Some(*b),
-        Some(Value::Number(n)) => n.as_i64().map(|i| i != 0),
-        _ => None,
-    }
-}
-
-fn untrusted_http_url(url: &str) -> bool {
-    // ExtraCodecs.UNTRUSTED_URI / Util.parseAndValidateUntrustedUri: http and
-    // https only, scheme case-insensitive.
-    url.split_once(':').is_some_and(|(scheme, _)| {
-        scheme.eq_ignore_ascii_case("http") || scheme.eq_ignore_ascii_case("https")
-    })
-}
-
-/// ClickEvent.CODEC plus the legacy `value` field TextComponentHoverAndClickEventFix
-/// renames (`url` / `command` / `page`).
-fn parse_click_event(e: &serde_json::Map<String, Value>) -> Option<crate::text::ClickEvent> {
-    let text = |k: &str| e.get(k).and_then(Value::as_str).map(str::to_owned);
-    let legacy = || text("value");
-    match e.get("action").and_then(Value::as_str) {
-        Some("open_url") => text("url")
-            .or_else(legacy)
-            .filter(|u| untrusted_http_url(u))
-            .map(crate::text::ClickEvent::OpenUrl),
-        Some("change_page") => e
-            .get("page")
-            .and_then(Value::as_i64)
-            .or_else(|| e.get("value").and_then(Value::as_i64))
-            .or_else(|| {
-                e.get("value")
-                    .and_then(Value::as_str)
-                    .and_then(|s| s.parse().ok())
-            })
-            .and_then(|p| i32::try_from(p).ok())
-            .filter(|p| *p >= 1)
-            .map(crate::text::ClickEvent::ChangePage),
-        Some("suggest_command") => text("command")
-            .or_else(legacy)
-            .map(crate::text::ClickEvent::SuggestCommand),
-        Some("run_command") => text("command")
-            .or_else(legacy)
-            .map(crate::text::ClickEvent::RunCommand),
-        Some("copy_to_clipboard") => text("value").map(crate::text::ClickEvent::CopyToClipboard),
-        // ClickEvent.ShowDialog.CODEC: a `minecraft:dialog` registry id or
-        // the dialog itself; the server may send it (isAllowedFromServer).
-        Some("show_dialog") => e.get("dialog").map(|dialog| {
-            crate::text::ClickEvent::ShowDialog(crate::scoreboard::json_to_tag(dialog))
-        }),
-        _ => None,
-    }
-}
-
 /// The style fields of a component object.
 fn object_style(o: &serde_json::Map<String, Value>) -> Style {
     let mut style = Style::default();
@@ -263,36 +196,58 @@ fn object_style(o: &serde_json::Map<String, Value>) -> Style {
         });
     }
     style.shadow_color = o.get("shadow_color").and_then(shadow_color);
-    style.bold = style_flag(o.get("bold"));
-    style.italic = style_flag(o.get("italic"));
-    style.underlined = style_flag(o.get("underlined"));
-    style.strikethrough = style_flag(o.get("strikethrough"));
-    style.obfuscated = style_flag(o.get("obfuscated"));
+    let flag = |k: &str| o.get(k).and_then(Value::as_bool);
+    style.bold = flag("bold");
+    style.italic = flag("italic");
+    style.underlined = flag("underlined");
+    style.strikethrough = flag("strikethrough");
+    style.obfuscated = flag("obfuscated");
     style.font = o.get("font").and_then(crate::text::font_id);
     // ClickEvent.CODEC: the actions a chat line acts on here. A component
     // from a server never opens a file.
-    if let Some(e) = style_event_object(o, "click_event", "clickEvent") {
-        style.click = parse_click_event(e);
+    if let Some(e) = o.get("click_event").and_then(Value::as_object) {
+        let text = |k: &str| e.get(k).and_then(Value::as_str).map(str::to_owned);
+        style.click = match e.get("action").and_then(Value::as_str) {
+            // ClickEvent.OpenUrl.CODEC: ExtraCodecs.UNTRUSTED_URI allows http and
+            // https only, the scheme in any case (Util.parseAndValidateUntrustedUri).
+            Some("open_url") => text("url")
+                .filter(|u| {
+                    u.split_once(':').is_some_and(|(scheme, _)| {
+                        scheme.eq_ignore_ascii_case("http") || scheme.eq_ignore_ascii_case("https")
+                    })
+                })
+                .map(crate::text::ClickEvent::OpenUrl),
+            // ClickEvent.ChangePage.CODEC: ExtraCodecs.POSITIVE_INT.
+            Some("change_page") => e
+                .get("page")
+                .and_then(Value::as_i64)
+                .and_then(|p| i32::try_from(p).ok())
+                .filter(|p| *p >= 1)
+                .map(crate::text::ClickEvent::ChangePage),
+            Some("suggest_command") => text("command").map(crate::text::ClickEvent::SuggestCommand),
+            Some("run_command") => text("command").map(crate::text::ClickEvent::RunCommand),
+            Some("copy_to_clipboard") => {
+                text("value").map(crate::text::ClickEvent::CopyToClipboard)
+            }
+            // ClickEvent.ShowDialog.CODEC: a `minecraft:dialog` registry id or
+            // the dialog itself; the server may send it (isAllowedFromServer).
+            Some("show_dialog") => e.get("dialog").map(|dialog| {
+                crate::text::ClickEvent::ShowDialog(crate::scoreboard::json_to_tag(dialog))
+            }),
+            _ => None,
+        };
     }
-    // HoverEvent.ShowText, ShowItem and ShowEntity.
-    if let Some(e) = style_event_object(o, "hover_event", "hoverEvent") {
+    // HoverEvent.ShowText and ShowItem.
+    if let Some(e) = o.get("hover_event").and_then(Value::as_object) {
         match e.get("action").and_then(Value::as_str) {
             Some("show_text") => {
-                // Modern `value`, or the older `contents` / nested `text`.
-                let value = e
-                    .get("value")
-                    .or_else(|| e.get("contents"))
-                    .or_else(|| e.get("text"));
-                if let Some(value) = value {
+                if let Some(value) = e.get("value") {
                     style.hover = Some(Box::new(to_text(value, &mut |s| Text::literal(s))));
                 }
             }
             Some("show_item") if e.get("id").is_some_and(Value::is_string) => {
                 style.hover_item = Some(Box::new(Value::Object(e.clone())));
             }
-            Some("show_entity") if e.get("id").is_some_and(Value::is_string) => {
-                style.hover_entity = Some(Box::new(Value::Object(e.clone())));
-            }
             _ => {}
         }
     }
@@ -548,43 +503,10 @@ mod tests {
         let t = to_text(&v, &mut |_| Text::empty());
         assert_eq!(t.plain(), "Hi there");
         assert_eq!(t.spans[1].style.color, named_color("red"));
-        // SNBT `1b` is a number in JSON; style flags still take it as true.
-        assert_eq!(t.spans[1].style.bold, Some(true));
         let (v, _) = parse_snbt("[\"a\",{\"text\":\"b\"}]").unwrap();
         assert_eq!(to_text(&v, &mut |_| Text::empty()).plain(), "ab");
     }
 
-    #[test]
-    fn legacy_click_event_open_url_uses_value_field() {
-        use crate::text::ClickEvent;
-        let modern = serde_json::json!({
-            "text": "site",
-            "click_event": {"action": "open_url", "url": "https://example.com"},
-            "underlined": true
-        });
-        let legacy = serde_json::json!({
-            "text": "site",
-            "clickEvent": {"action": "open_url", "value": "https://example.com"},
-            "underlined": 1
-        });
-        for component in [modern, legacy] {
-            let text = to_text(&component, &mut |_| Text::empty());
-            assert_eq!(
-                text.spans[0].style.click,
-                Some(ClickEvent::OpenUrl("https://example.com".into()))
-            );
-            assert_eq!(text.spans[0].style.underlined, Some(true));
-        }
-        let snbt = r#"{text:"site",underlined:1b,clickEvent:{action:open_url,value:"https://example.com"}}"#;
-        let (v, _) = parse_snbt(snbt).unwrap();
-        let text = to_text(&v, &mut |_| Text::empty());
-        assert_eq!(
-            text.spans[0].style.click,
-            Some(ClickEvent::OpenUrl("https://example.com".into()))
-        );
-        assert_eq!(text.spans[0].style.underlined, Some(true));
-    }
-
     #[test]
     fn the_font_is_inherited_and_kept() {
         let (v, _) =

crates/horizon-client-core/src/key_display.rs

@@ -1,68 +1,32 @@
 //! Key display names (`InputConstants.Key.getDisplayName`), shared by key
 //! mappings and `keybind` text components.
 use crate::text::Text;
-use std::{collections::BTreeMap, sync::RwLock};
 
-/// The keys that write a symbol, with what they write on a US layout.
-const SYMBOLS: [(&str, &str); 11] = [
-    ("key.keyboard.minus", "-"),
-    ("key.keyboard.equal", "="),
-    ("key.keyboard.left.bracket", "["),
-    ("key.keyboard.right.bracket", "]"),
-    ("key.keyboard.backslash", "\\"),
-    ("key.keyboard.semicolon", ";"),
-    ("key.keyboard.apostrophe", "'"),
-    ("key.keyboard.grave.accent", "`"),
-    ("key.keyboard.comma", ","),
-    ("key.keyboard.period", "."),
-    ("key.keyboard.slash", "/"),
-];
-
-/// What the player's keyboard layout writes on each key that writes
-/// something, by key name, as the window reported it (`learn_layout`).
-static LAYOUT: RwLock<BTreeMap<String, String>> = RwLock::new(BTreeMap::new());
-
-/// The keyboard layout writes `text` on the key `key` (`key.keyboard.q`):
-/// its name from now on, as `SDL_GetKeyFromScancode` names it with SDL's
-/// default keycode options. Only letter and symbol keys take it; a letter
-/// key keeps its Latin letter on a non-Latin layout (`latin_letters`), and
-/// the number row keeps its digits (`french_numbers`).
-pub fn learn_layout(key: &str, text: &str) {
-    let Some(rest) = key.strip_prefix("key.keyboard.") else {
-        return;
-    };
-    let mut chars = text.chars();
-    let (Some(c), None) = (chars.next(), chars.next()) else {
-        return;
-    };
-    let letter_key = rest.len() == 1 && rest.as_bytes()[0].is_ascii_lowercase();
-    let latin = c.is_ascii() || ('\u{C0}'..='\u{24F}').contains(&c);
-    if c.is_control()
-        || c.is_whitespace()
-        || !(letter_key || SYMBOLS.iter().any(|(k, _)| *k == key))
-        || (letter_key && c.is_alphabetic() && !latin)
-    {
-        return;
-    }
-    if let Ok(mut layout) = LAYOUT.write() {
-        layout.insert(key.to_owned(), c.to_uppercase().collect());
-    }
-}
-
-/// InputConstants.Key.getDisplayName: what the layout writes on the key,
-/// upper-case, else the US layout's character, else by translation.
+/// InputConstants.Key.getDisplayName: one-character keys as the upper-case
+/// character, others by translation.
 pub fn display_name(key: &str) -> Text {
-    if let Some(label) = LAYOUT.read().ok().and_then(|l| l.get(key).cloned()) {
-        return Text::literal(label);
-    }
     if let Some(rest) = key.strip_prefix("key.keyboard.")
         && rest.chars().count() == 1
     {
         let c = rest.to_uppercase();
         return Text::literal(c);
     }
-    if let Some((_, s)) = SYMBOLS.iter().find(|(k, _)| *k == key) {
-        return Text::literal(*s);
+    let symbol = match key {
+        "key.keyboard.minus" => Some("-"),
+        "key.keyboard.equal" => Some("="),
+        "key.keyboard.left.bracket" => Some("["),
+        "key.keyboard.right.bracket" => Some("]"),
+        "key.keyboard.backslash" => Some("\\"),
+        "key.keyboard.semicolon" => Some(";"),
+        "key.keyboard.apostrophe" => Some("'"),
+        "key.keyboard.grave.accent" => Some("`"),
+        "key.keyboard.comma" => Some(","),
+        "key.keyboard.period" => Some("."),
+        "key.keyboard.slash" => Some("/"),
+        _ => None,
+    };
+    if let Some(s) = symbol {
+        return Text::literal(s);
     }
     if let Some(n) = key.strip_prefix("key.mouse.")
         && n.parse::<u32>().is_ok()
@@ -72,36 +36,3 @@ pub fn display_name(key: &str) -> Text {
     }
     Text::translate(key, &[])
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn keys_show_what_the_layout_writes() {
-        // The layout table is shared: these keys are this test's alone.
-        assert_eq!(display_name("key.keyboard.q").plain(), "Q");
-        // AZERTY: A on the Q key, M on the semicolon key, a dead ^ on the
-        // left bracket, a comma on the M key.
-        learn_layout("key.keyboard.q", "a");
-        learn_layout("key.keyboard.semicolon", "m");
-        learn_layout("key.keyboard.left.bracket", "^");
-        learn_layout("key.keyboard.m", ",");
-        assert_eq!(display_name("key.keyboard.q").plain(), "A");
-        assert_eq!(display_name("key.keyboard.semicolon").plain(), "M");
-        assert_eq!(display_name("key.keyboard.left.bracket").plain(), "^");
-        assert_eq!(display_name("key.keyboard.m").plain(), ",");
-        // The number row keeps its digits; a Cyrillic letter, nothing
-        // printable and keys that write nothing are left alone.
-        learn_layout("key.keyboard.1", "&");
-        learn_layout("key.keyboard.f", "а");
-        learn_layout("key.keyboard.g", "\u{8}");
-        learn_layout("key.keyboard.tab", "\t");
-        learn_layout("key.keyboard.h", "ab");
-        assert_eq!(display_name("key.keyboard.1").plain(), "1");
-        assert_eq!(display_name("key.keyboard.f").plain(), "F");
-        assert_eq!(display_name("key.keyboard.g").plain(), "G");
-        assert_eq!(display_name("key.keyboard.h").plain(), "H");
-        assert_eq!(display_name("key.keyboard.slash").plain(), "/");
-    }
-}

crates/horizon-client-core/src/lang.rs

@@ -3,7 +3,6 @@
 //! from `pack.mcmeta` `language` sections, and a process-wide current
 //! language used by every screen.
 use std::{
-    cell::RefCell,
     collections::{BTreeMap, HashMap},
     sync::{
         Arc, RwLock,
@@ -35,15 +34,6 @@ pub struct Language {
 pub const DEFAULT: &str = "en_us";
 
 static CURRENT: RwLock<Option<Arc<Language>>> = RwLock::new(None);
-/// A language that only the calling thread sees, and the keys it was asked for and did not have
-/// (`scoped`).
-struct Scope {
-    language: Arc<Language>,
-    missed: Vec<String>,
-}
-thread_local! {
-    static SCOPE: RefCell<Option<Scope>> = const { RefCell::new(None) };
-}
 /// The current language's `bidirectional`, read for every drawn string.
 static BIDIRECTIONAL: AtomicBool = AtomicBool::new(false);
 
@@ -67,9 +57,6 @@ impl ResourceSource for Bundled {
             "assets/horizon/lang/en_us.json" => {
                 include_str!("../../horizon-client/assets/horizon/lang/en_us.json")
             }
-            "assets/horizon/lang/zh_cn.json" => {
-                include_str!("../../horizon-client/assets/horizon/lang/zh_cn.json")
-            }
             "assets/horizon/lang/ru_ru.json" => {
                 include_str!("../../horizon-client/assets/horizon/lang/ru_ru.json")
             }
@@ -79,31 +66,6 @@ impl ResourceSource for Bundled {
             "assets/horizon/lang/uk_ua.json" => {
                 include_str!("../../horizon-client/assets/horizon/lang/uk_ua.json")
             }
-            "assets/horizon/lang/tr_tr.json" => {
-                include_str!("../../horizon-client/assets/horizon/lang/tr_tr.json")
-            }
-            "assets/horizon/lang/de_de.json" | "assets/horizon/lang/de_at.json" => {
-                include_str!("../../horizon-client/assets/horizon/lang/de_de.json")
-            }
-            // Swiss German writes "ss" for "ß", as vanilla's de_ch does.
-            "assets/horizon/lang/de_ch.json" => {
-                let de = include_str!("../../horizon-client/assets/horizon/lang/de_de.json");
-                return Some(de.replace('ß', "ss").into_bytes());
-            }
-            "assets/horizon/lang/fr_fr.json"
-            | "assets/horizon/lang/fr_ca.json"
-            | "assets/horizon/lang/fr_ch.json" => {
-                include_str!("../../horizon-client/assets/horizon/lang/fr_fr.json")
-            }
-            "assets/horizon/lang/es_es.json"
-            | "assets/horizon/lang/es_ar.json"
-            | "assets/horizon/lang/es_cl.json"
-            | "assets/horizon/lang/es_ec.json"
-            | "assets/horizon/lang/es_mx.json"
-            | "assets/horizon/lang/es_uy.json"
-            | "assets/horizon/lang/es_ve.json" => {
-                include_str!("../../horizon-client/assets/horizon/lang/es_es.json")
-            }
             _ => return None,
         };
         Some(body.as_bytes().to_vec())
@@ -264,50 +226,8 @@ pub fn set(language: Language) {
     *CURRENT.write().unwrap_or_else(|e| e.into_inner()) = Some(Arc::new(language));
 }
 pub fn current() -> Option<Arc<Language>> {
-    if let Some(language) = SCOPE.with(|s| s.borrow().as_ref().map(|s| s.language.clone())) {
-        return Some(language);
-    }
     CURRENT.read().unwrap_or_else(|e| e.into_inner()).clone()
 }
-/// Runs `f` with `language` as the current language of this thread only, and returns what it
-/// returned with the keys `get` and `get_or` looked up and `language` did not have, in the order
-/// asked and without repeats. Nothing is set process-wide, so a test can draw a screen in another
-/// language while the tests beside it read theirs. Scopes nest: the inner one wins, and the outer
-/// one's misses do not include the inner one's. For tests: `bidirectional` stays the process-wide
-/// language's.
-pub fn scoped<R>(language: Language, f: impl FnOnce() -> R) -> (R, Vec<String>) {
-    /// Puts the outer scope back, also when `f` panics.
-    struct Restore(Option<Scope>);
-    impl Drop for Restore {
-        fn drop(&mut self) {
-            SCOPE.with(|s| *s.borrow_mut() = self.0.take());
-        }
-    }
-    let outer = SCOPE.with(|s| {
-        s.borrow_mut().replace(Scope {
-            language: Arc::new(language),
-            missed: Vec::new(),
-        })
-    });
-    let _restore = Restore(outer);
-    let result = f();
-    let missed = SCOPE.with(|s| {
-        s.borrow_mut()
-            .as_mut()
-            .map(|s| std::mem::take(&mut s.missed))
-    });
-    (result, missed.unwrap_or_default())
-}
-/// `key` was asked for in a `scoped` language that has no text for it.
-fn missed(key: &str) {
-    SCOPE.with(|s| {
-        if let Some(scope) = s.borrow_mut().as_mut()
-            && !scope.missed.iter().any(|m| m == key)
-        {
-            scope.missed.push(key.to_owned());
-        }
-    });
-}
 /// `ClientLanguage.defaultRightToLeft` of the current language.
 pub fn bidirectional() -> bool {
     BIDIRECTIONAL.load(Ordering::Relaxed)
@@ -319,19 +239,13 @@ pub fn code() -> String {
 pub fn get(key: &str) -> String {
     current()
         .and_then(|l| l.get(key).map(str::to_owned))
-        .unwrap_or_else(|| {
-            missed(key);
-            key.to_owned()
-        })
+        .unwrap_or_else(|| key.to_owned())
 }
 /// The translation, or `fallback` when the key is missing.
 pub fn get_or(key: &str, fallback: &str) -> String {
     current()
         .and_then(|l| l.get(key).map(str::to_owned))
-        .unwrap_or_else(|| {
-            missed(key);
-            fallback.to_owned()
-        })
+        .unwrap_or_else(|| fallback.to_owned())
 }
 pub fn has(key: &str) -> bool {
     current().is_some_and(|l| l.get(key).is_some())
@@ -365,16 +279,6 @@ mod tests {
         }
         assert_eq!(en.get("horizon.pages.mods"), Some("Mods"));
         assert_eq!(ru.get("horizon.pages.mods"), Some("Моды"));
-        let zh = Language::load(&[&empty], "zh_cn");
-        assert_eq!(zh.get("horizon.options.controller"), Some("手柄"));
-        assert_eq!(zh.get("horizon.pages.mods"), Some("模组"));
-        assert_eq!(zh.get("Preset"), Some("预设"));
-        assert_eq!(zh.get("%s chunks"), Some("%s 个区块"));
-        // Not every bundle is complete: the en_us layer is in every map, so a
-        // missing key falls back to English (`horizon.mods.not_built` is not
-        // in ru_ru either).
-        assert_eq!(zh.get("LOD Distance"), Some("LOD 距离"));
-        assert_eq!(ru.get("horizon.mods.not_built"), Some(" (Not built)"));
         let pl = Language::load(&[&empty], "pl_pl");
         assert_eq!(pl.get("horizon.options.controller"), Some("Kontroler"));
         assert_eq!(pl.get("horizon.options.vibration"), Some("Wibracje"));
@@ -383,217 +287,6 @@ mod tests {
             uk.get("horizon.options.on_screen_keyboard"),
             Some("Екранна клавіатура")
         );
-        let tr = Language::load(&[&empty], "tr_tr");
-        assert_eq!(tr.get("horizon.options.controller"), Some("Kontrolcü"));
-        let es = Language::load(&[&empty], "es_es");
-        assert_eq!(es.get("horizon.options.controller"), Some("Mando"));
-        // German and French, and their regional variants on the same file
-        // (Swiss German without "ß").
-        let de = Language::load(&[&empty], "de_de");
-        assert_eq!(de.get("horizon.osk.close"), Some("Schließen"));
-        let fr = Language::load(&[&empty], "fr_fr");
-        assert_eq!(fr.get("horizon.osk.close"), Some("Fermer"));
-        for (code, base) in [("de_at", &de), ("fr_ca", &fr), ("fr_ch", &fr)] {
-            let variant = Language::load(&[&empty], code);
-            assert_eq!(variant.map(), base.map(), "{code}");
-        }
-        let de_ch = Language::load(&[&empty], "de_ch");
-        assert_eq!(de_ch.get("horizon.osk.close"), Some("Schliessen"));
-        assert!(de_ch.map().values().all(|v| !v.contains('ß')));
-        assert_eq!(de_ch.len(), de.len());
-        let es_ve = Language::load(&[&empty], "es_ve");
-        assert_eq!(
-            es_ve.get("horizon.options.on_screen_keyboard"),
-            Some("Teclado en pantalla")
-        );
-    }
-
-    #[test]
-    fn a_scoped_language_is_the_calling_threads_and_reports_what_it_lacks() {
-        let empty = Mem(HashMap::new());
-        let outside = code();
-        let ((german, english_only, fallback, elsewhere), missed) =
-            scoped(Language::load(&[&empty], "de_de"), || {
-                (
-                    get("horizon.osk.close"),
-                    get("horizon.no_such_key"),
-                    get_or("horizon.no_fallback", "English"),
-                    // Another thread keeps the process-wide language.
-                    std::thread::spawn(code).join().unwrap(),
-                )
-            });
-        assert_eq!(german, "Schließen");
-        assert_eq!(english_only, "horizon.no_such_key");
-        assert_eq!(fallback, "English");
-        assert_eq!(elsewhere, outside);
-        assert_eq!(missed, ["horizon.no_such_key", "horizon.no_fallback"]);
-        // The scope ends with its closure.
-        assert_eq!(code(), outside);
-    }
-
-    #[test]
-    fn scopes_nest_and_end_when_their_closure_panics() {
-        let empty = Mem(HashMap::new());
-        let outside = code();
-        let (inner, missed) = scoped(Language::load(&[&empty], "fr_fr"), || {
-            let (inner, inner_missed) = scoped(Language::load(&[&empty], "pl_pl"), || {
-                (code(), get("horizon.inner_miss"))
-            });
-            assert_eq!(inner_missed, ["horizon.inner_miss"]);
-            assert_eq!(code(), "fr_fr");
-            inner.0
-        });
-        assert_eq!(inner, "pl_pl");
-        assert!(missed.is_empty());
-        let panicked = std::panic::catch_unwind(|| {
-            scoped(Language::load(&[&Mem(HashMap::new())], "de_de"), || {
-                panic!("a test failed inside a scope")
-            })
-        });
-        assert!(panicked.is_err());
-        assert_eq!(code(), outside);
-    }
-
-    /// `crates/horizon-client/assets/horizon/lang`, where Horizon's own strings live.
-    fn bundled_dir() -> std::path::PathBuf {
-        std::path::Path::new(env!("CARGO_MANIFEST_DIR"))
-            .join("../horizon-client/assets/horizon/lang")
-    }
-    /// The keys of a flat bundled file in file order, duplicates included (a map
-    /// would keep only the last of two equal keys). One `"key": "value"` per line.
-    fn file_keys(body: &str) -> Vec<String> {
-        body.lines()
-            .filter(|line| line.starts_with("  \""))
-            .map(|line| {
-                serde_json::Deserializer::from_str(line.trim_start())
-                    .into_iter::<String>()
-                    .next()
-                    .and_then(Result::ok)
-                    .unwrap_or_else(|| panic!("no key on line {line}"))
-            })
-            .collect()
-    }
-    /// The fields the code fills in (`%s`, `%d`, `%1$s`, `%.2f`, `%%`), sorted. A
-    /// percent sign that starts none of them ("100% is") is plain text.
-    fn placeholders(text: &str) -> Vec<String> {
-        let mut found = Vec::new();
-        let mut rest = text;
-        while let Some(at) = rest.find('%') {
-            rest = &rest[at + 1..];
-            let spec = rest
-                .find(|c: char| !(c.is_ascii_digit() || c == '$' || c == '.'))
-                .unwrap_or(rest.len());
-            let after = rest[spec..].chars().next();
-            if after.is_some_and(|c| matches!(c, 's' | 'd' | 'f' | '%')) {
-                let end = spec + 1;
-                found.push(format!("%{}", &rest[..end]));
-                rest = &rest[end..];
-            }
-        }
-        found.sort();
-        found
-    }
-
-    #[test]
-    fn bundled_files_are_served_and_have_no_stale_or_repeated_keys() {
-        let dir = bundled_dir();
-        let en_body = std::fs::read_to_string(dir.join("en_us.json")).unwrap();
-        let en: HashMap<String, String> = serde_json::from_str(&en_body).unwrap();
-        let mut seen = 0;
-        for entry in std::fs::read_dir(&dir).unwrap().flatten() {
-            let name = entry.file_name().into_string().unwrap();
-            let Some(code) = name.strip_suffix(".json") else {
-                continue;
-            };
-            seen += 1;
-            // A file that Bundled::read does not name is never loaded.
-            let path = format!("assets/horizon/lang/{name}");
-            assert!(
-                Bundled.read(&path).is_some(),
-                "{name} is not served by Bundled"
-            );
-            let body = std::fs::read_to_string(entry.path()).unwrap();
-            let map: HashMap<String, String> = serde_json::from_str(&body)
-                .unwrap_or_else(|e| panic!("{name} is not a flat string map: {e}"));
-            let keys = file_keys(&body);
-            assert_eq!(
-                keys.len(),
-                map.len(),
-                "{name} repeats a key or has a multi-line entry"
-            );
-            for (key, value) in &map {
-                // Stale: the code no longer asks for it, or it was renamed in en_us only.
-                let english = en
-                    .get(key)
-                    .unwrap_or_else(|| panic!("{code}: {key} is not in en_us.json"));
-                // A translation keeps the fields the code fills in.
-                assert_eq!(
-                    placeholders(value),
-                    placeholders(english),
-                    "{code}: {key} changes the placeholders of the English text"
-                );
-                assert!(!value.trim().is_empty(), "{code}: {key} is empty");
-            }
-        }
-        assert!(
-            seen >= 7,
-            "found {seen} bundled lang files in {}",
-            dir.display()
-        );
-    }
-
-    #[test]
-    fn every_horizon_key_the_code_names_is_in_en_us() {
-        fn rust_files(dir: &std::path::Path, out: &mut Vec<std::path::PathBuf>) {
-            for entry in std::fs::read_dir(dir).into_iter().flatten().flatten() {
-                let path = entry.path();
-                if path.is_dir() {
-                    rust_files(&path, out);
-                } else if path.extension().is_some_and(|e| e == "rs") {
-                    out.push(path);
-                }
-            }
-        }
-        let en: HashMap<String, String> = serde_json::from_str(
-            &std::fs::read_to_string(bundled_dir().join("en_us.json")).unwrap(),
-        )
-        .unwrap();
-        let crates = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("..");
-        let mut files = Vec::new();
-        for krate in [
-            "horizon-client",
-            "horizon-client-render",
-            "horizon-client-core",
-        ] {
-            rust_files(&crates.join(krate).join("src"), &mut files);
-        }
-        assert!(files.len() > 100, "found only {} sources", files.len());
-        let mut found = 0;
-        for file in files {
-            let text = std::fs::read_to_string(&file).unwrap();
-            for (at, _) in text.match_indices("\"horizon.") {
-                let rest = &text[at + 1..];
-                let Some(end) = rest.find('"') else { continue };
-                let key = &rest[..end];
-                // A key is `horizon.<group>.<name>`: lower-case letters, digits and `_`
-                // between the dots. A key built at run time has a brace; a file name
-                // has one dot; the server addresses that look like keys are listed.
-                const NOT_KEYS: &[&str] = &["horizon.bunchy7s.dev"];
-                let key_like = key
-                    .bytes()
-                    .all(|b| b.is_ascii_lowercase() || b.is_ascii_digit() || b"_.".contains(&b));
-                if key.matches('.').count() < 2 || !key_like || NOT_KEYS.contains(&key) {
-                    continue;
-                }
-                found += 1;
-                assert!(
-                    en.contains_key(key),
-                    "{} names {key}, which is not in en_us.json",
-                    file.display()
-                );
-            }
-        }
-        assert!(found > 50, "found only {found} key names");
     }
 
     #[test]

crates/horizon-client-core/src/potions.rs

@@ -9,8 +9,7 @@ pub enum Category {
     Harmful,
     Neutral,
 }
-/// A `MobEffect`: id (vanilla's without namespace, a mod's `<ns>:<path>`),
-/// colour, category, instantaneous.
+/// A `MobEffect`: id (without namespace), colour, category, instantaneous.
 #[derive(Clone, Copy, Debug)]
 pub struct EffectDef {
     pub id: &'static str,
@@ -85,80 +84,11 @@ pub const EFFECTS: &[EffectDef] = &[
     fx("infested", 9214860, H),
     fx("breath_of_the_nautilus", 65518, B),
 ];
-/// The effects content mods declare, registered after vanilla's.
-static MOD_EFFECTS: OnceLock<Vec<EffectDef>> = OnceLock::new();
-/// Registers the content mods' effects, `<ns>:<path>` ids in registry order.
-/// The list is set once per process: false when it already was, and the
-/// effects stay those of the first call until the game restarts.
-pub fn register_mod_effects(effects: impl IntoIterator<Item = (String, u32, Category)>) -> bool {
-    if MOD_EFFECTS.get().is_some() {
-        return false;
-    }
-    let defs: Vec<EffectDef> = effects
-        .into_iter()
-        .map(|(id, color, category)| {
-            debug_assert!(id.contains(':'), "{id} has no namespace");
-            fx(Box::leak(id.into_boxed_str()), color, category)
-        })
-        .collect();
-    MOD_EFFECTS.set(defs).is_ok()
-}
-/// The content mods' effects, in registry order.
-pub fn mod_effects() -> &'static [EffectDef] {
-    MOD_EFFECTS.get().map_or(&[], Vec::as_slice)
-}
-/// Every registered effect: vanilla's, then the content mods'.
-pub fn all_effects() -> impl Iterator<Item = &'static EffectDef> {
-    EFFECTS.iter().chain(mod_effects())
-}
 pub fn effect(id: &str) -> Option<&'static EffectDef> {
-    let short = id.trim_start_matches("minecraft:");
-    match EFFECTS.iter().find(|e| e.id == short) {
-        Some(e) => Some(e),
-        None => mod_effect(id),
-    }
+    let id = id.trim_start_matches("minecraft:");
+    EFFECTS.iter().find(|e| e.id == id)
 }
-/// A content mod's effect id (`<ns>:<path>`), not vanilla's with or
-/// without `minecraft:`.
-#[inline]
-pub fn is_mod_effect(id: &str) -> bool {
-    !id.starts_with("minecraft:") && id.bytes().any(|b| b == b':')
-}
-/// Out of line, so vanilla's lookups (every frame, every tick) stay as they were.
-#[cold]
-#[inline(never)]
-fn mod_effect(id: &str) -> Option<&'static EffectDef> {
-    mod_effects().iter().find(|e| e.id == id)
-}
-/// `MobEffect.getDescriptionId` (`Util.makeDescriptionId("effect", key)`):
-/// `effect.<namespace>.<path>`, `/` in the path as `.`.
-pub fn description_id(id: &str) -> String {
-    let (namespace, path) = id.split_once(':').unwrap_or(("minecraft", id));
-    format!("effect.{namespace}.{}", path.replace('/', "."))
-}
-/// The effect's sprite in the GUI atlas (`Hud.getMobEffectSprite`: the key
-/// with `mob_effect/` before its path): `mob_effect/<path>` for vanilla's,
-/// `<ns>:mob_effect/<path>` for a mod's.
-pub fn sprite(id: &str) -> String {
-    let mut out = String::new();
-    push_sprite(&mut out, id);
-    out
-}
-/// [`sprite`], appended to `out`.
-pub fn push_sprite(out: &mut String, id: &str) {
-    let path = match id.split_once(':') {
-        None => id,
-        Some(("minecraft", path)) => path,
-        Some((namespace, path)) => {
-            out.push_str(namespace);
-            out.push(':');
-            path
-        }
-    };
-    out.push_str("mob_effect/");
-    out.push_str(path);
-}
-/// Namespaced effect ids for mob effect storage; a mod's id already is.
+/// Namespaced effect ids for mob effect storage.
 pub fn namespaced(id: &'static str) -> &'static str {
     static IDS: OnceLock<HashMap<&'static str, &'static str>> = OnceLock::new();
     let key = id.strip_prefix("minecraft:").unwrap_or(id);
@@ -300,15 +230,10 @@ pub fn potion_color(id: Option<&str>) -> u32 {
     let Some(def) = id.and_then(potion) else {
         return BASE_POTION_COLOR;
     };
-    effects_color(def.effects.iter().map(|(id, _, amp)| (*id, *amp)))
-}
-/// `PotionContents.getColorOptional` of some effects, `(id, amplifier)`, all visible: the mix of
-/// their colours weighted by amplifier + 1, else the base potion colour.
-pub fn effects_color<'a>(effects: impl Iterator<Item = (&'a str, i32)>) -> u32 {
     let (mut r, mut g, mut b, mut total) = (0u32, 0u32, 0u32, 0u32);
-    for (e, amp) in effects {
+    for (e, _, amp) in def.effects {
         let Some(e) = effect(e) else { continue };
-        let w = amp as u32 + 1;
+        let w = *amp as u32 + 1;
         r += w * (e.color >> 16 & 255);
         g += w * (e.color >> 8 & 255);
         b += w * (e.color & 255);
@@ -323,60 +248,3 @@ pub fn effects_color<'a>(effects: impl Iterator<Item = (&'a str, i32)>) -> u32 {
         _ => BASE_POTION_COLOR,
     }
 }
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn description_ids_and_sprites_keep_the_namespace() {
-        assert_eq!(description_id("speed"), "effect.minecraft.speed");
-        assert_eq!(description_id("minecraft:speed"), "effect.minecraft.speed");
-        assert_eq!(description_id("ruby:curse/dark"), "effect.ruby.curse.dark");
-        assert_eq!(sprite("speed"), "mob_effect/speed");
-        assert_eq!(sprite("minecraft:speed"), "mob_effect/speed");
-        assert_eq!(sprite("ruby:curse/dark"), "ruby:mob_effect/curse/dark");
-    }
-
-    /// `PotionContents.getColorOptional`: each visible effect's colour weighted by its
-    /// amplifier + 1, the channels averaged by integer division; none gives the base colour.
-    #[test]
-    fn effects_mix_their_colours_by_amplifier() {
-        let c = |id: &str| effect(id).unwrap().color;
-        assert_eq!(effects_color([("poison", 0)].into_iter()), c("poison"));
-        let (p, s) = (c("poison"), c("speed"));
-        let mix = |shift: u32| (((p >> shift & 255) + 3 * (s >> shift & 255)) / 4) << shift;
-        assert_eq!(
-            effects_color([("poison", 0), ("speed", 2)].into_iter()),
-            mix(16) | mix(8) | mix(0)
-        );
-        assert_eq!(effects_color(std::iter::empty()), BASE_POTION_COLOR);
-    }
-
-    /// The only test that registers: the registry is set once per process.
-    #[test]
-    fn mod_effects_follow_vanilla_once_registered() {
-        assert!(register_mod_effects([(
-            "ruby:glow".to_owned(),
-            0xFF0000,
-            Category::Neutral
-        )]));
-        assert!(!register_mod_effects([(
-            "ruby:late".to_owned(),
-            1,
-            Category::Harmful
-        )]));
-        let glow = effect("ruby:glow").unwrap();
-        assert_eq!(
-            (glow.color, glow.category, glow.instant),
-            (0xFF0000, Category::Neutral, false)
-        );
-        assert!(effect("glow").is_none() && effect("ruby:late").is_none());
-        assert!(is_mod_effect(glow.id) && !is_mod_effect("speed"));
-        assert!(!is_mod_effect(namespaced("speed")));
-        assert_eq!(namespaced(glow.id), "ruby:glow");
-        assert_eq!(effect("minecraft:speed").unwrap().id, "speed");
-        let ids: Vec<_> = all_effects().map(|e| e.id).collect();
-        assert_eq!(ids.len(), EFFECTS.len() + 1);
-        assert_eq!(ids.last(), Some(&"ruby:glow"));
-    }
-}

crates/horizon-client-core/src/registries.rs

@@ -28,16 +28,6 @@ pub struct Registries {
     /// Game rule name -> integer-valued.
     pub game_rules: Vec<(String, bool)>,
     pub players: Vec<String>,
-    /// A dedicated server's lists, for the completions of `/op`, `/deop`, `/pardon`, `/pardon-ip` and
-    /// `/whitelist`: the operators' names, the banned names and addresses, the whitelisted names.
-    pub ops: Vec<String>,
-    pub banned_players: Vec<String>,
-    pub banned_ips: Vec<String>,
-    pub whitelisted: Vec<String>,
-    /// `ClientSuggestionProvider.customCompletionSuggestions`: the extra chat
-    /// completions the server sent (ClientboundCustomChatCompletionsPacket),
-    /// each once.
-    pub custom_completions: std::collections::BTreeSet<String>,
     /// Scoreboard objective names, team names and tracked score holders.
     pub objectives: Vec<String>,
     pub teams: Vec<String>,
@@ -97,55 +87,7 @@ pub struct RegistryIds {
     pub tags: Vec<String>,
 }
 const EMPTY: &[String] = &[];
-/// ClientboundCustomChatCompletionsPacket.Action.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub enum CustomCompletionAction {
-    Add,
-    Remove,
-    Set,
-}
-impl CustomCompletionAction {
-    /// `Action.BY_ID`: `ByIdMap.continuous` with `OutOfBoundsStrategy.ZERO`,
-    /// so an unknown id is `ADD`.
-    pub fn from_id(id: i32) -> Self {
-        match id {
-            1 => Self::Remove,
-            2 => Self::Set,
-            _ => Self::Add,
-        }
-    }
-}
-/// `ClientSuggestionProvider.modifyCustomCompletions`: the server adds,
-/// removes or replaces the extra chat completions.
-pub fn modify_custom_completions(
-    set: &mut std::collections::BTreeSet<String>,
-    action: CustomCompletionAction,
-    entries: &[String],
-) {
-    match action {
-        CustomCompletionAction::Add => set.extend(entries.iter().cloned()),
-        CustomCompletionAction::Remove => {
-            for e in entries {
-                set.remove(e);
-            }
-        }
-        CustomCompletionAction::Set => {
-            set.clear();
-            set.extend(entries.iter().cloned());
-        }
-    }
-}
 impl Registries {
-    /// `ClientSuggestionProvider.getCustomTabSuggestions`: what chat (not a
-    /// command) completes, the online players' names with the server's custom
-    /// completions, each once.
-    pub fn custom_tab_suggestions(&self) -> std::collections::BTreeSet<&str> {
-        self.players
-            .iter()
-            .chain(&self.custom_completions)
-            .map(String::as_str)
-            .collect()
-    }
     /// Fill what the game did not build itself from vanilla's exported
     /// registries (`command-registries.json`, written by
     /// `VanillaCommandParseOracle registries`): built-in registries such as
@@ -213,48 +155,6 @@ impl Registries {
             }
         }
     }
-    /// Only what [`Self::fill_from_export`] takes from an export, to keep
-    /// in place of the export itself (a third of its memory).
-    pub fn from_export(r: &serde_json::Value) -> Self {
-        let mut out = Self::default();
-        out.fill_from_export(r);
-        out
-    }
-    /// [`Self::fill_from_export`] from an export already read with
-    /// [`Self::from_export`]: each field the game left empty, each registry
-    /// it did not list.
-    pub fn fill_from_exported(&mut self, e: &Self) {
-        let fill = |field: &mut Vec<String>, from: &Vec<String>| {
-            if field.is_empty() {
-                field.clone_from(from);
-            }
-        };
-        fill(&mut self.effects, &e.effects);
-        fill(&mut self.enchantments, &e.enchantments);
-        fill(&mut self.attributes, &e.attributes);
-        fill(&mut self.damage_types, &e.damage_types);
-        fill(&mut self.templates, &e.templates);
-        fill(&mut self.persistent_components, &e.persistent_components);
-        fill(&mut self.learnable_recipes, &e.learnable_recipes);
-        for (name, ids) in &e.by_registry {
-            if !self.by_registry.contains_key(name) {
-                self.by_registry.insert(name.clone(), ids.clone());
-            }
-        }
-        if self.block_entities.is_empty() {
-            self.block_entities.clone_from(&e.block_entities);
-        }
-        if self.block_tag_members.is_empty() {
-            self.block_tag_members.clone_from(&e.block_tag_members);
-        }
-        if self.clock_time_markers.is_empty() {
-            self.clock_time_markers.clone_from(&e.clock_time_markers);
-        }
-        if self.advancement_criteria.is_empty() {
-            self.advancement_criteria
-                .clone_from(&e.advancement_criteria);
-        }
-    }
     /// The element ids of a registry (sorted).
     pub fn ids(&self, registry: &str) -> &[String] {
         if let Some(r) = self.by_registry.get(registry) {

crates/horizon-client-core/src/snbt.rs

@@ -3,8 +3,179 @@
 //! number formatting.
 use crate::text::{self, Style, Text};
 use horizon_world::nbt::Tag;
-use horizon_world::snbt_text::string_of;
-pub use horizon_world::snbt_text::{java_double, java_float, quote_and_escape, to_snbt};
+
+/// `Double.toString`.
+pub fn java_double(v: f64) -> String {
+    java_float_text(v, &format!("{v}"), &format!("{v:e}"))
+}
+/// `Float.toString`.
+pub fn java_float(v: f32) -> String {
+    java_float_text(f64::from(v), &format!("{v}"), &format!("{v:e}"))
+}
+fn java_float_text(v: f64, plain: &str, sci: &str) -> String {
+    if v.is_nan() {
+        return "NaN".into();
+    }
+    if v.is_infinite() {
+        return if v > 0.0 { "Infinity" } else { "-Infinity" }.into();
+    }
+    if v == 0.0 {
+        return if v.is_sign_negative() { "-0.0" } else { "0.0" }.into();
+    }
+    let a = v.abs();
+    if (1.0e-3..1.0e7).contains(&a) {
+        if plain.contains('.') {
+            plain.to_owned()
+        } else {
+            format!("{plain}.0")
+        }
+    } else {
+        let (mantissa, exponent) = sci.split_once('e').unwrap_or((sci, "0"));
+        let mantissa = if mantissa.contains('.') {
+            mantissa.to_owned()
+        } else {
+            format!("{mantissa}.0")
+        };
+        format!("{mantissa}E{exponent}")
+    }
+}
+
+/// `SnbtGrammar.escapeControlCharacters`.
+fn escape_control(c: char) -> Option<&'static str> {
+    Some(match c {
+        '\u{8}' => "b",
+        '\u{c}' => "f",
+        '\n' => "n",
+        '\r' => "r",
+        '\t' => "t",
+        _ => return None,
+    })
+}
+/// `StringTag.quoteAndEscape`.
+pub fn quote_and_escape(input: &str) -> String {
+    let mut out = String::from(" ");
+    let mut quote = '\0';
+    for c in input.chars() {
+        if c == '\\' {
+            out.push_str("\\\\");
+        } else if c != '"' && c != '\'' {
+            match escape_control(c) {
+                Some(e) => {
+                    out.push('\\');
+                    out.push_str(e);
+                }
+                None => out.push(c),
+            }
+        } else {
+            if quote == '\0' {
+                quote = if c == '"' { '\'' } else { '"' };
+            }
+            if quote == c {
+                out.push('\\');
+            }
+            out.push(c);
+        }
+    }
+    if quote == '\0' {
+        quote = '"';
+    }
+    out.replace_range(0..1, &quote.to_string());
+    out.push(quote);
+    out
+}
+fn unquoted_key(key: &str) -> bool {
+    if key.eq_ignore_ascii_case("true") || key.eq_ignore_ascii_case("false") {
+        return false;
+    }
+    let mut chars = key.chars();
+    let first_ok = chars
+        .next()
+        .is_some_and(|c| c.is_ascii_alphabetic() || c == '.' || c == '_');
+    // `[A-Za-z._]+[A-Za-z0-9._+-]*`
+    first_ok && chars.all(|c| c.is_ascii_alphanumeric() || matches!(c, '.' | '_' | '+' | '-'))
+}
+fn string_of(t: &horizon_world::nbt::JavaString) -> String {
+    t.to_string_lossy()
+}
+
+/// `Tag.toString` (StringTagVisitor).
+pub fn to_snbt(tag: &Tag) -> String {
+    let mut out = String::new();
+    visit(tag, &mut out);
+    out
+}
+fn visit(tag: &Tag, out: &mut String) {
+    match tag {
+        Tag::End => out.push_str("END"),
+        Tag::Byte(v) => out.push_str(&format!("{v}b")),
+        Tag::Short(v) => out.push_str(&format!("{v}s")),
+        Tag::Int(v) => out.push_str(&v.to_string()),
+        Tag::Long(v) => out.push_str(&format!("{v}L")),
+        Tag::Float(v) => {
+            out.push_str(&java_float(f32::from_bits(*v)));
+            out.push('f');
+        }
+        Tag::Double(v) => {
+            out.push_str(&java_double(f64::from_bits(*v)));
+            out.push('d');
+        }
+        Tag::String(s) => out.push_str(&quote_and_escape(&string_of(s))),
+        Tag::ByteArray(a) => {
+            out.push_str("[B;");
+            out.push_str(
+                &a.iter()
+                    .map(|v| format!("{}B", *v as i8))
+                    .collect::<Vec<_>>()
+                    .join(","),
+            );
+            out.push(']');
+        }
+        Tag::IntArray(a) => {
+            out.push_str("[I;");
+            out.push_str(&a.iter().map(i32::to_string).collect::<Vec<_>>().join(","));
+            out.push(']');
+        }
+        Tag::LongArray(a) => {
+            out.push_str("[L;");
+            out.push_str(
+                &a.iter()
+                    .map(|v| format!("{v}L"))
+                    .collect::<Vec<_>>()
+                    .join(","),
+            );
+            out.push(']');
+        }
+        Tag::List(l) => {
+            out.push('[');
+            for (i, t) in l.iter().enumerate() {
+                if i > 0 {
+                    out.push(',');
+                }
+                visit(t, out);
+            }
+            out.push(']');
+        }
+        Tag::Compound(c) => {
+            out.push('{');
+            let mut entries: Vec<(String, &Tag)> =
+                c.iter().map(|(k, v)| (string_of(k), v)).collect();
+            entries.sort_by(|a, b| a.0.cmp(&b.0));
+            for (i, (k, v)) in entries.iter().enumerate() {
+                if i > 0 {
+                    out.push(',');
+                }
+                if unquoted_key(k) {
+                    out.push_str(k);
+                } else {
+                    out.push_str(&quote_and_escape(k));
+                }
+                out.push(':');
+                visit(v, out);
+            }
+            out.push('}');
+        }
+    }
+}
 
 // ---- the coloured form -----------------------------------------------------
 

crates/horizon-client-core/src/text.rs

@@ -96,8 +96,6 @@ pub struct Style {
     pub hover: Option<Box<Text>>,
     /// `HoverEvent.ShowItem`: the event's `{id, count?, components?}` object.
     pub hover_item: Option<Box<Value>>,
-    /// `HoverEvent.ShowEntity`: the event's `{id, uuid, name?}` object.
-    pub hover_entity: Option<Box<Value>>,
     /// `Style.insertion`: the text a Shift-click puts in the chat box.
     pub insertion: Option<String>,
     /// The font (`FontDescription.Resource`), a full id like
@@ -129,12 +127,11 @@ impl Style {
         if self.click.is_none() {
             self.click.clone_from(&base.click);
         }
-        // One HoverEvent: its three kinds are inherited together, so a style
-        // with its own event never picks up another kind from `base`.
-        if self.hover.is_none() && self.hover_item.is_none() && self.hover_entity.is_none() {
+        if self.hover.is_none() {
             self.hover.clone_from(&base.hover);
+        }
+        if self.hover_item.is_none() {
             self.hover_item.clone_from(&base.hover_item);
-            self.hover_entity.clone_from(&base.hover_entity);
         }
         if self.insertion.is_none() {
             self.insertion.clone_from(&base.insertion);
@@ -594,10 +591,6 @@ fn style_json(style: &Style) -> Vec<(String, Value)> {
         let mut event = item.clone();
         event.insert("action".into(), "show_item".into());
         out.push(("hover_event".to_owned(), Value::Object(event)));
-    } else if let Some(Value::Object(entity)) = style.hover_entity.as_deref() {
-        let mut event = entity.clone();
-        event.insert("action".into(), "show_entity".into());
-        out.push(("hover_event".to_owned(), Value::Object(event)));
     }
     if let Some(insertion) = &style.insertion {
         out.push(("insertion".to_owned(), insertion.clone().into()));

crates/horizon-client-input/src/gamepad.rs

@@ -567,34 +567,6 @@ fn length(v: [f32; 2]) -> f32 {
     (v[0] * v[0] + v[1] * v[1]).sqrt()
 }
 
-/// 8BitDo Ultimate 2 Wireless (`2dc8:6012`). gilrs' bundled SDL DB only has a
-/// Windows row for it; on Linux/Bluetooth the right stick is on ABS_Z/ABS_RX
-/// (`LeftZ`/`RightStickX`) until an SDL mapping matches.
-pub const BITDO_ULTIMATE2_VID_PID: (u16, u16) = (0x2dc8, 0x6012);
-
-/// Stick axes after correcting pads whose right stick gilrs still exposes on
-/// `LeftZ`/`RightStickX` (no matching SDL row for this device version).
-/// `sdl_mapped` is true when gilrs already applied an SDL gamecontroller row.
-pub fn stick_axes(
-    left: [f32; 2],
-    right: [f32; 2],
-    left_z: f32,
-    vendor: Option<u16>,
-    product: Option<u16>,
-    sdl_mapped: bool,
-) -> ([f32; 2], [f32; 2]) {
-    if !sdl_mapped
-        && vendor == Some(BITDO_ULTIMATE2_VID_PID.0)
-        && product == Some(BITDO_ULTIMATE2_VID_PID.1)
-    {
-        // Default map: RightStickX is the stick's Y, LeftZ its X; RightStickY
-        // is the right trigger and must not drive look.
-        (left, [left_z, right[0]])
-    } else {
-        (left, right)
-    }
-}
-
 /// A radial deadzone: inside it the stick is centred; beyond it the rest of
 /// the travel is rescaled to 0..1 in the same direction, so diagonals aren't
 /// clipped and the first movement past the deadzone is small.
@@ -1206,38 +1178,6 @@ mod tests {
         assert_eq!(odd, PadSettings::default());
     }
 
-    #[test]
-    fn ultimate2_right_stick_on_z_without_sdl() {
-        let (left, right) = stick_axes(
-            [0.2, 0.3],
-            [0.7, -0.9],
-            -0.5,
-            Some(BITDO_ULTIMATE2_VID_PID.0),
-            Some(BITDO_ULTIMATE2_VID_PID.1),
-            false,
-        );
-        assert_eq!(left, [0.2, 0.3]);
-        assert_eq!(right, [-0.5, 0.7], "X from LeftZ, Y from RightStickX");
-        let kept = stick_axes(
-            [0.2, 0.3],
-            [0.7, -0.9],
-            -0.5,
-            Some(BITDO_ULTIMATE2_VID_PID.0),
-            Some(BITDO_ULTIMATE2_VID_PID.1),
-            true,
-        );
-        assert_eq!(kept, ([0.2, 0.3], [0.7, -0.9]), "SDL row already remapped");
-        let other = stick_axes(
-            [0.0, 0.0],
-            [1.0, 0.0],
-            0.5,
-            Some(0x045e),
-            Some(0x028e),
-            false,
-        );
-        assert_eq!(other, ([0.0, 0.0], [1.0, 0.0]));
-    }
-
     #[test]
     fn radial_deadzone_rescales() {
         assert_eq!(radial([0.1, 0.05], 0.15), [0.0, 0.0]);

crates/horizon-client-input/src/input.rs

@@ -2,9 +2,6 @@
 //! Item-use and sneak multipliers come from the player's current state; this
 //! module does not implement sprint eligibility, poses or the input lifecycle.
 
-use std::collections::HashSet;
-use winit::keyboard::{KeyCode, ModifiersState};
-
 fn length(v: [f32; 2]) -> f32 {
     f64::from(v[0] * v[0] + v[1] * v[1]).sqrt() as f32
 }
@@ -68,45 +65,3 @@ fn square_movement(v: [f32; 2]) -> [f32; 2] {
         },
     )
 }
-
-/// `InputQuirks.isQuitShortcutDown`: checks whether the platform's window-closing
-/// keyboard shortcut is held.
-/// - On macOS: Command (`super_key()`) + `Q`.
-/// - On Windows / Linux / other: Alt (`alt_key()`) + `F4`.
-pub fn is_quit_shortcut_down(modifiers: ModifiersState, keys: &HashSet<KeyCode>) -> bool {
-    if cfg!(target_os = "macos") {
-        modifiers.super_key() && keys.contains(&KeyCode::KeyQ)
-    } else {
-        modifiers.alt_key() && keys.contains(&KeyCode::F4)
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn quit_shortcut_follows_platform_modifiers_and_keys() {
-        let mut keys = HashSet::new();
-        let alt = ModifiersState::ALT;
-        let super_key = ModifiersState::SUPER;
-
-        assert!(!is_quit_shortcut_down(ModifiersState::empty(), &keys));
-
-        keys.insert(KeyCode::F4);
-        if cfg!(target_os = "macos") {
-            assert!(!is_quit_shortcut_down(alt, &keys));
-            keys.remove(&KeyCode::F4);
-            keys.insert(KeyCode::KeyQ);
-            assert!(is_quit_shortcut_down(super_key, &keys));
-            assert!(!is_quit_shortcut_down(alt, &keys));
-        } else {
-            assert!(is_quit_shortcut_down(alt, &keys));
-            assert!(!is_quit_shortcut_down(super_key, &keys));
-            keys.remove(&KeyCode::F4);
-            keys.insert(KeyCode::KeyQ);
-            assert!(!is_quit_shortcut_down(alt, &keys));
-            assert!(!is_quit_shortcut_down(super_key, &keys));
-        }
-    }
-}

crates/horizon-client-input/src/interaction_input.rs

@@ -51,10 +51,6 @@ impl InteractionInput {
     pub fn press(&mut self, button: Button) {
         self.clicks[button as usize] += 1;
     }
-    /// Whether a click waits for the next tick.
-    pub fn has_clicks(&self) -> bool {
-        self.clicks.iter().any(|&c| c > 0)
-    }
 
     pub fn tick(&mut self, world: &mut impl InteractionWorld, attack_down: bool, use_down: bool) {
         let [attack, use_item, pick] = std::mem::take(&mut self.clicks);
@@ -85,19 +81,6 @@ impl InteractionInput {
     }
 }
 
-/// The sentence of `Minecraft.handleKeybinds` that follows a key which opened
-/// a screen: `Gui.setScreen` has already run `KeyMapping.releaseAll()`, so
-/// `key.use` reads up and the same call releases an active use
-/// (`player.isUsingItem() && !keyUse.isDown()` → `MultiPlayerGameMode.releaseUsingItem`).
-/// Only the screens opened from the keybinds do this (the inventory, chat and
-/// advancements); the pause menu, server containers, mount inventories and
-/// dialogs release on the first tick after closing instead, as vanilla does.
-pub fn release_on_screen_open(world: &mut impl InteractionWorld) {
-    if world.using_item() {
-        world.release_using();
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;

crates/horizon-client-input/src/keybinds.rs

@@ -284,26 +284,6 @@ pub fn mouse_button(name: &str) -> Option<MouseButton> {
 }
 pub use horizon_client_core::key_display::display_name;
 
-/// A key event: what the layout writes on its key, without modifiers, names
-/// that key from now on (`key_display::learn_layout`), so an AZERTY player's
-/// Q key shows A.
-pub fn learn_layout(event: &winit::event::KeyEvent) {
-    use winit::keyboard::{Key, PhysicalKey};
-    use winit::platform::modifier_supplement::KeyEventExtModifierSupplement;
-    let PhysicalKey::Code(code) = event.physical_key else {
-        return;
-    };
-    let Some(name) = key_name(code) else {
-        return;
-    };
-    let learn = horizon_client_core::key_display::learn_layout;
-    match event.key_without_modifiers() {
-        Key::Character(text) => learn(name, &text),
-        Key::Dead(Some(c)) => learn(name, c.encode_utf8(&mut [0; 4])),
-        _ => {}
-    }
-}
-
 /// Current bindings by mapping name.
 #[derive(Clone, Debug, PartialEq, Eq)]
 pub struct KeyBinds {
@@ -483,21 +463,6 @@ impl KeyBinds {
             .find(|mapping| self.get(mapping) == name)
             .and_then(|mapping| key_code(Self::default_of(mapping)))
     }
-    /// `AbstractContainerScreen.checkHotbarKeyPressed`: the off hand and the
-    /// hotbar slots, as the controls bind them now. Answers the key the menu
-    /// acts on (`KeyF` for the off hand, `DigitN` for a slot), so a rebound key
-    /// swaps instead of reaching the screen.
-    pub fn container_hotbar_key(&self, key: KeyCode) -> Option<KeyCode> {
-        let name = key_name(key)?;
-        if self.get("key.swapOffhand") == name {
-            return Some(KeyCode::KeyF);
-        }
-        MAPPINGS
-            .iter()
-            .filter(|m| m.0.starts_with("key.hotbar."))
-            .find(|m| self.get(m.0) == name)
-            .and_then(|m| key_code(Self::default_of(m.0)))
-    }
 }
 
 #[cfg(test)]
@@ -534,29 +499,6 @@ mod tests {
         assert_eq!(keys.container_mouse_key(MouseButton::Forward, false), None);
     }
 
-    #[test]
-    fn container_hotkeys_follow_the_bound_keys() {
-        let mut keys = KeyBinds::default();
-        assert_eq!(
-            keys.container_hotbar_key(KeyCode::KeyF),
-            Some(KeyCode::KeyF)
-        );
-        assert_eq!(
-            keys.container_hotbar_key(KeyCode::Digit3),
-            Some(KeyCode::Digit3)
-        );
-        assert_eq!(keys.container_hotbar_key(KeyCode::Tab), None);
-        // The report's key: bound to the off hand, the menu takes it first.
-        keys.set("key.swapOffhand", "key.keyboard.tab");
-        assert_eq!(keys.container_hotbar_key(KeyCode::Tab), Some(KeyCode::KeyF));
-        assert_eq!(keys.container_hotbar_key(KeyCode::KeyF), None);
-        keys.set("key.hotbar.3", "key.keyboard.t");
-        assert_eq!(
-            keys.container_hotbar_key(KeyCode::KeyT),
-            Some(KeyCode::Digit3)
-        );
-    }
-
     #[test]
     fn rebinding_translates_to_defaults() {
         let mut k = KeyBinds::default();

crates/horizon-client-input/src/keymapping.rs

@@ -10,10 +10,6 @@ pub struct KeyState {
     released_by_screen_when_down: bool,
     toggle: Option<bool>,
     keyboard: bool,
-    /// Held down by a controller's toggle (Horizon's pad toggle-sneak, which
-    /// vanilla has no option for): until it lets go, the mapping toggles as
-    /// if its vanilla option were on, so a screen releases and restores it.
-    pad_toggled: bool,
 }
 
 impl KeyState {
@@ -24,7 +20,6 @@ impl KeyState {
             released_by_screen_when_down: false,
             toggle: None,
             keyboard: true,
-            pad_toggled: false,
         }
     }
     /// A `ToggleKeyMapping`; `keyboard` is whether the bound key is a keyboard key.
@@ -48,28 +43,16 @@ impl KeyState {
             true
         }
     }
-    /// The mapping toggles: its option is on, or a pad toggled it down.
-    fn needs_toggle(&self, option: bool) -> bool {
-        option || self.pad_toggled
-    }
     /// `setDown`; `needs_toggle` is the mapping's option value.
     pub fn set_down(&mut self, down: bool, needs_toggle: bool) {
-        if self.toggle.is_some() && self.needs_toggle(needs_toggle) {
+        if self.toggle.is_some() && needs_toggle {
             if down {
                 self.is_down = !self.is_down;
-                // Toggled back up: the pad's toggle is over.
-                self.pad_toggled &= self.is_down;
             }
         } else {
             self.is_down = down;
         }
     }
-    /// A controller's toggle button: flips the mapping like `setDown(true)`
-    /// with its option on, whatever the option says.
-    pub fn pad_toggle(&mut self) {
-        self.is_down = !self.is_down;
-        self.pad_toggled = self.is_down;
-    }
     /// `shouldSetOnIngameFocus` for a keyboard-bound, bound key.
     pub fn should_set_on_ingame_focus(&self, needs_toggle: bool) -> bool {
         self.keyboard && (self.toggle.is_none() || !needs_toggle)
@@ -78,8 +61,7 @@ impl KeyState {
     pub fn release(&mut self, needs_toggle: bool) {
         if self.toggle.is_some() {
             // ToggleKeyMapping.release does not clear pending clicks.
-            if self.needs_toggle(needs_toggle) && self.is_down || self.released_by_screen_when_down
-            {
+            if needs_toggle && self.is_down || self.released_by_screen_when_down {
                 self.released_by_screen_when_down = true;
             }
             self.reset();
@@ -88,8 +70,7 @@ impl KeyState {
             self.set_down(false, needs_toggle);
         }
     }
-    /// `ToggleKeyMapping.reset`. A pad toggle stays on record, so the screen
-    /// that released it restores it.
+    /// `ToggleKeyMapping.reset`.
     pub fn reset(&mut self) {
         self.is_down = false;
     }
@@ -102,10 +83,7 @@ impl KeyState {
         let Some(restore) = self.toggle else {
             return false;
         };
-        let result = restore
-            && self.needs_toggle(needs_toggle)
-            && self.keyboard
-            && self.released_by_screen_when_down;
+        let result = restore && needs_toggle && self.keyboard && self.released_by_screen_when_down;
         self.released_by_screen_when_down = false;
         result
     }
@@ -160,15 +138,6 @@ impl ToggleKeys {
             _ => {}
         }
     }
-    /// A controller's toggle button bound to `slot` (the pad's toggle-sneak):
-    /// a press with no screen open flips the mapping and clicks it, as a
-    /// key press does with the mapping's toggle option on.
-    pub fn pad_toggle(&mut self, slot: usize, screen_open: bool) {
-        if !screen_open {
-            self.0[slot].pad_toggle();
-            self.0[slot].click();
-        }
-    }
     /// `MouseHandler.onButton` for a button bound to `slot`: only without a
     /// screen or overlay.
     pub fn button(&mut self, slot: usize, pressed: bool, screen_open: bool, needs_toggle: bool) {
@@ -198,29 +167,12 @@ impl ToggleKeys {
     pub fn respawn(&mut self) {
         for key in &mut self.0 {
             key.reset();
-            // As with the vanilla option, the death screen closing after
-            // this still restores a toggle it released.
-            key.pad_toggled &= key.released_by_screen_when_down;
         }
     }
 }
 
 #[cfg(test)]
 mod tests {
-    /// `KeyMapping.resetToggleKeys` (a new `LocalPlayer`): a sneak and a sprint toggled on in one
-    /// world are off in the next.
-    #[test]
-    fn resetting_the_toggle_keys_puts_every_mapping_up() {
-        let mut keys = ToggleKeys::default();
-        keys.key(0, KeyAction::Press, false, true);
-        keys.key(1, KeyAction::Press, false, true);
-        assert!(keys.is_down(0) && keys.is_down(1));
-        for key in &mut keys.0 {
-            key.reset();
-        }
-        assert!(!keys.is_down(0) && !keys.is_down(1));
-    }
-
     use super::*;
     #[test]
     fn toggle_flips_on_press_and_ignores_release() {
@@ -245,57 +197,6 @@ mod tests {
         keys.respawn();
         assert!(!keys.is_down(SPRINT));
     }
-    /// #3061: the pad's toggle-sneak (vanilla's toggle crouch off) comes
-    /// back after a screen, as the vanilla option's toggle does; a
-    /// keyboard shift-click in the inventory does not drop it.
-    #[test]
-    fn pad_toggle_is_restored_after_a_screen() {
-        let off = [false; 4];
-        let mut keys = ToggleKeys::default();
-        keys.pad_toggle(SNEAK, false);
-        assert!(keys.is_down(SNEAK));
-        keys.screen_opened(off);
-        assert!(!keys.is_down(SNEAK));
-        keys.key(SNEAK, KeyAction::Press, true, false);
-        keys.key(SNEAK, KeyAction::Release, true, false);
-        keys.screen_closed(off);
-        assert!(keys.is_down(SNEAK), "the pad's toggle is restored");
-        // Toggled back up, it stays up through the next screen.
-        keys.pad_toggle(SNEAK, false);
-        assert!(!keys.is_down(SNEAK));
-        keys.screen_opened(off);
-        keys.screen_closed(off);
-        assert!(!keys.is_down(SNEAK));
-        // A held key is not restored, as before.
-        keys.key(SNEAK, KeyAction::Press, false, false);
-        keys.screen_opened(off);
-        keys.key(SNEAK, KeyAction::Release, true, false);
-        keys.screen_closed(off);
-        assert!(!keys.is_down(SNEAK));
-    }
-    /// After the pad's toggle is over (toggled up, or reset by a respawn
-    /// with no screen to restore it), the shift key holds again.
-    #[test]
-    fn pad_toggle_ends_with_its_release() {
-        let off = [false; 4];
-        let mut keys = ToggleKeys::default();
-        keys.pad_toggle(SNEAK, false);
-        keys.respawn();
-        assert!(!keys.is_down(SNEAK));
-        keys.key(SNEAK, KeyAction::Press, false, false);
-        keys.key(SNEAK, KeyAction::Release, false, false);
-        assert!(!keys.is_down(SNEAK), "held, not toggled");
-        // The death screen releases it and closes after the respawn: the
-        // toggle comes back, as with the vanilla option.
-        keys.pad_toggle(SNEAK, false);
-        keys.screen_opened(off);
-        keys.respawn();
-        keys.screen_closed(off);
-        assert!(keys.is_down(SNEAK));
-        // A press with a screen open does nothing.
-        keys.pad_toggle(SNEAK, true);
-        assert!(keys.is_down(SNEAK));
-    }
     #[test]
     fn screen_release_restores_toggled_state() {
         let mut k = KeyState::toggle(true, true);

crates/horizon-client-input/src/lib.rs

@@ -10,6 +10,5 @@ pub mod interaction_input;
 pub mod key_names;
 pub mod keybinds;
 pub mod keymapping;
-pub mod modifiers;
 pub mod mouse;
 pub mod window;

crates/horizon-client-input/src/modifiers.rs

@@ -1,232 +0,0 @@
-//! OS modifier reconciliation and modifiers synthesized by agent control.
-
-use crate::{
-    keybinds::{KeyBinds, key_code},
-    keymapping::{KeyAction, SNEAK, SPRINT, ToggleKeys},
-};
-use std::collections::HashSet;
-use winit::keyboard::{KeyCode, ModifiersState};
-
-const MODIFIERS: [(ModifiersState, [KeyCode; 2]); 4] = [
-    (
-        ModifiersState::SHIFT,
-        [KeyCode::ShiftLeft, KeyCode::ShiftRight],
-    ),
-    (
-        ModifiersState::CONTROL,
-        [KeyCode::ControlLeft, KeyCode::ControlRight],
-    ),
-    (ModifiersState::ALT, [KeyCode::AltLeft, KeyCode::AltRight]),
-    (
-        ModifiersState::SUPER,
-        [KeyCode::SuperLeft, KeyCode::SuperRight],
-    ),
-];
-
-/// A synthesized key updates the same modifier word as window events.
-/// Releasing one side must preserve the other side's hold.
-pub fn set_key(
-    modifiers: &mut ModifiersState,
-    physical: &mut HashSet<KeyCode>,
-    key: KeyCode,
-    down: bool,
-) {
-    let Some((bit, pair)) = MODIFIERS.iter().find(|(_, pair)| pair.contains(&key)) else {
-        return;
-    };
-    if down {
-        physical.insert(key);
-    } else {
-        physical.remove(&key);
-    }
-    modifiers.set(*bit, pair.iter().any(|key| physical.contains(key)));
-}
-
-/// A modifier held for one synthesized click (the pad's Y, an agent's
-/// shift-click): what [`restore`] puts back once the click is done.
-#[derive(Clone, Copy, Debug)]
-pub struct Held {
-    key: KeyCode,
-    was_down: bool,
-    bit: bool,
-}
-
-/// Holds `key` in both the physical keys and the modifier word, which is
-/// what screens read (`InputWithModifiers.hasShiftDown`).
-pub fn hold(modifiers: &mut ModifiersState, physical: &mut HashSet<KeyCode>, key: KeyCode) -> Held {
-    let bit = MODIFIERS
-        .iter()
-        .find(|(_, pair)| pair.contains(&key))
-        .is_some_and(|(bit, _)| modifiers.contains(*bit));
-    let held = Held {
-        key,
-        was_down: physical.contains(&key),
-        bit,
-    };
-    set_key(modifiers, physical, key, true);
-    held
-}
-
-/// Undoes [`hold`]: a key or bit that was already down stays down.
-pub fn restore(modifiers: &mut ModifiersState, physical: &mut HashSet<KeyCode>, held: Held) {
-    if !held.was_down {
-        physical.remove(&held.key);
-    }
-    if let Some((bit, _)) = MODIFIERS.iter().find(|(_, pair)| pair.contains(&held.key)) {
-        modifiers.set(*bit, held.bit);
-    }
-}
-
-/// Recover missing modifier releases without releasing a rebound key or a pad.
-/// ToggleKeyMapping itself preserves keyboard and controller toggles on release.
-pub fn reconcile(
-    modifiers: ModifiersState,
-    physical: &mut HashSet<KeyCode>,
-    bindings: &KeyBinds,
-    toggles: &mut ToggleKeys,
-    options: [bool; 2],
-    pad_held: [bool; 2],
-) {
-    for (bit, pair) in MODIFIERS {
-        if modifiers.contains(bit) {
-            continue;
-        }
-        for key in pair {
-            if !physical.remove(&key) {
-                continue;
-            }
-            for (slot, name) in [(SNEAK, "key.sneak"), (SPRINT, "key.sprint")] {
-                if key_code(bindings.get(name)) == Some(key) && !pad_held[slot] {
-                    toggles.key(slot, KeyAction::Release, false, options[slot]);
-                }
-            }
-        }
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn modifier_taps_release_both_bits() {
-        let mut modifiers = ModifiersState::empty();
-        let mut physical = HashSet::new();
-        for (bit, pair) in MODIFIERS {
-            for key in pair {
-                set_key(&mut modifiers, &mut physical, key, true);
-                assert!(modifiers.contains(bit));
-                set_key(&mut modifiers, &mut physical, key, false);
-                assert!(modifiers.is_empty());
-                assert!(physical.is_empty());
-            }
-        }
-    }
-
-    #[test]
-    fn releasing_one_side_keeps_the_other_modifier_held() {
-        let mut modifiers = ModifiersState::empty();
-        let mut physical = HashSet::new();
-        for (bit, [left, right]) in MODIFIERS {
-            set_key(&mut modifiers, &mut physical, left, true);
-            set_key(&mut modifiers, &mut physical, right, true);
-            set_key(&mut modifiers, &mut physical, left, false);
-            assert!(modifiers.contains(bit));
-            set_key(&mut modifiers, &mut physical, right, false);
-            assert!(modifiers.is_empty());
-        }
-    }
-
-    #[test]
-    fn a_held_click_restores_the_previous_state() {
-        let mut modifiers = ModifiersState::empty();
-        let mut physical = HashSet::new();
-        let held = hold(&mut modifiers, &mut physical, KeyCode::ShiftLeft);
-        assert!(modifiers.shift_key());
-        restore(&mut modifiers, &mut physical, held);
-        assert!(modifiers.is_empty());
-        assert!(physical.is_empty());
-
-        // Right Shift already held, or the OS word set with no physical key.
-        for start in [HashSet::from([KeyCode::ShiftRight]), HashSet::new()] {
-            let mut modifiers = ModifiersState::SHIFT;
-            let mut physical = start.clone();
-            let held = hold(&mut modifiers, &mut physical, KeyCode::ShiftLeft);
-            restore(&mut modifiers, &mut physical, held);
-            assert_eq!(modifiers, ModifiersState::SHIFT);
-            assert_eq!(physical, start);
-        }
-    }
-
-    #[test]
-    fn lost_releases_respect_rebindings_and_pad_holds() {
-        for slot in [SNEAK, SPRINT] {
-            for rebound in [false, true] {
-                for pad in [false, true] {
-                    for toggle in [false, true] {
-                        let mut bindings = KeyBinds::default();
-                        let (name, modifier) = if slot == SNEAK {
-                            ("key.sneak", KeyCode::ShiftLeft)
-                        } else {
-                            ("key.sprint", KeyCode::ControlLeft)
-                        };
-                        if rebound {
-                            bindings.set(name, "key.keyboard.c");
-                        }
-                        let mut physical = HashSet::from([modifier]);
-                        if rebound {
-                            physical.insert(KeyCode::KeyC);
-                        }
-                        let mut toggles = ToggleKeys::default();
-                        toggles.key(slot, KeyAction::Press, false, toggle);
-                        let mut options = [false; 2];
-                        options[slot] = toggle;
-                        let mut pad_held = [false; 2];
-                        pad_held[slot] = pad;
-                        reconcile(
-                            ModifiersState::ALT,
-                            &mut physical,
-                            &bindings,
-                            &mut toggles,
-                            options,
-                            pad_held,
-                        );
-                        assert_eq!(toggles.is_down(slot), rebound || pad || toggle);
-                        assert!(!physical.contains(&modifier));
-                        assert_eq!(physical.contains(&KeyCode::KeyC), rebound);
-                    }
-                }
-            }
-        }
-    }
-
-    #[test]
-    fn unrelated_modifier_change_does_not_release_an_action() {
-        let mut toggles = ToggleKeys::default();
-        toggles.key(SNEAK, KeyAction::Press, false, false);
-        reconcile(
-            ModifiersState::ALT,
-            &mut HashSet::new(),
-            &KeyBinds::default(),
-            &mut toggles,
-            [false; 2],
-            [false; 2],
-        );
-        assert!(toggles.is_down(SNEAK));
-    }
-
-    #[test]
-    fn lost_modifier_release_preserves_a_controller_toggle() {
-        let mut toggles = ToggleKeys::default();
-        toggles.pad_toggle(SNEAK, false);
-        reconcile(
-            ModifiersState::empty(),
-            &mut HashSet::from([KeyCode::ShiftLeft]),
-            &KeyBinds::default(),
-            &mut toggles,
-            [false; 2],
-            [false; 2],
-        );
-        assert!(toggles.is_down(SNEAK));
-    }
-}

crates/horizon-client-input/src/mouse.rs

@@ -342,28 +342,6 @@ pub fn mouse_position_after_grab_change(
     }
 }
 
-/// `MacosUtil.setCtrlClickEmulatesRightClick`: with the option on (and only on
-/// macOS), a left click made with Control held is a right click, and so is
-/// its release, whatever Control does in between.
-#[derive(Clone, Copy, Debug, Default)]
-pub struct RightClickEmulation {
-    emulating: bool,
-}
-impl RightClickEmulation {
-    /// Whether the left button's `pressed` or released event is a right click.
-    /// `enabled` is the option on macOS.
-    pub fn is_right_click(&mut self, pressed: bool, control: bool, enabled: bool) -> bool {
-        if pressed {
-            self.emulating = enabled && control;
-        }
-        let right = self.emulating;
-        if !pressed {
-            self.emulating = false;
-        }
-        right
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -548,21 +526,4 @@ mod tests {
             None
         );
     }
-
-    #[test]
-    fn control_click_is_a_right_click_until_released() {
-        let mut e = RightClickEmulation::default();
-        // The option off, or no Control: a left click stays one.
-        assert!(!e.is_right_click(true, true, false));
-        assert!(!e.is_right_click(false, true, false));
-        assert!(!e.is_right_click(true, false, true));
-        assert!(!e.is_right_click(false, true, true));
-        // Control held at the press: the press and the release are right clicks,
-        // even when Control was let go before the release.
-        assert!(e.is_right_click(true, true, true));
-        assert!(e.is_right_click(false, false, true));
-        // The next left click is its own.
-        assert!(!e.is_right_click(true, false, true));
-        assert!(!e.is_right_click(false, false, true));
-    }
 }

crates/horizon-client-input/src/window.rs

@@ -284,18 +284,12 @@ impl FramerateLimiter {
 /// (`Window.updateFullscreenState` -> `Minecraft.fullscreenStateChanged`), and
 /// the window is only asked to change when the option itself changes
 /// (`Window.updateFullscreenIfChanged`), never re-forced to the option.
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub struct FullscreenState {
     /// The state the window system last reported (`Window.fullscreen`).
     actual: bool,
     /// The state last asked of the window system, or adopted from it.
     requested: bool,
-    /// `Window.exclusiveFullscreen`.
-    exclusive: bool,
-    /// `Window.preferredFullscreenVideoMode`.
-    mode: Option<VideoMode>,
-    /// `Window.dirty`: the preferred mode changed and the screen has not been left yet.
-    mode_dirty: bool,
 }
 
 impl FullscreenState {
@@ -304,70 +298,9 @@ impl FullscreenState {
         Self {
             actual: false,
             requested,
-            exclusive: false,
-            mode: None,
-            mode_dirty: false,
         }
     }
 
-    /// `Window.updateFullscreenIfChanged` with the exclusive option and preferred mode: asks the
-    /// window to enter, leave or change its fullscreen only when one of them changed.
-    /// `in_video_screen` holds a changed mode back until the Video Settings screen closes
-    /// (`changeFullscreenVideoMode`).
-    pub fn apply(
-        &mut self,
-        window: &winit::window::Window,
-        wanted: bool,
-        exclusive: bool,
-        preferred: Option<VideoMode>,
-        in_video_screen: bool,
-    ) {
-        let request = self.request(wanted);
-        let reapply = self.set_exclusive(exclusive);
-        self.set_preferred_mode(preferred);
-        let mode_change = !in_video_screen && self.take_mode_change();
-        match request {
-            Some(false) => window.set_fullscreen(None),
-            Some(true) => window.set_fullscreen(Some(fullscreen_request(
-                window,
-                exclusive,
-                preferred.as_ref(),
-            ))),
-            None if reapply || mode_change => window.set_fullscreen(Some(fullscreen_request(
-                window,
-                exclusive,
-                preferred.as_ref(),
-            ))),
-            None => {}
-        }
-    }
-
-    /// `Window.setExclusiveFullscreen`: true when the option changed while fullscreen is
-    /// requested, so the window has to enter the other kind of fullscreen at once.
-    pub fn set_exclusive(&mut self, exclusive: bool) -> bool {
-        let changed = self.exclusive != exclusive;
-        self.exclusive = exclusive;
-        changed && self.requested
-    }
-
-    /// `Window.setPreferredFullscreenVideoMode`: a changed mode waits for `take_mode_change`.
-    pub fn set_preferred_mode(&mut self, mode: Option<VideoMode>) {
-        if self.mode != mode {
-            self.mode = mode;
-            self.mode_dirty = true;
-        }
-    }
-
-    /// `Window.changeFullscreenVideoMode` (the Video Settings screen closing): true once when
-    /// a changed mode has to be applied to a fullscreen window.
-    pub fn take_mode_change(&mut self) -> bool {
-        let apply = self.requested && self.mode_dirty;
-        if apply {
-            self.mode_dirty = false;
-        }
-        apply
-    }
-
     /// `Window.updateFullscreenIfChanged`: the state to ask of the window
     /// when the option `wanted` differs from what was last asked or adopted.
     pub fn request(&mut self, wanted: bool) -> Option<bool> {
@@ -388,168 +321,10 @@ impl FullscreenState {
     }
 }
 
-/// `VideoMode`: one display mode of a monitor, as `fullscreenResolution` in options.txt keeps it.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub struct VideoMode {
-    pub width: i32,
-    pub height: i32,
-    pub red_bits: i32,
-    pub green_bits: i32,
-    pub blue_bits: i32,
-    pub refresh_rate: f32,
-}
-
-impl VideoMode {
-    /// `VideoMode.read`: the JSON object `write` makes; any other string is None.
-    pub fn read(text: &str) -> Option<Self> {
-        let number = |key: &str| -> Option<f64> {
-            let at = text.find(&format!("\"{key}\""))? + key.len() + 2;
-            let rest = text[at..].trim_start().strip_prefix(':')?.trim_start();
-            let end = rest
-                .find(|c: char| !(c.is_ascii_digit() || matches!(c, '-' | '+' | '.' | 'e' | 'E')))
-                .unwrap_or(rest.len());
-            rest[..end].parse().ok()
-        };
-        if !text.trim_start().starts_with('{') {
-            return None;
-        }
-        Some(Self {
-            width: number("width")? as i32,
-            height: number("height")? as i32,
-            red_bits: number("red_bits")? as i32,
-            green_bits: number("green_bits")? as i32,
-            blue_bits: number("blue_bits")? as i32,
-            refresh_rate: number("refresh_rate")? as f32,
-        })
-    }
-
-    /// `VideoMode.write`: the Codec's JSON through Gson (a float prints as `60.0`).
-    pub fn write(&self) -> String {
-        let rate = if self.refresh_rate == self.refresh_rate.trunc() {
-            format!("{:.1}", self.refresh_rate)
-        } else {
-            self.refresh_rate.to_string()
-        };
-        format!(
-            "{{\"width\":{},\"height\":{},\"red_bits\":{},\"green_bits\":{},\"blue_bits\":{},\"refresh_rate\":{rate}}}",
-            self.width, self.height, self.red_bits, self.green_bits, self.blue_bits
-        )
-    }
-
-    /// `VideoMode.refreshRateLabel`: a whole rate without decimals, any other with two.
-    pub fn refresh_rate_label(&self) -> String {
-        if self.refresh_rate == self.refresh_rate.round_ties_even() {
-            (self.refresh_rate as i32).to_string()
-        } else {
-            format!("{:.2}", self.refresh_rate)
-        }
-    }
-
-    /// The colour depth `options.fullscreen.entry` shows.
-    pub fn bits(&self) -> i32 {
-        self.red_bits + self.green_bits + self.blue_bits
-    }
-
-    /// A winit mode: its depth is the total, split evenly over the channels.
-    pub fn from_winit(mode: &winit::monitor::VideoModeHandle) -> Self {
-        let depth = i32::from(mode.bit_depth());
-        let size = mode.size();
-        Self {
-            width: size.width as i32,
-            height: size.height as i32,
-            red_bits: depth / 3,
-            green_bits: depth / 3,
-            blue_bits: depth - 2 * (depth / 3),
-            refresh_rate: mode.refresh_rate_millihertz() as f32 / 1000.0,
-        }
-    }
-}
-
-/// `Monitor.videoModes`: the modes a monitor offers.
-pub fn monitor_video_modes(monitor: &winit::monitor::MonitorHandle) -> Vec<VideoMode> {
-    monitor
-        .video_modes()
-        .map(|m| VideoMode::from_winit(&m))
-        .collect()
-}
-
-/// The video modes of the window's monitor, listed once per monitor. Listing them takes tens of
-/// milliseconds on Windows, and settings apply at every step of a dragged slider: listing them
-/// each time made the slider stutter.
-#[derive(Debug)]
-pub struct VideoModeList<M = winit::monitor::MonitorHandle> {
-    listed: Option<M>,
-}
-
-impl<M> Default for VideoModeList<M> {
-    fn default() -> Self {
-        Self { listed: None }
-    }
-}
-
-impl<M: PartialEq> VideoModeList<M> {
-    /// The modes of `monitor` when it is not the monitor listed last, else `None` (the list
-    /// stands). No monitor lists none.
-    pub fn refresh(
-        &mut self,
-        monitor: Option<M>,
-        list: impl FnOnce(&M) -> Vec<VideoMode>,
-    ) -> Option<Vec<VideoMode>> {
-        if monitor.is_some() && monitor == self.listed {
-            return None;
-        }
-        let modes = monitor.as_ref().map(list).unwrap_or_default();
-        self.listed = monitor;
-        Some(modes)
-    }
-}
-
-/// `Monitor.currentMode`: the monitor's desktop mode; winit has no such query, so the mode of
-/// the monitor's own size with the highest refresh rate and depth.
-fn monitor_current_mode(
-    monitor: &winit::monitor::MonitorHandle,
-) -> Option<winit::monitor::VideoModeHandle> {
-    let size = monitor.size();
-    monitor
-        .video_modes()
-        .filter(|m| m.size() == size)
-        .max_by_key(|m| (m.refresh_rate_millihertz(), m.bit_depth()))
-}
-
-/// `Window.applyFullscreen`: the fullscreen the window asks for. Exclusive fullscreen takes
-/// `Monitor.getPreferredVideoMode` (the preferred mode if the monitor has it, else the desktop
-/// mode); a monitor with no usable mode falls back to borderless, as vanilla does.
-pub fn fullscreen_request(
-    window: &winit::window::Window,
-    exclusive: bool,
-    preferred: Option<&VideoMode>,
-) -> winit::window::Fullscreen {
-    use winit::window::Fullscreen;
-    if !exclusive {
-        return Fullscreen::Borderless(None);
-    }
-    let Some(monitor) = window
-        .current_monitor()
-        .or_else(|| window.primary_monitor())
-    else {
-        return Fullscreen::Borderless(None);
-    };
-    let wanted = preferred.and_then(|p| {
-        monitor
-            .video_modes()
-            .find(|m| VideoMode::from_winit(m) == *p)
-    });
-    match wanted.or_else(|| monitor_current_mode(&monitor)) {
-        Some(mode) => Fullscreen::Exclusive(mode),
-        None => Fullscreen::Borderless(None),
-    }
-}
-
 /// Horizon's icon for the window's title bar and the task bar (X11 and Windows; Wayland takes
 /// it from the `horizon.desktop` entry, macOS from the app bundle). `None` if it can't be read.
 pub fn icon() -> Option<winit::window::Icon> {
     let mut decoder = png::Decoder::new(std::io::Cursor::new(horizon_theme::ICON_PNG));
-    decoder.ignore_checksums(true);
     decoder.set_transformations(png::Transformations::EXPAND | png::Transformations::STRIP_16);
     let mut reader = decoder.read_info().ok()?;
     let mut bytes = vec![0; reader.output_buffer_size()?];
@@ -565,63 +340,11 @@ pub fn icon() -> Option<winit::window::Icon> {
 mod tests {
     use super::*;
 
-    #[test]
-    fn video_mode_round_trips_the_options_json() {
-        let mode = VideoMode {
-            width: 1920,
-            height: 1080,
-            red_bits: 8,
-            green_bits: 8,
-            blue_bits: 8,
-            refresh_rate: 60.0,
-        };
-        let text = mode.write();
-        assert_eq!(
-            text,
-            r#"{"width":1920,"height":1080,"red_bits":8,"green_bits":8,"blue_bits":8,"refresh_rate":60.0}"#
-        );
-        assert_eq!(VideoMode::read(&text), Some(mode));
-        assert_eq!(VideoMode::read("1920x1080"), None);
-        assert_eq!(VideoMode::read(r#"{"width":1}"#), None);
-    }
-    #[test]
-    fn refresh_rate_label_is_whole_or_two_decimals() {
-        let mut mode = VideoMode::read(
-            r#"{"width":1,"height":1,"red_bits":8,"green_bits":8,"blue_bits":8,"refresh_rate":144.0}"#,
-        )
-        .unwrap();
-        assert_eq!(mode.refresh_rate_label(), "144");
-        mode.refresh_rate = 59.94;
-        assert_eq!(mode.refresh_rate_label(), "59.94");
-        assert_eq!(mode.bits(), 24);
-    }
     #[test]
     fn the_window_icon_decodes() {
         assert!(icon().is_some());
     }
 
-    #[test]
-    fn exclusive_fullscreen_reapplies_only_while_fullscreen_is_requested() {
-        let mut f = FullscreenState::new(false);
-        assert!(!f.set_exclusive(true));
-        assert!(!f.set_exclusive(true));
-        assert_eq!(f.request(true), Some(true));
-        assert!(f.set_exclusive(false));
-        assert!(!f.set_exclusive(false));
-    }
-    #[test]
-    fn a_changed_video_mode_applies_once_when_fullscreen() {
-        let mode = VideoMode::read(
-            r#"{"width":1,"height":1,"red_bits":8,"green_bits":8,"blue_bits":8,"refresh_rate":60.0}"#,
-        );
-        let mut f = FullscreenState::new(false);
-        f.set_preferred_mode(mode);
-        assert!(!f.take_mode_change());
-        f.request(true);
-        f.set_preferred_mode(mode);
-        assert!(f.take_mode_change());
-        assert!(!f.take_mode_change());
-    }
     #[test]
     fn fullscreen_follows_the_option_only_when_it_changes() {
         let mut f = FullscreenState::new(false);
@@ -705,11 +428,6 @@ mod tests {
             vsync_present_mode(&[PresentMode::Fifo], false),
             Some(PresentMode::Fifo)
         );
-        // Regression guard: GLES capabilities report [Fifo, Immediate] without Mailbox.
-        assert_eq!(
-            vsync_present_mode(&[PresentMode::Fifo, PresentMode::Immediate], false),
-            Some(PresentMode::Immediate)
-        );
     }
     #[test]
     fn vsync_on_waits_for_the_display_whatever_the_present_mode() {
@@ -730,28 +448,4 @@ mod tests {
             Some(Immediate)
         );
     }
-
-    #[test]
-    fn video_modes_are_listed_again_only_for_another_monitor() {
-        let mode = |width| VideoMode {
-            width,
-            height: 1080,
-            red_bits: 8,
-            green_bits: 8,
-            blue_bits: 8,
-            refresh_rate: 60.0,
-        };
-        let mut list = VideoModeList::default();
-        let mut listings = 0;
-        let mut modes = |monitor: &i32| {
-            listings += 1;
-            vec![mode(*monitor)]
-        };
-        assert_eq!(list.refresh(Some(1), &mut modes), Some(vec![mode(1)]));
-        assert_eq!(list.refresh(Some(1), &mut modes), None);
-        assert_eq!(list.refresh(Some(2), &mut modes), Some(vec![mode(2)]));
-        assert_eq!(list.refresh(None, &mut modes), Some(vec![]));
-        assert_eq!(list.refresh(Some(2), &mut modes), Some(vec![mode(2)]));
-        assert_eq!(listings, 3);
-    }
 }

crates/horizon-client-lib/Cargo.toml

@@ -1,221 +0,0 @@
-[package]
-name = "horizon-client-lib"
-autobins = false
-autoexamples = false
-autotests = false
-version = "0.1.0"
-edition.workspace = true
-license.workspace = true
-rust-version = "1.90"
-description = "Reusable client systems, control tool and parity probes"
-
-[lib]
-path = "../horizon-client/src/client_lib.rs"
-
-[dependencies]
-horizon-assets = { path = "../horizon-assets" }
-horizon-client-core = { path = "../horizon-client-core" }
-horizon-client-input = { path = "../horizon-client-input" }
-horizon-client-render = { path = "../horizon-client-render" }
-horizon-command = { path = "../horizon-command" }
-horizon-items = { path = "../horizon-items" }
-horizon-core = { path = "../horizon-core" }
-# The server thread ahead of the workers (MinecraftServer.spin's Thread.setPriority).
-horizon-optifine = { path = "../horizon-optifine" }
-horizon-threads = { path = "../horizon-threads" }
-horizon-hdr = { path = "../horizon-hdr" }
-horizon-world = { path = "../horizon-world" }
-horizon-protocol = { path = "../horizon-protocol" }
-# server.properties, eula.txt and the user lists, shared with horizon-server.
-horizon-server-files = { path = "../horizon-server-files" }
-# The dedicated server's anticheat, off unless server.toml's [anticheat] turns it on (docs/anticheat.md).
-horizon-anticheat = { path = "../horizon-anticheat" }
-# The dedicated server's chat filter: [chat_filter], the slur list, mutes (docs/chat-filter.md).
-horizon-chat-filter = { path = "../horizon-chat-filter" }
-# Shader packs: reading them and turning their GLSL into naga modules.
-horizon-shaders = { path = "../horizon-shaders" }
-# Horizon's own shader packs: the format, the stages and the check (docs/shaders.md).
-horizon-shader-api = { path = "../horizon-shader-api" }
-horizon-friends = { path = "../horizon-friends" }
-# The narrator (GameNarrator): text-to-speech of chat, system messages and screens.
-horizon-narrator = { path = "../horizon-narrator" }
-# Horizon mods: sandboxed WebAssembly components, off unless installed and turned on (docs/mods.md).
-# Their runtime is the `mods` feature.
-horizon-mods = { path = "../horizon-mods", default-features = false, features = ["index"] }
-wgpu = { version = "30.0.1", default-features = false, features = ["std", "parking_lot", "vulkan", "metal", "wgsl", "naga-ir"] }
-winit = "0.30.13"
-pollster = "0.4"
-bytemuck = { version = "1.24", features = ["derive"] }
-glam = "0.30"
-png = "0.18"
-sha2 = "0.10.9"
-# Server resource packs are checked and cached by their SHA-1, as vanilla does.
-sha1 = "0.10"
-serde = { version = "1", features = ["derive"] }
-serde_json = { version = "1.0.151", features = ["raw_value"] }
-# hlsl-out: the gfx.rs tests translate every shader as wgpu's DirectX 12 backend does. A normal feature,
-# not a dev-dependency's, so builds, tests and examples share one build of naga, wgpu and this crate.
-naga = { version = "30.0.1", features = ["wgsl-in", "hlsl-out"] }
-miniz_oxide = "0.8"
-ab_glyph = "0.2.32"
-log = "0.4"
-chrono = { version = "0.4.42", default-features = false, features = ["clock", "std"] }
-flate2 = { version = "1.1.10", default-features = false, features = ["zlib-rs", "runtime_detection"] }
-horizon-theme = { path = "../horizon-theme" }
-# Opt-in data collection: the game keeps, the launcher sends (docs/telemetry.md); `live` is
-# the anonymous "I'm playing" ping the game sends itself (`heartbeat.rs`).
-horizon-telemetry = { path = "../horizon-telemetry", default-features = false, features = ["live"] }
-horizon-bench = { path = "../horizon-bench" }
-zip = { version = "9.1.3", default-features = false, features = ["deflate"] }
-# Controllers (evdev + libudev on Linux, IOKit on macOS, Windows.Gaming.Input); the `controllers` feature.
-gilrs = { version = "0.11", optional = true }
-# The DualSense's rumble, adaptive triggers and lights over HID (gilrs only reads it).
-horizon-dualsense = { path = "../horizon-dualsense", optional = true }
-# HTTPS to the Minecraft services (online-mode session join).
-ureq = { version = "2", default-features = false, features = ["tls"] }
-unicode-bidi = "0.3.18"
-# `LevelStorageAccess.estimateDiskSpace`: usable disk space, without unsafe code on Windows.
-fs4 = { version = "1.1.0", default-features = false, features = ["sync"] }
-
-[target.'cfg(unix)'.dependencies]
-# The server thread's CPU time per tick (`HORIZON_SPIKES`, spans.rs).
-rustix = { version = "1", default-features = false, features = ["std", "time", "process", "fs"] }
-
-[target.'cfg(windows)'.dependencies]
-# Use the registered URI handler without routing links through Explorer/cmd.
-open = { version = "5.4.5", features = ["shellexecute-on-windows"] }
-# DirectX 12, where Vulkan has no adapter or device, or by choice (`graphicsApi`, graphics.rs).
-# Shaders compile with FXC (d3dcompiler_47.dll, part of Windows), or DXC when dxcompiler.dll is
-# on the PATH.
-wgpu = { version = "30.0.1", default-features = false, features = ["dx12"] }
-
-[target.'cfg(target_os = "macos")'.dependencies]
-# Splitscreen: a window filling a monitor goes over its menu bar (game/split/windows.rs
-# `above_menu_bar`); all already in the tree through winit and wgpu.
-objc2 = "0.6"
-objc2-app-kit = { version = "0.3", default-features = false, features = ["std", "NSApplication", "NSResponder", "NSWindow", "NSScreen"] }
-objc2-foundation = { version = "0.3", default-features = false, features = ["std", "NSArray", "NSString"] }
-
-[target.'cfg(not(target_os = "macos"))'.dependencies]
-# OpenGL (WGL on Windows, EGL on Linux), the last fallback, for GPUs with no Vulkan or
-# DirectX 12 driver (`graphicsApi`, graphics.rs).
-wgpu = { version = "30.0.1", default-features = false, features = ["gles"] }
-
-[features]
-default = ["audio", "controllers"]
-# Sound output. Without it (and `controllers`) the program links neither libasound nor libudev on
-# Linux: the server build (`--no-default-features`, released as horizon-engine; docs/server.md).
-audio = ["horizon-client-render/audio"]
-# Controllers: gilrs, and the DualSense's own output. Without it only `horizon-ctl pad`'s virtual pad.
-controllers = ["dep:gilrs", "dep:horizon-dualsense", "horizon-client-input/controllers"]
-# Records the call sites of mob random draws (`mob_ai_probe` traces).
-rng-trace = ["horizon-core/rng-trace"]
-# Compatibility with earlier experiment commands: main already uses mimalloc.
-windows-mimalloc = []
-# Opt-in Windows heap experiment; see docs/windows-allocators.md.
-windows-segment-heap = []
-
-[lints]
-workspace = true
-
-[dev-dependencies]
-horizon-client-render = { path = "../horizon-client-render", features = ["test-support"] }
-horizon-items = { path = "../horizon-items", features = ["test-support"] }
-# Every WGSL shader translated as wgpu's DirectX 12 backend does (gfx.rs tests).
-naga = { version = "30.0.1", features = ["wgsl-in", "hlsl-out", "msl-out", "spv-out"] }
-
-[[bin]]
-name = "horizon-ctl"
-path = "../horizon-client/src/bin/horizon-ctl/main.rs"
-
-[[example]]
-name = "chunk_load_bench"
-path = "../horizon-client/examples/chunk_load_bench.rs"
-
-[[example]]
-name = "gameplay_decode_profile"
-path = "../horizon-client/examples/gameplay_decode_profile.rs"
-
-[[example]]
-name = "json_load_bench"
-path = "../horizon-client/examples/json_load_bench.rs"
-
-[[example]]
-name = "mod_port_probe"
-path = "../horizon-client/examples/mod_port_probe.rs"
-
-[[example]]
-name = "model_library_bench"
-path = "../horizon-client/examples/model_library_bench.rs"
-
-[[example]]
-name = "model_states_bench"
-path = "../horizon-client/examples/model_states_bench.rs"
-
-[[example]]
-name = "old_world_fixture"
-path = "../horizon-client/examples/old_world_fixture.rs"
-
-[[example]]
-name = "portal_scan_bench"
-path = "../horizon-client/examples/portal_scan_bench.rs"
-
-[[example]]
-name = "random_tick_eligibility_bench"
-path = "../horizon-client/examples/random_tick_eligibility_bench.rs"
-
-[[example]]
-name = "resource_memory"
-path = "../horizon-client/examples/resource_memory.rs"
-
-[[example]]
-name = "save_batch_bench"
-path = "../horizon-client/examples/save_batch_bench.rs"
-
-[[example]]
-name = "shared_json_startup_profile"
-path = "../horizon-client/examples/shared_json_startup_profile.rs"
-
-[[example]]
-name = "sprite_cache_parity"
-path = "../horizon-client/examples/sprite_cache_parity.rs"
-
-[[example]]
-name = "client_probe"
-path = "../horizon-client/examples/probe/main.rs"
-
-[[test]]
-name = "custom_component_api"
-path = "../horizon-client/tests/custom_component_api.rs"
-
-[[test]]
-name = "custom_component_unregistered"
-path = "../horizon-client/tests/custom_component_unregistered.rs"
-
-[[test]]
-name = "custom_component_wire"
-path = "../horizon-client/tests/custom_component_wire.rs"
-
-[[test]]
-name = "forced_chunks"
-path = "../horizon-client/tests/forced_chunks.rs"
-
-[[test]]
-name = "generation_saves"
-path = "../horizon-client/tests/generation_saves.rs"
-
-[[test]]
-name = "lan_bot"
-path = "../horizon-client/tests/lan_bot.rs"
-
-[[test]]
-name = "streaming_meshes"
-path = "../horizon-client/tests/streaming_meshes.rs"
-
-[[test]]
-name = "tall_column"
-path = "../horizon-client/tests/tall_column.rs"
-
-[[test]]
-name = "wide_states"
-path = "../horizon-client/tests/wide_states.rs"

crates/horizon-client-render/Cargo.toml

@@ -15,11 +15,6 @@ horizon-command = { path = "../horizon-command" }
 horizon-core = { path = "../horizon-core" }
 horizon-hdr = { path = "../horizon-hdr" }
 horizon-items = { path = "../horizon-items" }
-# The narrator option's status and whether the narrator is there (Options.narrator).
-horizon-narrator = { path = "../horizon-narrator" }
-# OptiFine-format pack files: random entity textures (hud.rs), connected textures
-# (connected.rs) and custom item texture rules (cit.rs).
-horizon-optifine = { path = "../horizon-optifine" }
 horizon-protocol = { path = "../horizon-protocol" }
 horizon-shader-api = { path = "../horizon-shader-api" }
 horizon-shaders = { path = "../horizon-shaders" }
@@ -28,7 +23,6 @@ horizon-theme = { path = "../horizon-theme" }
 horizon-threads = { path = "../horizon-threads" }
 horizon-world = { path = "../horizon-world" }
 ab_glyph = "0.2.32"
-base64 = "0.22"
 bytemuck = { version = "1.24", features = ["derive"] }
 # Sound (ALSA on Linux); the `audio` feature.
 cpal = { version = "0.16", optional = true }
@@ -37,21 +31,18 @@ flate2 = { version = "1.1.10", default-features = false, features = ["zlib-rs",
 glam = "0.30"
 log = "0.4"
 miniz_oxide = "0.8"
-naga = { version = "30.0.1", features = ["wgsl-in", "glsl-in", "hlsl-out"] }
-half = "2"
+naga = { version = "30.0.1", features = ["wgsl-in", "hlsl-out"] }
 png = "0.18"
 pollster = "0.4"
 serde = { version = "1", features = ["derive"] }
 serde_json = { version = "1.0.151", features = ["raw_value"] }
-sha1 = "0.10"
 sha2 = "0.10.9"
-smallvec = { version = "1", features = ["const_new"] }
 symphonia = { version = "0.5", default-features = false, features = ["ogg", "vorbis"] }
 unicode-bidi = "0.3.18"
 ureq = { version = "2", default-features = false, features = ["tls"] }
 wgpu = { version = "30.0.1", default-features = false, features = ["std", "parking_lot", "vulkan", "metal", "wgsl", "naga-ir"] }
 winit = "0.30.13"
-zip = { version = "9.1.3", default-features = false, features = ["deflate"] }
+zip = { version = "2", default-features = false, features = ["deflate"] }
 
 [target.'cfg(unix)'.dependencies]
 rustix = { version = "1", default-features = false, features = ["std", "time"] }
@@ -73,4 +64,4 @@ workspace = true
 
 [dev-dependencies]
 horizon-items = { path = "../horizon-items", features = ["test-support"] }
-naga = { version = "30.0.1", features = ["wgsl-in", "hlsl-out", "glsl-out", "msl-out", "spv-out"] }
+naga = { version = "30.0.1", features = ["wgsl-in", "hlsl-out", "msl-out", "spv-out"] }

crates/horizon-client-render/examples/pack_load_bench.rs

@@ -1,436 +0,0 @@
-//! How long a big resource pack takes to load and reload, on generated files only (no game
-//! resources): a stand-in vanilla root, a server-style zip pack of many namespaces, and a
-//! high-resolution pack over vanilla's own textures. Each stage runs a few times; the median
-//! is printed as a Markdown table.
-//! `cargo run --profile fast -p horizon-client-render --example pack_load_bench [-- --scale 1]`
-//! (`.github/workflows/pack-bench.yml` runs it on a branch and on its base, side by side).
-use horizon_client_render::{
-    hud::HudAtlas,
-    model_library::ParsedModels,
-    packs::{self, Pack},
-    sprites::Sprites,
-};
-use std::{
-    fs,
-    path::{Path, PathBuf},
-    time::Instant,
-};
-
-/// A small deterministic generator: the same files on every run and every branch.
-struct Noise(u64);
-impl Noise {
-    fn next(&mut self) -> u64 {
-        self.0 ^= self.0 << 13;
-        self.0 ^= self.0 >> 7;
-        self.0 ^= self.0 << 17;
-        self.0
-    }
-}
-
-/// A `side`x`side` RGBA PNG (`frames` tall when animated) of blotchy pixels, which compress
-/// about as well as real textures do.
-fn png(noise: &mut Noise, side: u32, frames: u32, alpha: bool) -> Vec<u8> {
-    let mut out = Vec::new();
-    {
-        let mut encoder = png::Encoder::new(&mut out, side, side * frames);
-        encoder.set_color(png::ColorType::Rgba);
-        encoder.set_depth(png::BitDepth::Eight);
-        let mut writer = encoder.write_header().unwrap();
-        let mut pixels = Vec::with_capacity((side * side * frames * 4) as usize);
-        let mut colour = [0u8; 4];
-        for i in 0..side * side * frames {
-            if i % 3 == 0 {
-                let n = noise.next();
-                colour = [n as u8, (n >> 8) as u8, (n >> 16) as u8, 255];
-                if alpha && n >> 40 & 3 == 0 {
-                    colour[3] = 0;
-                }
-            }
-            pixels.extend_from_slice(&colour);
-        }
-        writer.write_image_data(&pixels).unwrap();
-    }
-    out
-}
-
-fn model(noise: &mut Noise, namespace: &str, texture: &str) -> Vec<u8> {
-    let n = noise.next() % 4;
-    format!(
-        r##"{{"parent":"minecraft:block/cube_all","textures":{{"all":"{namespace}:{texture}"}},"elements":[{{"from":[0,0,0],"to":[16,{h},16],"faces":{{"north":{{"texture":"#all","uv":[0,0,16,16]}},"up":{{"texture":"#all"}}}}}}]}}"##,
-        h = 4 + n * 4
-    )
-    .into_bytes()
-}
-
-fn write(root: &Path, name: &str, bytes: &[u8]) {
-    let path = root.join(name);
-    fs::create_dir_all(path.parent().unwrap()).unwrap();
-    fs::write(path, bytes).unwrap();
-}
-
-/// A deflated zip written by hand (the reader skips CRCs, so they stay zero), at most 65535
-/// entries.
-#[derive(Default)]
-struct ZipOut {
-    out: Vec<u8>,
-    central: Vec<u8>,
-    count: u16,
-}
-impl ZipOut {
-    fn put(&mut self, name: &str, body: &[u8]) {
-        let data = miniz_oxide::deflate::compress_to_vec(body, 6);
-        let offset = u32::try_from(self.out.len()).unwrap();
-        let sizes = [data.len() as u32, body.len() as u32];
-        self.out.extend(0x0403_4b50u32.to_le_bytes());
-        self.out.extend([20, 0, 0, 0, 8, 0]);
-        self.out.extend([0; 8]);
-        sizes.iter().for_each(|s| self.out.extend(s.to_le_bytes()));
-        self.out.extend((name.len() as u16).to_le_bytes());
-        self.out.extend([0; 2]);
-        self.out.extend(name.as_bytes());
-        self.out.extend(&data);
-        self.central.extend(0x0201_4b50u32.to_le_bytes());
-        self.central.extend([20, 0, 20, 0, 0, 0, 8, 0]);
-        self.central.extend([0; 8]);
-        sizes
-            .iter()
-            .for_each(|s| self.central.extend(s.to_le_bytes()));
-        self.central.extend((name.len() as u16).to_le_bytes());
-        self.central.extend([0; 12]);
-        self.central.extend(offset.to_le_bytes());
-        self.central.extend(name.as_bytes());
-        self.count = self.count.checked_add(1).expect("too many zip entries");
-    }
-    fn finish(mut self, path: &Path) {
-        let start = self.out.len() as u32;
-        self.out.extend(&self.central);
-        self.out.extend(0x0605_4b50u32.to_le_bytes());
-        self.out.extend([0; 4]);
-        self.out.extend(self.count.to_le_bytes());
-        self.out.extend(self.count.to_le_bytes());
-        self.out.extend((self.central.len() as u32).to_le_bytes());
-        self.out.extend(start.to_le_bytes());
-        self.out.extend([0; 2]);
-        fs::write(path, self.out).unwrap();
-    }
-}
-
-const META: &[u8] = br#"{"pack":{"description":"bench","min_format":[69,0],"max_format":[999,0]}}"#;
-
-/// The stand-in game resources: vanilla-sized texture folders, models and the stacked JSON
-/// files (lang, sounds, fonts, atlases) every reload merges.
-fn vanilla(root: &Path, scale: usize, noise: &mut Noise) -> Vec<String> {
-    let mut blocks = Vec::new();
-    for i in 0..1100 * scale {
-        let name = format!("block/b{i}");
-        let frames = if i % 50 == 0 { 8 } else { 1 };
-        write(
-            root,
-            &format!("assets/minecraft/textures/{name}.png"),
-            &png(noise, 16, frames, i % 7 == 0),
-        );
-        if frames > 1 {
-            write(
-                root,
-                &format!("assets/minecraft/textures/{name}.png.mcmeta"),
-                br#"{"animation":{"frametime":2}}"#,
-            );
-        }
-        write(
-            root,
-            &format!("assets/minecraft/models/block/b{i}.json"),
-            &model(noise, "minecraft", &name),
-        );
-        blocks.push(format!("minecraft:{name}"));
-    }
-    for (folder, count, side) in [("item", 1500, 16), ("entity", 900, 64), ("gui", 800, 16)] {
-        for i in 0..count * scale {
-            let sub = if folder == "gui" { "sprites/" } else { "" };
-            write(
-                root,
-                &format!(
-                    "assets/minecraft/textures/{folder}/{sub}{}/t{i}.png",
-                    i % 20
-                ),
-                &png(noise, side, 1, true),
-            );
-        }
-    }
-    for i in 0..1500 * scale {
-        write(
-            root,
-            &format!("assets/minecraft/models/item/i{i}.json"),
-            &model(noise, "minecraft", &format!("item/{}/t{i}", i % 20)),
-        );
-    }
-    let lang: String = (0..4000)
-        .map(|i| format!("\"key.{i}\":\"Value {i}\""))
-        .collect::<Vec<_>>()
-        .join(",");
-    write(
-        root,
-        "assets/minecraft/lang/en_us.json",
-        format!("{{{lang}}}").as_bytes(),
-    );
-    write(
-        root,
-        "assets/minecraft/sounds.json",
-        br#"{"a":{"sounds":["a"]}}"#,
-    );
-    write(
-        root,
-        "assets/minecraft/atlases/blocks.json",
-        br#"{"sources":[{"type":"directory","source":"block","prefix":"block/"}]}"#,
-    );
-    write(root, "pack.mcmeta", META);
-    blocks
-}
-
-/// A server pack the way ItemsAdder-style plugins make them: one zip of many namespaces, each
-/// with its own items' textures and models, its sounds and its lang files.
-fn server_zip(path: &Path, scale: usize, noise: &mut Noise) {
-    let mut zip = ZipOut::default();
-    zip.put("pack.mcmeta", META);
-    for n in 0..190 {
-        let ns = format!("plugin{n}");
-        for i in 0..50 * scale {
-            let texture = format!("item/{}/t{i}", i % 5);
-            zip.put(
-                &format!("assets/{ns}/textures/{texture}.png"),
-                &png(noise, 32, 1, true),
-            );
-            zip.put(
-                &format!("assets/{ns}/models/item/{}/m{i}.json", i % 5),
-                &model(noise, &ns, &texture),
-            );
-            if i % 10 == 0 {
-                zip.put(&format!("assets/{ns}/sounds/s{i}.ogg"), &[0; 2048]);
-            }
-        }
-        zip.put(
-            &format!("assets/{ns}/lang/en_us.json"),
-            br#"{"item.custom":"Custom"}"#,
-        );
-    }
-    let lang: String = (0..2000)
-        .map(|i| format!("\"server.{i}\":\"Server {i}\""))
-        .collect::<Vec<_>>()
-        .join(",");
-    zip.put(
-        "assets/minecraft/lang/en_us.json",
-        format!("{{{lang}}}").as_bytes(),
-    );
-    zip.finish(path);
-}
-
-/// A 64x pack over vanilla's own block, item and entity textures, with OptiFine CTM-style
-/// tiles beside them: what the big OptiFine packs look like on disk.
-fn hd_zip(path: &Path, scale: usize, noise: &mut Noise) {
-    let mut zip = ZipOut::default();
-    zip.put("pack.mcmeta", META);
-    for i in 0..1100 * scale {
-        zip.put(
-            &format!("assets/minecraft/textures/block/b{i}.png"),
-            &png(noise, 64, 1, i % 7 == 0),
-        );
-        if i % 4 == 0 {
-            for tile in 0..12 {
-                zip.put(
-                    &format!("assets/minecraft/optifine/ctm/b{i}/{tile}.png"),
-                    &png(noise, 64, 1, false),
-                );
-            }
-            zip.put(
-                &format!("assets/minecraft/optifine/ctm/b{i}/b{i}.properties"),
-                format!("matchTiles=b{i}\nmethod=ctm\ntiles=0-11\n").as_bytes(),
-            );
-        }
-    }
-    for i in 0..750 * scale {
-        zip.put(
-            &format!("assets/minecraft/textures/item/{}/t{i}.png", i % 20),
-            &png(noise, 64, 1, true),
-        );
-    }
-    zip.finish(path);
-}
-
-fn median(mut ms: Vec<f64>) -> f64 {
-    ms.sort_by(f64::total_cmp);
-    ms[ms.len() / 2]
-}
-
-/// `f`'s median time over `runs`, with `before` (not timed) ahead of each run.
-fn time(runs: usize, mut before: impl FnMut(), mut f: impl FnMut()) -> f64 {
-    median(
-        (0..runs)
-            .map(|_| {
-                before();
-                let started = Instant::now();
-                f();
-                started.elapsed().as_secs_f64() * 1000.0
-            })
-            .collect(),
-    )
-}
-
-fn zip_pack(id: &str, path: PathBuf) -> Pack {
-    // Read the way `packs::folder` reads a `resourcepacks/` zip.
-    let dir = path.parent().unwrap().join(format!("{id}-dir"));
-    fs::create_dir_all(&dir).unwrap();
-    let at = dir.join(path.file_name().unwrap());
-    fs::rename(&path, &at).unwrap();
-    packs::folder(&dir, packs::RESOURCE_FORMAT)
-        .into_iter()
-        .next()
-        .unwrap_or_else(|| panic!("{id} is not a pack"))
-}
-
-fn main() {
-    let args: Vec<String> = std::env::args().collect();
-    let scale = args
-        .iter()
-        .position(|a| a == "--scale")
-        .and_then(|i| args.get(i + 1))
-        .map_or(1, |s| s.parse().unwrap());
-    let runs = 3;
-    let scratch = std::env::temp_dir().join(format!("horizon-pack-bench-{}", std::process::id()));
-    let _ = fs::remove_dir_all(&scratch);
-    fs::create_dir_all(&scratch).unwrap();
-    let mut noise = Noise(0x9e37_79b9_7f4a_7c15);
-    let vanilla_root = scratch.join("vanilla");
-    let blocks = vanilla(&vanilla_root, scale, &mut noise);
-    server_zip(&scratch.join("server.zip"), scale, &mut noise);
-    hd_zip(&scratch.join("hd.zip"), scale, &mut noise);
-    let server = zip_pack("server", scratch.join("server.zip"));
-    let hd = zip_pack("hd", scratch.join("hd.zip"));
-    let cache = scratch.join("cache");
-    let both = [hd.clone(), server.clone()];
-
-    let mut rows: Vec<(String, f64)> = Vec::new();
-    let mut row = |name: &str, ms: f64| {
-        eprintln!("{name}: {ms:.1} ms");
-        rows.push((name.to_owned(), ms));
-    };
-    let fresh = || {
-        let _ = fs::remove_dir_all(&cache);
-    };
-    row(
-        "overlay: build, both packs (cold)",
-        time(runs, fresh, || {
-            packs::resource_root(&vanilla_root, &both, &cache).unwrap();
-        }),
-    );
-    let root = packs::resource_root(&vanilla_root, &both, &cache).unwrap();
-    row(
-        "overlay: reuse, both packs (cache hit)",
-        time(
-            runs,
-            || {},
-            || {
-                packs::resource_root(&vanilla_root, &both, &cache).unwrap();
-            },
-        ),
-    );
-    // The pack screen: one pack turned off, then on again.
-    row(
-        "overlay: toggle the server pack off (new selection)",
-        time(
-            runs,
-            || {
-                let only =
-                    packs::resource_root(&vanilla_root, std::slice::from_ref(&hd), &cache).unwrap();
-                fs::remove_dir_all(&only).unwrap();
-            },
-            || {
-                packs::resource_root(&vanilla_root, std::slice::from_ref(&hd), &cache).unwrap();
-            },
-        ),
-    );
-    row(
-        "models: parse every model",
-        time(
-            runs,
-            || {},
-            || {
-                std::hint::black_box(ParsedModels::load(&root));
-            },
-        ),
-    );
-    let sprite_cache = root.join("horizon-sprites.cache");
-    // OptiFine connected-texture tiles, inserted by their path as `ConnectedTextures` does.
-    let tiles: Vec<String> = (0..1100 * scale)
-        .step_by(4)
-        .flat_map(|i| (0..12).map(move |t| format!("assets/minecraft/optifine/ctm/b{i}/{t}.png")))
-        .collect();
-    let sprites = |cold: bool, prefetch: bool, names: &[String], files: bool| {
-        time(
-            runs,
-            || {
-                if cold {
-                    let _ = fs::remove_file(&sprite_cache);
-                }
-            },
-            || {
-                let mut sprites = Sprites::with_disk_cache(&root);
-                if prefetch {
-                    sprites.prefetch(&root, names.iter().map(String::as_str));
-                }
-                for name in names {
-                    if files {
-                        sprites.insert_file(&root, name).unwrap();
-                    } else {
-                        sprites.insert(&root, name).unwrap();
-                    }
-                }
-                sprites.save_disk_cache();
-                sprites.finish();
-                std::hint::black_box(&sprites.pixels);
-            },
-        )
-    };
-    row(
-        "block sprites: one by one (no cache)",
-        sprites(true, false, &blocks, false),
-    );
-    row(
-        "block sprites: prefetched (no cache)",
-        sprites(true, true, &blocks, false),
-    );
-    row(
-        "block sprites: from the disk cache",
-        sprites(false, false, &blocks, false),
-    );
-    row("CTM tiles: one by one", sprites(false, false, &tiles, true));
-    row("CTM tiles: prefetched", sprites(false, true, &tiles, true));
-    row(
-        "GUI atlas: decode and stitch, both packs",
-        time(
-            runs,
-            || {},
-            || {
-                if let Err(e) = HudAtlas::build_over(&root, &vanilla_root) {
-                    eprintln!("GUI atlas failed: {e}");
-                }
-            },
-        ),
-    );
-    row(
-        "GUI atlas: vanilla alone",
-        time(
-            runs,
-            || {},
-            || {
-                let _ = HudAtlas::build(&vanilla_root);
-            },
-        ),
-    );
-
-    let cores = std::thread::available_parallelism().map_or(1, |n| n.get());
-    println!("| Stage (scale {scale}, {cores} threads, median of {runs}) | ms |");
-    println!("|---|---:|");
-    for (name, ms) in &rows {
-        println!("| {name} | {ms:.0} |");
-    }
-    let _ = fs::remove_dir_all(&scratch);
-}

crates/horizon-client-render/src/assets.rs

@@ -93,18 +93,9 @@ pub struct RenderAssets {
     pub model_gallery: Vec<Value>,
     pub animations: Vec<crate::sprites::SpriteAnimation>,
     pub sprite_layers: std::collections::BTreeMap<String, u32>,
-    /// OptiFine's emissive block overlays: base sprite and overlay sprite names.
-    pub emissive: Vec<(String, String)>,
     pub translucent_layers: Vec<bool>,
     /// Each layer's `MipmapGenerator` settings.
     pub sprite_mips: Vec<crate::mipmap::Settings>,
-    /// The resource packs' LabPBR maps (normals, specular), layer by layer at `pbr_size`:
-    /// empty when they ship none.
-    pub pbr_normals: Vec<u8>,
-    pub pbr_specular: Vec<u8>,
-    pub pbr_size: u32,
-    /// OptiFine connected textures (empty without `optifine/ctm` files).
-    pub connected: crate::connected::ConnectedTextures,
 }
 fn invalid(message: &str) -> io::Error {
     io::Error::new(io::ErrorKind::InvalidData, message)
@@ -201,8 +192,8 @@ impl Assets {
     pub fn reload(&self, root: &Path) -> Result<RenderAssets> {
         RenderAssets::load(root, self)
     }
-    /// [`Assets::reload`] for a server, which draws nothing: the sprites'
-    /// layers, without the block or item models or the textures' pixels.
+    /// [`Assets::reload`] for a server, which draws nothing: the models and
+    /// the sprites' layers, without the textures' pixels.
     pub fn reload_for_server(&self, root: &Path) -> Result<RenderAssets> {
         RenderAssets::load_with(root, self, false)
     }
@@ -211,24 +202,14 @@ impl RenderAssets {
     pub fn load(root: &Path, assets: &Assets) -> Result<Self> {
         Self::load_with(root, assets, true)
     }
-    fn load_with(root: &Path, assets: &Assets, draws: bool) -> Result<Self> {
+    fn load_with(root: &Path, assets: &Assets, pixels: bool) -> Result<Self> {
         let registry = assets.registry;
         let mut sprites = crate::sprites::Sprites::with_disk_cache(root);
         for name in MATERIALS {
             sprites.insert(root, &format!("minecraft:block/{name}"))?;
         }
-        // A server draws no block and no item: its block models (about 24 MB
-        // baked) and item model library (7 MB) stay empty.
-        let parsed = if draws {
-            crate::model_library::ParsedModels::load(root)
-        } else {
-            crate::model_library::ParsedModels::default()
-        };
-        let models = if draws {
-            crate::models::prepare_with_models(root, registry, &mut sprites, &parsed)?
-        } else {
-            crate::models::PreparedModels::default()
-        };
+        let parsed = crate::model_library::ParsedModels::load(root);
+        let models = crate::models::prepare_with_models(root, registry, &mut sprites, &parsed)?;
         let model_library = parsed.into_item_library();
         // Fluids are drawn by the fluid renderer, not block models; breaking
         // progress uses the destroy-stage overlays.
@@ -244,42 +225,8 @@ impl RenderAssets {
         for stage in 0..10 {
             sprites.insert(root, &format!("minecraft:block/destroy_stage_{stage}"))?;
         }
-        let mut emissive = Vec::new();
-        let connected = if draws {
-            crate::native_emissive::load(root, &mut sprites);
-            // A side's sprite, for rules that connect by tile: the first quad facing it.
-            let catalog = &models.catalog;
-            let mut found = Vec::new();
-            crate::connected::ConnectedTextures::load(
-                root,
-                registry,
-                &mut sprites,
-                |state, face| {
-                    let side = horizon_assets::model::Direction::ALL[face as usize];
-                    catalog
-                        .models_at(
-                            state,
-                            horizon_core::position::BlockPos::new(0, 0, 0),
-                            &mut found,
-                        )
-                        .ok()?;
-                    found
-                        .iter()
-                        .flat_map(|m| &m.faces)
-                        .find(|f| f.quad.facing == side)
-                        .map(|f| f.layer)
-                },
-            )
-        } else {
-            Default::default()
-        };
-        // After the connected tiles: a tile identical to a block shares its layer, and the
-        // overlays skip shared layers.
-        if draws {
-            emissive = crate::native_emissive::load_optifine(root, &mut sprites);
-        }
         sprites.save_disk_cache();
-        if draws {
+        if pixels {
             sprites.finish();
         } else {
             sprites.finish_without_pixels();
@@ -297,13 +244,8 @@ impl RenderAssets {
             model_gallery: models.states,
             animations: sprites.animations,
             sprite_layers: sprites.layers,
-            emissive,
             translucent_layers: sprites.translucent,
             sprite_mips: sprites.mips,
-            pbr_normals: sprites.normals,
-            pbr_specular: sprites.specular,
-            pbr_size: sprites.pbr_size,
-            connected,
         })
     }
 }

crates/horizon-client-render/src/atlas_sources.rs

@@ -208,26 +208,10 @@ pub fn list_textures(root: &Path) -> Vec<String> {
     out.sort();
     out
 }
-/// The file of a texture identifier. A Custom Item Textures id (`cit_assets`) names its
-/// resource path, wherever the folder: `directory` is not used for it. An id whose path would
-/// leave the root (a pack's model may write any) names a file that is never there.
+/// The file of a texture identifier.
 pub fn texture_path(root: &Path, texture: &str, directory: &str) -> PathBuf {
-    // No file can have a NUL in its name, so this one is never there.
-    const NOWHERE: &str = "assets/minecraft/textures/horizon/\0refused.png";
-    if texture.starts_with("horizon_cit:") {
-        return root.join(
-            crate::cit_assets::resource(texture, "png")
-                .as_deref()
-                .unwrap_or(NOWHERE),
-        );
-    }
     let (namespace, path) = texture.split_once(':').unwrap_or(("minecraft", texture));
-    let rel = format!("assets/{namespace}/{directory}/{path}.png");
-    root.join(if horizon_optifine::paths::valid(&rel) {
-        &rel
-    } else {
-        NOWHERE
-    })
+    root.join(format!("assets/{namespace}/{directory}/{path}.png"))
 }
 
 /// `SpriteSourceList.list`: every sprite id of the atlas and its origin.

crates/horizon-client-render/src/audio.rs

@@ -39,12 +39,6 @@ struct Channel {
     looping: bool,
     at: [f32; 3],
     relative: bool,
-    /// Whose sounds these are: 0 the game's, another splitscreen player's (`Audio::share`).
-    owner: u8,
-    /// Its world (`Mixer::world_id`; 0 none).
-    world: u32,
-    /// The sound file it started and when, to tell another player's copy of it.
-    started: Option<(String, std::time::Instant)>,
 }
 #[derive(Default)]
 struct Mixer {
@@ -52,37 +46,7 @@ struct Mixer {
     listener: [f64; 3],
     listener_yaw: f32,
     listener_pitch: f32,
-    /// Splitscreen: the other players' cameras (position, yaw, pitch) by owner. A world sound is
-    /// heard from the nearest camera, and panned half as wide while several share the speakers.
-    listeners: HashMap<u8, ([f64; 3], f32, f32)>,
-    /// Each camera's world by owner, as ids: the callback compares and copies integers.
-    worlds: HashMap<u8, u32>,
-    /// World names by id - 1 (`world_id`).
-    world_names: Vec<String>,
-    /// The callback's cameras (position, basis, world), kept to be refilled without allocating.
-    cameras: Vec<([f64; 3], Basis, u32)>,
     limiter_peak: f32,
-    /// The output device the stream was opened on (`Library.currentDeviceName`).
-    #[cfg(feature = "audio")]
-    device_name: String,
-    /// The stream reported its device gone (`Library.isCurrentDeviceDisconnected`).
-    #[cfg(feature = "audio")]
-    device_lost: bool,
-}
-/// A camera's forward, up and right vectors.
-type Basis = ([f64; 3], [f64; 3], [f64; 3]);
-impl Mixer {
-    /// The id of world `name` (1 and up), given once per name.
-    fn world_id(&mut self, name: &str) -> u32 {
-        let i = match self.world_names.iter().position(|w| w == name) {
-            Some(i) => i,
-            None => {
-                self.world_names.push(name.to_owned());
-                self.world_names.len() - 1
-            }
-        };
-        i as u32 + 1
-    }
 }
 /// A sound the player could have heard (`SoundEventListener.onPlaySound`):
 /// what the subtitle overlay needs.
@@ -105,34 +69,7 @@ pub struct MixerBackend {
     decoder: Option<std::sync::mpsc::Sender<Decode>>,
     next: ChannelId,
     live: bool,
-    /// Whose channels these are (`Channel::owner`).
-    owner: u8,
-    world: u32,
-    /// How many other players share this output: alone, a sound never looks for its copy.
-    shares: Arc<std::sync::atomic::AtomicUsize>,
 }
-/// A splitscreen player's backend leaving: its camera and sounds go with it.
-impl Drop for MixerBackend {
-    fn drop(&mut self) {
-        if self.owner == 0 {
-            return;
-        }
-        self.shares
-            .fetch_sub(1, std::sync::atomic::Ordering::Relaxed);
-        if let Ok(mut m) = self.mixer.lock() {
-            m.listeners.remove(&self.owner);
-            m.worlds.remove(&self.owner);
-            let owner = self.owner;
-            m.channels.retain(|_, c| c.owner != owner);
-        }
-    }
-}
-/// Splitscreen: each shared backend's channel ids start at a block of their own, never handed out
-/// again, so a player in a seat used before never reuses an id a departed one's decoder may
-/// still attach to. The game's own backend counts from 0, as before.
-static SHARED_CHANNELS: std::sync::atomic::AtomicU64 = std::sync::atomic::AtomicU64::new(0);
-/// Two players' copies of one sound: started within this of each other.
-const SAME_SOUND: std::time::Duration = std::time::Duration::from_millis(150);
 /// Decoded samples and their rate (`None`: the file did not load).
 type Samples = Option<(Arc<Vec<f32>>, u32)>;
 /// Decoded static sounds (`SoundBufferLibrary`'s buffers), dropped least
@@ -228,22 +165,6 @@ pub struct Audio {
     /// How many times each selection was stopped ("record *", "* minecraft:…", `*` for
     /// any), with or without an audio device, as `heard`.
     pub stopped: std::collections::BTreeMap<String, u32>,
-    /// The volume sliders' `SoundPreviewHandler`.
-    preview: crate::sound_preview::SoundPreview,
-    /// `SoundEngine.lastSeenDevices`: the system default output last seen.
-    #[cfg(feature = "audio")]
-    default_seen: Option<String>,
-    /// The ALSA cards (Linux) or Core Audio devices (macOS) last seen: listing
-    /// the output devices probes every one, so it waits for these to change
-    /// (`card_fingerprint`).
-    #[cfg(feature = "audio")]
-    cards_seen: Option<String>,
-    /// The other half of `lastSeenDevices`: every output device last seen.
-    #[cfg(feature = "audio")]
-    devices_seen: Vec<String>,
-    /// Ticks since the output devices were last looked at (`DeviceTracker.tick`).
-    #[cfg(feature = "audio")]
-    device_ticks: u32,
 }
 fn decode(path: &Path) -> Option<(Vec<f32>, u32)> {
     use symphonia::core::{
@@ -287,59 +208,7 @@ fn decode(path: &Path) -> Option<(Vec<f32>, u32)> {
     }
     Some((mono, rate))
 }
-/// A sound file without its variant number (`mob/creeper/say2.ogg` is `mob/creeper/say`): each
-/// player's game picks its own variant of the same event.
-// ponytail: variants named by a trailing number, as vanilla's are; the event name if a pack breaks it.
-fn variantless(key: &str) -> &str {
-    key.trim_end_matches(".ogg")
-        .trim_end_matches(|c: char| c.is_ascii_digit())
-}
 impl MixerBackend {
-    /// Splitscreen: another player's game started this same sound here just now (both clients
-    /// heard it); this copy stays stopped, the first is heard from the nearest camera.
-    ///
-    /// A copy is recognised only by its file (without the variant), world, place and time: the
-    /// games pick variants on their own and play many sounds client-side (steps, digging), so
-    /// nothing marks two copies of one event. Two different events alike in all four (two
-    /// players' steps on grass, side by side, within 150 ms) are heard once. That is accepted:
-    /// at that distance and timing they sound like one; a doubled sound is the louder fault.
-    fn duplicate(&self, channel: ChannelId, (namespace, path): (&str, &str)) -> bool {
-        // Alone: nobody else's copy, and no lock taken for it.
-        if self.shares.load(std::sync::atomic::Ordering::Relaxed) == 0 {
-            return false;
-        }
-        let Ok(mut m) = self.mixer.lock() else {
-            return false;
-        };
-        // Alone (no other player's camera), or a sound by the listener (a click, music): its own.
-        let Some(c) = m.channels.get(&channel).filter(|c| !c.relative) else {
-            return false;
-        };
-        if m.listeners.is_empty() {
-            return false;
-        }
-        let key = format!("{namespace}:{path}");
-        let key = variantless(&key);
-        let at = c.at;
-        let world = c.world;
-        let twin = m.channels.values().any(|o| {
-            o.owner != self.owner
-                && o.world == world
-                && !o.relative
-                && o.started
-                    .as_ref()
-                    .is_some_and(|(k, t)| k == key && t.elapsed() < SAME_SOUND)
-                && (0..3).map(|i| (o.at[i] - at[i]).powi(2)).sum::<f32>() < 4.0
-        });
-        if let Some(c) = m.channels.get_mut(&channel) {
-            if twin {
-                c.state = State::Stopped;
-            } else {
-                c.started = Some((key.to_owned(), std::time::Instant::now()));
-            }
-        }
-        twin
-    }
     fn with(&self, channel: ChannelId, f: impl FnOnce(&mut Channel)) {
         if let Ok(mut m) = self.mixer.lock()
             && let Some(c) = m.channels.get_mut(&channel)
@@ -364,9 +233,6 @@ impl Backend for MixerBackend {
                 looping: false,
                 at: [0.0; 3],
                 relative: false,
-                owner: self.owner,
-                world: self.world,
-                started: None,
             },
         );
         Some(id)
@@ -404,10 +270,6 @@ impl Backend for MixerBackend {
         }
         let (namespace, path) = sound.path();
         let file = self.root.join("assets").join(namespace).join(&path);
-        // A looping sound follows its entity in one client's tracking only: each keeps its own.
-        if !looping && self.duplicate(channel, (namespace, &path)) {
-            return;
-        }
         if sound.stream {
             // A streamed sound loops by restarting its stream.
             let mixer = self.mixer.clone();
@@ -516,50 +378,28 @@ fn distance_gain(linear: Option<f32>, distance: f32) -> f32 {
 #[cfg_attr(not(feature = "audio"), allow(dead_code))]
 fn mix(mixer: &mut Mixer, data: &mut [f32], channels: usize, rate: u32) {
     data.fill(0.0);
+    let listener = mixer.listener;
     // The camera's forward and up vectors (`Camera.forwardVector`/`upVector`)
     // and OpenAL's right = forward x up.
-    let basis = |yaw: f32, pitch: f32| {
-        let (yaw, pitch) = (f64::from(yaw.to_radians()), f64::from(pitch.to_radians()));
-        let forward = [
-            -yaw.sin() * pitch.cos(),
-            -pitch.sin(),
-            yaw.cos() * pitch.cos(),
-        ];
-        let up = [
-            -yaw.sin() * pitch.sin(),
-            pitch.cos(),
-            yaw.cos() * pitch.sin(),
-        ];
-        let right = [
-            forward[1] * up[2] - forward[2] * up[1],
-            forward[2] * up[0] - forward[0] * up[2],
-            forward[0] * up[1] - forward[1] * up[0],
-        ];
-        (forward, up, right)
-    };
-    // Every camera hearing (splitscreen: the other players' too), in the mixer's own buffer.
-    let mut cameras = std::mem::take(&mut mixer.cameras);
-    cameras.clear();
-    cameras.extend(
-        std::iter::once((
-            0,
-            (mixer.listener, mixer.listener_yaw, mixer.listener_pitch),
-        ))
-        .chain(
-            mixer
-                .listeners
-                .iter()
-                .map(|(&owner, &camera)| (owner, camera)),
-        )
-        .map(|(owner, (at, yaw, pitch))| {
-            (
-                at,
-                basis(yaw, pitch),
-                mixer.worlds.get(&owner).copied().unwrap_or_default(),
-            )
-        }),
+    let (yaw, pitch) = (
+        f64::from(mixer.listener_yaw.to_radians()),
+        f64::from(mixer.listener_pitch.to_radians()),
     );
-    let shared = cameras.len() > 1;
+    let forward = [
+        -yaw.sin() * pitch.cos(),
+        -pitch.sin(),
+        yaw.cos() * pitch.cos(),
+    ];
+    let up = [
+        -yaw.sin() * pitch.sin(),
+        pitch.cos(),
+        yaw.cos() * pitch.sin(),
+    ];
+    let right = [
+        forward[1] * up[2] - forward[2] * up[1],
+        forward[2] * up[0] - forward[0] * up[2],
+        forward[0] * up[1] - forward[1] * up[0],
+    ];
     let dot = |a: [f64; 3], b: [f64; 3]| (a[0] * b[0] + a[1] * b[1] + a[2] * b[2]) as f32;
     // Gains and pans per source for this buffer.
     let mut voices: Vec<(ChannelId, [f32; 3], f64)> = Vec::new();
@@ -570,48 +410,27 @@ fn mix(mixer: &mut Mixer, data: &mut [f32], channels: usize, rate: u32) {
         if c.state != State::Playing {
             continue;
         }
-        let at = [f64::from(c.at[0]), f64::from(c.at[1]), f64::from(c.at[2])];
-        let away = |listener: [f64; 3]| {
+        let d = if c.relative {
+            [f64::from(c.at[0]), f64::from(c.at[1]), f64::from(c.at[2])]
+        } else {
             [
-                at[0] - listener[0],
-                at[1] - listener[1],
-                at[2] - listener[2],
+                f64::from(c.at[0]) - listener[0],
+                f64::from(c.at[1]) - listener[1],
+                f64::from(c.at[2]) - listener[2],
             ]
         };
-        let length = |d: [f64; 3]| d[0] * d[0] + d[1] * d[1] + d[2] * d[2];
-        // The nearest camera hears it (one camera but in splitscreen).
-        let camera = cameras
-            .iter()
-            .filter(|camera| c.relative || camera.2 == c.world)
-            .min_by(|a, b| length(away(a.0)).total_cmp(&length(away(b.0))))
-            .map(|camera| (camera.0, camera.1));
-        // Unheard sources still advance: returning to a world must not resume stale sounds.
-        let (listener, (forward, up, right)) = camera.unwrap_or(([0.0; 3], basis(0.0, 0.0)));
-        let d = if c.relative { at } else { away(listener) };
         let distance = (d[0] * d[0] + d[1] * d[1] + d[2] * d[2]).sqrt() as f32;
-        let gain = if camera.is_some() {
-            c.gain.clamp(0.0, 1.0) * distance_gain(c.linear, distance)
-        } else {
-            0.0
-        };
+        let gain = c.gain.clamp(0.0, 1.0) * distance_gain(c.linear, distance);
         // Relative sources are already in OpenAL's listener space (-Z ahead).
-        let [mut left, mut right] = if c.relative {
+        let [left, right] = if c.relative {
             stereo_gains(d[0] as f32, d[1] as f32, -d[2] as f32)
         } else {
             stereo_gains(dot(d, right), dot(d, up), dot(d, forward))
-        };
-        if shared {
-            // Several players on the speakers: half the stereo width, as left and right are
-            // nobody's in particular.
-            let middle = (left + right) / 2.0;
-            left = middle + (left - middle) / 2.0;
-            right = middle + (right - middle) / 2.0;
         }
-        let [left, right] = [left, right].map(|pan| gain * pan);
+        .map(|pan| gain * pan);
         let step = f64::from(*source_rate) / f64::from(rate) * f64::from(c.pitch.max(0.0));
         voices.push((*id, [left, right, gain], step));
     }
-    mixer.cameras = cameras;
     for (id, [left, right, gain], step) in voices {
         let Some(c) = mixer.channels.get_mut(&id) else {
             continue;
@@ -685,96 +504,19 @@ fn open_device(
     use cpal::SampleFormat as F;
     let config = device.default_output_config()?;
     let stream = match config.sample_format() {
-        F::F32 => build_stream::<f32>(device, &config, mixer.clone()),
-        F::F64 => build_stream::<f64>(device, &config, mixer.clone()),
-        F::I16 => build_stream::<i16>(device, &config, mixer.clone()),
-        F::I32 => build_stream::<i32>(device, &config, mixer.clone()),
-        F::I8 => build_stream::<i8>(device, &config, mixer.clone()),
-        F::U16 => build_stream::<u16>(device, &config, mixer.clone()),
-        F::U32 => build_stream::<u32>(device, &config, mixer.clone()),
-        F::U8 => build_stream::<u8>(device, &config, mixer.clone()),
+        F::F32 => build_stream::<f32>(device, &config, mixer),
+        F::F64 => build_stream::<f64>(device, &config, mixer),
+        F::I16 => build_stream::<i16>(device, &config, mixer),
+        F::I32 => build_stream::<i32>(device, &config, mixer),
+        F::I8 => build_stream::<i8>(device, &config, mixer),
+        F::U16 => build_stream::<u16>(device, &config, mixer),
+        F::U32 => build_stream::<u32>(device, &config, mixer),
+        F::U8 => build_stream::<u8>(device, &config, mixer),
         other => Err(format!("unsupported sample format {other}").into()),
     }?;
     stream.play()?;
-    if let Ok(mut m) = mixer.lock() {
-        m.device_name = device.name().unwrap_or_default();
-        m.device_lost = false;
-    }
     Ok((stream, config))
 }
-/// Try one output device for `open`: skip it when it was already tried, log it
-/// when it opens, and keep its error when it does not.
-#[cfg(feature = "audio")]
-fn try_open_device(
-    device: &cpal::Device,
-    mixer: Arc<Mutex<Mixer>>,
-    tried: &mut Vec<String>,
-    errors: &mut Vec<String>,
-) -> Option<cpal::Stream> {
-    let name = device.name().unwrap_or_else(|_| "unnamed device".into());
-    if tried.contains(&name) {
-        return None;
-    }
-    tried.push(name.clone());
-    match open_device(device, mixer) {
-        Ok((stream, config)) => {
-            log::info!(
-                "Horizon: audio output {name} ({} Hz, {} channels, {})",
-                config.sample_rate().0,
-                config.channels(),
-                config.sample_format()
-            );
-            Some(stream)
-        }
-        Err(e) => {
-            errors.push(format!("{name}: {e}"));
-            None
-        }
-    }
-}
-/// The name of the system's default output device.
-#[cfg(feature = "audio")]
-fn default_output_name() -> Option<String> {
-    cpal::default_host()
-        .default_output_device()
-        .and_then(|d| d.name().ok())
-}
-/// A cheap fingerprint of what `output_devices` can list. On Linux, the ALSA
-/// cards: the rest are `cpal`'s fixed names. On macOS, every Core Audio
-/// device's name, inputs included: telling which of them play opens each one
-/// (about 90 ms a second with twenty devices), naming them takes 2 or 3 ms.
-/// `None` elsewhere, where the list is always looked at.
-#[cfg(feature = "audio")]
-fn card_fingerprint() -> Option<String> {
-    #[cfg(target_os = "linux")]
-    {
-        std::fs::read_to_string("/proc/asound/cards").ok()
-    }
-    #[cfg(target_os = "macos")]
-    {
-        let devices = cpal::default_host().devices().ok()?;
-        Some(
-            devices
-                .filter_map(|d| d.name().ok())
-                .collect::<Vec<_>>()
-                .join("\n"),
-        )
-    }
-    #[cfg(not(any(target_os = "linux", target_os = "macos")))]
-    {
-        None
-    }
-}
-/// Whether the output device list should be looked at again: only the ALSA
-/// cards can add or remove an entry, and `None` means there is no fingerprint,
-/// so the list has to be checked as before.
-#[cfg(any(feature = "audio", test))]
-fn cards_changed(seen: Option<&str>, cards: Option<&str>) -> bool {
-    match (seen, cards) {
-        (Some(seen), Some(cards)) => seen != cards,
-        _ => true,
-    }
-}
 #[cfg(feature = "audio")]
 fn build_stream<T: cpal::SizedSample + cpal::FromSample<f32>>(
     device: &cpal::Device,
@@ -784,7 +526,6 @@ fn build_stream<T: cpal::SizedSample + cpal::FromSample<f32>>(
     let rate = config.sample_rate().0;
     let channels = config.channels() as usize;
     let mut scratch = Vec::new();
-    let on_error = mixer.clone();
     let stream = device.build_output_stream(
         &config.config(),
         move |data: &mut [T], _| {
@@ -798,14 +539,7 @@ fn build_stream<T: cpal::SizedSample + cpal::FromSample<f32>>(
                 *out = T::from_sample(*s);
             }
         },
-        move |e| {
-            log::warn!("Horizon: audio stream error: {e}");
-            if matches!(e, cpal::StreamError::DeviceNotAvailable)
-                && let Ok(mut m) = on_error.lock()
-            {
-                m.device_lost = true;
-            }
-        },
+        |e| log::warn!("Horizon: audio stream error: {e}"),
         None,
     )?;
     Ok(stream)
@@ -879,17 +613,6 @@ impl Audio {
         };
         let mut engine = SoundEngine::new(registry);
         engine.loaded = live;
-        #[cfg(feature = "audio")]
-        let cards = if live { card_fingerprint() } else { None };
-        // Where the cards gate the list (Linux, macOS), it starts empty: opening the
-        // output does not need it, and listing it probes every device; the first
-        // change fills it. Elsewhere it starts with every device listed, as before.
-        #[cfg(feature = "audio")]
-        let devices = if live && cards.is_none() {
-            output_devices()
-        } else {
-            Vec::new()
-        };
         Self {
             _stream: stream,
             device_name: target_device.to_owned(),
@@ -901,9 +624,6 @@ impl Audio {
                 decoder: None,
                 next: 0,
                 live,
-                owner: 0,
-                world: 0,
-                shares: Arc::default(),
             },
             record_heard: false,
             listener: [0.0; 3],
@@ -914,15 +634,6 @@ impl Audio {
             capture: None,
             heard: Default::default(),
             stopped: Default::default(),
-            preview: Default::default(),
-            #[cfg(feature = "audio")]
-            default_seen: if live { default_output_name() } else { None },
-            #[cfg(feature = "audio")]
-            cards_seen: cards,
-            #[cfg(feature = "audio")]
-            devices_seen: devices,
-            #[cfg(feature = "audio")]
-            device_ticks: 0,
         }
     }
     #[cfg(not(feature = "audio"))]
@@ -987,20 +698,29 @@ impl Audio {
         }
         let host = cpal::default_host();
         let mut errors = Vec::new();
-        // The default device first: it is what plays, and listing the others
-        // probes every PCM, which is slow and prints ALSA's errors for the
-        // plugins this system lacks.
+        // The default device first, then any other output a host lists:
+        // a default that cannot open (busy, or a stale ALSA default) should
+        // not leave the game silent when another device works.
+        let default = host.default_output_device();
+        let others = host.output_devices().into_iter().flatten();
         let mut tried = Vec::new();
-        if let Some(device) = host.default_output_device()
-            && let Some(stream) = try_open_device(&device, mixer.clone(), &mut tried, &mut errors)
-        {
-            return Ok(stream);
-        }
-        // A default that cannot open (busy, or a stale ALSA default) should not
-        // leave the game silent when another device works.
-        for device in host.output_devices().into_iter().flatten() {
-            if let Some(stream) = try_open_device(&device, mixer.clone(), &mut tried, &mut errors) {
-                return Ok(stream);
+        for device in default.into_iter().chain(others) {
+            let name = device.name().unwrap_or_else(|_| "unnamed device".into());
+            if tried.contains(&name) {
+                continue;
+            }
+            tried.push(name.clone());
+            match open_device(&device, mixer.clone()) {
+                Ok((stream, config)) => {
+                    log::info!(
+                        "Horizon: audio output {name} ({} Hz, {} channels, {})",
+                        config.sample_rate().0,
+                        config.channels(),
+                        config.sample_format()
+                    );
+                    return Ok(stream);
+                }
+                Err(e) => errors.push(format!("{name}: {e}")),
             }
         }
         if errors.is_empty() {
@@ -1014,75 +734,15 @@ impl Audio {
             backend: &mut self.backend,
         }
     }
-    /// World identity for this player's sources and camera. Existing channels keep their world.
-    pub fn set_world(&mut self, world: &str) {
-        if let Ok(mut mixer) = self.backend.mixer.lock() {
-            let id = mixer.world_id(world);
-            self.backend.world = id;
-            mixer.worlds.insert(self.backend.owner, id);
-        }
-    }
-
     /// `SoundManager.updateSource`: the camera position and rotation
     /// (`Listener.setTransform` takes its forward and up vectors).
     pub fn set_listener(&mut self, position: [f64; 3], yaw: f32, pitch: f32) {
         self.listener = position;
         self.listener_yaw = yaw;
         if let Ok(mut m) = self.backend.mixer.lock() {
-            if self.backend.owner == 0 {
-                m.listener = position;
-                m.listener_yaw = yaw;
-                m.listener_pitch = pitch;
-            } else {
-                m.listeners
-                    .insert(self.backend.owner, (position, yaw, pitch));
-            }
-        }
-    }
-    /// Splitscreen: another player's sounds on this output, heard from its camera too
-    /// (`owner`: 1 to 255, its own). Dropped, its camera and sounds go.
-    pub fn share(&self, owner: u8) -> Self {
-        assert_ne!(owner, 0, "shared audio owners must be nonzero");
-        self.backend
-            .shares
-            .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
-        let mut engine = SoundEngine::new(self.engine.registry.clone());
-        engine.loaded = self.backend.live;
-        Self {
-            _stream: None,
-            device_name: self.device_name.clone(),
-            engine,
-            backend: MixerBackend {
-                mixer: self.backend.mixer.clone(),
-                root: self.backend.root.clone(),
-                cache: self.backend.cache.clone(),
-                decoder: None,
-                next: (SHARED_CHANNELS.fetch_add(1, std::sync::atomic::Ordering::Relaxed) + 1)
-                    << 40,
-                live: self.backend.live,
-                owner,
-                world: self.backend.world,
-                shares: self.backend.shares.clone(),
-            },
-            record_heard: false,
-            listener: [0.0; 3],
-            listener_yaw: 0.0,
-            master: self.master,
-            random: LegacyRandom::new(crate::sound_engine::unique_seed()),
-            source_override: None,
-            capture: None,
-            heard: Default::default(),
-            stopped: Default::default(),
-            preview: Default::default(),
-            // The device belongs to the first player's output, which looks after it.
-            #[cfg(feature = "audio")]
-            default_seen: self.default_seen.clone(),
-            #[cfg(feature = "audio")]
-            cards_seen: self.cards_seen.clone(),
-            #[cfg(feature = "audio")]
-            devices_seen: self.devices_seen.clone(),
-            #[cfg(feature = "audio")]
-            device_ticks: 0,
+            m.listener = position;
+            m.listener_yaw = yaw;
+            m.listener_pitch = pitch;
         }
     }
     /// Sync the volume options, refreshing the categories that changed
@@ -1101,93 +761,11 @@ impl Audio {
         }
         self.engine.listening = self.record_heard;
     }
-    /// `SoundEngine.shouldChangeDevice`: the open device was lost, the system
-    /// default changed (with no device chosen in the options), or the chosen
-    /// device came back; the output is then opened again. The devices are looked
-    /// at once a second.
-    #[cfg(feature = "audio")]
-    fn should_change_device(&mut self) -> bool {
-        // A splitscreen share plays through the first player's output: it leaves the device,
-        // and the mixer's lost flag, to that output.
-        if self.backend.owner != 0 {
-            return false;
-        }
-        let (current, lost) = match self.backend.mixer.lock() {
-            Ok(mut m) => (m.device_name.clone(), std::mem::take(&mut m.device_lost)),
-            Err(_) => return false,
-        };
-        if lost {
-            log::info!("Horizon: audio device was lost");
-            self.default_seen = default_output_name();
-            self.cards_seen = card_fingerprint();
-            self.devices_seen = output_devices();
-            return true;
-        }
-        self.device_ticks += 1;
-        if self._stream.is_none() || self.device_ticks < 20 {
-            return false;
-        }
-        self.device_ticks = 0;
-        let default = default_output_name();
-        let cards = card_fingerprint();
-        // Listing the devices probes every one (on Linux every built-in PCM,
-        // printing ALSA's errors for the plugins this system lacks; on macOS
-        // every Core Audio device, about 90 ms with twenty of them); only the
-        // fingerprint's devices can change the list, and it is cheap.
-        if default == self.default_seen
-            && !cards_changed(self.cards_seen.as_deref(), cards.as_deref())
-        {
-            return false;
-        }
-        self.cards_seen = cards;
-        let devices = output_devices();
-        // Only a change in the device lists is looked at, as in vanilla: a
-        // preferred device that is listed but cannot open is not retried.
-        if default == self.default_seen && devices == self.devices_seen {
-            return false;
-        }
-        self.default_seen = default.clone();
-        let wanted = self.device_name.clone();
-        let available = devices.contains(&wanted);
-        self.devices_seen = devices;
-        if wanted.is_empty() {
-            let changed = default.as_deref().is_some_and(|d| d != current);
-            if changed {
-                log::info!("Horizon: system default audio device has changed");
-            }
-            return changed;
-        }
-        let changed = current != wanted && available;
-        if changed {
-            log::info!("Horizon: preferred audio device has become available");
-        }
-        changed
-    }
     /// `SoundManager.tick(paused)`, once per client tick.
     pub fn tick(&mut self, paused: bool, ctx: &TickContext) {
-        #[cfg(feature = "audio")]
-        {
-            if self.should_change_device() {
-                // SoundEngine.reload: stop every sound, open the output again.
-                self.stop_all();
-                let device = self.device_name.clone();
-                if let Err(e) = self.set_device(&device) {
-                    log::warn!("Horizon: could not reopen the audio output: {e}");
-                }
-            }
-        }
         self.sync_volumes();
         self.engine.tick(paused, ctx, &mut self.backend);
     }
-    /// The `uiSoundReserve` extra: positional sounds leave
-    /// `sound_engine::HEARD_RESERVE` static channels free (off: vanilla's pool).
-    pub fn set_listener_reserve(&mut self, on: bool) {
-        self.engine.listener_reserve = if on {
-            crate::sound_engine::HEARD_RESERVE
-        } else {
-            0
-        };
-    }
     /// `SoundManager.pauseAllExcept(MUSIC, UI)`.
     pub fn pause(&mut self) {
         self.engine.pause_all_except(
@@ -1220,47 +798,6 @@ impl Audio {
         let seed = self.random.next_long();
         self.play_seeded(event, at, volume, pitch, seed);
     }
-    /// `ClientLevel.playLocalSound` with `distanceDelay`: a sound more than 10
-    /// blocks from the camera starts `sqrt(distance) / 40` seconds later.
-    pub fn play_distance_delayed(
-        &mut self,
-        event: &str,
-        at: [f64; 3],
-        volume: f32,
-        pitch: f32,
-        camera: [f64; 3],
-    ) {
-        let distance_sqr: f64 = (0..3).map(|i| (at[i] - camera[i]).powi(2)).sum();
-        if distance_sqr <= 100.0 {
-            self.play(event, Some(at), volume, pitch);
-            return;
-        }
-        self.play_after(
-            event,
-            at,
-            volume,
-            pitch,
-            (distance_sqr.sqrt() / 40.0 * 20.0) as i32,
-        );
-    }
-    /// `play` at a world position, starting `ticks` sound-engine ticks (20 a
-    /// second) from now: `SoundEngine.playDelayed`.
-    pub fn play_after(&mut self, event: &str, at: [f64; 3], volume: f32, pitch: f32, ticks: i32) {
-        let seed = self.random.next_long();
-        if let Some(capture) = self.capture.as_mut() {
-            capture.push((event.to_owned(), at, volume, pitch));
-        }
-        *self.heard.entry(event.to_owned()).or_default() += 1;
-        self.sync_volumes();
-        let event = crate::sound_events::normalize(event);
-        let source = self
-            .source_override
-            .unwrap_or_else(|| crate::settings::sound_source(&event));
-        let instance =
-            SoundInstance::at(&event, source, volume, pitch, LegacyRandom::new(seed), at);
-        let id = self.engine.add(instance, false);
-        self.engine.play_delayed(id, ticks);
-    }
     /// `play` for this client only: a sound a packet's handler plays
     /// (`playLocalSound`), which the guests play from that packet themselves.
     pub fn play_unshared(&mut self, event: &str, at: Option<[f64; 3]>, volume: f32, pitch: f32) {
@@ -1280,13 +817,6 @@ impl Audio {
             false,
         );
     }
-    /// `SoundPreviewHandler.preview`: a category volume slider moved to
-    /// `volume` on the title screen's options.
-    pub fn preview(&mut self, source: usize, volume: f32) {
-        let mut preview = std::mem::take(&mut self.preview);
-        preview.preview(self, source, volume);
-        self.preview = preview;
-    }
     /// `play` with the seed a sound packet carries.
     pub fn play_seeded(
         &mut self,
@@ -1355,13 +885,6 @@ impl Audio {
         self.stop_instance(id);
         self.release(id);
     }
-    /// `SoundBufferLibrary.enumerate`: the decoded buffers kept and their bytes.
-    pub fn cache_stats(&self) -> (usize, usize) {
-        self.backend
-            .cache
-            .lock()
-            .map_or((0, 0), |c| (c.entries.len(), c.bytes))
-    }
     /// Every sound event id (for command completion).
     /// The engine's table sizes and the mixer's channels (`status`).
     pub fn census(&self) -> serde_json::Value {
@@ -1480,9 +1003,6 @@ mod tests {
             looping,
             at,
             relative: false,
-            owner: 0,
-            world: 0,
-            started: None,
         }
     }
 
@@ -1640,185 +1160,6 @@ mod tests {
         assert!(close(gains(0.0, 90.0, [0.0, 0.0, 1.0]), [0.5, 0.5]));
     }
 
-    #[test]
-    fn splitscreen_sounds_are_heard_from_the_nearest_camera() {
-        // P1 far away, a second player beside the source: heard at full gain, centred.
-        let mut m = Mixer {
-            listener: [100.0, 0.0, 0.0],
-            ..Mixer::default()
-        };
-        m.listeners.insert(1, ([0.0, 0.0, 1.0], 0.0, 0.0));
-        m.channels
-            .insert(1, channel(vec![1.0; 4], Some(16.0), [0.0, 0.0, 2.0], true));
-        let mut data = [0.0; 2];
-        mix(&mut m, &mut data, 2, 48_000);
-        assert!(
-            data[0] > 0.5 && (data[0] - data[1]).abs() < 1e-4,
-            "{data:?}"
-        );
-        // Alone, P1 would not hear it: 100 blocks past its 16.
-        m.listeners.clear();
-        let mut data = [0.0; 2];
-        mix(&mut m, &mut data, 2, 48_000);
-        assert_eq!(data, [0.0; 2]);
-    }
-
-    #[test]
-    fn a_shared_listener_registers_even_in_the_hosts_world() {
-        let mut host = Audio::silent(Path::new("/nonexistent/horizon-test-audio"));
-        host.set_world("minecraft:overworld");
-        let mut guest = host.share(1);
-        guest.set_world("minecraft:overworld");
-        guest.set_listener([1.0, 2.0, 3.0], 0.0, 0.0);
-        let id = guest.backend.create(false).unwrap();
-        let mixer = host.backend.mixer.lock().unwrap();
-        let overworld = mixer
-            .world_names
-            .iter()
-            .position(|w| w == "minecraft:overworld");
-        let overworld = overworld.map(|i| i as u32 + 1);
-        assert_eq!(mixer.worlds.get(&1).copied(), overworld);
-        assert_eq!(Some(mixer.channels[&id].world), overworld);
-    }
-
-    #[test]
-    fn cameras_in_other_dimensions_cannot_hear_a_source() {
-        let mut m = Mixer {
-            listener: [100.0, 0.0, 0.0],
-            ..Default::default()
-        };
-        m.listeners.insert(1, ([0.0, 0.0, 1.0], 0.0, 0.0));
-        let nether = m.world_id("nether");
-        m.worlds.insert(1, nether);
-        m.channels
-            .insert(1, channel(vec![1.0; 4], Some(16.0), [0.0, 0.0, 2.0], true));
-        let mut data = [0.0; 2];
-        mix(&mut m, &mut data, 2, 48_000);
-        assert_eq!(
-            data, [0.0; 2],
-            "nearby Nether camera must not hear Overworld source"
-        );
-        m.channels.get_mut(&1).unwrap().world = nether;
-        mix(&mut m, &mut data, 2, 48_000);
-        assert!(data[0] > 0.5, "same-world camera must hear source");
-        let end = m.world_id("end");
-        m.worlds.insert(1, end);
-        data.fill(0.0);
-        mix(&mut m, &mut data, 2, 48_000);
-        assert_eq!(data, [0.0; 2], "no listener remains in source's world");
-    }
-
-    #[test]
-    fn sounds_in_a_world_without_listeners_finish_while_inaudible() {
-        let mut mixer = Mixer::default();
-        let mut source = channel(vec![1.0; 4], None, [0.0; 3], false);
-        let nether = mixer.world_id("nether");
-        source.world = nether;
-        mixer.channels.insert(1, source);
-        let mut data = [0.0; 4];
-        mix(&mut mixer, &mut data, 2, 48_000);
-        assert_eq!(data, [0.0; 4]);
-        assert!(mixer.channels[&1].position > 0.0);
-        mix(&mut mixer, &mut data, 2, 48_000);
-        assert_eq!(mixer.channels[&1].state, State::Stopped);
-        mixer.worlds.insert(0, nether);
-        mix(&mut mixer, &mut data, 2, 48_000);
-        assert_eq!(data, [0.0; 4], "returning must not resume the old one-shot");
-    }
-
-    #[test]
-    fn variants_of_one_sound_are_the_same_sound() {
-        assert_eq!(
-            variantless("minecraft:mob/creeper/say1.ogg"),
-            "minecraft:mob/creeper/say"
-        );
-        assert_eq!(
-            variantless("minecraft:step/grass6.ogg"),
-            "minecraft:step/grass"
-        );
-        assert_eq!(
-            variantless("minecraft:random/click.ogg"),
-            "minecraft:random/click"
-        );
-    }
-
-    #[test]
-    fn another_players_copy_of_a_sound_is_dropped() {
-        let mixer = Arc::new(Mutex::new(Mixer::default()));
-        // One other player shares the output.
-        let shares = Arc::new(std::sync::atomic::AtomicUsize::new(1));
-        let backend = |owner| MixerBackend {
-            mixer: mixer.clone(),
-            root: PathBuf::new(),
-            cache: Arc::default(),
-            decoder: None,
-            next: (u64::from(owner)) << 40,
-            live: true,
-            owner,
-            world: 0,
-            shares: shares.clone(),
-        };
-        let (mut p1, mut p2) = (backend(0), backend(1));
-        // P2 is listening (its camera is in the mixer), so two players share the speakers.
-        mixer
-            .lock()
-            .unwrap()
-            .listeners
-            .insert(1, ([0.0; 3], 0.0, 0.0));
-        let started = |b: &mut MixerBackend, at: [f64; 3]| {
-            let id = b.create(false).unwrap();
-            b.set_position(id, at);
-            !b.duplicate(id, ("minecraft", "mob/creeper/say1.ogg"))
-        };
-        assert!(started(&mut p1, [5.0, 64.0, 5.0]));
-        // P2's client got the same sound at the same place: one copy plays.
-        assert!(!started(&mut p2, [5.2, 64.0, 5.0]));
-        // Elsewhere, or P1's own second one, it is a sound of its own.
-        assert!(started(&mut p2, [40.0, 64.0, 5.0]));
-        assert!(started(&mut p1, [5.0, 64.0, 5.0]));
-        // Equal coordinates in another dimension describe a different sound.
-        p2.world = mixer.lock().unwrap().world_id("nether");
-        assert!(started(&mut p2, [5.0, 64.0, 5.0]));
-        // P2 leaving takes its sounds.
-        drop(p2);
-        assert!(
-            mixer
-                .lock()
-                .unwrap()
-                .channels
-                .values()
-                .all(|c| c.owner == 0)
-        );
-    }
-
-    #[test]
-    fn reusing_a_seat_does_not_reuse_its_channels_or_leave_its_camera() {
-        let host = Audio::silent(Path::new("/nonexistent/horizon-test-audio"));
-        let mut guest = host.share(1);
-        guest.set_world("overworld");
-        guest.set_listener([1.0, 0.0, 0.0], 0.0, 0.0);
-        let old = guest.backend.create(false).unwrap();
-        drop(guest);
-        {
-            let mixer = host.backend.mixer.lock().unwrap();
-            assert!(!mixer.channels.contains_key(&old));
-            assert!(!mixer.listeners.contains_key(&1));
-            assert!(!mixer.worlds.contains_key(&1));
-        }
-        let mut replacement = host.share(1);
-        let new = replacement.backend.create(false).unwrap();
-        assert_ne!(old, new);
-        assert!(
-            replacement
-                .backend
-                .mixer
-                .lock()
-                .unwrap()
-                .channels
-                .contains_key(&new)
-        );
-    }
-
     #[test]
     fn a_mono_output_plays_sources_unpanned() {
         let mut m = Mixer::default();
@@ -1828,15 +1169,4 @@ mod tests {
         mix(&mut m, &mut data, 1, 48_000);
         assert_eq!(data, [0.5; 2]);
     }
-
-    #[test]
-    fn output_devices_are_looked_at_again_only_when_the_cards_change() {
-        // No fingerprint (not Linux, or the cards could not be read): the list
-        // has to be looked at as before.
-        assert!(cards_changed(None, None));
-        assert!(cards_changed(Some("0 [PCH ]"), None));
-        // The same cards list the same devices; a card added or removed does not.
-        assert!(!cards_changed(Some("0 [PCH ]"), Some("0 [PCH ]")));
-        assert!(cards_changed(Some("0 [PCH ]"), Some("0 [PCH ]\n 1 [USB ]")));
-    }
 }

crates/horizon-client-render/src/auth.rs

@@ -52,20 +52,20 @@ impl AuthSession {
     /// The session file's JSON: {"name", "uuid", "access_token", "user_type": "msa", "xuid"}.
     pub fn parse(text: &str) -> Result<Self, String> {
         let v: serde_json::Value =
-            serde_json::from_str(text).map_err(|_| "the session is not valid JSON")?;
+            serde_json::from_str(text).map_err(|_| "the session file is not valid JSON")?;
         let field = |k: &str| v.get(k).and_then(|s| s.as_str());
-        let name = field("name").ok_or("the session has no name")?;
+        let name = field("name").ok_or("the session file has no name")?;
         if name.is_empty() || name.chars().count() > 16 {
-            return Err("the session's name is not a valid player name".into());
+            return Err("the session file's name is not a valid player name".into());
         }
         let uuid = field("uuid")
             .and_then(parse_uuid)
-            .ok_or("the session has no valid uuid")?;
+            .ok_or("the session file has no valid uuid")?;
         let access_token = field("access_token")
             .filter(|t| !t.is_empty())
-            .ok_or("the session has no access token")?;
+            .ok_or("the session file has no access token")?;
         if field("user_type").is_some_and(|t| t != "msa") {
-            return Err("the session is not a Microsoft account session".into());
+            return Err("the session file is not a Microsoft account session".into());
         }
         Ok(Self {
             name: name.to_owned(),
@@ -203,46 +203,6 @@ pub fn endpoint(doc: &serde_json::Value, service: &str, name: &str) -> Option<St
         .map(str::to_owned)
 }
 
-/// `Minecraft`'s constructor futures for the title screen: `UserApiService.fetchProperties`
-/// (the `player` service's `getAttributes`, with the bearer token) and
-/// `SessionService.fetchProfile(uuid, true)` (`getProfileById`). A failed
-/// attributes call falls back to the offline properties, a failed profile call
-/// to no actions, as vanilla does. Blocks: call it off the main thread.
-pub fn fetch_account_status(session: &AuthSession) -> crate::ban_notice::AccountStatus {
-    use crate::ban_notice::{AccountStatus, parse_profile_actions, parse_properties};
-    let Ok(doc) = discovery() else {
-        return AccountStatus::default();
-    };
-    let properties = endpoint(&doc, "player", "getAttributes")
-        .and_then(|url| {
-            agent()
-                .get(&url)
-                .set("Authorization", &format!("Bearer {}", session.access_token))
-                .call()
-                .ok()?
-                .into_string()
-                .ok()
-        })
-        .and_then(|body| parse_properties(&body))
-        .unwrap_or_default();
-    let actions = endpoint(&doc, "session", "getProfileById")
-        .and_then(|url| {
-            let url = url.replace("{profileId}", &format!("{:032x}", session.uuid));
-            agent()
-                .get(&format!("{url}?unsigned=true"))
-                .call()
-                .ok()?
-                .into_string()
-                .ok()
-        })
-        .map(|body| parse_profile_actions(&body))
-        .unwrap_or_default();
-    AccountStatus {
-        properties,
-        actions,
-    }
-}
-
 /// The JoinMinecraftServerRequest body; `selectedProfile` is the undashed UUID.
 pub fn join_request(session: &AuthSession, server_hash: &str) -> String {
     serde_json::json!({
@@ -272,211 +232,6 @@ pub fn join_server(session: &AuthSession, server_hash: &str) -> Result<(), JoinE
     }
 }
 
-/// The account's chat key pair (ProfileKeyPair): the private key that signs
-/// its chat, the public key with the services' signature over it, and when
-/// to fetch a new one (refreshedAfter, epoch milliseconds). Like the access
-/// token it stays in memory: vanilla's profilekeys file is never written.
-pub struct ChatKeyPair {
-    pub private: horizon_protocol::rsa::RsaPrivateKey,
-    pub public: horizon_protocol::secure_chat::ProfileKey,
-    pub refreshed_after: i64,
-}
-impl std::fmt::Debug for ChatKeyPair {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        f.debug_struct("ChatKeyPair")
-            .field("expires_at", &self.public.expires_at)
-            .field("refreshed_after", &self.refreshed_after)
-            .finish_non_exhaustive()
-    }
-}
-impl ChatKeyPair {
-    /// ProfileKeyPair.dueRefresh.
-    pub fn due_refresh(&self, now: i64) -> bool {
-        self.refreshed_after < now
-    }
-}
-
-/// Epoch milliseconds now.
-pub fn now_millis() -> i64 {
-    SystemTime::now()
-        .duration_since(SystemTime::UNIX_EPOCH)
-        .map_or(0, |d| d.as_millis() as i64)
-}
-
-/// Instant.parse for the services' UTC times
-/// (`2022-07-30T23:05:24.548227Z`): epoch milliseconds.
-pub fn parse_instant(text: &str) -> Option<i64> {
-    let text = text.strip_suffix('Z')?;
-    let (date, time) = text.split_once('T')?;
-    let mut date = date.splitn(3, '-').map(|p| p.parse::<i64>().ok());
-    let (y, m, d) = (date.next()??, date.next()??, date.next()??);
-    let (hms, fraction) = time.split_once('.').unwrap_or((time, ""));
-    let mut hms = hms.splitn(3, ':').map(|p| p.parse::<i64>().ok());
-    let (h, min, s) = (hms.next()??, hms.next()??, hms.next()??);
-    if !(1..=12).contains(&m) || !(1..=31).contains(&d) || h > 23 || min > 59 || s > 60 {
-        return None;
-    }
-    if !fraction.bytes().all(|b| b.is_ascii_digit()) {
-        return None;
-    }
-    let millis = format!("{fraction:0<3}")[..3].parse::<i64>().ok()?;
-    // Days from 1970-01-01 (Howard Hinnant's days_from_civil).
-    let y = if m <= 2 { y - 1 } else { y };
-    let era = y.div_euclid(400);
-    let yoe = y - era * 400;
-    let doy = (153 * (m + if m > 2 { -3 } else { 9 }) + 2) / 5 + d - 1;
-    let doe = yoe * 365 + yoe / 4 - yoe / 100 + doy;
-    let days = era * 146_097 + doe - 719_468;
-    Some(((days * 24 + h) * 60 + min) * 60_000 + s * 1000 + millis)
-}
-
-/// Crypt.stringToPemRsaPrivateKey / stringToRsaPublicKey: the base64
-/// between a PEM block's armour lines.
-fn pem_der(pem: &str) -> Option<Vec<u8>> {
-    let body: String = pem
-        .lines()
-        .filter(|l| !l.starts_with("-----"))
-        .flat_map(|l| l.chars().filter(|c| !c.is_whitespace()))
-        .collect();
-    crate::skins::base64_decode(&body)
-}
-
-/// KeyPairResponse from the certificates endpoint, as
-/// AccountProfileKeyPairManager.fetchProfileKeyPair reads it: the PEM key
-/// pair, publicKeySignatureV2 (the signature over the profile id too),
-/// expiresAt and refreshedAfter. None for anything malformed, or a private
-/// key that isn't the public key's other half.
-pub fn parse_certificates(body: &str) -> Option<ChatKeyPair> {
-    use horizon_protocol::rsa::{RsaPrivateKey, RsaPublicKey};
-    let v: serde_json::Value = serde_json::from_str(body).ok()?;
-    let field = |path: &str| v.pointer(path).and_then(|s| s.as_str());
-    let private = RsaPrivateKey::from_der(&pem_der(field("/keyPair/privateKey")?)?).ok()?;
-    let key = pem_der(field("/keyPair/publicKey")?)?;
-    if RsaPublicKey::from_der(&key).ok()? != private.public {
-        return None;
-    }
-    let signature = crate::skins::base64_decode(field("/publicKeySignatureV2")?)?;
-    Some(ChatKeyPair {
-        private,
-        public: horizon_protocol::secure_chat::ProfileKey {
-            expires_at: parse_instant(field("/expiresAt")?)?,
-            key,
-            signature,
-        },
-        refreshed_after: parse_instant(field("/refreshedAfter")?)?,
-    })
-}
-
-/// UserApiService.getKeyPair: the certificates endpoint, POSTed with the
-/// access token.
-pub fn fetch_chat_keys(session: &AuthSession) -> Result<ChatKeyPair, JoinError> {
-    let doc = discovery()?;
-    let url = endpoint(&doc, "player", "getCertificates").ok_or(JoinError::Unavailable)?;
-    let body = match agent()
-        .post(&url)
-        .set("Authorization", &format!("Bearer {}", session.access_token))
-        .set("Content-Type", "application/json; charset=utf-8")
-        .send_string("")
-    {
-        Ok(response) => response.into_string().unwrap_or_default(),
-        Err(ureq::Error::Status(status, response)) => {
-            return Err(JoinError::from_response(
-                status,
-                &response.into_string().unwrap_or_default(),
-            ));
-        }
-        Err(ureq::Error::Transport(_)) => return Err(JoinError::Unavailable),
-    };
-    parse_certificates(&body)
-        .ok_or_else(|| JoinError::Other("Malformed profile key pair response".to_owned()))
-}
-
-/// AccountProfileKeyPairManager.MINIMUM_PROFILE_KEY_REFRESH_INTERVAL.
-const KEY_RETRY: Duration = Duration::from_secs(60 * 60);
-
-/// The chat key pair as AccountProfileKeyPairManager keeps it: fetched on a
-/// background thread, kept until it is due a refresh, and on a failure kept
-/// as it was (the next try waits an hour, or the next join).
-#[derive(Default)]
-struct ChatKeys {
-    current: Option<Arc<ChatKeyPair>>,
-    fetching: bool,
-    next_try: Option<std::time::Instant>,
-}
-static CHAT_KEYS: Mutex<ChatKeys> = Mutex::new(ChatKeys {
-    current: None,
-    fetching: false,
-    next_try: None,
-});
-
-/// prepareKeyPair (`now`: on a join) or, from a tick, shouldRefreshKeyPair
-/// then prepareKeyPair: start fetching when there is no key pair or it is
-/// due a refresh. Nothing without a signed-in account.
-pub fn prepare_chat_keys(now: bool) {
-    let Some(session) = current() else {
-        return;
-    };
-    let mut keys = CHAT_KEYS.lock().unwrap();
-    let instant = std::time::Instant::now();
-    if keys.fetching || !now && keys.next_try.is_some_and(|t| instant < t) {
-        return;
-    }
-    keys.next_try = Some(instant + KEY_RETRY);
-    if keys
-        .current
-        .as_ref()
-        .is_some_and(|k| !k.due_refresh(now_millis()))
-    {
-        return;
-    }
-    keys.fetching = true;
-    drop(keys);
-    let spawned = std::thread::Builder::new()
-        .name("Profile key fetch".into())
-        .spawn(move || {
-            let result = fetch_chat_keys(&session);
-            let mut keys = CHAT_KEYS.lock().unwrap();
-            keys.fetching = false;
-            match result {
-                Ok(pair) => keys.current = Some(Arc::new(pair)),
-                Err(e) => log::error!("Failed to retrieve profile key pair: {e:?}"),
-            }
-        });
-    if spawned.is_err() {
-        CHAT_KEYS.lock().unwrap().fetching = false;
-    }
-}
-
-/// The chat key pair fetched so far, unless it has expired.
-pub fn chat_keys() -> Option<Arc<ChatKeyPair>> {
-    let now = now_millis();
-    CHAT_KEYS
-        .lock()
-        .unwrap()
-        .current
-        .clone()
-        .filter(|k| !k.public.has_expired(now))
-}
-
-const MINECRAFT_PROFILE: &str = "https://api.minecraftservices.com/minecraft/profile";
-
-/// The signed-in account's active skin and cape from `GET /minecraft/profile`.
-/// Single-player and integrated servers often send no `textures` property, or
-/// one without the equipped cape; the client asks the profile endpoint once.
-pub fn own_textures(session: &AuthSession) -> Option<crate::skins::Textures> {
-    let response = agent()
-        .get(MINECRAFT_PROFILE)
-        .set("Authorization", &format!("Bearer {}", session.access_token))
-        .call()
-        .ok()?;
-    if response.status() != 200 {
-        return None;
-    }
-    let body = response.into_string().ok()?;
-    let profile: serde_json::Value = serde_json::from_str(&body).ok()?;
-    Some(crate::skins::services_profile_textures(&profile))
-}
-
 /// What the session service says about a player joining this server
 /// (MinecraftServicesSessionService.hasJoinedServer).
 #[derive(Clone, Debug, PartialEq)]
@@ -671,104 +426,6 @@ mod tests {
         );
     }
 
-    #[test]
-    fn instants_like_java() {
-        assert_eq!(parse_instant("1970-01-01T00:00:00Z"), Some(0));
-        assert_eq!(parse_instant("1970-01-01T00:00:01.5Z"), Some(1500));
-        // Instant.parse("2022-07-30T23:05:24.548227Z").toEpochMilli().
-        assert_eq!(
-            parse_instant("2022-07-30T23:05:24.548227Z"),
-            Some(1_659_222_324_548)
-        );
-        assert_eq!(
-            parse_instant("2024-02-29T12:00:00Z"),
-            Some(1_709_208_000_000)
-        );
-        assert_eq!(parse_instant("1969-12-31T23:59:59Z"), Some(-1000));
-        for bad in [
-            "2022-07-30T23:05:24",
-            "2022-13-01T00:00:00Z",
-            "2022-07-30 23:05:24Z",
-            "2022-07-30T23:05:24.5x1Z",
-            "",
-        ] {
-            assert_eq!(parse_instant(bad), None, "{bad}");
-        }
-    }
-
-    /// A throwaway 1024-bit key (`openssl genrsa`, PKCS#8 as the services
-    /// send it under "RSA PRIVATE KEY") and its public half.
-    const PRIVATE_B64: &str = "MIICdQIBADANBgkqhkiG9w0BAQEFAASCAl8wggJbAgEAAoGBAKSDqaLOF2Ltt4tzWblkFeNYhdss67BhXTbOMUYjpcPdtf4dzNtgZsTf4WEluvc8pItGWChdpq3xzPC9GL4PZ+Oh1o6VR/wSm20/50QT7V+YcSP1VrVKjDpDSg/UoC1Fmdc/vb9AO8Ip7TxuRYd/uyog/ThQ8aGcWtvvtwPqx4XrAgMBAAECgYA+ZGy2gQDflRZSPeoeZHXkphMF/7BXUWW/vk1zs1tPwEsgV/70iEgRjHL2nA+fapFg/Mm8bWAkghrehmjW1BLq5w8sGdGJCHfE/kauu78jJK0/ME38e9bsSEvv5HMMxyx0mlV8DQu2pzCT71ceT8VD/1pewUbpeZypj5pxtsCIMQJBANXgca/mnAQXTuowI8FqMiald6OuAcAWbOaNrCB5HHWuxH7hFatSqGrgp4YLqHv7bzeodU1y/uxwc+/01khd0rMCQQDE6mPfIdZxHhWkMUAKhMEnrLanfCL0dfyAe+lBpqgPwO3UurCfCaFX5RdYB3fCyvgy5foHN1/I8/Eobp+enrvpAkBgkZnjeXWiZz/Lf/b1AtUoG/g8IHpL2BRNuVQpyWVvQX0ZaNoW5BiFQXCClsr5SBr8f4SPdsfhzBidFOiX/jz/AkBDuk6Bd3T3UR6ma54YQBLjX38vWf330QD4/CV9RCH30Sa8DT4kZT6OKah+yYrCf+cgMoNtqfkS9/xRKMNT3krJAkAaFrAT6HF5Y9b5OLASbbFe7MZ4zNCzuEl6plKNUi+JCHESaU/VCCuYOLoWLeSDFYkZUoSmqiRxH8fVTsBz393x";
-    const PUBLIC_B64: &str = "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCkg6mizhdi7beLc1m5ZBXjWIXbLOuwYV02zjFGI6XD3bX+HczbYGbE3+FhJbr3PKSLRlgoXaat8czwvRi+D2fjodaOlUf8EpttP+dEE+1fmHEj9Va1Sow6Q0oP1KAtRZnXP72/QDvCKe08bkWHf7sqIP04UPGhnFrb77cD6seF6wIDAQAB";
-
-    fn pem(label: &str, b64: &str) -> String {
-        let lines: Vec<&str> = b64
-            .as_bytes()
-            .chunks(76)
-            .map(|c| std::str::from_utf8(c).unwrap())
-            .collect();
-        format!(
-            "-----BEGIN {label}-----\n{}\n-----END {label}-----\n",
-            lines.join("\n")
-        )
-    }
-
-    fn certificates(private: &str, public: &str) -> String {
-        serde_json::json!({
-            "keyPair": {
-                "privateKey": pem("RSA PRIVATE KEY", private),
-                "publicKey": pem("RSA PUBLIC KEY", public),
-            },
-            "publicKeySignature": "djE=",
-            "publicKeySignatureV2": "c2ln",
-            "expiresAt": "2022-07-30T23:05:24.548227Z",
-            "refreshedAfter": "2022-07-30T15:05:24.548227Z",
-        })
-        .to_string()
-    }
-
-    #[test]
-    fn certificates_response() {
-        let pair = parse_certificates(&certificates(PRIVATE_B64, PUBLIC_B64)).unwrap();
-        assert_eq!(
-            pair.public.key,
-            crate::skins::base64_decode(PUBLIC_B64).unwrap()
-        );
-        assert_eq!(pair.public.signature, b"sig", "publicKeySignatureV2");
-        assert_eq!(pair.public.expires_at, 1_659_222_324_548);
-        assert_eq!(pair.refreshed_after, 1_659_193_524_548);
-        assert_eq!(pair.private.public_der(), pair.public.key);
-        assert!(pair.due_refresh(1_659_193_524_549));
-        assert!(!pair.due_refresh(1_659_193_524_548));
-        assert!(!format!("{pair:?}").contains("MII"));
-        // A public key that isn't the private key's, and broken fields.
-        let other = horizon_protocol::rsa::RsaPrivateKey::generate(1024).unwrap();
-        let other = base64(&other.public_der());
-        assert!(parse_certificates(&certificates(PRIVATE_B64, &other)).is_none());
-        assert!(parse_certificates(&certificates("bm9wZQ==", PUBLIC_B64)).is_none());
-        assert!(parse_certificates("{}").is_none());
-        assert!(parse_certificates("").is_none());
-    }
-
-    fn base64(bytes: &[u8]) -> String {
-        const A: &[u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
-        let mut out = String::new();
-        for c in bytes.chunks(3) {
-            let n = c
-                .iter()
-                .enumerate()
-                .fold(0u32, |n, (i, &b)| n | u32::from(b) << (16 - 8 * i));
-            for i in 0..4 {
-                out.push(if i <= c.len() {
-                    char::from(A[(n >> (18 - 6 * i) & 63) as usize])
-                } else {
-                    '='
-                });
-            }
-        }
-        out
-    }
-
     #[test]
     fn discovery_endpoints() {
         let doc = serde_json::json!({"discovery": {"session": {"endpoints": {"join": {"uri": "https://s/join"}}}}});

crates/horizon-client-render/src/ban_notice.rs

@@ -1,373 +0,0 @@
-//! The ban notices `Gui.addInitialScreens` queues before the title screen:
-//! `Minecraft.multiplayerBan()` (the account's MULTIPLAYER ban from the services
-//! attributes call), the forced name change and the banned skin
-//! (`ProfileResult.actions()`), and the text `BanNoticeScreens` shows for each.
-//! The network calls are in `auth.rs`; this file parses what they return.
-use crate::text::Text;
-
-/// `CommonLinks.SUSPENSION_HELP`.
-pub const SUSPENSION_HELP: &str = "https://aka.ms/mcjavamoderation";
-
-/// authlib's `BanDetails` (the id is never shown).
-#[derive(Clone, Debug, PartialEq, Eq)]
-pub struct BanDetails {
-    /// Epoch milliseconds the ban ends; `None` is permanent.
-    pub expires_ms: Option<i64>,
-    pub reason: Option<String>,
-    pub reason_message: Option<String>,
-}
-
-/// authlib's `UserProperties`, as far as the title screen reads it.
-#[derive(Clone, Debug, PartialEq, Eq)]
-pub struct UserProperties {
-    /// `UserFlag.SERVERS_ALLOWED` (`privileges.multiplayerServer.enabled`).
-    pub servers_allowed: bool,
-    /// `bannedScopes.get("MULTIPLAYER")`.
-    pub multiplayer_ban: Option<BanDetails>,
-}
-impl Default for UserProperties {
-    /// `UserApiService.OFFLINE_PROPERTIES`: what a failed fetch falls back to.
-    fn default() -> Self {
-        Self {
-            servers_allowed: true,
-            multiplayer_ban: None,
-        }
-    }
-}
-
-/// authlib's `ProfileResult.actions()`.
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
-pub struct ProfileActions {
-    pub forced_name_change: bool,
-    pub using_banned_skin: bool,
-}
-
-/// What the title screen learns about the account.
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
-pub struct AccountStatus {
-    pub properties: UserProperties,
-    pub actions: ProfileActions,
-}
-impl AccountStatus {
-    /// `Minecraft.allowsMultiplayer` (without the `--disableMultiplayer` flag).
-    pub fn allows_multiplayer(&self) -> bool {
-        self.properties.servers_allowed
-            && self.properties.multiplayer_ban.is_none()
-            && !self.actions.forced_name_change
-    }
-}
-
-/// One of the screens `Gui.addInitialScreens` adds.
-#[derive(Clone, Debug, PartialEq, Eq)]
-pub enum Notice {
-    /// `BanNoticeScreens.create`.
-    Multiplayer(BanDetails),
-    /// `BanNoticeScreens.createNameBan` with the profile's name.
-    Name(String),
-    /// `BanNoticeScreens.createSkinBan`.
-    Skin,
-}
-
-/// `Gui.addInitialScreens`' ban part, in its order: the multiplayer ban, the
-/// name ban, the skin ban.
-pub fn initial_notices(status: &AccountStatus, profile_name: &str) -> Vec<Notice> {
-    let mut notices = Vec::new();
-    if let Some(ban) = &status.properties.multiplayer_ban {
-        notices.push(Notice::Multiplayer(ban.clone()));
-    }
-    if status.actions.forced_name_change {
-        notices.push(Notice::Name(profile_name.to_owned()));
-    }
-    if status.actions.using_banned_skin {
-        notices.push(Notice::Skin);
-    }
-    notices
-}
-
-impl Notice {
-    /// The screen's title (bold).
-    pub fn title(&self) -> Text {
-        let key = match self {
-            Self::Multiplayer(ban) if ban.expires_ms.is_some() => "gui.banned.title.temporary",
-            Self::Multiplayer(_) => "gui.banned.title.permanent",
-            Self::Name(_) => "gui.banned.name.title",
-            Self::Skin => "gui.banned.skin.title",
-        };
-        Text::translate(key, &[]).bold()
-    }
-    /// The screen's message; `now_ms` is `Instant.now()`.
-    pub fn message(&self, now_ms: i64) -> Text {
-        let link = || Text::literal(SUSPENSION_HELP);
-        match self {
-            Self::Multiplayer(ban) => Text::translate(
-                "gui.banned.description",
-                &[reason_text(ban), status_text(ban, now_ms), link()],
-            ),
-            Self::Name(name) => Text::translate(
-                "gui.banned.name.description",
-                &[Text::colored(name.clone(), YELLOW), link()],
-            ),
-            Self::Skin => Text::translate("gui.banned.skin.description", &[link()]),
-        }
-    }
-}
-
-/// `ChatFormatting.YELLOW`.
-const YELLOW: u32 = 0xFFFF55;
-
-/// `BanReason.byId`: the translation key suffix.
-fn ban_reason(id: i32) -> Option<&'static str> {
-    Some(match id {
-        2 => "false_reporting",
-        5 => "hate_speech",
-        16 | 25 => "hate_terrorism_notorious_figure",
-        17 | 19 | 23 | 31 => "generic_violation",
-        21 => "harassment_or_bullying",
-        27 => "defamation_impersonation_false_information",
-        28 => "drugs",
-        29 => "fraud",
-        30 => "spam_or_advertising",
-        32 => "nudity_or_pornography",
-        33 | 35 | 36 => "sexually_inappropriate",
-        34 => "extreme_violence_or_gore",
-        53 => "imminent_harm_to_person_or_property",
-        _ => return None,
-    })
-}
-
-/// `BanNoticeScreens.getBanReasonText`.
-fn reason_text(ban: &BanDetails) -> Text {
-    let numeric = ban
-        .reason
-        .as_deref()
-        .filter(|r| !r.is_empty() && r.bytes().all(|b| b.is_ascii_digit()));
-    let Some(reason) = numeric else {
-        return Text::translate("gui.banned.description.unknownreason", &[]);
-    };
-    // Integer.parseInt: past i32 the vanilla screen would throw; show the code as is.
-    let id = reason.parse::<i32>().ok();
-    let text = if let Some(key) = id.and_then(ban_reason) {
-        Text::translate(&format!("gui.banned.reason.{key}"), &[]).bold()
-    } else if let Some(message) = &ban.reason_message {
-        Text::translate(
-            "gui.banned.description.reason_id_message",
-            &[Text::literal(reason), Text::literal(message.clone())],
-        )
-        .bold()
-    } else {
-        Text::translate("gui.banned.description.reason_id", &[Text::literal(reason)]).bold()
-    };
-    Text::translate("gui.banned.description.reason", &[text])
-}
-
-/// `BanNoticeScreens.getBanStatusText`.
-fn status_text(ban: &BanDetails, now_ms: i64) -> Text {
-    match ban.expires_ms {
-        Some(expires) => {
-            let duration = Text::translate(
-                "gui.banned.description.temporary.duration",
-                &[duration_text(expires - now_ms)],
-            )
-            .bold();
-            Text::translate("gui.banned.description.temporary", &[duration])
-        }
-        None => Text::translate("gui.banned.description.permanent", &[]).bold(),
-    }
-}
-
-/// `BanNoticeScreens.getBanDurationText`: days past 72 hours, else hours,
-/// else minutes (`Duration.toHours` and friends truncate toward zero).
-fn duration_text(millis: i64) -> Text {
-    let count = |n: i64| Text::literal(n.to_string());
-    let hours = millis / 3_600_000;
-    if hours > 72 {
-        Text::translate("gui.days", &[count(millis / 86_400_000)])
-    } else if hours < 1 {
-        Text::translate("gui.minutes", &[count(millis / 60_000)])
-    } else {
-        Text::translate("gui.hours", &[count(hours)])
-    }
-}
-
-/// `Instant` as authlib's gson adapter reads it: an ISO-8601 string, or epoch milliseconds.
-fn parse_instant(value: &serde_json::Value) -> Option<i64> {
-    match value {
-        serde_json::Value::Number(n) => n.as_i64(),
-        serde_json::Value::String(s) => chrono::DateTime::parse_from_rfc3339(s)
-            .ok()
-            .map(|t| t.timestamp_millis())
-            .or_else(|| s.parse().ok()),
-        _ => None,
-    }
-}
-
-/// `UserAttributesResponse` into `UserProperties` (`fetchProperties`). Bad JSON
-/// is an error, which vanilla answers with the offline properties.
-pub fn parse_properties(body: &str) -> Option<UserProperties> {
-    let v: serde_json::Value = serde_json::from_str(body).ok()?;
-    let servers_allowed = v
-        .pointer("/privileges/multiplayerServer/enabled")
-        .and_then(|e| e.as_bool())
-        .unwrap_or(false);
-    let multiplayer_ban = v
-        .pointer("/banStatus/bannedScopes/MULTIPLAYER")
-        .filter(|b| b.is_object())
-        .map(|b| {
-            let text = |k: &str| b.get(k).and_then(|s| s.as_str()).map(str::to_owned);
-            BanDetails {
-                expires_ms: b.get("expires").and_then(parse_instant),
-                reason: text("reason"),
-                reason_message: text("reasonMessage"),
-            }
-        });
-    Some(UserProperties {
-        servers_allowed,
-        multiplayer_ban,
-    })
-}
-
-/// `MinecraftProfilePropertiesResponse.profileActions` into `ProfileActionType`s.
-pub fn parse_profile_actions(body: &str) -> ProfileActions {
-    let mut actions = ProfileActions::default();
-    let v: serde_json::Value = serde_json::from_str(body).unwrap_or_default();
-    for action in v
-        .get("profileActions")
-        .and_then(|a| a.as_array())
-        .into_iter()
-        .flatten()
-    {
-        match action.get("type").and_then(|t| t.as_str()) {
-            Some("FORCED_NAME_CHANGE") => actions.forced_name_change = true,
-            Some("USING_BANNED_SKIN") => actions.using_banned_skin = true,
-            _ => {}
-        }
-    }
-    actions
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    const HOUR: i64 = 3_600_000;
-    /// 2026-11-01T00:00:00Z.
-    const EXPIRES: i64 = 1_793_491_200_000;
-
-    #[test]
-    fn parses_a_multiplayer_ban() {
-        let body = r#"{"privileges":{"multiplayerServer":{"enabled":false}},
-            "banStatus":{"bannedScopes":{"MULTIPLAYER":{"banId":"6b0f0a0e-0000-4000-8000-000000000000",
-            "expires":"2026-11-01T00:00:00Z","reason":"21","reasonMessage":"x"}}}}"#;
-        let p = parse_properties(body).unwrap();
-        assert!(!p.servers_allowed);
-        let ban = p.multiplayer_ban.unwrap();
-        assert_eq!(ban.expires_ms, Some(EXPIRES));
-        assert_eq!(ban.reason.as_deref(), Some("21"));
-        let numeric =
-            parse_properties(r#"{"banStatus":{"bannedScopes":{"MULTIPLAYER":{"expires":5}}}}"#)
-                .unwrap();
-        assert_eq!(numeric.multiplayer_ban.unwrap().expires_ms, Some(5));
-        assert!(parse_properties("nope").is_none());
-        let clean = parse_properties(
-            r#"{"privileges":{"multiplayerServer":{"enabled":true}},"banStatus":{"bannedScopes":{}}}"#,
-        )
-        .unwrap();
-        assert!(clean.servers_allowed && clean.multiplayer_ban.is_none());
-    }
-
-    #[test]
-    fn parses_profile_actions() {
-        let a = parse_profile_actions(
-            r#"{"id":"x","profileActions":[{"type":"FORCED_NAME_CHANGE"},{"type":"OTHER"}]}"#,
-        );
-        assert!(a.forced_name_change && !a.using_banned_skin);
-        let a = parse_profile_actions(r#"{"profileActions":[{"type":"USING_BANNED_SKIN"}]}"#);
-        assert!(!a.forced_name_change && a.using_banned_skin);
-        assert_eq!(parse_profile_actions("{}"), ProfileActions::default());
-    }
-
-    #[test]
-    fn queues_in_vanilla_order() {
-        let ban = BanDetails {
-            expires_ms: None,
-            reason: None,
-            reason_message: None,
-        };
-        let status = AccountStatus {
-            properties: UserProperties {
-                servers_allowed: true,
-                multiplayer_ban: Some(ban.clone()),
-            },
-            actions: ProfileActions {
-                forced_name_change: true,
-                using_banned_skin: true,
-            },
-        };
-        assert_eq!(
-            initial_notices(&status, "Steve"),
-            vec![
-                Notice::Multiplayer(ban),
-                Notice::Name("Steve".into()),
-                Notice::Skin
-            ]
-        );
-        assert!(!status.allows_multiplayer());
-        assert!(initial_notices(&AccountStatus::default(), "Steve").is_empty());
-        assert!(AccountStatus::default().allows_multiplayer());
-        let no_servers = AccountStatus {
-            properties: UserProperties {
-                servers_allowed: false,
-                multiplayer_ban: None,
-            },
-            ..Default::default()
-        };
-        assert!(!no_servers.allows_multiplayer());
-    }
-
-    /// The message's component JSON: the keys and arguments, whatever language is loaded.
-    fn json(notice: &Notice, now: i64) -> String {
-        notice.message(now).component().to_string()
-    }
-
-    #[test]
-    fn ban_text_follows_banned_screens() {
-        let temp = |reason: Option<&str>, message: Option<&str>| {
-            Notice::Multiplayer(BanDetails {
-                expires_ms: Some(100 * HOUR),
-                reason: reason.map(str::to_owned),
-                reason_message: message.map(str::to_owned),
-            })
-        };
-        assert_eq!(
-            temp(None, None).title().translation_key(),
-            Some("gui.banned.title.temporary")
-        );
-        let perm = Notice::Multiplayer(BanDetails {
-            expires_ms: None,
-            reason: Some("5".into()),
-            reason_message: None,
-        });
-        assert_eq!(
-            perm.title().translation_key(),
-            Some("gui.banned.title.permanent")
-        );
-        let text = json(&perm, 0);
-        assert!(text.contains("gui.banned.reason.hate_speech"));
-        assert!(text.contains("gui.banned.description.permanent"));
-        assert!(text.contains(SUSPENSION_HELP));
-        // Unknown ids show their code, with the message when there is one.
-        let with_message = json(&temp(Some("999"), Some("why")), 0);
-        assert!(with_message.contains("gui.banned.description.reason_id_message"));
-        assert!(with_message.contains("why"));
-        assert!(json(&temp(Some("999"), None), 0).contains("gui.banned.description.reason_id\""));
-        assert!(json(&temp(Some("abc"), None), 0).contains("gui.banned.description.unknownreason"));
-        // 100 hours left is past 72: days (4); less is hours; under an hour is minutes.
-        let duration = |now| json(&temp(None, None), now);
-        assert!(duration(0).contains("gui.days") && duration(0).contains("[4]"));
-        assert!(duration(60 * HOUR).contains("gui.hours") && duration(60 * HOUR).contains("[40]"));
-        let minutes = duration(100 * HOUR - 90_000);
-        assert!(minutes.contains("gui.minutes") && minutes.contains("[1]"));
-        assert!(json(&Notice::Name("Bob".into()), 0).contains("Bob"));
-        assert!(json(&Notice::Skin, 0).contains(SUSPENSION_HELP));
-    }
-}

crates/horizon-client-render/src/biome.rs

@@ -3,12 +3,7 @@
 use crate::Result;
 use horizon_core::{noise::SimplexNoise, position::BlockPos, random::LegacyRandom};
 use serde_json::Value;
-use std::{
-    collections::{BTreeMap, HashMap},
-    fs,
-    path::Path,
-    sync::Arc,
-};
+use std::{collections::HashMap, fs, path::Path};
 
 #[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum GrassModifier {
@@ -107,9 +102,6 @@ pub struct BiomeInfo {
     /// The biome's own fog colour attribute; otherwise the dimension's applies.
     pub fog: Option<u32>,
     pub water_fog: u32,
-    /// `BiomeGenerationSettings.features`: the placed feature ids of each
-    /// `GenerationStep.Decoration` step, in order.
-    pub features: Vec<Vec<String>>,
 }
 impl BiomeInfo {
     /// `Biome.getHeightAdjustedTemperature`: the frozen modifier, then cooler
@@ -138,27 +130,10 @@ impl BiomeInfo {
             .then(|| self.temperature_at(BlockPos::new(x, y, z), 63) < 0.15)
     }
 }
-/// The game's biomes, by id. The built-in (vanilla) biomes come first, in
-/// file order, and keep their ids whatever a world's data packs do; a pack's
-/// new biomes follow them (`with_packs`). Those are the client's own ids:
-/// the network registry's are `registry_order`'s.
-#[derive(Clone)]
 pub struct Biomes {
     pub list: Vec<BiomeInfo>,
     pub index: HashMap<String, u16>,
     info_noise: SimplexNoise,
-    colormaps: Arc<Colormaps>,
-    /// The built-in biomes, the first of `list` unless packs replaced them.
-    builtin: Arc<Vec<BiomeInfo>>,
-    /// The data packs' biome files (new biomes and replaced built-in ones),
-    /// for the tables that read more of a biome than `BiomeInfo` keeps.
-    packs: BTreeMap<String, Arc<Value>>,
-}
-/// The grass, foliage and dry foliage colormaps.
-struct Colormaps {
-    grass: Vec<u32>,
-    foliage: Vec<u32>,
-    dry: Vec<u32>,
 }
 fn color(v: &Value) -> Option<u32> {
     match v {
@@ -172,7 +147,6 @@ fn color(v: &Value) -> Option<u32> {
 fn colormap(root: &Path, name: &str) -> Result<Vec<u32>> {
     let path = root.join(format!("assets/minecraft/textures/colormap/{name}.png"));
     let mut decoder = png::Decoder::new(std::io::BufReader::new(fs::File::open(path)?));
-    decoder.ignore_checksums(true);
     decoder.set_transformations(png::Transformations::EXPAND | png::Transformations::STRIP_16);
     let mut reader = decoder.read_info()?;
     let mut bytes = vec![0; reader.output_buffer_size().ok_or("colormap too large")?];
@@ -192,90 +166,11 @@ fn sample(map: &[u32], temperature: f32, downfall: f32, fallback: u32) -> u32 {
     let index = (y << 8 | x) as usize;
     map.get(index).copied().unwrap_or(fallback)
 }
-impl BiomeInfo {
-    /// A biome file's (`worldgen/biome/<name>.json`) values, the colours it
-    /// leaves out sampled from the colormaps.
-    fn from_json(name: String, v: &Value, maps: &Colormaps) -> Self {
-        let effects = &v["effects"];
-        let attributes = &v["attributes"];
-        let temperature = v["temperature"].as_f64().unwrap_or(0.5) as f32;
-        let downfall = v["downfall"].as_f64().unwrap_or(0.5) as f32;
-        let modifier = match effects["grass_color_modifier"].as_str() {
-            Some("dark_forest") => GrassModifier::DarkForest,
-            Some("swamp") => GrassModifier::Swamp,
-            _ => GrassModifier::None,
-        };
-        let mut spawns: HashMap<String, Vec<SpawnEntry>> = HashMap::new();
-        let natural = &attributes["minecraft:gameplay/natural_mob_spawns"];
-        // A modifier object ({argument, modifier: overlay}) or the plain value;
-        // the overlay over the dimension's empty default is the biome's value.
-        let natural = if natural["argument"].is_object() {
-            &natural["argument"]
-        } else {
-            natural
-        };
-        let categories = &natural["spawns_by_category"];
-        for (category, entries) in categories.as_object().into_iter().flatten() {
-            let list = parse_entries(entries);
-            spawns.insert(category.clone(), list);
-        }
-        BiomeInfo {
-            spawns,
-            spawn_costs: parse_costs(&natural["spawn_costs"]),
-            creature_probability:
-                attributes["minecraft:gameplay/creature_world_gen_spawn_probability"]
-                    .as_f64()
-                    .unwrap_or(0.1) as f32,
-            increased_fire_burnout: attributes["minecraft:gameplay/increased_fire_burnout"]
-                .as_bool()
-                .unwrap_or(false),
-            temperature,
-            frozen: v["temperature_modifier"].as_str() == Some("frozen"),
-            downfall,
-            precipitation: v["has_precipitation"].as_bool().unwrap_or(true),
-            grass: color(&effects["grass_color"])
-                .unwrap_or_else(|| sample(&maps.grass, temperature, downfall, 0xFF00FF)),
-            modifier,
-            foliage: color(&effects["foliage_color"])
-                .unwrap_or_else(|| sample(&maps.foliage, temperature, downfall, 0x48B518)),
-            dry_foliage: color(&effects["dry_foliage_color"])
-                .unwrap_or_else(|| sample(&maps.dry, temperature, downfall, 0x5D4930)),
-            water: color(&effects["water_color"]).unwrap_or(0x3F76E4),
-            sky: color(&attributes["minecraft:visual/sky_color"]),
-            fog: color(&attributes["minecraft:visual/fog_color"]),
-            water_fog: color(&attributes["minecraft:visual/water_fog_color"]).unwrap_or(0x050533),
-            features: v["features"]
-                .as_array()
-                .into_iter()
-                .flatten()
-                .map(|step| {
-                    step.as_array()
-                        .into_iter()
-                        .flatten()
-                        .filter_map(Value::as_str)
-                        .map(str::to_owned)
-                        .collect()
-                })
-                .collect(),
-            name,
-        }
-    }
-}
-/// `Identifier.compareTo`: the path first, then the namespace.
-pub fn identifier_order(a: &str, b: &str) -> std::cmp::Ordering {
-    fn split(id: &str) -> (&str, &str) {
-        let (ns, path) = id.split_once(':').unwrap_or(("minecraft", id));
-        (path, ns)
-    }
-    split(a).cmp(&split(b))
-}
 impl Biomes {
     pub fn load(root: &Path) -> Result<Self> {
-        let maps = Colormaps {
-            grass: colormap(root, "grass")?,
-            foliage: colormap(root, "foliage")?,
-            dry: colormap(root, "dry_foliage")?,
-        };
+        let grass = colormap(root, "grass")?;
+        let foliage = colormap(root, "foliage")?;
+        let dry = colormap(root, "dry_foliage")?;
         let mut list = Vec::new();
         let mut names: Vec<_> = fs::read_dir(root.join("data/minecraft/worldgen/biome"))?
             .filter_map(|e| e.ok())
@@ -291,7 +186,57 @@ impl Biomes {
                     .ok_or("bad biome")?
             );
             let v: Value = serde_json::from_slice(&fs::read(&path)?)?;
-            list.push(BiomeInfo::from_json(name, &v, &maps));
+            let effects = &v["effects"];
+            let attributes = &v["attributes"];
+            let temperature = v["temperature"].as_f64().unwrap_or(0.5) as f32;
+            let downfall = v["downfall"].as_f64().unwrap_or(0.5) as f32;
+            let modifier = match effects["grass_color_modifier"].as_str() {
+                Some("dark_forest") => GrassModifier::DarkForest,
+                Some("swamp") => GrassModifier::Swamp,
+                _ => GrassModifier::None,
+            };
+            let mut spawns: HashMap<String, Vec<SpawnEntry>> = HashMap::new();
+            let natural = &attributes["minecraft:gameplay/natural_mob_spawns"];
+            // A modifier object ({argument, modifier: overlay}) or the plain value;
+            // the overlay over the dimension's empty default is the biome's value.
+            let natural = if natural["argument"].is_object() {
+                &natural["argument"]
+            } else {
+                natural
+            };
+            let categories = &natural["spawns_by_category"];
+            for (category, entries) in categories.as_object().into_iter().flatten() {
+                let list = parse_entries(entries);
+                spawns.insert(category.clone(), list);
+            }
+            list.push(BiomeInfo {
+                spawns,
+                spawn_costs: parse_costs(&natural["spawn_costs"]),
+                creature_probability:
+                    attributes["minecraft:gameplay/creature_world_gen_spawn_probability"]
+                        .as_f64()
+                        .unwrap_or(0.1) as f32,
+                increased_fire_burnout: attributes["minecraft:gameplay/increased_fire_burnout"]
+                    .as_bool()
+                    .unwrap_or(false),
+                temperature,
+                frozen: v["temperature_modifier"].as_str() == Some("frozen"),
+                downfall,
+                precipitation: v["has_precipitation"].as_bool().unwrap_or(true),
+                grass: color(&effects["grass_color"])
+                    .unwrap_or_else(|| sample(&grass, temperature, downfall, 0xFF00FF)),
+                modifier,
+                foliage: color(&effects["foliage_color"])
+                    .unwrap_or_else(|| sample(&foliage, temperature, downfall, 0x48B518)),
+                dry_foliage: color(&effects["dry_foliage_color"])
+                    .unwrap_or_else(|| sample(&dry, temperature, downfall, 0x5D4930)),
+                water: color(&effects["water_color"]).unwrap_or(0x3F76E4),
+                sky: color(&attributes["minecraft:visual/sky_color"]),
+                fog: color(&attributes["minecraft:visual/fog_color"]),
+                water_fog: color(&attributes["minecraft:visual/water_fog_color"])
+                    .unwrap_or(0x050533),
+                name,
+            });
         }
         let index = list
             .iter()
@@ -299,65 +244,11 @@ impl Biomes {
             .map(|(i, b)| (b.name.clone(), i as u16))
             .collect();
         Ok(Self {
-            builtin: Arc::new(list.clone()),
             list,
             index,
-            colormaps: Arc::new(maps),
-            packs: BTreeMap::new(),
             info_noise: SimplexNoise::with_skipped_offsets(&mut LegacyRandom::new(2345), true),
         })
     }
-    /// The built-in biomes with a world's data packs' biome files (id →
-    /// JSON) over them, as `RegistryDataLoader` builds the registry: a file
-    /// for a built-in biome replaces it, keeping its id, and new biomes join
-    /// after the built-in ones, in registry order. Starts from the built-in
-    /// table whatever packs `self` has.
-    pub fn with_packs<'a>(&self, files: impl IntoIterator<Item = (&'a str, &'a Value)>) -> Self {
-        let mut out = self.builtin_only();
-        let mut files: Vec<(&str, &Value)> = files.into_iter().collect();
-        files.sort_by(|a, b| identifier_order(a.0, b.0));
-        for (name, json) in files {
-            let info = BiomeInfo::from_json(name.to_owned(), json, &out.colormaps);
-            match out.index.get(name) {
-                Some(&id) => out.list[usize::from(id)] = info,
-                None if out.list.len() < usize::from(u16::MAX) => {
-                    out.index.insert(name.to_owned(), out.list.len() as u16);
-                    out.list.push(info);
-                }
-                None => continue,
-            }
-            out.packs.insert(name.to_owned(), Arc::new(json.clone()));
-        }
-        out
-    }
-    /// The built-in biomes alone: this table without what packs gave it.
-    pub fn builtin_only(&self) -> Self {
-        let mut out = self.clone();
-        if self.packs.is_empty() {
-            return out;
-        }
-        out.list = self.builtin.to_vec();
-        let builtin = out.list.len();
-        out.index.retain(|_, id| usize::from(*id) < builtin);
-        out.packs.clear();
-        out
-    }
-    /// The data pack file a world's biome `name` came from, if a pack added
-    /// or replaced it.
-    pub fn pack_file(&self, name: &str) -> Option<&Value> {
-        self.packs.get(name).map(|v| &**v)
-    }
-    /// Whether data packs added or replaced any biome.
-    pub fn has_packs(&self) -> bool {
-        !self.packs.is_empty()
-    }
-    /// The biome names in the network registry's order: `RegistryDataLoader`
-    /// sorts a registry's files by `Identifier` (path, then namespace).
-    pub fn registry_order(&self) -> Vec<&str> {
-        let mut names: Vec<&str> = self.list.iter().map(|b| b.name.as_str()).collect();
-        names.sort_by(|a, b| identifier_order(a, b));
-        names
-    }
     pub fn id(&self, name: &str) -> u16 {
         self.index
             .get(name)
@@ -388,52 +279,6 @@ impl Biomes {
     }
 }
 
-/// A biome's colours as a mod may change them (`native_biome_colors`), each
-/// 0xRRGGBB: what tints grass (before the dark forest's modifier; the swamp's
-/// noise colours replace it), leaves and vines, dry foliage (leaf litter) and
-/// water.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub struct BiomeColors {
-    pub grass: u32,
-    pub foliage: u32,
-    pub dry_foliage: u32,
-    pub water: u32,
-}
-
-impl Biomes {
-    /// This table with each biome's colours passed through `f`, given the
-    /// biome's name (`minecraft:plains`) and its colours; None when `f`
-    /// changed none. Bits past 0xFFFFFF are dropped.
-    pub fn with_colors(&self, mut f: impl FnMut(&str, &mut BiomeColors)) -> Option<Self> {
-        let mut out = self.clone();
-        let mut changed = false;
-        for b in &mut out.list {
-            let before = BiomeColors {
-                grass: b.grass,
-                foliage: b.foliage,
-                dry_foliage: b.dry_foliage,
-                water: b.water,
-            };
-            let mut colors = before;
-            f(&b.name, &mut colors);
-            let after = BiomeColors {
-                grass: colors.grass & 0xFF_FFFF,
-                foliage: colors.foliage & 0xFF_FFFF,
-                dry_foliage: colors.dry_foliage & 0xFF_FFFF,
-                water: colors.water & 0xFF_FFFF,
-            };
-            if after != before {
-                changed = true;
-                b.grass = after.grass;
-                b.foliage = after.foliage;
-                b.dry_foliage = after.dry_foliage;
-                b.water = after.water;
-            }
-        }
-        changed.then_some(out)
-    }
-}
-
 /// A 24-bit colour as sRGB components in 0..1.
 pub fn rgb(c: u32) -> [f32; 3] {
     [16, 8, 0].map(|shift| (c >> shift & 255) as f32 / 255.0)
@@ -499,163 +344,6 @@ pub fn blend_rgb(weights: &[(u16, f64)], mut value: impl FnMut(u16) -> [f32; 3])
     result.unwrap_or([0.0; 3])
 }
 
-#[cfg(test)]
-mod pack_tests {
-    use super::*;
-    use serde_json::json;
-
-    /// A built-in table of `names` (no colormaps: sampled colours fall back).
-    fn builtin(names: &[&str]) -> Biomes {
-        let maps = Colormaps {
-            grass: Vec::new(),
-            foliage: Vec::new(),
-            dry: Vec::new(),
-        };
-        let list: Vec<BiomeInfo> = names
-            .iter()
-            .map(|n| BiomeInfo::from_json((*n).to_owned(), &json!({}), &maps))
-            .collect();
-        Biomes {
-            builtin: Arc::new(list.clone()),
-            index: list
-                .iter()
-                .enumerate()
-                .map(|(i, b)| (b.name.clone(), i as u16))
-                .collect(),
-            list,
-            info_noise: SimplexNoise::with_skipped_offsets(&mut LegacyRandom::new(2345), true),
-            colormaps: Arc::new(maps),
-            packs: BTreeMap::new(),
-        }
-    }
-
-    #[test]
-    fn registry_order_is_path_then_namespace() {
-        use std::cmp::Ordering::*;
-        assert_eq!(identifier_order("minecraft:a", "minecraft:b"), Less);
-        assert_eq!(identifier_order("z:a", "a:b"), Less);
-        assert_eq!(identifier_order("b:same", "a:same"), Greater);
-        assert_eq!(identifier_order("minecraft:a", "minecraft:a_b"), Less);
-        assert_eq!(identifier_order("minecraft:a-b", "minecraft:a"), Greater);
-    }
-
-    #[test]
-    fn packs_replace_in_place_and_add_after_the_builtin_biomes() {
-        let base = builtin(&["minecraft:meadow", "minecraft:plains", "minecraft:river"]);
-        let red = json!({"temperature": 2.0, "effects": {"water_color": "#ff0000"}});
-        let hot = json!({"effects": {"grass_color": 0x123456}});
-        let files = [
-            ("pack:zeta", &hot),
-            ("minecraft:molten_peaks", &hot),
-            ("minecraft:river", &red),
-        ];
-        let world = base.with_packs(files);
-        // The built-in ids stay; the river takes the pack's values.
-        assert_eq!(world.id("minecraft:plains"), 1);
-        assert_eq!(world.id("minecraft:river"), 2);
-        assert_eq!(world.get(2).water, 0xFF0000);
-        assert_eq!(world.get(2).temperature, 2.0);
-        // New biomes follow, in registry order.
-        assert_eq!(world.id("minecraft:molten_peaks"), 3);
-        assert_eq!(world.id("pack:zeta"), 4);
-        assert_eq!(world.get(3).grass, 0x123456);
-        assert!(world.pack_file("minecraft:river").is_some());
-        assert!(world.pack_file("minecraft:plains").is_none());
-        // The network registry sorts every name by path, then namespace.
-        assert_eq!(
-            world.registry_order(),
-            [
-                "minecraft:meadow",
-                "minecraft:molten_peaks",
-                "minecraft:plains",
-                "minecraft:river",
-                "pack:zeta"
-            ]
-        );
-        // Another world starts again from the built-in biomes.
-        let other = world.with_packs([]);
-        assert_eq!(other.list.len(), 3);
-        assert!(!other.contains("minecraft:molten_peaks"));
-        assert_eq!(other.get(2).water, 0x3F76E4);
-        assert!(!other.has_packs());
-    }
-}
-
-#[cfg(test)]
-mod color_tests {
-    use super::*;
-    use serde_json::json;
-
-    fn biomes() -> Biomes {
-        let maps = Colormaps {
-            grass: Vec::new(),
-            foliage: Vec::new(),
-            dry: Vec::new(),
-        };
-        let effects = |grass: u32, modifier: &str| {
-            json!({"effects": {"grass_color": grass, "foliage_color": 0x112233,
-                "dry_foliage_color": 0x445566, "water_color": 0x3F76E4,
-                "grass_color_modifier": modifier}})
-        };
-        let list = vec![
-            BiomeInfo::from_json("minecraft:plains".into(), &effects(0x91BD59, "none"), &maps),
-            BiomeInfo::from_json(
-                "minecraft:dark_forest".into(),
-                &effects(0x91BD59, "dark_forest"),
-                &maps,
-            ),
-        ];
-        Biomes {
-            builtin: Arc::new(list.clone()),
-            index: list
-                .iter()
-                .enumerate()
-                .map(|(i, b)| (b.name.clone(), i as u16))
-                .collect(),
-            list,
-            info_noise: SimplexNoise::with_skipped_offsets(&mut LegacyRandom::new(2345), true),
-            colormaps: Arc::new(maps),
-            packs: BTreeMap::new(),
-        }
-    }
-
-    #[test]
-    fn a_change_reaches_the_tints_the_mesher_reads() {
-        let autumn = biomes()
-            .with_colors(|name, c| {
-                c.foliage = 0xD2691E;
-                if name == "minecraft:plains" {
-                    c.grass = 0xBFA055;
-                }
-            })
-            .expect("changed");
-        let plains = autumn.id("minecraft:plains");
-        assert_eq!(autumn.grass(plains, 0.0, 0.0), 0xBFA055);
-        assert_eq!(autumn.get(plains).foliage, 0xD2691E);
-        assert_eq!(autumn.get(plains).dry_foliage, 0x445566);
-        assert_eq!(autumn.get(plains).water, 0x3F76E4);
-        // The dark forest's modifier still darkens its (unchanged) grass:
-        // ((0x91BD59 & 0xFEFEFE) + 0x28340A) >> 1.
-        let dark = autumn.id("minecraft:dark_forest");
-        assert_eq!(autumn.grass(dark, 0.0, 0.0), 0x5C7831);
-        assert_eq!(autumn.get(dark).foliage, 0xD2691E);
-    }
-
-    #[test]
-    fn no_change_gives_none_and_alpha_bits_are_dropped() {
-        assert!(biomes().with_colors(|_, _| {}).is_none());
-        assert!(
-            biomes()
-                .with_colors(|_, c| c.water |= 0xFF00_0000)
-                .is_none()
-        );
-        let blue = biomes()
-            .with_colors(|_, c| c.water = 0xFF00_00FF)
-            .expect("changed");
-        assert_eq!(blue.get(0).water, 0x0000FF);
-    }
-}
-
 #[cfg(test)]
 mod blend_tests {
     use super::*;

crates/horizon-client-render/src/block_edit.rs

@@ -1,306 +0,0 @@
-//! Bulk block edits: runs of blocks up columns written straight into the
-//! resident sections, a section unpacked and packed once however many of its
-//! blocks change, instead of a `World::set` per block. Nothing round them is
-//! told (as `fill ... strict`); the light of each chunk changed is worked out
-//! again whole, off the game thread, rather than block by block, and each
-//! section changed is remeshed once.
-use crate::chunk::index;
-use crate::fast_hash::FxHashMap;
-use crate::world::World;
-
-/// A run of one column, resolved: blocks `y0..=y1` of column (x, z) set to
-/// `state` where filter `only` (if any) passes the block there.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub struct Run {
-    pub x: i32,
-    pub z: i32,
-    pub y0: i32,
-    pub y1: i32,
-    pub state: u32,
-    pub only: Option<u16>,
-}
-
-/// What an edit changed.
-#[derive(Debug, Default)]
-pub struct Outcome {
-    /// Blocks changed.
-    pub changed: u64,
-    /// Chunks with a change.
-    pub chunks: usize,
-    /// Changes of the states `tracked` asked for (block entities, watched
-    /// blocks): position, previous and new state.
-    pub tracked: Vec<((i32, i32, i32), u32, u32)>,
-}
-
-/// Per state answers, worked out once each.
-struct Memo(Vec<u8>);
-impl Memo {
-    #[inline]
-    fn get(&mut self, state: u32, ask: impl FnOnce(u32) -> bool) -> bool {
-        let i = state as usize;
-        if i >= self.0.len() {
-            self.0.resize(i + 1, 0);
-        }
-        if self.0[i] == 0 {
-            self.0[i] = 1 + u8::from(ask(state));
-        }
-        self.0[i] == 2
-    }
-}
-
-impl World {
-    /// Make `runs` in order, each seeing the changes of those before it.
-    /// `matches(filter, state)` says whether a filter passes a state, and
-    /// `tracked(state)` whether its changes are reported; each is asked once
-    /// per state. Runs in unloaded chunks and the parts of runs outside each
-    /// chunk's own column (`Chunk::layout`) are left out.
-    ///
-    /// Unlike `World::set`, this records nothing per block: no
-    /// `block_entities.state_changed` (a caller adds or removes block
-    /// entities itself, from `Outcome::tracked`), no `watched_writes` (ask
-    /// for those states through `tracked`), no `block_log` entry (the chunk
-    /// goes in `bulk_log` instead, sent whole), no `path_writes` (mobs'
-    /// paths are not recomputed for these blocks) and no `light_edits` (the
-    /// chunk and its neighbours are lit again whole, through `dirty_light`).
-    pub fn edit_runs(
-        &mut self,
-        runs: &[Run],
-        mut matches: impl FnMut(u16, u32) -> bool,
-        mut tracked: impl FnMut(u32) -> bool,
-    ) -> Outcome {
-        let mut out = Outcome::default();
-        // the runs of each chunk, in order, and the chunks in the order they were first named
-        let mut by_chunk: FxHashMap<(i32, i32), Vec<u32>> = FxHashMap::default();
-        let mut order = Vec::new();
-        for (i, r) in runs.iter().enumerate() {
-            if r.y1 < r.y0 {
-                continue;
-            }
-            let key = (r.x >> 4, r.z >> 4);
-            by_chunk
-                .entry(key)
-                .or_insert_with(|| {
-                    order.push(key);
-                    Vec::new()
-                })
-                .push(i as u32);
-        }
-        let mut filter_memo: Vec<Memo> = Vec::new();
-        let mut tracked_memo = Memo(Vec::new());
-        let mut values: Vec<Option<Box<[u32; 4096]>>> = Vec::new();
-        let mut changed: Vec<bool> = Vec::new();
-        for key in order {
-            let Some(chunk) = self.chunks.get(&key) else {
-                continue;
-            };
-            let (min_y, sections) = (chunk.min_y(), chunk.sections.len());
-            let max_y = chunk.max_y();
-            let list = &by_chunk[&key];
-            changed.clear();
-            changed.resize(sections, false);
-            values.clear();
-            values.resize_with(sections, || None);
-            let mut any = 0u64;
-            for &i in list {
-                let r = runs[i as usize];
-                let (lx, lz) = (r.x & 15, r.z & 15);
-                let (y0, y1) = (r.y0.max(min_y), r.y1.min(max_y - 1));
-                let mut y = y0;
-                while y <= y1 {
-                    let s = ((y - min_y) >> 4) as usize;
-                    let top = (min_y + (s as i32 + 1) * 16 - 1).min(y1);
-                    let vals = values[s].get_or_insert_with(|| {
-                        let mut v = Box::new([0u32; 4096]);
-                        chunk.sections[s].unpack(&mut v);
-                        v
-                    });
-                    for yy in y..=top {
-                        let at = index(lx, yy, lz);
-                        let old = vals[at];
-                        if old == r.state {
-                            continue;
-                        }
-                        if let Some(f) = r.only {
-                            let f = f as usize;
-                            if filter_memo.len() <= f {
-                                filter_memo.resize_with(f + 1, || Memo(Vec::new()));
-                            }
-                            if !filter_memo[f].get(old, |s| matches(f as u16, s)) {
-                                continue;
-                            }
-                        }
-                        vals[at] = r.state;
-                        changed[s] = true;
-                        any += 1;
-                        if tracked_memo.get(old, &mut tracked)
-                            || tracked_memo.get(r.state, &mut tracked)
-                        {
-                            out.tracked.push(((r.x, yy, r.z), old, r.state));
-                        }
-                    }
-                    y = top + 1;
-                }
-            }
-            if any == 0 {
-                continue;
-            }
-            out.changed += any;
-            out.chunks += 1;
-            let chunk =
-                std::sync::Arc::make_mut(self.chunks.get_mut(&key).expect("looked up above"));
-            for s in 0..sections {
-                if changed[s]
-                    && let Some(v) = &values[s]
-                {
-                    chunk.replace_blocks(s, v);
-                }
-            }
-            self.revision = self.revision.wrapping_add(1);
-            self.modified.insert(key);
-            if self.block_log.is_some() {
-                self.bulk_log.insert(key);
-            }
-            // remeshed once (with the neighbours whose faces and light it touches), lit again whole
-            for (s, _) in changed.iter().enumerate().filter(|c| *c.1) {
-                for ds in -1..=1 {
-                    let sy = s as i32 + ds;
-                    if !(0..sections as i32).contains(&sy) {
-                        continue;
-                    }
-                    for dz in -1..=1 {
-                        for dx in -1..=1 {
-                            self.dirty_sections.insert((key.0 + dx, sy, key.1 + dz));
-                        }
-                    }
-                }
-            }
-            for dz in -1..=1 {
-                for dx in -1..=1 {
-                    self.dirty_light.insert((key.0 + dx, key.1 + dz));
-                }
-            }
-        }
-        out
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::chunk::Chunk;
-    use horizon_world::registry::BlockStateId;
-    use std::sync::Arc;
-
-    fn world() -> World {
-        let mut w = World::new(BlockStateId(0), 0);
-        for cz in -1..=1 {
-            for cx in -1..=1 {
-                w.chunks.insert((cx, cz), Arc::new(Chunk::empty(cx, cz)));
-            }
-        }
-        // stone up to y 63
-        for z in -16..32 {
-            for x in -16..32 {
-                for y in -64..64 {
-                    w.set(x, y, z, BlockStateId(1)).unwrap();
-                }
-            }
-        }
-        w.dirty_light.clear();
-        w.dirty_sections.clear();
-        w.block_log = Some(Vec::new());
-        w
-    }
-    fn run(x: i32, z: i32, y0: i32, y1: i32, state: u32, only: Option<u16>) -> Run {
-        Run {
-            x,
-            z,
-            y0,
-            y1,
-            state,
-            only,
-        }
-    }
-
-    #[test]
-    fn runs_change_their_blocks_in_order() {
-        let mut w = world();
-        let runs = [
-            run(3, 4, 10, 40, 0, None),
-            run(3, 4, 10, 12, 5, None),
-            // only where it is air: over the stone, and the three blocks of 5 stay
-            run(3, 4, 0, 80, 7, Some(0)),
-            run(-1, 20, -70, 400, 9, None),
-        ];
-        let out = w.edit_runs(&runs, |_, s| s == 0, |_| false);
-        assert_eq!(w.block(3, 9, 4).0, 1);
-        assert_eq!(w.block(3, 11, 4).0, 5);
-        assert_eq!(w.block(3, 13, 4).0, 7);
-        assert_eq!(w.block(3, 70, 4).0, 7);
-        assert_eq!(w.block(3, 81, 4).0, 0);
-        assert_eq!(w.block(3, 0, 4).0, 1);
-        assert_eq!(w.block(-1, -64, 20).0, 9);
-        assert_eq!(w.block(-1, 319, 20).0, 9);
-        assert_eq!(w.block(0, 30, 20).0, 1);
-        // 31 dug, 3 set again, the air over them filled (28, and 17 over the stone), the whole of the other column
-        assert_eq!(out.changed, 31 + 3 + 45 + 384);
-        assert_eq!(out.chunks, 2);
-        assert!(w.bulk_log.contains(&(0, 0)) && w.bulk_log.contains(&(-1, 1)));
-        assert!(w.dirty_light.contains(&(1, 1)) && w.dirty_light.contains(&(-2, 2)));
-        assert!(w.dirty_sections.contains(&(1, 4, 1)));
-        // the per-block log is left to the blocks set one at a time
-        assert!(w.block_log.as_ref().unwrap().is_empty());
-    }
-
-    #[test]
-    fn unloaded_chunks_and_unchanged_blocks_are_left_out() {
-        let mut w = world();
-        let out = w.edit_runs(
-            &[run(100, 100, 0, 10, 0, None), run(0, 0, 0, 10, 1, None)],
-            |_, _| true,
-            |_| false,
-        );
-        assert_eq!(out.changed, 0);
-        assert_eq!(out.chunks, 0);
-        assert!(w.bulk_log.is_empty() && w.dirty_light.is_empty());
-    }
-
-    #[test]
-    fn tracked_states_are_reported() {
-        let mut w = world();
-        let out = w.edit_runs(&[run(1, 1, 60, 65, 3, None)], |_, _| true, |s| s == 3);
-        assert_eq!(out.tracked.len(), 6);
-        assert_eq!(out.tracked[0], ((1, 60, 1), 1, 3));
-        assert_eq!(out.tracked[5], ((1, 65, 1), 0, 3));
-    }
-
-    #[test]
-    fn heightmaps_follow_the_edit() {
-        let mut w = world();
-        let air = |s: u32| s == 0;
-        assert_eq!(w.world_surface(5, 5, |s| air(s.0)), 64);
-        w.edit_runs(&[run(5, 5, 20, 63, 0, None)], |_, _| true, |_| false);
-        assert_eq!(w.world_surface(5, 5, |s| air(s.0)), 20);
-        w.edit_runs(&[run(5, 5, 90, 90, 2, None)], |_, _| true, |_| false);
-        assert_eq!(w.world_surface(5, 5, |s| air(s.0)), 91);
-    }
-
-    #[test]
-    fn runs_follow_each_chunks_own_layout() {
-        use crate::chunk::ColumnLayout;
-        // a data pack's taller dimension: -128..=511
-        let tall = ColumnLayout::new(-128, 640).unwrap();
-        let mut w = World::new(BlockStateId(0), 0);
-        w.chunks
-            .insert((0, 0), Arc::new(Chunk::with_layout(0, 0, tall)));
-        let out = w.edit_runs(&[run(2, 3, -500, 900, 4, None)], |_, _| true, |_| false);
-        assert_eq!(out.changed, 640);
-        let chunk = &w.chunks[&(0, 0)];
-        assert_eq!(chunk.block(2, -128, 3).0, 4);
-        assert_eq!(chunk.block(2, -65, 3).0, 4);
-        assert_eq!(chunk.block(2, 320, 3).0, 4);
-        assert_eq!(chunk.block(2, 511, 3).0, 4);
-        assert!(w.dirty_sections.contains(&(0, 39, 0)));
-        assert!(!w.dirty_sections.contains(&(0, 40, 0)));
-    }
-}

crates/horizon-client-render/src/block_entities.rs

@@ -23,7 +23,7 @@
 //! Which states tick is a table by state id, built by the game from the block
 //! registry; whether a slot is made is decided when the slot is promoted at
 //! the start of the next tick, from the block state then.
-use crate::chunk::block_entity::{BlockEntity, ModContainer, ModEnergyBuffer, ModFluidTanks};
+use crate::chunk::block_entity::BlockEntity;
 use crate::fast_hash::{FxHashMap, FxHashSet};
 use std::collections::HashMap;
 use std::sync::Arc;
@@ -46,7 +46,6 @@ pub enum Ticking {
 #[derive(Default)]
 pub struct BlockEntities {
     map: HashMap<Pos, BlockEntity>,
-    attachments: HashMap<Pos, horizon_world::attachments::Attachments>,
     /// `Level.blockEntityTickers`: positions and the slot each was given.
     tickers: Arc<Vec<(Pos, u32)>>,
     /// `LevelChunk.tickersInLevel`: the live slot of each ticking position.
@@ -71,47 +70,6 @@ pub struct BlockEntities {
     replaced: FxHashSet<Pos>,
     /// `Ticking` by block state id; empty until the game builds it.
     states: Vec<Ticking>,
-    /// The containers of mod blocks' block entities, by block state id;
-    /// built with `states`.
-    mod_containers: FxHashMap<u32, Arc<ModContainer>>,
-    /// The fluid tanks of mod blocks' block entities, by block state id;
-    /// built with `states`, like the containers.
-    mod_fluids: FxHashMap<u32, Arc<ModFluidTanks>>,
-    /// The energy buffers of mod blocks' block entities, by block state id;
-    /// built with `states`, like the containers.
-    mod_energy: FxHashMap<u32, Arc<ModEnergyBuffer>>,
-    /// The positions of the mod block entities (`BlockEntity::Mod`) by chunk,
-    /// for the renderer: the mesher lists block entities by their template,
-    /// which leaves out a mod block whose template has none. One taken out
-    /// (`take`) stays listed until `put` or `remove`.
-    mods: FxHashMap<(i32, i32), FxHashSet<Pos>>,
-    /// The positions of the block entities that draw a bounding box (structure and test
-    /// instance blocks, `shows_box`), so a frame looks at them without scanning the map.
-    /// Like `mods`, one taken out stays listed until `put` or `remove`.
-    boxes: FxHashSet<Pos>,
-}
-
-/// A structure or test instance block: the block entities whose box the frame may draw.
-fn shows_box(entity: &BlockEntity) -> bool {
-    matches!(
-        entity,
-        BlockEntity::StructureBlock(_) | BlockEntity::TestInstanceBlock(_)
-    )
-}
-
-fn chunk_of((x, _, z): Pos) -> (i32, i32) {
-    (x >> 4, z >> 4)
-}
-
-/// Takes `pos` out of its chunk's mod block entity set.
-fn forget_mod(mods: &mut FxHashMap<(i32, i32), FxHashSet<Pos>>, pos: Pos) {
-    let chunk = chunk_of(pos);
-    if let Some(set) = mods.get_mut(&chunk) {
-        set.remove(&pos);
-        if set.is_empty() {
-            mods.remove(&chunk);
-        }
-    }
 }
 
 impl std::ops::Deref for BlockEntities {
@@ -194,27 +152,6 @@ impl BlockEntities {
     pub fn ticking(&self, state: u32) -> Ticking {
         self.states.get(state as usize).copied().unwrap_or_default()
     }
-    pub fn set_mod_containers(&mut self, containers: FxHashMap<u32, Arc<ModContainer>>) {
-        self.mod_containers = containers;
-    }
-    /// The container of a mod block's block entity in block state `state`.
-    pub fn mod_container(&self, state: u32) -> Option<&Arc<ModContainer>> {
-        self.mod_containers.get(&state)
-    }
-    pub fn set_mod_fluids(&mut self, fluids: FxHashMap<u32, Arc<ModFluidTanks>>) {
-        self.mod_fluids = fluids;
-    }
-    /// The fluid tanks of a mod block's block entity in block state `state`.
-    pub fn mod_fluids(&self, state: u32) -> Option<&Arc<ModFluidTanks>> {
-        self.mod_fluids.get(&state)
-    }
-    pub fn set_mod_energy(&mut self, energy: FxHashMap<u32, Arc<ModEnergyBuffer>>) {
-        self.mod_energy = energy;
-    }
-    /// The energy buffer of a mod block's block entity in block state `state`.
-    pub fn mod_energy(&self, state: u32) -> Option<&Arc<ModEnergyBuffer>> {
-        self.mod_energy.get(&state)
-    }
 
     fn next(&mut self) -> u32 {
         let n = self.next_slot;
@@ -233,65 +170,6 @@ impl BlockEntities {
         self.pending.remove(pos);
     }
 
-    /// Attachment map for a live block entity.
-    pub fn attachments_mut(
-        &mut self,
-        pos: Pos,
-    ) -> Option<&mut horizon_world::attachments::Attachments> {
-        if !self.map.contains_key(&pos) && !self.out.contains(&pos) {
-            return None;
-        }
-        Some(self.attachments.entry(pos).or_default())
-    }
-    /// Attachment maps in a loaded chunk, for a save snapshot.
-    pub fn chunk_attachments(
-        &self,
-        x: i32,
-        z: i32,
-    ) -> Vec<(Pos, horizon_world::attachments::Attachments)> {
-        self.attachments
-            .iter()
-            .filter(|(p, _)| p.0 >> 4 == x && p.2 >> 4 == z)
-            .map(|(p, data)| (*p, data.clone()))
-            .collect()
-    }
-    /// Restore a loaded block entity's attachment map.
-    pub fn restore_attachments(&mut self, pos: Pos, data: horizon_world::attachments::Attachments) {
-        if self.map.contains_key(&pos) {
-            self.attachments.insert(pos, data);
-        }
-    }
-    /// Whether any mod block entity is in the map: until one is, a block change
-    /// never looks one up (`LevelAccess::has_mod_block_entity`).
-    pub fn has_mods(&self) -> bool {
-        !self.mods.is_empty()
-    }
-    /// The structure and test instance blocks (a frame draws their boxes), in no order.
-    pub fn boxes(&self) -> impl Iterator<Item = (&Pos, &BlockEntity)> {
-        self.boxes
-            .iter()
-            .filter_map(|pos| Some((pos, self.map.get(pos)?)))
-    }
-    /// Keeps `pos` listed in `boxes` exactly while `entity` shows a box.
-    fn note_box(&mut self, pos: Pos, entity: Option<&BlockEntity>) {
-        if entity.is_some_and(shows_box) {
-            self.boxes.insert(pos);
-        } else {
-            self.boxes.remove(&pos);
-        }
-    }
-    /// The mod block entities within `radius` blocks of `x`, `z` (by chunk, so
-    /// far ones are skipped whole; the caller checks each distance).
-    pub fn mods_near(&self, x: f64, z: f64, radius: f64) -> impl Iterator<Item = &Pos> {
-        let far = move |c: i32, at: f64| {
-            let (lo, hi) = (f64::from(c * 16), f64::from(c * 16 + 16));
-            at < lo - radius || at > hi + radius
-        };
-        self.mods
-            .iter()
-            .filter(move |((cx, cz), _)| !far(*cx, x) && !far(*cz, z))
-            .flat_map(|(_, set)| set)
-    }
     pub fn get_mut(&mut self, pos: &Pos) -> Option<&mut BlockEntity> {
         self.map.get_mut(pos)
     }
@@ -303,33 +181,11 @@ impl BlockEntities {
     }
     /// `LevelChunk.setBlockEntity` (+ `addAndRegisterBlockEntity`): a new
     /// block entity may get a slot; one replacing another keeps its slot.
-    /// One of the same type rewrites it in place (a jukebox taking a disc,
-    /// `/data merge block`), where vanilla keeps the object, so its
-    /// attachments stay; any other replacement starts them over.
     pub fn insert(&mut self, pos: Pos, entity: BlockEntity) -> Option<BlockEntity> {
-        let new_is_mod = matches!(entity, BlockEntity::Mod(_));
-        let same_type = |old: &BlockEntity| match (old, &entity) {
-            (BlockEntity::Mod(old), BlockEntity::Mod(new)) => old.id == new.id,
-            (old, new) => std::mem::discriminant(old) == std::mem::discriminant(new),
-        };
-        if !self.map.get(&pos).is_some_and(same_type) {
-            self.attachments.remove(&pos);
-        }
-        let new_box = shows_box(&entity);
         let old = self.map.insert(pos, entity);
         if old.is_none() {
             self.add(pos);
         }
-        if new_box {
-            self.boxes.insert(pos);
-        } else if old.as_ref().is_some_and(shows_box) {
-            self.boxes.remove(&pos);
-        }
-        if new_is_mod {
-            self.mods.entry(chunk_of(pos)).or_default().insert(pos);
-        } else if matches!(old, Some(BlockEntity::Mod(_))) {
-            forget_mod(&mut self.mods, pos);
-        }
         old
     }
     /// The block entity at `pos`, made by `make` when there is none.
@@ -338,29 +194,15 @@ impl BlockEntities {
         pos: Pos,
         make: impl FnOnce() -> BlockEntity,
     ) -> &mut BlockEntity {
-        let absent = !self.map.contains_key(&pos);
-        if absent {
+        if !self.map.contains_key(&pos) {
             self.add(pos);
         }
-        let entity = self.map.entry(pos).or_insert_with(make);
-        if absent && matches!(entity, BlockEntity::Mod(_)) {
-            self.mods.entry(chunk_of(pos)).or_default().insert(pos);
-        }
-        if absent && shows_box(entity) {
-            self.boxes.insert(pos);
-        }
-        entity
+        self.map.entry(pos).or_insert_with(make)
     }
     /// `LevelChunk.removeBlockEntity`: the block entity and its slot.
     pub fn remove(&mut self, pos: &Pos) -> Option<BlockEntity> {
-        self.attachments.remove(pos);
         self.cancel(pos);
-        let removed = self.map.remove(pos);
-        if matches!(removed, Some(BlockEntity::Mod(_))) {
-            forget_mod(&mut self.mods, *pos);
-        }
-        self.boxes.remove(pos);
-        removed
+        self.map.remove(pos)
     }
     /// The block entity at `pos`, out of the map for a while: its slot stays
     /// for `put` to bring it back (a tick working on it).
@@ -374,10 +216,6 @@ impl BlockEntities {
     /// Brings back what `take` took, in its slot.
     pub fn put(&mut self, pos: Pos, entity: BlockEntity) {
         self.out.remove(&pos);
-        if matches!(entity, BlockEntity::Mod(_)) {
-            self.mods.entry(chunk_of(pos)).or_default().insert(pos);
-        }
-        self.note_box(pos, Some(&entity));
         if self.map.insert(pos, entity).is_none()
             && !self.live.contains_key(&pos)
             && !self.pending.contains_key(&pos)
@@ -388,30 +226,18 @@ impl BlockEntities {
     /// Removes the block entities `keep` refuses, and their slots
     /// (`clearAllBlockEntities` of unloaded chunks).
     pub fn retain(&mut self, mut keep: impl FnMut(&Pos, &mut BlockEntity) -> bool) {
-        let (live, pending, freed, attachments) = (
-            &mut self.live,
-            &mut self.pending,
-            &mut self.freed,
-            &mut self.attachments,
-        );
-        let (mods, boxes) = (&mut self.mods, &mut self.boxes);
+        let (live, pending, freed) = (&mut self.live, &mut self.pending, &mut self.freed);
         self.map.retain(|p, e| {
             let kept = keep(p, e);
             if !kept {
-                attachments.remove(p);
                 *freed |= live.remove(p).is_some();
                 pending.remove(p);
-                forget_mod(mods, *p);
-                boxes.remove(p);
             }
             kept
         });
     }
     pub fn clear(&mut self) {
-        self.attachments.clear();
         self.map.clear();
-        self.mods.clear();
-        self.boxes.clear();
         self.tickers = Arc::default();
         self.live.clear();
         self.added.clear();
@@ -428,18 +254,9 @@ impl BlockEntities {
     pub fn load_chunk(&mut self, entities: Vec<(Pos, BlockEntity)>) {
         let order = chunk_map_order(entities.iter().map(|(p, _)| *p));
         for (p, e) in entities {
-            self.attachments.remove(&p);
-            let new_is_mod = matches!(e, BlockEntity::Mod(_));
-            self.note_box(p, Some(&e));
-            let old = self.map.insert(p, e);
-            if old.is_some() {
+            if self.map.insert(p, e).is_some() {
                 self.replaced.insert(p);
             }
-            if new_is_mod {
-                self.mods.entry(chunk_of(p)).or_default().insert(p);
-            } else if matches!(old, Some(BlockEntity::Mod(_))) {
-                forget_mod(&mut self.mods, p);
-            }
         }
         for p in order {
             self.add(p);
@@ -532,84 +349,6 @@ mod tests {
             .collect()
     }
 
-    fn near(b: &BlockEntities, x: f64, z: f64, radius: f64) -> Vec<Pos> {
-        let mut found: Vec<Pos> = b.mods_near(x, z, radius).copied().collect();
-        found.sort();
-        found
-    }
-    #[test]
-    fn mod_block_entities_are_listed_by_chunk_until_they_go() {
-        let mut b = level();
-        let modded = || BlockEntity::Mod(Box::default());
-        b.insert((1, 64, 1), modded());
-        b.insert((200, 64, 1), modded());
-        b.insert((2, 64, 2), hopper());
-        b.get_or_insert_with((3, 64, 3), modded);
-        b.load_chunk(vec![((4, 64, 4), modded()), ((5, 64, 5), hopper())]);
-        // Only mods, and only chunks within reach.
-        assert_eq!(
-            near(&b, 0.0, 0.0, 64.0),
-            [(1, 64, 1), (3, 64, 3), (4, 64, 4)]
-        );
-        assert_eq!(near(&b, 200.0, 0.0, 8.0), [(200, 64, 1)]);
-        // Taken out for a tick, still listed; removed or replaced, gone.
-        let taken = b.take(&(1, 64, 1)).unwrap();
-        assert_eq!(near(&b, 0.0, 0.0, 64.0).len(), 3);
-        b.put((1, 64, 1), taken);
-        b.remove(&(3, 64, 3));
-        b.insert((4, 64, 4), hopper());
-        assert_eq!(near(&b, 0.0, 0.0, 64.0), [(1, 64, 1)]);
-        b.retain(|p, _| p.0 != 1);
-        assert!(near(&b, 0.0, 0.0, 64.0).is_empty());
-        b.clear();
-        assert!(near(&b, 200.0, 0.0, 8.0).is_empty());
-    }
-    #[test]
-    fn attachments_follow_block_entity_lifetime() {
-        use horizon_world::attachments::AttachmentType;
-        let ty = AttachmentType {
-            namespace: "test",
-            name: "value",
-            default: || 0,
-            codec: None,
-            copy_on_death: false,
-        };
-        let p = (1, 64, 2);
-        let mut entities = level();
-        assert!(entities.attachments_mut(p).is_none());
-        entities.insert(p, hopper());
-        entities.attachments_mut(p).unwrap().set(&ty, 4).unwrap();
-        let held = entities.take(&p).unwrap();
-        entities.put(p, held);
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(4));
-        entities.insert(p, hopper());
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(4));
-        let machine = |id: &str| {
-            BlockEntity::Mod(Box::new(
-                crate::chunk::block_entity::ModBlockEntityFields {
-                    id: id.into(),
-                    ..Default::default()
-                }
-                .into(),
-            ))
-        };
-        entities.insert(p, machine("test:a"));
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(0));
-        entities.attachments_mut(p).unwrap().set(&ty, 4).unwrap();
-        entities.insert(p, machine("test:a"));
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(4));
-        entities.insert(p, machine("test:b"));
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(0));
-        entities.attachments_mut(p).unwrap().set(&ty, 4).unwrap();
-        entities.remove(&p);
-        entities.insert(p, hopper());
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(0));
-        entities.attachments_mut(p).unwrap().set(&ty, 5).unwrap();
-        entities.retain(|_, _| false);
-        entities.insert(p, hopper());
-        assert_eq!(entities.attachments_mut(p).unwrap().get(&ty), Ok(0));
-    }
-
     #[test]
     fn slots_follow_vanilla_lifecycle() {
         let mut b = level();
@@ -694,43 +433,4 @@ mod tests {
         b.state_changed(p, 2, 1);
         assert_eq!(order(&mut b, &s), [q, p]);
     }
-
-    #[test]
-    fn boxes_list_exactly_the_structure_and_test_blocks() {
-        let test_block = || BlockEntity::TestInstanceBlock(Box::default());
-        let listed = |b: &BlockEntities| {
-            let mut v: Vec<Pos> = b.boxes().map(|(p, _)| *p).collect();
-            v.sort();
-            v
-        };
-        let mut b = level();
-        let (p, q, r) = ((0, 0, 0), (1, 0, 0), (2, 0, 0));
-        b.insert(p, test_block());
-        b.insert(q, hopper());
-        assert_eq!(listed(&b), [p]);
-        // Replaced by another kind, and back.
-        b.insert(p, hopper());
-        assert_eq!(listed(&b), []);
-        b.insert(q, test_block());
-        b.get_or_insert_with(r, test_block);
-        assert_eq!(listed(&b), [q, r]);
-        // Taken out: not shown until put back; put back as another kind: gone.
-        let taken = b.take(&q).unwrap();
-        assert_eq!(listed(&b), [r]);
-        b.put(q, taken);
-        assert_eq!(listed(&b), [q, r]);
-        let taken = b.take(&r).unwrap();
-        drop(taken);
-        b.put(r, hopper());
-        assert_eq!(listed(&b), [q]);
-        b.remove(&q);
-        assert_eq!(listed(&b), []);
-        b.load_chunk(vec![(p, test_block()), (q, hopper())]);
-        assert_eq!(listed(&b), [p]);
-        b.retain(|pos, _| *pos != p);
-        assert_eq!(listed(&b), []);
-        b.insert(r, test_block());
-        b.clear();
-        assert!(b.boxes.is_empty());
-    }
 }

crates/horizon-client-render/src/block_entity_cem.rs

@@ -1,630 +0,0 @@
-//! OptiFine custom entity models over the block entities' models (`block_entity_render`'s
-//! `MODELS`): `chest.jem`, `shulker_box.jem`, `banner.jem`, `bell.jem`, `head_zombie.jem`... (the
-//! "Block entity name" table of OptiFine's `cem_model.txt`, and Entity Model Features' one-file
-//! `banner`), found and read as the mobs' are ([`horizon_optifine::cem::files`]). Each entry
-//! replaces or joins the boxes of the vanilla part it names and takes its `scale`; animations
-//! don't run yet. A `.jem`'s texture paints the models it reshapes instead of vanilla's when the
-//! atlas has it.
-//!
-//! An entry's part is OptiFine's name for it, else the vanilla part's own name. Trapped and
-//! ender chests take only their own file, and copper chests (no CEM name) keep vanilla's chest.
-//! Lectern and enchanting-table books take theirs, else `book`. Signs, hanging signs and beds are
-//! block models here, so their files are not read; copper golem statues have no CEM name.
-
-use crate::block_entity_render::ModelPart;
-use horizon_optifine::cem::{
-    files::{atlas_name, jem_files, load_jem},
-    model::{Bone, EntityModel},
-};
-use std::{
-    collections::{BTreeMap, HashMap, HashSet},
-    path::Path,
-};
-
-/// One model the renderer draws, the CEM names that reshape it, best first, and OptiFine's
-/// names for its vanilla parts.
-struct Target {
-    key: &'static str,
-    /// The vanilla model it starts from: `key` itself, or the one a block the renderer tells
-    /// apart shares (a trapped chest's is the chest's).
-    base: &'static str,
-    names: &'static [&'static str],
-    parts: &'static [(&'static str, &'static str)],
-}
-
-const CHEST: &[(&str, &str)] = &[
-    ("root", "root"),
-    ("base", "bottom"),
-    ("lid", "lid"),
-    ("knob", "lock"),
-];
-const SHULKER: &[(&str, &str)] = &[("root", "root"), ("base", "base"), ("lid", "lid")];
-const BANNER: &[(&str, &str)] = &[("stand", "pole"), ("top", "bar")];
-const FLAG: &[(&str, &str)] = &[("slate", "flag")];
-const HEAD: &[(&str, &str)] = &[("root", "root"), ("head", "head")];
-const DRAGON: &[(&str, &str)] = &[("root", "root"), ("head", "head"), ("jaw", "jaw")];
-const PIGLIN: &[(&str, &str)] = &[
-    ("root", "root"),
-    ("head", "head"),
-    ("left_ear", "left_ear"),
-    ("right_ear", "right_ear"),
-];
-const BELL: &[(&str, &str)] = &[
-    ("root", "root"),
-    ("body", "bell_body"),
-    ("base", "bell_base"),
-];
-const BOOK: &[(&str, &str)] = &[
-    ("root", "root"),
-    ("cover_right", "right_lid"),
-    ("cover_left", "left_lid"),
-    ("pages_right", "right_pages"),
-    ("pages_left", "left_pages"),
-    ("flipping_page_right", "flip_page1"),
-    ("flipping_page_left", "flip_page2"),
-    ("book_spine", "seam"),
-];
-const POT_BASE: &[(&str, &str)] = &[("neck", "neck"), ("top", "top"), ("bottom", "bottom")];
-const POT_SIDES: &[(&str, &str)] = &[
-    ("front", "front"),
-    ("back", "back"),
-    ("left", "left"),
-    ("right", "right"),
-];
-
-const fn model(
-    key: &'static str,
-    names: &'static [&'static str],
-    parts: &'static [(&'static str, &'static str)],
-) -> Target {
-    Target {
-        key,
-        base: key,
-        names,
-        parts,
-    }
-}
-const fn copy(
-    key: &'static str,
-    base: &'static str,
-    names: &'static [&'static str],
-    parts: &'static [(&'static str, &'static str)],
-) -> Target {
-    Target {
-        key,
-        base,
-        names,
-        parts,
-    }
-}
-
-/// In order: a copy comes after its base.
-const TARGETS: &[Target] = &[
-    model("chest", &["chest"], CHEST),
-    model("double_chest_left", &["chest_left"], CHEST),
-    model("double_chest_right", &["chest_right"], CHEST),
-    copy("trapped_chest", "chest", &["trapped_chest"], CHEST),
-    copy(
-        "trapped_chest_left",
-        "double_chest_left",
-        &["trapped_chest_left"],
-        CHEST,
-    ),
-    copy(
-        "trapped_chest_right",
-        "double_chest_right",
-        &["trapped_chest_right"],
-        CHEST,
-    ),
-    copy("ender_chest", "chest", &["ender_chest"], CHEST),
-    model("shulker_box", &["shulker_box"], SHULKER),
-    model("standing_banner", &["banner_base", "banner"], BANNER),
-    model("wall_banner", &["banner_base", "banner"], BANNER),
-    model("standing_banner_flag", &["banner_flag", "banner"], FLAG),
-    model("wall_banner_flag", &["banner_flag", "banner"], FLAG),
-    model("skeleton_skull", &["head_skeleton"], HEAD),
-    model("wither_skeleton_skull", &["head_wither_skeleton"], HEAD),
-    model("zombie_head", &["head_zombie"], HEAD),
-    model("creeper_head", &["head_creeper"], HEAD),
-    model("dragon_skull", &["head_dragon"], DRAGON),
-    model("piglin_head", &["head_piglin"], PIGLIN),
-    model("player_head", &["head_player"], HEAD),
-    model("bell", &["bell"], BELL),
-    model("book", &["enchanting_book", "book"], BOOK),
-    copy("lectern_book", "book", &["lectern_book", "book"], BOOK),
-    model("conduit_shell", &["conduit"], &[("base", "shell")]),
-    model("conduit_cage", &["conduit"], &[("cage", "shell")]),
-    model("conduit_wind", &["conduit"], &[("wind", "wind")]),
-    model("conduit_eye", &["conduit"], &[("eye", "eye")]),
-    model("decorated_pot_base", &["decorated_pot"], POT_BASE),
-    model("decorated_pot_sides", &["decorated_pot"], POT_SIDES),
-];
-
-/// Every model, reshaped or vanilla's, and the atlas names of the `.jem` textures by model.
-pub type Reshaped = (
-    HashMap<&'static str, ModelPart>,
-    HashMap<&'static str, String>,
-);
-
-/// The models the packs under `root` reshape, over `vanilla`'s; None when no block entity has
-/// a `.jem` there.
-pub fn reshape(root: &Path, vanilla: &HashMap<&'static str, ModelPart>) -> Option<Reshaped> {
-    let (reshaped, unused) = reshape_all(root, vanilla)?;
-    for (path, part) in unused {
-        log::warn!("Horizon: custom entity model {path}: no part {part}");
-    }
-    Some(reshaped)
-}
-
-/// [`reshape`]'s models, and each file's entries whose part none of the models it reshapes has.
-fn reshape_all(
-    root: &Path,
-    vanilla: &HashMap<&'static str, ModelPart>,
-) -> Option<(Reshaped, Vec<(String, String)>)> {
-    let files = jem_files(root);
-    let named = |t: &Target| t.names.iter().any(|n| files.contains_key(*n));
-    if !TARGETS.iter().any(named) {
-        return None;
-    }
-    let mut models = vanilla.clone();
-    let mut textures = HashMap::new();
-    let mut reshaped = HashSet::new();
-    // Each file parsed once; which of its entries found a part in some model.
-    let mut parsed: HashMap<&str, Option<EntityModel>> = HashMap::new();
-    let mut used: BTreeMap<&str, Vec<bool>> = BTreeMap::new();
-    for t in TARGETS {
-        let Some(model) = vanilla.get(t.base) else {
-            continue;
-        };
-        let found = t
-            .names
-            .iter()
-            .flat_map(|name| files.get(*name).into_iter().flatten())
-            .map(String::as_str)
-            .find(|&path| {
-                parsed
-                    .entry(path)
-                    .or_insert_with(|| load_jem(root, path))
-                    .is_some()
-            });
-        let Some(path) = found else {
-            // A copy of a reshaped base that has no file of its own stays vanilla.
-            if t.key != t.base && reshaped.contains(t.base) {
-                models.insert(t.key, model.clone());
-            }
-            continue;
-        };
-        let Some(Some(jem)) = parsed.get(path) else {
-            continue;
-        };
-        let mut out = model.clone();
-        let hits = apply(&mut out, jem, t.parts);
-        // A file shared by several models (the conduit's, the pot's) paints only the models
-        // it reshapes: vanilla geometry keeps its own texture's layout.
-        let reshapes = hits.iter().any(|hit| *hit);
-        let marks = used
-            .entry(path)
-            .or_insert_with(|| vec![false; jem.parts.len()]);
-        for (mark, hit) in marks.iter_mut().zip(hits) {
-            *mark |= hit;
-        }
-        models.insert(t.key, out);
-        reshaped.insert(t.key);
-        if reshapes && let Some(texture) = jem.texture.as_deref().and_then(atlas_name) {
-            textures.insert(t.key, texture);
-        }
-    }
-    let mut unused = Vec::new();
-    for (path, marks) in &used {
-        let Some(Some(jem)) = parsed.get(path) else {
-            continue;
-        };
-        for (p, _) in jem.parts.iter().zip(marks).filter(|(_, hit)| !**hit) {
-            unused.push(((*path).to_owned(), p.part.clone()));
-        }
-    }
-    Some(((models, textures), unused))
-}
-
-/// `jem`'s entries on `model`, OptiFine's part names read through `parts`, else as the vanilla
-/// part's own name: a replacing entry clears its part's boxes, and each joins the part as a child
-/// `cem#<n>`. Which entries found their part.
-fn apply(model: &mut ModelPart, jem: &EntityModel, parts: &[(&str, &str)]) -> Vec<bool> {
-    let mut count = 0;
-    let mut hits = Vec::with_capacity(jem.parts.len());
-    for p in &jem.parts {
-        let mapped = parts.iter().find(|(of, _)| *of == p.part).map(|&(_, v)| v);
-        let target = match mapped {
-            Some(vanilla) if find_mut(model, vanilla).is_some() => vanilla,
-            _ => p.part.as_str(),
-        };
-        let Some(node) = find_mut(model, target) else {
-            hits.push(false);
-            continue;
-        };
-        if !p.attach {
-            node.polygons.clear();
-        }
-        let (name, mut bone) = part(&p.bone, &mut count);
-        bone.pose[6..9].fill(p.scale);
-        node.children.push((name, bone));
-        hits.push(true);
-    }
-    hits
-}
-
-/// The model itself for `root`, else its first part named `name`, depth first.
-fn find_mut<'a>(model: &'a mut ModelPart, name: &str) -> Option<&'a mut ModelPart> {
-    fn child<'a>(part: &'a mut ModelPart, name: &str) -> Option<&'a mut ModelPart> {
-        part.children.iter_mut().find_map(|(n, c)| {
-            if n.as_str() == name {
-                Some(c)
-            } else {
-                child(c, name)
-            }
-        })
-    }
-    if name == "root" {
-        return Some(model);
-    }
-    child(model, name)
-}
-
-/// A baked bone as a model part, named `cem#<n>`: unique in the model, so no vanilla pose
-/// change by name reaches it.
-fn part(bone: &Bone, count: &mut usize) -> (String, ModelPart) {
-    let name = format!("cem#{count}");
-    *count += 1;
-    let [x, y, z] = bone.pivot;
-    let [rx, ry, rz] = bone.rotation;
-    let out = ModelPart {
-        pose: [x, y, z, rx, ry, rz, 1.0, 1.0, 1.0],
-        polygons: bone.quads.iter().map(|q| q.vertices).collect(),
-        children: bone.children.iter().map(|c| part(c, count)).collect(),
-    };
-    (name, out)
-}
-
-#[cfg(test)]
-pub(crate) mod tests {
-    use super::*;
-    use std::{collections::BTreeSet, fs};
-
-    /// A part with one face and `children`.
-    pub(crate) fn plane(children: Vec<(&str, ModelPart)>) -> ModelPart {
-        ModelPart {
-            pose: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1.0, 1.0, 1.0],
-            polygons: vec![[[0.0; 5]; 4]],
-            children: children
-                .into_iter()
-                .map(|(n, c)| (n.to_owned(), c))
-                .collect(),
-        }
-    }
-    pub(crate) fn chest() -> ModelPart {
-        let mut root = plane(vec![
-            ("bottom", plane(vec![])),
-            ("lid", plane(vec![])),
-            ("lock", plane(vec![])),
-        ]);
-        root.polygons.clear();
-        root
-    }
-    pub(crate) const BOX: &str =
-        r#""boxes": [{"coordinates": [0, 0, 0, 1, 1, 1], "textureOffset": [0, 0]}]"#;
-    /// A fresh pack folder named for `test`, holding `files` under `assets/minecraft/`.
-    pub(crate) fn pack(test: &str, files: &[(&str, String)]) -> std::path::PathBuf {
-        let root =
-            std::env::temp_dir().join(format!("horizon-be-cem-{test}-{}", std::process::id()));
-        let _ = fs::remove_dir_all(&root);
-        for (path, text) in files {
-            let path = root.join("assets/minecraft").join(path);
-            fs::create_dir_all(path.parent().unwrap()).unwrap();
-            fs::write(path, text).unwrap();
-        }
-        root
-    }
-    /// A `.jem` replacing each of `parts` with one box.
-    fn jem(parts: &[&str]) -> String {
-        let entries: Vec<_> = parts
-            .iter()
-            .map(|p| format!(r#"{{"part": "{p}", {BOX}}}"#))
-            .collect();
-        format!(r#"{{"models": [{}]}}"#, entries.join(", "))
-    }
-    /// A `.jem` replacing each of `parts` with a box of its own: the `i`th is `i + 1` pixels
-    /// deep, so a part that took another entry's box shows.
-    fn jem_sized(parts: &[&str]) -> String {
-        let entries: Vec<_> = parts
-            .iter()
-            .enumerate()
-            .map(|(i, p)| {
-                let depth = i + 1;
-                format!(
-                    r#"{{"part": "{p}", "boxes": [{{"coordinates": [0, 0, 0, 1, 1, {depth}], "textureOffset": [0, 0]}}]}}"#
-                )
-            })
-            .collect();
-        format!(r#"{{"models": [{}]}}"#, entries.join(", "))
-    }
-    /// How deep (z) the custom box under `model`'s part `name` is.
-    fn depth(model: &ModelPart, name: &str) -> f32 {
-        let part = model.child(name).unwrap();
-        let zs = part
-            .children
-            .iter()
-            .flat_map(|(_, c)| c.polygons.iter().flatten().map(|v| v[2]));
-        let (lo, hi) = zs.fold((f32::MAX, f32::MIN), |(lo, hi), z| (lo.min(z), hi.max(z)));
-        hi - lo
-    }
-    /// Whether `model`'s part `name` was replaced by one custom box: its own face gone, and one
-    /// child of a box's six faces.
-    fn replaced(model: &ModelPart, name: &str) -> bool {
-        let part = model.child(name).unwrap();
-        match part.children.as_slice() {
-            [(_, only)] => part.polygons.is_empty() && only.polygons.len() == 6,
-            _ => false,
-        }
-    }
-
-    #[test]
-    fn every_optifine_part_name_lands_on_its_vanilla_part() {
-        // File, OptiFine's part, the model it reshapes, vanilla's part there.
-        let cases = [
-            ("chest", "base", "chest", "bottom"),
-            ("chest", "lid", "chest", "lid"),
-            ("chest", "knob", "chest", "lock"),
-            ("chest_left", "base", "double_chest_left", "bottom"),
-            ("chest_left", "lid", "double_chest_left", "lid"),
-            ("chest_left", "knob", "double_chest_left", "lock"),
-            ("chest_right", "base", "double_chest_right", "bottom"),
-            ("chest_right", "lid", "double_chest_right", "lid"),
-            ("chest_right", "knob", "double_chest_right", "lock"),
-            ("trapped_chest", "base", "trapped_chest", "bottom"),
-            ("trapped_chest", "knob", "trapped_chest", "lock"),
-            ("trapped_chest_left", "base", "trapped_chest_left", "bottom"),
-            ("trapped_chest_left", "knob", "trapped_chest_left", "lock"),
-            (
-                "trapped_chest_right",
-                "base",
-                "trapped_chest_right",
-                "bottom",
-            ),
-            ("trapped_chest_right", "knob", "trapped_chest_right", "lock"),
-            ("ender_chest", "base", "ender_chest", "bottom"),
-            ("ender_chest", "knob", "ender_chest", "lock"),
-            ("shulker_box", "base", "shulker_box", "base"),
-            ("shulker_box", "lid", "shulker_box", "lid"),
-            ("banner", "stand", "standing_banner", "pole"),
-            ("banner", "top", "standing_banner", "bar"),
-            ("banner", "top", "wall_banner", "bar"),
-            ("banner", "slate", "standing_banner_flag", "flag"),
-            ("banner", "slate", "wall_banner_flag", "flag"),
-            ("head_skeleton", "head", "skeleton_skull", "head"),
-            (
-                "head_wither_skeleton",
-                "head",
-                "wither_skeleton_skull",
-                "head",
-            ),
-            ("head_zombie", "head", "zombie_head", "head"),
-            ("head_creeper", "head", "creeper_head", "head"),
-            ("head_dragon", "head", "dragon_skull", "head"),
-            ("head_dragon", "jaw", "dragon_skull", "jaw"),
-            ("head_piglin", "head", "piglin_head", "head"),
-            ("head_piglin", "left_ear", "piglin_head", "left_ear"),
-            ("head_piglin", "right_ear", "piglin_head", "right_ear"),
-            ("head_player", "head", "player_head", "head"),
-            ("bell", "body", "bell", "bell_body"),
-            ("bell", "base", "bell", "bell_base"),
-            ("enchanting_book", "cover_right", "book", "right_lid"),
-            ("enchanting_book", "cover_left", "book", "left_lid"),
-            ("enchanting_book", "pages_right", "book", "right_pages"),
-            ("enchanting_book", "pages_left", "book", "left_pages"),
-            (
-                "enchanting_book",
-                "flipping_page_right",
-                "book",
-                "flip_page1",
-            ),
-            (
-                "enchanting_book",
-                "flipping_page_left",
-                "book",
-                "flip_page2",
-            ),
-            ("enchanting_book", "book_spine", "book", "seam"),
-            ("lectern_book", "cover_right", "lectern_book", "right_lid"),
-            ("lectern_book", "pages_left", "lectern_book", "left_pages"),
-            (
-                "lectern_book",
-                "flipping_page_right",
-                "lectern_book",
-                "flip_page1",
-            ),
-            ("lectern_book", "book_spine", "lectern_book", "seam"),
-            ("conduit", "base", "conduit_shell", "shell"),
-            ("conduit", "cage", "conduit_cage", "shell"),
-            ("conduit", "wind", "conduit_wind", "wind"),
-            ("conduit", "eye", "conduit_eye", "eye"),
-            ("decorated_pot", "neck", "decorated_pot_base", "neck"),
-            ("decorated_pot", "top", "decorated_pot_base", "top"),
-            ("decorated_pot", "bottom", "decorated_pot_base", "bottom"),
-            ("decorated_pot", "front", "decorated_pot_sides", "front"),
-            ("decorated_pot", "back", "decorated_pot_sides", "back"),
-            ("decorated_pot", "left", "decorated_pot_sides", "left"),
-            ("decorated_pot", "right", "decorated_pot_sides", "right"),
-        ];
-        // One file per name with each of its parts, and a stub of each model holding its parts
-        // (chest models all of theirs, so a misplaced entry shows).
-        let mut files: BTreeMap<&str, BTreeSet<&str>> = BTreeMap::new();
-        let mut trees: BTreeMap<&str, BTreeSet<&str>> = BTreeMap::new();
-        for (file, part, key, vanilla) in cases {
-            files.entry(file).or_default().insert(part);
-            trees.entry(key).or_default().insert(vanilla);
-        }
-        for key in ["chest", "double_chest_left", "double_chest_right"] {
-            trees
-                .entry(key)
-                .or_default()
-                .extend(["bottom", "lid", "lock"]);
-        }
-        let files_by_name = files.clone();
-        let files: Vec<_> = files
-            .iter()
-            .map(|(file, parts)| {
-                let parts: Vec<_> = parts.iter().copied().collect();
-                (format!("optifine/cem/{file}.jem"), jem_sized(&parts))
-            })
-            .collect();
-        let files: Vec<_> = files.iter().map(|(p, t)| (p.as_str(), t.clone())).collect();
-        let root = pack("parts", &files);
-        let vanilla: HashMap<&'static str, ModelPart> = trees
-            .iter()
-            .map(|(key, parts)| {
-                let parts = parts.iter().map(|p| (*p, plane(vec![]))).collect();
-                (*key, plane(parts))
-            })
-            .collect();
-        let result = reshape_all(&root, &vanilla);
-        fs::remove_dir_all(&root).unwrap();
-        let ((models, _), unused) = result.unwrap();
-        for (file, part, key, vanilla) in cases {
-            assert!(
-                replaced(&models[key], vanilla),
-                "{file}.jem {part}: {key} {vanilla}"
-            );
-            // The box is this entry's own: swapped names (left and right, body and base) show.
-            let own = files_by_name[file].iter().position(|p| *p == part).unwrap() + 1;
-            assert_eq!(
-                depth(&models[key], vanilla),
-                own as f32,
-                "{file}.jem {part}: {key} {vanilla}"
-            );
-        }
-        assert_eq!(unused, Vec::new());
-    }
-
-    #[test]
-    fn a_chest_jem_reshapes_the_chest_alone_and_warns_of_entries_without_a_part() {
-        let root = pack(
-            "chest",
-            &[(
-                "optifine/cem/chest.jem",
-                format!(
-                    r#"{{"texture": "textures/entity/chest/fancy.png", "models": [
-                        {{"part": "lid", {BOX}}},
-                        {{"part": "knob", "attach": true, "scale": 2, {BOX}}},
-                        {{"part": "bottom", {BOX}}},
-                        {{"part": "tail", {BOX}}}]}}"#
-                ),
-            )],
-        );
-        let vanilla: HashMap<_, _> = [("chest", chest()), ("double_chest_left", chest())].into();
-        let result = reshape_all(&root, &vanilla);
-        fs::remove_dir_all(&root).unwrap();
-        let ((models, textures), unused) = result.unwrap();
-        let chest = &models["chest"];
-        // Replaced: the lid's own face goes and the custom box (6 faces) joins it.
-        assert!(replaced(chest, "lid"));
-        // `bottom` is no OptiFine name but vanilla's own: it reaches the part as well.
-        assert!(replaced(chest, "bottom"));
-        // Attached: the lock keeps its face beside the scaled box.
-        let lock = chest.child("lock").unwrap();
-        assert_eq!((lock.polygons.len(), lock.children.len()), (1, 1));
-        assert_eq!(lock.children[0].1.pose[6..], [2.0, 2.0, 2.0]);
-        // `tail` names no chest part: the one warning.
-        assert_eq!(
-            unused,
-            [(
-                "assets/minecraft/optifine/cem/chest.jem".to_owned(),
-                "tail".to_owned()
-            )]
-        );
-        // The double chest has no file, nor do trapped and ender chests: vanilla's own, and
-        // only the chest takes the texture.
-        for key in ["double_chest_left", "trapped_chest", "ender_chest"] {
-            let lid = models[key].child("lid").unwrap();
-            assert_eq!((lid.polygons.len(), lid.children.len()), (1, 0), "{key}");
-        }
-        assert_eq!(
-            textures,
-            HashMap::from([("chest", "entity/chest/fancy".to_owned())])
-        );
-    }
-
-    #[test]
-    fn banners_split_one_file_and_books_fall_back() {
-        let root = pack(
-            "banner",
-            &[
-                ("optifine/cem/banner.jem", jem(&["stand", "top", "slate"])),
-                ("emf/cem/enchanting_book.jem", jem(&["cover_left"])),
-            ],
-        );
-        let banner = plane(vec![("pole", plane(vec![])), ("bar", plane(vec![]))]);
-        let wall = plane(vec![("bar", plane(vec![]))]);
-        let flag = plane(vec![("flag", plane(vec![]))]);
-        let book = plane(vec![("left_lid", plane(vec![]))]);
-        let vanilla: HashMap<_, _> = [
-            ("standing_banner", banner),
-            ("wall_banner", wall),
-            ("wall_banner_flag", flag),
-            ("book", book),
-        ]
-        .into();
-        let result = reshape_all(&root, &vanilla);
-        fs::remove_dir_all(&root).unwrap();
-        let ((models, textures), unused) = result.unwrap();
-        assert!(replaced(&models["standing_banner"], "pole"));
-        assert!(replaced(&models["standing_banner"], "bar"));
-        assert!(replaced(&models["wall_banner"], "bar"));
-        assert!(replaced(&models["wall_banner_flag"], "flag"));
-        assert!(replaced(&models["book"], "left_lid"));
-        // The lectern's book has no file of its own nor `book.jem`: vanilla's.
-        let lectern = models["lectern_book"].child("left_lid").unwrap();
-        assert_eq!((lectern.polygons.len(), lectern.children.len()), (1, 0));
-        assert!(textures.is_empty());
-        // Each entry found its part in one of the models: no warning.
-        assert_eq!(unused, Vec::new());
-    }
-
-    #[test]
-    fn book_jem_reshapes_the_lectern_book_without_its_own_file() {
-        let root = pack("book", &[("optifine/cem/book.jem", jem(&["cover_left"]))]);
-        let vanilla: HashMap<_, _> = [("book", plane(vec![("left_lid", plane(vec![]))]))].into();
-        let result = reshape(&root, &vanilla);
-        fs::remove_dir_all(&root).unwrap();
-        let (models, _) = result.unwrap();
-        assert!(replaced(&models["book"], "left_lid"));
-        assert!(replaced(&models["lectern_book"], "left_lid"));
-    }
-
-    #[test]
-    fn a_shared_file_paints_only_the_models_it_reshapes() {
-        // The conduit's file reshapes its eye alone: the shell, cage and wind keep their
-        // vanilla geometry and so their own textures.
-        let file = format!(
-            r#"{{"texture": "textures/entity/conduit/custom.png", "models": [{{"part": "eye", {BOX}}}]}}"#
-        );
-        let root = pack("conduit", &[("optifine/cem/conduit.jem", file)]);
-        let vanilla: HashMap<_, _> = [
-            "conduit_shell",
-            "conduit_cage",
-            "conduit_wind",
-            "conduit_eye",
-        ]
-        .map(|key| {
-            let part = if key == "conduit_eye" { "eye" } else { "shell" };
-            (key, plane(vec![(part, plane(vec![]))]))
-        })
-        .into();
-        let result = reshape(&root, &vanilla);
-        fs::remove_dir_all(&root).unwrap();
-        let (models, textures) = result.unwrap();
-        assert!(replaced(&models["conduit_eye"], "eye"));
-        let painted: BTreeSet<_> = textures.keys().copied().collect();
-        assert_eq!(painted, BTreeSet::from(["conduit_eye"]));
-        assert_eq!(textures["conduit_eye"], "entity/conduit/custom");
-    }
-}

crates/horizon-client-render/src/block_entity_render.rs

@@ -20,12 +20,7 @@ use horizon_world::{
     registry::{BlockRegistry, BlockStateId},
 };
 use serde_json::Value;
-use std::{
-    collections::HashMap,
-    f32::consts::PI,
-    path::Path,
-    sync::{Arc, Mutex, PoisonError, RwLock},
-};
+use std::{collections::HashMap, f32::consts::PI, path::Path, sync::Mutex};
 
 /// One baked `ModelPart`: initial pose, textured polygons (pixel units,
 /// normalized UVs) and named children.
@@ -125,12 +120,7 @@ pub struct Paint {
     pub tint: u32,
     pub light: u32,
     pub lights: (Vec3, Vec3),
-    /// The texture's OptiFine emissive overlay (`_e`): drawn again over it at full
-    /// brightness, with the same shading.
-    pub glow: Option<Rect>,
 }
-/// Full sky and block light, in [`vertex_light`]'s form.
-const FULL_BRIGHT: u32 = 240 | (240 << 8);
 /// `ModelPart.render`: translate by pose/16, rotate ZYX, scale; children inherit.
 /// `adjust` may change a part's pose by name (`setupAnim`); `skip` hides parts.
 pub fn draw_part(
@@ -152,7 +142,6 @@ pub fn draw_part(
         tint,
         light,
         lights,
-        glow,
     } = paint;
     for poly in &part.polygons {
         let pos = poly.map(|v| m.transform_point3(Vec3::new(v[0], v[1], v[2]) / 16.0));
@@ -166,19 +155,17 @@ pub fn draw_part(
             normal
         };
         let color = pack_color(tint, 255, diffuse(normal, lights));
-        for (r, light) in std::iter::once((r, light)).chain(glow.map(|g| (g, FULL_BRIGHT))) {
-            for (v, position) in poly.iter().zip(pos) {
-                out.push(Vertex {
-                    normal: [0; 4],
-                    pos: position.to_array(),
-                    uv: [r.u0 + (r.u1 - r.u0) * v[3], r.v0 + (r.v1 - r.v0) * v[4]],
-                    layer: 0,
-                    color,
-                    light,
+        for (v, position) in poly.iter().zip(pos) {
+            out.push(Vertex {
+                normal: [0; 4],
+                pos: position.to_array(),
+                uv: [r.u0 + (r.u1 - r.u0) * v[3], r.v0 + (r.v1 - r.v0) * v[4]],
+                layer: 0,
+                color,
+                light,
 
-                    glint_uv: [0.0, 0.0],
-                });
-            }
+                glint_uv: [0.0, 0.0],
+            });
         }
     }
     for (child_name, child) in &part.children {
@@ -784,8 +771,6 @@ pub struct Scene<'a> {
     pub max_y: i32,
     pub world: &'a World,
     pub sprites: &'a HashMap<String, Rect>,
-    /// The packs' OptiFine emissive overlays of the sprites.
-    pub emissive: &'a horizon_optifine::emissive::Emissive,
     pub nether: bool,
     /// Chest lid openness (`ChestLidController.getOpenNess`) at a position.
     pub lid: &'a dyn Fn([i32; 3]) -> f32,
@@ -804,105 +789,17 @@ pub struct Scene<'a> {
     pub glyphs: u64,
 }
 
-/// Empty by default (a dedicated server): no state has a block entity model.
-#[derive(Default)]
 pub struct BlockEntityRenderer {
-    vanilla: Arc<BlockEntityShapes>,
-    /// What draws: `vanilla`, or the packs' custom entity models over it.
-    shapes: RwLock<Arc<BlockEntityShapes>>,
+    models: HashMap<&'static str, ModelPart>,
     kinds: Vec<Kind>,
+    // Closed chest geometry: dimension lighting, chest part, horizontal facing.
+    closed_chests: [[[Vec<Vertex>; 4]; 3]; 2],
     /// Item id to its `PROVIDES_POTTERY_PATTERN` side texture (`Sheets.DECORATED_POT_MAPPER`).
     pot_patterns: HashMap<String, String>,
     /// `Block.shouldRenderFace` for End gateway faces (its occlusion pair cache needs a lock).
     visibility: Option<Mutex<FaceVisibility>>,
     sign_texts: Mutex<SignTexts>,
 }
-/// The block-entity models and what is baked from them: vanilla's, or the packs' custom entity
-/// models over them ([`crate::block_entity_cem`]).
-#[derive(Default)]
-pub struct BlockEntityShapes {
-    models: HashMap<&'static str, ModelPart>,
-    /// Closed chest geometry by chest model: dimension lighting, horizontal facing.
-    closed_chests: HashMap<&'static str, [[Vec<Vertex>; 4]; 2]>,
-    /// A `.jem`'s texture (atlas name) by model, drawn instead of vanilla's.
-    textures: HashMap<&'static str, String>,
-}
-/// The chest models, each baked with its lid closed.
-const CHEST_MODELS: [&str; 7] = [
-    "chest",
-    "double_chest_left",
-    "double_chest_right",
-    "trapped_chest",
-    "trapped_chest_left",
-    "trapped_chest_right",
-    "ender_chest",
-];
-impl BlockEntityShapes {
-    fn new(
-        models: HashMap<&'static str, ModelPart>,
-        textures: HashMap<&'static str, String>,
-    ) -> Self {
-        let closed_chests = CHEST_MODELS
-            .iter()
-            .filter_map(|key| Some((*key, closed_chest(models.get(key)?))))
-            .collect();
-        Self {
-            models,
-            closed_chests,
-            textures,
-        }
-    }
-    /// The texture model `key` draws with: its `.jem`'s when the atlas has it, else `vanilla`.
-    fn texture<'a>(
-        &'a self,
-        key: &str,
-        vanilla: &'a str,
-        sprites: &HashMap<String, Rect>,
-    ) -> &'a str {
-        match self.textures.get(key) {
-            Some(texture) if sprites.contains_key(texture) => texture,
-            _ => vanilla,
-        }
-    }
-}
-/// A chest model with its lid closed, for each dimension lighting and horizontal facing, its UVs
-/// over the whole texture.
-fn closed_chest(model: &ModelPart) -> [[Vec<Vertex>; 4]; 2] {
-    [false, true].map(|nether| {
-        [0.0f32, 90.0, 180.0, 270.0].map(|y_rot| {
-            let mut vertices = Vec::new();
-            draw_part(
-                model,
-                "root",
-                around(
-                    Mat4::from_rotation_y((-y_rot).to_radians()),
-                    Vec3::new(0.5, 0.0, 0.5),
-                ),
-                &|name, p| {
-                    if name == "lid" || name == "lock" {
-                        p[3] = crate::block_entity_anim::chest_lid_x_rot(0.0);
-                    }
-                },
-                Paint {
-                    sprite: Rect {
-                        u0: 0.0,
-                        v0: 0.0,
-                        u1: 1.0,
-                        v1: 1.0,
-                        w: 16,
-                        h: 16,
-                    },
-                    tint: 0xFFFFFF,
-                    light: 0,
-                    lights: diffuse_lights(nether),
-                    glow: None,
-                },
-                &mut vertices,
-            );
-            vertices
-        })
-    })
-}
 /// Laid-out sign text by position. `AbstractSignRenderer` lays the text out
 /// again each frame, glyph by glyph; its vertices only change with what is
 /// in the key, so they are kept relative to the block and moved to the camera.
@@ -985,35 +882,68 @@ impl BlockEntityRenderer {
             .collect();
         let mut renderer = Self::new(models, registry);
         renderer.visibility = Some(Mutex::new(visibility));
-        // The packs' custom entity models (`.jem` files), before anything draws.
-        renderer.set_shapes(renderer.shapes_for(root));
         // Sherd items: provides_pottery_pattern -> decorated_pot_pattern asset id.
-        let items = match horizon_world::item_defaults::read(root) {
-            Ok(items) => items,
-            Err(e) if e.kind() == std::io::ErrorKind::NotFound => Default::default(),
-            Err(e) => return Err(e.into()),
-        };
-        for (item, components) in &items {
-            let Some(pattern) = components["minecraft:provides_pottery_pattern"].as_str() else {
-                continue;
-            };
-            let name = pattern.strip_prefix("minecraft:").unwrap_or(pattern);
-            let file = root.join(format!("data/minecraft/decorated_pot_pattern/{name}.json"));
-            let Ok(def) = std::fs::read(file) else {
-                continue;
-            };
-            let def: Value = serde_json::from_slice(&def)?;
-            if let Some(asset) = def["asset_id"].as_str() {
-                let asset = asset.strip_prefix("minecraft:").unwrap_or(asset);
-                renderer
-                    .pot_patterns
-                    .insert(item.clone(), format!("entity/decorated_pot/{asset}"));
+        if let Ok(bytes) = std::fs::read(root.join("items.json")) {
+            let items: Value = serde_json::from_slice(&bytes)?;
+            for (item, components) in items.as_object().into_iter().flatten() {
+                let Some(pattern) = components["minecraft:provides_pottery_pattern"].as_str()
+                else {
+                    continue;
+                };
+                let name = pattern.strip_prefix("minecraft:").unwrap_or(pattern);
+                let file = root.join(format!("data/minecraft/decorated_pot_pattern/{name}.json"));
+                let Ok(def) = std::fs::read(file) else {
+                    continue;
+                };
+                let def: Value = serde_json::from_slice(&def)?;
+                if let Some(asset) = def["asset_id"].as_str() {
+                    let asset = asset.strip_prefix("minecraft:").unwrap_or(asset);
+                    renderer
+                        .pot_patterns
+                        .insert(item.clone(), format!("entity/decorated_pot/{asset}"));
+                }
             }
         }
         Ok(renderer)
     }
     fn new(models: HashMap<&'static str, ModelPart>, registry: &BlockRegistry) -> Self {
-        let vanilla = Arc::new(BlockEntityShapes::new(models, HashMap::new()));
+        let closed_chests = [false, true].map(|nether| {
+            ["chest", "double_chest_left", "double_chest_right"].map(|name| {
+                [0.0f32, 90.0, 180.0, 270.0].map(|y_rot| {
+                    let mut vertices = Vec::new();
+                    if let Some(model) = models.get(name) {
+                        draw_part(
+                            model,
+                            "root",
+                            around(
+                                Mat4::from_rotation_y((-y_rot).to_radians()),
+                                Vec3::new(0.5, 0.0, 0.5),
+                            ),
+                            &|name, p| {
+                                if name == "lid" || name == "lock" {
+                                    p[3] = crate::block_entity_anim::chest_lid_x_rot(0.0);
+                                }
+                            },
+                            Paint {
+                                sprite: Rect {
+                                    u0: 0.0,
+                                    v0: 0.0,
+                                    u1: 1.0,
+                                    v1: 1.0,
+                                    w: 16,
+                                    h: 16,
+                                },
+                                tint: 0xFFFFFF,
+                                light: 0,
+                                lights: diffuse_lights(nether),
+                            },
+                            &mut vertices,
+                        );
+                    }
+                    vertices
+                })
+            })
+        });
         let kinds = (0..registry.len() as u32)
             .map(|id| {
                 registry.state(BlockStateId(id)).map_or(Kind::None, |s| {
@@ -1026,31 +956,14 @@ impl BlockEntityRenderer {
             })
             .collect();
         Self {
-            shapes: RwLock::new(vanilla.clone()),
-            vanilla,
+            models,
             kinds,
+            closed_chests,
             pot_patterns: HashMap::new(),
             visibility: None,
             sign_texts: Mutex::default(),
         }
     }
-    /// The models the packs under `root` give, their `.jem` files over vanilla's, for
-    /// [`Self::set_shapes`] (a pack reload): vanilla's own, shared, without any.
-    pub fn shapes_for(&self, root: &Path) -> Arc<BlockEntityShapes> {
-        match crate::block_entity_cem::reshape(root, &self.vanilla.models) {
-            Some((models, textures)) => Arc::new(BlockEntityShapes::new(models, textures)),
-            None => self.vanilla.clone(),
-        }
-    }
-    pub fn set_shapes(&self, shapes: Arc<BlockEntityShapes>) {
-        *self.shapes.write().unwrap_or_else(PoisonError::into_inner) = shapes;
-    }
-    fn shapes(&self) -> Arc<BlockEntityShapes> {
-        self.shapes
-            .read()
-            .unwrap_or_else(PoisonError::into_inner)
-            .clone()
-    }
     fn kind(&self, state: u32) -> &Kind {
         self.kinds.get(state as usize).unwrap_or(&Kind::None)
     }
@@ -1201,12 +1114,7 @@ impl BlockEntityRenderer {
     pub fn renders(&self, state: u32) -> bool {
         !matches!(self.kind(state), Kind::None)
     }
-    /// `submitCrumblingOverlay` of ChestRenderer.submit, BannerRenderer.submit,
-    /// SkullBlockRenderer.submitSkull, ShulkerBoxRenderer.submit,
-    /// BellRenderer.submit, LecternRenderer.submit (the book),
-    /// CopperGolemStatueBlockRenderer.submit, ConduitRenderer.submit (the shell
-    /// or cage) and EnchantTableRenderer.submit (the book): the model drawn
-    /// again under the destroy stage.
+    /// ChestRenderer and BannerRenderer submit their animated models for crumbling.
     pub fn render_breaking(
         &self,
         scene: &Scene,
@@ -1215,18 +1123,7 @@ impl BlockEntityRenderer {
         stage: [f32; 2],
         out: &mut Vec<Vertex>,
     ) {
-        if !matches!(
-            self.kind(state),
-            Kind::Banner { .. }
-                | Kind::Chest { .. }
-                | Kind::Skull { .. }
-                | Kind::Shulker { .. }
-                | Kind::Bell
-                | Kind::Lectern { .. }
-                | Kind::CopperGolem { .. }
-                | Kind::Conduit
-                | Kind::EnchantingTable
-        ) {
+        if !matches!(self.kind(state), Kind::Banner { .. } | Kind::Chest { .. }) {
             return;
         }
         let origin = (DVec3::new(f64::from(pos[0]), f64::from(pos[1]), f64::from(pos[2]))
@@ -1344,7 +1241,6 @@ impl BlockEntityRenderer {
         world_chests: bool,
         out: &mut Vec<Vertex>,
     ) {
-        let shapes = self.shapes();
         let sprite = |name: &str| scene.sprites.get(name).copied();
         let paint = |name: &str, tint: u32, packed: u8| {
             let rect = if crumbling {
@@ -1364,9 +1260,6 @@ impl BlockEntityRenderer {
                 tint,
                 light: vertex_light(packed),
                 lights,
-                glow: (!crumbling)
-                    .then(|| scene.emissive.overlay(name).and_then(sprite))
-                    .flatten(),
             })
         };
         let none = |_: &str, _: &mut [f32; 9]| {};
@@ -1437,34 +1330,12 @@ impl BlockEntityRenderer {
                 } else {
                     *texture
                 };
-                // Trapped and ender chests have models of their own when a `.jem` reshapes
-                // them; copper chests have no CEM name and draw vanilla's chest.
-                let shapes: &BlockEntityShapes =
-                    if matches!(block.as_str(), "chest" | "trapped_chest" | "ender_chest") {
-                        &shapes
-                    } else {
-                        &self.vanilla
-                    };
-                let (own, chest) = match (block.as_str(), part) {
-                    ("trapped_chest", ChestPart::Single) => ("trapped_chest", "chest"),
-                    ("trapped_chest", ChestPart::Left) => {
-                        ("trapped_chest_left", "double_chest_left")
-                    }
-                    ("trapped_chest", ChestPart::Right) => {
-                        ("trapped_chest_right", "double_chest_right")
-                    }
-                    ("ender_chest", _) => ("ender_chest", "chest"),
-                    (_, ChestPart::Single) => ("chest", "chest"),
-                    (_, ChestPart::Left) => ("double_chest_left", "double_chest_left"),
-                    (_, ChestPart::Right) => ("double_chest_right", "double_chest_right"),
+                let model = match part {
+                    ChestPart::Single => "chest",
+                    ChestPart::Left => "double_chest_left",
+                    ChestPart::Right => "double_chest_right",
                 };
-                let key = if shapes.models.contains_key(own) {
-                    own
-                } else {
-                    chest
-                };
-                let texture = shapes.texture(key, texture, scene.sprites);
-                let Some(model) = shapes.models.get(key) else {
+                let Some(model) = self.models.get(model) else {
                     return;
                 };
                 let (open, other) = self.chest_openness(
@@ -1480,25 +1351,19 @@ impl BlockEntityRenderer {
                     packed = (packed >> 4).max(l >> 4) << 4 | (packed & 15).max(l & 15);
                 }
                 if world_chests && open == 0.0 {
-                    if let (Some(paint), Some(closed)) = (
-                        paint(texture, 0xFFFFFF, packed),
-                        shapes.closed_chests.get(key),
-                    ) {
-                        let vertices = &closed[usize::from(scene.nether)][*y_rot as usize / 90];
+                    if let Some(paint) = paint(texture, 0xFFFFFF, packed) {
+                        let vertices = &self.closed_chests[usize::from(scene.nether)]
+                            [*part as usize][*y_rot as usize / 90];
                         let origin = base.w_axis.truncate();
-                        let passes = std::iter::once((paint.sprite, paint.light))
-                            .chain(paint.glow.map(|g| (g, FULL_BRIGHT)));
-                        for (r, light) in passes {
-                            out.extend(vertices.iter().map(|v| Vertex {
-                                pos: (Vec3::from_array(v.pos) + origin).to_array(),
-                                uv: [
-                                    r.u0 + (r.u1 - r.u0) * v.uv[0],
-                                    r.v0 + (r.v1 - r.v0) * v.uv[1],
-                                ],
-                                light,
-                                ..*v
-                            }));
-                        }
+                        out.extend(vertices.iter().map(|v| Vertex {
+                            pos: (Vec3::from_array(v.pos) + origin).to_array(),
+                            uv: [
+                                paint.sprite.u0 + (paint.sprite.u1 - paint.sprite.u0) * v.uv[0],
+                                paint.sprite.v0 + (paint.sprite.v1 - paint.sprite.v0) * v.uv[1],
+                            ],
+                            light: paint.light,
+                            ..*v
+                        }));
                     }
                     return;
                 }
@@ -1519,12 +1384,8 @@ impl BlockEntityRenderer {
             }
             Kind::Shulker { texture, facing } => {
                 let (Some(model), Some(paint)) = (
-                    shapes.models.get("shulker_box"),
-                    paint(
-                        shapes.texture("shulker_box", texture, scene.sprites),
-                        0xFFFFFF,
-                        packed,
-                    ),
+                    self.models.get("shulker_box"),
+                    paint(texture, 0xFFFFFF, packed),
                 ) else {
                     return;
                 };
@@ -1548,13 +1409,12 @@ impl BlockEntityRenderer {
                 draw_part(model, "root", m, &lid, paint, out);
             }
             Kind::Banner { color, wall, angle } => {
-                let (main_key, flag_key) = if *wall {
+                let (main, flag) = if *wall {
                     ("wall_banner", "wall_banner_flag")
                 } else {
                     ("standing_banner", "standing_banner_flag")
                 };
-                let (Some(main), Some(flag)) =
-                    (shapes.models.get(main_key), shapes.models.get(flag_key))
+                let (Some(main), Some(flag)) = (self.models.get(main), self.models.get(flag))
                 else {
                     return;
                 };
@@ -1575,13 +1435,8 @@ impl BlockEntityRenderer {
                         p[3] = (-0.0125 + 0.01 * (2.0 * PI * phase).mcos()) * PI;
                     }
                 };
-                let banner_base = "entity/banner/banner_base";
-                let main_texture = shapes.texture(main_key, banner_base, scene.sprites);
-                if let Some(paint) = paint(main_texture, 0xFFFFFF, packed) {
+                if let Some(paint) = paint("entity/banner/banner_base", 0xFFFFFF, packed) {
                     draw_part(main, "root", m, &none, paint, out);
-                }
-                let flag_texture = shapes.texture(flag_key, banner_base, scene.sprites);
-                if let Some(paint) = paint(flag_texture, 0xFFFFFF, packed) {
                     draw_part(flag, "root", m, &wave, paint, out);
                 }
                 // Pattern passes must not multiply the crumbling decal.
@@ -1622,13 +1477,9 @@ impl BlockEntityRenderer {
                 } else {
                     None
                 };
-                let has_profile = skin.is_some();
-                // A `.jem` texture stands in for the default skin, not a profile's.
-                let texture = skin
-                    .as_deref()
-                    .unwrap_or_else(|| shapes.texture(model, texture, scene.sprites));
+                let texture = skin.as_deref().unwrap_or(texture);
                 let (Some(model), Some(paint)) =
-                    (shapes.models.get(model), paint(texture, 0xFFFFFF, packed))
+                    (self.models.get(model), paint(texture, 0xFFFFFF, packed))
                 else {
                     return;
                 };
@@ -1660,22 +1511,12 @@ impl BlockEntityRenderer {
                     "right_ear" => p[5] = (f64::from(t * PI * 0.2).cos() + 2.5) as f32 * 0.2,
                     _ => {}
                 };
-                let start = out.len();
                 draw_part(model, "root", m, &anim, paint, out);
-                // `SkullBlockRenderer.resolveSkullRenderType`: a head with a profile takes
-                // the player skin's `entityTranslucent` render type.
-                if has_profile {
-                    crate::gfx::mark_oit(&mut out[start..]);
-                }
             }
             Kind::Bell => {
                 let (Some(model), Some(paint)) = (
-                    shapes.models.get("bell"),
-                    paint(
-                        shapes.texture("bell", "entity/bell/bell_body", scene.sprites),
-                        0xFFFFFF,
-                        packed,
-                    ),
+                    self.models.get("bell"),
+                    paint("entity/bell/bell_body", 0xFFFFFF, packed),
                 ) else {
                     return;
                 };
@@ -1703,8 +1544,8 @@ impl BlockEntityRenderer {
             }
             Kind::DecoratedPot { y_rot } => {
                 let (Some(base_model), Some(sides)) = (
-                    shapes.models.get("decorated_pot_base"),
-                    shapes.models.get("decorated_pot_sides"),
+                    self.models.get("decorated_pot_base"),
+                    self.models.get("decorated_pot_sides"),
                 ) else {
                     return;
                 };
@@ -1732,20 +1573,17 @@ impl BlockEntityRenderer {
                     }
                 }
                 let first = out.len();
-                let pot_base = "entity/decorated_pot/decorated_pot_base";
-                let pot_base = shapes.texture("decorated_pot_base", pot_base, scene.sprites);
-                if let Some(paint) = paint(pot_base, 0xFFFFFF, packed) {
+                if let Some(paint) =
+                    paint("entity/decorated_pot/decorated_pot_base", 0xFFFFFF, packed)
+                {
                     draw_part(base_model, "root", m, &none, paint, out);
                 }
-                // PotDecorations (back, left, right, front); items without a pattern use the blank
-                // side (a `.jem`'s texture, if any).
-                let blank = "entity/decorated_pot/decorated_pot_side";
-                let blank = shapes.texture("decorated_pot_sides", blank, scene.sprites);
+                // PotDecorations (back, left, right, front); items without a pattern use the blank side.
                 for (side, item) in ["back", "left", "right", "front"].iter().zip(&a.sherds) {
                     let texture = item
                         .as_ref()
                         .and_then(|i| self.pot_patterns.get(i))
-                        .map_or(blank, String::as_str);
+                        .map_or("entity/decorated_pot/decorated_pot_side", String::as_str);
                     if let (Some(part), Some(paint)) =
                         (sides.child(side), paint(texture, 0xFFFFFF, packed))
                     {
@@ -1795,14 +1633,11 @@ impl BlockEntityRenderer {
                 let (ticks, active, hunting, raw_rotation) = (scene.anim)(pos).conduit;
                 // ConduitRenderer.extractRenderState.
                 let rotation = (raw_rotation + if active { scene.partial } else { 0.0 }) * -0.0375;
-                let tex = |key: &str, name: &str| {
-                    paint(shapes.texture(key, name, scene.sprites), 0xFFFFFF, packed)
-                };
+                let tex = |name: &str| paint(name, 0xFFFFFF, packed);
                 if !active {
-                    let (Some(model), Some(paint)) = (
-                        shapes.models.get("conduit_shell"),
-                        tex("conduit_shell", "entity/conduit/base"),
-                    ) else {
+                    let (Some(model), Some(paint)) =
+                        (self.models.get("conduit_shell"), tex("entity/conduit/base"))
+                    else {
                         return;
                     };
                     let m = base
@@ -1817,28 +1652,21 @@ impl BlockEntityRenderer {
                 let hh = (anim_time * 0.1).msin() / 2.0 + 0.5;
                 let hh = hh * hh + hh;
                 let lift = Vec3::new(0.5, 0.3 + hh * 0.2, 0.5);
-                if let (Some(model), Some(paint)) = (
-                    shapes.models.get("conduit_cage"),
-                    tex("conduit_cage", "entity/conduit/cage"),
-                ) {
+                if let (Some(model), Some(paint)) =
+                    (self.models.get("conduit_cage"), tex("entity/conduit/cage"))
+                {
                     let axis = Vec3::new(0.5, 1.0, 0.5).normalize();
                     let m = base
                         * Mat4::from_translation(lift)
                         * Mat4::from_quat(Quat::from_axis_angle(axis, degrees * (PI / 180.0)));
                     draw_part(model, "root", m, &none, paint, out);
                 }
-                // The crumbling overlay covers the shell and the cage only.
-                if crumbling {
-                    return;
-                }
                 let wind = if phase == 1 {
                     "entity/conduit/wind_vertical"
                 } else {
                     "entity/conduit/wind"
                 };
-                if let (Some(model), Some(paint)) =
-                    (shapes.models.get("conduit_wind"), tex("conduit_wind", wind))
-                {
+                if let (Some(model), Some(paint)) = (self.models.get("conduit_wind"), tex(wind)) {
                     let turn = match phase {
                         1 => Mat4::from_rotation_x(PI / 2.0),
                         2 => Mat4::from_rotation_z(PI / 2.0),
@@ -1856,9 +1684,7 @@ impl BlockEntityRenderer {
                 } else {
                     "entity/conduit/closed_eye"
                 };
-                if let (Some(model), Some(paint)) =
-                    (shapes.models.get("conduit_eye"), tex("conduit_eye", eye))
-                {
+                if let (Some(model), Some(paint)) = (self.models.get("conduit_eye"), tex(eye)) {
                     let m = base
                         * Mat4::from_translation(lift)
                         * Mat4::from_scale(Vec3::splat(0.5))
@@ -1869,14 +1695,9 @@ impl BlockEntityRenderer {
                 }
             }
             Kind::EnchantingTable => {
-                let book = "entity/enchantment/enchanting_table_book";
                 let (Some(model), Some(paint)) = (
-                    shapes.models.get("book"),
-                    paint(
-                        shapes.texture("book", book, scene.sprites),
-                        0xFFFFFF,
-                        packed,
-                    ),
+                    self.models.get("book"),
+                    paint("entity/enchantment/enchanting_table_book", 0xFFFFFF, packed),
                 ) else {
                     return;
                 };
@@ -1895,16 +1716,9 @@ impl BlockEntityRenderer {
                 draw_part(model, "root", m, &book_pose(openness, ff1, ff2), paint, out);
             }
             Kind::Lectern { y_rot } => {
-                // Its own `.jem`'s book, else the enchanting table's.
-                let key = if shapes.models.contains_key("lectern_book") {
-                    "lectern_book"
-                } else {
-                    "book"
-                };
-                let book = "entity/enchantment/enchanting_table_book";
                 let (Some(model), Some(paint)) = (
-                    shapes.models.get(key),
-                    paint(shapes.texture(key, book, scene.sprites), 0xFFFFFF, packed),
+                    self.models.get("book"),
+                    paint("entity/enchantment/enchanting_table_book", 0xFFFFFF, packed),
                 ) else {
                     return;
                 };
@@ -1935,7 +1749,7 @@ impl BlockEntityRenderer {
                     _ => "copper_golem",
                 };
                 let (Some(model), Some(paint)) =
-                    (shapes.models.get(key), paint(texture, 0xFFFFFF, packed))
+                    (self.models.get(key), paint(texture, 0xFFFFFF, packed))
                 else {
                     return;
                 };
@@ -2262,7 +2076,6 @@ mod tests {
             max_y: 320,
             world: &world,
             sprites: &base_sprites,
-            emissive: &Default::default(),
             nether: false,
             lid: &|_| 0.0,
             sign: &|_| None,
@@ -2462,7 +2275,6 @@ mod tests {
                 tint: 0xFFFFFF,
                 light: 0,
                 lights: diffuse_lights(false),
-                glow: None,
             },
             &mut out,
         );
@@ -2471,55 +2283,6 @@ mod tests {
         assert_eq!(out[2].uv, [0.5, 0.5]);
     }
 
-    /// An OptiFine emissive overlay draws each polygon again with its own sprite at full
-    /// brightness, shaded alike.
-    #[test]
-    fn a_glow_draws_the_part_again_at_full_brightness() {
-        let part = ModelPart {
-            pose: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1.0, 1.0, 1.0],
-            polygons: vec![[
-                [0.0, 0.0, 0.0, 0.0, 0.0],
-                [16.0, 0.0, 0.0, 1.0, 0.0],
-                [16.0, 0.0, 16.0, 1.0, 1.0],
-                [0.0, 0.0, 16.0, 0.0, 1.0],
-            ]],
-            children: vec![],
-        };
-        let rect = |u0, v0| Rect {
-            u0,
-            v0,
-            u1: u0 + 0.5,
-            v1: v0 + 0.5,
-            w: 1,
-            h: 1,
-        };
-        let mut out = Vec::new();
-        let light = vertex_light(0x52);
-        draw_part(
-            &part,
-            "root",
-            Mat4::IDENTITY,
-            &|_, _| {},
-            Paint {
-                sprite: rect(0.0, 0.0),
-                tint: 0xFFFFFF,
-                light,
-                lights: diffuse_lights(false),
-                glow: Some(rect(0.5, 0.5)),
-            },
-            &mut out,
-        );
-        assert_eq!(out.len(), 8);
-        let (base, glow) = out.split_at(4);
-        assert!(base.iter().all(|v| v.light == light));
-        assert!(glow.iter().all(|v| v.light == 240 | (240 << 8)));
-        assert_eq!(glow[2].uv, [1.0, 1.0]);
-        assert_eq!(base[2].uv, [0.5, 0.5]);
-        for (b, g) in base.iter().zip(glow) {
-            assert_eq!((b.pos, b.color), (g.pos, g.color));
-        }
-    }
-
     /// TextFeatureRenderer.renderText: an outlined call's text is drawn over
     /// its outline (Font.DisplayMode.POLYGON_OFFSET), never level with it,
     /// and plain text stays on the sign's plane.
@@ -2548,7 +2311,6 @@ mod tests {
             max_y: 320,
             world: &world,
             sprites: &sprites,
-            emissive: &Default::default(),
             nether: false,
             lid: &|_| 0.0,
             sign: &|_| None,
@@ -2587,8 +2349,7 @@ mod tests {
     #[test]
     fn cached_sign_text_matches_and_follows_changes() {
         let renderer = BlockEntityRenderer {
-            vanilla: Default::default(),
-            shapes: Default::default(),
+            models: HashMap::new(),
             kinds: vec![
                 Kind::Sign {
                     hanging: false,
@@ -2601,6 +2362,7 @@ mod tests {
                     angle: 90.0,
                 },
             ],
+            closed_chests: Default::default(),
             pot_patterns: HashMap::new(),
             visibility: None,
             sign_texts: Mutex::default(),
@@ -2653,7 +2415,6 @@ mod tests {
             max_y: 320,
             world: &world,
             sprites: &sprites,
-            emissive: &Default::default(),
             nether: false,
             lid: &|_| 0.0,
             sign: &first_sign,
@@ -2762,7 +2523,6 @@ mod tests {
             max_y: 320,
             world: &world,
             sprites: &sprites,
-            emissive: &Default::default(),
             nether: false,
             lid: &|_| 0.0,
             sign: &|_| None,
@@ -2784,131 +2544,4 @@ mod tests {
             "entitySolid culls the pot's back faces"
         );
     }
-
-    #[test]
-    fn a_chest_jem_reshapes_the_closed_chest_and_paints_its_texture() {
-        use crate::block_entity_cem::tests::{BOX, chest, pack};
-        let vanilla = Arc::new(BlockEntityShapes::new(
-            HashMap::from([("chest", chest())]),
-            HashMap::new(),
-        ));
-        let renderer = BlockEntityRenderer {
-            shapes: RwLock::new(vanilla.clone()),
-            vanilla,
-            kinds: Vec::new(),
-            pot_patterns: HashMap::new(),
-            visibility: None,
-            sign_texts: Mutex::default(),
-        };
-        // No block entity's `.jem` (a mob's only): vanilla's shapes, not a copy.
-        let empty = pack("render-none", &[("optifine/cem/zombie.jem", "{}".into())]);
-        assert!(Arc::ptr_eq(&renderer.shapes_for(&empty), &renderer.vanilla));
-        let root = pack(
-            "render-chest",
-            &[(
-                "optifine/cem/chest.jem",
-                format!(
-                    r#"{{"texture": "textures/entity/chest/fancy.png",
-                        "models": [{{"part": "lid", {BOX}}}]}}"#
-                ),
-            )],
-        );
-        renderer.set_shapes(renderer.shapes_for(&root));
-        let _ = std::fs::remove_dir_all(&root);
-        let _ = std::fs::remove_dir_all(&empty);
-        let rect = |u0: f32| Rect {
-            u0,
-            v0: 0.0,
-            u1: u0 + 0.2,
-            v1: 0.2,
-            w: 16,
-            h: 16,
-        };
-        let sprites: HashMap<String, Rect> = [
-            ("entity/chest/normal", rect(0.0)),
-            ("entity/chest/ender", rect(0.2)),
-            ("entity/chest/fancy", rect(0.4)),
-            ("entity/chest/copper", rect(0.6)),
-        ]
-        .map(|(name, r)| (name.to_owned(), r))
-        .into();
-        let world = World::new(BlockStateId(0), 1);
-        let scene = Scene {
-            camera: DVec3::ZERO,
-            orientation: Quat::IDENTITY,
-            anim: &|_| BlockAnim::default(),
-            texts: None,
-            partial: 0.0,
-            game_time: 0,
-            max_y: 320,
-            world: &world,
-            sprites: &sprites,
-            emissive: &Default::default(),
-            nether: false,
-            lid: &|_| 0.0,
-            sign: &|_| None,
-            banner: &|_| Vec::new(),
-            skull: &|_| None,
-            glyph: &|_| (None, 0.0),
-            glyphs: 0,
-        };
-        // A closed single chest of `block` drawn by `renderer`: positions and UVs.
-        let draw = |renderer: &BlockEntityRenderer, block: &str, texture: &'static str| {
-            let kind = Kind::Chest {
-                block: block.into(),
-                texture,
-                part: ChestPart::Single,
-                y_rot: 0.0,
-                double_with: None,
-            };
-            let mut out = Vec::new();
-            renderer.render_one(
-                &scene,
-                [0; 3],
-                &kind,
-                Mat4::IDENTITY,
-                0xF0,
-                diffuse_lights(false),
-                false,
-                true,
-                &mut out,
-            );
-            out.iter().map(|v| (v.pos, v.uv)).collect::<Vec<_>>()
-        };
-        // The chest's three faces become the bottom's, the lock's and the custom lid's six, in
-        // the `.jem`'s texture. Ender and copper chests have no file of their own: vanilla's
-        // three faces in their own textures. (Trapped chests: `block_entity_cem`'s tests; their
-        // texture turns festive in late December.)
-        for (block, texture, u0, faces) in [
-            ("chest", "entity/chest/normal", 0.4, 8),
-            ("ender_chest", "entity/chest/ender", 0.2, 3),
-            ("copper_chest", "entity/chest/copper", 0.6, 3),
-        ] {
-            let out = draw(&renderer, block, texture);
-            assert_eq!(out.len(), faces * 4, "{block}");
-            assert!(
-                out.iter().all(|(_, uv)| (u0..=u0 + 0.2).contains(&uv[0])),
-                "{block}"
-            );
-        }
-        // A copper chest draws exactly what it draws without any pack.
-        let plain = BlockEntityRenderer {
-            shapes: RwLock::new(renderer.vanilla.clone()),
-            vanilla: renderer.vanilla.clone(),
-            kinds: Vec::new(),
-            pot_patterns: HashMap::new(),
-            visibility: None,
-            sign_texts: Mutex::default(),
-        };
-        assert_eq!(
-            draw(&renderer, "copper_chest", "entity/chest/copper"),
-            draw(&plain, "copper_chest", "entity/chest/copper")
-        );
-        // The atlas has no such texture: vanilla's.
-        let shapes = renderer.shapes();
-        assert_eq!(
-            shapes.texture("chest", "entity/chest/normal", &HashMap::new()),
-            "entity/chest/normal"
-        );
-    }
 }

crates/horizon-client-render/src/border.wgsl

@@ -24,9 +24,6 @@ struct Out {
     return out;
 }
 @fragment fn fs_border(in: Out) -> @location(0) vec4<f32> {
-    return border_color(in);
-}
-fn border_color(in: Out) -> vec4<f32> {
     let color = textureSample(forcefield, forcefield_sampler, in.uv);
     if color.a == 0.0 {
         discard;

crates/horizon-client-render/src/brewing.rs

@@ -9,12 +9,11 @@ use crate::{
 };
 use horizon_world::loot::PackOverlay;
 use serde_json::Value;
-use std::{collections::HashSet, path::Path};
+use std::{collections::HashSet, fs, path::Path};
 
 pub use horizon_client_core::potions::{
-    BASE_POTION_COLOR, Category, EFFECTS, EffectDef, POTIONS, PotionDef, all_effects,
-    description_id, effect, is_mod_effect, mod_effects, namespaced, potion, potion_color,
-    register_mod_effects,
+    BASE_POTION_COLOR, Category, EFFECTS, EffectDef, POTIONS, PotionDef, effect, namespaced,
+    potion, potion_color,
 };
 /// `MobEffectUtil.formatDuration` at 20 TPS.
 pub fn format_duration(ticks: i32) -> String {
@@ -37,22 +36,6 @@ pub fn potion_name_key(item: &str, potion: Option<&str>) -> String {
     let suffix = potion.and_then(self::potion).map_or("empty", |p| p.name);
     format!("item.minecraft.{prefix}.effect.{suffix}")
 }
-/// `PotionContents.getAllEffects`: the potion's effects, then the stack's
-/// `custom_effects` (id, duration, amplifier). Unknown effect ids are dropped.
-pub fn contents_effects(stack: &ItemStack) -> Vec<(&'static str, i32, i32)> {
-    let potion = stack.potion().and_then(self::potion);
-    let custom = stack.custom_potion_effects();
-    potion
-        .map_or(&[][..], |d| d.effects)
-        .iter()
-        .copied()
-        .chain(
-            custom
-                .iter()
-                .filter_map(|(id, duration, amp)| Some((effect(id)?.id, *duration, *amp))),
-        )
-        .collect()
-}
 /// Roman amplifier suffix (`potion.potency.N`) and duration lines of a potion.
 pub fn tooltip(
     potion: Option<&str>,
@@ -81,7 +64,8 @@ pub fn effect_lines<'a>(
         .into_iter()
         .map(|(e, duration, amp)| {
             let e = e.trim_start_matches("minecraft:");
-            let mut line = translate(&description_id(e)).unwrap_or_else(|| e.to_owned());
+            let mut line =
+                translate(&format!("effect.minecraft.{e}")).unwrap_or_else(|| e.to_owned());
             if amp > 0 {
                 line.push(' ');
                 line.push_str(
@@ -158,43 +142,25 @@ pub struct Brewing {
     /// Items accepted in the bottle slots (`PotionIngredient.isPotionInput`).
     pub inputs: HashSet<String>,
 }
-/// The files right in `recipe/brewing/`, parsed, by id: taken from the whole
-/// recipe folder's read when another table holds it (the start loads them
-/// together), else read alone. A file that doesn't parse is left out.
-fn brewing_sources(root: &Path) -> Vec<(String, Value)> {
-    let recipe = root.join("data/minecraft/recipe");
-    let (folder, prefix) = match crate::json_folder::held(&recipe) {
-        Some(folder) => (folder, "brewing/"),
-        None => match crate::json_folder::read(&recipe.join("brewing")) {
-            Ok(folder) => (folder, ""),
-            Err(_) => return Vec::new(),
-        },
-    };
-    folder
-        .files
-        .iter()
-        .filter_map(|f| {
-            let name = f.name.strip_prefix(prefix).filter(|n| !n.contains('/'))?;
-            let v = serde_json::from_slice::<Value>(f.bytes().ok()?).ok()?;
-            Some((format!("minecraft:brewing/{name}"), v))
-        })
-        .collect()
-}
 impl Brewing {
     pub fn load(root: &Path, items: &Items, overlay: &PackOverlay) -> Self {
-        // NeoForge's load conditions: a file whose don't hold is silently
-        // absent. Vanilla's brewing recipes carry none; a pack's can.
-        let mods: Vec<String> = {
-            let mut mods = horizon_items::content_namespaces::mod_ids(root);
-            if !mods.iter().any(|m| m == "minecraft") {
-                mods.push("minecraft".to_owned());
-            }
-            mods
-        };
-        let conditions_hold = |v: &Value| {
-            horizon_world::conditions::conditions_hold(v, &|id: &str| mods.iter().any(|m| m == id))
-        };
-        let mut sources: Vec<(String, Value)> = brewing_sources(root);
+        let mut sources: Vec<(String, Value)> =
+            fs::read_dir(root.join("data/minecraft/recipe/brewing"))
+                .into_iter()
+                .flatten()
+                .flatten()
+                .filter_map(|e| {
+                    let bytes = fs::read(e.path()).ok()?;
+                    let v = serde_json::from_slice::<Value>(&bytes).ok()?;
+                    Some((
+                        format!(
+                            "minecraft:brewing/{}",
+                            e.file_name().to_string_lossy().strip_suffix(".json")?
+                        ),
+                        v,
+                    ))
+                })
+                .collect();
         // The world's packs' brewing recipes over the game's own: the top
         // pack's file for each id replaces it (`SimpleJsonResourceReloadListener`).
         for (id, files) in overlay.kind("recipe") {
@@ -209,11 +175,6 @@ impl Brewing {
                 None => sources.push((id.to_owned(), v)),
             }
         }
-        // The gate answers the merged file, as the crafting loader's does:
-        // a false-conditioned pack file leaves the lower one gone too.
-        // The data's recipe filters, over the final set.
-        let filters = horizon_items::recipe_filters::RecipeFilters::load(root, overlay);
-        sources.retain_mut(|(id, v)| conditions_hold(v) && filters.apply(id, v));
         sources.sort_by(|a, b| a.0.cmp(&b.0));
         let mut recipes = Vec::new();
         for (id, v) in sources {

crates/horizon-client-render/src/camera.rs

@@ -419,31 +419,6 @@ pub enum CameraFluid {
     PowderSnow,
 }
 
-/// `Camera.NearPlane`: the near plane's centre and its half extents toward
-/// the camera's left and up, relative to the camera.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub struct NearPlane {
-    pub forward: [f64; 3],
-    pub left: [f64; 3],
-    pub up: [f64; 3],
-}
-impl NearPlane {
-    /// `forward`, `getTopLeft`, `getTopRight`, `getBottomLeft`, `getBottomRight`:
-    /// the points `Camera.getFluidInCamera` looks for lava and powder snow at.
-    pub fn points(&self) -> [[f64; 3]; 5] {
-        let corner = |up: f64, left: f64| -> [f64; 3] {
-            std::array::from_fn(|i| self.forward[i] + self.up[i] * up + self.left[i] * left)
-        };
-        [
-            self.forward,
-            corner(1.0, 1.0),
-            corner(1.0, -1.0),
-            corner(-1.0, 1.0),
-            corner(-1.0, -1.0),
-        ]
-    }
-}
-
 /// `Camera`: the eye-height and field-of-view easing and the view placement.
 #[derive(Clone, Copy, Debug, PartialEq)]
 pub struct Camera {
@@ -459,10 +434,6 @@ pub struct Camera {
     pub up: [f32; 3],
     pub left: [f32; 3],
     pub detached: bool,
-    /// The entity's eye and view rotation (yaw, pitch), where a detached camera backs off
-    /// from.
-    pub eye: [f64; 3],
-    pub eye_rotation: [f32; 2],
 }
 impl Default for Camera {
     fn default() -> Self {
@@ -479,8 +450,6 @@ impl Default for Camera {
             up: [0.0, 1.0, 0.0],
             left: [-1.0, 0.0, 0.0],
             detached: false,
-            eye: [0.0; 3],
-            eye_rotation: [0.0; 2],
         }
     }
 }
@@ -506,19 +475,6 @@ impl Camera {
         self.up = self.rotation.transform([0.0, 1.0, 0.0]);
         self.left = self.rotation.transform([-1.0, 0.0, 0.0]);
     }
-    /// `Camera.getNearPlane(fov)` for a `width` x `height` window, at the
-    /// projection's `zNear` of 0.05.
-    pub fn near_plane(&self, fov: f32, width: f32, height: f32) -> NearPlane {
-        let z_near = f64::from(0.05f32);
-        let aspect = f64::from(width) / f64::from(height);
-        let plane_height = horizon_core::jmath::tan(f64::from(fov * DEG_TO_RAD) / 2.0) * z_near;
-        let scale = |v: [f32; 3], by: f64| v.map(|c| f64::from(c) * by);
-        NearPlane {
-            forward: scale(self.forwards, z_near),
-            left: scale(self.left, plane_height * aspect),
-            up: scale(self.up, plane_height),
-        }
-    }
     /// `Camera.move(forwards, up, right)`.
     pub fn move_by(&mut self, forwards: f32, up: f32, right: f32) {
         let offset = self.rotation.transform([right, up, -forwards]);
@@ -539,19 +495,6 @@ impl Camera {
         entity: &CameraEntity,
         partial: f32,
         camera_type: CameraType,
-        clip: impl FnMut([f64; 3], [f64; 3]) -> Option<[f64; 3]>,
-    ) {
-        self.align_with_entity_distance(entity, partial, camera_type, |distance| distance, clip);
-    }
-    /// Adjust the detached distance after entity/mount scaling, before collision clipping.
-    /// Only finite overrides in 0..=1024 blocks are accepted (within the game's ray budget).
-    /// First-person views do not call `adjust_distance`.
-    pub fn align_with_entity_distance(
-        &mut self,
-        entity: &CameraEntity,
-        partial: f32,
-        camera_type: CameraType,
-        adjust_distance: impl FnOnce(f32) -> f32,
         mut clip: impl FnMut([f64; 3], [f64; 3]) -> Option<[f64; 3]>,
     ) {
         self.set_rotation(entity.view_y_rot(partial), entity.view_x_rot(partial));
@@ -562,8 +505,6 @@ impl Camera {
                 + f64::from(lerp(partial, self.eye_height_old, self.eye_height)),
             lerp_d(p, entity.previous[2], entity.position[2]),
         ];
-        self.eye = self.position;
-        self.eye_rotation = [self.y_rot, self.x_rot];
         self.detached = !camera_type.is_first_person();
         if self.detached {
             if camera_type.is_mirrored() {
@@ -579,14 +520,10 @@ impl Camera {
                 mount_scale = s;
                 mount_distance = d as f32;
             }
-            let vanilla = java_max(scale * distance, mount_scale * mount_distance);
-            let adjusted = adjust_distance(vanilla);
-            let distance = if adjusted.is_finite() && (0.0..=1024.0).contains(&adjusted) {
-                adjusted
-            } else {
-                vanilla
-            };
-            let zoom = self.max_zoom(distance, &mut clip);
+            let zoom = self.max_zoom(
+                java_max(scale * distance, mount_scale * mount_distance),
+                &mut clip,
+            );
             self.move_by(-zoom, 0.0, 0.0);
         } else if let Some(LivingCamera {
             sleeping: Some(bed),
@@ -690,34 +627,6 @@ pub fn perspective(
     m[11] = -1.0;
     m
 }
-/// `Frustum.getNearPlaneBounds`: the box around the four corners of the
-/// culling frustum's NDC `z = -1` plane, relative to the camera (the caller
-/// moves it to the eye). The culling projection is `Camera.update`'s
-/// `setPerspective(fov, aspect, 0.05, depthFar, zZeroToOne)`.
-pub fn near_plane_bounds(
-    fov_degrees: f32,
-    width: f32,
-    height: f32,
-    yaw: f32,
-    pitch: f32,
-    far: f32,
-) -> ([f64; 3], [f64; 3]) {
-    let projection =
-        glam::Mat4::from_cols_array(&perspective(fov_degrees, width, height, 0.05, far, true));
-    // Frustum.calculateFrustum: projection * modelView.
-    let clip_to_world = (projection * view_matrix(yaw, pitch)).inverse();
-    let mut min = [f64::INFINITY; 3];
-    let mut max = [f64::NEG_INFINITY; 3];
-    for (x, y) in [(-1.0, -1.0), (1.0, -1.0), (1.0, 1.0), (-1.0, 1.0)] {
-        let p = clip_to_world * glam::Vec4::new(x, y, -1.0, 1.0);
-        let p = [p.x / p.w, p.y / p.w, p.z / p.w];
-        for k in 0..3 {
-            min[k] = min[k].min(f64::from(p[k]));
-            max[k] = max[k].max(f64::from(p[k]));
-        }
-    }
-    (min, max)
-}
 /// `GameRenderer.render3dHud`: the first-person hand and held items are
 /// drawn with their own projection at `hudFov` (70 degrees, changed only by
 /// death and fluids), never the FOV option or the sprint, speed and bow
@@ -925,19 +834,6 @@ pub fn spinning_effect_matrix(intensity: f32, angle_degrees: f32) -> glam::Mat4
 
 #[cfg(test)]
 mod tests {
-    #[test]
-    fn near_plane_bounds_sit_half_a_near_distance_ahead_of_the_eye() {
-        // Facing +Z (yaw 0): the zero-to-one culling projection puts NDC
-        // z = -1 at -far * near / (2 far - near) in front of the camera.
-        let far = 512.0;
-        let (min, max) = super::near_plane_bounds(70.0, 1600.0, 900.0, 0.0, 0.0, far);
-        let depth = f64::from(far * 0.05 / (2.0 * far - 0.05));
-        assert!((min[2] - depth).abs() < 1e-4 && (max[2] - depth).abs() < 1e-4);
-        let half_height = depth * 35.0f64.to_radians().tan();
-        assert!((max[1] - half_height).abs() < 1e-4 && (min[1] + half_height).abs() < 1e-4);
-        let half_width = half_height * 1600.0 / 900.0;
-        assert!((max[0] - half_width).abs() < 1e-3 && (min[0] + half_width).abs() < 1e-3);
-    }
     /// `moveCloak` trails a quarter of the way, jumps from 10 blocks away; the
     /// cape leans back as the player walks forward (south, body yaw 0).
     #[test]
@@ -1024,100 +920,6 @@ mod tests {
         assert!(camera.position[2] > -1.1 && camera.position[2] < -0.9);
     }
     #[test]
-    fn detached_distance_override_keeps_collision_clipping() {
-        let entity = CameraEntity {
-            position: [0.0; 3],
-            previous: [0.0; 3],
-            x_rot: 0.0,
-            y_rot: 0.0,
-            x_rot_o: 0.0,
-            y_rot_o: 0.0,
-            eye_height: 1.62,
-            living: Some(LivingCamera {
-                scale: 2.0,
-                camera_distance: 3.0,
-                sleeping: None,
-                dead: None,
-            }),
-            mount: Some((3.0, 4.0)),
-        };
-        for kind in [CameraType::ThirdPersonBack, CameraType::ThirdPersonFront] {
-            let mut camera = Camera::default();
-            let mut calls = 0;
-            let mut rays = 0;
-            let z = if kind.is_mirrored() { 1.0 } else { -1.0 };
-            camera.align_with_entity_distance(
-                &entity,
-                1.0,
-                kind,
-                |distance| {
-                    assert_eq!(distance, 12.0);
-                    8.0
-                },
-                |_, _| None,
-            );
-            assert!((camera.position[2] - z * 8.0).abs() < 1e-5);
-            camera.align_with_entity_distance(
-                &entity,
-                1.0,
-                kind,
-                |distance| {
-                    calls += 1;
-                    assert_eq!(distance, 12.0);
-                    8.0
-                },
-                |_, _| {
-                    rays += 1;
-                    Some([0.0, 0.0, z])
-                },
-            );
-            assert_eq!((calls, rays), (1, 8));
-            assert!((camera.position[2] - z).abs() < 0.2);
-        }
-    }
-    #[test]
-    fn detached_distance_rejects_invalid_values_and_accepts_zero() {
-        let entity = CameraEntity {
-            position: [0.0; 3],
-            previous: [0.0; 3],
-            x_rot: 0.0,
-            y_rot: 0.0,
-            x_rot_o: 0.0,
-            y_rot_o: 0.0,
-            eye_height: 1.62,
-            living: None,
-            mount: None,
-        };
-        for distance in [f32::NAN, f32::INFINITY, -1.0, 1025.0] {
-            let mut camera = Camera::default();
-            camera.align_with_entity_distance(
-                &entity,
-                1.0,
-                CameraType::ThirdPersonBack,
-                |_| distance,
-                |_, _| None,
-            );
-            assert!((camera.position[2] + 4.0).abs() < 1e-6);
-        }
-        let mut camera = Camera::default();
-        camera.align_with_entity_distance(
-            &entity,
-            1.0,
-            CameraType::ThirdPersonBack,
-            |_| 0.0,
-            |_, _| None,
-        );
-        assert_eq!(camera.position, camera.eye);
-        camera.align_with_entity_distance(
-            &entity,
-            1.0,
-            CameraType::FirstPerson,
-            |_| panic!("first person has no detached distance"),
-            |_, _| None,
-        );
-        assert_eq!(camera.position, camera.eye);
-    }
-    #[test]
     fn fov_modifier_combines_speed_flight_and_bow() {
         let mut p = FovPlayer {
             flying: false,

crates/horizon-client-render/src/chat.rs

@@ -21,18 +21,6 @@ const COMMAND_HISTORY_FILE: &str = "command_history.txt";
 const MAX_PERSISTED_COMMAND_HISTORY: usize = 50;
 /// GuiMessageTag.systemSinglePlayer's indicator colour.
 pub const SYSTEM_INDICATOR: u32 = 0xD0D0D0;
-/// `GuiMessageTag.CHAT_MODIFIED_INDICATOR_COLOR`.
-const MODIFIED_INDICATOR: u32 = 0x60_6060;
-/// A player message's signature (MessageSignature), which names it to a
-/// server's deletion.
-pub type Signature = horizon_protocol::secure_chat::Signature;
-/// How long a message shows before a deletion replaces it
-/// (`ChatComponent.deleteMessageOrDelay`: `addedTime + 60`).
-const DELETION_DELAY: u64 = 60;
-/// The smooth chat extra: the ticks a new line takes to slide in and fade in,
-/// and how far left of its place it starts (GUI pixels).
-const INTRO_TICKS: f32 = 5.0;
-const INTRO_WIDTH: f32 = 12.0;
 
 /// `ChatVisiblity`: the Chat option's three values.
 #[derive(Clone, Copy, Debug, PartialEq, Eq)]
@@ -175,72 +163,27 @@ impl ChatOptions {
 struct Message {
     added: u64,
     content: Text,
-    tag: Option<std::sync::Arc<Tag>>,
+    indicator: Option<u32>,
     source: ChatSource,
-    /// `GuiMessage.signature`: a signed player message's, for deletion.
-    signature: Option<Box<Signature>>,
 }
 /// A wrapped line (`GuiMessage.Line`).
 #[derive(Clone, Debug)]
 struct Line {
     added: u64,
     content: Text,
-    tag: Option<std::sync::Arc<Tag>>,
-}
-
-/// `GuiMessageTag`: the bar at the left of a message's lines, the tooltip
-/// over it, and for a modified message the icon after each line.
-#[derive(Clone, Debug, PartialEq)]
-pub struct Tag {
-    pub color: u32,
-    /// `GuiMessageTag.Icon.CHAT_MODIFIED`.
-    pub icon: bool,
-    pub text: Text,
-}
-impl Tag {
-    /// `GuiMessageTag.systemSinglePlayer`, in `color`.
-    pub fn system_single_player(color: u32) -> Self {
-        Self {
-            color,
-            icon: false,
-            text: Text::translate("chat.tag.system_single_player", &[]),
-        }
-    }
-    /// `GuiMessageTag.chatNotSecure`.
-    pub fn not_secure() -> Self {
-        Self {
-            color: SYSTEM_INDICATOR,
-            icon: false,
-            text: Text::translate("chat.tag.not_secure", &[]),
-        }
-    }
-    /// `GuiMessageTag.chatError`: red (`CHAT_ERROR`, 16733525), the tooltip `chat.tag.error`.
-    pub fn chat_error() -> Self {
-        Self {
-            color: 0xFF_5555,
-            icon: false,
-            text: Text::translate("chat.tag.error", &[]),
-        }
-    }
-    /// `GuiMessageTag.chatModified`: the tooltip adds the original content in grey.
-    pub fn modified(original_content: &str) -> Self {
-        Self {
-            color: MODIFIED_INDICATOR,
-            icon: true,
-            text: Text::empty()
-                .append(Text::translate("chat.tag.modified", &[]))
-                .append(Text::literal("\n"))
-                .append(Text::literal(original_content).with_color(text::GRAY)),
-        }
-    }
+    indicator: Option<u32>,
 }
 
 /// `ChatComponent.AlphaCalculator.timeBased`: opaque for 180 ticks, then
 /// fading out quadratically over 20.
-fn time_alpha(ticks: f32, added: u64) -> f32 {
-    let mut t = 1.0 - (ticks - added as f32) / 200.0;
-    t = (t * 10.0).clamp(0.0, 1.0);
-    t * t
+fn time_alpha(ticks: u64, added: u64) -> f32 {
+    let delta = ticks as i64 - added as i64;
+    let mut t = delta as f64 / 200.0;
+    t = 1.0 - t;
+    t *= 10.0;
+    t = t.clamp(0.0, 1.0);
+    t *= t;
+    t as f32
 }
 #[derive(Default)]
 pub struct Chat {
@@ -256,20 +199,12 @@ pub struct Chat {
     scroll: usize,
     new_since_scroll: bool,
     pub options: ChatOptions,
-    /// The smooth chat extra: a new line slides in from the left while it
-    /// fades in, instead of appearing whole.
-    pub smooth: bool,
-    /// The smooth chat extra: no indicator bar at the left of a line.
-    pub hide_indicator: bool,
     /// Messages printed to stdout as `[CHAT]` (vanilla logs them).
     pub log: bool,
     /// Messages added since the start, for the control socket's events.
     pub received: u64,
     /// The Chat option's `visibleMessageFilter` (`set_abilities`).
     abilities: ChatAbilities,
-    /// `ChatComponent.messageDeletionQueue`: deletions of messages still
-    /// too new to replace, with the tick from which they may be.
-    deletions: Vec<(Box<Signature>, u64)>,
 }
 impl Chat {
     pub fn lines_per_page(&self, focused: bool) -> usize {
@@ -290,99 +225,38 @@ impl Chat {
         ticks: u64,
         focused: bool,
     ) {
-        let tag = indicator.map(|color| std::sync::Arc::new(Tag::system_single_player(color)));
-        self.add_message(&atlas.font, content, tag, source, ticks, focused);
-    }
-    /// `add` of a player message with its signature, which a server's
-    /// deletion names it by (`GuiMessage.signature`).
-    pub fn add_signed(
-        &mut self,
-        atlas: &HudAtlas,
-        content: Text,
-        signature: Option<Signature>,
-        tag: Option<Tag>,
-        ticks: u64,
-        focused: bool,
-    ) {
-        self.add_player_message(&atlas.font, content, signature, tag, ticks, focused);
-    }
-    #[cfg(test)]
-    fn add_signed_message(
-        &mut self,
-        font: &crate::font::Font,
-        content: Text,
-        signature: Option<Signature>,
-        ticks: u64,
-        focused: bool,
-    ) {
-        self.add_player_message(font, content, signature, None, ticks, focused);
-    }
-    /// `ChatComponent.addPlayerMessage`: the tag the message's trust level made.
-    fn add_player_message(
-        &mut self,
-        font: &crate::font::Font,
-        content: Text,
-        signature: Option<Signature>,
-        tag: Option<Tag>,
-        ticks: u64,
-        focused: bool,
-    ) {
-        self.push_message(
-            font,
-            Message {
-                added: ticks,
-                content,
-                tag: tag.map(std::sync::Arc::new),
-                source: ChatSource::Player,
-                signature: signature.map(Box::new),
-            },
-            focused,
-        );
+        self.add_message(&atlas.font, content, indicator, source, ticks, focused);
     }
     fn add_message(
         &mut self,
         font: &crate::font::Font,
         content: Text,
-        tag: Option<std::sync::Arc<Tag>>,
+        indicator: Option<u32>,
         source: ChatSource,
         ticks: u64,
         focused: bool,
     ) {
-        self.push_message(
-            font,
-            Message {
-                added: ticks,
-                content,
-                tag,
-                source,
-                signature: None,
-            },
-            focused,
-        );
-    }
-    fn push_message(&mut self, font: &crate::font::Font, message: Message, focused: bool) {
-        if !self.abilities.shows(message.source) {
+        if !self.abilities.shows(source) {
             return;
         }
         // ChatComponent.logChatMessage: every message shown is in the log.
-        let plain = message.content.plain();
-        crate::logging::write_only(log::Level::Info, &format!("[CHAT] {plain}"));
+        crate::logging::write_only(log::Level::Info, &format!("[CHAT] {}", content.plain()));
         if self.log {
-            println!("[CHAT] {plain}");
+            println!("[CHAT] {}", content.plain());
         }
+        let message = Message {
+            added: ticks,
+            content,
+            indicator,
+            source,
+        };
         self.add_lines(font, &message, focused);
         self.messages.insert(0, message);
         self.messages.truncate(100);
         self.received += 1;
     }
     fn add_lines(&mut self, font: &crate::font::Font, message: &Message, focused: bool) {
-        // GuiMessage.splitLines: room for the tag's icon (its width, 4 before and 2 after).
-        let icon = if message.tag.as_ref().is_some_and(|tag| tag.icon) {
-            9 + 4 + 2
-        } else {
-            0
-        };
-        let width = self.max_width() - icon;
+        let width = self.max_width();
         let content = self.displayed(&message.content);
         for line in font.wrap_components(&content, width) {
             if focused && self.scroll > 0 {
@@ -394,7 +268,7 @@ impl Chat {
                 Line {
                     added: message.added,
                     content: line,
-                    tag: message.tag.clone(),
+                    indicator: message.indicator,
                 },
             );
         }
@@ -445,68 +319,8 @@ impl Chat {
     pub fn clear(&mut self) {
         self.messages.clear();
         self.lines.clear();
-        self.deletions.clear();
         self.scroll = 0;
     }
-    /// `ChatComponent.deleteMessage`: the server deleted a message. One
-    /// shown for 60 ticks becomes the grey "deleted" marker now; a newer
-    /// one waits until then (`messageDeletionQueue`).
-    pub fn delete_message(&mut self, atlas: &HudAtlas, signature: &Signature, ticks: u64) {
-        self.delete_message_with(&atlas.font, signature, ticks);
-    }
-    fn delete_message_with(&mut self, font: &crate::font::Font, signature: &Signature, ticks: u64) {
-        if let Some(delayed) = self.delete_or_delay(font, signature, ticks) {
-            self.deletions.push((Box::new(*signature), delayed));
-        }
-    }
-    /// `ChatComponent.tick` (`processMessageDeletionQueue`): the delayed
-    /// deletions whose message has shown long enough.
-    pub fn tick(&mut self, atlas: &HudAtlas, ticks: u64) {
-        self.process_deletions(&atlas.font, ticks);
-    }
-    fn process_deletions(&mut self, font: &crate::font::Font, ticks: u64) {
-        let mut deletions = std::mem::take(&mut self.deletions);
-        deletions.retain(|(signature, after)| {
-            ticks < *after || self.delete_or_delay(font, signature, ticks).is_some()
-        });
-        self.deletions = deletions;
-    }
-    /// `ChatComponent.deleteMessageOrDelay`: the newest message with this
-    /// signature, replaced by `createDeletedMarker` once 60 ticks have
-    /// passed since it was added; otherwise the tick to retry from.
-    fn delete_or_delay(
-        &mut self,
-        font: &crate::font::Font,
-        signature: &Signature,
-        ticks: u64,
-    ) -> Option<u64> {
-        let message = self
-            .messages
-            .iter_mut()
-            .find(|m| m.signature.as_deref() == Some(signature))?;
-        let deletable = message.added + DELETION_DELAY;
-        if ticks < deletable {
-            return Some(deletable);
-        }
-        *message = Message {
-            added: message.added,
-            content: Self::deleted_marker(),
-            tag: Some(std::sync::Arc::new(Tag::system_single_player(
-                SYSTEM_INDICATOR,
-            ))),
-            source: ChatSource::Server,
-            signature: None,
-        };
-        // refreshTrimmedMessages.
-        self.rewrap(font);
-        None
-    }
-    /// `ChatComponent.DELETED_CHAT_MESSAGE`: grey, italic.
-    fn deleted_marker() -> Text {
-        Text::translate("chat.deleted_marker", &[])
-            .with_color(text::GRAY)
-            .italic()
-    }
     /// `new CommandHistory(gameFolder)`: the commands kept from earlier runs
     /// start the chat's history (`ChatComponent`'s constructor).
     pub fn load_history(&mut self, game_folder: &std::path::Path) {
@@ -560,7 +374,7 @@ impl Chat {
     }
     /// `ChatComponent.extractRenderState` (background mode unless `focused`)
     /// on a screen `height` GUI pixels tall at `Hud.tickCount` `ticks`.
-    pub fn layout(&self, height: i32, ticks: f32, focused: bool) -> Vec<GuiDraw> {
+    pub fn layout(&self, height: i32, ticks: u64, focused: bool) -> Vec<GuiDraw> {
         let total = self.lines.len();
         if total == 0 {
             return Vec::new();
@@ -574,47 +388,28 @@ impl Chat {
         let entry_height = o.line_height();
         let bottom_to_text =
             (8.0 * (o.line_spacing + 1.0) - 4.0 * o.line_spacing + 0.5).floor() as i32;
-        // Vanilla's 200-tick fade reads the whole GUI ticks
-        // (`Gui.getGuiTicks`); only the smooth chat extra eases it per frame.
-        let fade_ticks = if self.smooth { ticks } else { ticks.floor() };
         let alpha_of = |line: &Line| {
             if focused {
                 1.0
             } else {
-                time_alpha(fade_ticks, line.added)
+                time_alpha(ticks, line.added)
             }
         };
-        // The smooth chat extra: how far into its intro a line is, 0 at the
-        // tick it was added and 1 once it has arrived, as (alpha, offset x).
-        let intro_of = |line: &Line| {
-            if focused || !self.smooth {
-                return (1.0, 0.0);
-            }
-            let t = ((ticks - line.added as f32) / INTRO_TICKS).clamp(0.0, 1.0);
-            let eased = 1.0 - (1.0 - t) * (1.0 - t);
-            (eased, (eased - 1.0) * INTRO_WIDTH)
-        };
         let visible = total
             .saturating_sub(self.scroll)
             .min(self.lines_per_page(focused));
-        let lines: Vec<(usize, &Line, f32, f32)> = (0..visible)
+        let lines: Vec<(usize, &Line, f32)> = (0..visible)
             .rev()
             .map(|i| (i, &self.lines[i + self.scroll]))
-            .map(|(i, line)| {
-                let (eased, slide) = intro_of(line);
-                (i, line, alpha_of(line) * eased, slide)
-            })
-            .filter(|(_, _, alpha, _)| *alpha > 1.0e-5)
+            .map(|(i, line)| (i, line, alpha_of(line)))
+            .filter(|(_, _, alpha)| *alpha > 1.0e-5)
             .collect();
         let mut out = vec![GuiDraw::Push(vec![
             PoseOp::Scale(scale, scale),
             PoseOp::Translate(4.0, 0.0),
         ])];
-        for &(i, _, alpha, slide) in &lines {
+        for &(i, _, alpha) in &lines {
             let bottom = chat_bottom - i as i32 * entry_height;
-            if slide != 0.0 {
-                out.push(GuiDraw::Push(vec![PoseOp::Translate(slide, 0.0)]));
-            }
             out.push(hud_layout::fill(
                 -4,
                 bottom - entry_height,
@@ -622,15 +417,9 @@ impl Chat {
                 bottom,
                 hud_layout::as8(alpha * background_opacity) << 24,
             ));
-            if slide != 0.0 {
-                out.push(GuiDraw::Pop);
-            }
         }
-        for &(i, line, alpha, slide) in &lines {
+        for &(i, line, alpha) in &lines {
             let bottom = chat_bottom - i as i32 * entry_height;
-            if slide != 0.0 {
-                out.push(GuiDraw::Push(vec![PoseOp::Translate(slide, 0.0)]));
-            }
             let opacity = alpha * text_opacity;
             let color = hud_layout::white(opacity);
             if color >> 24 != 0 {
@@ -642,8 +431,8 @@ impl Chat {
                     shadow: true,
                 });
             }
-            if let Some(tag) = line.tag.as_ref().filter(|_| !self.hide_indicator) {
-                let color = hud_layout::as8(opacity) << 24 | tag.color & 0xFF_FFFF;
+            if let Some(indicator) = line.indicator {
+                let color = hud_layout::as8(opacity) << 24 | indicator & 0xFF_FFFF;
                 out.push(hud_layout::fill(
                     -4,
                     bottom - entry_height,
@@ -652,9 +441,6 @@ impl Chat {
                     color,
                 ));
             }
-            if slide != 0.0 {
-                out.push(GuiDraw::Pop);
-            }
         }
         if focused {
             let count = lines.len() as i32;
@@ -691,7 +477,7 @@ impl Chat {
     }
     /// Draws [`Chat::layout`] into the HUD batch, and with the chat screen
     /// open the restricted prompt above the lines.
-    pub fn draw(&self, batch: &mut HudBatch, atlas: &HudAtlas, ticks: f32, focused: bool) {
+    pub fn draw(&self, batch: &mut HudBatch, atlas: &HudAtlas, ticks: u64, focused: bool) {
         let draws = self.layout(batch.height as i32, ticks, focused);
         hud_layout::paint(batch, atlas, &draws);
         if focused && self.abilities.any_restriction() {
@@ -807,91 +593,12 @@ impl Chat {
         }
         None
     }
-    /// `DrawingFocusedGraphicsAccess.handleTag` and `handleTagIcon` with the
-    /// cursor at GUI position `(x, y)` while chat is focused: the tooltip of
-    /// the tag under it (its bar, or its icon) and the icons to draw, those
-    /// under the cursor and those of the message the cursor is over.
-    pub fn focused_tags(
-        &self,
-        font: &crate::font::Font,
-        height: i32,
-        x: f64,
-        y: f64,
-    ) -> (Option<Text>, Vec<GuiDraw>) {
-        let o = &self.options;
-        let scale = o.scale as f32;
-        let chat_bottom = hud_layout::floor((height - 40) as f32 / scale);
-        let entry_height = o.line_height();
-        let bottom_to_text =
-            (8.0 * (o.line_spacing + 1.0) - 4.0 * o.line_spacing + 0.5).floor() as i32;
-        let (mouse_x, mouse_y) = (x / f64::from(scale) - 4.0, y / f64::from(scale));
-        let inside = |left: i32, top: i32, right: i32, bottom: i32| {
-            mouse_x >= f64::from(left)
-                && mouse_x < f64::from(right)
-                && mouse_y >= f64::from(top)
-                && mouse_y < f64::from(bottom)
-        };
-        let visible = self
-            .lines
-            .len()
-            .saturating_sub(self.scroll)
-            .min(self.lines_per_page(true));
-        let mut tooltip = None;
-        let mut icons = Vec::new();
-        let mut hovered_message = false;
-        for i in (0..visible).rev() {
-            let index = i + self.scroll;
-            let line = &self.lines[index];
-            let bottom = chat_bottom - i as i32 * entry_height;
-            let top = bottom - entry_height;
-            let width = font.width_text(&line.content).ceil() as i32;
-            hovered_message |= inside(0, top, width, bottom);
-            // GuiMessage.Line.endOfEntry: the next newer line is another message's.
-            let end_of_entry = index == 0
-                || match (&line.tag, &self.lines[index - 1].tag) {
-                    (Some(a), Some(b)) => !std::sync::Arc::ptr_eq(a, b),
-                    (None, None) => false,
-                    _ => true,
-                };
-            let force_icon = end_of_entry && hovered_message;
-            if end_of_entry {
-                hovered_message = false;
-            }
-            let Some(tag) = &line.tag else { continue };
-            if inside(-4, top, -2, bottom) {
-                tooltip = Some(tag.text.clone());
-            }
-            if tag.icon {
-                let (left, text_bottom) = (width + 4, bottom - bottom_to_text + 9);
-                let icon_top = text_bottom - 9 - 1;
-                let over = inside(left, icon_top, left + 9, text_bottom);
-                if over {
-                    tooltip = Some(tag.text.clone());
-                }
-                if force_icon || over {
-                    icons.push(GuiDraw::Sprite {
-                        sprite: "icon/chat_modified".into(),
-                        x: left,
-                        y: icon_top,
-                        w: 9,
-                        h: 9,
-                        region: None,
-                        color: hud_layout::WHITE,
-                        blend: hud_layout::Blend::Textured,
-                    });
-                }
-            }
-        }
-        if icons.is_empty() {
-            return (tooltip, icons);
-        }
-        let mut draws = vec![GuiDraw::Push(vec![
-            PoseOp::Scale(scale, scale),
-            PoseOp::Translate(4.0, 0.0),
-        ])];
-        draws.extend(icons);
-        draws.push(GuiDraw::Pop);
-        (tooltip, draws)
+    /// Whether the cursor is on a line's indicator bar while chat is focused
+    /// (`DrawingFocusedGraphicsAccess.handleTag`), whose tooltip is the
+    /// message tag's text.
+    pub fn indicator_at(&self, height: i32, x: f64, y: f64) -> bool {
+        self.line_at(height, x, y)
+            .is_some_and(|(line, x)| line.indicator.is_some() && (-4.0..-2.0).contains(&x))
     }
     /// Plain text of the newest messages (for tests and the control socket).
     pub fn recent_lines(&self, n: usize) -> Vec<String> {
@@ -911,22 +618,6 @@ impl Chat {
     }
 }
 
-/// `SuggestionsList.getNarrationMessage` for entry `index` of `count`.
-fn suggestion_narration(index: usize, count: usize, text: &str, tooltip: Option<&str>) -> Text {
-    let mut args = vec![
-        Text::literal((index + 1).to_string()),
-        Text::literal(count.to_string()),
-        Text::literal(text),
-    ];
-    match tooltip {
-        Some(tooltip) => {
-            args.push(Text::literal(tooltip));
-            Text::translate("narration.suggestion.tooltip", &args)
-        }
-        None => Text::translate("narration.suggestion", &args),
-    }
-}
-
 /// `CommandSuggestions.SuggestionsList`.
 #[derive(Clone, Debug)]
 struct SuggestionList {
@@ -938,17 +629,8 @@ struct SuggestionList {
     current: usize,
     last_mouse: (i32, i32),
     tab_cycles: bool,
-    /// `lastNarratedEntry`: the entry the narrator last said (-1: none yet).
-    last_narrated: isize,
 }
 impl SuggestionList {
-    /// `getNarrationMessage`: "Selected suggestion 2 out of 5: …", with its
-    /// tooltip when it has one. It marks the entry said.
-    fn narration_message(&mut self) -> Text {
-        self.last_narrated = self.current as isize;
-        let s = &self.list[self.current];
-        suggestion_narration(self.current, self.list.len(), &s.text, s.tooltip.as_deref())
-    }
     fn contains(&self, x: i32, y: i32) -> bool {
         let [rx, ry, w, h] = self.rect;
         x >= rx && x <= rx + w && y >= ry && y <= ry + h
@@ -1071,53 +753,6 @@ fn last_word_index(s: &str) -> usize {
     }
     if prev_space { s.len() } else { out }
 }
-/// `ChatScreen.normalizeChatMessage`: `String.trim`, then
-/// `StringUtils.normalizeSpace` (one space for every run of whitespace), then
-/// `StringUtil.trimChatMessage` (the first 256 UTF-16 code units, the length
-/// `ServerboundChatPacket`'s `stringUtf8(256)` decodes). The chat screen sends
-/// this, not what was typed: a line of spaces sends nothing, and a message the
-/// packet cannot hold is cut on the client, as vanilla's is, instead of by the
-/// server.
-pub fn normalize_chat_message(message: &str) -> String {
-    // String.trim: the code points up to U+0020, which is not `str::trim`'s
-    // Unicode whitespace (U+00A0 is not Java whitespace and stays).
-    let trimmed = message.trim_matches(|c: char| c <= ' ');
-    truncate_utf16(&normalize_space(trimmed), 256)
-}
-/// `StringUtils.normalizeSpace`: one space for every run of
-/// `Character.isWhitespace`, and none at either end.
-fn normalize_space(s: &str) -> String {
-    let mut out = String::with_capacity(s.len());
-    let mut space = false;
-    for c in s.chars() {
-        if crate::ui::java_whitespace(c) {
-            space = !out.is_empty();
-        } else {
-            if space {
-                out.push(' ');
-                space = false;
-            }
-            out.push(c);
-        }
-    }
-    out
-}
-/// `StringUtil.truncateStringIfNecessary(s, 256, false)`: Java counts UTF-16
-/// code units (`String.length`), so 129 emoji are cut to 128 of them, where
-/// `chars().take(256)` would keep all 129 (258 units) for the server to
-/// reject. A cut between the halves of a surrogate pair keeps the character
-/// below it: vanilla's `substring` leaves half a pair, which a Java `String`
-/// may hold and a Rust `String` may not.
-fn truncate_utf16(s: &str, max_units: usize) -> String {
-    let mut units = 0;
-    for (byte, c) in s.char_indices() {
-        units += c.len_utf16();
-        if units > max_units {
-            return s[..byte].to_owned();
-        }
-    }
-    s.to_owned()
-}
 impl ChatScreen {
     /// `ChatScreen.init`: the input at the bottom, focused, holding `initial`.
     pub fn new(
@@ -1207,14 +842,12 @@ impl ChatScreen {
             let value = self.input.value.clone();
             let auto = self.auto_suggestions;
             let abilities = self.abilities;
-            let message = std::mem::take(&mut self.input.message);
             *self = if self.layout == SuggestLayout::CHAT {
                 Self::new(m, c, &value, self.history_pos, width, height, abilities)
             } else {
                 Self::command_block(m, c, &value, width, height)
             };
             self.auto_suggestions = auto;
-            self.input.message = message;
         }
     }
     /// `ChatScreen.onEdited`.
@@ -1296,9 +929,7 @@ impl ChatScreen {
         } else if !command.chars().all(char::is_whitespace) {
             let partial = &command[..cursor_b];
             let mut builder = SuggestionsBuilder::new(partial, last_word_index(partial));
-            // ClientSuggestionProvider.getCustomTabSuggestions: the players
-            // and the server's custom chat completions.
-            builder.suggest_matching(c.registries.custom_tab_suggestions());
+            builder.suggest_matching(c.registries.players.iter().map(String::as_str));
             let (range, list) = merge_suggestions(partial, builder.out);
             self.awaiting = None;
             self.pending = Some((range.0, list));
@@ -1438,12 +1069,11 @@ impl ChatScreen {
         };
         self.suggestions = None;
         if self.allow_suggestions && self.auto_suggestions {
-            self.show_suggestions(m, false);
+            self.show_suggestions(m);
         }
     }
-    /// `CommandSuggestions.showSuggestions`: `immediate` (Tab asked for
-    /// them) has the narrator say the first one at once.
-    fn show_suggestions(&mut self, m: &Measure, immediate: bool) {
+    /// `CommandSuggestions.showSuggestions`.
+    fn show_suggestions(&mut self, m: &Measure) {
         let Some((start, list)) = self.pending.clone() else {
             return;
         };
@@ -1486,7 +1116,6 @@ impl ChatScreen {
             current: 0,
             last_mouse: (0, 0),
             tab_cycles: false,
-            last_narrated: if immediate { -1 } else { 0 },
         };
         self.select(&mut l, 0);
         self.suggestions = Some(l);
@@ -1506,9 +1135,6 @@ impl ChatScreen {
         self.input.suggestion = applied
             .strip_prefix(self.input.value.as_str())
             .map(str::to_owned);
-        if l.last_narrated != l.current as isize {
-            horizon_narrator::say_system_now(&l.narration_message().plain());
-        }
     }
     fn cycle(&mut self, l: &mut SuggestionList, dir: isize) {
         self.select(l, l.current as isize + dir);
@@ -1619,7 +1245,7 @@ impl ChatScreen {
             self.suggestions = Some(l);
             handled
         } else if key == K::Tab {
-            self.show_suggestions(m, true);
+            self.show_suggestions(m);
             true
         } else {
             false
@@ -1852,18 +1478,4 @@ impl ChatScreen {
     pub fn suggestions_visible(&self) -> bool {
         self.suggestions.is_some()
     }
-    /// `CommandSuggestions.getUsageNarration` while the list shows
-    /// (`isVisible`): whether Tab cycles it or fills the input in, and
-    /// whether Escape hides it (`allowHiding`, which only the chat's turns
-    /// off).
-    pub fn suggestions_usage(&self) -> Option<&'static str> {
-        let list = self.suggestions.as_ref()?;
-        let hidable = self.layout != SuggestLayout::CHAT;
-        Some(match (list.tab_cycles, hidable) {
-            (true, true) => "narration.suggestion.usage.cycle.hidable",
-            (true, false) => "narration.suggestion.usage.cycle.fixed",
-            (false, true) => "narration.suggestion.usage.fill.hidable",
-            (false, false) => "narration.suggestion.usage.fill.fixed",
-        })
-    }
 }

crates/horizon-client-render/src/chat_tests.rs

@@ -33,67 +33,12 @@ fn add(chat: &mut Chat, font: &Font, content: Text) {
             Line {
                 added: 0,
                 content,
-                tag: None,
+                indicator: None,
             },
         );
     }
 }
 
-#[test]
-fn smooth_chat_slides_a_line_in_and_can_hide_the_indicator() {
-    let mut chat = Chat {
-        smooth: true,
-        ..Chat::default()
-    };
-    chat.lines.push(Line {
-        added: 0,
-        content: Text::literal("hi"),
-        tag: Some(std::sync::Arc::new(Tag::system_single_player(
-            SYSTEM_INDICATOR,
-        ))),
-    });
-    let text_alpha = |draws: &[GuiDraw]| {
-        draws.iter().find_map(|d| match d {
-            GuiDraw::Text { color, .. } => Some(color >> 24),
-            _ => None,
-        })
-    };
-    // The slide is the negative translate the line carries while it moves.
-    let slide = |draws: &[GuiDraw]| {
-        draws.iter().find_map(|d| match d {
-            GuiDraw::Push(ops) => ops.iter().find_map(|op| match op {
-                PoseOp::Translate(x, _) if *x < 0.0 => Some(*x),
-                _ => None,
-            }),
-            _ => None,
-        })
-    };
-    // The tick it arrives: fully faded out, so nothing is drawn.
-    assert_eq!(text_alpha(&chat.layout(361, 0.0, false)), None);
-    // Halfway through the intro: left of its place and still faint.
-    let halfway = chat.layout(361, INTRO_TICKS / 2.0, false);
-    assert!(slide(&halfway).is_some_and(|x| (-INTRO_WIDTH..0.0).contains(&x)));
-    let faded = text_alpha(&halfway).expect("the line shows halfway through");
-    // Settled: in place and as opaque as vanilla's line.
-    let settled = chat.layout(361, INTRO_TICKS, false);
-    assert_eq!(slide(&settled), None);
-    assert!(text_alpha(&settled).expect("settled") > faded);
-    // The extra off draws the line whole on the tick it arrives, as vanilla.
-    chat.smooth = false;
-    let plain = chat.layout(361, 0.0, false);
-    assert_eq!(slide(&plain), None);
-    assert_eq!(text_alpha(&plain), text_alpha(&settled));
-    // The indicator bar is the -4 to -2 fill at the left of the line.
-    let bar = |draws: &[GuiDraw]| {
-        draws
-            .iter()
-            .any(|d| matches!(d, GuiDraw::Fill { x0: -4, x1: -2, .. }))
-    };
-    assert!(bar(&plain));
-    chat.hide_indicator = true;
-    assert!(!bar(&chat.layout(361, 0.0, false)));
-}
-
 #[test]
 fn clicking_seed_copies_the_raw_value_only_inside_the_link() {
     let font = font();
@@ -150,7 +95,7 @@ fn click_targets_match_rendered_spans_when_scaled_wrapped_and_scrolled() {
             for scroll in [0, 3, 12] {
                 chat.scroll = scroll;
                 let mut links = 0;
-                for draw in chat.layout(361, 0.0, true) {
+                for draw in chat.layout(361, 0, true) {
                     if let GuiDraw::Text { text, x, y, .. } = draw {
                         let mut at = x as f64;
                         for (c, style) in text.chars() {
@@ -299,58 +244,6 @@ fn mod_commands_are_coloured_and_complete_like_vanilla_ones() {
     assert_eq!(screen.value(), "/coords");
 }
 
-#[test]
-fn chat_completes_the_servers_custom_completions_with_the_players() {
-    // CommandSuggestions.updateCommandInfo completes chat from
-    // ClientSuggestionProvider.getCustomTabSuggestions: the online players
-    // and what ClientboundCustomChatCompletionsPacket added.
-    use crate::command::{CustomCompletionAction as Action, modify_custom_completions};
-    let font = font();
-    let m = Measure(&font);
-    let mut registries = Registries {
-        players: vec!["Steve".into()],
-        ..Registries::default()
-    };
-    let entries = |e: &[&str]| e.iter().map(|s| s.to_string()).collect::<Vec<_>>();
-    let set = &mut registries.custom_completions;
-    modify_custom_completions(set, Action::from_id(0), &entries(&["Alex", "#trade"]));
-    modify_custom_completions(set, Action::Add, &entries(&["Notch", "Steve"]));
-    modify_custom_completions(set, Action::Remove, &entries(&["Alex"]));
-    // An id past the last action is ADD (OutOfBoundsStrategy.ZERO).
-    modify_custom_completions(set, Action::from_id(7), &entries(&["Zuri"]));
-    assert_eq!(
-        registries
-            .custom_tab_suggestions()
-            .into_iter()
-            .collect::<Vec<_>>(),
-        ["#trade", "Notch", "Steve", "Zuri"]
-    );
-    let completed = |registries: &Registries, line: &str| {
-        let dispatcher = crate::command::vanilla::game_dispatcher();
-        let c = Commands {
-            dispatcher,
-            registries,
-        };
-        let mut screen = ChatScreen::new(&m, &c, "", 0, 640, 360, full());
-        screen.type_text(&m, &c, line);
-        // Chat shows no list by itself: Tab shows it, Tab again uses it.
-        for _ in 0..2 {
-            screen.key(&m, &c, &[], winit::keyboard::KeyCode::Tab, false, false);
-        }
-        screen.value().to_owned()
-    };
-    assert_eq!(completed(&registries, "hi no"), "hi Notch");
-    assert_eq!(completed(&registries, "sell #tr"), "sell #trade");
-    assert_eq!(completed(&registries, "hi st"), "hi Steve");
-    assert_eq!(completed(&registries, "hi al"), "hi al");
-    // SET replaces them all; the players stay.
-    let set = &mut registries.custom_completions;
-    modify_custom_completions(set, Action::Set, &entries(&["Alex"]));
-    assert_eq!(completed(&registries, "hi no"), "hi no");
-    assert_eq!(completed(&registries, "hi al"), "hi Alex");
-    assert_eq!(completed(&registries, "hi st"), "hi Steve");
-}
-
 #[test]
 fn ask_server_nodes_wait_for_the_servers_completions() {
     // ClientSuggestionProvider.customSuggestion: an `ask_server` node at the
@@ -574,130 +467,3 @@ fn a_guests_line_follows_the_player_message_permission() {
         );
     }
 }
-
-/// `ChatComponent.deleteMessageOrDelay`: a deleted message shows for 60
-/// ticks from when it was added, then becomes the grey italic
-/// `chat.deleted_marker` line with the system bar; the other lines stay.
-#[test]
-fn a_deleted_message_shows_60_ticks_then_becomes_the_marker() {
-    let font = font();
-    let mut chat = Chat::default();
-    let secret = [7; 256];
-    chat.add_signed_message(
-        &font,
-        Text::literal("<Steve> secret"),
-        Some(secret),
-        100,
-        false,
-    );
-    chat.add_signed_message(
-        &font,
-        Text::literal("<Alex> hi"),
-        Some([8; 256]),
-        110,
-        false,
-    );
-    let lines =
-        |chat: &Chat| -> Vec<String> { chat.lines.iter().map(|l| l.content.plain()).collect() };
-    let marker = Chat::deleted_marker().plain();
-    chat.delete_message_with(&font, &secret, 130);
-    assert_eq!(
-        lines(&chat),
-        ["<Alex> hi", "<Steve> secret"],
-        "too new: delayed"
-    );
-    chat.process_deletions(&font, 159);
-    assert_eq!(lines(&chat), ["<Alex> hi", "<Steve> secret"]);
-    chat.process_deletions(&font, 160);
-    assert_eq!(lines(&chat), ["<Alex> hi".to_owned(), marker.clone()]);
-    assert!(chat.deletions.is_empty());
-    let line = &chat.lines[1];
-    assert_eq!(line.tag.as_ref().map(|t| t.color), Some(SYSTEM_INDICATOR));
-    assert_eq!(line.added, 100, "the marker keeps the message's time");
-    assert!(
-        line.content
-            .spans
-            .iter()
-            .all(|s| s.style.color == Some(text::GRAY) && s.style.is_italic())
-    );
-    assert_eq!(
-        chat.messages[1].content.translation_key(),
-        Some("chat.deleted_marker")
-    );
-    // A message shown 60 ticks already is replaced at once; an unknown or
-    // already deleted signature changes nothing.
-    chat.delete_message_with(&font, &[8; 256], 170);
-    assert_eq!(lines(&chat), [marker.clone(), marker.clone()]);
-    chat.delete_message_with(&font, &secret, 200);
-    chat.delete_message_with(&font, &[9; 256], 200);
-    assert_eq!(lines(&chat), [marker.clone(), marker]);
-    assert!(chat.deletions.is_empty());
-}
-
-/// `SuggestionsList.select` says an entry once (`lastNarratedEntry`), as
-/// "suggestion N out of M", with its tooltip when it has one.
-#[test]
-fn a_suggestion_is_narrated_by_its_place_once() {
-    let suggestion = |text: &str, tooltip: Option<&str>| Suggestion {
-        range: (1, 1),
-        text: text.into(),
-        tooltip: tooltip.map(str::to_owned),
-        int_value: None,
-    };
-    let mut l = SuggestionList {
-        rect: [0; 4],
-        original: "/".into(),
-        list: vec![
-            suggestion("give", None),
-            suggestion("gamemode", Some("Mode")),
-        ],
-        offset: 0,
-        current: 1,
-        last_mouse: (0, 0),
-        tab_cycles: false,
-        last_narrated: 0,
-    };
-    let said = l.narration_message().component();
-    assert_eq!(l.last_narrated, 1);
-    assert_eq!(said["translate"], "narration.suggestion.tooltip");
-    assert_eq!(said["with"].as_array().map(Vec::len), Some(4));
-    l.current = 0;
-    let said = l.narration_message().component();
-    assert_eq!(said["translate"], "narration.suggestion");
-    assert_eq!(said["with"].as_array().map(Vec::len), Some(3));
-}
-
-#[test]
-fn a_chat_message_is_trimmed_and_its_whitespace_runs_collapsed() {
-    // ChatScreen.normalizeChatMessage: String.trim, then StringUtils
-    // .normalizeSpace, so a command gets the arguments the player meant.
-    assert_eq!(normalize_chat_message("  hello   there  "), "hello there");
-    assert_eq!(normalize_chat_message("/msg  Alex\thi"), "/msg Alex hi");
-    assert_eq!(normalize_chat_message("a\n\nb\r\nc"), "a b c");
-    assert_eq!(normalize_chat_message("\t \n"), "");
-    assert_eq!(normalize_chat_message(""), "");
-    // Character.isWhitespace is not str::trim's Unicode whitespace: U+00A0 is
-    // no Java whitespace, so it is neither trimmed nor collapsed, while the
-    // ideographic space U+3000 and Java's U+001C separators are.
-    assert_eq!(normalize_chat_message(" \u{a0} hi"), "\u{a0} hi");
-    assert_eq!(normalize_chat_message("a\u{a0}\u{a0}b"), "a\u{a0}\u{a0}b");
-    assert_eq!(normalize_chat_message("a\u{3000}\u{3000}b"), "a b");
-    assert_eq!(normalize_chat_message("a\u{1c}b"), "a b");
-}
-
-#[test]
-fn a_chat_message_is_cut_to_the_256_utf16_units_the_packet_holds() {
-    // StringUtil.trimChatMessage counts String.length(), UTF-16 code units:
-    // 256 ASCII characters are all kept, 257 are cut to 256.
-    assert_eq!(normalize_chat_message(&"a".repeat(256)).len(), 256);
-    assert_eq!(normalize_chat_message(&"a".repeat(300)).len(), 256);
-    // An emoji is two units, so 128 of them fill the packet and the 129th is
-    // dropped: chars().take(256) would keep all 129 and the server would
-    // reject the message.
-    let emoji = normalize_chat_message(&"\u{1f600}".repeat(129));
-    assert_eq!(emoji, "\u{1f600}".repeat(128));
-    assert_eq!(emoji.encode_utf16().count(), 256);
-    // A cut between the halves of a pair keeps the character below it.
-    let mixed = format!("{}\u{1f600}", "b".repeat(255));
-    assert_eq!(normalize_chat_message(&mixed), "b".repeat(255));
-}

crates/horizon-client-render/src/chunk.rs

@@ -82,45 +82,13 @@ impl LevelShape {
     /// vanilla Overworld's `-64..320` so that vanilla's Nether and End keep
     /// the 24 sections they have always had.
     pub fn column(self) -> ColumnLayout {
-        ColumnLayout::of_level(self.min_y, self.height)
-    }
-}
-
-/// The shapes of a world's three levels, from its dimension types.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub struct LevelShapes {
-    pub overworld: LevelShape,
-    pub nether: LevelShape,
-    pub end: LevelShape,
-}
-impl LevelShapes {
-    pub const VANILLA: Self = Self {
-        overworld: LevelShape::OVERWORLD,
-        nether: LevelShape::NETHER,
-        end: LevelShape::END,
-    };
-    /// The shape of the level `id` (`minecraft:overworld`,
-    /// `minecraft:the_nether`, `minecraft:the_end`); others get the
-    /// Overworld's.
-    pub fn get(&self, id: &str) -> LevelShape {
-        match id {
-            "minecraft:the_nether" => self.nether,
-            "minecraft:the_end" => self.end,
-            _ => self.overworld,
+        let low = self.min_y.min(MIN_Y);
+        let high = self.max_y().max(MIN_Y + HEIGHT);
+        ColumnLayout {
+            min_y: low,
+            sections: ((high - low) / 16) as usize,
         }
     }
-    pub fn get_mut(&mut self, id: &str) -> &mut LevelShape {
-        match id {
-            "minecraft:the_nether" => &mut self.nether,
-            "minecraft:the_end" => &mut self.end,
-            _ => &mut self.overworld,
-        }
-    }
-}
-impl Default for LevelShapes {
-    fn default() -> Self {
-        Self::VANILLA
-    }
 }
 
 /// The span of block Y a chunk holds: from `min_y`, `sections` sections up
@@ -135,16 +103,6 @@ impl ColumnLayout {
         min_y: MIN_Y,
         sections: SECTIONS,
     };
-    /// The column of a level from `min_y`, `height` high
-    /// (`LevelShape::column`).
-    pub fn of_level(min_y: i32, height: i32) -> Self {
-        let low = min_y.min(MIN_Y);
-        let high = (min_y + height).max(MIN_Y + HEIGHT);
-        Self {
-            min_y: low,
-            sections: ((high - low) / 16) as usize,
-        }
-    }
     /// `DimensionType.MIN_Y`, `MAX_Y`: 12 bits of `BlockPos` Y, less 32.
     pub const LOWEST_Y: i32 = -2032;
     pub const HIGHEST_Y: i32 = 2031;
@@ -197,13 +155,6 @@ impl ColumnLayout {
         self.min_y + index as i32 * 16
     }
 }
-/// `true` for each section of `layout`: what callers that keep no
-/// per-section record (of fluids, say) pass as "every section may have it".
-pub fn every_section(layout: ColumnLayout) -> &'static [bool] {
-    static ALL: [bool; crate::section_mask::SectionMask::CAPACITY] =
-        [true; crate::section_mask::SectionMask::CAPACITY];
-    &ALL[..layout.sections()]
-}
 impl Default for ColumnLayout {
     fn default() -> Self {
         Self::VANILLA
@@ -212,7 +163,7 @@ impl Default for ColumnLayout {
 
 /// Biomes are 4x4x4 containers over the biome table (67 entries: a 7-bit
 /// global palette).
-pub const BIOME_STRATEGY: Strategy = Strategy::biomes(8);
+pub const BIOME_STRATEGY: Strategy = Strategy::biomes(7);
 
 /// Bits of the block states' global palette: 16 for vanilla's 35,723 states
 /// (what vanilla servers and clients send), more when content mods add states
@@ -243,47 +194,6 @@ pub fn free_columns<T: Send + 'static>(columns: T, count: usize) {
 pub fn set_block_states(states: usize) {
     let bits = horizon_core::paletted::ceil_log2(states).max(16);
     BLOCK_BITS.store(bits, std::sync::atomic::Ordering::Relaxed);
-    forget_shared();
-}
-
-/// One allocation per kind of uniform section (a single block, a single
-/// biome and one light value), shared by every column that has it, keyed by
-/// (block, biome, light). A tall column is mostly such sections: air with
-/// full sky light above the terrain. Edits copy them (`Arc::make_mut`).
-type SharedSections = std::collections::HashMap<(u32, u32, u8), Arc<Section>>;
-static SHARED: std::sync::Mutex<Option<SharedSections>> = std::sync::Mutex::new(None);
-
-/// Replaces the uniform sections of `sections` with the shared ones.
-pub fn share_uniform(sections: &mut [Arc<Section>]) {
-    let key = |s: &Section| -> Option<(u32, u32, u8)> {
-        let Light::Uniform(light) = s.light else {
-            return None;
-        };
-        if s.blocks.bits() != 0 || s.biomes.bits() != 0 {
-            return None;
-        }
-        Some((s.blocks.uniform()?, s.biomes.uniform()?, light))
-    };
-    let Ok(mut shared) = SHARED.lock() else {
-        return;
-    };
-    let shared = shared.get_or_insert_with(Default::default);
-    for section in sections {
-        let Some(k) = key(section) else {
-            continue;
-        };
-        let one = shared.entry(k).or_insert_with(|| section.clone());
-        if !Arc::ptr_eq(one, section) {
-            *section = one.clone();
-        }
-    }
-}
-
-/// Forgets the shared sections, when the palette changes.
-fn forget_shared() {
-    if let Ok(mut shared) = SHARED.lock() {
-        *shared = None;
-    }
 }
 /// Packed light per block: sky light in the high nibble, block light in the low one.
 #[derive(Clone)]
@@ -391,9 +301,6 @@ pub struct Chunk {
     pub light_loaded: bool,
     /// Newly generated (not loaded from a save): eligible for generation-time spawns.
     pub fresh: bool,
-    /// Finished from a proto chunk just now, in any kind of world, not read
-    /// from a save (`ChunkEvent.Load`'s `isNewChunk`).
-    pub generated: bool,
     /// Block entities read from a save, moved into the world on arrival.
     pub block_entities: Vec<((i32, i32, i32), block_entity::BlockEntity)>,
     /// `CustomName` of the container block entities (shown as the screen title).
@@ -418,20 +325,18 @@ impl Chunk {
         Self::with_layout(x, z, ColumnLayout::VANILLA)
     }
     pub fn with_layout(x: i32, z: i32, layout: ColumnLayout) -> Self {
-        let mut one = [Arc::new(Section::default())];
-        share_uniform(&mut one);
-        let [empty] = one;
         Self {
             x,
             z,
             min_y: layout.min_y(),
-            sections: (0..layout.sections()).map(|_| empty.clone()).collect(),
+            sections: (0..layout.sections())
+                .map(|_| Arc::new(Section::default()))
+                .collect(),
             surface: OnceLock::new(),
             motion_blocking: OnceLock::new(),
             lit: false,
             light_loaded: false,
             fresh: false,
-            generated: false,
             block_entities: Vec::new(),
             block_names: Vec::new(),
             structure_refs: Vec::new(),
@@ -508,15 +413,6 @@ impl Chunk {
         }
         previous
     }
-    /// Section `s`'s block states replaced whole (a bulk edit): its storage
-    /// compacted, and the heightmaps built again on their next read.
-    pub fn replace_blocks(&mut self, s: usize, values: &[u32; 4096]) {
-        let section = Arc::make_mut(&mut self.sections[s]);
-        section.blocks = Section::from_blocks(values);
-        section.compact();
-        self.surface = OnceLock::new();
-        self.motion_blocking = OnceLock::new();
-    }
     /// `getHeight(Heightmap.Types.WORLD_SURFACE, x, z)` (`x`, `z` within the
     /// chunk): one above the highest block that isn't `air`, or the column's
     /// minimum Y.
@@ -644,10 +540,6 @@ impl RolledLoot {
 /// Save data loaded with a chunk that Horizon keeps but does not simulate.
 #[derive(Clone, Debug, Default)]
 pub struct ChunkExtras {
-    /// Server-owned mod data attached to this chunk.
-    pub attachments: horizon_world::attachments::Attachments,
-    /// Attachment maps of the chunk's block entities, on a save snapshot.
-    pub block_entity_attachments: Vec<((i32, i32, i32), horizon_world::attachments::Attachments)>,
     /// Chunk root keys written back as loaded (structures, PostProcessing,
     /// InhabitedTime, blending data, ...).
     pub root: Compound,

crates/horizon-client-render/src/chunk/block_entity.rs

@@ -8,13 +8,7 @@ use horizon_world::{
     level::sculk::SculkSpreader,
     nbt::{Compound, Tag},
 };
-use std::{
-    collections::HashMap,
-    sync::{
-        Arc,
-        atomic::{AtomicU64, Ordering},
-    },
-};
+use std::{collections::HashMap, sync::Arc};
 
 /// An entity's UUID as its four ints (`UUIDUtil.CODEC`).
 pub type Uuid = [i32; 4];
@@ -86,175 +80,9 @@ pub enum BlockEntity {
     Shelf(Box<Shelf>),
     /// `ChiseledBookShelfBlockEntity`: a `Container` of six one-book slots.
     ChiseledBookshelf(Box<ChiseledBookshelf>),
-    /// A block entity of a mod (`native_block_entity`), kept as its saved
-    /// compound for the mod to read and change.
-    Mod(Box<ModBlockEntity>),
     /// `PotentSulfurBlockEntity` (`game/potent_sulfur.rs`).
     PotentSulfur(PotentSulfur),
-    /// `StructureBlockEntity` (`structure_block.rs`).
-    StructureBlock(Box<crate::structure_block::StructureBlock>),
-    /// `JigsawBlockEntity` (`jigsaw_block.rs`).
-    JigsawBlock(Box<crate::jigsaw_block::JigsawBlock>),
-    /// `TestBlockEntity` (`test_block.rs`).
-    TestBlock(Box<crate::test_block::TestBlock>),
-    /// `TestInstanceBlockEntity` (`test_instance_block.rs`).
-    TestInstanceBlock(Box<crate::test_instance_block::TestInstanceBlock>),
 }
-/// A mod's block entity, read and changed through its fields
-/// (`ModBlockEntityFields`) as a struct's: `entity.nbt`. Each change goes
-/// through `DerefMut` and gives it a new `revision`, so a client tells
-/// whether what it kept of it (`BlockEntityDraw::keep`) is still right
-/// without comparing the whole entity, and no write can skip that.
-pub struct ModBlockEntity {
-    fields: ModBlockEntityFields,
-    revision: ModRevision,
-}
-/// What a `ModBlockEntity` holds: its type id (`mymod:machine`), its saved
-/// compound without `id`, `x`, `y`, `z` and `Items`, its item slots
-/// (`Items`) when its block has a container (`ModContainer`), and the data
-/// slots its menu shows (`ContainerData`: a furnace menu's flame and arrow),
-/// which the mod sets and nothing saves.
-#[derive(Clone, Debug, Default, PartialEq)]
-pub struct ModBlockEntityFields {
-    pub id: String,
-    pub nbt: Compound,
-    pub items: Vec<Option<ItemStack>>,
-    pub data: Vec<i32>,
-}
-/// Which contents a `ModBlockEntity` has had: one per entity made (a clone
-/// is another), counted on by each change. Equal revisions, equal contents.
-/// Neither saved nor compared.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub struct ModRevision {
-    born: u64,
-    changes: u64,
-}
-static MOD_BLOCK_ENTITIES_MADE: AtomicU64 = AtomicU64::new(0);
-impl ModBlockEntity {
-    pub fn new(fields: ModBlockEntityFields) -> Self {
-        Self {
-            fields,
-            revision: ModRevision {
-                born: MOD_BLOCK_ENTITIES_MADE.fetch_add(1, Ordering::Relaxed),
-                changes: 0,
-            },
-        }
-    }
-    pub fn revision(&self) -> ModRevision {
-        self.revision
-    }
-    /// A client's copy loads the tag the server sent (`loadWithComponents`
-    /// in `ClientPacketListener.handleBlockEntityData`): `tag`'s fields
-    /// replace its own of the same names. One it already has as sent is
-    /// left alone, so a tag sent again unchanged keeps its revision.
-    pub fn merge_update_tag(&mut self, tag: &Compound) {
-        for (k, v) in tag {
-            if self.nbt.get(k) != Some(v) {
-                self.nbt.insert(k.clone(), v.clone());
-            }
-        }
-    }
-}
-impl From<ModBlockEntityFields> for ModBlockEntity {
-    fn from(fields: ModBlockEntityFields) -> Self {
-        Self::new(fields)
-    }
-}
-impl Default for ModBlockEntity {
-    fn default() -> Self {
-        Self::new(ModBlockEntityFields::default())
-    }
-}
-impl Clone for ModBlockEntity {
-    fn clone(&self) -> Self {
-        Self::new(self.fields.clone())
-    }
-}
-impl PartialEq for ModBlockEntity {
-    fn eq(&self, other: &Self) -> bool {
-        self.fields == other.fields
-    }
-}
-impl std::fmt::Debug for ModBlockEntity {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        self.fields.fmt(f)
-    }
-}
-impl std::ops::Deref for ModBlockEntity {
-    type Target = ModBlockEntityFields;
-    fn deref(&self) -> &ModBlockEntityFields {
-        &self.fields
-    }
-}
-impl std::ops::DerefMut for ModBlockEntity {
-    fn deref_mut(&mut self) -> &mut ModBlockEntityFields {
-        self.revision.changes += 1;
-        &mut self.fields
-    }
-}
-/// The container of a mod block's block entity, as a `WorldlyContainer`
-/// says it: its slot count, the slots each face reaches
-/// (`getSlotsForFace`, by `Direction`: down, up, north, south, west, east),
-/// and the slots hoppers may put into (`canPlaceItemThroughFace`) and take
-/// from (`canTakeItemThroughFace`); and the vanilla menu that shows its
-/// slots when the block is used, if any (`MOD_MENUS`).
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
-pub struct ModContainer {
-    pub slots: usize,
-    pub faces: [Vec<usize>; 6],
-    pub inputs: Vec<usize>,
-    pub outputs: Vec<usize>,
-    pub menu: Option<String>,
-}
-/// The fluid tanks of a mod block's block entity, in the container's shape:
-/// each tank's capacity in millibuckets, the tanks each face reaches, and
-/// the tanks a fill may reach and a drain may take. The tanks' contents are
-/// not here: they live in the entity's saved compound, under `fluids`, so
-/// they survive restarts and the block's own tick reads them.
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
-pub struct ModFluidTanks {
-    /// Each tank's capacity in millibuckets, in tank order.
-    pub tanks: Vec<i32>,
-    pub faces: [Vec<usize>; 6],
-    /// The tanks a fill may reach (`canPlaceItemThroughFace`).
-    pub inputs: Vec<usize>,
-    /// The tanks a drain may take from (`canTakeItemThroughFace`).
-    pub outputs: Vec<usize>,
-}
-/// The energy buffer of a mod block's block entity (NeoForge's
-/// `SimpleEnergyHandler`): its capacity, the most one insert and one extract
-/// moves, and the faces a fill may come through and a drain may leave by.
-/// The amount is not here: it lives in the entity's saved compound, under
-/// `energy`, so it survives restarts and the block's own tick reads it.
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
-pub struct ModEnergyBuffer {
-    pub capacity: i32,
-    /// The most one insert moves; 0 takes none.
-    pub max_insert: i32,
-    /// The most one extract moves; 0 gives none.
-    pub max_extract: i32,
-    /// The faces, by `Direction` number, a fill may come through.
-    pub insert_faces: [bool; 6],
-    /// The faces a drain may leave by.
-    pub extract_faces: [bool; 6],
-}
-/// The vanilla menus a mod container can open, with the slot count each
-/// shows: slot grids, and the furnaces' (input, fuel, result), whose four
-/// data slots draw the flame (`data[0]` of `data[1]`) and the arrow
-/// (`data[2]` of `data[3]`), as `AbstractFurnaceBlockEntity.dataAccess`.
-pub const MOD_MENUS: [(&str, usize); 11] = [
-    ("minecraft:furnace", 3),
-    ("minecraft:blast_furnace", 3),
-    ("minecraft:smoker", 3),
-    ("minecraft:hopper", 5),
-    ("minecraft:generic_3x3", 9),
-    ("minecraft:generic_9x1", 9),
-    ("minecraft:generic_9x2", 18),
-    ("minecraft:generic_9x3", 27),
-    ("minecraft:generic_9x4", 36),
-    ("minecraft:generic_9x5", 45),
-    ("minecraft:generic_9x6", 54),
-];
 /// `PotentSulfurBlockEntity`: the seconds left to the geyser's next change of
 /// state (`waitingCountdown`, saved as `countdown`) and the game time of its
 /// last eruption block event, which the client's plume counts from.
@@ -336,9 +164,6 @@ pub struct SkullSkin {
     /// `ResolvableProfile.nameOrId` when the profile is `Dynamic` (a name or
     /// an id only): the key `skins::Resolver` resolves it by.
     pub dynamic: Option<NameOrId>,
-    /// `PlayerSkin.Patch.body`: the profile's `texture`, a resource pack
-    /// texture drawn instead of any skin.
-    pub texture: Option<String>,
     pub fallback: &'static str,
 }
 /// `Either<String, UUID>`: the key a `Dynamic` `ResolvableProfile` resolves
@@ -397,19 +222,11 @@ pub struct Beacon {
 }
 #[derive(Clone, Debug, Default)]
 pub struct Jukebox {
-    /// `JukeboxBlockEntity`'s one slot (`ContainerSingleItem`), so a hopper or
-    /// a dropper reaches it as it reaches any container.
-    pub items: [Option<ItemStack>; 1],
+    pub record: Option<ItemStack>,
     /// `ticks_since_song_started`, while a song plays.
     pub ticks: i64,
     pub playing: bool,
 }
-impl Jukebox {
-    /// `JukeboxBlockEntity.getTheItem`: the disc it holds.
-    pub fn record(&self) -> Option<&ItemStack> {
-        self.items[0].as_ref()
-    }
-}
 /// `BrewingStandBlockEntity` state. Slots: 0-2 bottles, 3 ingredient, 4 fuel.
 #[derive(Clone, Debug, Default)]
 pub struct BrewingStand {
@@ -691,64 +508,3 @@ pub struct CommandBlock {
     pub auto: bool,
     pub condition_met: bool,
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn a_mod_block_entitys_revision_moves_with_each_change_and_only_then() {
-        let mut machine = ModBlockEntity::new(ModBlockEntityFields {
-            id: "mymod:machine".into(),
-            data: vec![0],
-            ..Default::default()
-        });
-        let made = machine.revision();
-        // Reads leave it.
-        assert_eq!(machine.data[0] + machine.nbt.len() as i32, 0);
-        assert_eq!(machine.revision(), made);
-        // Every way to change a field moves it.
-        let mut seen = vec![made];
-        let changes: [fn(&mut ModBlockEntity); 4] = [
-            |m| m.data[0] = 1,
-            |m| _ = m.nbt.insert("progress".into(), Tag::Int(3)),
-            |m| m.items.push(None),
-            |m| m.id.push('s'),
-        ];
-        for change in changes {
-            change(&mut machine);
-            assert!(!seen.contains(&machine.revision()));
-            seen.push(machine.revision());
-        }
-        // Another entity, or a clone, never shares one, even with equal
-        // contents; equality is the contents' alone.
-        let copy = machine.clone();
-        assert_eq!(copy, machine);
-        assert!(!seen.contains(&copy.revision()));
-        let fresh = ModBlockEntity::default();
-        assert_ne!(fresh.revision(), ModBlockEntity::default().revision());
-    }
-
-    #[test]
-    fn an_update_tag_sent_again_unchanged_keeps_the_revision() {
-        let mut machine = ModBlockEntity::default();
-        let tag = Compound::from([
-            ("progress".into(), Tag::Int(3)),
-            ("fuel".into(), Tag::Int(9)),
-        ]);
-        machine.merge_update_tag(&tag);
-        let merged = machine.revision();
-        machine.merge_update_tag(&tag);
-        assert_eq!(machine.revision(), merged);
-        // One field changed: replaced, the other kept, the revision moved.
-        machine.merge_update_tag(&Compound::from([("progress".into(), Tag::Int(4))]));
-        assert_ne!(machine.revision(), merged);
-        assert_eq!(
-            machine.nbt,
-            Compound::from([
-                ("progress".into(), Tag::Int(4)),
-                ("fuel".into(), Tag::Int(9)),
-            ])
-        );
-    }
-}

crates/horizon-client-render/src/chunk_map.rs

@@ -1,13 +1,7 @@
 //! Resident chunk membership, with a token for consumers that cache its keys.
-use crate::{
-    chunk::Chunk,
-    fast_hash::{FxHashMap, FxHashSet},
-};
+use crate::{chunk::Chunk, fast_hash::FxHashMap};
 use std::{
-    collections::{
-        VecDeque,
-        hash_map::{Iter, ValuesMut},
-    },
+    collections::hash_map::{Iter, ValuesMut},
     ops::Deref,
     sync::{
         Arc,
@@ -22,46 +16,18 @@ fn next_revision() -> u64 {
     NEXT_REVISION.fetch_add(1, Ordering::Relaxed)
 }
 
-/// The membership changes one map keeps for the consumers that read them
-/// every tick (`TickChunkMembership.synchronize`); older ones are dropped.
-const MAX_RECENT_DELTAS: usize = 256;
-
-/// One membership change of one `ChunkMap`, stamped with the revision it
-/// brought the map to.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub enum ChunkMembershipDelta {
-    Added(Key),
-    Removed(Key),
-    Reset,
-}
-
 /// Read access behaves like a map. Structural writes are explicit so edits to
 /// blocks or light don't invalidate consumers of the loaded chunk key set.
 /// Tokens are process-wide: replacing the entire map also invalidates caches.
 pub struct ChunkMap {
     columns: Columns,
     revision: u64,
-    /// The oldest revision `recent_deltas` still answers for: the revision of
-    /// the change it last dropped, or the revision that cleared them. A
-    /// consumer holding an older one rebuilds, it does not replay.
-    min_valid_revision: u64,
-    /// This map's recent membership changes, in revision order.
-    /// Revisions are process-wide: the numbers missing in between belong to
-    /// the other maps (a server thread's, another dimension's), which say
-    /// nothing about this one's keys.
-    recent_deltas: VecDeque<(u64, ChunkMembershipDelta)>,
-    /// The resident chunks generation has not placed its animals in yet.
-    fresh: FxHashSet<Key>,
 }
 impl Default for ChunkMap {
     fn default() -> Self {
-        let revision = next_revision();
         Self {
             columns: Columns::default(),
-            revision,
-            min_valid_revision: revision,
-            recent_deltas: VecDeque::new(),
-            fresh: FxHashSet::default(),
+            revision: next_revision(),
         }
     }
 }
@@ -69,107 +35,26 @@ impl ChunkMap {
     pub fn membership_revision(&self) -> u64 {
         self.revision
     }
-    fn record_delta(&mut self, delta: ChunkMembershipDelta) {
-        if self.recent_deltas.len() >= MAX_RECENT_DELTAS
-            && let Some((evicted, _)) = self.recent_deltas.pop_front()
-        {
-            self.min_valid_revision = evicted;
-        }
-        self.recent_deltas.push_back((self.revision, delta));
-    }
-    /// This map's membership changes since `last_revision`, one of its own
-    /// earlier `membership_revision`s, or `None` when they can no longer be
-    /// answered: the consumer's revision predates what the ring kept, the map
-    /// was cleared since (a reset rebuilds everything), or the revision is not
-    /// this map's, which its own revisions give away: every one of them in the
-    /// answered range is the opening revision or a change the ring still
-    /// holds, so a revision another map took in between is refused, not
-    /// replayed.
-    pub fn deltas_since(
-        &self,
-        last_revision: u64,
-    ) -> Option<impl Iterator<Item = (u64, ChunkMembershipDelta)> + '_> {
-        if last_revision == 0
-            || last_revision < self.min_valid_revision
-            || last_revision > self.revision
-            || self.recent_deltas.is_empty()
-        {
-            return None;
-        }
-        let pos = self
-            .recent_deltas
-            .partition_point(|(rev, _)| *rev <= last_revision);
-        // A revision this map never took: another map's, drawing on the same
-        // process-wide counter. Only the opening revision and the ones the
-        // ring still holds are this map's.
-        let is_own_revision = last_revision == self.min_valid_revision
-            || (pos > 0 && self.recent_deltas[pos - 1].0 == last_revision);
-        if !is_own_revision {
-            return None;
-        }
-        let slice = self.recent_deltas.range(pos..);
-        if slice
-            .clone()
-            .any(|(_, d)| *d == ChunkMembershipDelta::Reset)
-        {
-            return None;
-        }
-        Some(slice.copied())
-    }
     pub fn insert(&mut self, key: Key, chunk: Arc<Chunk>) -> Option<Arc<Chunk>> {
-        if chunk.fresh {
-            self.fresh.insert(key);
-        } else {
-            self.fresh.remove(&key);
-        }
         let previous = self.columns.insert(key, chunk);
         if previous.is_none() {
             self.revision = next_revision();
-            self.record_delta(ChunkMembershipDelta::Added(key));
         }
         previous
     }
     pub fn remove(&mut self, key: &Key) -> Option<Arc<Chunk>> {
-        self.fresh.remove(key);
         let previous = self.columns.remove(key);
         if previous.is_some() {
             self.revision = next_revision();
-            self.record_delta(ChunkMembershipDelta::Removed(*key));
         }
         previous
     }
     pub fn clear(&mut self) {
         if !self.columns.is_empty() {
             self.columns.clear();
-            self.fresh.clear();
             self.revision = next_revision();
-            self.recent_deltas.clear();
-            self.recent_deltas
-                .push_back((self.revision, ChunkMembershipDelta::Reset));
-            self.min_valid_revision = self.revision;
         }
     }
-    pub fn has_fresh(&self) -> bool {
-        !self.fresh.is_empty()
-    }
-    /// The fresh keys in the chunk map's own iteration order, so the spawns
-    /// they drive run in the order a scan of the columns gave.
-    pub fn fresh_keys_ordered(&self) -> Vec<Key> {
-        if self.fresh.is_empty() {
-            Vec::new()
-        } else if self.fresh.len() == 1 {
-            self.fresh.iter().copied().collect()
-        } else {
-            self.columns
-                .keys()
-                .filter(|k| self.fresh.contains(k))
-                .copied()
-                .collect()
-        }
-    }
-    pub fn remove_fresh(&mut self, key: &Key) {
-        self.fresh.remove(key);
-    }
     pub fn get_mut(&mut self, key: &Key) -> Option<&mut Arc<Chunk>> {
         self.columns.get_mut(key)
     }
@@ -240,146 +125,4 @@ mod tests {
         map = ChunkMap::default();
         assert_ne!(cleared, map.membership_revision());
     }
-
-    /// The deltas' kinds, checking the ring answers in revision order.
-    fn kinds(deltas: Vec<(u64, ChunkMembershipDelta)>) -> Vec<ChunkMembershipDelta> {
-        let mut last = 0;
-        for (rev, _) in &deltas {
-            assert!(*rev > last, "the ring answers in revision order");
-            last = *rev;
-        }
-        deltas.into_iter().map(|(_, d)| d).collect()
-    }
-
-    /// Revision numbers are process-wide: the ones another map takes in
-    /// between, and a payload-only rewrite that takes none at all, say nothing
-    /// about this map's keys.
-    #[test]
-    fn deltas_since_ignores_revisions_other_maps_take() {
-        let mut map = ChunkMap::default();
-        let mut other = ChunkMap::default();
-        let chunk = Arc::new(Chunk::empty(0, 0));
-        map.insert((0, 0), chunk.clone());
-        let seen = map.membership_revision();
-        for key in [(1, 0), (2, 0), (3, 0)] {
-            other.insert(key, chunk.clone());
-        }
-        map.insert((0, 0), Arc::new(Chunk::empty(0, 0))); // Payload only.
-        map.insert((4, 0), chunk.clone());
-        map.remove(&(0, 0));
-        assert_eq!(
-            kinds(map.deltas_since(seen).unwrap().collect()),
-            [
-                ChunkMembershipDelta::Added((4, 0)),
-                ChunkMembershipDelta::Removed((0, 0)),
-            ]
-        );
-        // The consumer's own revision answers, with nothing new since.
-        assert!(
-            map.deltas_since(map.membership_revision())
-                .unwrap()
-                .next()
-                .is_none()
-        );
-        // A revision another map took in between: refused, not replayed.
-        assert!(map.deltas_since(other.membership_revision()).is_none());
-    }
-
-    /// A map built ahead of the live one, its revisions interleaved with it,
-    /// answering for a revision it never took: refused, so the consumer
-    /// rebuilds rather than replay another map's changes.
-    #[test]
-    fn deltas_since_none_for_interleaved_revision_from_another_map() {
-        let mut map = ChunkMap::default();
-        let mut other = ChunkMap::default();
-        let chunk = Arc::new(Chunk::empty(0, 0));
-        map.insert((0, 0), chunk.clone());
-        let seen = map.membership_revision();
-        other.insert((1, 0), chunk.clone());
-        let foreign = other.membership_revision();
-        map.insert((2, 0), chunk.clone());
-        assert!(map.deltas_since(foreign).is_none());
-        assert_eq!(
-            kinds(map.deltas_since(seen).unwrap().collect()),
-            [ChunkMembershipDelta::Added((2, 0))]
-        );
-    }
-
-    /// The ring answers for the changes it kept, and only those.
-    #[test]
-    fn deltas_since_none_for_a_revision_the_ring_dropped() {
-        let mut map = ChunkMap::default();
-        let chunk = Arc::new(Chunk::empty(0, 0));
-        let created = map.membership_revision();
-        let mut revisions = Vec::new();
-        let changes = MAX_RECENT_DELTAS as i32 + 1;
-        for i in 0..changes {
-            map.insert((i, 0), chunk.clone());
-            revisions.push(map.membership_revision());
-        }
-        let (first, kept) = revisions.split_first().unwrap();
-        // The oldest change fell out with the consumer's revision: rebuild.
-        assert!(map.deltas_since(created).is_none());
-        assert_eq!(map.deltas_since(*first).unwrap().count(), kept.len());
-    }
-
-    /// A reset rebuilds whatever the consumer last saw, and the ring answers
-    /// for what follows it.
-    #[test]
-    fn deltas_since_none_across_a_clear() {
-        let mut map = ChunkMap::default();
-        let chunk = Arc::new(Chunk::empty(0, 0));
-        map.insert((0, 0), chunk.clone());
-        let before = map.membership_revision();
-        map.clear();
-        assert!(map.deltas_since(before).is_none());
-        let cleared = map.membership_revision();
-        map.insert((1, 0), chunk);
-        assert_eq!(
-            kinds(map.deltas_since(cleared).unwrap().collect()),
-            [ChunkMembershipDelta::Added((1, 0))]
-        );
-    }
-
-    #[test]
-    fn fresh_chunks_tracking() {
-        let mut map = ChunkMap::default();
-        assert!(!map.has_fresh());
-        let mut chunk = Chunk::empty(1, 2);
-        chunk.fresh = true;
-        map.insert((1, 2), Arc::new(chunk));
-        assert!(map.has_fresh());
-        assert_eq!(map.fresh_keys_ordered(), vec![(1, 2)]);
-
-        map.remove_fresh(&(1, 2));
-        assert!(!map.has_fresh());
-
-        let mut chunk2 = Chunk::empty(3, 4);
-        chunk2.fresh = true;
-        map.insert((3, 4), Arc::new(chunk2));
-        assert!(map.has_fresh());
-
-        map.remove(&(3, 4));
-        assert!(!map.has_fresh());
-    }
-
-    #[test]
-    fn fresh_keys_ordered_matches_chunk_map_iteration_order() {
-        let mut map = ChunkMap::default();
-        let keys = [(-5, 10), (12, -3), (0, 0), (7, 8), (-1, -1), (4, 4)];
-        for (i, &key) in keys.iter().enumerate() {
-            let mut chunk = Chunk::empty(key.0, key.1);
-            chunk.fresh = i % 2 == 0;
-            map.insert(key, Arc::new(chunk));
-        }
-
-        let ordered = map.fresh_keys_ordered();
-        let expected: Vec<Key> = map
-            .keys()
-            .copied()
-            .filter(|k| map.fresh.contains(k))
-            .collect();
-        assert_eq!(ordered, expected);
-        assert_eq!(ordered.len(), 3);
-    }
 }

crates/horizon-client-render/src/cit.rs

@@ -1,849 +0,0 @@
-//! OptiFine's Custom Item Textures (and CIT Resewn's): the rules of the enabled packs'
-//! `optifine/cit/**/*.properties`, read from the overlay resource root. The rules themselves are
-//! `horizon_optifine::cit`'s.
-
-pub use horizon_optifine::cit::{Hand, Kind, Rule};
-
-use crate::cit_glint::{Global, StackGlint};
-use horizon_client_core::component::name_text;
-use horizon_client_core::scoreboard::comp_text;
-use horizon_items::item_data::{canon_tag, encode_components};
-use horizon_items::items::ItemStack;
-use horizon_optifine::cit::{ComponentTest, Source, ValueTest};
-use horizon_optifine::{Properties, properties_files_in};
-use horizon_world::nbt::{JavaString, Tag, parse_snbt};
-use std::borrow::Cow;
-use std::collections::HashMap;
-use std::fs;
-use std::hash::{DefaultHasher, Hash, Hasher};
-use std::path::Path;
-use std::sync::{Arc, Mutex};
-
-/// Every rule under the root's `optifine/cit/`, `mcpatcher/cit/` and CIT Resewn's
-/// `citresewn/cit/` folders, the one chosen first when several match first (`Rule::priority`).
-/// The pack's global `cit.properties` is not a rule.
-pub fn load_rules(root: &Path) -> Vec<Rule> {
-    let tops = ["optifine", "mcpatcher", "citresewn"];
-    let mut rules: Vec<Rule> = properties_files_in(root, &tops, "cit")
-        .into_iter()
-        .filter(|path| !path.ends_with("/cit.properties"))
-        .filter_map(|path| {
-            let props = read_properties(&root.join(&path))?;
-            let rule = Rule::parse(&path, &props, |p| root.join(p).is_file());
-            if rule.is_none() {
-                log::warn!("custom item textures: {path} is not a rule Horizon can read");
-            }
-            rule
-        })
-        .collect();
-    rules.sort_by(Rule::priority);
-    rules
-}
-
-/// A `.properties` file as CIT Resewn reads them (`Properties::parse_equals_first`): UTF-8,
-/// else Latin-1 as Java reads them, so a pack saved that way still loads. `None` when it can't
-/// be read.
-pub fn read_properties(path: &Path) -> Option<Properties> {
-    let bytes = fs::read(path).ok()?;
-    let text = String::from_utf8(bytes)
-        .unwrap_or_else(|e| e.into_bytes().iter().map(|&b| char::from(b)).collect());
-    Some(Properties::parse_equals_first(&text))
-}
-
-/// The rules with an index by item and a cache of what each stack matched.
-#[derive(Debug, Default)]
-pub struct CitRules {
-    pub rules: Vec<Rule>,
-    /// The pack's `cit.properties`.
-    pub global: Global,
-    /// Per kind (`Kind as usize`), the rules naming each item, in priority order.
-    by_item: [HashMap<String, Vec<u32>>; 4],
-    /// Enchantment rules without `items`, in priority order.
-    any_item: Vec<u32>,
-    /// Per rule, per component test: its literal read as SNBT and as a JSON text component.
-    literals: Vec<Vec<Prepared>>,
-    selected: Mutex<HashMap<u64, Option<u32>>>,
-    enchanted: Mutex<HashMap<u64, Vec<u32>>>,
-    glints: Mutex<HashMap<u64, Arc<StackGlint>>>,
-}
-
-#[derive(Debug, Default)]
-struct Prepared {
-    snbt: Option<Tag>,
-    json: Option<String>,
-}
-
-/// Cache entries kept before the cache starts over.
-const CACHE_LIMIT: usize = 4096;
-
-impl CitRules {
-    /// The enabled packs' rules under the overlay resource root.
-    pub fn load(root: &Path) -> Self {
-        Self {
-            global: crate::cit_glint::load_global(root),
-            ..Self::new(load_rules(root))
-        }
-    }
-
-    /// `rules` in priority order, the winner first.
-    pub fn new(rules: Vec<Rule>) -> Self {
-        let mut by_item: [HashMap<String, Vec<u32>>; 4] = Default::default();
-        let mut any_item = Vec::new();
-        for (i, rule) in rules.iter().enumerate() {
-            let i = i as u32;
-            if rule.kind == Kind::Enchantment && rule.items.is_empty() {
-                any_item.push(i);
-            }
-            for item in &rule.items {
-                let list = by_item[rule.kind as usize].entry(item.clone()).or_default();
-                if list.last() != Some(&i) {
-                    list.push(i);
-                }
-            }
-        }
-        let literals = rules
-            .iter()
-            .map(|r| r.components.iter().map(prepare).collect())
-            .collect();
-        Self {
-            rules,
-            by_item,
-            any_item,
-            literals,
-            ..Default::default()
-        }
-    }
-
-    pub fn is_empty(&self) -> bool {
-        self.rules.is_empty()
-    }
-
-    /// Leave out the Enchantment rules `keep` refuses (those without a drawable texture): they
-    /// match no stack, so vanilla's glint and the other rules of their layer stay.
-    pub fn keep_glints(&mut self, keep: impl Fn(usize) -> bool) {
-        self.any_item.retain(|&i| keep(i as usize));
-        let named = &mut self.by_item[Kind::Enchantment as usize];
-        for list in named.values_mut() {
-            list.retain(|&i| keep(i as usize));
-        }
-        named.retain(|_, list| !list.is_empty());
-        lock(&self.enchanted).clear();
-        lock(&self.glints).clear();
-    }
-
-    /// The winning rule of `kind` (Item, Armor or Elytra) for this stack, as an index into `rules`.
-    pub fn select(
-        &self,
-        kind: Kind,
-        stack: &ItemStack,
-        hand: Hand,
-        max_damage: u32,
-    ) -> Option<usize> {
-        let candidates = self.by_item[kind as usize].get(&*stack.item)?;
-        let comps = encode_components(stack);
-        let key = cache_key((0, kind, hand), stack, max_damage, comps.as_ref());
-        if let Some(hit) = lock(&self.selected).get(&key) {
-            return hit.map(|i| i as usize);
-        }
-        let found = candidates
-            .iter()
-            .copied()
-            .find(|&i| self.matches(i, stack, hand, max_damage, comps.as_ref()));
-        remember(&self.selected, key, found);
-        found.map(|i| i as usize)
-    }
-
-    /// Every matching Enchantment rule for the stack drawn in `hand` (`Hand::Main` for one in a
-    /// GUI), in priority order.
-    pub fn enchantments(&self, stack: &ItemStack, hand: Hand, max_damage: u32) -> Vec<usize> {
-        let named = self.by_item[Kind::Enchantment as usize]
-            .get(&*stack.item)
-            .map_or(&[][..], Vec::as_slice);
-        if named.is_empty() && self.any_item.is_empty() {
-            return Vec::new();
-        }
-        let comps = encode_components(stack);
-        let key = cache_key(
-            (1, Kind::Enchantment, hand),
-            stack,
-            max_damage,
-            comps.as_ref(),
-        );
-        let hit = lock(&self.enchanted).get(&key).cloned();
-        let found = hit.unwrap_or_else(|| {
-            let mut all: Vec<u32> = named.iter().chain(&self.any_item).copied().collect();
-            all.sort_unstable();
-            all.retain(|&i| self.matches(i, stack, hand, max_damage, comps.as_ref()));
-            remember(&self.enchanted, key, all.clone());
-            all
-        });
-        found.into_iter().map(|i| i as usize).collect()
-    }
-
-    /// The glint layers this stack draws in `hand` (`Hand::Main` in a GUI) and whether
-    /// vanilla's still does (`StackGlint`), worked out once per stack and hand; `None` when the
-    /// pack changes no glint. `foil` is whether the stack draws a glint at all
-    /// (`ItemStack::has_foil`): one that doesn't gets no layers.
-    pub fn glint(
-        &self,
-        stack: &ItemStack,
-        hand: Hand,
-        max_damage: u32,
-        foil: bool,
-    ) -> Option<Arc<StackGlint>> {
-        let no_rules =
-            self.any_item.is_empty() && self.by_item[Kind::Enchantment as usize].is_empty();
-        // Before the cache, which `foil` is not part of.
-        if !foil || (no_rules && self.global.use_glint) {
-            return None;
-        }
-        let comps = encode_components(stack);
-        let key = cache_key(
-            (2, Kind::Enchantment, hand),
-            stack,
-            max_damage,
-            comps.as_ref(),
-        );
-        if let Some(hit) = lock(&self.glints).get(&key) {
-            return Some(hit.clone());
-        }
-        let matched = self.enchantments(stack, hand, max_damage);
-        let glint = Arc::new(StackGlint::new(
-            &self.rules,
-            &matched,
-            stack.crafting_enchantments(),
-            &self.global,
-        ));
-        remember(&self.glints, key, glint.clone());
-        Some(glint)
-    }
-
-    /// Whether rule `i` matches the stack drawn in `hand`.
-    fn matches(
-        &self,
-        i: u32,
-        stack: &ItemStack,
-        hand: Hand,
-        max_damage: u32,
-        comps: Option<&Tag>,
-    ) -> bool {
-        let rule = &self.rules[i as usize];
-        if rule.hand != Hand::Any && rule.hand != hand {
-            return false;
-        }
-        let count = i32::try_from(stack.count).unwrap_or(i32::MAX);
-        if rule.stack_size.as_ref().is_some_and(|r| !r.contains(count)) {
-            return false;
-        }
-        // CIT Resewn: only damageable items have damage.
-        let damage = if max_damage > 0 { stack.damage } else { 0 };
-        if rule
-            .damage
-            .as_ref()
-            .is_some_and(|d| !d.matches(damage, max_damage))
-        {
-            return false;
-        }
-        let enchantments = stack.crafting_enchantments();
-        let listed = |id: &str| rule.enchantments.iter().any(|e| e == id);
-        if !rule.enchantments.is_empty() && !enchantments.iter().any(|(id, _)| listed(id)) {
-            return false;
-        }
-        if let Some(levels) = &rule.enchantment_levels {
-            let level_in_range = enchantments.iter().any(|(id, level)| {
-                (rule.enchantments.is_empty() || listed(id))
-                    && levels.contains(i32::try_from(*level).unwrap_or(i32::MAX))
-            });
-            if !level_in_range {
-                return false;
-            }
-        }
-        let literals = &self.literals[i as usize];
-        rule.components
-            .iter()
-            .zip(literals)
-            .all(|(test, lit)| component_test(test, lit, stack, comps) != test.negate)
-    }
-}
-
-fn lock<T>(m: &Mutex<T>) -> std::sync::MutexGuard<'_, T> {
-    m.lock().unwrap_or_else(|e| e.into_inner())
-}
-
-fn remember<V>(cache: &Mutex<HashMap<u64, V>>, key: u64, value: V) {
-    let mut cache = lock(cache);
-    if cache.len() >= CACHE_LIMIT {
-        cache.clear();
-    }
-    cache.insert(key, value);
-}
-
-/// What a cached answer depends on; `query` tells `select`, `enchantments` and `glint` apart.
-fn cache_key(query: (u8, Kind, Hand), stack: &ItemStack, max: u32, comps: Option<&Tag>) -> u64 {
-    let mut h = DefaultHasher::new();
-    (query.0, query.1 as u8, query.2 as u8, &*stack.item).hash(&mut h);
-    (stack.count, stack.damage, max, comps).hash(&mut h);
-    h.finish()
-}
-
-fn prepare(test: &ComponentTest) -> Prepared {
-    let ValueTest::Literal(lit) = &test.value else {
-        return Prepared::default();
-    };
-    let text = lit.text.trim();
-    let snbt = match parse_snbt(text) {
-        Ok((tag, read)) if read == text.len() && text.starts_with(['{', '[']) => Some(tag),
-        _ => None,
-    };
-    let json = json_plain(text);
-    Prepared { snbt, json }
-}
-
-/// The plain text of `s` read as a JSON text component.
-fn json_plain(s: &str) -> Option<String> {
-    if !s.starts_with(['{', '[', '"']) {
-        return None;
-    }
-    let value: serde_json::Value = serde_json::from_str(s).ok()?;
-    Some(comp_text(&value).plain())
-}
-
-/// Whether one test passes, before its `negate`.
-fn component_test(
-    test: &ComponentTest,
-    lit: &Prepared,
-    stack: &ItemStack,
-    comps: Option<&Tag>,
-) -> bool {
-    let legacy;
-    let (root, text_depth) = match &test.source {
-        Source::Component(id) => {
-            let depth = match id.as_str() {
-                "minecraft:custom_name" | "minecraft:item_name" => Some(0),
-                "minecraft:lore" => Some(1),
-                _ => None,
-            };
-            (comps.and_then(|c| c.get(id)), depth)
-        }
-        Source::LegacyEnchantments { stored } => {
-            let levels = if *stored {
-                stack.stored_enchantments()
-            } else {
-                stack.enchantments()
-            };
-            legacy = Tag::List(
-                levels
-                    .iter()
-                    .map(|(id, lvl)| {
-                        let lvl = i16::try_from(*lvl).unwrap_or(i16::MAX);
-                        Tag::compound([
-                            ("id", Tag::String((&**id).into())),
-                            ("lvl", Tag::Short(lvl)),
-                        ])
-                    })
-                    .collect(),
-            );
-            (Some(&legacy), None)
-        }
-    };
-    // Fields the component leaves out when 0, which pre-1.20.5 items always wrote.
-    let defaulted;
-    let root = match (&test.source, root, test.path.first()) {
-        (Source::Component(id), Some(Tag::Compound(map)), Some(field))
-            if matches!(
-                (id.as_str(), field.as_str()),
-                ("minecraft:written_book_content", "generation")
-                    | ("minecraft:fireworks", "flight_duration")
-            ) && !map.contains_key(&JavaString::from(field.as_str())) =>
-        {
-            let mut map = map.clone();
-            map.insert(JavaString::from(field.as_str()), Tag::Int(0));
-            defaulted = Tag::Compound(map);
-            Some(&defaulted)
-        }
-        (_, root, _) => root,
-    };
-    let Some(root) = root else {
-        return matches!(test.value, ValueTest::Exists(false));
-    };
-    if let ValueTest::Exists(want) = test.value {
-        return walk(root, &test.path, 0, &mut |_, _| true) == want;
-    }
-    walk(root, &test.path, 0, &mut |tag, depth| {
-        value_test(&test.value, lit, tag, text_depth == Some(depth))
-    })
-}
-
-/// Visits what `path` reaches from `tag`, true once `visit` is.
-fn walk(
-    tag: &Tag,
-    path: &[String],
-    depth: usize,
-    visit: &mut dyn FnMut(&Tag, usize) -> bool,
-) -> bool {
-    let Some((seg, rest)) = path.split_first() else {
-        return visit(tag, depth);
-    };
-    let mut next = |t: &Tag| walk(t, rest, depth + 1, visit);
-    let len = match tag {
-        Tag::Compound(map) if seg == "*" => return map.values().any(&mut next),
-        Tag::Compound(map) => return map.get(&JavaString::from(seg.as_str())).is_some_and(next),
-        Tag::List(v) => v.len(),
-        Tag::ByteArray(v) => v.len(),
-        Tag::IntArray(v) => v.len(),
-        Tag::LongArray(v) => v.len(),
-        _ => return false,
-    };
-    let element = |i: usize| match tag {
-        Tag::List(v) => Cow::Borrowed(&v[i]),
-        Tag::ByteArray(v) => Cow::Owned(Tag::Byte(v[i] as i8)),
-        Tag::IntArray(v) => Cow::Owned(Tag::Int(v[i])),
-        Tag::LongArray(v) => Cow::Owned(Tag::Long(v[i])),
-        _ => Cow::Owned(Tag::End),
-    };
-    if seg == "count" {
-        return next(&Tag::Int(i32::try_from(len).unwrap_or(i32::MAX)));
-    }
-    if seg == "*" {
-        return (0..len).any(|i| next(&element(i)));
-    }
-    seg.parse::<usize>()
-        .ok()
-        .filter(|&i| i < len)
-        .is_some_and(|i| next(&element(i)))
-}
-
-fn int_value(tag: &Tag) -> Option<i64> {
-    match *tag {
-        Tag::Byte(v) => Some(v.into()),
-        Tag::Short(v) => Some(v.into()),
-        Tag::Int(v) => Some(v.into()),
-        Tag::Long(v) => Some(v),
-        _ => None,
-    }
-}
-
-/// A number as Java's `String.valueOf` writes it (`3`, `3.0`).
-fn decimal(tag: &Tag) -> Option<String> {
-    let s = match *tag {
-        Tag::Float(b) => f32::from_bits(b).to_string(),
-        Tag::Double(b) => f64::from_bits(b).to_string(),
-        _ => return int_value(tag).map(|v| v.to_string()),
-    };
-    Some(if s.contains(['.', 'e', 'N', 'i']) {
-        s
-    } else {
-        s + ".0"
-    })
-}
-
-/// `text` against a string, its JSON text, or the plain text of a text component.
-fn text_matches(tag: &Tag, is_text: bool, text: impl Fn(&str) -> bool) -> bool {
-    match tag {
-        Tag::String(s) => {
-            let s = s.to_string_lossy();
-            text(&s)
-                || (is_text && text(&name_text(tag).plain()))
-                || json_plain(&s).is_some_and(|p| text(&p))
-        }
-        Tag::Compound(_) | Tag::List(_) => is_text && text(&name_text(tag).plain()),
-        _ => false,
-    }
-}
-
-fn value_test(test: &ValueTest, lit: &Prepared, tag: &Tag, is_text: bool) -> bool {
-    match test {
-        ValueTest::Exists(_) => true,
-        ValueTest::Range(r) => {
-            int_value(tag).is_some_and(|v| i32::try_from(v).is_ok_and(|v| r.contains(v)))
-        }
-        ValueTest::Raw(name) => name.matches(&canon_tag(tag)),
-        ValueTest::Text(name) => match decimal(tag) {
-            Some(n) => name.matches(&n),
-            None => text_matches(tag, is_text, |s| name.matches(s)),
-        },
-        ValueTest::Literal(l) => match tag {
-            Tag::Float(b) => l.text.trim().parse::<f32>().ok() == Some(f32::from_bits(*b)),
-            Tag::Double(b) => l.float == Some(f64::from_bits(*b)),
-            Tag::Compound(_) | Tag::List(_)
-                if lit.snbt.as_ref().is_some_and(|e| contains(e, tag)) =>
-            {
-                true
-            }
-            _ => match int_value(tag) {
-                Some(v) => l.int == Some(v),
-                None => text_matches(tag, is_text, |s| {
-                    s == l.text || lit.json.as_deref() == Some(s)
-                }),
-            },
-        },
-    }
-}
-
-/// `NbtUtils.compareNbt(expected, actual, true)`: every key and element of `expected` found in
-/// `actual`.
-fn contains(expected: &Tag, actual: &Tag) -> bool {
-    match (expected, actual) {
-        (Tag::Compound(e), Tag::Compound(a)) => e
-            .iter()
-            .all(|(k, v)| a.get(k).is_some_and(|a| contains(v, a))),
-        (Tag::List(e), Tag::List(a)) if e.is_empty() => a.is_empty(),
-        (Tag::List(e), Tag::List(a)) => e.iter().all(|e| a.iter().any(|a| contains(e, a))),
-        _ => expected == actual,
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use std::sync::Arc;
-
-    /// Rules from (file stem, properties), sorted as `load_rules` sorts them.
-    fn rules(files: &[(&str, &str)]) -> CitRules {
-        let mut rules: Vec<Rule> = files
-            .iter()
-            .map(|(stem, text)| {
-                let path = format!("assets/minecraft/optifine/cit/{stem}.properties");
-                let text = format!("texture=x\n{text}");
-                Rule::parse(&path, &Properties::parse_equals_first(&text), |_| true).unwrap()
-            })
-            .collect();
-        rules.sort_by(Rule::priority);
-        CitRules::new(rules)
-    }
-
-    fn stem(cit: &CitRules, i: Option<usize>) -> Option<&str> {
-        let path = &cit.rules[i?].path;
-        path.rsplit('/').next()?.strip_suffix(".properties")
-    }
-
-    fn item(cit: &CitRules, stack: ItemStack) -> Option<&str> {
-        stem(cit, cit.select(Kind::Item, &stack, Hand::Main, 0))
-    }
-
-    fn new(id: &str) -> ItemStack {
-        ItemStack::new(&format!("minecraft:{id}"), 1)
-    }
-
-    fn string(s: &str) -> Tag {
-        Tag::String(s.into())
-    }
-
-    fn with(id: &str, component: &str, tag: Tag) -> ItemStack {
-        let mut stack = new(id);
-        let component = format!("minecraft:{component}");
-        stack.data_mut().other.push((component, tag));
-        stack
-    }
-
-    fn enchanted(id: &str, levels: &[(&str, u32)]) -> ItemStack {
-        let mut stack = new(id);
-        let levels = levels
-            .iter()
-            .map(|(e, l)| (Arc::from(format!("minecraft:{e}")), *l));
-        stack.data_mut().enchantments = levels.collect();
-        stack
-    }
-
-    #[test]
-    fn heavier_rules_win_and_kinds_stay_apart() {
-        let cit = rules(&[
-            ("plain", "items=stick"),
-            ("heavy", "items=stick\nweight=2\nstackSize=2-"),
-            ("offhand", "items=stick\nweight=5\nhand=off"),
-            ("armor", "type=armor\nitems=stick"),
-            ("wings", "type=elytra"),
-        ]);
-        assert_eq!(item(&cit, new("stick")), Some("plain"));
-        assert_eq!(
-            item(&cit, ItemStack::new("minecraft:stick", 3)),
-            Some("heavy")
-        );
-        let pick = |kind, id, hand, max| stem(&cit, cit.select(kind, &new(id), hand, max));
-        assert_eq!(pick(Kind::Item, "stick", Hand::Off, 0), Some("offhand"));
-        assert_eq!(item(&cit, new("stone")), None);
-        assert_eq!(item(&cit, new("elytra")), None);
-        assert_eq!(pick(Kind::Elytra, "elytra", Hand::Main, 432), Some("wings"));
-        assert_eq!(pick(Kind::Armor, "stick", Hand::Main, 0), Some("armor"));
-    }
-
-    #[test]
-    fn names_match_by_their_plain_text() {
-        let cit = rules(&[
-            ("glob", "items=stick\nnbt.display.Name=ipattern:*sword"),
-            ("exact", "items=stone\ncomponents.custom_name=My Sword"),
-            ("json", "items=dirt\nnbt.display.Name=[\"My \",\"Sword\"]"),
-        ]);
-        let named = |id: &str, name: Tag| {
-            let mut stack = new(id);
-            stack.data_mut().custom_name = Some(name);
-            stack
-        };
-        let styled = Tag::compound([("text", string("My Sword")), ("color", string("red"))]);
-        assert_eq!(item(&cit, named("stick", styled.clone())), Some("glob"));
-        assert_eq!(item(&cit, named("stick", string("Blade"))), None);
-        assert_eq!(item(&cit, new("stick")), None);
-        assert_eq!(item(&cit, named("stone", styled.clone())), Some("exact"));
-        assert_eq!(item(&cit, named("dirt", styled)), Some("json"));
-    }
-
-    #[test]
-    fn lore_lines_and_list_counts() {
-        let cit = rules(&[
-            (
-                "any_line",
-                "items=stick\nnbt.display.Lore.*=ipattern:*legendary*",
-            ),
-            ("two_lines", "items=stone\ncomponents.lore.count=2"),
-        ]);
-        let bold = Tag::compound([("text", string("A LEGENDARY item")), ("bold", Tag::Byte(1))]);
-        let lore = Tag::List(vec![string("Common"), bold]);
-        assert_eq!(
-            item(&cit, with("stick", "lore", lore.clone())),
-            Some("any_line")
-        );
-        assert_eq!(item(&cit, with("stone", "lore", lore)), Some("two_lines"));
-        let one = Tag::List(vec![string("A legendary item")]);
-        assert_eq!(item(&cit, with("stone", "lore", one)), None);
-    }
-
-    #[test]
-    fn custom_data_existence_and_negation() {
-        let cit = rules(&[
-            (
-                "aote",
-                "items=stick\nweight=2\nnbt.ExtraAttributes.id=ASPECT_OF_THE_END",
-            ),
-            (
-                "not_hyp",
-                "items=stick\nweight=1\ncomponent.custom_data.ExtraAttributes.id=!HYP",
-            ),
-            ("unnamed", "items=stick\nnbt.display.Name=exists:false"),
-        ]);
-        let data = |id: &str| {
-            let attributes =
-                Tag::compound([("ExtraAttributes", Tag::compound([("id", string(id))]))]);
-            with("stick", "custom_data", attributes)
-        };
-        assert_eq!(item(&cit, data("ASPECT_OF_THE_END")), Some("aote"));
-        assert_eq!(item(&cit, data("MIDAS")), Some("not_hyp"));
-        assert_eq!(item(&cit, data("HYP")), Some("unnamed"));
-        let mut named = data("HYP");
-        named.data_mut().custom_name = Some(string("Hyperion"));
-        assert_eq!(item(&cit, named), None);
-    }
-
-    #[test]
-    fn legacy_enchantment_lists_and_model_data() {
-        let cit = rules(&[
-            (
-                "sharp",
-                "items=stick\nnbt.Enchantments.*.id=minecraft:sharpness\nnbt.Enchantments.0.lvl=5",
-            ),
-            ("cmd", "items=stone\nnbt.CustomModelData=3"),
-            (
-                "cmd_snbt",
-                "items=dirt\ncomponents.custom_model_data={floats:[3.0f]}",
-            ),
-        ]);
-        assert_eq!(
-            item(&cit, enchanted("stick", &[("sharpness", 5)])),
-            Some("sharp")
-        );
-        assert_eq!(item(&cit, enchanted("stick", &[("sharpness", 4)])), None);
-        let model = |id: &str, f: f32| {
-            let floats = Tag::List(vec![Tag::Float(f.to_bits()), Tag::Float(7f32.to_bits())]);
-            with(id, "custom_model_data", Tag::compound([("floats", floats)]))
-        };
-        assert_eq!(item(&cit, model("stone", 3.0)), Some("cmd"));
-        assert_eq!(item(&cit, model("stone", 3.5)), None);
-        assert_eq!(item(&cit, model("dirt", 3.0)), Some("cmd_snbt"));
-        assert_eq!(item(&cit, model("dirt", 2.0)), None);
-    }
-
-    #[test]
-    fn fields_left_out_at_zero_read_as_zero() {
-        let cit = rules(&[("zero", "items=firework_rocket\nnbt.Fireworks.Flight=0")]);
-        let mut rocket = new("firework_rocket");
-        rocket.data_mut().fireworks = Some((0, Vec::new()));
-        assert_eq!(item(&cit, rocket.clone()), Some("zero"));
-        rocket.data_mut().fireworks = Some((2, Vec::new()));
-        assert_eq!(item(&cit, rocket), None);
-    }
-
-    #[test]
-    fn damage_counts_only_for_damageable_items() {
-        let cit = rules(&[
-            ("worn", "items=diamond_sword\ndamage=50-100%"),
-            ("new", "items=stick\ndamage=0"),
-        ]);
-        let damaged = |id: &str, damage: u32, max: u32| {
-            let mut stack = new(id);
-            stack.damage = damage;
-            stem(&cit, cit.select(Kind::Item, &stack, Hand::Main, max))
-        };
-        // Half of 1561 is 780.5.
-        assert_eq!(damaged("diamond_sword", 780, 1561), None);
-        assert_eq!(damaged("diamond_sword", 781, 1561), Some("worn"));
-        assert_eq!(damaged("stick", 5, 0), Some("new"));
-    }
-
-    #[test]
-    fn enchantment_levels_and_rules_for_any_item() {
-        let cit = rules(&[
-            (
-                "sharp3",
-                "items=stick\nenchantments=sharpness\nenchantmentLevels=3-",
-            ),
-            ("any3", "items=stone\nenchantmentLevels=3-"),
-            ("glint", "type=enchantment\nenchantments=sharpness"),
-            (
-                "sword_glint",
-                "type=enchantment\nitems=diamond_sword\nweight=2",
-            ),
-        ]);
-        let mixed = [("sharpness", 2), ("unbreaking", 3)];
-        assert_eq!(item(&cit, enchanted("stick", &mixed)), None);
-        assert_eq!(
-            item(&cit, enchanted("stick", &[("sharpness", 4)])),
-            Some("sharp3")
-        );
-        assert_eq!(item(&cit, enchanted("stone", &mixed)), Some("any3"));
-        let glints = |stack: ItemStack| -> Vec<&str> {
-            let found = cit.enchantments(&stack, Hand::Main, 0).into_iter();
-            found.map(|i| stem(&cit, Some(i)).unwrap()).collect()
-        };
-        let sharp = [("sharpness", 1)];
-        assert_eq!(
-            glints(enchanted("diamond_sword", &sharp)),
-            ["sword_glint", "glint"]
-        );
-        assert_eq!(glints(enchanted("stick", &sharp)), ["glint"]);
-        assert!(glints(new("stick")).is_empty());
-        // Glints are never an item's texture.
-        assert_eq!(item(&cit, enchanted("diamond_sword", &sharp)), None);
-    }
-
-    /// `CitRules::glint` in the main hand, with the stack's own `has_foil` as callers pass it.
-    fn glint(cit: &CitRules, stack: &ItemStack, item_glint: bool) -> Option<Arc<StackGlint>> {
-        cit.glint(stack, Hand::Main, 0, stack.has_foil(item_glint))
-    }
-
-    /// `stack` with its `enchantment_glint_override` set to `on`.
-    fn overridden(mut stack: ItemStack, on: bool) -> ItemStack {
-        let flag = (
-            "minecraft:enchantment_glint_override".to_owned(),
-            Tag::Byte(on.into()),
-        );
-        stack.data_mut().other.push(flag);
-        stack
-    }
-
-    #[test]
-    fn a_stack_glint_reads_the_book_and_the_pack_file() {
-        let mut cit = rules(&[
-            ("sharp", "type=enchantment\nenchantments=sharpness"),
-            (
-                "keep",
-                "type=enchantment\nlayer=1\nuseGlint=true\nenchantments=mending",
-            ),
-        ]);
-        // An enchanted book's glint follows its stored enchantments.
-        let mut book = new("enchanted_book");
-        book.data_mut().stored_enchantments = vec![
-            (Arc::from("minecraft:sharpness"), 3),
-            (Arc::from("minecraft:mending"), 1),
-        ];
-        let book = glint(&cit, &book, true).unwrap();
-        let weights: Vec<_> = book.layers.iter().map(|l| l.weight).collect();
-        assert_eq!(weights, [0.75, 0.25]);
-        assert!(book.vanilla);
-        let plain = glint(&cit, &enchanted("stick", &[("sharpness", 1)]), false).unwrap();
-        assert_eq!(plain.layers.len(), 1);
-        assert!(!plain.vanilla);
-        // No enchantment rules: nothing changes, unless the pack turns vanilla's glint off.
-        let mut bare = rules(&[("stick", "items=stick")]);
-        assert!(glint(&bare, &overridden(new("stick"), true), false).is_none());
-        bare.global.use_glint = false;
-        assert!(
-            !glint(&bare, &overridden(new("stick"), true), false)
-                .unwrap()
-                .vanilla
-        );
-        cit.global.use_glint = false;
-        assert!(
-            glint(&cit, &overridden(new("stick"), true), false)
-                .unwrap()
-                .is_empty()
-        );
-    }
-
-    #[test]
-    fn only_a_stack_with_a_glint_gets_layers() {
-        let cit = rules(&[("any", "type=enchantment")]);
-        assert!(glint(&cit, &new("stick"), false).is_none());
-        // The override turns an enchanted stack's glint off, and an unenchanted one's on.
-        let off = overridden(enchanted("stick", &[("sharpness", 1)]), false);
-        assert!(glint(&cit, &off, false).is_none());
-        let on = glint(&cit, &overridden(new("stick"), true), false).unwrap();
-        let weights: Vec<_> = on.layers.iter().map(|l| l.weight).collect();
-        assert_eq!(
-            weights,
-            [1.0],
-            "nothing to share: the rule at full strength"
-        );
-        // The same stack, asked again without its glint, is not answered from the cache.
-        assert!(
-            cit.glint(&overridden(new("stick"), true), Hand::Main, 0, false)
-                .is_none()
-        );
-    }
-
-    #[test]
-    fn a_rule_left_out_of_the_glints_matches_nothing() {
-        let mut cit = rules(&[
-            ("broken", "type=enchantment\nitems=diamond_sword\nweight=1"),
-            ("shown", "type=enchantment"),
-        ]);
-        let sword = enchanted("diamond_sword", &[("sharpness", 1)]);
-        let layers = |cit: &CitRules| -> Vec<String> {
-            let glint = glint(cit, &sword, false).unwrap();
-            let stems = glint
-                .layers
-                .iter()
-                .map(|l| stem(cit, Some(l.rule)).unwrap());
-            stems.map(str::to_owned).collect()
-        };
-        // The heavier rule wins the layer, until its texture is missing.
-        assert_eq!(layers(&cit), ["broken"]);
-        let broken = (0..cit.rules.len())
-            .find(|&i| stem(&cit, Some(i)) == Some("broken"))
-            .unwrap();
-        cit.keep_glints(|i| i != broken);
-        assert_eq!(layers(&cit), ["shown"]);
-        assert_eq!(cit.enchantments(&sword, Hand::Main, 0).len(), 1);
-        // None left: vanilla's glint stays.
-        cit.keep_glints(|_| false);
-        assert!(glint(&cit, &sword, false).is_none());
-    }
-
-    #[test]
-    fn an_off_hand_layer_draws_only_in_the_off_hand() {
-        let cit = rules(&[
-            ("left", "type=enchantment\nlayer=1\nhand=off"),
-            ("both", "type=enchantment"),
-        ]);
-        let sword = enchanted("diamond_sword", &[("sharpness", 1)]);
-        let layers = |hand| -> Vec<&str> {
-            let glint = cit.glint(&sword, hand, 0, true).unwrap();
-            glint
-                .layers
-                .iter()
-                .map(|l| stem(&cit, Some(l.rule)).unwrap())
-                .collect()
-        };
-        assert_eq!(layers(Hand::Off), ["both", "left"]);
-        // Asked in this order, a cache keyed without the hand would answer as for the off hand.
-        assert_eq!(layers(Hand::Main), ["both"]);
-    }
-}

crates/horizon-client-render/src/cit_armor.rs

@@ -1,319 +0,0 @@
-//! Custom Item Textures for worn armour and elytra (`type=armor`, `type=elytra`). An armour rule
-//! names its textures after the armour texture files of before 1.21.2
-//! (`textures/models/armor/diamond_layer_1.png`): `texture.diamond_layer_1`,
-//! `texture.leather_layer_2_overlay`..., with `texture` for any layer it does not name. 26.3's
-//! equipment assets name the same layers `entity/equipment/humanoid/diamond` (layer 1: helmet,
-//! chestplate, boots) and `entity/equipment/humanoid_leggings/diamond` (layer 2), so the layers
-//! are mapped back to the old names here. An elytra rule's `texture` replaces the wings'.
-
-use crate::cit_assets::{rule_sprites, sprite_id};
-use horizon_optifine::cit::{Kind, Rule};
-use std::collections::BTreeSet;
-
-/// The pre-1.21.2 armour texture name of an equipment asset's layer: `asset` (`minecraft:gold`
-/// or `gold`) on the leggings layer (`humanoid_leggings`) or the others (`humanoid`), the dye
-/// overlay (`leather_overlay`) or the main texture.
-pub fn armor_layer_name(asset: &str, leggings: bool, overlay: bool) -> String {
-    let path = asset.rsplit_once(':').map_or(asset, |(_, p)| p);
-    // The equipment assets renamed from their old textures; the rest kept their names.
-    let old = match path {
-        "turtle_scute" => "turtle",
-        other => other,
-    };
-    let layer = if leggings { 2 } else { 1 };
-    let suffix = if overlay { "_overlay" } else { "" };
-    format!("{old}_layer_{layer}{suffix}")
-}
-
-/// The texture (a resource path) `rule` draws on the layer named `layer`: its `texture.<layer>`,
-/// else its `texture`.
-pub fn armor_texture<'a>(rule: &'a Rule, layer: &str) -> Option<&'a str> {
-    rule.textures
-        .iter()
-        .find(|(name, _)| name == layer)
-        .map(|(_, path)| path.as_str())
-        .or(rule.texture.as_deref())
-}
-
-/// The atlas name of a CIT texture: its `cit_assets` id, without `minecraft:` as the atlas packs
-/// vanilla's sprites.
-fn atlas_name(resource: &str) -> Option<String> {
-    let id = sprite_id(resource)?;
-    Some(match id.strip_prefix("minecraft:") {
-        Some(name) => name.to_owned(),
-        None => id,
-    })
-}
-
-/// The atlas sprite `rule` puts on the layer of equipment asset `asset` (see
-/// [`armor_layer_name`]); `None` keeps the vanilla texture.
-pub fn layer_sprite(rule: &Rule, asset: &str, leggings: bool, overlay: bool) -> Option<String> {
-    atlas_name(armor_texture(
-        rule,
-        &armor_layer_name(asset, leggings, overlay),
-    )?)
-}
-
-/// The atlas sprite an elytra rule puts on the wings.
-pub fn elytra_sprite(rule: &Rule) -> Option<String> {
-    atlas_name(armor_texture(rule, "elytra")?)
-}
-
-/// The atlas sprite the one CIT armour rule `rule` puts on a worn armour layer: the layer
-/// `vanilla` (an atlas name, `…_overlay` for the dye overlay) of equipment asset `asset` in
-/// equipment layer `kind` (`humanoid_leggings` for the leggings). `None` draws `vanilla`, as does
-/// a name the atlas lacks; nothing is allocated without a rule.
-pub fn worn_layer_sprite(
-    rule: Option<&Rule>,
-    asset: &str,
-    kind: &str,
-    vanilla: &str,
-) -> Option<String> {
-    let leggings = kind == "humanoid_leggings";
-    let overlay = vanilla.ends_with("_overlay");
-    layer_sprite(rule?, asset, leggings, overlay)
-}
-
-/// The CIT elytra rule's wings sprite. On `None`, or a name the atlas lacks, the caller draws the
-/// cape, else the equipment asset's own wings.
-pub fn wings_sprite(rule: Option<&Rule>) -> Option<String> {
-    elytra_sprite(rule?)
-}
-
-/// What a worn layer draws, looked up with `get` (the atlas): the rule's sprite
-/// ([`worn_layer_sprite`]), else `vanilla` when there is no rule or the atlas lacks its texture.
-pub fn worn_layer<R>(
-    rule: Option<&Rule>,
-    asset: &str,
-    kind: &str,
-    vanilla: &str,
-    get: impl Fn(&str) -> Option<R>,
-) -> Option<R> {
-    worn_layer_sprite(rule, asset, kind, vanilla)
-        .and_then(|name| get(&name))
-        .or_else(|| get(vanilla))
-}
-
-/// What worn wings draw, looked up with `get`: the rule's sprite, else the cape; `None` leaves
-/// them to the equipment asset's own wings.
-pub fn wings<R>(
-    rule: Option<&Rule>,
-    cape: Option<&str>,
-    get: impl Fn(&str) -> Option<R>,
-) -> Option<R> {
-    wings_sprite(rule)
-        .and_then(|name| get(&name))
-        .or_else(|| cape.and_then(&get))
-}
-
-/// Sprite ids the armour and elytra rules draw (see [`rule_sprites`]).
-pub fn armor_sprites(rules: &[Rule]) -> BTreeSet<String> {
-    rule_sprites(rules, |kind| matches!(kind, Kind::Armor | Kind::Elytra))
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use horizon_optifine::Properties;
-
-    fn rule(path: &str, text: &str) -> Rule {
-        Rule::parse(path, &Properties::parse_equals_first(text), |_| true).unwrap()
-    }
-
-    #[test]
-    fn layers_take_their_old_texture_names() {
-        assert_eq!(
-            armor_layer_name("minecraft:diamond", false, false),
-            "diamond_layer_1"
-        );
-        assert_eq!(armor_layer_name("diamond", true, false), "diamond_layer_2");
-        assert_eq!(
-            armor_layer_name("minecraft:leather", false, true),
-            "leather_layer_1_overlay"
-        );
-        assert_eq!(
-            armor_layer_name("minecraft:leather", true, true),
-            "leather_layer_2_overlay"
-        );
-        assert_eq!(
-            armor_layer_name("minecraft:gold", false, false),
-            "gold_layer_1"
-        );
-        assert_eq!(
-            armor_layer_name("minecraft:chainmail", true, false),
-            "chainmail_layer_2"
-        );
-        assert_eq!(
-            armor_layer_name("minecraft:turtle_scute", false, false),
-            "turtle_layer_1"
-        );
-        assert_eq!(
-            armor_layer_name("minecraft:netherite", true, false),
-            "netherite_layer_2"
-        );
-    }
-
-    #[test]
-    fn a_named_layer_wins_over_the_generic_texture() {
-        let r = rule(
-            "assets/minecraft/optifine/cit/armor/blue.properties",
-            "type=armor\nitems=diamond_chestplate diamond_leggings\ntexture=generic\n\
-             texture.diamond_layer_2=blue_legs\n",
-        );
-        let dir = "assets/minecraft/optifine/cit/armor";
-        assert_eq!(
-            armor_texture(&r, "diamond_layer_2"),
-            Some(format!("{dir}/blue_legs.png").as_str())
-        );
-        assert_eq!(
-            armor_texture(&r, "diamond_layer_1"),
-            Some(format!("{dir}/generic.png").as_str())
-        );
-        assert_eq!(
-            layer_sprite(&r, "minecraft:diamond", true, false).as_deref(),
-            Some("horizon_cit:minecraft/optifine/cit/armor/blue_legs")
-        );
-        assert_eq!(
-            layer_sprite(&r, "minecraft:diamond", false, false).as_deref(),
-            Some("horizon_cit:minecraft/optifine/cit/armor/generic")
-        );
-    }
-
-    #[test]
-    fn without_a_generic_texture_other_layers_stay_vanilla() {
-        let r = rule(
-            "assets/minecraft/optifine/cit/a.properties",
-            "type=armor\nitems=leather_helmet\ntexture.leather_layer_1=dyed\n",
-        );
-        assert_eq!(
-            layer_sprite(&r, "minecraft:leather", false, false).as_deref(),
-            Some("horizon_cit:minecraft/optifine/cit/dyed")
-        );
-        assert_eq!(layer_sprite(&r, "minecraft:leather", false, true), None);
-        assert_eq!(layer_sprite(&r, "minecraft:leather", true, false), None);
-    }
-
-    #[test]
-    fn a_vanilla_texture_path_keeps_its_atlas_name() {
-        let r = rule(
-            "assets/minecraft/optifine/cit/wings.properties",
-            "type=elytra\ntexture=minecraft:textures/entity/wings/dragon.png\n",
-        );
-        assert_eq!(elytra_sprite(&r).as_deref(), Some("entity/wings/dragon"));
-    }
-
-    #[test]
-    fn worn_layers_pick_the_rules_texture_for_their_layer() {
-        let r = rule(
-            "assets/minecraft/optifine/cit/dye.properties",
-            "type=armor\nitems=leather_chestplate leather_leggings\n\
-             texture.leather_layer_1=body\ntexture.leather_layer_1_overlay=body_dye\n\
-             texture.leather_layer_2=legs\n",
-        );
-        let cit = |p: &str| Some(format!("horizon_cit:minecraft/optifine/cit/{p}"));
-        let pick = |kind: &str, vanilla: &str| {
-            worn_layer_sprite(Some(&r), "minecraft:leather", kind, vanilla)
-        };
-        let body = "entity/equipment/humanoid/leather";
-        assert_eq!(pick("humanoid", body), cit("body"));
-        assert_eq!(
-            pick("humanoid", "entity/equipment/humanoid/leather_overlay"),
-            cit("body_dye")
-        );
-        assert_eq!(
-            pick(
-                "humanoid_leggings",
-                "entity/equipment/humanoid_leggings/leather"
-            ),
-            cit("legs")
-        );
-        // No `texture.leather_layer_2_overlay` and no `texture`: the overlay stays vanilla.
-        let legs_dye = "entity/equipment/humanoid_leggings/leather_overlay";
-        assert_eq!(pick("humanoid_leggings", legs_dye), None);
-        // No rule draws vanilla's.
-        assert_eq!(
-            worn_layer_sprite(None, "minecraft:leather", "humanoid", body),
-            None
-        );
-    }
-
-    #[test]
-    fn wings_take_the_rules_texture() {
-        let r = rule(
-            "assets/minecraft/optifine/cit/wings.properties",
-            "type=elytra\ntexture=wings\n",
-        );
-        assert_eq!(
-            wings_sprite(Some(&r)).as_deref(),
-            Some("horizon_cit:minecraft/optifine/cit/wings")
-        );
-        assert_eq!(wings_sprite(None), None);
-    }
-
-    #[test]
-    fn only_armor_and_elytra_rules_reach_the_atlas() {
-        let rules = [
-            rule(
-                "assets/minecraft/optifine/cit/sword.properties",
-                "items=diamond_sword\ntexture=sword\n",
-            ),
-            rule(
-                "assets/minecraft/optifine/cit/plate.properties",
-                "type=armor\nitems=iron_chestplate iron_leggings\ntexture=plate\n\
-                 texture.iron_layer_2=legs\n",
-            ),
-            rule(
-                "assets/minecraft/optifine/cit/wings.properties",
-                "type=elytra\ntexture=wings\n",
-            ),
-            rule(
-                "assets/minecraft/optifine/cit/glint.properties",
-                "type=enchantment\nenchantments=sharpness\ntexture=glint\n",
-            ),
-        ];
-        let got: Vec<String> = armor_sprites(&rules).into_iter().collect();
-        assert_eq!(
-            got,
-            [
-                "horizon_cit:minecraft/optifine/cit/legs",
-                "horizon_cit:minecraft/optifine/cit/plate",
-                "horizon_cit:minecraft/optifine/cit/wings",
-            ]
-        );
-    }
-
-    /// An atlas lookup that knows `names`.
-    fn atlas(names: &[&str]) -> impl Fn(&str) -> Option<String> {
-        let names: Vec<String> = names.iter().map(|n| (*n).to_owned()).collect();
-        move |s| names.iter().any(|n| n == s).then(|| s.to_owned())
-    }
-
-    #[test]
-    fn the_atlas_lookup_falls_back_to_vanilla_and_the_cape() {
-        let iron = rule(
-            "assets/minecraft/optifine/cit/iron.properties",
-            "type=armor\nitems=iron_chestplate\ntexture.iron_layer_1=plate",
-        );
-        let plate = "horizon_cit:minecraft/optifine/cit/plate";
-        let vanilla = "entity/equipment/humanoid/iron";
-        let layer = |rule: Option<&Rule>, names: &[&str]| {
-            worn_layer(rule, "minecraft:iron", "humanoid", vanilla, atlas(names))
-        };
-        assert_eq!(
-            layer(Some(&iron), &[plate, vanilla]).as_deref(),
-            Some(plate)
-        );
-        // The rule's texture didn't reach the atlas, or there's no rule: vanilla's layer.
-        assert_eq!(layer(Some(&iron), &[vanilla]).as_deref(), Some(vanilla));
-        assert_eq!(layer(None, &[plate, vanilla]).as_deref(), Some(vanilla));
-        let elytra = rule(
-            "assets/minecraft/optifine/cit/w.properties",
-            "type=elytra\ntexture=wings",
-        );
-        let w = "horizon_cit:minecraft/optifine/cit/wings";
-        let wing = |rule: Option<&Rule>, names: &[&str]| wings(rule, Some("cape/x"), atlas(names));
-        assert_eq!(wing(Some(&elytra), &[w, "cape/x"]).as_deref(), Some(w));
-        assert_eq!(wing(Some(&elytra), &["cape/x"]).as_deref(), Some("cape/x"));
-        assert_eq!(wings(None, None, atlas(&[w])), None);
-    }
-}

crates/horizon-client-render/src/cit_assets.rs

@@ -1,342 +0,0 @@
-//! The ids Custom Item Textures' files take in Horizon's atlas and model library. A CIT rule
-//! names its textures and models by resource path, mostly under `optifine/cit/` where vanilla
-//! never looks: those take the reserved namespace [`NAMESPACE`], their path the resource path's
-//! (`assets/minecraft/optifine/cit/swords/flame.png` is
-//! `horizon_cit:minecraft/optifine/cit/swords/flame`). A file already under `textures/` (or
-//! `models/`) keeps its vanilla id, so it is not packed twice.
-
-use horizon_assets::model::{CuboidModel, TextureSlot};
-use horizon_optifine::cit::{Kind, Rule};
-use std::collections::{BTreeMap, BTreeSet};
-use std::fs;
-use std::path::Path;
-
-/// The namespace of CIT files outside `textures/` and `models/`.
-pub const NAMESPACE: &str = "horizon_cit";
-
-/// `<namespace>:<path>`, if both keep to the identifier rules (lower-case letters, digits,
-/// `_.-`, and `/` in the path). CIT Resewn refuses the other paths too.
-fn identifier(namespace: &str, path: &str) -> Option<String> {
-    if namespace.is_empty() || path.is_empty() {
-        return None;
-    }
-    horizon_client_core::identifier::parse_identifier(&format!("{namespace}:{path}"))
-}
-
-/// The id of a resource path ending in `.<ext>`: `assets/<ns>/<folder>/<p>` is `<ns>:<p>`, any
-/// other `assets/<rest>` is `horizon_cit:<rest>`.
-fn id(resource: &str, folder: &str, ext: &str) -> Option<String> {
-    let rest = resource
-        .strip_prefix("assets/")?
-        .strip_suffix(ext)?
-        .strip_suffix('.')?;
-    if let Some((namespace, path)) = rest.split_once('/')
-        && let Some(path) = path.strip_prefix(folder).and_then(|p| p.strip_prefix('/'))
-    {
-        // A pack's own `assets/horizon_cit/` would name another file than its id maps back to.
-        return (namespace != NAMESPACE)
-            .then(|| identifier(namespace, path))
-            .flatten();
-    }
-    identifier(NAMESPACE, rest)
-}
-
-/// The atlas sprite id of a `.png` resource path.
-pub fn sprite_id(resource: &str) -> Option<String> {
-    id(resource, "textures", "png")
-}
-
-/// The model id of a `.json` resource path.
-pub fn model_id(resource: &str) -> Option<String> {
-    id(resource, "models", "json")
-}
-
-/// The resource path of a `horizon_cit` id, with the extension `ext`; `None` for other ids,
-/// and for one that would leave the resource root (a pack model may write any id).
-pub fn resource(id: &str, ext: &str) -> Option<String> {
-    let rest = id.strip_prefix(NAMESPACE)?.strip_prefix(':')?;
-    horizon_optifine::paths::valid(rest).then(|| format!("assets/{rest}.{ext}"))
-}
-
-/// Sprite ids the rules whose kind passes `keep` draw: their `texture` and `texture.<name>`
-/// values. A path no id can name is skipped with a warning.
-pub fn rule_sprites(rules: &[Rule], keep: impl Fn(Kind) -> bool) -> BTreeSet<String> {
-    let mut out = BTreeSet::new();
-    for rule in rules.iter().filter(|r| keep(r.kind)) {
-        let named = rule.textures.iter().map(|(_, path)| path);
-        for path in rule.texture.iter().chain(named) {
-            match sprite_id(path) {
-                Some(id) => {
-                    out.insert(id);
-                }
-                None => log::warn!(
-                    "custom item textures: {} names {path}, which is not a valid texture id",
-                    rule.path
-                ),
-            }
-        }
-    }
-    out
-}
-
-/// Sprite ids the item rules draw (`Kind::Item`, see [`rule_sprites`]). Textures named by CIT
-/// JSON models are [`model_sprites`].
-pub fn item_sprites(rules: &[Rule]) -> BTreeSet<String> {
-    rule_sprites(rules, |kind| kind == Kind::Item)
-}
-
-/// The resource path a model value `./x` (or `./../x`, `../x`) names beside the file at `file`,
-/// ending in `.<ext>` (added unless the value has it). `None` for other values and for paths
-/// that would leave the root.
-fn relative(file: &str, value: &str, ext: &str) -> Option<String> {
-    let mut rest = value
-        .strip_prefix("./")
-        .or_else(|| value.starts_with("../").then_some(value))?;
-    let mut dir = file.rsplit_once('/')?.0;
-    while let Some(up) = rest.strip_prefix("../") {
-        dir = dir.rsplit_once('/')?.0;
-        rest = up;
-    }
-    let rest = rest
-        .strip_suffix(ext)
-        .and_then(|r| r.strip_suffix('.'))
-        .unwrap_or(rest);
-    let path = format!("{dir}/{rest}.{ext}");
-    horizon_optifine::paths::valid(&path).then_some(path)
-}
-
-/// The id a relative value of the model at `file` names, as `CuboidModel::from_json` read it
-/// (`./x` is `minecraft:./x` there), with the resource path of the file it names.
-fn rebase(file: &str, id: &str, ext: &str) -> Option<(String, String)> {
-    let path = relative(file, id.strip_prefix("minecraft:")?, ext)?;
-    let id = if ext == "png" {
-        sprite_id(&path)
-    } else {
-        model_id(&path)
-    }?;
-    Some((id, path))
-}
-
-/// Parents followed from a rule's model before the rest are left to the library.
-const MAX_PARENTS: usize = 16;
-
-/// The CIT JSON models the item rules name (`model`, `model.<name>`) under their [`model_id`]s,
-/// with the parents they reach by relative path. Their `./x` texture and parent values become
-/// the ids of the files beside them. Only `horizon_cit` models: the others are in the model
-/// library already. A file that does not read or parse is left out, and a rule's layer that
-/// names it (or a model whose parents reach it) keeps its vanilla model.
-pub fn load_models(root: &Path, rules: &[Rule]) -> BTreeMap<String, CuboidModel> {
-    let mut out = BTreeMap::new();
-    let mut seen = BTreeSet::new();
-    for rule in rules.iter().filter(|r| r.kind == Kind::Item) {
-        let named = rule.models.iter().map(|(_, path)| path);
-        for path in rule.model.iter().chain(named) {
-            load_model(root, path, 0, &mut seen, &mut out);
-        }
-    }
-    out
-}
-
-fn load_model(
-    root: &Path,
-    resource: &str,
-    depth: usize,
-    seen: &mut BTreeSet<String>,
-    out: &mut BTreeMap<String, CuboidModel>,
-) {
-    let Some(id) = model_id(resource) else {
-        log::warn!("custom item textures: {resource} is not a valid model id");
-        return;
-    };
-    let ours = id
-        .strip_prefix(NAMESPACE)
-        .is_some_and(|r| r.starts_with(':'));
-    if !ours || depth > MAX_PARENTS || !seen.insert(id.clone()) {
-        return;
-    }
-    let model = fs::read_to_string(root.join(resource))
-        .map_err(|e| e.to_string())
-        .and_then(|text| CuboidModel::from_json(&text).map_err(|e| e.to_string()));
-    let mut model = match model {
-        Ok(model) => model,
-        Err(e) => {
-            log::warn!("custom item textures: skipped model {resource}: {e}");
-            return;
-        }
-    };
-    for slot in model.textures.values_mut() {
-        if let TextureSlot::Material(m) = slot
-            && let Some((id, _)) = rebase(resource, &m.sprite, "png")
-        {
-            m.sprite = id;
-        }
-    }
-    let parent = model
-        .parent
-        .as_deref()
-        .and_then(|p| rebase(resource, p, "json"));
-    if let Some((id, path)) = parent {
-        model.parent = Some(id);
-        load_model(root, &path, depth + 1, seen, out);
-    }
-    out.insert(id, model);
-}
-
-/// The `horizon_cit` sprites `models` name, which the atlas packs beside [`item_sprites`].
-pub fn model_sprites(models: &BTreeMap<String, CuboidModel>) -> BTreeSet<String> {
-    let prefix = format!("{NAMESPACE}:");
-    models
-        .values()
-        .flat_map(|m| m.textures.values())
-        .filter_map(|slot| match slot {
-            TextureSlot::Material(m) if m.sprite.starts_with(&prefix) => Some(m.sprite.clone()),
-            _ => None,
-        })
-        .collect()
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::atlas_sources::texture_path;
-    use std::path::Path;
-
-    #[test]
-    fn cit_paths_take_the_reserved_namespace_and_come_back() {
-        let png = "assets/minecraft/optifine/cit/swords/flame.png";
-        let id = sprite_id(png).unwrap();
-        assert_eq!(id, "horizon_cit:minecraft/optifine/cit/swords/flame");
-        assert_eq!(resource(&id, "png").as_deref(), Some(png));
-        let json = "assets/minecraft/optifine/cit/swords/flame.json";
-        let id = model_id(json).unwrap();
-        assert_eq!(id, "horizon_cit:minecraft/optifine/cit/swords/flame");
-        assert_eq!(resource(&id, "json").as_deref(), Some(json));
-    }
-
-    #[test]
-    fn files_under_textures_and_models_keep_their_vanilla_ids() {
-        let id = sprite_id("assets/minecraft/textures/item/stick.png");
-        assert_eq!(id.as_deref(), Some("minecraft:item/stick"));
-        let id = model_id("assets/gems/models/item/ruby.json");
-        assert_eq!(id.as_deref(), Some("gems:item/ruby"));
-        // A model id is not a resource of this module's own.
-        assert_eq!(resource("minecraft:item/stick", "png"), None);
-        // `textures` as a folder name elsewhere is still a CIT path.
-        let id = sprite_id("assets/minecraft/optifine/cit/textures/a.png");
-        assert_eq!(
-            id.as_deref(),
-            Some("horizon_cit:minecraft/optifine/cit/textures/a")
-        );
-    }
-
-    #[test]
-    fn paths_no_identifier_can_name_are_refused() {
-        for path in [
-            "assets/minecraft/optifine/cit/Flame.png",
-            "assets/minecraft/optifine/cit/fire sword.png",
-            "assets/minecraft/textures/item/Stick.png",
-            "assets/minecraft/optifine/cit/a.json",
-            "optifine/cit/a.png",
-        ] {
-            assert_eq!(sprite_id(path), None, "{path}");
-        }
-        assert_eq!(model_id("assets/minecraft/optifine/cit/A.json"), None);
-        assert_eq!(
-            sprite_id("assets//textures/item/x.png"),
-            None,
-            "no namespace"
-        );
-    }
-
-    #[test]
-    fn the_reserved_namespace_names_only_files_inside_the_root() {
-        // A pack's own `horizon_cit` namespace would map back to another file.
-        assert_eq!(sprite_id("assets/horizon_cit/textures/item/x.png"), None);
-        // A model may write any id: only ones inside the root name a file.
-        for id in [
-            "horizon_cit:../../etc/x",
-            "horizon_cit:a/../../x",
-            "horizon_cit:a\\..\\x",
-        ] {
-            assert_eq!(resource(id, "png"), None, "{id}");
-            // Nor does the texture's file: refused, not read from elsewhere.
-            let file = texture_path(Path::new("/r"), id, "textures");
-            assert!(file.starts_with("/r/assets") && !file.to_string_lossy().contains(".."));
-        }
-        let escape = texture_path(Path::new("/r"), "minecraft:../../../x", "textures");
-        assert!(!escape.to_string_lossy().contains(".."), "{escape:?}");
-    }
-
-    #[test]
-    fn both_id_forms_find_their_file() {
-        let root = Path::new("/r");
-        assert_eq!(
-            texture_path(root, "horizon_cit:minecraft/optifine/cit/a", "textures"),
-            root.join("assets/minecraft/optifine/cit/a.png")
-        );
-        assert_eq!(
-            texture_path(root, "minecraft:item/stick", "textures"),
-            root.join("assets/minecraft/textures/item/stick.png")
-        );
-    }
-
-    #[test]
-    fn rule_models_load_with_their_relative_textures_and_parents() {
-        let root = std::env::temp_dir().join(format!("horizon-cit-models-{}", std::process::id()));
-        let cit = root.join("assets/minecraft/optifine/cit");
-        fs::create_dir_all(cit.join("swords")).unwrap();
-        let write = |rel: &str, text: &str| fs::write(cit.join(rel), text).unwrap();
-        write(
-            "swords/flame.json",
-            r#"{"parent":"./../base","textures":{"layer0":"./flame","layer1":"item/stick"}}"#,
-        );
-        write(
-            "base.json",
-            r#"{"parent":"item/handheld","textures":{"layer2":"./glow.png"}}"#,
-        );
-        let props =
-            horizon_optifine::Properties::parse_equals_first("items=stick\nmodel=./swords/flame");
-        let rule = Rule::parse("assets/minecraft/optifine/cit/a.properties", &props, |p| {
-            root.join(p).is_file()
-        })
-        .unwrap();
-        let models = load_models(&root, &[rule]);
-        let _ = fs::remove_dir_all(&root);
-        let cit = |p: &str| format!("horizon_cit:minecraft/optifine/cit/{p}");
-        assert_eq!(
-            models.keys().cloned().collect::<Vec<_>>(),
-            [cit("base"), cit("swords/flame")]
-        );
-        let flame = &models[&cit("swords/flame")];
-        assert_eq!(flame.parent.as_deref(), Some(cit("base").as_str()));
-        assert_eq!(
-            models[&cit("base")].parent.as_deref(),
-            Some("minecraft:item/handheld")
-        );
-        assert_eq!(
-            model_sprites(&models).into_iter().collect::<Vec<_>>(),
-            [cit("glow"), cit("swords/flame")]
-        );
-    }
-
-    #[test]
-    fn relative_values_stay_in_the_root() {
-        let file = "assets/minecraft/optifine/cit/a/m.json";
-        let at = |v: &str| relative(file, v, "png");
-        assert_eq!(
-            at("./x").as_deref(),
-            Some("assets/minecraft/optifine/cit/a/x.png")
-        );
-        assert_eq!(
-            at("./../x.png").as_deref(),
-            Some("assets/minecraft/optifine/cit/x.png")
-        );
-        assert_eq!(
-            at("../../x").as_deref(),
-            Some("assets/minecraft/optifine/x.png")
-        );
-        assert_eq!(at("item/x"), None);
-        assert_eq!(at("./../../../../../x"), None);
-        assert_eq!(at("./a/../x"), None);
-    }
-}

crates/horizon-client-render/src/cit_glint.rs

@@ -1,386 +0,0 @@
-//! Custom Item Textures' enchantment glints (`type=enchantment`): which of a stack's matching
-//! rules draw, in which order and how strongly, and whether vanilla's glint still draws under
-//! them. The pack's `cit.properties` (`Global`) says how layers share an item.
-//!
-//! Written from OptiFine's `cit.properties` doc and CIT Resewn's (MIT) `TypeEnchantment` of
-//! before its 1.21.11 port, which implemented `method`, `cap` and `fade`: the sums and the
-//! cycle's fading follow it, except where noted.
-
-pub use horizon_optifine::cit::{Global, Method};
-
-use crate::cit::read_properties;
-use horizon_optifine::cit::Rule;
-use std::path::Path;
-
-/// The pack's global `cit.properties` under the overlay resource root: the first of
-/// `Global::PATHS` that exists, else the defaults.
-pub fn load_global(root: &Path) -> Global {
-    Global::PATHS
-        .iter()
-        .find_map(|path| read_properties(&root.join(path)))
-        .map(|props| Global::parse(&props))
-        .unwrap_or_default()
-}
-
-/// One glint layer a stack draws.
-#[derive(Clone, Copy, Debug, PartialEq)]
-pub struct GlintLayer {
-    /// The rule, an index into `CitRules::rules`.
-    pub rule: usize,
-    /// Its `average` or `layered` share, 1 under `none` and `cycle`.
-    pub weight: f32,
-    /// Its `duration`, for `cycle`.
-    duration: f32,
-}
-
-/// What a stack's glint is made of, worked out when the stack changes.
-#[derive(Clone, Debug, Default, PartialEq)]
-pub struct StackGlint {
-    /// Bottom first (`layer` ascending).
-    pub layers: Vec<GlintLayer>,
-    /// Whether vanilla's glint draws (on a stack that has one) under the layers.
-    pub vanilla: bool,
-    /// `fade` when the layers take turns (`method=cycle`).
-    cycle_fade: Option<f32>,
-}
-
-impl StackGlint {
-    /// The layers among `matched` (the stack's matching enchantment rules, in priority order,
-    /// as `CitRules::enchantments` gives them) that draw, for a stack with `enchantments`
-    /// (`ItemStack::crafting_enchantments`).
-    pub fn new(
-        rules: &[Rule],
-        matched: &[usize],
-        enchantments: &[(impl AsRef<str>, u32)],
-        global: &Global,
-    ) -> Self {
-        // The highest priority rule of each layer.
-        let mut layers: Vec<usize> = Vec::new();
-        for &i in matched {
-            let layer = rules[i].glint.layer;
-            if !layers.iter().any(|&j| rules[j].glint.layer == layer) {
-                layers.push(i);
-            }
-        }
-        layers.sort_by_key(|&i| rules[i].glint.layer);
-        let cycle = global.method == Method::Cycle;
-        // OptiFine's doc: `cap` is for `average` and `layered`, and keeps the topmost layers.
-        // `none`, which OptiFine lacks, is capped too, as CIT Resewn caps every method (it keeps
-        // the bottom layers, though, and caps cycles as well).
-        if let Some(cap) = global.cap.filter(|_| !cycle) {
-            let cap = usize::try_from(cap).unwrap_or(usize::MAX);
-            layers = layers.split_off(layers.len().saturating_sub(cap));
-        }
-        // CIT Resewn: any layer left asking for vanilla's glint keeps it, and the global
-        // `useGlint=false` removes it everywhere, as OptiFine's doc says too. `cap=0` leaves no
-        // custom layer, and vanilla's glint only if the pack's `useGlint` allows it.
-        let vanilla = global.use_glint
-            && (layers.is_empty() || layers.iter().any(|&i| rules[i].glint.use_glint));
-        // CIT Resewn: shares are against every enchantment of the stack, not only those the
-        // layers name.
-        let levels = enchantments.iter().map(|(_, level)| *level as f32);
-        let total = match global.method {
-            Method::Average => levels.sum::<f32>(),
-            Method::Layered => levels.fold(0.0, f32::max),
-            Method::None | Method::Cycle => 0.0,
-        };
-        let shared = matches!(global.method, Method::Average | Method::Layered);
-        let layers = layers
-            .into_iter()
-            .map(|i| {
-                let rule = &rules[i];
-                let named = &rule.enchantments;
-                let weight = if !shared || named.is_empty() {
-                    1.0
-                } else {
-                    // The highest level among the enchantments the rule names whose level also
-                    // passes its `enchantmentLevels` (CIT Resewn takes the first named one the
-                    // stack has, whatever its level).
-                    let in_range = |level: u32| {
-                        let level = i32::try_from(level).unwrap_or(i32::MAX);
-                        rule.enchantment_levels
-                            .as_ref()
-                            .is_none_or(|r| r.contains(level))
-                    };
-                    let level = enchantments
-                        .iter()
-                        .filter(|(id, level)| {
-                            let id: &str = id.as_ref();
-                            named.iter().any(|n| n == id) && in_range(*level)
-                        })
-                        .map(|(_, level)| *level as f32)
-                        .fold(0.0, f32::max);
-                    if total > 0.0 { level / total } else { 0.0 }
-                };
-                GlintLayer {
-                    rule: i,
-                    weight,
-                    duration: rule.glint.duration,
-                }
-            })
-            .collect();
-        Self {
-            layers,
-            vanilla,
-            cycle_fade: cycle.then_some(global.fade),
-        }
-    }
-
-    pub fn is_empty(&self) -> bool {
-        self.layers.is_empty()
-    }
-
-    /// Layer `index`'s intensity `seconds` into the game: its weight, and under `method=cycle`
-    /// its turn.
-    pub fn intensity(&self, index: usize, seconds: f64) -> f32 {
-        let layer = self.layers[index];
-        match self.cycle_fade {
-            None => layer.weight,
-            Some(fade) => cycle_intensity(&self.layers, fade, index, seconds),
-        }
-    }
-}
-
-/// CIT Resewn's `Loops.statelessFadingLoop`: each layer shows alone for its `duration`, then
-/// fades into the next over `fade` seconds, the last into the first. With no time at all
-/// (every `duration` and `fade` 0) the bottom layer shows alone.
-fn cycle_intensity(layers: &[GlintLayer], fade: f32, index: usize, seconds: f64) -> f32 {
-    let n = layers.len();
-    let fade = f64::from(fade);
-    let period: f64 = layers.iter().map(|l| f64::from(l.duration) + fade).sum();
-    if n == 1 || period <= 0.0 {
-        return if index == 0 { 1.0 } else { 0.0 };
-    }
-    let mut t = seconds.rem_euclid(period);
-    for (i, layer) in layers.iter().enumerate() {
-        let duration = f64::from(layer.duration);
-        if t < duration {
-            return if i == index { 1.0 } else { 0.0 };
-        }
-        t -= duration;
-        // Defensive: the last fade also takes anything rounding might leave of the period
-        // (none seen), ending fully on the first layer.
-        if t < fade || i + 1 == n {
-            let into = if fade > 0.0 {
-                (t / fade).min(1.0) as f32
-            } else {
-                1.0
-            };
-            return if i == index {
-                1.0 - into
-            } else if (i + 1) % n == index {
-                into
-            } else {
-                0.0
-            };
-        }
-        t -= fade;
-    }
-    // Not reached, as the last layer returns above; no layer rather than a panic.
-    0.0
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use horizon_optifine::Properties;
-
-    const DIR: &str = "assets/minecraft/optifine/cit";
-
-    /// An enchantment rule named `name` with `text` after `type` and `texture`.
-    fn rule(name: &str, text: &str) -> Rule {
-        let text = format!("type=enchantment\ntexture=glint\n{text}");
-        let path = format!("{DIR}/{name}.properties");
-        Rule::parse(&path, &Properties::parse_equals_first(&text), |_| true).unwrap()
-    }
-
-    fn global(text: &str) -> Global {
-        Global::parse(&Properties::parse_equals_first(text))
-    }
-
-    fn rules_of(layers: &StackGlint) -> Vec<usize> {
-        layers.layers.iter().map(|l| l.rule).collect()
-    }
-
-    const SWORD: [(&str, u32); 2] = [("minecraft:sharpness", 3), ("minecraft:unbreaking", 1)];
-
-    #[test]
-    fn one_rule_per_layer_bottom_first() {
-        let rules = [
-            rule("a", "layer=2"),
-            rule("b", "layer=0"),
-            rule("c", "layer=2"),
-            rule("d", "layer=-1"),
-        ];
-        // Priority order a, b, c, d: c loses layer 2 to a.
-        let g = StackGlint::new(&rules, &[0, 1, 2, 3], &SWORD, &Global::default());
-        assert_eq!(rules_of(&g), [3, 1, 0]);
-        let g = StackGlint::new(&rules, &[2, 0], &SWORD, &Global::default());
-        assert_eq!(rules_of(&g), [2]);
-    }
-
-    #[test]
-    fn average_and_layered_shares() {
-        let rules = [
-            rule("sharp", "enchantments=sharpness smite"),
-            rule("unb", "layer=1\nenchantments=unbreaking"),
-            rule("any", "layer=2"),
-            rule("fire", "layer=3\nenchantments=fire_aspect"),
-        ];
-        let weights = |method: &str| {
-            let g = StackGlint::new(&rules, &[0, 1, 2, 3], &SWORD, &global(method));
-            g.layers.iter().map(|l| l.weight).collect::<Vec<_>>()
-        };
-        // Sharpness III and Unbreaking I: 3 / 4 and 1 / 4; against the highest, 3 / 3 and 1 / 3.
-        // A rule naming no enchantment is at full strength, one the stack lacks at none.
-        assert_eq!(weights("method=average"), [0.75, 0.25, 1.0, 0.0]);
-        assert_eq!(weights("method=layered"), [1.0, 1.0 / 3.0, 1.0, 0.0]);
-        assert_eq!(weights("method=cycle"), [1.0; 4]);
-        assert_eq!(weights("method=none"), [1.0; 4]);
-    }
-
-    #[test]
-    fn the_level_is_one_the_rules_levels_allow() {
-        let rules = [rule(
-            "holy",
-            "enchantments=sharpness smite\nenchantmentLevels=1-2",
-        )];
-        // Sharpness V is out of range, so Smite I sets the share: 1 / 5 of the highest level.
-        let stack = [("minecraft:sharpness", 5), ("minecraft:smite", 1)];
-        let g = StackGlint::new(&rules, &[0], &stack, &global("method=layered"));
-        assert_eq!(g.layers[0].weight, 1.0 / 5.0);
-    }
-
-    #[test]
-    fn cap_keeps_the_topmost_layers() {
-        let rules = [
-            rule("a", "layer=0"),
-            rule("b", "layer=1"),
-            rule("c", "layer=2"),
-        ];
-        let g = StackGlint::new(&rules, &[0, 1, 2], &SWORD, &global("cap=2"));
-        assert_eq!(rules_of(&g), [1, 2]);
-        let g = StackGlint::new(&rules, &[0, 1, 2], &SWORD, &global("cap=0"));
-        assert!(g.is_empty());
-        let g = StackGlint::new(&rules, &[0, 1, 2], &SWORD, &global("cap=1\nmethod=none"));
-        assert_eq!(rules_of(&g), [2]);
-        // Cycles show every layer in turn.
-        let g = StackGlint::new(&rules, &[0, 1, 2], &SWORD, &global("cap=1\nmethod=cycle"));
-        assert_eq!(rules_of(&g), [0, 1, 2]);
-    }
-
-    #[test]
-    fn vanilla_glint() {
-        let plain = rule("plain", "");
-        let keep = rule("keep", "layer=1\nuseGlint=true");
-        let rules = [plain, keep];
-        let vanilla = |matched: &[usize], text: &str| {
-            StackGlint::new(&rules, matched, &SWORD, &global(text)).vanilla
-        };
-        assert!(vanilla(&[], ""), "no rule: vanilla's glint");
-        assert!(!vanilla(&[0], ""), "a rule replaces it");
-        assert!(vanilla(&[0, 1], ""), "unless one keeps it");
-        assert!(!vanilla(&[], "useGlint=false"));
-        assert!(!vanilla(&[1], "useGlint=false"), "the pack's word is final");
-        // Only the layers `cap` keeps count.
-        let rules = [rule("keep", "useGlint=true"), rule("top", "layer=1")];
-        let g = StackGlint::new(&rules, &[0, 1], &SWORD, &global("cap=1"));
-        assert!(!g.vanilla);
-        let g = StackGlint::new(&rules, &[0, 1], &SWORD, &global("cap=0"));
-        assert!(g.is_empty() && g.vanilla);
-        let g = StackGlint::new(&rules, &[0, 1], &SWORD, &global("cap=0\nuseGlint=false"));
-        assert!(!g.vanilla);
-    }
-
-    #[test]
-    fn cycles_take_turns_and_fade() {
-        let rules = [
-            rule("a", "duration=2"),
-            rule("b", "layer=1\nduration=1"),
-            rule("c", "layer=2\nduration=1"),
-        ];
-        let g = StackGlint::new(
-            &rules,
-            &[0, 1, 2],
-            &SWORD,
-            &global("method=cycle\nfade=0.5"),
-        );
-        // a 0-2, a→b 2-2.5, b 2.5-3.5, b→c 3.5-4, c 4-5, c→a 5-5.5, then again.
-        let at = |t: f64| [0, 1, 2].map(|i| g.intensity(i, t));
-        assert_eq!(at(1.0), [1.0, 0.0, 0.0]);
-        assert_eq!(at(2.125), [0.75, 0.25, 0.0]);
-        assert_eq!(at(3.0), [0.0, 1.0, 0.0]);
-        assert_eq!(at(3.75), [0.0, 0.5, 0.5]);
-        assert_eq!(at(4.5), [0.0, 0.0, 1.0]);
-        assert_eq!(at(5.25), [0.5, 0.0, 0.5]);
-        assert_eq!(at(5.5 + 3.0), [0.0, 1.0, 0.0]);
-        // One layer always shows.
-        let one = StackGlint::new(&rules, &[1], &SWORD, &global("method=cycle"));
-        assert_eq!(one.intensity(0, 0.7), 1.0);
-    }
-
-    #[test]
-    fn a_cycle_always_shows_a_whole_layer() {
-        let rules = [
-            rule("a", "duration=0.1"),
-            rule("b", "layer=1\nduration=0.7"),
-            rule("c", "layer=2\nduration=0.2"),
-        ];
-        let g = StackGlint::new(
-            &rules,
-            &[0, 1, 2],
-            &SWORD,
-            &global("method=cycle\nfade=0.3"),
-        );
-        // Every millisecond of the first two seconds, and just under a period, the last fade's
-        // end. (Rounding has not been seen to leave time past it; the last fade's clamp is
-        // defensive.)
-        let period: f64 = [0.1f32, 0.7, 0.2]
-            .map(|d| f64::from(d) + f64::from(0.3f32))
-            .iter()
-            .sum();
-        let last = f64::from_bits(period.to_bits() - 1);
-        for t in (0..2000_i32)
-            .map(|i| f64::from(i) * 0.001)
-            .chain([last, period + last])
-        {
-            let sum: f32 = (0..3).map(|i| g.intensity(i, t)).sum();
-            assert!((sum - 1.0).abs() < 1e-5, "{sum} at {t}");
-        }
-        // No time at all: the bottom layer alone, never NaN.
-        let still = [rule("a", "duration=0"), rule("b", "layer=1\nduration=0")];
-        let g = StackGlint::new(&still, &[0, 1], &SWORD, &global("method=cycle\nfade=0"));
-        for t in [0.0, 0.5, 7.25] {
-            assert_eq!([0, 1].map(|i| g.intensity(i, t)), [1.0, 0.0]);
-        }
-    }
-
-    #[test]
-    fn the_first_global_file_wins() {
-        let root = std::env::temp_dir().join(format!("horizon-cit-glint-{}", std::process::id()));
-        let _ = std::fs::remove_dir_all(&root);
-        assert_eq!(load_global(&root), Global::default());
-        let write = |path: &str, text: &[u8]| {
-            let file = root.join(path);
-            std::fs::create_dir_all(file.parent().unwrap()).unwrap();
-            std::fs::write(file, text).unwrap();
-        };
-        // Saved as Latin-1 (`é` is not UTF-8 alone), in the OptiFine doc's `cit/` folder.
-        write(
-            "assets/minecraft/optifine/cit/cit.properties",
-            b"# caf\xE9\nmethod=cycle",
-        );
-        assert_eq!(load_global(&root).method, Method::Cycle);
-        write("assets/minecraft/mcpatcher/cit.properties", b"method=none");
-        assert_eq!(load_global(&root).method, Method::Cycle);
-        write(
-            "assets/minecraft/optifine/cit.properties",
-            b"method=layered",
-        );
-        assert_eq!(load_global(&root).method, Method::Layered);
-        write("assets/minecraft/citresewn/cit.properties", b"cap=1");
-        let g = load_global(&root);
-        let _ = std::fs::remove_dir_all(&root);
-        assert_eq!((g.method, g.cap), (Method::Average, Some(1)));
-    }
-}

crates/horizon-client-render/src/clouds.rs

@@ -1,15 +1,7 @@
 //! Cloud visibility and flat/fancy cell geometry (`CloudRenderer`).
-/// `EnvironmentAttributes.CLOUD_HEIGHT`'s default, and the overworld's `visual/cloud_height`.
-pub const CLOUD_HEIGHT: f64 = 192.33;
-
-/// Whether the cloud color has any packed alpha (vanilla gates the clouds on it).
-pub fn has_color(alpha: f32) -> bool {
-    (alpha.clamp(0.0, 1.0) * 255.0) as u8 > 0
-}
-
 /// `LevelRenderer`: skip OFF clouds and colors with no packed alpha.
 pub fn visible(mode: &str, alpha: f32) -> bool {
-    mode != "false" && has_color(alpha)
+    mode != "false" && (alpha.clamp(0.0, 1.0) * 255.0) as u8 > 0
 }
 
 /// `buildFlatCell`: bottom plane, in both windings for the culled cloud pipeline.
@@ -118,7 +110,7 @@ impl Input<'_> {
         z -= (z / th).floor() * th;
         let cell_x = (x / 12.0).floor() as i64;
         let cell_z = (z / 12.0).floor() as i64;
-        let bottom = (CLOUD_HEIGHT - self.camera.y) as f32;
+        let bottom = (192.33 - self.camera.y) as f32;
         let key = MeshKey {
             cell_x,
             cell_z,
@@ -177,13 +169,11 @@ impl Mesh {
             let x0 = dx as f32 * 12.0;
             let z0 = dz as f32 * 12.0;
             let (x1, z1, y0, y1) = (x0 + 12.0, z0 + 12.0, 0.0, 4.0);
-            // The face's normal is for shader packs (`gl_Normal`); the game's clouds shade by
-            // `shade`.
-            let mut quad = |p: [[f32; 3]; 4], shade: u32, normal: [i8; 4]| {
+            let mut quad = |p: [[f32; 3]; 4], shade: u32| {
                 for v in p {
                     // Overlay 4: clouds (unlit, faded by the cloud fog end).
                     self.vertices.push(crate::mesher::Vertex {
-                        normal,
+                        normal: [0; 4],
                         pos: v,
                         uv,
                         layer: 4,
@@ -196,41 +186,17 @@ impl Mesh {
             };
             if input.fast {
                 for p in flat_cell(x0, z0, 0.0) {
-                    quad(p, 0, [0; 4]);
+                    quad(p, 0);
                 }
                 continue;
             }
             let quads = [
-                (
-                    [[x1, y0, z0], [x1, y0, z1], [x0, y0, z1], [x0, y0, z0]],
-                    1,
-                    [0, -127, 0, 0],
-                ),
-                (
-                    [[x0, y1, z0], [x0, y1, z1], [x1, y1, z1], [x1, y1, z0]],
-                    0,
-                    [0, 127, 0, 0],
-                ),
-                (
-                    [[x0, y0, z0], [x0, y1, z0], [x1, y1, z0], [x1, y0, z0]],
-                    2,
-                    [0, 0, -127, 0],
-                ),
-                (
-                    [[x1, y0, z1], [x1, y1, z1], [x0, y1, z1], [x0, y0, z1]],
-                    2,
-                    [0, 0, 127, 0],
-                ),
-                (
-                    [[x0, y0, z1], [x0, y1, z1], [x0, y1, z0], [x0, y0, z0]],
-                    3,
-                    [-127, 0, 0, 0],
-                ),
-                (
-                    [[x1, y0, z0], [x1, y1, z0], [x1, y1, z1], [x1, y0, z1]],
-                    3,
-                    [127, 0, 0, 0],
-                ),
+                ([[x1, y0, z0], [x1, y0, z1], [x0, y0, z1], [x0, y0, z0]], 1),
+                ([[x0, y1, z0], [x0, y1, z1], [x1, y1, z1], [x1, y1, z0]], 0),
+                ([[x0, y0, z0], [x0, y1, z0], [x1, y1, z0], [x1, y0, z0]], 2),
+                ([[x1, y0, z1], [x1, y1, z1], [x0, y1, z1], [x0, y0, z1]], 2),
+                ([[x0, y0, z1], [x0, y1, z1], [x0, y1, z0], [x0, y0, z0]], 3),
+                ([[x1, y0, z0], [x1, y1, z0], [x1, y1, z1], [x1, y0, z1]], 3),
             ];
             let mask = face_mask(
                 dx as i32,
@@ -244,12 +210,8 @@ impl Mesh {
                 ],
             );
             for (direction, inside) in faces(mask) {
-                let (p, shade, n) = quads[usize::from(direction)];
-                if inside {
-                    quad([p[3], p[2], p[1], p[0]], shade, n.map(|c| -c));
-                } else {
-                    quad(p, shade, n);
-                }
+                let (p, shade) = quads[usize::from(direction)];
+                quad(if inside { [p[3], p[2], p[1], p[0]] } else { p }, shade);
             }
         }
         self.key = Some(key);

crates/horizon-client-render/src/collisions.rs

@@ -199,9 +199,8 @@ where
 }
 impl SceneCollisions<'_, '_> {
     /// Position contexts permit geometric movement probes without inventing a
-    /// player, inventory, effects or fluid-standing behavior; a lava walker or
-    /// a living entity in leather boots collides as the living entity it is,
-    /// empty-handed.
+    /// player, inventory, effects or fluid-standing behavior; a lava walker
+    /// collides as the living entity it is, empty-handed.
     pub fn resolve(
         &mut self,
         bounds: Aabb,
@@ -237,10 +236,7 @@ impl SceneCollisions<'_, '_> {
     }
     fn context(&self, bounds: Aabb) -> CollisionContext<'static> {
         let y = bounds.min_position().y;
-        if !self
-            .subject
-            .is_some_and(|s| s.lava_walker || s.leather_boots)
-        {
+        if !self.subject.is_some_and(|s| s.lava_walker) {
             return CollisionContext::position(y);
         }
         CollisionContext::for_entity(
@@ -309,7 +305,7 @@ impl<'w> BlockCollisionWorld for SceneCollisions<'w, '_> {
     /// From the section's palette, without reading its blocks; a palette
     /// of the whole registry reads every cell.
     fn may_reach_out(&mut self, chunk: Self::Chunk, section_y: i32) -> io::Result<bool> {
-        let blocks = usize::try_from(section_y - (chunk.min_y() >> 4))
+        let blocks = usize::try_from(section_y - (crate::chunk::MIN_Y >> 4))
             .ok()
             .and_then(|s| chunk.sections.get(s))
             .map(|section| &section.blocks);
@@ -347,15 +343,8 @@ impl EntityMovementWorld for SceneCollisions<'_, '_> {
 }
 impl DynamicSupportWorld for SceneCollisions<'_, '_> {
     type Error = io::Error;
-    /// `ShulkerBoxBlockEntity.isClosed`: whether the lid is still shut. A
-    /// closed box collides as its plain block (`ShulkerBoxBlock.getShape`
-    /// asks the block entity, which has grown once the lid starts to open).
-    fn shulker_is_closed(&mut self, p: [i32; 3]) -> io::Result<Option<bool>> {
-        Ok(self
-            .world
-            .shulkers
-            .get(&p)
-            .map(|s| s.status == crate::block_entity_anim::ShulkerStatus::Closed))
+    fn shulker_is_closed(&mut self, _: [i32; 3]) -> io::Result<Option<bool>> {
+        Ok(None)
     }
     /// `MovingPistonBlock.getCollisionShape`: the block entity's moving shape
     /// (`PistonMovingBlockEntity.getCollisionShape`), outside any push.
@@ -384,17 +373,11 @@ impl PistonCollisionWorld for SceneCollisions<'_, '_> {
     }
 }
 impl DynamicCollisionWorld for SceneCollisions<'_, '_> {
-    /// `ShulkerBoxBlockEntity.getBoundingBox`: the box's collision shape
-    /// (`getShape`) is the free shape grown by the lid's progress, which is
-    /// what lets an entity sink into an opening box. None: no such box here.
     fn shulker_collision_state(
         &mut self,
-        p: [i32; 3],
+        _: [i32; 3],
     ) -> io::Result<Option<ShulkerCollisionState>> {
-        Ok(self.world.shulkers.get(&p).map(|s| ShulkerCollisionState {
-            previous_progress: s.progress_old,
-            progress: s.progress,
-        }))
+        Ok(None)
     }
 }
 impl LiquidCollisionWorld for SceneCollisions<'_, '_> {
@@ -514,8 +497,6 @@ impl EntityMovementWorld for LookupCollisions<'_, '_> {
 }
 impl DynamicSupportWorld for LookupCollisions<'_, '_> {
     type Error = io::Error;
-    /// No block-entity data: a lookup world has no shulker box to ask, so the
-    /// box collides as a shut one (`VoxelShape::block()`).
     fn shulker_is_closed(&mut self, _: [i32; 3]) -> io::Result<Option<bool>> {
         Ok(None)
     }
@@ -524,8 +505,6 @@ impl DynamicSupportWorld for LookupCollisions<'_, '_> {
     }
 }
 impl DynamicCollisionWorld for LookupCollisions<'_, '_> {
-    /// No block-entity data: the block table's own shape stands in for the lid
-    /// (`ShulkerBoxBlockEntity.getBoundingBox` needs a block entity).
     fn shulker_collision_state(
         &mut self,
         _: [i32; 3],
@@ -632,140 +611,3 @@ mod border_movement_tests {
         );
     }
 }
-
-#[cfg(test)]
-mod shulker_collision_tests {
-    use super::*;
-    use crate::block_entity_anim::{Shulker, ShulkerStatus, progress_delta_aabb};
-    use horizon_core::geometry::{Aabb, Axis, Direction, Vec3, VoxelShape};
-
-    /// A shulker box facing up at progress 0.0 (closed): collision is a 1x1x1 block.
-    #[test]
-    fn shulker_closed_collision_is_full_block() {
-        let shulker = Shulker {
-            status: ShulkerStatus::Closed,
-            progress: 0.0,
-            progress_old: 0.0,
-            ..Shulker::default()
-        };
-
-        let state = ShulkerCollisionState {
-            previous_progress: shulker.progress_old,
-            progress: shulker.progress,
-        };
-        let aabb = state.bounding_box(Direction::Up);
-
-        // Closed box: height 1.0
-        assert!((aabb.min(Axis::Y) - 0.0).abs() < 1.0e-9);
-        assert!((aabb.max(Axis::Y) - 1.0).abs() < 1.0e-9);
-        // Full horizontal extent
-        assert!((aabb.min(Axis::X) - 0.0).abs() < 1.0e-9);
-        assert!((aabb.max(Axis::X) - 1.0).abs() < 1.0e-9);
-    }
-
-    /// A shulker box facing up at progress 1.0 (fully open): collision is 1.5 tall.
-    #[test]
-    fn shulker_open_collision_grows_upward() {
-        let shulker = Shulker {
-            status: ShulkerStatus::Opened,
-            progress: 1.0,
-            progress_old: 1.0,
-            ..Shulker::default()
-        };
-
-        let state = ShulkerCollisionState {
-            previous_progress: shulker.progress_old,
-            progress: shulker.progress,
-        };
-        let aabb = state.bounding_box(Direction::Up);
-
-        // Fully open: height 1.5 (lid extends 0.5 above the block)
-        assert!((aabb.min(Axis::Y) - 0.0).abs() < 1.0e-9);
-        assert!((aabb.max(Axis::Y) - 1.5).abs() < 1.0e-9);
-    }
-
-    /// A shulker box halfway open: collision height is 1.25.
-    #[test]
-    fn shulker_half_open_collision_height() {
-        let shulker = Shulker {
-            status: ShulkerStatus::Opening,
-            progress: 0.5,
-            progress_old: 0.5,
-            ..Shulker::default()
-        };
-
-        let state = ShulkerCollisionState {
-            previous_progress: shulker.progress_old,
-            progress: shulker.progress,
-        };
-        let aabb = state.bounding_box(Direction::Up);
-
-        // Half open: height 1.25
-        assert!((aabb.min(Axis::Y) - 0.0).abs() < 1.0e-9);
-        assert!((aabb.max(Axis::Y) - 1.25).abs() < 1.0e-9);
-    }
-
-    /// Vanilla clip quirk: an entity whose feet are *inside* the grown lid box
-    /// moving DOWN is not stopped by the box (collision only triggers when
-    /// approaching from outside). An entity ABOVE the box moving DOWN is stopped.
-    #[test]
-    fn shulker_grown_box_allows_clip_when_inside() {
-        // Box at progress 1.0: spans y=0..1.5
-        let shulker = Shulker {
-            status: ShulkerStatus::Opened,
-            progress: 1.0,
-            progress_old: 1.0,
-            ..Shulker::default()
-        };
-        let state = ShulkerCollisionState {
-            previous_progress: shulker.progress_old,
-            progress: shulker.progress,
-        };
-        let aabb = state.bounding_box(Direction::Up);
-        let box_shape = VoxelShape::from_box(aabb).expect("shulker box is a valid shape");
-
-        // Entity box whose feet are at y=0.5 (inside the grown box), height 1.8
-        let entity = Aabb::new(Vec3::new(0.2, 0.5, 0.2), Vec3::new(0.8, 2.3, 0.8));
-
-        // Moving DOWN from inside the box: collide() should NOT stop it
-        // (the entity is already intersecting the box, so the downward movement
-        // sees no face to hit from above).
-        let down = -0.1;
-        let moved_down = box_shape.collide(Axis::Y, entity, down);
-        assert!(
-            (moved_down - down).abs() < 1.0e-9,
-            "entity inside grown box should fall through (clip): moved_down={moved_down}, expected={down}"
-        );
-
-        // Entity box whose feet are at y=1.6 (just ABOVE the grown box)
-        let entity_above = Aabb::new(Vec3::new(0.2, 1.6, 0.2), Vec3::new(0.8, 3.4, 0.8));
-
-        // Moving DOWN from above: collide() SHOULD stop it at y=1.5
-        let moved_down_above = box_shape.collide(Axis::Y, entity_above, -0.2);
-        // The box's top is at y=1.5, entity bottom at 1.6, so max down is -0.1
-        assert!(
-            (moved_down_above - (-0.1)).abs() < 1.0e-9,
-            "entity above grown box should be stopped: moved_down_above={moved_down_above}, expected=-0.1"
-        );
-    }
-
-    /// An entity standing on the lid (y=1.0 when closed, y=1.5 when open)
-    /// and pushed up by the lid: the lid's swept AABB pushes it along the facing.
-    /// This is tested at the integration level via `push_shulker_entities`;
-    /// here we only verify the swept box geometry matches vanilla's
-    /// `Shulker.getProgressDeltaAabb`.
-    #[test]
-    fn shulker_swept_box_matches_vanilla_delta() {
-        // From closed (0.0) to progress 0.5: the lid sweeps from y=0..1 (closed box)
-        // to y=0..1.5 (half open), so the swept volume in world coords at position
-        // [0.5, 0.0, 0.5] (bottom center of block at y=0) is y=1.0..1.5.
-        let delta = progress_delta_aabb(1.0, Direction::Up as u8, 0.0, 0.5, [0.5, 0.0, 0.5]);
-        assert!((delta[1] - 1.0).abs() < 1.0e-9); // minY
-        assert!((delta[4] - 1.5).abs() < 1.0e-9); // maxY
-
-        // From progress 0.5 to 1.0: swept y=1.5..2.0 in world coords
-        let delta2 = progress_delta_aabb(1.0, Direction::Up as u8, 0.5, 1.0, [0.5, 0.0, 0.5]);
-        assert!((delta2[1] - 1.5).abs() < 1.0e-9);
-        assert!((delta2[4] - 2.0).abs() < 1.0e-9);
-    }
-}

crates/horizon-client-render/src/containers.rs

@@ -3,66 +3,11 @@
 //! from the data-driven `context_int_provider`/`context_float_provider` files.
 pub use crate::chunk::block_entity::{
     Banner, Beacon, BlockEntity, Brushable, Campfire, ChiseledBookshelf, Crafter, CreakingHeart,
-    EndGateway, Furnace, FurnaceKind, Jukebox, Lectern, MOD_MENUS, ModBlockEntity,
-    ModBlockEntityFields, ModContainer, ModEnergyBuffer, ModFluidTanks, ModRevision, PotentSulfur,
-    Shelf, Skull, SkullSkin,
+    EndGateway, Furnace, FurnaceKind, Jukebox, Lectern, PotentSulfur, Shelf, Skull, SkullSkin,
 };
 use crate::items::ItemStack;
 use std::collections::HashMap;
 
-/// a content mod's menu type (`data/<id>/horizon/menu/`, vanilla's
-/// `MenuType`): its container slots, its data slots (`ContainerData`) and the
-/// slots players only take from.
-#[derive(Clone, Debug, PartialEq, Eq)]
-pub struct ModMenuType {
-    pub id: &'static str,
-    pub slots: usize,
-    pub data_slots: usize,
-    pub results: Vec<usize>,
-}
-
-static MOD_MENU_TYPES: std::sync::OnceLock<Vec<ModMenuType>> = std::sync::OnceLock::new();
-
-/// registers the content mods' menu types, `(id, slots, data slots,
-/// results)`, a list set once per process (false when it already was).
-pub fn register_mod_menu_types(
-    menus: impl IntoIterator<Item = (String, usize, usize, Vec<usize>)>,
-) -> bool {
-    if MOD_MENU_TYPES.get().is_some() {
-        return false;
-    }
-    let menus = menus
-        .into_iter()
-        .map(|(id, slots, data_slots, results)| ModMenuType {
-            id: Box::leak(id.into_boxed_str()),
-            slots,
-            data_slots,
-            results,
-        });
-    MOD_MENU_TYPES.set(menus.collect()).is_ok()
-}
-
-/// the content mods' menu types, in registry order.
-pub fn mod_menu_types() -> &'static [ModMenuType] {
-    MOD_MENU_TYPES.get().map_or(&[], Vec::as_slice)
-}
-
-/// the mod menu type named `id`, kept out of line: a vanilla menu never
-/// looks one up.
-#[cold]
-#[inline(never)]
-pub fn mod_menu_type(id: &str) -> Option<&'static ModMenuType> {
-    mod_menu_types().iter().find(|m| m.id == id)
-}
-
-/// whether a client of `brand` can be sent menu type `menu`: a vanilla
-/// client reads the type through `ByteBufCodecs.registry(Registries.MENU)`,
-/// and an id it lacks (`IdMap.byIdOrThrow`) disconnects it, so it is sent
-/// vanilla's only. A Horizon client has the server's (the content identity).
-pub fn menu_reaches(brand: &str, menu: &str) -> bool {
-    brand == "horizon" || menu.starts_with("minecraft:")
-}
-
 impl FurnaceKind {
     pub fn recipe_type(self) -> &'static str {
         match self {
@@ -136,39 +81,6 @@ pub fn double_chest_name(first: Option<&str>, second: Option<&str>) -> horizon_w
     display_name(first.or(second), "container.chestDouble")
 }
 
-/// `BaseContainerBlockEntity.sendChestLockedNotifications`: the action bar
-/// message of a container that refuses to open, `container.isLocked` naming it
-/// by its display name.
-pub fn locked_message(title: &horizon_world::nbt::Tag) -> horizon_world::nbt::Tag {
-    use horizon_world::nbt::Tag;
-    Tag::compound([
-        ("translate", Tag::String("container.isLocked".into())),
-        ("with", Tag::List(vec![title.clone()])),
-    ])
-}
-
-/// The menu a container vehicle's `createMenu` builds (`ContainerEntity`):
-/// `AbstractChestBoat.createMenu` and `MinecartChest.createMenu` are
-/// `ChestMenu.threeRows` (a 9x3 menu), `MinecartHopper.createMenu` is a
-/// `HopperMenu` (five slots). `None` for any other entity type.
-pub fn vehicle_menu(entity_type: &str) -> Option<(&'static str, usize)> {
-    match entity_type {
-        "minecraft:chest_minecart" => Some(("minecraft:generic_9x3", 27)),
-        "minecraft:hopper_minecart" => Some(("minecraft:hopper", HOPPER_SLOTS)),
-        n if n.ends_with("_chest_boat") || n.ends_with("_chest_raft") => {
-            Some(("minecraft:generic_9x3", 27))
-        }
-        _ => None,
-    }
-}
-
-/// `MenuProvider.getDisplayName` for a container vehicle: `Entity.getDisplayName`
-/// is its custom name, else `getName`, the entity type's name key. Horizon's
-/// vehicles keep no custom name, so this is the type's name key.
-pub fn vehicle_menu_name(entity_type: &str) -> String {
-    format!("entity.{}", entity_type.replacen(':', ".", 1))
-}
-
 impl Campfire {
     /// `placeFood`'s slot: the first empty one, given the item's
     /// `campfire_cooking` time; it takes one item of `held`.
@@ -250,7 +162,6 @@ impl SkullSkin {
         Self {
             download,
             dynamic,
-            texture: crate::skins::profile_texture_nbt(profile),
             fallback,
         }
     }
@@ -395,27 +306,6 @@ impl BlockEntity {
         if name == "minecraft:chiseled_bookshelf" {
             return Some(Self::ChiseledBookshelf(Box::default()));
         }
-        if name == "minecraft:structure_block" {
-            // The entity's mode is the state's (`StructureBlock.MODE`); the block's
-            // state is not known here, so a new one starts in its default, SAVE.
-            return Some(Self::StructureBlock(Box::new(
-                crate::structure_block::StructureBlock::new(
-                    crate::structure_block::StructureMode::Save,
-                ),
-            )));
-        }
-        if name == "minecraft:test_block" {
-            // The mode is the state's, which is not known here.
-            return Some(Self::TestBlock(Box::new(
-                crate::test_block::TestBlock::new(crate::test_block::TestBlockMode::Fail),
-            )));
-        }
-        if name == "minecraft:test_instance_block" {
-            return Some(Self::TestInstanceBlock(Box::default()));
-        }
-        if name == "minecraft:jigsaw" {
-            return Some(Self::JigsawBlock(Box::default()));
-        }
         if name == "minecraft:potent_sulfur" {
             return Some(Self::PotentSulfur(PotentSulfur::default()));
         }
@@ -429,7 +319,7 @@ impl BlockEntity {
         };
         Some(Self::Chest(vec![None; size]))
     }
-    pub fn id(&self) -> &str {
+    pub fn id(&self) -> &'static str {
         match self {
             Self::Chest(items) => match items.len() {
                 HOPPER_SLOTS => "minecraft:hopper",
@@ -462,12 +352,7 @@ impl BlockEntity {
             Self::Campfire(_) => "minecraft:campfire",
             Self::ChiseledBookshelf(_) => "minecraft:chiseled_bookshelf",
             Self::Shelf(_) => "minecraft:shelf",
-            Self::Mod(m) => &m.id,
             Self::PotentSulfur(_) => "minecraft:potent_sulfur",
-            Self::StructureBlock(_) => "minecraft:structure_block",
-            Self::JigsawBlock(_) => "minecraft:jigsaw",
-            Self::TestBlock(_) => "minecraft:test_block",
-            Self::TestInstanceBlock(_) => "minecraft:test_instance_block",
         }
     }
     pub fn contents(&self) -> Vec<ItemStack> {
@@ -476,7 +361,7 @@ impl BlockEntity {
             Self::Furnace(f) => f.items.iter().flatten().cloned().collect(),
             Self::Brewing(b) => b.items.iter().flatten().cloned().collect(),
             Self::Sign(_) => Vec::new(),
-            Self::Jukebox(j) => j.items.iter().flatten().cloned().collect(),
+            Self::Jukebox(j) => j.record.iter().cloned().collect(),
             Self::Beacon(_)
             | Self::CreakingHeart(_)
             | Self::Spawner(_)
@@ -487,13 +372,8 @@ impl BlockEntity {
             | Self::EndGateway(_)
             | Self::Skull(_)
             | Self::PotentSulfur(_)
-            | Self::StructureBlock(_)
-            | Self::JigsawBlock(_)
-            | Self::TestBlock(_)
-            | Self::TestInstanceBlock(_)
             | Self::DaylightDetector
             | Self::Brushable(_) => Vec::new(),
-            Self::Mod(m) => m.items.iter().flatten().cloned().collect(),
             Self::Lectern(l) => l.book.iter().cloned().collect(),
             Self::Sculk(_) => Vec::new(),
             Self::Banner(_) => Vec::new(),
@@ -509,6 +389,7 @@ impl BlockEntity {
             Self::Furnace(f) => &f.items,
             Self::Brewing(b) => &b.items,
             Self::Sign(_)
+            | Self::Jukebox(_)
             | Self::Beacon(_)
             | Self::Lectern(_)
             | Self::Sculk(_)
@@ -516,17 +397,11 @@ impl BlockEntity {
             | Self::EndGateway(_)
             | Self::Skull(_)
             | Self::PotentSulfur(_)
-            | Self::StructureBlock(_)
-            | Self::JigsawBlock(_)
-            | Self::TestBlock(_)
-            | Self::TestInstanceBlock(_)
             | Self::DaylightDetector
             | Self::Brushable(_) => &[],
-            Self::Jukebox(j) => &j.items,
             Self::Crafter(c) => &c.items,
             Self::ChiseledBookshelf(b) => &b.items,
             Self::Shelf(b) => &b.items,
-            Self::Mod(m) => &m.items,
             Self::CreakingHeart(_)
             | Self::Spawner(_)
             | Self::TrialSpawner(_)
@@ -543,6 +418,7 @@ impl BlockEntity {
             Self::Furnace(f) => &mut f.items,
             Self::Brewing(b) => &mut b.items,
             Self::Sign(_)
+            | Self::Jukebox(_)
             | Self::Beacon(_)
             | Self::Lectern(_)
             | Self::Sculk(_)
@@ -550,17 +426,11 @@ impl BlockEntity {
             | Self::EndGateway(_)
             | Self::Skull(_)
             | Self::PotentSulfur(_)
-            | Self::StructureBlock(_)
-            | Self::JigsawBlock(_)
-            | Self::TestBlock(_)
-            | Self::TestInstanceBlock(_)
             | Self::DaylightDetector
             | Self::Brushable(_) => &mut [],
-            Self::Jukebox(j) => &mut j.items,
             Self::Crafter(c) => &mut c.items,
             Self::ChiseledBookshelf(b) => &mut b.items,
             Self::Shelf(b) => &mut b.items,
-            Self::Mod(m) => &mut m.items,
             Self::CreakingHeart(_)
             | Self::Spawner(_)
             | Self::TrialSpawner(_)
@@ -665,15 +535,6 @@ mod tests {
     use super::*;
     use horizon_core::random::{LegacyRandom, RandomSource};
 
-    /// a client that isn't Horizon's is sent vanilla's menu types only.
-    #[test]
-    fn a_mod_menu_type_reaches_horizon_clients_only() {
-        assert!(menu_reaches("horizon", "ruby:press"));
-        assert!(!menu_reaches("vanilla", "ruby:press"));
-        assert!(!menu_reaches("fabric", "ruby:press"));
-        assert!(menu_reaches("vanilla", "minecraft:generic_9x3"));
-    }
-
     #[test]
     fn campfire_slots_take_food_cook_it_and_cool_down() {
         let mut c = Campfire::default();
@@ -709,26 +570,6 @@ mod tests {
         assert_eq!(fifth.count, 1);
     }
 
-    /// `JukeboxBlockEntity`'s single slot is a `Container` slot, so a hopper
-    /// (`HopperBlockEntity.getContainerAt`) can reach the disc in it.
-    #[test]
-    fn a_jukebox_offers_its_record_as_its_one_container_slot() {
-        let mut entity = BlockEntity::Jukebox(Jukebox::default());
-        assert_eq!(entity.slots().len(), 1);
-        assert!(entity.slots()[0].is_none(), "empty until a disc lands");
-        let disc = ItemStack::new("minecraft:cat", 1);
-        entity.slots_mut()[0] = Some(disc.clone());
-        let slots = entity.slots();
-        assert_eq!(slots[0].as_ref().map(|s| &*s.item), Some("minecraft:cat"));
-        match &entity {
-            BlockEntity::Jukebox(j) => {
-                assert_eq!(j.record().map(|s| &*s.item), Some("minecraft:cat"));
-            }
-            _ => panic!("a jukebox"),
-        }
-        assert_eq!(entity.contents().len(), 1);
-    }
-
     /// A whole amount pays itself without a draw; a fraction is a chance of one more.
     #[test]
     fn create_experience_rounds_the_fraction_by_chance() {

crates/horizon-client-render/src/crash.rs

@@ -212,7 +212,7 @@ fn operating_system() -> String {
     } else if cfg!(target_os = "macos") {
         command_output("sw_vers", &["-productVersion"]).map(|v| format!("macOS {v}"))
     } else if cfg!(windows) {
-        horizon_telemetry::system::windows_version()
+        command_output("cmd", &["/C", "ver"])
     } else {
         None
     };
@@ -227,11 +227,14 @@ fn operating_system() -> String {
 pub fn cpu() -> String {
     let threads = std::thread::available_parallelism().map_or(0, |n| n.get());
     let name = if cfg!(target_os = "linux") {
-        read("/proc/cpuinfo").and_then(|t| horizon_telemetry::system::linux_cpu_name(&t))
+        read("/proc/cpuinfo").and_then(|t| {
+            t.lines()
+                .find(|l| l.starts_with("model name"))
+                .and_then(|l| l.split_once(':'))
+                .map(|(_, v)| v.trim().to_owned())
+        })
     } else if cfg!(target_os = "macos") {
         command_output("sysctl", &["-n", "machdep.cpu.brand_string"])
-    } else if cfg!(windows) {
-        horizon_telemetry::system::windows_cpu()
     } else {
         std::env::var("PROCESSOR_IDENTIFIER").ok()
     };
@@ -293,9 +296,8 @@ fn memory() -> String {
     }
 }
 
-/// The report's details: Horizon's and the machine's, then what the game set as it ran. A dedicated
-/// server renders nothing: it leaves out the render settings it read from options.txt.
-pub fn system_details(side: &str) -> Vec<(String, String)> {
+/// The report's details: Horizon's and the machine's, then what the game set as it ran.
+pub fn system_details() -> Vec<(String, String)> {
     let mut out = vec![
         ("Horizon Version".to_owned(), version()),
         (
@@ -306,30 +308,18 @@ pub fn system_details(side: &str) -> Vec<(String, String)> {
         ("CPU".to_owned(), cpu()),
         ("Memory".to_owned(), memory()),
     ];
-    out.extend(
-        details()
-            .into_iter()
-            .filter(|(k, _)| side != "server" || *k != "Render Settings")
-            .map(|(k, v)| (k.to_owned(), v)),
-    );
+    out.extend(details().into_iter().map(|(k, v)| (k.to_owned(), v)));
     out
 }
 
-/// The thread's name as vanilla's reports say it: the main thread is the client's "Render thread"
-/// and the dedicated server's "Server thread".
-fn thread_name(side: &str) -> String {
+fn thread_name() -> String {
     let current = std::thread::current();
     match current.name() {
-        Some("main") | None if side == "server" => "Server thread".into(),
         Some("main") | None => "Render thread".into(),
         Some(name) => name.into(),
     }
 }
 
-/// What starts the stderr line naming a saved report, the path follows: the Launch API's
-/// promise to launchers (docs/api/launch.md), so it never changes within a line of that API.
-pub const SAVED_LINE: &str = "Horizon: crash report saved to ";
-
 /// Writes the report and tells where it is; the log gets the error too.
 fn deliver(home: &Path, report: Report) -> Option<PathBuf> {
     if REPORTED.swap(true, Ordering::SeqCst) {
@@ -351,10 +341,9 @@ fn deliver(home: &Path, report: Report) -> Option<PathBuf> {
     );
     crate::logging::flush();
     crate::telemetry::keep_crash(home, &report);
-    // A player of a shared game folder (`--player-dir`) finds the report beside its own log.
-    match report.save(crate::logging::player_dir_override().unwrap_or(home)) {
+    match report.save(home) {
         Ok(path) => {
-            eprintln!("{SAVED_LINE}{}", path.display());
+            eprintln!("Horizon: crash report saved to {}", path.display());
             Some(path)
         }
         Err(e) => {
@@ -376,38 +365,14 @@ pub fn report_watchdog(home: &Path, side: &'static str, message: String) -> Opti
             description: "Watching Server".into(),
             error: format!("{message} (Watching Server)"),
             stack: String::new(),
-            thread: thread_name(side),
+            thread: thread_name(),
             side,
-            details: system_details(side),
+            details: system_details(),
             log: crate::logging::recent_lines(),
         },
     )
 }
 
-/// The report for a game that went over the player's RAM limit (`ram_limit`), written by the
-/// watcher thread: it says nothing about where the memory went, so it carries no stack. The player
-/// chose this limit, so it is no bug to send (`telemetry::keep_crash`), and leaving that out ends
-/// the game seconds sooner: it keeps running, over its limit, until the report is written.
-pub fn report_memory_limit(home: &Path, side: &'static str, message: String) {
-    if REPORTED.swap(true, Ordering::SeqCst) {
-        return;
-    }
-    let report = Report {
-        time: Local::now(),
-        description: "RAM limit reached".into(),
-        error: message,
-        stack: String::new(),
-        thread: thread_name(side),
-        side,
-        details: system_details(side),
-        log: crate::logging::recent_lines(),
-    };
-    match report.save(home) {
-        Ok(path) => eprintln!("{SAVED_LINE}{}", path.display()),
-        Err(e) => eprintln!("Horizon: could not save a crash report: {e}"),
-    }
-}
-
 fn payload_text(payload: &(dyn std::any::Any + Send)) -> String {
     payload
         .downcast_ref::<&str>()
@@ -511,31 +476,15 @@ pub fn panic_report(info: &std::panic::PanicHookInfo, side: &'static str) -> Rep
             &std::backtrace::Backtrace::force_capture().to_string(),
             true,
         ),
-        thread: thread_name(side),
+        thread: thread_name(),
         side,
-        details: system_details(side),
+        details: system_details(),
         log: crate::logging::recent_lines(),
     }
 }
 
-/// Whether `name` is one of the streaming pool's threads, vanilla's `Util` worker threads.
-fn is_worker_thread(name: Option<&str>) -> bool {
-    name.is_some_and(|n| n.starts_with("horizon-worker-"))
-}
-
-/// `Util.onThreadException`: a panic on a worker thread is made a report titled "Exception on
-/// worker thread", with the thread's name, as `BlockableEventLoop.relayDelayCrash` hands it to
-/// the main thread.
-pub fn worker_panic_report(info: &std::panic::PanicHookInfo, side: &'static str) -> Report {
-    Report {
-        description: "Exception on worker thread".into(),
-        ..panic_report(info, side)
-    }
-}
-
 /// Reports panics: on the main thread a crash report (the panic then ends the game, exit code
-/// 101); on a worker thread (`Util.onThreadException`) a crash report too, and the game ends
-/// with it; on other threads the error goes to the log, as vanilla's uncaught exception handler
+/// 101); on other threads the error goes to the log, as vanilla's uncaught exception handler
 /// does. The default hook still prints the panic. A panic inside `contain` is only logged.
 pub fn install(home: PathBuf, side: &'static str) {
     let default = std::panic::take_hook();
@@ -547,14 +496,10 @@ pub fn install(home: PathBuf, side: &'static str) {
         let main = std::thread::current().name() == Some("main");
         if main {
             deliver(&home, panic_report(info, side));
-        } else if is_worker_thread(std::thread::current().name()) {
-            deliver(&home, worker_panic_report(info, side));
-            // The crash ends the game, as the relayed report does on vanilla's main thread.
-            std::process::exit(101);
         } else {
             log::error!(
                 "Caught previously unhandled exception in thread {}: {}",
-                thread_name(side),
+                thread_name(),
                 panic_message(info)
             );
         }
@@ -603,9 +548,9 @@ pub fn report_error(
                 description: DebugCrash::MESSAGE.into(),
                 error: DebugCrash::MESSAGE.into(),
                 stack: debug.stack.clone(),
-                thread: thread_name(side),
+                thread: thread_name(),
                 side,
-                details: system_details(side),
+                details: system_details(),
                 log: crate::logging::recent_lines(),
             },
         );
@@ -623,9 +568,9 @@ pub fn report_error(
             description: "Fatal error".into(),
             error: message,
             stack: String::new(),
-            thread: thread_name(side),
+            thread: thread_name(),
             side,
-            details: system_details(side),
+            details: system_details(),
             log: crate::logging::recent_lines(),
         },
     )
@@ -723,26 +668,6 @@ mod tests {
         ));
     }
 
-    #[test]
-    fn a_dedicated_servers_report_names_its_server_thread_and_no_render_settings() {
-        let unnamed = |side: &'static str| {
-            std::thread::spawn(move || thread_name(side))
-                .join()
-                .unwrap()
-        };
-        assert_eq!(unnamed("server"), "Server thread");
-        assert_eq!(unnamed("client"), "Render thread");
-        set_detail("Render Settings", "render distance 12");
-        let has = |side| {
-            system_details(side)
-                .iter()
-                .any(|(k, _)| k == "Render Settings")
-        };
-        assert!(has("client"));
-        assert!(!has("server"));
-        clear_detail("Render Settings");
-    }
-
     #[test]
     fn stacks_start_at_the_panicking_frame() {
         let bt = format!(
@@ -776,13 +701,6 @@ mod tests {
         assert!(first.contains("crash.rs"), "{}", debug.stack);
     }
 
-    #[test]
-    fn worker_threads_are_the_streaming_pool() {
-        assert!(is_worker_thread(Some("horizon-worker-3")));
-        assert!(!is_worker_thread(Some("main")));
-        assert!(!is_worker_thread(None));
-    }
-
     #[test]
     fn a_panic_becomes_a_report() {
         // A real panic through a hook, as the game's would be.

crates/horizon-client-render/src/datapack.rs

@@ -23,7 +23,7 @@ enum Source {
 }
 impl DataPack {
     /// Every file path under `prefix` (relative to the pack root).
-    pub fn list(&self, prefix: &str) -> Vec<String> {
+    fn list(&self, prefix: &str) -> Vec<String> {
         match &self.source {
             Source::Zip(z) => z
                 .names()
@@ -58,13 +58,12 @@ impl DataPack {
         }
         out
     }
-    pub fn read(&self, path: &str) -> Option<Vec<u8>> {
+    fn read(&self, path: &str) -> Option<Vec<u8>> {
         match &self.source {
             Source::Zip(z) => z.read(path).ok(),
             Source::Dir(root) => std::fs::read(root.join(path)).ok(),
         }
     }
-
     /// The `description` of `pack.mcmeta`, as text.
     pub fn description(&self) -> String {
         let Some(bytes) = self.read("pack.mcmeta") else {
@@ -76,24 +75,6 @@ impl DataPack {
             other => other["text"].as_str().unwrap_or_default().to_owned(),
         }
     }
-    /// The `features.enabled` flag ids of `pack.mcmeta`
-    /// (`FeatureFlagsMetadataSection`): the flags the pack asks to turn on.
-    pub fn features(&self) -> Vec<String> {
-        self.mcmeta()["features"]["enabled"]
-            .as_array()
-            .map(|a| {
-                a.iter()
-                    .filter_map(|f| f.as_str().map(str::to_owned))
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-    /// The `pack.mcmeta` as JSON, empty when it is missing or unreadable.
-    fn mcmeta(&self) -> serde_json::Value {
-        self.read("pack.mcmeta")
-            .and_then(|b| serde_json::from_slice(&b).ok())
-            .unwrap_or_default()
-    }
 }
 fn walk(root: &Path, dir: &Path, out: &mut Vec<String>) {
     let Ok(entries) = std::fs::read_dir(dir) else {
@@ -146,43 +127,14 @@ pub fn discover(world: &Path) -> Vec<DataPack> {
     packs.sort_by(|a, b| a.id.cmp(&b.id));
     packs
 }
-/// The resources root's built-in feature packs (`ServerPacksSource`
-/// scanning the game's `data/minecraft/datapacks`): every folder with a
-/// `pack.mcmeta`, a feature pack (`PackSource.FEATURE`). Off until a world
-/// selects them.
-pub fn feature_packs(resources: &Path) -> Vec<DataPack> {
-    let Ok(entries) = std::fs::read_dir(resources.join("data").join("minecraft").join("datapacks"))
-    else {
-        return Vec::new();
-    };
-    let mut packs = Vec::new();
-    for e in entries.flatten() {
-        let path = e.path();
-        if path.join("pack.mcmeta").exists() {
-            packs.push(DataPack {
-                id: e.file_name().to_string_lossy().into_owned(),
-                source: Source::Dir(path),
-            });
-        }
-    }
-    packs.sort_by(|a, b| a.id.cmp(&b.id));
-    packs
-}
-/// The packs of `<world>/datapacks` plus the resources root's feature packs:
-/// the world's whole repository, as `PackRepository.reload` sees it.
-pub fn discover_with_features(world_root: &Path, resources: &Path) -> Vec<DataPack> {
-    let mut packs = discover(world_root);
-    packs.extend(feature_packs(resources));
-    packs
-}
 
 // ---- Create World ------------------------------------------------------------
 
 /// Create World's Data Packs screen (`PackSelectionScreen` on vanilla's
-/// `mcworld-` folder): the folder's packs (`PackSource.WORLD`), the
-/// built-in one (`resources` holds its `pack.png`), and the feature packs
-/// of `resources` (`PackSource.FEATURE`), available at the bottom and off
-/// until picked — the Experiments.
+/// `mcworld-` folder): the folder's packs (`PackSource.WORLD`) and the
+/// built-in one (`resources` holds its `pack.png`), which can be unselected
+/// and stays at the bottom. Horizon has no experiments, so their feature
+/// packs are not offered.
 pub fn screen_packs(dir: &Path, resources: &Path) -> Vec<crate::pack_screen::PackInfo> {
     use crate::{
         pack_screen::{Compat, PackInfo, Source, load_icon},
@@ -220,23 +172,6 @@ pub fn screen_packs(dir: &Path, resources: &Path) -> Vec<crate::pack_screen::Pac
         position: Position::Bottom,
         fixed: false,
     });
-    for p in feature_packs(resources) {
-        let meta = p.mcmeta();
-        let (description, description_style) =
-            crate::packs::component_root(&meta["pack"]["description"]);
-        infos.push(PackInfo {
-            icon: None,
-            id: p.id.clone(),
-            title: Text::translate(&format!("dataPack.{}.name", p.id), &[]),
-            description,
-            description_style,
-            source: Source::Feature,
-            compat: crate::packs::compatibility_for(&meta, format),
-            required: false,
-            position: Position::Bottom,
-            fixed: false,
-        });
-    }
     infos
 }
 /// A new empty folder for Create World's packs
@@ -250,59 +185,6 @@ pub fn temp_folder() -> std::io::Result<PathBuf> {
     std::fs::create_dir_all(&dir)?;
     Ok(dir)
 }
-/// `PackSelectionScreen.onFilesDrop`'s `PackDetector`: a zip is a pack; a
-/// folder is one when it holds a `pack.mcmeta`, or exactly one folder that
-/// does (a folder zipped by the system, which adds a wrapper). Copied into
-/// `dir`; false when `path` is no pack.
-pub fn copy_pack(path: &Path, dir: &Path) -> bool {
-    fn copy_dir(from: &Path, at: &Path) {
-        let _ = std::fs::create_dir_all(at);
-        for entry in std::fs::read_dir(from).into_iter().flatten().flatten() {
-            let path = entry.path();
-            let to = at.join(entry.file_name());
-            if path.is_dir() {
-                copy_dir(&path, &to);
-            } else {
-                let _ = std::fs::copy(&path, &to);
-            }
-        }
-    }
-    let name = || {
-        path.file_name()
-            .map(|n| n.to_string_lossy().into_owned())
-            .unwrap_or_default()
-    };
-    if path.is_file() {
-        return path
-            .extension()
-            .is_some_and(|e| e.eq_ignore_ascii_case("zip"))
-            && {
-                let _ = std::fs::create_dir_all(dir);
-                std::fs::copy(path, dir.join(name())).is_ok()
-            };
-    }
-    if !path.is_dir() {
-        return false;
-    }
-    if path.join("pack.mcmeta").is_file() {
-        copy_dir(path, &dir.join(name()));
-        return true;
-    }
-    let own: Vec<PathBuf> = std::fs::read_dir(path)
-        .into_iter()
-        .flatten()
-        .flatten()
-        .map(|e| e.path())
-        .filter(|p| p.is_dir() && p.join("pack.mcmeta").is_file())
-        .collect();
-    match own.as_slice() {
-        [one] => {
-            copy_dir(one, &dir.join(one.file_name().unwrap_or_default()));
-            true
-        }
-        _ => false,
-    }
-}
 /// What's in a folder of packs, to notice packs added or removed while the
 /// screen shows it (`PackSelectionScreen.Watcher`).
 pub fn folder_stamp(dir: &Path) -> Vec<(String, Option<std::time::SystemTime>)> {
@@ -341,39 +223,6 @@ pub fn install(dir: &Path, world: &Path, selected: &[String]) -> Result<(), Stri
     let file = world.join("datapacks.json");
     std::fs::write(&file, json.to_string()).map_err(|e| err(&file, e))
 }
-/// Re-Create World's packs from a saved world: a new folder holding a copy of
-/// its `datapacks` (`CreateWorldScreen.createTempDataPackDirFromExistingWorld`; `None` when the
-/// world has none), and the selection its `datapacks.json` makes, lowest
-/// priority first (`WorldOpenFlows.recreateWorldData` keeps the world's `DataConfiguration`).
-/// The built-in pack is selected unless the world turned it off.
-pub fn for_recreate(world: &Path) -> (Option<PathBuf>, Vec<String>) {
-    let packs = discover(world);
-    // No flags here: the recreated world keeps the original's
-    // `enabled_features`, and the flag-aware load re-adds the feature packs
-    // it asks for (`for_recreate`'s selection only seeds the new world's
-    // `datapacks.json`).
-    let mut selected = enabled_ids(world, &packs, &[]);
-    let vanilla_off = std::fs::read(world.join("datapacks.json"))
-        .ok()
-        .and_then(|b| serde_json::from_slice::<serde_json::Value>(&b).ok())
-        .and_then(|v| v["disabled"].as_array().cloned())
-        .is_some_and(|a| a.iter().any(|id| id.as_str() == Some("vanilla")));
-    if !vanilla_off {
-        selected.insert(0, "vanilla".into());
-    }
-    if packs.is_empty() {
-        return (None, selected);
-    }
-    let dir = temp_folder().ok().and_then(|dir| {
-        if copy(&world.join("datapacks"), &dir).is_ok() {
-            Some(dir)
-        } else {
-            let _ = std::fs::remove_dir_all(&dir);
-            None
-        }
-    });
-    (dir, selected)
-}
 /// A file, or a folder and everything in it.
 fn copy(from: &Path, to: &Path) -> Result<(), String> {
     let err = |e: std::io::Error| format!("{} -> {}: {e}", from.display(), to.display());
@@ -575,7 +424,7 @@ pub struct DataStore {
     /// `item_modifier` files, for `/item modify`.
     pub item_modifiers: BTreeMap<String, serde_json::Value>,
     /// The content tables' raw files from the packs after the built-in one:
-    /// `recipe/`, `recipe_filter/`, `loot_table/`, `advancement/`, `dialog/`, `data_maps/` and `tags/…/` files, by
+    /// `recipe/`, `loot_table/`, `advancement/` and `tags/…/` files, by
     /// `<kind-dir>/<ns>:<path>`, each id's files in pack order. The tables
     /// merge them over what they read from the resource root.
     pub files: BTreeMap<String, Vec<Vec<u8>>>,
@@ -583,21 +432,17 @@ pub struct DataStore {
     pub errors: Vec<(String, String)>,
 }
 /// `<kind-dir>/<ns>:<path>` for a pack file the content tables read:
-/// `recipe/`, `recipe_filter/`, `loot_table/`, `advancement/`, `trade_set/`,
-/// `villager_trade/`, `dialog/`, `data_maps/` or `tags/<sub>/`, where the id keeps the sub
-/// path so a nested tag kind stays addressable.
+/// `recipe/`, `loot_table/`, `advancement/` or `tags/<sub>/`, where the id
+/// keeps the sub path so a nested tag kind stays addressable.
 fn content_id(file: &str) -> Option<String> {
     let rest = file.strip_prefix("data/")?;
     let (ns, rest) = rest.split_once('/')?;
     let (kind, rest) = rest.split_once('/')?;
     let kind = match kind {
-        "recipe" | "recipe_filter" | "loot_table" | "advancement" | "trade_set"
-        | "villager_trade" | "dialog" | "data_maps" => kind,
-        // A tag id is `{ns}:{path-under-tags}` (`tags/worldgen/biome/
-        // test:sub/mytag`), the whole path after the namespace, so nested
-        // registries keep their directory (`TagLoader`'s id shape).
+        "recipe" | "loot_table" | "advancement" => kind,
         "tags" => {
-            return Some(format!("tags/{ns}:{}", rest.strip_suffix(".json")?));
+            let (sub, name) = rest.rsplit_once('/')?;
+            return Some(format!("tags/{sub}/{ns}:{}", name.strip_suffix(".json")?));
         }
         _ => return None,
     };
@@ -623,17 +468,12 @@ impl DataStore {
             let builtin = pack.id == "vanilla";
             for f in pack.list_kinds(&[
                 "advancement",
-                "data_maps",
-                "dialog",
                 "function",
                 "item_modifier",
                 "loot_table",
                 "predicate",
                 "recipe",
-                "recipe_filter",
                 "tags",
-                "trade_set",
-                "villager_trade",
             ]) {
                 if !seen.insert(f.clone()) {
                     continue;
@@ -747,25 +587,10 @@ fn hash_normalize(s: &str) -> String {
     }
 }
 
-/// Whether every flag `pack` asks for (`Pack.getRequestedFeatures`) is among
-/// the world's `enabled_features`.
-fn features_enabled(pack: &DataPack, enabled_features: &[String]) -> bool {
-    pack.features()
-        .iter()
-        .all(|f| enabled_features.iter().any(|e| e == f))
-}
-
 /// The ids of `packs` (a world's, from `discover`) that are enabled, lowest
 /// priority first: those `<world>/datapacks.json` lists as enabled, in its
 /// order, then every pack it lists neither way, in name order.
-///
-/// `enabled_features` are the world's feature flags
-/// (`WorldDataConfiguration.enabledFeatures`): a pack a pack file selected
-/// while asking for missing features comes off
-/// (`MinecraftServer.configurePackRepository`), and a feature pack whose
-/// features the world enables is forced on however the world's selection
-/// feels about it (`MinecraftServer.enableForcedFeaturePacks`).
-pub fn enabled_ids(world: &Path, packs: &[DataPack], enabled_features: &[String]) -> Vec<String> {
+pub fn enabled_ids(world: &Path, packs: &[DataPack]) -> Vec<String> {
     let saved: Option<serde_json::Value> = std::fs::read(world.join("datapacks.json"))
         .ok()
         .and_then(|b| serde_json::from_slice(&b).ok());
@@ -784,69 +609,15 @@ pub fn enabled_ids(world: &Path, packs: &[DataPack], enabled_features: &[String]
     let mut enabled: Vec<String> = list("enabled")
         .into_iter()
         .filter(|id| packs.iter().any(|p| &p.id == id))
-        .filter(|id| {
-            packs
-                .iter()
-                .find(|p| &p.id == id)
-                .is_none_or(|p| features_enabled(p, enabled_features))
-        })
         .collect();
     for p in packs {
-        // A pack nobody mentions comes on (`PackRepository.reload` selects
-        // every new pack), but a feature pack stays off until the world
-        // enabled its flag (`PackSource.FEATURE` starts unselected).
-        if !enabled.contains(&p.id)
-            && !disabled.contains(&p.id)
-            && p.id.starts_with("file/")
-            && features_enabled(p, enabled_features)
-        {
-            enabled.push(p.id.clone());
-        }
-    }
-    for p in packs {
-        let feature_pack = !p.id.starts_with("file/") && p.id != "vanilla";
-        if feature_pack
-            && !p.features().is_empty()
-            && features_enabled(p, enabled_features)
-            && !enabled.contains(&p.id)
-        {
+        if !enabled.contains(&p.id) && !disabled.contains(&p.id) {
             enabled.push(p.id.clone());
         }
     }
     enabled
 }
 
-/// The level stems of `packs` (`data/<namespace>/dimension/<path>.json`, lowest priority first,
-/// as `enabled_ids` orders them): the id `namespace:path` and the parsed JSON, a later pack's
-/// file for an id replacing an earlier one's. This is `context.datapackDimensions()` of
-/// `WorldOpenFlows.loadWorldStem`.
-pub fn dimension_stems(packs: &[&DataPack]) -> BTreeMap<String, serde_json::Value> {
-    let mut out = BTreeMap::new();
-    for pack in packs {
-        for file in pack.list_kinds(&["dimension"]) {
-            let Some(rest) = file.strip_prefix("data/") else {
-                continue;
-            };
-            let Some((namespace, rest)) = rest.split_once('/') else {
-                continue;
-            };
-            let Some(path) = rest
-                .strip_prefix("dimension/")
-                .and_then(|p| p.strip_suffix(".json"))
-            else {
-                continue;
-            };
-            if let Some(json) = pack
-                .read(&file)
-                .and_then(|b| serde_json::from_slice(&b).ok())
-            {
-                out.insert(format!("{namespace}:{path}"), json);
-            }
-        }
-    }
-    out
-}
-
 // ---- worldgen ----------------------------------------------------------------
 
 /// The worldgen entries of `packs` (lowest priority first, the built-in pack
@@ -865,6 +636,11 @@ pub fn worldgen_overrides(
             let read = || String::from_utf8(pack.read(&file)?).ok();
             match out.add_file(&pack.id, &file, read) {
                 PackFile::Read | PackFile::Other => {}
+                PackFile::DimensionType { id, min_y, height } => warnings.push(format!(
+                    "{}: dimension type {id} (min_y {min_y}, height {height}) is not used: \
+                     the dimension keeps its vanilla build height",
+                    pack.id
+                )),
                 PackFile::NotRead(kind) => {
                     *not_read.entry(format!("{}: {kind}", pack.id)).or_default() += 1
                 }
@@ -883,15 +659,6 @@ pub fn worldgen_overrides(
 mod tests {
     use super::*;
 
-    #[test]
-    fn data_map_files_are_content_files_keyed_by_map_namespace_and_registry() {
-        assert_eq!(
-            content_id("data/mymod/data_maps/item/fuel.json").as_deref(),
-            Some("data_maps/mymod:item/fuel")
-        );
-        assert_eq!(content_id("data/mymod/data_maps/item/fuel.txt"), None);
-    }
-
     #[test]
     fn enabled_packs_override_worldgen_in_order() {
         let dir = std::env::temp_dir().join(format!("hz-datapack-worldgen-{}", std::process::id()));
@@ -929,7 +696,7 @@ mod tests {
         )
         .unwrap();
         let packs = discover(&dir);
-        let enabled = enabled_ids(&dir, &packs, &[]);
+        let enabled = enabled_ids(&dir, &packs);
         assert_eq!(enabled, ["file/b", "file/a"]);
         let enabled: Vec<&DataPack> = enabled
             .iter()
@@ -946,13 +713,10 @@ mod tests {
         );
         let tag_packs: Vec<&str> = o.tags("biome_tags").map(|(_, p, _)| p).collect();
         assert_eq!(tag_packs, ["file/b", "file/a"]);
-        assert_eq!(warnings.len(), 2, "{warnings:?}");
-        assert!(warnings[0].contains("minecraft:new_peaks"));
-        assert!(warnings[1].contains("worldgen/world_preset"));
-        assert_eq!(
-            o.level_height("minecraft:overworld").map(|h| h.height),
-            Some(2096)
-        );
+        assert_eq!(warnings.len(), 3, "{warnings:?}");
+        assert!(warnings[0].contains("height 2096"));
+        assert!(warnings[1].contains("minecraft:new_peaks"));
+        assert!(warnings[2].contains("worldgen/world_preset"));
         let _ = std::fs::remove_dir_all(&dir);
     }
     use horizon_world::nbt::parse_snbt;
@@ -1043,10 +807,6 @@ mod tests {
             "data/mine/predicate/p.json",
             "{\"condition\":\"minecraft:random_chance\",\"chance\":1}",
         );
-        write(
-            "data/mine/dialog/config/points.json",
-            "{\"type\":\"minecraft:notice\",\"title\":\"Points\"}",
-        );
         let packs = discover(&dir);
         assert_eq!(packs.len(), 1);
         assert_eq!(packs[0].id, "file/mypack");
@@ -1059,11 +819,6 @@ mod tests {
             ["mine:a", "mine:sub/b"]
         );
         assert!(store.predicates.contains_key("mine:p"));
-        // Dialogs reach the synchronized registry through the content files.
-        assert_eq!(
-            store.files["dialog/mine:config/points"],
-            [b"{\"type\":\"minecraft:notice\",\"title\":\"Points\"}".to_vec()]
-        );
         let _ = std::fs::remove_dir_all(&dir);
     }
 
@@ -1151,17 +906,9 @@ mod tests {
             std::fs::create_dir_all(path.parent().unwrap()).unwrap();
             std::fs::write(path, t).unwrap();
         };
-        write(
-            "fns",
-            "pack.mcmeta",
-            r#"{"pack":{"min_format":121,"max_format":121}}"#,
-        );
+        write("fns", "pack.mcmeta", r#"{"pack":{"pack_format":121}}"#);
         write("fns", "data/x/function/f.mcfunction", "say hi");
-        write(
-            "off",
-            "pack.mcmeta",
-            r#"{"pack":{"min_format":121,"max_format":121}}"#,
-        );
+        write("off", "pack.mcmeta", r#"{"pack":{"pack_format":121}}"#);
         std::fs::create_dir_all(&dir).unwrap();
         let mut zip = zip::ZipWriter::new(std::fs::File::create(dir.join("old.zip")).unwrap());
         zip.start_file("pack.mcmeta", zip::write::SimpleFileOptions::default())