mirror of
https://github.com/l0ng-ai/openidea.git
synced 2026-11-22 09:39:27 -10:00
Compare commits
22
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
61f811434c | ||
|
|
4e1cec5233 | ||
|
|
150eacc3de | ||
|
|
d1cc3cf68a | ||
|
|
7c00ce4fa1 | ||
|
|
6539a95cb8 | ||
|
|
08613ca800 | ||
|
|
1ad8b06a1a | ||
|
|
2ca0e195e5 | ||
|
|
750d35dd6e | ||
|
|
f0273690b9 | ||
|
|
04611c0388 | ||
|
|
1cfc71ae58 | ||
|
|
f8257b88b4 | ||
|
|
63b88bedc9 | ||
|
|
8daaef38d9 | ||
|
|
efd4e454ee | ||
|
|
0379c37a49 | ||
|
|
98da80b2b3 | ||
|
|
5c2e7ff92a | ||
|
|
e86a853048 | ||
|
|
fd8f0eb99c |
No files matched your search
@@ -29,7 +29,7 @@ Conventions:
|
||||
| ---------- | --------------------------------------- | --------------------------------------------------------------------------------------- |
|
||||
| oxfmt | `pnpm format` (CI: `pnpm format:check`) | `.oxfmtrc.json`: print width 120, double quotes, semicolons, trailing commas everywhere |
|
||||
| oxlint | `pnpm lint` | `.oxlintrc.json`: TypeScript and React plugins |
|
||||
| Type check | `pnpm typecheck` | `tsconfig.json` and the configs of `perf/`, `scripts/`, `smoke/` |
|
||||
| Type check | `pnpm typecheck` | `tsconfig.json` and the configs of `e2e/`, `evals/`, `perf/`, `scripts/`, `smoke/` |
|
||||
| knip | `pnpm knip` | `knip.ts`: unused files, exports and dependencies |
|
||||
|
||||
`pnpm knip` fails on an export nobody imports, a file nobody reaches or a dependency nobody uses. Delete dead code rather than suppressing it; exports used only inside their own file are allowed.
|
||||
|
||||
@@ -26,7 +26,7 @@ The same page also has:
|
||||
- **Different tool window background**: set tool windows apart from the editor.
|
||||
- **Background Image**: an image shown through the project window, with its **Opacity**, **Fill** (scale, original size or tile) and **Anchor**.
|
||||
- **Accessibility**: **Use contrast scrollbars** and **Adjust colors for red-green vision deficiency** (for protanopia and deuteranopia).
|
||||
- **Compact mode** under **UI Options**.
|
||||
- **Compact mode** under **UI Options**, also in **View › Appearance**. As in IntelliJ IDEA, it uses shorter tree and list rows, a smaller main toolbar, tool window stripes and status bar, 16px toolbar and stripe icons, and 1px smaller text in the toolbar, status bar, editor tabs and tool window headers.
|
||||
|
||||
## Editor color scheme
|
||||
|
||||
|
||||
@@ -25,12 +25,12 @@ description: "Rust 与 TypeScript 的格式化、lint 和死代码检查,以
|
||||
|
||||
## TypeScript 与 React
|
||||
|
||||
| 工具 | 命令 | 配置 |
|
||||
| -------- | ---------------------------------------- | --------------------------------------------------------- |
|
||||
| oxfmt | `pnpm format`(CI:`pnpm format:check`) | `.oxfmtrc.json`:行宽 120、双引号、分号、处处尾逗号 |
|
||||
| oxlint | `pnpm lint` | `.oxlintrc.json`:TypeScript 和 React 插件 |
|
||||
| 类型检查 | `pnpm typecheck` | `tsconfig.json` 以及 `perf/`、`scripts/`、`smoke/` 的配置 |
|
||||
| knip | `pnpm knip` | `knip.ts`:未使用的文件、导出和依赖 |
|
||||
| 工具 | 命令 | 配置 |
|
||||
| -------- | ---------------------------------------- | --------------------------------------------------------------------------- |
|
||||
| oxfmt | `pnpm format`(CI:`pnpm format:check`) | `.oxfmtrc.json`:行宽 120、双引号、处处尾逗号 |
|
||||
| oxlint | `pnpm lint` | `.oxlintrc.json`:TypeScript 和 React 插件 |
|
||||
| 类型检查 | `pnpm typecheck` | `tsconfig.json` 以及 `e2e/`、`evals/`、`perf/`、`scripts/`、`smoke/` 的配置 |
|
||||
| knip | `pnpm knip` | `knip.ts`:未使用的文件、导出和依赖 |
|
||||
|
||||
`pnpm knip` 发现没人 import 的导出、没人引用的文件或没人用的依赖时会失败。请删掉死代码,而不是屏蔽检查;只在本文件内使用的导出是允许的。
|
||||
|
||||
|
||||
@@ -26,7 +26,7 @@ description: "选择界面主题和编辑器配色方案,导入 IntelliJ 主
|
||||
- **不同的工具窗口背景**:让工具窗口与编辑器区分开。
|
||||
- **背景图像**:透过项目窗口显示的图像,可设置 **不透明度**、**填充**(缩放、原始大小或平铺)和 **位置**。
|
||||
- **辅助功能**:**使用对比度滚动条** 和 **针对红绿色觉缺陷调整颜色**(适用于红色盲和绿色盲)。
|
||||
- **UI 选项** 下的 **紧凑模式**。
|
||||
- **UI 选项** 下的 **紧凑模式**,也可在 **视图 › 外观** 中切换。与 IntelliJ IDEA 一致:树和列表的行更矮,主工具栏、工具窗口栏和状态栏更紧凑,工具栏和工具窗口栏图标为 16px,工具栏、状态栏、编辑器标签页和工具窗口标题的文字小 1px。
|
||||
|
||||
## 编辑器配色方案
|
||||
|
||||
|
||||
@@ -26,7 +26,7 @@ const firstTask: AgentTask = {
|
||||
const secondTask: AgentTask = { ...firstTask, id: "focus-second", title: "Second focus task" };
|
||||
const draft = "draft keep this unsent";
|
||||
const reboundShortcut = "Control+Meta+Shift+J";
|
||||
const subagent: AgentEntry = {
|
||||
const subagent: Extract<AgentEntry, { type: "subagent" }> = {
|
||||
type: "subagent",
|
||||
id: "focus-child",
|
||||
title: "Inspect focus behavior",
|
||||
|
||||
@@ -149,7 +149,7 @@ test("opens slash-prefixed Windows Markdown links with preview content and hover
|
||||
for (const [label, path, heading] of [
|
||||
["Specification", spec, "Windows specification"],
|
||||
["Work skill", skill, "Work specification skill"],
|
||||
]) {
|
||||
] as const) {
|
||||
const link = reply.getByRole("link", { name: label, exact: true });
|
||||
await link.hover();
|
||||
await expect(link).toHaveAttribute("title", path);
|
||||
|
||||
@@ -1,5 +1,7 @@
|
||||
import { expect, test } from "./fixtures";
|
||||
import type { AgentQuestion, AgentTask } from "../src/bindings";
|
||||
import type * as AgentStore from "../src/features/agents/store";
|
||||
import type * as Ipc from "../src/platform/ipc";
|
||||
|
||||
const task: AgentTask = {
|
||||
id: "questions",
|
||||
@@ -49,14 +51,12 @@ for (const status of ["running", "ready"] as const) {
|
||||
const key = JSON.stringify(["request_user_input_async", "call-1", 0]);
|
||||
await page.evaluate(
|
||||
async ({ task, status, key }) => {
|
||||
// Keep the workbench imports in the browser's Vite realm.
|
||||
const storePath = "/src/features/agents/store.ts";
|
||||
const ipcPath = "/src/platform/ipc.ts";
|
||||
const store = await import(storePath);
|
||||
(await import(ipcPath)).commands.agentAnswerQuestion = async (
|
||||
id: string,
|
||||
question: string,
|
||||
answer: string | null,
|
||||
) => {
|
||||
const store: typeof AgentStore = await import(storePath);
|
||||
const { commands }: typeof Ipc = await import(ipcPath);
|
||||
commands.agentAnswerQuestion = async (id, question, answer) => {
|
||||
document.documentElement.dataset.asyncAnswer = JSON.stringify({ id, question, answer });
|
||||
const entries = store.useAgents.getState().entries.get(id)!;
|
||||
store.useAgents.setState({
|
||||
@@ -111,7 +111,7 @@ for (const status of ["running", "ready"] as const) {
|
||||
if (status === "running") {
|
||||
await page.evaluate(async (id) => {
|
||||
const storePath = "/src/features/agents/store.ts";
|
||||
const { useAgents } = await import(storePath);
|
||||
const { useAgents }: typeof AgentStore = await import(storePath);
|
||||
useAgents.setState((s) => ({ tasks: new Map(s.tasks).set(id, { ...s.tasks.get(id)!, status: "ready" }) }));
|
||||
}, task.id);
|
||||
await expect(card.getByRole("radio", { name: /^Read latest content/ })).toBeChecked();
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import type * as ProjectStore from "../src/platform/project";
|
||||
import { expect, ipcCalls, openFromTree, stubDesktop, test } from "./fixtures";
|
||||
|
||||
test.use({ video: "on" });
|
||||
@@ -114,9 +115,11 @@ test("restricting an attached folder leaves the current project untouched", asyn
|
||||
test("restricted attachments can be trusted individually from the banner", async ({ workbench: page }) => {
|
||||
await stubDesktop(page);
|
||||
await page.evaluate(async () => {
|
||||
const m = "/src/platform/project.ts";
|
||||
const { useProject } = await import(/* @vite-ignore */ m);
|
||||
// Load the running workbench's store in the browser.
|
||||
const projectPath = "/src/platform/project.ts";
|
||||
const { useProject }: typeof ProjectStore = await import(/* @vite-ignore */ projectPath);
|
||||
const primary = useProject.getState().project;
|
||||
if (!primary) throw new Error("Expected the sample project to be open");
|
||||
let current = {
|
||||
...primary,
|
||||
trusted: false,
|
||||
@@ -126,11 +129,11 @@ test("restricted attachments can be trusted individually from the banner", async
|
||||
const trusted = new Set([primary.root]);
|
||||
window.__ipc.handlers.project_trust_status = ({ path }) => ({
|
||||
root: path,
|
||||
trusted: trusted.has(path),
|
||||
trusted: typeof path === "string" && trusted.has(path),
|
||||
decided: true,
|
||||
});
|
||||
window.__ipc.handlers.project_trust_set = ({ path, trusted: allow }) => {
|
||||
if (allow) trusted.add(path);
|
||||
if (allow && typeof path === "string") trusted.add(path);
|
||||
current = { ...current, trusted: current.workspace.projects.every((path) => trusted.has(path)) };
|
||||
};
|
||||
window.__ipc.handlers.project_current = () => current;
|
||||
|
||||
+219
-1
@@ -427,6 +427,70 @@ test("Find Usages from the editor context menu lists every usage by file and ope
|
||||
).toHaveAttribute("aria-selected", "true");
|
||||
});
|
||||
|
||||
test("usage locations and preview stay readable as the available space changes", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 1040, height: 760 });
|
||||
const editor = await openSample(page);
|
||||
await page.evaluate(
|
||||
({ file, other }) => {
|
||||
const locations = [
|
||||
{ path: file, range: { start: { line: 16, col: 8 }, end: { line: 16, col: 15 } } },
|
||||
{ path: file, range: { start: { line: 20, col: 27 }, end: { line: 20, col: 34 } } },
|
||||
{ path: other, range: { start: { line: 0, col: 0 }, end: { line: 0, col: 7 } } },
|
||||
];
|
||||
window.__ipc.handlers.lsp_references = () => ({
|
||||
locations,
|
||||
classified: [{ location: locations[2], kind: "code", text: "service.submit(order)" }],
|
||||
incomplete: null,
|
||||
librariesSkipped: true,
|
||||
});
|
||||
},
|
||||
{ file: FILE, other: `${ROOT}/domain/checkout/processing/calculations/PaymentProcessingService.kt` },
|
||||
);
|
||||
await caretAt(editor, page, "val order: Order", "service");
|
||||
await page.keyboard.press("Meta+Alt+F7");
|
||||
const popup = page.getByRole("dialog", { name: "Usages" });
|
||||
const scope = popup.getByRole("button", { name: "Scope" });
|
||||
const openWindow = popup.getByRole("button", { name: /^Open in Find Window/ });
|
||||
await expect(popup.getByTestId("usage-row")).toHaveCount(3);
|
||||
await popup.getByRole("button", { name: "Show Preview" }).click();
|
||||
const code = popup.getByRole("region", { name: "Preview" });
|
||||
await expect(code.locator(".cm-content")).toContainText("service.find(status");
|
||||
|
||||
await page.setViewportSize({ width: 480, height: 470 });
|
||||
const within = async (child: Locator, parent: Locator) => {
|
||||
const [c, p] = await Promise.all([child.boundingBox(), parent.boundingBox()]);
|
||||
return (
|
||||
!!c &&
|
||||
!!p &&
|
||||
c.x >= p.x - 1 &&
|
||||
c.y >= p.y - 1 &&
|
||||
c.x + c.width <= p.x + p.width + 1 &&
|
||||
c.y + c.height <= p.y + p.height + 1
|
||||
);
|
||||
};
|
||||
await expect.poll(() => within(scope, popup)).toBe(true);
|
||||
await expect.poll(() => within(openWindow, popup)).toBe(true);
|
||||
await expect.poll(() => within(code, popup)).toBe(true);
|
||||
const results = popup.getByRole("listbox", { name: "Usages" });
|
||||
await expect.poll(() => within(popup.getByTestId("usage-row").last(), results)).toBe(true);
|
||||
const firstRow = popup.getByTestId("usage-row").first();
|
||||
const file = firstRow.getByText("build.gradle.kts", { exact: true });
|
||||
await expect(file).toBeVisible();
|
||||
const [filename, snippet] = await Promise.all([file.boundingBox(), firstRow.locator("mark").boundingBox()]);
|
||||
expect(filename!.x + filename!.width).toBeLessThan(snippet!.x);
|
||||
await openWindow.click();
|
||||
|
||||
const tree = page.getByRole("tree", { name: "Usages" });
|
||||
const target = tree.getByRole("treeitem", { name: /^17 service\.find\(status/ });
|
||||
await target.click();
|
||||
const preview = page.getByRole("region", { name: "Preview" });
|
||||
await expect(preview).toContainText("service.find(status");
|
||||
await expect.poll(async () => (await preview.boundingBox())!.y > (await tree.boundingBox())!.y).toBe(true);
|
||||
await page.setViewportSize({ width: 1040, height: 760 });
|
||||
await expect.poll(async () => (await preview.boundingBox())!.x > (await tree.boundingBox())!.x).toBe(true);
|
||||
await expect(preview).toContainText("service.find(status");
|
||||
});
|
||||
|
||||
test("⇧F6 renames in place and sends the server's edit to be applied", async ({ workbench: page }) => {
|
||||
const editor = await openSample(page);
|
||||
await page.evaluate(
|
||||
@@ -495,7 +559,161 @@ test("indexed single-file rename previews all anchors and applies only after con
|
||||
}
|
||||
await expect.poll(() => ipcCalls(page, "apply_workspace_edit")).toHaveLength(1);
|
||||
const [apply] = await ipcCalls(page, "apply_workspace_edit");
|
||||
expect(apply.edit).toMatchObject({ preconditions: [{ path: FILE, hash: "indexed-snapshot" }] });
|
||||
expect(apply?.edit).toMatchObject({ preconditions: [{ path: FILE, hash: "indexed-snapshot" }] });
|
||||
});
|
||||
|
||||
test("rename keeps the typed name, uses the editor font and shows long preview names in a narrow dialog", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
const editor = await openSample(page);
|
||||
await page.evaluate(
|
||||
async ({ file, prepared }) => {
|
||||
const projectModule = "/src/platform/project.ts";
|
||||
const schemaModule = "/src/features/settings/model/schema.ts";
|
||||
const [{ useProject }, { DEFAULT_SETTINGS }] = await Promise.all([
|
||||
import(/* @vite-ignore */ projectModule),
|
||||
import(/* @vite-ignore */ schemaModule),
|
||||
]);
|
||||
const base = useProject.getState().settings ?? DEFAULT_SETTINGS;
|
||||
useProject.setState({ settings: { ...base, editor: { ...base.editor, fontSize: 17 } } });
|
||||
window.__ipc.handlers.lsp_prepare_rename = () => prepared;
|
||||
window.__ipc.handlers.lsp_rename = (args) => ({
|
||||
preview: true,
|
||||
incomplete: null,
|
||||
edit: {
|
||||
files: [
|
||||
{
|
||||
kind: "edit",
|
||||
path: file,
|
||||
edits: [{ range: prepared, new_text: args.newName }],
|
||||
},
|
||||
],
|
||||
},
|
||||
});
|
||||
window.__ipc.handlers.apply_workspace_edit = () => null;
|
||||
},
|
||||
{ file: FILE, prepared: range(20, 12, 17) },
|
||||
);
|
||||
|
||||
await caretAt(editor, page, "val order: Order", "order");
|
||||
await page.keyboard.press("Shift+F6");
|
||||
await expect(page.getByText(/Press ⇧F6 to show dialog/)).toBeVisible();
|
||||
const name = "checkoutOrderWithDeliveryInstructionsAndInventoryReservation";
|
||||
await page.keyboard.insertText(name);
|
||||
await page.keyboard.press("Shift+F6");
|
||||
await page.setViewportSize({ width: 440, height: 520 });
|
||||
const dialog = page.getByRole("dialog", { name: "Rename 'order'", exact: true });
|
||||
const input = dialog.getByRole("textbox", { name: "New name" });
|
||||
await expect(input).toBeFocused();
|
||||
await expect(input).toHaveValue(name);
|
||||
await expect(input).toHaveCSS("font-size", "17px");
|
||||
const [label, field] = await Promise.all([
|
||||
dialog.getByText("New name", { exact: true }).boundingBox(),
|
||||
input.boundingBox(),
|
||||
]);
|
||||
expect(label!.x + label!.width).toBeLessThan(field!.x);
|
||||
const rename = dialog.getByRole("button", { name: "Rename", exact: true });
|
||||
|
||||
await input.fill("");
|
||||
await expect(rename).toBeDisabled();
|
||||
await input.press("Enter");
|
||||
await expect(dialog).toBeVisible();
|
||||
expect(await ipcCalls(page, "lsp_rename")).toHaveLength(0);
|
||||
await input.fill(name);
|
||||
await input.press("Enter");
|
||||
|
||||
const summary = `Rename 'order' to '${name}'`;
|
||||
const preview = page.getByRole("dialog", { name: summary, exact: true });
|
||||
const context = preview.getByText(summary, { exact: true });
|
||||
await expect(context).toBeVisible();
|
||||
const geometry = await context.evaluate((element) => ({
|
||||
client: element.clientWidth,
|
||||
content: element.scrollWidth,
|
||||
}));
|
||||
expect(geometry.content).toBeLessThanOrEqual(geometry.client + 1);
|
||||
await expect(preview.getByText("1 occurrence in 1 file")).toBeVisible();
|
||||
expect(await ipcCalls(page, "apply_workspace_edit")).toHaveLength(0);
|
||||
await preview.getByRole("button", { name: "Do Refactor" }).click();
|
||||
await expect.poll(() => ipcCalls(page, "apply_workspace_edit")).toHaveLength(1);
|
||||
});
|
||||
|
||||
test("intention previews fit narrow windows and wrap long code lines", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 1600, height: 900 });
|
||||
const editor = await openSample(page);
|
||||
await page.evaluate(async () => {
|
||||
const path = "/src/platform/project.ts";
|
||||
const { useProject } = await import(/* @vite-ignore */ path);
|
||||
const { settings } = useProject.getState();
|
||||
useProject.setState({ settings: { ...settings, editor: { ...settings?.editor, fontSize: 16 } } });
|
||||
});
|
||||
await expect(editor.locator(".cm-content")).toHaveCSS("font-size", "16px");
|
||||
const replacement = "com.acme.orders." + "SharedDevelopmentOrderModel".repeat(6);
|
||||
await page.evaluate(
|
||||
({ file, replacement, edit }) => {
|
||||
window.__ipc.handlers.lsp_code_actions = () => [
|
||||
{
|
||||
title: "Replace Order with the fully qualified shared development order model",
|
||||
kind: "quickfix",
|
||||
isPreferred: true,
|
||||
disabledReason: null,
|
||||
edit: { files: [{ kind: "edit", path: file, edits: [{ range: edit, new_text: replacement }] }] },
|
||||
command: null,
|
||||
data: null,
|
||||
server: 1,
|
||||
},
|
||||
...Array.from({ length: 11 }, (_, i) => ({
|
||||
title: `Create alternative Order model ${i + 1}`,
|
||||
kind: "quickfix",
|
||||
isPreferred: false,
|
||||
disabledReason: null,
|
||||
edit: null,
|
||||
command: null,
|
||||
data: null,
|
||||
server: 1,
|
||||
})),
|
||||
];
|
||||
window.__ipc.handlers.lsp_execute_code_action = () => [];
|
||||
},
|
||||
{ file: FILE, replacement, edit: range(20, 19, 24) },
|
||||
);
|
||||
await caretAt(editor, page, "val order: Order", "Order ");
|
||||
await page.keyboard.press("Alt+Enter");
|
||||
const popup = page.getByRole("dialog", { name: "Intentions", exact: true });
|
||||
const options = popup.getByRole("listbox", { name: "Intentions" });
|
||||
const preview = popup.locator('[aria-label="Preview"]');
|
||||
await expect(preview.locator("pre")).toContainText(replacement);
|
||||
const wide = (await options.boundingBox())!;
|
||||
const widePreview = (await preview.boundingBox())!;
|
||||
expect(widePreview.x).toBeGreaterThanOrEqual(wide.x + wide.width - 1);
|
||||
|
||||
await page.setViewportSize({ width: 1050, height: 900 });
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const list = (await options.boundingBox())!;
|
||||
const code = (await preview.boundingBox())!;
|
||||
return code.x + code.width - list.x;
|
||||
})
|
||||
.toBeLessThanOrEqual(1);
|
||||
|
||||
await page.setViewportSize({ width: 520, height: 540 });
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const menu = (await popup.boundingBox())!;
|
||||
const list = (await options.boundingBox())!;
|
||||
const code = (await preview.boundingBox())!;
|
||||
return {
|
||||
popupFits: menu.x >= 0 && menu.y >= 0 && menu.x + menu.width <= 521 && menu.y + menu.height <= 541,
|
||||
previewBelow: code.y >= list.y + list.height - 1,
|
||||
previewFits: code.x >= menu.x && code.x + code.width <= menu.x + menu.width + 1,
|
||||
};
|
||||
})
|
||||
.toEqual({ popupFits: true, previewBelow: true, previewFits: true });
|
||||
expect(await preview.evaluate((el) => el.scrollWidth - el.clientWidth)).toBeLessThanOrEqual(1);
|
||||
await expect(preview.locator("pre")).toHaveCSS("font-size", "16px");
|
||||
await expect(options).toBeFocused();
|
||||
await page.keyboard.press("Enter");
|
||||
await expect(popup).toBeHidden();
|
||||
await expect.poll(() => ipcCalls(page, "lsp_execute_code_action")).toHaveLength(1);
|
||||
});
|
||||
|
||||
test("diagnostics underline the range and ⌥⏎ applies the preferred quick fix", async ({ workbench: page }) => {
|
||||
|
||||
@@ -0,0 +1,48 @@
|
||||
import { expect, test } from "./fixtures";
|
||||
|
||||
/** Heights IDEA's Islands theme uses in compact mode (`*.compact` keys), against the defaults. */
|
||||
const SIZES = {
|
||||
normal: { titleBar: 40, treeRow: 24, stripeIcon: 20, statusBar: 34, runButton: 30 },
|
||||
compact: { titleBar: 32, treeRow: 22, stripeIcon: 16, statusBar: 24, runButton: 26 },
|
||||
};
|
||||
|
||||
async function measure(page: import("@playwright/test").Page) {
|
||||
return page.evaluate(() => {
|
||||
const height = (selector: string) => document.querySelector(selector)?.getBoundingClientRect().height ?? null;
|
||||
return {
|
||||
titleBar: height("header"),
|
||||
treeRow: height('[role="tree"][aria-label="Project"] [role="treeitem"]'),
|
||||
stripeIcon: height("[data-stripe-button] svg"),
|
||||
statusBar: height('footer[aria-label="Status bar"]'),
|
||||
runButton: height("[data-run-chooser] + * button"),
|
||||
};
|
||||
});
|
||||
}
|
||||
|
||||
test("Compact Mode shrinks rows, toolbars, stripes and the status bar like IDEA", async ({ workbench: page }, info) => {
|
||||
// Plain-browser mode has no settings backend: set what the toggle action would store.
|
||||
const setCompact = (compactMode: boolean) =>
|
||||
page.evaluate(async (compactMode) => {
|
||||
const projectPath = "/src/platform/project.ts";
|
||||
const { useProject } = await import(/* @vite-ignore */ projectPath);
|
||||
const settings = useProject.getState().settings;
|
||||
useProject.setState({
|
||||
settings: {
|
||||
...settings,
|
||||
appearance: { ...settings?.appearance, theme: "dark", syncWithOs: false, compactMode },
|
||||
},
|
||||
});
|
||||
}, compactMode);
|
||||
|
||||
await setCompact(false);
|
||||
await expect.poll(() => measure(page)).toEqual(SIZES.normal);
|
||||
await info.attach("normal", { body: await page.screenshot({ animations: "disabled" }), contentType: "image/png" });
|
||||
|
||||
await setCompact(true);
|
||||
await expect(page.locator("html")).toHaveAttribute("data-compact", "");
|
||||
await expect.poll(() => measure(page)).toEqual(SIZES.compact);
|
||||
await info.attach("compact", { body: await page.screenshot({ animations: "disabled" }), contentType: "image/png" });
|
||||
|
||||
await setCompact(false);
|
||||
await expect.poll(() => measure(page)).toEqual(SIZES.normal);
|
||||
});
|
||||
@@ -6,7 +6,7 @@ for (const [id, selector] of [
|
||||
["keymap", "[class*='presetLabel']"],
|
||||
["editor.inspections", "[class*='profileRow'] > span:first-child"],
|
||||
["vcs.issueNavigation", "[class*='pageBody'] button:not([aria-label])"],
|
||||
]) {
|
||||
] as const) {
|
||||
test(`${id} keeps compact labels inside their controls`, async ({ workbench: page }) => {
|
||||
await page.keyboard.press("Meta+,");
|
||||
const dialog = page.getByRole("dialog");
|
||||
@@ -41,7 +41,7 @@ for (const [id, selector] of [
|
||||
for (const [id, selector] of [
|
||||
["general", "[class*='fontRow'] > label"],
|
||||
["build.console", "[class*='inlineRow'] > label"],
|
||||
]) {
|
||||
] as const) {
|
||||
test(`${id} keeps a readable width for inline text`, async ({ workbench: page }) => {
|
||||
await page.keyboard.press("Meta+,");
|
||||
await expect(page.getByRole("dialog", { name: "Settings", exact: true })).toBeVisible();
|
||||
|
||||
@@ -49,7 +49,7 @@ commands.lspHover = async () => {
|
||||
};
|
||||
commands.lspDocumentLinks = async () => ({ status: "ok", data: [] });
|
||||
commands.lspDocumentHighlights = async () => ({ status: "ok", data: [] });
|
||||
commands.cancelRequest = async () => ({ status: "ok", data: null });
|
||||
commands.cancelRequest = async () => {};
|
||||
const java = new EditorView({
|
||||
parent: javaHost,
|
||||
state: EditorState.create({
|
||||
|
||||
@@ -10,7 +10,7 @@ test("data source tabs share a stable layout and scroll within a short window",
|
||||
|
||||
const dialog = page.getByRole("dialog", { name: "New Data Source" });
|
||||
const panel = dialog.getByRole("tabpanel");
|
||||
const dialogSize = () => dialog.evaluate((element) => [element.offsetWidth, element.offsetHeight]);
|
||||
const dialogSize = () => dialog.evaluate((element: HTMLElement) => [element.offsetWidth, element.offsetHeight]);
|
||||
await expect(panel.getByRole("textbox", { name: "Host:" })).toBeVisible();
|
||||
const size = await dialogSize();
|
||||
await dialog.getByRole("tab", { name: "SSH/SSL" }).click();
|
||||
|
||||
@@ -187,7 +187,7 @@ test("result context menu fits the viewport, responds to hover and keyboard, and
|
||||
for (const [theme, label] of [
|
||||
["solarized-light", "Solarized Light"],
|
||||
["solarized-dark", "Solarized Dark"],
|
||||
]) {
|
||||
] as const) {
|
||||
test(`${label}: retains the inactive context-menu target's hover until dismissal without selecting it`, async ({
|
||||
workbench: page,
|
||||
}, info) => {
|
||||
|
||||
@@ -113,3 +113,60 @@ test("stops at a breakpoint, shows frames and variables, steps and resumes", asy
|
||||
await expect.poll(() => ipcCalls(page, "debug_resume")).toHaveLength(1);
|
||||
await expect(debug.getByText("CreateOrderRequest(sku='A-1', qty=2)")).toBeHidden();
|
||||
});
|
||||
|
||||
test("Evaluate keeps a multiline expression and its result visible in a short dialog", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 580, height: 420 });
|
||||
await stubDesktop(page);
|
||||
await page.evaluate(async (session) => {
|
||||
const handlers = window.__ipc.handlers;
|
||||
handlers.debug_capabilities = () => ({});
|
||||
handlers.debug_completions = () => [];
|
||||
handlers.debug_evaluate_in = () => ({
|
||||
name: "orderSummary",
|
||||
typeName: "OrderSummary",
|
||||
value: "total = 36",
|
||||
variablesReference: 210,
|
||||
evaluateName: null,
|
||||
});
|
||||
handlers.debug_variables = () => [
|
||||
{ name: "tax", value: "4", typeName: "int", variablesReference: 0, evaluateName: null },
|
||||
];
|
||||
const stateModule = "/src/features/debugger/state.ts";
|
||||
const { adoptSession } = await import(/* @vite-ignore */ stateModule);
|
||||
adoptSession(session, { name: "Checkout", adapter: "debugpy", status: "paused", selectedFrame: 11 });
|
||||
}, SESSION);
|
||||
|
||||
await page.keyboard.press("Alt+F8");
|
||||
const dialog = page.getByRole("dialog", { name: "Evaluate expression" });
|
||||
const field = dialog.getByRole("textbox", { name: "Expression" });
|
||||
const expression = ["orderSummary(", ...Array.from({ length: 12 }, (_, i) => ` item${i},`), ")"].join("\n");
|
||||
await field.fill(expression);
|
||||
await field.press("Enter");
|
||||
const result = dialog.getByRole("tree", { name: "Evaluation result" });
|
||||
const row = result.getByRole("treeitem").first();
|
||||
await expect(row).toContainText("total = 36");
|
||||
await expect
|
||||
.poll(() =>
|
||||
dialog.locator("[data-dialog-body]").evaluate((body) => {
|
||||
const area = body.querySelector("textarea")!;
|
||||
const resultRow = body.querySelector('[role="treeitem"]')!.getBoundingClientRect();
|
||||
const bounds = body.getBoundingClientRect();
|
||||
return (
|
||||
body.scrollHeight <= body.clientHeight + 1 &&
|
||||
area.scrollHeight > area.clientHeight &&
|
||||
resultRow.top >= bounds.top &&
|
||||
resultRow.bottom <= bounds.bottom
|
||||
);
|
||||
}),
|
||||
)
|
||||
.toBe(true);
|
||||
await row.click();
|
||||
await row.press("ArrowRight");
|
||||
await expect(result.getByText("tax", { exact: true })).toBeVisible();
|
||||
|
||||
await field.fill("otherExpression");
|
||||
await dialog.getByRole("button", { name: "History", exact: true }).click();
|
||||
await page.getByRole("menuitem", { name: /orderSummary/ }).click();
|
||||
await expect(field).toHaveValue(expression);
|
||||
await expect(field).toBeFocused();
|
||||
});
|
||||
@@ -0,0 +1,63 @@
|
||||
import { expect, stubDesktop, test } from "./fixtures";
|
||||
|
||||
const amountName = "regionalSettlementAmountFromExternalProcessorBeforeRounding";
|
||||
const routingName = "settlementRoutingReferenceForCrossBorderReconciliation";
|
||||
const routingValue = "'APR-2026 / eu-west / batch-701 / settlement complete'";
|
||||
|
||||
test("keeps values and their full-value action readable in a narrow debugger", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 1220, height: 760 });
|
||||
await stubDesktop(page);
|
||||
await page.evaluate(
|
||||
async ({ amountName, routingName, routingValue }) => {
|
||||
const debugModule = "/src/features/debugger/state.ts";
|
||||
const layoutModule = "/src/workbench/toolwindows/store.ts";
|
||||
const servicesModule = "/src/workbench/contributions.ts";
|
||||
const { adoptSession } = await import(/* @vite-ignore */ debugModule);
|
||||
const { moveToolWindow, setToolWindowSize } = await import(/* @vite-ignore */ layoutModule);
|
||||
const { toolWindowService } = await import(/* @vite-ignore */ servicesModule);
|
||||
const h = window.__ipc.handlers;
|
||||
h.debug_scopes = () => [{ name: "Locals", variablesReference: 100, expensive: false }];
|
||||
h.debug_variables = () => [
|
||||
{ name: amountName, value: "47.74", typeName: "float", variablesReference: 0, evaluateName: amountName },
|
||||
{ name: routingName, value: routingValue, typeName: "str", variablesReference: 0, evaluateName: routingName },
|
||||
];
|
||||
adoptSession(91, {
|
||||
name: "Checkout",
|
||||
adapter: "debugpy",
|
||||
status: "paused",
|
||||
selectedFrame: 11,
|
||||
frames: [{ id: 11, name: "checkout", path: null, line: 0, column: 0, presentationHint: null }],
|
||||
});
|
||||
moveToolWindow("debug", "right");
|
||||
setToolWindowSize("right", 390);
|
||||
toolWindowService().show("debug", true);
|
||||
},
|
||||
{ amountName, routingName, routingValue },
|
||||
);
|
||||
|
||||
const debug = page.getByRole("region", { name: "Debug", exact: true });
|
||||
await debug.getByRole("tab", { name: "Threads & Variables", exact: true }).click();
|
||||
const amount = debug.getByText("47.74", { exact: true });
|
||||
await expect
|
||||
.poll(() => amount.evaluate((el) => el.clientWidth > 0 && el.scrollWidth <= el.clientWidth + 1))
|
||||
.toBe(true);
|
||||
const routing = debug.getByRole("treeitem").filter({ hasText: routingName });
|
||||
const show = routing.getByTitle("Show", { exact: true });
|
||||
await expect(show).toBeInViewport({ ratio: 1 });
|
||||
await show.click();
|
||||
const dialog = page.getByRole("dialog", { name: `Value of ${routingName}` });
|
||||
await expect(dialog.getByText(routingValue, { exact: true })).toBeVisible();
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(dialog).toBeHidden();
|
||||
|
||||
await page.setViewportSize({ width: 1640, height: 760 });
|
||||
await page.evaluate(async () => {
|
||||
const layoutModule = "/src/workbench/toolwindows/store.ts";
|
||||
const { moveToolWindow } = await import(/* @vite-ignore */ layoutModule);
|
||||
moveToolWindow("debug", "bottom");
|
||||
});
|
||||
await expect(show).toBeHidden();
|
||||
await expect
|
||||
.poll(() => routing.getByText(routingValue, { exact: true }).evaluate((el) => el.scrollWidth <= el.clientWidth + 1))
|
||||
.toBe(true);
|
||||
});
|
||||
@@ -133,6 +133,64 @@ test("breadcrumbs follow the caret into the symbol under it", async ({ workbench
|
||||
await expect(bar).toBeHidden();
|
||||
});
|
||||
|
||||
test("narrow breadcrumb bars keep the current symbol visible and allow opening earlier crumbs", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
const editor = await openFromTree(page, "build.gradle.kts");
|
||||
const path = page.getByRole("navigation", { name: "Breadcrumbs", exact: true });
|
||||
const code = page.getByRole("navigation", { name: "Code breadcrumbs" });
|
||||
await editor.locator(".cm-line", { hasText: "service.find(status" }).click();
|
||||
await expect(code).toContainText("list()");
|
||||
|
||||
await page.evaluate(async () => {
|
||||
const documentModule = "/src/editor/core/model/document.ts";
|
||||
const editorModule = "/src/editor/core/controller.ts";
|
||||
const projectModule = "/src/platform/project.ts";
|
||||
const schemaModule = "/src/features/settings/model/schema.ts";
|
||||
const [{ useOutline }, { useEditorStatus }, { useProject }, { DEFAULT_SETTINGS }] = await Promise.all([
|
||||
import(/* @vite-ignore */ documentModule),
|
||||
import(/* @vite-ignore */ editorModule),
|
||||
import(/* @vite-ignore */ projectModule),
|
||||
import(/* @vite-ignore */ schemaModule),
|
||||
]);
|
||||
const base = useProject.getState().settings ?? DEFAULT_SETTINGS;
|
||||
useProject.setState({ settings: { ...base, editor: { ...base.editor, fontSize: 17 } } });
|
||||
const activePath = useEditorStatus.getState().status.path;
|
||||
let outline = useOutline.getState()[activePath];
|
||||
for (const name of ["OrderProcessingStrategies", "SalesApplicationRouting", "CheckoutWorkspaceConfiguration"]) {
|
||||
outline = [{ ...outline[0], name, detail: null, children: outline }];
|
||||
}
|
||||
useOutline.setState({ [activePath]: outline });
|
||||
});
|
||||
|
||||
await page.setViewportSize({ width: 620, height: 620 });
|
||||
const fullyInBar = (bar: typeof path, label: string) =>
|
||||
bar.evaluate((nav, text) => {
|
||||
const crumb = [...nav.querySelectorAll("button")].find((button) => button.textContent === text);
|
||||
if (!crumb) return false;
|
||||
const { left, right } = nav.getBoundingClientRect();
|
||||
const rect = crumb.getBoundingClientRect();
|
||||
return rect.width > 0 && rect.left >= left - 1 && rect.right <= right + 1;
|
||||
}, label);
|
||||
for (const bar of [path, code]) {
|
||||
await expect.poll(() => fullyInBar(bar, "list()")).toBe(true);
|
||||
await expect(bar.locator('[aria-current="location"]')).toHaveText("list()");
|
||||
}
|
||||
await expect(code.locator('[aria-current="location"]')).toHaveCSS("font-size", "17px");
|
||||
await code.hover();
|
||||
await page.mouse.wheel(0, -1200);
|
||||
await expect.poll(() => fullyInBar(code, "CheckoutWorkspaceConfiguration")).toBe(true);
|
||||
|
||||
const current = path.locator('[aria-current="location"]');
|
||||
await current.focus();
|
||||
await current.press("Home");
|
||||
const project = path.getByRole("button", { name: /acme-api/ }).first();
|
||||
await expect(project).toBeFocused();
|
||||
await expect.poll(() => fullyInBar(path, "acme-api")).toBe(true);
|
||||
await project.press("ArrowDown");
|
||||
await expect(page.getByRole("listbox", { name: "acme-api" })).toBeVisible();
|
||||
});
|
||||
|
||||
/** What the in-memory backend has saved for `path`. */
|
||||
const saved = (page: Page, path: string) =>
|
||||
page.evaluate(async (path) => {
|
||||
@@ -174,6 +232,48 @@ test("⌘R replaces every match in the file", async ({ workbench: page }) => {
|
||||
await expect(editor.locator(".cm-line", { hasText: "OrderDto" })).toHaveCount(2);
|
||||
});
|
||||
|
||||
test("the inline find and replace controls stay inside a narrow editor pane", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 1120, height: 760 });
|
||||
const editor = await openFromTree(page, "build.gradle.kts");
|
||||
await editor.locator(".cm-content").click();
|
||||
await page.keyboard.press("Meta+r");
|
||||
const bar = page.getByRole("search", { name: "Replace in file" });
|
||||
const find = bar.getByRole("textbox", { name: "Find" });
|
||||
const replace = bar.getByRole("textbox", { name: "Replace" });
|
||||
const next = bar.getByRole("button", { name: /Next Occurrence/ });
|
||||
await find.fill("OrderDto");
|
||||
await find.press("Tab");
|
||||
await expect(replace).toBeFocused();
|
||||
await replace.fill("OrderView");
|
||||
const navigationIsBelowFind = async () => {
|
||||
const [input, button] = await Promise.all([find.boundingBox(), next.boundingBox()]);
|
||||
return !!input && !!button && button.y >= input.y + input.height;
|
||||
};
|
||||
const controlsFit = () =>
|
||||
bar.evaluate((panel) => {
|
||||
const bounds = panel.getBoundingClientRect();
|
||||
return [...panel.querySelectorAll("button, textarea")].every((element) => {
|
||||
const control = element.getBoundingClientRect();
|
||||
return control.width > 0 && control.left >= bounds.left && control.right <= bounds.right;
|
||||
});
|
||||
});
|
||||
await expect.poll(navigationIsBelowFind).toBe(false);
|
||||
|
||||
await page.setViewportSize({ width: 590, height: 760 });
|
||||
await expect.poll(controlsFit).toBe(true);
|
||||
await expect.poll(navigationIsBelowFind).toBe(true);
|
||||
await page.setViewportSize({ width: 495, height: 760 });
|
||||
await expect.poll(controlsFit).toBe(true);
|
||||
await expect(find).toHaveValue("OrderDto");
|
||||
await expect(replace).toHaveValue("OrderView");
|
||||
await next.click();
|
||||
await expect(bar.getByText(/^[12]\/2$/)).toBeVisible();
|
||||
await bar.getByRole("button", { name: "Replace All" }).click();
|
||||
await expect(editor.locator(".cm-line", { hasText: "OrderView" })).toHaveCount(2);
|
||||
await bar.getByRole("button", { name: "Close", exact: true }).click();
|
||||
await expect(bar).toBeHidden();
|
||||
});
|
||||
|
||||
test("Markdown preview highlights ⌘F matches, selected words and scales diagrams with font zoom", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
@@ -538,3 +638,15 @@ test("dragging the Markdown split divider resizes and reflows editor and preview
|
||||
.poll(async () => Math.round((await reopenedEditor.boundingBox())!.width))
|
||||
.toBe(Math.round(initialEditor));
|
||||
});
|
||||
|
||||
test("Markdown Preview only leaves the Project view clickable", async ({ workbench: page }) => {
|
||||
await openFromTree(page, "README.md");
|
||||
await page.getByRole("button", { name: "Preview Only" }).click();
|
||||
await expect(page.getByRole("document", { name: "Markdown preview" })).toBeVisible();
|
||||
|
||||
const row = page.getByRole("treeitem", { name: "build.gradle.kts", exact: true });
|
||||
// A hidden editor panel used to leave an implicit resize region over everything left of the preview,
|
||||
// which swallowed the click.
|
||||
await row.click();
|
||||
await expect(row).toHaveAttribute("aria-selected", "true");
|
||||
});
|
||||
@@ -45,11 +45,10 @@ POST https://example.test/messages
|
||||
const json = document.createElement("div");
|
||||
json.id = "json";
|
||||
document.body.append(json);
|
||||
const jsonSupport = await loadSupport(findLanguageDescription("JSON", "body.json")!);
|
||||
if (!jsonSupport) throw new Error("Failed to load JSON support for the highlighting fixture");
|
||||
new EditorView({
|
||||
parent: json,
|
||||
doc: '{"name": "World", "count": 12, "enabled": true, "ready": false, "empty": null, "items": [1]}',
|
||||
extensions: [
|
||||
await loadSupport(findLanguageDescription("JSON", "body.json")!),
|
||||
syntaxHighlighting(openideaHighlightStyle),
|
||||
],
|
||||
extensions: [jsonSupport, syntaxHighlighting(openideaHighlightStyle)],
|
||||
});
|
||||
@@ -1,4 +1,5 @@
|
||||
import { readFileSync } from "node:fs";
|
||||
import type * as EditorBackend from "../src/editor/core/backend";
|
||||
import { expect, test } from "./fixtures";
|
||||
|
||||
const xml = readFileSync(
|
||||
@@ -10,13 +11,14 @@ test("imported PHP colours stay separate from Java and preserve regular text on
|
||||
workbench: page,
|
||||
}, info) => {
|
||||
await page.evaluate(async (xml) => {
|
||||
// Load the workbench modules in the browser's Vite realm.
|
||||
const iclsPath = "/src/platform/icls.ts";
|
||||
const projectPath = "/src/platform/project.ts";
|
||||
const backendPath = "/src/editor/core/backend.ts";
|
||||
const contributionsPath = "/src/workbench/contributions.ts";
|
||||
const { parseIcls } = await import(iclsPath);
|
||||
const { useProject } = await import(projectPath);
|
||||
const { docBackend } = await import(backendPath);
|
||||
const { docBackend }: typeof EditorBackend = await import(backendPath);
|
||||
const { editorService } = await import(contributionsPath);
|
||||
const previous = useProject.getState().settings ?? {};
|
||||
useProject.setState({
|
||||
@@ -31,10 +33,11 @@ test("imported PHP colours stay separate from Java and preserve regular text on
|
||||
},
|
||||
});
|
||||
const backend = docBackend();
|
||||
if (!("files" in backend) || !(backend.files instanceof Map)) throw new Error("Expected the in-memory backend");
|
||||
const open = backend.open.bind(backend);
|
||||
backend.open = async (...args: Parameters<typeof open>) => {
|
||||
const result = await open(...args);
|
||||
return args[0].endsWith(".php") ? { ...result, language: "php", uiMode: "PHP" } : result;
|
||||
backend.open = async (path) => {
|
||||
const result = await open(path);
|
||||
return path.endsWith(".php") ? { ...result, language: "php", uiMode: "PHP" } : result;
|
||||
};
|
||||
backend.files.set(
|
||||
"/dev/acme-api/palette.php",
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import { EditorView } from "@codemirror/view";
|
||||
import { commands, type InlayHint, type Range } from "../src/platform/ipc";
|
||||
import type { InlayHint, Range } from "../src/bindings";
|
||||
import { commands } from "../src/platform/ipc";
|
||||
import { setInvokeRoute } from "../src/platform/tauriCore";
|
||||
import { lspDoc } from "../src/editor/lsp/lsp";
|
||||
import { inlayExtension } from "../src/editor/lsp/inlay";
|
||||
|
||||
+16
-11
@@ -1,3 +1,4 @@
|
||||
import type { DataSource_Deserialize, DbJdbcDriver } from "../src/bindings";
|
||||
import { expect, ipcCalls, stubDesktop, test } from "./fixtures";
|
||||
|
||||
test("configures a local JDBC profile and a source through mocked IPC", async ({ workbench: page }, info) => {
|
||||
@@ -102,21 +103,25 @@ test("configures a local JDBC profile and a source through mocked IPC", async ({
|
||||
await source.getByLabel("Property value", { exact: true }).fill("true");
|
||||
await test.click();
|
||||
await expect(source.getByRole("status")).toHaveText("Succeeded: Mock JDBC database");
|
||||
const [{ source: tested, password }] = await ipcCalls(page, "db_test");
|
||||
expect(password).toBe("mock secret");
|
||||
const [tested] = await ipcCalls(page, "db_test");
|
||||
expect(tested).toMatchObject({
|
||||
driver: "jdbc",
|
||||
url,
|
||||
user: "example-user",
|
||||
readOnly: true,
|
||||
properties: [{ name: "ssl", value: "true" }],
|
||||
password: "mock secret",
|
||||
source: {
|
||||
driver: "jdbc",
|
||||
url,
|
||||
user: "example-user",
|
||||
readOnly: true,
|
||||
properties: [{ name: "ssl", value: "true" }],
|
||||
},
|
||||
});
|
||||
await source.getByRole("button", { name: "OK", exact: true }).click();
|
||||
await expect(source).not.toBeVisible();
|
||||
const [{ sources }] = await ipcCalls(page, "db_save_sources");
|
||||
const [saved] = sources as Record<string, unknown>[];
|
||||
const [{ driver }] = await ipcCalls(page, "db_save_jdbc_driver");
|
||||
const [save] = await ipcCalls(page, "db_save_sources");
|
||||
const saved = (save?.sources as DataSource_Deserialize[] | undefined)?.[0];
|
||||
const [profile] = await ipcCalls(page, "db_save_jdbc_driver");
|
||||
const driver = profile?.driver as DbJdbcDriver | undefined;
|
||||
if (!saved || !driver) throw new Error("Expected the JDBC source and driver to be saved");
|
||||
expect(saved.readOnly).toBe(true);
|
||||
expect(saved.jdbcDriver).toBe((driver as Record<string, unknown>).id);
|
||||
expect(saved.jdbcDriver).toBe(driver.id);
|
||||
for (const key of ["jars", "className", "classpath", "exec", "password"]) expect(saved).not.toHaveProperty(key);
|
||||
});
|
||||
@@ -1,5 +1,5 @@
|
||||
/** Linked Gradle builds use isolated native stubs; no real builds or files are touched. */
|
||||
import type { GradleModel, RunConfig } from "../src/platform/ipc";
|
||||
import type { GradleModel, RunConfig_Deserialize } from "../src/bindings";
|
||||
import { expect, ipcCalls, stubDesktop, test } from "./fixtures";
|
||||
|
||||
const build = (dir: string): GradleModel => ({
|
||||
@@ -46,7 +46,7 @@ test("links independent Gradle roots, runs identical task paths in their own bui
|
||||
};
|
||||
h["plugin:dialog|open"] = () => ["/dev/acme-api/second/settings.gradle"];
|
||||
h.run_start = (args) => {
|
||||
const config = args.config as RunConfig;
|
||||
const config = args.config as RunConfig_Deserialize;
|
||||
const id = ++runId;
|
||||
setTimeout(() => window.__ipc.emit({ type: "runExited", run: id, code: 0 }), 50);
|
||||
return { id, configId: config.id, name: config.name, pid: 4242 + id, running: true, pty: false };
|
||||
@@ -89,7 +89,7 @@ test("links independent Gradle roots, runs identical task paths in their own bui
|
||||
await expect.poll(async () => (await ipcCalls(page, "run_start")).length).toBe(1);
|
||||
await tasks.nth(1).dblclick();
|
||||
await expect.poll(async () => (await ipcCalls(page, "run_start")).length).toBe(2);
|
||||
const runs = (await ipcCalls(page, "run_start")).map((args) => args.config as RunConfig);
|
||||
const runs = (await ipcCalls(page, "run_start")).map((args) => args.config as RunConfig_Deserialize);
|
||||
expect(runs[0]!.id).not.toBe(runs[1]!.id);
|
||||
for (const [index, dir] of ["first", "second"].entries()) {
|
||||
expect(runs[index]).toMatchObject({
|
||||
|
||||
@@ -63,6 +63,44 @@ const result = (page: Page) => page.getByRole("region", { name: "Result" });
|
||||
const text = async (pane: Locator) => (await pane.locator(".cm-content").innerText()).replace(//g, "");
|
||||
const status = (page: Page) => page.locator("#merge-host [class*=status]").first();
|
||||
|
||||
test("merge controls and pane titles fit while resizing the result", async ({ page }) => {
|
||||
await page.setViewportSize({ width: 400, height: 600 });
|
||||
await mountMerge(page);
|
||||
const host = page.locator("#merge-host");
|
||||
for (const name of ["Accept Yours", "Accept Theirs", "Cancel", "Apply"])
|
||||
await expect(host.getByRole("button", { name, exact: true })).toBeInViewport({ ratio: 1 });
|
||||
await expect(status(page)).toHaveText("3 changes left, 2 conflicts");
|
||||
await expect(status(page)).toBeInViewport({ ratio: 1 });
|
||||
|
||||
const ours = page.getByRole("region", { name: "Your version" });
|
||||
await expect(ours.getByText("Your version", { exact: true })).toBeVisible();
|
||||
await expect(
|
||||
page.getByRole("region", { name: "Their version" }).getByText("Their version", { exact: true }),
|
||||
).toBeVisible();
|
||||
await ours.locator(".cm-merge-accept").nth(1).focus();
|
||||
await page.keyboard.press("Enter");
|
||||
await expect.poll(() => text(result(page))).toContain("\nmine\n");
|
||||
|
||||
await page.setViewportSize({ width: 980, height: 660 });
|
||||
const resultWidth = async () => (await result(page).boundingBox())!.width;
|
||||
const initial = await resultWidth();
|
||||
const left = host.getByRole("separator", { name: "Resize left merge pane" });
|
||||
await left.press("ArrowLeft");
|
||||
await expect.poll(resultWidth).toBeGreaterThan(initial + 1);
|
||||
|
||||
const right = host.getByRole("separator", { name: "Resize right merge pane" });
|
||||
const grip = (await right.boundingBox())!;
|
||||
const withLeftResized = await resultWidth();
|
||||
await page.mouse.move(grip.x + grip.width / 2, grip.y + grip.height / 2);
|
||||
await page.mouse.down();
|
||||
await page.mouse.move(grip.x + grip.width / 2 + 36, grip.y + grip.height / 2, { steps: 4 });
|
||||
await page.mouse.up();
|
||||
await expect.poll(resultWidth).toBeGreaterThan(withLeftResized + 20);
|
||||
await expect(result(page).getByText("Result", { exact: true })).toBeVisible();
|
||||
await expect(ours.getByText("Changes from main", { exact: true })).toBeVisible();
|
||||
await expect.poll(() => text(result(page))).toContain("\nmine\n");
|
||||
});
|
||||
|
||||
/** Capture the save boundary, keeping real editor state, dialogs and Apply behavior. */
|
||||
async function captureWrites(page: Page) {
|
||||
await page.evaluate(async () => {
|
||||
|
||||
@@ -0,0 +1,76 @@
|
||||
import type { Page } from "@playwright/test";
|
||||
import type { SignatureHelp } from "../src/bindings";
|
||||
import { expect, openFromTree, stubDesktop, test } from "./fixtures";
|
||||
|
||||
function signature(name: string, parameters: string[]) {
|
||||
let offset = name.length + 1;
|
||||
const ranges: [number, number][] = parameters.map((parameter) => {
|
||||
const range: [number, number] = [offset, offset + parameter.length];
|
||||
offset = range[1] + 2;
|
||||
return range;
|
||||
});
|
||||
return { label: `${name}(${parameters.join(", ")}): Invoice`, parameters: ranges, documentation: null };
|
||||
}
|
||||
|
||||
async function openParameterInfo(page: Page, help: SignatureHelp) {
|
||||
const editor = await openFromTree(page, "build.gradle.kts");
|
||||
await stubDesktop(page);
|
||||
await page.evaluate((help) => {
|
||||
window.__ipc.handlers.lsp_signature_help = () => help;
|
||||
}, help);
|
||||
await editor.locator(".cm-line", { hasText: "return order.toDto()" }).click();
|
||||
await page.keyboard.press("End");
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await page.keyboard.press("Meta+p");
|
||||
const popup = page.locator(".cm-lsp-signature");
|
||||
await expect(popup).toBeVisible();
|
||||
return { editor, popup };
|
||||
}
|
||||
|
||||
test("parameter info wraps long parameters and follows the editor width", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 1120, height: 700 });
|
||||
const parameter = "roundingPolicyForThirdPartyPaymentsWithMultipleSettlementCurrencies: RoundingPolicy";
|
||||
const { editor, popup } = await openParameterInfo(page, {
|
||||
signatures: [signature("formatInvoice", ["order: Cart", parameter, "currency: string"])],
|
||||
activeSignature: 0,
|
||||
activeParameter: 1,
|
||||
});
|
||||
await page.setViewportSize({ width: 560, height: 650 });
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const [pane, hint] = await Promise.all([editor.boundingBox(), popup.boundingBox()]);
|
||||
return !!pane && !!hint && hint.x >= pane.x - 1 && hint.x + hint.width <= pane.x + pane.width + 1;
|
||||
})
|
||||
.toBe(true);
|
||||
await expect.poll(() => popup.evaluate((el) => el.scrollWidth - el.clientWidth)).toBeLessThanOrEqual(1);
|
||||
await expect(popup.locator("b")).toHaveText(parameter);
|
||||
const fontSize = await editor.locator(".cm-content").evaluate((el) => getComputedStyle(el).fontSize);
|
||||
await expect(popup).toHaveCSS("font-size", fontSize);
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(popup).toBeHidden();
|
||||
});
|
||||
|
||||
test("parameter info keeps the active overload visible and scrolls to the others", async ({ workbench: page }) => {
|
||||
const signatures = Array.from({ length: 20 }, (_, i) =>
|
||||
signature("formatInvoice", [`order: Cart${i}`, "currency: string"]),
|
||||
);
|
||||
const { popup } = await openParameterInfo(page, { signatures, activeSignature: 16, activeParameter: 1 });
|
||||
await expect(popup.locator(".cm-lsp-signature-row")).toHaveCount(signatures.length);
|
||||
const active = popup.locator(".cm-lsp-signature-active b");
|
||||
await expect(active).toHaveText("currency: string");
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const [frame, parameter] = await Promise.all([popup.boundingBox(), active.boundingBox()]);
|
||||
return (
|
||||
!!frame && !!parameter && parameter.y >= frame.y && parameter.y + parameter.height <= frame.y + frame.height
|
||||
);
|
||||
})
|
||||
.toBe(true);
|
||||
expect(await popup.evaluate((el) => el.scrollTop)).toBeGreaterThan(0);
|
||||
await popup.hover();
|
||||
await page.mouse.wheel(0, -1200);
|
||||
await expect.poll(() => popup.evaluate((el) => el.scrollTop)).toBe(0);
|
||||
await expect(
|
||||
popup.getByText("formatInvoice(order: Cart0, currency: string): Invoice", { exact: true }),
|
||||
).toBeInViewport();
|
||||
});
|
||||
+120
-42
@@ -9,50 +9,75 @@ import { expect, stubDesktop, test } from "./fixtures";
|
||||
const ROOT = "/dev/acme-api";
|
||||
const HUGE = `feature/wrap-${"x".repeat(140)}`;
|
||||
|
||||
async function openPushDialog(page: Page) {
|
||||
const OUTGOING = "Apply order-level discounts before calculating checkout taxes";
|
||||
|
||||
async function openPushDialog(page: Page, { outgoing = false, multi = false } = {}) {
|
||||
await stubDesktop(page);
|
||||
await page.evaluate(async (root) => {
|
||||
const h = window.__ipc.handlers;
|
||||
h.vcs_roots = () => [{ root, operation: null, head: "main", headCommit: "1111111" }];
|
||||
h.vcs_branch_info = () => ({
|
||||
head: "main",
|
||||
headCommit: "1111111",
|
||||
upstream: "origin/main",
|
||||
ahead: 0,
|
||||
behind: 0,
|
||||
operation: null,
|
||||
});
|
||||
h.vcs_status = () => [];
|
||||
h.vcs_log = () => [];
|
||||
h.vcs_remotes = () => [{ name: "origin", url: "[email protected]:acme/api.git" }];
|
||||
const branch = (name: string, remote: boolean, upstream: string | null = null) => ({
|
||||
name,
|
||||
remote,
|
||||
current: !remote,
|
||||
upstream,
|
||||
ahead: 0,
|
||||
behind: 0,
|
||||
lastCommitMs: 0,
|
||||
});
|
||||
h.vcs_branches = () => [
|
||||
branch("main", false, "origin/main"),
|
||||
branch("feature/login", false),
|
||||
branch("origin/main", true),
|
||||
branch("origin/feature/login", true),
|
||||
branch("origin/fix/error-auth", true),
|
||||
branch("origin/feature/PLATFORM-12345-order-history-export", true),
|
||||
branch(`origin/feature/wrap-${"x".repeat(140)}`, true),
|
||||
];
|
||||
const vcsModule = "/src/features/vcs/store.ts";
|
||||
const { useVcs, refreshNow } = await import(/* @vite-ignore */ vcsModule);
|
||||
useVcs.setState({ available: true, root, repo: root, branchesLoaded: false, stashesLoaded: false });
|
||||
await refreshNow();
|
||||
const actionsModule = "/src/platform/actions.ts";
|
||||
const { executeAction } = await import(/* @vite-ignore */ actionsModule);
|
||||
void executeAction("vcs.push");
|
||||
}, ROOT);
|
||||
await page.evaluate(
|
||||
async ({ root, outgoing, multi, subject }) => {
|
||||
const h = window.__ipc.handlers;
|
||||
const head = multi ? "feature/refine-checkout-pricing-and-order-summary-for-regional-release" : "main";
|
||||
const roots = multi ? [root, `${root}/billing-and-refunds`] : [root];
|
||||
h.vcs_roots = () => roots.map((root) => ({ root, operation: null, head, headCommit: "1111111" }));
|
||||
h.vcs_branch_info = () => ({
|
||||
head,
|
||||
headCommit: "1111111",
|
||||
upstream: `origin/${head}`,
|
||||
ahead: outgoing ? 1 : 0,
|
||||
behind: 0,
|
||||
operation: null,
|
||||
});
|
||||
h.vcs_status = () => [];
|
||||
h.vcs_log = () =>
|
||||
outgoing
|
||||
? [
|
||||
{
|
||||
id: "2222222",
|
||||
shortId: "2222222",
|
||||
parents: ["1111111"],
|
||||
summary: subject,
|
||||
message: subject + "\n\nKeep the new totals consistent with receipts.",
|
||||
author: "Sam Rivera",
|
||||
email: "[email protected]",
|
||||
timeMs: 1795100000000,
|
||||
},
|
||||
]
|
||||
: [];
|
||||
h.vcs_commit_files = () => [{ path: "checkout.ts", oldPath: null, kind: "modified" }];
|
||||
h.vcs_has_hook = () => false;
|
||||
h.vcs_remotes = () => [{ name: "origin", url: "[email protected]:acme/api.git" }];
|
||||
const branch = (name: string, remote: boolean, upstream: string | null = null) => ({
|
||||
name,
|
||||
remote,
|
||||
current: !remote,
|
||||
upstream,
|
||||
ahead: 0,
|
||||
behind: 0,
|
||||
lastCommitMs: 0,
|
||||
});
|
||||
h.vcs_branches = () => [
|
||||
branch("main", false, "origin/main"),
|
||||
branch("feature/login", false),
|
||||
branch("origin/main", true),
|
||||
branch("origin/feature/login", true),
|
||||
branch("origin/fix/error-auth", true),
|
||||
branch("origin/feature/PLATFORM-12345-order-history-export", true),
|
||||
branch(`origin/feature/wrap-${"x".repeat(140)}`, true),
|
||||
];
|
||||
const vcsModule = "/src/features/vcs/store.ts";
|
||||
const { useVcs, refreshNow } = await import(/* @vite-ignore */ vcsModule);
|
||||
useVcs.setState({ available: true, root, repo: root, branchesLoaded: false, stashesLoaded: false });
|
||||
await refreshNow();
|
||||
const actionsModule = "/src/platform/actions.ts";
|
||||
const { executeAction } = await import(/* @vite-ignore */ actionsModule);
|
||||
void executeAction("vcs.push");
|
||||
},
|
||||
{ root: ROOT, outgoing, multi, subject: OUTGOING },
|
||||
);
|
||||
const dialog = page.getByRole("dialog", { name: /Push/ });
|
||||
const input = dialog.getByRole("combobox", { name: "Target branch" });
|
||||
const input = multi
|
||||
? dialog.getByRole("textbox", { name: "Target branch of acme-api" })
|
||||
: dialog.getByRole("combobox", { name: "Target branch" });
|
||||
await expect(input).toBeVisible();
|
||||
return { dialog, input };
|
||||
}
|
||||
@@ -127,3 +152,56 @@ test("Escape closes the list but keeps the dialog", async ({ workbench: page })
|
||||
await expect(page.getByRole("listbox", { name: "Remote branches" })).toHaveCount(0);
|
||||
await expect(dialog).toBeVisible();
|
||||
});
|
||||
|
||||
test("Push keeps commit subjects and changed files readable in a narrow window", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 1140, height: 760 });
|
||||
const { dialog, input } = await openPushDialog(page, { outgoing: true });
|
||||
const outgoing = dialog.getByRole("listbox", { name: "Outgoing commits" });
|
||||
const files = dialog.getByRole("tree", { name: "Changed files" });
|
||||
const commit = outgoing.getByRole("option", { name: new RegExp(OUTGOING) });
|
||||
await commit.click();
|
||||
await expect(files.getByText("checkout.ts")).toBeVisible();
|
||||
const filesBelowCommits = async () => {
|
||||
const [list, tree] = await Promise.all([outgoing.boundingBox(), files.boundingBox()]);
|
||||
return !!list && !!tree && tree.y >= list.y + list.height;
|
||||
};
|
||||
await expect.poll(filesBelowCommits).toBe(false);
|
||||
|
||||
await page.setViewportSize({ width: 540, height: 630 });
|
||||
await expect.poll(filesBelowCommits).toBe(true);
|
||||
await expect(commit).toHaveAttribute("aria-selected", "true");
|
||||
const subject = commit.getByText(OUTGOING, { exact: true });
|
||||
await expect(subject).toHaveAttribute("title", /Sam Rivera/);
|
||||
await expect.poll(() => subject.evaluate((el) => el.scrollWidth <= el.clientWidth)).toBe(true);
|
||||
await expect(input).toHaveValue("main");
|
||||
await expect(dialog.getByRole("button", { name: "Push", exact: true })).toBeInViewport();
|
||||
const details = dialog.getByRole("region", { name: "Commit details" });
|
||||
await expect(details).toContainText("Keep the new totals consistent with receipts.");
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const [tree, message] = await Promise.all([files.boundingBox(), details.boundingBox()]);
|
||||
return !!tree && !!message && message.y >= tree.y + tree.height;
|
||||
})
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
test("Push keeps per-repository targets editable with long source branches", async ({ workbench: page }) => {
|
||||
await page.setViewportSize({ width: 475, height: 620 });
|
||||
const { dialog, input } = await openPushDialog(page, { outgoing: true, multi: true });
|
||||
const other = dialog.getByRole("textbox", { name: "Target branch of billing-and-refunds" });
|
||||
for (const field of [input, other]) {
|
||||
await expect
|
||||
.poll(() =>
|
||||
field.evaluate((target) => {
|
||||
const row = target.closest('[role="treeitem"]')!.getBoundingClientRect();
|
||||
const bounds = target.getBoundingClientRect();
|
||||
return bounds.width >= 42 && bounds.left >= row.left && bounds.right <= row.right;
|
||||
}),
|
||||
)
|
||||
.toBe(true);
|
||||
}
|
||||
await input.fill("release/checkout");
|
||||
await expect(input).toHaveValue("release/checkout");
|
||||
await expect(other).toHaveValue(/^feature\//);
|
||||
await expect(dialog.getByRole("checkbox", { name: "acme-api" })).toBeChecked();
|
||||
});
|
||||
@@ -0,0 +1,73 @@
|
||||
import type { Page } from "@playwright/test";
|
||||
import { expect, openFromTree, stubDesktop, test } from "./fixtures";
|
||||
|
||||
async function quickDocumentation(page: Page, markdown: string) {
|
||||
const editor = await openFromTree(page, "build.gradle.kts");
|
||||
await stubDesktop(page);
|
||||
await page.evaluate((value) => {
|
||||
window.__ipc.handlers.lsp_hover = () => ({ contents: { kind: "markdown", value }, range: null });
|
||||
}, markdown);
|
||||
const line = editor.locator(".cm-line", { hasText: "return order.toDto()" });
|
||||
await line.click();
|
||||
await page.keyboard.press("End");
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await page.keyboard.press("ArrowLeft");
|
||||
await page.keyboard.press("F1");
|
||||
const popup = page.getByRole("dialog", { name: "Documentation", exact: true });
|
||||
await expect(popup.locator(".cm-lsp-markdown")).toBeVisible();
|
||||
return popup;
|
||||
}
|
||||
|
||||
test("short quick documentation uses a readable width and a compact corner of actions", async ({ workbench: page }) => {
|
||||
const popup = await quickDocumentation(page, "Returns the total.");
|
||||
const back = popup.getByRole("button", { name: "Back", exact: true });
|
||||
const dock = popup.getByRole("button", { name: "Show in Documentation Tool Window" });
|
||||
await expect(dock).toBeVisible();
|
||||
const bounds = (await popup.boundingBox())!;
|
||||
expect(bounds.width).toBeGreaterThanOrEqual(298);
|
||||
expect(bounds.width).toBeLessThan(320);
|
||||
const backBounds = (await back.boundingBox())!;
|
||||
const dockBounds = (await dock.boundingBox())!;
|
||||
expect(backBounds.x).toBeGreaterThan(bounds.x + bounds.width / 2);
|
||||
expect(bounds.x + bounds.width - dockBounds.x - dockBounds.width).toBeLessThan(16);
|
||||
await expect(popup.locator(".cm-lsp-markdown")).toHaveCSS("font-size", "13px");
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(popup).toBeHidden();
|
||||
});
|
||||
|
||||
test("long quick documentation scrolls with its actions in view", async ({ workbench: page }) => {
|
||||
const signature = "fun calculateTotal(order: Order, options: ExtendedPricingOptions): CalculationResult";
|
||||
const markdown = [
|
||||
`\`\`\`kotlin\n${signature}\n\`\`\``,
|
||||
...Array.from({ length: 22 }, (_, i) => {
|
||||
return `Section ${i + 1}. Explains the applicable pricing rules, shipping restrictions and currency options.`;
|
||||
}),
|
||||
"End of pricing documentation.",
|
||||
].join("\n\n");
|
||||
const popup = await quickDocumentation(page, markdown);
|
||||
const dock = popup.getByRole("button", { name: "Show in Documentation Tool Window" });
|
||||
await expect(dock).toBeVisible();
|
||||
expect((await popup.boundingBox())!.width).toBeLessThan(508);
|
||||
await page.setViewportSize({ width: 430, height: 500 });
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const box = (await popup.boundingBox())!;
|
||||
return Math.max(-box.x, -box.y, box.x + box.width - 430, box.y + box.height - 500);
|
||||
})
|
||||
.toBeLessThanOrEqual(1);
|
||||
const body = popup.locator(".cm-lsp-markdown").locator("..");
|
||||
const last = popup.getByText("End of pricing documentation.");
|
||||
const dockBefore = (await dock.boundingBox())!;
|
||||
await expect(body.locator("pre")).toContainText(signature);
|
||||
const scroll = await body.evaluate((node) => {
|
||||
node.scrollTop = node.scrollHeight;
|
||||
return { top: node.scrollTop, horizontalOverflow: node.scrollWidth - node.clientWidth };
|
||||
});
|
||||
expect(scroll.top).toBeGreaterThan(0);
|
||||
expect(scroll.horizontalOverflow).toBeLessThanOrEqual(1);
|
||||
const lastBounds = (await last.boundingBox())!;
|
||||
expect(lastBounds.y + lastBounds.height).toBeLessThanOrEqual(dockBefore.y + 1);
|
||||
expect(await dock.boundingBox()).toEqual(dockBefore);
|
||||
await expect(dock).toBeInViewport();
|
||||
});
|
||||
+76
-3
@@ -3,15 +3,21 @@
|
||||
* the process. Processes are stubbed at the IPC layer; `crates/ide-run` covers spawning them.
|
||||
*/
|
||||
import type { Page } from "@playwright/test";
|
||||
import type { RunConfig } from "../src/bindings";
|
||||
import { expect, ipcCalls, stubDesktop, test } from "./fixtures";
|
||||
|
||||
const RUN_ID = 7;
|
||||
|
||||
/** One saved `npm run dev` configuration; `run_start` prints `output` and exits with `exit` unless null. */
|
||||
async function stubRun(page: Page, output: { kind: string; text: string }[], exit: number | null) {
|
||||
async function stubRun(
|
||||
page: Page,
|
||||
output: { kind: string; text: string }[],
|
||||
exit: number | null,
|
||||
overrides: Partial<RunConfig> = {},
|
||||
) {
|
||||
await stubDesktop(page);
|
||||
await page.evaluate(
|
||||
async ({ output, exit, runId }) => {
|
||||
async ({ output, exit, runId, overrides }) => {
|
||||
const config = {
|
||||
id: "npm:dev",
|
||||
name: "dev",
|
||||
@@ -23,6 +29,7 @@ async function stubRun(page: Page, output: { kind: string; text: string }[], exi
|
||||
detected: false,
|
||||
isTest: false,
|
||||
debugAdapter: null,
|
||||
...overrides,
|
||||
};
|
||||
const h = window.__ipc.handlers;
|
||||
h.run_configs = () => [config];
|
||||
@@ -43,7 +50,7 @@ async function stubRun(page: Page, output: { kind: string; text: string }[], exi
|
||||
await loadConfigs();
|
||||
selectConfig(config.id);
|
||||
},
|
||||
{ output, exit, runId: RUN_ID },
|
||||
{ output, exit, runId: RUN_ID, overrides },
|
||||
);
|
||||
}
|
||||
|
||||
@@ -177,6 +184,72 @@ test("Go reruns keep each package's exact failures and the original configuratio
|
||||
]);
|
||||
});
|
||||
|
||||
test("test results keep counts, actions and selected output visible as the pane narrows", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
await page.setViewportSize({ width: 1060, height: 740 });
|
||||
const goPackage = "example.com/checkout";
|
||||
const name = "TestCheckoutTotalsWithDiscountsAndPendingInventoryReservations";
|
||||
const message = "expected subtotal 42, got 37";
|
||||
const records = [
|
||||
{ Action: "run", Test: name },
|
||||
{ Action: "output", Test: name, Output: message + "\n" },
|
||||
{ Action: "fail", Test: name, Elapsed: 0.125 },
|
||||
{ Action: "pass", Test: "TestPayment", Elapsed: 0.02 },
|
||||
{ Action: "skip", Test: "TestDelayedShipping" },
|
||||
{ Action: "fail", Elapsed: 0.17 },
|
||||
];
|
||||
await stubRun(
|
||||
page,
|
||||
records.map((record) => ({ kind: "stdout", text: JSON.stringify({ Package: goPackage, ...record }) + "\n" })),
|
||||
1,
|
||||
{
|
||||
id: "go:checkout-tests",
|
||||
name: "Checkout tests",
|
||||
kind: "go",
|
||||
command: "go",
|
||||
args: ["test", "-json"],
|
||||
isTest: true,
|
||||
},
|
||||
);
|
||||
await page.keyboard.press("Control+r");
|
||||
const run = page.getByRole("region", { name: "Run", exact: true });
|
||||
const tree = run.getByRole("tree", { name: "Test results" });
|
||||
const row = tree.getByRole("treeitem", { name: new RegExp(name) });
|
||||
await row.click();
|
||||
const output = run.getByRole("log");
|
||||
await expect(output).toContainText(message);
|
||||
await expect.poll(async () => (await output.boundingBox())!.x > (await tree.boundingBox())!.x).toBe(true);
|
||||
await page.setViewportSize({ width: 540, height: 740 });
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const [list, console] = await Promise.all([tree.boundingBox(), output.boundingBox()]);
|
||||
return !!list && !!console && console.y >= list.y + list.height - 1;
|
||||
})
|
||||
.toBe(true);
|
||||
const summary = run.getByRole("status").filter({ hasText: "1 failing" });
|
||||
for (const count of ["1 failing", "1 passed", "1 ignored"]) await expect(summary.getByText(count)).toBeVisible();
|
||||
await expect(row).toHaveAttribute("aria-selected", "true");
|
||||
await expect(row.getByText("125 ms")).toBeVisible();
|
||||
await expect(output).toContainText(message);
|
||||
const toolbar = run.getByRole("toolbar", { name: "Test results" });
|
||||
await toolbar.getByRole("button", { name: "More Actions" }).click();
|
||||
await expect(page.getByRole("menuitem", { name: "Collapse All" })).toBeVisible();
|
||||
await expect(page.getByRole("menuitem", { name: "Export Test Results…" })).toBeVisible();
|
||||
await page.keyboard.press("Escape");
|
||||
const divider = run.getByRole("separator");
|
||||
const treeHeight = async () => (await tree.boundingBox())!.height;
|
||||
const beforeResize = await treeHeight();
|
||||
await divider.press("ArrowDown");
|
||||
await expect.poll(treeHeight).toBeGreaterThan(beforeResize + 1);
|
||||
const customizedHeight = await treeHeight();
|
||||
await page.setViewportSize({ width: 1060, height: 740 });
|
||||
await expect.poll(async () => (await output.boundingBox())!.x > (await tree.boundingBox())!.x).toBe(true);
|
||||
await page.setViewportSize({ width: 540, height: 740 });
|
||||
await expect.poll(async () => Math.abs((await treeHeight()) - customizedHeight)).toBeLessThan(2);
|
||||
await expect(output).toContainText(message);
|
||||
});
|
||||
|
||||
test("CMake builds the selected target in Build before starting only the application in Run", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
|
||||
@@ -0,0 +1,79 @@
|
||||
import { expect, test } from "./fixtures";
|
||||
|
||||
test("Run Anything keeps its command field and shortcuts visible as its results scroll", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
await page.setViewportSize({ width: 1080, height: 740 });
|
||||
await page.evaluate(async () => {
|
||||
const projectModule = "/src/platform/project.ts";
|
||||
const contributionsModule = "/src/workbench/contributions.ts";
|
||||
const historyModule = "/src/features/run-anything/model.ts";
|
||||
const [{ useProject }, { registerRunAnythingProvider }, { pushHistory }] = await Promise.all([
|
||||
import(/* @vite-ignore */ projectModule),
|
||||
import(/* @vite-ignore */ contributionsModule),
|
||||
import(/* @vite-ignore */ historyModule),
|
||||
]);
|
||||
const root = useProject.getState().project.root;
|
||||
for (const command of ["git status", "git diff --stat", "pnpm lint", "pnpm test"]) pushHistory(root, command);
|
||||
const tasks = Array.from({ length: 8 }, (_, i) => {
|
||||
const command = `npm run verify-${i + 1}`;
|
||||
return {
|
||||
key: command,
|
||||
label: `Verify checkout configuration ${i + 1}`,
|
||||
detail: "checkout-service / workspace verification",
|
||||
completion: command,
|
||||
run: () => {
|
||||
document.body.dataset.runAnythingCommand = command;
|
||||
},
|
||||
};
|
||||
});
|
||||
registerRunAnythingProvider({
|
||||
id: "test-verify",
|
||||
order: -100,
|
||||
group: "Run Configurations",
|
||||
items: (line: string) => tasks.filter((task) => task.completion.includes(line)),
|
||||
});
|
||||
});
|
||||
await page.keyboard.press("Control");
|
||||
await page.keyboard.press("Control");
|
||||
|
||||
const popup = page.getByRole("dialog", { name: "Run Anything", exact: true });
|
||||
const field = popup.getByLabel("Command line", { exact: true });
|
||||
const results = popup.getByRole("listbox", { name: "Run Anything entries" });
|
||||
const hint = popup.getByText(/Enter to run, Tab to complete|Tab to complete, Enter to run/);
|
||||
await expect(field).toBeFocused();
|
||||
await page.setViewportSize({ width: 560, height: 340 });
|
||||
await expect
|
||||
.poll(async () => {
|
||||
const [shell, footer] = await Promise.all([popup.boundingBox(), hint.boundingBox()]);
|
||||
return (
|
||||
!!shell &&
|
||||
!!footer &&
|
||||
Math.abs(shell.x - (560 - shell.width) / 2) < 2 &&
|
||||
shell.x >= 14 &&
|
||||
footer.y + footer.height <= shell.y + shell.height + 1
|
||||
);
|
||||
})
|
||||
.toBe(true);
|
||||
await expect.poll(() => results.evaluate((el) => el.scrollHeight > el.clientHeight)).toBe(true);
|
||||
|
||||
await field.fill("verify");
|
||||
await field.press("ArrowDown");
|
||||
await expect(field).toHaveValue("npm run verify-1");
|
||||
const selected = results.getByRole("option", { selected: true });
|
||||
await expect(selected).toContainText("Verify checkout configuration 1");
|
||||
await expect(field).toHaveAttribute("aria-activedescendant", (await selected.getAttribute("id"))!);
|
||||
await field.press("Tab");
|
||||
await expect(field).toHaveValue("npm run verify-1");
|
||||
await expect(field).toBeFocused();
|
||||
await field.press("Shift+Tab");
|
||||
const history = popup.getByRole("button", { name: "Clear History" });
|
||||
await expect(history).toBeFocused();
|
||||
await history.press("Enter");
|
||||
await expect(history).toBeHidden();
|
||||
await expect(field).toBeFocused();
|
||||
await field.press("ArrowDown");
|
||||
await field.press("Enter");
|
||||
await expect(popup).toBeHidden();
|
||||
await expect(page.locator("body")).toHaveAttribute("data-run-anything-command", "npm run verify-1");
|
||||
});
|
||||
@@ -1,8 +1,8 @@
|
||||
import type { Page } from "@playwright/test";
|
||||
import { expect, test } from "./fixtures";
|
||||
|
||||
async function openConfigurations(page: Page) {
|
||||
await page.evaluate(async () => {
|
||||
async function openConfigurations(page: Page, target?: string) {
|
||||
await page.evaluate(async (target) => {
|
||||
const path = "/src/features/run/store.ts";
|
||||
const { useRun } = await import(/* @vite-ignore */ path);
|
||||
const base = {
|
||||
@@ -21,6 +21,7 @@ async function openConfigurations(page: Page) {
|
||||
...base,
|
||||
id: "layout:app",
|
||||
name: "Payments development server",
|
||||
target,
|
||||
beforeLaunch: [{ kind: "run", target: "layout:prepare" }],
|
||||
},
|
||||
{ ...base, id: "layout:prepare", name: "Prepare generated sources for the payments development server" },
|
||||
@@ -29,10 +30,31 @@ async function openConfigurations(page: Page) {
|
||||
loaded: true,
|
||||
editorOpen: true,
|
||||
});
|
||||
});
|
||||
}, target);
|
||||
await expect(page.getByRole("dialog", { name: "Run/Debug Configurations", exact: true })).toBeVisible();
|
||||
}
|
||||
|
||||
test("long run target names leave room for configuration names in the sidebar", async ({ workbench: page }) => {
|
||||
const target = "payments-development-shared-staging-runner-west";
|
||||
await openConfigurations(page, target);
|
||||
const dialog = page.getByRole("dialog", { name: "Run/Debug Configurations", exact: true });
|
||||
const tree = dialog.getByRole("tree", { name: "Run configurations", exact: true });
|
||||
const row = tree.getByRole("treeitem", { name: /^Payments development server/ });
|
||||
const name = row.getByText("Payments development server", { exact: true });
|
||||
const badge = row.getByText(`@ ${target}`, { exact: true });
|
||||
await expect(badge).toBeVisible();
|
||||
|
||||
for (const width of [1100, 520]) {
|
||||
await page.setViewportSize({ width, height: 820 });
|
||||
await expect.poll(async () => (await name.boundingBox())!.width).toBeGreaterThan(width === 1100 ? 80 : 50);
|
||||
await expect.poll(() => tree.evaluate((el) => el.scrollWidth - el.clientWidth)).toBeLessThanOrEqual(1);
|
||||
}
|
||||
|
||||
await expect(badge).toBeHidden();
|
||||
await expect(row).toHaveAttribute("title", new RegExp(`Payments development server @ ${target}`));
|
||||
await expect(dialog.getByRole("textbox", { name: "Name", exact: true })).toHaveValue("Payments development server");
|
||||
});
|
||||
|
||||
test("run configuration sidebar resizes with mouse and keyboard and remembers the layout", async ({
|
||||
workbench: page,
|
||||
}) => {
|
||||
|
||||
+8
-4
@@ -1,3 +1,4 @@
|
||||
import type { SearchQuery } from "../src/bindings";
|
||||
import { doubleShift, expect, ipcCalls, openFromTree, stubDesktop, test } from "./fixtures";
|
||||
|
||||
test("double Shift opens Search Everywhere with its tabs; Escape closes it", async ({ workbench: page }) => {
|
||||
@@ -100,11 +101,14 @@ test("Find in Files streams matches by file and opens the chosen one at its line
|
||||
await expect
|
||||
.poll(
|
||||
async () =>
|
||||
(await ipcCalls(page, "search_start")).filter((c) => !/\bTODO\b/.test(c.query?.pattern ?? "")).at(-1)?.query,
|
||||
(await ipcCalls(page, "search_start"))
|
||||
.filter(({ query }) => {
|
||||
const pattern = query && typeof query === "object" && "pattern" in query ? query.pattern : undefined;
|
||||
return typeof pattern !== "string" || !/\bTODO\b/.test(pattern);
|
||||
})
|
||||
.at(-1)?.query,
|
||||
)
|
||||
.toMatchObject({
|
||||
pattern: "OrderService",
|
||||
});
|
||||
.toMatchObject({ pattern: "OrderService" } satisfies Pick<SearchQuery, "pattern">);
|
||||
const preview = dialog.getByRole("region", { name: "Preview", exact: true }).locator(".cm-content");
|
||||
await expect(preview).toHaveAttribute("contenteditable", "true");
|
||||
// Matches take the editor scheme's search result background (IDEA's SEARCH_RESULT_ATTRIBUTES) and keep the syntax colours.
|
||||
|
||||
@@ -79,7 +79,7 @@ test.describe("search popups at the minimum window width", () => {
|
||||
[400, 500],
|
||||
[600, 700],
|
||||
[1120, 750],
|
||||
]) {
|
||||
] as const) {
|
||||
await page.setViewportSize({ width, height });
|
||||
await expectControlsFit(page);
|
||||
// Room enough for the title and the reporter's count: shown whole, on one line.
|
||||
|
||||
@@ -9,9 +9,9 @@ test("semantic roles honor all Color Scheme attributes and keep modifier styles"
|
||||
[".cm-sem-function:not(.cm-sem-static)", "rgb(102, 136, 170)"],
|
||||
[".cm-sem-parameter", "rgb(119, 153, 187)"],
|
||||
[".cm-sem-constant", "rgb(136, 170, 204)"],
|
||||
]) {
|
||||
] as const) {
|
||||
const role = page.locator(selector);
|
||||
await expect(role).toHaveCSS("color", color!);
|
||||
await expect(role).toHaveCSS("color", color);
|
||||
await expect(role).toHaveCSS("background-color", "rgb(221, 238, 255)");
|
||||
}
|
||||
await expect(page.locator(".cm-sem-namespace")).toHaveCSS("font-style", "italic");
|
||||
|
||||
@@ -6,7 +6,7 @@ for (const [id, selector] of [
|
||||
["languages.servers", "[class*='body'] > [class*='language'][aria-label]"],
|
||||
["plugins", "[class*='body'] > [class*='details']"],
|
||||
["agents.list", "section[aria-label='Codex']"],
|
||||
]) {
|
||||
] as const) {
|
||||
test(`${id} keeps its details usable beside the list`, async ({ workbench: page }) => {
|
||||
await page.keyboard.press("Meta+,");
|
||||
const dialog = page.getByRole("dialog", { name: "Settings", exact: true });
|
||||
|
||||
+4
-8
@@ -1,12 +1,8 @@
|
||||
{
|
||||
"extends": "../tsconfig.json",
|
||||
"compilerOptions": {
|
||||
"target": "ES2022",
|
||||
"module": "ESNext",
|
||||
"moduleResolution": "bundler",
|
||||
"strict": true,
|
||||
"noEmit": true,
|
||||
"skipLibCheck": true,
|
||||
"types": ["node"]
|
||||
"lib": ["ES2024", "DOM", "DOM.Iterable"],
|
||||
"types": ["node", "vite/client"]
|
||||
},
|
||||
"include": ["./**/*.ts", "../playwright.config.ts"]
|
||||
"include": [".", "../playwright.config.ts", "../src/**/*.d.ts"]
|
||||
}
|
||||
+1
-1
@@ -17,7 +17,7 @@
|
||||
"format": "oxfmt",
|
||||
"format:check": "oxfmt --check",
|
||||
"knip": "knip",
|
||||
"typecheck": "tsrs --noEmit && tsrs -p tsconfig.node.json --noEmit && tsrs -p perf --noEmit && tsrs -p evals --noEmit && tsrs -p scripts --noEmit && tsrs -p smoke --noEmit",
|
||||
"typecheck": "tsrs --noEmit && tsrs -p tsconfig.node.json --noEmit && tsrs -p perf --noEmit && tsrs -p evals --noEmit && tsrs -p scripts --noEmit && tsrs -p smoke --noEmit && tsrs -p e2e --noEmit",
|
||||
"gen:bindings": "cargo test -p openidea --test export_bindings",
|
||||
"gen:windows-icons": "node scripts/gen-windows-icons.ts",
|
||||
"gen:angular-grammar": "lezer-generator src/editor/core/cm/angular/angular.grammar --typeScript -o src/editor/core/cm/angular/parser.ts",
|
||||
|
||||
@@ -47,7 +47,7 @@ import { useDistractionFree } from "@/workbench/distractionFree";
|
||||
import { restoreMaximizedToolWindow } from "@/workbench/toolwindows/store";
|
||||
import { ask, confirm } from "@/workbench/messages";
|
||||
import { t, tx } from "@/platform/i18n";
|
||||
import { call, commands, isTauri } from "@/platform/ipc";
|
||||
import { call, commands, isErrorKind, isTauri } from "@/platform/ipc";
|
||||
import { openLightweightEditor } from "./openLightweightEditor";
|
||||
import { windowBackgroundHex } from "@/workbench/theme";
|
||||
import { hoverActionsAt } from "@/platform/hoverActions";
|
||||
@@ -736,7 +736,7 @@ export class EditorController implements SlotHost {
|
||||
return this.slots.get(tabId) ?? this.createSlot(tabId, m, init);
|
||||
})
|
||||
.catch((e: unknown) => {
|
||||
if (this.restoredTabs.has(tabId) && (e as { kind?: string } | null)?.kind === "notFound") {
|
||||
if (this.restoredTabs.has(tabId) && isErrorKind(e, "notFound")) {
|
||||
// A file from the saved session no longer exists: drop its tab quietly.
|
||||
this.restoredTabs.delete(tabId);
|
||||
this.restoredViews.delete(path);
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
import { ChangeSet, Text } from "@codemirror/state";
|
||||
import type { TextChange } from "@/platform/ipc";
|
||||
import type { IdeError, TextChange } from "@/platform/ipc";
|
||||
import { DocSync, toTextChanges } from "./DocSync";
|
||||
import { minimalChanges } from "./diff";
|
||||
|
||||
@@ -19,7 +19,7 @@ function numberedLines(count: number) {
|
||||
}
|
||||
|
||||
class OutOfSync extends Error {
|
||||
kind = "outOfSync";
|
||||
readonly kind: IdeError["kind"] = "outOfSync";
|
||||
}
|
||||
|
||||
/** Backend double: requests are queued and processed explicitly, in order. */
|
||||
|
||||
@@ -25,7 +25,7 @@
|
||||
* the snapshot, selections mapped).
|
||||
*/
|
||||
import { ChangeSet, Text } from "@codemirror/state";
|
||||
import type { TextChange } from "@/platform/ipc";
|
||||
import { isErrorKind, type TextChange } from "@/platform/ipc";
|
||||
import { minimalChanges } from "./diff";
|
||||
|
||||
export interface SyncTransport {
|
||||
@@ -64,10 +64,6 @@ export const frameScheduler: Scheduler = (fn) => {
|
||||
setTimeout(once, 50);
|
||||
};
|
||||
|
||||
function isOutOfSync(e: unknown): boolean {
|
||||
return typeof e === "object" && e !== null && (e as { kind?: string }).kind === "outOfSync";
|
||||
}
|
||||
|
||||
export function toTextChanges(cs: ChangeSet): TextChange[] {
|
||||
const out: TextChange[] = [];
|
||||
cs.iterChanges((fromA, toA, _fromB, _toB, inserted) => {
|
||||
@@ -210,7 +206,7 @@ export class DocSync {
|
||||
}
|
||||
|
||||
private onReject(error: unknown) {
|
||||
if (!isOutOfSync(error)) {
|
||||
if (!isErrorKind(error, "outOfSync")) {
|
||||
this.host.onError?.(error);
|
||||
this.hardResync(error);
|
||||
return;
|
||||
|
||||
@@ -151,52 +151,126 @@
|
||||
}
|
||||
|
||||
/* Find / replace bar */
|
||||
.find {
|
||||
.findContainer {
|
||||
flex: none;
|
||||
display: grid;
|
||||
grid-template-columns: minmax(220px, 420px) auto 1fr;
|
||||
align-items: center;
|
||||
column-gap: var(--space-1-5);
|
||||
row-gap: var(--space-1-5);
|
||||
padding: 6px 8px 6px 10px;
|
||||
min-width: 0;
|
||||
container: editor-find / inline-size;
|
||||
background: var(--bg-editor-inline, var(--bg-elev));
|
||||
border-bottom: 1px solid var(--border-editor-tabs, var(--border));
|
||||
}
|
||||
.findExpandable {
|
||||
grid-template-columns: auto minmax(220px, 420px) auto 1fr;
|
||||
.find {
|
||||
display: grid;
|
||||
grid-template-columns: [mode] auto [field] minmax(0, 420px) [actions] fit-content(50%) [close] minmax(
|
||||
min-content,
|
||||
1fr
|
||||
);
|
||||
align-items: start;
|
||||
row-gap: var(--space-1);
|
||||
padding: var(--space-1-5) var(--space-2);
|
||||
}
|
||||
.findExpand {
|
||||
grid-column: 1;
|
||||
grid-row: 1;
|
||||
}
|
||||
.findExpandable .findField {
|
||||
grid-column: 2;
|
||||
grid-area: 1 / mode;
|
||||
margin-inline-end: var(--space-1);
|
||||
}
|
||||
.findField {
|
||||
grid-area: 1 / field;
|
||||
}
|
||||
.replaceField {
|
||||
grid-area: 2 / field;
|
||||
}
|
||||
.findField,
|
||||
.replaceField {
|
||||
min-width: 0;
|
||||
}
|
||||
.findButtons {
|
||||
.findClose {
|
||||
grid-area: 1 / close;
|
||||
justify-self: end;
|
||||
margin-inline-start: var(--space-1);
|
||||
}
|
||||
.findExpand,
|
||||
.findClose {
|
||||
margin-block-start: var(--space-1);
|
||||
}
|
||||
.findButtons,
|
||||
.replaceButtons {
|
||||
display: flex;
|
||||
flex-wrap: wrap;
|
||||
align-items: center;
|
||||
min-width: 0;
|
||||
min-height: var(--h-field);
|
||||
margin-inline-start: var(--space-1-5);
|
||||
}
|
||||
.findButtons {
|
||||
grid-area: 1 / actions;
|
||||
gap: var(--space-0-5);
|
||||
}
|
||||
.replaceButtons {
|
||||
grid-area: 2 / actions;
|
||||
gap: var(--space-1);
|
||||
}
|
||||
.findCount {
|
||||
font-size: var(--fs-ui);
|
||||
min-inline-size: 5ch;
|
||||
padding-inline: var(--space-1);
|
||||
font-size: var(--fs-small);
|
||||
font-variant-numeric: tabular-nums;
|
||||
color: var(--fg-subtle);
|
||||
padding: 0 8px 0 4px;
|
||||
min-width: 56px;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.findCountNone {
|
||||
color: var(--danger);
|
||||
}
|
||||
.findClose {
|
||||
justify-self: end;
|
||||
|
||||
@container editor-find (width < 500px) {
|
||||
.find {
|
||||
grid-template-columns: [mode] auto [field] minmax(0, 1fr) [close] auto;
|
||||
}
|
||||
.findButtons,
|
||||
.replaceButtons {
|
||||
grid-column: field / -1;
|
||||
min-height: 0;
|
||||
margin-inline-start: 0;
|
||||
}
|
||||
.findButtons {
|
||||
grid-row: 2;
|
||||
}
|
||||
.replaceField {
|
||||
grid-row: 3;
|
||||
}
|
||||
.replaceButtons {
|
||||
grid-row: 4;
|
||||
}
|
||||
.replaceButtons > button {
|
||||
max-width: 100%;
|
||||
height: auto;
|
||||
min-height: var(--h-control);
|
||||
white-space: normal;
|
||||
overflow-wrap: anywhere;
|
||||
}
|
||||
}
|
||||
.replaceButtons {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-1-5);
|
||||
|
||||
@container editor-find (width < 224px) {
|
||||
.findField,
|
||||
.replaceField,
|
||||
.replaceButtons {
|
||||
grid-column: mode / -1;
|
||||
}
|
||||
.findExpand,
|
||||
.findClose {
|
||||
grid-row: 2;
|
||||
margin-block-start: 0;
|
||||
}
|
||||
.findButtons {
|
||||
grid-column: field;
|
||||
}
|
||||
.findInput {
|
||||
display: grid;
|
||||
grid-template-columns: repeat(auto-fill, minmax(20px, 1fr));
|
||||
height: auto;
|
||||
padding-block: var(--space-1);
|
||||
}
|
||||
.findInput textarea {
|
||||
grid-column: 2 / -1;
|
||||
}
|
||||
}
|
||||
|
||||
/* Go to line */
|
||||
@@ -218,15 +292,44 @@
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
}
|
||||
.crumbButton {
|
||||
flex: none;
|
||||
max-width: 240px;
|
||||
gap: 5px;
|
||||
color: var(--fg);
|
||||
}
|
||||
.crumbButton:last-child {
|
||||
flex: 0 1 auto;
|
||||
.crumbStrip {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
min-width: 0;
|
||||
overflow-x: auto;
|
||||
overflow-y: hidden;
|
||||
scrollbar-width: none;
|
||||
}
|
||||
.crumbStrip::-webkit-scrollbar {
|
||||
display: none;
|
||||
}
|
||||
.crumbStrip:is([data-crumbs-before], [data-crumbs-after]) {
|
||||
--crumb-mask: linear-gradient(
|
||||
to right,
|
||||
var(--crumb-start, black),
|
||||
black var(--space-3),
|
||||
black calc(100% - var(--space-3)),
|
||||
var(--crumb-end, black)
|
||||
);
|
||||
-webkit-mask-image: var(--crumb-mask);
|
||||
mask-image: var(--crumb-mask);
|
||||
}
|
||||
.crumbStrip[data-crumbs-before] {
|
||||
--crumb-start: transparent;
|
||||
}
|
||||
.crumbStrip[data-crumbs-after] {
|
||||
--crumb-end: transparent;
|
||||
}
|
||||
.crumbStrip .crumbButton {
|
||||
flex: none;
|
||||
max-width: min(240px, 100%);
|
||||
margin: 0;
|
||||
padding: 0 var(--space-1);
|
||||
font: inherit;
|
||||
color: inherit;
|
||||
}
|
||||
.crumbStrip .crumbButton[aria-current="location"] {
|
||||
color: var(--fg);
|
||||
}
|
||||
.crumbIcon {
|
||||
flex: none;
|
||||
@@ -240,7 +343,6 @@
|
||||
.statusSep {
|
||||
flex: none;
|
||||
color: var(--fg-faint);
|
||||
margin: 0 2px;
|
||||
}
|
||||
.lock {
|
||||
display: inline-flex;
|
||||
@@ -339,13 +441,23 @@
|
||||
flex: none;
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-0-5);
|
||||
height: 26px;
|
||||
padding: 0 8px;
|
||||
height: max(24px, calc(1em + var(--space-2)));
|
||||
padding: 0 var(--space-2);
|
||||
overflow: hidden;
|
||||
background: var(--bg-editor, var(--bg-island));
|
||||
color: var(--fg-muted);
|
||||
font-size: var(--fs-small);
|
||||
font-family: var(--font-mono);
|
||||
font-size: var(--fs-code);
|
||||
}
|
||||
.codeCrumbs .crumbStrip {
|
||||
gap: var(--space-0-5);
|
||||
}
|
||||
.codeCrumbs .crumbButton {
|
||||
height: max(20px, calc(1em + var(--space-1)));
|
||||
max-width: 100%;
|
||||
}
|
||||
.codeCrumbs .crumbButton[aria-current="location"] {
|
||||
background: var(--bg-tree-selected-inactive);
|
||||
}
|
||||
.codeCrumbsTop {
|
||||
border-bottom: 1px solid var(--border-editor-tabs, var(--border));
|
||||
|
||||
+176
-173
@@ -608,182 +608,185 @@ export function FindPanel({ target, version, replace, seq, onReplaceShown, onClo
|
||||
const canReplace = !!opts.search && !invalid;
|
||||
|
||||
return (
|
||||
<div
|
||||
ref={panelRef}
|
||||
onFocusCapture={() => {
|
||||
focusedTarget = target;
|
||||
setContext("findBarFocus", true);
|
||||
setContext(
|
||||
"findBarHasResults",
|
||||
!!target.results && !!opts.search && (!opts.regexp || regexValid(opts.search)) && !!count?.total,
|
||||
);
|
||||
}}
|
||||
onBlurCapture={(e) => {
|
||||
if (!panelRef.current?.contains(e.relatedTarget as Node | null)) setContext("findBarFocus", false);
|
||||
}}
|
||||
className={clsx(styles.find, onReplaceShown && styles.findExpandable)}
|
||||
role="search"
|
||||
aria-label={replace ? "Replace in file" : "Find in file"}
|
||||
>
|
||||
{onReplaceShown && (
|
||||
<IconButton
|
||||
icon={replace ? "chevron-down" : "chevron-right"}
|
||||
title={replace ? "Hide Replace" : "Show Replace"}
|
||||
size="small"
|
||||
className={styles.findExpand}
|
||||
aria-expanded={replace}
|
||||
onMouseDown={(e) => e.preventDefault()}
|
||||
onClick={() => {
|
||||
if (replaceBoxRef.current?.contains(document.activeElement)) inputRef.current?.focus();
|
||||
onReplaceShown(!replace);
|
||||
}}
|
||||
<div className={styles.findContainer}>
|
||||
<div
|
||||
ref={panelRef}
|
||||
onFocusCapture={() => {
|
||||
focusedTarget = target;
|
||||
setContext("findBarFocus", true);
|
||||
setContext(
|
||||
"findBarHasResults",
|
||||
!!target.results && !!opts.search && (!opts.regexp || regexValid(opts.search)) && !!count?.total,
|
||||
);
|
||||
}}
|
||||
onBlurCapture={(e) => {
|
||||
if (!panelRef.current?.contains(e.relatedTarget as Node | null)) setContext("findBarFocus", false);
|
||||
}}
|
||||
className={styles.find}
|
||||
role="search"
|
||||
aria-label={replace ? "Replace in file" : "Find in file"}
|
||||
>
|
||||
{onReplaceShown && (
|
||||
<IconButton
|
||||
icon={replace ? "chevron-down" : "chevron-right"}
|
||||
title={replace ? "Hide Replace" : "Show Replace"}
|
||||
size="small"
|
||||
className={styles.findExpand}
|
||||
aria-expanded={replace}
|
||||
onMouseDown={(e) => e.preventDefault()}
|
||||
onClick={() => {
|
||||
if (replaceBoxRef.current?.contains(document.activeElement)) inputRef.current?.focus();
|
||||
onReplaceShown(!replace);
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
<div ref={findBoxRef} className={styles.findField}>
|
||||
<SearchField
|
||||
ref={inputRef}
|
||||
value={opts.search}
|
||||
onChange={(search) => setOpts({ search })}
|
||||
placeholder="Find"
|
||||
aria-label="Find"
|
||||
invalid={invalid || none}
|
||||
multiline
|
||||
onHistory={() => setHistoryMenu("find")}
|
||||
onKeyDown={(e) => onKeyDown(e, "find")}
|
||||
className={styles.findInput}
|
||||
toggles={[
|
||||
{
|
||||
id: "case",
|
||||
icon: "case",
|
||||
title: "Match Case",
|
||||
shortcut: formatBinding("Alt+C"),
|
||||
pressed: opts.caseSensitive,
|
||||
onToggle: () => toggle("caseSensitive"),
|
||||
},
|
||||
{
|
||||
id: "word",
|
||||
icon: "word",
|
||||
title: "Words",
|
||||
shortcut: formatBinding("Alt+W"),
|
||||
pressed: opts.wholeWord,
|
||||
onToggle: () => toggle("wholeWord"),
|
||||
},
|
||||
{
|
||||
id: "regex",
|
||||
icon: "regex",
|
||||
title: "Regex",
|
||||
shortcut: formatBinding("Alt+X"),
|
||||
pressed: opts.regexp,
|
||||
onToggle: () => toggle("regexp"),
|
||||
},
|
||||
]}
|
||||
/>
|
||||
</div>
|
||||
<div className={styles.findButtons}>
|
||||
<span className={clsx(styles.findCount, (none || invalid) && styles.findCountNone)} aria-live="polite">
|
||||
{counter}
|
||||
</span>
|
||||
<IconButton
|
||||
icon="arrow-up"
|
||||
title="Previous Occurrence"
|
||||
shortcut={formatBinding("Shift+Enter")}
|
||||
size="small"
|
||||
onClick={() => run(findPrevious)}
|
||||
/>
|
||||
<IconButton
|
||||
icon="arrow-down"
|
||||
title="Next Occurrence"
|
||||
shortcut={formatBinding("Enter")}
|
||||
size="small"
|
||||
onClick={() => run(findNext)}
|
||||
/>
|
||||
<IconButton
|
||||
ref={filterRef}
|
||||
icon="filter"
|
||||
title="Filter Search Results"
|
||||
size="small"
|
||||
pressed={scoped || inChanges || opts.context !== "any"}
|
||||
onClick={() => setFilterMenu(true)}
|
||||
/>
|
||||
<IconButton ref={moreRef} icon="more" title="More" size="small" onClick={() => setMoreMenu(true)} />
|
||||
</div>
|
||||
<IconButton icon="close" title="Close" shortcut="⎋" size="small" className={styles.findClose} onClick={close} />
|
||||
{replace && (
|
||||
<>
|
||||
<div ref={replaceBoxRef} className={styles.replaceField}>
|
||||
<SearchField
|
||||
ref={replaceRef}
|
||||
value={opts.replace}
|
||||
onChange={(value) => setOpts({ replace: value })}
|
||||
placeholder="Replace"
|
||||
aria-label="Replace"
|
||||
multiline
|
||||
onHistory={() => setHistoryMenu("replace")}
|
||||
onKeyDown={(e) => onKeyDown(e, "replace")}
|
||||
toggles={[
|
||||
{
|
||||
id: "preserveCase",
|
||||
icon: "preserve-case",
|
||||
title: "Preserve Case",
|
||||
pressed: opts.preserveCase,
|
||||
onToggle: () => toggle("preserveCase"),
|
||||
},
|
||||
]}
|
||||
/>
|
||||
</div>
|
||||
<div className={styles.replaceButtons}>
|
||||
<Button
|
||||
size="small"
|
||||
title={tx`Replace (${formatBinding("Alt+P")})`}
|
||||
onClick={doReplace}
|
||||
disabled={!canReplace}
|
||||
>
|
||||
<T>Replace</T>
|
||||
</Button>
|
||||
<Button
|
||||
size="small"
|
||||
title={tx`Replace All (${formatBinding("Alt+A")})`}
|
||||
onClick={doReplaceAll}
|
||||
disabled={!canReplace}
|
||||
>
|
||||
<T>Replace All</T>
|
||||
</Button>
|
||||
<Button
|
||||
size="small"
|
||||
title={
|
||||
count?.excluded ? tx`Include (${formatBinding("Alt+L")})` : tx`Exclude (${formatBinding("Alt+L")})`
|
||||
}
|
||||
onClick={() => run(excludeCurrent)}
|
||||
disabled={!canReplace || (!count?.total && !count?.excluded)}
|
||||
>
|
||||
{count?.excluded ? <T>Include</T> : <T>Exclude</T>}
|
||||
</Button>
|
||||
</div>
|
||||
</>
|
||||
)}
|
||||
<Menu
|
||||
open={historyMenu !== null}
|
||||
anchor={historyMenu === "replace" ? replaceBoxRef : findBoxRef}
|
||||
items={historyMenu ? historyItems(historyMenu) : []}
|
||||
placement="bottom-start"
|
||||
aria-label="Recent searches"
|
||||
onClose={() => setHistoryMenu(null)}
|
||||
/>
|
||||
)}
|
||||
<div ref={findBoxRef} className={styles.findField}>
|
||||
<SearchField
|
||||
ref={inputRef}
|
||||
value={opts.search}
|
||||
onChange={(search) => setOpts({ search })}
|
||||
placeholder="Find"
|
||||
aria-label="Find"
|
||||
invalid={invalid || none}
|
||||
multiline
|
||||
onHistory={() => setHistoryMenu("find")}
|
||||
onKeyDown={(e) => onKeyDown(e, "find")}
|
||||
toggles={[
|
||||
{
|
||||
id: "case",
|
||||
icon: "case",
|
||||
title: "Match Case",
|
||||
shortcut: formatBinding("Alt+C"),
|
||||
pressed: opts.caseSensitive,
|
||||
onToggle: () => toggle("caseSensitive"),
|
||||
},
|
||||
{
|
||||
id: "word",
|
||||
icon: "word",
|
||||
title: "Words",
|
||||
shortcut: formatBinding("Alt+W"),
|
||||
pressed: opts.wholeWord,
|
||||
onToggle: () => toggle("wholeWord"),
|
||||
},
|
||||
{
|
||||
id: "regex",
|
||||
icon: "regex",
|
||||
title: "Regex",
|
||||
shortcut: formatBinding("Alt+X"),
|
||||
pressed: opts.regexp,
|
||||
onToggle: () => toggle("regexp"),
|
||||
},
|
||||
]}
|
||||
<Menu
|
||||
open={moreMenu}
|
||||
anchor={moreRef}
|
||||
items={moreItems}
|
||||
placement="bottom-end"
|
||||
aria-label="Find options"
|
||||
onClose={() => setMoreMenu(false)}
|
||||
/>
|
||||
<Menu
|
||||
open={filterMenu}
|
||||
anchor={filterRef}
|
||||
items={filterItems}
|
||||
placement="bottom-end"
|
||||
aria-label="Filter search results"
|
||||
onClose={() => setFilterMenu(false)}
|
||||
/>
|
||||
</div>
|
||||
<div className={styles.findButtons}>
|
||||
<span className={clsx(styles.findCount, (none || invalid) && styles.findCountNone)} aria-live="polite">
|
||||
{counter}
|
||||
</span>
|
||||
<IconButton
|
||||
icon="arrow-up"
|
||||
title="Previous Occurrence"
|
||||
shortcut={formatBinding("Shift+Enter")}
|
||||
size="small"
|
||||
onClick={() => run(findPrevious)}
|
||||
/>
|
||||
<IconButton
|
||||
icon="arrow-down"
|
||||
title="Next Occurrence"
|
||||
shortcut={formatBinding("Enter")}
|
||||
size="small"
|
||||
onClick={() => run(findNext)}
|
||||
/>
|
||||
<IconButton
|
||||
ref={filterRef}
|
||||
icon="filter"
|
||||
title="Filter Search Results"
|
||||
size="small"
|
||||
pressed={scoped || inChanges || opts.context !== "any"}
|
||||
onClick={() => setFilterMenu(true)}
|
||||
/>
|
||||
<IconButton ref={moreRef} icon="more" title="More" size="small" onClick={() => setMoreMenu(true)} />
|
||||
</div>
|
||||
<IconButton icon="close" title="Close" shortcut="⎋" size="small" className={styles.findClose} onClick={close} />
|
||||
{replace && (
|
||||
<>
|
||||
<div ref={replaceBoxRef} className={styles.findField}>
|
||||
<SearchField
|
||||
ref={replaceRef}
|
||||
value={opts.replace}
|
||||
onChange={(value) => setOpts({ replace: value })}
|
||||
placeholder="Replace"
|
||||
aria-label="Replace"
|
||||
multiline
|
||||
onHistory={() => setHistoryMenu("replace")}
|
||||
onKeyDown={(e) => onKeyDown(e, "replace")}
|
||||
toggles={[
|
||||
{
|
||||
id: "preserveCase",
|
||||
icon: "preserve-case",
|
||||
title: "Preserve Case",
|
||||
pressed: opts.preserveCase,
|
||||
onToggle: () => toggle("preserveCase"),
|
||||
},
|
||||
]}
|
||||
/>
|
||||
</div>
|
||||
<div className={styles.replaceButtons}>
|
||||
<Button
|
||||
size="small"
|
||||
title={tx`Replace (${formatBinding("Alt+P")})`}
|
||||
onClick={doReplace}
|
||||
disabled={!canReplace}
|
||||
>
|
||||
<T>Replace</T>
|
||||
</Button>
|
||||
<Button
|
||||
size="small"
|
||||
title={tx`Replace All (${formatBinding("Alt+A")})`}
|
||||
onClick={doReplaceAll}
|
||||
disabled={!canReplace}
|
||||
>
|
||||
<T>Replace All</T>
|
||||
</Button>
|
||||
<Button
|
||||
size="small"
|
||||
title={
|
||||
count?.excluded ? tx`Include (${formatBinding("Alt+L")})` : tx`Exclude (${formatBinding("Alt+L")})`
|
||||
}
|
||||
onClick={() => run(excludeCurrent)}
|
||||
disabled={!canReplace || (!count?.total && !count?.excluded)}
|
||||
>
|
||||
{count?.excluded ? <T>Include</T> : <T>Exclude</T>}
|
||||
</Button>
|
||||
</div>
|
||||
</>
|
||||
)}
|
||||
<Menu
|
||||
open={historyMenu !== null}
|
||||
anchor={historyMenu === "replace" ? replaceBoxRef : findBoxRef}
|
||||
items={historyMenu ? historyItems(historyMenu) : []}
|
||||
placement="bottom-start"
|
||||
aria-label="Recent searches"
|
||||
onClose={() => setHistoryMenu(null)}
|
||||
/>
|
||||
<Menu
|
||||
open={moreMenu}
|
||||
anchor={moreRef}
|
||||
items={moreItems}
|
||||
placement="bottom-end"
|
||||
aria-label="Find options"
|
||||
onClose={() => setMoreMenu(false)}
|
||||
/>
|
||||
<Menu
|
||||
open={filterMenu}
|
||||
anchor={filterRef}
|
||||
items={filterItems}
|
||||
placement="bottom-end"
|
||||
aria-label="Filter search results"
|
||||
onClose={() => setFilterMenu(false)}
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -1,15 +1,16 @@
|
||||
/** Status bar widgets of the active text editor (design footer). */
|
||||
import { Fragment, useRef, useState } from "react";
|
||||
import { Fragment, useLayoutEffect, useRef, useState, type ComponentPropsWithoutRef } from "react";
|
||||
import clsx from "clsx";
|
||||
import { useShallow } from "zustand/react/shallow";
|
||||
import { executeAction } from "@/platform/actions";
|
||||
import { shortcutLabel } from "@/platform/keymap";
|
||||
import { basename, dirname, projectFolder, relativePath, useProject } from "@/platform/project";
|
||||
import type { LineEnding, OutlineItem } from "@/platform/ipc";
|
||||
import { BarButton, Icon, Menu, badgeKind, fileIconName } from "@/ui";
|
||||
import { BarButton, Icon, Menu, badgeKind, fileIconName, revealHorizontally } from "@/ui";
|
||||
import { notifications, useProjectViewLead } from "@/workbench/contributions";
|
||||
import { useDistractionFree } from "@/workbench/distractionFree";
|
||||
import { ENCODING_CHOICES, useEditorPrefs } from "@/platform/editorSettings";
|
||||
import { BUNDLED_MONO_FAMILY, monoFontFamily } from "@/platform/fonts";
|
||||
import {
|
||||
gitRevisionOf,
|
||||
isUntitledUri,
|
||||
@@ -145,15 +146,39 @@ function pathCrumbs(project: { root: string; name: string } | null, path: string
|
||||
return segments;
|
||||
}
|
||||
|
||||
/** A row of crumbs; a segment with `nav` opens a popup of its children. */
|
||||
function CrumbNav({ segments, className, ariaLabel }: { segments: Crumb[]; className?: string; ariaLabel?: string }) {
|
||||
const [popup, setPopup] = useState<{ nav: NavSegment; anchor: HTMLElement } | null>(null);
|
||||
function updateBreadcrumbEdges(row: HTMLDivElement) {
|
||||
row.toggleAttribute("data-crumbs-before", row.scrollLeft > 1);
|
||||
row.toggleAttribute("data-crumbs-after", row.scrollLeft + row.clientWidth < row.scrollWidth - 1);
|
||||
}
|
||||
|
||||
function BreadcrumbStrip({
|
||||
trail,
|
||||
activateOnDown = false,
|
||||
children,
|
||||
...props
|
||||
}: ComponentPropsWithoutRef<"nav"> & { trail: string; activateOnDown?: boolean }) {
|
||||
const strip = useRef<HTMLDivElement>(null);
|
||||
useLayoutEffect(() => {
|
||||
const row = strip.current;
|
||||
if (!row) return;
|
||||
const revealCurrent = () => {
|
||||
const focused = document.activeElement;
|
||||
if (focused instanceof HTMLElement && row.contains(focused)) revealHorizontally(row, focused);
|
||||
else row.scrollLeft = row.scrollWidth;
|
||||
updateBreadcrumbEdges(row);
|
||||
};
|
||||
revealCurrent();
|
||||
if (typeof ResizeObserver === "undefined") return;
|
||||
const resize = new ResizeObserver(revealCurrent);
|
||||
resize.observe(row);
|
||||
return () => resize.disconnect();
|
||||
}, [trail]);
|
||||
return (
|
||||
<nav
|
||||
className={className}
|
||||
aria-label={ariaLabel}
|
||||
{...props}
|
||||
onKeyDown={(e) => {
|
||||
const buttons = [...e.currentTarget.querySelectorAll<HTMLButtonElement>("button")];
|
||||
if (e.altKey || e.ctrlKey || e.metaKey) return;
|
||||
const buttons = [...(strip.current?.querySelectorAll("button") ?? [])];
|
||||
const index = buttons.indexOf(e.target as HTMLButtonElement);
|
||||
if (index < 0) return;
|
||||
let next: number;
|
||||
@@ -161,7 +186,7 @@ function CrumbNav({ segments, className, ariaLabel }: { segments: Crumb[]; class
|
||||
else if (e.key === "ArrowRight") next = Math.min(buttons.length - 1, index + 1);
|
||||
else if (e.key === "Home") next = 0;
|
||||
else if (e.key === "End") next = buttons.length - 1;
|
||||
else if (e.key === "ArrowDown") {
|
||||
else if (e.key === "ArrowDown" && activateOnDown) {
|
||||
e.preventDefault();
|
||||
e.stopPropagation();
|
||||
buttons[index]?.click();
|
||||
@@ -172,30 +197,64 @@ function CrumbNav({ segments, className, ariaLabel }: { segments: Crumb[]; class
|
||||
buttons[next]?.focus();
|
||||
}}
|
||||
>
|
||||
{segments.map((s, i) => (
|
||||
<Fragment key={i}>
|
||||
{i > 0 && <Icon name="chevron-right" size={12} className={styles.statusSep} />}
|
||||
<BarButton
|
||||
className={styles.crumbButton}
|
||||
tooltip={s.title}
|
||||
aria-haspopup={s.nav ? "listbox" : undefined}
|
||||
onClick={(e) => {
|
||||
const nav = s.nav;
|
||||
const anchor = e.currentTarget;
|
||||
if (nav) setPopup((p) => (p?.anchor === anchor ? null : { nav, anchor }));
|
||||
else s.run?.();
|
||||
}}
|
||||
>
|
||||
{s.icon && <Icon name={s.icon} size={16} className={styles.crumbIcon} />}
|
||||
<span className={styles.crumbLabel}>{s.label}</span>
|
||||
</BarButton>
|
||||
</Fragment>
|
||||
))}
|
||||
{popup && <NavChildrenPopup segment={popup.nav} anchor={popup.anchor} onClose={() => setPopup(null)} />}
|
||||
<div
|
||||
ref={strip}
|
||||
className={styles.crumbStrip}
|
||||
onScroll={(e) => updateBreadcrumbEdges(e.currentTarget)}
|
||||
onWheel={(e) => {
|
||||
if (e.shiftKey || e.ctrlKey || e.deltaX) return;
|
||||
const row = e.currentTarget;
|
||||
const scale = e.deltaMode === 1 ? 16 : e.deltaMode === 2 ? row.clientWidth : 1;
|
||||
row.scrollLeft += e.deltaY * scale;
|
||||
}}
|
||||
>
|
||||
{children}
|
||||
</div>
|
||||
</nav>
|
||||
);
|
||||
}
|
||||
|
||||
/** A row of crumbs; a segment with `nav` opens a popup of its children. */
|
||||
function CrumbNav({ segments, className }: { segments: Crumb[]; className?: string }) {
|
||||
const [popup, setPopup] = useState<{ nav: NavSegment; anchor: HTMLElement } | null>(null);
|
||||
return (
|
||||
<BreadcrumbStrip
|
||||
trail={segments.map((s) => s.title).join("\n")}
|
||||
activateOnDown
|
||||
className={className}
|
||||
aria-label={tx("Breadcrumbs")}
|
||||
>
|
||||
{segments.map((s, i) => {
|
||||
const current = i === segments.length - 1;
|
||||
const icon = s.nav?.kind === "dir" && !s.nav.root && !current ? undefined : s.icon;
|
||||
return (
|
||||
<Fragment key={i}>
|
||||
{i > 0 && <Icon name="chevron-right" size={12} className={styles.statusSep} />}
|
||||
<BarButton
|
||||
className={styles.crumbButton}
|
||||
tooltip={s.title}
|
||||
aria-current={current ? "location" : undefined}
|
||||
aria-haspopup={s.nav ? "listbox" : undefined}
|
||||
onClick={(e) => {
|
||||
const nav = s.nav;
|
||||
const anchor = e.currentTarget;
|
||||
if (nav) setPopup((p) => (p?.anchor === anchor ? null : { nav, anchor }));
|
||||
else s.run?.();
|
||||
}}
|
||||
>
|
||||
{icon && (
|
||||
<Icon name={icon} size={s.nav?.kind === "dir" && s.nav.root ? 12 : 16} className={styles.crumbIcon} />
|
||||
)}
|
||||
<span className={styles.crumbLabel}>{s.label}</span>
|
||||
</BarButton>
|
||||
</Fragment>
|
||||
);
|
||||
})}
|
||||
{popup && <NavChildrenPopup segment={popup.nav} anchor={popup.anchor} onClose={() => setPopup(null)} />}
|
||||
</BreadcrumbStrip>
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* IDEA new UI navigation bar (the top of the workbench, or the status bar
|
||||
* footer via `inStatusBar`): project › dirs › file › symbols, with icons;
|
||||
@@ -241,7 +300,7 @@ export function Breadcrumbs({ className, inStatusBar = false }: { className?: st
|
||||
segments.push(projectCrumb(project ?? currentProject));
|
||||
}
|
||||
if (!segments.length) return null;
|
||||
return <CrumbNav segments={segments} className={className ?? styles.status} ariaLabel={tx("Breadcrumbs")} />;
|
||||
return <CrumbNav segments={segments} className={className ?? styles.status} />;
|
||||
}
|
||||
|
||||
/** The status bar instance of the navigation bar; renders only for `statusBar`. */
|
||||
@@ -262,7 +321,8 @@ export function CodeBreadcrumbs({
|
||||
tabId: string;
|
||||
position: "top" | "bottom";
|
||||
}) {
|
||||
const prefs = useEditorPrefs().breadcrumbs;
|
||||
const { breadcrumbs: prefs, fallbackFont } = useEditorPrefs();
|
||||
const editorSettings = useProject((s) => s.settings?.editor);
|
||||
const language = useDocMeta((s) => s[path]?.language);
|
||||
const outline = useOutline((s) => s[path]);
|
||||
let chain = useCaretSymbols(path, outline);
|
||||
@@ -278,29 +338,35 @@ export function CodeBreadcrumbs({
|
||||
!chain.length
|
||||
)
|
||||
return null;
|
||||
const family = editorSettings?.fontFamily;
|
||||
const fontFamily =
|
||||
(family && family !== BUNDLED_MONO_FAMILY) || fallbackFont.trim()
|
||||
? monoFontFamily(family, fallbackFont, "var(--font-mono)")
|
||||
: undefined;
|
||||
const fontSize = editorSettings?.fontSize ?? undefined;
|
||||
return (
|
||||
<nav
|
||||
<BreadcrumbStrip
|
||||
trail={JSON.stringify([path, fontFamily, fontSize, ...chain.map((item) => item.name)])}
|
||||
style={{ fontFamily, fontSize }}
|
||||
className={clsx(styles.codeCrumbs, position === "top" ? styles.codeCrumbsTop : styles.codeCrumbsBottom)}
|
||||
aria-label={tx("Code breadcrumbs")}
|
||||
>
|
||||
{chain.map((item, i) => (
|
||||
<Fragment key={i}>
|
||||
{i > 0 && <Icon name="chevron-right" size={12} className={styles.statusSep} />}
|
||||
<BarButton
|
||||
className={styles.crumbButton}
|
||||
tooltip={item.detail ?? item.name}
|
||||
onClick={() =>
|
||||
void editorController().openFile(path, {
|
||||
selection: { line: item.selection_range.start.line, col: item.selection_range.start.col },
|
||||
})
|
||||
}
|
||||
>
|
||||
<Icon name={`symbol-${badgeKind(item.kind)}`} size={14} className={styles.crumbIcon} />
|
||||
<span className={styles.crumbLabel}>{item.name}</span>
|
||||
</BarButton>
|
||||
</Fragment>
|
||||
<BarButton
|
||||
key={i}
|
||||
className={styles.crumbButton}
|
||||
tooltip={item.detail ?? item.name}
|
||||
aria-current={i === chain.length - 1 ? "location" : undefined}
|
||||
onClick={() =>
|
||||
void editorController().openFile(path, {
|
||||
selection: { line: item.selection_range.start.line, col: item.selection_range.start.col },
|
||||
})
|
||||
}
|
||||
>
|
||||
<span className={styles.crumbLabel}>{item.name}</span>
|
||||
</BarButton>
|
||||
))}
|
||||
</nav>
|
||||
</BreadcrumbStrip>
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
@@ -30,8 +30,7 @@
|
||||
}
|
||||
.withPreview {
|
||||
flex-direction: row;
|
||||
width: auto;
|
||||
max-width: min(1160px, 94vw);
|
||||
min-width: 0;
|
||||
}
|
||||
.listMain {
|
||||
display: flex;
|
||||
@@ -39,6 +38,11 @@
|
||||
min-width: 0;
|
||||
flex: none;
|
||||
}
|
||||
.withPreview .listMain {
|
||||
flex: 1 1 320px;
|
||||
min-width: 300px;
|
||||
min-height: 0;
|
||||
}
|
||||
.mnemonic {
|
||||
width: 10px;
|
||||
flex: none;
|
||||
@@ -48,14 +52,39 @@
|
||||
text-align: right;
|
||||
}
|
||||
.previewPanel {
|
||||
width: 420px;
|
||||
flex: none;
|
||||
flex: 0 1 var(--list-preview-width);
|
||||
min-width: 300px;
|
||||
min-height: 60px;
|
||||
max-height: 340px;
|
||||
max-height: 300px;
|
||||
overflow: auto;
|
||||
border-left: 1px solid var(--border-popup);
|
||||
background: var(--bg-popup-inline, var(--bg-elev));
|
||||
}
|
||||
.previewLeft {
|
||||
flex-direction: row-reverse;
|
||||
}
|
||||
.previewLeft .previewPanel {
|
||||
border-left: 0;
|
||||
border-right: 1px solid var(--border-popup);
|
||||
}
|
||||
.previewBelow {
|
||||
flex-direction: column;
|
||||
}
|
||||
.previewBelow .listMain {
|
||||
flex: 0 1 auto;
|
||||
min-width: 0;
|
||||
}
|
||||
.previewBelow .previewPanel {
|
||||
flex: 0 1 auto;
|
||||
min-width: 0;
|
||||
min-height: 0;
|
||||
max-height: min(300px, 40vh);
|
||||
border-left: 0;
|
||||
border-top: 1px solid var(--border-popup);
|
||||
}
|
||||
.previewBelow .previewPanel[aria-busy] {
|
||||
height: 60px;
|
||||
}
|
||||
.previewText {
|
||||
padding: 8px 10px;
|
||||
font-size: var(--fs-small);
|
||||
@@ -66,12 +95,13 @@
|
||||
padding: 6px 0;
|
||||
font-family: var(--openidea-editor-font, var(--font-mono));
|
||||
font-weight: var(--fw-code);
|
||||
font-size: var(--fs-small);
|
||||
font-size: var(--openidea-editor-font-size, var(--fs-code));
|
||||
color: var(--fg-editor);
|
||||
}
|
||||
.diffLine {
|
||||
padding: 0 10px;
|
||||
white-space: pre;
|
||||
white-space: pre-wrap;
|
||||
overflow-wrap: anywhere;
|
||||
min-height: 1.4em;
|
||||
}
|
||||
.diff-added {
|
||||
@@ -231,6 +261,34 @@
|
||||
font-size: var(--fs-tiny);
|
||||
color: var(--fg-faint);
|
||||
}
|
||||
.symbolRename {
|
||||
display: grid;
|
||||
grid-template-columns: auto minmax(0, 1fr);
|
||||
align-items: center;
|
||||
gap: var(--space-2) var(--space-3);
|
||||
padding: var(--space-3);
|
||||
font-family: var(--font-ui);
|
||||
font-size: var(--fs-ui);
|
||||
}
|
||||
.renameContext,
|
||||
.symbolRenameNote {
|
||||
grid-column: 1 / -1;
|
||||
min-width: 0;
|
||||
overflow-wrap: anywhere;
|
||||
}
|
||||
.renameContext {
|
||||
color: var(--fg-emphasis);
|
||||
}
|
||||
.symbolRename .renameField {
|
||||
width: 100%;
|
||||
height: max(var(--h-field), calc(var(--openidea-editor-font-size, var(--fs-code)) + var(--space-2)));
|
||||
font-family: var(--openidea-editor-font, var(--font-mono));
|
||||
font-size: var(--openidea-editor-font-size, var(--fs-code));
|
||||
}
|
||||
.symbolRenameNote {
|
||||
color: var(--fg-muted);
|
||||
font-size: var(--fs-small);
|
||||
}
|
||||
|
||||
/* Fits its content up to a cap; resized (`data-resized`), it keeps that size and the body scrolls. */
|
||||
.docPopup {
|
||||
@@ -238,6 +296,10 @@
|
||||
flex-direction: column;
|
||||
overflow: hidden;
|
||||
}
|
||||
.docPopup:not([data-resized]) {
|
||||
width: max-content;
|
||||
min-width: min(300px, 90vw);
|
||||
}
|
||||
.docScope {
|
||||
display: contents;
|
||||
}
|
||||
@@ -246,21 +308,32 @@
|
||||
}
|
||||
.docPopup .docFrame {
|
||||
flex: 1 1 auto;
|
||||
min-width: 0;
|
||||
min-height: 0;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
}
|
||||
.docPopup:not([data-resized]) .docFrame {
|
||||
max-width: min(600px, 90vw);
|
||||
max-height: 420px;
|
||||
max-width: min(500px, 90vw);
|
||||
max-height: 500px;
|
||||
}
|
||||
.docPopup .docBody {
|
||||
flex: 1 1 auto;
|
||||
min-height: 0;
|
||||
overflow: auto;
|
||||
overscroll-behavior: contain;
|
||||
padding: var(--space-2) var(--space-4) var(--space-1);
|
||||
}
|
||||
.docPopup .docToolbar {
|
||||
position: static;
|
||||
flex: none;
|
||||
align-self: flex-end;
|
||||
margin: 0 var(--space-2) var(--space-1);
|
||||
padding: 0;
|
||||
border: 0;
|
||||
}
|
||||
.docPopup .docToolbar .spacer {
|
||||
display: none;
|
||||
}
|
||||
.docWindowFrame {
|
||||
height: 100%;
|
||||
@@ -353,6 +426,36 @@
|
||||
flex-direction: column;
|
||||
overflow: hidden;
|
||||
}
|
||||
.renamePreview [data-dialog-body] {
|
||||
display: block;
|
||||
overflow: auto;
|
||||
}
|
||||
.previewContext {
|
||||
padding: var(--space-2) 14px 0;
|
||||
overflow-wrap: anywhere;
|
||||
color: var(--fg-emphasis);
|
||||
font-size: var(--fs-ui);
|
||||
}
|
||||
.renamePreview .previewList {
|
||||
overflow: visible;
|
||||
}
|
||||
.renamePreview .previewName {
|
||||
min-width: 0;
|
||||
max-width: 55%;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.renamePreview .previewOp {
|
||||
flex: 0 1 auto;
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.renamePreview .previewWarning {
|
||||
overflow-wrap: anywhere;
|
||||
}
|
||||
.previewSummary {
|
||||
flex: none;
|
||||
padding: 10px 14px 6px;
|
||||
@@ -424,6 +527,18 @@
|
||||
font-size: var(--fs-small);
|
||||
color: var(--fg-editor);
|
||||
}
|
||||
.renamePreview .previewOccurrences .previewRow {
|
||||
min-height: var(--h-row);
|
||||
height: auto;
|
||||
align-items: baseline;
|
||||
padding-block: var(--space-1);
|
||||
}
|
||||
.renamePreview .previewCode {
|
||||
font-family: var(--openidea-editor-font, var(--font-mono));
|
||||
font-size: var(--openidea-editor-font-size, var(--fs-code));
|
||||
white-space: pre-wrap;
|
||||
overflow-wrap: anywhere;
|
||||
}
|
||||
.previewMatch {
|
||||
background: var(--bg-search-match);
|
||||
color: var(--fg-search-match, inherit);
|
||||
|
||||
+129
-18
@@ -1,5 +1,5 @@
|
||||
/** React popups for LSP editor features, rendered as a workbench overlay. */
|
||||
import { useEffect, useMemo, useRef, useState, type KeyboardEvent } from "react";
|
||||
import { useEffect, useId, useMemo, useRef, useState, type CSSProperties, type KeyboardEvent } from "react";
|
||||
import clsx from "clsx";
|
||||
import {
|
||||
Checkbox,
|
||||
@@ -49,11 +49,17 @@ function ItemIcon({ item }: { item: ListPopupItem }) {
|
||||
return <span className={styles.iconSpacer} />;
|
||||
}
|
||||
|
||||
function ListPreviewPanel({ preview }: { preview: ListPreview | null | "loading" }) {
|
||||
function ListPreviewPanel({
|
||||
preview,
|
||||
themeClasses,
|
||||
}: {
|
||||
preview: ListPreview | null | "loading";
|
||||
themeClasses?: string;
|
||||
}) {
|
||||
if (preview === "loading") return <div className={styles.previewPanel} aria-busy="true" />;
|
||||
if (!preview) return null;
|
||||
return (
|
||||
<div className={styles.previewPanel} aria-label={tx("Preview")}>
|
||||
<div className={clsx(styles.previewPanel, themeClasses)} role="region" aria-label={tx("Preview")}>
|
||||
{preview.kind === "text" ? (
|
||||
<div className={styles.previewText}>{preview.text}</div>
|
||||
) : (
|
||||
@@ -70,6 +76,9 @@ function ListPreviewPanel({ preview }: { preview: ListPreview | null | "loading"
|
||||
);
|
||||
}
|
||||
|
||||
const LIST_PREVIEW_WIDTH = 420;
|
||||
const MIN_SIDE_BY_SIDE_WIDTH = 660;
|
||||
|
||||
function ListPopup({ popup }: { popup: Extract<LspPopup, { kind: "list" }> }) {
|
||||
const [query, setQuery] = useState("");
|
||||
const filtered = useMemo(() => {
|
||||
@@ -91,6 +100,13 @@ function ListPopup({ popup }: { popup: Extract<LspPopup, { kind: "list" }> }) {
|
||||
|
||||
const [preview, setPreview] = useState<{ id: string; data: ListPreview | null } | null>(null);
|
||||
const fetchPreview = popup.preview;
|
||||
const [viewportWidth, setViewportWidth] = useState(() => window.innerWidth);
|
||||
useEffect(() => {
|
||||
if (!fetchPreview) return;
|
||||
const resize = () => setViewportWidth(window.innerWidth);
|
||||
window.addEventListener("resize", resize);
|
||||
return () => window.removeEventListener("resize", resize);
|
||||
}, [fetchPreview]);
|
||||
useEffect(() => {
|
||||
if (!fetchPreview || !activeItem || activeItem.disabled) return;
|
||||
const ctrl = new AbortController();
|
||||
@@ -164,22 +180,46 @@ function ListPopup({ popup }: { popup: Extract<LspPopup, { kind: "list" }> }) {
|
||||
? ("loading" as const)
|
||||
: null
|
||||
: null;
|
||||
const hasPreview = shownPreview !== null;
|
||||
const previewBelow = hasPreview && viewportWidth <= MIN_SIDE_BY_SIDE_WIDTH;
|
||||
const previewLeft =
|
||||
hasPreview &&
|
||||
!previewBelow &&
|
||||
popup.anchor.x + width + LIST_PREVIEW_WIDTH > viewportWidth - 6 &&
|
||||
popup.anchor.x >= LIST_PREVIEW_WIDTH + 6;
|
||||
const anchor = useMemo(() => {
|
||||
if (!fetchPreview) return popup.anchor;
|
||||
const x = popup.anchor.x - (previewLeft ? LIST_PREVIEW_WIDTH : 0);
|
||||
return {
|
||||
getBoundingClientRect: () =>
|
||||
new DOMRect(
|
||||
Math.max(0, Math.min(x, window.innerWidth)),
|
||||
Math.max(0, Math.min(popup.anchor.y, window.innerHeight)),
|
||||
0,
|
||||
0,
|
||||
),
|
||||
};
|
||||
}, [fetchPreview, popup.anchor, previewLeft]);
|
||||
const popupSize = {
|
||||
width: hasPreview ? width + LIST_PREVIEW_WIDTH : width,
|
||||
"--list-preview-width": `${LIST_PREVIEW_WIDTH}px`,
|
||||
} as CSSProperties;
|
||||
const indexOf = (item: ListPopupItem) => popup.items.indexOf(item);
|
||||
return (
|
||||
<Popup
|
||||
open
|
||||
anchor={popup.anchor}
|
||||
anchor={anchor}
|
||||
onClose={closePopup}
|
||||
aria-label={popup.title}
|
||||
className={clsx(styles.listPopup, popup.preview && styles.withPreview)}
|
||||
style={popup.preview ? undefined : { width }}
|
||||
className={clsx(
|
||||
styles.listPopup,
|
||||
hasPreview && styles.withPreview,
|
||||
previewBelow && styles.previewBelow,
|
||||
previewLeft && styles.previewLeft,
|
||||
)}
|
||||
style={popupSize}
|
||||
>
|
||||
<div
|
||||
className={styles.listMain}
|
||||
style={popup.preview ? { width } : undefined}
|
||||
data-testid="list-popup"
|
||||
aria-busy={popup.busy || undefined}
|
||||
>
|
||||
<div className={styles.listMain} data-testid="list-popup" aria-busy={popup.busy || undefined}>
|
||||
<div className={styles.listHeader}>
|
||||
<span className={styles.listTitle}>{popup.title}</span>
|
||||
{popup.busy && <Spinner size={12} />}
|
||||
@@ -260,7 +300,7 @@ function ListPopup({ popup }: { popup: Extract<LspPopup, { kind: "list" }> }) {
|
||||
/>
|
||||
</div>
|
||||
</div>
|
||||
{popup.preview && <ListPreviewPanel preview={shownPreview} />}
|
||||
{popup.preview && <ListPreviewPanel preview={shownPreview} themeClasses={popup.themeClasses} />}
|
||||
{sub?.item.submenu && (
|
||||
<Popup
|
||||
open
|
||||
@@ -352,10 +392,71 @@ function RenamePopup({ popup }: { popup: Extract<LspPopup, { kind: "rename" }> }
|
||||
);
|
||||
}
|
||||
|
||||
function SymbolRenameDialog({ popup }: { popup: Extract<LspPopup, { kind: "symbolRename" }> }) {
|
||||
const [value, setValue] = useState(popup.initial);
|
||||
const field = useId();
|
||||
const name = value.trim();
|
||||
return (
|
||||
<Dialog
|
||||
open
|
||||
title="Rename"
|
||||
aria-label={popup.title}
|
||||
onClose={closePopup}
|
||||
blockWorkbenchShortcuts
|
||||
width={440}
|
||||
buttons={[
|
||||
{
|
||||
label: "Rename",
|
||||
role: "default",
|
||||
disabled: !name,
|
||||
onClick: () => {
|
||||
closePopup();
|
||||
popup.onSubmit(name);
|
||||
},
|
||||
},
|
||||
{ label: "Cancel", role: "cancel" },
|
||||
]}
|
||||
>
|
||||
<div className={popup.themeClasses}>
|
||||
<div className={styles.symbolRename}>
|
||||
<div className={styles.renameContext}>{popup.title}</div>
|
||||
<label htmlFor={field}>
|
||||
<T>New name</T>
|
||||
</label>
|
||||
<Input
|
||||
id={field}
|
||||
className={styles.renameField}
|
||||
mono
|
||||
data-autofocus
|
||||
autoSelect
|
||||
value={value}
|
||||
onChange={(e) => setValue(e.target.value)}
|
||||
invalid={!name}
|
||||
/>
|
||||
{popup.note && <div className={styles.symbolRenameNote}>{popup.note}</div>}
|
||||
</div>
|
||||
</div>
|
||||
</Dialog>
|
||||
);
|
||||
}
|
||||
|
||||
function DocPopup({ popup }: { popup: Extract<LspPopup, { kind: "doc" }> }) {
|
||||
const focusSeq = useLspPopup((s) => s.focusSeq);
|
||||
const scope = useRef<HTMLDivElement>(null);
|
||||
const opened = useRef(focusSeq);
|
||||
// The captured caret can end up outside the viewport while the popup is open.
|
||||
const anchor = useMemo(
|
||||
() => ({
|
||||
getBoundingClientRect: () =>
|
||||
new DOMRect(
|
||||
Math.max(0, Math.min(popup.anchor.x, window.innerWidth)),
|
||||
Math.max(0, Math.min(popup.anchor.y, window.innerHeight)),
|
||||
0,
|
||||
0,
|
||||
),
|
||||
}),
|
||||
[popup.anchor],
|
||||
);
|
||||
useEffect(() => {
|
||||
if (focusSeq !== opened.current)
|
||||
scope.current?.querySelector<HTMLElement>("[data-lsp-doc]")?.focus({ preventScroll: true });
|
||||
@@ -364,7 +465,7 @@ function DocPopup({ popup }: { popup: Extract<LspPopup, { kind: "doc" }> }) {
|
||||
return (
|
||||
<Popup
|
||||
open
|
||||
anchor={popup.anchor}
|
||||
anchor={anchor}
|
||||
onClose={closePopup}
|
||||
aria-label="Documentation"
|
||||
className={styles.docPopup}
|
||||
@@ -483,6 +584,7 @@ function savePreviewSize(size: { w: number; h: number }) {
|
||||
}
|
||||
|
||||
function PreviewDialog({ popup }: { popup: Extract<LspPopup, { kind: "preview" }> }) {
|
||||
const rename = popup.renameThemeClasses !== undefined;
|
||||
const root = useProject((s) => s.project?.root ?? "");
|
||||
const { summary } = popup;
|
||||
const [initialSize] = useState(loadPreviewSize);
|
||||
@@ -490,8 +592,9 @@ function PreviewDialog({ popup }: { popup: Extract<LspPopup, { kind: "preview" }
|
||||
<Dialog
|
||||
open
|
||||
onClose={closePopup}
|
||||
title={popup.title}
|
||||
className={styles.previewDialog}
|
||||
title={rename ? "Rename" : popup.title}
|
||||
aria-label={popup.title}
|
||||
className={clsx(styles.previewDialog, rename && styles.renamePreview)}
|
||||
width={560}
|
||||
minWidth={400}
|
||||
minHeight={220}
|
||||
@@ -512,6 +615,7 @@ function PreviewDialog({ popup }: { popup: Extract<LspPopup, { kind: "preview" }
|
||||
{ label: "Cancel", role: "cancel" },
|
||||
]}
|
||||
>
|
||||
{rename && <div className={styles.previewContext}>{popup.title}</div>}
|
||||
{popup.warnings?.map((w) => (
|
||||
<div key={w} className={styles.previewWarning} role="note">
|
||||
<Icon name="warning" size={14} />
|
||||
@@ -520,7 +624,10 @@ function PreviewDialog({ popup }: { popup: Extract<LspPopup, { kind: "preview" }
|
||||
))}
|
||||
<div className={styles.previewSummary}>{describeSummary(summary)}</div>
|
||||
{popup.occurrences ? (
|
||||
<ul className={styles.previewList} aria-label={tx("Occurrences")}>
|
||||
<ul
|
||||
className={clsx(styles.previewList, styles.previewOccurrences, popup.renameThemeClasses)}
|
||||
aria-label={tx("Occurrences")}
|
||||
>
|
||||
{popup.occurrences.map((o, i) => {
|
||||
const lead = o.text.length - o.text.trimStart().length;
|
||||
const text = o.text.trim();
|
||||
@@ -543,7 +650,9 @@ function PreviewDialog({ popup }: { popup: Extract<LspPopup, { kind: "preview" }
|
||||
{summary.entries.map((e) => (
|
||||
<li key={e.path} className={styles.previewRow}>
|
||||
<Icon name={fileIconName(basename(e.path), e.path)} size={14} className={styles.itemIcon} />
|
||||
<span className={styles.previewName}>{basename(e.path)}</span>
|
||||
<span className={styles.previewName} title={relativePath(root, e.path)}>
|
||||
{basename(e.path)}
|
||||
</span>
|
||||
<span className={styles.previewPath} title={relativePath(root, e.path)}>
|
||||
{relativePath(root, e.path)}
|
||||
</span>
|
||||
@@ -689,6 +798,8 @@ export function LspPopups() {
|
||||
return <ListPopup key={seq} popup={popup} />;
|
||||
case "rename":
|
||||
return <RenamePopup key={seq} popup={popup} />;
|
||||
case "symbolRename":
|
||||
return <SymbolRenameDialog key={seq} popup={popup} />;
|
||||
case "doc":
|
||||
return <DocPopup key={seq} popup={popup} />;
|
||||
case "definition":
|
||||
|
||||
@@ -552,6 +552,7 @@ export async function showIntentions(view: EditorView) {
|
||||
items,
|
||||
busy,
|
||||
preview,
|
||||
themeClasses: view.themeClasses,
|
||||
onClose: () => {
|
||||
dismissed = true;
|
||||
},
|
||||
|
||||
@@ -104,6 +104,7 @@ export type LspPopup =
|
||||
pin?: { label: string; run: () => void };
|
||||
/** Side panel for the selected row, fetched lazily; `signal` aborts when the selection moves. */
|
||||
preview?: (item: ListPopupItem, signal: AbortSignal) => Promise<ListPreview | null>;
|
||||
themeClasses?: string;
|
||||
/** Runs when the popup goes away (closed, replaced or a row ran). */
|
||||
onClose?: () => void;
|
||||
}
|
||||
@@ -129,6 +130,14 @@ export type LspPopup =
|
||||
hint?: string;
|
||||
onSubmit: (name: string) => void;
|
||||
}
|
||||
| {
|
||||
kind: "symbolRename";
|
||||
title: string;
|
||||
initial: string;
|
||||
note?: string;
|
||||
themeClasses: string;
|
||||
onSubmit: (name: string) => void;
|
||||
}
|
||||
| {
|
||||
kind: "preview";
|
||||
title: string;
|
||||
@@ -139,6 +148,8 @@ export type LspPopup =
|
||||
warnings?: string[];
|
||||
/** Individual occurrences with line previews (single-file syntax-based renames). */
|
||||
occurrences?: PreviewOccurrence[];
|
||||
/** The editor theme for a symbol rename and its occurrence snippets. */
|
||||
renameThemeClasses?: string;
|
||||
};
|
||||
|
||||
export interface PreviewOccurrence {
|
||||
|
||||
@@ -27,9 +27,9 @@ import { executeAction } from "@/platform/actions";
|
||||
import { whenAllSynced, whenSynced, type EditorDocContext } from "@/editor/api";
|
||||
import { structure } from "@/editor/structure";
|
||||
import { docOf, incompleteNote, isUnavailable, lspRequest, reportLspError } from "./lsp";
|
||||
import { comparePos, offsetToPos, rangeToOffsets } from "./positions";
|
||||
import { offsetToPos, rangeToOffsets } from "./positions";
|
||||
import { showHint } from "./hint";
|
||||
import { caretAnchor, openPopup, type PreviewOccurrence } from "./popupStore";
|
||||
import { openPopup, type PreviewOccurrence } from "./popupStore";
|
||||
import { needsPreview, summarizeWorkspaceEdit } from "./workspaceEdit";
|
||||
import { endInplaceRename, inplaceSession, startInplaceRename, type Span } from "./inplaceRename";
|
||||
import { shortcutLabel } from "@/platform/keymap";
|
||||
@@ -127,10 +127,10 @@ export async function startRename(view: EditorView) {
|
||||
const oldName = view.state.sliceDoc(from, to);
|
||||
const dialog = (initial: string) =>
|
||||
openPopup({
|
||||
kind: "rename",
|
||||
anchor: caretAnchor(view, from),
|
||||
kind: "symbolRename",
|
||||
title: tx`Rename '${oldName}'`,
|
||||
initial,
|
||||
themeClasses: view.themeClasses,
|
||||
onSubmit: (newName) => void finishRename(view, doc, pos, oldName, newName),
|
||||
});
|
||||
if (from === to) {
|
||||
@@ -304,6 +304,7 @@ async function finishRename(view: EditorView, doc: EditorDocContext, pos: Pos, o
|
||||
kind: "preview",
|
||||
title: tx`Rename '${oldName}' to '${newName}'`,
|
||||
summary,
|
||||
renameThemeClasses: view.themeClasses,
|
||||
...(note ? { warnings: [note] } : {}),
|
||||
confirmLabel: note ? "Rename Anyway" : "Do Refactor",
|
||||
onConfirm: () => void applyEdit(view, edit),
|
||||
@@ -350,13 +351,12 @@ async function startSyntaxRename(
|
||||
return true;
|
||||
}
|
||||
const { plan } = result;
|
||||
const at = plan.occurrences.find((o) => comparePos(o.range.start, pos) <= 0 && comparePos(pos, o.range.end) <= 0);
|
||||
openPopup({
|
||||
kind: "rename",
|
||||
anchor: caretAnchor(view, rangeToOffsets(view.state.doc, (at ?? plan.occurrences[0]!).range).from),
|
||||
kind: "symbolRename",
|
||||
title: tx`Rename '${plan.symbol.name}'`,
|
||||
initial: plan.symbol.name,
|
||||
note: `${SYNTAX_NOTE}: local occurrences only`,
|
||||
themeClasses: view.themeClasses,
|
||||
onSubmit: (newName) => void commitSyntaxRename(view, doc, plan, newName),
|
||||
});
|
||||
return true;
|
||||
@@ -418,6 +418,7 @@ export async function commitSyntaxRename(
|
||||
},
|
||||
warnings: [...risks, `${SYNTAX_NOTE}. Only the occurrences below will be renamed.`],
|
||||
occurrences,
|
||||
renameThemeClasses: view.themeClasses,
|
||||
confirmLabel: "Rename Anyway",
|
||||
onConfirm: apply,
|
||||
});
|
||||
|
||||
+51
-10
@@ -6,8 +6,17 @@
|
||||
*/
|
||||
import { EditorSelection, Prec, StateEffect, StateField, type Extension } from "@codemirror/state";
|
||||
import { completionStatus, hasNextSnippetField, hasPrevSnippetField } from "@codemirror/autocomplete";
|
||||
import { EditorView, ViewPlugin, keymap, showTooltip, type Tooltip, type ViewUpdate } from "@codemirror/view";
|
||||
import {
|
||||
EditorView,
|
||||
ViewPlugin,
|
||||
keymap,
|
||||
repositionTooltips,
|
||||
showTooltip,
|
||||
type Tooltip,
|
||||
type ViewUpdate,
|
||||
} from "@codemirror/view";
|
||||
import { commands, type SignatureHelp } from "@/platform/ipc";
|
||||
import { tooltipBounds } from "@/editor/core/cm/setup";
|
||||
import { docOf, lspRequest, reportLspError, debounce } from "./lsp";
|
||||
import { offsetToPos } from "./positions";
|
||||
import { showHint } from "./hint";
|
||||
@@ -40,8 +49,6 @@ export function splitSignature(label: string, params: ReadonlyArray<[number, num
|
||||
return { before: label.slice(0, s), param: label.slice(s, e), after: label.slice(e) };
|
||||
}
|
||||
|
||||
const MAX_ROWS = 12;
|
||||
|
||||
/** Whether an overload can take an argument at `index` (varargs take any number). */
|
||||
export function acceptsParameter(sig: { label: string; parameters: ReadonlyArray<[number, number]> }, index: number) {
|
||||
if (index < sig.parameters.length) return true;
|
||||
@@ -54,23 +61,27 @@ function signatureTooltip(s: SigState): Tooltip {
|
||||
pos: s.pos,
|
||||
above: true,
|
||||
strictSide: false,
|
||||
create: () => {
|
||||
create: (view) => {
|
||||
const dom = document.createElement("div");
|
||||
dom.className = "cm-lsp-signature";
|
||||
dom.setAttribute("role", "tooltip");
|
||||
const { signatures, activeSignature, activeParameter } = s.help;
|
||||
const start = Math.max(0, Math.min(activeSignature - 6, signatures.length - MAX_ROWS));
|
||||
signatures.slice(start, start + MAX_ROWS).forEach((sig, j) => {
|
||||
const i = start + j;
|
||||
let active: HTMLElement | null = null;
|
||||
signatures.forEach((sig, i) => {
|
||||
const row = document.createElement("div");
|
||||
row.className = "cm-lsp-signature-row";
|
||||
if (i === activeSignature) row.classList.add("cm-lsp-signature-active");
|
||||
else if (!acceptsParameter(sig, activeParameter)) row.classList.add("cm-lsp-signature-disabled");
|
||||
if (i === activeSignature) {
|
||||
row.classList.add("cm-lsp-signature-active");
|
||||
row.setAttribute("aria-current", "true");
|
||||
active = row;
|
||||
} else if (!acceptsParameter(sig, activeParameter)) row.classList.add("cm-lsp-signature-disabled");
|
||||
const parts = splitSignature(sig.label, sig.parameters, activeParameter);
|
||||
row.append(parts.before);
|
||||
if (parts.param) {
|
||||
const b = document.createElement("b");
|
||||
b.textContent = parts.param;
|
||||
row.appendChild(b);
|
||||
if (i === activeSignature) active = b;
|
||||
}
|
||||
row.append(parts.after);
|
||||
dom.appendChild(row);
|
||||
@@ -81,7 +92,37 @@ function signatureTooltip(s: SigState): Tooltip {
|
||||
d.classList.add("cm-lsp-signature-doc");
|
||||
dom.appendChild(d);
|
||||
}
|
||||
return { dom };
|
||||
const fit = ({ left, right }: { left: number; right: number }) => {
|
||||
const width = `${Math.max(0, Math.floor(right - left))}px`;
|
||||
const fontSize = getComputedStyle(view.contentDOM).fontSize;
|
||||
const changed = dom.style.getPropertyValue("--cm-signature-width") !== width || dom.style.fontSize !== fontSize;
|
||||
if (changed) {
|
||||
dom.style.setProperty("--cm-signature-width", width);
|
||||
dom.style.fontSize = fontSize;
|
||||
}
|
||||
return changed;
|
||||
};
|
||||
// Reveal the current parameter after wrapping or a vertical clamp. Leave manual scrolling alone.
|
||||
let fittedWidth = 0;
|
||||
let fittedHeight = 0;
|
||||
return {
|
||||
dom,
|
||||
mount: () => void fit(tooltipBounds(view)),
|
||||
positioned: (space) => {
|
||||
if (fit(space)) {
|
||||
repositionTooltips(view);
|
||||
return;
|
||||
}
|
||||
if (!active || (fittedWidth === dom.clientWidth && fittedHeight === dom.clientHeight)) return;
|
||||
fittedWidth = dom.clientWidth;
|
||||
fittedHeight = dom.clientHeight;
|
||||
const top = dom.getBoundingClientRect().top + dom.clientTop;
|
||||
const parameter = active.getBoundingClientRect();
|
||||
const below = parameter.bottom - (top + fittedHeight);
|
||||
if (parameter.top < top || parameter.height >= fittedHeight) dom.scrollTop += parameter.top - top;
|
||||
else if (below > 0) dom.scrollTop += below;
|
||||
},
|
||||
};
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
@@ -646,8 +646,8 @@ describe("rename wiring", () => {
|
||||
const view = editor("const x = 1;\nf({ x });", "typescript", 6);
|
||||
await startRename(view);
|
||||
const popup = useLspPopup.getState().popup;
|
||||
expect(popup?.kind).toBe("rename");
|
||||
if (popup?.kind !== "rename") return;
|
||||
expect(popup?.kind).toBe("symbolRename");
|
||||
if (popup?.kind !== "symbolRename") return;
|
||||
expect(popup.note).toContain("Based on syntax");
|
||||
popup.onSubmit("y");
|
||||
await vi.waitFor(() => expect(view.state.doc.toString()).toBe("const y = 1;\nf({ x: y });"));
|
||||
@@ -661,7 +661,7 @@ describe("rename wiring", () => {
|
||||
const view = editor("const x = 1;\nx;\nvar x;", "typescript", 6);
|
||||
await startRename(view);
|
||||
const popup = useLspPopup.getState().popup;
|
||||
if (popup?.kind !== "rename") throw new Error("no rename popup");
|
||||
if (popup?.kind !== "symbolRename") throw new Error("no rename dialog");
|
||||
popup.onSubmit("y");
|
||||
await vi.waitFor(() => expect(useLspPopup.getState().popup?.kind).toBe("preview"));
|
||||
const preview = useLspPopup.getState().popup;
|
||||
@@ -860,12 +860,12 @@ describe("rename wiring", () => {
|
||||
await startRename(view);
|
||||
expect(inplaceSession(view.state)?.oldName).toBe("x");
|
||||
await startRename(view);
|
||||
expect(useLspPopup.getState().popup?.kind).toBe("rename");
|
||||
expect(useLspPopup.getState().popup?.kind).toBe("symbolRename");
|
||||
if (finish === "cancel") closePopup();
|
||||
release({ status: "ok", data: r(0, 6, 7) });
|
||||
await older;
|
||||
expect(inplaceSession(view.state)).toBeNull();
|
||||
expect(useLspPopup.getState().popup?.kind ?? null).toBe(finish === "dialog" ? "rename" : null);
|
||||
expect(useLspPopup.getState().popup?.kind ?? null).toBe(finish === "dialog" ? "symbolRename" : null);
|
||||
});
|
||||
|
||||
it.each(["text", "document"])("drops pending preparation when the editor %s changes", async (change) => {
|
||||
@@ -938,7 +938,7 @@ describe("rename wiring", () => {
|
||||
);
|
||||
cmd.syntaxLocals.mockReturnValueOnce(ok(local({ references: [] })));
|
||||
await startRename(view);
|
||||
expect(useLspPopup.getState().popup?.kind).toBe("rename");
|
||||
expect(useLspPopup.getState().popup?.kind).toBe("symbolRename");
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
+17
-10
@@ -270,28 +270,35 @@ export const lspTheme = EditorView.theme({
|
||||
cursor: "pointer",
|
||||
},
|
||||
".cm-lsp-link-button:hover": { color: "var(--link-hover)", textDecoration: "underline" },
|
||||
".cm-lsp-signature": {
|
||||
".cm-tooltip.cm-lsp-signature": {
|
||||
fontFamily: "var(--openidea-editor-font, var(--font-mono))",
|
||||
fontWeight: "var(--fw-code, 400)",
|
||||
fontSize: "var(--openidea-editor-font-size, var(--fs-code))",
|
||||
padding: "6px 10px",
|
||||
maxWidth: "640px",
|
||||
maxWidth: "min(640px, var(--cm-signature-width, 100%))",
|
||||
maxHeight: "min(380px, 65vh)",
|
||||
paddingBlock: "var(--space-0-5)",
|
||||
overflow: "auto",
|
||||
overscrollBehavior: "contain",
|
||||
},
|
||||
".cm-lsp-signature-row": {
|
||||
color: "var(--fg-secondary)",
|
||||
whiteSpace: "pre-wrap",
|
||||
overflowWrap: "anywhere",
|
||||
lineHeight: "1.5",
|
||||
padding: "var(--space-0-5) var(--space-2)",
|
||||
paddingInlineStart: "calc(var(--space-2) + 2ch)",
|
||||
textIndent: "-2ch",
|
||||
},
|
||||
".cm-lsp-signature-row": { color: "var(--fg-subtle)", whiteSpace: "pre-wrap", lineHeight: "max(20px, 1.5em)" },
|
||||
".cm-lsp-signature-active": {
|
||||
color: "var(--fg-strong)",
|
||||
backgroundColor: "var(--bg-identifier-under-caret, color-mix(in srgb, var(--accent) 14%, transparent))",
|
||||
margin: "0 -10px",
|
||||
padding: "0 10px",
|
||||
},
|
||||
".cm-lsp-signature-disabled": { opacity: "0.55" },
|
||||
".cm-lsp-signature b": { fontWeight: "var(--fw-code-bold, 700)", color: "var(--fg-strong)" },
|
||||
".cm-lsp-signature-doc": {
|
||||
borderTop: "1px solid var(--border-popup)",
|
||||
marginTop: "6px",
|
||||
paddingTop: "6px",
|
||||
maxHeight: "160px",
|
||||
overflow: "auto",
|
||||
marginTop: "var(--space-1)",
|
||||
padding: "var(--space-2)",
|
||||
},
|
||||
".cm-tooltip:has(> .cm-lsp-hint)": { background: "none", border: "none", boxShadow: "none" },
|
||||
".cm-lsp-hint": {
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
/** Import Sessions from Other Apps: pick sessions a scan found now, and import them as tasks. */
|
||||
import { useEffect, useId, useMemo, useRef, useState, type KeyboardEvent, type MouseEvent } from "react";
|
||||
import { Button, Dialog, Icon, List, SearchField, Spinner, T, listNavigate, rowSelectionMode, selectRow } from "@/ui";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import { hasPrimaryModifier } from "@/platform/keymap";
|
||||
import { relativePath, useProject } from "@/platform/project";
|
||||
import { useTx } from "@/platform/i18n";
|
||||
@@ -41,6 +42,7 @@ function folderOf(cwd: string | null, root: string | undefined): string {
|
||||
|
||||
function ImportSessionsDialog() {
|
||||
const tx = useTx();
|
||||
const rowHeight = useRowHeight(ROW);
|
||||
const listId = useId();
|
||||
const root = useProject((s) => s.project?.root);
|
||||
const external = useAgents((s) => s.external);
|
||||
@@ -216,7 +218,7 @@ function ImportSessionsDialog() {
|
||||
activeIndex={lead}
|
||||
onSelect={select}
|
||||
isSelected={(r) => !!sel.keys?.has(r.key)}
|
||||
rowHeight={ROW}
|
||||
rowHeight={rowHeight}
|
||||
aria-label={tx("Sessions from other apps")}
|
||||
empty={
|
||||
<div className={styles.empty}>
|
||||
|
||||
@@ -176,7 +176,6 @@ function ExecutePopup({ tool }: { tool: BuildTool }) {
|
||||
}}
|
||||
focusable={false}
|
||||
hoverSelects={false}
|
||||
rowHeight={24}
|
||||
sectionHeight={28}
|
||||
className={styles.completions}
|
||||
aria-label="Completions"
|
||||
|
||||
@@ -5,18 +5,27 @@
|
||||
overflow: hidden;
|
||||
}
|
||||
.header {
|
||||
height: 26px;
|
||||
flex: none;
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-2);
|
||||
padding: 0 10px;
|
||||
flex-wrap: wrap;
|
||||
min-height: var(--h-field);
|
||||
gap: var(--space-0-5) var(--space-2);
|
||||
padding: var(--space-0-5) 10px;
|
||||
border-bottom: 1px solid var(--border-popup);
|
||||
font-size: var(--fs-small);
|
||||
font-size: var(--fs-ui);
|
||||
color: var(--fg-muted);
|
||||
}
|
||||
.actions {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
flex-wrap: wrap;
|
||||
min-width: 0;
|
||||
gap: var(--space-0-5) var(--space-2);
|
||||
font-size: var(--fs-small);
|
||||
}
|
||||
.scope {
|
||||
flex: none;
|
||||
max-width: min(100%, 18em);
|
||||
}
|
||||
|
||||
.searching {
|
||||
@@ -26,23 +35,32 @@
|
||||
}
|
||||
|
||||
.title {
|
||||
flex: 1;
|
||||
flex: 1 1 160px;
|
||||
display: flex;
|
||||
align-items: baseline;
|
||||
gap: var(--space-1);
|
||||
min-width: 0;
|
||||
color: var(--fg-emphasis);
|
||||
}
|
||||
.titleLabel {
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
color: var(--fg-emphasis);
|
||||
}
|
||||
.count {
|
||||
flex: none;
|
||||
white-space: nowrap;
|
||||
font-size: var(--fs-small);
|
||||
color: var(--fg-subtle);
|
||||
}
|
||||
.link {
|
||||
flex: none;
|
||||
max-width: 100%;
|
||||
border: none;
|
||||
background: none;
|
||||
padding: 0;
|
||||
font: inherit;
|
||||
color: var(--link);
|
||||
text-align: left;
|
||||
cursor: pointer;
|
||||
}
|
||||
.link:hover {
|
||||
@@ -52,7 +70,6 @@
|
||||
.body {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
min-height: 24px;
|
||||
padding: 2px 0;
|
||||
box-sizing: content-box;
|
||||
}
|
||||
@@ -60,21 +77,31 @@
|
||||
flex: 1;
|
||||
}
|
||||
.row {
|
||||
display: flex;
|
||||
display: grid;
|
||||
grid-template-columns: min(34%, 176px) 5ch minmax(0, 1fr);
|
||||
align-items: center;
|
||||
gap: var(--space-2);
|
||||
min-width: 0;
|
||||
width: 100%;
|
||||
}
|
||||
.file {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-1);
|
||||
min-width: 0;
|
||||
}
|
||||
.icon {
|
||||
flex: none;
|
||||
color: var(--fg-muted);
|
||||
}
|
||||
.spacer {
|
||||
flex: 1;
|
||||
.fileName {
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
}
|
||||
.where {
|
||||
flex: none;
|
||||
.line {
|
||||
overflow: hidden;
|
||||
text-align: right;
|
||||
font-variant-numeric: tabular-nums;
|
||||
font-size: var(--fs-small);
|
||||
color: var(--fg-subtle);
|
||||
}
|
||||
@@ -95,12 +122,15 @@
|
||||
outline: none;
|
||||
}
|
||||
.filter {
|
||||
flex: none;
|
||||
max-width: 12ch;
|
||||
font-family: var(--font-mono);
|
||||
color: var(--fg-strong);
|
||||
background: var(--accent-soft);
|
||||
border-radius: var(--radius-small);
|
||||
padding: 0 4px;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.noMatch {
|
||||
color: var(--danger);
|
||||
@@ -111,8 +141,9 @@
|
||||
font-size: var(--fs-small);
|
||||
}
|
||||
.preview {
|
||||
flex: none;
|
||||
height: 200px;
|
||||
flex: 0 1 auto;
|
||||
height: min(164px, 32vh);
|
||||
min-height: min(64px, 18vh);
|
||||
border-top: 1px solid var(--border-popup);
|
||||
overflow: hidden;
|
||||
}
|
||||
@@ -131,3 +162,9 @@
|
||||
.previewMatch {
|
||||
background: var(--bg-text-search-result);
|
||||
}
|
||||
|
||||
@media (max-width: 600px) {
|
||||
.title {
|
||||
flex-basis: 100%;
|
||||
}
|
||||
}
|
||||
@@ -12,6 +12,7 @@ import { codePreviewExtensions } from "@/editor/api";
|
||||
import { basename } from "@/platform/project";
|
||||
import { shortcutLabel } from "@/platform/keymap";
|
||||
import { Icon, IconButton, List, Popup, Select, Spinner, fileIconName, listNavigate } from "@/ui";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import { openLocation, readFileLines } from "./ipc";
|
||||
import {
|
||||
dismissUsagesPopup,
|
||||
@@ -83,6 +84,7 @@ const ROW = 24;
|
||||
function UsagesPopupInner() {
|
||||
const { anchor, symbol, groups, note, loading, scope } = useUsagesPopup();
|
||||
const preview = useUsagesPopupPreview((s) => s.preview);
|
||||
const rowHeight = useRowHeight(ROW);
|
||||
const all = useMemo<Usage[]>(() => groups.flatMap((g) => g.usages), [groups]);
|
||||
const [filter, setFilter] = useState("");
|
||||
const accessOptions = useUsageAccessOptions();
|
||||
@@ -93,6 +95,7 @@ function UsagesPopupInner() {
|
||||
const [active, setActive] = useState(0);
|
||||
const current = Math.min(active, items.length - 1);
|
||||
const total = usageCount(groups);
|
||||
const rowCount = Math.max(1, Math.min(14, items.length));
|
||||
const pick = (u: Usage | undefined) => {
|
||||
if (!u) return;
|
||||
close();
|
||||
@@ -158,46 +161,48 @@ function UsagesPopupInner() {
|
||||
>
|
||||
<div className={styles.header}>
|
||||
<span className={styles.title}>
|
||||
{symbol ? tx`Usages of ${symbol}` : tx("Usages")}{" "}
|
||||
<span className={styles.titleLabel}>{symbol ? tx`Usages of ${symbol}` : tx("Usages")}</span>{" "}
|
||||
<span className={styles.count}>
|
||||
{filter || items.length !== total ? tx`${items.length} of ${total} found` : tx`${total} found`}
|
||||
</span>
|
||||
</span>
|
||||
{scope && (
|
||||
<Select<UsageScope>
|
||||
variant="ghost"
|
||||
aria-label={tx("Scope")}
|
||||
className={styles.scope}
|
||||
value={scope}
|
||||
options={[
|
||||
{ value: "project", label: tx("Project Files") },
|
||||
{ value: "libraries", label: tx("Project and Libraries") },
|
||||
]}
|
||||
onChange={setUsagesPopupScope}
|
||||
<div className={styles.actions}>
|
||||
{scope && (
|
||||
<Select<UsageScope>
|
||||
variant="ghost"
|
||||
aria-label={tx("Scope")}
|
||||
className={styles.scope}
|
||||
value={scope}
|
||||
options={[
|
||||
{ value: "project", label: tx("Project Files") },
|
||||
{ value: "libraries", label: tx("Project and Libraries") },
|
||||
]}
|
||||
onChange={setUsagesPopupScope}
|
||||
/>
|
||||
)}
|
||||
{loading && (
|
||||
<span className={styles.searching} role="status" aria-label={tx("Searching for more usages")}>
|
||||
<Spinner size={16} variant="spokes" />
|
||||
</span>
|
||||
)}
|
||||
{filter && (
|
||||
<span className={clsx(styles.filter, !items.length && styles.noMatch)} role="status">
|
||||
{filter}
|
||||
</span>
|
||||
)}
|
||||
<IconButton
|
||||
icon="preview-details"
|
||||
size="small"
|
||||
title="Show Preview"
|
||||
pressed={preview}
|
||||
onMouseDown={(e) => e.preventDefault()}
|
||||
onClick={() => setUsagesPopupPreview(!preview)}
|
||||
/>
|
||||
)}
|
||||
{loading && (
|
||||
<span className={styles.searching} role="status" aria-label={tx("Searching for more usages")}>
|
||||
<Spinner size={16} variant="spokes" />
|
||||
</span>
|
||||
)}
|
||||
{filter && (
|
||||
<span className={clsx(styles.filter, !items.length && styles.noMatch)} role="status">
|
||||
{filter}
|
||||
</span>
|
||||
)}
|
||||
<IconButton
|
||||
icon="preview-details"
|
||||
size="small"
|
||||
title="Show Preview"
|
||||
pressed={preview}
|
||||
onMouseDown={(e) => e.preventDefault()}
|
||||
onClick={() => setUsagesPopupPreview(!preview)}
|
||||
/>
|
||||
<button type="button" className={styles.link} onClick={openInFindWindow}>
|
||||
{tx("Open in Find Window")}
|
||||
{keys ? ` ${keys}` : ""}
|
||||
</button>
|
||||
<button type="button" className={styles.link} onClick={openInFindWindow}>
|
||||
{tx("Open in Find Window")}
|
||||
{keys ? ` ${keys}` : ""}
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
<UsageAccessFilter items={all} />
|
||||
{note && (
|
||||
@@ -205,7 +210,10 @@ function UsagesPopupInner() {
|
||||
{note}
|
||||
</div>
|
||||
)}
|
||||
<div className={styles.body} style={{ height: Math.max(1, Math.min(14, items.length)) * ROW }}>
|
||||
<div
|
||||
className={styles.body}
|
||||
style={{ height: rowCount * rowHeight, minHeight: `min(${Math.min(rowCount, 3) * rowHeight}px, 18vh)` }}
|
||||
>
|
||||
<List
|
||||
items={items}
|
||||
getKey={(u) =>
|
||||
@@ -215,7 +223,7 @@ function UsagesPopupInner() {
|
||||
onActiveChange={setActive}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={ROW}
|
||||
rowHeight={rowHeight}
|
||||
aria-label="Usages"
|
||||
onActivate={pick}
|
||||
empty={
|
||||
@@ -225,12 +233,14 @@ function UsagesPopupInner() {
|
||||
}
|
||||
renderItem={(u) => (
|
||||
<div className={styles.row} data-testid="usage-row" data-path={u.path} data-line={u.line}>
|
||||
<Icon name={fileIconName(basename(u.path), u.path)} size={16} className={styles.icon} />
|
||||
<UsagePreview usage={u} />
|
||||
<span className={styles.spacer} />
|
||||
<span className={styles.where}>
|
||||
{basename(u.path)}:{u.line + 1}
|
||||
<span className={styles.file}>
|
||||
<Icon name={fileIconName(basename(u.path), u.path)} size={16} className={styles.icon} />
|
||||
<span className={styles.fileName} title={u.path}>
|
||||
{basename(u.path)}
|
||||
</span>
|
||||
</span>
|
||||
<span className={styles.line}>{u.line + 1}</span>
|
||||
<UsagePreview usage={u} />
|
||||
</div>
|
||||
)}
|
||||
/>
|
||||
|
||||
@@ -25,15 +25,15 @@
|
||||
background: var(--border);
|
||||
}
|
||||
.summary {
|
||||
height: 26px;
|
||||
min-height: 26px;
|
||||
flex: none;
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-1-5);
|
||||
padding: 0 10px;
|
||||
flex-wrap: wrap;
|
||||
gap: var(--space-0-5) var(--space-1-5);
|
||||
padding: var(--space-0-5) 10px;
|
||||
font-size: var(--fs-ui);
|
||||
color: var(--fg-subtle);
|
||||
white-space: nowrap;
|
||||
}
|
||||
.groupLabel {
|
||||
color: var(--fg);
|
||||
@@ -42,12 +42,13 @@
|
||||
color: var(--danger);
|
||||
}
|
||||
.link {
|
||||
flex: none;
|
||||
max-width: 100%;
|
||||
border: none;
|
||||
background: none;
|
||||
padding: 0;
|
||||
font: inherit;
|
||||
color: var(--link);
|
||||
text-align: left;
|
||||
cursor: pointer;
|
||||
}
|
||||
.link:hover {
|
||||
@@ -81,9 +82,18 @@
|
||||
flex: none;
|
||||
}
|
||||
.file {
|
||||
flex: none;
|
||||
max-width: 56%;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
color: var(--fg);
|
||||
}
|
||||
.muted,
|
||||
.directory {
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
color: var(--fg-subtle);
|
||||
}
|
||||
.count {
|
||||
flex: none;
|
||||
color: var(--fg-subtle);
|
||||
@@ -101,7 +111,7 @@
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
font-family: var(--font-mono);
|
||||
font-size: var(--fs-ui);
|
||||
font-size: var(--fs-code);
|
||||
color: var(--fg);
|
||||
}
|
||||
.match {
|
||||
@@ -135,3 +145,18 @@
|
||||
flex: 1;
|
||||
min-height: 0;
|
||||
}
|
||||
.splitFrame {
|
||||
display: flex;
|
||||
min-width: 0;
|
||||
}
|
||||
.sourcePreview {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
font-family: var(--font-mono);
|
||||
font-size: var(--fs-code);
|
||||
line-height: 1.45;
|
||||
}
|
||||
.sourcePreview .sourceText[role="region"] {
|
||||
font: inherit;
|
||||
font-weight: var(--fw-code);
|
||||
}
|
||||
@@ -2,11 +2,13 @@
|
||||
* "usages" tool window: Find Usages results grouped by file with line
|
||||
* previews, one tab per search (pinnable, as the Find tool window's tabs).
|
||||
*/
|
||||
import { useCallback, useMemo, useRef, useState, type KeyboardEvent, type ReactNode } from "react";
|
||||
import { useCallback, useLayoutEffect, useMemo, useRef, useState, type KeyboardEvent, type ReactNode } from "react";
|
||||
import clsx from "clsx";
|
||||
import { create } from "zustand";
|
||||
import { previewColors, tokenSpans, useLineTokens } from "@/editor/lineTokens";
|
||||
import { formatMessage, useTx } from "@/platform/i18n";
|
||||
import { useEditorPrefs } from "@/platform/editorSettings";
|
||||
import { BUNDLED_MONO_FAMILY, monoFontFamily } from "@/platform/fonts";
|
||||
import { shortcutLabel } from "@/platform/keymap";
|
||||
import { basename, relativeDir, useProject } from "@/platform/project";
|
||||
import { maybeEditorService, useOccurrenceNavigator } from "@/workbench/contributions";
|
||||
@@ -245,8 +247,12 @@ export function UsagesView() {
|
||||
return (
|
||||
<span className={clsx(styles.row, isExcluded(n) && styles.excluded)}>
|
||||
<Icon name={fileIconName(basename(path), path)} size={16} className={styles.icon} />
|
||||
<span className={styles.file}>{basename(path)}</span>
|
||||
<span className={styles.muted}>{relativeDir(root, path)}</span>
|
||||
<span className={styles.file} title={path}>
|
||||
{basename(path)}
|
||||
</span>
|
||||
<span className={styles.directory} title={path}>
|
||||
{relativeDir(root, path)}
|
||||
</span>
|
||||
<span className={styles.count}>
|
||||
{n.group.usages.length} {tx(n.group.usages.length === 1 ? "usage" : "usages")}
|
||||
</span>
|
||||
@@ -401,34 +407,62 @@ export function useUsagesHeaderMenu(): MenuItem[] {
|
||||
|
||||
function UsagesSplit({ preview, children }: { preview: ReactNode; children: ReactNode }) {
|
||||
const show = useUsagesOptions((s) => s.preview);
|
||||
const frame = useRef<HTMLDivElement>(null);
|
||||
const [stacked, setStacked] = useState(false);
|
||||
useLayoutEffect(() => {
|
||||
const el = frame.current;
|
||||
if (!show || !el) return;
|
||||
const measure = () => setStacked(el.clientWidth < 580);
|
||||
measure();
|
||||
if (typeof ResizeObserver === "undefined") return;
|
||||
const observer = new ResizeObserver(measure);
|
||||
observer.observe(el);
|
||||
return () => observer.disconnect();
|
||||
}, [show]);
|
||||
if (!show) return children;
|
||||
return (
|
||||
<SplitGroup orientation="horizontal" id="usages-preview-split" storageKey="openidea.usages.previewSplit">
|
||||
<SplitPanel id="usages" minSize={160} className={styles.panel}>
|
||||
{children}
|
||||
</SplitPanel>
|
||||
<SplitHandle />
|
||||
<SplitPanel id="preview" minSize={160} defaultSize="45%" className={styles.panel}>
|
||||
{preview}
|
||||
</SplitPanel>
|
||||
</SplitGroup>
|
||||
<div ref={frame} className={styles.splitFrame}>
|
||||
<SplitGroup
|
||||
orientation={stacked ? "vertical" : "horizontal"}
|
||||
id="usages-preview-split"
|
||||
storageKey={stacked ? "openidea.usages.previewSplit.vertical" : "openidea.usages.previewSplit"}
|
||||
>
|
||||
<SplitPanel id="usages" minSize={stacked ? "30%" : 160} className={styles.panel}>
|
||||
{children}
|
||||
</SplitPanel>
|
||||
<SplitHandle />
|
||||
<SplitPanel id="preview" minSize={stacked ? "30%" : 160} defaultSize="45%" className={styles.panel}>
|
||||
{preview}
|
||||
</SplitPanel>
|
||||
</SplitGroup>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
function UsagesPreview({ node }: { node: Node | null }) {
|
||||
const usage = node?.kind === "usage" ? node.usage : node?.kind === "file" ? (node.group.usages[0] ?? null) : null;
|
||||
const search = useUsages(activeUsageSearch);
|
||||
const settings = useProject((s) => s.settings?.editor);
|
||||
const { fallbackFont } = useEditorPrefs();
|
||||
const family = settings?.fontFamily;
|
||||
const fontFamily =
|
||||
(family && family !== BUNDLED_MONO_FAMILY) || fallbackFont.trim()
|
||||
? monoFontFamily(family, fallbackFont, "var(--font-mono)")
|
||||
: undefined;
|
||||
const highlights = useMemo(() => {
|
||||
const group = usage && search?.groups.find((g) => g.path === usage.path);
|
||||
return (group?.usages ?? []).map((u) => ({ line: u.line, ranges: [[u.col, u.endCol] as const] }));
|
||||
}, [usage, search?.groups]);
|
||||
return (
|
||||
<SourcePreview
|
||||
path={usage?.path ?? null}
|
||||
line={usage?.line ?? 0}
|
||||
highlights={highlights}
|
||||
load={previewText}
|
||||
colorize={previewColors}
|
||||
/>
|
||||
<div className={styles.sourcePreview} style={{ fontFamily, fontSize: settings?.fontSize ?? undefined }}>
|
||||
<SourcePreview
|
||||
path={usage?.path ?? null}
|
||||
line={usage?.line ?? 0}
|
||||
highlights={highlights}
|
||||
load={previewText}
|
||||
colorize={previewColors}
|
||||
className={styles.sourceText}
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -7,6 +7,7 @@ import { Icon, Input, List, Popup, listNavigate } from "@/ui";
|
||||
import { tx } from "@/platform/i18n";
|
||||
import type { GridColumn } from "./Grid";
|
||||
import styles from "./Database.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
export function filterColumns(columns: readonly GridColumn[], query: string): number[] {
|
||||
const q = query.trim().toLowerCase();
|
||||
@@ -24,6 +25,7 @@ export function ColumnsPopup(props: {
|
||||
onPick: (col: number) => void;
|
||||
onClose: () => void;
|
||||
}) {
|
||||
const rowHeight = useRowHeight(22);
|
||||
const [query, setQuery] = useState("");
|
||||
const [active, setActive] = useState(0);
|
||||
const shown = filterColumns(props.columns, query);
|
||||
@@ -72,7 +74,7 @@ export function ColumnsPopup(props: {
|
||||
onActivate={(_, i) => pick(i)}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={22}
|
||||
rowHeight={rowHeight}
|
||||
aria-label={tx("Columns")}
|
||||
className={styles.columnsList}
|
||||
empty={<span>{tx("No matching columns")}</span>}
|
||||
|
||||
@@ -154,6 +154,28 @@
|
||||
flex: 1;
|
||||
min-height: 0;
|
||||
}
|
||||
/* A console's request in flight; the previous result stays below it. */
|
||||
.executing {
|
||||
flex: none;
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-2);
|
||||
min-width: 0;
|
||||
padding: var(--space-1) var(--space-3);
|
||||
border-bottom: 1px solid var(--border);
|
||||
color: var(--fg-muted);
|
||||
font-size: var(--fs-small);
|
||||
}
|
||||
.executingText {
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.executingTime {
|
||||
flex: none;
|
||||
font-variant-numeric: tabular-nums;
|
||||
}
|
||||
/* Gives way before the name does. */
|
||||
.treeDetail {
|
||||
color: var(--fg-muted);
|
||||
@@ -657,6 +679,12 @@
|
||||
}
|
||||
|
||||
/* Console run feedback: timing after a statement, gutter check / error, error banner. */
|
||||
:global(.cm-openidea-db-executing) {
|
||||
background: var(--accent-soft);
|
||||
}
|
||||
:global(.cm-openidea-db-elapsed) {
|
||||
font-variant-numeric: tabular-nums;
|
||||
}
|
||||
:global(.cm-openidea-db-timing) {
|
||||
margin-left: 1.5em;
|
||||
color: var(--fg-muted);
|
||||
|
||||
@@ -30,6 +30,7 @@ vi.mock("@tanstack/react-virtual", () => ({
|
||||
getTotalSize: () => count * 24,
|
||||
getVirtualItems: () => Array.from({ length: count }, (_, index) => ({ index, start: index * 24, key: index })),
|
||||
scrollToIndex: () => {},
|
||||
measure: () => {},
|
||||
}),
|
||||
}));
|
||||
|
||||
|
||||
@@ -16,6 +16,8 @@ import {
|
||||
type MouseEvent,
|
||||
} from "react";
|
||||
import clsx from "clsx";
|
||||
import { useShallow } from "zustand/react/shallow";
|
||||
import { basename } from "@/platform/project";
|
||||
import { call, commands, type DbPlanNode, type DbQueryResult } from "@/platform/ipc";
|
||||
import { shortcutLabel } from "@/platform/keymap";
|
||||
import { setContext } from "@/platform/context";
|
||||
@@ -35,7 +37,7 @@ import {
|
||||
resolveTarget,
|
||||
type EditBlockReason,
|
||||
} from "./resultEditing";
|
||||
import { pageWindow } from "./resultView";
|
||||
import { formatElapsed, pageWindow } from "./resultView";
|
||||
import { resultTabMenu } from "./resultTabActions";
|
||||
import { analyze } from "./sql/analyze";
|
||||
import { nameMatcher } from "./sql/dialect";
|
||||
@@ -55,6 +57,7 @@ import {
|
||||
rerunResult,
|
||||
useDatabase,
|
||||
withConnection,
|
||||
type ConsoleExecution,
|
||||
type OutputLine,
|
||||
type ResultTab,
|
||||
} from "./store";
|
||||
@@ -744,8 +747,40 @@ function PinButton({ tab }: { tab: ResultTab }) {
|
||||
);
|
||||
}
|
||||
|
||||
/** The most recently started console request, while it runs. */
|
||||
function useLatestExecution(): [string, ConsoleExecution] | undefined {
|
||||
return useDatabase(
|
||||
useShallow((s) => {
|
||||
let latest: [string, ConsoleExecution] | undefined;
|
||||
for (const entry of Object.entries(s.executions))
|
||||
if (!latest || entry[1].startedAt > latest[1].startedAt) latest = entry;
|
||||
return latest;
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
function ExecutingBar({ path, execution }: { path: string; execution: ConsoleExecution }) {
|
||||
const [now, setNow] = useState(() => Date.now());
|
||||
useEffect(() => {
|
||||
const timer = setInterval(() => setNow(Date.now()), 100);
|
||||
return () => clearInterval(timer);
|
||||
}, [execution.startedAt]);
|
||||
const name = basename(path);
|
||||
const count = execution.statements;
|
||||
return (
|
||||
<div className={styles.executing} role="status">
|
||||
<Spinner size={12} label={tx("Executing")} />
|
||||
<span className={styles.executingText} title={path}>
|
||||
{count > 1 ? tx`Executing ${count} statements in ${name}…` : tx`Executing in ${name}…`}
|
||||
</span>
|
||||
<span className={styles.executingTime}>{formatElapsed(Math.max(0, now - execution.startedAt))}</span>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
export function ResultsView() {
|
||||
const results = useDatabase((s) => s.results);
|
||||
const execution = useLatestExecution();
|
||||
const active = useDatabase((s) => s.activeResult);
|
||||
const hasOutput = useDatabase((s) => s.output.length > 0);
|
||||
const root = useRef<HTMLDivElement>(null);
|
||||
@@ -772,6 +807,8 @@ export function ResultsView() {
|
||||
owner: e.currentTarget,
|
||||
});
|
||||
};
|
||||
const executing = execution && <ExecutingBar path={execution[0]} execution={execution[1]} />;
|
||||
if (!results.length && !hasOutput && executing) return <div className={styles.view}>{executing}</div>;
|
||||
if (!results.length && !hasOutput)
|
||||
return (
|
||||
<EmptyState title="No results">
|
||||
@@ -825,6 +862,7 @@ export function ResultsView() {
|
||||
]}
|
||||
/>
|
||||
</ToolWindowContentTabs>
|
||||
{executing}
|
||||
<div
|
||||
ref={panel}
|
||||
className={styles.fill}
|
||||
|
||||
@@ -23,6 +23,7 @@ import {
|
||||
Facet,
|
||||
Prec,
|
||||
RangeSet,
|
||||
type Range,
|
||||
StateEffect,
|
||||
StateField,
|
||||
type Extension,
|
||||
@@ -42,8 +43,15 @@ import {
|
||||
import { useEffect, useMemo, useRef, useState, type PointerEvent } from "react";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import type { EditorDocContext } from "@/editor/api";
|
||||
import { iconNode } from "@/ui/iconNode";
|
||||
import { call, commands, type DbDriver, type DbSessionContext, type DbStatementOutcome } from "@/platform/ipc";
|
||||
import { iconNode, spinnerNode } from "@/ui/iconNode";
|
||||
import {
|
||||
call,
|
||||
commands,
|
||||
type DbDriver,
|
||||
type DbSessionContext,
|
||||
type DbStatementOutcome,
|
||||
type SqlStatement,
|
||||
} from "@/platform/ipc";
|
||||
import { shortcutLabel } from "@/platform/keymap";
|
||||
import { Icon, IconButton, Select, Toolbar, lazyComponent } from "@/ui";
|
||||
import { useProject } from "@/platform/project";
|
||||
@@ -93,6 +101,7 @@ import type { ResultTab } from "./store";
|
||||
/** `templates` feature's language-data key for finer template contexts. */
|
||||
const TEMPLATE_CONTEXT_KEY = "openideaTemplateContexts";
|
||||
|
||||
import { formatElapsed } from "./resultView";
|
||||
import { SQL_LANGUAGE } from "./sqlLanguage";
|
||||
export { SQL_LANGUAGE };
|
||||
const ROW_LIMITS = ["100", "500", "1000", "5000", "50000"];
|
||||
@@ -107,19 +116,40 @@ interface RunMark {
|
||||
ms: number | null;
|
||||
}
|
||||
|
||||
/** The statements a running request submitted (a batch: all of them, in order). */
|
||||
interface Executing {
|
||||
/** Tells this run from a later one on the same console. */
|
||||
token: number;
|
||||
/** The statements' offsets in the text sent. */
|
||||
sent: readonly { from: number; to: number }[];
|
||||
/** Where they are now. */
|
||||
spans: readonly { from: number; to: number }[];
|
||||
/** Where the elapsed time shows: after the last statement's `;`. */
|
||||
at: number;
|
||||
startedAt: number;
|
||||
}
|
||||
|
||||
interface RunState {
|
||||
marks: readonly RunMark[];
|
||||
/** Message of the bottom error banner (`null`: hidden). */
|
||||
banner: string | null;
|
||||
executing: Executing | null;
|
||||
}
|
||||
|
||||
const setRun = StateEffect.define<RunState>();
|
||||
|
||||
const runField = StateField.define<RunState>({
|
||||
create: () => ({ marks: [], banner: null }),
|
||||
create: () => ({ marks: [], banner: null, executing: null }),
|
||||
update(value, tr) {
|
||||
for (const e of tr.effects) if (e.is(setRun)) return e.value;
|
||||
if (!tr.docChanged) return value;
|
||||
// The request runs the text it was sent; edits only move where that shows.
|
||||
const ex = value.executing;
|
||||
const executing = ex && {
|
||||
...ex,
|
||||
spans: ex.spans.map((r) => ({ from: tr.changes.mapPos(r.from, 1), to: tr.changes.mapPos(r.to, -1) })),
|
||||
at: tr.changes.mapPos(ex.at),
|
||||
};
|
||||
// Editing a statement drops its mark.
|
||||
const marks: RunMark[] = [];
|
||||
for (const m of value.marks) {
|
||||
@@ -135,12 +165,18 @@ const runField = StateField.define<RunState>({
|
||||
timingAt: tr.changes.mapPos(m.timingAt),
|
||||
});
|
||||
}
|
||||
return { ...value, marks };
|
||||
return { ...value, marks, executing };
|
||||
},
|
||||
provide: (f) => [
|
||||
EditorView.decorations.from(f, (st) => {
|
||||
const ranges = [];
|
||||
const ex = st.executing;
|
||||
for (const r of ex?.spans ?? [])
|
||||
if (r.from < r.to) ranges.push(Decoration.mark({ class: "cm-openidea-db-executing" }).range(r.from, r.to));
|
||||
if (ex) ranges.push(Decoration.widget({ widget: new ElapsedWidget(ex.startedAt), side: 1 }).range(ex.at));
|
||||
for (const m of st.marks) {
|
||||
// The new run takes the place of a statement's last outcome.
|
||||
if (ex?.spans.some((r) => r.from <= m.to && m.from <= r.to)) continue;
|
||||
if (m.error)
|
||||
ranges.push(
|
||||
Decoration.mark({ class: "cm-openidea-db-error", attributes: { title: m.error } }).range(m.from, m.to),
|
||||
@@ -164,11 +200,47 @@ class TimingWidget extends WidgetType {
|
||||
toDOM() {
|
||||
const span = document.createElement("span");
|
||||
span.className = "cm-openidea-db-timing";
|
||||
span.textContent = this.ms < 1000 ? `${Math.round(this.ms)} ms` : `${(this.ms / 1000).toFixed(1)} s`;
|
||||
span.textContent = formatElapsed(this.ms);
|
||||
return span;
|
||||
}
|
||||
}
|
||||
|
||||
/** The running time of the request, ticking until it ends. */
|
||||
class ElapsedWidget extends WidgetType {
|
||||
private timer: ReturnType<typeof setInterval> | undefined;
|
||||
constructor(readonly startedAt: number) {
|
||||
super();
|
||||
}
|
||||
eq(other: ElapsedWidget) {
|
||||
return other.startedAt === this.startedAt;
|
||||
}
|
||||
toDOM() {
|
||||
const span = document.createElement("span");
|
||||
span.className = "cm-openidea-db-timing cm-openidea-db-elapsed";
|
||||
const tick = () => {
|
||||
const elapsed = formatElapsed(Date.now() - this.startedAt);
|
||||
span.textContent = tx`Executing… ${elapsed}`;
|
||||
};
|
||||
tick();
|
||||
this.timer = setInterval(tick, 100);
|
||||
return span;
|
||||
}
|
||||
destroy() {
|
||||
clearInterval(this.timer);
|
||||
}
|
||||
}
|
||||
|
||||
class ExecutingMarker extends GutterMarker {
|
||||
eq(other: GutterMarker) {
|
||||
return other instanceof ExecutingMarker;
|
||||
}
|
||||
toDOM() {
|
||||
const el = spinnerNode(12, "cm-openidea-db-run-executing");
|
||||
el.title = tx("Executing");
|
||||
return el;
|
||||
}
|
||||
}
|
||||
|
||||
class RunMarker extends GutterMarker {
|
||||
constructor(readonly error: string | null) {
|
||||
super();
|
||||
@@ -192,9 +264,12 @@ const runGutter = gutter({
|
||||
markers: (view) => {
|
||||
const st = view.state.field(runField);
|
||||
const doc = view.state.doc;
|
||||
const ranges = st.marks
|
||||
.filter((m) => m.from <= doc.length)
|
||||
const ex = st.executing;
|
||||
const ranges: Range<GutterMarker>[] = st.marks
|
||||
.filter((m) => m.from <= doc.length && !ex?.spans.some((r) => r.from <= m.to && m.from <= r.to))
|
||||
.map((m) => new RunMarker(m.error).range(doc.lineAt(m.from).from));
|
||||
const first = ex?.spans[0];
|
||||
if (first && first.from <= doc.length) ranges.push(new ExecutingMarker().range(doc.lineAt(first.from).from));
|
||||
return RangeSet.of(ranges, true);
|
||||
},
|
||||
});
|
||||
@@ -233,20 +308,59 @@ export function markOutcomes(view: EditorView, outcomes: readonly DbStatementOut
|
||||
}));
|
||||
const failed = outcomes.find((o) => o.error);
|
||||
const name = failed ? (sourceById(consoleSource(view.state.facet(consolePath)))?.name ?? "") : "";
|
||||
view.dispatch({ effects: setRun.of({ marks, banner: failed ? `[${name}] ${failed.error}` : null }) });
|
||||
view.dispatch({
|
||||
effects: setRun.of({ ...view.state.field(runField), marks, banner: failed ? `[${name}] ${failed.error}` : null }),
|
||||
});
|
||||
}
|
||||
|
||||
let nextExecution = 0;
|
||||
|
||||
/** `outcomes` at where their statements are now, when the text was edited while they ran. */
|
||||
function placed(
|
||||
executing: Executing | null,
|
||||
token: number,
|
||||
outcomes: readonly DbStatementOutcome[],
|
||||
): readonly DbStatementOutcome[] {
|
||||
if (executing?.token !== token) return outcomes;
|
||||
return outcomes.map((o) => {
|
||||
const i = executing.sent.findIndex((r) => r.from === o.statement.from && r.to === o.statement.to);
|
||||
const now = executing.spans[i];
|
||||
return now ? { ...o, statement: { ...o.statement, from: now.from, to: now.to } } : o;
|
||||
});
|
||||
}
|
||||
|
||||
/** Runs `from`–`to` of `view`, showing the submitted statements as executing until the request ends. */
|
||||
async function executeRange(view: EditorView, path: string, from: number, to: number) {
|
||||
const token = ++nextExecution;
|
||||
const sent = view.state.doc;
|
||||
const start = (statements: readonly SqlStatement[]) => {
|
||||
// The offsets are into the text sent; an edit since (while asking for parameters) leaves them unplaced.
|
||||
if (view.state.doc !== sent) return;
|
||||
const spans = statements.map((st) => ({ from: st.from, to: st.to }));
|
||||
const last = spans.at(-1);
|
||||
if (!last) return;
|
||||
const at = view.state.sliceDoc(last.to, last.to + 1) === ";" ? last.to + 1 : last.to;
|
||||
const executing = { token, sent: spans, spans, at, startedAt: Date.now() };
|
||||
view.dispatch({ effects: setRun.of({ ...view.state.field(runField), executing }) });
|
||||
};
|
||||
try {
|
||||
const outcomes = await executeConsole(path, sent.toString(), from, to, start);
|
||||
if (outcomes.length) markOutcomes(view, placed(view.state.field(runField).executing, token, outcomes));
|
||||
} finally {
|
||||
const st = view.state.field(runField, false);
|
||||
if (st?.executing?.token === token) view.dispatch({ effects: setRun.of({ ...st, executing: null }) });
|
||||
}
|
||||
}
|
||||
|
||||
/** Runs the statement at the caret (or the selected ones) of `view`. */
|
||||
export async function executeInView(view: EditorView, path: string) {
|
||||
const sel = view.state.selection.main;
|
||||
const outcomes = await executeConsole(path, view.state.doc.toString(), sel.from, sel.to);
|
||||
if (outcomes.length) markOutcomes(view, outcomes);
|
||||
await executeRange(view, path, sel.from, sel.to);
|
||||
}
|
||||
|
||||
/** Runs every statement of `view`, in order (stops at the first that fails). */
|
||||
export async function executeScriptInView(view: EditorView, path: string) {
|
||||
const outcomes = await executeConsole(path, view.state.doc.toString(), 0, view.state.doc.length);
|
||||
if (outcomes.length) markOutcomes(view, outcomes);
|
||||
await executeRange(view, path, 0, view.state.doc.length);
|
||||
}
|
||||
|
||||
/** Explain Plan of the statement at the caret (or the first selected one) of `view`. */
|
||||
|
||||
@@ -3,9 +3,10 @@ import { EditorState } from "@codemirror/state";
|
||||
import { EditorView } from "@codemirror/view";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { useProject } from "@/platform/project";
|
||||
import { consoleExtension } from "./console";
|
||||
import { consoleExtension, executeScriptInView } from "./console";
|
||||
import { SQL_LANGUAGE } from "./sqlLanguage";
|
||||
import { executeConsole, rerunResult, useDatabase } from "./store";
|
||||
import { provideToolWindowService } from "@/workbench/contributions";
|
||||
|
||||
const backend = vi.hoisted(() => ({ execute: vi.fn(), statements: vi.fn() }));
|
||||
|
||||
@@ -30,6 +31,7 @@ const initial = useDatabase.getState();
|
||||
let runs = 0;
|
||||
|
||||
beforeEach(() => {
|
||||
provideToolWindowService({ show: () => {} } as never);
|
||||
runs = 0;
|
||||
useProject.setState({
|
||||
project: { name: "p", root: "/p", trusted: true } as never,
|
||||
@@ -134,3 +136,59 @@ describe("In-Editor Results", () => {
|
||||
view.destroy();
|
||||
});
|
||||
});
|
||||
|
||||
describe("statements in flight", () => {
|
||||
it("marks what was submitted with its running time, then the outcome", async () => {
|
||||
const parent = document.createElement("div");
|
||||
document.body.append(parent);
|
||||
const doc = "SELECT 1;\nSELECT 2;\n";
|
||||
const view = new EditorView({
|
||||
parent,
|
||||
state: EditorState.create({
|
||||
doc,
|
||||
extensions: consoleExtension({ language: SQL_LANGUAGE, path: PATH } as never),
|
||||
}),
|
||||
});
|
||||
let finish!: () => void;
|
||||
const gate = new Promise<void>((resolve) => {
|
||||
finish = resolve;
|
||||
});
|
||||
const execute = backend.execute.getMockImplementation()!;
|
||||
backend.execute.mockImplementationOnce(async (...args: unknown[]) => {
|
||||
await gate;
|
||||
return execute(...(args as Parameters<typeof execute>));
|
||||
});
|
||||
const executing = () => [...view.dom.querySelectorAll(".cm-openidea-db-executing")].map((e) => e.textContent);
|
||||
const elapsed = () => view.dom.querySelector(".cm-openidea-db-elapsed")?.textContent;
|
||||
|
||||
let pending!: Promise<void>;
|
||||
await act(async () => {
|
||||
pending = executeScriptInView(view, PATH);
|
||||
await vi.waitFor(() => expect(backend.execute).toHaveBeenCalled());
|
||||
});
|
||||
expect(executing()).toEqual(["SELECT 1", "SELECT 2"]);
|
||||
expect(elapsed()).toMatch(/^Executing… \d+ ms$/);
|
||||
expect(view.dom.querySelector(".cm-openidea-db-run-executing")).not.toBeNull();
|
||||
|
||||
// Typing above moves the marks with their text.
|
||||
act(() => view.dispatch({ changes: { from: 0, insert: "-- a longer note above\n" } }));
|
||||
expect(executing()).toEqual(["SELECT 1", "SELECT 2"]);
|
||||
|
||||
await act(async () => {
|
||||
finish();
|
||||
await pending;
|
||||
});
|
||||
expect(executing()).toEqual([]);
|
||||
expect(elapsed()).toBeUndefined();
|
||||
// The outcomes land on the statements, not on where they were when sent.
|
||||
const lines = [...view.dom.querySelectorAll(".cm-openidea-db-gutter .cm-gutterElement")]
|
||||
.filter((e) => e.querySelector(".cm-openidea-db-run-ok"))
|
||||
.map((e) => e.getBoundingClientRect().top);
|
||||
expect(lines).toHaveLength(2);
|
||||
expect(view.dom.querySelectorAll(".cm-openidea-db-timing")).toHaveLength(2);
|
||||
expect(view.state.doc.lineAt(view.posAtDOM(view.dom.querySelector(".cm-openidea-db-timing")!)).text).toBe(
|
||||
"SELECT 1;",
|
||||
);
|
||||
view.destroy();
|
||||
});
|
||||
});
|
||||
@@ -157,6 +157,7 @@ export function activate(): () => void {
|
||||
manualCommit: new Set(),
|
||||
pendingTx: new Set(),
|
||||
running: {},
|
||||
executions: {},
|
||||
dialog: null,
|
||||
newMenuOpen: false,
|
||||
});
|
||||
|
||||
@@ -67,6 +67,7 @@ import {
|
||||
useDatabase,
|
||||
withConnection,
|
||||
} from "./store";
|
||||
import { provideToolWindowService } from "@/workbench/contributions";
|
||||
|
||||
const initial = useDatabase.getState();
|
||||
const initialProject = useProject.getState();
|
||||
@@ -129,6 +130,8 @@ function switchProject(project: ProjectInfo) {
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
// `showServiceView` reaches the real service, not the mocked accessor above.
|
||||
provideToolWindowService({ show: ui.show } as never);
|
||||
vi.resetAllMocks();
|
||||
useProject.setState({ project: projectA });
|
||||
savedSources = [pg, other];
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
/**
|
||||
* Pure helpers of the result views: IDEA's local filter and client-side sort
|
||||
* of loaded rows, search in the grid, paging of console results, the
|
||||
* Aggregates of a selection, and the series of the chart.
|
||||
* Aggregates of a selection, the series of the chart, and how long a statement took.
|
||||
*/
|
||||
import type { Cell } from "./model";
|
||||
|
||||
@@ -462,3 +462,8 @@ export function pageWindow({ page, pageSize, rows, hasMore, total }: PageState):
|
||||
export function pageFetch(page: number, pageSize: number): { maxRows: number; skip: number } {
|
||||
return { maxRows: pageSize, skip: page * pageSize };
|
||||
}
|
||||
|
||||
/** A statement's run time as IDEA shows it: `840 ms`, `3.2 s`. */
|
||||
export function formatElapsed(ms: number): string {
|
||||
return ms < 1000 ? `${Math.round(ms)} ms` : `${(ms / 1000).toFixed(1)} s`;
|
||||
}
|
||||
@@ -9,6 +9,7 @@ import { ResultsView } from "./ResultsView";
|
||||
import { executeConsole, explainConsole, pinResult, rerunResult, useDatabase, type ResultTab } from "./store";
|
||||
import { registerResultTabActions } from "./resultTabActions";
|
||||
import { activeTableEditor, installTableEditorFocus } from "./tableEditorFocus";
|
||||
import { provideToolWindowService } from "@/workbench/contributions";
|
||||
|
||||
const backend = vi.hoisted(() => ({
|
||||
driver: "postgres" as DbDriver,
|
||||
@@ -95,6 +96,7 @@ function show(text: string, columns: Array<{ name: string }>, rows: (string | nu
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
provideToolWindowService({ show: () => {} } as never);
|
||||
vi.clearAllMocks();
|
||||
backend.statements.mockImplementation((_id: unknown, text: string) =>
|
||||
Promise.resolve({ status: "ok", data: [{ from: 0, to: text.length, text }] }),
|
||||
@@ -809,3 +811,64 @@ describe("result tab reuse (IDEA: new results replace the console's unpinned tab
|
||||
expect(useDatabase.getState().activeResult).toBe(fresh);
|
||||
});
|
||||
});
|
||||
|
||||
describe("a console request in flight", () => {
|
||||
const hold = () => {
|
||||
let finish!: () => void;
|
||||
const gate = new Promise<void>((resolve) => {
|
||||
finish = resolve;
|
||||
});
|
||||
const execute = backend.execute.getMockImplementation()!;
|
||||
backend.execute.mockImplementationOnce(async (...args: unknown[]) => {
|
||||
await gate;
|
||||
return execute(...(args as Parameters<typeof execute>));
|
||||
});
|
||||
return () => finish();
|
||||
};
|
||||
|
||||
it("shows that it is executing instead of No results on a first run", async () => {
|
||||
show("SELECT 1", [{ name: "id" }], [["1"]]);
|
||||
useDatabase.setState({ results: [], activeResult: null, consoles: { "console.sql": "pg" } });
|
||||
const finish = hold();
|
||||
await act(async () => render(<ResultsView />));
|
||||
let pending!: Promise<unknown>;
|
||||
await act(async () => {
|
||||
pending = executeConsole("console.sql", "SELECT pg_sleep(5)", 0, 0);
|
||||
await vi.waitFor(() => expect(backend.execute).toHaveBeenCalled());
|
||||
});
|
||||
expect(screen.queryByText("No results")).toBeNull();
|
||||
expect(screen.getByText("Executing in console.sql…").parentElement).toHaveTextContent(/\d+ ms$/);
|
||||
await act(async () => {
|
||||
finish();
|
||||
await pending;
|
||||
});
|
||||
expect(screen.queryByText(/Executing in/)).toBeNull();
|
||||
expect(useDatabase.getState().executions).toEqual({});
|
||||
});
|
||||
|
||||
it("keeps the previous result visible while the next run executes", async () => {
|
||||
show("SELECT * FROM users", [{ name: "id" }, { name: "name" }], [["1", "Ann"]]);
|
||||
useDatabase.setState({ consoles: { "console.sql": "pg" } });
|
||||
backend.statements.mockResolvedValueOnce({
|
||||
status: "ok",
|
||||
data: [
|
||||
{ from: 0, to: 8, text: "SELECT 1" },
|
||||
{ from: 10, to: 18, text: "SELECT 2" },
|
||||
],
|
||||
});
|
||||
const finish = hold();
|
||||
await act(async () => render(<ResultsView />));
|
||||
let pending!: Promise<unknown>;
|
||||
await act(async () => {
|
||||
pending = executeConsole("console.sql", "SELECT 1; SELECT 2", 0, 18);
|
||||
await vi.waitFor(() => expect(backend.execute).toHaveBeenCalled());
|
||||
});
|
||||
expect(screen.getByText("Executing 2 statements in console.sql…")).toBeTruthy();
|
||||
expect(screen.getByText("Ann")).toBeTruthy();
|
||||
await act(async () => {
|
||||
finish();
|
||||
await pending;
|
||||
});
|
||||
expect(screen.queryByText(/Executing/)).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -174,6 +174,12 @@ export interface SourceCatalog {
|
||||
databases: Record<string, DbCatalogSchema[]>;
|
||||
}
|
||||
|
||||
export interface ConsoleExecution {
|
||||
startedAt: number;
|
||||
/** Statements submitted (a batch runs them in order; the backend doesn't say which one is current). */
|
||||
statements: number;
|
||||
}
|
||||
|
||||
interface DatabaseState {
|
||||
sources: DataSource[];
|
||||
loaded: boolean;
|
||||
@@ -205,6 +211,8 @@ interface DatabaseState {
|
||||
output: OutputLine[];
|
||||
/** Console path → running request. */
|
||||
running: Record<string, RequestId>;
|
||||
/** Console path → what its running request submitted, and since when (ms since the epoch). */
|
||||
executions: Record<string, ConsoleExecution>;
|
||||
maxRows: number;
|
||||
dialog: DialogState | null;
|
||||
/** Target of the tree's lead node. */
|
||||
@@ -271,6 +279,7 @@ export const useDatabase = create<DatabaseState>(() => ({
|
||||
activeResult: null,
|
||||
output: [],
|
||||
running: {},
|
||||
executions: {},
|
||||
maxRows: 500,
|
||||
dialog: null,
|
||||
selectedSource: null,
|
||||
@@ -1233,6 +1242,8 @@ export async function executeConsole(
|
||||
text: string,
|
||||
from: number,
|
||||
to: number,
|
||||
/** Called once the statements are submitted, with what was submitted. */
|
||||
onStart?: (statements: readonly SqlStatement[]) => void,
|
||||
): Promise<DbStatementOutcome[]> {
|
||||
const id = consoleSource(path);
|
||||
if (!id) {
|
||||
@@ -1252,8 +1263,14 @@ export async function executeConsole(
|
||||
const prev = useDatabase.getState().running[path];
|
||||
if (prev) void commands.cancelRequest(prev);
|
||||
const request = nextRequestId();
|
||||
useDatabase.setState((s) => ({ running: { ...s.running, [path]: request } }));
|
||||
useDatabase.setState((s) => ({
|
||||
running: { ...s.running, [path]: request },
|
||||
executions: { ...s.executions, [path]: { startedAt: Date.now(), statements: statements.length } },
|
||||
}));
|
||||
onStart?.(statements);
|
||||
try {
|
||||
// IDEA brings the results up as the run starts, showing it executing.
|
||||
if (!inEditorResults()) showServiceView(RESULTS_VIEW, false);
|
||||
const pageSize = useDatabase.getState().maxRows;
|
||||
const schema = consoleSchema(path) || (await loadCompletion(id))?.defaultSchema || "";
|
||||
if (!current()) return [];
|
||||
@@ -1296,7 +1313,9 @@ export async function executeConsole(
|
||||
if (s.running[path] !== request) return s;
|
||||
const running = { ...s.running };
|
||||
delete running[path];
|
||||
return { running };
|
||||
const executions = { ...s.executions };
|
||||
delete executions[path];
|
||||
return { running, executions };
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -14,6 +14,7 @@ import {
|
||||
type ClassSort,
|
||||
} from "./editor/classRows";
|
||||
import styles from "./HeapSnapshotEditor.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
const COLUMNS: ReadonlyArray<{ key: ClassSort; label: string; numeric: boolean; diff?: boolean }> = [
|
||||
{ key: "name", label: "Class", numeric: false },
|
||||
@@ -66,6 +67,7 @@ export function HeapClasses({
|
||||
selected: number | null;
|
||||
onSelect: (row: HeapClassRow | null) => void;
|
||||
}) {
|
||||
const rowHeight = useRowHeight(22);
|
||||
const tx = useTx();
|
||||
const [query, setQuery] = useState<ClassQuery>(DEFAULT_CLASS_QUERY);
|
||||
const compared = changes !== null;
|
||||
@@ -124,7 +126,7 @@ export function HeapClasses({
|
||||
renderItem={(r) => <ClassRow row={r} changes={changes} />}
|
||||
activeIndex={selected === null ? -1 : rows.findIndex((r) => r.classIndex === selected)}
|
||||
onActiveChange={(i) => onSelect(rows[i] ?? null)}
|
||||
rowHeight={22}
|
||||
rowHeight={rowHeight}
|
||||
tableBody={{ headerRows: 1 }}
|
||||
empty={<span className={styles.note}>{tx("No matches")}</span>}
|
||||
/>
|
||||
|
||||
@@ -6,6 +6,7 @@ import { formatBytes } from "../../memory/rows";
|
||||
import { useHeapQuery } from "./heapQuery";
|
||||
import { ObjectText } from "./ObjectText";
|
||||
import styles from "../HeapSnapshotEditor.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
const LIMIT = 100;
|
||||
|
||||
@@ -21,6 +22,7 @@ export function BiggestObjects({
|
||||
selected: number | null;
|
||||
onSelect: (object: HeapObjectRow) => void;
|
||||
}) {
|
||||
const rowHeight = useRowHeight(22);
|
||||
const tx = useTx();
|
||||
const page = useHeapQuery(`${snapshot}:${cls.classIndex}`, () =>
|
||||
call(commands.debugHeapDominators(snapshot, null, cls.classIndex, 0, LIMIT)),
|
||||
@@ -70,7 +72,7 @@ export function BiggestObjects({
|
||||
)}
|
||||
activeIndex={selected === null ? -1 : rows.findIndex((o) => o.object === selected)}
|
||||
onActiveChange={(i) => rows[i] && onSelect(rows[i])}
|
||||
rowHeight={22}
|
||||
rowHeight={rowHeight}
|
||||
tableBody={{ headerRows: 1 }}
|
||||
/>
|
||||
</div>
|
||||
|
||||
@@ -24,6 +24,7 @@ import { keepKeysOnButton } from "./rowButtonKeys";
|
||||
import { columnsOf, formatBytes, formatCount, formatDelta, queryFor, visibleRows, type SortKey } from "./rows";
|
||||
import { unavailableText } from "./unavailableText";
|
||||
import styles from "./MemoryView.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
const COLUMNS: ReadonlyArray<{ key: SortKey; label: string; numeric: boolean }> = [
|
||||
{ key: "name", label: "Class", numeric: false },
|
||||
@@ -105,6 +106,7 @@ function ClassRow({
|
||||
}
|
||||
|
||||
export function MemoryView({ session }: { session: DebugSession }) {
|
||||
const rowHeight = useRowHeight(22);
|
||||
// Also re-renders the reason text, which reads the catalog when called.
|
||||
const tx = useTx();
|
||||
const id = session.id;
|
||||
@@ -248,7 +250,7 @@ export function MemoryView({ session }: { session: DebugSession }) {
|
||||
onActivate={(r, _i, e) => {
|
||||
if (e.type === "keydown" && listsInstances && paused) showInstancesOf(r.name);
|
||||
}}
|
||||
rowHeight={22}
|
||||
rowHeight={rowHeight}
|
||||
tableBody={{ headerRows: 1 }}
|
||||
empty={<span className={styles.note}>{tx("No matches")}</span>}
|
||||
/>
|
||||
|
||||
@@ -172,31 +172,72 @@
|
||||
}
|
||||
|
||||
/* evaluate dialog */
|
||||
.evalDialog {
|
||||
height: min(440px, 100%);
|
||||
}
|
||||
|
||||
.evalBody {
|
||||
height: 100%;
|
||||
box-sizing: border-box;
|
||||
padding: 12px 14px;
|
||||
padding: var(--space-2) var(--space-3) 0;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
gap: 10px;
|
||||
gap: var(--space-2);
|
||||
}
|
||||
|
||||
.evalExpression,
|
||||
.evalResult {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
min-height: 0;
|
||||
gap: var(--space-1);
|
||||
}
|
||||
|
||||
/* Long fragments scroll inside the field so the result keeps its own space. */
|
||||
.evalExpression {
|
||||
max-height: 50%;
|
||||
}
|
||||
|
||||
.evalImport {
|
||||
flex: none;
|
||||
max-height: 40%;
|
||||
overflow: auto;
|
||||
padding: var(--space-1);
|
||||
display: flex;
|
||||
flex-wrap: wrap;
|
||||
align-items: center;
|
||||
align-content: start;
|
||||
gap: var(--space-1) var(--space-2);
|
||||
border-bottom: 1px solid var(--border);
|
||||
}
|
||||
|
||||
.evalImport > button {
|
||||
max-width: 100%;
|
||||
height: auto;
|
||||
min-height: var(--h-control);
|
||||
white-space: normal;
|
||||
overflow-wrap: anywhere;
|
||||
}
|
||||
|
||||
/* Grows with the dialog when it is resized. */
|
||||
.evalResult {
|
||||
flex: 1;
|
||||
min-height: 220px;
|
||||
}
|
||||
|
||||
.evalResultContent {
|
||||
flex: 1;
|
||||
min-height: 0;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
border: 1px solid var(--border-popup);
|
||||
border-radius: var(--radius-small);
|
||||
padding: 4px 6px;
|
||||
padding: var(--space-0-5) var(--space-1);
|
||||
overflow: hidden;
|
||||
}
|
||||
|
||||
.evalHint {
|
||||
padding: var(--space-2);
|
||||
color: var(--fg-muted);
|
||||
font-size: var(--fs-small);
|
||||
overflow: auto;
|
||||
}
|
||||
|
||||
.chooser {
|
||||
@@ -259,33 +300,38 @@
|
||||
/* Evaluate: a field that grows with ⇧Enter, like IDEA's expression editor. */
|
||||
.evalInputRow {
|
||||
display: flex;
|
||||
align-items: flex-start;
|
||||
gap: var(--space-1);
|
||||
}
|
||||
.evalInput {
|
||||
flex: 1;
|
||||
min-width: 0;
|
||||
min-height: var(--h-field, 28px);
|
||||
padding: 5px 8px;
|
||||
resize: none;
|
||||
appearance: none;
|
||||
border: 0;
|
||||
min-height: 0;
|
||||
border-radius: var(--radius-control, 4px);
|
||||
background: var(--bg-field, var(--bg-button));
|
||||
box-shadow: inset 0 0 0 1px var(--border-button);
|
||||
color: var(--fg-strong);
|
||||
font-family: var(--font-mono);
|
||||
font-size: var(--fs-ui);
|
||||
line-height: 18px;
|
||||
outline: none;
|
||||
-webkit-user-select: text;
|
||||
user-select: text;
|
||||
}
|
||||
.evalInput:focus {
|
||||
.evalInputRow:focus-within {
|
||||
box-shadow:
|
||||
inset 0 0 0 1px var(--focus-ring),
|
||||
0 0 0 1px var(--focus-ring);
|
||||
}
|
||||
.evalInput {
|
||||
flex: 1;
|
||||
min-width: 0;
|
||||
min-height: 0;
|
||||
padding: var(--space-1) var(--space-2);
|
||||
resize: none;
|
||||
appearance: none;
|
||||
border: 0;
|
||||
background: none;
|
||||
color: var(--fg-strong);
|
||||
font-family: var(--font-mono);
|
||||
font-size: var(--fs-code);
|
||||
font-weight: var(--fw-code);
|
||||
line-height: var(--lh-code);
|
||||
outline: none;
|
||||
-webkit-user-select: text;
|
||||
user-select: text;
|
||||
}
|
||||
.evalInput::placeholder {
|
||||
color: var(--fg-faint);
|
||||
}
|
||||
.evalHistory {
|
||||
align-self: flex-start;
|
||||
margin: var(--space-1);
|
||||
}
|
||||
@@ -764,8 +764,9 @@ function EvaluateDialogInner({ initial }: { initial: string }) {
|
||||
const [history, setHistory] = useState(() => readHistory("evaluate"));
|
||||
const [historyMenu, setHistoryMenu] = useState(false);
|
||||
const historyPos = useRef(-1);
|
||||
const historyButton = useRef<HTMLSpanElement>(null);
|
||||
const historyButton = useRef<HTMLButtonElement>(null);
|
||||
const field = useRef<HTMLTextAreaElement>(null);
|
||||
const expressionId = useId();
|
||||
const session = useDebug((s) => (s.active != null ? s.sessions[s.active] : undefined));
|
||||
const paused = session?.status === "paused";
|
||||
const close = () => useOverlays.setState({ evaluate: null });
|
||||
@@ -824,7 +825,10 @@ function EvaluateDialogInner({ initial }: { initial: string }) {
|
||||
onClose={close}
|
||||
title="Evaluate"
|
||||
width={620}
|
||||
minWidth={340}
|
||||
minHeight={240}
|
||||
resizable="both"
|
||||
className={styles.evalDialog}
|
||||
aria-label="Evaluate expression"
|
||||
footerStart={
|
||||
<Button
|
||||
@@ -844,13 +848,14 @@ function EvaluateDialogInner({ initial }: { initial: string }) {
|
||||
]}
|
||||
>
|
||||
<div className={styles.evalBody}>
|
||||
<div className={styles.field}>
|
||||
<span className={styles.label}>
|
||||
<div className={styles.evalExpression}>
|
||||
<label className={styles.label} htmlFor={expressionId}>
|
||||
<T>Expression</T>
|
||||
</span>
|
||||
</label>
|
||||
<div className={styles.evalInputRow}>
|
||||
<textarea
|
||||
ref={field}
|
||||
id={expressionId}
|
||||
className={styles.evalInput}
|
||||
rows={lines}
|
||||
value={expression}
|
||||
@@ -866,19 +871,22 @@ function EvaluateDialogInner({ initial }: { initial: string }) {
|
||||
spellCheck={false}
|
||||
autoComplete="off"
|
||||
data-autofocus=""
|
||||
aria-label={tx("Expression")}
|
||||
placeholder={paused ? "Expression to evaluate in the selected frame" : "Pause the program to evaluate"}
|
||||
placeholder={tx(
|
||||
paused ? "Expression to evaluate in the selected frame" : "Pause the program to evaluate",
|
||||
)}
|
||||
/>
|
||||
{completion.popup}
|
||||
<span ref={historyButton}>
|
||||
<IconButton
|
||||
icon="history"
|
||||
title="History"
|
||||
size="small"
|
||||
disabled={!history.length}
|
||||
onClick={() => setHistoryMenu(true)}
|
||||
/>
|
||||
</span>
|
||||
<IconButton
|
||||
ref={historyButton}
|
||||
className={styles.evalHistory}
|
||||
icon="history"
|
||||
title="History"
|
||||
size="small"
|
||||
aria-haspopup="menu"
|
||||
aria-expanded={historyMenu}
|
||||
disabled={!history.length}
|
||||
onClick={() => setHistoryMenu(true)}
|
||||
/>
|
||||
</div>
|
||||
<Menu
|
||||
open={historyMenu}
|
||||
@@ -891,32 +899,37 @@ function EvaluateDialogInner({ initial }: { initial: string }) {
|
||||
.map((h) => ({ label: h.replace(/\s+/g, " "), verbatim: true, run: () => recall(h) }))}
|
||||
/>
|
||||
</div>
|
||||
{ambiguous && (
|
||||
<div className={styles.evalImport} role="group" aria-label={tx("Class to import")}>
|
||||
<span className={styles.label}>{tx`Choose the class to import for ${className}:`}</span>
|
||||
{ambiguous.candidates.map((c) => (
|
||||
<Button
|
||||
key={c}
|
||||
variant="ghost"
|
||||
size="small"
|
||||
onClick={() => {
|
||||
if (session) rememberImport(session.id, c);
|
||||
void run();
|
||||
}}
|
||||
>
|
||||
{c}
|
||||
</Button>
|
||||
))}
|
||||
</div>
|
||||
)}
|
||||
<div className={styles.evalResult}>
|
||||
{result ? (
|
||||
<VariablesView roots={[result]} session={session?.id ?? null} aria-label="Evaluation result" />
|
||||
) : (
|
||||
<div className={styles.empty}>
|
||||
{paused ? tx("Press Enter to evaluate") : tx("Evaluation is available while the program is suspended")}
|
||||
</div>
|
||||
)}
|
||||
<span className={styles.label}>
|
||||
<T>Result</T>
|
||||
</span>
|
||||
<div className={styles.evalResultContent}>
|
||||
{ambiguous && (
|
||||
<div className={styles.evalImport} role="group" aria-label={tx("Class to import")}>
|
||||
<span className={styles.label}>{tx`Choose the class to import for ${className}:`}</span>
|
||||
{ambiguous.candidates.map((c) => (
|
||||
<Button
|
||||
key={c}
|
||||
variant="ghost"
|
||||
size="small"
|
||||
onClick={() => {
|
||||
if (session) rememberImport(session.id, c);
|
||||
void run();
|
||||
}}
|
||||
>
|
||||
{c}
|
||||
</Button>
|
||||
))}
|
||||
</div>
|
||||
)}
|
||||
{result ? (
|
||||
<VariablesView roots={[result]} session={session?.id ?? null} aria-label="Evaluation result" />
|
||||
) : (
|
||||
<div className={styles.evalHint}>
|
||||
{paused ? tx("Press Enter to evaluate") : tx("Evaluation is available while the program is suspended")}
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</Dialog>
|
||||
|
||||
@@ -10,12 +10,12 @@
|
||||
.row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 5px;
|
||||
gap: var(--space-1);
|
||||
min-width: 0;
|
||||
width: 100%;
|
||||
max-width: 100%;
|
||||
box-sizing: border-box;
|
||||
font-family: var(--font-mono);
|
||||
font-family: var(--font-ui);
|
||||
font-size: var(--fs-ui);
|
||||
white-space: pre;
|
||||
color: var(--fg);
|
||||
@@ -23,17 +23,27 @@
|
||||
}
|
||||
|
||||
.name {
|
||||
flex: none;
|
||||
min-width: 0;
|
||||
max-width: 45%;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
color: var(--fg);
|
||||
}
|
||||
|
||||
.evalName {
|
||||
flex: 0 1 auto;
|
||||
max-width: 45%;
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
}
|
||||
|
||||
.varName {
|
||||
color: var(--debug-name, var(--syn-property));
|
||||
}
|
||||
|
||||
.nodeIcon {
|
||||
flex: none;
|
||||
margin-right: 1px;
|
||||
}
|
||||
|
||||
.eq {
|
||||
@@ -41,15 +51,28 @@
|
||||
color: var(--fg-subtle);
|
||||
}
|
||||
|
||||
.valueGroup {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-1);
|
||||
min-width: min(8ch, 45%);
|
||||
flex: 1 1 0;
|
||||
}
|
||||
|
||||
.value {
|
||||
min-width: 0;
|
||||
flex: 1 1 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
font-family: var(--font-mono);
|
||||
}
|
||||
|
||||
.showValue {
|
||||
flex: none;
|
||||
flex: 0 0 auto;
|
||||
max-width: 100%;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
padding: 0;
|
||||
border: 0;
|
||||
background: none;
|
||||
@@ -104,6 +127,7 @@
|
||||
|
||||
.type {
|
||||
min-width: 0;
|
||||
max-width: 25%;
|
||||
flex: 0 1 auto;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
@@ -128,7 +152,7 @@
|
||||
|
||||
.editInput {
|
||||
flex: 1;
|
||||
min-width: 80px;
|
||||
min-width: min(80px, 40%);
|
||||
height: 18px;
|
||||
padding: 0 4px;
|
||||
font: inherit;
|
||||
|
||||
@@ -415,7 +415,9 @@ function VarEditRow({
|
||||
useEffect(() => acquirePopup(), []);
|
||||
return (
|
||||
<span className={styles.row}>
|
||||
<span className={styles.name}>{node.name}</span>
|
||||
<span className={styles.name} title={node.name}>
|
||||
{node.name}
|
||||
</span>
|
||||
<span className={styles.eq}>=</span>
|
||||
<input
|
||||
className={clsx(styles.editInput, error && styles.editInvalid)}
|
||||
@@ -465,18 +467,21 @@ function VarRow({
|
||||
const valueRef = useRef<HTMLSpanElement>(null);
|
||||
const [overflow, setOverflow] = useState(false);
|
||||
useLayoutEffect(() => {
|
||||
const el = valueRef.current;
|
||||
if (!el) {
|
||||
const text = valueRef.current;
|
||||
const group = text?.parentElement;
|
||||
if (!text || !group) {
|
||||
setOverflow(false);
|
||||
return;
|
||||
}
|
||||
const update = () => setOverflow(el.scrollWidth > el.clientWidth + 1);
|
||||
// The group measures the space available before the Show button takes any of it.
|
||||
const update = () => setOverflow(text.scrollWidth > group.clientWidth + 1);
|
||||
update();
|
||||
if (typeof ResizeObserver === "undefined") return;
|
||||
const observer = new ResizeObserver(update);
|
||||
observer.observe(el);
|
||||
observer.observe(group);
|
||||
observer.observe(text);
|
||||
return () => observer.disconnect();
|
||||
}, [node.value]);
|
||||
}, [node.value, node.typeName, node.error]);
|
||||
if (node.kind === "message") return <span className={styles.message}>{node.name}</span>;
|
||||
if (node.kind === "scope")
|
||||
return (
|
||||
@@ -487,13 +492,22 @@ function VarRow({
|
||||
);
|
||||
const kind = node.error ? null : classifyValue(node.value, node.typeName);
|
||||
const shown = shownValue(node.value, node.typeName);
|
||||
const evaluation = node.kind === "eval";
|
||||
return (
|
||||
<span className={styles.row}>
|
||||
<span className={styles.row} title={node.name}>
|
||||
<Icon name={nodeIcon(node)} size={16} className={styles.nodeIcon} />
|
||||
{!shown.entry && (
|
||||
<>
|
||||
<span className={clsx(styles.name, node.kind === "var" && styles.varName, changed && styles.changed)}>
|
||||
{node.name}
|
||||
<span
|
||||
className={clsx(
|
||||
styles.name,
|
||||
evaluation && styles.evalName,
|
||||
node.kind === "var" && styles.varName,
|
||||
changed && styles.changed,
|
||||
)}
|
||||
title={evaluation ? node.name : undefined}
|
||||
>
|
||||
{evaluation ? oneLine(node.name) : node.name}
|
||||
</span>
|
||||
<span className={styles.eq}>=</span>
|
||||
</>
|
||||
@@ -502,23 +516,29 @@ function VarRow({
|
||||
<span className={styles.error}>{oneLine(node.error)}</span>
|
||||
) : (
|
||||
<>
|
||||
{shown.label && <span className={styles.type}>{shown.label}</span>}
|
||||
<span ref={valueRef} className={clsx(styles.value, kind && styles[kind])} title={node.value}>
|
||||
{oneLine(shown.text)}
|
||||
</span>
|
||||
{overflow && (
|
||||
<button
|
||||
type="button"
|
||||
className={styles.showValue}
|
||||
title={tx("Show")}
|
||||
onClick={(e) => {
|
||||
e.stopPropagation();
|
||||
onShowValue(node);
|
||||
}}
|
||||
>
|
||||
…{tx("Show")}
|
||||
</button>
|
||||
{shown.label && (
|
||||
<span className={styles.type} title={shown.label}>
|
||||
{shown.label}
|
||||
</span>
|
||||
)}
|
||||
<span className={styles.valueGroup}>
|
||||
<span ref={valueRef} className={clsx(styles.value, kind && styles[kind])} title={node.value}>
|
||||
{oneLine(shown.text)}
|
||||
</span>
|
||||
{overflow && (
|
||||
<button
|
||||
type="button"
|
||||
className={styles.showValue}
|
||||
title={tx("Show")}
|
||||
onClick={(e) => {
|
||||
e.stopPropagation();
|
||||
onShowValue(node);
|
||||
}}
|
||||
>
|
||||
…{tx("Show")}
|
||||
</button>
|
||||
)}
|
||||
</span>
|
||||
</>
|
||||
)}
|
||||
</span>
|
||||
|
||||
@@ -18,6 +18,7 @@ import {
|
||||
import type { CloneSourceProps } from "@/workbench/contributions";
|
||||
import { openInBrowser } from "../data/local";
|
||||
import styles from "./GitHubCloneSource.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
type Row = { repo: GhAccountRepo; indices: number[] | null };
|
||||
|
||||
@@ -32,6 +33,7 @@ export function matchRepos(repos: readonly GhAccountRepo[], query: string): Row[
|
||||
}
|
||||
|
||||
export function GitHubCloneSource({ url, onUrl, onClone, disabled }: CloneSourceProps) {
|
||||
const rowHeight = useRowHeight(26);
|
||||
const [state, setState] = useState<GhAccountRepos | null>(null);
|
||||
const [query, setQuery] = useState("");
|
||||
const [attempt, setAttempt] = useState(0);
|
||||
@@ -140,7 +142,7 @@ export function GitHubCloneSource({ url, onUrl, onClone, disabled }: CloneSource
|
||||
activeIndex={active}
|
||||
onActiveChange={pick}
|
||||
focusable={false}
|
||||
rowHeight={26}
|
||||
rowHeight={rowHeight}
|
||||
empty={
|
||||
<span className={styles.muted}>
|
||||
<T>{state.repos.length ? "No matching repositories" : "No repositories"}</T>
|
||||
|
||||
@@ -16,6 +16,7 @@ import { prettyDate } from "../ui/prettyDate";
|
||||
import { commitDescription } from "./model";
|
||||
import { selectCommit, useCreatePr, type CreateChange } from "./store";
|
||||
import styles from "./Create.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
function Centered({ children, error }: { children: ReactNode; error?: boolean }) {
|
||||
return <div className={error ? `${styles.centered} ${styles.errorText}` : styles.centered}>{children}</div>;
|
||||
@@ -170,6 +171,7 @@ function showDiff(all: readonly CreateChange[], first: CreateChange) {
|
||||
}
|
||||
|
||||
function ChangesTree() {
|
||||
const rowHeight = useRowHeight(22);
|
||||
const changes = useCreatePr((s) => s.changes);
|
||||
const files = changes?.state === "ok" ? changes.value : null;
|
||||
const roots = useMemo(() => (files ? buildFileTree(files, (f) => f.path) : []), [files]);
|
||||
@@ -219,7 +221,7 @@ function ChangesTree() {
|
||||
selected={selection}
|
||||
onSelectionChange={setSelection}
|
||||
multiSelect
|
||||
rowHeight={22}
|
||||
rowHeight={rowHeight}
|
||||
aria-label="Changes"
|
||||
speedSearch
|
||||
onActivate={(n) => n.file && showDiff(ordered, n.file)}
|
||||
|
||||
@@ -178,7 +178,6 @@ function HeadPopup(props: { anchor: HTMLElement; initialRepo: GHRemote; onClose:
|
||||
onActivate={(r) => choose(r)}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={24}
|
||||
className={styles.headList}
|
||||
aria-label="Branches"
|
||||
empty={<div className={styles.hint}>{tx("Nothing to show")}</div>}
|
||||
|
||||
@@ -78,7 +78,6 @@ export function BranchWidget({
|
||||
getKey={(a) => a}
|
||||
onActivate={(a) => run(a)}
|
||||
hoverSelects
|
||||
rowHeight={24}
|
||||
aria-label={tx("Branches")}
|
||||
renderItem={(a, state) => (
|
||||
<div className={styles.popupRow} data-active={state.active || undefined}>
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/** Bounded local configuration evidence, never an effective runtime identity. */
|
||||
import type { FileEntry } from "@/platform/ipc";
|
||||
import { isErrorKind, type FileEntry } from "@/platform/ipc";
|
||||
import { ipcPath } from "@/platform/paths";
|
||||
|
||||
export interface ServiceReader {
|
||||
@@ -90,7 +90,7 @@ export async function loadServiceName(module: string, reader: ServiceReader): Pr
|
||||
try {
|
||||
entries = await reader.directory(directory);
|
||||
} catch (error) {
|
||||
if ((error as { kind?: string }).kind === "notFound") continue;
|
||||
if (isErrorKind(error, "notFound")) continue;
|
||||
return null;
|
||||
}
|
||||
for (const file of entries) {
|
||||
|
||||
@@ -86,7 +86,6 @@ function EditMacrosDialog({ onClose }: { onClose: () => void }) {
|
||||
getKey={(m) => m.name}
|
||||
activeIndex={Math.min(active, saved.length - 1)}
|
||||
onActiveChange={setActive}
|
||||
rowHeight={24}
|
||||
className={styles.list}
|
||||
aria-label="Macros"
|
||||
empty={
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
/** Installed plugins, their UI contributions, the selected plugin theme, and the operations on them. */
|
||||
import { create } from "zustand";
|
||||
import { tx } from "@/platform/i18n";
|
||||
import { isErrorKind } from "@/platform/ipc";
|
||||
import type {
|
||||
ActiveTheme,
|
||||
CapabilityInfo,
|
||||
@@ -412,7 +413,7 @@ export async function runPluginCommand(
|
||||
const status = usePlugins.getState().plugins.find((p) => p.id === pluginId)?.status;
|
||||
// A trap disables the plugin and the backend already announced why; a
|
||||
// consent request opens its own dialog.
|
||||
const permission = (e as { kind?: string }).kind === "permissionDenied";
|
||||
const permission = isErrorKind(e, "permissionDenied");
|
||||
if (status !== "failed" && !permission)
|
||||
notifications().notify({ group: "plugins", level: "error", title: `${title} failed`, body: errorText(e) });
|
||||
return null;
|
||||
|
||||
@@ -79,7 +79,6 @@ function NewPopup({ at, items }: { at: { x: number; y: number }; items: MenuItem
|
||||
onActivate={(r) => pick(r)}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={24}
|
||||
className={styles.list}
|
||||
aria-label="File types"
|
||||
empty={
|
||||
|
||||
@@ -1,61 +1,67 @@
|
||||
.popup {
|
||||
width: 620px;
|
||||
max-width: calc(100vw - 32px);
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
width: min(670px, calc(100vw - 32px));
|
||||
overflow: hidden;
|
||||
}
|
||||
.body {
|
||||
flex: 1 1 auto;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
min-height: 0;
|
||||
font-family: var(--font-ui);
|
||||
}
|
||||
.header {
|
||||
flex: none;
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-2);
|
||||
height: var(--h-row);
|
||||
padding: 4px 10px 0;
|
||||
font-size: var(--fs-small);
|
||||
color: var(--fg-subtle);
|
||||
min-height: var(--h-field);
|
||||
padding: var(--space-0-5) var(--space-3);
|
||||
border-bottom: 1px solid var(--border-popup);
|
||||
background: var(--bg-frame, var(--bg-app));
|
||||
}
|
||||
.title {
|
||||
flex: 1;
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
font-size: var(--fs-ui);
|
||||
font-weight: 600;
|
||||
color: var(--fg-strong);
|
||||
}
|
||||
.link {
|
||||
flex: none;
|
||||
max-width: 50%;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
padding: 0;
|
||||
border: 0;
|
||||
background: none;
|
||||
color: var(--link);
|
||||
font: inherit;
|
||||
font-size: var(--fs-small);
|
||||
cursor: pointer;
|
||||
}
|
||||
.link:hover {
|
||||
color: var(--link-hover);
|
||||
}
|
||||
.inputRow {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-1-5);
|
||||
padding: 6px 10px;
|
||||
border-bottom: 1px solid var(--border-popup);
|
||||
}
|
||||
.inputIcon {
|
||||
.query {
|
||||
flex: none;
|
||||
color: var(--fg-subtle);
|
||||
}
|
||||
.input {
|
||||
flex: 1;
|
||||
font-family: var(--font-ui);
|
||||
padding: var(--space-2);
|
||||
}
|
||||
.rows {
|
||||
max-height: 360px;
|
||||
height: auto;
|
||||
flex: 1 1 auto;
|
||||
min-height: var(--h-row);
|
||||
max-height: 600px;
|
||||
overflow-x: hidden;
|
||||
}
|
||||
.section {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
width: 100%;
|
||||
gap: 10px;
|
||||
gap: var(--space-3);
|
||||
padding: 0;
|
||||
font-size: var(--fs-small);
|
||||
color: var(--fg-subtle);
|
||||
@@ -93,23 +99,35 @@
|
||||
.detail {
|
||||
flex: 0 1 auto;
|
||||
min-width: 0;
|
||||
max-width: 45%;
|
||||
max-width: min(36%, 26ch);
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
font-style: italic;
|
||||
margin-left: auto;
|
||||
color: var(--fg-subtle);
|
||||
font-size: var(--fs-small);
|
||||
white-space: nowrap;
|
||||
}
|
||||
.activeRow .detail {
|
||||
color: var(--fg);
|
||||
}
|
||||
.empty {
|
||||
padding: 6px 10px;
|
||||
padding: var(--space-1) var(--space-3) var(--space-2);
|
||||
color: var(--fg-subtle);
|
||||
font-size: var(--fs-small);
|
||||
}
|
||||
.footer {
|
||||
padding: 6px 10px;
|
||||
flex: none;
|
||||
display: flex;
|
||||
flex-wrap: wrap;
|
||||
align-items: center;
|
||||
gap: var(--space-0-5) var(--space-3);
|
||||
padding: var(--space-1-5) var(--space-3);
|
||||
border-top: 1px solid var(--border-popup);
|
||||
font-size: var(--fs-small);
|
||||
color: var(--fg-subtle);
|
||||
}
|
||||
.navigationHint {
|
||||
display: inline-flex;
|
||||
align-items: center;
|
||||
gap: var(--space-1);
|
||||
}
|
||||
@@ -4,14 +4,15 @@
|
||||
* the selected entry, or the line itself: a provider that claims it, else the
|
||||
* shell in the project directory, its output in the Run tool window.
|
||||
*/
|
||||
import { useMemo, useState, type KeyboardEvent } from "react";
|
||||
import { useId, useMemo, useRef, useState, type KeyboardEvent } from "react";
|
||||
import clsx from "clsx";
|
||||
import { create } from "zustand";
|
||||
import { executeAction } from "@/platform/actions";
|
||||
import { usePlatform } from "@/platform/platformInfo";
|
||||
import { useProject } from "@/platform/project";
|
||||
import { Icon, Input, List, Popup, T, listNavigate } from "@/ui";
|
||||
import { Icon, Kbd, List, Popup, SearchField, T, firstSelectable, listNavigate } from "@/ui";
|
||||
import { runAnythingProviderList } from "@/workbench/contributions";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import { buildRows, clearHistory, pushHistory, readHistory, shellRunConfig, type Row } from "./model";
|
||||
import styles from "./RunAnything.module.css";
|
||||
|
||||
@@ -44,8 +45,13 @@ export function RunAnythingHost() {
|
||||
}
|
||||
|
||||
const isSection = (r: Row) => r.kind === "section";
|
||||
const ROW_HEIGHT = 24;
|
||||
const commandAnchor = { getBoundingClientRect: () => new DOMRect(window.innerWidth / 2, 72, 0, 0) };
|
||||
|
||||
function RunAnythingPopup({ root }: { root: string }) {
|
||||
const field = useRef<HTMLInputElement>(null);
|
||||
const rowHeight = useRowHeight(ROW_HEIGHT);
|
||||
const listId = useId();
|
||||
const [line, setLine] = useState("");
|
||||
const [active, setActive] = useState(-1);
|
||||
const [history, setHistory] = useState(() => readHistory(root));
|
||||
@@ -57,6 +63,10 @@ function RunAnythingPopup({ root }: { root: string }) {
|
||||
}),
|
||||
[line, history],
|
||||
);
|
||||
const selected = rows[active];
|
||||
const first = firstSelectable(rows, isSection);
|
||||
const hasRows = first >= 0;
|
||||
const command = selected?.kind === "item" ? (selected.item.completion ?? selected.item.label) : line;
|
||||
|
||||
const run = (row: Row | undefined) => {
|
||||
if (!row || row.kind !== "item") return;
|
||||
@@ -75,21 +85,25 @@ function RunAnythingPopup({ root }: { root: string }) {
|
||||
setActive(-1);
|
||||
};
|
||||
|
||||
const onKeyDown = (e: KeyboardEvent) => {
|
||||
const onKeyDown = (e: KeyboardEvent<HTMLInputElement>) => {
|
||||
if (e.nativeEvent.isComposing || e.altKey || e.ctrlKey || e.metaKey) return;
|
||||
if (["ArrowDown", "ArrowUp", "PageDown", "PageUp"].includes(e.key)) {
|
||||
const next = listNavigate(e.key, { items: rows, active: Math.max(active, 0), wrap: true, isSection });
|
||||
if (next !== null) {
|
||||
const height = e.currentTarget.ownerDocument.getElementById(listId)?.clientHeight ?? rowHeight;
|
||||
const pageSize = Math.max(1, Math.floor(height / rowHeight) - 1);
|
||||
const next = listNavigate(e.key, { items: rows, active, wrap: true, isSection, pageSize });
|
||||
if (next !== null && hasRows) {
|
||||
e.preventDefault();
|
||||
setActive(active < 0 && e.key === "ArrowDown" ? rows.findIndex((r) => !isSection(r)) : next);
|
||||
setActive(next < 0 ? first : next);
|
||||
}
|
||||
return;
|
||||
}
|
||||
if (e.key === "Tab") {
|
||||
if (e.key === "Tab" && !e.shiftKey && hasRows) {
|
||||
e.preventDefault();
|
||||
complete(rows[active >= 0 ? active : rows.findIndex((r) => !isSection(r))]);
|
||||
e.stopPropagation();
|
||||
complete(selected ?? rows[first]);
|
||||
} else if (e.key === "Enter") {
|
||||
e.preventDefault();
|
||||
if (active >= 0) run(rows[active]);
|
||||
if (selected) run(selected);
|
||||
else runLine();
|
||||
}
|
||||
};
|
||||
@@ -97,7 +111,7 @@ function RunAnythingPopup({ root }: { root: string }) {
|
||||
return (
|
||||
<Popup
|
||||
open
|
||||
anchor={{ x: window.innerWidth / 2, y: 72 }}
|
||||
anchor={commandAnchor}
|
||||
placement="bottom"
|
||||
onClose={close}
|
||||
role="dialog"
|
||||
@@ -117,59 +131,83 @@ function RunAnythingPopup({ root }: { root: string }) {
|
||||
onClick={() => {
|
||||
clearHistory(root);
|
||||
setHistory([]);
|
||||
setActive(-1);
|
||||
field.current?.focus();
|
||||
}}
|
||||
>
|
||||
<T>Clear History</T>
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
<div className={styles.inputRow}>
|
||||
<Icon name="run-anything" size={16} className={styles.inputIcon} />
|
||||
<Input
|
||||
<div className={styles.query}>
|
||||
<SearchField
|
||||
ref={field}
|
||||
data-autofocus
|
||||
variant="bare"
|
||||
className={styles.input}
|
||||
value={line}
|
||||
leadingIcon="run-anything"
|
||||
clearable={false}
|
||||
role="combobox"
|
||||
aria-autocomplete="list"
|
||||
aria-expanded={hasRows}
|
||||
aria-controls={hasRows ? listId : undefined}
|
||||
aria-activedescendant={selected?.kind === "item" ? `${listId}-${active}` : undefined}
|
||||
value={command}
|
||||
placeholder="Run a command, configuration or goal"
|
||||
aria-label="Command line"
|
||||
onChange={(e) => {
|
||||
setLine(e.target.value);
|
||||
onChange={(value) => {
|
||||
setLine(value);
|
||||
setActive(-1);
|
||||
}}
|
||||
onKeyDown={onKeyDown}
|
||||
/>
|
||||
</div>
|
||||
<List
|
||||
items={rows}
|
||||
getKey={(r) => r.key}
|
||||
isSection={isSection}
|
||||
renderSection={(r) => <div className={styles.section}>{r.kind === "section" && <T>{r.label}</T>}</div>}
|
||||
activeIndex={active}
|
||||
onActiveChange={setActive}
|
||||
onActivate={(r) => run(r)}
|
||||
focusable={false}
|
||||
hoverSelects={false}
|
||||
rowHeight={24}
|
||||
className={styles.rows}
|
||||
aria-label="Run Anything entries"
|
||||
empty={
|
||||
<div className={styles.empty}>
|
||||
{line.trim() ? <T>Press Enter to run the command in the project directory</T> : <T>Type a command</T>}
|
||||
{hasRows ? (
|
||||
<>
|
||||
<List
|
||||
id={listId}
|
||||
items={rows}
|
||||
getKey={(r) => r.key}
|
||||
isSection={isSection}
|
||||
renderSection={(r) => <div className={styles.section}>{r.kind === "section" && <T>{r.label}</T>}</div>}
|
||||
activeIndex={active}
|
||||
onActiveChange={setActive}
|
||||
onActivate={(r) => run(r)}
|
||||
focusable={false}
|
||||
hoverSelects={false}
|
||||
rowHeight={rowHeight}
|
||||
className={styles.rows}
|
||||
aria-label="Run Anything entries"
|
||||
renderItem={(r, state) =>
|
||||
r.kind === "item" ? (
|
||||
<div className={clsx(styles.row, state.active && styles.activeRow)}>
|
||||
<Icon name={r.item.icon ?? "run"} size={16} className={styles.rowIcon} />
|
||||
<span className={styles.label} title={r.item.label}>
|
||||
{r.item.label}
|
||||
</span>
|
||||
{r.item.detail && (
|
||||
<span className={styles.detail} title={r.item.detail}>
|
||||
{r.item.detail}
|
||||
</span>
|
||||
)}
|
||||
</div>
|
||||
) : null
|
||||
}
|
||||
/>
|
||||
<div className={styles.footer}>
|
||||
<span className={styles.navigationHint}>
|
||||
<Kbd>↑</Kbd>
|
||||
<Kbd>↓</Kbd>
|
||||
<T>Navigate</T>
|
||||
</span>
|
||||
<T>Tab to complete, Enter to run</T>
|
||||
</div>
|
||||
}
|
||||
renderItem={(r, state) =>
|
||||
r.kind === "item" ? (
|
||||
<div className={clsx(styles.row, state.active && styles.activeRow)}>
|
||||
<Icon name={r.item.icon ?? "run"} size={16} className={styles.rowIcon} />
|
||||
<span className={styles.label}>{r.item.label}</span>
|
||||
{r.item.detail && <span className={styles.detail}>{r.item.detail}</span>}
|
||||
</div>
|
||||
) : null
|
||||
}
|
||||
/>
|
||||
<div className={styles.footer}>
|
||||
<T>Enter to run, Tab to complete. Other commands run in the project directory.</T>
|
||||
</div>
|
||||
</>
|
||||
) : (
|
||||
line.trim() && (
|
||||
<div className={styles.empty}>
|
||||
<T>Press Enter to run the command in the project directory</T>
|
||||
</div>
|
||||
)
|
||||
)}
|
||||
</div>
|
||||
</Popup>
|
||||
);
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import { useMemo, useState, type KeyboardEvent } from "react";
|
||||
import clsx from "clsx";
|
||||
import { HighlightedText, Icon, List, Popup, SearchField, fuzzyMatch, listNavigate, T, type PopupAnchor } from "@/ui";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import { useRunConfigTypes, runConfigTypes, type RunConfigTypeContribution } from "@/workbench/contributions";
|
||||
import styles from "./Run.module.css";
|
||||
|
||||
@@ -59,6 +60,7 @@ export function AddConfigPopup({
|
||||
onClose: () => void;
|
||||
}) {
|
||||
const types = useRunConfigTypes((s) => s.types);
|
||||
const rowHeight = useRowHeight(ROW);
|
||||
const [query, setQuery] = useState("");
|
||||
const rows = useMemo(() => typeRows(runConfigTypes(types), query), [types, query]);
|
||||
const isSection = (r: TypeRow) => r.kind === "group";
|
||||
@@ -115,7 +117,7 @@ export function AddConfigPopup({
|
||||
variant="bare"
|
||||
/>
|
||||
</div>
|
||||
<div style={{ height: Math.max(ROW, Math.min(rows.length * ROW, 14 * ROW)) }}>
|
||||
<div style={{ height: Math.max(rowHeight, Math.min(rows.length * rowHeight, 14 * rowHeight)) }}>
|
||||
<List<TypeRow>
|
||||
aria-label="Configuration types"
|
||||
className={styles.chooserList}
|
||||
@@ -127,7 +129,7 @@ export function AddConfigPopup({
|
||||
onActiveChange={setActive}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={ROW}
|
||||
rowHeight={rowHeight}
|
||||
onActivate={(r) => pick(r)}
|
||||
empty={
|
||||
<span className={styles.chooserMuted}>
|
||||
|
||||
@@ -16,6 +16,7 @@ import {
|
||||
T,
|
||||
type MenuItem,
|
||||
} from "@/ui";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import type { RunConfig } from "@/platform/ipc";
|
||||
import { useWorkflowSettings } from "@/platform/workflowSettings";
|
||||
import { useDebugRunSessions } from "@/workbench/contributions";
|
||||
@@ -99,7 +100,7 @@ export function buildRows(
|
||||
return rows;
|
||||
}
|
||||
|
||||
const rowHeight = (r: Row) => (r.type === "section" && !r.label ? SEPARATOR : ROW);
|
||||
const heightOf = (r: Row, rowHeight: number) => (r.type === "section" && !r.label ? SEPARATOR : rowHeight);
|
||||
|
||||
let closedAt = 0;
|
||||
/** The chooser closed within the last moment (a click on its own anchor shouldn't reopen it). */
|
||||
@@ -145,6 +146,7 @@ export function mnemonics(rows: readonly Row[]): Map<string, number> {
|
||||
|
||||
function ConfigChooser() {
|
||||
const mode = useRun((s) => s.chooserMode);
|
||||
const rowHeight = useRowHeight(ROW);
|
||||
const configs = useRun((s) => s.configs);
|
||||
const selectedId = useRun((s) => s.selectedId);
|
||||
const temporary = useRun((s) => s.temporary);
|
||||
@@ -285,8 +287,8 @@ function ConfigChooser() {
|
||||
};
|
||||
|
||||
const height = Math.min(
|
||||
rows.reduce((sum, r) => sum + rowHeight(r), 0),
|
||||
14 * ROW,
|
||||
rows.reduce((sum, r) => sum + heightOf(r, rowHeight), 0),
|
||||
14 * rowHeight,
|
||||
);
|
||||
|
||||
// IDEA: a configuration's submenu lists its executors, then Edit and Pin.
|
||||
@@ -366,7 +368,7 @@ function ConfigChooser() {
|
||||
onActiveChange={setActive}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={ROW}
|
||||
rowHeight={rowHeight}
|
||||
onActivate={(r) => activate(r)}
|
||||
renderItem={(r, { active: isActive }) => {
|
||||
if (r.type === "save") {
|
||||
|
||||
@@ -511,6 +511,7 @@ function EditConfigsDialog() {
|
||||
aria-expanded={!collapsed.has(r.key)}
|
||||
className={styles.editItem}
|
||||
style={{ paddingLeft: 6 }}
|
||||
title={tx(r.label)}
|
||||
onClick={() => toggle(r.key)}
|
||||
onDragOver={(e) => e.preventDefault()}
|
||||
onDrop={(e) => onDrop(e, r.kind, null)}
|
||||
@@ -534,6 +535,7 @@ function EditConfigsDialog() {
|
||||
aria-expanded={!collapsed.has(r.key)}
|
||||
className={clsx(styles.editItem, sel && styles.editItemSelected)}
|
||||
style={{ paddingLeft: 22 }}
|
||||
title={r.name}
|
||||
onClick={() => setSelection({ type: "folder", kind: r.kind, name: r.name })}
|
||||
onDoubleClick={() => toggle(r.key)}
|
||||
onDragOver={(e) => e.preventDefault()}
|
||||
@@ -547,6 +549,9 @@ function EditConfigsDialog() {
|
||||
}
|
||||
const c = r.config;
|
||||
const isTomcat = c.kind === "tomcat";
|
||||
const name = c.name || tx("Unnamed");
|
||||
const target = c.target ? targetName(c, runTargets) : null;
|
||||
const scope = !c.detected && !isTomcat ? (c.local ? "local" : "user") : null;
|
||||
const tomcatNoArtifact =
|
||||
isTomcat &&
|
||||
((c.params?.deployment ?? "artifact") === "artifact"
|
||||
@@ -561,7 +566,9 @@ function EditConfigsDialog() {
|
||||
className={clsx(styles.editItem, current?.id === c.id && styles.editItemSelected)}
|
||||
style={{ paddingLeft: r.depth === 2 ? 50 : 34 }}
|
||||
onClick={() => setSelection({ type: "config", id: c.id })}
|
||||
title={commandLine(c)}
|
||||
title={[name + (target ? ` @ ${target}` : "") + (scope ? ` (${scope})` : ""), commandLine(c)]
|
||||
.filter(Boolean)
|
||||
.join("\n")}
|
||||
draggable
|
||||
onDragStart={(e) => {
|
||||
dragged.current = c.id;
|
||||
@@ -579,11 +586,9 @@ function EditConfigsDialog() {
|
||||
)}
|
||||
</span>
|
||||
<span className={styles.chooserName}>{c.name || <T>Unnamed</T>}</span>
|
||||
{c.target && <span className={styles.chooserMuted}>@ {targetName(c, runTargets)}</span>}
|
||||
{target && <span className={clsx(styles.chooserMuted, styles.editTarget)}>@ {target}</span>}
|
||||
{errorsById[c.id] && <Icon name="error" size={12} className={styles.failed} label="Invalid" />}
|
||||
{!c.detected && !isTomcat && (
|
||||
<span className={styles.chooserMuted}>{c.local ? "local" : "user"}</span>
|
||||
)}
|
||||
{scope && <span className={styles.chooserMuted}>{scope}</span>}
|
||||
</button>
|
||||
);
|
||||
})}
|
||||
|
||||
@@ -253,26 +253,44 @@
|
||||
flex-direction: column;
|
||||
height: 100%;
|
||||
min-width: 0;
|
||||
border-right: 1px solid var(--border);
|
||||
}
|
||||
.testHeader {
|
||||
.testToolbar,
|
||||
.testStatusBar {
|
||||
flex: none;
|
||||
display: flex;
|
||||
flex-wrap: wrap;
|
||||
align-items: center;
|
||||
gap: var(--space-2);
|
||||
height: 28px;
|
||||
padding: 0 4px 0 10px;
|
||||
min-height: 28px;
|
||||
border-bottom: 1px solid var(--border);
|
||||
}
|
||||
.testToolbar {
|
||||
gap: var(--space-0-5);
|
||||
padding: var(--space-0-5) var(--space-1);
|
||||
}
|
||||
.testStatusBar {
|
||||
gap: var(--space-0-5) var(--space-2);
|
||||
padding: var(--space-0-5) var(--space-2);
|
||||
font-size: var(--fs-ui);
|
||||
color: var(--fg-secondary);
|
||||
}
|
||||
.testCounts {
|
||||
flex: 1 1 auto;
|
||||
display: flex;
|
||||
gap: 10px;
|
||||
flex-wrap: wrap;
|
||||
gap: var(--space-0-5) var(--space-2);
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.testStatus,
|
||||
.testTotalDuration {
|
||||
flex: none;
|
||||
}
|
||||
.testTotalDuration {
|
||||
margin-left: auto;
|
||||
color: var(--fg-subtle);
|
||||
font-size: var(--fs-small);
|
||||
font-variant-numeric: tabular-nums;
|
||||
}
|
||||
.testTree {
|
||||
flex: 1;
|
||||
min-height: 0;
|
||||
@@ -299,8 +317,11 @@
|
||||
flex: none;
|
||||
padding-right: 8px;
|
||||
color: var(--fg-subtle);
|
||||
font-family: var(--font-mono);
|
||||
font-size: var(--fs-small);
|
||||
font-variant-numeric: tabular-nums;
|
||||
}
|
||||
.testTree [aria-selected="true"] .testDuration {
|
||||
color: var(--fg);
|
||||
}
|
||||
.testEmpty {
|
||||
padding: 12px;
|
||||
@@ -338,17 +359,17 @@
|
||||
align-items: center;
|
||||
gap: var(--space-1);
|
||||
max-width: 260px;
|
||||
height: 30px;
|
||||
border-radius: 6px;
|
||||
height: var(--h-toolbar-widget);
|
||||
border-radius: var(--radius-toolbar-dropdown);
|
||||
}
|
||||
.widgetDevice {
|
||||
composes: widgetChooser;
|
||||
max-width: 180px;
|
||||
}
|
||||
.widgetButton {
|
||||
width: 30px;
|
||||
height: 30px;
|
||||
border-radius: 6px;
|
||||
width: var(--titlebar-tool-button);
|
||||
height: var(--titlebar-tool-button);
|
||||
border-radius: var(--radius-toolbar-button);
|
||||
}
|
||||
.widgetLoading {
|
||||
display: inline-flex;
|
||||
@@ -553,6 +574,7 @@
|
||||
flex: 1;
|
||||
}
|
||||
.editSidebar {
|
||||
container: run-config-navigation / inline-size;
|
||||
min-height: 0;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
@@ -596,6 +618,22 @@
|
||||
background: var(--bg-selected-strong);
|
||||
color: var(--fg-strong);
|
||||
}
|
||||
.editTarget {
|
||||
flex: 0 1 auto;
|
||||
min-width: 0;
|
||||
max-width: 25%;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.editItem .failed {
|
||||
flex: none;
|
||||
}
|
||||
@container run-config-navigation (max-width: 220px) {
|
||||
.editItem .chooserMuted {
|
||||
display: none;
|
||||
}
|
||||
}
|
||||
.editForm {
|
||||
flex: 1;
|
||||
min-width: 0;
|
||||
@@ -701,6 +739,7 @@
|
||||
}
|
||||
.editGroupName {
|
||||
color: var(--fg-strong);
|
||||
font-weight: 600;
|
||||
}
|
||||
.editEmpty {
|
||||
flex: 1;
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import { useEffect, useMemo, useRef, useState } from "react";
|
||||
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from "react";
|
||||
import clsx from "clsx";
|
||||
import type { GroupImperativeHandle, Layout } from "react-resizable-panels";
|
||||
import type { RunConfig } from "@/platform/ipc";
|
||||
import type { RunTargetValid } from "@/platform/remoteSettings";
|
||||
import { useAgentRunSettings, useWorkflowSettings } from "@/platform/workflowSettings";
|
||||
@@ -47,7 +48,7 @@ import {
|
||||
} from "./store";
|
||||
import { rerunFailedConfigs } from "./testing/rerun";
|
||||
import { formatDuration, nodeOutput } from "./testing";
|
||||
import { TestTreeView } from "./TestTreeView";
|
||||
import { TestStatusBar, TestTreeView } from "./TestTreeView";
|
||||
import { StackTracePanel, useStackTraces, type StackTraceTab } from "./stackTrace";
|
||||
import { closeRunTab, runTabMenu } from "./runTabs";
|
||||
import { showApplicationUpdate, useApplicationUpdates } from "./applicationUpdate";
|
||||
@@ -59,6 +60,11 @@ import { archivedAgentSessions, closeAgentArchive } from "./agentRuns";
|
||||
import styles from "./Run.module.css";
|
||||
import { tx } from "@/platform/i18n";
|
||||
|
||||
const TEST_SPLIT_DEFAULTS = {
|
||||
horizontal: { tests: 34, console: 66 },
|
||||
vertical: { tests: 48, console: 52 },
|
||||
};
|
||||
|
||||
function failed(s: RunSession): boolean {
|
||||
return s.status === "failed" || (s.status === "finished" && s.exitCode !== 0 && !s.stopped);
|
||||
}
|
||||
@@ -93,6 +99,25 @@ export function SessionPanel({
|
||||
const softWrap = wrapOverride ?? defaultWrap;
|
||||
const [selectedTest, setSelectedTest] = useState<string | null>(null);
|
||||
const [findOpen, setFindOpen] = useState(false);
|
||||
const body = useRef<HTMLDivElement>(null);
|
||||
const [stackedTests, setStackedTests] = useState(false);
|
||||
const testSplit = useRef<GroupImperativeHandle>(null);
|
||||
const testLayouts = useRef<Record<keyof typeof TEST_SPLIT_DEFAULTS, Layout>>({ ...TEST_SPLIT_DEFAULTS });
|
||||
const testOrientation = stackedTests ? "vertical" : "horizontal";
|
||||
const hasTests = !!rt?.tests;
|
||||
useLayoutEffect(() => {
|
||||
const pane = body.current;
|
||||
if (!hasTests || !pane) return;
|
||||
const measure = () => setStackedTests(pane.clientWidth < 560);
|
||||
measure();
|
||||
if (typeof ResizeObserver === "undefined") return;
|
||||
const resize = new ResizeObserver(measure);
|
||||
resize.observe(pane);
|
||||
return () => resize.disconnect();
|
||||
}, [hasTests]);
|
||||
useLayoutEffect(() => {
|
||||
if (hasTests) testSplit.current?.setLayout(testLayouts.current[testOrientation]);
|
||||
}, [hasTests, testOrientation]);
|
||||
const running = isLive(session);
|
||||
const cwd = runDirectory(session.config.cwd);
|
||||
const baseConfig = useRun(() => baseConfigOf(session));
|
||||
@@ -136,6 +161,7 @@ export function SessionPanel({
|
||||
|
||||
const consoleColumn = (
|
||||
<div className={styles.consoleColumn}>
|
||||
{rt.tests && <TestStatusBar results={rt.tests} version={version} running={running} />}
|
||||
{rt.console.dropped > 0 && !testModel && (
|
||||
<div className={styles.notice}>{tx`${rt.console.dropped.toLocaleString()} earlier lines were discarded`}</div>
|
||||
)}
|
||||
@@ -279,10 +305,19 @@ export function SessionPanel({
|
||||
/>
|
||||
</div>
|
||||
</div>
|
||||
<div className={styles.sessionBody}>
|
||||
<div ref={body} className={styles.sessionBody}>
|
||||
{rt.tests ? (
|
||||
<SplitGroup orientation="horizontal" id={`run-tests-${session.id}`} className={styles.testSplit}>
|
||||
<SplitPanel id="tests" defaultSize="32%" minSize="140px">
|
||||
<SplitGroup
|
||||
orientation={testOrientation}
|
||||
id={`run-tests-${session.id}`}
|
||||
className={styles.testSplit}
|
||||
groupRef={testSplit}
|
||||
defaultLayout={TEST_SPLIT_DEFAULTS[testOrientation]}
|
||||
onLayoutChanged={(layout, meta) => {
|
||||
if (meta.isUserInteraction) testLayouts.current[testOrientation] = meta.requestedLayout ?? layout;
|
||||
}}
|
||||
>
|
||||
<SplitPanel id="tests" minSize={stackedTests ? "28%" : "140px"}>
|
||||
<TestTreeView
|
||||
results={rt.tests}
|
||||
version={version}
|
||||
@@ -296,7 +331,7 @@ export function SessionPanel({
|
||||
/>
|
||||
</SplitPanel>
|
||||
<SplitHandle />
|
||||
<SplitPanel id="console" minSize="200px">
|
||||
<SplitPanel id="console" minSize={stackedTests ? "28%" : "200px"}>
|
||||
{consoleColumn}
|
||||
</SplitPanel>
|
||||
</SplitGroup>
|
||||
|
||||
@@ -12,9 +12,11 @@ import { CURRENT_FILE, useRun, isLive } from "./store";
|
||||
import { compoundTargets, selectedTarget } from "./sessionTargets";
|
||||
import { isDebugOnly } from "./types";
|
||||
import styles from "./Run.module.css";
|
||||
import { useChromeIconSize } from "@/ui/density";
|
||||
|
||||
/** Title bar: configuration chooser, Run / Debug, and Rerun / Stop while running. */
|
||||
export function RunWidget() {
|
||||
const iconSize = useChromeIconSize();
|
||||
const tx = useTx();
|
||||
const label = useRemoteLabel();
|
||||
const configs = useRun((s) => s.configs);
|
||||
@@ -92,20 +94,20 @@ export function RunWidget() {
|
||||
<IconButton
|
||||
icon="run"
|
||||
size="large"
|
||||
iconSize={18}
|
||||
iconSize={iconSize - 2}
|
||||
className={clsx(styles.widgetButton, styles.widgetRun)}
|
||||
title="Run"
|
||||
disabled
|
||||
/>
|
||||
)}
|
||||
<span className={clsx(styles.widgetButton, styles.widgetLoading)}>
|
||||
<Spinner variant="spokes" size={18} label={tx("Starting…")} />
|
||||
<Spinner variant="spokes" size={iconSize - 2} label={tx("Starting…")} />
|
||||
</span>
|
||||
{!debugging && (
|
||||
<IconButton
|
||||
icon="debug"
|
||||
size="large"
|
||||
iconSize={18}
|
||||
iconSize={iconSize - 2}
|
||||
className={styles.widgetButton}
|
||||
title="Debug"
|
||||
disabled
|
||||
@@ -118,7 +120,7 @@ export function RunWidget() {
|
||||
<IconButton
|
||||
icon="resume"
|
||||
size="large"
|
||||
iconSize={20}
|
||||
iconSize={iconSize}
|
||||
className={styles.widgetButton}
|
||||
title="Resume Program"
|
||||
shortcut={shortcutLabel("debug.resume")}
|
||||
@@ -141,7 +143,7 @@ export function RunWidget() {
|
||||
<IconButton
|
||||
icon="run"
|
||||
size="large"
|
||||
iconSize={20}
|
||||
iconSize={iconSize}
|
||||
className={clsx(styles.widgetButton, styles.widgetRun)}
|
||||
title={
|
||||
selected
|
||||
@@ -159,7 +161,7 @@ export function RunWidget() {
|
||||
<IconButton
|
||||
icon="debug"
|
||||
size="large"
|
||||
iconSize={20}
|
||||
iconSize={iconSize}
|
||||
className={styles.widgetButton}
|
||||
title={selected ? tx`Debug '${selected.name}'` : currentFile ? "Debug Current File" : "Debug"}
|
||||
shortcut={shortcutLabel("run.debug")}
|
||||
@@ -196,7 +198,7 @@ export function RunWidget() {
|
||||
ref={moreRef}
|
||||
icon="more"
|
||||
size="large"
|
||||
iconSize={20}
|
||||
iconSize={iconSize}
|
||||
className={styles.widgetButton}
|
||||
title="More Actions"
|
||||
aria-haspopup="menu"
|
||||
|
||||
@@ -49,6 +49,12 @@ function Host(props: {
|
||||
);
|
||||
}
|
||||
|
||||
function moreItem(name: string) {
|
||||
const trigger = screen.getByRole("button", { name: "More Actions" });
|
||||
if (trigger.getAttribute("aria-expanded") !== "true") fireEvent.click(trigger);
|
||||
return screen.getByRole("menuitem", { name });
|
||||
}
|
||||
|
||||
describe("TestTreeView", () => {
|
||||
beforeEach(() => localStorage.clear());
|
||||
afterEach(() => vi.clearAllMocks());
|
||||
@@ -264,17 +270,17 @@ describe("Expand All / Collapse All", () => {
|
||||
expect(rows()).toContain("reuses()");
|
||||
});
|
||||
|
||||
it("the buttons run the actions, and are unavailable without suites", () => {
|
||||
it("the menu runs the actions, and they are unavailable without suites", () => {
|
||||
const dispose = registerActions([
|
||||
{ id: "run.expandAllTests", title: "Expand All", run: () => {} },
|
||||
{ id: "run.collapseAllTests", title: "Collapse All", run: () => {} },
|
||||
]);
|
||||
onTestFinished(dispose);
|
||||
const { unmount } = render(view(nested()));
|
||||
fireEvent.click(screen.getByRole("button", { name: "Expand All" }));
|
||||
expect(actions.executeAction).toHaveBeenCalledWith("run.expandAllTests", undefined);
|
||||
fireEvent.click(screen.getByRole("button", { name: "Collapse All" }));
|
||||
expect(actions.executeAction).toHaveBeenCalledWith("run.collapseAllTests", undefined);
|
||||
fireEvent.click(moreItem("Expand All"));
|
||||
expect(actions.executeAction).toHaveBeenCalledWith("run.expandAllTests");
|
||||
fireEvent.click(moreItem("Collapse All"));
|
||||
expect(actions.executeAction).toHaveBeenCalledWith("run.collapseAllTests");
|
||||
unmount();
|
||||
expect(testTree.expandAll).toBeNull();
|
||||
|
||||
@@ -282,8 +288,8 @@ describe("Expand All / Collapse All", () => {
|
||||
flat.apply([{ type: "result", path: ["main_test"], status: "failed" }]);
|
||||
flat.finish(1);
|
||||
render(view(flat));
|
||||
expect(screen.getByRole("button", { name: "Expand All" })).toBeDisabled();
|
||||
expect(screen.getByRole("button", { name: "Collapse All" })).toBeDisabled();
|
||||
expect(moreItem("Expand All")).toHaveAttribute("aria-disabled", "true");
|
||||
expect(moreItem("Collapse All")).toHaveAttribute("aria-disabled", "true");
|
||||
});
|
||||
});
|
||||
|
||||
@@ -306,9 +312,9 @@ describe("Export Test Results", () => {
|
||||
/>
|
||||
);
|
||||
|
||||
it("the button and the action open the dialog for the finished run", () => {
|
||||
it("the menu and the action open the dialog for the finished run", () => {
|
||||
const { unmount } = render(view(finished(), false));
|
||||
fireEvent.click(screen.getByRole("button", { name: "Export Test Results…" }));
|
||||
fireEvent.click(moreItem("Export Test Results…"));
|
||||
expect(screen.getByRole("dialog", { name: "Export Test Results" })).toBeInTheDocument();
|
||||
fireEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||
act(() => testTree.exportResults!());
|
||||
@@ -322,13 +328,13 @@ describe("Export Test Results", () => {
|
||||
|
||||
it("is unavailable while the tests run and without results", () => {
|
||||
const { rerender } = render(view(finished(), true));
|
||||
expect(screen.getByRole("button", { name: "Export Test Results…" })).toBeDisabled();
|
||||
expect(moreItem("Export Test Results…")).toHaveAttribute("aria-disabled", "true");
|
||||
expect(testTree.exportResults).toBeNull();
|
||||
rerender(view(new TestResults(), false));
|
||||
expect(screen.getByRole("button", { name: "Export Test Results…" })).toBeDisabled();
|
||||
expect(moreItem("Export Test Results…")).toHaveAttribute("aria-disabled", "true");
|
||||
expect(testTree.exportResults).toBeNull();
|
||||
rerender(view(finished(), false));
|
||||
expect(screen.getByRole("button", { name: "Export Test Results…" })).toBeEnabled();
|
||||
expect(moreItem("Export Test Results…")).not.toHaveAttribute("aria-disabled", "true");
|
||||
expect(testTree.exportResults).not.toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -9,6 +9,7 @@ import {
|
||||
showContextMenu,
|
||||
useContextMenuStore,
|
||||
Spinner,
|
||||
Toolbar,
|
||||
Tree,
|
||||
type MenuItem,
|
||||
type TreeHandle,
|
||||
@@ -83,6 +84,41 @@ export function StatusIcon({ status }: { status: TestStatus | null }) {
|
||||
}
|
||||
}
|
||||
|
||||
export function TestStatusBar({
|
||||
results,
|
||||
version,
|
||||
running,
|
||||
}: {
|
||||
results: TestResults;
|
||||
version: number;
|
||||
running: boolean;
|
||||
}) {
|
||||
const counts = useMemo(() => results.counts(), [results, version]); // eslint-disable-line react-hooks/exhaustive-deps
|
||||
const status = running
|
||||
? "running"
|
||||
: counts.failed
|
||||
? "failed"
|
||||
: counts.passed
|
||||
? "passed"
|
||||
: counts.skipped
|
||||
? "skipped"
|
||||
: null;
|
||||
const duration = results.summary.durationMs;
|
||||
|
||||
return (
|
||||
<div className={styles.testStatusBar} role="status">
|
||||
<StatusIcon status={status} />
|
||||
<span className={styles.testCounts}>
|
||||
{counts.failed > 0 && <span className={styles.failed}>{tx`${counts.failed} failing`}</span>}
|
||||
{counts.passed > 0 && <span>{tx`${counts.passed} passed`}</span>}
|
||||
{counts.skipped > 0 && <span className={styles.skipped}>{tx`${counts.skipped} ignored`}</span>}
|
||||
{counts.total === 0 && <span className={styles.skipped}>{running ? tx("Running…") : tx("No tests")}</span>}
|
||||
</span>
|
||||
{duration !== undefined && <span className={styles.testTotalDuration}>{formatDuration(duration)}</span>}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
const isFailedTest = (n: TestNode) => n.children.length === 0 && nodeStatus(n) === "failed";
|
||||
|
||||
const treeModel = {
|
||||
@@ -163,6 +199,8 @@ export function TestTreeView({
|
||||
});
|
||||
const sortButton = useRef<HTMLButtonElement>(null);
|
||||
const [sortMenu, setSortMenu] = useState(false);
|
||||
const moreButton = useRef<HTMLButtonElement>(null);
|
||||
const [moreMenu, setMoreMenu] = useState(false);
|
||||
const [expanded, setExpanded] = useState<Set<string> | null>(null);
|
||||
const [exporting, setExporting] = useState(false);
|
||||
const [selection, setSelection] = useState<Set<string>>(new Set());
|
||||
@@ -226,7 +264,6 @@ export function TestTreeView({
|
||||
}
|
||||
};
|
||||
|
||||
const counts = useMemo(() => results.counts(), [results, version]); // eslint-disable-line react-hooks/exhaustive-deps
|
||||
// Like IDEA, Sort by Duration applies once the run has finished, so rows don't jump while tests report.
|
||||
const byDuration = sortByDuration && !running;
|
||||
const roots = useMemo(() => {
|
||||
@@ -276,21 +313,9 @@ export function TestTreeView({
|
||||
const hasPrevFailed = findOccurrence(roots, selected, -1, treeModel) !== null;
|
||||
const hasNextFailed = findOccurrence(roots, selected, 1, treeModel) !== null;
|
||||
|
||||
const status = running ? "running" : counts.failed > 0 ? "failed" : counts.total > 0 ? "passed" : null;
|
||||
const duration = results.summary.durationMs;
|
||||
|
||||
return (
|
||||
<div className={styles.testPane}>
|
||||
<div className={styles.testHeader}>
|
||||
<StatusIcon status={status} />
|
||||
<span className={styles.testCounts}>
|
||||
{counts.failed > 0 && <span className={styles.failed}>{tx`${counts.failed} failing`}</span>}
|
||||
{counts.passed > 0 && <span>{tx`${counts.passed} passed`}</span>}
|
||||
{counts.skipped > 0 && <span className={styles.skipped}>{tx`${counts.skipped} ignored`}</span>}
|
||||
{counts.total === 0 && <span className={styles.skipped}>{running ? tx("Running…") : tx("No tests")}</span>}
|
||||
{duration !== undefined && <span className={styles.skipped}>{formatDuration(duration)}</span>}
|
||||
</span>
|
||||
<span className={styles.spacer} />
|
||||
<Toolbar className={styles.testToolbar} aria-label="Test results">
|
||||
<IconButton
|
||||
icon="test-show-passed"
|
||||
size="small"
|
||||
@@ -332,14 +357,6 @@ export function TestTreeView({
|
||||
]}
|
||||
onClose={() => setSortMenu(false)}
|
||||
/>
|
||||
<IconButton icon="expand-all" action="run.expandAllTests" size="small" iconSize={16} disabled={!hasSuites} />
|
||||
<IconButton
|
||||
icon="collapse-all"
|
||||
action="run.collapseAllTests"
|
||||
size="small"
|
||||
iconSize={16}
|
||||
disabled={!hasSuites}
|
||||
/>
|
||||
<IconButton
|
||||
icon="arrow-up"
|
||||
action="navigate.prevOccurrence"
|
||||
@@ -357,14 +374,42 @@ export function TestTreeView({
|
||||
disabled={!hasNextFailed}
|
||||
/>
|
||||
<IconButton
|
||||
icon="export"
|
||||
ref={moreButton}
|
||||
icon="more-horizontal"
|
||||
size="small"
|
||||
iconSize={16}
|
||||
title="Export Test Results…"
|
||||
disabled={!canExport}
|
||||
onClick={() => setExporting(true)}
|
||||
title="More Actions"
|
||||
aria-haspopup="menu"
|
||||
aria-expanded={moreMenu}
|
||||
onClick={() => setMoreMenu((open) => !open)}
|
||||
/>
|
||||
</div>
|
||||
<Menu
|
||||
open={moreMenu}
|
||||
anchor={moreButton}
|
||||
onClose={() => setMoreMenu(false)}
|
||||
items={[
|
||||
{
|
||||
icon: "expand-all",
|
||||
label: "Expand All",
|
||||
disabled: !hasSuites,
|
||||
run: () => void executeAction("run.expandAllTests"),
|
||||
},
|
||||
{
|
||||
icon: "collapse-all",
|
||||
label: "Collapse All",
|
||||
disabled: !hasSuites,
|
||||
run: () => void executeAction("run.collapseAllTests"),
|
||||
},
|
||||
{ kind: "separator" },
|
||||
{
|
||||
icon: "export",
|
||||
label: "Export Test Results…",
|
||||
disabled: !canExport,
|
||||
run: () => setExporting(true),
|
||||
},
|
||||
]}
|
||||
/>
|
||||
</Toolbar>
|
||||
{exporting && (
|
||||
<ExportTestResultsDialog results={results} name={name} cwd={cwd} onClose={() => setExporting(false)} />
|
||||
)}
|
||||
@@ -396,7 +441,9 @@ export function TestTreeView({
|
||||
return (
|
||||
<span className={styles.testRow}>
|
||||
<StatusIcon status={s} />
|
||||
<span className={clsx(styles.testName, s === "skipped" && styles.skipped)}>{n.name}</span>
|
||||
<span className={clsx(styles.testName, s === "skipped" && styles.skipped)} title={n.name}>
|
||||
{n.name}
|
||||
</span>
|
||||
{d !== undefined && <span className={styles.testDuration}>{formatDuration(d)}</span>}
|
||||
</span>
|
||||
);
|
||||
|
||||
@@ -85,7 +85,6 @@ function ScratchChooser({ languages }: { languages: readonly ScratchLanguage[] }
|
||||
onActivate={(r) => pick(r)}
|
||||
focusable={false}
|
||||
hoverSelects
|
||||
rowHeight={24}
|
||||
className={styles.list}
|
||||
aria-label="Languages"
|
||||
empty={
|
||||
|
||||
@@ -29,6 +29,7 @@ import {
|
||||
type PathBookmark,
|
||||
} from "./store";
|
||||
import styles from "./BookmarkPopups.module.css";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
|
||||
export function BookmarkPopupsOverlay() {
|
||||
const chooser = useBookmarkPopups((s) => s.chooser);
|
||||
@@ -186,6 +187,7 @@ export function bookmarkRows(
|
||||
const isSectionRow = (r: Row) => r.kind === "file" || r.kind === "list";
|
||||
|
||||
function BookmarksPopup() {
|
||||
const rowHeight = useRowHeight(22);
|
||||
const items = useBookmarks((s) => s.items);
|
||||
const paths = useBookmarks((s) => s.paths);
|
||||
const lists = useBookmarks((s) => s.lists);
|
||||
@@ -247,8 +249,7 @@ function BookmarksPopup() {
|
||||
jump(r);
|
||||
}}
|
||||
aria-label="Bookmarks"
|
||||
rowHeight={22}
|
||||
sectionHeight={24}
|
||||
rowHeight={rowHeight}
|
||||
empty={<span>{items.length || paths.length ? null : <T>No bookmarks</T>}</span>}
|
||||
renderSection={(r) =>
|
||||
r.kind === "file" ? (
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import { writeClipboardText } from "@/platform/clipboard";
|
||||
import { onSearchCategoriesChanged, onEndpointsChanged } from "@/workbench/contributions";
|
||||
import { useFilePresentation } from "@/ui/filePresentation";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import { useEffect, useMemo, useRef, useState, type KeyboardEvent, type MouseEvent } from "react";
|
||||
import clsx from "clsx";
|
||||
import { actionToggled, executeAction, executeActionFrom, getAction } from "@/platform/actions";
|
||||
@@ -87,7 +88,7 @@ export function claimSearchKeys(input: () => HTMLElement | null): () => void {
|
||||
return registerKeyClaim((e) => e.target === input() && SEARCH_KEYS.has(e.key));
|
||||
}
|
||||
const ROW = 24;
|
||||
const MIN_LIST = 10 * ROW;
|
||||
const MIN_LIST_ROWS = 10;
|
||||
const DEBOUNCE_MS = 60;
|
||||
|
||||
export function SearchEverywhereOverlay() {
|
||||
@@ -100,6 +101,7 @@ const INITIAL_SELECTION: Selection = { key: null, anchorKey: null, lead: -1, anc
|
||||
|
||||
function SearchEverywhereDialog() {
|
||||
const tx = useTx();
|
||||
const rowHeight = useRowHeight(ROW);
|
||||
const tab = useSearchEverywhere((s) => s.tab);
|
||||
const hint = hintFor(tab, tx);
|
||||
const [tabs, setTabs] = useState(searchTabs);
|
||||
@@ -472,8 +474,8 @@ function SearchEverywhereDialog() {
|
||||
};
|
||||
|
||||
// While a query is typed the list keeps a minimum height so the popup doesn't jump with every keystroke.
|
||||
const minList = parsed.text.trim() && !listing ? MIN_LIST : 0;
|
||||
const listHeight = Math.max(minList, rows.length * ROW);
|
||||
const minList = parsed.text.trim() && !listing ? MIN_LIST_ROWS * rowHeight : 0;
|
||||
const listHeight = Math.max(minList, rows.length * rowHeight);
|
||||
const previewTarget = previewOf(activeRow);
|
||||
const emptyQuery = !parsed.text.trim();
|
||||
const showEmpty = !rows.length && snap && !snap.loading && (!emptyQuery || tab !== "all");
|
||||
@@ -521,8 +523,8 @@ function SearchEverywhereDialog() {
|
||||
isSelected={(r) => !!sel.keys?.has(r.key)}
|
||||
onActivate={(r, _i, e) => activate(r, (e as MouseEvent).shiftKey)}
|
||||
focusable={false}
|
||||
rowHeight={ROW}
|
||||
sectionHeight={ROW}
|
||||
rowHeight={rowHeight}
|
||||
sectionHeight={rowHeight}
|
||||
className={styles.list}
|
||||
aria-label={tx("Results")}
|
||||
renderItem={(r, state) => (
|
||||
|
||||
@@ -37,6 +37,7 @@ import {
|
||||
type MenuItem,
|
||||
T,
|
||||
} from "@/ui";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import { maybeEditorService, notifications } from "@/workbench/contributions";
|
||||
import { confirm } from "@/workbench/messages";
|
||||
import { basename, dirname, openLocation } from "../common/open";
|
||||
@@ -144,6 +145,7 @@ function displayDirectory(dir: string, root: string | null): string {
|
||||
|
||||
function FindInFilesDialog() {
|
||||
const s = useFindPopup();
|
||||
const rowHeight = useRowHeight(ROW);
|
||||
const txt = useTxTemplate();
|
||||
const project = useProject((p) => p.project);
|
||||
const root = project?.workspace?.projects[0] ?? (project?.workspace ? null : (project?.root ?? null));
|
||||
@@ -591,7 +593,7 @@ function FindInFilesDialog() {
|
||||
openRow(r, e.shiftKey);
|
||||
}}
|
||||
focusable={false}
|
||||
rowHeight={ROW}
|
||||
rowHeight={rowHeight}
|
||||
aria-label="Matches"
|
||||
empty={
|
||||
query ? (
|
||||
@@ -864,7 +866,7 @@ function FindInFilesDialog() {
|
||||
<div className={styles.split}>
|
||||
{rows.length ? (
|
||||
<SplitGroup orientation="vertical" id="find-popup-split" storageKey={FIND_POPUP_SPLIT_KEY}>
|
||||
<SplitPanel id="results" minSize={ROW * 3} defaultSize="33%">
|
||||
<SplitPanel id="results" minSize={rowHeight * 3} defaultSize="33%">
|
||||
{resultsBox}
|
||||
</SplitPanel>
|
||||
<SplitHandle hairline={false} />
|
||||
|
||||
@@ -387,7 +387,6 @@ function RecentFilesDialog() {
|
||||
}}
|
||||
onActivate={(t) => openTool(t.tw)}
|
||||
focusable={false}
|
||||
rowHeight={24}
|
||||
aria-label="Tool windows"
|
||||
renderItem={(t) => <ToolRow tw={t.tw} title={t.title} indices={t.indices} />}
|
||||
/>
|
||||
@@ -414,7 +413,6 @@ function RecentFilesDialog() {
|
||||
isSelected={(f) => effectiveColumn === "files" && !!fileSelection.keys?.has(f.path)}
|
||||
onActivate={(f, _i, e) => openFile(f, e.shiftKey)}
|
||||
focusable={false}
|
||||
rowHeight={24}
|
||||
aria-label={switcher ? "Open files" : "Recent files"}
|
||||
empty={
|
||||
paths && (
|
||||
|
||||
@@ -17,6 +17,7 @@ import {
|
||||
type TreeHandle,
|
||||
T,
|
||||
} from "@/ui";
|
||||
import { useRowHeight } from "@/ui/density";
|
||||
import type { OutlineItem } from "@/platform/ipc";
|
||||
import { useShownLine } from "@/editor/api";
|
||||
import { badgeKind, basename, openLocation } from "../common/open";
|
||||
@@ -364,6 +365,7 @@ const POPUP_ROW = 22;
|
||||
|
||||
function FileStructureDialog() {
|
||||
useLiveOutline();
|
||||
const rowHeight = useRowHeight(POPUP_ROW);
|
||||
const path = useOutline((s) => s.path);
|
||||
const items = useOutline((s) => s.items);
|
||||
const loading = useOutline((s) => s.loading);
|
||||
@@ -466,7 +468,7 @@ function FileStructureDialog() {
|
||||
e.preventDefault();
|
||||
};
|
||||
|
||||
const height = Math.min(420, Math.max(1, visibleCount(filter.nodes, collapsed)) * POPUP_ROW + 8);
|
||||
const height = Math.min(420, Math.max(1, visibleCount(filter.nodes, collapsed)) * rowHeight + 8);
|
||||
return (
|
||||
<Dialog
|
||||
open
|
||||
@@ -553,7 +555,7 @@ function FileStructureDialog() {
|
||||
speedSearch={false}
|
||||
activateExpandable
|
||||
onActivate={(n) => choose(n)}
|
||||
rowHeight={POPUP_ROW}
|
||||
rowHeight={rowHeight}
|
||||
indent={16}
|
||||
empty={
|
||||
<span className={styles.popupEmpty}>
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { formatPattern, formatTimestamp } from "@/platform/dateFormat";
|
||||
import { resolveThemeId } from "@/workbench/theme";
|
||||
import { useCompactMode } from "@/ui/density";
|
||||
import { applyAppearanceOptions, nextZoom, SMALL_TREE_INDENT } from "../appearanceRuntime";
|
||||
import { validateSettings } from "../model/schema";
|
||||
import { validateGeneralExtras, validateAppearanceExtras, validateNotifications } from "../model/behaviorSchema";
|
||||
@@ -106,6 +107,16 @@ describe("appearance & behavior settings", () => {
|
||||
expect(validateAppearanceExtras({ navigationBar: "everywhere" }).navigationBar).toBe("statusBar");
|
||||
});
|
||||
|
||||
it("applies Compact mode to the root attribute and the JS density store", () => {
|
||||
const root = document.createElement("div");
|
||||
applyAppearanceOptions(validateSettings({ appearance: { compactMode: true } }), root);
|
||||
expect(root.dataset.compact).toBe("");
|
||||
expect(useCompactMode.getState()).toBe(true);
|
||||
applyAppearanceOptions(validateSettings({}), root);
|
||||
expect(root.dataset.compact).toBeUndefined();
|
||||
expect(useCompactMode.getState()).toBe(false);
|
||||
});
|
||||
|
||||
it("defaults Use smaller indents in trees to off and applies the indent variable", () => {
|
||||
expect(validateAppearanceExtras({}).smallTreeIndents).toBe(false);
|
||||
expect(validateAppearanceExtras({ smallTreeIndents: true }).smallTreeIndents).toBe(true);
|
||||
|
||||
@@ -13,6 +13,7 @@ import { usePlatform } from "@/platform/platformInfo";
|
||||
import { useProject } from "@/platform/project";
|
||||
import { loadSystemFonts, useSystemFontStore } from "@/platform/systemFonts";
|
||||
import { setDragRequiresAlt } from "@/ui";
|
||||
import { setCompactMode } from "@/ui/density";
|
||||
import { ZOOM_LIMITS } from "@/platform/zoom";
|
||||
import { DEFAULT_SETTINGS, validateSettings, type ValidSettings } from "./model/schema";
|
||||
import type { BackgroundImageValid } from "./model/behaviorSchema";
|
||||
@@ -45,6 +46,7 @@ export function applyAppearanceOptions(s: ValidSettings, root: HTMLElement = doc
|
||||
} else root.style.removeProperty("--font-ui");
|
||||
|
||||
flag(root, "compact", a.compactMode);
|
||||
setCompactMode(a.compactMode);
|
||||
flag(root, "contrastScrollbars", a.contrastScrollbars);
|
||||
flag(root, "redGreen", a.redGreenVision);
|
||||
flag(root, "toolWindowBg", a.differentToolWindowBackground, "different");
|
||||
|
||||
@@ -356,7 +356,6 @@ export function SettingsLayout() {
|
||||
onSelectionChange={(_sel, node) => node && selectPage(node.key)}
|
||||
multiSelect={false}
|
||||
speedSearch={false}
|
||||
rowHeight={24}
|
||||
empty={
|
||||
<div className={styles.noMatch}>
|
||||
<T>No matches</T>
|
||||
|
||||
Loaded 100 of 158 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user