[PR #1] [MERGED] fix: Cleanup stale map in a background goroutine. #1

New Issue

2026-02-16T03:15:22-05:00

yindo commented

2026-02-16 03:15:22 -05:00

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langsmith-collector-proxy/pull/1
Author: @angus-langchain
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/19/2025
Merged by: @angus-langchain

Base: main ← Head: 001-angus/ttl-spanmap-in-background

📝 Commits (1)

5400b8b fix: Cleanup stale map in a background goroutine.

📊 Changes

1 file changed (+29 additions, -12 deletions)

View changed files

📝 internal/translator/translator.go (+29 -12)

📄 Description

Iterating over the span map and ttling every call to Translate() adds significant overhead. We should cleanup all spans in a background thread outside of the hotpath.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langsmith-collector-proxy/pull/1 **Author:** [@angus-langchain](https://github.com/angus-langchain) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/19/2025 **Merged by:** [@angus-langchain](https://github.com/angus-langchain) **Base:** `main` ← **Head:** `001-angus/ttl-spanmap-in-background` --- ### 📝 Commits (1) - [`5400b8b`](https://github.com/langchain-ai/langsmith-collector-proxy/commit/5400b8b7089a0042031f9f1909edfa502bb66dee) fix: Cleanup stale map in a background goroutine. ### 📊 Changes **1 file changed** (+29 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `internal/translator/translator.go` (+29 -12) </details> ### 📄 Description Iterating over the span map and ttling every call to `Translate()` adds significant overhead. We should cleanup all spans in a background thread outside of the hotpath. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 03:15:22 -05:00

yindo closed this issue

2026-02-16 03:15:23 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: langchain-ai/langsmith-collector-proxy#1