langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12351] Fix the issue where TextGeneration component does not correctly clear input data. #27612

New Issue
Closed
opened 2026-02-21 20:41:51 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:51 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12351

State: closed
Merged: Yes

Summary

Resolves #11849

This PR is a resubmission as requested, as part of the now-closed #11850 .

Fixed

  • Fix the issue where TextGeneration component does not correctly clear input data
    • Fixed the issue in the text generation application where the TextGeneration component did not properly reset references when clearing the form. This issue caused old form values to be automatically filled in upon re-entering data. Now, the form references are correctly reset after clearing, ensuring that new input data is not affected by previous values.

Modification Details

This section was automatically generated by GitHub Copilot actions.

This pull request includes changes to the web/app/components/share/text-generation/index.tsx file to improve the handling of state updates and references. The most important changes are the addition of the useCallback hook and the refactoring of the inputs state management.

Improvements to state management:

  • Added useCallback to memoize the setInputs function, ensuring that it does not get recreated on each render. (web/app/components/share/text-generation/index.tsx)
  • Refactored the inputs state management by introducing doSetInputs and inputsRef to keep the state and its reference in sync. (web/app/components/share/text-generation/index.tsx)

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12351 **State:** closed **Merged:** Yes --- # Summary Resolves #11849 ***This PR is a resubmission as requested, as part of the now-closed #11850 .*** # Fixed - **Fix the issue where `TextGeneration` component does not correctly clear input data** - Fixed the issue in the text generation application where the `TextGeneration` component did not properly reset references when clearing the form. This issue caused old form values to be automatically filled in upon re-entering data. Now, the form references are correctly reset after clearing, ensuring that new input data is not affected by previous values. # Modification Details > This section was automatically generated by `GitHub Copilot actions`. This pull request includes changes to the `web/app/components/share/text-generation/index.tsx` file to improve the handling of state updates and references. The most important changes are the addition of the `useCallback` hook and the refactoring of the `inputs` state management. Improvements to state management: * Added `useCallback` to memoize the `setInputs` function, ensuring that it does not get recreated on each render. (`web/app/components/share/text-generation/index.tsx`) * Refactored the `inputs` state management by introducing `doSetInputs` and `inputsRef` to keep the state and its reference in sync. (`web/app/components/share/text-generation/index.tsx`) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:51 -05:00
yindo closed this issue 2026-02-21 20:41:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27612
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?