langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #27614] fix: resolve stale closure values in LLM node callbacks (#27612) #31817

New Issue
Closed
opened 2026-02-21 20:50:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:12 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/27614

State: closed
Merged: Yes

What does this PR do?

Fixes #27612

Resolves data loss issue where LLM node prompt changes are lost when calling /workflows/draft API.

Changes

  • Updated 8 callback functions in use-config.ts to use inputRef.current instead of closure-captured inputs
  • Removed inputs from dependency arrays to improve performance
  • Made code consistent with other handlers in the same file and other node types

Root Cause

The callbacks were using stale closure values (inputs) instead of the latest ref value (inputRef.current), causing updates to be based on outdated data when rapid edits occurred within the 5-second debounce window.

Testing

  • ✅ Tested locally with rapid prompt edits
  • ✅ Verified /workflows/draft API receives correct data
  • ✅ No linter errors
  • ✅ No performance regressions observed
**Original Pull Request:** https://github.com/langgenius/dify/pull/27614 **State:** closed **Merged:** Yes --- ## What does this PR do? Fixes #27612 Resolves data loss issue where LLM node prompt changes are lost when calling `/workflows/draft` API. ## Changes - Updated 8 callback functions in `use-config.ts` to use `inputRef.current` instead of closure-captured `inputs` - Removed `inputs` from dependency arrays to improve performance - Made code consistent with other handlers in the same file and other node types ## Root Cause The callbacks were using stale closure values (`inputs`) instead of the latest ref value (`inputRef.current`), causing updates to be based on outdated data when rapid edits occurred within the 5-second debounce window. ## Testing - ✅ Tested locally with rapid prompt edits - ✅ Verified `/workflows/draft` API receives correct data - ✅ No linter errors - ✅ No performance regressions observed
yindo added the pull-request label 2026-02-21 20:50:12 -05:00
yindo closed this issue 2026-02-21 20:50:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31817
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?