langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #17843] Fix external knowledge Issues: (#17685) #28781

New Issue
Closed
opened 2026-02-21 20:44:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:44:06 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/17843

State: closed
Merged: Yes

Use metadata.document_id or title for external KB retrieval to fix citation grouping

Summary

Resolves #17685

When processing external knowledge base retrieval results, the document_id was not assigned, resulting in all retrieved results having a document_id of null. However, the front-end page happens to group and display cited files based on the document_id, leading to a maximum of only one file citation being displayed during the conversation.

Solution: When processing external knowledge base retrieval results, attempt to obtain metadata.document_id from the external knowledge base's returned results. If there is no document_id, then take metadata.title as the document_id.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/17843 **State:** closed **Merged:** Yes --- Use metadata.document_id or title for external KB retrieval to fix citation grouping # Summary Resolves #17685 When processing external knowledge base retrieval results, the `document_id` was not assigned, resulting in all retrieved results having a `document_id` of null. However, the front-end page happens to group and display cited files based on the `document_id`, leading to a maximum of only one file citation being displayed during the conversation. Solution: When processing external knowledge base retrieval results, attempt to obtain `metadata.document_id` from the external knowledge base's returned results. If there is no `document_id`, then take `metadata.title` as the `document_id`. # Screenshots | Before | After | |--------|-------| | ![image](https://github.com/user-attachments/assets/791c7432-ae81-4cf8-8f77-727e6246a55d)| ![image](https://github.com/user-attachments/assets/8699d6fe-04ec-4320-8c03-14dc0847b48c) | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:44:06 -05:00
yindo closed this issue 2026-02-21 20:44:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#28781
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?