langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20945] test: run vdb test of oceanbase with docker compose in CI tests #29530

New Issue
Closed
opened 2026-02-21 20:45:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20945

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • to close [Refactor/Chore] Consolidate API CI test execution (#20943)
  • Previously, the vdb test for Oceanbase was mocked and never tested with an actual Oceanbase instance.
  • With this PR,
    • Start an Oceanbase container instance with docker-compose. The existing Docker image tag 4.3.5.1-101010042025042417 will continue to be used, as the shorter version 4.3.5-lts turns out to be lower than 4.3.5.1, which is the minimum required version for the full text search index. As 4.3.5-lts tag is now updated and shipping with FTS feature, change to use this image tag.
    • Set the critical system parameter config ob_vector_memory_limit_percentage to greater than 0 ahead of creating the collection. Otherwise, it fails the creation with an error message of ob_vector_memory_limit_percentage=0.
    • Skip all the mocking of client and assertions in OceanBaseVectorTest
image

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20945 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> - to close #20943 - Previously, the vdb test for Oceanbase was mocked and never tested with an actual Oceanbase instance. - With this PR, - Start an Oceanbase container instance with docker-compose. ~~The existing Docker image tag `4.3.5.1-101010042025042417` will continue to be used, as the shorter version `4.3.5-lts` turns out to be lower than 4.3.5.1, which is the minimum required version for the full text search index.~~ As `4.3.5-lts` tag is now updated and shipping with FTS feature, change to use this image tag. - Set the critical system parameter config `ob_vector_memory_limit_percentage` to greater than 0 ahead of creating the collection. Otherwise, it fails the creation with an error message of `ob_vector_memory_limit_percentage=0`. - Skip all the mocking of client and assertions in OceanBaseVectorTest <img width="842" alt="image" src="https://github.com/user-attachments/assets/555979fc-2bea-4e41-93cd-18e49308133e" /> ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:44 -05:00
yindo closed this issue 2026-02-21 20:45:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29530
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?