langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25001] fix: remove unnecessary modal visibility toggle on error in name save #30885

New Issue
Closed
opened 2026-02-21 20:48:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25001

State: closed
Merged: Yes

Fixes #25000

Summary

This pull request makes a minor update to the error handling logic in the AccountPage component. The change removes the call to setEditNameModalVisible(false) from the error handling block, so the edit name modal will no longer be closed automatically when an error occurs during the save operation.

Screenshots

Before After
CleanShot 2025-09-02 at 18 17 59 CleanShot 2025-09-02 at 18 18 40

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/25001 **State:** closed **Merged:** Yes --- Fixes #25000 ## Summary This pull request makes a minor update to the error handling logic in the `AccountPage` component. The change removes the call to `setEditNameModalVisible(false)` from the error handling block, so the edit name modal will no longer be closed automatically when an error occurs during the save operation. ## Screenshots | Before | After | |--------|-------| | ![CleanShot 2025-09-02 at 18 17 59](https://github.com/user-attachments/assets/5283f148-6c2d-4f01-9457-2037a6679a64)| ![CleanShot 2025-09-02 at 18 18 40](https://github.com/user-attachments/assets/fd285778-025f-456b-8f1d-39a4ca54a35e) | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:25 -05:00
yindo closed this issue 2026-02-21 20:48:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?