langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-27 11:11:21 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25373] refactor: update pyrightconfig.json to use ignore field for better type checking configuration #31035

New Issue
Closed
opened 2026-02-21 20:48:42 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:42 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25373

State: closed
Merged: Yes

Summary

This PR updates the pyrightconfig.json configuration to use the "ignore" field instead of expanding the "exclude" field for directories that should not be type-checked.

Related Issue

Closes #25372

Changes Made

  • Moved directories from exclude to ignore field for clearer semantics
  • Narrowed include field to focus on models and configs directories
  • Kept essential exclusions (.venv, tests/, migrations/) in exclude field

Rationale

Using the ignore field for directories that should not be type-checked provides clearer semantics:

  • exclude is for files that shouldn't be processed at all
  • ignore is for files that are processed but not type-checked

This distinction helps maintainers understand the intent better and aligns with Pyright's recommended configuration patterns.

**Original Pull Request:** https://github.com/langgenius/dify/pull/25373 **State:** closed **Merged:** Yes --- ## Summary This PR updates the pyrightconfig.json configuration to use the "ignore" field instead of expanding the "exclude" field for directories that should not be type-checked. ## Related Issue Closes #25372 ## Changes Made - Moved directories from `exclude` to `ignore` field for clearer semantics - Narrowed `include` field to focus on `models` and `configs` directories - Kept essential exclusions (`.venv`, `tests/`, `migrations/`) in `exclude` field ## Rationale Using the `ignore` field for directories that should not be type-checked provides clearer semantics: - `exclude` is for files that shouldn't be processed at all - `ignore` is for files that are processed but not type-checked This distinction helps maintainers understand the intent better and aligns with Pyright's recommended configuration patterns.
yindo added the pull-request label 2026-02-21 20:48:42 -05:00
yindo closed this issue 2026-02-21 20:48:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31035
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?