langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29039] fix(mcp): add root-level OAuth metadata discovery fallback #32273

New Issue
Open
opened 2026-02-21 20:51:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:05 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29039

State: open
Merged: No

Summary

  • Add root-level OAuth Authorization Server Metadata discovery fallback for MCP servers that don't follow RFC 8414 path suffix convention

Problem

When connecting to MCP servers like Atlassian (https://mcp.atlassian.com/v1/sse), OAuth metadata discovery fails with "Failed to discover OAuth metadata from server".

This happens because:

  1. RFC 8414 specifies that when the issuer URL has a path, metadata should be at /.well-known/oauth-authorization-server{path}
  2. Dify tries /.well-known/oauth-authorization-server/v1/sse which returns 404
  3. Atlassian places metadata at root-level /.well-known/oauth-authorization-server without the path suffix

Solution

Add root-level /.well-known/oauth-authorization-server as a fallback URL when the path-suffixed discovery fails.

Test plan

  • Tested with Atlassian MCP server (https://mcp.atlassian.com/v1/sse)
  • OAuth authorization flow completes successfully
**Original Pull Request:** https://github.com/langgenius/dify/pull/29039 **State:** open **Merged:** No --- ## Summary - Add root-level OAuth Authorization Server Metadata discovery fallback for MCP servers that don't follow RFC 8414 path suffix convention ## Problem When connecting to MCP servers like Atlassian (`https://mcp.atlassian.com/v1/sse`), OAuth metadata discovery fails with "Failed to discover OAuth metadata from server". This happens because: 1. RFC 8414 specifies that when the issuer URL has a path, metadata should be at `/.well-known/oauth-authorization-server{path}` 2. Dify tries `/.well-known/oauth-authorization-server/v1/sse` which returns 404 3. Atlassian places metadata at root-level `/.well-known/oauth-authorization-server` without the path suffix ## Solution Add root-level `/.well-known/oauth-authorization-server` as a fallback URL when the path-suffixed discovery fails. ## Test plan - [x] Tested with Atlassian MCP server (`https://mcp.atlassian.com/v1/sse`) - [x] OAuth authorization flow completes successfully
yindo added the pull-request label 2026-02-21 20:51:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32273
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?