langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32273] Fix/analyticdb vector initialize sql #33643

New Issue
Open
opened 2026-02-21 20:53:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:39 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32273

State: open
Merged: No

Summary

This PR improves AnalyticDB vector store initialization when using SQL mode (ANALYTICDB_HOST configured).

Changes:

  1. to_tsquery_from_text initialization
    Wrap CREATE OR REPLACE FUNCTION public.to_tsquery_from_text in a PL/pgSQL DO block and catch insufficient_privilege via SQLSTATE '42501'. Initialization now succeeds when the function already exists and the current database user is not the owner (e.g. has only EXECUTE on the function), avoiding failures in managed/shared AnalyticDB environments.

  2. ANN vector index options
    Remove external_storage=0 from the CREATE INDEX ... USING ann(vector) options to improve compatibility with AnalyticDB versions or configurations where this option is not supported or has been deprecated.

Motivation:
When Dify runs as a non-superuser or when the function is pre-created by an admin, the previous direct CREATE OR REPLACE FUNCTION could raise a privilege error and block vector DB setup. Using SQLSTATE '42501' is more portable than the named exception in some PostgreSQL-derived engines (e.g. AnalyticDB).

Fixes #32271

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/32273 **State:** open **Merged:** No --- ## Summary This PR improves AnalyticDB vector store initialization when using SQL mode (`ANALYTICDB_HOST` configured). **Changes:** 1. **to_tsquery_from_text initialization** Wrap `CREATE OR REPLACE FUNCTION public.to_tsquery_from_text` in a PL/pgSQL `DO` block and catch `insufficient_privilege` via `SQLSTATE '42501'`. Initialization now succeeds when the function already exists and the current database user is not the owner (e.g. has only `EXECUTE` on the function), avoiding failures in managed/shared AnalyticDB environments. 2. **ANN vector index options** Remove `external_storage=0` from the `CREATE INDEX ... USING ann(vector)` options to improve compatibility with AnalyticDB versions or configurations where this option is not supported or has been deprecated. **Motivation:** When Dify runs as a non-superuser or when the function is pre-created by an admin, the previous direct `CREATE OR REPLACE FUNCTION` could raise a privilege error and block vector DB setup. Using `SQLSTATE '42501'` is more portable than the named exception in some PostgreSQL-derived engines (e.g. AnalyticDB). Fixes #32271 ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?