langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29483] perf: remove the n+1 query #32435

New Issue
Closed
opened 2026-02-21 20:51:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:24 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29483

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #29482

replaced the N+1 pattern with an efficient batch-loading approach:

Before (N+1 queries):

for message in messages:
    if message.workflow_run:  # Individual query for each message
       status_counts[WorkflowExecutionStatus(message.workflow_run.status)] += 1

After (1 batch query):

  1. Get all workflow_run_ids from messages in this conversation

workflow_run_ids = [msg.workflow_run_id for msg in messages if msg.workflow_run_id]

  1. Single batch query to load all workflow runs, filtered by app_id
workflow_runs_query = db.session.scalars(
   select(WorkflowRun).where(
       WorkflowRun.id.in_(workflow_run_ids),
       WorkflowRun.app_id == self.app_id  # Important security/scope filter
   )
).all()
  1. Use the batch-loaded data
workflow_runs = {run.id: run for run in workflow_runs_query}
for message in messages:
    workflow_run = workflow_runs.get(message.workflow_run_id)
    if workflow_run:
        status_counts[WorkflowExecutionStatus(workflow_run.status)] += 1

Performance Impact

  • Before: 1 + N queries (where N = number of messages with workflow runs)
  • After: 2 queries per conversation (regardless of message count)
  • For your case: Reduced from ~85 queries to just 2 queries

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/29483 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary fix #29482 replaced the N+1 pattern with an efficient batch-loading approach: ## Before (N+1 queries): ```python for message in messages: if message.workflow_run: # Individual query for each message status_counts[WorkflowExecutionStatus(message.workflow_run.status)] += 1 ``` ## After (1 batch query): 1. Get all workflow_run_ids from messages in this conversation workflow_run_ids = [msg.workflow_run_id for msg in messages if msg.workflow_run_id] 2. Single batch query to load all workflow runs, filtered by app_id ```python workflow_runs_query = db.session.scalars( select(WorkflowRun).where( WorkflowRun.id.in_(workflow_run_ids), WorkflowRun.app_id == self.app_id # Important security/scope filter ) ).all() ``` 4. Use the batch-loaded data ```python workflow_runs = {run.id: run for run in workflow_runs_query} for message in messages: workflow_run = workflow_runs.get(message.workflow_run_id) if workflow_run: status_counts[WorkflowExecutionStatus(workflow_run.status)] += 1 ``` Performance Impact - Before: 1 + N queries (where N = number of messages with workflow runs) - After: 2 queries per conversation (regardless of message count) - For your case: Reduced from ~85 queries to just 2 queries ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:51:24 -05:00
yindo closed this issue 2026-02-21 20:51:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32435
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?