langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-19 08:35:20 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32435] fix: resolve markdown hydration warning by ensuring valid DOM nesting for images #33744

New Issue
Open
opened 2026-02-21 20:53:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:48 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32435

State: open
Merged: No

Hey team, I fixed the hydration warning (issue #32362) regarding invalid HTML nesting in Markdown. The problem was that the Paragraph component would use a "p" tag even when images
were present. Since images use a "div" from the ImageGallery, it caused an invalid "p inside a div" error.

I updated the logic to use a "div" wrapper instead of a "p" tag whenever an image is detected anywhere in the paragraph. I also swapped the "div" in the Img component for a "span"
to keep things cleaner. Verified this locally and the console errors are fixed. Fixes #32362.

**Original Pull Request:** https://github.com/langgenius/dify/pull/32435 **State:** open **Merged:** No --- Hey team, I fixed the hydration warning (issue #32362) regarding invalid HTML nesting in Markdown. The problem was that the Paragraph component would use a "p" tag even when images were present. Since images use a "div" from the ImageGallery, it caused an invalid "p inside a div" error. I updated the logic to use a "div" wrapper instead of a "p" tag whenever an image is detected anywhere in the paragraph. I also swapped the "div" in the Img component for a "span" to keep things cleaner. Verified this locally and the console errors are fixed. Fixes #32362.
yindo added the pull-request label 2026-02-21 20:53:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?