langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Refactor: Enhance Workflow Nodes for Clearer Exception Handling #6515

New Issue
Closed
opened 2026-02-21 18:16:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 18:16:05 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Nov 2, 2024).

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

In order to improve the clarity and maintainability of exception handling in our workflow nodes, the following changes are proposed:

  1. Create Specific Error Types for Each Node: Define unique error types for individual nodes to avoid using generic exceptions such as ValueError. This change will help in distinguishing different failure scenarios more precisely.

  2. Return NodeRunResult with Exception Details: When possible, return a NodeRunResult that includes comprehensive exception information rather than raising uncategorized exceptions without context. This approach provides better context for error handling and improves debugging and traceability throughout the workflow.

Implementing these changes will contribute to more robust error handling, enhancing both developer experience and system reliability.

2. Additional context or comments

  • ListOperator @laipz8200 in #10206
  • DocumentExtractor @laipz8200 in #10208
  • CodeNode @laipz8200 in #10218
  • HttpRequestNode @laipz8200 in #10219
  • LLMNode @laipz8200 in #10221
  • ParameterExtractorNode @laipz8200 in #10260
  • QuestionClassifierNode @laipz8200 in #10365
  • ToolNode @laipz8200 in #10357
  • KnowledgeRetrievalNode @laipz8200 in #10385
  • IterationNode @laipz8200 in #10366

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
Originally created by @laipz8200 on GitHub (Nov 2, 2024). ### Self Checks - [X] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [X] I confirm that I am using English to submit this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). - [X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:） - [X] Please do not modify this template :) and fill in all the required fields. ### 1. Is this request related to a challenge you're experiencing? Tell me about your story. In order to improve the clarity and maintainability of exception handling in our workflow nodes, the following changes are proposed: 1. **Create Specific Error Types for Each Node**: Define unique error types for individual nodes to avoid using generic exceptions such as `ValueError`. This change will help in distinguishing different failure scenarios more precisely. 2. **Return NodeRunResult with Exception Details**: When possible, return a `NodeRunResult` that includes comprehensive exception information rather than raising uncategorized exceptions without context. This approach provides better context for error handling and improves debugging and traceability throughout the workflow. Implementing these changes will contribute to more robust error handling, enhancing both developer experience and system reliability. ### 2. Additional context or comments - [x] ListOperator @laipz8200 in #10206 - [x] DocumentExtractor @laipz8200 in #10208 - [x] CodeNode @laipz8200 in #10218 - [x] HttpRequestNode @laipz8200 in #10219 - [x] LLMNode @laipz8200 in #10221 - [x] ParameterExtractorNode @laipz8200 in #10260 - [x] QuestionClassifierNode @laipz8200 in #10365 - [x] ToolNode @laipz8200 in #10357 - [x] KnowledgeRetrievalNode @laipz8200 in #10385 - [x] IterationNode @laipz8200 in #10366 ### 3. Can you help us with this feature? - [ ] I am interested in contributing to this feature.
yindo added the good first issue🌊 feat:workflow labels 2026-02-21 18:16:05 -05:00
yindo closed this issue 2026-02-21 18:16:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label good first issue 🌊 feat:workflow
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#6515
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?